{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/169047507","pull_request_review_id":97510111,"id":169047507,"diff_hunk":"@@ -39,64 +38,78 @@ describe(__filename, () => {\n       expect(apiHost).toEqual('https://localhost');\n     });\n \n-    it('transforms method to upper case', () => {\n+    it('transforms method to upper case', async () => {\n+      mockWindow.expects('fetch')\n+        .withArgs(sinon.match.any, sinon.match({ method: 'GET' }))\n+        .returns(createApiResponse());\n+\n+      await api.callApi({ endpoint: 'resource', method: 'get' });\n+      mockWindow.verify();\n+    });\n+\n+    it('adds some query string params to all requests', async () => {\n+      const lang = 'en-US';\n+      const { state } = dispatchClientMetadata({ lang });\n+\n+      mockWindow.expects('fetch')\n+        .withArgs(urlWithTheseParams({ lang, wrap_outgoing_links: true }))","path":"tests/unit/core/api/test_index.js","position":46,"original_position":46,"commit_id":"c0afb2250abdae0411c8bba64a84b5e1afec2459","original_commit_id":"c0afb2250abdae0411c8bba64a84b5e1afec2459","user":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"This is cool! 👍 ","created_at":"2018-02-19T11:19:13Z","updated_at":"2018-02-19T11:24:44Z","html_url":"https://github.com/mozilla/addons-frontend/pull/4408#discussion_r169047507","pull_request_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/169047507"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/4408#discussion_r169047507"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408","id":169691683,"html_url":"https://github.com/mozilla/addons-frontend/pull/4408","diff_url":"https://github.com/mozilla/addons-frontend/pull/4408.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/4408.patch","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4408","number":4408,"state":"open","locked":false,"title":"Explicitly ask API to wrap outgoing URLs","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars1.githubusercontent.com/u/55398?v=4","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/mozilla/addons-frontend/issues/4393 by configuring all API requests with the new parameter.\r\n\r\nBecause all API requests have a new query param, this broke a lot of tests that were too tightly coupled to the entire URL. I fixed all of those by making the tests ignore parts of the URL that were not relevant. This is something we've been meaning to do for a while now. I thought there was an issue on file but I couldn't find it.\r\n\r\nSorry for the noise but this cleanup should make the tests more robust.","created_at":"2018-02-16T18:16:00Z","updated_at":"2018-02-19T11:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55ef469ef62cf435e73820c4896788023213b9b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/4408/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/c0afb2250abdae0411c8bba64a84b5e1afec2459","head":{"label":"kumar303:outgoing-urls-4393","ref":"outgoing-urls-4393","sha":"c0afb2250abdae0411c8bba64a84b5e1afec2459","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars1.githubusercontent.com/u/55398?v=4","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"repo":{"id":63971080,"name":"addons-frontend","full_name":"kumar303/addons-frontend","owner":{"login":"kumar303","id":55398,"avatar_url":"https://avatars1.githubusercontent.com/u/55398?v=4","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumar303/addons-frontend","description":"Front-end infrastructure and code to complement mozilla/addons-server","fork":true,"url":"https://api.github.com/repos/kumar303/addons-frontend","forks_url":"https://api.github.com/repos/kumar303/addons-frontend/forks","keys_url":"https://api.github.com/repos/kumar303/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumar303/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumar303/addons-frontend/teams","hooks_url":"https://api.github.com/repos/kumar303/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/kumar303/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/kumar303/addons-frontend/events","assignees_url":"https://api.github.com/repos/kumar303/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/kumar303/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/kumar303/addons-frontend/tags","blobs_url":"https://api.github.com/repos/kumar303/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumar303/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumar303/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumar303/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumar303/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/kumar303/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/kumar303/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/kumar303/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/kumar303/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/kumar303/addons-frontend/subscription","commits_url":"https://api.github.com/repos/kumar303/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumar303/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumar303/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumar303/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumar303/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/kumar303/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumar303/addons-frontend/merges","archive_url":"https://api.github.com/repos/kumar303/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumar303/addons-frontend/downloads","issues_url":"https://api.github.com/repos/kumar303/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/kumar303/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/kumar303/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/kumar303/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumar303/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/kumar303/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/kumar303/addons-frontend/deployments","created_at":"2016-07-22T17:24:59Z","updated_at":"2016-07-22T17:25:02Z","pushed_at":"2018-02-16T18:07:18Z","git_url":"git://github.com/kumar303/addons-frontend.git","ssh_url":"git@github.com:kumar303/addons-frontend.git","clone_url":"https://github.com/kumar303/addons-frontend.git","svn_url":"https://github.com/kumar303/addons-frontend","homepage":null,"size":487482,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"bfba71758c5e011e2ff717c0a8cacd702bb9a295","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":52104368,"name":"addons-frontend","full_name":"mozilla/addons-frontend","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-frontend","description":"Front-end to complement mozilla/addons-server","fork":false,"url":"https://api.github.com/repos/mozilla/addons-frontend","forks_url":"https://api.github.com/repos/mozilla/addons-frontend/forks","keys_url":"https://api.github.com/repos/mozilla/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-frontend/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-frontend/events","assignees_url":"https://api.github.com/repos/mozilla/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-frontend/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-frontend/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-frontend/merges","archive_url":"https://api.github.com/repos/mozilla/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-frontend/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-frontend/deployments","created_at":"2016-02-19T17:25:57Z","updated_at":"2018-02-16T12:33:06Z","pushed_at":"2018-02-19T10:51:10Z","git_url":"git://github.com/mozilla/addons-frontend.git","ssh_url":"git@github.com:mozilla/addons-frontend.git","clone_url":"https://github.com/mozilla/addons-frontend.git","svn_url":"https://github.com/mozilla/addons-frontend","homepage":"","size":487696,"stargazers_count":95,"watchers_count":95,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":438,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":94,"open_issues":438,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/4408"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/4408"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/4408/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/4408/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-frontend/statuses/c0afb2250abdae0411c8bba64a84b5e1afec2459"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tofumatt"}}