{"action":"created","issue":{"url":"https://api.github.com/repos/martin5211/learn-node-js/issues/1","repository_url":"https://api.github.com/repos/martin5211/learn-node-js","labels_url":"https://api.github.com/repos/martin5211/learn-node-js/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/martin5211/learn-node-js/issues/1/comments","events_url":"https://api.github.com/repos/martin5211/learn-node-js/issues/1/events","html_url":"https://github.com/martin5211/learn-node-js/issues/1","id":348912921,"node_id":"MDU6SXNzdWUzNDg5MTI5MjE=","number":1,"title":"TosoliniNico | Lesson 1","user":{"login":"martin5211","id":2163083,"node_id":"MDQ6VXNlcjIxNjMwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/2163083?v=4","gravatar_id":"","url":"https://api.github.com/users/martin5211","html_url":"https://github.com/martin5211","followers_url":"https://api.github.com/users/martin5211/followers","following_url":"https://api.github.com/users/martin5211/following{/other_user}","gists_url":"https://api.github.com/users/martin5211/gists{/gist_id}","starred_url":"https://api.github.com/users/martin5211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin5211/subscriptions","organizations_url":"https://api.github.com/users/martin5211/orgs","repos_url":"https://api.github.com/users/martin5211/repos","events_url":"https://api.github.com/users/martin5211/events{/privacy}","received_events_url":"https://api.github.com/users/martin5211/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"martin5211","id":2163083,"node_id":"MDQ6VXNlcjIxNjMwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/2163083?v=4","gravatar_id":"","url":"https://api.github.com/users/martin5211","html_url":"https://github.com/martin5211","followers_url":"https://api.github.com/users/martin5211/followers","following_url":"https://api.github.com/users/martin5211/following{/other_user}","gists_url":"https://api.github.com/users/martin5211/gists{/gist_id}","starred_url":"https://api.github.com/users/martin5211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin5211/subscriptions","organizations_url":"https://api.github.com/users/martin5211/orgs","repos_url":"https://api.github.com/users/martin5211/repos","events_url":"https://api.github.com/users/martin5211/events{/privacy}","received_events_url":"https://api.github.com/users/martin5211/received_events","type":"User","site_admin":false},"assignees":[{"login":"martin5211","id":2163083,"node_id":"MDQ6VXNlcjIxNjMwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/2163083?v=4","gravatar_id":"","url":"https://api.github.com/users/martin5211","html_url":"https://github.com/martin5211","followers_url":"https://api.github.com/users/martin5211/followers","following_url":"https://api.github.com/users/martin5211/following{/other_user}","gists_url":"https://api.github.com/users/martin5211/gists{/gist_id}","starred_url":"https://api.github.com/users/martin5211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin5211/subscriptions","organizations_url":"https://api.github.com/users/martin5211/orgs","repos_url":"https://api.github.com/users/martin5211/repos","events_url":"https://api.github.com/users/martin5211/events{/privacy}","received_events_url":"https://api.github.com/users/martin5211/received_events","type":"User","site_admin":false},{"login":"TosoliniNico","id":41934486,"node_id":"MDQ6VXNlcjQxOTM0NDg2","avatar_url":"https://avatars0.githubusercontent.com/u/41934486?v=4","gravatar_id":"","url":"https://api.github.com/users/TosoliniNico","html_url":"https://github.com/TosoliniNico","followers_url":"https://api.github.com/users/TosoliniNico/followers","following_url":"https://api.github.com/users/TosoliniNico/following{/other_user}","gists_url":"https://api.github.com/users/TosoliniNico/gists{/gist_id}","starred_url":"https://api.github.com/users/TosoliniNico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TosoliniNico/subscriptions","organizations_url":"https://api.github.com/users/TosoliniNico/orgs","repos_url":"https://api.github.com/users/TosoliniNico/repos","events_url":"https://api.github.com/users/TosoliniNico/events{/privacy}","received_events_url":"https://api.github.com/users/TosoliniNico/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-08T22:20:09Z","updated_at":"2018-08-15T15:26:38Z","closed_at":"2018-08-15T15:26:38Z","author_association":"OWNER","body":"Looks good. I've some comments:\r\n\r\nhttps://github.com/martin5211/learn-node-js/blob/57f77d755a9ddb31de46c651d8b9581f5882b7df/lesson_1/ejercicio/app.js#L6\r\n\r\n- You can use `process.argv` instead of yargs module. Sometimes it's better to use NodeJS core functions because some external dependencies are not very well maintained by their developers. (https://nodejs.org/docs/latest/api/process.html#process_process_argv)\r\n\r\nhttps://github.com/martin5211/learn-node-js/blob/57f77d755a9ddb31de46c651d8b9581f5882b7df/lesson_1/ejercicio/app.js#L3\r\n\r\n- It seems that lodash isn't used in any part of the code. Avoid the load of unnecessary dependencies.\r\n\r\n- Avoid the unnecessary blank lines at the end of file (app.js). It's good to maintain a proper and clean format for good readability.\r\n"},"comment":{"url":"https://api.github.com/repos/martin5211/learn-node-js/issues/comments/413233878","html_url":"https://github.com/martin5211/learn-node-js/issues/1#issuecomment-413233878","issue_url":"https://api.github.com/repos/martin5211/learn-node-js/issues/1","id":413233878,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzIzMzg3OA==","user":{"login":"martin5211","id":2163083,"node_id":"MDQ6VXNlcjIxNjMwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/2163083?v=4","gravatar_id":"","url":"https://api.github.com/users/martin5211","html_url":"https://github.com/martin5211","followers_url":"https://api.github.com/users/martin5211/followers","following_url":"https://api.github.com/users/martin5211/following{/other_user}","gists_url":"https://api.github.com/users/martin5211/gists{/gist_id}","starred_url":"https://api.github.com/users/martin5211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin5211/subscriptions","organizations_url":"https://api.github.com/users/martin5211/orgs","repos_url":"https://api.github.com/users/martin5211/repos","events_url":"https://api.github.com/users/martin5211/events{/privacy}","received_events_url":"https://api.github.com/users/martin5211/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T15:26:38Z","updated_at":"2018-08-15T15:26:38Z","author_association":"OWNER","body":"Looks good. Closing issue."}}
{"actor":{"display_login":"martin5211"}}