{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/2966","repository_url":"https://api.github.com/repos/openshift/origin-web-console","labels_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2966/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2966/comments","events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2966/events","html_url":"https://github.com/openshift/origin-web-console/pull/2966","id":315893852,"number":2966,"title":"Open Remote Desktop for a windows VM (kubevirt)","user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"labels":[{"id":714855427,"url":"https://api.github.com/repos/openshift/origin-web-console/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/origin-web-console/milestones/9","html_url":"https://github.com/openshift/origin-web-console/milestone/9","labels_url":"https://api.github.com/repos/openshift/origin-web-console/milestones/9/labels","id":3296539,"number":9,"title":"3.11.0","description":null,"creator":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-04-25T14:23:51Z","updated_at":"2018-05-10T18:22:29Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-04-19T14:07:17Z","updated_at":"2018-05-14T06:50:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2966","html_url":"https://github.com/openshift/origin-web-console/pull/2966","diff_url":"https://github.com/openshift/origin-web-console/pull/2966.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/2966.patch"},"body":"Link to open RDP session to access Windows VM via downloading of an RDP file is added.\r\nMime-type of the downloaded content is: `application/rdp`.\r\n\r\nRequires a Service object exposing VM ports [1].\r\nThe Service.spec.selector[\"kubevirt.io/domain\"] is expected\r\nto match OVM.metadata.labels[\"kubevirt.io/domain\"].\r\n    \r\nThe RDP link is rendered if:\r\n  - matching Service is defined\r\n  - VM is running\r\n  - VM is Windows\r\n\r\nVM operating system is determined from \"kubevirt.io/os\" label of\r\nthe running OfflineVirtualMachine object (means OVM.metadata.labels[\"kubevirt.io/domain\"] starts at \"win\").\r\n    \r\nIf a Service object can not be found, but the VM is Windows and running,\r\ninformative text about missing Service is rendered instead of the link.\r\n\r\nThe RDP IP:Port works for NodePort, ClusterIP and LoadBalancer Services.\r\n\r\nIn a nutshell, the IP:Port is determined for Service type of:\r\n  - NodePort:\r\n    - port = Service.spec.port[].nodePort\r\n    - IP = nodeIP of node the VM is scheduled to (conforms pod.spec.hostIP)\r\n  - ClusterIP\r\n    - port = Service.spec.port[].port\r\n    - IP = Service.spec.clusterIP\r\n  - LoadBalancer\r\n    - port = Service.spec.port[].port\r\n    - IP = Service.spec.externalIP[0]\r\n\r\nThe Service is expected to map 3389 port to one of the above.\r\n\r\n[1] https://github.com/kubevirt/user-guide/blob/master/workloads/virtual-machines/expose-service.md\r\n\r\n---\r\n\r\nDepends on: ~~https://github.com/openshift/origin-web-console/pull/2964~~"},"comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments/388714102","html_url":"https://github.com/openshift/origin-web-console/pull/2966#issuecomment-388714102","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2966","id":388714102,"user":{"login":"mareklibra","id":17194943,"avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T06:50:49Z","updated_at":"2018-05-14T06:50:49Z","author_association":"CONTRIBUTOR","body":"@spadgett , since code-freeze has been postponed to June 6th, may I ask for review? \r\nThere are other patches blocked on this... Thanks."}}
{"actor":{"display_login":"mareklibra"}}