{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39","id":175662231,"html_url":"https://github.com/danieleorler/cryptobot/pull/39","diff_url":"https://github.com/danieleorler/cryptobot/pull/39.diff","patch_url":"https://github.com/danieleorler/cryptobot/pull/39.patch","issue_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/39","number":39,"state":"closed","locked":false,"title":"refactored the algorithm structure","user":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"body":"on the quest to make the algorithms swapable now all the code reasoning on the market is contained in classes implementing the interface `Indicator`.\r\nThe algorithm is no longer scattered around the project.\r\n\r\nEvery indicator has the opportunity to store its data on a `CryptoAnalysis` object (when evaluating the market) and on a `PositionAnalysis` object (when holding a position on a currency)","created_at":"2018-03-16T22:44:48Z","updated_at":"2018-03-18T21:55:59Z","closed_at":"2018-03-18T21:55:59Z","merged_at":"2018-03-18T21:55:59Z","merge_commit_sha":"258eab0d189e7596ec2a811bd744412ff95cb8d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"reitoo","id":881871,"avatar_url":"https://avatars2.githubusercontent.com/u/881871?v=4","gravatar_id":"","url":"https://api.github.com/users/reitoo","html_url":"https://github.com/reitoo","followers_url":"https://api.github.com/users/reitoo/followers","following_url":"https://api.github.com/users/reitoo/following{/other_user}","gists_url":"https://api.github.com/users/reitoo/gists{/gist_id}","starred_url":"https://api.github.com/users/reitoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitoo/subscriptions","organizations_url":"https://api.github.com/users/reitoo/orgs","repos_url":"https://api.github.com/users/reitoo/repos","events_url":"https://api.github.com/users/reitoo/events{/privacy}","received_events_url":"https://api.github.com/users/reitoo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39/commits","review_comments_url":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39/comments","review_comment_url":"https://api.github.com/repos/danieleorler/cryptobot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/39/comments","statuses_url":"https://api.github.com/repos/danieleorler/cryptobot/statuses/bf66eca4b3e8a7b82ac4551b6db7419efcff9e37","head":{"label":"danieleorler:refactored-algorithm","ref":"refactored-algorithm","sha":"bf66eca4b3e8a7b82ac4551b6db7419efcff9e37","user":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"repo":{"id":117168572,"name":"cryptobot","full_name":"danieleorler/cryptobot","owner":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieleorler/cryptobot","description":null,"fork":false,"url":"https://api.github.com/repos/danieleorler/cryptobot","forks_url":"https://api.github.com/repos/danieleorler/cryptobot/forks","keys_url":"https://api.github.com/repos/danieleorler/cryptobot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieleorler/cryptobot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieleorler/cryptobot/teams","hooks_url":"https://api.github.com/repos/danieleorler/cryptobot/hooks","issue_events_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/events{/number}","events_url":"https://api.github.com/repos/danieleorler/cryptobot/events","assignees_url":"https://api.github.com/repos/danieleorler/cryptobot/assignees{/user}","branches_url":"https://api.github.com/repos/danieleorler/cryptobot/branches{/branch}","tags_url":"https://api.github.com/repos/danieleorler/cryptobot/tags","blobs_url":"https://api.github.com/repos/danieleorler/cryptobot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieleorler/cryptobot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieleorler/cryptobot/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieleorler/cryptobot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieleorler/cryptobot/statuses/{sha}","languages_url":"https://api.github.com/repos/danieleorler/cryptobot/languages","stargazers_url":"https://api.github.com/repos/danieleorler/cryptobot/stargazers","contributors_url":"https://api.github.com/repos/danieleorler/cryptobot/contributors","subscribers_url":"https://api.github.com/repos/danieleorler/cryptobot/subscribers","subscription_url":"https://api.github.com/repos/danieleorler/cryptobot/subscription","commits_url":"https://api.github.com/repos/danieleorler/cryptobot/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieleorler/cryptobot/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieleorler/cryptobot/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieleorler/cryptobot/contents/{+path}","compare_url":"https://api.github.com/repos/danieleorler/cryptobot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieleorler/cryptobot/merges","archive_url":"https://api.github.com/repos/danieleorler/cryptobot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieleorler/cryptobot/downloads","issues_url":"https://api.github.com/repos/danieleorler/cryptobot/issues{/number}","pulls_url":"https://api.github.com/repos/danieleorler/cryptobot/pulls{/number}","milestones_url":"https://api.github.com/repos/danieleorler/cryptobot/milestones{/number}","notifications_url":"https://api.github.com/repos/danieleorler/cryptobot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieleorler/cryptobot/labels{/name}","releases_url":"https://api.github.com/repos/danieleorler/cryptobot/releases{/id}","deployments_url":"https://api.github.com/repos/danieleorler/cryptobot/deployments","created_at":"2018-01-12T00:01:31Z","updated_at":"2018-03-13T22:49:30Z","pushed_at":"2018-03-18T21:55:59Z","git_url":"git://github.com/danieleorler/cryptobot.git","ssh_url":"git@github.com:danieleorler/cryptobot.git","clone_url":"https://github.com/danieleorler/cryptobot.git","svn_url":"https://github.com/danieleorler/cryptobot","homepage":null,"size":339,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"danieleorler:master","ref":"master","sha":"ad40cd362f650125ef821e8e15c0ae01089b2547","user":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"repo":{"id":117168572,"name":"cryptobot","full_name":"danieleorler/cryptobot","owner":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieleorler/cryptobot","description":null,"fork":false,"url":"https://api.github.com/repos/danieleorler/cryptobot","forks_url":"https://api.github.com/repos/danieleorler/cryptobot/forks","keys_url":"https://api.github.com/repos/danieleorler/cryptobot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieleorler/cryptobot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieleorler/cryptobot/teams","hooks_url":"https://api.github.com/repos/danieleorler/cryptobot/hooks","issue_events_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/events{/number}","events_url":"https://api.github.com/repos/danieleorler/cryptobot/events","assignees_url":"https://api.github.com/repos/danieleorler/cryptobot/assignees{/user}","branches_url":"https://api.github.com/repos/danieleorler/cryptobot/branches{/branch}","tags_url":"https://api.github.com/repos/danieleorler/cryptobot/tags","blobs_url":"https://api.github.com/repos/danieleorler/cryptobot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieleorler/cryptobot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieleorler/cryptobot/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieleorler/cryptobot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieleorler/cryptobot/statuses/{sha}","languages_url":"https://api.github.com/repos/danieleorler/cryptobot/languages","stargazers_url":"https://api.github.com/repos/danieleorler/cryptobot/stargazers","contributors_url":"https://api.github.com/repos/danieleorler/cryptobot/contributors","subscribers_url":"https://api.github.com/repos/danieleorler/cryptobot/subscribers","subscription_url":"https://api.github.com/repos/danieleorler/cryptobot/subscription","commits_url":"https://api.github.com/repos/danieleorler/cryptobot/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieleorler/cryptobot/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieleorler/cryptobot/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieleorler/cryptobot/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieleorler/cryptobot/contents/{+path}","compare_url":"https://api.github.com/repos/danieleorler/cryptobot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieleorler/cryptobot/merges","archive_url":"https://api.github.com/repos/danieleorler/cryptobot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieleorler/cryptobot/downloads","issues_url":"https://api.github.com/repos/danieleorler/cryptobot/issues{/number}","pulls_url":"https://api.github.com/repos/danieleorler/cryptobot/pulls{/number}","milestones_url":"https://api.github.com/repos/danieleorler/cryptobot/milestones{/number}","notifications_url":"https://api.github.com/repos/danieleorler/cryptobot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieleorler/cryptobot/labels{/name}","releases_url":"https://api.github.com/repos/danieleorler/cryptobot/releases{/id}","deployments_url":"https://api.github.com/repos/danieleorler/cryptobot/deployments","created_at":"2018-01-12T00:01:31Z","updated_at":"2018-03-13T22:49:30Z","pushed_at":"2018-03-18T21:55:59Z","git_url":"git://github.com/danieleorler/cryptobot.git","ssh_url":"git@github.com:danieleorler/cryptobot.git","clone_url":"https://github.com/danieleorler/cryptobot.git","svn_url":"https://github.com/danieleorler/cryptobot","homepage":null,"size":339,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39"},"html":{"href":"https://github.com/danieleorler/cryptobot/pull/39"},"issue":{"href":"https://api.github.com/repos/danieleorler/cryptobot/issues/39"},"comments":{"href":"https://api.github.com/repos/danieleorler/cryptobot/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/danieleorler/cryptobot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danieleorler/cryptobot/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/danieleorler/cryptobot/statuses/bf66eca4b3e8a7b82ac4551b6db7419efcff9e37"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danieleorler","id":254141,"avatar_url":"https://avatars1.githubusercontent.com/u/254141?v=4","gravatar_id":"","url":"https://api.github.com/users/danieleorler","html_url":"https://github.com/danieleorler","followers_url":"https://api.github.com/users/danieleorler/followers","following_url":"https://api.github.com/users/danieleorler/following{/other_user}","gists_url":"https://api.github.com/users/danieleorler/gists{/gist_id}","starred_url":"https://api.github.com/users/danieleorler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieleorler/subscriptions","organizations_url":"https://api.github.com/users/danieleorler/orgs","repos_url":"https://api.github.com/users/danieleorler/repos","events_url":"https://api.github.com/users/danieleorler/events{/privacy}","received_events_url":"https://api.github.com/users/danieleorler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":216,"deletions":107,"changed_files":11}}
{"actor":{"display_login":"danieleorler"}}