{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/186198071","pull_request_review_id":117735073,"id":186198071,"diff_hunk":"@@ -0,0 +1,113 @@\n+/*\n+ * The Alluxio Open Foundation licenses this work under the Apache License, version 2.0\n+ * (the \"License\"). You may not use this work except in compliance with the License, which is\n+ * available at www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * This software is distributed on an \"AS IS\" basis, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,\n+ * either express or implied, as more fully set forth in the License.\n+ *\n+ * See the NOTICE file distributed with this work for information regarding copyright ownership.\n+ */\n+\n+package alluxio.master.meta;\n+\n+import alluxio.Configuration;\n+import alluxio.PropertyKey;\n+import alluxio.heartbeat.HeartbeatExecutor;\n+\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import javax.annotation.concurrent.NotThreadSafe;\n+import java.io.IOException;\n+import java.util.concurrent.atomic.AtomicReference;\n+\n+/**\n+ * Task that carries out the necessary standby master to leader master communications, including\n+ * register and heartbeat. This class manages its own {@link MetaMasterMasterClient}.\n+ *\n+ * When running, this task first requests master configuration from the standby master,\n+ * then sends it to the leader master. After which, the task will wait for the elapsed time\n+ * since its last heartbeat has reached the heartbeat interval. Then the cycle will continue.\n+ *\n+ * If the task fails to heartbeat to the leader master, it will destroy its old master client","path":"core/server/master/src/main/java/alluxio/master/meta/MetaMasterSync.java","position":33,"original_position":33,"commit_id":"78afd69974120ba1e693e20b8768f0b744340e5a","original_commit_id":"78afd69974120ba1e693e20b8768f0b744340e5a","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"is this necessary? I think the `MetaMasterClient` should be able to handle the retries.","created_at":"2018-05-04T19:51:16Z","updated_at":"2018-05-04T19:59:24Z","html_url":"https://github.com/Alluxio/alluxio/pull/7233#discussion_r186198071","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/186198071"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7233#discussion_r186198071"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233","id":185845702,"html_url":"https://github.com/Alluxio/alluxio/pull/7233","diff_url":"https://github.com/Alluxio/alluxio/pull/7233.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7233.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7233","number":7233,"state":"open","locked":false,"title":"[ALLUXIO-3184] Master communication for server configuration checker ","user":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-3184","created_at":"2018-05-03T21:41:10Z","updated_at":"2018-05-04T19:59:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fba579bf6328d35086b0fbcd879576b50c6cae07","assignee":{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"assignees":[{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7233/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/78afd69974120ba1e693e20b8768f0b744340e5a","head":{"label":"LuQQiu:masterCommunication","ref":"masterCommunication","sha":"78afd69974120ba1e693e20b8768f0b744340e5a","user":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"repo":{"id":131058240,"name":"alluxio","full_name":"LuQQiu/alluxio","owner":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LuQQiu/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/LuQQiu/alluxio","forks_url":"https://api.github.com/repos/LuQQiu/alluxio/forks","keys_url":"https://api.github.com/repos/LuQQiu/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuQQiu/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuQQiu/alluxio/teams","hooks_url":"https://api.github.com/repos/LuQQiu/alluxio/hooks","issue_events_url":"https://api.github.com/repos/LuQQiu/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/LuQQiu/alluxio/events","assignees_url":"https://api.github.com/repos/LuQQiu/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/LuQQiu/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/LuQQiu/alluxio/tags","blobs_url":"https://api.github.com/repos/LuQQiu/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuQQiu/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuQQiu/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuQQiu/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuQQiu/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/LuQQiu/alluxio/languages","stargazers_url":"https://api.github.com/repos/LuQQiu/alluxio/stargazers","contributors_url":"https://api.github.com/repos/LuQQiu/alluxio/contributors","subscribers_url":"https://api.github.com/repos/LuQQiu/alluxio/subscribers","subscription_url":"https://api.github.com/repos/LuQQiu/alluxio/subscription","commits_url":"https://api.github.com/repos/LuQQiu/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuQQiu/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuQQiu/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuQQiu/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuQQiu/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/LuQQiu/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuQQiu/alluxio/merges","archive_url":"https://api.github.com/repos/LuQQiu/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuQQiu/alluxio/downloads","issues_url":"https://api.github.com/repos/LuQQiu/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/LuQQiu/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/LuQQiu/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/LuQQiu/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuQQiu/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/LuQQiu/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/LuQQiu/alluxio/deployments","created_at":"2018-04-25T20:11:47Z","updated_at":"2018-04-25T20:11:55Z","pushed_at":"2018-05-04T18:42:45Z","git_url":"git://github.com/LuQQiu/alluxio.git","ssh_url":"git@github.com:LuQQiu/alluxio.git","clone_url":"https://github.com/LuQQiu/alluxio.git","svn_url":"https://github.com/LuQQiu/alluxio","homepage":"http://www.alluxio.org/","size":87944,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:config-checker","ref":"config-checker","sha":"6caae6e58cf1680d53867b5ab04e6f87241e8cbd","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-05-04T12:38:36Z","pushed_at":"2018-05-04T18:42:48Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":87890,"stargazers_count":3473,"watchers_count":3473,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1875,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1875,"open_issues":13,"watchers":3473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7233"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7233"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7233/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7233/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/78afd69974120ba1e693e20b8768f0b744340e5a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aaudiber"}}