{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22559","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22559/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22559/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22559/events","html_url":"https://github.com/tensorflow/tensorflow/pull/22559","id":364388318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTg2NzUz","number":22559,"title":"Fix grpc+gdr compile error introduced in 33170cc6.","user":{"login":"byronyi","id":2613663,"node_id":"MDQ6VXNlcjI2MTM2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2613663?v=4","gravatar_id":"","url":"https://api.github.com/users/byronyi","html_url":"https://github.com/byronyi","followers_url":"https://api.github.com/users/byronyi/followers","following_url":"https://api.github.com/users/byronyi/following{/other_user}","gists_url":"https://api.github.com/users/byronyi/gists{/gist_id}","starred_url":"https://api.github.com/users/byronyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronyi/subscriptions","organizations_url":"https://api.github.com/users/byronyi/orgs","repos_url":"https://api.github.com/users/byronyi/repos","events_url":"https://api.github.com/users/byronyi/events{/privacy}","received_events_url":"https://api.github.com/users/byronyi/received_events","type":"User","site_admin":false},"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":987666414,"node_id":"MDU6TGFiZWw5ODc2NjY0MTQ=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull","name":"ready to pull","color":"2cd643","default":false}],"state":"closed","locked":false,"assignee":{"login":"caisq","id":16824702,"node_id":"MDQ6VXNlcjE2ODI0NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"assignees":[{"login":"caisq","id":16824702,"node_id":"MDQ6VXNlcjE2ODI0NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-09-27T09:40:15Z","updated_at":"2018-10-07T15:01:26Z","closed_at":"2018-10-06T16:50:53Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/22559","html_url":"https://github.com/tensorflow/tensorflow/pull/22559","diff_url":"https://github.com/tensorflow/tensorflow/pull/22559.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/22559.patch"},"body":"@poxvoculi Most CPU tensors in PS are still managed by cpu_allocator, and I have added a separate path to copy them back to a CPU tensor managed by ProcessState::GetCPUAllocator.\r\n\r\nI believe there is no harm (maybe a little bit larger page table on NIC?) to register the same memory region multiple times, so it is not required for the memory managers to be singletons."},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/427659942","html_url":"https://github.com/tensorflow/tensorflow/pull/22559#issuecomment-427659942","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22559","id":427659942,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY1OTk0Mg==","user":{"login":"yanivbl6","id":24679884,"node_id":"MDQ6VXNlcjI0Njc5ODg0","avatar_url":"https://avatars2.githubusercontent.com/u/24679884?v=4","gravatar_id":"","url":"https://api.github.com/users/yanivbl6","html_url":"https://github.com/yanivbl6","followers_url":"https://api.github.com/users/yanivbl6/followers","following_url":"https://api.github.com/users/yanivbl6/following{/other_user}","gists_url":"https://api.github.com/users/yanivbl6/gists{/gist_id}","starred_url":"https://api.github.com/users/yanivbl6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanivbl6/subscriptions","organizations_url":"https://api.github.com/users/yanivbl6/orgs","repos_url":"https://api.github.com/users/yanivbl6/repos","events_url":"https://api.github.com/users/yanivbl6/events{/privacy}","received_events_url":"https://api.github.com/users/yanivbl6/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T15:01:26Z","updated_at":"2018-10-07T15:01:26Z","author_association":"CONTRIBUTOR","body":"hi @byronyi, @poxvoculi \r\nI tried running the new GDR from latest master but I encountered an error:\r\nCheck failed: 0 == cpu_allocators_.size() (0 vs. 1)AddCPUAllocVisitor must be called prior to first call to ProcessState::GetCPUAllocator\r\n\r\nI am also getting the same error on my the patch I am working on to fix the verbs contribution.\r\n\r\nMy understanding is the the GPU \"base device\" is created in [this line](https://github.com/tensorflow/tensorflow/blob/aab3c53e1484404a70565324d1231c4e6ead7425/tensorflow/core/common_runtime/gpu/gpu_device.cc#L1111), trigerring the call to GetCPUAllocator before the visitors are registered, which is an error.\r\nI am still trying to figure out how the tensorflow core is managing/syncing those event (GPU context creation and memory manager initialization). "}}
{"actor":{"display_login":"yanivbl6"}}