{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/179567361","pull_request_review_id":109836305,"id":179567361,"diff_hunk":"@@ -0,0 +1,40 @@\n+package com.netflix.spinnaker.clouddriver.openstack.deploy.ops.servergroup","path":"clouddriver-openstack/src/main/groovy/com/netflix/spinnaker/clouddriver/openstack/deploy/ops/servergroup/StackChecker.groovy","position":1,"original_position":1,"commit_id":"f3b654abc23a2922d679674584ae5b703742b982","original_commit_id":"061295c3c4ea72f84260dc42ac52292926922445","user":{"login":"brianberzins","id":2465816,"avatar_url":"https://avatars0.githubusercontent.com/u/2465816?v=4","gravatar_id":"","url":"https://api.github.com/users/brianberzins","html_url":"https://github.com/brianberzins","followers_url":"https://api.github.com/users/brianberzins/followers","following_url":"https://api.github.com/users/brianberzins/following{/other_user}","gists_url":"https://api.github.com/users/brianberzins/gists{/gist_id}","starred_url":"https://api.github.com/users/brianberzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianberzins/subscriptions","organizations_url":"https://api.github.com/users/brianberzins/orgs","repos_url":"https://api.github.com/users/brianberzins/repos","events_url":"https://api.github.com/users/brianberzins/events{/privacy}","received_events_url":"https://api.github.com/users/brianberzins/received_events","type":"User","site_admin":false},"body":"I also missed that other sub modules are mixing groovy/java source. If we're just talking about making it a java file inside the groovy source directory (as I saw in other sub modules) I have no problem with this.\r\n","created_at":"2018-04-05T18:56:11Z","updated_at":"2018-04-05T18:56:11Z","html_url":"https://github.com/spinnaker/clouddriver/pull/2482#discussion_r179567361","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/179567361"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/2482#discussion_r179567361"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482"}},"in_reply_to_id":179558609},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482","id":179471241,"html_url":"https://github.com/spinnaker/clouddriver/pull/2482","diff_url":"https://github.com/spinnaker/clouddriver/pull/2482.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/2482.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2482","number":2482,"state":"open","locked":false,"title":"fix(provider/openstack): corrects behavior of status checkers","user":{"login":"brianberzins","id":2465816,"avatar_url":"https://avatars0.githubusercontent.com/u/2465816?v=4","gravatar_id":"","url":"https://api.github.com/users/brianberzins","html_url":"https://github.com/brianberzins","followers_url":"https://api.github.com/users/brianberzins/followers","following_url":"https://api.github.com/users/brianberzins/following{/other_user}","gists_url":"https://api.github.com/users/brianberzins/gists{/gist_id}","starred_url":"https://api.github.com/users/brianberzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianberzins/subscriptions","organizations_url":"https://api.github.com/users/brianberzins/orgs","repos_url":"https://api.github.com/users/brianberzins/repos","events_url":"https://api.github.com/users/brianberzins/events{/privacy}","received_events_url":"https://api.github.com/users/brianberzins/received_events","type":"User","site_admin":false},"body":"Co-authored-by: Gardnem6 <12258900+Gardnem6@users.noreply.github.com>\r\nCo-authored-by: msilpala <msilpala@users.noreply.github.com>\r\nCo-authored-by: esengstrom <37663918+esengstrom@users.noreply.github.com>\r\n\r\nThe underlying problem: we noticed a number of openstack operations failed/succeeded quickly on the openstack side, but those failures/successes were not always propagating through to spinnaker. Instead, spinnaker would continue to wait for deployments/deletes/resizes until they eventually timed out. The inconsistent behavior turned out to be whether or not the status was successful within the first check inside of a status-checking loop.\r\n\r\nThis looks like a large PR, but each of the following were done to fix the single aforementioned problem.\r\n\r\n\r\nUse of the `BlockingStatusChecker` was inconsistent. In some cases it was assumed that the closure being called would be called within a loop, while other cases assumed it would be called only once. This pull request makes it so that all usages expect the closure to be called in the loop. Effectively, make the request to change once: then call the status checkers closure in a loop.\r\n\r\nMoved the LoadBalancer checker into it's own class and created a new checker for Stack operations.\r\n\r\nThe openstack provider was inconsistent between whether or not calls to specific APIs should throw exceptions when a `null` is returned. This PR changes those behaviors to consistently allow `null` to be returned. When an exception should be thrown, it is now thrown from a separate `null` check.\r\n\r\nAdded a `StackConfig` analogous to the `LbaasConfig` to configure timeouts and polling intervals for operations to openstack \"stack\" APIs. Included default configuration for both. Reasonable defaults are included in case configuration files do not specify them.\r\n\r\nA large number of test cases were updated to account for these changes. In most cases, the number of calls made to mocked objects changed based on the corrected looping logic. Additional tests were created for the extra logic of checking stack statuses.","created_at":"2018-04-04T18:15:02Z","updated_at":"2018-04-05T18:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7bffe77daba9782a8bc398a71ff245dd9a1a7d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2482/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/f3b654abc23a2922d679674584ae5b703742b982","head":{"label":"brianberzins:openstack-checking-fix","ref":"openstack-checking-fix","sha":"f3b654abc23a2922d679674584ae5b703742b982","user":{"login":"brianberzins","id":2465816,"avatar_url":"https://avatars0.githubusercontent.com/u/2465816?v=4","gravatar_id":"","url":"https://api.github.com/users/brianberzins","html_url":"https://github.com/brianberzins","followers_url":"https://api.github.com/users/brianberzins/followers","following_url":"https://api.github.com/users/brianberzins/following{/other_user}","gists_url":"https://api.github.com/users/brianberzins/gists{/gist_id}","starred_url":"https://api.github.com/users/brianberzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianberzins/subscriptions","organizations_url":"https://api.github.com/users/brianberzins/orgs","repos_url":"https://api.github.com/users/brianberzins/repos","events_url":"https://api.github.com/users/brianberzins/events{/privacy}","received_events_url":"https://api.github.com/users/brianberzins/received_events","type":"User","site_admin":false},"repo":{"id":117012564,"name":"clouddriver","full_name":"brianberzins/clouddriver","owner":{"login":"brianberzins","id":2465816,"avatar_url":"https://avatars0.githubusercontent.com/u/2465816?v=4","gravatar_id":"","url":"https://api.github.com/users/brianberzins","html_url":"https://github.com/brianberzins","followers_url":"https://api.github.com/users/brianberzins/followers","following_url":"https://api.github.com/users/brianberzins/following{/other_user}","gists_url":"https://api.github.com/users/brianberzins/gists{/gist_id}","starred_url":"https://api.github.com/users/brianberzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianberzins/subscriptions","organizations_url":"https://api.github.com/users/brianberzins/orgs","repos_url":"https://api.github.com/users/brianberzins/repos","events_url":"https://api.github.com/users/brianberzins/events{/privacy}","received_events_url":"https://api.github.com/users/brianberzins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianberzins/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/brianberzins/clouddriver","forks_url":"https://api.github.com/repos/brianberzins/clouddriver/forks","keys_url":"https://api.github.com/repos/brianberzins/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianberzins/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianberzins/clouddriver/teams","hooks_url":"https://api.github.com/repos/brianberzins/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/brianberzins/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/brianberzins/clouddriver/events","assignees_url":"https://api.github.com/repos/brianberzins/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/brianberzins/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/brianberzins/clouddriver/tags","blobs_url":"https://api.github.com/repos/brianberzins/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianberzins/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianberzins/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianberzins/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianberzins/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/brianberzins/clouddriver/languages","stargazers_url":"https://api.github.com/repos/brianberzins/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/brianberzins/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/brianberzins/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/brianberzins/clouddriver/subscription","commits_url":"https://api.github.com/repos/brianberzins/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianberzins/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianberzins/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianberzins/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianberzins/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/brianberzins/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianberzins/clouddriver/merges","archive_url":"https://api.github.com/repos/brianberzins/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianberzins/clouddriver/downloads","issues_url":"https://api.github.com/repos/brianberzins/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/brianberzins/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/brianberzins/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/brianberzins/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianberzins/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/brianberzins/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/brianberzins/clouddriver/deployments","created_at":"2018-01-10T21:24:38Z","updated_at":"2018-01-10T21:24:47Z","pushed_at":"2018-04-05T18:29:40Z","git_url":"git://github.com/brianberzins/clouddriver.git","ssh_url":"git@github.com:brianberzins/clouddriver.git","clone_url":"https://github.com/brianberzins/clouddriver.git","svn_url":"https://github.com/brianberzins/clouddriver","homepage":null,"size":39053,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"0f8501f62050c387432ef0dd8a8fbeb867a09873","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2018-04-05T02:31:40Z","pushed_at":"2018-04-05T18:29:42Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":39026,"stargazers_count":137,"watchers_count":137,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":323,"open_issues":10,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/2482"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/2482"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/2482/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2482/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/f3b654abc23a2922d679674584ae5b703742b982"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brianberzins"}}