{"action":"created","comment":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/237490372","pull_request_review_id":179799522,"id":237490372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ5MDM3Mg==","diff_hunk":"@@ -71,12 +77,20 @@ class $Inline implements ResourceInterface\n \t/**\n \t * Sets extra HTML attributes\n \t */\n-\tpublic function setAttributes(array attributes) -> <$Inline>\n+\tpublic function setAttributes(array attributes) -> <ResourceInterface>\n \t{\n \t\tlet this->_attributes = attributes;\n \t\treturn this;\n \t}\n \n+\t/**\n+\t * returns extra HTML attributes\n+\t */\n+\tpublic function getAttributes() -> array | null\n+\t{\n+\t\treturn this->_attributes;\n+\t}","path":"phalcon/assets/inline.zep","position":56,"original_position":56,"commit_id":"883e904dd0097955b35549fd8b13634d8fbddb93","original_commit_id":"883e904dd0097955b35549fd8b13634d8fbddb93","user":{"login":"sergeyklay","id":1256298,"node_id":"MDQ6VXNlcjEyNTYyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1256298?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyklay","html_url":"https://github.com/sergeyklay","followers_url":"https://api.github.com/users/sergeyklay/followers","following_url":"https://api.github.com/users/sergeyklay/following{/other_user}","gists_url":"https://api.github.com/users/sergeyklay/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyklay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyklay/subscriptions","organizations_url":"https://api.github.com/users/sergeyklay/orgs","repos_url":"https://api.github.com/users/sergeyklay/repos","events_url":"https://api.github.com/users/sergeyklay/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyklay/received_events","type":"User","site_admin":false},"body":"No needed","created_at":"2018-11-29T13:43:23Z","updated_at":"2018-11-29T13:53:26Z","html_url":"https://github.com/phalcon/cphalcon/pull/13592#discussion_r237490372","pull_request_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/237490372"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13592#discussion_r237490372"},"pull_request":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592"}}},"pull_request":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592","id":230214749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjE0NzQ5","html_url":"https://github.com/phalcon/cphalcon/pull/13592","diff_url":"https://github.com/phalcon/cphalcon/pull/13592.diff","patch_url":"https://github.com/phalcon/cphalcon/pull/13592.patch","issue_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13592","number":13592,"state":"open","locked":false,"title":"fix merge conflicts with 4.0.x and 3.4.x with type hinting and interfaces ( zephir 0.11 )","user":{"login":"Izopi4a","id":7415020,"node_id":"MDQ6VXNlcjc0MTUwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7415020?v=4","gravatar_id":"","url":"https://api.github.com/users/Izopi4a","html_url":"https://github.com/Izopi4a","followers_url":"https://api.github.com/users/Izopi4a/followers","following_url":"https://api.github.com/users/Izopi4a/following{/other_user}","gists_url":"https://api.github.com/users/Izopi4a/gists{/gist_id}","starred_url":"https://api.github.com/users/Izopi4a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Izopi4a/subscriptions","organizations_url":"https://api.github.com/users/Izopi4a/orgs","repos_url":"https://api.github.com/users/Izopi4a/repos","events_url":"https://api.github.com/users/Izopi4a/events{/privacy}","received_events_url":"https://api.github.com/users/Izopi4a/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\n* Type: bug fix | code quality \r\n\r\n**In raising this pull request, I confirm the following (please check boxes):**\r\n\r\n- [x] I have read and understood the [Contributing Guidelines](https://github.com/phalcon/cphalcon/blob/master/CONTRIBUTING.md)?\r\n- [x] I have checked that another pull request for this purpose does not exist.\r\n\r\nSmall description of change:\r\n\r\nfixing interfaces for latest zephir\r\n\r\nNow ... there are more things that we can fix/break here. I noticed a few \"problems\" during the fixes. However there are 20+ merge conflicts with this one. \r\nIf we could merge this one, and then we can continue improving ( because this one is already long enough ) \r\n\r\nThanks\r\n\r\n","created_at":"2018-11-12T17:35:29Z","updated_at":"2018-11-29T13:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2be761d3b446f4748e27035de4b27cbca23a3637","assignee":{"login":"niden","id":1073784,"node_id":"MDQ6VXNlcjEwNzM3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073784?v=4","gravatar_id":"","url":"https://api.github.com/users/niden","html_url":"https://github.com/niden","followers_url":"https://api.github.com/users/niden/followers","following_url":"https://api.github.com/users/niden/following{/other_user}","gists_url":"https://api.github.com/users/niden/gists{/gist_id}","starred_url":"https://api.github.com/users/niden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niden/subscriptions","organizations_url":"https://api.github.com/users/niden/orgs","repos_url":"https://api.github.com/users/niden/repos","events_url":"https://api.github.com/users/niden/events{/privacy}","received_events_url":"https://api.github.com/users/niden/received_events","type":"User","site_admin":false},"assignees":[{"login":"niden","id":1073784,"node_id":"MDQ6VXNlcjEwNzM3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073784?v=4","gravatar_id":"","url":"https://api.github.com/users/niden","html_url":"https://github.com/niden","followers_url":"https://api.github.com/users/niden/followers","following_url":"https://api.github.com/users/niden/following{/other_user}","gists_url":"https://api.github.com/users/niden/gists{/gist_id}","starred_url":"https://api.github.com/users/niden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niden/subscriptions","organizations_url":"https://api.github.com/users/niden/orgs","repos_url":"https://api.github.com/users/niden/repos","events_url":"https://api.github.com/users/niden/events{/privacy}","received_events_url":"https://api.github.com/users/niden/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":38989055,"node_id":"MDU6TGFiZWwzODk4OTA1NQ==","url":"https://api.github.com/repos/phalcon/cphalcon/labels/Enhancement","name":"Enhancement","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/phalcon/cphalcon/milestones/21","html_url":"https://github.com/phalcon/cphalcon/milestone/21","labels_url":"https://api.github.com/repos/phalcon/cphalcon/milestones/21/labels","id":1912191,"node_id":"MDk6TWlsZXN0b25lMTkxMjE5MQ==","number":21,"title":"4.0.0","description":"","creator":{"login":"sergeyklay","id":1256298,"node_id":"MDQ6VXNlcjEyNTYyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1256298?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyklay","html_url":"https://github.com/sergeyklay","followers_url":"https://api.github.com/users/sergeyklay/followers","following_url":"https://api.github.com/users/sergeyklay/following{/other_user}","gists_url":"https://api.github.com/users/sergeyklay/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyklay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyklay/subscriptions","organizations_url":"https://api.github.com/users/sergeyklay/orgs","repos_url":"https://api.github.com/users/sergeyklay/repos","events_url":"https://api.github.com/users/sergeyklay/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyklay/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":61,"state":"open","created_at":"2016-07-29T16:36:07Z","updated_at":"2018-11-29T12:12:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592/commits","review_comments_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592/comments","review_comment_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13592/comments","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/883e904dd0097955b35549fd8b13634d8fbddb93","head":{"label":"Izopi4a:fix-typehints-4.0.x","ref":"fix-typehints-4.0.x","sha":"883e904dd0097955b35549fd8b13634d8fbddb93","user":{"login":"Izopi4a","id":7415020,"node_id":"MDQ6VXNlcjc0MTUwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7415020?v=4","gravatar_id":"","url":"https://api.github.com/users/Izopi4a","html_url":"https://github.com/Izopi4a","followers_url":"https://api.github.com/users/Izopi4a/followers","following_url":"https://api.github.com/users/Izopi4a/following{/other_user}","gists_url":"https://api.github.com/users/Izopi4a/gists{/gist_id}","starred_url":"https://api.github.com/users/Izopi4a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Izopi4a/subscriptions","organizations_url":"https://api.github.com/users/Izopi4a/orgs","repos_url":"https://api.github.com/users/Izopi4a/repos","events_url":"https://api.github.com/users/Izopi4a/events{/privacy}","received_events_url":"https://api.github.com/users/Izopi4a/received_events","type":"User","site_admin":false},"repo":{"id":42773752,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc3Mzc1Mg==","name":"cphalcon","full_name":"Izopi4a/cphalcon","private":false,"owner":{"login":"Izopi4a","id":7415020,"node_id":"MDQ6VXNlcjc0MTUwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7415020?v=4","gravatar_id":"","url":"https://api.github.com/users/Izopi4a","html_url":"https://github.com/Izopi4a","followers_url":"https://api.github.com/users/Izopi4a/followers","following_url":"https://api.github.com/users/Izopi4a/following{/other_user}","gists_url":"https://api.github.com/users/Izopi4a/gists{/gist_id}","starred_url":"https://api.github.com/users/Izopi4a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Izopi4a/subscriptions","organizations_url":"https://api.github.com/users/Izopi4a/orgs","repos_url":"https://api.github.com/users/Izopi4a/repos","events_url":"https://api.github.com/users/Izopi4a/events{/privacy}","received_events_url":"https://api.github.com/users/Izopi4a/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Izopi4a/cphalcon","description":"Web framework delivered as a C-extension for PHP","fork":true,"url":"https://api.github.com/repos/Izopi4a/cphalcon","forks_url":"https://api.github.com/repos/Izopi4a/cphalcon/forks","keys_url":"https://api.github.com/repos/Izopi4a/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Izopi4a/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Izopi4a/cphalcon/teams","hooks_url":"https://api.github.com/repos/Izopi4a/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/Izopi4a/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/Izopi4a/cphalcon/events","assignees_url":"https://api.github.com/repos/Izopi4a/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/Izopi4a/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/Izopi4a/cphalcon/tags","blobs_url":"https://api.github.com/repos/Izopi4a/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Izopi4a/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Izopi4a/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Izopi4a/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Izopi4a/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/Izopi4a/cphalcon/languages","stargazers_url":"https://api.github.com/repos/Izopi4a/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/Izopi4a/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/Izopi4a/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/Izopi4a/cphalcon/subscription","commits_url":"https://api.github.com/repos/Izopi4a/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Izopi4a/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Izopi4a/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Izopi4a/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Izopi4a/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/Izopi4a/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Izopi4a/cphalcon/merges","archive_url":"https://api.github.com/repos/Izopi4a/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Izopi4a/cphalcon/downloads","issues_url":"https://api.github.com/repos/Izopi4a/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/Izopi4a/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/Izopi4a/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/Izopi4a/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Izopi4a/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/Izopi4a/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/Izopi4a/cphalcon/deployments","created_at":"2015-09-19T13:25:42Z","updated_at":"2018-11-10T09:07:51Z","pushed_at":"2018-11-15T14:57:02Z","git_url":"git://github.com/Izopi4a/cphalcon.git","ssh_url":"git@github.com:Izopi4a/cphalcon.git","clone_url":"https://github.com/Izopi4a/cphalcon.git","svn_url":"https://github.com/Izopi4a/cphalcon","homepage":"phalconphp.com","size":141496,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"phalcon:4.0.x","ref":"4.0.x","sha":"138dab611a3b05e421ba1422d1087f3c6a6d7f4e","user":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"repo":{"id":2854337,"node_id":"MDEwOlJlcG9zaXRvcnkyODU0MzM3","name":"cphalcon","full_name":"phalcon/cphalcon","private":false,"owner":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/phalcon/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":false,"url":"https://api.github.com/repos/phalcon/cphalcon","forks_url":"https://api.github.com/repos/phalcon/cphalcon/forks","keys_url":"https://api.github.com/repos/phalcon/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phalcon/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phalcon/cphalcon/teams","hooks_url":"https://api.github.com/repos/phalcon/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/phalcon/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/phalcon/cphalcon/events","assignees_url":"https://api.github.com/repos/phalcon/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/phalcon/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/phalcon/cphalcon/tags","blobs_url":"https://api.github.com/repos/phalcon/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phalcon/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phalcon/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/phalcon/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/phalcon/cphalcon/languages","stargazers_url":"https://api.github.com/repos/phalcon/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/phalcon/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/phalcon/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/phalcon/cphalcon/subscription","commits_url":"https://api.github.com/repos/phalcon/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/phalcon/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/phalcon/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/phalcon/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/phalcon/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phalcon/cphalcon/merges","archive_url":"https://api.github.com/repos/phalcon/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phalcon/cphalcon/downloads","issues_url":"https://api.github.com/repos/phalcon/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/phalcon/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/phalcon/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/phalcon/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phalcon/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/phalcon/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/phalcon/cphalcon/deployments","created_at":"2011-11-26T05:52:50Z","updated_at":"2018-11-29T13:41:28Z","pushed_at":"2018-11-29T00:57:22Z","git_url":"git://github.com/phalcon/cphalcon.git","ssh_url":"git@github.com:phalcon/cphalcon.git","clone_url":"https://github.com/phalcon/cphalcon.git","svn_url":"https://github.com/phalcon/cphalcon","homepage":"https://phalconphp.com","size":149984,"stargazers_count":9321,"watchers_count":9321,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1724,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1724,"open_issues":172,"watchers":9321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13592"},"issue":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13592"},"comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13592/comments"},"review_comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592/comments"},"review_comment":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13592/commits"},"statuses":{"href":"https://api.github.com/repos/phalcon/cphalcon/statuses/883e904dd0097955b35549fd8b13634d8fbddb93"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sergeyklay"}}