{"action":"created","issue":{"url":"https://api.github.com/repos/RogueException/Discord.Net/issues/943","repository_url":"https://api.github.com/repos/RogueException/Discord.Net","labels_url":"https://api.github.com/repos/RogueException/Discord.Net/issues/943/labels{/name}","comments_url":"https://api.github.com/repos/RogueException/Discord.Net/issues/943/comments","events_url":"https://api.github.com/repos/RogueException/Discord.Net/issues/943/events","html_url":"https://github.com/RogueException/Discord.Net/pull/943","id":292202508,"number":943,"title":"Add support for parsing multiple types of quotation marks in commands, Fix #942","user":{"login":"Chris-Johnston","id":16418643,"avatar_url":"https://avatars0.githubusercontent.com/u/16418643?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Johnston","html_url":"https://github.com/Chris-Johnston","followers_url":"https://api.github.com/users/Chris-Johnston/followers","following_url":"https://api.github.com/users/Chris-Johnston/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Johnston/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Johnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Johnston/subscriptions","organizations_url":"https://api.github.com/users/Chris-Johnston/orgs","repos_url":"https://api.github.com/users/Chris-Johnston/repos","events_url":"https://api.github.com/users/Chris-Johnston/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Johnston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-01-28T12:56:26Z","updated_at":"2018-04-30T16:12:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RogueException/Discord.Net/pulls/943","html_url":"https://github.com/RogueException/Discord.Net/pull/943","diff_url":"https://github.com/RogueException/Discord.Net/pull/943.diff","patch_url":"https://github.com/RogueException/Discord.Net/pull/943.patch"},"body":"#942 brings up the issue that non-remainder string parameters of commands cannot be parsed with non-standard double quotation marks (`\"`). I added a list of quotation mark aliases to the `CommandServiceConfig`. This means the library can now parse unicode double quotation marks and also culture-specific ones (like `「` and `«`).\r\n\r\nI used aliases that were mentioned in the d.net channel, but I'm not certain what the default values should be set to.\r\n\r\nI would like to get feedback if anything needs improvement. My discord handle in the channel is `@ChrisJ#8703`.\r\n\r\n**Testing Method:**\r\nI wanted to test that a single string could be parsed correctly when wrapped in multiple types of quotation marks. Here's a command that I used:\r\n```cs\r\n[Command(\"testcmd\")]\r\npublic async Task TestCmd(string txt, int aNumber)\r\n{\r\n    await ReplyAsync($\"{txt} {aNumber}\");\r\n}\r\n```\r\n\r\nAnd sample execution yields:\r\n`-testcmd \"test\" 123` => `test 123` (normal behavior)\r\n`-testcmd “test\\“cmd\\\"“ 123` => `test“cmd\" 123` (escaping still works)\r\n`-testcmd «this is a multiple word string» 123` => `this is a multiple word string 123`\r\n`-testcmd «you can mix and match\" 456` => `you can mix and match 456`\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/RogueException/Discord.Net/issues/comments/385447904","html_url":"https://github.com/RogueException/Discord.Net/pull/943#issuecomment-385447904","issue_url":"https://api.github.com/repos/RogueException/Discord.Net/issues/943","id":385447904,"user":{"login":"Chris-Johnston","id":16418643,"avatar_url":"https://avatars0.githubusercontent.com/u/16418643?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Johnston","html_url":"https://github.com/Chris-Johnston","followers_url":"https://api.github.com/users/Chris-Johnston/followers","following_url":"https://api.github.com/users/Chris-Johnston/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Johnston/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Johnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Johnston/subscriptions","organizations_url":"https://api.github.com/users/Chris-Johnston/orgs","repos_url":"https://api.github.com/users/Chris-Johnston/repos","events_url":"https://api.github.com/users/Chris-Johnston/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Johnston/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T16:12:50Z","updated_at":"2018-04-30T16:12:50Z","author_association":"CONTRIBUTOR","body":"#1043 replaces ns1.3 with ns2.0. if it is merged, we will be able to support generating quotation mark pairs programmatically, see the comment thread immediately above\r\n\r\nHopefully might be able to have this merged?"}}
{"actor":{"display_login":"Chris-Johnston"}}