{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3425","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3425/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3425/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3425/events","html_url":"https://github.com/electron-userland/electron-builder/issues/3425","id":374644687,"node_id":"MDU6SXNzdWUzNzQ2NDQ2ODc=","number":3425,"title":"20.29.0 Bug? MAS codesigning fails","user":{"login":"rr326","id":1766391,"node_id":"MDQ6VXNlcjE3NjYzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1766391?v=4","gravatar_id":"","url":"https://api.github.com/users/rr326","html_url":"https://github.com/rr326","followers_url":"https://api.github.com/users/rr326/followers","following_url":"https://api.github.com/users/rr326/following{/other_user}","gists_url":"https://api.github.com/users/rr326/gists{/gist_id}","starred_url":"https://api.github.com/users/rr326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr326/subscriptions","organizations_url":"https://api.github.com/users/rr326/orgs","repos_url":"https://api.github.com/users/rr326/repos","events_url":"https://api.github.com/users/rr326/events{/privacy}","received_events_url":"https://api.github.com/users/rr326/received_events","type":"User","site_admin":false},"labels":[{"id":309000662,"node_id":"MDU6TGFiZWwzMDkwMDA2NjI=","url":"https://api.github.com/repos/electron-userland/electron-builder/labels/mac","name":"mac","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-27T13:22:04Z","updated_at":"2018-10-27T13:31:39Z","closed_at":null,"author_association":"NONE","body":"<!-- Which version of electron-builder are you using? -->\r\n<!-- Please always try to use latest version before report. -->\r\n* **Version**: 20.29.0\r\n\r\n<!-- Which version of electron-updater are you using (if applicable)? -->\r\n\r\n<!-- What target are you building for? -->\r\n* **Target**: mas \r\n\r\n<!-- Enter your issue details below this comment. -->\r\nThis is a new error that shows up in 20.29 but not 20.28.\r\nWith `DEBUG=electron-osx-sign`\r\n\r\n      electron-osx-sign Executing... codesign --sign 6A26EE0DB4362DA30BE6EF06695E6AF16B101C69 --force --entitlements build/entitlements.mac.inherit.plist /Users/rrosen/dev/filing/dist_prod_dist/mac/FileSimple.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa +0ms\r\n      electron-osx-sign Error executing file:\r\n     > Stdout:\r\n     > Stderr: /Users/rrosen/dev/filing/dist_prod_dist/mas/FileSimple.app/Contents/MacOS/FileSimple: code object is not signed at all\r\n    In subcomponent: /Users/rrosen/dev/filing/dist_prod_dist/mas/FileSimple.app/Contents/Library/LoginItems/Contents/_CodeSignature/CodeResources\r\n     +36ms\r\n    Error: Command failed: codesign --sign C706993845BB96DBE90EF9DC927A955FBAF62731 --force --entitlements build/entitlements.mac.inherit.plist /Users/rrosen/dev/filing/dist_prod_dist/mas/FileSimple.app/Contents/MacOS/FileSimple\r\n    /Users/rrosen/dev/filing/dist_prod_dist/mas/FileSimple.app/Contents/MacOS/FileSimple: code object is not signed at all\r\n    In subcomponent: /Users/rrosen/dev/filing/dist_prod_dist/mas/FileSimple.app/Contents/Library/LoginItems/Contents/_CodeSignature/CodeResources\r\n\r\nWhen I built with previous versions I'd get an app stucture of:\r\n\r\n    ls FileSimple.app/Contents/Library/LoginItems\r\n    ./        ../       FileSimple Login Helper.app/\r\n\r\nWhen I build with 20.29:\r\n\r\n    ls dist_prod_dist/mas/FileSimple.app/Contents/Library/LoginItems                                         \r\n    ./        ../       Contents/\r\n\r\nLooking at the changes in 20.29 it seems you've changed the building of helpers and maybe this bug crept in. (I know this is prerelease so maybe you'd catch it anyway, but I needed to try 20.29 because I'm stuck on a bug related to #3412)\r\n<!-- If you want, you can donate to increase issue priority (https://www.electron.build/donate) -->"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments/433620465","html_url":"https://github.com/electron-userland/electron-builder/issues/3425#issuecomment-433620465","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3425","id":433620465,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYyMDQ2NQ==","user":{"login":"rr326","id":1766391,"node_id":"MDQ6VXNlcjE3NjYzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1766391?v=4","gravatar_id":"","url":"https://api.github.com/users/rr326","html_url":"https://github.com/rr326","followers_url":"https://api.github.com/users/rr326/followers","following_url":"https://api.github.com/users/rr326/following{/other_user}","gists_url":"https://api.github.com/users/rr326/gists{/gist_id}","starred_url":"https://api.github.com/users/rr326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr326/subscriptions","organizations_url":"https://api.github.com/users/rr326/orgs","repos_url":"https://api.github.com/users/rr326/repos","events_url":"https://api.github.com/users/rr326/events{/privacy}","received_events_url":"https://api.github.com/users/rr326/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T13:31:39Z","updated_at":"2018-10-27T13:31:39Z","author_association":"NONE","body":"4.0.0-beta.5"}}
{"actor":{"display_login":"rr326"}}