{"action":"closed","number":2260,"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/2260","id":189118458,"html_url":"https://github.com/FRRouting/frr/pull/2260","diff_url":"https://github.com/FRRouting/frr/pull/2260.diff","patch_url":"https://github.com/FRRouting/frr/pull/2260.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/2260","number":2260,"state":"closed","locked":false,"title":"doc: fix distclean","user":{"login":"qlyoung","id":6827003,"avatar_url":"https://avatars3.githubusercontent.com/u/6827003?v=4","gravatar_id":"","url":"https://api.github.com/users/qlyoung","html_url":"https://github.com/qlyoung","followers_url":"https://api.github.com/users/qlyoung/followers","following_url":"https://api.github.com/users/qlyoung/following{/other_user}","gists_url":"https://api.github.com/users/qlyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/qlyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlyoung/subscriptions","organizations_url":"https://api.github.com/users/qlyoung/orgs","repos_url":"https://api.github.com/users/qlyoung/repos","events_url":"https://api.github.com/users/qlyoung/events{/privacy}","received_events_url":"https://api.github.com/users/qlyoung/received_events","type":"User","site_admin":false},"body":"Apparently Automake has some undocumented logic somewhere that makes it\r\nso any Makefile generated from an Automake Makefile.am is removed from\r\nits secret list of things to delete that it deletes when performing a\r\nrecursive distclean before actually performing the recursive distclean\r\nand since the secret list is automatically generated from the list of\r\nthings that Autoconf should generate in configure.ac we can't remove the\r\nMakefile from that list or it will break Automake's list of things to\r\nautomatically generate that it generates from Autoconf's list of things\r\nto automatically generate.\r\n\r\nThus, to prevent Automake from deleting Makefiles and then immediately\r\ntrying to use the Makefiles it just deleted to delete said Makefiles, we\r\nmust remove ourselves from the secret list, which is accomplished by\r\nchanging the file extension to '.am' instead of '.in'.\r\n\r\nAlso removed AM targets; works the same either way but might as well cut them.\r\n\r\nSigned-off-by: Quentin Young <qlyoung@cumulusnetworks.com>","created_at":"2018-05-18T19:46:39Z","updated_at":"2018-05-20T01:30:19Z","closed_at":"2018-05-20T01:30:19Z","merged_at":"2018-05-20T01:30:19Z","merge_commit_sha":"a44ed5bd8c47838a2a422195658f147877f15f31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/2260/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/2260/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/2260/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/9eb51ce3610a3228d8473e420863d0ce88090c5a","head":{"label":"qlyoung:fix-docs-distclean","ref":"fix-docs-distclean","sha":"9eb51ce3610a3228d8473e420863d0ce88090c5a","user":{"login":"qlyoung","id":6827003,"avatar_url":"https://avatars3.githubusercontent.com/u/6827003?v=4","gravatar_id":"","url":"https://api.github.com/users/qlyoung","html_url":"https://github.com/qlyoung","followers_url":"https://api.github.com/users/qlyoung/followers","following_url":"https://api.github.com/users/qlyoung/following{/other_user}","gists_url":"https://api.github.com/users/qlyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/qlyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlyoung/subscriptions","organizations_url":"https://api.github.com/users/qlyoung/orgs","repos_url":"https://api.github.com/users/qlyoung/repos","events_url":"https://api.github.com/users/qlyoung/events{/privacy}","received_events_url":"https://api.github.com/users/qlyoung/received_events","type":"User","site_admin":false},"repo":{"id":76620415,"name":"frr","full_name":"qlyoung/frr","owner":{"login":"qlyoung","id":6827003,"avatar_url":"https://avatars3.githubusercontent.com/u/6827003?v=4","gravatar_id":"","url":"https://api.github.com/users/qlyoung","html_url":"https://github.com/qlyoung","followers_url":"https://api.github.com/users/qlyoung/followers","following_url":"https://api.github.com/users/qlyoung/following{/other_user}","gists_url":"https://api.github.com/users/qlyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/qlyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlyoung/subscriptions","organizations_url":"https://api.github.com/users/qlyoung/orgs","repos_url":"https://api.github.com/users/qlyoung/repos","events_url":"https://api.github.com/users/qlyoung/events{/privacy}","received_events_url":"https://api.github.com/users/qlyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qlyoung/frr","description":null,"fork":true,"url":"https://api.github.com/repos/qlyoung/frr","forks_url":"https://api.github.com/repos/qlyoung/frr/forks","keys_url":"https://api.github.com/repos/qlyoung/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qlyoung/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qlyoung/frr/teams","hooks_url":"https://api.github.com/repos/qlyoung/frr/hooks","issue_events_url":"https://api.github.com/repos/qlyoung/frr/issues/events{/number}","events_url":"https://api.github.com/repos/qlyoung/frr/events","assignees_url":"https://api.github.com/repos/qlyoung/frr/assignees{/user}","branches_url":"https://api.github.com/repos/qlyoung/frr/branches{/branch}","tags_url":"https://api.github.com/repos/qlyoung/frr/tags","blobs_url":"https://api.github.com/repos/qlyoung/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qlyoung/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qlyoung/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/qlyoung/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qlyoung/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/qlyoung/frr/languages","stargazers_url":"https://api.github.com/repos/qlyoung/frr/stargazers","contributors_url":"https://api.github.com/repos/qlyoung/frr/contributors","subscribers_url":"https://api.github.com/repos/qlyoung/frr/subscribers","subscription_url":"https://api.github.com/repos/qlyoung/frr/subscription","commits_url":"https://api.github.com/repos/qlyoung/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/qlyoung/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/qlyoung/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/qlyoung/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/qlyoung/frr/contents/{+path}","compare_url":"https://api.github.com/repos/qlyoung/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qlyoung/frr/merges","archive_url":"https://api.github.com/repos/qlyoung/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qlyoung/frr/downloads","issues_url":"https://api.github.com/repos/qlyoung/frr/issues{/number}","pulls_url":"https://api.github.com/repos/qlyoung/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/qlyoung/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/qlyoung/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qlyoung/frr/labels{/name}","releases_url":"https://api.github.com/repos/qlyoung/frr/releases{/id}","deployments_url":"https://api.github.com/repos/qlyoung/frr/deployments","created_at":"2016-12-16T04:12:57Z","updated_at":"2018-05-13T01:07:58Z","pushed_at":"2018-05-18T19:45:39Z","git_url":"git://github.com/qlyoung/frr.git","ssh_url":"git@github.com:qlyoung/frr.git","clone_url":"https://github.com/qlyoung/frr.git","svn_url":"https://github.com/qlyoung/frr","homepage":null,"size":42895,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"29be7d92cc65e685bf3e543b1033729fc7b39235","user":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-05-19T13:30:38Z","pushed_at":"2018-05-20T01:30:19Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":39273,"stargazers_count":511,"watchers_count":511,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"archived":false,"open_issues_count":208,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":199,"open_issues":208,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2260"},"html":{"href":"https://github.com/FRRouting/frr/pull/2260"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2260"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2260/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2260/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2260/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/9eb51ce3610a3228d8473e420863d0ce88090c5a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rzalamena","id":205063,"avatar_url":"https://avatars3.githubusercontent.com/u/205063?v=4","gravatar_id":"","url":"https://api.github.com/users/rzalamena","html_url":"https://github.com/rzalamena","followers_url":"https://api.github.com/users/rzalamena/followers","following_url":"https://api.github.com/users/rzalamena/following{/other_user}","gists_url":"https://api.github.com/users/rzalamena/gists{/gist_id}","starred_url":"https://api.github.com/users/rzalamena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzalamena/subscriptions","organizations_url":"https://api.github.com/users/rzalamena/orgs","repos_url":"https://api.github.com/users/rzalamena/repos","events_url":"https://api.github.com/users/rzalamena/events{/privacy}","received_events_url":"https://api.github.com/users/rzalamena/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":20,"changed_files":7}}
{"actor":{"display_login":"rzalamena"}}