{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/223976225","pull_request_review_id":163231634,"id":223976225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk3NjIyNQ==","diff_hunk":"@@ -0,0 +1,29 @@\n+# SUSE's openQA tests\n+#\n+# Copyright © 2018 SUSE LLC\n+#\n+# Copying and distribution of this file, with or without modification,\n+# are permitted in any medium without royalty provided the copyright\n+# notice and this notice are preserved.  This file is offered as-is,\n+# without any warranty.\n+\n+# Summary: Verify data integrity of the iso image by comparing checksum.\n+# Maintainer: Joaquín Rivera <jeriveramoya@suse.com>\n+\n+use base \"opensusebasetest\";\n+use strict;\n+use testapi;\n+use Digest::file 'digest_file_hex';\n+\n+sub run {\n+    my $self = shift;\n+\n+    my $iso      = get_required_var(\"ISO\");\n+    my $checksum = get_required_var(\"CHECKSUM_ISO\");\n+\n+    my $digest = digest_file_hex($iso, \"SHA-256\");\n+    diag \"ISO checksum on the worker side: $digest\";\n+    ($checksum eq $digest) ? diag 'ok' : record_info('Failed', 'ISO checksum failed', result => 'fail');","path":"tests/installation/iso_checksum.pm","position":26,"original_position":26,"commit_id":"9236537629a2c46827524deabbb2989be1143a36","original_commit_id":"9236537629a2c46827524deabbb2989be1143a36","user":{"login":"asdil12","id":725608,"node_id":"MDQ6VXNlcjcyNTYwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/725608?v=4","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"body":"maybe you could include the expected and the actual checksum (and algo) in the `record_info`","created_at":"2018-10-10T08:13:55Z","updated_at":"2018-10-10T08:13:55Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889#discussion_r223976225","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/223976225"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889#discussion_r223976225"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889","id":220673322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjczMzIy","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5889","number":5889,"state":"open","locked":false,"title":"Add new test for data integrity","user":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"body":"Add new test for data integrity: verify data integrity of the iso image by comparing checksum from IBS/OBS with checksum on the worker.\r\nVariable `ISO_CHECKSUM` is not yet available, it depends on this other progress ticket [Need to crosscheck ISOs against checksum in rsync.pl and/or before starting test](https://progress.opensuse.org/issues/13302)\r\nI kept the same behavior than in isosize.pm test for the test to not die, but not sure if still want to do it like that for checksum.\r\n- Related ticket: https://progress.opensuse.org/issues/41414\r\n- Verification run: \r\n - [sle-15-SP1-create_hdd_gnome iso_checksum ok](http://dhcp42.suse.cz/tests/212#step/iso_checksum/1)\r\n - [sle-15-SP1-create_hdd_gnome iso_checksum fail](http://dhcp42.suse.cz/tests/213#step/iso_checksum/1)\r\n","created_at":"2018-10-05T11:41:29Z","updated_at":"2018-10-10T08:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5bc491ee8faa648a63c3ecea340813ca3346c8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5889/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/9236537629a2c46827524deabbb2989be1143a36","head":{"label":"jknphy:add_iso_checksum","ref":"add_iso_checksum","sha":"9236537629a2c46827524deabbb2989be1143a36","user":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"repo":{"id":102743269,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3NDMyNjk=","name":"os-autoinst-distri-opensuse","full_name":"jknphy/os-autoinst-distri-opensuse","private":false,"owner":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jknphy/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/deployments","created_at":"2017-09-07T13:55:24Z","updated_at":"2018-08-31T12:46:53Z","pushed_at":"2018-10-10T08:11:57Z","git_url":"git://github.com/jknphy/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:jknphy/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/jknphy/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/jknphy/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":97488,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"93fb5b3fb91ac7f962277952a69823e18dccc85e","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","private":false,"owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-10-10T07:58:44Z","pushed_at":"2018-10-10T08:11:59Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":97553,"stargazers_count":34,"watchers_count":34,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":148,"open_issues":56,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5889"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5889"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5889/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5889/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/9236537629a2c46827524deabbb2989be1143a36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"asdil12"}}