{"action":"created","comment":{"url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/comments/168965159","pull_request_review_id":97415818,"id":168965159,"diff_hunk":"@@ -193,15 +196,29 @@ def _set_services(self):\n             always call the base implementation first, as it reserves IID of\n             1 for the Accessory Information service (HAP requirement).\n         \"\"\"\n+        info_data = {","path":"pyhap/accessory.py","position":22,"original_position":14,"commit_id":"f47ef42051632c24ff0a939fb9793e67dabba982","original_commit_id":"f8e921fc5f16a0e58b3867ecb2be5eceb0d3bdd9","user":{"login":"ikalchev","id":25887324,"avatar_url":"https://avatars2.githubusercontent.com/u/25887324?v=4","gravatar_id":"","url":"https://api.github.com/users/ikalchev","html_url":"https://github.com/ikalchev","followers_url":"https://api.github.com/users/ikalchev/followers","following_url":"https://api.github.com/users/ikalchev/following{/other_user}","gists_url":"https://api.github.com/users/ikalchev/gists{/gist_id}","starred_url":"https://api.github.com/users/ikalchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikalchev/subscriptions","organizations_url":"https://api.github.com/users/ikalchev/orgs","repos_url":"https://api.github.com/users/ikalchev/repos","events_url":"https://api.github.com/users/ikalchev/events{/privacy}","received_events_url":"https://api.github.com/users/ikalchev/received_events","type":"User","site_admin":false},"body":"I see your point, I will try to address this.\r\n\r\nThe IID=1 requirement is a big hack as is currently implemented. I will surely kick this out from here and make something that is harder to screw up.","created_at":"2018-02-18T20:54:39Z","updated_at":"2018-02-18T20:55:03Z","html_url":"https://github.com/ikalchev/HAP-python/pull/41#discussion_r168965159","pull_request_url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/comments/168965159"},"html":{"href":"https://github.com/ikalchev/HAP-python/pull/41#discussion_r168965159"},"pull_request":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41"}},"in_reply_to_id":168926083},"pull_request":{"url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41","id":169779691,"html_url":"https://github.com/ikalchev/HAP-python/pull/41","diff_url":"https://github.com/ikalchev/HAP-python/pull/41.diff","patch_url":"https://github.com/ikalchev/HAP-python/pull/41.patch","issue_url":"https://api.github.com/repos/ikalchev/HAP-python/issues/41","number":41,"state":"open","locked":false,"title":"Allow classes to easily override AccessoryInformation data.","user":{"login":"schinckel","id":23411,"avatar_url":"https://avatars1.githubusercontent.com/u/23411?v=4","gravatar_id":"","url":"https://api.github.com/users/schinckel","html_url":"https://github.com/schinckel","followers_url":"https://api.github.com/users/schinckel/followers","following_url":"https://api.github.com/users/schinckel/following{/other_user}","gists_url":"https://api.github.com/users/schinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/schinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schinckel/subscriptions","organizations_url":"https://api.github.com/users/schinckel/orgs","repos_url":"https://api.github.com/users/schinckel/repos","events_url":"https://api.github.com/users/schinckel/events{/privacy}","received_events_url":"https://api.github.com/users/schinckel/received_events","type":"User","site_admin":false},"body":"Resolves #37.","created_at":"2018-02-17T11:34:13Z","updated_at":"2018-02-18T20:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91bbdff381e52d93a4d373328ce2d6510e2f83a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41/commits","review_comments_url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41/comments","review_comment_url":"https://api.github.com/repos/ikalchev/HAP-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ikalchev/HAP-python/issues/41/comments","statuses_url":"https://api.github.com/repos/ikalchev/HAP-python/statuses/f47ef42051632c24ff0a939fb9793e67dabba982","head":{"label":"schinckel:accessory-information","ref":"accessory-information","sha":"f47ef42051632c24ff0a939fb9793e67dabba982","user":{"login":"schinckel","id":23411,"avatar_url":"https://avatars1.githubusercontent.com/u/23411?v=4","gravatar_id":"","url":"https://api.github.com/users/schinckel","html_url":"https://github.com/schinckel","followers_url":"https://api.github.com/users/schinckel/followers","following_url":"https://api.github.com/users/schinckel/following{/other_user}","gists_url":"https://api.github.com/users/schinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/schinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schinckel/subscriptions","organizations_url":"https://api.github.com/users/schinckel/orgs","repos_url":"https://api.github.com/users/schinckel/repos","events_url":"https://api.github.com/users/schinckel/events{/privacy}","received_events_url":"https://api.github.com/users/schinckel/received_events","type":"User","site_admin":false},"repo":{"id":120272224,"name":"HAP-python","full_name":"schinckel/HAP-python","owner":{"login":"schinckel","id":23411,"avatar_url":"https://avatars1.githubusercontent.com/u/23411?v=4","gravatar_id":"","url":"https://api.github.com/users/schinckel","html_url":"https://github.com/schinckel","followers_url":"https://api.github.com/users/schinckel/followers","following_url":"https://api.github.com/users/schinckel/following{/other_user}","gists_url":"https://api.github.com/users/schinckel/gists{/gist_id}","starred_url":"https://api.github.com/users/schinckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schinckel/subscriptions","organizations_url":"https://api.github.com/users/schinckel/orgs","repos_url":"https://api.github.com/users/schinckel/repos","events_url":"https://api.github.com/users/schinckel/events{/privacy}","received_events_url":"https://api.github.com/users/schinckel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schinckel/HAP-python","description":"A python implementation of the HomeKit Accessory Protocol (HAP)","fork":true,"url":"https://api.github.com/repos/schinckel/HAP-python","forks_url":"https://api.github.com/repos/schinckel/HAP-python/forks","keys_url":"https://api.github.com/repos/schinckel/HAP-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schinckel/HAP-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schinckel/HAP-python/teams","hooks_url":"https://api.github.com/repos/schinckel/HAP-python/hooks","issue_events_url":"https://api.github.com/repos/schinckel/HAP-python/issues/events{/number}","events_url":"https://api.github.com/repos/schinckel/HAP-python/events","assignees_url":"https://api.github.com/repos/schinckel/HAP-python/assignees{/user}","branches_url":"https://api.github.com/repos/schinckel/HAP-python/branches{/branch}","tags_url":"https://api.github.com/repos/schinckel/HAP-python/tags","blobs_url":"https://api.github.com/repos/schinckel/HAP-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schinckel/HAP-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schinckel/HAP-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/schinckel/HAP-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schinckel/HAP-python/statuses/{sha}","languages_url":"https://api.github.com/repos/schinckel/HAP-python/languages","stargazers_url":"https://api.github.com/repos/schinckel/HAP-python/stargazers","contributors_url":"https://api.github.com/repos/schinckel/HAP-python/contributors","subscribers_url":"https://api.github.com/repos/schinckel/HAP-python/subscribers","subscription_url":"https://api.github.com/repos/schinckel/HAP-python/subscription","commits_url":"https://api.github.com/repos/schinckel/HAP-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/schinckel/HAP-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/schinckel/HAP-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/schinckel/HAP-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/schinckel/HAP-python/contents/{+path}","compare_url":"https://api.github.com/repos/schinckel/HAP-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schinckel/HAP-python/merges","archive_url":"https://api.github.com/repos/schinckel/HAP-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schinckel/HAP-python/downloads","issues_url":"https://api.github.com/repos/schinckel/HAP-python/issues{/number}","pulls_url":"https://api.github.com/repos/schinckel/HAP-python/pulls{/number}","milestones_url":"https://api.github.com/repos/schinckel/HAP-python/milestones{/number}","notifications_url":"https://api.github.com/repos/schinckel/HAP-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schinckel/HAP-python/labels{/name}","releases_url":"https://api.github.com/repos/schinckel/HAP-python/releases{/id}","deployments_url":"https://api.github.com/repos/schinckel/HAP-python/deployments","created_at":"2018-02-05T07:51:34Z","updated_at":"2018-02-05T07:51:36Z","pushed_at":"2018-02-17T21:45:30Z","git_url":"git://github.com/schinckel/HAP-python.git","ssh_url":"git@github.com:schinckel/HAP-python.git","clone_url":"https://github.com/schinckel/HAP-python.git","svn_url":"https://github.com/schinckel/HAP-python","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ikalchev:master","ref":"master","sha":"e17e875a4e99a755c30f33dee6bdd310736e0068","user":{"login":"ikalchev","id":25887324,"avatar_url":"https://avatars2.githubusercontent.com/u/25887324?v=4","gravatar_id":"","url":"https://api.github.com/users/ikalchev","html_url":"https://github.com/ikalchev","followers_url":"https://api.github.com/users/ikalchev/followers","following_url":"https://api.github.com/users/ikalchev/following{/other_user}","gists_url":"https://api.github.com/users/ikalchev/gists{/gist_id}","starred_url":"https://api.github.com/users/ikalchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikalchev/subscriptions","organizations_url":"https://api.github.com/users/ikalchev/orgs","repos_url":"https://api.github.com/users/ikalchev/repos","events_url":"https://api.github.com/users/ikalchev/events{/privacy}","received_events_url":"https://api.github.com/users/ikalchev/received_events","type":"User","site_admin":false},"repo":{"id":106929485,"name":"HAP-python","full_name":"ikalchev/HAP-python","owner":{"login":"ikalchev","id":25887324,"avatar_url":"https://avatars2.githubusercontent.com/u/25887324?v=4","gravatar_id":"","url":"https://api.github.com/users/ikalchev","html_url":"https://github.com/ikalchev","followers_url":"https://api.github.com/users/ikalchev/followers","following_url":"https://api.github.com/users/ikalchev/following{/other_user}","gists_url":"https://api.github.com/users/ikalchev/gists{/gist_id}","starred_url":"https://api.github.com/users/ikalchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikalchev/subscriptions","organizations_url":"https://api.github.com/users/ikalchev/orgs","repos_url":"https://api.github.com/users/ikalchev/repos","events_url":"https://api.github.com/users/ikalchev/events{/privacy}","received_events_url":"https://api.github.com/users/ikalchev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikalchev/HAP-python","description":"A python implementation of the HomeKit Accessory Protocol (HAP)","fork":false,"url":"https://api.github.com/repos/ikalchev/HAP-python","forks_url":"https://api.github.com/repos/ikalchev/HAP-python/forks","keys_url":"https://api.github.com/repos/ikalchev/HAP-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikalchev/HAP-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikalchev/HAP-python/teams","hooks_url":"https://api.github.com/repos/ikalchev/HAP-python/hooks","issue_events_url":"https://api.github.com/repos/ikalchev/HAP-python/issues/events{/number}","events_url":"https://api.github.com/repos/ikalchev/HAP-python/events","assignees_url":"https://api.github.com/repos/ikalchev/HAP-python/assignees{/user}","branches_url":"https://api.github.com/repos/ikalchev/HAP-python/branches{/branch}","tags_url":"https://api.github.com/repos/ikalchev/HAP-python/tags","blobs_url":"https://api.github.com/repos/ikalchev/HAP-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikalchev/HAP-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikalchev/HAP-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikalchev/HAP-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikalchev/HAP-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ikalchev/HAP-python/languages","stargazers_url":"https://api.github.com/repos/ikalchev/HAP-python/stargazers","contributors_url":"https://api.github.com/repos/ikalchev/HAP-python/contributors","subscribers_url":"https://api.github.com/repos/ikalchev/HAP-python/subscribers","subscription_url":"https://api.github.com/repos/ikalchev/HAP-python/subscription","commits_url":"https://api.github.com/repos/ikalchev/HAP-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikalchev/HAP-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikalchev/HAP-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikalchev/HAP-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikalchev/HAP-python/contents/{+path}","compare_url":"https://api.github.com/repos/ikalchev/HAP-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikalchev/HAP-python/merges","archive_url":"https://api.github.com/repos/ikalchev/HAP-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikalchev/HAP-python/downloads","issues_url":"https://api.github.com/repos/ikalchev/HAP-python/issues{/number}","pulls_url":"https://api.github.com/repos/ikalchev/HAP-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ikalchev/HAP-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ikalchev/HAP-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikalchev/HAP-python/labels{/name}","releases_url":"https://api.github.com/repos/ikalchev/HAP-python/releases{/id}","deployments_url":"https://api.github.com/repos/ikalchev/HAP-python/deployments","created_at":"2017-10-14T13:21:38Z","updated_at":"2018-02-18T02:19:15Z","pushed_at":"2018-02-18T09:17:22Z","git_url":"git://github.com/ikalchev/HAP-python.git","ssh_url":"git@github.com:ikalchev/HAP-python.git","clone_url":"https://github.com/ikalchev/HAP-python.git","svn_url":"https://github.com/ikalchev/HAP-python","homepage":null,"size":170,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":11,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41"},"html":{"href":"https://github.com/ikalchev/HAP-python/pull/41"},"issue":{"href":"https://api.github.com/repos/ikalchev/HAP-python/issues/41"},"comments":{"href":"https://api.github.com/repos/ikalchev/HAP-python/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ikalchev/HAP-python/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/ikalchev/HAP-python/statuses/f47ef42051632c24ff0a939fb9793e67dabba982"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ikalchev"}}