{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/206124937","pull_request_review_id":141522751,"id":206124937,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyNDkzNw==","diff_hunk":"@@ -576,13 +577,14 @@ def externals\n   end\n \n   def fetch_repo(target, url, revision = nil, ignore_externals = false)\n-    # Use \"svn up\" when the repository already exists locally.\n+    # Use \"svn update\" when the repository already exists locally.\n     # This saves on bandwidth and will have a similar effect to verifying the\n     # cache as it will make any changes to get the right revision.\n-    svncommand = target.directory? ? \"up\" : \"checkout\"\n-    args = [\"svn\", svncommand]\n-    args << url unless target.directory?\n-    args << target\n+    args = if target.directory?\n+      [\"cd\", target.to_s, \";\", \"svn\", \"update\"]","path":"Library/Homebrew/download_strategy.rb","position":null,"original_position":36,"commit_id":"c63d8813afe0be383d3aa98adb11112869a71122","original_commit_id":"43d53a67b772a4a08748dc58e4b23f51b78fbd59","user":{"login":"ffeu","id":13699202,"node_id":"MDQ6VXNlcjEzNjk5MjAy","avatar_url":"https://avatars0.githubusercontent.com/u/13699202?v=4","gravatar_id":"","url":"https://api.github.com/users/ffeu","html_url":"https://github.com/ffeu","followers_url":"https://api.github.com/users/ffeu/followers","following_url":"https://api.github.com/users/ffeu/following{/other_user}","gists_url":"https://api.github.com/users/ffeu/gists{/gist_id}","starred_url":"https://api.github.com/users/ffeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffeu/subscriptions","organizations_url":"https://api.github.com/users/ffeu/orgs","repos_url":"https://api.github.com/users/ffeu/repos","events_url":"https://api.github.com/users/ffeu/events{/privacy}","received_events_url":"https://api.github.com/users/ffeu/received_events","type":"User","site_admin":false},"body":"That's what I meant with my last comment, I wanted to check because of the\r\ncheck ```if args[0] == \"update\"```...","created_at":"2018-07-30T13:05:28Z","updated_at":"2018-07-30T13:05:29Z","html_url":"https://github.com/Homebrew/brew/pull/4551#discussion_r206124937","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/4551","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/206124937"},"html":{"href":"https://github.com/Homebrew/brew/pull/4551#discussion_r206124937"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4551"}},"in_reply_to_id":206069777},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/4551","id":203949475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTQ5NDc1","html_url":"https://github.com/Homebrew/brew/pull/4551","diff_url":"https://github.com/Homebrew/brew/pull/4551.diff","patch_url":"https://github.com/Homebrew/brew/pull/4551.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/4551","number":4551,"state":"open","locked":false,"title":"Adjusting SVN commands to consider the @ symbol","user":{"login":"ffeu","id":13699202,"node_id":"MDQ6VXNlcjEzNjk5MjAy","avatar_url":"https://avatars0.githubusercontent.com/u/13699202?v=4","gravatar_id":"","url":"https://api.github.com/users/ffeu","html_url":"https://github.com/ffeu","followers_url":"https://api.github.com/users/ffeu/followers","following_url":"https://api.github.com/users/ffeu/following{/other_user}","gists_url":"https://api.github.com/users/ffeu/gists{/gist_id}","starred_url":"https://api.github.com/users/ffeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffeu/subscriptions","organizations_url":"https://api.github.com/users/ffeu/orgs","repos_url":"https://api.github.com/users/ffeu/repos","events_url":"https://api.github.com/users/ffeu/events{/privacy}","received_events_url":"https://api.github.com/users/ffeu/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/PATH_spec.rb).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\n### Details\r\n\r\nThis is another approach to solve problem presented by the #4358 PR.\r\n\r\nSubversion uses '@' to point to a specific revision, so when creating formulas with an @ symbol, the local svn path inherits that character and Subversion gets confused.\r\n\r\nBasically, an [additional @ at the end solves it](https://stackoverflow.com/a/757510/796963). So no need to change the paths, it's justing changing the commands.\r\n\r\nHowever, this is not consistent through all commands. The commands are affected as follows:\r\n\r\n```\r\nsvn checkout url1 foo@a   # properly checks out url1 to foo@a\r\nsvn switch url2 foo@a     # properly switchs foo@a to url2\r\nsvn update foo@a@         # properly updates foo@a \r\nsvn info foo@a@           # properly obtains info on foo@a \r\nsvn export foo@a@ newdir  # properly export foo@a contents to newdir\r\n```\r\n\r\nAs previously discussed in the #4358 PR, this approach:\r\n - affects only SVN resources;\r\n - doesn't change current path used for svn repositories\r\n - it's expected to NOT interfere with cleanup or mirror\r\n\r\n```brew style``` is OK with my changes, but there were warnings unrelated to this PR.\r\n\r\n### Disclaimer\r\n\r\nI kindly request **special attention** reviewing this PR, as my ruby experience is equal to 28 lines of code (this PR). :)\r\n","created_at":"2018-07-25T20:11:35Z","updated_at":"2018-07-30T13:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0930f39957458ef4931404f8c8602421c8c10c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/4551/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/4551/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/4551/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/c63d8813afe0be383d3aa98adb11112869a71122","head":{"label":"ffeu:fix_svn_with_at_symbol","ref":"fix_svn_with_at_symbol","sha":"c63d8813afe0be383d3aa98adb11112869a71122","user":{"login":"ffeu","id":13699202,"node_id":"MDQ6VXNlcjEzNjk5MjAy","avatar_url":"https://avatars0.githubusercontent.com/u/13699202?v=4","gravatar_id":"","url":"https://api.github.com/users/ffeu","html_url":"https://github.com/ffeu","followers_url":"https://api.github.com/users/ffeu/followers","following_url":"https://api.github.com/users/ffeu/following{/other_user}","gists_url":"https://api.github.com/users/ffeu/gists{/gist_id}","starred_url":"https://api.github.com/users/ffeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffeu/subscriptions","organizations_url":"https://api.github.com/users/ffeu/orgs","repos_url":"https://api.github.com/users/ffeu/repos","events_url":"https://api.github.com/users/ffeu/events{/privacy}","received_events_url":"https://api.github.com/users/ffeu/received_events","type":"User","site_admin":false},"repo":{"id":142344472,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNDQ0NzI=","name":"brew","full_name":"ffeu/brew","owner":{"login":"ffeu","id":13699202,"node_id":"MDQ6VXNlcjEzNjk5MjAy","avatar_url":"https://avatars0.githubusercontent.com/u/13699202?v=4","gravatar_id":"","url":"https://api.github.com/users/ffeu","html_url":"https://github.com/ffeu","followers_url":"https://api.github.com/users/ffeu/followers","following_url":"https://api.github.com/users/ffeu/following{/other_user}","gists_url":"https://api.github.com/users/ffeu/gists{/gist_id}","starred_url":"https://api.github.com/users/ffeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffeu/subscriptions","organizations_url":"https://api.github.com/users/ffeu/orgs","repos_url":"https://api.github.com/users/ffeu/repos","events_url":"https://api.github.com/users/ffeu/events{/privacy}","received_events_url":"https://api.github.com/users/ffeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ffeu/brew","description":"🍺 The missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/ffeu/brew","forks_url":"https://api.github.com/repos/ffeu/brew/forks","keys_url":"https://api.github.com/repos/ffeu/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ffeu/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ffeu/brew/teams","hooks_url":"https://api.github.com/repos/ffeu/brew/hooks","issue_events_url":"https://api.github.com/repos/ffeu/brew/issues/events{/number}","events_url":"https://api.github.com/repos/ffeu/brew/events","assignees_url":"https://api.github.com/repos/ffeu/brew/assignees{/user}","branches_url":"https://api.github.com/repos/ffeu/brew/branches{/branch}","tags_url":"https://api.github.com/repos/ffeu/brew/tags","blobs_url":"https://api.github.com/repos/ffeu/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ffeu/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ffeu/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/ffeu/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ffeu/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/ffeu/brew/languages","stargazers_url":"https://api.github.com/repos/ffeu/brew/stargazers","contributors_url":"https://api.github.com/repos/ffeu/brew/contributors","subscribers_url":"https://api.github.com/repos/ffeu/brew/subscribers","subscription_url":"https://api.github.com/repos/ffeu/brew/subscription","commits_url":"https://api.github.com/repos/ffeu/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/ffeu/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/ffeu/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/ffeu/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/ffeu/brew/contents/{+path}","compare_url":"https://api.github.com/repos/ffeu/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ffeu/brew/merges","archive_url":"https://api.github.com/repos/ffeu/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ffeu/brew/downloads","issues_url":"https://api.github.com/repos/ffeu/brew/issues{/number}","pulls_url":"https://api.github.com/repos/ffeu/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/ffeu/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/ffeu/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ffeu/brew/labels{/name}","releases_url":"https://api.github.com/repos/ffeu/brew/releases{/id}","deployments_url":"https://api.github.com/repos/ffeu/brew/deployments","created_at":"2018-07-25T19:26:51Z","updated_at":"2018-07-25T19:26:56Z","pushed_at":"2018-07-30T13:05:15Z","git_url":"git://github.com/ffeu/brew.git","ssh_url":"git@github.com:ffeu/brew.git","clone_url":"https://github.com/ffeu/brew.git","svn_url":"https://github.com/ffeu/brew","homepage":"https://brew.sh","size":24738,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"a1f0ff43220023f1af9747574a7edaf28d4563ad","user":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"node_id":"MDEwOlJlcG9zaXRvcnk1MzIzODgxMw==","name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":"🍺 The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2018-07-30T13:03:31Z","pushed_at":"2018-07-30T13:05:16Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"https://brew.sh","size":24735,"stargazers_count":13165,"watchers_count":13165,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3036,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":3036,"open_issues":35,"watchers":13165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4551"},"html":{"href":"https://github.com/Homebrew/brew/pull/4551"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/4551"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/4551/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4551/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4551/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/c63d8813afe0be383d3aa98adb11112869a71122"}},"author_association":"NONE"}}
{"actor":{"display_login":"ffeu"}}