{"action":"opened","number":200,"pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200","id":230191042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTkxMDQy","html_url":"https://github.com/alphagov/notifications-ftp/pull/200","diff_url":"https://github.com/alphagov/notifications-ftp/pull/200.diff","patch_url":"https://github.com/alphagov/notifications-ftp/pull/200.patch","issue_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/200","number":200,"state":"open","locked":false,"title":"Check file exists after an exception","user":{"login":"servingUpAces","id":4282990,"node_id":"MDQ6VXNlcjQyODI5OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4282990?v=4","gravatar_id":"","url":"https://api.github.com/users/servingUpAces","html_url":"https://github.com/servingUpAces","followers_url":"https://api.github.com/users/servingUpAces/followers","following_url":"https://api.github.com/users/servingUpAces/following{/other_user}","gists_url":"https://api.github.com/users/servingUpAces/gists{/gist_id}","starred_url":"https://api.github.com/users/servingUpAces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servingUpAces/subscriptions","organizations_url":"https://api.github.com/users/servingUpAces/orgs","repos_url":"https://api.github.com/users/servingUpAces/repos","events_url":"https://api.github.com/users/servingUpAces/events{/privacy}","received_events_url":"https://api.github.com/users/servingUpAces/received_events","type":"User","site_admin":false},"body":"On November 6, we got a few exceptions when sending the files to DVLA, this resulted in us sending the files 2 or 3 times (resulting in sending over 10,000 extra letters).\r\n\r\nLuckily they noticed that some of files were duplicate.\r\nThis PR tries to prevent that by checking the file exists with the right name and size on the remote server.","created_at":"2018-11-12T16:19:07Z","updated_at":"2018-11-12T16:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200/commits","review_comments_url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200/comments","review_comment_url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/200/comments","statuses_url":"https://api.github.com/repos/alphagov/notifications-ftp/statuses/6a77d10ced999ad54e3e653aafc57c93e9fca1cf","head":{"label":"alphagov:check-file-exists-after-exception","ref":"check-file-exists-after-exception","sha":"6a77d10ced999ad54e3e653aafc57c93e9fca1cf","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":59823639,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgyMzYzOQ==","name":"notifications-ftp","full_name":"alphagov/notifications-ftp","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/notifications-ftp","description":"Sends letters from GOV.UK Notify to DVLA over FTP","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-ftp","forks_url":"https://api.github.com/repos/alphagov/notifications-ftp/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-ftp/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-ftp/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-ftp/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-ftp/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-ftp/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-ftp/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-ftp/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-ftp/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-ftp/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-ftp/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-ftp/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-ftp/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-ftp/deployments","created_at":"2016-05-27T09:41:19Z","updated_at":"2018-07-13T13:52:48Z","pushed_at":"2018-11-12T16:18:36Z","git_url":"git://github.com/alphagov/notifications-ftp.git","ssh_url":"git@github.com:alphagov/notifications-ftp.git","clone_url":"https://github.com/alphagov/notifications-ftp.git","svn_url":"https://github.com/alphagov/notifications-ftp","homepage":"","size":210,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"2cf80301204b1a6d0117d6e23bf909f03f964d5b","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":59823639,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgyMzYzOQ==","name":"notifications-ftp","full_name":"alphagov/notifications-ftp","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/notifications-ftp","description":"Sends letters from GOV.UK Notify to DVLA over FTP","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-ftp","forks_url":"https://api.github.com/repos/alphagov/notifications-ftp/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-ftp/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-ftp/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-ftp/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-ftp/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-ftp/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-ftp/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-ftp/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-ftp/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-ftp/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-ftp/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-ftp/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-ftp/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-ftp/deployments","created_at":"2016-05-27T09:41:19Z","updated_at":"2018-07-13T13:52:48Z","pushed_at":"2018-11-12T16:18:36Z","git_url":"git://github.com/alphagov/notifications-ftp.git","ssh_url":"git@github.com:alphagov/notifications-ftp.git","clone_url":"https://github.com/alphagov/notifications-ftp.git","svn_url":"https://github.com/alphagov/notifications-ftp","homepage":"","size":210,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200"},"html":{"href":"https://github.com/alphagov/notifications-ftp/pull/200"},"issue":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/issues/200"},"comments":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/notifications-ftp/statuses/6a77d10ced999ad54e3e653aafc57c93e9fca1cf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"servingUpAces"}}