{"action":"closed","number":3697,"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697","id":222201609,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjAxNjA5","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3697","diff_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3697.diff","patch_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3697.patch","issue_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3697","number":3697,"state":"closed","locked":false,"title":"Fix button URLs to work in unmanaged NPSP","user":{"login":"davisagli","id":49014,"node_id":"MDQ6VXNlcjQ5MDE0","avatar_url":"https://avatars0.githubusercontent.com/u/49014?v=4","gravatar_id":"","url":"https://api.github.com/users/davisagli","html_url":"https://github.com/davisagli","followers_url":"https://api.github.com/users/davisagli/followers","following_url":"https://api.github.com/users/davisagli/following{/other_user}","gists_url":"https://api.github.com/users/davisagli/gists{/gist_id}","starred_url":"https://api.github.com/users/davisagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisagli/subscriptions","organizations_url":"https://api.github.com/users/davisagli/orgs","repos_url":"https://api.github.com/users/davisagli/repos","events_url":"https://api.github.com/users/davisagli/events{/privacy}","received_events_url":"https://api.github.com/users/davisagli/received_events","type":"User","site_admin":false},"body":"This adds a new Package_Settings__c custom setting object with a Namespace_Prefix__c field,\r\nand uses it to get the namespace for use in Cumulus' own button URLs.\r\nThe goal is to have buttons linking to VF pages that work in both managed and unmanaged deployments of NPSP.\r\n\r\nFor managed NPSP, the setting is initialized in the STG_InstallScript after installation or push upgrades.\r\nFor unmanaged NPSP, the setting is initialized in the anon apex run by the `npsp_default_settings` CCI task.\r\n\r\nThe new setting object is set as Protected because to use it from outside the package you would need to already know the namespace.\r\n\r\nWe should be sure to test this as a beta release to make sure there are no surprises.\r\n\r\n# Critical Changes\r\n\r\n# Changes\r\n\r\n# Issues Closed\r\n\r\n# New Metadata\r\n\r\n# Deleted Metadata\r\n","created_at":"2018-10-11T16:27:02Z","updated_at":"2018-10-12T16:14:36Z","closed_at":"2018-10-12T16:14:36Z","merged_at":"2018-10-12T16:14:36Z","merge_commit_sha":"c39224d110161cf737aaae85bde5fb0906ef71ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cdcarter","id":164,"node_id":"MDQ6VXNlcjE2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/164?v=4","gravatar_id":"","url":"https://api.github.com/users/cdcarter","html_url":"https://github.com/cdcarter","followers_url":"https://api.github.com/users/cdcarter/followers","following_url":"https://api.github.com/users/cdcarter/following{/other_user}","gists_url":"https://api.github.com/users/cdcarter/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcarter/subscriptions","organizations_url":"https://api.github.com/users/cdcarter/orgs","repos_url":"https://api.github.com/users/cdcarter/repos","events_url":"https://api.github.com/users/cdcarter/events{/privacy}","received_events_url":"https://api.github.com/users/cdcarter/received_events","type":"User","site_admin":false},{"login":"lmeerkatz","id":2000501,"node_id":"MDQ6VXNlcjIwMDA1MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2000501?v=4","gravatar_id":"","url":"https://api.github.com/users/lmeerkatz","html_url":"https://github.com/lmeerkatz","followers_url":"https://api.github.com/users/lmeerkatz/followers","following_url":"https://api.github.com/users/lmeerkatz/following{/other_user}","gists_url":"https://api.github.com/users/lmeerkatz/gists{/gist_id}","starred_url":"https://api.github.com/users/lmeerkatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmeerkatz/subscriptions","organizations_url":"https://api.github.com/users/lmeerkatz/orgs","repos_url":"https://api.github.com/users/lmeerkatz/repos","events_url":"https://api.github.com/users/lmeerkatz/events{/privacy}","received_events_url":"https://api.github.com/users/lmeerkatz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697/commits","review_comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697/comments","review_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3697/comments","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/6d5b4d8c234b3e8408df45d241b9c461b99696c1","head":{"label":"SalesforceFoundation:feature/button-url-namespace","ref":"feature/button-url-namespace","sha":"6d5b4d8c234b3e8408df45d241b9c461b99696c1","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-10-12T04:04:13Z","pushed_at":"2018-10-12T16:14:36Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":92400,"stargazers_count":275,"watchers_count":275,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":204,"open_issues":317,"watchers":275,"default_branch":"master"}},"base":{"label":"SalesforceFoundation:master","ref":"master","sha":"f168c3f55a36391431f9086d4baf45401910f359","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-10-12T04:04:13Z","pushed_at":"2018-10-12T16:14:36Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":92400,"stargazers_count":275,"watchers_count":275,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":204,"open_issues":317,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3697"},"issue":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3697"},"comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3697/comments"},"review_comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697/comments"},"review_comment":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3697/commits"},"statuses":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/6d5b4d8c234b3e8408df45d241b9c461b99696c1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davisagli","id":49014,"node_id":"MDQ6VXNlcjQ5MDE0","avatar_url":"https://avatars0.githubusercontent.com/u/49014?v=4","gravatar_id":"","url":"https://api.github.com/users/davisagli","html_url":"https://github.com/davisagli","followers_url":"https://api.github.com/users/davisagli/followers","following_url":"https://api.github.com/users/davisagli/following{/other_user}","gists_url":"https://api.github.com/users/davisagli/gists{/gist_id}","starred_url":"https://api.github.com/users/davisagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisagli/subscriptions","organizations_url":"https://api.github.com/users/davisagli/orgs","repos_url":"https://api.github.com/users/davisagli/repos","events_url":"https://api.github.com/users/davisagli/events{/privacy}","received_events_url":"https://api.github.com/users/davisagli/received_events","type":"User","site_admin":false},"comments":1,"review_comments":19,"maintainer_can_modify":false,"commits":2,"additions":69,"deletions":42,"changed_files":9}}
{"actor":{"display_login":"davisagli"}}