{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/244736734","pull_request_review_id":188673946,"id":244736734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDczNjczNA==","diff_hunk":"@@ -204,22 +210,59 @@ synchronized void shutdown() {\n     @Override\n     public synchronized void onCancelled() {\n         logger.info(\n-                \"Received cancellation request for data frame job [\" + job.getConfig().getId() + \"], state: [\" + indexer.getState() + \"]\");\n+                \"Received cancellation request for data frame job [\" + job.getId() + \"], state: [\" + indexer.getState() + \"]\");\n         if (indexer.abort()) {\n             // there is no background job running, we can shutdown safely\n             shutdown();\n         }\n     }\n \n     protected class ClientDataFrameIndexer extends DataFrameIndexer {\n+        private static final int LOAD_JOB_TIMEOUT_IN_SECONDS = 30;\n         private final Client client;\n+        private final DataFrameJobConfigManager jobConfigManager;\n+        private final String jobId;\n+\n+        private DataFrameJobConfig jobConfig = null;\n \n-        public ClientDataFrameIndexer(DataFrameJob job, AtomicReference<IndexerState> initialState,\n+        public ClientDataFrameIndexer(String jobId, DataFrameJobConfigManager jobConfigManager, AtomicReference<IndexerState> initialState,\n                 Map<String, Object> initialPosition, Client client) {\n-            super(threadPool.executor(ThreadPool.Names.GENERIC), job, initialState, initialPosition);\n+            super(threadPool.executor(ThreadPool.Names.GENERIC), initialState, initialPosition);\n+            this.jobId = jobId;\n+            this.jobConfigManager = jobConfigManager;\n             this.client = client;\n         }\n \n+        @Override\n+        protected DataFrameJobConfig getConfig() {\n+            return jobConfig;\n+        }\n+\n+        @Override\n+        protected String getJobId() {\n+            return jobId;\n+        }\n+\n+        @Override\n+        public synchronized boolean maybeTriggerAsyncJob(long now) {\n+            if (jobConfig == null) {\n+                CountDownLatch latch = new CountDownLatch(1);","path":"x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/job/DataFrameJobTask.java","position":196,"original_position":196,"commit_id":"22116c44a50f114a18c08611293cead0ecb714e4","original_commit_id":"e617abe5b46756bccc331324c357c61ece3e8caa","user":{"login":"benwtrent","id":4357155,"node_id":"MDQ6VXNlcjQzNTcxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4357155?v=4","gravatar_id":"","url":"https://api.github.com/users/benwtrent","html_url":"https://github.com/benwtrent","followers_url":"https://api.github.com/users/benwtrent/followers","following_url":"https://api.github.com/users/benwtrent/following{/other_user}","gists_url":"https://api.github.com/users/benwtrent/gists{/gist_id}","starred_url":"https://api.github.com/users/benwtrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwtrent/subscriptions","organizations_url":"https://api.github.com/users/benwtrent/orgs","repos_url":"https://api.github.com/users/benwtrent/repos","events_url":"https://api.github.com/users/benwtrent/events{/privacy}","received_events_url":"https://api.github.com/users/benwtrent/received_events","type":"User","site_admin":false},"body":"I am not sure how this latch is ever counted down. Maybe you should use a `LatchedActionListener`?","created_at":"2019-01-02T13:34:54Z","updated_at":"2019-01-02T13:37:00Z","html_url":"https://github.com/elastic/elasticsearch/pull/37068#discussion_r244736734","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/244736734"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/37068#discussion_r244736734"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068","id":241707466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzA3NDY2","html_url":"https://github.com/elastic/elasticsearch/pull/37068","diff_url":"https://github.com/elastic/elasticsearch/pull/37068.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/37068.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/37068","number":37068,"state":"open","locked":false,"title":"[ML-DataFrame] Feature/fib jobconfigmanager","user":{"login":"hendrikmuhs","id":7126422,"node_id":"MDQ6VXNlcjcxMjY0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7126422?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikmuhs","html_url":"https://github.com/hendrikmuhs","followers_url":"https://api.github.com/users/hendrikmuhs/followers","following_url":"https://api.github.com/users/hendrikmuhs/following{/other_user}","gists_url":"https://api.github.com/users/hendrikmuhs/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikmuhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikmuhs/subscriptions","organizations_url":"https://api.github.com/users/hendrikmuhs/orgs","repos_url":"https://api.github.com/users/hendrikmuhs/repos","events_url":"https://api.github.com/users/hendrikmuhs/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikmuhs/received_events","type":"User","site_admin":false},"body":"**Feature Branch PR**\r\n\r\nstore configurations in an index rather than the cluster state\r\n\r\nNotes:\r\n\r\n- breaking change (for the feature branch, breaks if you try to upgrade cluster with old jobs in the cluster state)\r\n- the cluster state only holds the job id's, configurations are stored in the internal index\r\n- configuration is lazily loaded","created_at":"2019-01-02T09:59:24Z","updated_at":"2019-01-02T13:37:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"302979e9d384251115afdec9277e71759b1a8196","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":912833043,"node_id":"MDU6TGFiZWw5MTI4MzMwNDM=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:ml","name":":ml","color":"0e8a16","default":false},{"id":23172,"node_id":"MDU6TGFiZWwyMzE3Mg==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Efeature","name":">feature","color":"006b75","default":false},{"id":130371191,"node_id":"MDU6TGFiZWwxMzAzNzExOTE=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/WIP","name":"WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/37068/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/22116c44a50f114a18c08611293cead0ecb714e4","head":{"label":"hendrikmuhs:feature/fib-jobconfigmanager","ref":"feature/fib-jobconfigmanager","sha":"22116c44a50f114a18c08611293cead0ecb714e4","user":{"login":"hendrikmuhs","id":7126422,"node_id":"MDQ6VXNlcjcxMjY0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7126422?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikmuhs","html_url":"https://github.com/hendrikmuhs","followers_url":"https://api.github.com/users/hendrikmuhs/followers","following_url":"https://api.github.com/users/hendrikmuhs/following{/other_user}","gists_url":"https://api.github.com/users/hendrikmuhs/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikmuhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikmuhs/subscriptions","organizations_url":"https://api.github.com/users/hendrikmuhs/orgs","repos_url":"https://api.github.com/users/hendrikmuhs/repos","events_url":"https://api.github.com/users/hendrikmuhs/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikmuhs/received_events","type":"User","site_admin":false},"repo":{"id":78730585,"node_id":"MDEwOlJlcG9zaXRvcnk3ODczMDU4NQ==","name":"elasticsearch","full_name":"hendrikmuhs/elasticsearch","private":false,"owner":{"login":"hendrikmuhs","id":7126422,"node_id":"MDQ6VXNlcjcxMjY0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7126422?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikmuhs","html_url":"https://github.com/hendrikmuhs","followers_url":"https://api.github.com/users/hendrikmuhs/followers","following_url":"https://api.github.com/users/hendrikmuhs/following{/other_user}","gists_url":"https://api.github.com/users/hendrikmuhs/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikmuhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikmuhs/subscriptions","organizations_url":"https://api.github.com/users/hendrikmuhs/orgs","repos_url":"https://api.github.com/users/hendrikmuhs/repos","events_url":"https://api.github.com/users/hendrikmuhs/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikmuhs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hendrikmuhs/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/hendrikmuhs/elasticsearch","forks_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/forks","keys_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/teams","hooks_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/events","assignees_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/tags","blobs_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/subscription","commits_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/merges","archive_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/downloads","issues_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/hendrikmuhs/elasticsearch/deployments","created_at":"2017-01-12T09:48:40Z","updated_at":"2018-08-08T15:21:17Z","pushed_at":"2019-01-02T13:20:23Z","git_url":"git://github.com/hendrikmuhs/elasticsearch.git","ssh_url":"git@github.com:hendrikmuhs/elasticsearch.git","clone_url":"https://github.com/hendrikmuhs/elasticsearch.git","svn_url":"https://github.com/hendrikmuhs/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":505749,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:feature/fib","ref":"feature/fib","sha":"7010273f1bc98d0c87cff56c1bc2ccadaa433c12","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2019-01-02T13:16:11Z","pushed_at":"2019-01-02T13:29:43Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":548948,"stargazers_count":37266,"watchers_count":37266,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12537,"mirror_url":null,"archived":false,"open_issues_count":1889,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12537,"open_issues":1889,"watchers":37266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/37068"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/37068"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/37068/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/37068/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/22116c44a50f114a18c08611293cead0ecb714e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benwtrent"}}