{"action":"created","issue":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/1786","repository_url":"https://api.github.com/repos/apache/bookkeeper","labels_url":"https://api.github.com/repos/apache/bookkeeper/issues/1786/labels{/name}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1786/comments","events_url":"https://api.github.com/repos/apache/bookkeeper/issues/1786/events","html_url":"https://github.com/apache/bookkeeper/pull/1786","id":377595756,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTAxNzU0","number":1786,"title":"BP-36: Stats documentation annotation","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"labels":[{"id":821712023,"node_id":"MDU6TGFiZWw4MjE3MTIwMjM=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/stats","name":"area/stats","color":"f9d0c4","default":false},{"id":710081965,"node_id":"MDU6TGFiZWw3MTAwODE5NjU=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/tools","name":"area/tools","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"assignees":[{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/bookkeeper/milestones/5","html_url":"https://github.com/apache/bookkeeper/milestone/5","labels_url":"https://api.github.com/repos/apache/bookkeeper/milestones/5/labels","id":3566485,"node_id":"MDk6TWlsZXN0b25lMzU2NjQ4NQ==","number":5,"title":"4.9.0","description":"Release 4.9.0","creator":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":124,"state":"open","created_at":"2018-08-13T18:10:09Z","updated_at":"2018-11-07T09:07:43Z","due_on":"2018-11-15T08:00:00Z","closed_at":null},"comments":5,"created_at":"2018-11-05T21:44:59Z","updated_at":"2018-11-07T23:48:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1786","html_url":"https://github.com/apache/bookkeeper/pull/1786","diff_url":"https://github.com/apache/bookkeeper/pull/1786.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1786.patch"},"body":"\r\n\r\nDescriptions of the changes in this PR:\r\n\r\n*Motivation*\r\n\r\nA common ask from people using bookkeeper is how they can monitor bookies and bookkeeper clients, what kind of metrics that bookkeeper exposes\r\nand what are the important metrics. Currently bookkeeper doesn't provide any metrics page for guiding people on monitoring bookkeeper services.\r\n\r\nIn order to help people on this, we need to provide a few documentation pages about metrics. However if we just write such pages, those pages\r\ncan quickly get out-of-dated when code is changed. The proposal here is to seek a programming way for generating metrics related pages.\r\n\r\nMaster Issue: #1785\r\n\r\n> ---\r\n> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit\r\n> checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all\r\n> the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You\r\n> can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if\r\n> you are not sure, committers will help you:\r\n>\r\n> - [ ] [skip bookkeeper-server bookie tests]: skip testing `org.apache.bookkeeper.bookie` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server client tests]: skip testing `org.apache.bookkeeper.client` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server replication tests]: skip testing `org.apache.bookkeeper.replication` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server tls tests]: skip testing `org.apache.bookkeeper.tls` in bookkeeper-server module.\r\n> - [ ] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.\r\n> - [ ] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.\r\n> - [ ] [skip build java8]: skip build on java8. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> - [ ] [skip build java9]: skip build on java9. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> ---\r\n\r\n> ---\r\n> Be sure to do all of the following to help us incorporate your contribution\r\n> quickly and easily:\r\n>\r\n> If this PR is a BookKeeper Proposal (BP):\r\n>\r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<BP-#>: Description of bookkeeper proposal`\r\n>     `e.g. BP-1: 64 bits ledger is support`\r\n> - [ ] Attach the master issue link in the description of this PR.\r\n> - [ ] Attach the google doc link if the BP is written in Google Doc.\r\n>\r\n> Otherwise:\r\n> \r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<Issue #>: Description of pull request`\r\n>     `e.g. Issue 123: Description ...`\r\n> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.\r\n> - [ ] Replace `<Issue #>` in the title with the actual Issue number.\r\n> \r\n> ---\r\n"},"comment":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/comments/436820287","html_url":"https://github.com/apache/bookkeeper/pull/1786#issuecomment-436820287","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1786","id":436820287,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjgyMDI4Nw==","user":{"login":"dlg99","id":8622884,"node_id":"MDQ6VXNlcjg2MjI4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T23:48:25Z","updated_at":"2018-11-07T23:48:25Z","author_association":"CONTRIBUTOR","body":"@sijie i.e. addEntry does bookieAddEntry and journalAddEntry so it is a parent for both.\r\nate the same time we want to show that bookieAddEntry happens before journalAddEntry to i.e. order these metrics correctly in the documentation and describe the sequence fo events there.\r\n\r\nparent defines hierarchy and happensAfter simply orders sequence of siblings."}}
{"actor":{"display_login":"dlg99"}}