{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/5498","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/5498/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/5498/comments","events_url":"https://api.github.com/repos/istio/istio/issues/5498/events","html_url":"https://github.com/istio/istio/issues/5498","id":321535796,"node_id":"MDU6SXNzdWUzMjE1MzU3OTY=","number":5498,"title":"A model.Service is built from each address of a ServiceEntry","user":{"login":"vadimeisenbergibm","id":16784982,"node_id":"MDQ6VXNlcjE2Nzg0OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"labels":[{"id":735781806,"node_id":"MDU6TGFiZWw3MzU3ODE4MDY=","url":"https://api.github.com/repos/istio/istio/labels/area/networking","name":"area/networking","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"vadimeisenbergibm","id":16784982,"node_id":"MDQ6VXNlcjE2Nzg0OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false},"assignees":[{"login":"vadimeisenbergibm","id":16784982,"node_id":"MDQ6VXNlcjE2Nzg0OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-09T11:38:33Z","updated_at":"2018-05-30T20:04:23Z","closed_at":null,"author_association":"MEMBER","body":"There is a mismatch between the pilot model of a Service with a single `Address` or a map of `Addresses`, an address per cluster, https://github.com/istio/istio/blob/release-0.8/pilot/pkg/model/service.go#L53, and the definition of the ServiceEntry https://github.com/istio/api/blob/master/networking/v1alpha3/service_entry.proto#L170.\r\n\r\nCurrently, a model.Service is built from each address of ServiceEntry.\r\n\r\nA possible  renaming: rename model's  `Addresses` into `ClusterAddresses`, and `Address` into `Addresses`. Then take the `Addresses` into account in the code that builds tcp proxy filters - https://github.com/istio/istio/blob/release-0.8/pilot/pkg/networking/core/v1alpha3/listener.go#L381 ."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/393299447","html_url":"https://github.com/istio/istio/issues/5498#issuecomment-393299447","issue_url":"https://api.github.com/repos/istio/istio/issues/5498","id":393299447,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzI5OTQ0Nw==","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T20:04:23Z","updated_at":"2018-05-30T20:04:23Z","author_association":"MEMBER","body":"Service entry is essentially model.service exposed as crd. And we are essentially doing what you suggest. Convert everything into a simple model.service for consumption everywhere. "}}
{"actor":{"display_login":"rshriram"}}