{"action":"opened","number":732,"pull_request":{"url":"https://api.github.com/repos/crawl/crawl/pulls/732","id":180683992,"html_url":"https://github.com/crawl/crawl/pull/732","diff_url":"https://github.com/crawl/crawl/pull/732.diff","patch_url":"https://github.com/crawl/crawl/pull/732.patch","issue_url":"https://api.github.com/repos/crawl/crawl/issues/732","number":732,"state":"open","locked":false,"title":"Make Zonguldrok's Shrine non-trivial (take 2)","user":{"login":"NormalPerson7","id":37064413,"avatar_url":"https://avatars1.githubusercontent.com/u/37064413?v=4","gravatar_id":"","url":"https://api.github.com/users/NormalPerson7","html_url":"https://github.com/NormalPerson7","followers_url":"https://api.github.com/users/NormalPerson7/followers","following_url":"https://api.github.com/users/NormalPerson7/following{/other_user}","gists_url":"https://api.github.com/users/NormalPerson7/gists{/gist_id}","starred_url":"https://api.github.com/users/NormalPerson7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NormalPerson7/subscriptions","organizations_url":"https://api.github.com/users/NormalPerson7/orgs","repos_url":"https://api.github.com/users/NormalPerson7/repos","events_url":"https://api.github.com/users/NormalPerson7/events{/privacy}","received_events_url":"https://api.github.com/users/NormalPerson7/received_events","type":"User","site_admin":false},"body":"For a long time now, Zonguldrok's Shrine has been one of the easiest wizlabs. It has killed a meagre 21 players since the release of 0.20, compared to Lehudib's which has over 70 kills. This pull request aims to fix this by making the spawns over time from the gravestones on the outside much more dangerous, and create a more challenging boss battle. There were three stages to this:\r\n\r\n**Buff the boss battle**: add two extra liches in addition to the antique lich when moving towards the loot.\r\n**Buff and vary the derived undead**. Instead of three possible derived undead, there are now nine base types which can each spawn as zombies, simulacra or spectral things - which base type spawns is dependent on the tier of spawn, which increases over number of spawns already made.\r\n**Buff and vary the non-derived undead.** Instead of four possible derived undead, there are now thirteen, which have a variety of different powers: invisibility, hexes, MR/2 attacks, slowing attacks, fearsome and vampiric melee, summoning and offensive spells, as opposed to the skeletal warriors and 1 ancient champion that were the most dangerous things that spawned previously.\r\n\r\nPlease could you provide general feedback where possible, in addition to specific feedback regarding:\r\n(a) Code style: feel free to tell me how the code could be clearer or more efficient;\r\n(b) Is the boss battle too dangerous now, and would there be something more fitting other than more liches?\r\n(c) _How do I set up set_random_mon_list - it seems not to actually affect anything when it comes to gameplay?_ **Done, thanks for explaining this gammafunk.**\r\n(d) _Is it even necessary at all to have a cap on the number of non-derived undead that can spawn from each tier? Given that there is now a much greater variation in the monsters that spawn, I am wondering if this can be entirely removed._  **I have now removed this, in commit 3.**\r\n(e) The sword of Zonguldrok doesn't actually ever seem to spawn; instead I have found a randart double sword every time that I have tested. Is this a feature or a bug, because it seems like the sword should always generate?\r\n\r\nThis is my second attempt at creating this PR. After accidentally apparently changing 262 files with an attempted but failed merge commit, I decided to start again from scratch. It appears to be fixed now, but that is why there are a few erroneous commits from before. The relevant commits are all numbered.","created_at":"2018-04-10T18:05:46Z","updated_at":"2018-04-10T18:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crawl/crawl/pulls/732/commits","review_comments_url":"https://api.github.com/repos/crawl/crawl/pulls/732/comments","review_comment_url":"https://api.github.com/repos/crawl/crawl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crawl/crawl/issues/732/comments","statuses_url":"https://api.github.com/repos/crawl/crawl/statuses/7bfef18130f115b8a9f011903de6590654d146fe","head":{"label":"NormalPerson7:buff-zonguldrok-2","ref":"buff-zonguldrok-2","sha":"7bfef18130f115b8a9f011903de6590654d146fe","user":{"login":"NormalPerson7","id":37064413,"avatar_url":"https://avatars1.githubusercontent.com/u/37064413?v=4","gravatar_id":"","url":"https://api.github.com/users/NormalPerson7","html_url":"https://github.com/NormalPerson7","followers_url":"https://api.github.com/users/NormalPerson7/followers","following_url":"https://api.github.com/users/NormalPerson7/following{/other_user}","gists_url":"https://api.github.com/users/NormalPerson7/gists{/gist_id}","starred_url":"https://api.github.com/users/NormalPerson7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NormalPerson7/subscriptions","organizations_url":"https://api.github.com/users/NormalPerson7/orgs","repos_url":"https://api.github.com/users/NormalPerson7/repos","events_url":"https://api.github.com/users/NormalPerson7/events{/privacy}","received_events_url":"https://api.github.com/users/NormalPerson7/received_events","type":"User","site_admin":false},"repo":{"id":123885497,"name":"crawl","full_name":"NormalPerson7/crawl","owner":{"login":"NormalPerson7","id":37064413,"avatar_url":"https://avatars1.githubusercontent.com/u/37064413?v=4","gravatar_id":"","url":"https://api.github.com/users/NormalPerson7","html_url":"https://github.com/NormalPerson7","followers_url":"https://api.github.com/users/NormalPerson7/followers","following_url":"https://api.github.com/users/NormalPerson7/following{/other_user}","gists_url":"https://api.github.com/users/NormalPerson7/gists{/gist_id}","starred_url":"https://api.github.com/users/NormalPerson7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NormalPerson7/subscriptions","organizations_url":"https://api.github.com/users/NormalPerson7/orgs","repos_url":"https://api.github.com/users/NormalPerson7/repos","events_url":"https://api.github.com/users/NormalPerson7/events{/privacy}","received_events_url":"https://api.github.com/users/NormalPerson7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NormalPerson7/crawl","description":"Dungeon Crawl: Stone Soup official repository","fork":true,"url":"https://api.github.com/repos/NormalPerson7/crawl","forks_url":"https://api.github.com/repos/NormalPerson7/crawl/forks","keys_url":"https://api.github.com/repos/NormalPerson7/crawl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NormalPerson7/crawl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NormalPerson7/crawl/teams","hooks_url":"https://api.github.com/repos/NormalPerson7/crawl/hooks","issue_events_url":"https://api.github.com/repos/NormalPerson7/crawl/issues/events{/number}","events_url":"https://api.github.com/repos/NormalPerson7/crawl/events","assignees_url":"https://api.github.com/repos/NormalPerson7/crawl/assignees{/user}","branches_url":"https://api.github.com/repos/NormalPerson7/crawl/branches{/branch}","tags_url":"https://api.github.com/repos/NormalPerson7/crawl/tags","blobs_url":"https://api.github.com/repos/NormalPerson7/crawl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NormalPerson7/crawl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NormalPerson7/crawl/git/refs{/sha}","trees_url":"https://api.github.com/repos/NormalPerson7/crawl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NormalPerson7/crawl/statuses/{sha}","languages_url":"https://api.github.com/repos/NormalPerson7/crawl/languages","stargazers_url":"https://api.github.com/repos/NormalPerson7/crawl/stargazers","contributors_url":"https://api.github.com/repos/NormalPerson7/crawl/contributors","subscribers_url":"https://api.github.com/repos/NormalPerson7/crawl/subscribers","subscription_url":"https://api.github.com/repos/NormalPerson7/crawl/subscription","commits_url":"https://api.github.com/repos/NormalPerson7/crawl/commits{/sha}","git_commits_url":"https://api.github.com/repos/NormalPerson7/crawl/git/commits{/sha}","comments_url":"https://api.github.com/repos/NormalPerson7/crawl/comments{/number}","issue_comment_url":"https://api.github.com/repos/NormalPerson7/crawl/issues/comments{/number}","contents_url":"https://api.github.com/repos/NormalPerson7/crawl/contents/{+path}","compare_url":"https://api.github.com/repos/NormalPerson7/crawl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NormalPerson7/crawl/merges","archive_url":"https://api.github.com/repos/NormalPerson7/crawl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NormalPerson7/crawl/downloads","issues_url":"https://api.github.com/repos/NormalPerson7/crawl/issues{/number}","pulls_url":"https://api.github.com/repos/NormalPerson7/crawl/pulls{/number}","milestones_url":"https://api.github.com/repos/NormalPerson7/crawl/milestones{/number}","notifications_url":"https://api.github.com/repos/NormalPerson7/crawl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NormalPerson7/crawl/labels{/name}","releases_url":"https://api.github.com/repos/NormalPerson7/crawl/releases{/id}","deployments_url":"https://api.github.com/repos/NormalPerson7/crawl/deployments","created_at":"2018-03-05T08:04:16Z","updated_at":"2018-04-10T16:01:46Z","pushed_at":"2018-04-10T17:57:58Z","git_url":"git://github.com/NormalPerson7/crawl.git","ssh_url":"git@github.com:NormalPerson7/crawl.git","clone_url":"https://github.com/NormalPerson7/crawl.git","svn_url":"https://github.com/NormalPerson7/crawl","homepage":"http://crawl.develz.org/","size":176411,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crawl:master","ref":"master","sha":"d16d1391c7b25229e63db5c33e33d80b2ff1ae0c","user":{"login":"crawl","id":8470194,"avatar_url":"https://avatars1.githubusercontent.com/u/8470194?v=4","gravatar_id":"","url":"https://api.github.com/users/crawl","html_url":"https://github.com/crawl","followers_url":"https://api.github.com/users/crawl/followers","following_url":"https://api.github.com/users/crawl/following{/other_user}","gists_url":"https://api.github.com/users/crawl/gists{/gist_id}","starred_url":"https://api.github.com/users/crawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawl/subscriptions","organizations_url":"https://api.github.com/users/crawl/orgs","repos_url":"https://api.github.com/users/crawl/repos","events_url":"https://api.github.com/users/crawl/events{/privacy}","received_events_url":"https://api.github.com/users/crawl/received_events","type":"Organization","site_admin":false},"repo":{"id":23038334,"name":"crawl","full_name":"crawl/crawl","owner":{"login":"crawl","id":8470194,"avatar_url":"https://avatars1.githubusercontent.com/u/8470194?v=4","gravatar_id":"","url":"https://api.github.com/users/crawl","html_url":"https://github.com/crawl","followers_url":"https://api.github.com/users/crawl/followers","following_url":"https://api.github.com/users/crawl/following{/other_user}","gists_url":"https://api.github.com/users/crawl/gists{/gist_id}","starred_url":"https://api.github.com/users/crawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawl/subscriptions","organizations_url":"https://api.github.com/users/crawl/orgs","repos_url":"https://api.github.com/users/crawl/repos","events_url":"https://api.github.com/users/crawl/events{/privacy}","received_events_url":"https://api.github.com/users/crawl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crawl/crawl","description":"Dungeon Crawl: Stone Soup official repository","fork":false,"url":"https://api.github.com/repos/crawl/crawl","forks_url":"https://api.github.com/repos/crawl/crawl/forks","keys_url":"https://api.github.com/repos/crawl/crawl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crawl/crawl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crawl/crawl/teams","hooks_url":"https://api.github.com/repos/crawl/crawl/hooks","issue_events_url":"https://api.github.com/repos/crawl/crawl/issues/events{/number}","events_url":"https://api.github.com/repos/crawl/crawl/events","assignees_url":"https://api.github.com/repos/crawl/crawl/assignees{/user}","branches_url":"https://api.github.com/repos/crawl/crawl/branches{/branch}","tags_url":"https://api.github.com/repos/crawl/crawl/tags","blobs_url":"https://api.github.com/repos/crawl/crawl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crawl/crawl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crawl/crawl/git/refs{/sha}","trees_url":"https://api.github.com/repos/crawl/crawl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crawl/crawl/statuses/{sha}","languages_url":"https://api.github.com/repos/crawl/crawl/languages","stargazers_url":"https://api.github.com/repos/crawl/crawl/stargazers","contributors_url":"https://api.github.com/repos/crawl/crawl/contributors","subscribers_url":"https://api.github.com/repos/crawl/crawl/subscribers","subscription_url":"https://api.github.com/repos/crawl/crawl/subscription","commits_url":"https://api.github.com/repos/crawl/crawl/commits{/sha}","git_commits_url":"https://api.github.com/repos/crawl/crawl/git/commits{/sha}","comments_url":"https://api.github.com/repos/crawl/crawl/comments{/number}","issue_comment_url":"https://api.github.com/repos/crawl/crawl/issues/comments{/number}","contents_url":"https://api.github.com/repos/crawl/crawl/contents/{+path}","compare_url":"https://api.github.com/repos/crawl/crawl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crawl/crawl/merges","archive_url":"https://api.github.com/repos/crawl/crawl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crawl/crawl/downloads","issues_url":"https://api.github.com/repos/crawl/crawl/issues{/number}","pulls_url":"https://api.github.com/repos/crawl/crawl/pulls{/number}","milestones_url":"https://api.github.com/repos/crawl/crawl/milestones{/number}","notifications_url":"https://api.github.com/repos/crawl/crawl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crawl/crawl/labels{/name}","releases_url":"https://api.github.com/repos/crawl/crawl/releases{/id}","deployments_url":"https://api.github.com/repos/crawl/crawl/deployments","created_at":"2014-08-17T10:39:37Z","updated_at":"2018-04-08T02:16:01Z","pushed_at":"2018-04-09T19:14:09Z","git_url":"git://github.com/crawl/crawl.git","ssh_url":"git@github.com:crawl/crawl.git","clone_url":"https://github.com/crawl/crawl.git","svn_url":"https://github.com/crawl/crawl","homepage":"http://crawl.develz.org/","size":176517,"stargazers_count":779,"watchers_count":779,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":335,"open_issues":37,"watchers":779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crawl/crawl/pulls/732"},"html":{"href":"https://github.com/crawl/crawl/pull/732"},"issue":{"href":"https://api.github.com/repos/crawl/crawl/issues/732"},"comments":{"href":"https://api.github.com/repos/crawl/crawl/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/crawl/crawl/pulls/732/comments"},"review_comment":{"href":"https://api.github.com/repos/crawl/crawl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crawl/crawl/pulls/732/commits"},"statuses":{"href":"https://api.github.com/repos/crawl/crawl/statuses/7bfef18130f115b8a9f011903de6590654d146fe"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":9,"additions":109,"deletions":26,"changed_files":1}}
{"actor":{"display_login":"NormalPerson7"}}