{"action":"created","issue":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3721","repository_url":"https://api.github.com/repos/freedomofpress/securedrop","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3721/labels{/name}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3721/comments","events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3721/events","html_url":"https://github.com/freedomofpress/securedrop/pull/3721","id":351665938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjAyOTUy","number":3721,"title":"Allow viewing of Tor browser functional test over VNC","user":{"login":"msheiny","id":1727935,"node_id":"MDQ6VXNlcjE3Mjc5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1727935?v=4","gravatar_id":"","url":"https://api.github.com/users/msheiny","html_url":"https://github.com/msheiny","followers_url":"https://api.github.com/users/msheiny/followers","following_url":"https://api.github.com/users/msheiny/following{/other_user}","gists_url":"https://api.github.com/users/msheiny/gists{/gist_id}","starred_url":"https://api.github.com/users/msheiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheiny/subscriptions","organizations_url":"https://api.github.com/users/msheiny/orgs","repos_url":"https://api.github.com/users/msheiny/repos","events_url":"https://api.github.com/users/msheiny/events{/privacy}","received_events_url":"https://api.github.com/users/msheiny/received_events","type":"User","site_admin":false},"labels":[{"id":475996783,"node_id":"MDU6TGFiZWw0NzU5OTY3ODM=","url":"https://api.github.com/repos/freedomofpress/securedrop/labels/functional_tests","name":"functional_tests","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-17T16:51:35Z","updated_at":"2018-09-27T17:15:45Z","closed_at":"2018-09-27T17:15:45Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3721","html_url":"https://github.com/freedomofpress/securedrop/pull/3721","diff_url":"https://github.com/freedomofpress/securedrop/pull/3721.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/3721.patch"},"body":"## Status\r\n\r\nReady for review\r\n\r\n## Description of Changes\r\n\r\nFixes #3718 \r\n\r\nChanges proposed in this pull request:\r\n* Does some re-configuration with the existing VNC helper function and uses Xvnc instead (quite frankly I had a lot of issues trying to get it working with `x11vnc` + `Xvfb` )\r\n* Adds some helper commands \r\n\r\n## Testing\r\n\r\nHow should the reviewer test this PR?\r\n\r\nIf you want to test against a remote server:\r\n* Start a staging server (either via the upgrade scenario or manually)\r\n* If you didn't use `upgrade` scenario - fill out the `instance_information.json` and do the create_dev dance\r\n* Start the tests `cd securedrop ;  ./bin/dev-shell ./bin/run-test tests/functional` \r\n* While those are running (once you start seeing test section) run `make func-vnc` )\r\n* :tada:  you should see the tests running \r\n\r\nOf special note is that I did `NOT` run this under macOS yet so I'll need anyone with `macOS` *cough* *cough* @redshiftzero *cough* to take a look and make sure that `make func-vnc` call works\r\n\r\n## Checklist\r\n\r\n- [ ] How many woodchucks?"},"comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments/425172399","html_url":"https://github.com/freedomofpress/securedrop/pull/3721#issuecomment-425172399","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3721","id":425172399,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE3MjM5OQ==","user":{"login":"redshiftzero","id":7832803,"node_id":"MDQ6VXNlcjc4MzI4MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7832803?v=4","gravatar_id":"","url":"https://api.github.com/users/redshiftzero","html_url":"https://github.com/redshiftzero","followers_url":"https://api.github.com/users/redshiftzero/followers","following_url":"https://api.github.com/users/redshiftzero/following{/other_user}","gists_url":"https://api.github.com/users/redshiftzero/gists{/gist_id}","starred_url":"https://api.github.com/users/redshiftzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redshiftzero/subscriptions","organizations_url":"https://api.github.com/users/redshiftzero/orgs","repos_url":"https://api.github.com/users/redshiftzero/repos","events_url":"https://api.github.com/users/redshiftzero/events{/privacy}","received_events_url":"https://api.github.com/users/redshiftzero/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T17:15:45Z","updated_at":"2018-09-27T17:15:45Z","author_association":"CONTRIBUTOR","body":"superseded by #3817"}}
{"actor":{"display_login":"redshiftzero"}}