{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/4172","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/4172/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4172/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/4172/events","html_url":"https://github.com/facebook/rocksdb/pull/4172","id":343834775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzczODYz","number":4172,"title":"Remove random writes from SST file ingestion","user":{"login":"riversand963","id":20094703,"node_id":"MDQ6VXNlcjIwMDk0NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"riversand963","id":20094703,"node_id":"MDQ6VXNlcjIwMDk0NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"assignees":[{"login":"riversand963","id":20094703,"node_id":"MDQ6VXNlcjIwMDk0NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-07-23T23:49:19Z","updated_at":"2018-07-27T21:52:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4172","html_url":"https://github.com/facebook/rocksdb/pull/4172","diff_url":"https://github.com/facebook/rocksdb/pull/4172.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4172.patch"},"body":"RocksDB used to store global_seqno in external SST files written by\r\nSstFileWriter. During file ingestion, RocksDB uses `pwrite` to update the\r\n`global_seqno`. Since random write is not supported in some non-POSIX compliant\r\nfile systems, external SST file ingestion is not supported on these file\r\nsystems. To address this limitation, we no longer update `global_seqno` during\r\nfile ingestion. Later RocksDB uses the MANIFEST and other information in table\r\nproperties to deduce global seqno for externally-ingested SST files.\r\n\r\nTest plan:\r\n```\r\n$make clean && make -j16 all check\r\n$./external_sst_file_test\r\n$./external_sst_file_basic_test"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/408547748","html_url":"https://github.com/facebook/rocksdb/pull/4172#issuecomment-408547748","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4172","id":408547748,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODU0Nzc0OA==","user":{"login":"facebook-github-bot","id":6422482,"node_id":"MDQ6VXNlcjY0MjI0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T21:52:49Z","updated_at":"2018-07-27T21:52:49Z","author_association":"NONE","body":"[@riversand963](https://github.com/riversand963) has updated the pull request. [Re-import the pull request](https://our.intern.facebook.com/intern/opensource/github/pull_request/confirm/import/278042926335372/)"}}
{"actor":{"display_login":"facebook-github-bot"}}