{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/3221","repository_url":"https://api.github.com/repos/Microsoft/vcpkg","labels_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/3221/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/3221/comments","events_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/3221/events","html_url":"https://github.com/Microsoft/vcpkg/pull/3221","id":312170178,"number":3221,"title":"add Unicode code page flag for resource compiler","user":{"login":"miurahr","id":123720,"avatar_url":"https://avatars1.githubusercontent.com/u/123720?v=4","gravatar_id":"","url":"https://api.github.com/users/miurahr","html_url":"https://github.com/miurahr","followers_url":"https://api.github.com/users/miurahr/followers","following_url":"https://api.github.com/users/miurahr/following{/other_user}","gists_url":"https://api.github.com/users/miurahr/gists{/gist_id}","starred_url":"https://api.github.com/users/miurahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miurahr/subscriptions","organizations_url":"https://api.github.com/users/miurahr/orgs","repos_url":"https://api.github.com/users/miurahr/repos","events_url":"https://api.github.com/users/miurahr/events{/privacy}","received_events_url":"https://api.github.com/users/miurahr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-07T04:44:30Z","updated_at":"2018-04-10T17:53:18Z","closed_at":"2018-04-10T17:52:35Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/vcpkg/pulls/3221","html_url":"https://github.com/Microsoft/vcpkg/pull/3221","diff_url":"https://github.com/Microsoft/vcpkg/pull/3221.diff","patch_url":"https://github.com/Microsoft/vcpkg/pull/3221.patch"},"body":"On CJK Windows, it does not accept UTF-8 or other non-ascii characters. Because MSVC assumes that sources are in traditional DBCS(Doublei-byte Character Set) such as CP932 for Japanese and CP936 for Chinese, etc.\r\n\r\nHere is a place and problem explanation where curl have non ASCII characters in CP1252.\r\ncurl/curl#1217\r\nSame issue also exist in src/main/windows/version.rc#L28\r\n\r\nMSVC detect source encoding and character set from source. A source with BOM code recognized\r\nto Unicode encoded with UTF-8. Without BOM, MSVC assumes local code page character set and enccding, that is defined above Windows configuration, except for English Windows default is UTF-8 and Unicode. It is a character set  problem rather than encoding.\r\n\r\nWill fix #3128 \r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/comments/380190652","html_url":"https://github.com/Microsoft/vcpkg/pull/3221#issuecomment-380190652","issue_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/3221","id":380190652,"user":{"login":"ras0219-msft","id":12301622,"avatar_url":"https://avatars2.githubusercontent.com/u/12301622?v=4","gravatar_id":"","url":"https://api.github.com/users/ras0219-msft","html_url":"https://github.com/ras0219-msft","followers_url":"https://api.github.com/users/ras0219-msft/followers","following_url":"https://api.github.com/users/ras0219-msft/following{/other_user}","gists_url":"https://api.github.com/users/ras0219-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/ras0219-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ras0219-msft/subscriptions","organizations_url":"https://api.github.com/users/ras0219-msft/orgs","repos_url":"https://api.github.com/users/ras0219-msft/repos","events_url":"https://api.github.com/users/ras0219-msft/events{/privacy}","received_events_url":"https://api.github.com/users/ras0219-msft/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T17:53:18Z","updated_at":"2018-04-10T17:53:18Z","author_association":"CONTRIBUTOR","body":"Thanks for the PR!\r\n\r\nInstead of adding code to each port, this looks like something we should always do. I've therefore added it to our master toolchain file for Windows in 58be848. Let me know if that fixes the issue!"}}
{"actor":{"display_login":"ras0219-msft"}}