{"action":"closed","number":25206,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206","id":183258303,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25206","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25206.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25206.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25206","number":25206,"state":"closed","locked":false,"title":"[classnames] Support for ES modules","user":{"login":"alexey-pelykh","id":345102,"avatar_url":"https://avatars0.githubusercontent.com/u/345102?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-pelykh","html_url":"https://github.com/alexey-pelykh","followers_url":"https://api.github.com/users/alexey-pelykh/followers","following_url":"https://api.github.com/users/alexey-pelykh/following{/other_user}","gists_url":"https://api.github.com/users/alexey-pelykh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-pelykh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-pelykh/subscriptions","organizations_url":"https://api.github.com/users/alexey-pelykh/orgs","repos_url":"https://api.github.com/users/alexey-pelykh/repos","events_url":"https://api.github.com/users/alexey-pelykh/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-pelykh/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/JedWatson/classnames/commit/915186aaa510e0c6be6c2cf20788aac474790e27\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.\r\n","created_at":"2018-04-22T06:35:19Z","updated_at":"2018-04-30T17:26:12Z","closed_at":"2018-04-30T17:26:12Z","merged_at":null,"merge_commit_sha":"8632b5ab1063bbad4f80eb93cc2041765534739c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":644116170,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Abandoned","name":"Abandoned","color":"EEEEEE","default":false},{"id":684321576,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":395679059,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25206/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f0afe309ad09b50c6c50c8af8368f3341549d521","head":{"label":"brainbeanapps:classnames_support_for_esmodules","ref":"classnames_support_for_esmodules","sha":"f0afe309ad09b50c6c50c8af8368f3341549d521","user":{"login":"brainbeanapps","id":14878004,"avatar_url":"https://avatars1.githubusercontent.com/u/14878004?v=4","gravatar_id":"","url":"https://api.github.com/users/brainbeanapps","html_url":"https://github.com/brainbeanapps","followers_url":"https://api.github.com/users/brainbeanapps/followers","following_url":"https://api.github.com/users/brainbeanapps/following{/other_user}","gists_url":"https://api.github.com/users/brainbeanapps/gists{/gist_id}","starred_url":"https://api.github.com/users/brainbeanapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainbeanapps/subscriptions","organizations_url":"https://api.github.com/users/brainbeanapps/orgs","repos_url":"https://api.github.com/users/brainbeanapps/repos","events_url":"https://api.github.com/users/brainbeanapps/events{/privacy}","received_events_url":"https://api.github.com/users/brainbeanapps/received_events","type":"Organization","site_admin":false},"repo":{"id":130463061,"name":"DefinitelyTyped","full_name":"brainbeanapps/DefinitelyTyped","owner":{"login":"brainbeanapps","id":14878004,"avatar_url":"https://avatars1.githubusercontent.com/u/14878004?v=4","gravatar_id":"","url":"https://api.github.com/users/brainbeanapps","html_url":"https://github.com/brainbeanapps","followers_url":"https://api.github.com/users/brainbeanapps/followers","following_url":"https://api.github.com/users/brainbeanapps/following{/other_user}","gists_url":"https://api.github.com/users/brainbeanapps/gists{/gist_id}","starred_url":"https://api.github.com/users/brainbeanapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainbeanapps/subscriptions","organizations_url":"https://api.github.com/users/brainbeanapps/orgs","repos_url":"https://api.github.com/users/brainbeanapps/repos","events_url":"https://api.github.com/users/brainbeanapps/events{/privacy}","received_events_url":"https://api.github.com/users/brainbeanapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brainbeanapps/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped","forks_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/brainbeanapps/DefinitelyTyped/deployments","created_at":"2018-04-21T10:24:00Z","updated_at":"2018-04-25T02:32:41Z","pushed_at":"2018-04-26T04:28:26Z","git_url":"git://github.com/brainbeanapps/DefinitelyTyped.git","ssh_url":"git@github.com:brainbeanapps/DefinitelyTyped.git","clone_url":"https://github.com/brainbeanapps/DefinitelyTyped.git","svn_url":"https://github.com/brainbeanapps/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":312950,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"afb4ff4cfb411a9b60c2952a9a6207c6b83be67c","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-04-30T16:18:33Z","pushed_at":"2018-04-30T17:16:53Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":314267,"stargazers_count":15323,"watchers_count":15323,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12751,"mirror_url":null,"archived":false,"open_issues_count":2100,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12751,"open_issues":2100,"watchers":15323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25206"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25206"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25206/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25206/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f0afe309ad09b50c6c50c8af8368f3341549d521"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"typescript-bot"}}