{"action":"created","issue":{"url":"https://api.github.com/repos/styled-components/styled-components/issues/1411","repository_url":"https://api.github.com/repos/styled-components/styled-components","labels_url":"https://api.github.com/repos/styled-components/styled-components/issues/1411/labels{/name}","comments_url":"https://api.github.com/repos/styled-components/styled-components/issues/1411/comments","events_url":"https://api.github.com/repos/styled-components/styled-components/issues/1411/events","html_url":"https://github.com/styled-components/styled-components/issues/1411","id":286560926,"number":1411,"title":"Hoist non react statics","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars2.githubusercontent.com/u/3165635?v=4","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"labels":[{"id":425493751,"url":"https://api.github.com/repos/styled-components/styled-components/labels/enhancement%20:sparkles:","name":"enhancement :sparkles:","color":"1d76db","default":false},{"id":461725692,"url":"https://api.github.com/repos/styled-components/styled-components/labels/good%20first%20issue%20:octocat:","name":"good first issue :octocat:","color":"0e8a16","default":false},{"id":425493752,"url":"https://api.github.com/repos/styled-components/styled-components/labels/help%20wanted%20:raised_hands:","name":"help wanted :raised_hands:","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-07T11:03:57Z","updated_at":"2018-02-27T09:46:11Z","closed_at":null,"author_association":"NONE","body":"### What will it allow you to do that you can't do today?\r\n\r\nSolve https://github.com/mui-org/material-ui/issues/9736 out of the box. We add a `muiName` static property to some of the Material-UI components. However, this static property is lost after wrapping the component with styled-components.\r\n\r\n### How will it make current work-arounds straightforward?\r\n\r\nYou are already solving the problem for withTheme:\r\nhttps://github.com/styled-components/styled-components/blob/1dfc7a64ff8ff3706424d68bbe021b8f973ff9db/src/hoc/withTheme.js#L6\r\n\r\n### What potential bugs and edge cases does it help to avoid?\r\n\r\nIt's making the styled component higher-order component transparent to static properties.\r\n  "},"comment":{"url":"https://api.github.com/repos/styled-components/styled-components/issues/comments/368811343","html_url":"https://github.com/styled-components/styled-components/issues/1411#issuecomment-368811343","issue_url":"https://api.github.com/repos/styled-components/styled-components/issues/1411","id":368811343,"user":{"login":"danez","id":231804,"avatar_url":"https://avatars2.githubusercontent.com/u/231804?v=4","gravatar_id":"","url":"https://api.github.com/users/danez","html_url":"https://github.com/danez","followers_url":"https://api.github.com/users/danez/followers","following_url":"https://api.github.com/users/danez/following{/other_user}","gists_url":"https://api.github.com/users/danez/gists{/gist_id}","starred_url":"https://api.github.com/users/danez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danez/subscriptions","organizations_url":"https://api.github.com/users/danez/orgs","repos_url":"https://api.github.com/users/danez/repos","events_url":"https://api.github.com/users/danez/events{/privacy}","received_events_url":"https://api.github.com/users/danez/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T09:46:11Z","updated_at":"2018-02-27T09:46:11Z","author_association":"NONE","body":"The same applies to `react-tabs` which also assigns static properties to its components so the wrapping component can identify his children. The are sadly lost when using styled components and people use workarounds to get it working. https://github.com/reactjs/react-tabs/issues/148#issuecomment-368809171"}}
{"actor":{"display_login":"danez"}}