{"action":"created","comment":{"url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/comments/211293612","pull_request_review_id":147683358,"id":211293612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTI5MzYxMg==","diff_hunk":"@@ -25,12 +25,15 @@ class AssetsUrlInterpreter extends AssetUrlInterpreter\n      */\n     public function interpret(Concrete $object, $value, Mapping $map, $data, DefinitionInterface $definition, $params, $configuration)\n     {\n-        $asset = parent::interpret($object, $value, $map, $data, $definition, $params, $configuration);\n+        $assets = [];","path":"src/ImportDefinitionsBundle/Interpreter/AssetsUrlInterpreter.php","position":5,"original_position":5,"commit_id":"07c6ff7c23f75be236dac7c4a31f8280c6a60867","original_commit_id":"07c6ff7c23f75be236dac7c4a31f8280c6a60867","user":{"login":"dkarlovi","id":209225,"node_id":"MDQ6VXNlcjIwOTIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/209225?v=4","gravatar_id":"","url":"https://api.github.com/users/dkarlovi","html_url":"https://github.com/dkarlovi","followers_url":"https://api.github.com/users/dkarlovi/followers","following_url":"https://api.github.com/users/dkarlovi/following{/other_user}","gists_url":"https://api.github.com/users/dkarlovi/gists{/gist_id}","starred_url":"https://api.github.com/users/dkarlovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkarlovi/subscriptions","organizations_url":"https://api.github.com/users/dkarlovi/orgs","repos_url":"https://api.github.com/users/dkarlovi/repos","events_url":"https://api.github.com/users/dkarlovi/events{/privacy}","received_events_url":"https://api.github.com/users/dkarlovi/received_events","type":"User","site_admin":false},"body":"But this is BC compatible? You get back either an array of assets or `null`?","created_at":"2018-08-20T14:58:00Z","updated_at":"2018-08-20T14:58:00Z","html_url":"https://github.com/w-vision/ImportDefinitions/pull/74#discussion_r211293612","pull_request_url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/comments/211293612"},"html":{"href":"https://github.com/w-vision/ImportDefinitions/pull/74#discussion_r211293612"},"pull_request":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74"}},"in_reply_to_id":211292937},"pull_request":{"url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74","id":209548010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTQ4MDEw","html_url":"https://github.com/w-vision/ImportDefinitions/pull/74","diff_url":"https://github.com/w-vision/ImportDefinitions/pull/74.diff","patch_url":"https://github.com/w-vision/ImportDefinitions/pull/74.patch","issue_url":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/74","number":74,"state":"open","locked":false,"title":"feature: support array of URLs in assets_url interpreter","user":{"login":"dkarlovi","id":209225,"node_id":"MDQ6VXNlcjIwOTIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/209225?v=4","gravatar_id":"","url":"https://api.github.com/users/dkarlovi","html_url":"https://github.com/dkarlovi","followers_url":"https://api.github.com/users/dkarlovi/followers","following_url":"https://api.github.com/users/dkarlovi/following{/other_user}","gists_url":"https://api.github.com/users/dkarlovi/gists{/gist_id}","starred_url":"https://api.github.com/users/dkarlovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkarlovi/subscriptions","organizations_url":"https://api.github.com/users/dkarlovi/orgs","repos_url":"https://api.github.com/users/dkarlovi/repos","events_url":"https://api.github.com/users/dkarlovi/events{/privacy}","received_events_url":"https://api.github.com/users/dkarlovi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-20T14:54:04Z","updated_at":"2018-08-20T14:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee560856bcdc0a59dd966ad6a9ced7c9a7ed90eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74/commits","review_comments_url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74/comments","review_comment_url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/74/comments","statuses_url":"https://api.github.com/repos/w-vision/ImportDefinitions/statuses/07c6ff7c23f75be236dac7c4a31f8280c6a60867","head":{"label":"dkarlovi:multiple-assets-urls-interpreter-support","ref":"multiple-assets-urls-interpreter-support","sha":"07c6ff7c23f75be236dac7c4a31f8280c6a60867","user":{"login":"dkarlovi","id":209225,"node_id":"MDQ6VXNlcjIwOTIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/209225?v=4","gravatar_id":"","url":"https://api.github.com/users/dkarlovi","html_url":"https://github.com/dkarlovi","followers_url":"https://api.github.com/users/dkarlovi/followers","following_url":"https://api.github.com/users/dkarlovi/following{/other_user}","gists_url":"https://api.github.com/users/dkarlovi/gists{/gist_id}","starred_url":"https://api.github.com/users/dkarlovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkarlovi/subscriptions","organizations_url":"https://api.github.com/users/dkarlovi/orgs","repos_url":"https://api.github.com/users/dkarlovi/repos","events_url":"https://api.github.com/users/dkarlovi/events{/privacy}","received_events_url":"https://api.github.com/users/dkarlovi/received_events","type":"User","site_admin":false},"repo":{"id":137845834,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4NDU4MzQ=","name":"ImportDefinitions","full_name":"dkarlovi/ImportDefinitions","owner":{"login":"dkarlovi","id":209225,"node_id":"MDQ6VXNlcjIwOTIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/209225?v=4","gravatar_id":"","url":"https://api.github.com/users/dkarlovi","html_url":"https://github.com/dkarlovi","followers_url":"https://api.github.com/users/dkarlovi/followers","following_url":"https://api.github.com/users/dkarlovi/following{/other_user}","gists_url":"https://api.github.com/users/dkarlovi/gists{/gist_id}","starred_url":"https://api.github.com/users/dkarlovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkarlovi/subscriptions","organizations_url":"https://api.github.com/users/dkarlovi/orgs","repos_url":"https://api.github.com/users/dkarlovi/repos","events_url":"https://api.github.com/users/dkarlovi/events{/privacy}","received_events_url":"https://api.github.com/users/dkarlovi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkarlovi/ImportDefinitions","description":"Import Definitions Plugin for Pimcore","fork":true,"url":"https://api.github.com/repos/dkarlovi/ImportDefinitions","forks_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/forks","keys_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/teams","hooks_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/hooks","issue_events_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/issues/events{/number}","events_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/events","assignees_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/assignees{/user}","branches_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/branches{/branch}","tags_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/tags","blobs_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/statuses/{sha}","languages_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/languages","stargazers_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/stargazers","contributors_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/contributors","subscribers_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/subscribers","subscription_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/subscription","commits_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/contents/{+path}","compare_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/merges","archive_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/downloads","issues_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/issues{/number}","pulls_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/pulls{/number}","milestones_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/milestones{/number}","notifications_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/labels{/name}","releases_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/releases{/id}","deployments_url":"https://api.github.com/repos/dkarlovi/ImportDefinitions/deployments","created_at":"2018-06-19T05:50:47Z","updated_at":"2018-06-19T05:50:49Z","pushed_at":"2018-08-20T14:53:43Z","git_url":"git://github.com/dkarlovi/ImportDefinitions.git","ssh_url":"git@github.com:dkarlovi/ImportDefinitions.git","clone_url":"https://github.com/dkarlovi/ImportDefinitions.git","svn_url":"https://github.com/dkarlovi/ImportDefinitions","homepage":"","size":1155,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w-vision:master","ref":"master","sha":"6d15b79c44a9f63b2179bcc1c3b3b70fe5edc553","user":{"login":"w-vision","id":18732597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyNTk3","avatar_url":"https://avatars0.githubusercontent.com/u/18732597?v=4","gravatar_id":"","url":"https://api.github.com/users/w-vision","html_url":"https://github.com/w-vision","followers_url":"https://api.github.com/users/w-vision/followers","following_url":"https://api.github.com/users/w-vision/following{/other_user}","gists_url":"https://api.github.com/users/w-vision/gists{/gist_id}","starred_url":"https://api.github.com/users/w-vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-vision/subscriptions","organizations_url":"https://api.github.com/users/w-vision/orgs","repos_url":"https://api.github.com/users/w-vision/repos","events_url":"https://api.github.com/users/w-vision/events{/privacy}","received_events_url":"https://api.github.com/users/w-vision/received_events","type":"Organization","site_admin":false},"repo":{"id":62632812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjYzMjgxMg==","name":"ImportDefinitions","full_name":"w-vision/ImportDefinitions","owner":{"login":"w-vision","id":18732597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyNTk3","avatar_url":"https://avatars0.githubusercontent.com/u/18732597?v=4","gravatar_id":"","url":"https://api.github.com/users/w-vision","html_url":"https://github.com/w-vision","followers_url":"https://api.github.com/users/w-vision/followers","following_url":"https://api.github.com/users/w-vision/following{/other_user}","gists_url":"https://api.github.com/users/w-vision/gists{/gist_id}","starred_url":"https://api.github.com/users/w-vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-vision/subscriptions","organizations_url":"https://api.github.com/users/w-vision/orgs","repos_url":"https://api.github.com/users/w-vision/repos","events_url":"https://api.github.com/users/w-vision/events{/privacy}","received_events_url":"https://api.github.com/users/w-vision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w-vision/ImportDefinitions","description":"Import Definitions Plugin for Pimcore","fork":false,"url":"https://api.github.com/repos/w-vision/ImportDefinitions","forks_url":"https://api.github.com/repos/w-vision/ImportDefinitions/forks","keys_url":"https://api.github.com/repos/w-vision/ImportDefinitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w-vision/ImportDefinitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w-vision/ImportDefinitions/teams","hooks_url":"https://api.github.com/repos/w-vision/ImportDefinitions/hooks","issue_events_url":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/events{/number}","events_url":"https://api.github.com/repos/w-vision/ImportDefinitions/events","assignees_url":"https://api.github.com/repos/w-vision/ImportDefinitions/assignees{/user}","branches_url":"https://api.github.com/repos/w-vision/ImportDefinitions/branches{/branch}","tags_url":"https://api.github.com/repos/w-vision/ImportDefinitions/tags","blobs_url":"https://api.github.com/repos/w-vision/ImportDefinitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w-vision/ImportDefinitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w-vision/ImportDefinitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/w-vision/ImportDefinitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w-vision/ImportDefinitions/statuses/{sha}","languages_url":"https://api.github.com/repos/w-vision/ImportDefinitions/languages","stargazers_url":"https://api.github.com/repos/w-vision/ImportDefinitions/stargazers","contributors_url":"https://api.github.com/repos/w-vision/ImportDefinitions/contributors","subscribers_url":"https://api.github.com/repos/w-vision/ImportDefinitions/subscribers","subscription_url":"https://api.github.com/repos/w-vision/ImportDefinitions/subscription","commits_url":"https://api.github.com/repos/w-vision/ImportDefinitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/w-vision/ImportDefinitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/w-vision/ImportDefinitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/w-vision/ImportDefinitions/contents/{+path}","compare_url":"https://api.github.com/repos/w-vision/ImportDefinitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w-vision/ImportDefinitions/merges","archive_url":"https://api.github.com/repos/w-vision/ImportDefinitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w-vision/ImportDefinitions/downloads","issues_url":"https://api.github.com/repos/w-vision/ImportDefinitions/issues{/number}","pulls_url":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls{/number}","milestones_url":"https://api.github.com/repos/w-vision/ImportDefinitions/milestones{/number}","notifications_url":"https://api.github.com/repos/w-vision/ImportDefinitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w-vision/ImportDefinitions/labels{/name}","releases_url":"https://api.github.com/repos/w-vision/ImportDefinitions/releases{/id}","deployments_url":"https://api.github.com/repos/w-vision/ImportDefinitions/deployments","created_at":"2016-07-05T11:51:45Z","updated_at":"2018-07-17T15:40:02Z","pushed_at":"2018-08-20T14:54:04Z","git_url":"git://github.com/w-vision/ImportDefinitions.git","ssh_url":"git@github.com:w-vision/ImportDefinitions.git","clone_url":"https://github.com/w-vision/ImportDefinitions.git","svn_url":"https://github.com/w-vision/ImportDefinitions","homepage":"","size":1218,"stargazers_count":30,"watchers_count":30,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":2,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74"},"html":{"href":"https://github.com/w-vision/ImportDefinitions/pull/74"},"issue":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/74"},"comments":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/w-vision/ImportDefinitions/statuses/07c6ff7c23f75be236dac7c4a31f8280c6a60867"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dkarlovi"}}