{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/specutils/issues/368","repository_url":"https://api.github.com/repos/astropy/specutils","labels_url":"https://api.github.com/repos/astropy/specutils/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/astropy/specutils/issues/368/comments","events_url":"https://api.github.com/repos/astropy/specutils/issues/368/events","html_url":"https://github.com/astropy/specutils/issues/368","id":375105431,"node_id":"MDU6SXNzdWUzNzUxMDU0MzE=","number":368,"title":"Decide if not-in-order spectra should be supported","user":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"labels":[{"id":1051865253,"node_id":"MDU6TGFiZWwxMDUxODY1MjUz","url":"https://api.github.com/repos/astropy/specutils/labels/Priority-medium","name":"Priority-medium","color":"fdbb84","default":false},{"id":954463409,"node_id":"MDU6TGFiZWw5NTQ0NjM0MDk=","url":"https://api.github.com/repos/astropy/specutils/labels/discussion","name":"discussion","color":"7147d3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/astropy/specutils/milestones/4","html_url":"https://github.com/astropy/specutils/milestone/4","labels_url":"https://api.github.com/repos/astropy/specutils/milestones/4/labels","id":3625197,"node_id":"MDk6TWlsZXN0b25lMzYyNTE5Nw==","number":4,"title":"v0.6.0","description":"","creator":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":4,"state":"open","created_at":"2018-09-05T15:05:29Z","updated_at":"2018-11-21T14:48:10Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-10-29T16:30:42Z","updated_at":"2018-12-07T16:13:34Z","closed_at":null,"author_association":"MEMBER","body":"In spacetelescope/specviz#471 an issue came up that at it's core is about a spectrum being \"out of order\" - that is, some of the other specutils machinery assumes the `spectral_axis` is strictly ordered.\r\n\r\nWhile it's of course possible to fix the associated specutils machinery, it's almost certain that user-written analysis tools might make this assumption.  So what is to be done?  Here are the options I see:\r\n\r\n1. Have a warning be issued when a `Spectrum1D` is created and the inputs are out-of-order (both the array *and* the wcs case, probably by just checking `spectral_axis`).  This warning would basically just say \"this might work for some things... but be aware here there be dragons because it's tricky to get this right\".\r\n1. Raise an *exception* if the input is a `Quantity` `spectral_axis`, saying \"you should sort your spectral_axis\" (and a warning for wcs, which is impossible to fix-up)\r\n1. Forcibly re-order the inputs \r\n1. Do nothing in code, but document clearly what the expectation is - i.e., should user code assume in-order or not?\r\n\r\ncc @brechmos-stsci @nluetzge @crawfordsm @nmearl "},"comment":{"url":"https://api.github.com/repos/astropy/specutils/issues/comments/445281739","html_url":"https://github.com/astropy/specutils/issues/368#issuecomment-445281739","issue_url":"https://api.github.com/repos/astropy/specutils/issues/368","id":445281739,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTI4MTczOQ==","user":{"login":"SaOgaz","id":5287848,"node_id":"MDQ6VXNlcjUyODc4NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/5287848?v=4","gravatar_id":"","url":"https://api.github.com/users/SaOgaz","html_url":"https://github.com/SaOgaz","followers_url":"https://api.github.com/users/SaOgaz/followers","following_url":"https://api.github.com/users/SaOgaz/following{/other_user}","gists_url":"https://api.github.com/users/SaOgaz/gists{/gist_id}","starred_url":"https://api.github.com/users/SaOgaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaOgaz/subscriptions","organizations_url":"https://api.github.com/users/SaOgaz/orgs","repos_url":"https://api.github.com/users/SaOgaz/repos","events_url":"https://api.github.com/users/SaOgaz/events{/privacy}","received_events_url":"https://api.github.com/users/SaOgaz/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T16:13:34Z","updated_at":"2018-12-07T16:13:34Z","author_association":"COLLABORATOR","body":"Noting here: a lot of the x1d JWST files are non in ascending order."}}
{"actor":{"display_login":"SaOgaz"}}