{"action":"created","issue":{"url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/17","repository_url":"https://api.github.com/repos/modelhub-ai/modelhub-engine","labels_url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/17/comments","events_url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/17/events","html_url":"https://github.com/modelhub-ai/modelhub-engine/issues/17","id":309133470,"node_id":"MDU6SXNzdWUzMDkxMzM0NzA=","number":17,"title":"Docker Hub Automated Builds","user":{"login":"michaelschwier","id":29986016,"node_id":"MDQ6VXNlcjI5OTg2MDE2","avatar_url":"https://avatars2.githubusercontent.com/u/29986016?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelschwier","html_url":"https://github.com/michaelschwier","followers_url":"https://api.github.com/users/michaelschwier/followers","following_url":"https://api.github.com/users/michaelschwier/following{/other_user}","gists_url":"https://api.github.com/users/michaelschwier/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelschwier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelschwier/subscriptions","organizations_url":"https://api.github.com/users/michaelschwier/orgs","repos_url":"https://api.github.com/users/michaelschwier/repos","events_url":"https://api.github.com/users/michaelschwier/events{/privacy}","received_events_url":"https://api.github.com/users/michaelschwier/received_events","type":"User","site_admin":false},"labels":[{"id":845327501,"node_id":"MDU6TGFiZWw4NDUzMjc1MDE=","url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/labels/wontfix","name":"wontfix","color":"ffffff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-27T21:05:04Z","updated_at":"2018-07-26T20:43:32Z","closed_at":null,"author_association":"MEMBER","body":"I am not convinced by the automated builds on Docker Hub. It sometimes fails with no log image, while it builds fine locally. Also the Displayed Dockerfile is not the one in the current repo.\r\n\r\nBut the main reason I would argue to not build automatically:\r\nEvery push to our master repo on github will trigger a new build on docker hub. We probably don't want that, but would rather maintain only certain \"releases\" on docker hub. So we could have a dedicated branch/tag on github for releases (which we should have anyway when we start official releases), but would also need to create a new docker repo for each new branch ... so in conclusion: for development we can keep the automatic docker build, since it potentially saves us time because we don't all have to build a new docker, just pull it. But for releases it would probably be better to push dedicated release versions to docker hub (or just provide them directly on modelhub.ai to not confuse the users with multiple locations and versions of the files they need)."},"comment":{"url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/comments/408229056","html_url":"https://github.com/modelhub-ai/modelhub-engine/issues/17#issuecomment-408229056","issue_url":"https://api.github.com/repos/modelhub-ai/modelhub-engine/issues/17","id":408229056,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODIyOTA1Ng==","user":{"login":"fedorov","id":313942,"node_id":"MDQ6VXNlcjMxMzk0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/313942?v=4","gravatar_id":"","url":"https://api.github.com/users/fedorov","html_url":"https://github.com/fedorov","followers_url":"https://api.github.com/users/fedorov/followers","following_url":"https://api.github.com/users/fedorov/following{/other_user}","gists_url":"https://api.github.com/users/fedorov/gists{/gist_id}","starred_url":"https://api.github.com/users/fedorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedorov/subscriptions","organizations_url":"https://api.github.com/users/fedorov/orgs","repos_url":"https://api.github.com/users/fedorov/repos","events_url":"https://api.github.com/users/fedorov/events{/privacy}","received_events_url":"https://api.github.com/users/fedorov/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T20:43:32Z","updated_at":"2018-07-26T20:43:32Z","author_association":"NONE","body":"Few more points to consider:\r\n* At the moment, there is absolutely no documented way to know for the user how the Docker Hub images were generated. There is no link to the Dockerfile behind them.\r\n* Some users might have concerns running images of unknown provenance.\r\n* The connection between the tags in DockerHub and tags in the modelhub-engine repo is indirect, and requires the maintainer to make sure they are assigned consistently (and there is no way to know from the docker image what was the exact Dockerfile that was used to generate it, or at least I don't know of such)\r\n\r\nThe use of DockerHub to generate images automatically would\r\n* establish direct and automatic connection between GitHub repo, tags and the image\r\n* would ensure that DockerHub generated the image, not an individual, improving the confidence of the user that the resulting image is secure\r\n\r\nI agree those are not issues of urgency or high importance, just for consideration for the future!"}}
{"actor":{"display_login":"fedorov"}}