{"action":"closed","number":1021,"pull_request":{"url":"https://api.github.com/repos/mavlink/mavlink/pulls/1021","id":229933175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTMzMTc1","html_url":"https://github.com/mavlink/mavlink/pull/1021","diff_url":"https://github.com/mavlink/mavlink/pull/1021.diff","patch_url":"https://github.com/mavlink/mavlink/pull/1021.patch","issue_url":"https://api.github.com/repos/mavlink/mavlink/issues/1021","number":1021,"state":"closed","locked":false,"title":"Make MAV_CMDs own section of messages with field markup","user":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"body":"Enum schema now allows params to have markup like fields that define possible values, units, and display hints to GCS - e.g.: enum value, max/min/increment, units, label, display with X decimal points.\r\n\r\nThere is no really clean way to display all these fields in the current layout (see https://github.com/mavlink/mavlink/pull/1019 for best shot).\r\n\r\nThis PR does two things.\r\n1. It splits MAV_CMD into its own group as a peer of messages and enums\r\n![image](https://user-images.githubusercontent.com/5368500/48309599-42b74500-e5d2-11e8-851e-d44208be9c5d.png)\r\n2. It mimics the message format to allow columns for units and values.\r\n![image](https://user-images.githubusercontent.com/5368500/48309623-7abe8800-e5d2-11e8-97f4-74a12632aa3c.png)\r\nBut these are only displayed if the fields are defined. If not, it looks like:\r\n![image](https://user-images.githubusercontent.com/5368500/48309635-9d50a100-e5d2-11e8-914a-b047a66e227c.png)\r\n\r\nThe only question is where should label and decimal point fields go. I have currently put them in the description because those two don't matter to all users (they mostly matter to GCS authors).\r\nIs that good?\r\n\r\nYou can play with this here:\r\nhttps://hamishwillee.gitbooks.io/ham_mavdevguide/content/v/just_messages/en/messages/common.html","created_at":"2018-11-11T05:56:46Z","updated_at":"2018-11-12T23:09:02Z","closed_at":"2018-11-12T23:09:02Z","merged_at":"2018-11-12T23:09:02Z","merge_commit_sha":"2c52b06e125f88f6b674db112f127dc35d7a9c71","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LorenzMeier","id":1208119,"node_id":"MDQ6VXNlcjEyMDgxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1208119?v=4","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":908774435,"node_id":"MDU6TGFiZWw5MDg3NzQ0MzU=","url":"https://api.github.com/repos/mavlink/mavlink/labels/Dev%20Call","name":"Dev Call","color":"0e98d3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/mavlink/pulls/1021/commits","review_comments_url":"https://api.github.com/repos/mavlink/mavlink/pulls/1021/comments","review_comment_url":"https://api.github.com/repos/mavlink/mavlink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mavlink/mavlink/issues/1021/comments","statuses_url":"https://api.github.com/repos/mavlink/mavlink/statuses/683048e961aab6083915b539fc6f51da72c63970","head":{"label":"hamishwillee:mav_separate","ref":"mav_separate","sha":"683048e961aab6083915b539fc6f51da72c63970","user":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"repo":{"id":45574618,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU3NDYxOA==","name":"mavlink","full_name":"hamishwillee/mavlink","private":false,"owner":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hamishwillee/mavlink","description":"MAVLink micro air vehicle marshalling / communication library","fork":true,"url":"https://api.github.com/repos/hamishwillee/mavlink","forks_url":"https://api.github.com/repos/hamishwillee/mavlink/forks","keys_url":"https://api.github.com/repos/hamishwillee/mavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hamishwillee/mavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hamishwillee/mavlink/teams","hooks_url":"https://api.github.com/repos/hamishwillee/mavlink/hooks","issue_events_url":"https://api.github.com/repos/hamishwillee/mavlink/issues/events{/number}","events_url":"https://api.github.com/repos/hamishwillee/mavlink/events","assignees_url":"https://api.github.com/repos/hamishwillee/mavlink/assignees{/user}","branches_url":"https://api.github.com/repos/hamishwillee/mavlink/branches{/branch}","tags_url":"https://api.github.com/repos/hamishwillee/mavlink/tags","blobs_url":"https://api.github.com/repos/hamishwillee/mavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hamishwillee/mavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hamishwillee/mavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/hamishwillee/mavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hamishwillee/mavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/hamishwillee/mavlink/languages","stargazers_url":"https://api.github.com/repos/hamishwillee/mavlink/stargazers","contributors_url":"https://api.github.com/repos/hamishwillee/mavlink/contributors","subscribers_url":"https://api.github.com/repos/hamishwillee/mavlink/subscribers","subscription_url":"https://api.github.com/repos/hamishwillee/mavlink/subscription","commits_url":"https://api.github.com/repos/hamishwillee/mavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/hamishwillee/mavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/hamishwillee/mavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/hamishwillee/mavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/hamishwillee/mavlink/contents/{+path}","compare_url":"https://api.github.com/repos/hamishwillee/mavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hamishwillee/mavlink/merges","archive_url":"https://api.github.com/repos/hamishwillee/mavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hamishwillee/mavlink/downloads","issues_url":"https://api.github.com/repos/hamishwillee/mavlink/issues{/number}","pulls_url":"https://api.github.com/repos/hamishwillee/mavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/hamishwillee/mavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/hamishwillee/mavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hamishwillee/mavlink/labels{/name}","releases_url":"https://api.github.com/repos/hamishwillee/mavlink/releases{/id}","deployments_url":"https://api.github.com/repos/hamishwillee/mavlink/deployments","created_at":"2015-11-04T23:38:25Z","updated_at":"2018-10-22T22:49:48Z","pushed_at":"2018-11-11T05:58:30Z","git_url":"git://github.com/hamishwillee/mavlink.git","ssh_url":"git@github.com:hamishwillee/mavlink.git","clone_url":"https://github.com/hamishwillee/mavlink.git","svn_url":"https://github.com/hamishwillee/mavlink","homepage":"http://qgroundcontrol.org/mavlink/start","size":7635,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"c788ca3e143fbb0fd1f90a14fd2a473673b50973","user":{"login":"mavlink","id":961247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTI0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/961247?v=4","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":2195723,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1NzIz","name":"mavlink","full_name":"mavlink/mavlink","private":false,"owner":{"login":"mavlink","id":961247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTI0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/961247?v=4","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mavlink/mavlink","description":"Marshalling / communication library for drones.","fork":false,"url":"https://api.github.com/repos/mavlink/mavlink","forks_url":"https://api.github.com/repos/mavlink/mavlink/forks","keys_url":"https://api.github.com/repos/mavlink/mavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/mavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/mavlink/teams","hooks_url":"https://api.github.com/repos/mavlink/mavlink/hooks","issue_events_url":"https://api.github.com/repos/mavlink/mavlink/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/mavlink/events","assignees_url":"https://api.github.com/repos/mavlink/mavlink/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/mavlink/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/mavlink/tags","blobs_url":"https://api.github.com/repos/mavlink/mavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/mavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/mavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/mavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/mavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/mavlink/languages","stargazers_url":"https://api.github.com/repos/mavlink/mavlink/stargazers","contributors_url":"https://api.github.com/repos/mavlink/mavlink/contributors","subscribers_url":"https://api.github.com/repos/mavlink/mavlink/subscribers","subscription_url":"https://api.github.com/repos/mavlink/mavlink/subscription","commits_url":"https://api.github.com/repos/mavlink/mavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/mavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/mavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/mavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavlink/mavlink/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/mavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/mavlink/merges","archive_url":"https://api.github.com/repos/mavlink/mavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/mavlink/downloads","issues_url":"https://api.github.com/repos/mavlink/mavlink/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/mavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/mavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/mavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/mavlink/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/mavlink/releases{/id}","deployments_url":"https://api.github.com/repos/mavlink/mavlink/deployments","created_at":"2011-08-12T06:51:52Z","updated_at":"2018-11-09T15:16:38Z","pushed_at":"2018-11-12T23:09:02Z","git_url":"git://github.com/mavlink/mavlink.git","ssh_url":"git@github.com:mavlink/mavlink.git","clone_url":"https://github.com/mavlink/mavlink.git","svn_url":"https://github.com/mavlink/mavlink","homepage":"http://mavlink.io","size":7798,"stargazers_count":652,"watchers_count":652,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":950,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":950,"open_issues":86,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/1021"},"html":{"href":"https://github.com/mavlink/mavlink/pull/1021"},"issue":{"href":"https://api.github.com/repos/mavlink/mavlink/issues/1021"},"comments":{"href":"https://api.github.com/repos/mavlink/mavlink/issues/1021/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/1021/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mavlink/mavlink/pulls/1021/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/mavlink/statuses/683048e961aab6083915b539fc6f51da72c63970"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":125,"deletions":15,"changed_files":2}}
{"actor":{"display_login":"hamishwillee"}}