{"action":"closed","number":23739,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23739","id":224103376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTAzMzc2","html_url":"https://github.com/nodejs/node/pull/23739","diff_url":"https://github.com/nodejs/node/pull/23739.diff","patch_url":"https://github.com/nodejs/node/pull/23739.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/23739","number":23739,"state":"closed","locked":false,"title":"build,meta: don't try to lint commit message","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"/CC @Trott \r\n\r\nI think <ins>in its current form</ins> the false negatives have outweighed the true negatives. All in all I don't think commit message formatting has been a limiting factor for landing velocity.\r\n\r\nFixes: https://github.com/nodejs/node/issues/23737\r\nRefs: https://github.com/nodejs/node/pull/22452\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-10-18T21:22:12Z","updated_at":"2018-11-06T14:40:49Z","closed_at":"2018-11-06T14:40:48Z","merged_at":"2018-11-06T14:40:48Z","merge_commit_sha":"bec505bed7518697ad4679b864c1adbb1162a0fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":637807400,"node_id":"MDU6TGFiZWw2Mzc4MDc0MDA=","url":"https://api.github.com/repos/nodejs/node/labels/CI%20/%20flaky%20test","name":"CI / flaky test","color":"ffff00","default":false},{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":191447057,"node_id":"MDU6TGFiZWwxOTE0NDcwNTc=","url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/23739/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/23739/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23739/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/bec505bed7518697ad4679b864c1adbb1162a0fa","head":{"label":"refack:no-lint-commit-on-travis","ref":"no-lint-commit-on-travis","sha":"bec505bed7518697ad4679b864c1adbb1162a0fa","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"repo":{"id":81225016,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIyNTAxNg==","name":"node","full_name":"refack/node","private":false,"owner":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/refack/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/refack/node","forks_url":"https://api.github.com/repos/refack/node/forks","keys_url":"https://api.github.com/repos/refack/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refack/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refack/node/teams","hooks_url":"https://api.github.com/repos/refack/node/hooks","issue_events_url":"https://api.github.com/repos/refack/node/issues/events{/number}","events_url":"https://api.github.com/repos/refack/node/events","assignees_url":"https://api.github.com/repos/refack/node/assignees{/user}","branches_url":"https://api.github.com/repos/refack/node/branches{/branch}","tags_url":"https://api.github.com/repos/refack/node/tags","blobs_url":"https://api.github.com/repos/refack/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refack/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refack/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/refack/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refack/node/statuses/{sha}","languages_url":"https://api.github.com/repos/refack/node/languages","stargazers_url":"https://api.github.com/repos/refack/node/stargazers","contributors_url":"https://api.github.com/repos/refack/node/contributors","subscribers_url":"https://api.github.com/repos/refack/node/subscribers","subscription_url":"https://api.github.com/repos/refack/node/subscription","commits_url":"https://api.github.com/repos/refack/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/refack/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/refack/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/refack/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/refack/node/contents/{+path}","compare_url":"https://api.github.com/repos/refack/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refack/node/merges","archive_url":"https://api.github.com/repos/refack/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refack/node/downloads","issues_url":"https://api.github.com/repos/refack/node/issues{/number}","pulls_url":"https://api.github.com/repos/refack/node/pulls{/number}","milestones_url":"https://api.github.com/repos/refack/node/milestones{/number}","notifications_url":"https://api.github.com/repos/refack/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refack/node/labels{/name}","releases_url":"https://api.github.com/repos/refack/node/releases{/id}","deployments_url":"https://api.github.com/repos/refack/node/deployments","created_at":"2017-02-07T15:47:09Z","updated_at":"2018-11-01T02:28:41Z","pushed_at":"2018-11-06T14:39:21Z","git_url":"git://github.com/refack/node.git","ssh_url":"git@github.com:refack/node.git","clone_url":"https://github.com/refack/node.git","svn_url":"https://github.com/refack/node","homepage":"https://nodejs.org","size":408775,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"0f63d84f807edb17466f9357a630467cf608f954","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-06T14:33:22Z","pushed_at":"2018-11-06T14:39:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":430198,"stargazers_count":55122,"watchers_count":55122,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12046,"mirror_url":null,"archived":false,"open_issues_count":877,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12046,"open_issues":877,"watchers":55122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/23739"},"html":{"href":"https://github.com/nodejs/node/pull/23739"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/23739"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/23739/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/23739/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/23739/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/bec505bed7518697ad4679b864c1adbb1162a0fa"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"refack"}}