{"action":"created","issue":{"url":"https://api.github.com/repos/runconduit/conduit/issues/1115","repository_url":"https://api.github.com/repos/runconduit/conduit","labels_url":"https://api.github.com/repos/runconduit/conduit/issues/1115/labels{/name}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/1115/comments","events_url":"https://api.github.com/repos/runconduit/conduit/issues/1115/events","html_url":"https://github.com/runconduit/conduit/pull/1115","id":332060886,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjM2OTY3","number":1115,"title":"proxy: Refactor `convert` from crate to module","user":{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"labels":[{"id":773709989,"node_id":"MDU6TGFiZWw3NzM3MDk5ODk=","url":"https://api.github.com/repos/runconduit/conduit/labels/area/proxy","name":"area/proxy","color":"0052CC","default":false}],"state":"open","locked":false,"assignee":{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"assignees":[{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-13T15:59:35Z","updated_at":"2018-06-13T17:56:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/1115","html_url":"https://github.com/runconduit/conduit/pull/1115","diff_url":"https://github.com/runconduit/conduit/pull/1115.diff","patch_url":"https://github.com/runconduit/conduit/pull/1115.patch"},"body":"In e2093e3, we created a `convert` crate when refactoring the proxy's\r\ngRPC bindings into a dedicated crate.\r\n\r\nIt's not really necessary to handle `convert` as a crate, given that it\r\nholds a single 39-line file that's mostly comments. It's possible to\r\n\"vendor\" this file in the proxy and controller-grpc crates because\r\nneither crate requires that the other use the same type."},"comment":{"url":"https://api.github.com/repos/runconduit/conduit/issues/comments/397029027","html_url":"https://github.com/runconduit/conduit/pull/1115#issuecomment-397029027","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/1115","id":397029027,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzAyOTAyNw==","user":{"login":"seanmonstar","id":51479,"node_id":"MDQ6VXNlcjUxNDc5","avatar_url":"https://avatars1.githubusercontent.com/u/51479?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T17:56:39Z","updated_at":"2018-06-13T17:56:39Z","author_association":"CONTRIBUTOR","body":"Does doing this provide some benefit? If so, it'd be useful to have that here in the comment history for when we forget."}}
{"actor":{"display_login":"seanmonstar"}}