{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/235935668","pull_request_review_id":177920142,"id":235935668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkzNTY2OA==","diff_hunk":"@@ -44,10 +45,19 @@ public async Task InitializeAsync(IConsensus consensusParameters, ChainedHeader\n \n             int heightToSyncTo = tip.Height > this.numberOfBlocksToKeep ? tip.Height - this.numberOfBlocksToKeep : 0;\n \n-            for (int i = tip.Height; i >= heightToSyncTo; i--)\n+            for (int i = tip.Height - 1; i >= heightToSyncTo; i--)","path":"src/Stratis.Bitcoin.Features.Consensus/ProvenBlockHeaders/RewindDataIndexStore.cs","position":13,"original_position":13,"commit_id":"2a9b92a29160d61160755997c308cb131aa59838","original_commit_id":"2a9b92a29160d61160755997c308cb131aa59838","user":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"body":"We should not have rewind data of current tip, that was the reason there was a `continue;` there before, the continue is wrong because there should always be rewind data for past blocks, so better is to start form the right place and throw if not found.","created_at":"2018-11-23T13:08:21Z","updated_at":"2018-11-23T13:08:21Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807#discussion_r235935668","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/235935668"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807#discussion_r235935668"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807"}},"in_reply_to_id":235921608},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807","id":233059686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDU5Njg2","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2807","number":2807,"state":"open","locked":false,"title":"PH store to use sorted dictionary","user":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-22T19:09:52Z","updated_at":"2018-11-23T13:08:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f19fd89c2ed5273875d7ad02162ce5f9e61c4d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2807/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2a9b92a29160d61160755997c308cb131aa59838","head":{"label":"dangershony:ph-store-sorting","ref":"ph-store-sorting","sha":"2a9b92a29160d61160755997c308cb131aa59838","user":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"repo":{"id":68708758,"node_id":"MDEwOlJlcG9zaXRvcnk2ODcwODc1OA==","name":"StratisBitcoinFullNode","full_name":"dangershony/StratisBitcoinFullNode","private":false,"owner":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dangershony/StratisBitcoinFullNode","description":null,"fork":true,"url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/deployments","created_at":"2016-09-20T12:18:08Z","updated_at":"2016-09-20T12:18:09Z","pushed_at":"2018-11-22T19:09:21Z","git_url":"git://github.com/dangershony/StratisBitcoinFullNode.git","ssh_url":"git@github.com:dangershony/StratisBitcoinFullNode.git","clone_url":"https://github.com/dangershony/StratisBitcoinFullNode.git","svn_url":"https://github.com/dangershony/StratisBitcoinFullNode","homepage":null,"size":39771,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"2487b32706f2c97544a0620f84ae4bba1e981410","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","private":false,"owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-11-23T09:45:43Z","pushed_at":"2018-11-23T10:04:18Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":38693,"stargazers_count":592,"watchers_count":592,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":262,"open_issues":217,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2807"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2807"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2807/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2807/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2a9b92a29160d61160755997c308cb131aa59838"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dangershony"}}