{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/204397673","pull_request_review_id":139468683,"id":204397673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDM5NzY3Mw==","diff_hunk":"@@ -2291,7 +2289,9 @@ lexer_expect_object_literal_id (parser_context_t *context_p, /**< context */\n         lexer_skip_spaces (context_p);\n \n         if (context_p->source_p < context_p->source_end_p\n-            && context_p->source_p[0] != LIT_CHAR_COLON)\n+            && context_p->source_p[0] != LIT_CHAR_COLON\n+            && context_p->source_p[0] != LIT_CHAR_RIGHT_BRACE\n+            && context_p->source_p[0] != LIT_CHAR_COMMA)","path":"jerry-core/parser/js/js-lexer.c","position":23,"original_position":23,"commit_id":"089ac6ab62a3ccaf72b1f384e64b42e8c52a03c5","original_commit_id":"089ac6ab62a3ccaf72b1f384e64b42e8c52a03c5","user":{"login":"zherczeg","id":2270193,"node_id":"MDQ6VXNlcjIyNzAxOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2270193?v=4","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"I mean the pre-scanner which checks JS code early. It is used by `switch`, `for-in`, etc.","created_at":"2018-07-23T13:21:16Z","updated_at":"2018-07-23T13:21:16Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2432#discussion_r204397673","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/204397673"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2432#discussion_r204397673"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432"}},"in_reply_to_id":204391836},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432","id":202948083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTQ4MDgz","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2432","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/2432.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/2432.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2432","number":2432,"state":"open","locked":false,"title":"Support for shorthand object literal notation.","user":{"login":"AnthonyCalandra","id":952574,"node_id":"MDQ6VXNlcjk1MjU3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/952574?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyCalandra","html_url":"https://github.com/AnthonyCalandra","followers_url":"https://api.github.com/users/AnthonyCalandra/followers","following_url":"https://api.github.com/users/AnthonyCalandra/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyCalandra/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyCalandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyCalandra/subscriptions","organizations_url":"https://api.github.com/users/AnthonyCalandra/orgs","repos_url":"https://api.github.com/users/AnthonyCalandra/repos","events_url":"https://api.github.com/users/AnthonyCalandra/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyCalandra/received_events","type":"User","site_admin":false},"body":"This pull request adds support for object literal shorthand notation (properties and methods). In code:\r\n```js\r\nlet foo = 1;\r\nlet bar = { foo }; // Equivalent to: { foo: foo }\r\nlet baz = {\r\n  fn() {\r\n    return 123;\r\n  }\r\n}; // Equivalent to: { fn: function() { return 123; } }\r\n```\r\nJerryScript-DCO-1.0-Signed-off-by: Anthony Calandra anthony@anthony-calandra.com","created_at":"2018-07-20T20:25:37Z","updated_at":"2018-07-23T13:21:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2756f160f4b9481067619285a46d69ccf504be6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2432/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/089ac6ab62a3ccaf72b1f384e64b42e8c52a03c5","head":{"label":"AnthonyCalandra:shorthand-obj-literal-notation","ref":"shorthand-obj-literal-notation","sha":"089ac6ab62a3ccaf72b1f384e64b42e8c52a03c5","user":{"login":"AnthonyCalandra","id":952574,"node_id":"MDQ6VXNlcjk1MjU3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/952574?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyCalandra","html_url":"https://github.com/AnthonyCalandra","followers_url":"https://api.github.com/users/AnthonyCalandra/followers","following_url":"https://api.github.com/users/AnthonyCalandra/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyCalandra/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyCalandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyCalandra/subscriptions","organizations_url":"https://api.github.com/users/AnthonyCalandra/orgs","repos_url":"https://api.github.com/users/AnthonyCalandra/repos","events_url":"https://api.github.com/users/AnthonyCalandra/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyCalandra/received_events","type":"User","site_admin":false},"repo":{"id":134870163,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4NzAxNjM=","name":"jerryscript","full_name":"AnthonyCalandra/jerryscript","owner":{"login":"AnthonyCalandra","id":952574,"node_id":"MDQ6VXNlcjk1MjU3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/952574?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyCalandra","html_url":"https://github.com/AnthonyCalandra","followers_url":"https://api.github.com/users/AnthonyCalandra/followers","following_url":"https://api.github.com/users/AnthonyCalandra/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyCalandra/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyCalandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyCalandra/subscriptions","organizations_url":"https://api.github.com/users/AnthonyCalandra/orgs","repos_url":"https://api.github.com/users/AnthonyCalandra/repos","events_url":"https://api.github.com/users/AnthonyCalandra/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyCalandra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnthonyCalandra/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":true,"url":"https://api.github.com/repos/AnthonyCalandra/jerryscript","forks_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/forks","keys_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/teams","hooks_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/events","assignees_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/tags","blobs_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/languages","stargazers_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/subscription","commits_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/merges","archive_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/downloads","issues_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/AnthonyCalandra/jerryscript/deployments","created_at":"2018-05-25T14:56:56Z","updated_at":"2018-07-20T00:04:55Z","pushed_at":"2018-07-22T02:07:43Z","git_url":"git://github.com/AnthonyCalandra/jerryscript.git","ssh_url":"git@github.com:AnthonyCalandra/jerryscript.git","clone_url":"https://github.com/AnthonyCalandra/jerryscript.git","svn_url":"https://github.com/AnthonyCalandra/jerryscript","homepage":"http://jerryscript.net","size":45255,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"77d9314b1d0de684a44df51a8bd7f63182b9c4ca","user":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"node_id":"MDEwOlJlcG9zaXRvcnkzMzMzOTY2MA==","name":"jerryscript","full_name":"jerryscript-project/jerryscript","owner":{"login":"jerryscript-project","id":23194380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTk0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2018-07-23T11:10:49Z","pushed_at":"2018-07-23T13:13:57Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":46386,"stargazers_count":3150,"watchers_count":3150,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":362,"open_issues":50,"watchers":3150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2432"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2432"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2432/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2432/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/089ac6ab62a3ccaf72b1f384e64b42e8c52a03c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zherczeg"}}