{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/OrN/rscplus/pulls/63","id":189098482,"html_url":"https://github.com/OrN/rscplus/pull/63","diff_url":"https://github.com/OrN/rscplus/pull/63.diff","patch_url":"https://github.com/OrN/rscplus/pull/63.patch","issue_url":"https://api.github.com/repos/OrN/rscplus/issues/63","number":63,"state":"closed","locked":false,"title":"Feature - Highlight & Block lists","user":{"login":"nickzuber","id":10540865,"avatar_url":"https://avatars1.githubusercontent.com/u/10540865?v=4","gravatar_id":"","url":"https://api.github.com/users/nickzuber","html_url":"https://github.com/nickzuber","followers_url":"https://api.github.com/users/nickzuber/followers","following_url":"https://api.github.com/users/nickzuber/following{/other_user}","gists_url":"https://api.github.com/users/nickzuber/gists{/gist_id}","starred_url":"https://api.github.com/users/nickzuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickzuber/subscriptions","organizations_url":"https://api.github.com/users/nickzuber/orgs","repos_url":"https://api.github.com/users/nickzuber/repos","events_url":"https://api.github.com/users/nickzuber/events{/privacy}","received_events_url":"https://api.github.com/users/nickzuber/received_events","type":"User","site_admin":false},"body":"## What's New\r\n\r\nThis introduces a configurable highlight list and block list in the settings tab in the `Overlays` tab.\r\n\r\n<details>\r\n<summary>Screenshot of Overlay tab in Settings</summary>\r\n<img src=\"https://user-images.githubusercontent.com/10540865/40250405-2c3d04e0-5aa4-11e8-86d6-96ee1193141b.png\" />\r\n</details>\r\n\r\n## Blocked Items\r\n\r\nThese are items that will not be shown on the ground when `iteminfo` is enabled.\r\n\r\n## Highlighted Items\r\n\r\nThese are items that have a different color when they appear on the ground (when `iteminfo` is enabled), and there's an additional little star that appears next to the text.\r\n\r\n<details>\r\n<summary>Screenshot of highlighted & blocked items in the game</summary>\r\n<img src=\"https://user-images.githubusercontent.com/10540865/40250484-6bef219a-5aa4-11e8-9b25-2f6e691bd65d.png\" />\r\n</details>\r\n\r\n## Comments & Improvements\r\n\r\nA list is just a comma separated string so we can easily handle that within the settings. When we check for an item in a list, we convert it into an array and then check to see if the item is a substring of any of the items in the list. \r\n\r\nFor example, if you have `lob` in your block list, it will block all items that contain the string `lob` like `Lobster pot` or `Raw lobster` etc. It is not case sensitive. \r\n\r\nI haven't noticed any performance related issues while using this implementation (from having to convert the string list into an array constantly whenever we attempt to draw an item), but if we wanted to improve this there are a couple of ways:\r\n\r\n - Store the lists as arrays; whenever we save the settings, decode the array into the comma separated string and store it. Whenever we load the settings, we'd encode the string into an array and keep that representation as the actual settings value.\r\n\r\n## UPDATE\r\n\r\nI ended up just implementing the idea above:\r\n\r\nStore the lists as arrays; whenever we save the settings, decode the array into the comma separated string and store it. Whenever we load the settings, we'd encode the string into an array and keep that representation as the actual settings value.\r\n\r\nCloses #51 \r\n","created_at":"2018-05-18T18:13:53Z","updated_at":"2018-05-20T17:03:05Z","closed_at":"2018-05-20T17:03:05Z","merged_at":"2018-05-20T17:03:04Z","merge_commit_sha":"dd4d46d0302b35296cc8bb5a98cdcba9f60b260d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OrN/rscplus/pulls/63/commits","review_comments_url":"https://api.github.com/repos/OrN/rscplus/pulls/63/comments","review_comment_url":"https://api.github.com/repos/OrN/rscplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrN/rscplus/issues/63/comments","statuses_url":"https://api.github.com/repos/OrN/rscplus/statuses/f1d0bba89212bd8ffb46ebc80dbe372744298904","head":{"label":"nickzuber:block-list","ref":"block-list","sha":"f1d0bba89212bd8ffb46ebc80dbe372744298904","user":{"login":"nickzuber","id":10540865,"avatar_url":"https://avatars1.githubusercontent.com/u/10540865?v=4","gravatar_id":"","url":"https://api.github.com/users/nickzuber","html_url":"https://github.com/nickzuber","followers_url":"https://api.github.com/users/nickzuber/followers","following_url":"https://api.github.com/users/nickzuber/following{/other_user}","gists_url":"https://api.github.com/users/nickzuber/gists{/gist_id}","starred_url":"https://api.github.com/users/nickzuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickzuber/subscriptions","organizations_url":"https://api.github.com/users/nickzuber/orgs","repos_url":"https://api.github.com/users/nickzuber/repos","events_url":"https://api.github.com/users/nickzuber/events{/privacy}","received_events_url":"https://api.github.com/users/nickzuber/received_events","type":"User","site_admin":false},"repo":{"id":106733839,"name":"rscplus","full_name":"nickzuber/rscplus","owner":{"login":"nickzuber","id":10540865,"avatar_url":"https://avatars1.githubusercontent.com/u/10540865?v=4","gravatar_id":"","url":"https://api.github.com/users/nickzuber","html_url":"https://github.com/nickzuber","followers_url":"https://api.github.com/users/nickzuber/followers","following_url":"https://api.github.com/users/nickzuber/following{/other_user}","gists_url":"https://api.github.com/users/nickzuber/gists{/gist_id}","starred_url":"https://api.github.com/users/nickzuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickzuber/subscriptions","organizations_url":"https://api.github.com/users/nickzuber/orgs","repos_url":"https://api.github.com/users/nickzuber/repos","events_url":"https://api.github.com/users/nickzuber/events{/privacy}","received_events_url":"https://api.github.com/users/nickzuber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickzuber/rscplus","description":"RuneScape Classic client mod","fork":true,"url":"https://api.github.com/repos/nickzuber/rscplus","forks_url":"https://api.github.com/repos/nickzuber/rscplus/forks","keys_url":"https://api.github.com/repos/nickzuber/rscplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickzuber/rscplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickzuber/rscplus/teams","hooks_url":"https://api.github.com/repos/nickzuber/rscplus/hooks","issue_events_url":"https://api.github.com/repos/nickzuber/rscplus/issues/events{/number}","events_url":"https://api.github.com/repos/nickzuber/rscplus/events","assignees_url":"https://api.github.com/repos/nickzuber/rscplus/assignees{/user}","branches_url":"https://api.github.com/repos/nickzuber/rscplus/branches{/branch}","tags_url":"https://api.github.com/repos/nickzuber/rscplus/tags","blobs_url":"https://api.github.com/repos/nickzuber/rscplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickzuber/rscplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickzuber/rscplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickzuber/rscplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickzuber/rscplus/statuses/{sha}","languages_url":"https://api.github.com/repos/nickzuber/rscplus/languages","stargazers_url":"https://api.github.com/repos/nickzuber/rscplus/stargazers","contributors_url":"https://api.github.com/repos/nickzuber/rscplus/contributors","subscribers_url":"https://api.github.com/repos/nickzuber/rscplus/subscribers","subscription_url":"https://api.github.com/repos/nickzuber/rscplus/subscription","commits_url":"https://api.github.com/repos/nickzuber/rscplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickzuber/rscplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickzuber/rscplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickzuber/rscplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickzuber/rscplus/contents/{+path}","compare_url":"https://api.github.com/repos/nickzuber/rscplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickzuber/rscplus/merges","archive_url":"https://api.github.com/repos/nickzuber/rscplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickzuber/rscplus/downloads","issues_url":"https://api.github.com/repos/nickzuber/rscplus/issues{/number}","pulls_url":"https://api.github.com/repos/nickzuber/rscplus/pulls{/number}","milestones_url":"https://api.github.com/repos/nickzuber/rscplus/milestones{/number}","notifications_url":"https://api.github.com/repos/nickzuber/rscplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickzuber/rscplus/labels{/name}","releases_url":"https://api.github.com/repos/nickzuber/rscplus/releases{/id}","deployments_url":"https://api.github.com/repos/nickzuber/rscplus/deployments","created_at":"2017-10-12T19:01:54Z","updated_at":"2018-05-18T15:52:11Z","pushed_at":"2018-05-18T20:57:27Z","git_url":"git://github.com/nickzuber/rscplus.git","ssh_url":"git@github.com:nickzuber/rscplus.git","clone_url":"https://github.com/nickzuber/rscplus.git","svn_url":"https://github.com/nickzuber/rscplus","homepage":"http://orn.github.io/rscplus/","size":10609,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OrN:master","ref":"master","sha":"a64b9f73678471ce1b828485bc505b72d6e3cb53","user":{"login":"OrN","id":10935290,"avatar_url":"https://avatars1.githubusercontent.com/u/10935290?v=4","gravatar_id":"","url":"https://api.github.com/users/OrN","html_url":"https://github.com/OrN","followers_url":"https://api.github.com/users/OrN/followers","following_url":"https://api.github.com/users/OrN/following{/other_user}","gists_url":"https://api.github.com/users/OrN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrN/subscriptions","organizations_url":"https://api.github.com/users/OrN/orgs","repos_url":"https://api.github.com/users/OrN/repos","events_url":"https://api.github.com/users/OrN/events{/privacy}","received_events_url":"https://api.github.com/users/OrN/received_events","type":"User","site_admin":false},"repo":{"id":49876507,"name":"rscplus","full_name":"OrN/rscplus","owner":{"login":"OrN","id":10935290,"avatar_url":"https://avatars1.githubusercontent.com/u/10935290?v=4","gravatar_id":"","url":"https://api.github.com/users/OrN","html_url":"https://github.com/OrN","followers_url":"https://api.github.com/users/OrN/followers","following_url":"https://api.github.com/users/OrN/following{/other_user}","gists_url":"https://api.github.com/users/OrN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrN/subscriptions","organizations_url":"https://api.github.com/users/OrN/orgs","repos_url":"https://api.github.com/users/OrN/repos","events_url":"https://api.github.com/users/OrN/events{/privacy}","received_events_url":"https://api.github.com/users/OrN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OrN/rscplus","description":"RuneScape Classic client mod","fork":false,"url":"https://api.github.com/repos/OrN/rscplus","forks_url":"https://api.github.com/repos/OrN/rscplus/forks","keys_url":"https://api.github.com/repos/OrN/rscplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrN/rscplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrN/rscplus/teams","hooks_url":"https://api.github.com/repos/OrN/rscplus/hooks","issue_events_url":"https://api.github.com/repos/OrN/rscplus/issues/events{/number}","events_url":"https://api.github.com/repos/OrN/rscplus/events","assignees_url":"https://api.github.com/repos/OrN/rscplus/assignees{/user}","branches_url":"https://api.github.com/repos/OrN/rscplus/branches{/branch}","tags_url":"https://api.github.com/repos/OrN/rscplus/tags","blobs_url":"https://api.github.com/repos/OrN/rscplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrN/rscplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrN/rscplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrN/rscplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrN/rscplus/statuses/{sha}","languages_url":"https://api.github.com/repos/OrN/rscplus/languages","stargazers_url":"https://api.github.com/repos/OrN/rscplus/stargazers","contributors_url":"https://api.github.com/repos/OrN/rscplus/contributors","subscribers_url":"https://api.github.com/repos/OrN/rscplus/subscribers","subscription_url":"https://api.github.com/repos/OrN/rscplus/subscription","commits_url":"https://api.github.com/repos/OrN/rscplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrN/rscplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrN/rscplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrN/rscplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrN/rscplus/contents/{+path}","compare_url":"https://api.github.com/repos/OrN/rscplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrN/rscplus/merges","archive_url":"https://api.github.com/repos/OrN/rscplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrN/rscplus/downloads","issues_url":"https://api.github.com/repos/OrN/rscplus/issues{/number}","pulls_url":"https://api.github.com/repos/OrN/rscplus/pulls{/number}","milestones_url":"https://api.github.com/repos/OrN/rscplus/milestones{/number}","notifications_url":"https://api.github.com/repos/OrN/rscplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrN/rscplus/labels{/name}","releases_url":"https://api.github.com/repos/OrN/rscplus/releases{/id}","deployments_url":"https://api.github.com/repos/OrN/rscplus/deployments","created_at":"2016-01-18T12:49:59Z","updated_at":"2018-05-18T06:35:48Z","pushed_at":"2018-05-20T17:03:04Z","git_url":"git://github.com/OrN/rscplus.git","ssh_url":"git@github.com:OrN/rscplus.git","clone_url":"https://github.com/OrN/rscplus.git","svn_url":"https://github.com/OrN/rscplus","homepage":"http://orn.github.io/rscplus/","size":10592,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":14,"open_issues":7,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OrN/rscplus/pulls/63"},"html":{"href":"https://github.com/OrN/rscplus/pull/63"},"issue":{"href":"https://api.github.com/repos/OrN/rscplus/issues/63"},"comments":{"href":"https://api.github.com/repos/OrN/rscplus/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/OrN/rscplus/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/OrN/rscplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrN/rscplus/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/OrN/rscplus/statuses/f1d0bba89212bd8ffb46ebc80dbe372744298904"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"OrN","id":10935290,"avatar_url":"https://avatars1.githubusercontent.com/u/10935290?v=4","gravatar_id":"","url":"https://api.github.com/users/OrN","html_url":"https://github.com/OrN","followers_url":"https://api.github.com/users/OrN/followers","following_url":"https://api.github.com/users/OrN/following{/other_user}","gists_url":"https://api.github.com/users/OrN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrN/subscriptions","organizations_url":"https://api.github.com/users/OrN/orgs","repos_url":"https://api.github.com/users/OrN/repos","events_url":"https://api.github.com/users/OrN/events{/privacy}","received_events_url":"https://api.github.com/users/OrN/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":156,"deletions":10,"changed_files":7}}
{"actor":{"display_login":"OrN"}}