{"action":"closed","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2425","repository_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy","labels_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2425/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2425/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2425/events","html_url":"https://github.com/rust-lang-nursery/rust-clippy/issues/2425","id":293615218,"number":2425,"title":"clippy_lints v0.0.184 doesn't compile ","user":{"login":"masonk","id":449998,"avatar_url":"https://avatars0.githubusercontent.com/u/449998?v=4","gravatar_id":"","url":"https://api.github.com/users/masonk","html_url":"https://github.com/masonk","followers_url":"https://api.github.com/users/masonk/followers","following_url":"https://api.github.com/users/masonk/following{/other_user}","gists_url":"https://api.github.com/users/masonk/gists{/gist_id}","starred_url":"https://api.github.com/users/masonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masonk/subscriptions","organizations_url":"https://api.github.com/users/masonk/orgs","repos_url":"https://api.github.com/users/masonk/repos","events_url":"https://api.github.com/users/masonk/events{/privacy}","received_events_url":"https://api.github.com/users/masonk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-01T17:21:03Z","updated_at":"2018-02-05T07:08:16Z","closed_at":"2018-02-05T07:08:16Z","author_association":"NONE","body":"I tried to add Clippy to my project today, but it didn't compile. I tried in Windows 10 and WSL (Ubuntu).\r\nRust nightly 1.25.0.\r\n\r\nIt's like the `label` field was removed from a struct and downstream code wasn't updated.\r\n\r\n\r\nError message\r\n\r\n```\r\nmason@mason-gaming-pc:~/dev/rust/golden$ cargo +nightly build --features \"clippy\" --verbose\r\n       Fresh left-pad v1.0.1\r\n       Fresh dtoa v0.4.2\r\n       Fresh quote v0.3.15\r\n       Fresh matches v0.1.6\r\n       Fresh either v1.4.0\r\n       Fresh lazy_static v1.0.0\r\n       Fresh quine-mc_cluskey v0.2.4\r\n       Fresh bitflags v0.9.1\r\n       Fresh regex-syntax v0.4.2\r\n       Fresh percent-encoding v1.0.1\r\n       Fresh itoa v0.3.4\r\n       Fresh libc v0.2.36\r\n       Fresh vec_map v0.8.0\r\n       Fresh unicode-normalization v0.1.5\r\n       Fresh if_chain v0.1.2\r\n       Fresh getopts v0.2.17\r\n       Fresh utf8-ranges v1.0.0\r\n       Fresh unicode-xid v0.0.4\r\n       Fresh num-traits v0.1.42\r\n       Fresh semver-parser v0.7.0\r\n       Fresh lazy_static v0.1.16\r\n       Fresh void v1.0.2\r\n       Fresh serde v1.0.27\r\n       Fresh unicode-bidi v0.3.4\r\n       Fresh itertools v0.6.5\r\n       Fresh memchr v2.0.1\r\n       Fresh synom v0.11.3\r\n       Fresh semver v0.6.0\r\n       Fresh unreachable v1.0.0\r\n       Fresh toml v0.4.5\r\n       Fresh serde_json v1.0.9\r\n       Fresh idna v0.1.4\r\n       Fresh aho-corasick v0.6.4\r\n       Fresh syn v0.11.11\r\n       Fresh thread_local v0.3.5\r\n       Fresh pulldown-cmark v0.0.15\r\n       Fresh url v1.6.0\r\n       Fresh serde_derive_internals v0.19.0\r\n       Fresh regex v0.2.5\r\n       Fresh serde_derive v1.0.27\r\n   Compiling clippy_lints v0.0.184\r\n       Fresh cargo_metadata v0.2.3\r\n     Running `rustc --crate-name clippy_lints /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=cb8c0529306695b6 -C extra-filename=-cb8c0529306695b6 --out-dir /mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps -L dependency=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps --extern semver=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libsemver-d67c3d0a5514e050.rlib --extern pulldown_cmark=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libpulldown_cmark-b6274c104a4ed161.rlib --extern quine_mc_cluskey=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libquine_mc_cluskey-ebc359e1ace7a017.rlib --extern itertools=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libitertools-78ea1062c84dabe4.rlib --extern regex_syntax=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libregex_syntax-fa8602255742fda4.rlib --extern lazy_static=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/liblazy_static-81d07c4e79860199.rlib --extern if_chain=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libif_chain-5deb8c66f3e01bac.rlib --extern serde=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libserde-7017de094d273885.rlib --extern toml=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libtoml-2949ae399a9a9d88.rlib --extern unicode_normalization=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libunicode_normalization-9b8361452867f8a7.rlib --extern url=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/liburl-d537e41b61bb3fd7.rlib --extern serde_derive=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libserde_derive-0e212090d3b1aec7.so --extern matches=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libmatches-32edb66e6ed63589.rlib --cap-lints allow`\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:76:26\r\n   |\r\n76 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                          ^^^^^ unknown field\r\n   |\r\n   = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:76:37\r\n   |\r\n76 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                                     ^^^^^ unknown field\r\n   |\r\n   = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `name` on type `&_`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:76:53\r\n   |\r\n76 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                                                     ^^^^\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:90:26\r\n   |\r\n90 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                          ^^^^^ unknown field\r\n   |\r\n   = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:90:37\r\n   |\r\n90 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                                     ^^^^^ unknown field\r\n   |\r\n   = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `name` on type `&_`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:90:53\r\n   |\r\n90 |                 both(&li.label, &ri.label, |l, r| l.name.as_str() == r.name.as_str())\r\n   |                                                     ^^^^\r\n\r\nerror[E0609]: no field `name` on type `&syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:108:78\r\n    |\r\n108 |                 lls == rls && self.eq_block(lb, rb) && both(ll, rl, |l, r| l.name.as_str() == r.name.as_str())\r\n    |                                                                              ^^^^\r\n\r\nerror[E0609]: no field `name` on type `&syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:108:97\r\n    |\r\n108 |                 lls == rls && self.eq_block(lb, rb) && both(ll, rl, |l, r| l.name.as_str() == r.name.as_str())\r\n    |                                                                                                 ^^^^\r\n\r\nerror[E0609]: no field `name` on type `&syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:134:88\r\n    |\r\n134 |                 self.eq_expr(lc, rc) && self.eq_block(lb, rb) && both(ll, rl, |l, r| l.name.as_str() == r.name.as_str())\r\n    |                                                                                        ^^^^\r\n\r\nerror[E0609]: no field `name` on type `&syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:134:107\r\n    |\r\n134 |                 self.eq_expr(lc, rc) && self.eq_block(lb, rb) && both(ll, rl, |l, r| l.name.as_str() == r.name.as_str())\r\n    |                                                                                                           ^^^^\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:330:36\r\n    |\r\n330 |                 if let Some(i) = i.label {\r\n    |                                    ^^^^^ unknown field\r\n    |\r\n    = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:367:36\r\n    |\r\n367 |                 if let Some(i) = i.label {\r\n    |                                    ^^^^^ unknown field\r\n    |\r\n    = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `name` on type `syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:432:39\r\n    |\r\n432 |                     self.hash_name(&i.name);\r\n    |                                       ^^^^ unknown field\r\n    |\r\n    = note: available fields are: `node`, `span`\r\n\r\nerror[E0609]: no field `name` on type `syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/hir_utils.rs:527:39\r\n    |\r\n527 |                     self.hash_name(&l.name);\r\n    |                                       ^^^^ unknown field\r\n    |\r\n    = note: available fields are: `node`, `span`\r\n\r\nerror[E0599]: no method named `next_point` found for type `&syntax::codemap::CodeMap` in the current scope\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/utils/sugg.rs:505:38\r\n    |\r\n505 |         let hi = cx.sess().codemap().next_point(remove_span).hi();\r\n    |                                      ^^^^^^^^^^\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n    --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/loops.rs:1811:50\r\n     |\r\n1811 |         ExprBreak(dest, ref passed_expr) if dest.label.is_none() && passed_expr.is_none() => true,\r\n     |                                                  ^^^^^ unknown field\r\n     |\r\n     = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0599]: no method named `next_point` found for type `&syntax::codemap::CodeMap` in the current scope\r\n    --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/methods.rs:1170:54\r\n     |\r\n1170 |                 let next_point = cx.sess().codemap().next_point(fold_args[0].span);\r\n     |                                                      ^^^^^^^^^^\r\n\r\nerror[E0061]: this function takes 2 parameters but 1 parameter was supplied\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/misc.rs:548:10\r\n    |\r\n548 |         .builtin_deref(true)\r\n    |          ^^^^^^^^^^^^^ expected 2 parameters\r\n\r\nerror[E0061]: this function takes 2 parameters but 1 parameter was supplied\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/misc.rs:552:10\r\n    |\r\n552 |         .builtin_deref(true)\r\n    |          ^^^^^^^^^^^^^ expected 2 parameters\r\n\r\nerror[E0023]: this pattern has 5 fields, but the corresponding tuple variant has 4 fields\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/misc_early.rs:299:24\r\n    |\r\n299 |                 if let ExprKind::Closure(_, _, ref decl, ref block, _) = closure.node {\r\n    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 4 fields, found 5\r\n\r\nerror[E0023]: this pattern has 5 fields, but the corresponding tuple variant has 4 fields\r\n   --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/misc_early.rs:330:24\r\n    |\r\n330 |                 if let ExprKind::Closure(_, _, _, _, _) = t.node;\r\n    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 4 fields, found 5\r\n\r\nerror[E0609]: no field `label` on type `rustc::hir::Destination`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/unused_label.rs:72:110\r\n   |\r\n72 |             hir::ExprBreak(destination, _) | hir::ExprAgain(destination) => if let Some(label) = destination.label {\r\n   |                                                                                                              ^^^^^ unknown field\r\n   |\r\n   = note: available fields are: `ident`, `target_id`\r\n\r\nerror[E0609]: no field `name` on type `syntax::codemap::Spanned<syntax::ast::Symbol>`\r\n  --> /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/unused_label.rs:76:42\r\n   |\r\n76 |                 self.labels.insert(label.name.as_str(), expr.span);\r\n   |                                          ^^^^ unknown field\r\n   |\r\n   = note: available fields are: `node`, `span`\r\n\r\nerror: aborting due to 23 previous errors\r\n\r\nerror: Could not compile `clippy_lints`.\r\n\r\nCaused by:\r\n  process didn't exit successfully: `rustc --crate-name clippy_lints /mnt/c/Users/mason_000/wsl/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.184/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=cb8c0529306695b6 -C extra-filename=-cb8c0529306695b6 --out-dir /mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps -L dependency=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps --extern semver=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libsemver-d67c3d0a5514e050.rlib --extern pulldown_cmark=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libpulldown_cmark-b6274c104a4ed161.rlib --extern quine_mc_cluskey=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libquine_mc_cluskey-ebc359e1ace7a017.rlib --extern itertools=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libitertools-78ea1062c84dabe4.rlib --extern regex_syntax=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libregex_syntax-fa8602255742fda4.rlib --extern lazy_static=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/liblazy_static-81d07c4e79860199.rlib --extern if_chain=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libif_chain-5deb8c66f3e01bac.rlib --extern serde=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libserde-7017de094d273885.rlib --extern toml=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libtoml-2949ae399a9a9d88.rlib --extern unicode_normalization=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libunicode_normalization-9b8361452867f8a7.rlib --extern url=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/liburl-d537e41b61bb3fd7.rlib --extern serde_derive=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libserde_derive-0e212090d3b1aec7.so --extern matches=/mnt/c/Users/mason_000/wsl/dev/rust/golden/target/debug/deps/libmatches-32edb66e6ed63589.rlib --cap-lints allow` (exit code: 101)\r\nmason@mason-gaming-pc:~/dev/rust/golden$\r\n```\r\n\r\n```\r\nmason@mason-gaming-pc:~/dev/rust/golden$ rustup show\r\nDefault host: x86_64-unknown-linux-gnu\r\n\r\ninstalled toolchains\r\n--------------------\r\n\r\nstable-x86_64-unknown-linux-gnu\r\nnightly-x86_64-unknown-linux-gnu (default)\r\n\r\nactive toolchain\r\n----------------\r\n\r\nnightly-x86_64-unknown-linux-gnu (default)\r\nrustc 1.25.0-nightly (73ac5d6a8 2018-01-11)\r\n```\r\n\r\n```\r\nPS C:\\Users\\mason_000\\wsl\\dev\\rust\\advent2017> rustup show\r\nDefault host: x86_64-pc-windows-msvc\r\n\r\ninstalled toolchains\r\n--------------------\r\n\r\nstable-x86_64-pc-windows-msvc\r\nbeta-x86_64-pc-windows-msvc\r\nnightly-x86_64-pc-windows-msvc (default)\r\n\r\nactive toolchain\r\n----------------\r\n\r\nnightly-x86_64-pc-windows-msvc (default)\r\nrustc 1.25.0-nightly (73ac5d6a8 2018-01-11)\r\n```\r\n\r\n"}}
{"actor":{"display_login":"oli-obk"}}