{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/206707612","pull_request_review_id":142174199,"id":206707612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcwNzYxMg==","diff_hunk":"@@ -52,15 +52,17 @@ def _get_module_root():\n \n def _run_test(args: argparse.Namespace):\n     initial_working_dir = os.getcwd()\n-    module_root = _get_module_root()\n-    logger.info(\"Changing directory to %s\", module_root)\n-    os.chdir(module_root)\n-    test_dir = os.path.join(module_root, \"tests\")\n+    module_parent = _get_module_root().parent\n+    logger.info(\"Changing directory to %s\", module_parent)\n+    os.chdir(module_parent)\n+    test_dir = os.path.join(module_parent, \"allennlp\")\n     logger.info(\"Running tests at %s\", test_dir)\n     if args.run_all:\n         # TODO(nfliu): remove this when notebooks have been rewritten as markdown.\n-        pytest.main([test_dir, '-k', 'not notebooks_test'])\n+        ec = pytest.main([test_dir, '--color=no', '-k', 'not notebooks_test'])\n     else:\n-        pytest.main([test_dir, '-k', 'not sniff_test and not notebooks_test'])\n+        ec = pytest.main([test_dir, '--color=no', '-k', 'not sniff_test and not notebooks_test',\n+                     '-m', 'not java'])\n     # Change back to original working directory after running tests\n     os.chdir(initial_working_dir)\n+    exit(ec)","path":"allennlp/commands/test_install.py","position":23,"original_position":23,"commit_id":"5483c7472bbe261e9fe3df05443043090672bc8f","original_commit_id":"5483c7472bbe261e9fe3df05443043090672bc8f","user":{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false},"body":"it looks fine, but I'm not familiar enough with the interplay of pytest and sys.exit to notice if it's wrong","created_at":"2018-07-31T22:47:28Z","updated_at":"2018-07-31T22:47:29Z","html_url":"https://github.com/allenai/allennlp/pull/1551#discussion_r206707612","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/1551","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/206707612"},"html":{"href":"https://github.com/allenai/allennlp/pull/1551#discussion_r206707612"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1551"}},"in_reply_to_id":206706863},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/1551","id":204953358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTUzMzU4","html_url":"https://github.com/allenai/allennlp/pull/1551","diff_url":"https://github.com/allenai/allennlp/pull/1551.diff","patch_url":"https://github.com/allenai/allennlp/pull/1551.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/1551","number":1551,"state":"open","locked":false,"title":"WIP: Skip tests that require Java in test-install","user":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"* Skip tests that require `java` when running `test-install` as we don't distribute Java via `pip`.\r\n* Exit with the same exit code as `pytest` when running `test-install`.\r\n* Run in the right directory so test fixtures are found.","created_at":"2018-07-30T23:00:06Z","updated_at":"2018-07-31T22:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a73eb1a2db950828aa53e654637720f13047962e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/1551/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/1551/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/1551/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/5483c7472bbe261e9fe3df05443043090672bc8f","head":{"label":"schmmd:avoid-java-tests","ref":"avoid-java-tests","sha":"5483c7472bbe261e9fe3df05443043090672bc8f","user":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"repo":{"id":95493347,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ5MzM0Nw==","name":"allennlp","full_name":"schmmd/allennlp","owner":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmmd/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/schmmd/allennlp","forks_url":"https://api.github.com/repos/schmmd/allennlp/forks","keys_url":"https://api.github.com/repos/schmmd/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmmd/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmmd/allennlp/teams","hooks_url":"https://api.github.com/repos/schmmd/allennlp/hooks","issue_events_url":"https://api.github.com/repos/schmmd/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/schmmd/allennlp/events","assignees_url":"https://api.github.com/repos/schmmd/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/schmmd/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/schmmd/allennlp/tags","blobs_url":"https://api.github.com/repos/schmmd/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmmd/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmmd/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmmd/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmmd/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/schmmd/allennlp/languages","stargazers_url":"https://api.github.com/repos/schmmd/allennlp/stargazers","contributors_url":"https://api.github.com/repos/schmmd/allennlp/contributors","subscribers_url":"https://api.github.com/repos/schmmd/allennlp/subscribers","subscription_url":"https://api.github.com/repos/schmmd/allennlp/subscription","commits_url":"https://api.github.com/repos/schmmd/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmmd/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmmd/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmmd/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmmd/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/schmmd/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmmd/allennlp/merges","archive_url":"https://api.github.com/repos/schmmd/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmmd/allennlp/downloads","issues_url":"https://api.github.com/repos/schmmd/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/schmmd/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/schmmd/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/schmmd/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmmd/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/schmmd/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/schmmd/allennlp/deployments","created_at":"2017-06-26T22:04:12Z","updated_at":"2018-06-19T15:17:12Z","pushed_at":"2018-07-31T22:39:36Z","git_url":"git://github.com/schmmd/allennlp.git","ssh_url":"git@github.com:schmmd/allennlp.git","clone_url":"https://github.com/schmmd/allennlp.git","svn_url":"https://github.com/schmmd/allennlp","homepage":null,"size":13278,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"10ac9ede83df2bb6747b42731e0a2fbabb680d61","user":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM1NjQwOA==","name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2018-07-31T22:01:40Z","pushed_at":"2018-07-31T22:39:38Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":13475,"stargazers_count":2833,"watchers_count":2833,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":470,"open_issues":84,"watchers":2833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1551"},"html":{"href":"https://github.com/allenai/allennlp/pull/1551"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1551"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1551/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1551/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1551/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/5483c7472bbe261e9fe3df05443043090672bc8f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joelgrus"}}