{"action":"created","comment":{"url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/comments/205957338","pull_request_review_id":141331099,"id":205957338,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk1NzMzOA==","diff_hunk":"@@ -0,0 +1,219 @@\n+<?php\n+\n+\tnamespace Stoic\\IO;\n+\n+\tuse Stoic\\IO\\SanitationHelper;\n+\n+\t/**\n+\t * Class ParameterHelper\n+\t *\n+\t * @package Stoic\\IO\n+\t * @version 1.0.0\n+\t */\n+\tclass ParameterHelper {\n+\n+\t\t/**\n+\t\t * Array of parameters.\n+\t\t *\n+\t\t * @var array\n+\t\t */\n+\t\tprivate $_parameters = array();\n+\n+\t\t/**\n+\t\t * Sanitation Helper\n+\t\t *\n+\t\t * @var SanitationHelper\n+\t\t */\n+\t\tprivate $_sanitizer = null;\n+\n+\t\t/**\n+\t\t * Creates a new ParameterHelper instance.\n+\t\t *\n+\t\t * @param array            $params    Array of parameters to dispense.\n+\t\t * @param SanitationHelper $sanitizer Helper class that sanitizes values to a specific type.\n+\t\t */\n+\t\tpublic function __construct(array $params = null, SanitationHelper $sanitizer = null) {\n+\t\t\tif (is_null($params)) {\n+\t\t\t\t$params = array();\n+\t\t\t}\n+\n+\t\t\tif (is_null($sanitizer)) {\n+\t\t\t\t$sanitizer = new SanitationHelper();\n+\t\t\t}\n+\n+\t\t\t$this->_parameters = $params;\n+\t\t\t$this->_sanitizer  = $sanitizer;\n+\t\t}","path":"ParameterHelper.php","position":42,"original_position":46,"commit_id":"1a19c21a6ba253350e43889145559f639db4e814","original_commit_id":"a0823fa580e6bf887937693ba38ca9ba160e1e58","user":{"login":"AndyM84","id":1574682,"node_id":"MDQ6VXNlcjE1NzQ2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1574682?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyM84","html_url":"https://github.com/AndyM84","followers_url":"https://api.github.com/users/AndyM84/followers","following_url":"https://api.github.com/users/AndyM84/following{/other_user}","gists_url":"https://api.github.com/users/AndyM84/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyM84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyM84/subscriptions","organizations_url":"https://api.github.com/users/AndyM84/orgs","repos_url":"https://api.github.com/users/AndyM84/repos","events_url":"https://api.github.com/users/AndyM84/events{/privacy}","received_events_url":"https://api.github.com/users/AndyM84/received_events","type":"User","site_admin":false},"body":"Been a long time since commenting on this, and I think here's where I stand today:\r\n\r\nThere are times when each of these approaches could be argued as 'reasonable', so maybe trying to be consistent is a futile thing.","created_at":"2018-07-29T00:42:45Z","updated_at":"2018-07-29T00:42:45Z","html_url":"https://github.com/zibings/stoic-php-io/pull/8#discussion_r205957338","pull_request_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/comments/205957338"},"html":{"href":"https://github.com/zibings/stoic-php-io/pull/8#discussion_r205957338"},"pull_request":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8"}},"in_reply_to_id":116807608},"pull_request":{"url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8","id":120715896,"node_id":"MDExOlB1bGxSZXF1ZXN0MTIwNzE1ODk2","html_url":"https://github.com/zibings/stoic-php-io/pull/8","diff_url":"https://github.com/zibings/stoic-php-io/pull/8.diff","patch_url":"https://github.com/zibings/stoic-php-io/pull/8.patch","issue_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/8","number":8,"state":"open","locked":false,"title":"ParameterHelper","user":{"login":"c-butcher","id":1325362,"node_id":"MDQ6VXNlcjEzMjUzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1325362?v=4","gravatar_id":"","url":"https://api.github.com/users/c-butcher","html_url":"https://github.com/c-butcher","followers_url":"https://api.github.com/users/c-butcher/followers","following_url":"https://api.github.com/users/c-butcher/following{/other_user}","gists_url":"https://api.github.com/users/c-butcher/gists{/gist_id}","starred_url":"https://api.github.com/users/c-butcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-butcher/subscriptions","organizations_url":"https://api.github.com/users/c-butcher/orgs","repos_url":"https://api.github.com/users/c-butcher/repos","events_url":"https://api.github.com/users/c-butcher/events{/privacy}","received_events_url":"https://api.github.com/users/c-butcher/received_events","type":"User","site_admin":false},"body":"Added the initial commit of the new ParameterHelper which is working with the SanitationHelper.","created_at":"2017-05-15T23:27:20Z","updated_at":"2018-07-29T00:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a21cfe3945b3b48f8f3287f583c500e0c6d4e03","assignee":{"login":"AndyM84","id":1574682,"node_id":"MDQ6VXNlcjE1NzQ2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1574682?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyM84","html_url":"https://github.com/AndyM84","followers_url":"https://api.github.com/users/AndyM84/followers","following_url":"https://api.github.com/users/AndyM84/following{/other_user}","gists_url":"https://api.github.com/users/AndyM84/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyM84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyM84/subscriptions","organizations_url":"https://api.github.com/users/AndyM84/orgs","repos_url":"https://api.github.com/users/AndyM84/repos","events_url":"https://api.github.com/users/AndyM84/events{/privacy}","received_events_url":"https://api.github.com/users/AndyM84/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndyM84","id":1574682,"node_id":"MDQ6VXNlcjE1NzQ2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1574682?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyM84","html_url":"https://github.com/AndyM84","followers_url":"https://api.github.com/users/AndyM84/followers","following_url":"https://api.github.com/users/AndyM84/following{/other_user}","gists_url":"https://api.github.com/users/AndyM84/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyM84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyM84/subscriptions","organizations_url":"https://api.github.com/users/AndyM84/orgs","repos_url":"https://api.github.com/users/AndyM84/repos","events_url":"https://api.github.com/users/AndyM84/events{/privacy}","received_events_url":"https://api.github.com/users/AndyM84/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8/commits","review_comments_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8/comments","review_comment_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/8/comments","statuses_url":"https://api.github.com/repos/zibings/stoic-php-io/statuses/1a19c21a6ba253350e43889145559f639db4e814","head":{"label":"zibings:cbutcher-6","ref":"cbutcher-6","sha":"1a19c21a6ba253350e43889145559f639db4e814","user":{"login":"zibings","id":15657997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU3OTk3","avatar_url":"https://avatars3.githubusercontent.com/u/15657997?v=4","gravatar_id":"","url":"https://api.github.com/users/zibings","html_url":"https://github.com/zibings","followers_url":"https://api.github.com/users/zibings/followers","following_url":"https://api.github.com/users/zibings/following{/other_user}","gists_url":"https://api.github.com/users/zibings/gists{/gist_id}","starred_url":"https://api.github.com/users/zibings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zibings/subscriptions","organizations_url":"https://api.github.com/users/zibings/orgs","repos_url":"https://api.github.com/users/zibings/repos","events_url":"https://api.github.com/users/zibings/events{/privacy}","received_events_url":"https://api.github.com/users/zibings/received_events","type":"Organization","site_admin":false},"repo":{"id":90786872,"node_id":"MDEwOlJlcG9zaXRvcnk5MDc4Njg3Mg==","name":"stoic-php-io","full_name":"zibings/stoic-php-io","owner":{"login":"zibings","id":15657997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU3OTk3","avatar_url":"https://avatars3.githubusercontent.com/u/15657997?v=4","gravatar_id":"","url":"https://api.github.com/users/zibings","html_url":"https://github.com/zibings","followers_url":"https://api.github.com/users/zibings/followers","following_url":"https://api.github.com/users/zibings/following{/other_user}","gists_url":"https://api.github.com/users/zibings/gists{/gist_id}","starred_url":"https://api.github.com/users/zibings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zibings/subscriptions","organizations_url":"https://api.github.com/users/zibings/orgs","repos_url":"https://api.github.com/users/zibings/repos","events_url":"https://api.github.com/users/zibings/events{/privacy}","received_events_url":"https://api.github.com/users/zibings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zibings/stoic-php-io","description":"Input and Output components for the Stoic Framework","fork":false,"url":"https://api.github.com/repos/zibings/stoic-php-io","forks_url":"https://api.github.com/repos/zibings/stoic-php-io/forks","keys_url":"https://api.github.com/repos/zibings/stoic-php-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zibings/stoic-php-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zibings/stoic-php-io/teams","hooks_url":"https://api.github.com/repos/zibings/stoic-php-io/hooks","issue_events_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/events{/number}","events_url":"https://api.github.com/repos/zibings/stoic-php-io/events","assignees_url":"https://api.github.com/repos/zibings/stoic-php-io/assignees{/user}","branches_url":"https://api.github.com/repos/zibings/stoic-php-io/branches{/branch}","tags_url":"https://api.github.com/repos/zibings/stoic-php-io/tags","blobs_url":"https://api.github.com/repos/zibings/stoic-php-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zibings/stoic-php-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zibings/stoic-php-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/zibings/stoic-php-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zibings/stoic-php-io/statuses/{sha}","languages_url":"https://api.github.com/repos/zibings/stoic-php-io/languages","stargazers_url":"https://api.github.com/repos/zibings/stoic-php-io/stargazers","contributors_url":"https://api.github.com/repos/zibings/stoic-php-io/contributors","subscribers_url":"https://api.github.com/repos/zibings/stoic-php-io/subscribers","subscription_url":"https://api.github.com/repos/zibings/stoic-php-io/subscription","commits_url":"https://api.github.com/repos/zibings/stoic-php-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/zibings/stoic-php-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/zibings/stoic-php-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/zibings/stoic-php-io/contents/{+path}","compare_url":"https://api.github.com/repos/zibings/stoic-php-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zibings/stoic-php-io/merges","archive_url":"https://api.github.com/repos/zibings/stoic-php-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zibings/stoic-php-io/downloads","issues_url":"https://api.github.com/repos/zibings/stoic-php-io/issues{/number}","pulls_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls{/number}","milestones_url":"https://api.github.com/repos/zibings/stoic-php-io/milestones{/number}","notifications_url":"https://api.github.com/repos/zibings/stoic-php-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zibings/stoic-php-io/labels{/name}","releases_url":"https://api.github.com/repos/zibings/stoic-php-io/releases{/id}","deployments_url":"https://api.github.com/repos/zibings/stoic-php-io/deployments","created_at":"2017-05-09T20:02:34Z","updated_at":"2017-05-16T01:25:58Z","pushed_at":"2017-05-22T01:54:55Z","git_url":"git://github.com/zibings/stoic-php-io.git","ssh_url":"git@github.com:zibings/stoic-php-io.git","clone_url":"https://github.com/zibings/stoic-php-io.git","svn_url":"https://github.com/zibings/stoic-php-io","homepage":"","size":53,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"zibings:master","ref":"master","sha":"a6cd5ed7e21ffa20084591d9eb2c5383124f3728","user":{"login":"zibings","id":15657997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU3OTk3","avatar_url":"https://avatars3.githubusercontent.com/u/15657997?v=4","gravatar_id":"","url":"https://api.github.com/users/zibings","html_url":"https://github.com/zibings","followers_url":"https://api.github.com/users/zibings/followers","following_url":"https://api.github.com/users/zibings/following{/other_user}","gists_url":"https://api.github.com/users/zibings/gists{/gist_id}","starred_url":"https://api.github.com/users/zibings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zibings/subscriptions","organizations_url":"https://api.github.com/users/zibings/orgs","repos_url":"https://api.github.com/users/zibings/repos","events_url":"https://api.github.com/users/zibings/events{/privacy}","received_events_url":"https://api.github.com/users/zibings/received_events","type":"Organization","site_admin":false},"repo":{"id":90786872,"node_id":"MDEwOlJlcG9zaXRvcnk5MDc4Njg3Mg==","name":"stoic-php-io","full_name":"zibings/stoic-php-io","owner":{"login":"zibings","id":15657997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU3OTk3","avatar_url":"https://avatars3.githubusercontent.com/u/15657997?v=4","gravatar_id":"","url":"https://api.github.com/users/zibings","html_url":"https://github.com/zibings","followers_url":"https://api.github.com/users/zibings/followers","following_url":"https://api.github.com/users/zibings/following{/other_user}","gists_url":"https://api.github.com/users/zibings/gists{/gist_id}","starred_url":"https://api.github.com/users/zibings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zibings/subscriptions","organizations_url":"https://api.github.com/users/zibings/orgs","repos_url":"https://api.github.com/users/zibings/repos","events_url":"https://api.github.com/users/zibings/events{/privacy}","received_events_url":"https://api.github.com/users/zibings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zibings/stoic-php-io","description":"Input and Output components for the Stoic Framework","fork":false,"url":"https://api.github.com/repos/zibings/stoic-php-io","forks_url":"https://api.github.com/repos/zibings/stoic-php-io/forks","keys_url":"https://api.github.com/repos/zibings/stoic-php-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zibings/stoic-php-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zibings/stoic-php-io/teams","hooks_url":"https://api.github.com/repos/zibings/stoic-php-io/hooks","issue_events_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/events{/number}","events_url":"https://api.github.com/repos/zibings/stoic-php-io/events","assignees_url":"https://api.github.com/repos/zibings/stoic-php-io/assignees{/user}","branches_url":"https://api.github.com/repos/zibings/stoic-php-io/branches{/branch}","tags_url":"https://api.github.com/repos/zibings/stoic-php-io/tags","blobs_url":"https://api.github.com/repos/zibings/stoic-php-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zibings/stoic-php-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zibings/stoic-php-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/zibings/stoic-php-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zibings/stoic-php-io/statuses/{sha}","languages_url":"https://api.github.com/repos/zibings/stoic-php-io/languages","stargazers_url":"https://api.github.com/repos/zibings/stoic-php-io/stargazers","contributors_url":"https://api.github.com/repos/zibings/stoic-php-io/contributors","subscribers_url":"https://api.github.com/repos/zibings/stoic-php-io/subscribers","subscription_url":"https://api.github.com/repos/zibings/stoic-php-io/subscription","commits_url":"https://api.github.com/repos/zibings/stoic-php-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/zibings/stoic-php-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/zibings/stoic-php-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/zibings/stoic-php-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/zibings/stoic-php-io/contents/{+path}","compare_url":"https://api.github.com/repos/zibings/stoic-php-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zibings/stoic-php-io/merges","archive_url":"https://api.github.com/repos/zibings/stoic-php-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zibings/stoic-php-io/downloads","issues_url":"https://api.github.com/repos/zibings/stoic-php-io/issues{/number}","pulls_url":"https://api.github.com/repos/zibings/stoic-php-io/pulls{/number}","milestones_url":"https://api.github.com/repos/zibings/stoic-php-io/milestones{/number}","notifications_url":"https://api.github.com/repos/zibings/stoic-php-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zibings/stoic-php-io/labels{/name}","releases_url":"https://api.github.com/repos/zibings/stoic-php-io/releases{/id}","deployments_url":"https://api.github.com/repos/zibings/stoic-php-io/deployments","created_at":"2017-05-09T20:02:34Z","updated_at":"2017-05-16T01:25:58Z","pushed_at":"2017-05-22T01:54:55Z","git_url":"git://github.com/zibings/stoic-php-io.git","ssh_url":"git@github.com:zibings/stoic-php-io.git","clone_url":"https://github.com/zibings/stoic-php-io.git","svn_url":"https://github.com/zibings/stoic-php-io","homepage":"","size":53,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8"},"html":{"href":"https://github.com/zibings/stoic-php-io/pull/8"},"issue":{"href":"https://api.github.com/repos/zibings/stoic-php-io/issues/8"},"comments":{"href":"https://api.github.com/repos/zibings/stoic-php-io/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zibings/stoic-php-io/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/zibings/stoic-php-io/statuses/1a19c21a6ba253350e43889145559f639db4e814"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AndyM84"}}