{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66936","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66936/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66936/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66936/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66936","id":347177893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODY0MDAy","number":66936,"title":"Support dry run in admission webhooks","user":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-02T21:17:08Z","updated_at":"2018-08-07T17:00:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66936","html_url":"https://github.com/kubernetes/kubernetes/pull/66936","diff_url":"https://github.com/kubernetes/kubernetes/pull/66936.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66936.patch"},"body":"**What this PR does / why we need it**:\r\nFollow up to https://github.com/kubernetes/kubernetes/pull/66391\r\n- [x] add DryRun to ```admission.k8s.io/v1beta1.AdmissionReview```\r\n- [x] add DryRunnable to ```admissionregistration.k8s.io/v1beta1.(Valid|Mut)atingWebhookConfiguration```\r\n- [x] add dry run support to (Valid|Mut)atingAdmissionWebhook\r\n\r\nIncludes all the api-changes outlined by https://github.com/kubernetes/community/pull/2387\r\n\r\n/sig api-machinery\r\n\r\n**Release note**:\r\n```release-note\r\nTo address the possibility dry-run requests overwhelming admission webhooks that rely on side effects and a reconciliation mechanism, a new field will be added to admissionregistration.k8s.io/v1beta1.ValidatingWebhookConfiguration and admissionregistration.k8s.io/v1beta1.MutatingWebhookConfiguration so that webhooks can explicitly register as having dry-run support. If a dry-run request is made on a resource that triggers a non dry-run supporting webhook, the request will be completely rejected, with \"400: Bad Request\". Additionally, a new field will be added to the admission.k8s.io/v1beta1.AdmissionReview API object, exposing to webhooks whether or not the request being reviewed is a dry-run.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/411128651","html_url":"https://github.com/kubernetes/kubernetes/pull/66936#issuecomment-411128651","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66936","id":411128651,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTEyODY1MQ==","user":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T17:00:30Z","updated_at":"2018-08-07T17:00:30Z","author_association":"CONTRIBUTOR","body":"@kubernetes/sig-api-machinery-api-reviews \r\n@kubernetes/api-reviewers"}}
{"actor":{"display_login":"jennybuckley"}}