{"action":"closed","issue":{"url":"https://api.github.com/repos/MetaMask/Design/issues/11","repository_url":"https://api.github.com/repos/MetaMask/Design","labels_url":"https://api.github.com/repos/MetaMask/Design/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/Design/issues/11/comments","events_url":"https://api.github.com/repos/MetaMask/Design/issues/11/events","html_url":"https://github.com/MetaMask/Design/issues/11","id":312704659,"node_id":"MDU6SXNzdWUzMTI3MDQ2NTk=","number":11,"title":"Confirm Screen Updates","user":{"login":"cjeria","id":597770,"node_id":"MDQ6VXNlcjU5Nzc3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/597770?v=4","gravatar_id":"","url":"https://api.github.com/users/cjeria","html_url":"https://github.com/cjeria","followers_url":"https://api.github.com/users/cjeria/followers","following_url":"https://api.github.com/users/cjeria/following{/other_user}","gists_url":"https://api.github.com/users/cjeria/gists{/gist_id}","starred_url":"https://api.github.com/users/cjeria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjeria/subscriptions","organizations_url":"https://api.github.com/users/cjeria/orgs","repos_url":"https://api.github.com/users/cjeria/repos","events_url":"https://api.github.com/users/cjeria/events{/privacy}","received_events_url":"https://api.github.com/users/cjeria/received_events","type":"User","site_admin":false},"labels":[{"id":944009469,"node_id":"MDU6TGFiZWw5NDQwMDk0Njk=","url":"https://api.github.com/repos/MetaMask/Design/labels/Action%20(confirm)%20Screen","name":"Action (confirm) Screen","color":"ffe760","default":false}],"state":"closed","locked":false,"assignee":{"login":"cjeria","id":597770,"node_id":"MDQ6VXNlcjU5Nzc3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/597770?v=4","gravatar_id":"","url":"https://api.github.com/users/cjeria","html_url":"https://github.com/cjeria","followers_url":"https://api.github.com/users/cjeria/followers","following_url":"https://api.github.com/users/cjeria/following{/other_user}","gists_url":"https://api.github.com/users/cjeria/gists{/gist_id}","starred_url":"https://api.github.com/users/cjeria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjeria/subscriptions","organizations_url":"https://api.github.com/users/cjeria/orgs","repos_url":"https://api.github.com/users/cjeria/repos","events_url":"https://api.github.com/users/cjeria/events{/privacy}","received_events_url":"https://api.github.com/users/cjeria/received_events","type":"User","site_admin":false},"assignees":[{"login":"cjeria","id":597770,"node_id":"MDQ6VXNlcjU5Nzc3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/597770?v=4","gravatar_id":"","url":"https://api.github.com/users/cjeria","html_url":"https://github.com/cjeria","followers_url":"https://api.github.com/users/cjeria/followers","following_url":"https://api.github.com/users/cjeria/following{/other_user}","gists_url":"https://api.github.com/users/cjeria/gists{/gist_id}","starred_url":"https://api.github.com/users/cjeria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjeria/subscriptions","organizations_url":"https://api.github.com/users/cjeria/orgs","repos_url":"https://api.github.com/users/cjeria/repos","events_url":"https://api.github.com/users/cjeria/events{/privacy}","received_events_url":"https://api.github.com/users/cjeria/received_events","type":"User","site_admin":false},{"login":"celinepark94","id":4051426,"node_id":"MDQ6VXNlcjQwNTE0MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4051426?v=4","gravatar_id":"","url":"https://api.github.com/users/celinepark94","html_url":"https://github.com/celinepark94","followers_url":"https://api.github.com/users/celinepark94/followers","following_url":"https://api.github.com/users/celinepark94/following{/other_user}","gists_url":"https://api.github.com/users/celinepark94/gists{/gist_id}","starred_url":"https://api.github.com/users/celinepark94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celinepark94/subscriptions","organizations_url":"https://api.github.com/users/celinepark94/orgs","repos_url":"https://api.github.com/users/celinepark94/repos","events_url":"https://api.github.com/users/celinepark94/events{/privacy}","received_events_url":"https://api.github.com/users/celinepark94/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-04-09T22:07:07Z","updated_at":"2018-07-18T15:21:23Z","closed_at":"2018-07-18T15:21:23Z","author_association":"COLLABORATOR","body":"We have a few GH issues that are addressing different problems with the confirm transaction screen.\n\n# Problems: \n\n### Total amount + Gas not visible\nTotal and Amount/Gas Fee values are hidden below main action buttons because tx body data is pushing it all the way down. \n\nSee the gihub issue here: https://github.com/MetaMask/metamask-extension/issues/3885\n![image.png](https://images.zenhubusercontent.com/59b80272b0222d5de4776ba7/b8368176-7165-468c-9302-f8eb9fb770ad)\n\n### Show method data\n\nNeed to show transaction “method data” in transaction ui somewhere. Dan suggested bubbling up this piece of data. Need to find a balance between this and amount.\n\nSee the gihub issue here: https://github.com/MetaMask/metamask-extension/issues/2847\n\n![image.png](https://images.zenhubusercontent.com/59b80272b0222d5de4776ba7/ec8976f0-e5d2-4232-8b38-b818e09aad78)\n\n### Trust Badge\nAnother team at ConsenSys is wanting us to design for adding a trust badge to verified smart contracts. This is a work in progress and we still don't have details regarding what this will mean, but there's a mock with a checkmark in the sketch file to reference.\n\n![image.png](https://images.zenhubusercontent.com/59b80272b0222d5de4776ba7/2e7755e3-bcd2-4cb7-b849-2cc8f7c9e218)\n\n#### Side Notes\n- Make this UI consistent with token transaction\n- TX screen needs to have the “Edit gas” button.\n- Let's also consider what this means for Sign Request screen. Notice the top section is used to describe the transaction type here https://github.com/MetaMask/metamask-extension/issues/3578\n\nWe need to strike a balance between displaying the transaction type, method data, amounts and action buttons in such a way can be consistently displayed across confirm screens. \n\n@celinepark94 I've added a new page in our sketch file called \"Confirm TX screen\" with all the screens related to the above. Let me know if you have any questions!"}}
{"actor":{"display_login":"bdresser"}}