{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/182084973","pull_request_review_id":112825225,"id":182084973,"diff_hunk":"@@ -1,12 +1,17 @@\n+import pytest\n+\n from plenum.common.types import f\n from plenum.common.txn_util import reqToTxn\n from plenum.test.helper import signed_random_requests\n from stp_core.common.log import getlogger\n \n logger = getlogger()\n \n+nodeCount = 1\n+\n \n-def test_req_id_key_error(testNode, wallet1):\n+@pytest.mark.skip(reason='test changed in INDY-1029')\n+def test_req_id_key_error(looper, txnPoolNodeSetNotStarted, wallet1):","path":"plenum/test/node_catchup/test_req_id_key_error.py","position":15,"original_position":15,"commit_id":"5f19cce7c7a331922cf4ced5f05c3e101e941466","original_commit_id":"5f19cce7c7a331922cf4ced5f05c3e101e941466","user":{"login":"ashcherbakov","id":21102430,"avatar_url":"https://avatars1.githubusercontent.com/u/21102430?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcherbakov","html_url":"https://github.com/ashcherbakov","followers_url":"https://api.github.com/users/ashcherbakov/followers","following_url":"https://api.github.com/users/ashcherbakov/following{/other_user}","gists_url":"https://api.github.com/users/ashcherbakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcherbakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcherbakov/subscriptions","organizations_url":"https://api.github.com/users/ashcherbakov/orgs","repos_url":"https://api.github.com/users/ashcherbakov/repos","events_url":"https://api.github.com/users/ashcherbakov/events{/privacy}","received_events_url":"https://api.github.com/users/ashcherbakov/received_events","type":"User","site_admin":false},"body":"I don't see any sense in this test...","created_at":"2018-04-17T14:06:09Z","updated_at":"2018-04-17T14:06:09Z","html_url":"https://github.com/hyperledger/indy-plenum/pull/595#discussion_r182084973","pull_request_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/182084973"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/595#discussion_r182084973"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595","id":177934368,"html_url":"https://github.com/hyperledger/indy-plenum/pull/595","diff_url":"https://github.com/hyperledger/indy-plenum/pull/595.diff","patch_url":"https://github.com/hyperledger/indy-plenum/pull/595.patch","issue_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/595","number":595,"state":"open","locked":false,"title":"[INDY-1237] Get rid of RegistryPoolManager","user":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"body":"Signed-off-by: ArtObr <artemobruchnikov@gmail.com>","created_at":"2018-03-28T05:37:05Z","updated_at":"2018-04-17T14:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a90beb63b62d1b133099f4723b183b3570f54cf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595/commits","review_comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595/comments","review_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/595/comments","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/5f19cce7c7a331922cf4ced5f05c3e101e941466","head":{"label":"ArtObr:indy-sdk-integration/INDY-1237","ref":"indy-sdk-integration/INDY-1237","sha":"5f19cce7c7a331922cf4ced5f05c3e101e941466","user":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"repo":{"id":117691801,"name":"indy-plenum","full_name":"ArtObr/indy-plenum","owner":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArtObr/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":true,"url":"https://api.github.com/repos/ArtObr/indy-plenum","forks_url":"https://api.github.com/repos/ArtObr/indy-plenum/forks","keys_url":"https://api.github.com/repos/ArtObr/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtObr/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtObr/indy-plenum/teams","hooks_url":"https://api.github.com/repos/ArtObr/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/ArtObr/indy-plenum/events","assignees_url":"https://api.github.com/repos/ArtObr/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/ArtObr/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/ArtObr/indy-plenum/tags","blobs_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtObr/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtObr/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/ArtObr/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/ArtObr/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/ArtObr/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/ArtObr/indy-plenum/subscription","commits_url":"https://api.github.com/repos/ArtObr/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtObr/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtObr/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/ArtObr/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtObr/indy-plenum/merges","archive_url":"https://api.github.com/repos/ArtObr/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtObr/indy-plenum/downloads","issues_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/ArtObr/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtObr/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtObr/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtObr/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/ArtObr/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/ArtObr/indy-plenum/deployments","created_at":"2018-01-16T14:11:22Z","updated_at":"2018-01-16T14:11:26Z","pushed_at":"2018-04-17T13:56:42Z","git_url":"git://github.com/ArtObr/indy-plenum.git","ssh_url":"git@github.com:ArtObr/indy-plenum.git","clone_url":"https://github.com/ArtObr/indy-plenum.git","svn_url":"https://github.com/ArtObr/indy-plenum","homepage":"","size":8334,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"904012a63a6b23b85d361fa30eb91d1e01bc865d","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":51585028,"name":"indy-plenum","full_name":"hyperledger/indy-plenum","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":false,"url":"https://api.github.com/repos/hyperledger/indy-plenum","forks_url":"https://api.github.com/repos/hyperledger/indy-plenum/forks","keys_url":"https://api.github.com/repos/hyperledger/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/indy-plenum/teams","hooks_url":"https://api.github.com/repos/hyperledger/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/indy-plenum/events","assignees_url":"https://api.github.com/repos/hyperledger/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/tags","blobs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/hyperledger/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscription","commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/indy-plenum/merges","archive_url":"https://api.github.com/repos/hyperledger/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/indy-plenum/downloads","issues_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/indy-plenum/deployments","created_at":"2016-02-12T12:03:16Z","updated_at":"2018-04-17T11:41:11Z","pushed_at":"2018-04-17T13:59:34Z","git_url":"git://github.com/hyperledger/indy-plenum.git","ssh_url":"git@github.com:hyperledger/indy-plenum.git","clone_url":"https://github.com/hyperledger/indy-plenum.git","svn_url":"https://github.com/hyperledger/indy-plenum","homepage":"","size":8036,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":128,"open_issues":11,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/595"},"issue":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/595"},"comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/5f19cce7c7a331922cf4ced5f05c3e101e941466"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ashcherbakov"}}