{"push_id":3126340514,"size":14,"distinct_size":14,"ref":"refs/heads/master","head":"e867ea416afca1bffa4e047dd63f7bac38158a02","before":"64c34b571ae49b0a8f47b7acd65e255785ffbaca","commits":[{"sha":"ee3c7f03c350a23976522c463569ffec90a1868b","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings: rename local ctx variable to saved_ctx\n\nThis will help avoiding conflicts when the get_ctx() method gets\nrenamed to ctx().\nThe check for the case where the first argument\nis already called \"ctx\" is removed because\nthe first argument is never called \"saved_ctx\".\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/ee3c7f03c350a23976522c463569ffec90a1868b"},{"sha":"1f40bbf2fe599c489639b25f24853f6c5f4cd6db","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings: add back namespace specifier on isl object types (including ctx)\n\nThis commmit partially reverts isl-0.18-1068-g85eb4b7f (drop namespace\nqualifier in generated C++ bindings, Tue Jun 12 22:40:21 2018 +0200).\nThe (then) \"isl::\" specifier was removed because it relied\non the nested \"checked\" namespace being inlined.\nThis commit used the \"isl::\" or \"isl::checked::\" specifier\ndepending on the bindings that are being generated.\n\nThe main purpose of this commit is to ensure that no ambiguity\nis introduced when the get_ctx() method gets renamed to ctx()\nby specifying the ctx type as isl::ctx or isl::checked::ctx.\nAn alternative would be to specify the type as \"class ctx\",\nbut this would require more changes to the code because\nthe same type is also used in contexts where the additional\n\"class\" is not allowed, e.g., in the class declaration itself.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/1f40bbf2fe599c489639b25f24853f6c5f4cd6db"},{"sha":"1ef258fd8030d02cf154dec134ae0c3699623f12","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings: specify namespace on return type of get_ctx() method\n\nLike the previous commit, this commits partially reverts\nisl-0.18-1068-g85eb4b7f (drop namespace qualifier in generated\nC++ bindings, Tue Jun 12 22:40:21 2018 +0200).\nAgain, the purpose is to avoid ambiguities\nwhen the get_ctx() method is renamed to ctx().\nFor consistency with the previous commit, a namespace specifier\nis added rather than adding the \"class\" keyword.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/1ef258fd8030d02cf154dec134ae0c3699623f12"},{"sha":"89032cf3ecd58b660408ac96f7f32e607f83ec69","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings: specify namespace in ctx object construction in get_ctx() method\n\nLike the previous two commits, this commits partially reverts\nisl-0.18-1068-g85eb4b7f (drop namespace qualifier in generated\nC++ bindings, Tue Jun 12 22:40:21 2018 +0200).\nAgain, the purpose is to avoid ambiguities\nwhen the get_ctx() method is renamed to ctx().\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/89032cf3ecd58b660408ac96f7f32e607f83ec69"},{"sha":"f5f35ae1c3b4edcbb18b8bd639361256cf8c1030","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings: rename get_ctx method to ctx\n\nIn the C API, a \"get\" infix in the function name serves\nas a reminder that the function does not consume (\"take\")\nits argument(s).\nIn the C++ bindings, there is no such concept,\nso the (now) \"get\" prefix does not serve any purpose and\nin fact introduces a distinction that is completely irrelevant\nand can only lead to confusion.\n\nThis commit is a first step towards removing this prefix and\nspecifically targets the get_ctx() method that is automatically\nadded to all exported classes and that is specific to the C++ bindings.\nThe method was introduced in isl-0.18-987-gec4ece19 (cpp: generate\nget_ctx method for all exported classes, Wed Jul 5 14:07:48 2017 +0200),\nbut it was removed in isl-0.18-1047-g4a20ef8e (drop C++ bindings,\nSun Feb 4 09:06:48 2018 +0100), only to get merged back in in\nisl-0.20-35-ge0a98b62 (Merge branch 'cpp', Mon Jul 30 23:10:59 2018 +0200).\nIt was therefore not included in any release and should\ntherefore be safe to change without introducing backward\nincompatibilities.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/f5f35ae1c3b4edcbb18b8bd639361256cf8c1030"},{"sha":"4d0511bcb0837248dd120953410a966db942bf7c","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"add isl_ast_node_if_get_else_node as alternative name for ..._get_else\n\nIn an upcoming commit, the bindings generator will be changed\nto export \"get\" functions as two methods, one with and one without\nthe \"get_\" prefix.  For the function isl_ast_node_if_get_else,\nthis means a method called \"else\" would be generated,\nwhich is a keyword in both C++ and Python.\nWhile it would be possible to add a special case for this function\nsuch that no method without \"get_\" prefix would be generated,\na solution that does not involve special cases is preferred.\n\nThis commit renames the \"get_else\" function to \"get_else_node\"\nsuch that the generated method will be called \"else_node\"\ninstead of \"else\".\nIt is the new name that gets exported instead of the original name.\nUnfortunately, the original name was already exported in\nisl-0.20-780-ge7f6f8a57 (export isl_ast_node methods,\nTue Oct 16 16:43:21 2018 +0200), so this may break code\nof early adopters.  Still, no incompatibility with respect\nto previous releases is introduced because the export was\nadded after the latest release.\n\nFor consistency of function naming, the functions\nisl_ast_node_if_has_else and isl_ast_node_if_get_then\nare renamed in a similar way.\n\nThe original names are preserved in the C interface\nfor backward compatibility.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/4d0511bcb0837248dd120953410a966db942bf7c"},{"sha":"485d6440fbf3dcf0634e8dda74d88b7e4ff0718e","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"cpp_generator::print_method_header: extract out print_named_method_header\n\nThe extracted method will be used to print a method header using\na name that is different from its default name.\nIn particular, it will allow the header of a given method\nto be printed using different names.  This will be used to print\ntwo different headers for \"get\" methods,\none with the \"get_\" prefix and one without.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/485d6440fbf3dcf0634e8dda74d88b7e4ff0718e"},{"sha":"b9145059ef0e54db3123af6f75563178c5dd444d","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"cpp_generator::print_method_decl: extract out print_named_method_decl\n\nThe extracted method will be used to print a declaration\nfor a method using a name that is different from its default name.\nIn particular, this will be used to print two declarations\nfor \"get\" methods.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/b9145059ef0e54db3123af6f75563178c5dd444d"},{"sha":"c4e721f04a1b2b3ddef72a8072035fb9c4c8cfa9","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"python_generator::print_method_header: extract out print_method_arguments\n\nThis function will be reused to print a call to a \"get\" method\nfrom a duplicate method with a different name.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/c4e721f04a1b2b3ddef72a8072035fb9c4c8cfa9"},{"sha":"3a2c4077c76a1b347ac6c15d2875d669db56c7c0","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"generator::is_static: extract out isl_class::is_static\n\nSince generator::is_static takes a reference to an isl_class anyway,\nit may as well be called as an instance method of isl_class.\nHaving the method available as an isl_class method will\nalso make it easier to call it during the detection of \"get\" methods\nin an upcoming commit.\n\nThe original callers of is_static are not changed in this commit.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/3a2c4077c76a1b347ac6c15d2875d669db56c7c0"},{"sha":"1daf53d6c3576e8cbd12265954a50b741f43f896","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"move prefixcmp to interface/generator.h\n\nThis will allow this function to be reused in the next commit.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/1daf53d6c3576e8cbd12265954a50b741f43f896"},{"sha":"53ec4e237deeeddbbf810ca5ff588697705bd63b","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"bindings: drop \"get_\" prefix of methods that start this way\n\nIn the C API, a \"get\" infix in the function name serves\nas a reminder that the function does not consume (\"take\")\nits argument(s).\nIn the C++ and Python bindings, there is no such concept,\nso the (now) \"get\" prefix does not serve any purpose and\nin fact introduces a distinction that is completely irrelevant\nand can only lead to confusion.\n\nDrop the \"get_\" prefix from all corresponding exported methods.\nUnfortunately, such methods have been exported to the (Python) bindings\never since isl-0.15-226-g30cd06c67 (export isl_schedule and\nisl_schedule_node, Wed Oct 21 22:25:46 2015 +0200).\nThe original names (with \"get_\" prefix)  can therefore not be removed.\nThis commit therefore also introduces methods with the original names\nthat call the corresponding methods with the new names.\nIn order to keep the differences between the Python and the C++ bindings\nas small as possible, the same is done in the C++ bindings.\n\nNote that no distinction is made between functions that are already\nexported and those that will be exported in future.\nThis means that newly exported \"get\" methods will also\nbe exported under two names.\nIt does not seem worth the effort to try and make such a distinction.\nIn fact, it would probably be confusing to have some \"get\" methods\nexported twice and others only once.\n\nAn alternative to having one variant call the other would be\nto simply generate the same method twice but using different names.\nThe current scheme makes is more obvious that the two methods\nare identical.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/53ec4e237deeeddbbf810ca5ff588697705bd63b"},{"sha":"49ed344ef762981d86375175b1f2f51068581eb4","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"C++ bindings tests: drop \"get_\" prefix from method calls\n\nThese methods are available under two names,\nbut the name without the \"get_\" prefix is considered\nto be the canonical name.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/49ed344ef762981d86375175b1f2f51068581eb4"},{"sha":"e867ea416afca1bffa4e047dd63f7bac38158a02","author":{"name":"Sven Verdoolaege","email":"dd860110a62b19214c4ee03aec0abffecb4e86b8@cerebras.net"},"message":"Python bindings tests: drop \"get_\" prefix from method calls\n\nThese methods are available under two names,\nbut the name without the \"get_\" prefix is considered\nto be the canonical name.\n\nSigned-off-by: Sven Verdoolaege <sven@cerebras.net>","distinct":true,"url":"https://api.github.com/repos/prateekkumarweb/isl/commits/e867ea416afca1bffa4e047dd63f7bac38158a02"}]}
{"actor":{"display_login":"prateekkumarweb"}}