{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/198778028","pull_request_review_id":132766612,"id":198778028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODc3ODAyOA==","diff_hunk":"@@ -2022,8 +2018,7 @@ namespace libtorrent\n \n \t\t// in case file priorities were passed in via the add_torrent_params\n \t\t// and also in the case of share mode, we need to update the priorities\n-\t\tif (!m_file_priority.empty() && std::find(m_file_priority.begin()\n-\t\t\t\t, m_file_priority.end(), 0) != m_file_priority.end())\n+\t\tif (std::find(m_file_priority.begin(), m_file_priority.end(), 0) != m_file_priority.end())","path":"src/torrent.cpp","position":38,"original_position":38,"commit_id":"d7a7fefc4ce33a58e67e72730a8f7d0bfeeb1704","original_commit_id":"d7a7fefc4ce33a58e67e72730a8f7d0bfeeb1704","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"I would prefer to keep lines shorter than this","created_at":"2018-06-28T09:37:40Z","updated_at":"2018-06-28T09:37:40Z","html_url":"https://github.com/arvidn/libtorrent/pull/3133#discussion_r198778028","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/198778028"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3133#discussion_r198778028"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133","id":197808161,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODA4MTYx","html_url":"https://github.com/arvidn/libtorrent/pull/3133","diff_url":"https://github.com/arvidn/libtorrent/pull/3133.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/3133.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3133","number":3133,"state":"open","locked":false,"title":"Fix torrent files prioritization","user":{"login":"d-komarov","id":20125415,"node_id":"MDQ6VXNlcjIwMTI1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/20125415?v=4","gravatar_id":"","url":"https://api.github.com/users/d-komarov","html_url":"https://github.com/d-komarov","followers_url":"https://api.github.com/users/d-komarov/followers","following_url":"https://api.github.com/users/d-komarov/following{/other_user}","gists_url":"https://api.github.com/users/d-komarov/gists{/gist_id}","starred_url":"https://api.github.com/users/d-komarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-komarov/subscriptions","organizations_url":"https://api.github.com/users/d-komarov/orgs","repos_url":"https://api.github.com/users/d-komarov/repos","events_url":"https://api.github.com/users/d-komarov/events{/privacy}","received_events_url":"https://api.github.com/users/d-komarov/received_events","type":"User","site_admin":false},"body":"After setting file priority, any subsequent attempt to set different\r\npriorities will fail if there is a `file_priority` job running in in\r\ndisk thread. This happens because `torrent::m_file_priority` is being\r\nupdated before adding disk thread job. The problem is gone if the file\r\npriority vector owned by the torrent object, is modified in the\r\n`torrent::on_file_priority` callback, when disk job finishes.\r\n\r\n* Fix torrent test\r\n* Minor `torrent` class refactoring","created_at":"2018-06-27T17:54:39Z","updated_at":"2018-06-28T09:37:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5abc641b3ffd3b2b798d5b4c7db3d45963251f00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3133/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/d7a7fefc4ce33a58e67e72730a8f7d0bfeeb1704","head":{"label":"d-komarov:file_priorities","ref":"file_priorities","sha":"d7a7fefc4ce33a58e67e72730a8f7d0bfeeb1704","user":{"login":"d-komarov","id":20125415,"node_id":"MDQ6VXNlcjIwMTI1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/20125415?v=4","gravatar_id":"","url":"https://api.github.com/users/d-komarov","html_url":"https://github.com/d-komarov","followers_url":"https://api.github.com/users/d-komarov/followers","following_url":"https://api.github.com/users/d-komarov/following{/other_user}","gists_url":"https://api.github.com/users/d-komarov/gists{/gist_id}","starred_url":"https://api.github.com/users/d-komarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-komarov/subscriptions","organizations_url":"https://api.github.com/users/d-komarov/orgs","repos_url":"https://api.github.com/users/d-komarov/repos","events_url":"https://api.github.com/users/d-komarov/events{/privacy}","received_events_url":"https://api.github.com/users/d-komarov/received_events","type":"User","site_admin":false},"repo":{"id":96580470,"node_id":"MDEwOlJlcG9zaXRvcnk5NjU4MDQ3MA==","name":"libtorrent","full_name":"d-komarov/libtorrent","owner":{"login":"d-komarov","id":20125415,"node_id":"MDQ6VXNlcjIwMTI1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/20125415?v=4","gravatar_id":"","url":"https://api.github.com/users/d-komarov","html_url":"https://github.com/d-komarov","followers_url":"https://api.github.com/users/d-komarov/followers","following_url":"https://api.github.com/users/d-komarov/following{/other_user}","gists_url":"https://api.github.com/users/d-komarov/gists{/gist_id}","starred_url":"https://api.github.com/users/d-komarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-komarov/subscriptions","organizations_url":"https://api.github.com/users/d-komarov/orgs","repos_url":"https://api.github.com/users/d-komarov/repos","events_url":"https://api.github.com/users/d-komarov/events{/privacy}","received_events_url":"https://api.github.com/users/d-komarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-komarov/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/d-komarov/libtorrent","forks_url":"https://api.github.com/repos/d-komarov/libtorrent/forks","keys_url":"https://api.github.com/repos/d-komarov/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-komarov/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-komarov/libtorrent/teams","hooks_url":"https://api.github.com/repos/d-komarov/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/d-komarov/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/d-komarov/libtorrent/events","assignees_url":"https://api.github.com/repos/d-komarov/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/d-komarov/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/d-komarov/libtorrent/tags","blobs_url":"https://api.github.com/repos/d-komarov/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-komarov/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-komarov/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-komarov/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-komarov/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/d-komarov/libtorrent/languages","stargazers_url":"https://api.github.com/repos/d-komarov/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/d-komarov/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/d-komarov/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/d-komarov/libtorrent/subscription","commits_url":"https://api.github.com/repos/d-komarov/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-komarov/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-komarov/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-komarov/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-komarov/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/d-komarov/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-komarov/libtorrent/merges","archive_url":"https://api.github.com/repos/d-komarov/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-komarov/libtorrent/downloads","issues_url":"https://api.github.com/repos/d-komarov/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/d-komarov/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/d-komarov/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/d-komarov/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-komarov/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/d-komarov/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/d-komarov/libtorrent/deployments","created_at":"2017-07-07T22:15:51Z","updated_at":"2018-03-14T10:12:56Z","pushed_at":"2018-06-27T20:16:25Z","git_url":"git://github.com/d-komarov/libtorrent.git","ssh_url":"git@github.com:d-komarov/libtorrent.git","clone_url":"https://github.com/d-komarov/libtorrent.git","svn_url":"https://github.com/d-komarov/libtorrent","homepage":"http://libtorrent.org","size":62468,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:RC_1_1","ref":"RC_1_1","sha":"457672309087e6377601c680d55c451e29dcf012","user":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4MTc2OQ==","name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"node_id":"MDQ6VXNlcjY2MTQ1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-06-27T12:41:59Z","pushed_at":"2018-06-27T20:16:27Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":76481,"stargazers_count":1340,"watchers_count":1340,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":390,"open_issues":221,"watchers":1340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3133"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3133"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3133/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3133/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/d7a7fefc4ce33a58e67e72730a8f7d0bfeeb1704"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arvidn"}}