{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/206112226","pull_request_review_id":141506918,"id":206112226,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjExMjIyNg==","diff_hunk":"@@ -295,6 +286,78 @@ class SiteSelector extends Component {\n \t\t\tsites = sites.filter( site => site.slug !== this.props.selected );\n \t\t}\n \n+\t\treturn sites;\n+\t}\n+\n+\tshouldRenderRecentSites() {\n+\t\treturn (\n+\t\t\tthis.props.showRecentSites &&\n+\t\t\tthis.shouldShowGroups() &&\n+\t\t\t! this.props.sitesFound &&\n+\t\t\tsize( this.props.recentSites )","path":"client/components/site-selector/index.jsx","position":45,"original_position":45,"commit_id":"29b48713e30e818214d7d2d8a56e0061ad004b69","original_commit_id":"29b48713e30e818214d7d2d8a56e0061ad004b69","user":{"login":"jsnajdr","id":664258,"node_id":"MDQ6VXNlcjY2NDI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/664258?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false},"body":"The check for non-empty `recentSites` can be removed. Even non-empty list can be made empty by a filter. `renderRecentSites` must do the check once more anyway.","created_at":"2018-07-30T12:21:41Z","updated_at":"2018-07-30T12:21:50Z","html_url":"https://github.com/Automattic/wp-calypso/pull/25847#discussion_r206112226","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/206112226"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/25847#discussion_r206112226"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847","id":198816367,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODE2MzY3","html_url":"https://github.com/Automattic/wp-calypso/pull/25847","diff_url":"https://github.com/Automattic/wp-calypso/pull/25847.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/25847.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25847","number":25847,"state":"open","locked":false,"title":"Fix: clean up my-sites/sites/sites.jsx","user":{"login":"mariovalney","id":5784633,"node_id":"MDQ6VXNlcjU3ODQ2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5784633?v=4","gravatar_id":"","url":"https://api.github.com/users/mariovalney","html_url":"https://github.com/mariovalney","followers_url":"https://api.github.com/users/mariovalney/followers","following_url":"https://api.github.com/users/mariovalney/following{/other_user}","gists_url":"https://api.github.com/users/mariovalney/gists{/gist_id}","starred_url":"https://api.github.com/users/mariovalney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariovalney/subscriptions","organizations_url":"https://api.github.com/users/mariovalney/orgs","repos_url":"https://api.github.com/users/mariovalney/repos","events_url":"https://api.github.com/users/mariovalney/events{/privacy}","received_events_url":"https://api.github.com/users/mariovalney/received_events","type":"User","site_admin":false},"body":"**[Status] In Progress**\r\n\r\nFrom #25783\r\n\r\n#### In `my-sites/sites/sites.jsx`:\r\n\r\n- [x] Remove the `observe( 'user' )` mixin: the component doesn't access the User object at all. The code that did was removed a long time ago.\r\n- [x] Codemod the `createReactClass` into an ES6 React class.\r\n- [x] The component doesn't need the `selectedSite` prop. It's used in the `filterSites` but that's obsolete code. It used to reset the \"Public\"/\"Private\" filters in filterbar when a site was selected. The UI is completely different today.\r\n- [x] The component doesn't need the `sites` prop and doesn't need to pass it down to `SiteSelector`. `SiteSelector` has its own `connect` call that retrieves sites from Redux.\r\n- [x] Remove `client/my-sites/sites/package.json` and rename `sites.jsx` to `index.jsx`? Specifying a non-default index file in `package.json` is a convention we no longer use.\r\n- [x] Fix the recent sites list to consider `filter`.\r\n- [x] Change `SiteSelector`.","created_at":"2018-07-02T23:48:18Z","updated_at":"2018-07-30T12:21:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"896427d4a763be7fc19aa8a22ed65a788cbe6486","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":301697869,"node_id":"MDU6TGFiZWwzMDE2OTc4Njk=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/OSS%20Citizen","name":"OSS Citizen","color":"5319e7","default":false},{"id":285009984,"node_id":"MDU6TGFiZWwyODUwMDk5ODQ=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Sites","name":"Sites","color":"006b75","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25847/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/29b48713e30e818214d7d2d8a56e0061ad004b69","head":{"label":"mariovalney:fix/25783/2","ref":"fix/25783/2","sha":"29b48713e30e818214d7d2d8a56e0061ad004b69","user":{"login":"mariovalney","id":5784633,"node_id":"MDQ6VXNlcjU3ODQ2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5784633?v=4","gravatar_id":"","url":"https://api.github.com/users/mariovalney","html_url":"https://github.com/mariovalney","followers_url":"https://api.github.com/users/mariovalney/followers","following_url":"https://api.github.com/users/mariovalney/following{/other_user}","gists_url":"https://api.github.com/users/mariovalney/gists{/gist_id}","starred_url":"https://api.github.com/users/mariovalney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariovalney/subscriptions","organizations_url":"https://api.github.com/users/mariovalney/orgs","repos_url":"https://api.github.com/users/mariovalney/repos","events_url":"https://api.github.com/users/mariovalney/events{/privacy}","received_events_url":"https://api.github.com/users/mariovalney/received_events","type":"User","site_admin":false},"repo":{"id":137256436,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNTY0MzY=","name":"wp-calypso","full_name":"mariovalney/wp-calypso","owner":{"login":"mariovalney","id":5784633,"node_id":"MDQ6VXNlcjU3ODQ2MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5784633?v=4","gravatar_id":"","url":"https://api.github.com/users/mariovalney","html_url":"https://github.com/mariovalney","followers_url":"https://api.github.com/users/mariovalney/followers","following_url":"https://api.github.com/users/mariovalney/following{/other_user}","gists_url":"https://api.github.com/users/mariovalney/gists{/gist_id}","starred_url":"https://api.github.com/users/mariovalney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariovalney/subscriptions","organizations_url":"https://api.github.com/users/mariovalney/orgs","repos_url":"https://api.github.com/users/mariovalney/repos","events_url":"https://api.github.com/users/mariovalney/events{/privacy}","received_events_url":"https://api.github.com/users/mariovalney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariovalney/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":true,"url":"https://api.github.com/repos/mariovalney/wp-calypso","forks_url":"https://api.github.com/repos/mariovalney/wp-calypso/forks","keys_url":"https://api.github.com/repos/mariovalney/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariovalney/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariovalney/wp-calypso/teams","hooks_url":"https://api.github.com/repos/mariovalney/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/mariovalney/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/mariovalney/wp-calypso/events","assignees_url":"https://api.github.com/repos/mariovalney/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/mariovalney/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/mariovalney/wp-calypso/tags","blobs_url":"https://api.github.com/repos/mariovalney/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariovalney/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariovalney/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariovalney/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariovalney/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/mariovalney/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/mariovalney/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/mariovalney/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/mariovalney/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/mariovalney/wp-calypso/subscription","commits_url":"https://api.github.com/repos/mariovalney/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariovalney/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariovalney/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariovalney/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariovalney/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/mariovalney/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariovalney/wp-calypso/merges","archive_url":"https://api.github.com/repos/mariovalney/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariovalney/wp-calypso/downloads","issues_url":"https://api.github.com/repos/mariovalney/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/mariovalney/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/mariovalney/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/mariovalney/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariovalney/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/mariovalney/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/mariovalney/wp-calypso/deployments","created_at":"2018-06-13T18:38:52Z","updated_at":"2018-07-02T23:38:59Z","pushed_at":"2018-07-24T13:42:15Z","git_url":"git://github.com/mariovalney/wp-calypso.git","ssh_url":"git@github.com:mariovalney/wp-calypso.git","clone_url":"https://github.com/mariovalney/wp-calypso.git","svn_url":"https://github.com/mariovalney/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":96197,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"44d302cbf0a6fc65f46a13edb1e811bf762dcfb9","user":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzNjg5NQ==","name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-07-30T12:01:20Z","pushed_at":"2018-07-30T12:20:01Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":102976,"stargazers_count":10141,"watchers_count":10141,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1438,"mirror_url":null,"archived":false,"open_issues_count":1576,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1438,"open_issues":1576,"watchers":10141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/25847"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/25847"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/25847/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25847/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/29b48713e30e818214d7d2d8a56e0061ad004b69"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsnajdr"}}