{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60613","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60613/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60613/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60613/events","html_url":"https://github.com/kubernetes/kubernetes/issues/60613","id":301266290,"number":60613,"title":"kms plugin tests should be unix only","user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":617149945,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-01T03:32:42Z","updated_at":"2018-03-01T03:36:10Z","closed_at":null,"author_association":"MEMBER","body":"<!-- This form is for bug reports and feature requests ONLY! \r\n\r\nIf you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).\r\n-->\r\n\r\n**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n\r\n> Uncomment only one, leave it on its own line: \r\n>\r\n/kind bug\r\n\r\n\r\n**What happened**: `hack/verify-typecheck.sh` gives\r\n```\r\nERROR(windows/amd64) test/integration/master/kms_plugin_mock.go:106:9: Unlink not declared by package unix\r\nERROR(windows/386) test/integration/master/kms_plugin_mock.go:106:9: Unlink not declared by package unix  \r\n```\r\n\r\n**What you expected to happen**: I expect the codebase to typecheck for all platforms/architectures we compile for\r\n\r\n**How to reproduce it (as minimally and precisely as possible)**: `hack/verify-typecheck.sh`\r\n\r\n\r\n**Anything else we need to know?**: the unix package unsurprisingly only builds on unix, we should probably add build tags to these tests so they are skipped for other platforms. This is one of the things preventing us from using typecheck to quickly verify all PRs\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/369464027","html_url":"https://github.com/kubernetes/kubernetes/issues/60613#issuecomment-369464027","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60613","id":369464027,"user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T03:36:10Z","updated_at":"2018-03-01T03:36:10Z","author_association":"MEMBER","body":"/sig testing"}}
{"actor":{"display_login":"BenTheElder"}}