{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/184364338","pull_request_review_id":115543667,"id":184364338,"diff_hunk":"@@ -1796,7 +1796,7 @@ IndirectLighting EvaluateBSDF_SSLighting(LightLoopContext lightLoopContext,\n \n             float3 rayOriginWS      = preLightData.transparentPositionWS;\n             float3 rayDirWS         = preLightData.transparentRefractV;\n-#if DEBUG_DISPLAY\n+#ifdef DEBUG_DISPLAY","path":"ScriptableRenderPipeline/HDRenderPipeline/HDRP/Material/Lit/Lit.hlsl","position":11,"original_position":11,"commit_id":"beb76f36c1f53b1f121d69aff21dfaceba28e1de","original_commit_id":"beb76f36c1f53b1f121d69aff21dfaceba28e1de","user":{"login":"sebastienlagarde","id":21238527,"avatar_url":"https://avatars2.githubusercontent.com/u/21238527?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienlagarde","html_url":"https://github.com/sebastienlagarde","followers_url":"https://api.github.com/users/sebastienlagarde/followers","following_url":"https://api.github.com/users/sebastienlagarde/following{/other_user}","gists_url":"https://api.github.com/users/sebastienlagarde/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienlagarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienlagarde/subscriptions","organizations_url":"https://api.github.com/users/sebastienlagarde/orgs","repos_url":"https://api.github.com/users/sebastienlagarde/repos","events_url":"https://api.github.com/users/sebastienlagarde/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienlagarde/received_events","type":"User","site_admin":false},"body":"Thanks for this fix!","created_at":"2018-04-26T12:05:37Z","updated_at":"2018-04-26T12:05:37Z","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277#discussion_r184364338","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/184364338"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277#discussion_r184364338"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277","id":184161958,"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277","diff_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277.diff","patch_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/1277","number":1277,"state":"open","locked":false,"title":"Switch support","user":{"login":"kaychang-unity","id":37455951,"avatar_url":"https://avatars2.githubusercontent.com/u/37455951?v=4","gravatar_id":"","url":"https://api.github.com/users/kaychang-unity","html_url":"https://github.com/kaychang-unity","followers_url":"https://api.github.com/users/kaychang-unity/followers","following_url":"https://api.github.com/users/kaychang-unity/following{/other_user}","gists_url":"https://api.github.com/users/kaychang-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/kaychang-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaychang-unity/subscriptions","organizations_url":"https://api.github.com/users/kaychang-unity/orgs","repos_url":"https://api.github.com/users/kaychang-unity/repos","events_url":"https://api.github.com/users/kaychang-unity/events{/privacy}","received_events_url":"https://api.github.com/users/kaychang-unity/received_events","type":"User","site_admin":false},"body":"New tentative for Switch support.\r\nHDRP is not working yet. LWRP is partially working.","created_at":"2018-04-25T21:00:09Z","updated_at":"2018-04-26T12:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"phi-lira","id":7453395,"avatar_url":"https://avatars3.githubusercontent.com/u/7453395?v=4","gravatar_id":"","url":"https://api.github.com/users/phi-lira","html_url":"https://github.com/phi-lira","followers_url":"https://api.github.com/users/phi-lira/followers","following_url":"https://api.github.com/users/phi-lira/following{/other_user}","gists_url":"https://api.github.com/users/phi-lira/gists{/gist_id}","starred_url":"https://api.github.com/users/phi-lira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phi-lira/subscriptions","organizations_url":"https://api.github.com/users/phi-lira/orgs","repos_url":"https://api.github.com/users/phi-lira/repos","events_url":"https://api.github.com/users/phi-lira/events{/privacy}","received_events_url":"https://api.github.com/users/phi-lira/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/1277/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/beb76f36c1f53b1f121d69aff21dfaceba28e1de","head":{"label":"Unity-Technologies:switch_support","ref":"switch_support","sha":"beb76f36c1f53b1f121d69aff21dfaceba28e1de","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2018-04-26T09:02:15Z","pushed_at":"2018-04-26T11:53:53Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":1778378,"stargazers_count":649,"watchers_count":649,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":150,"open_issues":25,"watchers":649,"default_branch":"master"}},"base":{"label":"Unity-Technologies:master","ref":"master","sha":"1582124356b1bc3a88dc7366e4401f3b932c27e3","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2018-04-26T09:02:15Z","pushed_at":"2018-04-26T11:53:53Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":1778378,"stargazers_count":649,"watchers_count":649,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":150,"open_issues":25,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/1277"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/1277"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/1277/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/1277/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/beb76f36c1f53b1f121d69aff21dfaceba28e1de"}},"author_association":"NONE"}}
{"actor":{"display_login":"sebastienlagarde"}}