{"action":"created","issue":{"url":"https://api.github.com/repos/typestack/class-transformer/issues/156","repository_url":"https://api.github.com/repos/typestack/class-transformer","labels_url":"https://api.github.com/repos/typestack/class-transformer/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/typestack/class-transformer/issues/156/comments","events_url":"https://api.github.com/repos/typestack/class-transformer/issues/156/events","html_url":"https://github.com/typestack/class-transformer/pull/156","id":334326580,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzI4MTA1","number":156,"title":"Fix circular checks breaking nested serialized types #128","user":{"login":"guscastro","id":5071465,"node_id":"MDQ6VXNlcjUwNzE0NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5071465?v=4","gravatar_id":"","url":"https://api.github.com/users/guscastro","html_url":"https://github.com/guscastro","followers_url":"https://api.github.com/users/guscastro/followers","following_url":"https://api.github.com/users/guscastro/following{/other_user}","gists_url":"https://api.github.com/users/guscastro/gists{/gist_id}","starred_url":"https://api.github.com/users/guscastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guscastro/subscriptions","organizations_url":"https://api.github.com/users/guscastro/orgs","repos_url":"https://api.github.com/users/guscastro/repos","events_url":"https://api.github.com/users/guscastro/events{/privacy}","received_events_url":"https://api.github.com/users/guscastro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-21T03:42:39Z","updated_at":"2018-07-05T23:14:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/typestack/class-transformer/pulls/156","html_url":"https://github.com/typestack/class-transformer/pull/156","diff_url":"https://github.com/typestack/class-transformer/pull/156.diff","patch_url":"https://github.com/typestack/class-transformer/pull/156.patch"},"body":"Fixes #128 and additionally the case added to the test as part of this PR.\r\n\r\nThe library currently detects circular references using a map keeping track of nesting level and disallowing equal references on lower nesting levels (see `transformedTypesMap`).\r\n\r\nI fail to understand why this is necessary. Given transformation is a depth-first traversal of the object graph, my understanding is that a simple add/delete from a stack/`Set` should suffice. Please let me know if I'm missing something.\r\n\r\nAside - unsure why Travis CI is failing on only one of the node versions. I would appreciate some help with that failure."},"comment":{"url":"https://api.github.com/repos/typestack/class-transformer/issues/comments/402878591","html_url":"https://github.com/typestack/class-transformer/pull/156#issuecomment-402878591","issue_url":"https://api.github.com/repos/typestack/class-transformer/issues/156","id":402878591,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjg3ODU5MQ==","user":{"login":"nockawa","id":3279175,"node_id":"MDQ6VXNlcjMyNzkxNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3279175?v=4","gravatar_id":"","url":"https://api.github.com/users/nockawa","html_url":"https://github.com/nockawa","followers_url":"https://api.github.com/users/nockawa/followers","following_url":"https://api.github.com/users/nockawa/following{/other_user}","gists_url":"https://api.github.com/users/nockawa/gists{/gist_id}","starred_url":"https://api.github.com/users/nockawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nockawa/subscriptions","organizations_url":"https://api.github.com/users/nockawa/orgs","repos_url":"https://api.github.com/users/nockawa/repos","events_url":"https://api.github.com/users/nockawa/events{/privacy}","received_events_url":"https://api.github.com/users/nockawa/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T23:14:02Z","updated_at":"2018-07-05T23:14:02Z","author_association":"NONE","body":"@guscastro there's no one to validate your PR, so I assume the NPM packaged is not up to date with this fix?\r\n\r\nI have a simple case of a custom type defining a field of another custom type which is not working at all...\r\nDisappointing, I though I would get rid of all the conversion plumbing...\r\n\r\nIf you have any info, thanks in advance."}}
{"actor":{"display_login":"nockawa"}}