{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments/221534120","pull_request_review_id":160202706,"id":221534120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTUzNDEyMA==","diff_hunk":"@@ -0,0 +1,76 @@\n+const ShowPassword = require('../../utils/show-password');\n+const expect = require('chai').expect;\n+const sinon = require('sinon');\n+\n+describe('ShowPassword', () => {\n+\tlet password;\n+\tlet control;\n+\tlet sandbox;\n+\tlet showPassword;\n+\n+\tbeforeEach(() => {\n+\t\tpassword = { type: '' };\n+\t\tcontrol = { addEventListener: function () {}, checked: false };\n+\t\tshowPassword = new ShowPassword(password, control);\n+\t\tsandbox = sinon.createSandbox();\n+\t\tsandbox.spy(showPassword, 'showPassword');\n+\t\tsandbox.spy(showPassword, 'hidePassword');\n+\t\tsandbox.spy(control, 'addEventListener');\n+\t});\n+\n+\tafterEach(() => {\n+\t\tsandbox.restore();\n+\t});\n+\n+\tdescribe('constructor', () => {\n+\t\tit('should throw an error if password not supplied', () => {\n+\t\t\texpect(() => {\n+\t\t\t\tnew ShowPassword();\n+\t\t\t}).to.throw();\n+\t\t});\n+\n+\t\tit('should throw an error if control not supplied', () => {","path":"tests/utils/show-password.spec.js","position":32,"original_position":32,"commit_id":"9c4b0dc4eef2ec6b6d5809edea125550012c6127","original_commit_id":"9c4b0dc4eef2ec6b6d5809edea125550012c6127","user":{"login":"liamkeaton","id":1721150,"node_id":"MDQ6VXNlcjE3MjExNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1721150?v=4","gravatar_id":"","url":"https://api.github.com/users/liamkeaton","html_url":"https://github.com/liamkeaton","followers_url":"https://api.github.com/users/liamkeaton/followers","following_url":"https://api.github.com/users/liamkeaton/following{/other_user}","gists_url":"https://api.github.com/users/liamkeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/liamkeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamkeaton/subscriptions","organizations_url":"https://api.github.com/users/liamkeaton/orgs","repos_url":"https://api.github.com/users/liamkeaton/repos","events_url":"https://api.github.com/users/liamkeaton/events{/privacy}","received_events_url":"https://api.github.com/users/liamkeaton/received_events","type":"User","site_admin":false},"body":"Good shout, maybe we should rename the var to be `toggle` or `checkbox`?","created_at":"2018-10-01T08:51:39Z","updated_at":"2018-10-01T08:51:39Z","html_url":"https://github.com/Financial-Times/n-conversion-forms/pull/39#discussion_r221534120","pull_request_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments/221534120"},"html":{"href":"https://github.com/Financial-Times/n-conversion-forms/pull/39#discussion_r221534120"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39"}},"in_reply_to_id":221526687},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39","id":219021989,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDIxOTg5","html_url":"https://github.com/Financial-Times/n-conversion-forms/pull/39","diff_url":"https://github.com/Financial-Times/n-conversion-forms/pull/39.diff","patch_url":"https://github.com/Financial-Times/n-conversion-forms/pull/39.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/39","number":39,"state":"open","locked":false,"title":"Hide and show password utility","user":{"login":"liamkeaton","id":1721150,"node_id":"MDQ6VXNlcjE3MjExNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1721150?v=4","gravatar_id":"","url":"https://api.github.com/users/liamkeaton","html_url":"https://github.com/liamkeaton","followers_url":"https://api.github.com/users/liamkeaton/followers","following_url":"https://api.github.com/users/liamkeaton/following{/other_user}","gists_url":"https://api.github.com/users/liamkeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/liamkeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamkeaton/subscriptions","organizations_url":"https://api.github.com/users/liamkeaton/orgs","repos_url":"https://api.github.com/users/liamkeaton/repos","events_url":"https://api.github.com/users/liamkeaton/events{/privacy}","received_events_url":"https://api.github.com/users/liamkeaton/received_events","type":"User","site_admin":false},"body":"## Feature Description\r\nVery simple utility to hide and show passwords by passing in a input field and control checkbox.\r\n","created_at":"2018-09-28T16:28:43Z","updated_at":"2018-10-01T08:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc724ef60409eb42cb4d94f90338d31ce0b64b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/39/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/9c4b0dc4eef2ec6b6d5809edea125550012c6127","head":{"label":"Financial-Times:lk/show-password","ref":"lk/show-password","sha":"9c4b0dc4eef2ec6b6d5809edea125550012c6127","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":133928511,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjg1MTE=","name":"n-conversion-forms","full_name":"Financial-Times/n-conversion-forms","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/n-conversion-forms","description":"Shared components for all conversion forms.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms","forks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/deployments","created_at":"2018-05-18T08:49:07Z","updated_at":"2018-10-01T08:16:44Z","pushed_at":"2018-10-01T08:17:35Z","git_url":"git://github.com/Financial-Times/n-conversion-forms.git","ssh_url":"git@github.com:Financial-Times/n-conversion-forms.git","clone_url":"https://github.com/Financial-Times/n-conversion-forms.git","svn_url":"https://github.com/Financial-Times/n-conversion-forms","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"0e105c678bdb3e9582319a48b9d3a5336ba63713","user":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":133928511,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Mjg1MTE=","name":"n-conversion-forms","full_name":"Financial-Times/n-conversion-forms","private":false,"owner":{"login":"Financial-Times","id":3502508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDI1MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Financial-Times/n-conversion-forms","description":"Shared components for all conversion forms.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-conversion-forms","forks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-conversion-forms/deployments","created_at":"2018-05-18T08:49:07Z","updated_at":"2018-10-01T08:16:44Z","pushed_at":"2018-10-01T08:17:35Z","git_url":"git://github.com/Financial-Times/n-conversion-forms.git","ssh_url":"git@github.com:Financial-Times/n-conversion-forms.git","clone_url":"https://github.com/Financial-Times/n-conversion-forms.git","svn_url":"https://github.com/Financial-Times/n-conversion-forms","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39"},"html":{"href":"https://github.com/Financial-Times/n-conversion-forms/pull/39"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/39"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-conversion-forms/statuses/9c4b0dc4eef2ec6b6d5809edea125550012c6127"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liamkeaton"}}