{"action":"created","comment":{"url":"https://api.github.com/repos/cssinjs/react-jss/pulls/comments/200647703","pull_request_review_id":135007055,"id":200647703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDY0NzcwMw==","diff_hunk":"@@ -21,32 +21,12 @@\n  * @param {Object} styles dynamic styles object without static properties\n  * @return {Object|null}\n  */\n-export default (classes, styles) => {\n-  // Add `composes` property to rules which are already defined in `classes`.\n-  for (const name in styles) {\n-    const className = classes[name]\n-    if (!className) break\n-\n-    if (typeof styles[name] === 'function') {\n-      styles[name] = {\n-        extend: styles[name],\n-        composes: className\n-      }\n-      continue\n-    }\n-\n-    styles[name].composes = className\n-  }\n-\n-  if (styles) {\n-    // Add rules which are defined in `classes` but aren't in styles.\n-    for (const name in classes) {\n-      const className = styles[name]\n-      if (!className) {\n-        styles[name] = {composes: classes[name]}\n-      }\n-    }\n+export default (staticClasses, dynamicClasses) => {\n+  for (const name in dynamicClasses) {\n+    staticClasses[name] = staticClasses[name]","path":"src/compose.js","position":31,"original_position":31,"commit_id":"3f7e6d248afc8a1aacdf0844d56a542721f012d1","original_commit_id":"3f7e6d248afc8a1aacdf0844d56a542721f012d1","user":{"login":"kof","id":52824,"node_id":"MDQ6VXNlcjUyODI0","avatar_url":"https://avatars0.githubusercontent.com/u/52824?v=4","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false},"body":"you are mutating the classes object that you got from the static style sheet, we shouldn't mutate that","created_at":"2018-07-06T13:08:46Z","updated_at":"2018-07-06T13:08:46Z","html_url":"https://github.com/cssinjs/react-jss/pull/271#discussion_r200647703","pull_request_url":"https://api.github.com/repos/cssinjs/react-jss/pulls/271","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/comments/200647703"},"html":{"href":"https://github.com/cssinjs/react-jss/pull/271#discussion_r200647703"},"pull_request":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/cssinjs/react-jss/pulls/271","id":199555409,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTU1NDA5","html_url":"https://github.com/cssinjs/react-jss/pull/271","diff_url":"https://github.com/cssinjs/react-jss/pull/271.diff","patch_url":"https://github.com/cssinjs/react-jss/pull/271.patch","issue_url":"https://api.github.com/repos/cssinjs/react-jss/issues/271","number":271,"state":"open","locked":false,"title":"Fix having empty classes in the dynamic sheet","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"body":"As discussed in #267 \r\nThis should remove empty classes and remove depending on jss-compose and jss-nested.","created_at":"2018-07-05T18:42:46Z","updated_at":"2018-07-06T13:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"972ed057c8be420b80969447718f6ee150573bd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":165202512,"node_id":"MDU6TGFiZWwxNjUyMDI1MTI=","url":"https://api.github.com/repos/cssinjs/react-jss/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/cssinjs/react-jss/pulls/271/commits","review_comments_url":"https://api.github.com/repos/cssinjs/react-jss/pulls/271/comments","review_comment_url":"https://api.github.com/repos/cssinjs/react-jss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cssinjs/react-jss/issues/271/comments","statuses_url":"https://api.github.com/repos/cssinjs/react-jss/statuses/3f7e6d248afc8a1aacdf0844d56a542721f012d1","head":{"label":"HenriBeck:fix-composing-classes","ref":"fix-composing-classes","sha":"3f7e6d248afc8a1aacdf0844d56a542721f012d1","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"repo":{"id":123020327,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMjAzMjc=","name":"react-jss","full_name":"HenriBeck/react-jss","owner":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HenriBeck/react-jss","description":"JSS integration for React.","fork":true,"url":"https://api.github.com/repos/HenriBeck/react-jss","forks_url":"https://api.github.com/repos/HenriBeck/react-jss/forks","keys_url":"https://api.github.com/repos/HenriBeck/react-jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HenriBeck/react-jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HenriBeck/react-jss/teams","hooks_url":"https://api.github.com/repos/HenriBeck/react-jss/hooks","issue_events_url":"https://api.github.com/repos/HenriBeck/react-jss/issues/events{/number}","events_url":"https://api.github.com/repos/HenriBeck/react-jss/events","assignees_url":"https://api.github.com/repos/HenriBeck/react-jss/assignees{/user}","branches_url":"https://api.github.com/repos/HenriBeck/react-jss/branches{/branch}","tags_url":"https://api.github.com/repos/HenriBeck/react-jss/tags","blobs_url":"https://api.github.com/repos/HenriBeck/react-jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HenriBeck/react-jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HenriBeck/react-jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/HenriBeck/react-jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HenriBeck/react-jss/statuses/{sha}","languages_url":"https://api.github.com/repos/HenriBeck/react-jss/languages","stargazers_url":"https://api.github.com/repos/HenriBeck/react-jss/stargazers","contributors_url":"https://api.github.com/repos/HenriBeck/react-jss/contributors","subscribers_url":"https://api.github.com/repos/HenriBeck/react-jss/subscribers","subscription_url":"https://api.github.com/repos/HenriBeck/react-jss/subscription","commits_url":"https://api.github.com/repos/HenriBeck/react-jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/HenriBeck/react-jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/HenriBeck/react-jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/HenriBeck/react-jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/HenriBeck/react-jss/contents/{+path}","compare_url":"https://api.github.com/repos/HenriBeck/react-jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HenriBeck/react-jss/merges","archive_url":"https://api.github.com/repos/HenriBeck/react-jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HenriBeck/react-jss/downloads","issues_url":"https://api.github.com/repos/HenriBeck/react-jss/issues{/number}","pulls_url":"https://api.github.com/repos/HenriBeck/react-jss/pulls{/number}","milestones_url":"https://api.github.com/repos/HenriBeck/react-jss/milestones{/number}","notifications_url":"https://api.github.com/repos/HenriBeck/react-jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HenriBeck/react-jss/labels{/name}","releases_url":"https://api.github.com/repos/HenriBeck/react-jss/releases{/id}","deployments_url":"https://api.github.com/repos/HenriBeck/react-jss/deployments","created_at":"2018-02-26T19:35:07Z","updated_at":"2018-04-18T18:42:02Z","pushed_at":"2018-07-05T19:13:48Z","git_url":"git://github.com/HenriBeck/react-jss.git","ssh_url":"git@github.com:HenriBeck/react-jss.git","clone_url":"https://github.com/HenriBeck/react-jss.git","svn_url":"https://github.com/HenriBeck/react-jss","homepage":"http://cssinjs.org/react-jss","size":769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cssinjs:master","ref":"master","sha":"09347d14b4d260fe7af9934ea0e23bb135ce4901","user":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":29107681,"node_id":"MDEwOlJlcG9zaXRvcnkyOTEwNzY4MQ==","name":"react-jss","full_name":"cssinjs/react-jss","owner":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cssinjs/react-jss","description":"JSS integration for React.","fork":false,"url":"https://api.github.com/repos/cssinjs/react-jss","forks_url":"https://api.github.com/repos/cssinjs/react-jss/forks","keys_url":"https://api.github.com/repos/cssinjs/react-jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cssinjs/react-jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cssinjs/react-jss/teams","hooks_url":"https://api.github.com/repos/cssinjs/react-jss/hooks","issue_events_url":"https://api.github.com/repos/cssinjs/react-jss/issues/events{/number}","events_url":"https://api.github.com/repos/cssinjs/react-jss/events","assignees_url":"https://api.github.com/repos/cssinjs/react-jss/assignees{/user}","branches_url":"https://api.github.com/repos/cssinjs/react-jss/branches{/branch}","tags_url":"https://api.github.com/repos/cssinjs/react-jss/tags","blobs_url":"https://api.github.com/repos/cssinjs/react-jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cssinjs/react-jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cssinjs/react-jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/cssinjs/react-jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cssinjs/react-jss/statuses/{sha}","languages_url":"https://api.github.com/repos/cssinjs/react-jss/languages","stargazers_url":"https://api.github.com/repos/cssinjs/react-jss/stargazers","contributors_url":"https://api.github.com/repos/cssinjs/react-jss/contributors","subscribers_url":"https://api.github.com/repos/cssinjs/react-jss/subscribers","subscription_url":"https://api.github.com/repos/cssinjs/react-jss/subscription","commits_url":"https://api.github.com/repos/cssinjs/react-jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/cssinjs/react-jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/cssinjs/react-jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/cssinjs/react-jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/cssinjs/react-jss/contents/{+path}","compare_url":"https://api.github.com/repos/cssinjs/react-jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cssinjs/react-jss/merges","archive_url":"https://api.github.com/repos/cssinjs/react-jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cssinjs/react-jss/downloads","issues_url":"https://api.github.com/repos/cssinjs/react-jss/issues{/number}","pulls_url":"https://api.github.com/repos/cssinjs/react-jss/pulls{/number}","milestones_url":"https://api.github.com/repos/cssinjs/react-jss/milestones{/number}","notifications_url":"https://api.github.com/repos/cssinjs/react-jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cssinjs/react-jss/labels{/name}","releases_url":"https://api.github.com/repos/cssinjs/react-jss/releases{/id}","deployments_url":"https://api.github.com/repos/cssinjs/react-jss/deployments","created_at":"2015-01-11T21:58:34Z","updated_at":"2018-07-06T07:29:27Z","pushed_at":"2018-07-06T07:29:25Z","git_url":"git://github.com/cssinjs/react-jss.git","ssh_url":"git@github.com:cssinjs/react-jss.git","clone_url":"https://github.com/cssinjs/react-jss.git","svn_url":"https://github.com/cssinjs/react-jss","homepage":"http://cssinjs.org/react-jss","size":784,"stargazers_count":938,"watchers_count":938,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":22,"watchers":938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/271"},"html":{"href":"https://github.com/cssinjs/react-jss/pull/271"},"issue":{"href":"https://api.github.com/repos/cssinjs/react-jss/issues/271"},"comments":{"href":"https://api.github.com/repos/cssinjs/react-jss/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cssinjs/react-jss/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/cssinjs/react-jss/statuses/3f7e6d248afc8a1aacdf0844d56a542721f012d1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kof"}}