{"action":"created","issue":{"url":"https://api.github.com/repos/rugk/offline-qr-code/issues/108","repository_url":"https://api.github.com/repos/rugk/offline-qr-code","labels_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/108/comments","events_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/108/events","html_url":"https://github.com/rugk/offline-qr-code/pull/108","id":339989580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTA5OTk1","number":108,"title":"Added retry mechanism for tabs","user":{"login":"OogieBoogieInJSON","id":1884609,"node_id":"MDQ6VXNlcjE4ODQ2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1884609?v=4","gravatar_id":"","url":"https://api.github.com/users/OogieBoogieInJSON","html_url":"https://github.com/OogieBoogieInJSON","followers_url":"https://api.github.com/users/OogieBoogieInJSON/followers","following_url":"https://api.github.com/users/OogieBoogieInJSON/following{/other_user}","gists_url":"https://api.github.com/users/OogieBoogieInJSON/gists{/gist_id}","starred_url":"https://api.github.com/users/OogieBoogieInJSON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OogieBoogieInJSON/subscriptions","organizations_url":"https://api.github.com/users/OogieBoogieInJSON/orgs","repos_url":"https://api.github.com/users/OogieBoogieInJSON/repos","events_url":"https://api.github.com/users/OogieBoogieInJSON/events{/privacy}","received_events_url":"https://api.github.com/users/OogieBoogieInJSON/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-07-10T20:12:03Z","updated_at":"2018-07-15T19:19:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rugk/offline-qr-code/pulls/108","html_url":"https://github.com/rugk/offline-qr-code/pull/108","diff_url":"https://github.com/rugk/offline-qr-code/pull/108.diff","patch_url":"https://github.com/rugk/offline-qr-code/pull/108.patch"},"body":"Fixes #98 \r\n\r\nI've tried with the onUpdate listener but aparently the behavior is unpredictable. When the event is triggered with status being complete all urls are missing but the API docs say they should be there.\r\nI ended up with this implementation but still if you are super quick after pressing enter to navigate to that url and then open the extension, the tabs query will not have the urls in there. By super quick, I mean under a second."},"comment":{"url":"https://api.github.com/repos/rugk/offline-qr-code/issues/comments/405111902","html_url":"https://github.com/rugk/offline-qr-code/pull/108#issuecomment-405111902","issue_url":"https://api.github.com/repos/rugk/offline-qr-code/issues/108","id":405111902,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTExMTkwMg==","user":{"login":"rugk","id":11966684,"node_id":"MDQ6VXNlcjExOTY2Njg0","avatar_url":"https://avatars3.githubusercontent.com/u/11966684?v=4","gravatar_id":"","url":"https://api.github.com/users/rugk","html_url":"https://github.com/rugk","followers_url":"https://api.github.com/users/rugk/followers","following_url":"https://api.github.com/users/rugk/following{/other_user}","gists_url":"https://api.github.com/users/rugk/gists{/gist_id}","starred_url":"https://api.github.com/users/rugk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rugk/subscriptions","organizations_url":"https://api.github.com/users/rugk/orgs","repos_url":"https://api.github.com/users/rugk/repos","events_url":"https://api.github.com/users/rugk/events{/privacy}","received_events_url":"https://api.github.com/users/rugk/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T19:19:06Z","updated_at":"2018-07-15T19:19:06Z","author_association":"OWNER","body":"Oh, I found an issue in the logic: You both throw an error if the maximum retries were exceeded _and_ when the `tab.url` is not there. So either this causes it to always re-try (which it does not seem to do), or it causes it to stop retrying when `tab.url` is `undefined`.\r\n\r\nAlso the `retryPromise` code is not really clear to me. Should not you e.g. create the `new Promise` only after the original `invokedFunction` promise was rejected?\r\nMaybe try to specify the maximum retry amount in `retryPromise`, too?"}}
{"actor":{"display_login":"rugk"}}