{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/14870","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/14870/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14870/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/14870/events","html_url":"https://github.com/sympy/sympy/pull/14870","id":338573999,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDY5NjM2","number":14870,"title":"fix to issue #14732","user":{"login":"avishrivastava11","id":35996093,"node_id":"MDQ6VXNlcjM1OTk2MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/35996093?v=4","gravatar_id":"","url":"https://api.github.com/users/avishrivastava11","html_url":"https://github.com/avishrivastava11","followers_url":"https://api.github.com/users/avishrivastava11/followers","following_url":"https://api.github.com/users/avishrivastava11/following{/other_user}","gists_url":"https://api.github.com/users/avishrivastava11/gists{/gist_id}","starred_url":"https://api.github.com/users/avishrivastava11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishrivastava11/subscriptions","organizations_url":"https://api.github.com/users/avishrivastava11/orgs","repos_url":"https://api.github.com/users/avishrivastava11/repos","events_url":"https://api.github.com/users/avishrivastava11/events{/privacy}","received_events_url":"https://api.github.com/users/avishrivastava11/received_events","type":"User","site_admin":false},"labels":[{"id":222449974,"node_id":"MDU6TGFiZWwyMjI0NDk5NzQ=","url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn","name":"PR: author's turn","color":"ffff80","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-05T13:25:34Z","updated_at":"2018-07-25T03:16:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14870","html_url":"https://github.com/sympy/sympy/pull/14870","diff_url":"https://github.com/sympy/sympy/pull/14870.diff","patch_url":"https://github.com/sympy/sympy/pull/14870.patch"},"body":"Added better documentation for evalf(subs=...)\r\n\r\n#14732\r\nFixes #14732\r\n\r\nI have added an explanation as to why we should prefer expr.evalf(subs=...) over expr.subs(...).evalf() or expr.evalf().subs(...)\r\n\r\nAlong with that, I've also added the explanation and the example given by @asmeurer in answering the question on stack-overflow ( https://stackoverflow.com/questions/50439037/what-exactly-is-the-subs-argument-of-the-evalf-method-of-sympy-expression-fo )\r\n\r\n@asmeurer  @smichr  and other members and contributers\r\nPls review this PR, and let me know the improvements\r\nGreat working with you guys. :)\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\nNO ENTRY\r\n<!-- END RELEASE NOTES -->\r\n"},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/407620265","html_url":"https://github.com/sympy/sympy/pull/14870#issuecomment-407620265","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14870","id":407620265,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzYyMDI2NQ==","user":{"login":"smichr","id":90703,"node_id":"MDQ6VXNlcjkwNzAz","avatar_url":"https://avatars3.githubusercontent.com/u/90703?v=4","gravatar_id":"","url":"https://api.github.com/users/smichr","html_url":"https://github.com/smichr","followers_url":"https://api.github.com/users/smichr/followers","following_url":"https://api.github.com/users/smichr/following{/other_user}","gists_url":"https://api.github.com/users/smichr/gists{/gist_id}","starred_url":"https://api.github.com/users/smichr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smichr/subscriptions","organizations_url":"https://api.github.com/users/smichr/orgs","repos_url":"https://api.github.com/users/smichr/repos","events_url":"https://api.github.com/users/smichr/events{/privacy}","received_events_url":"https://api.github.com/users/smichr/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T03:16:05Z","updated_at":"2018-07-25T03:16:05Z","author_association":"MEMBER","body":"@avishrivastava11, thanks for getting this going. This was a needed addition to the docs. As I wrote in one of my commit notes, I wonder if this sort of evaluation should be done automatically when doing subs if there are no free symbols in the substitution result. That can be a new issue/topic for discussion, however."}}
{"actor":{"display_login":"smichr"}}