{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/12","repository_url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec","labels_url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/12/comments","events_url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/12/events","html_url":"https://github.com/wordpress-mobile/react-native-aztec/pull/12","id":315671100,"number":12,"title":"Initial iOS support.","user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars1.githubusercontent.com/u/1836005?v=4","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"labels":[{"id":869431205,"url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-18T22:59:24Z","updated_at":"2018-04-19T15:30:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/pulls/12","html_url":"https://github.com/wordpress-mobile/react-native-aztec/pull/12","diff_url":"https://github.com/wordpress-mobile/react-native-aztec/pull/12.diff","patch_url":"https://github.com/wordpress-mobile/react-native-aztec/pull/12.patch"},"body":"### Description\r\n\r\nThis PR adds initial support for iOS.  It allows running the project in iOS and loading a very simple (solid blue) view - as a placeholder for Aztec.\r\n\r\n### Details:\r\n\r\nThere are several changes included in this PR due to several issues I had to deal with in iOS:\r\n\r\n- Added two identical .gitignore files for Xcode / Swift / ObjC ([one](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-d7c35f6840db1950f2da9713671b70ddR1) for the example project, and [one](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-88fb5bc44eff8c82891374d0ae90f56aR1) for the root project).  They're both a copy of [GitHub's Swift `.gitignore` file](https://github.com/github/gitignore/blob/master/Swift.gitignore).  The reason I kept them in the Xcode project folder is to make it easier to update them by just overwriting the files.  The added bonus is that Android devs don't need to care about iOS's files.  The downside is the `.gitignore` file is duplicated.  Feel free to criticize!\r\n- The root `package.json` [no longer tries to clean the example App](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L8).  The rationale is that the library shouldn't care about the example App's caches.\r\n- Added [a clean and clean:install procedure](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-012ac553d93d987b8d34ad013052bc96R11) to the example app's `package.json` file.\r\n- Added [some iOS cleaning procedures](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-012ac553d93d987b8d34ad013052bc96R12) which shouln't run if Xcode isn't installed.\r\n- Added a `yarn clean cache --force` call to both [the root](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R8) and [the example app's](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-012ac553d93d987b8d34ad013052bc96R11) clean procedures.\r\n- Updated [the `react` and `react-native` dependencies](https://github.com/wordpress-mobile/react-native-aztec/pull/12/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R12) to be compatible with Xcode 9.3.\r\n- Updated `yarn.lock`, although I'm not sure if that's necessary - let me know if it's appropriate to roll that back.\r\n\r\n### Additional Info\r\n\r\n<details><summary>Expand to see .babelrc error log</summary>\r\n\r\n```\r\nerror: bundling failed: Error: Unable to resolve module `./node_modules` from `/Users/diego/Developer/react-native-aztec/example/App.js`: The module `./node_modules` could not be found from `/Users/diego/Developer/react-native-aztec/example/App.js`. Indeed, none of these files exist:\r\n\r\n  * `/Users/diego/Developer/react-native-aztec/example/node_modules(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json)`\r\n  * `/Users/diego/Developer/react-native-aztec/example/node_modules/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json)`\r\n    at ModuleResolver.resolveDependency (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:161:851)\r\n    at ResolutionRequest.resolveDependency (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:91:16)\r\n    at DependencyGraph.resolveDependency (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/node-haste/DependencyGraph.js:272:4579)\r\n    at dependencies.map.relativePath (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/DeltaBundler/traverseDependencies.js:376:19)\r\n    at Array.map (<anonymous>)\r\n    at resolveDependencies (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/DeltaBundler/traverseDependencies.js:374:16)\r\n    at /Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/DeltaBundler/traverseDependencies.js:212:33\r\n    at Generator.next (<anonymous>)\r\n    at step (/Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/DeltaBundler/traverseDependencies.js:297:313)\r\n    at /Users/diego/Developer/react-native-aztec/example/node_modules/metro/src/DeltaBundler/traverseDependencies.js:297:473\r\n BUNDLE  [ios, dev] ./index.js ░░░░░░░░░░░░░░░░ 0.0% (0/1), failed.\r\n```\r\n</details>\r\n\r\n### Important\r\n\r\nPlease note that I haven't tested how my changes impact Android because I don't have the environment set-up yet (work in progress).  So test carefully and let me know if there's any problem.\r\n\r\n### Testing\r\n\r\n- Do `yarn:clean install` in the root directory.  Make sure all is fine.\r\n- Do `yarn:clean install` in the `example` directory.  Make sure all is fine and the new iOS cleaning procedures don't show errors.  Make sure `example/node_modules/react-native-aztec` exists.\r\n- Run the Android example project and make sure there are no errors.\r\n- Run the iOS example project and make sure a blue view (placeholder view) is displayed.\r\n\r\n<img width=\"522\" alt=\"screen shot 2018-04-18 at 13 37 02\" src=\"https://user-images.githubusercontent.com/1836005/38962239-c5d1245c-4342-11e8-8865-bfea27d8c375.png\">"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/comments/382779642","html_url":"https://github.com/wordpress-mobile/react-native-aztec/pull/12#issuecomment-382779642","issue_url":"https://api.github.com/repos/wordpress-mobile/react-native-aztec/issues/12","id":382779642,"user":{"login":"diegoreymendez","id":1836005,"avatar_url":"https://avatars1.githubusercontent.com/u/1836005?v=4","gravatar_id":"","url":"https://api.github.com/users/diegoreymendez","html_url":"https://github.com/diegoreymendez","followers_url":"https://api.github.com/users/diegoreymendez/followers","following_url":"https://api.github.com/users/diegoreymendez/following{/other_user}","gists_url":"https://api.github.com/users/diegoreymendez/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoreymendez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoreymendez/subscriptions","organizations_url":"https://api.github.com/users/diegoreymendez/orgs","repos_url":"https://api.github.com/users/diegoreymendez/repos","events_url":"https://api.github.com/users/diegoreymendez/events{/privacy}","received_events_url":"https://api.github.com/users/diegoreymendez/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T15:30:29Z","updated_at":"2018-04-19T15:30:29Z","author_association":"NONE","body":"Removed the `yarn cache clean --force` command, and updated the GitHub issue description @maxme."}}
{"actor":{"display_login":"diegoreymendez"}}