{"action":"created","comment":{"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments/234602932","pull_request_review_id":176276459,"id":234602932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDYwMjkzMg==","diff_hunk":"@@ -13,17 +13,7 @@ ColumnLayout {\n \n     onVisibleChanged: visible ? load() : ''\n     function load() {\n-        yubiKey.pivReadCertificate(slot, function (resp) {\n-            if (resp.success) {\n-                certificate = resp.cert\n-            } else {\n-                if (resp.error) {\n-                    pivError.show(resp.error)\n-                } else {\n-                    pivError.show('Failed to read certificate')\n-                }\n-            }\n-        })\n+        yubiKey.refreshPiv(function () {})","path":"ykman-gui/qml/PivCertificateInfo.qml","position":15,"original_position":15,"commit_id":"831efa08253ef68539fcf2518b4ed5232836e105","original_commit_id":"831efa08253ef68539fcf2518b4ed5232836e105","user":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"Good points!","created_at":"2018-11-19T12:38:32Z","updated_at":"2018-11-19T12:38:32Z","html_url":"https://github.com/Yubico/yubikey-manager-qt/pull/91#discussion_r234602932","pull_request_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments/234602932"},"html":{"href":"https://github.com/Yubico/yubikey-manager-qt/pull/91#discussion_r234602932"},"pull_request":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91"}},"in_reply_to_id":234534405},"pull_request":{"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91","id":231624354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjI0MzU0","html_url":"https://github.com/Yubico/yubikey-manager-qt/pull/91","diff_url":"https://github.com/Yubico/yubikey-manager-qt/pull/91.diff","patch_url":"https://github.com/Yubico/yubikey-manager-qt/pull/91.patch","issue_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/91","number":91,"state":"open","locked":false,"title":"Merge pivListCertificates and pivReadCertificate into refreshPiv","user":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"This causes some error handling to be removed, since we don't have any good facilities for capturing errors from `refreshPiv` right now.","created_at":"2018-11-16T18:56:25Z","updated_at":"2018-11-19T12:38:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f0d37d185fb8811c6dd7363adb59ab8678266e1","assignee":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"assignees":[{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91/commits","review_comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91/comments","review_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/91/comments","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/831efa08253ef68539fcf2518b4ed5232836e105","head":{"label":"Yubico:piv-refresh-list-certs","ref":"piv-refresh-list-certs","sha":"831efa08253ef68539fcf2518b4ed5232836e105","user":{"login":"Yubico","id":531825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTgyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"repo":{"id":71568220,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2ODIyMA==","name":"yubikey-manager-qt","full_name":"Yubico/yubikey-manager-qt","private":false,"owner":{"login":"Yubico","id":531825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTgyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yubico/yubikey-manager-qt","description":"Cross-platform application for configuring any YubiKey over all USB interfaces.","fork":false,"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt","forks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/forks","keys_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/teams","hooks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/hooks","issue_events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/events","assignees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/tags","blobs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/languages","stargazers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/stargazers","contributors_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contributors","subscribers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscribers","subscription_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscription","commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/merges","archive_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/downloads","issues_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/labels{/name}","releases_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/deployments","created_at":"2016-10-21T13:40:28Z","updated_at":"2018-11-15T12:16:27Z","pushed_at":"2018-11-19T09:05:52Z","git_url":"git://github.com/Yubico/yubikey-manager-qt.git","ssh_url":"git@github.com:Yubico/yubikey-manager-qt.git","clone_url":"https://github.com/Yubico/yubikey-manager-qt.git","svn_url":"https://github.com/Yubico/yubikey-manager-qt","homepage":"https://developers.yubico.com/yubikey-manager-qt/","size":13006,"stargazers_count":64,"watchers_count":64,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":6,"open_issues":7,"watchers":64,"default_branch":"master"}},"base":{"label":"Yubico:piv","ref":"piv","sha":"c94f91695edf72414f5e03cf1df5191a2271f290","user":{"login":"Yubico","id":531825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTgyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"repo":{"id":71568220,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2ODIyMA==","name":"yubikey-manager-qt","full_name":"Yubico/yubikey-manager-qt","private":false,"owner":{"login":"Yubico","id":531825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTgyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yubico/yubikey-manager-qt","description":"Cross-platform application for configuring any YubiKey over all USB interfaces.","fork":false,"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt","forks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/forks","keys_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/teams","hooks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/hooks","issue_events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/events","assignees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/tags","blobs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/languages","stargazers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/stargazers","contributors_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contributors","subscribers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscribers","subscription_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscription","commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/merges","archive_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/downloads","issues_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/labels{/name}","releases_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/deployments","created_at":"2016-10-21T13:40:28Z","updated_at":"2018-11-15T12:16:27Z","pushed_at":"2018-11-19T09:05:52Z","git_url":"git://github.com/Yubico/yubikey-manager-qt.git","ssh_url":"git@github.com:Yubico/yubikey-manager-qt.git","clone_url":"https://github.com/Yubico/yubikey-manager-qt.git","svn_url":"https://github.com/Yubico/yubikey-manager-qt","homepage":"https://developers.yubico.com/yubikey-manager-qt/","size":13006,"stargazers_count":64,"watchers_count":64,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":6,"open_issues":7,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91"},"html":{"href":"https://github.com/Yubico/yubikey-manager-qt/pull/91"},"issue":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/91"},"comments":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/831efa08253ef68539fcf2518b4ed5232836e105"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"emlun"}}