{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/dijit/pulls/comments/174522139","pull_request_review_id":103894495,"id":174522139,"diff_hunk":"@@ -431,6 +432,34 @@ define([\n \t\t\t\t\t}, 10);\n \t\t\t\t}\n \t\t\t}\n+\t\t},\n+\n+\t\t_onMouseUp: function(){\n+\t\t\t// summary:\n+\t\t\t//\t\tFunction to define a behavior on mouse up on the element\n+\t\t\t//\t\ttype this dialog edits to move the cursor just outside\n+\t\t\t//\t\tanchor tags when clicking on their edges.\n+\t\t\t// tags:\n+\t\t\t//\t\tprotected.\n+\t\t\tif(has('ff')){","path":"_editor/plugins/LinkDialog.js","position":21,"original_position":21,"commit_id":"7d0361fef12d2e7fd317420fb2f3dec6af885847","original_commit_id":"7d0361fef12d2e7fd317420fb2f3dec6af885847","user":{"login":"pottedmeat","id":38750,"avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"body":"I'd be happy to have this work across the board because, as I mentioned above, even Chrome has situations where it leaves the cursor inside the anchor. Someone with more expertise may be able to do the right feature detection to ensure these APIs function as expected across the board.","created_at":"2018-03-14T16:24:52Z","updated_at":"2018-03-14T16:24:52Z","html_url":"https://github.com/dojo/dijit/pull/137#discussion_r174522139","pull_request_url":"https://api.github.com/repos/dojo/dijit/pulls/137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dojo/dijit/pulls/comments/174522139"},"html":{"href":"https://github.com/dojo/dijit/pull/137#discussion_r174522139"},"pull_request":{"href":"https://api.github.com/repos/dojo/dijit/pulls/137"}},"in_reply_to_id":174517356},"pull_request":{"url":"https://api.github.com/repos/dojo/dijit/pulls/137","id":174756509,"html_url":"https://github.com/dojo/dijit/pull/137","diff_url":"https://github.com/dojo/dijit/pull/137.diff","patch_url":"https://github.com/dojo/dijit/pull/137.patch","issue_url":"https://api.github.com/repos/dojo/dijit/issues/137","number":137,"state":"open","locked":false,"title":"In FF, move the cursor just outside anchor tags when clicking on their edges","user":{"login":"pottedmeat","id":38750,"avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"body":"When using the editor in Firefox, clicking at the edges of anchor links inserts text within the link.\r\n\r\n* This implementation targets Firefox specifically right now, though I noticed in Chrome, for example, that clicking a link at the very start of a line runs into the same problem\r\n* Behavior is only enforced when a 0-width selection is encountered (e.g. just a click)\r\n* Behavior is only tied to mouse selection\r\n* A single-character link could either be selected via click and drag or navigated to by key press\r\n* You can still get to the beginning/end of a link's text via key press","created_at":"2018-03-13T18:50:44Z","updated_at":"2018-03-14T16:24:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03873a07e20af4395b5dc2ce57508bef05388fce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/dojo/dijit/milestones/9","html_url":"https://github.com/dojo/dijit/milestone/9","labels_url":"https://api.github.com/repos/dojo/dijit/milestones/9/labels","id":3123906,"number":9,"title":"1.13.1","description":null,"creator":{"login":"dylans","id":97291,"avatar_url":"https://avatars1.githubusercontent.com/u/97291?v=4","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2018-02-17T12:34:35Z","updated_at":"2018-03-14T16:11:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dojo/dijit/pulls/137/commits","review_comments_url":"https://api.github.com/repos/dojo/dijit/pulls/137/comments","review_comment_url":"https://api.github.com/repos/dojo/dijit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/dijit/issues/137/comments","statuses_url":"https://api.github.com/repos/dojo/dijit/statuses/7d0361fef12d2e7fd317420fb2f3dec6af885847","head":{"label":"pottedmeat:firefox-link-selection","ref":"firefox-link-selection","sha":"7d0361fef12d2e7fd317420fb2f3dec6af885847","user":{"login":"pottedmeat","id":38750,"avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"repo":{"id":70070383,"name":"dijit","full_name":"pottedmeat/dijit","owner":{"login":"pottedmeat","id":38750,"avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pottedmeat/dijit","description":"The Dojo Toolkit UI library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":true,"url":"https://api.github.com/repos/pottedmeat/dijit","forks_url":"https://api.github.com/repos/pottedmeat/dijit/forks","keys_url":"https://api.github.com/repos/pottedmeat/dijit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pottedmeat/dijit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pottedmeat/dijit/teams","hooks_url":"https://api.github.com/repos/pottedmeat/dijit/hooks","issue_events_url":"https://api.github.com/repos/pottedmeat/dijit/issues/events{/number}","events_url":"https://api.github.com/repos/pottedmeat/dijit/events","assignees_url":"https://api.github.com/repos/pottedmeat/dijit/assignees{/user}","branches_url":"https://api.github.com/repos/pottedmeat/dijit/branches{/branch}","tags_url":"https://api.github.com/repos/pottedmeat/dijit/tags","blobs_url":"https://api.github.com/repos/pottedmeat/dijit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pottedmeat/dijit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pottedmeat/dijit/git/refs{/sha}","trees_url":"https://api.github.com/repos/pottedmeat/dijit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pottedmeat/dijit/statuses/{sha}","languages_url":"https://api.github.com/repos/pottedmeat/dijit/languages","stargazers_url":"https://api.github.com/repos/pottedmeat/dijit/stargazers","contributors_url":"https://api.github.com/repos/pottedmeat/dijit/contributors","subscribers_url":"https://api.github.com/repos/pottedmeat/dijit/subscribers","subscription_url":"https://api.github.com/repos/pottedmeat/dijit/subscription","commits_url":"https://api.github.com/repos/pottedmeat/dijit/commits{/sha}","git_commits_url":"https://api.github.com/repos/pottedmeat/dijit/git/commits{/sha}","comments_url":"https://api.github.com/repos/pottedmeat/dijit/comments{/number}","issue_comment_url":"https://api.github.com/repos/pottedmeat/dijit/issues/comments{/number}","contents_url":"https://api.github.com/repos/pottedmeat/dijit/contents/{+path}","compare_url":"https://api.github.com/repos/pottedmeat/dijit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pottedmeat/dijit/merges","archive_url":"https://api.github.com/repos/pottedmeat/dijit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pottedmeat/dijit/downloads","issues_url":"https://api.github.com/repos/pottedmeat/dijit/issues{/number}","pulls_url":"https://api.github.com/repos/pottedmeat/dijit/pulls{/number}","milestones_url":"https://api.github.com/repos/pottedmeat/dijit/milestones{/number}","notifications_url":"https://api.github.com/repos/pottedmeat/dijit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pottedmeat/dijit/labels{/name}","releases_url":"https://api.github.com/repos/pottedmeat/dijit/releases{/id}","deployments_url":"https://api.github.com/repos/pottedmeat/dijit/deployments","created_at":"2016-10-05T14:52:44Z","updated_at":"2018-03-13T18:35:32Z","pushed_at":"2018-03-13T20:28:32Z","git_url":"git://github.com/pottedmeat/dijit.git","ssh_url":"git@github.com:pottedmeat/dijit.git","clone_url":"https://github.com/pottedmeat/dijit.git","svn_url":"https://github.com/pottedmeat/dijit","homepage":"https://dojotoolkit.org/","size":30045,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"b1d699622533d7f900c0177faaccba355b083e88","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":10160531,"name":"dijit","full_name":"dojo/dijit","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/dijit","description":"Dojo 1 - UI library. Please submit bugs to https://bugs.dojotoolkit.org/","fork":false,"url":"https://api.github.com/repos/dojo/dijit","forks_url":"https://api.github.com/repos/dojo/dijit/forks","keys_url":"https://api.github.com/repos/dojo/dijit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/dijit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/dijit/teams","hooks_url":"https://api.github.com/repos/dojo/dijit/hooks","issue_events_url":"https://api.github.com/repos/dojo/dijit/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/dijit/events","assignees_url":"https://api.github.com/repos/dojo/dijit/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/dijit/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/dijit/tags","blobs_url":"https://api.github.com/repos/dojo/dijit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/dijit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/dijit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/dijit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/dijit/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/dijit/languages","stargazers_url":"https://api.github.com/repos/dojo/dijit/stargazers","contributors_url":"https://api.github.com/repos/dojo/dijit/contributors","subscribers_url":"https://api.github.com/repos/dojo/dijit/subscribers","subscription_url":"https://api.github.com/repos/dojo/dijit/subscription","commits_url":"https://api.github.com/repos/dojo/dijit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/dijit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/dijit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/dijit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/dijit/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/dijit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/dijit/merges","archive_url":"https://api.github.com/repos/dojo/dijit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/dijit/downloads","issues_url":"https://api.github.com/repos/dojo/dijit/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/dijit/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/dijit/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/dijit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/dijit/labels{/name}","releases_url":"https://api.github.com/repos/dojo/dijit/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/dijit/deployments","created_at":"2013-05-19T19:50:33Z","updated_at":"2018-03-11T18:14:10Z","pushed_at":"2018-03-13T20:35:44Z","git_url":"git://github.com/dojo/dijit.git","ssh_url":"git@github.com:dojo/dijit.git","clone_url":"https://github.com/dojo/dijit.git","svn_url":"https://github.com/dojo/dijit","homepage":"https://dojotoolkit.org/","size":30066,"stargazers_count":168,"watchers_count":168,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":176,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":176,"open_issues":6,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/dijit/pulls/137"},"html":{"href":"https://github.com/dojo/dijit/pull/137"},"issue":{"href":"https://api.github.com/repos/dojo/dijit/issues/137"},"comments":{"href":"https://api.github.com/repos/dojo/dijit/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/dijit/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/dijit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/dijit/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/dijit/statuses/7d0361fef12d2e7fd317420fb2f3dec6af885847"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pottedmeat"}}