{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/215989264","pull_request_review_id":153380918,"id":215989264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk4OTI2NA==","diff_hunk":"@@ -74,15 +74,26 @@ export class AbstractClosedCaptionButton\n  * {@code AbstractClosedCaptionButton} component.\n  *\n  * @param {Object} state - The redux state.\n+ * @param {Object} ownProps - The properties explicitly passed to the component\n+ * instance.\n  * @private\n  * @returns {{\n- *     __requestingSubtitles: boolean\n+ *     _requestingSubtitles: boolean,\n+ *     visible: boolean\n  * }}\n  */\n-export function _abstractMapStateToProps(state: Object) {\n+export function _abstractMapStateToProps(state: Object, ownProps: Object) {\n     const { _requestingSubtitles } = state['features/subtitles'];\n+    const { transcribingEnabled } = state['features/base/config'];\n+\n+    let { visible } = ownProps;\n+\n+    if (typeof visible === 'undefined') {\n+        visible = transcribingEnabled;\n+    }","path":"react/features/subtitles/components/AbstractClosedCaptionButton.js","position":null,"original_position":22,"commit_id":"dcb98e210ddb86ca9445fe00c43ff9eea1397845","original_commit_id":"e8b4fe0bb004e42b4028219874f742b78ba46dc5","user":{"login":"paweldomas","id":2965063,"node_id":"MDQ6VXNlcjI5NjUwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2965063?v=4","gravatar_id":"","url":"https://api.github.com/users/paweldomas","html_url":"https://github.com/paweldomas","followers_url":"https://api.github.com/users/paweldomas/followers","following_url":"https://api.github.com/users/paweldomas/following{/other_user}","gists_url":"https://api.github.com/users/paweldomas/gists{/gist_id}","starred_url":"https://api.github.com/users/paweldomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paweldomas/subscriptions","organizations_url":"https://api.github.com/users/paweldomas/orgs","repos_url":"https://api.github.com/users/paweldomas/repos","events_url":"https://api.github.com/users/paweldomas/events{/privacy}","received_events_url":"https://api.github.com/users/paweldomas/received_events","type":"User","site_admin":false},"body":"I remember it was taking me so much time reading such neatly optimised code and trying to decode what each of the parts are doing exactly. It was the code around here (it has change a bit since then):\r\nhttps://github.com/jitsi/jitsi-meet/blob/master/react/features/base/lib-jitsi-meet/native/RTCPeerConnection.js#L285\r\nIt's still people reading that code and not interpreters.","created_at":"2018-09-07T15:02:19Z","updated_at":"2018-09-07T15:02:20Z","html_url":"https://github.com/jitsi/jitsi-meet/pull/3424#discussion_r215989264","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/215989264"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/3424#discussion_r215989264"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424"}},"in_reply_to_id":215846484},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424","id":213655128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjU1MTI4","html_url":"https://github.com/jitsi/jitsi-meet/pull/3424","diff_url":"https://github.com/jitsi/jitsi-meet/pull/3424.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/3424.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/3424","number":3424,"state":"open","locked":false,"title":"fix(RN): show the CC button only when transcribing is available","user":{"login":"paweldomas","id":2965063,"node_id":"MDQ6VXNlcjI5NjUwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2965063?v=4","gravatar_id":"","url":"https://api.github.com/users/paweldomas","html_url":"https://github.com/paweldomas","followers_url":"https://api.github.com/users/paweldomas/followers","following_url":"https://api.github.com/users/paweldomas/following{/other_user}","gists_url":"https://api.github.com/users/paweldomas/gists{/gist_id}","starred_url":"https://api.github.com/users/paweldomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paweldomas/subscriptions","organizations_url":"https://api.github.com/users/paweldomas/orgs","repos_url":"https://api.github.com/users/paweldomas/repos","events_url":"https://api.github.com/users/paweldomas/events{/privacy}","received_events_url":"https://api.github.com/users/paweldomas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-06T15:14:22Z","updated_at":"2018-09-07T15:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3b836a2e2736be74709f0333f8faec8c1b2feff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"saghul","id":317464,"node_id":"MDQ6VXNlcjMxNzQ2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":692685797,"node_id":"MDU6TGFiZWw2OTI2ODU3OTc=","url":"https://api.github.com/repos/jitsi/jitsi-meet/labels/project:react-native","name":"project:react-native","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/3424/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/dcb98e210ddb86ca9445fe00c43ff9eea1397845","head":{"label":"jitsi:fix_rn_cc_button_visible","ref":"fix_rn_cc_button_visible","sha":"dcb98e210ddb86ca9445fe00c43ff9eea1397845","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNTY3MA==","name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2018-09-06T20:29:17Z","pushed_at":"2018-09-07T14:12:21Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/meet","size":28997,"stargazers_count":2823,"watchers_count":2823,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":975,"mirror_url":null,"archived":false,"open_issues_count":526,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":975,"open_issues":526,"watchers":2823,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"f148b5010061a58da801bbc76aa0e3b01ff4d642","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNTY3MA==","name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2018-09-06T20:29:17Z","pushed_at":"2018-09-07T14:12:21Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/meet","size":28997,"stargazers_count":2823,"watchers_count":2823,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":975,"mirror_url":null,"archived":false,"open_issues_count":526,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":975,"open_issues":526,"watchers":2823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/3424"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/3424"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/3424/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/3424/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/dcb98e210ddb86ca9445fe00c43ff9eea1397845"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"paweldomas"}}