{"action":"created","comment":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/238528973","pull_request_review_id":181089157,"id":238528973,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODUyODk3Mw==","diff_hunk":"@@ -741,12 +741,11 @@ bool jsonrpc_command_add(struct jsonrpc *rpc, struct json_command *command)\n \n void jsonrpc_command_remove(struct jsonrpc *rpc, const char *method)\n {\n-\t// FIXME: Currently leaves NULL entries in the table, if we\n-\t// restart plugins we should shift them out.\n \tfor (size_t i=0; i<tal_count(rpc->commands); i++) {\n \t\tstruct json_command *cmd = rpc->commands[i];\n \t\tif (cmd && streq(cmd->name, method)) {\n-\t\t\trpc->commands[i] = tal_free(cmd);\n+\t\t\ttal_arr_remove(&rpc->commands, i);\n+\t\t\ttal_free(cmd);","path":"lightningd/jsonrpc.c","position":11,"original_position":11,"commit_id":"176254a6d6380e069dd7ae024cfdb8136984e1b2","original_commit_id":"64de0a2e6b5f2b618726c9c0201b14ec0904343a","user":{"login":"rustyrussell","id":775844,"node_id":"MDQ6VXNlcjc3NTg0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/775844?v=4","gravatar_id":"","url":"https://api.github.com/users/rustyrussell","html_url":"https://github.com/rustyrussell","followers_url":"https://api.github.com/users/rustyrussell/followers","following_url":"https://api.github.com/users/rustyrussell/following{/other_user}","gists_url":"https://api.github.com/users/rustyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/rustyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustyrussell/subscriptions","organizations_url":"https://api.github.com/users/rustyrussell/orgs","repos_url":"https://api.github.com/users/rustyrussell/repos","events_url":"https://api.github.com/users/rustyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/rustyrussell/received_events","type":"User","site_admin":false},"body":"Also, I think we can now remove the `if (cmd &&` and similar in find_cmd and jsonrpc_command_add?","created_at":"2018-12-04T04:49:27Z","updated_at":"2018-12-04T04:51:02Z","html_url":"https://github.com/ElementsProject/lightning/pull/2131#discussion_r238528973","pull_request_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/238528973"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/2131#discussion_r238528973"},"pull_request":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131"}},"in_reply_to_id":238528667},"pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131","id":235614851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjE0ODUx","html_url":"https://github.com/ElementsProject/lightning/pull/2131","diff_url":"https://github.com/ElementsProject/lightning/pull/2131.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/2131.patch","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/2131","number":2131,"state":"open","locked":false,"title":"plugin: Some cleanups that didn't make it into part 2 of the plugin saga","user":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"body":" - Changelog entry\r\n - `tal_arr_remove`\r\n - Timeout for `getmanifest` call\r\n - Double free issue when killing a plugin.","created_at":"2018-12-03T22:29:05Z","updated_at":"2018-12-04T04:51:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b307826dac72125d8d8cdcbdca15f28824ed220","assignee":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"assignees":[{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1116907159,"node_id":"MDU6TGFiZWwxMTE2OTA3MTU5","url":"https://api.github.com/repos/ElementsProject/lightning/labels/plugin","name":"plugin","color":"ffefaf","default":false}],"milestone":{"url":"https://api.github.com/repos/ElementsProject/lightning/milestones/5","html_url":"https://github.com/ElementsProject/lightning/milestone/5","labels_url":"https://api.github.com/repos/ElementsProject/lightning/milestones/5/labels","id":3758483,"node_id":"MDk6TWlsZXN0b25lMzc1ODQ4Mw==","number":5,"title":"v0.6.3","description":"","creator":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2018-10-22T19:39:47Z","updated_at":"2018-12-03T22:29:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/2131/comments","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/176254a6d6380e069dd7ae024cfdb8136984e1b2","head":{"label":"cdecker:plugin-4","ref":"plugin-4","sha":"176254a6d6380e069dd7ae024cfdb8136984e1b2","user":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"repo":{"id":62466348,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQ2NjM0OA==","name":"lightning","full_name":"cdecker/lightning","private":false,"owner":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cdecker/lightning","description":"Lightning network","fork":true,"url":"https://api.github.com/repos/cdecker/lightning","forks_url":"https://api.github.com/repos/cdecker/lightning/forks","keys_url":"https://api.github.com/repos/cdecker/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdecker/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdecker/lightning/teams","hooks_url":"https://api.github.com/repos/cdecker/lightning/hooks","issue_events_url":"https://api.github.com/repos/cdecker/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/cdecker/lightning/events","assignees_url":"https://api.github.com/repos/cdecker/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/cdecker/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/cdecker/lightning/tags","blobs_url":"https://api.github.com/repos/cdecker/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdecker/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdecker/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdecker/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdecker/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/cdecker/lightning/languages","stargazers_url":"https://api.github.com/repos/cdecker/lightning/stargazers","contributors_url":"https://api.github.com/repos/cdecker/lightning/contributors","subscribers_url":"https://api.github.com/repos/cdecker/lightning/subscribers","subscription_url":"https://api.github.com/repos/cdecker/lightning/subscription","commits_url":"https://api.github.com/repos/cdecker/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdecker/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdecker/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdecker/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdecker/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/cdecker/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdecker/lightning/merges","archive_url":"https://api.github.com/repos/cdecker/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdecker/lightning/downloads","issues_url":"https://api.github.com/repos/cdecker/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/cdecker/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/cdecker/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/cdecker/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdecker/lightning/labels{/name}","releases_url":"https://api.github.com/repos/cdecker/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/cdecker/lightning/deployments","created_at":"2016-07-02T19:17:14Z","updated_at":"2018-11-26T23:10:08Z","pushed_at":"2018-12-03T22:26:59Z","git_url":"git://github.com/cdecker/lightning.git","ssh_url":"git@github.com:cdecker/lightning.git","clone_url":"https://github.com/cdecker/lightning.git","svn_url":"https://github.com/cdecker/lightning","homepage":null,"size":22450,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"ElementsProject:master","ref":"master","sha":"d7e94a93866c457ed327c8b1b3ef37015a2aed73","user":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37350472,"node_id":"MDEwOlJlcG9zaXRvcnkzNzM1MDQ3Mg==","name":"lightning","full_name":"ElementsProject/lightning","private":false,"owner":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ElementsProject/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":false,"url":"https://api.github.com/repos/ElementsProject/lightning","forks_url":"https://api.github.com/repos/ElementsProject/lightning/forks","keys_url":"https://api.github.com/repos/ElementsProject/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/lightning/teams","hooks_url":"https://api.github.com/repos/ElementsProject/lightning/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/lightning/events","assignees_url":"https://api.github.com/repos/ElementsProject/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/lightning/tags","blobs_url":"https://api.github.com/repos/ElementsProject/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/lightning/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/lightning/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/lightning/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/lightning/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/lightning/subscription","commits_url":"https://api.github.com/repos/ElementsProject/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/lightning/merges","archive_url":"https://api.github.com/repos/ElementsProject/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/lightning/downloads","issues_url":"https://api.github.com/repos/ElementsProject/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/lightning/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/lightning/deployments","created_at":"2015-06-13T00:04:22Z","updated_at":"2018-12-03T20:26:53Z","pushed_at":"2018-12-04T03:34:43Z","git_url":"git://github.com/ElementsProject/lightning.git","ssh_url":"git@github.com:ElementsProject/lightning.git","clone_url":"https://github.com/ElementsProject/lightning.git","svn_url":"https://github.com/ElementsProject/lightning","homepage":"","size":22020,"stargazers_count":1212,"watchers_count":1212,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":344,"open_issues":159,"watchers":1212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/2131"},"issue":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/2131"},"comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/2131/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/2131/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/lightning/statuses/176254a6d6380e069dd7ae024cfdb8136984e1b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rustyrussell"}}