{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/kikito/love-loader/pulls/21","id":175697356,"html_url":"https://github.com/kikito/love-loader/pull/21","diff_url":"https://github.com/kikito/love-loader/pull/21.diff","patch_url":"https://github.com/kikito/love-loader/pull/21.patch","issue_url":"https://api.github.com/repos/kikito/love-loader/issues/21","number":21,"state":"open","locked":false,"title":" Remove reference to thread from loader after completion.","user":{"login":"TannerRogalsky","id":654931,"avatar_url":"https://avatars0.githubusercontent.com/u/654931?v=4","gravatar_id":"","url":"https://api.github.com/users/TannerRogalsky","html_url":"https://github.com/TannerRogalsky","followers_url":"https://api.github.com/users/TannerRogalsky/followers","following_url":"https://api.github.com/users/TannerRogalsky/following{/other_user}","gists_url":"https://api.github.com/users/TannerRogalsky/gists{/gist_id}","starred_url":"https://api.github.com/users/TannerRogalsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TannerRogalsky/subscriptions","organizations_url":"https://api.github.com/users/TannerRogalsky/orgs","repos_url":"https://api.github.com/users/TannerRogalsky/repos","events_url":"https://api.github.com/users/TannerRogalsky/events{/privacy}","received_events_url":"https://api.github.com/users/TannerRogalsky/received_events","type":"User","site_admin":false},"body":"We’ve signalled the loading thread to shut down but it’s possible that we have another update tick before it manages to do so. We’re already checking that `loader.thread` exists so removing the reference to that thread is an effective guard against a slow thread ending.\r\n\r\nIf would be better to remove the condition that creates this race in the first place but this should be an adequate stopgap.\r\n\r\nThis fixes #8.","created_at":"2018-03-17T12:01:57Z","updated_at":"2018-03-17T12:01:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kikito/love-loader/pulls/21/commits","review_comments_url":"https://api.github.com/repos/kikito/love-loader/pulls/21/comments","review_comment_url":"https://api.github.com/repos/kikito/love-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kikito/love-loader/issues/21/comments","statuses_url":"https://api.github.com/repos/kikito/love-loader/statuses/cecc63be1dfd0fade146037f4991f4068c5b5d2b","head":{"label":"kikito:fix_finish_callback_multicall","ref":"fix_finish_callback_multicall","sha":"cecc63be1dfd0fade146037f4991f4068c5b5d2b","user":{"login":"kikito","id":63131,"avatar_url":"https://avatars1.githubusercontent.com/u/63131?v=4","gravatar_id":"","url":"https://api.github.com/users/kikito","html_url":"https://github.com/kikito","followers_url":"https://api.github.com/users/kikito/followers","following_url":"https://api.github.com/users/kikito/following{/other_user}","gists_url":"https://api.github.com/users/kikito/gists{/gist_id}","starred_url":"https://api.github.com/users/kikito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikito/subscriptions","organizations_url":"https://api.github.com/users/kikito/orgs","repos_url":"https://api.github.com/users/kikito/repos","events_url":"https://api.github.com/users/kikito/events{/privacy}","received_events_url":"https://api.github.com/users/kikito/received_events","type":"User","site_admin":false},"repo":{"id":3294425,"name":"love-loader","full_name":"kikito/love-loader","owner":{"login":"kikito","id":63131,"avatar_url":"https://avatars1.githubusercontent.com/u/63131?v=4","gravatar_id":"","url":"https://api.github.com/users/kikito","html_url":"https://github.com/kikito","followers_url":"https://api.github.com/users/kikito/followers","following_url":"https://api.github.com/users/kikito/following{/other_user}","gists_url":"https://api.github.com/users/kikito/gists{/gist_id}","starred_url":"https://api.github.com/users/kikito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikito/subscriptions","organizations_url":"https://api.github.com/users/kikito/orgs","repos_url":"https://api.github.com/users/kikito/repos","events_url":"https://api.github.com/users/kikito/events{/privacy}","received_events_url":"https://api.github.com/users/kikito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kikito/love-loader","description":"Threaded resource loading for LÖVE","fork":false,"url":"https://api.github.com/repos/kikito/love-loader","forks_url":"https://api.github.com/repos/kikito/love-loader/forks","keys_url":"https://api.github.com/repos/kikito/love-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kikito/love-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kikito/love-loader/teams","hooks_url":"https://api.github.com/repos/kikito/love-loader/hooks","issue_events_url":"https://api.github.com/repos/kikito/love-loader/issues/events{/number}","events_url":"https://api.github.com/repos/kikito/love-loader/events","assignees_url":"https://api.github.com/repos/kikito/love-loader/assignees{/user}","branches_url":"https://api.github.com/repos/kikito/love-loader/branches{/branch}","tags_url":"https://api.github.com/repos/kikito/love-loader/tags","blobs_url":"https://api.github.com/repos/kikito/love-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kikito/love-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kikito/love-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/kikito/love-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kikito/love-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/kikito/love-loader/languages","stargazers_url":"https://api.github.com/repos/kikito/love-loader/stargazers","contributors_url":"https://api.github.com/repos/kikito/love-loader/contributors","subscribers_url":"https://api.github.com/repos/kikito/love-loader/subscribers","subscription_url":"https://api.github.com/repos/kikito/love-loader/subscription","commits_url":"https://api.github.com/repos/kikito/love-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/kikito/love-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/kikito/love-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/kikito/love-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/kikito/love-loader/contents/{+path}","compare_url":"https://api.github.com/repos/kikito/love-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kikito/love-loader/merges","archive_url":"https://api.github.com/repos/kikito/love-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kikito/love-loader/downloads","issues_url":"https://api.github.com/repos/kikito/love-loader/issues{/number}","pulls_url":"https://api.github.com/repos/kikito/love-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/kikito/love-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/kikito/love-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kikito/love-loader/labels{/name}","releases_url":"https://api.github.com/repos/kikito/love-loader/releases{/id}","deployments_url":"https://api.github.com/repos/kikito/love-loader/deployments","created_at":"2012-01-29T00:26:13Z","updated_at":"2018-03-16T22:23:20Z","pushed_at":"2018-03-17T12:01:17Z","git_url":"git://github.com/kikito/love-loader.git","ssh_url":"git@github.com:kikito/love-loader.git","clone_url":"https://github.com/kikito/love-loader.git","svn_url":"https://github.com/kikito/love-loader","homepage":"http://love2d.org","size":8778,"stargazers_count":85,"watchers_count":85,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":6,"watchers":85,"default_branch":"master"}},"base":{"label":"kikito:master","ref":"master","sha":"e4f738af0ab1e4193893b2ab2b60a6126792a585","user":{"login":"kikito","id":63131,"avatar_url":"https://avatars1.githubusercontent.com/u/63131?v=4","gravatar_id":"","url":"https://api.github.com/users/kikito","html_url":"https://github.com/kikito","followers_url":"https://api.github.com/users/kikito/followers","following_url":"https://api.github.com/users/kikito/following{/other_user}","gists_url":"https://api.github.com/users/kikito/gists{/gist_id}","starred_url":"https://api.github.com/users/kikito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikito/subscriptions","organizations_url":"https://api.github.com/users/kikito/orgs","repos_url":"https://api.github.com/users/kikito/repos","events_url":"https://api.github.com/users/kikito/events{/privacy}","received_events_url":"https://api.github.com/users/kikito/received_events","type":"User","site_admin":false},"repo":{"id":3294425,"name":"love-loader","full_name":"kikito/love-loader","owner":{"login":"kikito","id":63131,"avatar_url":"https://avatars1.githubusercontent.com/u/63131?v=4","gravatar_id":"","url":"https://api.github.com/users/kikito","html_url":"https://github.com/kikito","followers_url":"https://api.github.com/users/kikito/followers","following_url":"https://api.github.com/users/kikito/following{/other_user}","gists_url":"https://api.github.com/users/kikito/gists{/gist_id}","starred_url":"https://api.github.com/users/kikito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikito/subscriptions","organizations_url":"https://api.github.com/users/kikito/orgs","repos_url":"https://api.github.com/users/kikito/repos","events_url":"https://api.github.com/users/kikito/events{/privacy}","received_events_url":"https://api.github.com/users/kikito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kikito/love-loader","description":"Threaded resource loading for LÖVE","fork":false,"url":"https://api.github.com/repos/kikito/love-loader","forks_url":"https://api.github.com/repos/kikito/love-loader/forks","keys_url":"https://api.github.com/repos/kikito/love-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kikito/love-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kikito/love-loader/teams","hooks_url":"https://api.github.com/repos/kikito/love-loader/hooks","issue_events_url":"https://api.github.com/repos/kikito/love-loader/issues/events{/number}","events_url":"https://api.github.com/repos/kikito/love-loader/events","assignees_url":"https://api.github.com/repos/kikito/love-loader/assignees{/user}","branches_url":"https://api.github.com/repos/kikito/love-loader/branches{/branch}","tags_url":"https://api.github.com/repos/kikito/love-loader/tags","blobs_url":"https://api.github.com/repos/kikito/love-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kikito/love-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kikito/love-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/kikito/love-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kikito/love-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/kikito/love-loader/languages","stargazers_url":"https://api.github.com/repos/kikito/love-loader/stargazers","contributors_url":"https://api.github.com/repos/kikito/love-loader/contributors","subscribers_url":"https://api.github.com/repos/kikito/love-loader/subscribers","subscription_url":"https://api.github.com/repos/kikito/love-loader/subscription","commits_url":"https://api.github.com/repos/kikito/love-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/kikito/love-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/kikito/love-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/kikito/love-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/kikito/love-loader/contents/{+path}","compare_url":"https://api.github.com/repos/kikito/love-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kikito/love-loader/merges","archive_url":"https://api.github.com/repos/kikito/love-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kikito/love-loader/downloads","issues_url":"https://api.github.com/repos/kikito/love-loader/issues{/number}","pulls_url":"https://api.github.com/repos/kikito/love-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/kikito/love-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/kikito/love-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kikito/love-loader/labels{/name}","releases_url":"https://api.github.com/repos/kikito/love-loader/releases{/id}","deployments_url":"https://api.github.com/repos/kikito/love-loader/deployments","created_at":"2012-01-29T00:26:13Z","updated_at":"2018-03-16T22:23:20Z","pushed_at":"2018-03-17T12:01:17Z","git_url":"git://github.com/kikito/love-loader.git","ssh_url":"git@github.com:kikito/love-loader.git","clone_url":"https://github.com/kikito/love-loader.git","svn_url":"https://github.com/kikito/love-loader","homepage":"http://love2d.org","size":8778,"stargazers_count":85,"watchers_count":85,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":6,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kikito/love-loader/pulls/21"},"html":{"href":"https://github.com/kikito/love-loader/pull/21"},"issue":{"href":"https://api.github.com/repos/kikito/love-loader/issues/21"},"comments":{"href":"https://api.github.com/repos/kikito/love-loader/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/kikito/love-loader/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/kikito/love-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kikito/love-loader/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/kikito/love-loader/statuses/cecc63be1dfd0fade146037f4991f4068c5b5d2b"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"TannerRogalsky"}}