{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/172829045","pull_request_review_id":101911315,"id":172829045,"diff_hunk":"@@ -41,15 +41,20 @@ static adxl345_t adxl345_devs[ADXL345_NUM];\n  */\n static saul_reg_t saul_entries[ADXL345_NUM];\n \n+/**\n+ * @brief   Define the number of saul info\n+ */\n+#define ADXL345_INFO_NUM (sizeof(adxl345_saul_info) / sizeof(adxl345_saul_info[0]))\n+\n /**\n  * @brief   Reference the driver structs\n- * @{\n  */\n extern saul_driver_t adxl345_saul_driver;\n-/** @} */\n \n void auto_init_adxl345(void)\n {\n+    assert(ADXL345_INFO_NUM == ADXL345_NUM);","path":"sys/auto_init/saul/auto_init_adxl345.c","position":27,"original_position":27,"commit_id":"5e07118aeddc340cae76e64ab1e34a8bac677679","original_commit_id":"5e07118aeddc340cae76e64ab1e34a8bac677679","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"Not possible (see https://github.com/RIOT-OS/RIOT/pull/8669#discussion_r172821505) so let's rebuild and then go.","created_at":"2018-03-07T12:38:33Z","updated_at":"2018-03-07T12:38:33Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8671#discussion_r172829045","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/172829045"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8671#discussion_r172829045"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671"}},"in_reply_to_id":172799402},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671","id":171986627,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8671","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8671.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8671.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8671","number":8671,"state":"open","locked":false,"title":"drivers/adxl345: apply unified params definition scheme","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nThis PR update the params definitions scheme for the adxl345 device driver.\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n\r\n### Issues/PRs references\r\n\r\nInitially done in #7937 and related to #7519\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2018-02-28T15:29:35Z","updated_at":"2018-03-07T12:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9ae5f0790151c847a1e4780eee331a5aa084136","assignee":{"login":"kYc0o","id":5419775,"avatar_url":"https://avatars1.githubusercontent.com/u/5419775?v=4","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false},"assignees":[{"login":"kYc0o","id":5419775,"avatar_url":"https://avatars1.githubusercontent.com/u/5419775?v=4","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":122032371,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c","default":false},{"id":135467271,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8671/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/5e07118aeddc340cae76e64ab1e34a8bac677679","head":{"label":"aabadie:pr/drivers/params/adxl345","ref":"pr/drivers/params/adxl345","sha":"5e07118aeddc340cae76e64ab1e34a8bac677679","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"repo":{"id":44016379,"name":"RIOT","full_name":"aabadie/RIOT","owner":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aabadie/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/aabadie/RIOT","forks_url":"https://api.github.com/repos/aabadie/RIOT/forks","keys_url":"https://api.github.com/repos/aabadie/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aabadie/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aabadie/RIOT/teams","hooks_url":"https://api.github.com/repos/aabadie/RIOT/hooks","issue_events_url":"https://api.github.com/repos/aabadie/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/aabadie/RIOT/events","assignees_url":"https://api.github.com/repos/aabadie/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/aabadie/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/aabadie/RIOT/tags","blobs_url":"https://api.github.com/repos/aabadie/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aabadie/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aabadie/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/aabadie/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aabadie/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/aabadie/RIOT/languages","stargazers_url":"https://api.github.com/repos/aabadie/RIOT/stargazers","contributors_url":"https://api.github.com/repos/aabadie/RIOT/contributors","subscribers_url":"https://api.github.com/repos/aabadie/RIOT/subscribers","subscription_url":"https://api.github.com/repos/aabadie/RIOT/subscription","commits_url":"https://api.github.com/repos/aabadie/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/aabadie/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/aabadie/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/aabadie/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/aabadie/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/aabadie/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aabadie/RIOT/merges","archive_url":"https://api.github.com/repos/aabadie/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aabadie/RIOT/downloads","issues_url":"https://api.github.com/repos/aabadie/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/aabadie/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/aabadie/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/aabadie/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aabadie/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/aabadie/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/aabadie/RIOT/deployments","created_at":"2015-10-10T15:36:27Z","updated_at":"2016-10-29T18:27:28Z","pushed_at":"2018-03-07T10:10:41Z","git_url":"git://github.com/aabadie/RIOT.git","ssh_url":"git@github.com:aabadie/RIOT.git","clone_url":"https://github.com/aabadie/RIOT.git","svn_url":"https://github.com/aabadie/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":49817,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"8a6bed72bdbd022cbfb1ab3f07d626eb76323d43","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-03-06T02:43:18Z","pushed_at":"2018-03-07T12:17:49Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":49121,"stargazers_count":1667,"watchers_count":1667,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":979,"mirror_url":null,"archived":false,"open_issues_count":725,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":979,"open_issues":725,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8671"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8671"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8671/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8671/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/5e07118aeddc340cae76e64ab1e34a8bac677679"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"miri64"}}