{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/openweave/openweave-core/pulls/24","id":211906454,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTA2NDU0","html_url":"https://github.com/openweave/openweave-core/pull/24","diff_url":"https://github.com/openweave/openweave-core/pull/24.diff","patch_url":"https://github.com/openweave/openweave-core/pull/24.patch","issue_url":"https://api.github.com/repos/openweave/openweave-core/issues/24","number":24,"state":"closed","locked":false,"title":"Further DNS enhancements","user":{"login":"jaylogue","id":636485,"node_id":"MDQ6VXNlcjYzNjQ4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/636485?v=4","gravatar_id":"","url":"https://api.github.com/users/jaylogue","html_url":"https://github.com/jaylogue","followers_url":"https://api.github.com/users/jaylogue/followers","following_url":"https://api.github.com/users/jaylogue/following{/other_user}","gists_url":"https://api.github.com/users/jaylogue/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylogue/subscriptions","organizations_url":"https://api.github.com/users/jaylogue/orgs","repos_url":"https://api.github.com/users/jaylogue/repos","events_url":"https://api.github.com/users/jaylogue/events{/privacy}","received_events_url":"https://api.github.com/users/jaylogue/received_events","type":"User","site_admin":false},"body":"(NOTE: This work is in support of WEAV-3088).\r\n\r\n-- Extended the WeaveConnection::Connect() API to allow DNS options to be specified when establishing a Weave connection using a hostname.\r\n\r\n-- Added support to WeaveBinding for specifying DNS options to be used when resolving the peer address using a hostname.\r\n\r\n-- Added a new callback to the WeaveServiceManager that allows applications to observe and optionally alter the arguments passed to WeaveConnection::Connect() during the course of establishing a service connection.  One of the arguments that can be altered via this callback is the DNS options, giving applications control over name resolution during service connection establishment.\r\n\r\n-- Added command line arguments to weave-ping, mock-device, mock-weave-bg, weave-key-export and weave-service-dir tools to allow the user to override the DNS options used when resolving hostnames during service connection establishment.\r\n\r\n-- Enhanced TestBinding tool to allow testing of DNS options on WeaveBinding.","created_at":"2018-08-29T22:32:56Z","updated_at":"2018-09-04T23:11:42Z","closed_at":"2018-09-04T23:11:41Z","merged_at":"2018-09-04T23:11:41Z","merge_commit_sha":"069b9d6a604e883ddc6b2ad9b25dd4f4db5e0dd1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robszewczyk","id":4296188,"node_id":"MDQ6VXNlcjQyOTYxODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4296188?v=4","gravatar_id":"","url":"https://api.github.com/users/robszewczyk","html_url":"https://github.com/robszewczyk","followers_url":"https://api.github.com/users/robszewczyk/followers","following_url":"https://api.github.com/users/robszewczyk/following{/other_user}","gists_url":"https://api.github.com/users/robszewczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/robszewczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robszewczyk/subscriptions","organizations_url":"https://api.github.com/users/robszewczyk/orgs","repos_url":"https://api.github.com/users/robszewczyk/repos","events_url":"https://api.github.com/users/robszewczyk/events{/privacy}","received_events_url":"https://api.github.com/users/robszewczyk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openweave/openweave-core/pulls/24/commits","review_comments_url":"https://api.github.com/repos/openweave/openweave-core/pulls/24/comments","review_comment_url":"https://api.github.com/repos/openweave/openweave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openweave/openweave-core/issues/24/comments","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/5668c6682c056c8d40aff8b511eeec32dfd9f736","head":{"label":"openweave:feature/jay/further-dns-enhancements","ref":"feature/jay/further-dns-enhancements","sha":"5668c6682c056c8d40aff8b511eeec32dfd9f736","user":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"repo":{"id":101915019,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTUwMTk=","name":"openweave-core","full_name":"openweave/openweave-core","owner":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openweave/openweave-core","description":"openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging. ","fork":false,"url":"https://api.github.com/repos/openweave/openweave-core","forks_url":"https://api.github.com/repos/openweave/openweave-core/forks","keys_url":"https://api.github.com/repos/openweave/openweave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openweave/openweave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openweave/openweave-core/teams","hooks_url":"https://api.github.com/repos/openweave/openweave-core/hooks","issue_events_url":"https://api.github.com/repos/openweave/openweave-core/issues/events{/number}","events_url":"https://api.github.com/repos/openweave/openweave-core/events","assignees_url":"https://api.github.com/repos/openweave/openweave-core/assignees{/user}","branches_url":"https://api.github.com/repos/openweave/openweave-core/branches{/branch}","tags_url":"https://api.github.com/repos/openweave/openweave-core/tags","blobs_url":"https://api.github.com/repos/openweave/openweave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openweave/openweave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openweave/openweave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openweave/openweave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openweave/openweave-core/languages","stargazers_url":"https://api.github.com/repos/openweave/openweave-core/stargazers","contributors_url":"https://api.github.com/repos/openweave/openweave-core/contributors","subscribers_url":"https://api.github.com/repos/openweave/openweave-core/subscribers","subscription_url":"https://api.github.com/repos/openweave/openweave-core/subscription","commits_url":"https://api.github.com/repos/openweave/openweave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openweave/openweave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openweave/openweave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openweave/openweave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openweave/openweave-core/contents/{+path}","compare_url":"https://api.github.com/repos/openweave/openweave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openweave/openweave-core/merges","archive_url":"https://api.github.com/repos/openweave/openweave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openweave/openweave-core/downloads","issues_url":"https://api.github.com/repos/openweave/openweave-core/issues{/number}","pulls_url":"https://api.github.com/repos/openweave/openweave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openweave/openweave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openweave/openweave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openweave/openweave-core/labels{/name}","releases_url":"https://api.github.com/repos/openweave/openweave-core/releases{/id}","deployments_url":"https://api.github.com/repos/openweave/openweave-core/deployments","created_at":"2017-08-30T18:22:10Z","updated_at":"2018-08-30T16:23:14Z","pushed_at":"2018-09-04T23:11:41Z","git_url":"git://github.com/openweave/openweave-core.git","ssh_url":"git@github.com:openweave/openweave-core.git","clone_url":"https://github.com/openweave/openweave-core.git","svn_url":"https://github.com/openweave/openweave-core","homepage":null,"size":44956,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":6,"watchers":78,"default_branch":"master"}},"base":{"label":"openweave:master","ref":"master","sha":"4506eaeacb564f3f872ffb3322750c57cc05dd40","user":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"repo":{"id":101915019,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTUwMTk=","name":"openweave-core","full_name":"openweave/openweave-core","owner":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openweave/openweave-core","description":"openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging. ","fork":false,"url":"https://api.github.com/repos/openweave/openweave-core","forks_url":"https://api.github.com/repos/openweave/openweave-core/forks","keys_url":"https://api.github.com/repos/openweave/openweave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openweave/openweave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openweave/openweave-core/teams","hooks_url":"https://api.github.com/repos/openweave/openweave-core/hooks","issue_events_url":"https://api.github.com/repos/openweave/openweave-core/issues/events{/number}","events_url":"https://api.github.com/repos/openweave/openweave-core/events","assignees_url":"https://api.github.com/repos/openweave/openweave-core/assignees{/user}","branches_url":"https://api.github.com/repos/openweave/openweave-core/branches{/branch}","tags_url":"https://api.github.com/repos/openweave/openweave-core/tags","blobs_url":"https://api.github.com/repos/openweave/openweave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openweave/openweave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openweave/openweave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openweave/openweave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openweave/openweave-core/languages","stargazers_url":"https://api.github.com/repos/openweave/openweave-core/stargazers","contributors_url":"https://api.github.com/repos/openweave/openweave-core/contributors","subscribers_url":"https://api.github.com/repos/openweave/openweave-core/subscribers","subscription_url":"https://api.github.com/repos/openweave/openweave-core/subscription","commits_url":"https://api.github.com/repos/openweave/openweave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openweave/openweave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openweave/openweave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openweave/openweave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openweave/openweave-core/contents/{+path}","compare_url":"https://api.github.com/repos/openweave/openweave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openweave/openweave-core/merges","archive_url":"https://api.github.com/repos/openweave/openweave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openweave/openweave-core/downloads","issues_url":"https://api.github.com/repos/openweave/openweave-core/issues{/number}","pulls_url":"https://api.github.com/repos/openweave/openweave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openweave/openweave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openweave/openweave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openweave/openweave-core/labels{/name}","releases_url":"https://api.github.com/repos/openweave/openweave-core/releases{/id}","deployments_url":"https://api.github.com/repos/openweave/openweave-core/deployments","created_at":"2017-08-30T18:22:10Z","updated_at":"2018-08-30T16:23:14Z","pushed_at":"2018-09-04T23:11:41Z","git_url":"git://github.com/openweave/openweave-core.git","ssh_url":"git@github.com:openweave/openweave-core.git","clone_url":"https://github.com/openweave/openweave-core.git","svn_url":"https://github.com/openweave/openweave-core","homepage":null,"size":44956,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":6,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/24"},"html":{"href":"https://github.com/openweave/openweave-core/pull/24"},"issue":{"href":"https://api.github.com/repos/openweave/openweave-core/issues/24"},"comments":{"href":"https://api.github.com/repos/openweave/openweave-core/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/openweave/openweave-core/statuses/5668c6682c056c8d40aff8b511eeec32dfd9f736"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jaylogue","id":636485,"node_id":"MDQ6VXNlcjYzNjQ4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/636485?v=4","gravatar_id":"","url":"https://api.github.com/users/jaylogue","html_url":"https://github.com/jaylogue","followers_url":"https://api.github.com/users/jaylogue/followers","following_url":"https://api.github.com/users/jaylogue/following{/other_user}","gists_url":"https://api.github.com/users/jaylogue/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylogue/subscriptions","organizations_url":"https://api.github.com/users/jaylogue/orgs","repos_url":"https://api.github.com/users/jaylogue/repos","events_url":"https://api.github.com/users/jaylogue/events{/privacy}","received_events_url":"https://api.github.com/users/jaylogue/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":445,"deletions":59,"changed_files":15}}
{"actor":{"display_login":"jaylogue"}}