{"action":"created","issue":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/481","repository_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/481/labels{/name}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/481/comments","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/481/events","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/481","id":334728748,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjI2NjQz","number":481,"title":"hv mmu & ept revisit","user":{"login":"lifeix","id":36348136,"node_id":"MDQ6VXNlcjM2MzQ4MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36348136?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeix","html_url":"https://github.com/lifeix","followers_url":"https://api.github.com/users/lifeix/followers","following_url":"https://api.github.com/users/lifeix/following{/other_user}","gists_url":"https://api.github.com/users/lifeix/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeix/subscriptions","organizations_url":"https://api.github.com/users/lifeix/orgs","repos_url":"https://api.github.com/users/lifeix/repos","events_url":"https://api.github.com/users/lifeix/events{/privacy}","received_events_url":"https://api.github.com/users/lifeix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-22T03:04:18Z","updated_at":"2018-06-22T03:05:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/481","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/481","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/481.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/481.patch"},"body":"v1-v2:\r\n1. minor fix when mask EPT cache type.\r\n\r\nv1:\r\nNow the hv mmu & ept map/unmap/modify logic is not clear. Map may map\r\nmapped page tables; unmap may unmap non-mapped or unmapped page tables;\r\nmodify may modify gfn to mfn mapping besides page table attributes or\r\nmodify non-mapped page table.\r\nWe want to change this. Let's set some rules first:\r\n1. map can only map unmapped page tables\r\n2. unmap can only unmap mapped page tables;\r\n3. modify can only modify mapped page tables' attributes.\r\n\r\nBesides, we want to move configure page table attributes outsides internal\r\nimplement logic.\r\n\r\nThis patch is the serial one.\r\nAfter this serial, we can achieve:\r\n1. We would not unmap unmap non-mapped or unmapped page tables;\r\n2. set page tables attributes at frist before call internal implement function.\r\n\r\nNext will\r\n1. remove cma support in the dm & sos vhm\r\n2. remove MAP_MMIO in sos vhm then remove MAP_MMIO in hv\r\n3. add MAP_MODIFY in hv then add MAP_MODIFY in sos vhm\r\n4. apply rules list above in hv\r\n"},"comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments/399306797","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/481#issuecomment-399306797","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/481","id":399306797,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTMwNjc5Nw==","user":{"login":"NanlinXie","id":37297158,"node_id":"MDQ6VXNlcjM3Mjk3MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/37297158?v=4","gravatar_id":"","url":"https://api.github.com/users/NanlinXie","html_url":"https://github.com/NanlinXie","followers_url":"https://api.github.com/users/NanlinXie/followers","following_url":"https://api.github.com/users/NanlinXie/following{/other_user}","gists_url":"https://api.github.com/users/NanlinXie/gists{/gist_id}","starred_url":"https://api.github.com/users/NanlinXie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanlinXie/subscriptions","organizations_url":"https://api.github.com/users/NanlinXie/orgs","repos_url":"https://api.github.com/users/NanlinXie/repos","events_url":"https://api.github.com/users/NanlinXie/events{/privacy}","received_events_url":"https://api.github.com/users/NanlinXie/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T03:05:24Z","updated_at":"2018-06-22T03:05:24Z","author_association":"NONE","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"NanlinXie"}}