{"action":"created","issue":{"url":"https://api.github.com/repos/scionproto/scion/issues/1618","repository_url":"https://api.github.com/repos/scionproto/scion","labels_url":"https://api.github.com/repos/scionproto/scion/issues/1618/labels{/name}","comments_url":"https://api.github.com/repos/scionproto/scion/issues/1618/comments","events_url":"https://api.github.com/repos/scionproto/scion/issues/1618/events","html_url":"https://github.com/scionproto/scion/pull/1618","id":333948483,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDM5Nzg1","number":1618,"title":"Make protos consistent between go and python","user":{"login":"worxli","id":2504856,"node_id":"MDQ6VXNlcjI1MDQ4NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2504856?v=4","gravatar_id":"","url":"https://api.github.com/users/worxli","html_url":"https://github.com/worxli","followers_url":"https://api.github.com/users/worxli/followers","following_url":"https://api.github.com/users/worxli/following{/other_user}","gists_url":"https://api.github.com/users/worxli/gists{/gist_id}","starred_url":"https://api.github.com/users/worxli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worxli/subscriptions","organizations_url":"https://api.github.com/users/worxli/orgs","repos_url":"https://api.github.com/users/worxli/repos","events_url":"https://api.github.com/users/worxli/events{/privacy}","received_events_url":"https://api.github.com/users/worxli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-20T07:03:54Z","updated_at":"2018-06-26T12:11:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scionproto/scion/pulls/1618","html_url":"https://github.com/scionproto/scion/pull/1618","diff_url":"https://github.com/scionproto/scion/pull/1618.diff","patch_url":"https://github.com/scionproto/scion/pull/1618.patch"},"body":"Make proto signature equal in go and python\r\n\r\n- Add timestamp to sign in python\r\n- Add non-signature fields into signature in go\r\n- Make signature fields order consistent\r\n- Fix ASEntry sign method in python\r\n\r\nFixes #1524. Fixes #1617.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scionproto/scion/1618)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/scionproto/scion/issues/comments/400284709","html_url":"https://github.com/scionproto/scion/pull/1618#issuecomment-400284709","issue_url":"https://api.github.com/repos/scionproto/scion/issues/1618","id":400284709,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDI4NDcwOQ==","user":{"login":"kormat","id":6919822,"node_id":"MDQ6VXNlcjY5MTk4MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6919822?v=4","gravatar_id":"","url":"https://api.github.com/users/kormat","html_url":"https://github.com/kormat","followers_url":"https://api.github.com/users/kormat/followers","following_url":"https://api.github.com/users/kormat/following{/other_user}","gists_url":"https://api.github.com/users/kormat/gists{/gist_id}","starred_url":"https://api.github.com/users/kormat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kormat/subscriptions","organizations_url":"https://api.github.com/users/kormat/orgs","repos_url":"https://api.github.com/users/kormat/repos","events_url":"https://api.github.com/users/kormat/events{/privacy}","received_events_url":"https://api.github.com/users/kormat/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T12:11:48Z","updated_at":"2018-06-26T12:11:48Z","author_association":"CONTRIBUTOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 4 of 4 files at r2.\nReview status: :shipit: complete! all files reviewed, all discussions resolved\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/scionproto/scion/1618#-:-LFw-R-dEjEynNJ8y2Zv:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kormat"}}