{"action":"created","comment":{"url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/comments/166330595","pull_request_review_id":94372227,"id":166330595,"diff_hunk":"@@ -180,6 +184,20 @@ class SquadUserAdmin(UserAdmin):\n     filter_horizontal = ('user_permissions', 'groups',)\n \n \n+class ConfigurationSettingsAdmin(admin.ModelAdmin):","path":"onboarding_project/squad_pantry_app/admin.py","position":24,"original_position":24,"commit_id":"a16173b89f3c5cede9af73ba19f3019242b19b00","original_commit_id":"a16173b89f3c5cede9af73ba19f3019242b19b00","user":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"body":"This is not what we discussed. We had two ideas:\r\n\r\n1. Have a `Settings` model like this:\r\n```py\r\nclass Settings(models.model):\r\n    order_limit = model.IntegerField()\r\n    another_setting = model.CharField()\r\n    ....\r\n    <other_settings>\r\n```\r\nAnd create a single instance of the above model and do not let any one add more records. If you want add another setting, you add a new field to this model and migrate.\r\n\r\n2. Have a configurable model:\r\n```py\r\nclass ConfigurationSettings(models.model)\r\n     key = models.CharField()\r\n     value = models.CharField()\r\n```\r\n\r\nAnd create a `limit` = `<num>` key value pair. In this case, the admin must be able to add new records. How else would you be able to specify a new setting?\r\n\r\nWhat you have done is a mixture of method 1 and 2.","created_at":"2018-02-06T15:03:35Z","updated_at":"2018-02-06T15:10:09Z","html_url":"https://github.com/lonesword/squad-pantry/pull/3#discussion_r166330595","pull_request_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/comments/166330595"},"html":{"href":"https://github.com/lonesword/squad-pantry/pull/3#discussion_r166330595"},"pull_request":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3","id":167419053,"html_url":"https://github.com/lonesword/squad-pantry/pull/3","diff_url":"https://github.com/lonesword/squad-pantry/pull/3.diff","patch_url":"https://github.com/lonesword/squad-pantry/pull/3.patch","issue_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/3","number":3,"state":"open","locked":false,"title":"As a squad-pantry, I'll be able to set limit to incoming orders","user":{"login":"prakhar96","id":13600114,"avatar_url":"https://avatars0.githubusercontent.com/u/13600114?v=4","gravatar_id":"","url":"https://api.github.com/users/prakhar96","html_url":"https://github.com/prakhar96","followers_url":"https://api.github.com/users/prakhar96/followers","following_url":"https://api.github.com/users/prakhar96/following{/other_user}","gists_url":"https://api.github.com/users/prakhar96/gists{/gist_id}","starred_url":"https://api.github.com/users/prakhar96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakhar96/subscriptions","organizations_url":"https://api.github.com/users/prakhar96/orgs","repos_url":"https://api.github.com/users/prakhar96/repos","events_url":"https://api.github.com/users/prakhar96/events{/privacy}","received_events_url":"https://api.github.com/users/prakhar96/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T13:50:58Z","updated_at":"2018-02-06T15:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06128a707fbaac7a4dd04891cc7cb83c6d6f9497","assignee":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"assignees":[{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3/commits","review_comments_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3/comments","review_comment_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/3/comments","statuses_url":"https://api.github.com/repos/lonesword/squad-pantry/statuses/a16173b89f3c5cede9af73ba19f3019242b19b00","head":{"label":"lonesword:kx4e","ref":"kx4e","sha":"a16173b89f3c5cede9af73ba19f3019242b19b00","user":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"repo":{"id":119834657,"name":"squad-pantry","full_name":"lonesword/squad-pantry","owner":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lonesword/squad-pantry","description":"Order food from the Squad kitchenette","fork":false,"url":"https://api.github.com/repos/lonesword/squad-pantry","forks_url":"https://api.github.com/repos/lonesword/squad-pantry/forks","keys_url":"https://api.github.com/repos/lonesword/squad-pantry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonesword/squad-pantry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonesword/squad-pantry/teams","hooks_url":"https://api.github.com/repos/lonesword/squad-pantry/hooks","issue_events_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/events{/number}","events_url":"https://api.github.com/repos/lonesword/squad-pantry/events","assignees_url":"https://api.github.com/repos/lonesword/squad-pantry/assignees{/user}","branches_url":"https://api.github.com/repos/lonesword/squad-pantry/branches{/branch}","tags_url":"https://api.github.com/repos/lonesword/squad-pantry/tags","blobs_url":"https://api.github.com/repos/lonesword/squad-pantry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonesword/squad-pantry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonesword/squad-pantry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonesword/squad-pantry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonesword/squad-pantry/statuses/{sha}","languages_url":"https://api.github.com/repos/lonesword/squad-pantry/languages","stargazers_url":"https://api.github.com/repos/lonesword/squad-pantry/stargazers","contributors_url":"https://api.github.com/repos/lonesword/squad-pantry/contributors","subscribers_url":"https://api.github.com/repos/lonesword/squad-pantry/subscribers","subscription_url":"https://api.github.com/repos/lonesword/squad-pantry/subscription","commits_url":"https://api.github.com/repos/lonesword/squad-pantry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonesword/squad-pantry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonesword/squad-pantry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lonesword/squad-pantry/contents/{+path}","compare_url":"https://api.github.com/repos/lonesword/squad-pantry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonesword/squad-pantry/merges","archive_url":"https://api.github.com/repos/lonesword/squad-pantry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonesword/squad-pantry/downloads","issues_url":"https://api.github.com/repos/lonesword/squad-pantry/issues{/number}","pulls_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls{/number}","milestones_url":"https://api.github.com/repos/lonesword/squad-pantry/milestones{/number}","notifications_url":"https://api.github.com/repos/lonesword/squad-pantry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonesword/squad-pantry/labels{/name}","releases_url":"https://api.github.com/repos/lonesword/squad-pantry/releases{/id}","deployments_url":"https://api.github.com/repos/lonesword/squad-pantry/deployments","created_at":"2018-02-01T12:45:36Z","updated_at":"2018-02-03T10:41:18Z","pushed_at":"2018-02-06T14:42:47Z","git_url":"git://github.com/lonesword/squad-pantry.git","ssh_url":"git@github.com:lonesword/squad-pantry.git","clone_url":"https://github.com/lonesword/squad-pantry.git","svn_url":"https://github.com/lonesword/squad-pantry","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lonesword:master","ref":"master","sha":"93447fd17a5184443a404ec493494a30b624b683","user":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"repo":{"id":119834657,"name":"squad-pantry","full_name":"lonesword/squad-pantry","owner":{"login":"lonesword","id":5657225,"avatar_url":"https://avatars2.githubusercontent.com/u/5657225?v=4","gravatar_id":"","url":"https://api.github.com/users/lonesword","html_url":"https://github.com/lonesword","followers_url":"https://api.github.com/users/lonesword/followers","following_url":"https://api.github.com/users/lonesword/following{/other_user}","gists_url":"https://api.github.com/users/lonesword/gists{/gist_id}","starred_url":"https://api.github.com/users/lonesword/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonesword/subscriptions","organizations_url":"https://api.github.com/users/lonesword/orgs","repos_url":"https://api.github.com/users/lonesword/repos","events_url":"https://api.github.com/users/lonesword/events{/privacy}","received_events_url":"https://api.github.com/users/lonesword/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lonesword/squad-pantry","description":"Order food from the Squad kitchenette","fork":false,"url":"https://api.github.com/repos/lonesword/squad-pantry","forks_url":"https://api.github.com/repos/lonesword/squad-pantry/forks","keys_url":"https://api.github.com/repos/lonesword/squad-pantry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonesword/squad-pantry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonesword/squad-pantry/teams","hooks_url":"https://api.github.com/repos/lonesword/squad-pantry/hooks","issue_events_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/events{/number}","events_url":"https://api.github.com/repos/lonesword/squad-pantry/events","assignees_url":"https://api.github.com/repos/lonesword/squad-pantry/assignees{/user}","branches_url":"https://api.github.com/repos/lonesword/squad-pantry/branches{/branch}","tags_url":"https://api.github.com/repos/lonesword/squad-pantry/tags","blobs_url":"https://api.github.com/repos/lonesword/squad-pantry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonesword/squad-pantry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonesword/squad-pantry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonesword/squad-pantry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonesword/squad-pantry/statuses/{sha}","languages_url":"https://api.github.com/repos/lonesword/squad-pantry/languages","stargazers_url":"https://api.github.com/repos/lonesword/squad-pantry/stargazers","contributors_url":"https://api.github.com/repos/lonesword/squad-pantry/contributors","subscribers_url":"https://api.github.com/repos/lonesword/squad-pantry/subscribers","subscription_url":"https://api.github.com/repos/lonesword/squad-pantry/subscription","commits_url":"https://api.github.com/repos/lonesword/squad-pantry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonesword/squad-pantry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonesword/squad-pantry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonesword/squad-pantry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lonesword/squad-pantry/contents/{+path}","compare_url":"https://api.github.com/repos/lonesword/squad-pantry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonesword/squad-pantry/merges","archive_url":"https://api.github.com/repos/lonesword/squad-pantry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonesword/squad-pantry/downloads","issues_url":"https://api.github.com/repos/lonesword/squad-pantry/issues{/number}","pulls_url":"https://api.github.com/repos/lonesword/squad-pantry/pulls{/number}","milestones_url":"https://api.github.com/repos/lonesword/squad-pantry/milestones{/number}","notifications_url":"https://api.github.com/repos/lonesword/squad-pantry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonesword/squad-pantry/labels{/name}","releases_url":"https://api.github.com/repos/lonesword/squad-pantry/releases{/id}","deployments_url":"https://api.github.com/repos/lonesword/squad-pantry/deployments","created_at":"2018-02-01T12:45:36Z","updated_at":"2018-02-03T10:41:18Z","pushed_at":"2018-02-06T14:42:47Z","git_url":"git://github.com/lonesword/squad-pantry.git","ssh_url":"git@github.com:lonesword/squad-pantry.git","clone_url":"https://github.com/lonesword/squad-pantry.git","svn_url":"https://github.com/lonesword/squad-pantry","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3"},"html":{"href":"https://github.com/lonesword/squad-pantry/pull/3"},"issue":{"href":"https://api.github.com/repos/lonesword/squad-pantry/issues/3"},"comments":{"href":"https://api.github.com/repos/lonesword/squad-pantry/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lonesword/squad-pantry/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/lonesword/squad-pantry/statuses/a16173b89f3c5cede9af73ba19f3019242b19b00"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lonesword"}}