{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/104","repository_url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/104/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/104/events","html_url":"https://github.com/rust-lang-nursery/rustc-guide/issues/104","id":309112067,"number":104,"title":"More information on attributes","user":{"login":"phansch","id":2042399,"avatar_url":"https://avatars3.githubusercontent.com/u/2042399?v=4","gravatar_id":"","url":"https://api.github.com/users/phansch","html_url":"https://github.com/phansch","followers_url":"https://api.github.com/users/phansch/followers","following_url":"https://api.github.com/users/phansch/following{/other_user}","gists_url":"https://api.github.com/users/phansch/gists{/gist_id}","starred_url":"https://api.github.com/users/phansch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansch/subscriptions","organizations_url":"https://api.github.com/users/phansch/orgs","repos_url":"https://api.github.com/users/phansch/repos","events_url":"https://api.github.com/users/phansch/events{/privacy}","received_events_url":"https://api.github.com/users/phansch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-27T19:59:21Z","updated_at":"2018-03-28T20:39:18Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I recently wrote a clippy lint that deals with attributes (mostly outer attributes) and found very little information on how they are implemented. Most of the information I gathered through PR comments and issues in the rust repo. The [reference](https://doc.rust-lang.org/reference/attributes.html) only explains how to use the different attributes.\r\n\r\nDo you think it would make sense to have a chapter on attributes in the guide?\r\n\r\nSome weird things and questions I came across:\r\n- The AST seems to contain attributes that are not in the actual source code (Is this because of macro expansion?) (https://github.com/rust-lang-nursery/rust-clippy/pull/2340#issuecomment-361055252)\r\n- some expanded attributes seem to have an empty TokenStream and some not\r\n- cfg_attr is special somehow\r\n- In general lots of inconsistencies in the data from the syntax crate? \r\n\r\nI would be happy to start something myself, but would need some pointers as to where the attribute stuff happens."},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/comments/377028341","html_url":"https://github.com/rust-lang-nursery/rustc-guide/issues/104#issuecomment-377028341","issue_url":"https://api.github.com/repos/rust-lang-nursery/rustc-guide/issues/104","id":377028341,"user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars1.githubusercontent.com/u/679122?v=4","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T20:39:18Z","updated_at":"2018-03-28T20:39:18Z","author_association":"NONE","body":"There will be discussion about that on friday @ all hands.\r\n\r\ncc @matklad I hear you organise discussion for that?"}}
{"actor":{"display_login":"nagisa"}}