{"action":"created","issue":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/2","repository_url":"https://api.github.com/repos/KevinOConnor/klipper","labels_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/2/comments","events_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/2/events","html_url":"https://github.com/KevinOConnor/klipper/issues/2","id":222041338,"number":2,"title":"Physical UI support?","user":{"login":"mhv-shared","id":20760370,"avatar_url":"https://avatars1.githubusercontent.com/u/20760370?v=4","gravatar_id":"","url":"https://api.github.com/users/mhv-shared","html_url":"https://github.com/mhv-shared","followers_url":"https://api.github.com/users/mhv-shared/followers","following_url":"https://api.github.com/users/mhv-shared/following{/other_user}","gists_url":"https://api.github.com/users/mhv-shared/gists{/gist_id}","starred_url":"https://api.github.com/users/mhv-shared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhv-shared/subscriptions","organizations_url":"https://api.github.com/users/mhv-shared/orgs","repos_url":"https://api.github.com/users/mhv-shared/repos","events_url":"https://api.github.com/users/mhv-shared/events{/privacy}","received_events_url":"https://api.github.com/users/mhv-shared/received_events","type":"User","site_admin":false},"labels":[{"id":382382583,"url":"https://api.github.com/repos/KevinOConnor/klipper/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":117,"created_at":"2017-04-16T23:54:13Z","updated_at":"2018-02-09T20:05:46Z","closed_at":null,"author_association":"NONE","body":"Do you plan to add support for LCD + encoder? Or will control always be done through octoprint?"},"comment":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/comments/364549018","html_url":"https://github.com/KevinOConnor/klipper/issues/2#issuecomment-364549018","issue_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/2","id":364549018,"user":{"login":"KevinOConnor","id":3004890,"avatar_url":"https://avatars3.githubusercontent.com/u/3004890?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinOConnor","html_url":"https://github.com/KevinOConnor","followers_url":"https://api.github.com/users/KevinOConnor/followers","following_url":"https://api.github.com/users/KevinOConnor/following{/other_user}","gists_url":"https://api.github.com/users/KevinOConnor/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinOConnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinOConnor/subscriptions","organizations_url":"https://api.github.com/users/KevinOConnor/orgs","repos_url":"https://api.github.com/users/KevinOConnor/repos","events_url":"https://api.github.com/users/KevinOConnor/events{/privacy}","received_events_url":"https://api.github.com/users/KevinOConnor/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T20:05:46Z","updated_at":"2018-02-09T20:05:46Z","author_association":"OWNER","body":"@TunaLatte - Great!  Was this with my merged code on branch work-lcd-20180115?\r\n\r\n> small question but could rather have large answer: How does this affect max step rate on avr platforms? I will run tests anyways but its nice to hear an input to avoid missing out extra things when testing. Repetier firmware stutters on high facets gcode when using rotary encoder for example. I would worry if the encoder uses and affects interrupts significantly.\r\n\r\nI don't think it will significantly impact performance.  The lcd code doesn't disable interrupts at all, and the button detection code only has a very small amount of code that runs with interrupts disabled.  It could slow command processing (queuing of moves), but it's not difficult to prioritize regular commands over lcd commands so that doesn't seem like an issue either.  Only testing will tell though."}}
{"actor":{"display_login":"KevinOConnor"}}