{"action":"created","comment":{"url":"https://api.github.com/repos/mui-org/material-ui/pulls/comments/210330961","pull_request_review_id":146522854,"id":210330961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDMzMDk2MQ==","diff_hunk":"@@ -0,0 +1,41 @@\n+import warning from 'warning';\n+import getDisplayName from 'recompose/getDisplayName';\n+\n+function mergeClasses(options = {}) {\n+  const { baseClasses, newClasses, Component, noBase = false } = options;\n+\n+  if (!newClasses) {\n+    return baseClasses;\n+  }\n+\n+  return {\n+    ...baseClasses,\n+    ...Object.keys(newClasses).reduce((accumulator, key) => {\n+      warning(\n+        baseClasses[key] || noBase,\n+        [\n+          `Material-UI: the key \\`${key}\\` ` +\n+            `provided to the classes property is not implemented in ${getDisplayName(Component)}.`,\n+          `You can only override one of the following: ${Object.keys(baseClasses).join(',')}`,\n+        ].join('\\n'),\n+      );\n+\n+      warning(\n+        !newClasses[key] || typeof newClasses[key] === 'string',\n+        [\n+          `Material-UI: the key \\`${key}\\` ` +\n+            `provided to the classes property is not valid for ${getDisplayName(Component)}.`,\n+          `You need to provide a non empty string instead of: ${newClasses[key]}.`,","path":"packages/material-ui/src/styles/mergeClasses.js","position":28,"original_position":28,"commit_id":"884068a5bedd299838ad29b6448f24289e61013f","original_commit_id":"884068a5bedd299838ad29b6448f24289e61013f","user":{"login":"nicosommi","id":1702755,"node_id":"MDQ6VXNlcjE3MDI3NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1702755?v=4","gravatar_id":"","url":"https://api.github.com/users/nicosommi","html_url":"https://github.com/nicosommi","followers_url":"https://api.github.com/users/nicosommi/followers","following_url":"https://api.github.com/users/nicosommi/following{/other_user}","gists_url":"https://api.github.com/users/nicosommi/gists{/gist_id}","starred_url":"https://api.github.com/users/nicosommi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicosommi/subscriptions","organizations_url":"https://api.github.com/users/nicosommi/orgs","repos_url":"https://api.github.com/users/nicosommi/repos","events_url":"https://api.github.com/users/nicosommi/events{/privacy}","received_events_url":"https://api.github.com/users/nicosommi/received_events","type":"User","site_admin":false},"body":"> What does it mean?\r\n\r\nThat it is using [this](https://reactjs.org/docs/legacy-context.html) instead of [this](https://reactjs.org/docs/context.html)\r\n\r\nIn practical terms the new theme is used in a declarative way by rendering a consumer and using the children on the default render prop.\r\n\r\nSo my component wrapper looks like this:\r\n```\r\n      <ThemeProvider.Consumer>\r\n        {theme => {\r\n          return (\r\n            <List classes={processStyleObjects(classes, theme)}>\r\n              {this.props.children}\r\n            </List>\r\n          )\r\n        }}\r\n      </ThemeProvider.Consumer>\r\n```\r\n\r\nInstead of creating the HOC.","created_at":"2018-08-15T16:42:56Z","updated_at":"2018-08-15T16:42:56Z","html_url":"https://github.com/mui-org/material-ui/pull/11904#discussion_r210330961","pull_request_url":"https://api.github.com/repos/mui-org/material-ui/pulls/11904","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/comments/210330961"},"html":{"href":"https://github.com/mui-org/material-ui/pull/11904#discussion_r210330961"},"pull_request":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/11904"}},"in_reply_to_id":209617569},"pull_request":{"url":"https://api.github.com/repos/mui-org/material-ui/pulls/11904","id":195644163,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjQ0MTYz","html_url":"https://github.com/mui-org/material-ui/pull/11904","diff_url":"https://github.com/mui-org/material-ui/pull/11904.diff","patch_url":"https://github.com/mui-org/material-ui/pull/11904.patch","issue_url":"https://api.github.com/repos/mui-org/material-ui/issues/11904","number":11904,"state":"closed","locked":false,"title":"[Select] Fix classes merge issue","user":{"login":"C-Rodg","id":8096996,"node_id":"MDQ6VXNlcjgwOTY5OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8096996?v=4","gravatar_id":"","url":"https://api.github.com/users/C-Rodg","html_url":"https://github.com/C-Rodg","followers_url":"https://api.github.com/users/C-Rodg/followers","following_url":"https://api.github.com/users/C-Rodg/following{/other_user}","gists_url":"https://api.github.com/users/C-Rodg/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Rodg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Rodg/subscriptions","organizations_url":"https://api.github.com/users/C-Rodg/orgs","repos_url":"https://api.github.com/users/C-Rodg/repos","events_url":"https://api.github.com/users/C-Rodg/events{/privacy}","received_events_url":"https://api.github.com/users/C-Rodg/received_events","type":"User","site_admin":false},"body":"Hey,\r\nI have added children and classes to the inputProps for the Select component, which prevents the removal of default styling mentioned in #11867.\r\n\r\nThanks!\r\n\r\nCloses #11867","created_at":"2018-06-18T20:49:01Z","updated_at":"2018-08-15T16:42:56Z","closed_at":"2018-06-19T22:32:23Z","merged_at":"2018-06-19T22:32:23Z","merge_commit_sha":"30ede7cdfa173317467307c7e97ba7697008cd0e","assignee":{"login":"oliviertassinari","id":3165635,"node_id":"MDQ6VXNlcjMxNjU2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3165635?v=4","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"assignees":[{"login":"oliviertassinari","id":3165635,"node_id":"MDQ6VXNlcjMxNjU2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3165635?v=4","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":122764862,"node_id":"MDU6TGFiZWwxMjI3NjQ4NjI=","url":"https://api.github.com/repos/mui-org/material-ui/labels/bug","name":"bug","color":"e11d21","default":true},{"id":460200815,"node_id":"MDU6TGFiZWw0NjAyMDA4MTU=","url":"https://api.github.com/repos/mui-org/material-ui/labels/component:%20Select","name":"component: Select","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mui-org/material-ui/pulls/11904/commits","review_comments_url":"https://api.github.com/repos/mui-org/material-ui/pulls/11904/comments","review_comment_url":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/11904/comments","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/884068a5bedd299838ad29b6448f24289e61013f","head":{"label":"C-Rodg:select-merge-classes","ref":"select-merge-classes","sha":"884068a5bedd299838ad29b6448f24289e61013f","user":{"login":"C-Rodg","id":8096996,"node_id":"MDQ6VXNlcjgwOTY5OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8096996?v=4","gravatar_id":"","url":"https://api.github.com/users/C-Rodg","html_url":"https://github.com/C-Rodg","followers_url":"https://api.github.com/users/C-Rodg/followers","following_url":"https://api.github.com/users/C-Rodg/following{/other_user}","gists_url":"https://api.github.com/users/C-Rodg/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Rodg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Rodg/subscriptions","organizations_url":"https://api.github.com/users/C-Rodg/orgs","repos_url":"https://api.github.com/users/C-Rodg/repos","events_url":"https://api.github.com/users/C-Rodg/events{/privacy}","received_events_url":"https://api.github.com/users/C-Rodg/received_events","type":"User","site_admin":false},"repo":{"id":132788240,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODgyNDA=","name":"material-ui","full_name":"C-Rodg/material-ui","owner":{"login":"C-Rodg","id":8096996,"node_id":"MDQ6VXNlcjgwOTY5OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8096996?v=4","gravatar_id":"","url":"https://api.github.com/users/C-Rodg","html_url":"https://github.com/C-Rodg","followers_url":"https://api.github.com/users/C-Rodg/followers","following_url":"https://api.github.com/users/C-Rodg/following{/other_user}","gists_url":"https://api.github.com/users/C-Rodg/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Rodg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Rodg/subscriptions","organizations_url":"https://api.github.com/users/C-Rodg/orgs","repos_url":"https://api.github.com/users/C-Rodg/repos","events_url":"https://api.github.com/users/C-Rodg/events{/privacy}","received_events_url":"https://api.github.com/users/C-Rodg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/C-Rodg/material-ui","description":"React components that implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/C-Rodg/material-ui","forks_url":"https://api.github.com/repos/C-Rodg/material-ui/forks","keys_url":"https://api.github.com/repos/C-Rodg/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C-Rodg/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C-Rodg/material-ui/teams","hooks_url":"https://api.github.com/repos/C-Rodg/material-ui/hooks","issue_events_url":"https://api.github.com/repos/C-Rodg/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/C-Rodg/material-ui/events","assignees_url":"https://api.github.com/repos/C-Rodg/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/C-Rodg/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/C-Rodg/material-ui/tags","blobs_url":"https://api.github.com/repos/C-Rodg/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C-Rodg/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C-Rodg/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/C-Rodg/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C-Rodg/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/C-Rodg/material-ui/languages","stargazers_url":"https://api.github.com/repos/C-Rodg/material-ui/stargazers","contributors_url":"https://api.github.com/repos/C-Rodg/material-ui/contributors","subscribers_url":"https://api.github.com/repos/C-Rodg/material-ui/subscribers","subscription_url":"https://api.github.com/repos/C-Rodg/material-ui/subscription","commits_url":"https://api.github.com/repos/C-Rodg/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/C-Rodg/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/C-Rodg/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/C-Rodg/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/C-Rodg/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/C-Rodg/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C-Rodg/material-ui/merges","archive_url":"https://api.github.com/repos/C-Rodg/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C-Rodg/material-ui/downloads","issues_url":"https://api.github.com/repos/C-Rodg/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/C-Rodg/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/C-Rodg/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/C-Rodg/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C-Rodg/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/C-Rodg/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/C-Rodg/material-ui/deployments","created_at":"2018-05-09T17:03:01Z","updated_at":"2018-06-28T15:43:18Z","pushed_at":"2018-06-28T18:47:14Z","git_url":"git://github.com/C-Rodg/material-ui.git","ssh_url":"git@github.com:C-Rodg/material-ui.git","clone_url":"https://github.com/C-Rodg/material-ui.git","svn_url":"https://github.com/C-Rodg/material-ui","homepage":"http://www.material-ui.com","size":43373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1-beta"}},"base":{"label":"mui-org:master","ref":"master","sha":"f14d6d09cba644a219bad80840cb0bfed6e1ae38","user":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA4MzE1Ng==","name":"material-ui","full_name":"mui-org/material-ui","owner":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mui-org/material-ui","description":"React components that implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/mui-org/material-ui","forks_url":"https://api.github.com/repos/mui-org/material-ui/forks","keys_url":"https://api.github.com/repos/mui-org/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mui-org/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mui-org/material-ui/teams","hooks_url":"https://api.github.com/repos/mui-org/material-ui/hooks","issue_events_url":"https://api.github.com/repos/mui-org/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mui-org/material-ui/events","assignees_url":"https://api.github.com/repos/mui-org/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mui-org/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mui-org/material-ui/tags","blobs_url":"https://api.github.com/repos/mui-org/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mui-org/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mui-org/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mui-org/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mui-org/material-ui/languages","stargazers_url":"https://api.github.com/repos/mui-org/material-ui/stargazers","contributors_url":"https://api.github.com/repos/mui-org/material-ui/contributors","subscribers_url":"https://api.github.com/repos/mui-org/material-ui/subscribers","subscription_url":"https://api.github.com/repos/mui-org/material-ui/subscription","commits_url":"https://api.github.com/repos/mui-org/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mui-org/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mui-org/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mui-org/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mui-org/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mui-org/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mui-org/material-ui/merges","archive_url":"https://api.github.com/repos/mui-org/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mui-org/material-ui/downloads","issues_url":"https://api.github.com/repos/mui-org/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mui-org/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mui-org/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mui-org/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mui-org/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/mui-org/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mui-org/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2018-08-15T15:53:39Z","pushed_at":"2018-08-15T16:18:51Z","git_url":"git://github.com/mui-org/material-ui.git","ssh_url":"git@github.com:mui-org/material-ui.git","clone_url":"https://github.com/mui-org/material-ui.git","svn_url":"https://github.com/mui-org/material-ui","homepage":"https://material-ui.com/","size":47874,"stargazers_count":39375,"watchers_count":39375,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7241,"mirror_url":null,"archived":false,"open_issues_count":189,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7241,"open_issues":189,"watchers":39375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/11904"},"html":{"href":"https://github.com/mui-org/material-ui/pull/11904"},"issue":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/11904"},"comments":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/11904/comments"},"review_comments":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/11904/comments"},"review_comment":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/11904/commits"},"statuses":{"href":"https://api.github.com/repos/mui-org/material-ui/statuses/884068a5bedd299838ad29b6448f24289e61013f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicosommi"}}