{"action":"created","issue":{"url":"https://api.github.com/repos/pmodels/mpich/issues/3359","repository_url":"https://api.github.com/repos/pmodels/mpich","labels_url":"https://api.github.com/repos/pmodels/mpich/issues/3359/labels{/name}","comments_url":"https://api.github.com/repos/pmodels/mpich/issues/3359/comments","events_url":"https://api.github.com/repos/pmodels/mpich/issues/3359/events","html_url":"https://github.com/pmodels/mpich/pull/3359","id":367233365,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzE4OTU4","number":3359,"title":"F77tof90","user":{"login":"raffenet","id":1410792,"node_id":"MDQ6VXNlcjE0MTA3OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1410792?v=4","gravatar_id":"","url":"https://api.github.com/users/raffenet","html_url":"https://github.com/raffenet","followers_url":"https://api.github.com/users/raffenet/followers","following_url":"https://api.github.com/users/raffenet/following{/other_user}","gists_url":"https://api.github.com/users/raffenet/gists{/gist_id}","starred_url":"https://api.github.com/users/raffenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffenet/subscriptions","organizations_url":"https://api.github.com/users/raffenet/orgs","repos_url":"https://api.github.com/users/raffenet/repos","events_url":"https://api.github.com/users/raffenet/events{/privacy}","received_events_url":"https://api.github.com/users/raffenet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-05T14:22:22Z","updated_at":"2018-10-09T07:53:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/3359","html_url":"https://github.com/pmodels/mpich/pull/3359","diff_url":"https://github.com/pmodels/mpich/pull/3359.diff","patch_url":"https://github.com/pmodels/mpich/pull/3359.patch"},"body":"This is a step-by-step breakdown of the first commit in #2382. Probably me just being overly committed to showing the work involved, but it fixes a few issues I noticed in the other PR."},"comment":{"url":"https://api.github.com/repos/pmodels/mpich/issues/comments/428096042","html_url":"https://github.com/pmodels/mpich/pull/3359#issuecomment-428096042","issue_url":"https://api.github.com/repos/pmodels/mpich/issues/3359","id":428096042,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODA5NjA0Mg==","user":{"login":"ggouaillardet","id":7233259,"node_id":"MDQ6VXNlcjcyMzMyNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7233259?v=4","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T07:53:25Z","updated_at":"2018-10-09T07:53:25Z","author_association":"CONTRIBUTOR","body":"@raffenet I had a second look at it, and it seems the only missing patch is below\r\n\r\n```diff\r\ndiff --git a/test/mpi/configure.ac b/test/mpi/configure.ac\r\nindex 830251d7c..7ea794751 100644\r\n--- a/test/mpi/configure.ac\r\n+++ b/test/mpi/configure.ac\r\n@@ -81,8 +81,8 @@ if test \"X$master_top_srcdir\" = \"X\" -a \"$USE_MAINTAINER_MODE\" = \"yes\" ; then\r\n         ;;        \r\n     esac\r\n     # Now, see if we can find the f77tof90 routine\r\n-    if test -x $use_top_srcdir/../../maint/f77tof90 ; then \r\n-        master_top_srcdir=`cd $use_top_srcdir && cd ../.. && pwd`\r\n+    if test -x $use_top_srcdir/maint/f77tof90 ; then \r\n+        master_top_srcdir=`cd $use_top_srcdir && pwd`\r\n     else \r\n         AC_MSG_ERROR([Unable to find master source file - reconfigure using --disable-maintainer_mode])\r\n     fi\r\ndiff --git a/test/mpi/maint/f77tof90 b/test/mpi/maint/f77tof90\r\nindex fb2168d69..2844d881d 100755\r\n--- a/test/mpi/maint/f77tof90\r\n+++ b/test/mpi/maint/f77tof90\r\n@@ -389,8 +389,8 @@ if MAINTAINER_MODE\r\n # change its contents\r\n \\$(srcdir)/Makefile.am: \\$(srcdir)/Makefile.am-stamp\r\n \r\n-\\$(srcdir)/Makefile.am-stamp: \\$(srcdir)/${indir}/Makefile.am \\$(srcdir)/maint/f77tof90\r\n-\\t( cd \\$(srcdir) && ./maint/f77tof90 ${indir} ${outdir} Makefile.am Makefile.ap )\r\n+\\$(srcdir)/Makefile.am-stamp: \\$(top_srcdir)/${indir}/Makefile.am \\$(top_srcdir)/maint/f77tof90\r\n+\\t( cd \\$(top_srcdir) && ./maint/f77tof90 ${indir} ${outdir} Makefile.am Makefile.ap )\r\n \r\n MAINTAINERCLEANFILES ${mcf_plus}= Makefile.am-stamp\r\n EXTRA_DIST ${ed_plus}= Makefile.am-stamp ${testlist_ap} ${makefile_ap}\r\n```"}}
{"actor":{"display_login":"ggouaillardet"}}