{"action":"opened","number":2879,"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879","id":218767306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzY3MzA2","html_url":"https://github.com/avocado-framework/avocado/pull/2879","diff_url":"https://github.com/avocado-framework/avocado/pull/2879.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/2879.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/2879","number":2879,"state":"open","locked":false,"title":"vmimage: more tests for parser and base and minor improvements","user":{"login":"cacarrara","id":348237,"node_id":"MDQ6VXNlcjM0ODIzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/348237?v=4","gravatar_id":"","url":"https://api.github.com/users/cacarrara","html_url":"https://github.com/cacarrara","followers_url":"https://api.github.com/users/cacarrara/followers","following_url":"https://api.github.com/users/cacarrara/following{/other_user}","gists_url":"https://api.github.com/users/cacarrara/gists{/gist_id}","starred_url":"https://api.github.com/users/cacarrara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacarrara/subscriptions","organizations_url":"https://api.github.com/users/cacarrara/orgs","repos_url":"https://api.github.com/users/cacarrara/repos","events_url":"https://api.github.com/users/cacarrara/events{/privacy}","received_events_url":"https://api.github.com/users/cacarrara/received_events","type":"User","site_admin":false},"body":"This change focus mostly on increasing tests for `VmImageHtmlParser` and\r\n`ImageProviderBase`. During the tests implementation some improvements\r\nwere detected: the process of feed a html parser run both for get an\r\nimage version and image url was duplicated so it was unified in a single\r\nmethod.\r\n\r\nBesides that the process to get a best version for an image was put on a\r\nspecific method so each provider can override it if required. Today the\r\ndefault rule for a best version is based on calling max() function on\r\nfound versions. However we can't assume it's the default for every\r\nprovider. As far as we know, for a possible OpenSuse provider in future\r\nthis rule will not be valid.\r\n\r\nReference: https://trello.com/c/vtM1SPpJ\r\nSigned-off-by: Caio Carrara <ccarrara@redhat.com>","created_at":"2018-09-27T19:43:40Z","updated_at":"2018-09-27T19:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"clebergnu","id":447178,"node_id":"MDQ6VXNlcjQ0NzE3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/447178?v=4","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/2879/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/6816e6432cbd0e73c9d3bb9e838479aff7ddb429","head":{"label":"cacarrara:add-tests-for-vmimage","ref":"add-tests-for-vmimage","sha":"6816e6432cbd0e73c9d3bb9e838479aff7ddb429","user":{"login":"cacarrara","id":348237,"node_id":"MDQ6VXNlcjM0ODIzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/348237?v=4","gravatar_id":"","url":"https://api.github.com/users/cacarrara","html_url":"https://github.com/cacarrara","followers_url":"https://api.github.com/users/cacarrara/followers","following_url":"https://api.github.com/users/cacarrara/following{/other_user}","gists_url":"https://api.github.com/users/cacarrara/gists{/gist_id}","starred_url":"https://api.github.com/users/cacarrara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacarrara/subscriptions","organizations_url":"https://api.github.com/users/cacarrara/orgs","repos_url":"https://api.github.com/users/cacarrara/repos","events_url":"https://api.github.com/users/cacarrara/events{/privacy}","received_events_url":"https://api.github.com/users/cacarrara/received_events","type":"User","site_admin":false},"repo":{"id":144047999,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwNDc5OTk=","name":"avocado","full_name":"cacarrara/avocado","private":false,"owner":{"login":"cacarrara","id":348237,"node_id":"MDQ6VXNlcjM0ODIzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/348237?v=4","gravatar_id":"","url":"https://api.github.com/users/cacarrara","html_url":"https://github.com/cacarrara","followers_url":"https://api.github.com/users/cacarrara/followers","following_url":"https://api.github.com/users/cacarrara/following{/other_user}","gists_url":"https://api.github.com/users/cacarrara/gists{/gist_id}","starred_url":"https://api.github.com/users/cacarrara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacarrara/subscriptions","organizations_url":"https://api.github.com/users/cacarrara/orgs","repos_url":"https://api.github.com/users/cacarrara/repos","events_url":"https://api.github.com/users/cacarrara/events{/privacy}","received_events_url":"https://api.github.com/users/cacarrara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cacarrara/avocado","description":"Avocado Test Framework","fork":true,"url":"https://api.github.com/repos/cacarrara/avocado","forks_url":"https://api.github.com/repos/cacarrara/avocado/forks","keys_url":"https://api.github.com/repos/cacarrara/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cacarrara/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cacarrara/avocado/teams","hooks_url":"https://api.github.com/repos/cacarrara/avocado/hooks","issue_events_url":"https://api.github.com/repos/cacarrara/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/cacarrara/avocado/events","assignees_url":"https://api.github.com/repos/cacarrara/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/cacarrara/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/cacarrara/avocado/tags","blobs_url":"https://api.github.com/repos/cacarrara/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cacarrara/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cacarrara/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/cacarrara/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cacarrara/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/cacarrara/avocado/languages","stargazers_url":"https://api.github.com/repos/cacarrara/avocado/stargazers","contributors_url":"https://api.github.com/repos/cacarrara/avocado/contributors","subscribers_url":"https://api.github.com/repos/cacarrara/avocado/subscribers","subscription_url":"https://api.github.com/repos/cacarrara/avocado/subscription","commits_url":"https://api.github.com/repos/cacarrara/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/cacarrara/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/cacarrara/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/cacarrara/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/cacarrara/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/cacarrara/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cacarrara/avocado/merges","archive_url":"https://api.github.com/repos/cacarrara/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cacarrara/avocado/downloads","issues_url":"https://api.github.com/repos/cacarrara/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/cacarrara/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/cacarrara/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/cacarrara/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cacarrara/avocado/labels{/name}","releases_url":"https://api.github.com/repos/cacarrara/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/cacarrara/avocado/deployments","created_at":"2018-08-08T17:42:26Z","updated_at":"2018-09-27T17:40:16Z","pushed_at":"2018-09-27T19:41:36Z","git_url":"git://github.com/cacarrara/avocado.git","ssh_url":"git@github.com:cacarrara/avocado.git","clone_url":"https://github.com/cacarrara/avocado.git","svn_url":"https://github.com/cacarrara/avocado","homepage":"http://avocado-framework.github.io/","size":12760,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"c08192456fec0fef4f07decad03944130deb5e74","user":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17449498,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ0OTQ5OA==","name":"avocado","full_name":"avocado-framework/avocado","private":false,"owner":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/avocado-framework/avocado","description":"Avocado Test Framework","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado","forks_url":"https://api.github.com/repos/avocado-framework/avocado/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado/deployments","created_at":"2014-03-05T17:52:27Z","updated_at":"2018-09-27T17:39:57Z","pushed_at":"2018-09-27T17:39:53Z","git_url":"git://github.com/avocado-framework/avocado.git","ssh_url":"git@github.com:avocado-framework/avocado.git","clone_url":"https://github.com/avocado-framework/avocado.git","svn_url":"https://github.com/avocado-framework/avocado","homepage":"http://avocado-framework.github.io/","size":12759,"stargazers_count":166,"watchers_count":166,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":179,"open_issues":17,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/2879"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/2879"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/2879/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2879/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado/statuses/6816e6432cbd0e73c9d3bb9e838479aff7ddb429"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":123,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"cacarrara"}}