{"action":"created","comment":{"url":"https://api.github.com/repos/loads/molotov/pulls/comments/166583065","pull_request_review_id":94666686,"id":166583065,"diff_hunk":"@@ -200,12 +201,39 @@ def test_single_mode(self):\n         async def here_three(session):\n             _RES.append(3)\n \n-        stdout, stderr = self._test_molotov('-cx', '--max-runs', '2', '-s',\n+        stdout, stderr, exit_code = self._test_molotov('-cx', '--max-runs', '2', '-s',\n                                             'here_three',\n                                             'molotov.tests.test_run')\n         wanted = \"SUCCESSES: 2\"\n         self.assertTrue(wanted in stdout)\n \n+    @dedicatedloop\n+    def test_fail_mode_pass(self):\n+\n+        @scenario(weight=10)\n+        async def here_three(session):\n+            _RES.append(3)\n+\n+        stdout, stderr, exit_code = self._test_molotov('-cx', '--max-runs', '2',\n+                                            '--fail', '1', 'here_three',\n+                                            'molotov.tests.test_run')","path":"molotov/tests/test_run.py","position":93,"original_position":93,"commit_id":"2cdcc141fe91cc5de5df6f9ba4875fab9d77dbbf","original_commit_id":"2cdcc141fe91cc5de5df6f9ba4875fab9d77dbbf","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"continuation line under-indented for visual indent","created_at":"2018-02-07T10:57:15Z","updated_at":"2018-02-07T10:57:16Z","html_url":"https://github.com/loads/molotov/pull/105#discussion_r166583065","pull_request_url":"https://api.github.com/repos/loads/molotov/pulls/105","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/loads/molotov/pulls/comments/166583065"},"html":{"href":"https://github.com/loads/molotov/pull/105#discussion_r166583065"},"pull_request":{"href":"https://api.github.com/repos/loads/molotov/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/loads/molotov/pulls/105","id":167423278,"html_url":"https://github.com/loads/molotov/pull/105","diff_url":"https://github.com/loads/molotov/pull/105.diff","patch_url":"https://github.com/loads/molotov/pull/105.patch","issue_url":"https://api.github.com/repos/loads/molotov/issues/105","number":105,"state":"open","locked":false,"title":"Add --fail flag","user":{"login":"Miouge1","id":13647208,"avatar_url":"https://avatars0.githubusercontent.com/u/13647208?v=4","gravatar_id":"","url":"https://api.github.com/users/Miouge1","html_url":"https://github.com/Miouge1","followers_url":"https://api.github.com/users/Miouge1/followers","following_url":"https://api.github.com/users/Miouge1/following{/other_user}","gists_url":"https://api.github.com/users/Miouge1/gists{/gist_id}","starred_url":"https://api.github.com/users/Miouge1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miouge1/subscriptions","organizations_url":"https://api.github.com/users/Miouge1/orgs","repos_url":"https://api.github.com/users/Miouge1/repos","events_url":"https://api.github.com/users/Miouge1/events{/privacy}","received_events_url":"https://api.github.com/users/Miouge1/received_events","type":"User","site_admin":false},"body":"This PR adds support for a flag to control the return/exit code of molotov.\r\n\r\nThis is useful for integration in CI/CD scenario were you might want to load-test applications without having to parse the stdout.","created_at":"2018-02-06T14:08:18Z","updated_at":"2018-02-07T10:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2a64c08f4d9774fe6defbb10f296a487146710a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/loads/molotov/pulls/105/commits","review_comments_url":"https://api.github.com/repos/loads/molotov/pulls/105/comments","review_comment_url":"https://api.github.com/repos/loads/molotov/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loads/molotov/issues/105/comments","statuses_url":"https://api.github.com/repos/loads/molotov/statuses/2cdcc141fe91cc5de5df6f9ba4875fab9d77dbbf","head":{"label":"Miouge1:exit-code","ref":"exit-code","sha":"2cdcc141fe91cc5de5df6f9ba4875fab9d77dbbf","user":{"login":"Miouge1","id":13647208,"avatar_url":"https://avatars0.githubusercontent.com/u/13647208?v=4","gravatar_id":"","url":"https://api.github.com/users/Miouge1","html_url":"https://github.com/Miouge1","followers_url":"https://api.github.com/users/Miouge1/followers","following_url":"https://api.github.com/users/Miouge1/following{/other_user}","gists_url":"https://api.github.com/users/Miouge1/gists{/gist_id}","starred_url":"https://api.github.com/users/Miouge1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miouge1/subscriptions","organizations_url":"https://api.github.com/users/Miouge1/orgs","repos_url":"https://api.github.com/users/Miouge1/repos","events_url":"https://api.github.com/users/Miouge1/events{/privacy}","received_events_url":"https://api.github.com/users/Miouge1/received_events","type":"User","site_admin":false},"repo":{"id":120464745,"name":"molotov","full_name":"Miouge1/molotov","owner":{"login":"Miouge1","id":13647208,"avatar_url":"https://avatars0.githubusercontent.com/u/13647208?v=4","gravatar_id":"","url":"https://api.github.com/users/Miouge1","html_url":"https://github.com/Miouge1","followers_url":"https://api.github.com/users/Miouge1/followers","following_url":"https://api.github.com/users/Miouge1/following{/other_user}","gists_url":"https://api.github.com/users/Miouge1/gists{/gist_id}","starred_url":"https://api.github.com/users/Miouge1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miouge1/subscriptions","organizations_url":"https://api.github.com/users/Miouge1/orgs","repos_url":"https://api.github.com/users/Miouge1/repos","events_url":"https://api.github.com/users/Miouge1/events{/privacy}","received_events_url":"https://api.github.com/users/Miouge1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Miouge1/molotov","description":"Load Testing Tool","fork":true,"url":"https://api.github.com/repos/Miouge1/molotov","forks_url":"https://api.github.com/repos/Miouge1/molotov/forks","keys_url":"https://api.github.com/repos/Miouge1/molotov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Miouge1/molotov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Miouge1/molotov/teams","hooks_url":"https://api.github.com/repos/Miouge1/molotov/hooks","issue_events_url":"https://api.github.com/repos/Miouge1/molotov/issues/events{/number}","events_url":"https://api.github.com/repos/Miouge1/molotov/events","assignees_url":"https://api.github.com/repos/Miouge1/molotov/assignees{/user}","branches_url":"https://api.github.com/repos/Miouge1/molotov/branches{/branch}","tags_url":"https://api.github.com/repos/Miouge1/molotov/tags","blobs_url":"https://api.github.com/repos/Miouge1/molotov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Miouge1/molotov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Miouge1/molotov/git/refs{/sha}","trees_url":"https://api.github.com/repos/Miouge1/molotov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Miouge1/molotov/statuses/{sha}","languages_url":"https://api.github.com/repos/Miouge1/molotov/languages","stargazers_url":"https://api.github.com/repos/Miouge1/molotov/stargazers","contributors_url":"https://api.github.com/repos/Miouge1/molotov/contributors","subscribers_url":"https://api.github.com/repos/Miouge1/molotov/subscribers","subscription_url":"https://api.github.com/repos/Miouge1/molotov/subscription","commits_url":"https://api.github.com/repos/Miouge1/molotov/commits{/sha}","git_commits_url":"https://api.github.com/repos/Miouge1/molotov/git/commits{/sha}","comments_url":"https://api.github.com/repos/Miouge1/molotov/comments{/number}","issue_comment_url":"https://api.github.com/repos/Miouge1/molotov/issues/comments{/number}","contents_url":"https://api.github.com/repos/Miouge1/molotov/contents/{+path}","compare_url":"https://api.github.com/repos/Miouge1/molotov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Miouge1/molotov/merges","archive_url":"https://api.github.com/repos/Miouge1/molotov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Miouge1/molotov/downloads","issues_url":"https://api.github.com/repos/Miouge1/molotov/issues{/number}","pulls_url":"https://api.github.com/repos/Miouge1/molotov/pulls{/number}","milestones_url":"https://api.github.com/repos/Miouge1/molotov/milestones{/number}","notifications_url":"https://api.github.com/repos/Miouge1/molotov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Miouge1/molotov/labels{/name}","releases_url":"https://api.github.com/repos/Miouge1/molotov/releases{/id}","deployments_url":"https://api.github.com/repos/Miouge1/molotov/deployments","created_at":"2018-02-06T13:54:52Z","updated_at":"2018-02-06T13:54:54Z","pushed_at":"2018-02-07T10:57:08Z","git_url":"git://github.com/Miouge1/molotov.git","ssh_url":"git@github.com:Miouge1/molotov.git","clone_url":"https://github.com/Miouge1/molotov.git","svn_url":"https://github.com/Miouge1/molotov","homepage":"","size":374,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"loads:master","ref":"master","sha":"b6316b7b736bc0398359538a4b75b2571503d0dc","user":{"login":"loads","id":8523648,"avatar_url":"https://avatars2.githubusercontent.com/u/8523648?v=4","gravatar_id":"","url":"https://api.github.com/users/loads","html_url":"https://github.com/loads","followers_url":"https://api.github.com/users/loads/followers","following_url":"https://api.github.com/users/loads/following{/other_user}","gists_url":"https://api.github.com/users/loads/gists{/gist_id}","starred_url":"https://api.github.com/users/loads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loads/subscriptions","organizations_url":"https://api.github.com/users/loads/orgs","repos_url":"https://api.github.com/users/loads/repos","events_url":"https://api.github.com/users/loads/events{/privacy}","received_events_url":"https://api.github.com/users/loads/received_events","type":"Organization","site_admin":false},"repo":{"id":35025578,"name":"molotov","full_name":"loads/molotov","owner":{"login":"loads","id":8523648,"avatar_url":"https://avatars2.githubusercontent.com/u/8523648?v=4","gravatar_id":"","url":"https://api.github.com/users/loads","html_url":"https://github.com/loads","followers_url":"https://api.github.com/users/loads/followers","following_url":"https://api.github.com/users/loads/following{/other_user}","gists_url":"https://api.github.com/users/loads/gists{/gist_id}","starred_url":"https://api.github.com/users/loads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loads/subscriptions","organizations_url":"https://api.github.com/users/loads/orgs","repos_url":"https://api.github.com/users/loads/repos","events_url":"https://api.github.com/users/loads/events{/privacy}","received_events_url":"https://api.github.com/users/loads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loads/molotov","description":"Load Testing Tool","fork":false,"url":"https://api.github.com/repos/loads/molotov","forks_url":"https://api.github.com/repos/loads/molotov/forks","keys_url":"https://api.github.com/repos/loads/molotov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loads/molotov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loads/molotov/teams","hooks_url":"https://api.github.com/repos/loads/molotov/hooks","issue_events_url":"https://api.github.com/repos/loads/molotov/issues/events{/number}","events_url":"https://api.github.com/repos/loads/molotov/events","assignees_url":"https://api.github.com/repos/loads/molotov/assignees{/user}","branches_url":"https://api.github.com/repos/loads/molotov/branches{/branch}","tags_url":"https://api.github.com/repos/loads/molotov/tags","blobs_url":"https://api.github.com/repos/loads/molotov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loads/molotov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loads/molotov/git/refs{/sha}","trees_url":"https://api.github.com/repos/loads/molotov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loads/molotov/statuses/{sha}","languages_url":"https://api.github.com/repos/loads/molotov/languages","stargazers_url":"https://api.github.com/repos/loads/molotov/stargazers","contributors_url":"https://api.github.com/repos/loads/molotov/contributors","subscribers_url":"https://api.github.com/repos/loads/molotov/subscribers","subscription_url":"https://api.github.com/repos/loads/molotov/subscription","commits_url":"https://api.github.com/repos/loads/molotov/commits{/sha}","git_commits_url":"https://api.github.com/repos/loads/molotov/git/commits{/sha}","comments_url":"https://api.github.com/repos/loads/molotov/comments{/number}","issue_comment_url":"https://api.github.com/repos/loads/molotov/issues/comments{/number}","contents_url":"https://api.github.com/repos/loads/molotov/contents/{+path}","compare_url":"https://api.github.com/repos/loads/molotov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loads/molotov/merges","archive_url":"https://api.github.com/repos/loads/molotov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loads/molotov/downloads","issues_url":"https://api.github.com/repos/loads/molotov/issues{/number}","pulls_url":"https://api.github.com/repos/loads/molotov/pulls{/number}","milestones_url":"https://api.github.com/repos/loads/molotov/milestones{/number}","notifications_url":"https://api.github.com/repos/loads/molotov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loads/molotov/labels{/name}","releases_url":"https://api.github.com/repos/loads/molotov/releases{/id}","deployments_url":"https://api.github.com/repos/loads/molotov/deployments","created_at":"2015-05-04T09:17:25Z","updated_at":"2018-02-07T09:04:13Z","pushed_at":"2018-02-07T10:57:10Z","git_url":"git://github.com/loads/molotov.git","ssh_url":"git@github.com:loads/molotov.git","clone_url":"https://github.com/loads/molotov.git","svn_url":"https://github.com/loads/molotov","homepage":"","size":374,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":16,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loads/molotov/pulls/105"},"html":{"href":"https://github.com/loads/molotov/pull/105"},"issue":{"href":"https://api.github.com/repos/loads/molotov/issues/105"},"comments":{"href":"https://api.github.com/repos/loads/molotov/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/loads/molotov/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/loads/molotov/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loads/molotov/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/loads/molotov/statuses/2cdcc141fe91cc5de5df6f9ba4875fab9d77dbbf"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}