{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/parthanium/xkcd/pulls/2","id":194835927,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODM1OTI3","html_url":"https://github.com/parthanium/xkcd/pull/2","diff_url":"https://github.com/parthanium/xkcd/pull/2.diff","patch_url":"https://github.com/parthanium/xkcd/pull/2.patch","issue_url":"https://api.github.com/repos/parthanium/xkcd/issues/2","number":2,"state":"open","locked":false,"title":"Fixes2018","user":{"login":"Dapbler","id":39928983,"node_id":"MDQ6VXNlcjM5OTI4OTgz","avatar_url":"https://avatars2.githubusercontent.com/u/39928983?v=4","gravatar_id":"","url":"https://api.github.com/users/Dapbler","html_url":"https://github.com/Dapbler","followers_url":"https://api.github.com/users/Dapbler/followers","following_url":"https://api.github.com/users/Dapbler/following{/other_user}","gists_url":"https://api.github.com/users/Dapbler/gists{/gist_id}","starred_url":"https://api.github.com/users/Dapbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dapbler/subscriptions","organizations_url":"https://api.github.com/users/Dapbler/orgs","repos_url":"https://api.github.com/users/Dapbler/repos","events_url":"https://api.github.com/users/Dapbler/events{/privacy}","received_events_url":"https://api.github.com/users/Dapbler/received_events","type":"User","site_admin":false},"body":"Hi, thanks for this script, just what I was looking for.\r\nI'm new to github (and pretty new to Python as well...), so apologies if I've gotten something about the process wrong and my code isn't very elegant yet.\r\nI've downloaded up to 2006 with the script and patched for exceptions as they came up.\r\n\r\nFixes:\r\n- Minor fix to latest (range didn't cope with links changing to https, I guess) which strips non digits from result.\r\n- Changed comic range to be inclusive of last comic.\r\n- Keeps file extension of downloaded file\r\n- Replaces forward slashes in titles with underscores (issue on nix/mac - amusingly came up in PC/Mac comic)\r\n- Does not attempt download on the weird comics (moved 404 and other exception case testing into f() to de-duplicate checks).\r\n- Cleans extra HTML coming back from title search (I can't remember what comic this was needed for)\r\n\r\nEnhancements (you may want to trim these out):\r\n- Adds numeric prefix to file names (eg 1234-Title.png) so they sort in publication order.\r\n- Optional command line arguments --nogui, --comic, --dest for scripted/command line use\r\n","created_at":"2018-06-14T09:46:20Z","updated_at":"2018-06-14T09:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/parthanium/xkcd/pulls/2/commits","review_comments_url":"https://api.github.com/repos/parthanium/xkcd/pulls/2/comments","review_comment_url":"https://api.github.com/repos/parthanium/xkcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parthanium/xkcd/issues/2/comments","statuses_url":"https://api.github.com/repos/parthanium/xkcd/statuses/1f6e832ab113e63d6f7e0e101f0d3c59b1cd8f7a","head":{"label":"Dapbler:fixes2018","ref":"fixes2018","sha":"1f6e832ab113e63d6f7e0e101f0d3c59b1cd8f7a","user":{"login":"Dapbler","id":39928983,"node_id":"MDQ6VXNlcjM5OTI4OTgz","avatar_url":"https://avatars2.githubusercontent.com/u/39928983?v=4","gravatar_id":"","url":"https://api.github.com/users/Dapbler","html_url":"https://github.com/Dapbler","followers_url":"https://api.github.com/users/Dapbler/followers","following_url":"https://api.github.com/users/Dapbler/following{/other_user}","gists_url":"https://api.github.com/users/Dapbler/gists{/gist_id}","starred_url":"https://api.github.com/users/Dapbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dapbler/subscriptions","organizations_url":"https://api.github.com/users/Dapbler/orgs","repos_url":"https://api.github.com/users/Dapbler/repos","events_url":"https://api.github.com/users/Dapbler/events{/privacy}","received_events_url":"https://api.github.com/users/Dapbler/received_events","type":"User","site_admin":false},"repo":{"id":137096359,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwOTYzNTk=","name":"xkcd","full_name":"Dapbler/xkcd","owner":{"login":"Dapbler","id":39928983,"node_id":"MDQ6VXNlcjM5OTI4OTgz","avatar_url":"https://avatars2.githubusercontent.com/u/39928983?v=4","gravatar_id":"","url":"https://api.github.com/users/Dapbler","html_url":"https://github.com/Dapbler","followers_url":"https://api.github.com/users/Dapbler/followers","following_url":"https://api.github.com/users/Dapbler/following{/other_user}","gists_url":"https://api.github.com/users/Dapbler/gists{/gist_id}","starred_url":"https://api.github.com/users/Dapbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dapbler/subscriptions","organizations_url":"https://api.github.com/users/Dapbler/orgs","repos_url":"https://api.github.com/users/Dapbler/repos","events_url":"https://api.github.com/users/Dapbler/events{/privacy}","received_events_url":"https://api.github.com/users/Dapbler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dapbler/xkcd","description":"A Python 3.3 script to download xkcd comics.","fork":true,"url":"https://api.github.com/repos/Dapbler/xkcd","forks_url":"https://api.github.com/repos/Dapbler/xkcd/forks","keys_url":"https://api.github.com/repos/Dapbler/xkcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dapbler/xkcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dapbler/xkcd/teams","hooks_url":"https://api.github.com/repos/Dapbler/xkcd/hooks","issue_events_url":"https://api.github.com/repos/Dapbler/xkcd/issues/events{/number}","events_url":"https://api.github.com/repos/Dapbler/xkcd/events","assignees_url":"https://api.github.com/repos/Dapbler/xkcd/assignees{/user}","branches_url":"https://api.github.com/repos/Dapbler/xkcd/branches{/branch}","tags_url":"https://api.github.com/repos/Dapbler/xkcd/tags","blobs_url":"https://api.github.com/repos/Dapbler/xkcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dapbler/xkcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dapbler/xkcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dapbler/xkcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dapbler/xkcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Dapbler/xkcd/languages","stargazers_url":"https://api.github.com/repos/Dapbler/xkcd/stargazers","contributors_url":"https://api.github.com/repos/Dapbler/xkcd/contributors","subscribers_url":"https://api.github.com/repos/Dapbler/xkcd/subscribers","subscription_url":"https://api.github.com/repos/Dapbler/xkcd/subscription","commits_url":"https://api.github.com/repos/Dapbler/xkcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dapbler/xkcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dapbler/xkcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dapbler/xkcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dapbler/xkcd/contents/{+path}","compare_url":"https://api.github.com/repos/Dapbler/xkcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dapbler/xkcd/merges","archive_url":"https://api.github.com/repos/Dapbler/xkcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dapbler/xkcd/downloads","issues_url":"https://api.github.com/repos/Dapbler/xkcd/issues{/number}","pulls_url":"https://api.github.com/repos/Dapbler/xkcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Dapbler/xkcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Dapbler/xkcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dapbler/xkcd/labels{/name}","releases_url":"https://api.github.com/repos/Dapbler/xkcd/releases{/id}","deployments_url":"https://api.github.com/repos/Dapbler/xkcd/deployments","created_at":"2018-06-12T16:02:28Z","updated_at":"2018-06-12T16:02:30Z","pushed_at":"2018-06-14T09:34:03Z","git_url":"git://github.com/Dapbler/xkcd.git","ssh_url":"git@github.com:Dapbler/xkcd.git","clone_url":"https://github.com/Dapbler/xkcd.git","svn_url":"https://github.com/Dapbler/xkcd","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"parthanium:master","ref":"master","sha":"ee402e123d7d71c54a163792d9161b6566e4228f","user":{"login":"parthanium","id":6397530,"node_id":"MDQ6VXNlcjYzOTc1MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6397530?v=4","gravatar_id":"","url":"https://api.github.com/users/parthanium","html_url":"https://github.com/parthanium","followers_url":"https://api.github.com/users/parthanium/followers","following_url":"https://api.github.com/users/parthanium/following{/other_user}","gists_url":"https://api.github.com/users/parthanium/gists{/gist_id}","starred_url":"https://api.github.com/users/parthanium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthanium/subscriptions","organizations_url":"https://api.github.com/users/parthanium/orgs","repos_url":"https://api.github.com/users/parthanium/repos","events_url":"https://api.github.com/users/parthanium/events{/privacy}","received_events_url":"https://api.github.com/users/parthanium/received_events","type":"User","site_admin":false},"repo":{"id":16864502,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg2NDUwMg==","name":"xkcd","full_name":"parthanium/xkcd","owner":{"login":"parthanium","id":6397530,"node_id":"MDQ6VXNlcjYzOTc1MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6397530?v=4","gravatar_id":"","url":"https://api.github.com/users/parthanium","html_url":"https://github.com/parthanium","followers_url":"https://api.github.com/users/parthanium/followers","following_url":"https://api.github.com/users/parthanium/following{/other_user}","gists_url":"https://api.github.com/users/parthanium/gists{/gist_id}","starred_url":"https://api.github.com/users/parthanium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthanium/subscriptions","organizations_url":"https://api.github.com/users/parthanium/orgs","repos_url":"https://api.github.com/users/parthanium/repos","events_url":"https://api.github.com/users/parthanium/events{/privacy}","received_events_url":"https://api.github.com/users/parthanium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parthanium/xkcd","description":"A Python 3.3 script to download xkcd comics.","fork":false,"url":"https://api.github.com/repos/parthanium/xkcd","forks_url":"https://api.github.com/repos/parthanium/xkcd/forks","keys_url":"https://api.github.com/repos/parthanium/xkcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parthanium/xkcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parthanium/xkcd/teams","hooks_url":"https://api.github.com/repos/parthanium/xkcd/hooks","issue_events_url":"https://api.github.com/repos/parthanium/xkcd/issues/events{/number}","events_url":"https://api.github.com/repos/parthanium/xkcd/events","assignees_url":"https://api.github.com/repos/parthanium/xkcd/assignees{/user}","branches_url":"https://api.github.com/repos/parthanium/xkcd/branches{/branch}","tags_url":"https://api.github.com/repos/parthanium/xkcd/tags","blobs_url":"https://api.github.com/repos/parthanium/xkcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parthanium/xkcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parthanium/xkcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/parthanium/xkcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parthanium/xkcd/statuses/{sha}","languages_url":"https://api.github.com/repos/parthanium/xkcd/languages","stargazers_url":"https://api.github.com/repos/parthanium/xkcd/stargazers","contributors_url":"https://api.github.com/repos/parthanium/xkcd/contributors","subscribers_url":"https://api.github.com/repos/parthanium/xkcd/subscribers","subscription_url":"https://api.github.com/repos/parthanium/xkcd/subscription","commits_url":"https://api.github.com/repos/parthanium/xkcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/parthanium/xkcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/parthanium/xkcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/parthanium/xkcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/parthanium/xkcd/contents/{+path}","compare_url":"https://api.github.com/repos/parthanium/xkcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parthanium/xkcd/merges","archive_url":"https://api.github.com/repos/parthanium/xkcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parthanium/xkcd/downloads","issues_url":"https://api.github.com/repos/parthanium/xkcd/issues{/number}","pulls_url":"https://api.github.com/repos/parthanium/xkcd/pulls{/number}","milestones_url":"https://api.github.com/repos/parthanium/xkcd/milestones{/number}","notifications_url":"https://api.github.com/repos/parthanium/xkcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parthanium/xkcd/labels{/name}","releases_url":"https://api.github.com/repos/parthanium/xkcd/releases{/id}","deployments_url":"https://api.github.com/repos/parthanium/xkcd/deployments","created_at":"2014-02-15T14:39:34Z","updated_at":"2017-10-21T15:58:06Z","pushed_at":"2018-06-13T23:37:19Z","git_url":"git://github.com/parthanium/xkcd.git","ssh_url":"git@github.com:parthanium/xkcd.git","clone_url":"https://github.com/parthanium/xkcd.git","svn_url":"https://github.com/parthanium/xkcd","homepage":null,"size":176,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parthanium/xkcd/pulls/2"},"html":{"href":"https://github.com/parthanium/xkcd/pull/2"},"issue":{"href":"https://api.github.com/repos/parthanium/xkcd/issues/2"},"comments":{"href":"https://api.github.com/repos/parthanium/xkcd/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/parthanium/xkcd/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/parthanium/xkcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parthanium/xkcd/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/parthanium/xkcd/statuses/1f6e832ab113e63d6f7e0e101f0d3c59b1cd8f7a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":6,"additions":107,"deletions":49,"changed_files":1}}
{"actor":{"display_login":"Dapbler"}}