{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/215331044","pull_request_review_id":152570777,"id":215331044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTMzMTA0NA==","diff_hunk":"@@ -42,21 +42,30 @@ installer_url: $INSTALLER\n provider: onprem\n platform: aws\n aws_region: us-west-2\n-os_name: cent-os-7-dcos-prereqs\n key_helper: true\n instance_type: m4.large\n-num_public_agents: 1\n-num_private_agents: 3\n num_masters: 3\n+os_name: cent-os-7-dcos-prereqs","path":"ci/launch_cluster.sh","position":10,"original_position":10,"commit_id":"a5e8d1f72c039781e00016cd79de5f53b0e7258e","original_commit_id":"a5e8d1f72c039781e00016cd79de5f53b0e7258e","user":{"login":"jeschkies","id":2418440,"node_id":"MDQ6VXNlcjI0MTg0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2418440?v=4","gravatar_id":"","url":"https://api.github.com/users/jeschkies","html_url":"https://github.com/jeschkies","followers_url":"https://api.github.com/users/jeschkies/followers","following_url":"https://api.github.com/users/jeschkies/following{/other_user}","gists_url":"https://api.github.com/users/jeschkies/gists{/gist_id}","starred_url":"https://api.github.com/users/jeschkies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeschkies/subscriptions","organizations_url":"https://api.github.com/users/jeschkies/orgs","repos_url":"https://api.github.com/users/jeschkies/repos","events_url":"https://api.github.com/users/jeschkies/events{/privacy}","received_events_url":"https://api.github.com/users/jeschkies/received_events","type":"User","site_admin":false},"body":"Nit: this should be line 45.","created_at":"2018-09-05T16:00:54Z","updated_at":"2018-09-05T16:03:23Z","html_url":"https://github.com/mesosphere/marathon/pull/5949#discussion_r215331044","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5949","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/215331044"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5949#discussion_r215331044"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5949"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/5949","id":165751012,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY1NzUxMDEy","html_url":"https://github.com/mesosphere/marathon/pull/5949","diff_url":"https://github.com/mesosphere/marathon/pull/5949.diff","patch_url":"https://github.com/mesosphere/marathon/pull/5949.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/5949","number":5949,"state":"open","locked":false,"title":"Hybrid Cloud: SI Tests","user":{"login":"wavesoft","id":883486,"node_id":"MDQ6VXNlcjg4MzQ4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/883486?v=4","gravatar_id":"","url":"https://api.github.com/users/wavesoft","html_url":"https://github.com/wavesoft","followers_url":"https://api.github.com/users/wavesoft/followers","following_url":"https://api.github.com/users/wavesoft/following{/other_user}","gists_url":"https://api.github.com/users/wavesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/wavesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavesoft/subscriptions","organizations_url":"https://api.github.com/users/wavesoft/orgs","repos_url":"https://api.github.com/users/wavesoft/repos","events_url":"https://api.github.com/users/wavesoft/events{/privacy}","received_events_url":"https://api.github.com/users/wavesoft/received_events","type":"User","site_admin":false},"body":"---\r\n~⚠️ **DO Review** but don't merge until #5982 is merged first~\r\n\r\n---\r\n\r\nThis PR introduces hybrid-cloud System Integration tests:\r\n\r\n- `marathon_common_tests.py::test_faultdomains_default` : Checks the behaviour of launching an app without fault domain constraints\r\n- `marathon_common_tests.py::test_faultdomains_region_only` : Checks the behaviour of launching an app with only `region` fixed \r\n- `marathon_common_tests.py::test_faultdomains_region_and_zone` : Checks the behaviour of launching an app with `region` and `zone` fixed\r\n- `marathon_common_tests.py::test_faultdomains_region_unique` : Checks the behaviour of the `[\"@region\", \"UNIQUE\"]` constraints\r\n- `marathon_common_tests.py::test_faultdomains_zone_unique` : Checks the behaviour of the `[\"@zone\", \"UNIQUE\"]` constraints\r\n\r\nThese tests are discovering the zones and regions of the cluster by asking the cluster's mesos leader. When launching a DC/OS cluster make sure that there is at least 1 remote region, bigger than the local region, having at least 2 zones each. For example:\r\n\r\n```yaml\r\nfault_domain_helper:\r\n  LocalZone:\r\n    num_zones: 2\r\n    num_private_agents: 2\r\n    local: true\r\n  RemoteZone:\r\n    num_zones: 3\r\n    num_public_agents: 1\r\n    num_private_agents: 2\r\n```\r\n\r\n_Related JIRA issue: [MARATHON_EE-1672](https://jira.mesosphere.com/browse/MARATHON_EE-1672)_\r\n\r\n## WIP Items\r\n\r\n* [x] Modify `dcos-launch` to start a multi-zone cluster on EE by default\r\n* [x] Figure out other constraints that needs to be tested","created_at":"2018-01-29T16:23:55Z","updated_at":"2018-09-05T16:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43a70b0b9975f4a24dad68a707e58727c60fb2fa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ichernetsky","id":96977,"node_id":"MDQ6VXNlcjk2OTc3","avatar_url":"https://avatars1.githubusercontent.com/u/96977?v=4","gravatar_id":"","url":"https://api.github.com/users/ichernetsky","html_url":"https://github.com/ichernetsky","followers_url":"https://api.github.com/users/ichernetsky/followers","following_url":"https://api.github.com/users/ichernetsky/following{/other_user}","gists_url":"https://api.github.com/users/ichernetsky/gists{/gist_id}","starred_url":"https://api.github.com/users/ichernetsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichernetsky/subscriptions","organizations_url":"https://api.github.com/users/ichernetsky/orgs","repos_url":"https://api.github.com/users/ichernetsky/repos","events_url":"https://api.github.com/users/ichernetsky/events{/privacy}","received_events_url":"https://api.github.com/users/ichernetsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5949/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5949/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/5949/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/a5e8d1f72c039781e00016cd79de5f53b0e7258e","head":{"label":"mesosphere:ic/tests/hybrid-cloud","ref":"ic/tests/hybrid-cloud","sha":"a5e8d1f72c039781e00016cd79de5f53b0e7258e","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-09-05T15:20:20Z","pushed_at":"2018-09-05T15:59:37Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":37976,"stargazers_count":3720,"watchers_count":3720,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":851,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":851,"open_issues":18,"watchers":3720,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"faead2763d8e41a5582e9855b929a0abaa9f050e","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-09-05T15:20:20Z","pushed_at":"2018-09-05T15:59:37Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":37976,"stargazers_count":3720,"watchers_count":3720,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":851,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":851,"open_issues":18,"watchers":3720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5949"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5949"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5949"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5949/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5949/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5949/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/a5e8d1f72c039781e00016cd79de5f53b0e7258e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jeschkies"}}