{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/22977","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/22977/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/22977/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/22977/events","html_url":"https://github.com/laravel/framework/pull/22977","id":293398069,"number":22977,"title":"[5.5] Fix void returns","user":{"login":"carusogabriel","id":16328050,"avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-01T04:13:53Z","updated_at":"2018-02-01T07:39:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/22977","html_url":"https://github.com/laravel/framework/pull/22977","diff_url":"https://github.com/laravel/framework/pull/22977.diff","patch_url":"https://github.com/laravel/framework/pull/22977.patch"},"body":"This PR fixes functions that have `void` returns documented, but return something actually.\r\n\r\nThere are other cases, but those will require logic change and I'll PR separately.\r\n\r\nThere were all found with [PHPStan](https://github.com/phpstan/phpstan) :smile: "},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/362183354","html_url":"https://github.com/laravel/framework/pull/22977#issuecomment-362183354","issue_url":"https://api.github.com/repos/laravel/framework/issues/22977","id":362183354,"user":{"login":"carusogabriel","id":16328050,"avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T07:39:55Z","updated_at":"2018-02-01T07:39:55Z","author_association":"CONTRIBUTOR","body":"> Are the phpdocs supposed to tell you what the code currently does; or what it is allowed to do?\r\n\r\n@sisve I guess is, as it is its purpose, right? Laravel is known by its awesome documentation, both inside and outside with the manual.\r\n\r\n> Perhaps you should target the upcoming 5.6 release instead?\r\n\r\nI'll leave with Taylor because I consider it as a bug-fix, not a new feature.\r\n\r\n> So even though the current version does not return any Response object, the return should still stay for the reason above (extending), I would suppose?\r\n\r\n@lagbox That's a good point, but if you are right, we should fix the phpDocs, not the code instead."}}
{"actor":{"display_login":"carusogabriel"}}