{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/comments/208043243","pull_request_review_id":143776929,"id":208043243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODA0MzI0Mw==","diff_hunk":"@@ -752,6 +753,30 @@ public Activity createActivityFromProcessor(Processor processor,\n \t\treturn activity;\n \t}\n \n+\tpublic Configuration createNestedRelationship(Processor processor, Workflow childWorkflow, Profile profile) {\n+\t\tif(processor.getParent() == null) {\n+\t\t\tthrow new IllegalStateException(\"Processor \" + processor + \" has no parent\");\n+\t\t}\n+\t\tif(processor.getParent().getParent() != childWorkflow.getParent()) {\n+\t\t\tthrow new IllegalStateException(\n+\t\t\t\t\t\"Processor \" + processor + \" and workflow \" + childWorkflow + \" are not in the same Workflow bundle\");\n+\t\t}\n+\t\tif(nestedWorkflowForProcessor(processor, profile) != null) {","path":"taverna-scufl2-api/src/main/java/org/apache/taverna/scufl2/api/common/Scufl2Tools.java","position":20,"original_position":20,"commit_id":"3efbf0857f0ed3c8d7fa8b52f45bdc73af2ff747","original_commit_id":"d93452d7ab30dc36bf0cabafe923ff3707bb0c55","user":{"login":"haouech","id":13291270,"node_id":"MDQ6VXNlcjEzMjkxMjcw","avatar_url":"https://avatars3.githubusercontent.com/u/13291270?v=4","gravatar_id":"","url":"https://api.github.com/users/haouech","html_url":"https://github.com/haouech","followers_url":"https://api.github.com/users/haouech/followers","following_url":"https://api.github.com/users/haouech/following{/other_user}","gists_url":"https://api.github.com/users/haouech/gists{/gist_id}","starred_url":"https://api.github.com/users/haouech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haouech/subscriptions","organizations_url":"https://api.github.com/users/haouech/orgs","repos_url":"https://api.github.com/users/haouech/repos","events_url":"https://api.github.com/users/haouech/events{/privacy}","received_events_url":"https://api.github.com/users/haouech/received_events","type":"User","site_admin":false},"body":"I see your point. I took advantage of the already thrown exceptions by the 'getActivity' method of Processor. Now we make sure that the processor has no activity bound to it before nesting the workflows.","created_at":"2018-08-06T22:03:35Z","updated_at":"2018-08-06T22:03:36Z","html_url":"https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208043243","pull_request_url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/comments/208043243"},"html":{"href":"https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208043243"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41"}},"in_reply_to_id":207915625},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41","id":204591175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTkxMTc1","html_url":"https://github.com/apache/incubator-taverna-language/pull/41","diff_url":"https://github.com/apache/incubator-taverna-language/pull/41.diff","patch_url":"https://github.com/apache/incubator-taverna-language/pull/41.patch","issue_url":"https://api.github.com/repos/apache/incubator-taverna-language/issues/41","number":41,"state":"open","locked":false,"title":"Add helper method to create nesting relationship between workflows","user":{"login":"haouech","id":13291270,"node_id":"MDQ6VXNlcjEzMjkxMjcw","avatar_url":"https://avatars3.githubusercontent.com/u/13291270?v=4","gravatar_id":"","url":"https://api.github.com/users/haouech","html_url":"https://github.com/haouech","followers_url":"https://api.github.com/users/haouech/followers","following_url":"https://api.github.com/users/haouech/following{/other_user}","gists_url":"https://api.github.com/users/haouech/gists{/gist_id}","starred_url":"https://api.github.com/users/haouech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haouech/subscriptions","organizations_url":"https://api.github.com/users/haouech/orgs","repos_url":"https://api.github.com/users/haouech/repos","events_url":"https://api.github.com/users/haouech/events{/privacy}","received_events_url":"https://api.github.com/users/haouech/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-28T12:29:33Z","updated_at":"2018-08-06T22:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"496ac0d7ce5db12246ac965f2668af5df14a4a56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-taverna-language/issues/41/comments","statuses_url":"https://api.github.com/repos/apache/incubator-taverna-language/statuses/3efbf0857f0ed3c8d7fa8b52f45bdc73af2ff747","head":{"label":"haouech:nested","ref":"nested","sha":"3efbf0857f0ed3c8d7fa8b52f45bdc73af2ff747","user":{"login":"haouech","id":13291270,"node_id":"MDQ6VXNlcjEzMjkxMjcw","avatar_url":"https://avatars3.githubusercontent.com/u/13291270?v=4","gravatar_id":"","url":"https://api.github.com/users/haouech","html_url":"https://github.com/haouech","followers_url":"https://api.github.com/users/haouech/followers","following_url":"https://api.github.com/users/haouech/following{/other_user}","gists_url":"https://api.github.com/users/haouech/gists{/gist_id}","starred_url":"https://api.github.com/users/haouech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haouech/subscriptions","organizations_url":"https://api.github.com/users/haouech/orgs","repos_url":"https://api.github.com/users/haouech/repos","events_url":"https://api.github.com/users/haouech/events{/privacy}","received_events_url":"https://api.github.com/users/haouech/received_events","type":"User","site_admin":false},"repo":{"id":133666405,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2NjY0MDU=","name":"incubator-taverna-language","full_name":"haouech/incubator-taverna-language","owner":{"login":"haouech","id":13291270,"node_id":"MDQ6VXNlcjEzMjkxMjcw","avatar_url":"https://avatars3.githubusercontent.com/u/13291270?v=4","gravatar_id":"","url":"https://api.github.com/users/haouech","html_url":"https://github.com/haouech","followers_url":"https://api.github.com/users/haouech/followers","following_url":"https://api.github.com/users/haouech/following{/other_user}","gists_url":"https://api.github.com/users/haouech/gists{/gist_id}","starred_url":"https://api.github.com/users/haouech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haouech/subscriptions","organizations_url":"https://api.github.com/users/haouech/orgs","repos_url":"https://api.github.com/users/haouech/repos","events_url":"https://api.github.com/users/haouech/events{/privacy}","received_events_url":"https://api.github.com/users/haouech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haouech/incubator-taverna-language","description":"Mirror of Apache Taverna Language (incubating)","fork":true,"url":"https://api.github.com/repos/haouech/incubator-taverna-language","forks_url":"https://api.github.com/repos/haouech/incubator-taverna-language/forks","keys_url":"https://api.github.com/repos/haouech/incubator-taverna-language/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haouech/incubator-taverna-language/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haouech/incubator-taverna-language/teams","hooks_url":"https://api.github.com/repos/haouech/incubator-taverna-language/hooks","issue_events_url":"https://api.github.com/repos/haouech/incubator-taverna-language/issues/events{/number}","events_url":"https://api.github.com/repos/haouech/incubator-taverna-language/events","assignees_url":"https://api.github.com/repos/haouech/incubator-taverna-language/assignees{/user}","branches_url":"https://api.github.com/repos/haouech/incubator-taverna-language/branches{/branch}","tags_url":"https://api.github.com/repos/haouech/incubator-taverna-language/tags","blobs_url":"https://api.github.com/repos/haouech/incubator-taverna-language/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haouech/incubator-taverna-language/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haouech/incubator-taverna-language/git/refs{/sha}","trees_url":"https://api.github.com/repos/haouech/incubator-taverna-language/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haouech/incubator-taverna-language/statuses/{sha}","languages_url":"https://api.github.com/repos/haouech/incubator-taverna-language/languages","stargazers_url":"https://api.github.com/repos/haouech/incubator-taverna-language/stargazers","contributors_url":"https://api.github.com/repos/haouech/incubator-taverna-language/contributors","subscribers_url":"https://api.github.com/repos/haouech/incubator-taverna-language/subscribers","subscription_url":"https://api.github.com/repos/haouech/incubator-taverna-language/subscription","commits_url":"https://api.github.com/repos/haouech/incubator-taverna-language/commits{/sha}","git_commits_url":"https://api.github.com/repos/haouech/incubator-taverna-language/git/commits{/sha}","comments_url":"https://api.github.com/repos/haouech/incubator-taverna-language/comments{/number}","issue_comment_url":"https://api.github.com/repos/haouech/incubator-taverna-language/issues/comments{/number}","contents_url":"https://api.github.com/repos/haouech/incubator-taverna-language/contents/{+path}","compare_url":"https://api.github.com/repos/haouech/incubator-taverna-language/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haouech/incubator-taverna-language/merges","archive_url":"https://api.github.com/repos/haouech/incubator-taverna-language/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haouech/incubator-taverna-language/downloads","issues_url":"https://api.github.com/repos/haouech/incubator-taverna-language/issues{/number}","pulls_url":"https://api.github.com/repos/haouech/incubator-taverna-language/pulls{/number}","milestones_url":"https://api.github.com/repos/haouech/incubator-taverna-language/milestones{/number}","notifications_url":"https://api.github.com/repos/haouech/incubator-taverna-language/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haouech/incubator-taverna-language/labels{/name}","releases_url":"https://api.github.com/repos/haouech/incubator-taverna-language/releases{/id}","deployments_url":"https://api.github.com/repos/haouech/incubator-taverna-language/deployments","created_at":"2018-05-16T13:01:11Z","updated_at":"2018-05-16T13:01:15Z","pushed_at":"2018-08-06T22:00:39Z","git_url":"git://github.com/haouech/incubator-taverna-language.git","ssh_url":"git@github.com:haouech/incubator-taverna-language.git","clone_url":"https://github.com/haouech/incubator-taverna-language.git","svn_url":"https://github.com/haouech/incubator-taverna-language","homepage":null,"size":16182,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a5251d10fac4f6ec811026400df987debbd43634","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30956940,"node_id":"MDEwOlJlcG9zaXRvcnkzMDk1Njk0MA==","name":"incubator-taverna-language","full_name":"apache/incubator-taverna-language","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-taverna-language","description":"Mirror of Apache Taverna Language (incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-taverna-language","forks_url":"https://api.github.com/repos/apache/incubator-taverna-language/forks","keys_url":"https://api.github.com/repos/apache/incubator-taverna-language/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-taverna-language/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-taverna-language/teams","hooks_url":"https://api.github.com/repos/apache/incubator-taverna-language/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-taverna-language/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-taverna-language/events","assignees_url":"https://api.github.com/repos/apache/incubator-taverna-language/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-taverna-language/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-taverna-language/tags","blobs_url":"https://api.github.com/repos/apache/incubator-taverna-language/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-taverna-language/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-taverna-language/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-taverna-language/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-taverna-language/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-taverna-language/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-taverna-language/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-taverna-language/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-taverna-language/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-taverna-language/subscription","commits_url":"https://api.github.com/repos/apache/incubator-taverna-language/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-taverna-language/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-taverna-language/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-taverna-language/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-taverna-language/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-taverna-language/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-taverna-language/merges","archive_url":"https://api.github.com/repos/apache/incubator-taverna-language/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-taverna-language/downloads","issues_url":"https://api.github.com/repos/apache/incubator-taverna-language/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-taverna-language/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-taverna-language/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-taverna-language/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-taverna-language/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-taverna-language/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-taverna-language/deployments","created_at":"2015-02-18T08:00:05Z","updated_at":"2018-08-06T15:23:02Z","pushed_at":"2018-08-06T22:00:40Z","git_url":"git://github.com/apache/incubator-taverna-language.git","ssh_url":"git@github.com:apache/incubator-taverna-language.git","clone_url":"https://github.com/apache/incubator-taverna-language.git","svn_url":"https://github.com/apache/incubator-taverna-language","homepage":null,"size":16160,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41"},"html":{"href":"https://github.com/apache/incubator-taverna-language/pull/41"},"issue":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/issues/41"},"comments":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-taverna-language/statuses/3efbf0857f0ed3c8d7fa8b52f45bdc73af2ff747"}},"author_association":"NONE"}}
{"actor":{"display_login":"haouech"}}