{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments/172691824","pull_request_review_id":101753199,"id":172691824,"diff_hunk":"@@ -499,17 +500,25 @@ impl CacheDev {\n                             dm: &DM,\n                             table: Vec<TargetLine<LinearDevTargetParams>>)\n                             -> DmResult<()> {\n+        // Follow resize_origin example in device-mapper-test-suite file\n+        // cache_stack.rb. This looks funky, but it does seem to be exactly\n+        // what the test is doing.","path":"src/cachedev.rs","position":23,"original_position":23,"commit_id":"518fc587b0c269d0424c765e6ba65d05406307b2","original_commit_id":"518fc587b0c269d0424c765e6ba65d05406307b2","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"body":"We do not want to resume self. See commit message in \"Do not resume\" commit and header comments for these methods.","created_at":"2018-03-06T23:08:24Z","updated_at":"2018-03-06T23:08:24Z","html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/283#discussion_r172691824","pull_request_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments/172691824"},"html":{"href":"https://github.com/stratis-storage/devicemapper-rs/pull/283#discussion_r172691824"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283"}},"in_reply_to_id":172653265},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283","id":172327739,"html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/283","diff_url":"https://github.com/stratis-storage/devicemapper-rs/pull/283.diff","patch_url":"https://github.com/stratis-storage/devicemapper-rs/pull/283.patch","issue_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/283","number":283,"state":"open","locked":false,"title":"Rewrite set_*_table methods","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-01T19:16:14Z","updated_at":"2018-03-06T23:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbab5350f5fde9e58374a1667ba0cfe25f2c466b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":570452650,"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/labels/review-final","name":"review-final","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/milestones/1","html_url":"https://github.com/stratis-storage/devicemapper-rs/milestone/1","labels_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/milestones/1/labels","id":2692649,"number":1,"title":"Stratis 0.5","description":"Tasks here that we want for Stratisd 0.5 release.","creator":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":14,"state":"open","created_at":"2017-08-09T19:19:12Z","updated_at":"2018-03-06T18:33:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/283/comments","statuses_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/518fc587b0c269d0424c765e6ba65d05406307b2","head":{"label":"mulkieran:master-suspend-2","ref":"master-suspend-2","sha":"518fc587b0c269d0424c765e6ba65d05406307b2","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"repo":{"id":86095047,"name":"devicemapper-rs","full_name":"mulkieran/devicemapper-rs","owner":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mulkieran/devicemapper-rs","description":"A Rust library for using Linux devicemapper","fork":true,"url":"https://api.github.com/repos/mulkieran/devicemapper-rs","forks_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/forks","keys_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/teams","hooks_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/hooks","issue_events_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/events","assignees_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/tags","blobs_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/languages","stargazers_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/stargazers","contributors_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/contributors","subscribers_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/subscribers","subscription_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/subscription","commits_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/merges","archive_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/downloads","issues_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/labels{/name}","releases_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/releases{/id}","deployments_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/deployments","created_at":"2017-03-24T17:40:16Z","updated_at":"2017-03-24T17:40:18Z","pushed_at":"2018-03-02T14:19:26Z","git_url":"git://github.com/mulkieran/devicemapper-rs.git","ssh_url":"git@github.com:mulkieran/devicemapper-rs.git","clone_url":"https://github.com/mulkieran/devicemapper-rs.git","svn_url":"https://github.com/mulkieran/devicemapper-rs","homepage":null,"size":2572,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"e393f970e2963d895f59c2b66ff2d4d9fb8aa5c8","user":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":41330009,"name":"devicemapper-rs","full_name":"stratis-storage/devicemapper-rs","owner":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/devicemapper-rs","description":"A Rust library for using Linux devicemapper","fork":false,"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs","forks_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/forks","keys_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/teams","hooks_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/events","assignees_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/tags","blobs_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/subscription","commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/merges","archive_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/downloads","issues_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/deployments","created_at":"2015-08-24T22:25:32Z","updated_at":"2018-02-21T17:05:15Z","pushed_at":"2018-03-02T14:19:27Z","git_url":"git://github.com/stratis-storage/devicemapper-rs.git","ssh_url":"git@github.com:stratis-storage/devicemapper-rs.git","clone_url":"https://github.com/stratis-storage/devicemapper-rs.git","svn_url":"https://github.com/stratis-storage/devicemapper-rs","homepage":null,"size":2439,"stargazers_count":19,"watchers_count":19,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":12,"open_issues":33,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283"},"html":{"href":"https://github.com/stratis-storage/devicemapper-rs/pull/283"},"issue":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/283"},"comments":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/518fc587b0c269d0424c765e6ba65d05406307b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mulkieran"}}