{"action":"created","issue":{"url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/470","repository_url":"https://api.github.com/repos/prescottprue/react-redux-firebase","labels_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/470/comments","events_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/470/events","html_url":"https://github.com/prescottprue/react-redux-firebase/issues/470","id":325035485,"number":470,"title":"feat(auth): updateProfileOnLogin for signInWithEmailAndPassword login (currently runs only for createUser)","user":{"login":"cgestes","id":49141,"avatar_url":"https://avatars3.githubusercontent.com/u/49141?v=4","gravatar_id":"","url":"https://api.github.com/users/cgestes","html_url":"https://github.com/cgestes","followers_url":"https://api.github.com/users/cgestes/followers","following_url":"https://api.github.com/users/cgestes/following{/other_user}","gists_url":"https://api.github.com/users/cgestes/gists{/gist_id}","starred_url":"https://api.github.com/users/cgestes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgestes/subscriptions","organizations_url":"https://api.github.com/users/cgestes/orgs","repos_url":"https://api.github.com/users/cgestes/repos","events_url":"https://api.github.com/users/cgestes/events{/privacy}","received_events_url":"https://api.github.com/users/cgestes/received_events","type":"User","site_admin":false},"labels":[{"id":461211429,"url":"https://api.github.com/repos/prescottprue/react-redux-firebase/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-21T19:42:31Z","updated_at":"2018-05-29T01:36:47Z","closed_at":null,"author_association":"NONE","body":"**What is the current behavior?**\r\n\r\nIt does not create the user profile.\r\n\r\nsee: https://github.com/prescottprue/react-redux-firebase/blob/master/src/actions/auth.js#L447\r\n```javascript\r\n    if (method === 'signInWithEmailAndPassword') {\r\n      return { user: userData };\r\n    }\r\n```\r\n\r\n**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via [codesandbox](https://codesandbox.io/) or similar.**\r\n\r\nTo reproduce, remove the user profile of someone already signup.\r\n\r\nCase where this can happens:\r\n- activating userProfile with already created users\r\n- switching between firebase and firestore for storing profiles\r\n- bugs..\r\n\r\n**What is the expected behavior?**\r\n\r\nI would expect the userProfile to be updated on login of the user, it ease the migration.\r\n\r\n\r\nFeel free to tell me how to help. I can author a patch if this is recognised as a bug.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/comments/392628892","html_url":"https://github.com/prescottprue/react-redux-firebase/issues/470#issuecomment-392628892","issue_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/470","id":392628892,"user":{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T01:36:47Z","updated_at":"2018-05-29T01:36:47Z","author_association":"OWNER","body":"@cgestes The original intention was to keep usage of `createUser` for email signup - my thought was that it would be unclear to mention that `login` creates a profile in RTDB, but not within the authentication tab. \r\n\r\nI think that this would remove some corner cases, so going to look into making the change. Open to a PR if you get a chance."}}
{"actor":{"display_login":"prescottprue"}}