{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/236333363","pull_request_review_id":178387745,"id":236333363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMzMzM2Mw==","diff_hunk":"@@ -18,11 +18,13 @@ import { injectable, inject, named } from 'inversify';\n import { ProcessManager } from './process-manager';\n import { ILogger } from '@theia/core/lib/common';\n import { Process, ProcessType, ProcessOptions } from './process';\n-import { ChildProcess, spawn } from 'child_process';\n+import { ChildProcess, spawn, fork } from 'child_process';\n import * as stream from 'stream';\n \n export const RawProcessOptions = Symbol('RawProcessOptions');\n export interface RawProcessOptions extends ProcessOptions {\n+    /** default: spawn */\n+    type?: 'spawn' | 'fork';","path":"packages/process/src/node/raw-process.ts","position":21,"original_position":11,"commit_id":"232b016a73201ef1bf61f983a7ec80f6a51996e8","original_commit_id":"b7afbddd6761f1d33b55df3e45b8db2651539e6e","user":{"login":"thegecko","id":61341,"node_id":"MDQ6VXNlcjYxMzQx","avatar_url":"https://avatars1.githubusercontent.com/u/61341?v=4","gravatar_id":"","url":"https://api.github.com/users/thegecko","html_url":"https://github.com/thegecko","followers_url":"https://api.github.com/users/thegecko/followers","following_url":"https://api.github.com/users/thegecko/following{/other_user}","gists_url":"https://api.github.com/users/thegecko/gists{/gist_id}","starred_url":"https://api.github.com/users/thegecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thegecko/subscriptions","organizations_url":"https://api.github.com/users/thegecko/orgs","repos_url":"https://api.github.com/users/thegecko/repos","events_url":"https://api.github.com/users/thegecko/events{/privacy}","received_events_url":"https://api.github.com/users/thegecko/received_events","type":"User","site_admin":false},"body":"boom!","created_at":"2018-11-26T16:43:51Z","updated_at":"2018-11-26T16:43:51Z","html_url":"https://github.com/theia-ide/theia/pull/3637#discussion_r236333363","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/3637","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/236333363"},"html":{"href":"https://github.com/theia-ide/theia/pull/3637#discussion_r236333363"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3637"}},"in_reply_to_id":236313801},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/3637","id":233605500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjA1NTAw","html_url":"https://github.com/theia-ide/theia/pull/3637","diff_url":"https://github.com/theia-ide/theia/pull/3637.diff","patch_url":"https://github.com/theia-ide/theia/pull/3637.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/3637","number":3637,"state":"open","locked":false,"title":"[process] Add ability to create a new node process by forking","user":{"login":"thegecko","id":61341,"node_id":"MDQ6VXNlcjYxMzQx","avatar_url":"https://avatars1.githubusercontent.com/u/61341?v=4","gravatar_id":"","url":"https://api.github.com/users/thegecko","html_url":"https://github.com/thegecko","followers_url":"https://api.github.com/users/thegecko/followers","following_url":"https://api.github.com/users/thegecko/following{/other_user}","gists_url":"https://api.github.com/users/thegecko/gists{/gist_id}","starred_url":"https://api.github.com/users/thegecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thegecko/subscriptions","organizations_url":"https://api.github.com/users/thegecko/orgs","repos_url":"https://api.github.com/users/thegecko/repos","events_url":"https://api.github.com/users/thegecko/events{/privacy}","received_events_url":"https://api.github.com/users/thegecko/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Rob Moran <rob.moran@arm.com>\r\n\r\nWhen running Theia on the desktop in electron, we have the need to create a new node process.\r\nWe would prefer to use the version of node shipped with electron rather than have our users install a new node instance.\r\n\r\nTherefore, this PR adds the ability to fork the main process.\r\n","created_at":"2018-11-26T15:51:01Z","updated_at":"2018-11-26T16:43:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"135916d9703083b3920d4229d0a736c4d03514d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kittaakos","id":1405703,"node_id":"MDQ6VXNlcjE0MDU3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/3637/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/3637/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/3637/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/232b016a73201ef1bf61f983a7ec80f6a51996e8","head":{"label":"theia-ide:process-fork","ref":"process-fork","sha":"232b016a73201ef1bf61f983a7ec80f6a51996e8","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-11-26T16:29:01Z","pushed_at":"2018-11-26T16:43:27Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":113688,"stargazers_count":1934,"watchers_count":1934,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":291,"open_issues":721,"watchers":1934,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"a5a5c3bf91267f7d25f3906e0e8134e93c6441de","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-11-26T16:29:01Z","pushed_at":"2018-11-26T16:43:27Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":113688,"stargazers_count":1934,"watchers_count":1934,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":291,"open_issues":721,"watchers":1934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3637"},"html":{"href":"https://github.com/theia-ide/theia/pull/3637"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3637"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3637/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3637/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3637/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/232b016a73201ef1bf61f983a7ec80f6a51996e8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"thegecko"}}