{"push_id":3012214641,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"de43225f110f9ef1af87fd3d8d2684743894362b","before":"f17e6e219eeb5e7c1f9ae72edd47bd651a36cfda","commits":[{"sha":"39c4178bbc28c8dc20bcc39cff3b881ad37ca717","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"Fix format of OF1.3 async_get_request in generated loxi code.\n\nThis implements the corresponding change to Loxi submitted here:\nhttps://github.com/floodlight/loxigen/pull/633","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/39c4178bbc28c8dc20bcc39cff3b881ad37ca717"},{"sha":"8c09498d2cbc54c629c6205c400d8c56806fafaf","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"Fix error for modifying a reserved group to OFPGMFC_UNKNOWN_GROUP.\n\nOF1.2 only specifies OFPGMFC_INVALID_GROUP for \"invalid group types\", not\nfor modifying a reserved group.  OFPGMFC_UNKNOWN_GROUP makes more sense,\nsince a reserved group doesn't exist as a group.","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/8c09498d2cbc54c629c6205c400d8c56806fafaf"},{"sha":"b580c0d710ccce0c940320c6b17b82fc9b0a17d5","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"Set OFPVID_PRESENT in set_field actions for vlan_vid in OF1.3.\n\nOpenFlow 1.3 section 7.2.5 \"Action Structures\" says:\n\n    The value in the payload of the OXM TLV must be valid, in particular\n    the OFPVID_PRESENT bit must be set in OXM_OF_VLAN_VID set-field\n    actions.\n\nThe PushVlanVid, PushVlanVidPcp, and SetVlanVid tests didn't do this and\nthus failed with OVS, which enforces this behavior.  This commit fixes the\nproblem.","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/b580c0d710ccce0c940320c6b17b82fc9b0a17d5"},{"sha":"34c678b58bfcb4f79d76592a6c77459ffa2ce4dd","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"OFPR_INVALID_TTL must not be enabled by default in OF1.3.\n\nOpenFlow 1.3 section 7.3.10 \"Set Asynchronous Configuration Message\" says:\n\n    In the absence of such switch configuration, the initial configuration\n    shall be:\n\n       * In the “master” or “equal” role, enable all OFPT_PACKET_IN\n         messages, except those with reason OFPR_INVALID_TTL, ...\n\nbut the actual test checked that all packet-in messages including\nOFPR_INVALID_TTL were enabled.  This fixes the problem.","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/34c678b58bfcb4f79d76592a6c77459ffa2ce4dd"},{"sha":"5731610d4ef49a559a6fa0abf237051d5a20d5fe","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"Use correct defaults for watch_port, watch_group in OF1.2, OF1.3.\n\nAll-1-bits mean \"don't watch anything\" but this code was using 0, which\ncauses errors.","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/5731610d4ef49a559a6fa0abf237051d5a20d5fe"},{"sha":"05a99de1399cd43d2c695ec1d91eba231cc48698","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"tests: Fix buffer_ids for adding flows in OF1.0.\n\nSeveral flow_mod messages for adding flows specified a zero buffer_id, but\n0xffffffff is the correct value when no buffer is to be used.","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/05a99de1399cd43d2c695ec1d91eba231cc48698"},{"sha":"562b0e30f7826c613c8d9aa9c1ae0f1750fa8f58","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"Avoid ambiguous case in pktact.DirectLlcPackets test for OF1.0.\n\nOpenFlow 1.0 section 3.4 \"Matching\" says:\n\n    A flow entry that specifies an Ethernet type of 0x05FF, matches all\n    Ethernet 802.2 frames without a SNAP header and those with SNAP headers\n    that do not have an OUI of 0x000000.\n\nThe two parts of the test changed in this patch are meant to check that\nsuch a match on Ethertype 0x5ff (aka OFP_DL_TYPE_NOT_ETH_TYPE) does not\nmatch a packet with a valid Ethertype that appears in a SNAP header.\nHowever, they in fact test against 0x0003 as the Ethertype, which is not\na valid Ethertype (the minimum valid Ethertype is 0x600).  The OpenFlow\n1.0 specification doesn't say anything about how to handle this case.\nOpen vSwitch chooses to treat it the same as the other non-Ethernet cases\nusing 0x5ff as the Ethertype.  Thus, the test fails due to an ambiguity.\n\nThis commit changes the test to one that uses a valid Ethertype (0x1234).","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/562b0e30f7826c613c8d9aa9c1ae0f1750fa8f58"},{"sha":"94895fd4960c02e986fb8122a0a1b7843fa4126e","author":{"name":"Ben Pfaff","email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org"},"message":"controller: Avoid ofp.message.bsn_error in OF1.2.\n\nbsn_error is only defined in OF1.3 and later but this code tried to use it\nin OF1.2 as well.  (OF1.2 is version 3, OF1.3 is version 4.)","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/94895fd4960c02e986fb8122a0a1b7843fa4126e"},{"sha":"de43225f110f9ef1af87fd3d8d2684743894362b","author":{"name":"Ken Chiang","email":"4323212caced304f6d4c1963c9646ed4fae37274@bigswitch.com"},"message":"Merge pull request #239 from blp/bugfixes\n\nBugfixes","distinct":true,"url":"https://api.github.com/repos/floodlight/oftest/commits/de43225f110f9ef1af87fd3d8d2684743894362b"}]}
{"actor":{"display_login":"kenchiang"}}