{"action":"created","issue":{"url":"https://api.github.com/repos/conan-io/conan/issues/2621","repository_url":"https://api.github.com/repos/conan-io/conan","labels_url":"https://api.github.com/repos/conan-io/conan/issues/2621/labels{/name}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/2621/comments","events_url":"https://api.github.com/repos/conan-io/conan/issues/2621/events","html_url":"https://github.com/conan-io/conan/pull/2621","id":305933418,"number":2621,"title":"adds tests for virtualenv generator and fixes export inconsistency","user":{"login":"niosHD","id":1627467,"avatar_url":"https://avatars1.githubusercontent.com/u/1627467?v=4","gravatar_id":"","url":"https://api.github.com/users/niosHD","html_url":"https://github.com/niosHD","followers_url":"https://api.github.com/users/niosHD/followers","following_url":"https://api.github.com/users/niosHD/following{/other_user}","gists_url":"https://api.github.com/users/niosHD/gists{/gist_id}","starred_url":"https://api.github.com/users/niosHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosHD/subscriptions","organizations_url":"https://api.github.com/users/niosHD/orgs","repos_url":"https://api.github.com/users/niosHD/repos","events_url":"https://api.github.com/users/niosHD/events{/privacy}","received_events_url":"https://api.github.com/users/niosHD/received_events","type":"User","site_admin":false},"labels":[{"id":822995659,"url":"https://api.github.com/repos/conan-io/conan/labels/contributor%20pr","name":"contributor pr","color":"f4ac27","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/45","html_url":"https://github.com/conan-io/conan/milestone/45","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/45/labels","id":3138860,"number":45,"title":"1.4","description":null,"creator":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":0,"state":"open","created_at":"2018-02-23T11:10:08Z","updated_at":"2018-04-23T10:30:58Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-03-16T13:46:16Z","updated_at":"2018-04-23T10:55:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/2621","html_url":"https://github.com/conan-io/conan/pull/2621","diff_url":"https://github.com/conan-io/conan/pull/2621.diff","patch_url":"https://github.com/conan-io/conan/pull/2621.patch"},"body":"As announced in #2556 this PR adds a simple test for the virtualenv generator and fixes the inconsistency regarding the export command. Given these tests, I will implement #2568 next. A little heads up, while doing so I will refactor the whole virtualenv generator which is very messy at the moment."},"comment":{"url":"https://api.github.com/repos/conan-io/conan/issues/comments/383535224","html_url":"https://github.com/conan-io/conan/pull/2621#issuecomment-383535224","issue_url":"https://api.github.com/repos/conan-io/conan/issues/2621","id":383535224,"user":{"login":"niosHD","id":1627467,"avatar_url":"https://avatars1.githubusercontent.com/u/1627467?v=4","gravatar_id":"","url":"https://api.github.com/users/niosHD","html_url":"https://github.com/niosHD","followers_url":"https://api.github.com/users/niosHD/followers","following_url":"https://api.github.com/users/niosHD/following{/other_user}","gists_url":"https://api.github.com/users/niosHD/gists{/gist_id}","starred_url":"https://api.github.com/users/niosHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosHD/subscriptions","organizations_url":"https://api.github.com/users/niosHD/orgs","repos_url":"https://api.github.com/users/niosHD/repos","events_url":"https://api.github.com/users/niosHD/events{/privacy}","received_events_url":"https://api.github.com/users/niosHD/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T10:55:14Z","updated_at":"2018-04-23T10:55:14Z","author_association":"CONTRIBUTOR","body":"You are welcome! A small warning though, the behavior requested in #2568 has to be re-evaluated based on the information I collected in #2638. Namely, the used `is_posix` check only works for the msys subsystem that I used during development. More work is required to generalize the behavior. Anyway, a review and some guidance on how to proceed is greatly appreciated."}}
{"actor":{"display_login":"niosHD"}}