{"action":"created","issue":{"url":"https://api.github.com/repos/steveicarus/iverilog/issues/213","repository_url":"https://api.github.com/repos/steveicarus/iverilog","labels_url":"https://api.github.com/repos/steveicarus/iverilog/issues/213/labels{/name}","comments_url":"https://api.github.com/repos/steveicarus/iverilog/issues/213/comments","events_url":"https://api.github.com/repos/steveicarus/iverilog/issues/213/events","html_url":"https://github.com/steveicarus/iverilog/pull/213","id":374603650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjY3NzIz","number":213,"title":"VPI search path updates","user":{"login":"alexforencich","id":508807,"node_id":"MDQ6VXNlcjUwODgwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/508807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexforencich","html_url":"https://github.com/alexforencich","followers_url":"https://api.github.com/users/alexforencich/followers","following_url":"https://api.github.com/users/alexforencich/following{/other_user}","gists_url":"https://api.github.com/users/alexforencich/gists{/gist_id}","starred_url":"https://api.github.com/users/alexforencich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexforencich/subscriptions","organizations_url":"https://api.github.com/users/alexforencich/orgs","repos_url":"https://api.github.com/users/alexforencich/repos","events_url":"https://api.github.com/users/alexforencich/events{/privacy}","received_events_url":"https://api.github.com/users/alexforencich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-27T04:06:24Z","updated_at":"2018-10-29T20:44:00Z","closed_at":"2018-10-29T20:36:58Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/steveicarus/iverilog/pulls/213","html_url":"https://github.com/steveicarus/iverilog/pull/213","diff_url":"https://github.com/steveicarus/iverilog/pull/213.diff","patch_url":"https://github.com/steveicarus/iverilog/pull/213.patch"},"body":"This patch does three main things. First, it reverses the order in which the internal path list is checked so that paths specified with -M are checked first and the default paths are checked last.  Second, it enforces the path count limit to prevent crashes.  Third, it implements the environment variable IVERILOG_VPI_MODULE_PATH to specify a colon-separated list of directories in which to look for VPI modules.  "},"comment":{"url":"https://api.github.com/repos/steveicarus/iverilog/issues/comments/434072365","html_url":"https://github.com/steveicarus/iverilog/pull/213#issuecomment-434072365","issue_url":"https://api.github.com/repos/steveicarus/iverilog/issues/213","id":434072365,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDA3MjM2NQ==","user":{"login":"martinwhitaker","id":4000916,"node_id":"MDQ6VXNlcjQwMDA5MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4000916?v=4","gravatar_id":"","url":"https://api.github.com/users/martinwhitaker","html_url":"https://github.com/martinwhitaker","followers_url":"https://api.github.com/users/martinwhitaker/followers","following_url":"https://api.github.com/users/martinwhitaker/following{/other_user}","gists_url":"https://api.github.com/users/martinwhitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/martinwhitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinwhitaker/subscriptions","organizations_url":"https://api.github.com/users/martinwhitaker/orgs","repos_url":"https://api.github.com/users/martinwhitaker/repos","events_url":"https://api.github.com/users/martinwhitaker/events{/privacy}","received_events_url":"https://api.github.com/users/martinwhitaker/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T20:44:00Z","updated_at":"2018-10-29T20:44:00Z","author_association":"COLLABORATOR","body":"OK, looks good apart from the '-M -' option having changed behaviour - it used to remove the default path. I've fixed that, although it's probably not needed now we put the default path last. I also took the opportunity to refactor the code for easier readability/maintainability.\r\n\r\nAs for indentation, if it was up to me, the hard tabs would have gone long ago. But it's Steve's project, so that's up to him."}}
{"actor":{"display_login":"martinwhitaker"}}