{"action":"closed","issue":{"url":"https://api.github.com/repos/bitstadium/HockeySDK-Windows/issues/99","repository_url":"https://api.github.com/repos/bitstadium/HockeySDK-Windows","labels_url":"https://api.github.com/repos/bitstadium/HockeySDK-Windows/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/bitstadium/HockeySDK-Windows/issues/99/comments","events_url":"https://api.github.com/repos/bitstadium/HockeySDK-Windows/issues/99/events","html_url":"https://github.com/bitstadium/HockeySDK-Windows/issues/99","id":200513380,"number":99,"title":"Propagation of unhandled error sometimes fails","user":{"login":"schuettecarsten","id":1275166,"avatar_url":"https://avatars2.githubusercontent.com/u/1275166?v=4","gravatar_id":"","url":"https://api.github.com/users/schuettecarsten","html_url":"https://github.com/schuettecarsten","followers_url":"https://api.github.com/users/schuettecarsten/followers","following_url":"https://api.github.com/users/schuettecarsten/following{/other_user}","gists_url":"https://api.github.com/users/schuettecarsten/gists{/gist_id}","starred_url":"https://api.github.com/users/schuettecarsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuettecarsten/subscriptions","organizations_url":"https://api.github.com/users/schuettecarsten/orgs","repos_url":"https://api.github.com/users/schuettecarsten/repos","events_url":"https://api.github.com/users/schuettecarsten/events{/privacy}","received_events_url":"https://api.github.com/users/schuettecarsten/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-12T23:54:13Z","updated_at":"2018-03-15T22:25:22Z","closed_at":"2018-03-15T22:25:22Z","author_association":"CONTRIBUTOR","body":"The propagation of unhandled error in `CoreApplication_UnhandledErrorDetected` sometimes fails and then very strange things are logged in Hockey. See below. Also, these kind of exceptions are logged twice, because they are processed twice by HockeySDK.\r\n\r\n```\r\nThread 2 Crashed:\r\n0   XXX.Uap10                        0x00007ffc6ef7f0d0 McgInterop.McgHelpers.ThrowFailed(Int32 hr, RuntimeTypeHandle typeHnd) in c:\\windows\\ServiceProfiles\\NetworkService\\appdata\\local\\packages\\appcompile-20170108-104557-8196\\ac\\Temp\\Ilc1112771177\\XXX.Uap10.McgInterop\\Helpers.g.cs at 6416:10\r\n1   XXX.Uap10                        0x00007ffc6f014b65 McgInterop.ComCallHelpers.ComCall__HRESULT($__ComObject __this, RuntimeTypeHandle __typeHnd, Int32 __targetIndex) in c:\\windows\\ServiceProfiles\\NetworkService\\appdata\\local\\packages\\appcompile-20170108-104557-8196\\ac\\Temp\\Ilc1112771177\\XXX.Uap10.McgInterop\\SharedStubs.g.cs at 271:5\r\n2   XXX.Uap10                        0x00007ffc6f014a8b McgInterop.ForwardComSharedStubs.Proc_<System.__Canon>(Void* InstParam, $__ComObject __this, Int32 __targetIndex) in c:\\windows\\ServiceProfiles\\NetworkService\\appdata\\local\\packages\\appcompile-20170108-104557-8196\\ac\\Temp\\Ilc1112771177\\XXX.Uap10.McgInterop\\SharedStubs.g.cs at 4983:4\r\n3   XXX.Uap10                        0x00007ffc6f46a3a8 Windows.ApplicationModel.Core.UnhandledError.Propagate() in c:\\windows\\ServiceProfiles\\NetworkService\\appdata\\local\\packages\\appcompile-20170108-104557-8196\\ac\\Temp\\Ilc1112771177\\XXX.Uap10.McgInterop\\SafeTypes.g.cs at 5849:4\r\n4   XXX.Uap10                        0x00007ffc6f4676dd Microsoft.HockeyApp.Extensibility.Windows.UnhandledExceptionTelemetryModule.CoreApplication_UnhandledErrorDetected(Object sender, $UnhandledErrorDetectedEventArgs e) in D:\\Projekte\\3rdParty\\HockeySDK-Windows\\Src\\Kit.UWP\\Services\\UnhandledExceptionTelemetryModule.cs at 201:17\r\n```\r\n\r\nAfter propagated exception is logged by HockeySDK, the exception mus be rethrows (to crash the app which is expected behaviour here):\r\n\r\n```\r\n                // if we don't throw exception - app will not be crashed. We need to throw to not change the app behavior.\r\n                // known issue: stack trace will contain SDK methods from now on.\r\n                throw;\r\n```\r\n\r\nBut this causes the exception to be logged again by the HockeySDK unhandled crash handlers. Maybe it's a better idea to throw a special exception type and sort in logging this out when the app crashes?"}}
{"actor":{"display_login":"schuettecarsten"}}