{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/tailor/pulls/comments/209448354","pull_request_review_id":145467802,"id":209448354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ0ODM1NA==","diff_hunk":"@@ -16,6 +16,20 @@ const hasValue = value => {\n     return false;\n };\n \n+const getFragmentAssetUris = (refs, assetSize) => {\n+    const scriptUris = [];\n+    const styleUris = [];\n+\n+    for (const ref of refs) {\n+        if (ref.rel === 'fragment-script') {","path":"lib/fragment.js","position":22,"original_position":22,"commit_id":"032abda96fcb3618d8550d1e98e102e21c0340a2","original_commit_id":"032abda96fcb3618d8550d1e98e102e21c0340a2","user":{"login":"ruiaraujo","id":303833,"node_id":"MDQ6VXNlcjMwMzgzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/303833?v=4","gravatar_id":"","url":"https://api.github.com/users/ruiaraujo","html_url":"https://github.com/ruiaraujo","followers_url":"https://api.github.com/users/ruiaraujo/followers","following_url":"https://api.github.com/users/ruiaraujo/following{/other_user}","gists_url":"https://api.github.com/users/ruiaraujo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruiaraujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruiaraujo/subscriptions","organizations_url":"https://api.github.com/users/ruiaraujo/orgs","repos_url":"https://api.github.com/users/ruiaraujo/repos","events_url":"https://api.github.com/users/ruiaraujo/events{/privacy}","received_events_url":"https://api.github.com/users/ruiaraujo/received_events","type":"User","site_admin":false},"body":"Do we have tests for this filtering behaviour?","created_at":"2018-08-12T08:59:11Z","updated_at":"2018-08-12T08:59:12Z","html_url":"https://github.com/zalando/tailor/pull/248#discussion_r209448354","pull_request_url":"https://api.github.com/repos/zalando/tailor/pulls/248","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zalando/tailor/pulls/comments/209448354"},"html":{"href":"https://github.com/zalando/tailor/pull/248#discussion_r209448354"},"pull_request":{"href":"https://api.github.com/repos/zalando/tailor/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/tailor/pulls/248","id":207808438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODA4NDM4","html_url":"https://github.com/zalando/tailor/pull/248","diff_url":"https://github.com/zalando/tailor/pull/248.diff","patch_url":"https://github.com/zalando/tailor/pull/248.patch","issue_url":"https://api.github.com/repos/zalando/tailor/issues/248","number":248,"state":"open","locked":false,"title":"(perf): improve parsing of link header from fragments","user":{"login":"vigneshshanmugam","id":3902525,"node_id":"MDQ6VXNlcjM5MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3902525?v=4","gravatar_id":"","url":"https://api.github.com/users/vigneshshanmugam","html_url":"https://github.com/vigneshshanmugam","followers_url":"https://api.github.com/users/vigneshshanmugam/followers","following_url":"https://api.github.com/users/vigneshshanmugam/following{/other_user}","gists_url":"https://api.github.com/users/vigneshshanmugam/gists{/gist_id}","starred_url":"https://api.github.com/users/vigneshshanmugam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vigneshshanmugam/subscriptions","organizations_url":"https://api.github.com/users/vigneshshanmugam/orgs","repos_url":"https://api.github.com/users/vigneshshanmugam/repos","events_url":"https://api.github.com/users/vigneshshanmugam/events{/privacy}","received_events_url":"https://api.github.com/users/vigneshshanmugam/received_events","type":"User","site_admin":false},"body":"+ Roll our own fine tuned parse link header implementation based on https://github.com/thlorenz/parse-link-header\r\n+ Avoid double parsing of link headers on fragment response and while preloading\r\n+ Keep fragment object shape static","created_at":"2018-08-12T07:17:21Z","updated_at":"2018-08-12T08:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbbd2c7a262daa6fbe10b458617a164b69505e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mo-gr","id":95577,"node_id":"MDQ6VXNlcjk1NTc3","avatar_url":"https://avatars2.githubusercontent.com/u/95577?v=4","gravatar_id":"","url":"https://api.github.com/users/mo-gr","html_url":"https://github.com/mo-gr","followers_url":"https://api.github.com/users/mo-gr/followers","following_url":"https://api.github.com/users/mo-gr/following{/other_user}","gists_url":"https://api.github.com/users/mo-gr/gists{/gist_id}","starred_url":"https://api.github.com/users/mo-gr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mo-gr/subscriptions","organizations_url":"https://api.github.com/users/mo-gr/orgs","repos_url":"https://api.github.com/users/mo-gr/repos","events_url":"https://api.github.com/users/mo-gr/events{/privacy}","received_events_url":"https://api.github.com/users/mo-gr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/tailor/pulls/248/commits","review_comments_url":"https://api.github.com/repos/zalando/tailor/pulls/248/comments","review_comment_url":"https://api.github.com/repos/zalando/tailor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/tailor/issues/248/comments","statuses_url":"https://api.github.com/repos/zalando/tailor/statuses/032abda96fcb3618d8550d1e98e102e21c0340a2","head":{"label":"zalando:perf-1","ref":"perf-1","sha":"032abda96fcb3618d8550d1e98e102e21c0340a2","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":50101496,"node_id":"MDEwOlJlcG9zaXRvcnk1MDEwMTQ5Ng==","name":"tailor","full_name":"zalando/tailor","owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/tailor","description":"A streaming layout service for front-end microservices","fork":false,"url":"https://api.github.com/repos/zalando/tailor","forks_url":"https://api.github.com/repos/zalando/tailor/forks","keys_url":"https://api.github.com/repos/zalando/tailor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/tailor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/tailor/teams","hooks_url":"https://api.github.com/repos/zalando/tailor/hooks","issue_events_url":"https://api.github.com/repos/zalando/tailor/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/tailor/events","assignees_url":"https://api.github.com/repos/zalando/tailor/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/tailor/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/tailor/tags","blobs_url":"https://api.github.com/repos/zalando/tailor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/tailor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/tailor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/tailor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/tailor/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/tailor/languages","stargazers_url":"https://api.github.com/repos/zalando/tailor/stargazers","contributors_url":"https://api.github.com/repos/zalando/tailor/contributors","subscribers_url":"https://api.github.com/repos/zalando/tailor/subscribers","subscription_url":"https://api.github.com/repos/zalando/tailor/subscription","commits_url":"https://api.github.com/repos/zalando/tailor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/tailor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/tailor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/tailor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/tailor/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/tailor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/tailor/merges","archive_url":"https://api.github.com/repos/zalando/tailor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/tailor/downloads","issues_url":"https://api.github.com/repos/zalando/tailor/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/tailor/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/tailor/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/tailor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/tailor/labels{/name}","releases_url":"https://api.github.com/repos/zalando/tailor/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/tailor/deployments","created_at":"2016-01-21T10:55:04Z","updated_at":"2018-08-11T08:42:04Z","pushed_at":"2018-08-12T08:54:11Z","git_url":"git://github.com/zalando/tailor.git","ssh_url":"git@github.com:zalando/tailor.git","clone_url":"https://github.com/zalando/tailor.git","svn_url":"https://github.com/zalando/tailor","homepage":"http://www.mosaic9.org","size":658,"stargazers_count":686,"watchers_count":686,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":13,"watchers":686,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"d05e816394d3d2042445a5246c0c6f7368abf0e0","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":50101496,"node_id":"MDEwOlJlcG9zaXRvcnk1MDEwMTQ5Ng==","name":"tailor","full_name":"zalando/tailor","owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/tailor","description":"A streaming layout service for front-end microservices","fork":false,"url":"https://api.github.com/repos/zalando/tailor","forks_url":"https://api.github.com/repos/zalando/tailor/forks","keys_url":"https://api.github.com/repos/zalando/tailor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/tailor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/tailor/teams","hooks_url":"https://api.github.com/repos/zalando/tailor/hooks","issue_events_url":"https://api.github.com/repos/zalando/tailor/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/tailor/events","assignees_url":"https://api.github.com/repos/zalando/tailor/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/tailor/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/tailor/tags","blobs_url":"https://api.github.com/repos/zalando/tailor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/tailor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/tailor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/tailor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/tailor/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/tailor/languages","stargazers_url":"https://api.github.com/repos/zalando/tailor/stargazers","contributors_url":"https://api.github.com/repos/zalando/tailor/contributors","subscribers_url":"https://api.github.com/repos/zalando/tailor/subscribers","subscription_url":"https://api.github.com/repos/zalando/tailor/subscription","commits_url":"https://api.github.com/repos/zalando/tailor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/tailor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/tailor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/tailor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/tailor/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/tailor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/tailor/merges","archive_url":"https://api.github.com/repos/zalando/tailor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/tailor/downloads","issues_url":"https://api.github.com/repos/zalando/tailor/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/tailor/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/tailor/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/tailor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/tailor/labels{/name}","releases_url":"https://api.github.com/repos/zalando/tailor/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/tailor/deployments","created_at":"2016-01-21T10:55:04Z","updated_at":"2018-08-11T08:42:04Z","pushed_at":"2018-08-12T08:54:11Z","git_url":"git://github.com/zalando/tailor.git","ssh_url":"git@github.com:zalando/tailor.git","clone_url":"https://github.com/zalando/tailor.git","svn_url":"https://github.com/zalando/tailor","homepage":"http://www.mosaic9.org","size":658,"stargazers_count":686,"watchers_count":686,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":13,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/tailor/pulls/248"},"html":{"href":"https://github.com/zalando/tailor/pull/248"},"issue":{"href":"https://api.github.com/repos/zalando/tailor/issues/248"},"comments":{"href":"https://api.github.com/repos/zalando/tailor/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/tailor/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/tailor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/tailor/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/tailor/statuses/032abda96fcb3618d8550d1e98e102e21c0340a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ruiaraujo"}}