{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/24610","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/24610/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/24610/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/24610/events","html_url":"https://github.com/odoo/odoo/pull/24610","id":320838952,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2Mzc3MzEy","number":24610,"title":"[FIX] pos: reconciliation and performance issues","user":{"login":"dbo-odoo","id":9530767,"node_id":"MDQ6VXNlcjk1MzA3Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/9530767?v=4","gravatar_id":"","url":"https://api.github.com/users/dbo-odoo","html_url":"https://github.com/dbo-odoo","followers_url":"https://api.github.com/users/dbo-odoo/followers","following_url":"https://api.github.com/users/dbo-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbo-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbo-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbo-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbo-odoo/orgs","repos_url":"https://api.github.com/users/dbo-odoo/repos","events_url":"https://api.github.com/users/dbo-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbo-odoo/received_events","type":"User","site_admin":false},"labels":[{"id":106174181,"node_id":"MDU6TGFiZWwxMDYxNzQxODE=","url":"https://api.github.com/repos/odoo/odoo/labels/OE","name":"OE","color":"a24689","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-05-07T15:01:45Z","updated_at":"2018-09-10T11:43:15Z","closed_at":"2018-06-06T08:09:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/24610","html_url":"https://github.com/odoo/odoo/pull/24610","diff_url":"https://github.com/odoo/odoo/pull/24610.diff","patch_url":"https://github.com/odoo/odoo/pull/24610.patch"},"body":"Before this commit, the complete list of orders of the pos session\r\nwas processed through the reconciliation mechanism to check if an\r\nautomatic reconciliation was possible (introduced in a controversial\r\n'bug fix' at fe70f07, itself a backport of a master commit at\r\na2319b4). The goal of this auto-reconciliation was to avoid potentially\r\nsilent and numerous customer statements that could be reconciled\r\nautomatically.\r\n\r\nThis is mostly useless in a lot of cases, since a lot of users do not\r\nset any partner_id value on the pos order - there is nothing useful to\r\nreconcile. Going through the whole list of orders is time-wasting\r\n(especially since the reconciliation method does not scale well).\r\n\r\nCombine this with users who do not close their POS session often enough\r\nand closing a session can suddenly take up to several hours to process\r\ninstead of several seconds with practically no obvious gain.\r\n\r\nAfter this commit, only orders which have a partner set on them will be\r\nauto-reconciled.\r\n\r\nopw-1818838 and opw-1817172"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/419884252","html_url":"https://github.com/odoo/odoo/pull/24610#issuecomment-419884252","issue_url":"https://api.github.com/repos/odoo/odoo/issues/24610","id":419884252,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTg4NDI1Mg==","user":{"login":"kebeclibre","id":17759223,"node_id":"MDQ6VXNlcjE3NzU5MjIz","avatar_url":"https://avatars3.githubusercontent.com/u/17759223?v=4","gravatar_id":"","url":"https://api.github.com/users/kebeclibre","html_url":"https://github.com/kebeclibre","followers_url":"https://api.github.com/users/kebeclibre/followers","following_url":"https://api.github.com/users/kebeclibre/following{/other_user}","gists_url":"https://api.github.com/users/kebeclibre/gists{/gist_id}","starred_url":"https://api.github.com/users/kebeclibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kebeclibre/subscriptions","organizations_url":"https://api.github.com/users/kebeclibre/orgs","repos_url":"https://api.github.com/users/kebeclibre/repos","events_url":"https://api.github.com/users/kebeclibre/events{/privacy}","received_events_url":"https://api.github.com/users/kebeclibre/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T11:43:15Z","updated_at":"2018-09-10T11:43:15Z","author_association":"CONTRIBUTOR","body":"@Cedric-Pigeon \r\nIt is not a \"feature\", rather it was a courtesy fix.\r\nBesides, as I told you, there is no way to match orders move lines with payments one to one."}}
{"actor":{"display_login":"kebeclibre"}}