{"action":"closed","number":719,"pull_request":{"url":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719","id":223619271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjE5Mjcx","html_url":"https://github.com/tediousjs/node-mssql/pull/719","diff_url":"https://github.com/tediousjs/node-mssql/pull/719.diff","patch_url":"https://github.com/tediousjs/node-mssql/pull/719.patch","issue_url":"https://api.github.com/repos/tediousjs/node-mssql/issues/719","number":719,"state":"closed","locked":false,"title":"FIX Pool depletion bug resolution","user":{"login":"dhensby","id":563596,"node_id":"MDQ6VXNlcjU2MzU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/563596?v=4","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"body":"see: #614 \r\n\r\nThis fixes a problem where connection pools are depleted, apparently because the end event can be fired before the connect and this results in a double promise resolution. This is patched by ensuring only allowing one call to either `resolve` or `reject`","created_at":"2018-10-17T14:08:59Z","updated_at":"2018-10-18T10:14:03Z","closed_at":"2018-10-18T10:14:02Z","merged_at":null,"merge_commit_sha":"5988721a0ba54560ccc252ed4a93ffab09e768df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719/commits","review_comments_url":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719/comments","review_comment_url":"https://api.github.com/repos/tediousjs/node-mssql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tediousjs/node-mssql/issues/719/comments","statuses_url":"https://api.github.com/repos/tediousjs/node-mssql/statuses/363c5969c93cc2fa83b6c6b21cec5e8a0731c118","head":{"label":"dhensby:pulls/fix-pool-depletion-again","ref":"pulls/fix-pool-depletion-again","sha":"363c5969c93cc2fa83b6c6b21cec5e8a0731c118","user":{"login":"dhensby","id":563596,"node_id":"MDQ6VXNlcjU2MzU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/563596?v=4","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"repo":{"id":153463469,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0NjM0Njk=","name":"node-mssql","full_name":"dhensby/node-mssql","private":false,"owner":{"login":"dhensby","id":563596,"node_id":"MDQ6VXNlcjU2MzU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/563596?v=4","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhensby/node-mssql","description":"Microsoft SQL Server client for Node.js","fork":true,"url":"https://api.github.com/repos/dhensby/node-mssql","forks_url":"https://api.github.com/repos/dhensby/node-mssql/forks","keys_url":"https://api.github.com/repos/dhensby/node-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhensby/node-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhensby/node-mssql/teams","hooks_url":"https://api.github.com/repos/dhensby/node-mssql/hooks","issue_events_url":"https://api.github.com/repos/dhensby/node-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/dhensby/node-mssql/events","assignees_url":"https://api.github.com/repos/dhensby/node-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/dhensby/node-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/dhensby/node-mssql/tags","blobs_url":"https://api.github.com/repos/dhensby/node-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhensby/node-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhensby/node-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhensby/node-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhensby/node-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/dhensby/node-mssql/languages","stargazers_url":"https://api.github.com/repos/dhensby/node-mssql/stargazers","contributors_url":"https://api.github.com/repos/dhensby/node-mssql/contributors","subscribers_url":"https://api.github.com/repos/dhensby/node-mssql/subscribers","subscription_url":"https://api.github.com/repos/dhensby/node-mssql/subscription","commits_url":"https://api.github.com/repos/dhensby/node-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhensby/node-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhensby/node-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhensby/node-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhensby/node-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/dhensby/node-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhensby/node-mssql/merges","archive_url":"https://api.github.com/repos/dhensby/node-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhensby/node-mssql/downloads","issues_url":"https://api.github.com/repos/dhensby/node-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/dhensby/node-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/dhensby/node-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/dhensby/node-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhensby/node-mssql/labels{/name}","releases_url":"https://api.github.com/repos/dhensby/node-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/dhensby/node-mssql/deployments","created_at":"2018-10-17T13:39:35Z","updated_at":"2018-10-18T10:07:42Z","pushed_at":"2018-10-18T10:08:55Z","git_url":"git://github.com/dhensby/node-mssql.git","ssh_url":"git@github.com:dhensby/node-mssql.git","clone_url":"https://github.com/dhensby/node-mssql.git","svn_url":"https://github.com/dhensby/node-mssql","homepage":"https://tediousjs.github.io/node-mssql","size":1092,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tediousjs:master","ref":"master","sha":"7f374a8d73b00b17aa5b5ea5621c4314fc6e2daa","user":{"login":"tediousjs","id":20347522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ3NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/20347522?v=4","gravatar_id":"","url":"https://api.github.com/users/tediousjs","html_url":"https://github.com/tediousjs","followers_url":"https://api.github.com/users/tediousjs/followers","following_url":"https://api.github.com/users/tediousjs/following{/other_user}","gists_url":"https://api.github.com/users/tediousjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tediousjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tediousjs/subscriptions","organizations_url":"https://api.github.com/users/tediousjs/orgs","repos_url":"https://api.github.com/users/tediousjs/repos","events_url":"https://api.github.com/users/tediousjs/events{/privacy}","received_events_url":"https://api.github.com/users/tediousjs/received_events","type":"Organization","site_admin":false},"repo":{"id":12028300,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyODMwMA==","name":"node-mssql","full_name":"tediousjs/node-mssql","private":false,"owner":{"login":"tediousjs","id":20347522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ3NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/20347522?v=4","gravatar_id":"","url":"https://api.github.com/users/tediousjs","html_url":"https://github.com/tediousjs","followers_url":"https://api.github.com/users/tediousjs/followers","following_url":"https://api.github.com/users/tediousjs/following{/other_user}","gists_url":"https://api.github.com/users/tediousjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tediousjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tediousjs/subscriptions","organizations_url":"https://api.github.com/users/tediousjs/orgs","repos_url":"https://api.github.com/users/tediousjs/repos","events_url":"https://api.github.com/users/tediousjs/events{/privacy}","received_events_url":"https://api.github.com/users/tediousjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tediousjs/node-mssql","description":"Microsoft SQL Server client for Node.js","fork":false,"url":"https://api.github.com/repos/tediousjs/node-mssql","forks_url":"https://api.github.com/repos/tediousjs/node-mssql/forks","keys_url":"https://api.github.com/repos/tediousjs/node-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tediousjs/node-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tediousjs/node-mssql/teams","hooks_url":"https://api.github.com/repos/tediousjs/node-mssql/hooks","issue_events_url":"https://api.github.com/repos/tediousjs/node-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/tediousjs/node-mssql/events","assignees_url":"https://api.github.com/repos/tediousjs/node-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/tediousjs/node-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/tediousjs/node-mssql/tags","blobs_url":"https://api.github.com/repos/tediousjs/node-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tediousjs/node-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tediousjs/node-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/tediousjs/node-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tediousjs/node-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/tediousjs/node-mssql/languages","stargazers_url":"https://api.github.com/repos/tediousjs/node-mssql/stargazers","contributors_url":"https://api.github.com/repos/tediousjs/node-mssql/contributors","subscribers_url":"https://api.github.com/repos/tediousjs/node-mssql/subscribers","subscription_url":"https://api.github.com/repos/tediousjs/node-mssql/subscription","commits_url":"https://api.github.com/repos/tediousjs/node-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/tediousjs/node-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/tediousjs/node-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/tediousjs/node-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/tediousjs/node-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/tediousjs/node-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tediousjs/node-mssql/merges","archive_url":"https://api.github.com/repos/tediousjs/node-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tediousjs/node-mssql/downloads","issues_url":"https://api.github.com/repos/tediousjs/node-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/tediousjs/node-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/tediousjs/node-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/tediousjs/node-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tediousjs/node-mssql/labels{/name}","releases_url":"https://api.github.com/repos/tediousjs/node-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/tediousjs/node-mssql/deployments","created_at":"2013-08-10T23:12:35Z","updated_at":"2018-10-17T21:42:03Z","pushed_at":"2018-10-18T10:08:59Z","git_url":"git://github.com/tediousjs/node-mssql.git","ssh_url":"git@github.com:tediousjs/node-mssql.git","clone_url":"https://github.com/tediousjs/node-mssql.git","svn_url":"https://github.com/tediousjs/node-mssql","homepage":"https://tediousjs.github.io/node-mssql","size":1106,"stargazers_count":1321,"watchers_count":1321,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":226,"license":null,"forks":309,"open_issues":226,"watchers":1321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719"},"html":{"href":"https://github.com/tediousjs/node-mssql/pull/719"},"issue":{"href":"https://api.github.com/repos/tediousjs/node-mssql/issues/719"},"comments":{"href":"https://api.github.com/repos/tediousjs/node-mssql/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/tediousjs/node-mssql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tediousjs/node-mssql/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/tediousjs/node-mssql/statuses/363c5969c93cc2fa83b6c6b21cec5e8a0731c118"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":29,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"dhensby"}}