{"action":"created","comment":{"url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/comments/245043212","pull_request_review_id":189068074,"id":245043212,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA0MzIxMg==","diff_hunk":"@@ -29,6 +29,15 @@ export interface GuidedTour {\n     skipCallback?: (stepSkippedOn: number) => void;\n     /** Function will be called when tour is completed */\n     completeCallback?: () => void;\n+    /** Minimum size of screen in pixels before the tour is run, if the tour is resized below this value the user will be told to resize */\n+    minimumScreenSize?: number;\n+}\n+\n+export interface OrientationConfiguration {\n+    /** Where the tour step will appear next to the selected element */\n+    orientationDirection: Orientation,\n+    /** When this orientation configuration starts in pixels */\n+    startSize?: number","path":"src/guided-tour.constants.ts","position":21,"original_position":21,"commit_id":"d81dcf83149900b67a052401ac15d1fd1f76d191","original_commit_id":"d81dcf83149900b67a052401ac15d1fd1f76d191","user":{"login":"RobertCMusk","id":5100147,"node_id":"MDQ6VXNlcjUxMDAxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5100147?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertCMusk","html_url":"https://github.com/RobertCMusk","followers_url":"https://api.github.com/users/RobertCMusk/followers","following_url":"https://api.github.com/users/RobertCMusk/following{/other_user}","gists_url":"https://api.github.com/users/RobertCMusk/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertCMusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertCMusk/subscriptions","organizations_url":"https://api.github.com/users/RobertCMusk/orgs","repos_url":"https://api.github.com/users/RobertCMusk/repos","events_url":"https://api.github.com/users/RobertCMusk/events{/privacy}","received_events_url":"https://api.github.com/users/RobertCMusk/received_events","type":"User","site_admin":false},"body":"It is not the minimum size though it is when that config starts, so if it is set to 1000 then at 1000px and below it uses that config.","created_at":"2019-01-03T15:53:19Z","updated_at":"2019-01-03T15:53:20Z","html_url":"https://github.com/lsqlabs/ngx-guided-tour/pull/4#discussion_r245043212","pull_request_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/comments/245043212"},"html":{"href":"https://github.com/lsqlabs/ngx-guided-tour/pull/4#discussion_r245043212"},"pull_request":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4"}},"in_reply_to_id":245028445},"pull_request":{"url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4","id":242005625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDA1NjI1","html_url":"https://github.com/lsqlabs/ngx-guided-tour/pull/4","diff_url":"https://github.com/lsqlabs/ngx-guided-tour/pull/4.diff","patch_url":"https://github.com/lsqlabs/ngx-guided-tour/pull/4.patch","issue_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/4","number":4,"state":"open","locked":false,"title":"[ch6328] Add position configuration and minimum size for tours","user":{"login":"RobertCMusk","id":5100147,"node_id":"MDQ6VXNlcjUxMDAxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5100147?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertCMusk","html_url":"https://github.com/RobertCMusk","followers_url":"https://api.github.com/users/RobertCMusk/followers","following_url":"https://api.github.com/users/RobertCMusk/following{/other_user}","gists_url":"https://api.github.com/users/RobertCMusk/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertCMusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertCMusk/subscriptions","organizations_url":"https://api.github.com/users/RobertCMusk/orgs","repos_url":"https://api.github.com/users/RobertCMusk/repos","events_url":"https://api.github.com/users/RobertCMusk/events{/privacy}","received_events_url":"https://api.github.com/users/RobertCMusk/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-01-03T14:12:44Z","updated_at":"2019-01-03T15:53:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c070a45bc06906a7eb1c0f4e34a60d4c85a51dbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4/commits","review_comments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4/comments","review_comment_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/4/comments","statuses_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/statuses/d81dcf83149900b67a052401ac15d1fd1f76d191","head":{"label":"lsqlabs:rmusk/ch6328/small-size-support","ref":"rmusk/ch6328/small-size-support","sha":"d81dcf83149900b67a052401ac15d1fd1f76d191","user":{"login":"lsqlabs","id":38542019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQyMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/38542019?v=4","gravatar_id":"","url":"https://api.github.com/users/lsqlabs","html_url":"https://github.com/lsqlabs","followers_url":"https://api.github.com/users/lsqlabs/followers","following_url":"https://api.github.com/users/lsqlabs/following{/other_user}","gists_url":"https://api.github.com/users/lsqlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lsqlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsqlabs/subscriptions","organizations_url":"https://api.github.com/users/lsqlabs/orgs","repos_url":"https://api.github.com/users/lsqlabs/repos","events_url":"https://api.github.com/users/lsqlabs/events{/privacy}","received_events_url":"https://api.github.com/users/lsqlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":146001701,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDE3MDE=","name":"ngx-guided-tour","full_name":"lsqlabs/ngx-guided-tour","private":false,"owner":{"login":"lsqlabs","id":38542019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQyMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/38542019?v=4","gravatar_id":"","url":"https://api.github.com/users/lsqlabs","html_url":"https://github.com/lsqlabs","followers_url":"https://api.github.com/users/lsqlabs/followers","following_url":"https://api.github.com/users/lsqlabs/following{/other_user}","gists_url":"https://api.github.com/users/lsqlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lsqlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsqlabs/subscriptions","organizations_url":"https://api.github.com/users/lsqlabs/orgs","repos_url":"https://api.github.com/users/lsqlabs/repos","events_url":"https://api.github.com/users/lsqlabs/events{/privacy}","received_events_url":"https://api.github.com/users/lsqlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsqlabs/ngx-guided-tour","description":null,"fork":false,"url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour","forks_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/forks","keys_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/teams","hooks_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/hooks","issue_events_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/events{/number}","events_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/events","assignees_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/assignees{/user}","branches_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/branches{/branch}","tags_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/tags","blobs_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/statuses/{sha}","languages_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/languages","stargazers_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/stargazers","contributors_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/contributors","subscribers_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/subscribers","subscription_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/subscription","commits_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/contents/{+path}","compare_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/merges","archive_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/downloads","issues_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues{/number}","pulls_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls{/number}","milestones_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/milestones{/number}","notifications_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/labels{/name}","releases_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/releases{/id}","deployments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/deployments","created_at":"2018-08-24T14:27:46Z","updated_at":"2019-01-03T15:35:43Z","pushed_at":"2019-01-03T15:35:47Z","git_url":"git://github.com/lsqlabs/ngx-guided-tour.git","ssh_url":"git@github.com:lsqlabs/ngx-guided-tour.git","clone_url":"https://github.com/lsqlabs/ngx-guided-tour.git","svn_url":"https://github.com/lsqlabs/ngx-guided-tour","homepage":null,"size":1239,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"lsqlabs:master","ref":"master","sha":"d1e34bb1038b270c7c1333603c52e5fd094fbbd0","user":{"login":"lsqlabs","id":38542019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQyMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/38542019?v=4","gravatar_id":"","url":"https://api.github.com/users/lsqlabs","html_url":"https://github.com/lsqlabs","followers_url":"https://api.github.com/users/lsqlabs/followers","following_url":"https://api.github.com/users/lsqlabs/following{/other_user}","gists_url":"https://api.github.com/users/lsqlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lsqlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsqlabs/subscriptions","organizations_url":"https://api.github.com/users/lsqlabs/orgs","repos_url":"https://api.github.com/users/lsqlabs/repos","events_url":"https://api.github.com/users/lsqlabs/events{/privacy}","received_events_url":"https://api.github.com/users/lsqlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":146001701,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDE3MDE=","name":"ngx-guided-tour","full_name":"lsqlabs/ngx-guided-tour","private":false,"owner":{"login":"lsqlabs","id":38542019,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQyMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/38542019?v=4","gravatar_id":"","url":"https://api.github.com/users/lsqlabs","html_url":"https://github.com/lsqlabs","followers_url":"https://api.github.com/users/lsqlabs/followers","following_url":"https://api.github.com/users/lsqlabs/following{/other_user}","gists_url":"https://api.github.com/users/lsqlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lsqlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsqlabs/subscriptions","organizations_url":"https://api.github.com/users/lsqlabs/orgs","repos_url":"https://api.github.com/users/lsqlabs/repos","events_url":"https://api.github.com/users/lsqlabs/events{/privacy}","received_events_url":"https://api.github.com/users/lsqlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsqlabs/ngx-guided-tour","description":null,"fork":false,"url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour","forks_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/forks","keys_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/teams","hooks_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/hooks","issue_events_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/events{/number}","events_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/events","assignees_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/assignees{/user}","branches_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/branches{/branch}","tags_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/tags","blobs_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/statuses/{sha}","languages_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/languages","stargazers_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/stargazers","contributors_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/contributors","subscribers_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/subscribers","subscription_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/subscription","commits_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/contents/{+path}","compare_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/merges","archive_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/downloads","issues_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues{/number}","pulls_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls{/number}","milestones_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/milestones{/number}","notifications_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/labels{/name}","releases_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/releases{/id}","deployments_url":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/deployments","created_at":"2018-08-24T14:27:46Z","updated_at":"2019-01-03T15:35:43Z","pushed_at":"2019-01-03T15:35:47Z","git_url":"git://github.com/lsqlabs/ngx-guided-tour.git","ssh_url":"git@github.com:lsqlabs/ngx-guided-tour.git","clone_url":"https://github.com/lsqlabs/ngx-guided-tour.git","svn_url":"https://github.com/lsqlabs/ngx-guided-tour","homepage":null,"size":1239,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4"},"html":{"href":"https://github.com/lsqlabs/ngx-guided-tour/pull/4"},"issue":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/4"},"comments":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/lsqlabs/ngx-guided-tour/statuses/d81dcf83149900b67a052401ac15d1fd1f76d191"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"RobertCMusk"}}