{"action":"created","comment":{"url":"https://api.github.com/repos/segmentio/evergreen/pulls/comments/204134287","pull_request_review_id":139165193,"id":204134287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEzNDI4Nw==","diff_hunk":"@@ -1,11 +1,21 @@\n import tinycolor from 'tinycolor2'\n import palette from '../foundational-styles/palette'\n \n-const getTooltipProps = () => {\n-  return {\n-    backgroundColor: tinycolor(palette.neutral.base)\n-      .setAlpha(0.95)\n-      .toString()\n+const getTooltipProps = appearance => {\n+  switch (appearance) {\n+    case 'card':","path":"src/theme/src/default-theme/component-specific/getTooltipProps.js","position":11,"original_position":11,"commit_id":"8f6427d6bd082844da20a7f0b4178c363beb2bad","original_commit_id":"8f6427d6bd082844da20a7f0b4178c363beb2bad","user":{"login":"mshwery","id":710752,"node_id":"MDQ6VXNlcjcxMDc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/710752?v=4","gravatar_id":"","url":"https://api.github.com/users/mshwery","html_url":"https://github.com/mshwery","followers_url":"https://api.github.com/users/mshwery/followers","following_url":"https://api.github.com/users/mshwery/following{/other_user}","gists_url":"https://api.github.com/users/mshwery/gists{/gist_id}","starred_url":"https://api.github.com/users/mshwery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshwery/subscriptions","organizations_url":"https://api.github.com/users/mshwery/orgs","repos_url":"https://api.github.com/users/mshwery/repos","events_url":"https://api.github.com/users/mshwery/events{/privacy}","received_events_url":"https://api.github.com/users/mshwery/received_events","type":"User","site_admin":false},"body":"This might be a misunderstanding of the semantics, but I've often followed the rule of thumb that a `Tooltip` is simple, short content. It cannot contain html or other components, only strings. With those semantics, things that look like a raised \"card\" would qualify as a `Popover` IMO.\r\n\r\nNot sure if this meshes with Evergreen's component semantics, but thought it was worth mentioning here (if it allows us to simplify things).","created_at":"2018-07-20T18:35:15Z","updated_at":"2018-07-20T18:46:26Z","html_url":"https://github.com/segmentio/evergreen/pull/235#discussion_r204134287","pull_request_url":"https://api.github.com/repos/segmentio/evergreen/pulls/235","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/comments/204134287"},"html":{"href":"https://github.com/segmentio/evergreen/pull/235#discussion_r204134287"},"pull_request":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/segmentio/evergreen/pulls/235","id":202701428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzAxNDI4","html_url":"https://github.com/segmentio/evergreen/pull/235","diff_url":"https://github.com/segmentio/evergreen/pull/235.diff","patch_url":"https://github.com/segmentio/evergreen/pull/235.patch","issue_url":"https://api.github.com/repos/segmentio/evergreen/issues/235","number":235,"state":"open","locked":false,"title":"[V4] Use Tooltip inside of a Popover","user":{"login":"jeroenransijn","id":564463,"node_id":"MDQ6VXNlcjU2NDQ2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/564463?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroenransijn","html_url":"https://github.com/jeroenransijn","followers_url":"https://api.github.com/users/jeroenransijn/followers","following_url":"https://api.github.com/users/jeroenransijn/following{/other_user}","gists_url":"https://api.github.com/users/jeroenransijn/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroenransijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroenransijn/subscriptions","organizations_url":"https://api.github.com/users/jeroenransijn/orgs","repos_url":"https://api.github.com/users/jeroenransijn/repos","events_url":"https://api.github.com/users/jeroenransijn/events{/privacy}","received_events_url":"https://api.github.com/users/jeroenransijn/received_events","type":"User","site_admin":false},"body":"This PR implements the support of putting a `Tooltip` inside of a `Popover`.\r\n\r\n## Preview\r\n![popover tooltip styled](https://user-images.githubusercontent.com/564463/42973586-8a51447a-8b68-11e8-8e4e-8c4f64fed77a.gif)\r\n\r\n## Code Example\r\n\r\nThe above example is rendered by the following code.\r\n\r\n```jsx\r\n<Popover content={<PopoverContentWithTextInput />}>\r\n  <Tooltip content=\"Click me\">\r\n    <Button marginRight={20}>Tooltip Card + Popover</Button>\r\n  </Tooltip>\r\n</Popover>\r\n<Popover content={<PopoverContentWithTextInput />}>\r\n  <Tooltip\r\n    appearance=\"card\"\r\n    content={\r\n      <React.Fragment>\r\n        <Heading>Heading</Heading>\r\n        <Paragraph color=\"muted\" marginTop={4}>\r\n          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do\r\n          eiusmod tempor incididunt ut labore et dolore magna aliqua.\r\n        </Paragraph>\r\n      </React.Fragment>\r\n    }\r\n    statelessProps={{\r\n      paddingY: 24,\r\n      paddingX: 24,\r\n      maxWidth: 280\r\n    }}\r\n  >\r\n    <Button>Tooltip + Popover</Button>\r\n  </Tooltip>\r\n</Popover>\r\n```\r\n\r\n## Other additions\r\n\r\nThis PR also adds the support for 2 appearances on a `Tooltip`: `default` and `card`.","created_at":"2018-07-19T22:31:51Z","updated_at":"2018-07-20T18:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd4c62650faf34a8020b045cd7704d99691b970e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Rowno","id":605501,"node_id":"MDQ6VXNlcjYwNTUwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/605501?v=4","gravatar_id":"","url":"https://api.github.com/users/Rowno","html_url":"https://github.com/Rowno","followers_url":"https://api.github.com/users/Rowno/followers","following_url":"https://api.github.com/users/Rowno/following{/other_user}","gists_url":"https://api.github.com/users/Rowno/gists{/gist_id}","starred_url":"https://api.github.com/users/Rowno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rowno/subscriptions","organizations_url":"https://api.github.com/users/Rowno/orgs","repos_url":"https://api.github.com/users/Rowno/repos","events_url":"https://api.github.com/users/Rowno/events{/privacy}","received_events_url":"https://api.github.com/users/Rowno/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":672426028,"node_id":"MDU6TGFiZWw2NzI0MjYwMjg=","url":"https://api.github.com/repos/segmentio/evergreen/labels/Priority:%20Medium","name":"Priority: Medium","color":"F7C653","default":false},{"id":678572186,"node_id":"MDU6TGFiZWw2Nzg1NzIxODY=","url":"https://api.github.com/repos/segmentio/evergreen/labels/Type:%20Improvement","name":"Type: Improvement","color":"435A6F","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/segmentio/evergreen/pulls/235/commits","review_comments_url":"https://api.github.com/repos/segmentio/evergreen/pulls/235/comments","review_comment_url":"https://api.github.com/repos/segmentio/evergreen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segmentio/evergreen/issues/235/comments","statuses_url":"https://api.github.com/repos/segmentio/evergreen/statuses/8f6427d6bd082844da20a7f0b4178c363beb2bad","head":{"label":"segmentio:v4-tooltip-inside-popover","ref":"v4-tooltip-inside-popover","sha":"8f6427d6bd082844da20a7f0b4178c363beb2bad","user":{"login":"segmentio","id":819518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxOTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/819518?v=4","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":98789146,"node_id":"MDEwOlJlcG9zaXRvcnk5ODc4OTE0Ng==","name":"evergreen","full_name":"segmentio/evergreen","owner":{"login":"segmentio","id":819518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxOTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/819518?v=4","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/evergreen","description":"🌲 Evergreen React UI Framework by Segment","fork":false,"url":"https://api.github.com/repos/segmentio/evergreen","forks_url":"https://api.github.com/repos/segmentio/evergreen/forks","keys_url":"https://api.github.com/repos/segmentio/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/evergreen/teams","hooks_url":"https://api.github.com/repos/segmentio/evergreen/hooks","issue_events_url":"https://api.github.com/repos/segmentio/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/evergreen/events","assignees_url":"https://api.github.com/repos/segmentio/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/evergreen/tags","blobs_url":"https://api.github.com/repos/segmentio/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/evergreen/languages","stargazers_url":"https://api.github.com/repos/segmentio/evergreen/stargazers","contributors_url":"https://api.github.com/repos/segmentio/evergreen/contributors","subscribers_url":"https://api.github.com/repos/segmentio/evergreen/subscribers","subscription_url":"https://api.github.com/repos/segmentio/evergreen/subscription","commits_url":"https://api.github.com/repos/segmentio/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/evergreen/merges","archive_url":"https://api.github.com/repos/segmentio/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/evergreen/downloads","issues_url":"https://api.github.com/repos/segmentio/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/segmentio/evergreen/deployments","created_at":"2017-07-30T10:03:14Z","updated_at":"2018-07-20T13:00:11Z","pushed_at":"2018-07-20T17:30:41Z","git_url":"git://github.com/segmentio/evergreen.git","ssh_url":"git@github.com:segmentio/evergreen.git","clone_url":"https://github.com/segmentio/evergreen.git","svn_url":"https://github.com/segmentio/evergreen","homepage":"https://evergreen.surge.sh/","size":3093,"stargazers_count":456,"watchers_count":456,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":43,"open_issues":30,"watchers":456,"default_branch":"master"}},"base":{"label":"segmentio:v4","ref":"v4","sha":"7630a539339c55ba8e54374ccd074f88362c8803","user":{"login":"segmentio","id":819518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxOTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/819518?v=4","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":98789146,"node_id":"MDEwOlJlcG9zaXRvcnk5ODc4OTE0Ng==","name":"evergreen","full_name":"segmentio/evergreen","owner":{"login":"segmentio","id":819518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxOTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/819518?v=4","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/evergreen","description":"🌲 Evergreen React UI Framework by Segment","fork":false,"url":"https://api.github.com/repos/segmentio/evergreen","forks_url":"https://api.github.com/repos/segmentio/evergreen/forks","keys_url":"https://api.github.com/repos/segmentio/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/evergreen/teams","hooks_url":"https://api.github.com/repos/segmentio/evergreen/hooks","issue_events_url":"https://api.github.com/repos/segmentio/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/evergreen/events","assignees_url":"https://api.github.com/repos/segmentio/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/evergreen/tags","blobs_url":"https://api.github.com/repos/segmentio/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/evergreen/languages","stargazers_url":"https://api.github.com/repos/segmentio/evergreen/stargazers","contributors_url":"https://api.github.com/repos/segmentio/evergreen/contributors","subscribers_url":"https://api.github.com/repos/segmentio/evergreen/subscribers","subscription_url":"https://api.github.com/repos/segmentio/evergreen/subscription","commits_url":"https://api.github.com/repos/segmentio/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/evergreen/merges","archive_url":"https://api.github.com/repos/segmentio/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/evergreen/downloads","issues_url":"https://api.github.com/repos/segmentio/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/segmentio/evergreen/deployments","created_at":"2017-07-30T10:03:14Z","updated_at":"2018-07-20T13:00:11Z","pushed_at":"2018-07-20T17:30:41Z","git_url":"git://github.com/segmentio/evergreen.git","ssh_url":"git@github.com:segmentio/evergreen.git","clone_url":"https://github.com/segmentio/evergreen.git","svn_url":"https://github.com/segmentio/evergreen","homepage":"https://evergreen.surge.sh/","size":3093,"stargazers_count":456,"watchers_count":456,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":43,"open_issues":30,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/235"},"html":{"href":"https://github.com/segmentio/evergreen/pull/235"},"issue":{"href":"https://api.github.com/repos/segmentio/evergreen/issues/235"},"comments":{"href":"https://api.github.com/repos/segmentio/evergreen/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segmentio/evergreen/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/segmentio/evergreen/statuses/8f6427d6bd082844da20a7f0b4178c363beb2bad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mshwery"}}