{"action":"created","comment":{"url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/comments/173087294","pull_request_review_id":102214430,"id":173087294,"diff_hunk":"@@ -831,6 +866,10 @@ def _create_deployment(name, image, api, healthcheck_path='/', replicas=2,\n         },\n     }\n \n+    if image_pull_secret is not None:\n+        image_pull_secret_tag = [{'name': image_pull_secret}]\n+        template[\"spec\"][\"template\"][\"spec\"]['imagePullSecrets'] = image_pull_secret_tag","path":"apsconnectcli/apsconnect.py","position":null,"original_position":84,"commit_id":"e6d491d38d4448e9deb1b638896a51c70b4305fb","original_commit_id":"28d996deb6aea6f1adfddfa00559583362973ffa","user":{"login":"gmahato","id":37011410,"avatar_url":"https://avatars0.githubusercontent.com/u/37011410?v=4","gravatar_id":"","url":"https://api.github.com/users/gmahato","html_url":"https://github.com/gmahato","followers_url":"https://api.github.com/users/gmahato/followers","following_url":"https://api.github.com/users/gmahato/following{/other_user}","gists_url":"https://api.github.com/users/gmahato/gists{/gist_id}","starred_url":"https://api.github.com/users/gmahato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmahato/subscriptions","organizations_url":"https://api.github.com/users/gmahato/orgs","repos_url":"https://api.github.com/users/gmahato/repos","events_url":"https://api.github.com/users/gmahato/events{/privacy}","received_events_url":"https://api.github.com/users/gmahato/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-03-08T08:07:53Z","updated_at":"2018-03-08T08:07:53Z","html_url":"https://github.com/ingrammicro/apsconnect-cli/pull/50#discussion_r173087294","pull_request_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/comments/173087294"},"html":{"href":"https://github.com/ingrammicro/apsconnect-cli/pull/50#discussion_r173087294"},"pull_request":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50"}},"in_reply_to_id":172859227},"pull_request":{"url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50","id":172655704,"html_url":"https://github.com/ingrammicro/apsconnect-cli/pull/50","diff_url":"https://github.com/ingrammicro/apsconnect-cli/pull/50.diff","patch_url":"https://github.com/ingrammicro/apsconnect-cli/pull/50.patch","issue_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/50","number":50,"state":"open","locked":false,"title":"LITE-4557 : Change in apsconnectcli to take ECR credential as input to pull images from ECR private repo","user":{"login":"gmahato","id":37011410,"avatar_url":"https://avatars0.githubusercontent.com/u/37011410?v=4","gravatar_id":"","url":"https://api.github.com/users/gmahato","html_url":"https://github.com/gmahato","followers_url":"https://api.github.com/users/gmahato/followers","following_url":"https://api.github.com/users/gmahato/following{/other_user}","gists_url":"https://api.github.com/users/gmahato/gists{/gist_id}","starred_url":"https://api.github.com/users/gmahato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmahato/subscriptions","organizations_url":"https://api.github.com/users/gmahato/orgs","repos_url":"https://api.github.com/users/gmahato/repos","events_url":"https://api.github.com/users/gmahato/events{/privacy}","received_events_url":"https://api.github.com/users/gmahato/received_events","type":"User","site_admin":false},"body":"LITE-4557 : Change in apsconnectcli to take ECR credential as input to pull images from ECR private repo\r\n\r\nNew parameter for backend deployment :\r\n1. aws_ecr_key\r\n2. aws_ecr_secret","created_at":"2018-03-03T07:45:21Z","updated_at":"2018-03-08T08:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"663e8b445fe2eb5d5f270ec5f26394471503c4ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50/commits","review_comments_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50/comments","review_comment_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/50/comments","statuses_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/statuses/e6d491d38d4448e9deb1b638896a51c70b4305fb","head":{"label":"gmahato:master","ref":"master","sha":"e6d491d38d4448e9deb1b638896a51c70b4305fb","user":{"login":"gmahato","id":37011410,"avatar_url":"https://avatars0.githubusercontent.com/u/37011410?v=4","gravatar_id":"","url":"https://api.github.com/users/gmahato","html_url":"https://github.com/gmahato","followers_url":"https://api.github.com/users/gmahato/followers","following_url":"https://api.github.com/users/gmahato/following{/other_user}","gists_url":"https://api.github.com/users/gmahato/gists{/gist_id}","starred_url":"https://api.github.com/users/gmahato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmahato/subscriptions","organizations_url":"https://api.github.com/users/gmahato/orgs","repos_url":"https://api.github.com/users/gmahato/repos","events_url":"https://api.github.com/users/gmahato/events{/privacy}","received_events_url":"https://api.github.com/users/gmahato/received_events","type":"User","site_admin":false},"repo":{"id":123668340,"name":"apsconnect-cli","full_name":"gmahato/apsconnect-cli","owner":{"login":"gmahato","id":37011410,"avatar_url":"https://avatars0.githubusercontent.com/u/37011410?v=4","gravatar_id":"","url":"https://api.github.com/users/gmahato","html_url":"https://github.com/gmahato","followers_url":"https://api.github.com/users/gmahato/followers","following_url":"https://api.github.com/users/gmahato/following{/other_user}","gists_url":"https://api.github.com/users/gmahato/gists{/gist_id}","starred_url":"https://api.github.com/users/gmahato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmahato/subscriptions","organizations_url":"https://api.github.com/users/gmahato/orgs","repos_url":"https://api.github.com/users/gmahato/repos","events_url":"https://api.github.com/users/gmahato/events{/privacy}","received_events_url":"https://api.github.com/users/gmahato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmahato/apsconnect-cli","description":"A command line tool for APS connector installation on Odin Automation in the relaxed way.","fork":true,"url":"https://api.github.com/repos/gmahato/apsconnect-cli","forks_url":"https://api.github.com/repos/gmahato/apsconnect-cli/forks","keys_url":"https://api.github.com/repos/gmahato/apsconnect-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmahato/apsconnect-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmahato/apsconnect-cli/teams","hooks_url":"https://api.github.com/repos/gmahato/apsconnect-cli/hooks","issue_events_url":"https://api.github.com/repos/gmahato/apsconnect-cli/issues/events{/number}","events_url":"https://api.github.com/repos/gmahato/apsconnect-cli/events","assignees_url":"https://api.github.com/repos/gmahato/apsconnect-cli/assignees{/user}","branches_url":"https://api.github.com/repos/gmahato/apsconnect-cli/branches{/branch}","tags_url":"https://api.github.com/repos/gmahato/apsconnect-cli/tags","blobs_url":"https://api.github.com/repos/gmahato/apsconnect-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmahato/apsconnect-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmahato/apsconnect-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmahato/apsconnect-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmahato/apsconnect-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/gmahato/apsconnect-cli/languages","stargazers_url":"https://api.github.com/repos/gmahato/apsconnect-cli/stargazers","contributors_url":"https://api.github.com/repos/gmahato/apsconnect-cli/contributors","subscribers_url":"https://api.github.com/repos/gmahato/apsconnect-cli/subscribers","subscription_url":"https://api.github.com/repos/gmahato/apsconnect-cli/subscription","commits_url":"https://api.github.com/repos/gmahato/apsconnect-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmahato/apsconnect-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmahato/apsconnect-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmahato/apsconnect-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmahato/apsconnect-cli/contents/{+path}","compare_url":"https://api.github.com/repos/gmahato/apsconnect-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmahato/apsconnect-cli/merges","archive_url":"https://api.github.com/repos/gmahato/apsconnect-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmahato/apsconnect-cli/downloads","issues_url":"https://api.github.com/repos/gmahato/apsconnect-cli/issues{/number}","pulls_url":"https://api.github.com/repos/gmahato/apsconnect-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/gmahato/apsconnect-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/gmahato/apsconnect-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmahato/apsconnect-cli/labels{/name}","releases_url":"https://api.github.com/repos/gmahato/apsconnect-cli/releases{/id}","deployments_url":"https://api.github.com/repos/gmahato/apsconnect-cli/deployments","created_at":"2018-03-03T07:04:16Z","updated_at":"2018-03-03T07:04:18Z","pushed_at":"2018-03-08T07:56:03Z","git_url":"git://github.com/gmahato/apsconnect-cli.git","ssh_url":"git@github.com:gmahato/apsconnect-cli.git","clone_url":"https://github.com/gmahato/apsconnect-cli.git","svn_url":"https://github.com/gmahato/apsconnect-cli","homepage":"https://help.connect.cloud.im/provider/deployment/frontend","size":223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ingrammicro:master","ref":"master","sha":"3cf21a4966e68080f4c11942bc5adde52b4b7906","user":{"login":"ingrammicro","id":21345425,"avatar_url":"https://avatars0.githubusercontent.com/u/21345425?v=4","gravatar_id":"","url":"https://api.github.com/users/ingrammicro","html_url":"https://github.com/ingrammicro","followers_url":"https://api.github.com/users/ingrammicro/followers","following_url":"https://api.github.com/users/ingrammicro/following{/other_user}","gists_url":"https://api.github.com/users/ingrammicro/gists{/gist_id}","starred_url":"https://api.github.com/users/ingrammicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingrammicro/subscriptions","organizations_url":"https://api.github.com/users/ingrammicro/orgs","repos_url":"https://api.github.com/users/ingrammicro/repos","events_url":"https://api.github.com/users/ingrammicro/events{/privacy}","received_events_url":"https://api.github.com/users/ingrammicro/received_events","type":"Organization","site_admin":false},"repo":{"id":93873726,"name":"apsconnect-cli","full_name":"ingrammicro/apsconnect-cli","owner":{"login":"ingrammicro","id":21345425,"avatar_url":"https://avatars0.githubusercontent.com/u/21345425?v=4","gravatar_id":"","url":"https://api.github.com/users/ingrammicro","html_url":"https://github.com/ingrammicro","followers_url":"https://api.github.com/users/ingrammicro/followers","following_url":"https://api.github.com/users/ingrammicro/following{/other_user}","gists_url":"https://api.github.com/users/ingrammicro/gists{/gist_id}","starred_url":"https://api.github.com/users/ingrammicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingrammicro/subscriptions","organizations_url":"https://api.github.com/users/ingrammicro/orgs","repos_url":"https://api.github.com/users/ingrammicro/repos","events_url":"https://api.github.com/users/ingrammicro/events{/privacy}","received_events_url":"https://api.github.com/users/ingrammicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ingrammicro/apsconnect-cli","description":"A command line tool for APS connector installation on Odin Automation in the relaxed way.","fork":false,"url":"https://api.github.com/repos/ingrammicro/apsconnect-cli","forks_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/forks","keys_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/teams","hooks_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/hooks","issue_events_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/events","assignees_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/tags","blobs_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/languages","stargazers_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/stargazers","contributors_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/contributors","subscribers_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/subscribers","subscription_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/subscription","commits_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/merges","archive_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/downloads","issues_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/labels{/name}","releases_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ingrammicro/apsconnect-cli/deployments","created_at":"2017-06-09T15:43:06Z","updated_at":"2018-02-12T11:10:48Z","pushed_at":"2018-03-08T07:56:04Z","git_url":"git://github.com/ingrammicro/apsconnect-cli.git","ssh_url":"git@github.com:ingrammicro/apsconnect-cli.git","clone_url":"https://github.com/ingrammicro/apsconnect-cli.git","svn_url":"https://github.com/ingrammicro/apsconnect-cli","homepage":"https://help.connect.cloud.im/provider/deployment/frontend","size":125,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50"},"html":{"href":"https://github.com/ingrammicro/apsconnect-cli/pull/50"},"issue":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/50"},"comments":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/ingrammicro/apsconnect-cli/statuses/e6d491d38d4448e9deb1b638896a51c70b4305fb"}},"author_association":"NONE"}}
{"actor":{"display_login":"gmahato"}}