{"action":"created","issue":{"url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/66","repository_url":"https://api.github.com/repos/JSBSim-Team/jsbsim","labels_url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/66/comments","events_url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/66/events","html_url":"https://github.com/JSBSim-Team/jsbsim/pull/66","id":333021613,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzUzMTU0","number":66,"title":"Implement pressure altitude and density altitude for full 86km of ISA","user":{"login":"seanmcleod","id":824856,"node_id":"MDQ6VXNlcjgyNDg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/824856?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmcleod","html_url":"https://github.com/seanmcleod","followers_url":"https://api.github.com/users/seanmcleod/followers","following_url":"https://api.github.com/users/seanmcleod/following{/other_user}","gists_url":"https://api.github.com/users/seanmcleod/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmcleod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmcleod/subscriptions","organizations_url":"https://api.github.com/users/seanmcleod/orgs","repos_url":"https://api.github.com/users/seanmcleod/repos","events_url":"https://api.github.com/users/seanmcleod/events{/privacy}","received_events_url":"https://api.github.com/users/seanmcleod/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-16T23:10:50Z","updated_at":"2018-06-17T14:59:38Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JSBSim-Team/jsbsim/pulls/66","html_url":"https://github.com/JSBSim-Team/jsbsim/pull/66","diff_url":"https://github.com/JSBSim-Team/jsbsim/pull/66.diff","patch_url":"https://github.com/JSBSim-Team/jsbsim/pull/66.patch"},"body":"@djlinse you'll be happy to know that the troposphere specific check based on altitude is now gone and there are no troposphere specific variables anymore. \r\n\r\nI've added pressure altitude and density altitude checks to the Python test cases to test for at least 1 altitude in every ISA defined layer up to 86km.\r\n"},"comment":{"url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/comments/397884598","html_url":"https://github.com/JSBSim-Team/jsbsim/pull/66#issuecomment-397884598","issue_url":"https://api.github.com/repos/JSBSim-Team/jsbsim/issues/66","id":397884598,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg4NDU5OA==","user":{"login":"djlinse","id":39423509,"node_id":"MDQ6VXNlcjM5NDIzNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/39423509?v=4","gravatar_id":"","url":"https://api.github.com/users/djlinse","html_url":"https://github.com/djlinse","followers_url":"https://api.github.com/users/djlinse/followers","following_url":"https://api.github.com/users/djlinse/following{/other_user}","gists_url":"https://api.github.com/users/djlinse/gists{/gist_id}","starred_url":"https://api.github.com/users/djlinse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djlinse/subscriptions","organizations_url":"https://api.github.com/users/djlinse/orgs","repos_url":"https://api.github.com/users/djlinse/repos","events_url":"https://api.github.com/users/djlinse/events{/privacy}","received_events_url":"https://api.github.com/users/djlinse/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T14:59:38Z","updated_at":"2018-06-17T14:59:38Z","author_association":"CONTRIBUTOR","body":"@bcoconni I see why the FGStandard uses the temperature table and understand why it might have been developed in that fashion originally.  But this is one of the very few places in coding of a complicated physical model when you have an exact standard that says what the number should be.  Just my OCD-ness, I guess.\r\n\r\nI hadn't really thought about/noticed how the standard temperature table was being used/abused as far as the 0/1 indexing.  Not a good coding convention, but possibly/probably not worth worrying about.\r\n\r\n@seanmcleod I still will would suggest that rather than calculate Lmb in each routine, that you make a variable StdLapseRate (or StdLapseRateVector if you must), and assign it a copy of LapseRateVector in InitModel, much like I did with StdPressureBreakpointVector, as at that point LapseRateVector is exactly what you are calculating over and over again, I believe.  "}}
{"actor":{"display_login":"djlinse"}}