{"action":"created","comment":{"url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/comments/165656704","pull_request_review_id":93634760,"id":165656704,"diff_hunk":"@@ -14,6 +14,10 @@ def asset_record\n     asset_record_hash.values\n   end\n \n+  def find_parent_asset_record(definition)","path":"app/models/concerns/has_asset_record.rb","position":4,"original_position":4,"commit_id":"89d01e826a378a67458643b2b32dfabd3b274311","original_commit_id":"89d01e826a378a67458643b2b32dfabd3b274311","user":{"login":"WilliamMcCumstie","id":16605145,"avatar_url":"https://avatars1.githubusercontent.com/u/16605145?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamMcCumstie","html_url":"https://github.com/WilliamMcCumstie","followers_url":"https://api.github.com/users/WilliamMcCumstie/followers","following_url":"https://api.github.com/users/WilliamMcCumstie/following{/other_user}","gists_url":"https://api.github.com/users/WilliamMcCumstie/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamMcCumstie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamMcCumstie/subscriptions","organizations_url":"https://api.github.com/users/WilliamMcCumstie/orgs","repos_url":"https://api.github.com/users/WilliamMcCumstie/repos","events_url":"https://api.github.com/users/WilliamMcCumstie/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamMcCumstie/received_events","type":"User","site_admin":false},"body":"It is correctly named. `asset_records` is a collection of `asset_record_fields` except not all of them belong to the current asset.\r\n\r\nIn this case we want the `asset_record` because this includes the fields set at the `component_type` level. \r\n\r\n`find_parent_asset_field_record` would imply we are looking one level higher and no more. This is not the case as we do want the grandparent records (if required).","created_at":"2018-02-02T14:22:29Z","updated_at":"2018-02-02T14:22:29Z","html_url":"https://github.com/alces-software/alces-flight-center/pull/38#discussion_r165656704","pull_request_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/comments/165656704"},"html":{"href":"https://github.com/alces-software/alces-flight-center/pull/38#discussion_r165656704"},"pull_request":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38"}},"in_reply_to_id":165379828},"pull_request":{"url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38","id":164293285,"html_url":"https://github.com/alces-software/alces-flight-center/pull/38","diff_url":"https://github.com/alces-software/alces-flight-center/pull/38.diff","patch_url":"https://github.com/alces-software/alces-flight-center/pull/38.patch","issue_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/38","number":38,"state":"closed","locked":false,"title":"Additional UI features for `AssetRecord` table","user":{"login":"WilliamMcCumstie","id":16605145,"avatar_url":"https://avatars1.githubusercontent.com/u/16605145?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamMcCumstie","html_url":"https://github.com/WilliamMcCumstie","followers_url":"https://api.github.com/users/WilliamMcCumstie/followers","following_url":"https://api.github.com/users/WilliamMcCumstie/following{/other_user}","gists_url":"https://api.github.com/users/WilliamMcCumstie/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamMcCumstie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamMcCumstie/subscriptions","organizations_url":"https://api.github.com/users/WilliamMcCumstie/orgs","repos_url":"https://api.github.com/users/WilliamMcCumstie/repos","events_url":"https://api.github.com/users/WilliamMcCumstie/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamMcCumstie/received_events","type":"User","site_admin":false},"body":"Based on #36, please merge it first.\r\n\r\nA few additional `UI` features have been added to the edit `AssetRecord` table.\r\n1. It no longer autofills the `asset_record_table` with the parent/ higher values. Instead the parent values are now a placeholder. This required the `HasAssetRecordConcern` to be modified as empty strings no longer mean delete in all circumstances. https://github.com/alces-software/alces-flight-center/pull/38/commits/264fcb822fe1447401db97f61cd11cb3a8f4815d\r\n1. Asset records that can only be set at the component level are greyed out at the group level. Title text has been set to explain this.\r\n1. The `ComponentMake` can now be changed for the `ComponentGroup` based on the previous `ComponentType`.\r\n1. The `Components` are now displayed on the `ComponentGroup` page.","created_at":"2018-01-22T12:24:46Z","updated_at":"2018-02-02T14:22:29Z","closed_at":"2018-02-01T16:35:21Z","merged_at":"2018-02-01T16:35:21Z","merge_commit_sha":"c394cbe2553f32169deaf0d2d0f99e63e3730a6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38/commits","review_comments_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38/comments","review_comment_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/38/comments","statuses_url":"https://api.github.com/repos/alces-software/alces-flight-center/statuses/89d01e826a378a67458643b2b32dfabd3b274311","head":{"label":"alces-software:feature/ui-asset-record","ref":"feature/ui-asset-record","sha":"89d01e826a378a67458643b2b32dfabd3b274311","user":{"login":"alces-software","id":945288,"avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"repo":{"id":103410349,"name":"alces-flight-center","full_name":"alces-software/alces-flight-center","owner":{"login":"alces-software","id":945288,"avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alces-software/alces-flight-center","description":"Alces Flight Center cluster support and management site","fork":false,"url":"https://api.github.com/repos/alces-software/alces-flight-center","forks_url":"https://api.github.com/repos/alces-software/alces-flight-center/forks","keys_url":"https://api.github.com/repos/alces-software/alces-flight-center/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alces-software/alces-flight-center/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alces-software/alces-flight-center/teams","hooks_url":"https://api.github.com/repos/alces-software/alces-flight-center/hooks","issue_events_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/events{/number}","events_url":"https://api.github.com/repos/alces-software/alces-flight-center/events","assignees_url":"https://api.github.com/repos/alces-software/alces-flight-center/assignees{/user}","branches_url":"https://api.github.com/repos/alces-software/alces-flight-center/branches{/branch}","tags_url":"https://api.github.com/repos/alces-software/alces-flight-center/tags","blobs_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/refs{/sha}","trees_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alces-software/alces-flight-center/statuses/{sha}","languages_url":"https://api.github.com/repos/alces-software/alces-flight-center/languages","stargazers_url":"https://api.github.com/repos/alces-software/alces-flight-center/stargazers","contributors_url":"https://api.github.com/repos/alces-software/alces-flight-center/contributors","subscribers_url":"https://api.github.com/repos/alces-software/alces-flight-center/subscribers","subscription_url":"https://api.github.com/repos/alces-software/alces-flight-center/subscription","commits_url":"https://api.github.com/repos/alces-software/alces-flight-center/commits{/sha}","git_commits_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/commits{/sha}","comments_url":"https://api.github.com/repos/alces-software/alces-flight-center/comments{/number}","issue_comment_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/comments{/number}","contents_url":"https://api.github.com/repos/alces-software/alces-flight-center/contents/{+path}","compare_url":"https://api.github.com/repos/alces-software/alces-flight-center/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alces-software/alces-flight-center/merges","archive_url":"https://api.github.com/repos/alces-software/alces-flight-center/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alces-software/alces-flight-center/downloads","issues_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues{/number}","pulls_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls{/number}","milestones_url":"https://api.github.com/repos/alces-software/alces-flight-center/milestones{/number}","notifications_url":"https://api.github.com/repos/alces-software/alces-flight-center/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alces-software/alces-flight-center/labels{/name}","releases_url":"https://api.github.com/repos/alces-software/alces-flight-center/releases{/id}","deployments_url":"https://api.github.com/repos/alces-software/alces-flight-center/deployments","created_at":"2017-09-13T14:30:59Z","updated_at":"2018-01-08T18:42:13Z","pushed_at":"2018-02-02T14:19:04Z","git_url":"git://github.com/alces-software/alces-flight-center.git","ssh_url":"git@github.com:alces-software/alces-flight-center.git","clone_url":"https://github.com/alces-software/alces-flight-center.git","svn_url":"https://github.com/alces-software/alces-flight-center","homepage":"https://center.alces-flight.com/","size":7561,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":8,"watchers":1,"default_branch":"develop"}},"base":{"label":"alces-software:develop","ref":"develop","sha":"20010a3f2bcbe4e7059fb31772f0040ec6c61907","user":{"login":"alces-software","id":945288,"avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"repo":{"id":103410349,"name":"alces-flight-center","full_name":"alces-software/alces-flight-center","owner":{"login":"alces-software","id":945288,"avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alces-software/alces-flight-center","description":"Alces Flight Center cluster support and management site","fork":false,"url":"https://api.github.com/repos/alces-software/alces-flight-center","forks_url":"https://api.github.com/repos/alces-software/alces-flight-center/forks","keys_url":"https://api.github.com/repos/alces-software/alces-flight-center/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alces-software/alces-flight-center/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alces-software/alces-flight-center/teams","hooks_url":"https://api.github.com/repos/alces-software/alces-flight-center/hooks","issue_events_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/events{/number}","events_url":"https://api.github.com/repos/alces-software/alces-flight-center/events","assignees_url":"https://api.github.com/repos/alces-software/alces-flight-center/assignees{/user}","branches_url":"https://api.github.com/repos/alces-software/alces-flight-center/branches{/branch}","tags_url":"https://api.github.com/repos/alces-software/alces-flight-center/tags","blobs_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/refs{/sha}","trees_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alces-software/alces-flight-center/statuses/{sha}","languages_url":"https://api.github.com/repos/alces-software/alces-flight-center/languages","stargazers_url":"https://api.github.com/repos/alces-software/alces-flight-center/stargazers","contributors_url":"https://api.github.com/repos/alces-software/alces-flight-center/contributors","subscribers_url":"https://api.github.com/repos/alces-software/alces-flight-center/subscribers","subscription_url":"https://api.github.com/repos/alces-software/alces-flight-center/subscription","commits_url":"https://api.github.com/repos/alces-software/alces-flight-center/commits{/sha}","git_commits_url":"https://api.github.com/repos/alces-software/alces-flight-center/git/commits{/sha}","comments_url":"https://api.github.com/repos/alces-software/alces-flight-center/comments{/number}","issue_comment_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues/comments{/number}","contents_url":"https://api.github.com/repos/alces-software/alces-flight-center/contents/{+path}","compare_url":"https://api.github.com/repos/alces-software/alces-flight-center/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alces-software/alces-flight-center/merges","archive_url":"https://api.github.com/repos/alces-software/alces-flight-center/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alces-software/alces-flight-center/downloads","issues_url":"https://api.github.com/repos/alces-software/alces-flight-center/issues{/number}","pulls_url":"https://api.github.com/repos/alces-software/alces-flight-center/pulls{/number}","milestones_url":"https://api.github.com/repos/alces-software/alces-flight-center/milestones{/number}","notifications_url":"https://api.github.com/repos/alces-software/alces-flight-center/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alces-software/alces-flight-center/labels{/name}","releases_url":"https://api.github.com/repos/alces-software/alces-flight-center/releases{/id}","deployments_url":"https://api.github.com/repos/alces-software/alces-flight-center/deployments","created_at":"2017-09-13T14:30:59Z","updated_at":"2018-01-08T18:42:13Z","pushed_at":"2018-02-02T14:19:04Z","git_url":"git://github.com/alces-software/alces-flight-center.git","ssh_url":"git@github.com:alces-software/alces-flight-center.git","clone_url":"https://github.com/alces-software/alces-flight-center.git","svn_url":"https://github.com/alces-software/alces-flight-center","homepage":"https://center.alces-flight.com/","size":7561,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":8,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38"},"html":{"href":"https://github.com/alces-software/alces-flight-center/pull/38"},"issue":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/issues/38"},"comments":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/alces-software/alces-flight-center/statuses/89d01e826a378a67458643b2b32dfabd3b274311"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"WilliamMcCumstie"}}