{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/239954238","pull_request_review_id":182884152,"id":239954238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk1NDIzOA==","diff_hunk":"@@ -49,9 +49,19 @@ import (\n \t\"github.com/knative/serving/pkg/system\"\n )\n \n+var (\n+\toriginGateways = map[string]string{\n+\t\t\"gateway.knative-shared-gateway\": \"origin.ns.svc.cluster.local\",\n+\t}\n+\tnewGateways = map[string]string{\n+\t\t\"gateway.knative-ingress-gateway\": \"custom.ns.svc.cluster.local\",\n+\t\t\"gateway.knative-shared-gateway\":  \"origin.ns.svc.cluster.local\",\n+\t}\n+)\n+\n const (\n-\toriginGateway = \"origin.ns.svc.cluster.local\"\n-\tcustomGateway = \"custom.ns.svc.cluster.local\"\n+\toriginDomainInternal = \"origin.ns.svc.cluster.local\"\n+\tnewDomainInternal    = \"custom.ns.svc.cluster.local\"","path":"pkg/reconciler/v1alpha1/clusteringress/clusteringress_test.go","position":18,"original_position":18,"commit_id":"119816b51322e26eeee5b88d48c18b895145ff11","original_commit_id":"119816b51322e26eeee5b88d48c18b895145ff11","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"body":"use these constants above?","created_at":"2018-12-07T21:41:07Z","updated_at":"2018-12-07T21:45:02Z","html_url":"https://github.com/knative/serving/pull/2666#discussion_r239954238","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/2666","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/239954238"},"html":{"href":"https://github.com/knative/serving/pull/2666#discussion_r239954238"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/2666"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2666","id":236771749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzcxNzQ5","html_url":"https://github.com/knative/serving/pull/2666","diff_url":"https://github.com/knative/serving/pull/2666.diff","patch_url":"https://github.com/knative/serving/pull/2666.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2666","number":2666,"state":"open","locked":false,"title":"Support exposing ClusterIngress to two or more shared Gateways.","user":{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\n## Proposed Changes\r\n\r\nIn order for existing users to migrate cleanly off existing `knative-ingressgateway` we need to have a mechanism to allow them to expose their Services to two or more External LoadBalancer and cleanly update the domain to point to new IP address.  This change makes that possible.\r\n\r\nHence even though #1969 is fixed we will leave the `knative-ingressgateway` around and will have it removed may be when 0.4 rolls out.\r\n\r\n\r\n**Release Note**\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\nReinstate the `knative-ingressgateway` to allow existing users to upgrade cleanly.\r\n```\r\n","created_at":"2018-12-07T06:55:21Z","updated_at":"2018-12-07T21:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf5d5d208319bc6fc1bff92d88432bb60f70178","assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2666/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2666/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2666/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/119816b51322e26eeee5b88d48c18b895145ff11","head":{"label":"tcnghia:two-gateways","ref":"two-gateways","sha":"119816b51322e26eeee5b88d48c18b895145ff11","user":{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"repo":{"id":142332734,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzI3MzQ=","name":"serving","full_name":"tcnghia/serving","private":false,"owner":{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tcnghia/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/tcnghia/serving","forks_url":"https://api.github.com/repos/tcnghia/serving/forks","keys_url":"https://api.github.com/repos/tcnghia/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcnghia/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcnghia/serving/teams","hooks_url":"https://api.github.com/repos/tcnghia/serving/hooks","issue_events_url":"https://api.github.com/repos/tcnghia/serving/issues/events{/number}","events_url":"https://api.github.com/repos/tcnghia/serving/events","assignees_url":"https://api.github.com/repos/tcnghia/serving/assignees{/user}","branches_url":"https://api.github.com/repos/tcnghia/serving/branches{/branch}","tags_url":"https://api.github.com/repos/tcnghia/serving/tags","blobs_url":"https://api.github.com/repos/tcnghia/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcnghia/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcnghia/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcnghia/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcnghia/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/tcnghia/serving/languages","stargazers_url":"https://api.github.com/repos/tcnghia/serving/stargazers","contributors_url":"https://api.github.com/repos/tcnghia/serving/contributors","subscribers_url":"https://api.github.com/repos/tcnghia/serving/subscribers","subscription_url":"https://api.github.com/repos/tcnghia/serving/subscription","commits_url":"https://api.github.com/repos/tcnghia/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcnghia/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcnghia/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcnghia/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcnghia/serving/contents/{+path}","compare_url":"https://api.github.com/repos/tcnghia/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcnghia/serving/merges","archive_url":"https://api.github.com/repos/tcnghia/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcnghia/serving/downloads","issues_url":"https://api.github.com/repos/tcnghia/serving/issues{/number}","pulls_url":"https://api.github.com/repos/tcnghia/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/tcnghia/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/tcnghia/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcnghia/serving/labels{/name}","releases_url":"https://api.github.com/repos/tcnghia/serving/releases{/id}","deployments_url":"https://api.github.com/repos/tcnghia/serving/deployments","created_at":"2018-07-25T17:30:16Z","updated_at":"2018-12-07T17:19:55Z","pushed_at":"2018-12-07T21:00:10Z","git_url":"git://github.com/tcnghia/serving.git","ssh_url":"git@github.com:tcnghia/serving.git","clone_url":"https://github.com/tcnghia/serving.git","svn_url":"https://github.com/tcnghia/serving","homepage":"","size":29949,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"a9038a69c7f38d3e18c464622c935f2b3d8149e8","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-12-07T20:17:34Z","pushed_at":"2018-12-07T21:44:23Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":29797,"stargazers_count":909,"watchers_count":909,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":295,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":191,"open_issues":295,"watchers":909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2666"},"html":{"href":"https://github.com/knative/serving/pull/2666"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2666"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2666/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2666/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2666/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/119816b51322e26eeee5b88d48c18b895145ff11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattmoor"}}