{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2381","repository_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2381/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2381/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2381/events","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2381","id":366023786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODAxMTg1","number":2381,"title":"Add support for replicas and clarify updateStrategy","user":{"login":"jldeen","id":7676214,"node_id":"MDQ6VXNlcjc2NzYyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7676214?v=4","gravatar_id":"","url":"https://api.github.com/users/jldeen","html_url":"https://github.com/jldeen","followers_url":"https://api.github.com/users/jldeen/followers","following_url":"https://api.github.com/users/jldeen/following{/other_user}","gists_url":"https://api.github.com/users/jldeen/gists{/gist_id}","starred_url":"https://api.github.com/users/jldeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jldeen/subscriptions","organizations_url":"https://api.github.com/users/jldeen/orgs","repos_url":"https://api.github.com/users/jldeen/repos","events_url":"https://api.github.com/users/jldeen/events{/privacy}","received_events_url":"https://api.github.com/users/jldeen/received_events","type":"User","site_admin":false},"labels":[{"id":485046198,"node_id":"MDU6TGFiZWw0ODUwNDYxOTg=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676207277,"node_id":"MDU6TGFiZWw2NzYyMDcyNzc=","url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-02T18:28:39Z","updated_at":"2018-10-04T12:33:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/2381","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2381","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2381.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2381.patch"},"body":"This PR is a \r\n - [x ] Feature Implementation\r\n - [ ] Bug Fix\r\n - [ ] Documentation\r\n\r\n**What this PR does / why we need it**:\r\nThis PR adds in support for:\r\n - `replicas` per apiServer deployment and controllerManager deployment (useful in prod envs)\r\n - support for `minReadySeconds` per deployment for pods\r\n - clarify/change `deploymentStrategy` to `updateStrategy` since the type of \"deployment\" really only happens during \"update\"\r\n - update readme.md to include `helm delete --purge` for full deletion\r\n - update readme.md to include proposed updates mentioned above\r\n\r\n**Which issue(s) this PR fixes** \r\n<!-- *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: -->\r\nFixes #\r\n\r\nPlease leave this checklist in the PR comment so that maintainers can ensure a good PR.\r\n\r\nMerge Checklist:\r\n - [ ] New feature \r\n   - [ ] Tests\r\n   - [ ] Documentation\r\n - [ ] SVCat CLI flag\r\n - [ ] Server Flag for config\r\n   - [ ] Chart changes\r\n   - [ ] removing a flag by marking deprecated and hiding to avoid\r\n         breaking the chart release and existing clients who provide a\r\n         flag that will get an error when they try to update\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments/427001135","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/2381#issuecomment-427001135","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/2381","id":427001135,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzAwMTEzNQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T12:33:11Z","updated_at":"2018-10-04T12:33:11Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes-incubator/service-catalog/pull/2381#issuecomment-427001125\" title=\"Approved\">jboyd01</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes-incubator/service-catalog/blob/master/OWNERS)~~ [jboyd01]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}