{"action":"created","comment":{"url":"https://api.github.com/repos/github-for-unity/Unity/pulls/comments/182455644","pull_request_review_id":113253886,"id":182455644,"diff_hunk":"@@ -106,7 +109,7 @@ class LoginManager : ILoginManager\n             var host = loginResultData.Host;\n             var keychainAdapter = keychain.Connect(host);\n             var username = keychainAdapter.Credential.Username;\n-            var password = keychainAdapter.Credential.Token;","path":"src/GitHub.Api/Authentication/LoginManager.cs","position":18,"original_position":18,"commit_id":"80f2ba8c566c6f0e6f9c267761dae9b0c9f3a1f2","original_commit_id":"80f2ba8c566c6f0e6f9c267761dae9b0c9f3a1f2","user":{"login":"shana","id":310137,"avatar_url":"https://avatars1.githubusercontent.com/u/310137?v=4","gravatar_id":"","url":"https://api.github.com/users/shana","html_url":"https://github.com/shana","followers_url":"https://api.github.com/users/shana/followers","following_url":"https://api.github.com/users/shana/following{/other_user}","gists_url":"https://api.github.com/users/shana/gists{/gist_id}","starred_url":"https://api.github.com/users/shana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana/subscriptions","organizations_url":"https://api.github.com/users/shana/orgs","repos_url":"https://api.github.com/users/shana/repos","events_url":"https://api.github.com/users/shana/events{/privacy}","received_events_url":"https://api.github.com/users/shana/received_events","type":"User","site_admin":true},"body":"Is this change needed? The username and password are stored in the keychain at the beginning of the process (in https://github.com/github-for-unity/Unity/pull/691/files#diff-6d6481eca7dfd1acee9426efc4be8854R75), and we always use them until we're finished with 2fa, right?","created_at":"2018-04-18T14:49:53Z","updated_at":"2018-04-18T14:49:54Z","html_url":"https://github.com/github-for-unity/Unity/pull/691#discussion_r182455644","pull_request_url":"https://api.github.com/repos/github-for-unity/Unity/pulls/691","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/comments/182455644"},"html":{"href":"https://github.com/github-for-unity/Unity/pull/691#discussion_r182455644"},"pull_request":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/691"}}},"pull_request":{"url":"https://api.github.com/repos/github-for-unity/Unity/pulls/691","id":181263534,"html_url":"https://github.com/github-for-unity/Unity/pull/691","diff_url":"https://github.com/github-for-unity/Unity/pull/691.diff","patch_url":"https://github.com/github-for-unity/Unity/pull/691.patch","issue_url":"https://api.github.com/repos/github-for-unity/Unity/issues/691","number":691,"state":"open","locked":false,"title":"Don't save the keychain before completing 2FA","user":{"login":"StanleyGoldman","id":417571,"avatar_url":"https://avatars0.githubusercontent.com/u/417571?v=4","gravatar_id":"","url":"https://api.github.com/users/StanleyGoldman","html_url":"https://github.com/StanleyGoldman","followers_url":"https://api.github.com/users/StanleyGoldman/followers","following_url":"https://api.github.com/users/StanleyGoldman/following{/other_user}","gists_url":"https://api.github.com/users/StanleyGoldman/gists{/gist_id}","starred_url":"https://api.github.com/users/StanleyGoldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanleyGoldman/subscriptions","organizations_url":"https://api.github.com/users/StanleyGoldman/orgs","repos_url":"https://api.github.com/users/StanleyGoldman/repos","events_url":"https://api.github.com/users/StanleyGoldman/events{/privacy}","received_events_url":"https://api.github.com/users/StanleyGoldman/received_events","type":"User","site_admin":true},"body":"Fixes #686 \r\n\r\n- Don't save the keychain before completing 2FA\r\n- Removing unused LoginAsync method","created_at":"2018-04-12T16:44:21Z","updated_at":"2018-04-18T14:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1c7d94078537dca1005b3d18ab57830e2b871e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":633049056,"url":"https://api.github.com/repos/github-for-unity/Unity/labels/ready-for-review","name":"ready-for-review","color":"bf4080","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/github-for-unity/Unity/pulls/691/commits","review_comments_url":"https://api.github.com/repos/github-for-unity/Unity/pulls/691/comments","review_comment_url":"https://api.github.com/repos/github-for-unity/Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github-for-unity/Unity/issues/691/comments","statuses_url":"https://api.github.com/repos/github-for-unity/Unity/statuses/80f2ba8c566c6f0e6f9c267761dae9b0c9f3a1f2","head":{"label":"github-for-unity:fixes/save-keychain-on-2fa-success","ref":"fixes/save-keychain-on-2fa-success","sha":"80f2ba8c566c6f0e6f9c267761dae9b0c9f3a1f2","user":{"login":"github-for-unity","id":28719038,"avatar_url":"https://avatars0.githubusercontent.com/u/28719038?v=4","gravatar_id":"","url":"https://api.github.com/users/github-for-unity","html_url":"https://github.com/github-for-unity","followers_url":"https://api.github.com/users/github-for-unity/followers","following_url":"https://api.github.com/users/github-for-unity/following{/other_user}","gists_url":"https://api.github.com/users/github-for-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/github-for-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-for-unity/subscriptions","organizations_url":"https://api.github.com/users/github-for-unity/orgs","repos_url":"https://api.github.com/users/github-for-unity/repos","events_url":"https://api.github.com/users/github-for-unity/events{/privacy}","received_events_url":"https://api.github.com/users/github-for-unity/received_events","type":"Organization","site_admin":false},"repo":{"id":94770860,"name":"Unity","full_name":"github-for-unity/Unity","owner":{"login":"github-for-unity","id":28719038,"avatar_url":"https://avatars0.githubusercontent.com/u/28719038?v=4","gravatar_id":"","url":"https://api.github.com/users/github-for-unity","html_url":"https://github.com/github-for-unity","followers_url":"https://api.github.com/users/github-for-unity/followers","following_url":"https://api.github.com/users/github-for-unity/following{/other_user}","gists_url":"https://api.github.com/users/github-for-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/github-for-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-for-unity/subscriptions","organizations_url":"https://api.github.com/users/github-for-unity/orgs","repos_url":"https://api.github.com/users/github-for-unity/repos","events_url":"https://api.github.com/users/github-for-unity/events{/privacy}","received_events_url":"https://api.github.com/users/github-for-unity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github-for-unity/Unity","description":"GitHub for Unity","fork":false,"url":"https://api.github.com/repos/github-for-unity/Unity","forks_url":"https://api.github.com/repos/github-for-unity/Unity/forks","keys_url":"https://api.github.com/repos/github-for-unity/Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github-for-unity/Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github-for-unity/Unity/teams","hooks_url":"https://api.github.com/repos/github-for-unity/Unity/hooks","issue_events_url":"https://api.github.com/repos/github-for-unity/Unity/issues/events{/number}","events_url":"https://api.github.com/repos/github-for-unity/Unity/events","assignees_url":"https://api.github.com/repos/github-for-unity/Unity/assignees{/user}","branches_url":"https://api.github.com/repos/github-for-unity/Unity/branches{/branch}","tags_url":"https://api.github.com/repos/github-for-unity/Unity/tags","blobs_url":"https://api.github.com/repos/github-for-unity/Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github-for-unity/Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github-for-unity/Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/github-for-unity/Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github-for-unity/Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/github-for-unity/Unity/languages","stargazers_url":"https://api.github.com/repos/github-for-unity/Unity/stargazers","contributors_url":"https://api.github.com/repos/github-for-unity/Unity/contributors","subscribers_url":"https://api.github.com/repos/github-for-unity/Unity/subscribers","subscription_url":"https://api.github.com/repos/github-for-unity/Unity/subscription","commits_url":"https://api.github.com/repos/github-for-unity/Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/github-for-unity/Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/github-for-unity/Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/github-for-unity/Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/github-for-unity/Unity/contents/{+path}","compare_url":"https://api.github.com/repos/github-for-unity/Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github-for-unity/Unity/merges","archive_url":"https://api.github.com/repos/github-for-unity/Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github-for-unity/Unity/downloads","issues_url":"https://api.github.com/repos/github-for-unity/Unity/issues{/number}","pulls_url":"https://api.github.com/repos/github-for-unity/Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/github-for-unity/Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/github-for-unity/Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github-for-unity/Unity/labels{/name}","releases_url":"https://api.github.com/repos/github-for-unity/Unity/releases{/id}","deployments_url":"https://api.github.com/repos/github-for-unity/Unity/deployments","created_at":"2017-06-19T11:44:40Z","updated_at":"2018-04-18T14:01:34Z","pushed_at":"2018-04-18T14:49:36Z","git_url":"git://github.com/github-for-unity/Unity.git","ssh_url":"git@github.com:github-for-unity/Unity.git","clone_url":"https://github.com/github-for-unity/Unity.git","svn_url":"https://github.com/github-for-unity/Unity","homepage":"https://unity.github.com/","size":15187,"stargazers_count":843,"watchers_count":843,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":134,"open_issues":89,"watchers":843,"default_branch":"master"}},"base":{"label":"github-for-unity:master","ref":"master","sha":"a0e1223327f43d08eca966cf8d0ba1636deb00cb","user":{"login":"github-for-unity","id":28719038,"avatar_url":"https://avatars0.githubusercontent.com/u/28719038?v=4","gravatar_id":"","url":"https://api.github.com/users/github-for-unity","html_url":"https://github.com/github-for-unity","followers_url":"https://api.github.com/users/github-for-unity/followers","following_url":"https://api.github.com/users/github-for-unity/following{/other_user}","gists_url":"https://api.github.com/users/github-for-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/github-for-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-for-unity/subscriptions","organizations_url":"https://api.github.com/users/github-for-unity/orgs","repos_url":"https://api.github.com/users/github-for-unity/repos","events_url":"https://api.github.com/users/github-for-unity/events{/privacy}","received_events_url":"https://api.github.com/users/github-for-unity/received_events","type":"Organization","site_admin":false},"repo":{"id":94770860,"name":"Unity","full_name":"github-for-unity/Unity","owner":{"login":"github-for-unity","id":28719038,"avatar_url":"https://avatars0.githubusercontent.com/u/28719038?v=4","gravatar_id":"","url":"https://api.github.com/users/github-for-unity","html_url":"https://github.com/github-for-unity","followers_url":"https://api.github.com/users/github-for-unity/followers","following_url":"https://api.github.com/users/github-for-unity/following{/other_user}","gists_url":"https://api.github.com/users/github-for-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/github-for-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-for-unity/subscriptions","organizations_url":"https://api.github.com/users/github-for-unity/orgs","repos_url":"https://api.github.com/users/github-for-unity/repos","events_url":"https://api.github.com/users/github-for-unity/events{/privacy}","received_events_url":"https://api.github.com/users/github-for-unity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github-for-unity/Unity","description":"GitHub for Unity","fork":false,"url":"https://api.github.com/repos/github-for-unity/Unity","forks_url":"https://api.github.com/repos/github-for-unity/Unity/forks","keys_url":"https://api.github.com/repos/github-for-unity/Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github-for-unity/Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github-for-unity/Unity/teams","hooks_url":"https://api.github.com/repos/github-for-unity/Unity/hooks","issue_events_url":"https://api.github.com/repos/github-for-unity/Unity/issues/events{/number}","events_url":"https://api.github.com/repos/github-for-unity/Unity/events","assignees_url":"https://api.github.com/repos/github-for-unity/Unity/assignees{/user}","branches_url":"https://api.github.com/repos/github-for-unity/Unity/branches{/branch}","tags_url":"https://api.github.com/repos/github-for-unity/Unity/tags","blobs_url":"https://api.github.com/repos/github-for-unity/Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github-for-unity/Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github-for-unity/Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/github-for-unity/Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github-for-unity/Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/github-for-unity/Unity/languages","stargazers_url":"https://api.github.com/repos/github-for-unity/Unity/stargazers","contributors_url":"https://api.github.com/repos/github-for-unity/Unity/contributors","subscribers_url":"https://api.github.com/repos/github-for-unity/Unity/subscribers","subscription_url":"https://api.github.com/repos/github-for-unity/Unity/subscription","commits_url":"https://api.github.com/repos/github-for-unity/Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/github-for-unity/Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/github-for-unity/Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/github-for-unity/Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/github-for-unity/Unity/contents/{+path}","compare_url":"https://api.github.com/repos/github-for-unity/Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github-for-unity/Unity/merges","archive_url":"https://api.github.com/repos/github-for-unity/Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github-for-unity/Unity/downloads","issues_url":"https://api.github.com/repos/github-for-unity/Unity/issues{/number}","pulls_url":"https://api.github.com/repos/github-for-unity/Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/github-for-unity/Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/github-for-unity/Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github-for-unity/Unity/labels{/name}","releases_url":"https://api.github.com/repos/github-for-unity/Unity/releases{/id}","deployments_url":"https://api.github.com/repos/github-for-unity/Unity/deployments","created_at":"2017-06-19T11:44:40Z","updated_at":"2018-04-18T14:01:34Z","pushed_at":"2018-04-18T14:49:36Z","git_url":"git://github.com/github-for-unity/Unity.git","ssh_url":"git@github.com:github-for-unity/Unity.git","clone_url":"https://github.com/github-for-unity/Unity.git","svn_url":"https://github.com/github-for-unity/Unity","homepage":"https://unity.github.com/","size":15187,"stargazers_count":843,"watchers_count":843,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":134,"open_issues":89,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/691"},"html":{"href":"https://github.com/github-for-unity/Unity/pull/691"},"issue":{"href":"https://api.github.com/repos/github-for-unity/Unity/issues/691"},"comments":{"href":"https://api.github.com/repos/github-for-unity/Unity/issues/691/comments"},"review_comments":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/691/comments"},"review_comment":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github-for-unity/Unity/pulls/691/commits"},"statuses":{"href":"https://api.github.com/repos/github-for-unity/Unity/statuses/80f2ba8c566c6f0e6f9c267761dae9b0c9f3a1f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shana"}}