{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/19009","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/19009/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/19009/comments","events_url":"https://api.github.com/repos/apple/swift/issues/19009/events","html_url":"https://github.com/apple/swift/pull/19009","id":354538362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjc3Mzg0","number":19009,"title":"Removed some TF attr modifiers (e.g. $dtype)","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-28T01:42:28Z","updated_at":"2018-08-28T11:59:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19009","html_url":"https://github.com/apple/swift/pull/19009","diff_url":"https://github.com/apple/swift/pull/19009.diff","patch_url":"https://github.com/apple/swift/pull/19009.patch"},"body":"Also extended attr sanity check code in TFDeabstraction::formGraphOp() to make\r\nsure for a $tensor attr, its # scalar values match the # of scalars specified in\r\nthe subsequent shape attr. e.g. We have 2 scalar elements below.\r\n\r\n```swift\r\n  let shape : TensorShape = [1, 2]\r\n  _ = #tfop(\"Const\", dtype: Float.self, value$tensor: [17.0 as Float, 18.0], shape: shape)\r\n```\r\n\r\nThese special attr modifiers are still needed:\r\n- `$tensor`: for graph lowering to know an int/double array refers to a tensor\r\n- `$shape`: for graph lowering to lower an int array to a shape attr properly\r\n- `$array`: as needed for extracting a dtype list (see https://github.com/apple/swift/pull/18992)."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/416557759","html_url":"https://github.com/apple/swift/pull/19009#issuecomment-416557759","issue_url":"https://api.github.com/repos/apple/swift/issues/19009","id":416557759,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjU1Nzc1OQ==","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T11:59:30Z","updated_at":"2018-08-28T11:59:30Z","author_association":"COLLABORATOR","body":"Tests passed:\r\nhttps://ci-external.swift.org/view/Pull%20Request/job/swift-PR-TensorFlow-Linux/756/\r\nhttps://ci-external.swift.org/view/Pull%20Request/job/swift-PR-TensorFlow-Linux-gpu/54/"}}
{"actor":{"display_login":"mhong"}}