{"action":"created","comment":{"url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/comments/215800594","pull_request_review_id":153149547,"id":215800594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgwMDU5NA==","diff_hunk":"@@ -116,16 +141,21 @@ if (UNIX)\n     install(FILES       \"${CMAKE_CURRENT_BINARY_DIR}/libgraphqlparser.pc\"\n             DESTINATION \"${CMAKE_INSTALL_PREFIX}/lib/pkgconfig\")\n   endif()\n-endif()\n \n-IF (test)\n-  ADD_SUBDIRECTORY(test)\n+  IF (test)\n+    ADD_SUBDIRECTORY(test)\n \n-  if(UNIX)\n-    # setup valgrind\n-    ADD_CUSTOM_TARGET(memcheck\n-      valgrind --leak-check=full --suppressions=./test/valgrind.supp --dsymutil=yes --error-exitcode=1 ./test/runTests  >/dev/null\n-    )\n-  endif()\n+    if(UNIX)","path":"CMakeLists.txt","position":79,"original_position":79,"commit_id":"c06cad636840b871e038b49c1999e78b397dd48f","original_commit_id":"c06cad636840b871e038b49c1999e78b397dd48f","user":{"login":"wravery","id":6502881,"node_id":"MDQ6VXNlcjY1MDI4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6502881?v=4","gravatar_id":"","url":"https://api.github.com/users/wravery","html_url":"https://github.com/wravery","followers_url":"https://api.github.com/users/wravery/followers","following_url":"https://api.github.com/users/wravery/following{/other_user}","gists_url":"https://api.github.com/users/wravery/gists{/gist_id}","starred_url":"https://api.github.com/users/wravery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wravery/subscriptions","organizations_url":"https://api.github.com/users/wravery/orgs","repos_url":"https://api.github.com/users/wravery/repos","events_url":"https://api.github.com/users/wravery/events{/privacy}","received_events_url":"https://api.github.com/users/wravery/received_events","type":"User","site_admin":false},"body":"I'm not sure `valgrind` is available on Windows, I'll check. It might be better to nest the `if(UNIX)` inside of `if(test)` though, so if there are tests that run equally well on Windows (or that can be made to run there) then they can go outside of the platform check.","created_at":"2018-09-06T22:44:43Z","updated_at":"2018-09-06T22:44:43Z","html_url":"https://github.com/graphql/libgraphqlparser/pull/67#discussion_r215800594","pull_request_url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/comments/215800594"},"html":{"href":"https://github.com/graphql/libgraphqlparser/pull/67#discussion_r215800594"},"pull_request":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67"}},"in_reply_to_id":215725968},"pull_request":{"url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67","id":203966630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTY2NjMw","html_url":"https://github.com/graphql/libgraphqlparser/pull/67","diff_url":"https://github.com/graphql/libgraphqlparser/pull/67.diff","patch_url":"https://github.com/graphql/libgraphqlparser/pull/67.patch","issue_url":"https://api.github.com/repos/graphql/libgraphqlparser/issues/67","number":67,"state":"open","locked":false,"title":"Start building as a shared library on Windows (DLL)","user":{"login":"wravery","id":6502881,"node_id":"MDQ6VXNlcjY1MDI4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6502881?v=4","gravatar_id":"","url":"https://api.github.com/users/wravery","html_url":"https://github.com/wravery","followers_url":"https://api.github.com/users/wravery/followers","following_url":"https://api.github.com/users/wravery/following{/other_user}","gists_url":"https://api.github.com/users/wravery/gists{/gist_id}","starred_url":"https://api.github.com/users/wravery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wravery/subscriptions","organizations_url":"https://api.github.com/users/wravery/orgs","repos_url":"https://api.github.com/users/wravery/repos","events_url":"https://api.github.com/users/wravery/events{/privacy}","received_events_url":"https://api.github.com/users/wravery/received_events","type":"User","site_admin":false},"body":"This is a potential fix for Issue #39. It depends on having python2 and winflexbison in the program path because the output of flex and bison is a little different with the --wincompat flag. We can't just use the checked in versions of those files on Windows.\r\n\r\nAlternatively, [Microsoft/vcpkg ](https://github.com/Microsoft/vcpkg) can acquire those tools on demand for Windows. I have a pull request to that project (#3953) to add a port for this library, it patches the CMakeList.txt file to add these tools to the path without requiring a separate install on Windows. The same port works on the Linux version of vcpkg as well.","created_at":"2018-07-25T21:19:29Z","updated_at":"2018-09-06T22:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26f66223ec893054a118078c261d7fecfaff752","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":242194478,"node_id":"MDU6TGFiZWwyNDIxOTQ0Nzg=","url":"https://api.github.com/repos/graphql/libgraphqlparser/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67/commits","review_comments_url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67/comments","review_comment_url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql/libgraphqlparser/issues/67/comments","statuses_url":"https://api.github.com/repos/graphql/libgraphqlparser/statuses/c06cad636840b871e038b49c1999e78b397dd48f","head":{"label":"wravery:master","ref":"master","sha":"c06cad636840b871e038b49c1999e78b397dd48f","user":{"login":"wravery","id":6502881,"node_id":"MDQ6VXNlcjY1MDI4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6502881?v=4","gravatar_id":"","url":"https://api.github.com/users/wravery","html_url":"https://github.com/wravery","followers_url":"https://api.github.com/users/wravery/followers","following_url":"https://api.github.com/users/wravery/following{/other_user}","gists_url":"https://api.github.com/users/wravery/gists{/gist_id}","starred_url":"https://api.github.com/users/wravery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wravery/subscriptions","organizations_url":"https://api.github.com/users/wravery/orgs","repos_url":"https://api.github.com/users/wravery/repos","events_url":"https://api.github.com/users/wravery/events{/privacy}","received_events_url":"https://api.github.com/users/wravery/received_events","type":"User","site_admin":false},"repo":{"id":142351355,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNTEzNTU=","name":"libgraphqlparser","full_name":"wravery/libgraphqlparser","owner":{"login":"wravery","id":6502881,"node_id":"MDQ6VXNlcjY1MDI4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6502881?v=4","gravatar_id":"","url":"https://api.github.com/users/wravery","html_url":"https://github.com/wravery","followers_url":"https://api.github.com/users/wravery/followers","following_url":"https://api.github.com/users/wravery/following{/other_user}","gists_url":"https://api.github.com/users/wravery/gists{/gist_id}","starred_url":"https://api.github.com/users/wravery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wravery/subscriptions","organizations_url":"https://api.github.com/users/wravery/orgs","repos_url":"https://api.github.com/users/wravery/repos","events_url":"https://api.github.com/users/wravery/events{/privacy}","received_events_url":"https://api.github.com/users/wravery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wravery/libgraphqlparser","description":"A GraphQL query parser in C++ with C and C++ APIs","fork":true,"url":"https://api.github.com/repos/wravery/libgraphqlparser","forks_url":"https://api.github.com/repos/wravery/libgraphqlparser/forks","keys_url":"https://api.github.com/repos/wravery/libgraphqlparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wravery/libgraphqlparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wravery/libgraphqlparser/teams","hooks_url":"https://api.github.com/repos/wravery/libgraphqlparser/hooks","issue_events_url":"https://api.github.com/repos/wravery/libgraphqlparser/issues/events{/number}","events_url":"https://api.github.com/repos/wravery/libgraphqlparser/events","assignees_url":"https://api.github.com/repos/wravery/libgraphqlparser/assignees{/user}","branches_url":"https://api.github.com/repos/wravery/libgraphqlparser/branches{/branch}","tags_url":"https://api.github.com/repos/wravery/libgraphqlparser/tags","blobs_url":"https://api.github.com/repos/wravery/libgraphqlparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wravery/libgraphqlparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wravery/libgraphqlparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/wravery/libgraphqlparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wravery/libgraphqlparser/statuses/{sha}","languages_url":"https://api.github.com/repos/wravery/libgraphqlparser/languages","stargazers_url":"https://api.github.com/repos/wravery/libgraphqlparser/stargazers","contributors_url":"https://api.github.com/repos/wravery/libgraphqlparser/contributors","subscribers_url":"https://api.github.com/repos/wravery/libgraphqlparser/subscribers","subscription_url":"https://api.github.com/repos/wravery/libgraphqlparser/subscription","commits_url":"https://api.github.com/repos/wravery/libgraphqlparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/wravery/libgraphqlparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/wravery/libgraphqlparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/wravery/libgraphqlparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/wravery/libgraphqlparser/contents/{+path}","compare_url":"https://api.github.com/repos/wravery/libgraphqlparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wravery/libgraphqlparser/merges","archive_url":"https://api.github.com/repos/wravery/libgraphqlparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wravery/libgraphqlparser/downloads","issues_url":"https://api.github.com/repos/wravery/libgraphqlparser/issues{/number}","pulls_url":"https://api.github.com/repos/wravery/libgraphqlparser/pulls{/number}","milestones_url":"https://api.github.com/repos/wravery/libgraphqlparser/milestones{/number}","notifications_url":"https://api.github.com/repos/wravery/libgraphqlparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wravery/libgraphqlparser/labels{/name}","releases_url":"https://api.github.com/repos/wravery/libgraphqlparser/releases{/id}","deployments_url":"https://api.github.com/repos/wravery/libgraphqlparser/deployments","created_at":"2018-07-25T20:36:40Z","updated_at":"2018-07-26T01:41:37Z","pushed_at":"2018-07-26T01:41:35Z","git_url":"git://github.com/wravery/libgraphqlparser.git","ssh_url":"git@github.com:wravery/libgraphqlparser.git","clone_url":"https://github.com/wravery/libgraphqlparser.git","svn_url":"https://github.com/wravery/libgraphqlparser","homepage":"","size":284,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql:master","ref":"master","sha":"9d55a3c2d0afb9b1024b380858b584b39ff8001e","user":{"login":"graphql","id":12972006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTcyMDA2","avatar_url":"https://avatars0.githubusercontent.com/u/12972006?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql","html_url":"https://github.com/graphql","followers_url":"https://api.github.com/users/graphql/followers","following_url":"https://api.github.com/users/graphql/following{/other_user}","gists_url":"https://api.github.com/users/graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql/subscriptions","organizations_url":"https://api.github.com/users/graphql/orgs","repos_url":"https://api.github.com/users/graphql/repos","events_url":"https://api.github.com/users/graphql/events{/privacy}","received_events_url":"https://api.github.com/users/graphql/received_events","type":"Organization","site_admin":false},"repo":{"id":39927385,"node_id":"MDEwOlJlcG9zaXRvcnkzOTkyNzM4NQ==","name":"libgraphqlparser","full_name":"graphql/libgraphqlparser","owner":{"login":"graphql","id":12972006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTcyMDA2","avatar_url":"https://avatars0.githubusercontent.com/u/12972006?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql","html_url":"https://github.com/graphql","followers_url":"https://api.github.com/users/graphql/followers","following_url":"https://api.github.com/users/graphql/following{/other_user}","gists_url":"https://api.github.com/users/graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql/subscriptions","organizations_url":"https://api.github.com/users/graphql/orgs","repos_url":"https://api.github.com/users/graphql/repos","events_url":"https://api.github.com/users/graphql/events{/privacy}","received_events_url":"https://api.github.com/users/graphql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql/libgraphqlparser","description":"A GraphQL query parser in C++ with C and C++ APIs","fork":false,"url":"https://api.github.com/repos/graphql/libgraphqlparser","forks_url":"https://api.github.com/repos/graphql/libgraphqlparser/forks","keys_url":"https://api.github.com/repos/graphql/libgraphqlparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql/libgraphqlparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql/libgraphqlparser/teams","hooks_url":"https://api.github.com/repos/graphql/libgraphqlparser/hooks","issue_events_url":"https://api.github.com/repos/graphql/libgraphqlparser/issues/events{/number}","events_url":"https://api.github.com/repos/graphql/libgraphqlparser/events","assignees_url":"https://api.github.com/repos/graphql/libgraphqlparser/assignees{/user}","branches_url":"https://api.github.com/repos/graphql/libgraphqlparser/branches{/branch}","tags_url":"https://api.github.com/repos/graphql/libgraphqlparser/tags","blobs_url":"https://api.github.com/repos/graphql/libgraphqlparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql/libgraphqlparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql/libgraphqlparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql/libgraphqlparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql/libgraphqlparser/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql/libgraphqlparser/languages","stargazers_url":"https://api.github.com/repos/graphql/libgraphqlparser/stargazers","contributors_url":"https://api.github.com/repos/graphql/libgraphqlparser/contributors","subscribers_url":"https://api.github.com/repos/graphql/libgraphqlparser/subscribers","subscription_url":"https://api.github.com/repos/graphql/libgraphqlparser/subscription","commits_url":"https://api.github.com/repos/graphql/libgraphqlparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql/libgraphqlparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql/libgraphqlparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql/libgraphqlparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql/libgraphqlparser/contents/{+path}","compare_url":"https://api.github.com/repos/graphql/libgraphqlparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql/libgraphqlparser/merges","archive_url":"https://api.github.com/repos/graphql/libgraphqlparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql/libgraphqlparser/downloads","issues_url":"https://api.github.com/repos/graphql/libgraphqlparser/issues{/number}","pulls_url":"https://api.github.com/repos/graphql/libgraphqlparser/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql/libgraphqlparser/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql/libgraphqlparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql/libgraphqlparser/labels{/name}","releases_url":"https://api.github.com/repos/graphql/libgraphqlparser/releases{/id}","deployments_url":"https://api.github.com/repos/graphql/libgraphqlparser/deployments","created_at":"2015-07-30T02:36:22Z","updated_at":"2018-09-06T18:32:21Z","pushed_at":"2018-09-06T09:16:04Z","git_url":"git://github.com/graphql/libgraphqlparser.git","ssh_url":"git@github.com:graphql/libgraphqlparser.git","clone_url":"https://github.com/graphql/libgraphqlparser.git","svn_url":"https://github.com/graphql/libgraphqlparser","homepage":"","size":276,"stargazers_count":581,"watchers_count":581,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":5,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67"},"html":{"href":"https://github.com/graphql/libgraphqlparser/pull/67"},"issue":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/issues/67"},"comments":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/graphql/libgraphqlparser/statuses/c06cad636840b871e038b49c1999e78b397dd48f"}},"author_association":"NONE"}}
{"actor":{"display_login":"wravery"}}