{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/174092743","pull_request_review_id":103385349,"id":174092743,"diff_hunk":"@@ -52,7 +55,7 @@ def get_node_sw(n)\n                #fallback to something default\n                iface=n[:crowbar_ohai][:switch_config].keys[0]\n             end\n-            sw_name=n[:crowbar_ohai][:switch_config][iface][:switch_name]\n+            return n[:crowbar_ohai][:switch_config].fetch(iface, switch_name: -1)[:switch_name]","path":"chef/cookbooks/swift/libraries/rack_awareness.rb","position":17,"original_position":17,"commit_id":"a1ed6d0eb24adb09a42ef92286916808ac5e664b","original_commit_id":"a1ed6d0eb24adb09a42ef92286916808ac5e664b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/RedundantReturn: Redundant return detected. (https://github.com/bbatsov/ruby-style-guide#no-explicit-return)","created_at":"2018-03-13T11:15:44Z","updated_at":"2018-03-13T11:15:44Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1585#discussion_r174092743","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/174092743"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1585#discussion_r174092743"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585","id":174627446,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/1585","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1585.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1585.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1585","number":1585,"state":"open","locked":false,"title":"swift: Fix switch detection (bsc#1075015)","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"1. The addresses in `crowbar_wall` are full CIDR entries so netmask\r\n   needs to be removed before comparing to plain `storage_ip`.\r\n2. Sometimes switch_config is not fully populated for all nodes (yet).\r\n   Fall back to default in such cases.\r\n\r\n(cherry picked from commit 186ebc0213234ff40f32408dd4bc28692e1812e6)\r\n\r\nbackport of #1538 ","created_at":"2018-03-13T11:15:39Z","updated_at":"2018-03-13T11:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c73cebfe53179f5aa30f2a85261c822638c72db2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"toabctl","id":276317,"avatar_url":"https://avatars0.githubusercontent.com/u/276317?v=4","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},{"login":"rhafer","id":373399,"avatar_url":"https://avatars2.githubusercontent.com/u/373399?v=4","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars1.githubusercontent.com/u/841385?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},{"login":"JanZerebecki","id":7452727,"avatar_url":"https://avatars1.githubusercontent.com/u/7452727?v=4","gravatar_id":"","url":"https://api.github.com/users/JanZerebecki","html_url":"https://github.com/JanZerebecki","followers_url":"https://api.github.com/users/JanZerebecki/followers","following_url":"https://api.github.com/users/JanZerebecki/following{/other_user}","gists_url":"https://api.github.com/users/JanZerebecki/gists{/gist_id}","starred_url":"https://api.github.com/users/JanZerebecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanZerebecki/subscriptions","organizations_url":"https://api.github.com/users/JanZerebecki/orgs","repos_url":"https://api.github.com/users/JanZerebecki/repos","events_url":"https://api.github.com/users/JanZerebecki/events{/privacy}","received_events_url":"https://api.github.com/users/JanZerebecki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":627890491,"url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/backport%20from%20SOC8","name":"backport from SOC8","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1585/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a1ed6d0eb24adb09a42ef92286916808ac5e664b","head":{"label":"skazi0:swift-no-switch-bp","ref":"swift-no-switch-bp","sha":"a1ed6d0eb24adb09a42ef92286916808ac5e664b","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"repo":{"id":62718880,"name":"crowbar-openstack","full_name":"skazi0/crowbar-openstack","owner":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skazi0/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/skazi0/crowbar-openstack","forks_url":"https://api.github.com/repos/skazi0/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/skazi0/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skazi0/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skazi0/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/skazi0/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/skazi0/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/skazi0/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/skazi0/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/skazi0/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skazi0/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/skazi0/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/skazi0/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/skazi0/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/skazi0/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/skazi0/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/skazi0/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/skazi0/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/skazi0/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/skazi0/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skazi0/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/skazi0/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skazi0/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/skazi0/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/skazi0/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/skazi0/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skazi0/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/skazi0/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/skazi0/crowbar-openstack/deployments","created_at":"2016-07-06T12:20:57Z","updated_at":"2017-03-30T10:43:07Z","pushed_at":"2018-03-13T11:14:04Z","git_url":"git://github.com/skazi0/crowbar-openstack.git","ssh_url":"git@github.com:skazi0/crowbar-openstack.git","clone_url":"https://github.com/skazi0/crowbar-openstack.git","svn_url":"https://github.com/skazi0/crowbar-openstack","homepage":null,"size":20583,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:stable/4.0","ref":"stable/4.0","sha":"113e2c87443ea6b090534db3985a006e3aab0da9","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-03-09T05:07:31Z","pushed_at":"2018-03-13T11:15:39Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":20842,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":72,"license":null,"forks":79,"open_issues":72,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1585"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1585"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a1ed6d0eb24adb09a42ef92286916808ac5e664b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}