{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/221078194","pull_request_review_id":159641384,"id":221078194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTA3ODE5NA==","diff_hunk":"@@ -136,12 +161,12 @@ public void InflictDamage(Actor self, Actor attacker, Damage damage, bool ignore\n \t\t\t\tPreviousDamageState = oldState,\n \t\t\t};\n \n-\t\t\tforeach (var nd in self.TraitsImplementing<INotifyDamage>()\n-\t\t\t\t\t.Concat(self.Owner.PlayerActor.TraitsImplementing<INotifyDamage>()))\n+\t\t\tforeach (var nd in notifyDamage","path":"OpenRA.Mods.Common/Traits/Health.cs","position":100,"original_position":75,"commit_id":"d260b696d673a1939b4c2425964324949a9acf3a","original_commit_id":"f8c25fae52ad77d3e5ed12e2ef6ce6730afb91d2","user":{"login":"pchote","id":167819,"node_id":"MDQ6VXNlcjE2NzgxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/167819?v=4","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Likewise here","created_at":"2018-09-27T21:10:23Z","updated_at":"2018-09-27T21:20:29Z","html_url":"https://github.com/OpenRA/OpenRA/pull/15629#discussion_r221078194","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/221078194"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/15629#discussion_r221078194"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629","id":217000562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAwNTYy","html_url":"https://github.com/OpenRA/OpenRA/pull/15629","diff_url":"https://github.com/OpenRA/OpenRA/pull/15629.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/15629.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/15629","number":15629,"state":"open","locked":false,"title":"Minor performance optimizations for InflictDamage/kills","user":{"login":"reaperrr","id":2857877,"node_id":"MDQ6VXNlcjI4NTc4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"body":"I don't expect any of this to make a noticable difference, but combined it might still help a little bit in reducing #9142.\r\n\r\nSee individual commit messages for more details where the code might not be immediately self-explanatory.","created_at":"2018-09-20T14:48:12Z","updated_at":"2018-09-27T21:20:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975c295cc4a0da75b9936b3e4e90c2a8cf5cf5b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118143255,"node_id":"MDU6TGFiZWwxMTgxNDMyNTU=","url":"https://api.github.com/repos/OpenRA/OpenRA/labels/PR:%20Needs%20+2","name":"PR: Needs +2","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/15629/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/d260b696d673a1939b4c2425964324949a9acf3a","head":{"label":"reaperrr:inflict-dmg-perf","ref":"inflict-dmg-perf","sha":"d260b696d673a1939b4c2425964324949a9acf3a","user":{"login":"reaperrr","id":2857877,"node_id":"MDQ6VXNlcjI4NTc4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"repo":{"id":6804707,"node_id":"MDEwOlJlcG9zaXRvcnk2ODA0NzA3","name":"OpenRA","full_name":"reaperrr/OpenRA","private":false,"owner":{"login":"reaperrr","id":2857877,"node_id":"MDQ6VXNlcjI4NTc4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/reaperrr/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX. Bugs at http://bugs.open-ra.org/","fork":true,"url":"https://api.github.com/repos/reaperrr/OpenRA","forks_url":"https://api.github.com/repos/reaperrr/OpenRA/forks","keys_url":"https://api.github.com/repos/reaperrr/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperrr/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperrr/OpenRA/teams","hooks_url":"https://api.github.com/repos/reaperrr/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/reaperrr/OpenRA/events","assignees_url":"https://api.github.com/repos/reaperrr/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/reaperrr/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/reaperrr/OpenRA/tags","blobs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperrr/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperrr/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperrr/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperrr/OpenRA/languages","stargazers_url":"https://api.github.com/repos/reaperrr/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/reaperrr/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/reaperrr/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/reaperrr/OpenRA/subscription","commits_url":"https://api.github.com/repos/reaperrr/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperrr/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperrr/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaperrr/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/reaperrr/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperrr/OpenRA/merges","archive_url":"https://api.github.com/repos/reaperrr/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperrr/OpenRA/downloads","issues_url":"https://api.github.com/repos/reaperrr/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/reaperrr/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperrr/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperrr/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperrr/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/reaperrr/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/reaperrr/OpenRA/deployments","created_at":"2012-11-21T23:13:26Z","updated_at":"2015-09-20T21:10:57Z","pushed_at":"2018-09-27T15:54:46Z","git_url":"git://github.com/reaperrr/OpenRA.git","ssh_url":"git@github.com:reaperrr/OpenRA.git","clone_url":"https://github.com/reaperrr/OpenRA.git","svn_url":"https://github.com/reaperrr/OpenRA","homepage":"http://open-ra.org","size":137051,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"2e3f2e079ad79255fcc994ef077a93bca9137811","user":{"login":"OpenRA","id":409046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTA0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"node_id":"MDEwOlJlcG9zaXRvcnk5NTk5MDg=","name":"OpenRA","full_name":"OpenRA/OpenRA","private":false,"owner":{"login":"OpenRA","id":409046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTA0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2018-09-27T14:38:25Z","pushed_at":"2018-09-27T18:08:13Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":134855,"stargazers_count":5562,"watchers_count":5562,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1626,"mirror_url":null,"archived":false,"open_issues_count":1474,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1626,"open_issues":1474,"watchers":5562,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/15629"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/15629"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/15629/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/15629/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/d260b696d673a1939b4c2425964324949a9acf3a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pchote"}}