{"action":"created","comment":{"url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/comments/192825055","pull_request_review_id":125675867,"id":192825055,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjgyNTA1NQ==","diff_hunk":"@@ -21,7 +20,7 @@ class Signature:\n     between (r, s) and DER formatting.\n     \"\"\"\n \n-    def __init__(self, r: int, s: int):\n+    def __init__(self, r: CurveBN, s: CurveBN):","path":"umbral/signing.py","position":23,"original_position":23,"commit_id":"09832ec31a2cfb1de690940ddf61a5e013d162bd","original_commit_id":"09832ec31a2cfb1de690940ddf61a5e013d162bd","user":{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},"body":"Yep, agreed.","created_at":"2018-06-04T17:45:19Z","updated_at":"2018-06-04T17:45:19Z","html_url":"https://github.com/nucypher/pyUmbral/pull/159#discussion_r192825055","pull_request_url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/comments/192825055"},"html":{"href":"https://github.com/nucypher/pyUmbral/pull/159#discussion_r192825055"},"pull_request":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159"}},"in_reply_to_id":192809424},"pull_request":{"url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159","id":191746730,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzQ2NzMw","html_url":"https://github.com/nucypher/pyUmbral/pull/159","diff_url":"https://github.com/nucypher/pyUmbral/pull/159.diff","patch_url":"https://github.com/nucypher/pyUmbral/pull/159.patch","issue_url":"https://api.github.com/repos/nucypher/pyUmbral/issues/159","number":159,"state":"open","locked":false,"title":"Simplified API","user":{"login":"cygnusv","id":2564234,"node_id":"MDQ6VXNlcjI1NjQyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2564234?v=4","gravatar_id":"","url":"https://api.github.com/users/cygnusv","html_url":"https://github.com/cygnusv","followers_url":"https://api.github.com/users/cygnusv/followers","following_url":"https://api.github.com/users/cygnusv/following{/other_user}","gists_url":"https://api.github.com/users/cygnusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cygnusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cygnusv/subscriptions","organizations_url":"https://api.github.com/users/cygnusv/orgs","repos_url":"https://api.github.com/users/cygnusv/repos","events_url":"https://api.github.com/users/cygnusv/events{/privacy}","received_events_url":"https://api.github.com/users/cygnusv/received_events","type":"User","site_admin":false},"body":"## What this does: ##\r\nThis PR provides a slightly simplified API for pyUmbral. In particular, removes all redundant arguments from public and private methods that could be obtained by other means (primarily, from a neighboring argument), such as `params` and correctness keys. The result is not only that the interface is simplified, but also that there is less surface for misuse. \r\n\r\n* Simplified public API for `umbral.pre` and `umbral.fragments`:\r\n    * Methods now only take Umbral keys as arguments, rather than primitive types (Point, CurveBN).\r\n    * Remove unnecessary arguments from public facing and internal methods when they can be extracted from a `Capsule`, `UmbralPublicKey` or `UmbralPrivateKey`.\r\n    * Adapts the test suite to new simplified API\r\n* Adds a new set of tests in `test_simple_api` that goes through the Umbral lifecycle with intermediate serialization/deserialization, in order to better capture a real use of pyUmbral.\r\n* Several bugfixes: \r\n    * Fix `Signature` to account for the order of the curve (hence adding support to non-default curves)\r\n         * Uses `CurveBN` instead of `int`\r\n         * `Signature.from_bytes` takes an additional argument 'curve'\r\n    * Fixes a bug in the deserialization method in `Capsule`, `KFrag`, `CapsuleFrag`, and `CorrectnessProof` for non-default curves, due to not passing the curve to `ByteStringSplitter`.\r\n    * Fixes a bug in `Capsule.attach_cfrag()` that allowed to attach incorrect `CFrag`\r\n* Other improvements:\r\n    * Adds a getter in `Capsule` for correctness keys\r\n    * Add `__bytes__` to `UmbralPrivateKey`\r\n    * Removes `pre.CHACHA20_KEY_SIZE` constant and uses `dem.DEM_KEYSIZE` instead\r\n    * Add `__eq__` method to `UmbralParameters`\r\n\r\n","created_at":"2018-05-31T13:02:28Z","updated_at":"2018-06-04T17:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c28a883a340b7b00a47b574b558e9cad19cf3a26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},{"login":"KPrasch","id":679404,"node_id":"MDQ6VXNlcjY3OTQwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/679404?v=4","gravatar_id":"","url":"https://api.github.com/users/KPrasch","html_url":"https://github.com/KPrasch","followers_url":"https://api.github.com/users/KPrasch/followers","following_url":"https://api.github.com/users/KPrasch/following{/other_user}","gists_url":"https://api.github.com/users/KPrasch/gists{/gist_id}","starred_url":"https://api.github.com/users/KPrasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KPrasch/subscriptions","organizations_url":"https://api.github.com/users/KPrasch/orgs","repos_url":"https://api.github.com/users/KPrasch/repos","events_url":"https://api.github.com/users/KPrasch/events{/privacy}","received_events_url":"https://api.github.com/users/KPrasch/received_events","type":"User","site_admin":false},{"login":"michwill","id":740600,"node_id":"MDQ6VXNlcjc0MDYwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/740600?v=4","gravatar_id":"","url":"https://api.github.com/users/michwill","html_url":"https://github.com/michwill","followers_url":"https://api.github.com/users/michwill/followers","following_url":"https://api.github.com/users/michwill/following{/other_user}","gists_url":"https://api.github.com/users/michwill/gists{/gist_id}","starred_url":"https://api.github.com/users/michwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michwill/subscriptions","organizations_url":"https://api.github.com/users/michwill/orgs","repos_url":"https://api.github.com/users/michwill/repos","events_url":"https://api.github.com/users/michwill/events{/privacy}","received_events_url":"https://api.github.com/users/michwill/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159/commits","review_comments_url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159/comments","review_comment_url":"https://api.github.com/repos/nucypher/pyUmbral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nucypher/pyUmbral/issues/159/comments","statuses_url":"https://api.github.com/repos/nucypher/pyUmbral/statuses/09832ec31a2cfb1de690940ddf61a5e013d162bd","head":{"label":"cygnusv:params-in-capsule","ref":"params-in-capsule","sha":"09832ec31a2cfb1de690940ddf61a5e013d162bd","user":{"login":"cygnusv","id":2564234,"node_id":"MDQ6VXNlcjI1NjQyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2564234?v=4","gravatar_id":"","url":"https://api.github.com/users/cygnusv","html_url":"https://github.com/cygnusv","followers_url":"https://api.github.com/users/cygnusv/followers","following_url":"https://api.github.com/users/cygnusv/following{/other_user}","gists_url":"https://api.github.com/users/cygnusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cygnusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cygnusv/subscriptions","organizations_url":"https://api.github.com/users/cygnusv/orgs","repos_url":"https://api.github.com/users/cygnusv/repos","events_url":"https://api.github.com/users/cygnusv/events{/privacy}","received_events_url":"https://api.github.com/users/cygnusv/received_events","type":"User","site_admin":false},"repo":{"id":122940535,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NDA1MzU=","name":"pyUmbral","full_name":"cygnusv/pyUmbral","owner":{"login":"cygnusv","id":2564234,"node_id":"MDQ6VXNlcjI1NjQyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2564234?v=4","gravatar_id":"","url":"https://api.github.com/users/cygnusv","html_url":"https://github.com/cygnusv","followers_url":"https://api.github.com/users/cygnusv/followers","following_url":"https://api.github.com/users/cygnusv/following{/other_user}","gists_url":"https://api.github.com/users/cygnusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cygnusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cygnusv/subscriptions","organizations_url":"https://api.github.com/users/cygnusv/orgs","repos_url":"https://api.github.com/users/cygnusv/repos","events_url":"https://api.github.com/users/cygnusv/events{/privacy}","received_events_url":"https://api.github.com/users/cygnusv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cygnusv/pyUmbral","description":"NuCypher implementation of Umbral using OpenSSL and Cryptography.io","fork":true,"url":"https://api.github.com/repos/cygnusv/pyUmbral","forks_url":"https://api.github.com/repos/cygnusv/pyUmbral/forks","keys_url":"https://api.github.com/repos/cygnusv/pyUmbral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cygnusv/pyUmbral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cygnusv/pyUmbral/teams","hooks_url":"https://api.github.com/repos/cygnusv/pyUmbral/hooks","issue_events_url":"https://api.github.com/repos/cygnusv/pyUmbral/issues/events{/number}","events_url":"https://api.github.com/repos/cygnusv/pyUmbral/events","assignees_url":"https://api.github.com/repos/cygnusv/pyUmbral/assignees{/user}","branches_url":"https://api.github.com/repos/cygnusv/pyUmbral/branches{/branch}","tags_url":"https://api.github.com/repos/cygnusv/pyUmbral/tags","blobs_url":"https://api.github.com/repos/cygnusv/pyUmbral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cygnusv/pyUmbral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cygnusv/pyUmbral/git/refs{/sha}","trees_url":"https://api.github.com/repos/cygnusv/pyUmbral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cygnusv/pyUmbral/statuses/{sha}","languages_url":"https://api.github.com/repos/cygnusv/pyUmbral/languages","stargazers_url":"https://api.github.com/repos/cygnusv/pyUmbral/stargazers","contributors_url":"https://api.github.com/repos/cygnusv/pyUmbral/contributors","subscribers_url":"https://api.github.com/repos/cygnusv/pyUmbral/subscribers","subscription_url":"https://api.github.com/repos/cygnusv/pyUmbral/subscription","commits_url":"https://api.github.com/repos/cygnusv/pyUmbral/commits{/sha}","git_commits_url":"https://api.github.com/repos/cygnusv/pyUmbral/git/commits{/sha}","comments_url":"https://api.github.com/repos/cygnusv/pyUmbral/comments{/number}","issue_comment_url":"https://api.github.com/repos/cygnusv/pyUmbral/issues/comments{/number}","contents_url":"https://api.github.com/repos/cygnusv/pyUmbral/contents/{+path}","compare_url":"https://api.github.com/repos/cygnusv/pyUmbral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cygnusv/pyUmbral/merges","archive_url":"https://api.github.com/repos/cygnusv/pyUmbral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cygnusv/pyUmbral/downloads","issues_url":"https://api.github.com/repos/cygnusv/pyUmbral/issues{/number}","pulls_url":"https://api.github.com/repos/cygnusv/pyUmbral/pulls{/number}","milestones_url":"https://api.github.com/repos/cygnusv/pyUmbral/milestones{/number}","notifications_url":"https://api.github.com/repos/cygnusv/pyUmbral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cygnusv/pyUmbral/labels{/name}","releases_url":"https://api.github.com/repos/cygnusv/pyUmbral/releases{/id}","deployments_url":"https://api.github.com/repos/cygnusv/pyUmbral/deployments","created_at":"2018-02-26T08:49:26Z","updated_at":"2018-06-01T17:19:07Z","pushed_at":"2018-06-04T15:34:39Z","git_url":"git://github.com/cygnusv/pyUmbral.git","ssh_url":"git@github.com:cygnusv/pyUmbral.git","clone_url":"https://github.com/cygnusv/pyUmbral.git","svn_url":"https://github.com/cygnusv/pyUmbral","homepage":"","size":5430,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nucypher:master","ref":"master","sha":"90a631cbd6b1d07767309420cd5af919f6a9575e","user":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"repo":{"id":115219228,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyMTkyMjg=","name":"pyUmbral","full_name":"nucypher/pyUmbral","owner":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nucypher/pyUmbral","description":"NuCypher implementation of Umbral using OpenSSL and Cryptography.io","fork":false,"url":"https://api.github.com/repos/nucypher/pyUmbral","forks_url":"https://api.github.com/repos/nucypher/pyUmbral/forks","keys_url":"https://api.github.com/repos/nucypher/pyUmbral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nucypher/pyUmbral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nucypher/pyUmbral/teams","hooks_url":"https://api.github.com/repos/nucypher/pyUmbral/hooks","issue_events_url":"https://api.github.com/repos/nucypher/pyUmbral/issues/events{/number}","events_url":"https://api.github.com/repos/nucypher/pyUmbral/events","assignees_url":"https://api.github.com/repos/nucypher/pyUmbral/assignees{/user}","branches_url":"https://api.github.com/repos/nucypher/pyUmbral/branches{/branch}","tags_url":"https://api.github.com/repos/nucypher/pyUmbral/tags","blobs_url":"https://api.github.com/repos/nucypher/pyUmbral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nucypher/pyUmbral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nucypher/pyUmbral/git/refs{/sha}","trees_url":"https://api.github.com/repos/nucypher/pyUmbral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nucypher/pyUmbral/statuses/{sha}","languages_url":"https://api.github.com/repos/nucypher/pyUmbral/languages","stargazers_url":"https://api.github.com/repos/nucypher/pyUmbral/stargazers","contributors_url":"https://api.github.com/repos/nucypher/pyUmbral/contributors","subscribers_url":"https://api.github.com/repos/nucypher/pyUmbral/subscribers","subscription_url":"https://api.github.com/repos/nucypher/pyUmbral/subscription","commits_url":"https://api.github.com/repos/nucypher/pyUmbral/commits{/sha}","git_commits_url":"https://api.github.com/repos/nucypher/pyUmbral/git/commits{/sha}","comments_url":"https://api.github.com/repos/nucypher/pyUmbral/comments{/number}","issue_comment_url":"https://api.github.com/repos/nucypher/pyUmbral/issues/comments{/number}","contents_url":"https://api.github.com/repos/nucypher/pyUmbral/contents/{+path}","compare_url":"https://api.github.com/repos/nucypher/pyUmbral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nucypher/pyUmbral/merges","archive_url":"https://api.github.com/repos/nucypher/pyUmbral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nucypher/pyUmbral/downloads","issues_url":"https://api.github.com/repos/nucypher/pyUmbral/issues{/number}","pulls_url":"https://api.github.com/repos/nucypher/pyUmbral/pulls{/number}","milestones_url":"https://api.github.com/repos/nucypher/pyUmbral/milestones{/number}","notifications_url":"https://api.github.com/repos/nucypher/pyUmbral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nucypher/pyUmbral/labels{/name}","releases_url":"https://api.github.com/repos/nucypher/pyUmbral/releases{/id}","deployments_url":"https://api.github.com/repos/nucypher/pyUmbral/deployments","created_at":"2017-12-23T20:10:04Z","updated_at":"2018-06-04T16:33:14Z","pushed_at":"2018-06-04T16:33:12Z","git_url":"git://github.com/nucypher/pyUmbral.git","ssh_url":"git@github.com:nucypher/pyUmbral.git","clone_url":"https://github.com/nucypher/pyUmbral.git","svn_url":"https://github.com/nucypher/pyUmbral","homepage":"","size":5409,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":16,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159"},"html":{"href":"https://github.com/nucypher/pyUmbral/pull/159"},"issue":{"href":"https://api.github.com/repos/nucypher/pyUmbral/issues/159"},"comments":{"href":"https://api.github.com/repos/nucypher/pyUmbral/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nucypher/pyUmbral/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/nucypher/pyUmbral/statuses/09832ec31a2cfb1de690940ddf61a5e013d162bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jMyles"}}