{"action":"created","comment":{"url":"https://api.github.com/repos/flack/quickform/pulls/comments/197371253","pull_request_review_id":131102098,"id":197371253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzM3MTI1Mw==","diff_hunk":"@@ -259,7 +259,7 @@ class HTML_QuickForm_date extends HTML_QuickForm_group\n     */\n     public function __construct($elementName = null, $elementLabel = null, $options = array(), $attributes = null)\n     {\n-        parent::__construct($elementName, $elementLabel, $attributes);\n+        parent::__construct($elementName, $elementLabel, null);","path":"lib/HTML/QuickForm/date.php","position":5,"original_position":5,"commit_id":"95c9b178bb7ebba4689cf82dabf28f242d44318c","original_commit_id":"95c9b178bb7ebba4689cf82dabf28f242d44318c","user":{"login":"flack","id":425166,"node_id":"MDQ6VXNlcjQyNTE2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/425166?v=4","gravatar_id":"","url":"https://api.github.com/users/flack","html_url":"https://github.com/flack","followers_url":"https://api.github.com/users/flack/followers","following_url":"https://api.github.com/users/flack/following{/other_user}","gists_url":"https://api.github.com/users/flack/gists{/gist_id}","starred_url":"https://api.github.com/users/flack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flack/subscriptions","organizations_url":"https://api.github.com/users/flack/orgs","repos_url":"https://api.github.com/users/flack/repos","events_url":"https://api.github.com/users/flack/events{/privacy}","received_events_url":"https://api.github.com/users/flack/received_events","type":"User","site_admin":false},"body":"in fact, this should be sufficient\r\n\r\n```php\r\nparent::__construct($elementName, $elementLabel);\r\n```\r\n\r\nAlso (and I realize that this is a preexisiting bug), I think it would be good to call `$this->setAttrbutes()` in the constructor, so that the attributes don't get lost. Because further down in the class, they are applied to the `select` element:\r\n\r\nhttps://github.com/MaybeFactor/quickform/blob/95c9b178bb7ebba4689cf82dabf28f242d44318c/lib/HTML/QuickForm/date.php#L397","created_at":"2018-06-22T08:14:33Z","updated_at":"2018-06-22T08:15:10Z","html_url":"https://github.com/flack/quickform/pull/14#discussion_r197371253","pull_request_url":"https://api.github.com/repos/flack/quickform/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/flack/quickform/pulls/comments/197371253"},"html":{"href":"https://github.com/flack/quickform/pull/14#discussion_r197371253"},"pull_request":{"href":"https://api.github.com/repos/flack/quickform/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/flack/quickform/pulls/14","id":196636917,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjM2OTE3","html_url":"https://github.com/flack/quickform/pull/14","diff_url":"https://github.com/flack/quickform/pull/14.diff","patch_url":"https://github.com/flack/quickform/pull/14.patch","issue_url":"https://api.github.com/repos/flack/quickform/issues/14","number":14,"state":"open","locked":false,"title":"Fixes for issues #12 and #13","user":{"login":"MaybeFactor","id":29883856,"node_id":"MDQ6VXNlcjI5ODgzODU2","avatar_url":"https://avatars1.githubusercontent.com/u/29883856?v=4","gravatar_id":"","url":"https://api.github.com/users/MaybeFactor","html_url":"https://github.com/MaybeFactor","followers_url":"https://api.github.com/users/MaybeFactor/followers","following_url":"https://api.github.com/users/MaybeFactor/following{/other_user}","gists_url":"https://api.github.com/users/MaybeFactor/gists{/gist_id}","starred_url":"https://api.github.com/users/MaybeFactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaybeFactor/subscriptions","organizations_url":"https://api.github.com/users/MaybeFactor/orgs","repos_url":"https://api.github.com/users/MaybeFactor/repos","events_url":"https://api.github.com/users/MaybeFactor/events{/privacy}","received_events_url":"https://api.github.com/users/MaybeFactor/received_events","type":"User","site_admin":false},"body":"Fixes for issues #12 and #13","created_at":"2018-06-22T04:47:18Z","updated_at":"2018-06-22T08:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89298ee006f51c149623c73a6f72e47cdf3049d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flack/quickform/pulls/14/commits","review_comments_url":"https://api.github.com/repos/flack/quickform/pulls/14/comments","review_comment_url":"https://api.github.com/repos/flack/quickform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flack/quickform/issues/14/comments","statuses_url":"https://api.github.com/repos/flack/quickform/statuses/95c9b178bb7ebba4689cf82dabf28f242d44318c","head":{"label":"MaybeFactor:master","ref":"master","sha":"95c9b178bb7ebba4689cf82dabf28f242d44318c","user":{"login":"MaybeFactor","id":29883856,"node_id":"MDQ6VXNlcjI5ODgzODU2","avatar_url":"https://avatars1.githubusercontent.com/u/29883856?v=4","gravatar_id":"","url":"https://api.github.com/users/MaybeFactor","html_url":"https://github.com/MaybeFactor","followers_url":"https://api.github.com/users/MaybeFactor/followers","following_url":"https://api.github.com/users/MaybeFactor/following{/other_user}","gists_url":"https://api.github.com/users/MaybeFactor/gists{/gist_id}","starred_url":"https://api.github.com/users/MaybeFactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaybeFactor/subscriptions","organizations_url":"https://api.github.com/users/MaybeFactor/orgs","repos_url":"https://api.github.com/users/MaybeFactor/repos","events_url":"https://api.github.com/users/MaybeFactor/events{/privacy}","received_events_url":"https://api.github.com/users/MaybeFactor/received_events","type":"User","site_admin":false},"repo":{"id":138254591,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNTQ1OTE=","name":"quickform","full_name":"MaybeFactor/quickform","owner":{"login":"MaybeFactor","id":29883856,"node_id":"MDQ6VXNlcjI5ODgzODU2","avatar_url":"https://avatars1.githubusercontent.com/u/29883856?v=4","gravatar_id":"","url":"https://api.github.com/users/MaybeFactor","html_url":"https://github.com/MaybeFactor","followers_url":"https://api.github.com/users/MaybeFactor/followers","following_url":"https://api.github.com/users/MaybeFactor/following{/other_user}","gists_url":"https://api.github.com/users/MaybeFactor/gists{/gist_id}","starred_url":"https://api.github.com/users/MaybeFactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaybeFactor/subscriptions","organizations_url":"https://api.github.com/users/MaybeFactor/orgs","repos_url":"https://api.github.com/users/MaybeFactor/repos","events_url":"https://api.github.com/users/MaybeFactor/events{/privacy}","received_events_url":"https://api.github.com/users/MaybeFactor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaybeFactor/quickform","description":"Forward compatible fork of HTML_QuickForm","fork":true,"url":"https://api.github.com/repos/MaybeFactor/quickform","forks_url":"https://api.github.com/repos/MaybeFactor/quickform/forks","keys_url":"https://api.github.com/repos/MaybeFactor/quickform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaybeFactor/quickform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaybeFactor/quickform/teams","hooks_url":"https://api.github.com/repos/MaybeFactor/quickform/hooks","issue_events_url":"https://api.github.com/repos/MaybeFactor/quickform/issues/events{/number}","events_url":"https://api.github.com/repos/MaybeFactor/quickform/events","assignees_url":"https://api.github.com/repos/MaybeFactor/quickform/assignees{/user}","branches_url":"https://api.github.com/repos/MaybeFactor/quickform/branches{/branch}","tags_url":"https://api.github.com/repos/MaybeFactor/quickform/tags","blobs_url":"https://api.github.com/repos/MaybeFactor/quickform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaybeFactor/quickform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaybeFactor/quickform/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaybeFactor/quickform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaybeFactor/quickform/statuses/{sha}","languages_url":"https://api.github.com/repos/MaybeFactor/quickform/languages","stargazers_url":"https://api.github.com/repos/MaybeFactor/quickform/stargazers","contributors_url":"https://api.github.com/repos/MaybeFactor/quickform/contributors","subscribers_url":"https://api.github.com/repos/MaybeFactor/quickform/subscribers","subscription_url":"https://api.github.com/repos/MaybeFactor/quickform/subscription","commits_url":"https://api.github.com/repos/MaybeFactor/quickform/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaybeFactor/quickform/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaybeFactor/quickform/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaybeFactor/quickform/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaybeFactor/quickform/contents/{+path}","compare_url":"https://api.github.com/repos/MaybeFactor/quickform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaybeFactor/quickform/merges","archive_url":"https://api.github.com/repos/MaybeFactor/quickform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaybeFactor/quickform/downloads","issues_url":"https://api.github.com/repos/MaybeFactor/quickform/issues{/number}","pulls_url":"https://api.github.com/repos/MaybeFactor/quickform/pulls{/number}","milestones_url":"https://api.github.com/repos/MaybeFactor/quickform/milestones{/number}","notifications_url":"https://api.github.com/repos/MaybeFactor/quickform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaybeFactor/quickform/labels{/name}","releases_url":"https://api.github.com/repos/MaybeFactor/quickform/releases{/id}","deployments_url":"https://api.github.com/repos/MaybeFactor/quickform/deployments","created_at":"2018-06-22T04:29:32Z","updated_at":"2018-06-22T04:45:32Z","pushed_at":"2018-06-22T04:45:31Z","git_url":"git://github.com/MaybeFactor/quickform.git","ssh_url":"git@github.com:MaybeFactor/quickform.git","clone_url":"https://github.com/MaybeFactor/quickform.git","svn_url":"https://github.com/MaybeFactor/quickform","homepage":"","size":194,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flack:master","ref":"master","sha":"f7976f3ff878bf1650d18d64d4ea95335cfdf74b","user":{"login":"flack","id":425166,"node_id":"MDQ6VXNlcjQyNTE2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/425166?v=4","gravatar_id":"","url":"https://api.github.com/users/flack","html_url":"https://github.com/flack","followers_url":"https://api.github.com/users/flack/followers","following_url":"https://api.github.com/users/flack/following{/other_user}","gists_url":"https://api.github.com/users/flack/gists{/gist_id}","starred_url":"https://api.github.com/users/flack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flack/subscriptions","organizations_url":"https://api.github.com/users/flack/orgs","repos_url":"https://api.github.com/users/flack/repos","events_url":"https://api.github.com/users/flack/events{/privacy}","received_events_url":"https://api.github.com/users/flack/received_events","type":"User","site_admin":false},"repo":{"id":9413642,"node_id":"MDEwOlJlcG9zaXRvcnk5NDEzNjQy","name":"quickform","full_name":"flack/quickform","owner":{"login":"flack","id":425166,"node_id":"MDQ6VXNlcjQyNTE2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/425166?v=4","gravatar_id":"","url":"https://api.github.com/users/flack","html_url":"https://github.com/flack","followers_url":"https://api.github.com/users/flack/followers","following_url":"https://api.github.com/users/flack/following{/other_user}","gists_url":"https://api.github.com/users/flack/gists{/gist_id}","starred_url":"https://api.github.com/users/flack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flack/subscriptions","organizations_url":"https://api.github.com/users/flack/orgs","repos_url":"https://api.github.com/users/flack/repos","events_url":"https://api.github.com/users/flack/events{/privacy}","received_events_url":"https://api.github.com/users/flack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flack/quickform","description":"Forward compatible fork of HTML_QuickForm","fork":false,"url":"https://api.github.com/repos/flack/quickform","forks_url":"https://api.github.com/repos/flack/quickform/forks","keys_url":"https://api.github.com/repos/flack/quickform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flack/quickform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flack/quickform/teams","hooks_url":"https://api.github.com/repos/flack/quickform/hooks","issue_events_url":"https://api.github.com/repos/flack/quickform/issues/events{/number}","events_url":"https://api.github.com/repos/flack/quickform/events","assignees_url":"https://api.github.com/repos/flack/quickform/assignees{/user}","branches_url":"https://api.github.com/repos/flack/quickform/branches{/branch}","tags_url":"https://api.github.com/repos/flack/quickform/tags","blobs_url":"https://api.github.com/repos/flack/quickform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flack/quickform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flack/quickform/git/refs{/sha}","trees_url":"https://api.github.com/repos/flack/quickform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flack/quickform/statuses/{sha}","languages_url":"https://api.github.com/repos/flack/quickform/languages","stargazers_url":"https://api.github.com/repos/flack/quickform/stargazers","contributors_url":"https://api.github.com/repos/flack/quickform/contributors","subscribers_url":"https://api.github.com/repos/flack/quickform/subscribers","subscription_url":"https://api.github.com/repos/flack/quickform/subscription","commits_url":"https://api.github.com/repos/flack/quickform/commits{/sha}","git_commits_url":"https://api.github.com/repos/flack/quickform/git/commits{/sha}","comments_url":"https://api.github.com/repos/flack/quickform/comments{/number}","issue_comment_url":"https://api.github.com/repos/flack/quickform/issues/comments{/number}","contents_url":"https://api.github.com/repos/flack/quickform/contents/{+path}","compare_url":"https://api.github.com/repos/flack/quickform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flack/quickform/merges","archive_url":"https://api.github.com/repos/flack/quickform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flack/quickform/downloads","issues_url":"https://api.github.com/repos/flack/quickform/issues{/number}","pulls_url":"https://api.github.com/repos/flack/quickform/pulls{/number}","milestones_url":"https://api.github.com/repos/flack/quickform/milestones{/number}","notifications_url":"https://api.github.com/repos/flack/quickform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flack/quickform/labels{/name}","releases_url":"https://api.github.com/repos/flack/quickform/releases{/id}","deployments_url":"https://api.github.com/repos/flack/quickform/deployments","created_at":"2013-04-13T12:58:30Z","updated_at":"2018-05-22T18:48:20Z","pushed_at":"2018-06-22T04:47:19Z","git_url":"git://github.com/flack/quickform.git","ssh_url":"git@github.com:flack/quickform.git","clone_url":"https://github.com/flack/quickform.git","svn_url":"https://github.com/flack/quickform","homepage":"","size":184,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":9,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flack/quickform/pulls/14"},"html":{"href":"https://github.com/flack/quickform/pull/14"},"issue":{"href":"https://api.github.com/repos/flack/quickform/issues/14"},"comments":{"href":"https://api.github.com/repos/flack/quickform/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/flack/quickform/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/flack/quickform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flack/quickform/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/flack/quickform/statuses/95c9b178bb7ebba4689cf82dabf28f242d44318c"}},"author_association":"NONE"}}
{"actor":{"display_login":"flack"}}