{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/perf.html/issues/1122","repository_url":"https://api.github.com/repos/devtools-html/perf.html","labels_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1122/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1122/comments","events_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1122/events","html_url":"https://github.com/devtools-html/perf.html/issues/1122","id":339584745,"node_id":"MDU6SXNzdWUzMzk1ODQ3NDU=","number":1122,"title":"changing profile-logic for network panel","user":{"login":"zoepage","id":562354,"node_id":"MDQ6VXNlcjU2MjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/562354?v=4","gravatar_id":"","url":"https://api.github.com/users/zoepage","html_url":"https://github.com/zoepage","followers_url":"https://api.github.com/users/zoepage/followers","following_url":"https://api.github.com/users/zoepage/following{/other_user}","gists_url":"https://api.github.com/users/zoepage/gists{/gist_id}","starred_url":"https://api.github.com/users/zoepage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoepage/subscriptions","organizations_url":"https://api.github.com/users/zoepage/orgs","repos_url":"https://api.github.com/users/zoepage/repos","events_url":"https://api.github.com/users/zoepage/events{/privacy}","received_events_url":"https://api.github.com/users/zoepage/received_events","type":"User","site_admin":false},"labels":[{"id":556223712,"node_id":"MDU6TGFiZWw1NTYyMjM3MTI=","url":"https://api.github.com/repos/devtools-html/perf.html/labels/discussion","name":"discussion","color":"1d76db","default":false},{"id":556270202,"node_id":"MDU6TGFiZWw1NTYyNzAyMDI=","url":"https://api.github.com/repos/devtools-html/perf.html/labels/markers","name":"markers","color":"c2e0c6","default":false},{"id":935434496,"node_id":"MDU6TGFiZWw5MzU0MzQ0OTY=","url":"https://api.github.com/repos/devtools-html/perf.html/labels/needs%20requirements","name":"needs requirements","color":"fbca04","default":false},{"id":988716708,"node_id":"MDU6TGFiZWw5ODg3MTY3MDg=","url":"https://api.github.com/repos/devtools-html/perf.html/labels/network%20panel","name":"network panel","color":"77ccff","default":false},{"id":556211235,"node_id":"MDU6TGFiZWw1NTYyMTEyMzU=","url":"https://api.github.com/repos/devtools-html/perf.html/labels/profile%20data","name":"profile data","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-09T19:53:31Z","updated_at":"2018-07-13T15:17:21Z","closed_at":null,"author_association":"COLLABORATOR","body":"After working on #1110, I've realized we might have to create a new profile logic for the network panel. \r\n\r\nRight now we use the tracing markers as our data source:\r\nhttps://github.com/devtools-html/perf.html/blob/65796f2124f7e67bfbab28438126682edf78b51c/src/profile-logic/profile-data.js#L1309\r\n\r\nBut this seems not a 100% fit for our needs as we either get a marker with `startTime` and `endTime`, so we can display the duration (this is good) or we just get the `startTime` and no duration (not so good). One possibility would be, we could display the `startTime` as a vertical stroke, but I am not sure if this would improve the quality of the data visualization.\r\n\r\nAnother idea that @gregtatum did bring up today was to use http://www.softwareishard.com/blog/har-12-spec/#timings (which I also discussed with @mstange last week). This is the data we are using for the network panel in devTools. That would be definitely be interesting for the network sidebar.\r\n\r\nWhat are your thoughts on this @gregtatum @mstange @past @julienw?"},"comment":{"url":"https://api.github.com/repos/devtools-html/perf.html/issues/comments/404864330","html_url":"https://github.com/devtools-html/perf.html/issues/1122#issuecomment-404864330","issue_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1122","id":404864330,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDg2NDMzMA==","user":{"login":"zoepage","id":562354,"node_id":"MDQ6VXNlcjU2MjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/562354?v=4","gravatar_id":"","url":"https://api.github.com/users/zoepage","html_url":"https://github.com/zoepage","followers_url":"https://api.github.com/users/zoepage/followers","following_url":"https://api.github.com/users/zoepage/following{/other_user}","gists_url":"https://api.github.com/users/zoepage/gists{/gist_id}","starred_url":"https://api.github.com/users/zoepage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoepage/subscriptions","organizations_url":"https://api.github.com/users/zoepage/orgs","repos_url":"https://api.github.com/users/zoepage/repos","events_url":"https://api.github.com/users/zoepage/events{/privacy}","received_events_url":"https://api.github.com/users/zoepage/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T15:17:20Z","updated_at":"2018-07-13T15:17:20Z","author_association":"COLLABORATOR","body":"> The gray rectangle seems to correspond semantically to a request for which the DNS lookup failed, which I assume will give us both start and end markers, no?\r\n\r\nYes, here we get start and end. \r\n\r\n> I guess my assumption was that if the end marker wasn't available, then the rectangle must have extended until the end of the timeline.\r\n\r\nAh, I see. Thanks for the explanation :)\r\n\r\nI was thinking about this quite some time and how I see it, we have 2 options:\r\n\r\n1. Displaying the rectangle to the end, but in a different color or opacity. Contra here? We would add more noise to the visualization.\r\n\r\n2. Displaying just the start as a stroke would indicate there was a start, but we do not have an end (, which would mean the tracking was interrupted or the data lost)."}}
{"actor":{"display_login":"zoepage"}}