{"action":"created","comment":{"url":"https://api.github.com/repos/vitchyr/multiworld/pulls/comments/212833137","pull_request_review_id":149545034,"id":212833137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgzMzEzNw==","diff_hunk":"@@ -554,15 +554,58 @@ def __init__(self,\n                  min_y_pos=.5,\n                  max_y_pos=.7,\n                  use_line=True,\n+                 num_resets_before_door_reset=1,\n+                 num_resets_before_hand_reset=1,\n+                 reset_hand_with_door=False,\n                  **kwargs\n                  ):\n         self.quick_init(locals())\n         self.max_x_pos = max_x_pos\n         self.min_y_pos = min_y_pos\n         self.max_y_pos = max_y_pos\n         self.use_line = use_line\n+        self.door_reset_counter = 0\n+        self.hand_reset_counter = 0\n+        self.num_resets_before_door_reset = num_resets_before_door_reset\n+        self.num_resets_before_hand_reset = num_resets_before_hand_reset\n+        self.reset_hand_with_door = reset_hand_with_door\n         super().__init__(goal_low=goal_low, goal_high=goal_high, **kwargs)\n \n+    def reset(self):\n+        if self.reset_hand_with_door:","path":"multiworld/envs/mujoco/sawyer_xyz/sawyer_door.py","position":22,"original_position":22,"commit_id":"28fb5a16b240420e3a42420ed2f7beebd9fe607b","original_commit_id":"28fb5a16b240420e3a42420ed2f7beebd9fe607b","user":{"login":"vitchyr","id":1297125,"node_id":"MDQ6VXNlcjEyOTcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1297125?v=4","gravatar_id":"","url":"https://api.github.com/users/vitchyr","html_url":"https://github.com/vitchyr","followers_url":"https://api.github.com/users/vitchyr/followers","following_url":"https://api.github.com/users/vitchyr/following{/other_user}","gists_url":"https://api.github.com/users/vitchyr/gists{/gist_id}","starred_url":"https://api.github.com/users/vitchyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitchyr/subscriptions","organizations_url":"https://api.github.com/users/vitchyr/orgs","repos_url":"https://api.github.com/users/vitchyr/repos","events_url":"https://api.github.com/users/vitchyr/events{/privacy}","received_events_url":"https://api.github.com/users/vitchyr/received_events","type":"User","site_admin":false},"body":"We can just get the same results by makign sure `num_resets_before_door_reset` is a multiple of `num_resets_before_hand_reset`.  We might want to do that instead of having this extra hyperparameter","created_at":"2018-08-26T17:19:44Z","updated_at":"2018-08-26T17:29:45Z","html_url":"https://github.com/vitchyr/multiworld/pull/20#discussion_r212833137","pull_request_url":"https://api.github.com/repos/vitchyr/multiworld/pulls/20","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/comments/212833137"},"html":{"href":"https://github.com/vitchyr/multiworld/pull/20#discussion_r212833137"},"pull_request":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/vitchyr/multiworld/pulls/20","id":210936508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTM2NTA4","html_url":"https://github.com/vitchyr/multiworld/pull/20","diff_url":"https://github.com/vitchyr/multiworld/pull/20.diff","patch_url":"https://github.com/vitchyr/multiworld/pull/20.patch","issue_url":"https://api.github.com/repos/vitchyr/multiworld/issues/20","number":20,"state":"open","locked":false,"title":"Arena reset pusher","user":{"login":"mdalal2020","id":21963649,"node_id":"MDQ6VXNlcjIxOTYzNjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/21963649?v=4","gravatar_id":"","url":"https://api.github.com/users/mdalal2020","html_url":"https://github.com/mdalal2020","followers_url":"https://api.github.com/users/mdalal2020/followers","following_url":"https://api.github.com/users/mdalal2020/following{/other_user}","gists_url":"https://api.github.com/users/mdalal2020/gists{/gist_id}","starred_url":"https://api.github.com/users/mdalal2020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdalal2020/subscriptions","organizations_url":"https://api.github.com/users/mdalal2020/orgs","repos_url":"https://api.github.com/users/mdalal2020/repos","events_url":"https://api.github.com/users/mdalal2020/events{/privacy}","received_events_url":"https://api.github.com/users/mdalal2020/received_events","type":"User","site_admin":false},"body":"Sawyer Door with reset free functionality - only for push and pull task for now\r\nsmall reset free changes for push and reach env\r\ntwo puck pushing env in arena - set to goal doesn't work right now (can sample goals with pucks inside each other)","created_at":"2018-08-26T06:21:21Z","updated_at":"2018-08-26T17:29:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08c1b1dfbd5a0f4582f9dc30d2317e9b47d5ae85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitchyr/multiworld/pulls/20/commits","review_comments_url":"https://api.github.com/repos/vitchyr/multiworld/pulls/20/comments","review_comment_url":"https://api.github.com/repos/vitchyr/multiworld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitchyr/multiworld/issues/20/comments","statuses_url":"https://api.github.com/repos/vitchyr/multiworld/statuses/28fb5a16b240420e3a42420ed2f7beebd9fe607b","head":{"label":"vitchyr:arena_reset_pusher","ref":"arena_reset_pusher","sha":"28fb5a16b240420e3a42420ed2f7beebd9fe607b","user":{"login":"vitchyr","id":1297125,"node_id":"MDQ6VXNlcjEyOTcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1297125?v=4","gravatar_id":"","url":"https://api.github.com/users/vitchyr","html_url":"https://github.com/vitchyr","followers_url":"https://api.github.com/users/vitchyr/followers","following_url":"https://api.github.com/users/vitchyr/following{/other_user}","gists_url":"https://api.github.com/users/vitchyr/gists{/gist_id}","starred_url":"https://api.github.com/users/vitchyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitchyr/subscriptions","organizations_url":"https://api.github.com/users/vitchyr/orgs","repos_url":"https://api.github.com/users/vitchyr/repos","events_url":"https://api.github.com/users/vitchyr/events{/privacy}","received_events_url":"https://api.github.com/users/vitchyr/received_events","type":"User","site_admin":false},"repo":{"id":136516109,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MTYxMDk=","name":"multiworld","full_name":"vitchyr/multiworld","owner":{"login":"vitchyr","id":1297125,"node_id":"MDQ6VXNlcjEyOTcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1297125?v=4","gravatar_id":"","url":"https://api.github.com/users/vitchyr","html_url":"https://github.com/vitchyr","followers_url":"https://api.github.com/users/vitchyr/followers","following_url":"https://api.github.com/users/vitchyr/following{/other_user}","gists_url":"https://api.github.com/users/vitchyr/gists{/gist_id}","starred_url":"https://api.github.com/users/vitchyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitchyr/subscriptions","organizations_url":"https://api.github.com/users/vitchyr/orgs","repos_url":"https://api.github.com/users/vitchyr/repos","events_url":"https://api.github.com/users/vitchyr/events{/privacy}","received_events_url":"https://api.github.com/users/vitchyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitchyr/multiworld","description":"Multitask Environments for RL","fork":false,"url":"https://api.github.com/repos/vitchyr/multiworld","forks_url":"https://api.github.com/repos/vitchyr/multiworld/forks","keys_url":"https://api.github.com/repos/vitchyr/multiworld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitchyr/multiworld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitchyr/multiworld/teams","hooks_url":"https://api.github.com/repos/vitchyr/multiworld/hooks","issue_events_url":"https://api.github.com/repos/vitchyr/multiworld/issues/events{/number}","events_url":"https://api.github.com/repos/vitchyr/multiworld/events","assignees_url":"https://api.github.com/repos/vitchyr/multiworld/assignees{/user}","branches_url":"https://api.github.com/repos/vitchyr/multiworld/branches{/branch}","tags_url":"https://api.github.com/repos/vitchyr/multiworld/tags","blobs_url":"https://api.github.com/repos/vitchyr/multiworld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitchyr/multiworld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitchyr/multiworld/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitchyr/multiworld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitchyr/multiworld/statuses/{sha}","languages_url":"https://api.github.com/repos/vitchyr/multiworld/languages","stargazers_url":"https://api.github.com/repos/vitchyr/multiworld/stargazers","contributors_url":"https://api.github.com/repos/vitchyr/multiworld/contributors","subscribers_url":"https://api.github.com/repos/vitchyr/multiworld/subscribers","subscription_url":"https://api.github.com/repos/vitchyr/multiworld/subscription","commits_url":"https://api.github.com/repos/vitchyr/multiworld/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitchyr/multiworld/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitchyr/multiworld/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitchyr/multiworld/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitchyr/multiworld/contents/{+path}","compare_url":"https://api.github.com/repos/vitchyr/multiworld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitchyr/multiworld/merges","archive_url":"https://api.github.com/repos/vitchyr/multiworld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitchyr/multiworld/downloads","issues_url":"https://api.github.com/repos/vitchyr/multiworld/issues{/number}","pulls_url":"https://api.github.com/repos/vitchyr/multiworld/pulls{/number}","milestones_url":"https://api.github.com/repos/vitchyr/multiworld/milestones{/number}","notifications_url":"https://api.github.com/repos/vitchyr/multiworld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitchyr/multiworld/labels{/name}","releases_url":"https://api.github.com/repos/vitchyr/multiworld/releases{/id}","deployments_url":"https://api.github.com/repos/vitchyr/multiworld/deployments","created_at":"2018-06-07T18:27:27Z","updated_at":"2018-08-22T17:21:52Z","pushed_at":"2018-08-26T08:20:57Z","git_url":"git://github.com/vitchyr/multiworld.git","ssh_url":"git@github.com:vitchyr/multiworld.git","clone_url":"https://github.com/vitchyr/multiworld.git","svn_url":"https://github.com/vitchyr/multiworld","homepage":null,"size":23372,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":2,"watchers":20,"default_branch":"master"}},"base":{"label":"vitchyr:master","ref":"master","sha":"c7d7f43583dc2e0936e5f9aa6f34fe86838b2ee0","user":{"login":"vitchyr","id":1297125,"node_id":"MDQ6VXNlcjEyOTcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1297125?v=4","gravatar_id":"","url":"https://api.github.com/users/vitchyr","html_url":"https://github.com/vitchyr","followers_url":"https://api.github.com/users/vitchyr/followers","following_url":"https://api.github.com/users/vitchyr/following{/other_user}","gists_url":"https://api.github.com/users/vitchyr/gists{/gist_id}","starred_url":"https://api.github.com/users/vitchyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitchyr/subscriptions","organizations_url":"https://api.github.com/users/vitchyr/orgs","repos_url":"https://api.github.com/users/vitchyr/repos","events_url":"https://api.github.com/users/vitchyr/events{/privacy}","received_events_url":"https://api.github.com/users/vitchyr/received_events","type":"User","site_admin":false},"repo":{"id":136516109,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MTYxMDk=","name":"multiworld","full_name":"vitchyr/multiworld","owner":{"login":"vitchyr","id":1297125,"node_id":"MDQ6VXNlcjEyOTcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1297125?v=4","gravatar_id":"","url":"https://api.github.com/users/vitchyr","html_url":"https://github.com/vitchyr","followers_url":"https://api.github.com/users/vitchyr/followers","following_url":"https://api.github.com/users/vitchyr/following{/other_user}","gists_url":"https://api.github.com/users/vitchyr/gists{/gist_id}","starred_url":"https://api.github.com/users/vitchyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitchyr/subscriptions","organizations_url":"https://api.github.com/users/vitchyr/orgs","repos_url":"https://api.github.com/users/vitchyr/repos","events_url":"https://api.github.com/users/vitchyr/events{/privacy}","received_events_url":"https://api.github.com/users/vitchyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitchyr/multiworld","description":"Multitask Environments for RL","fork":false,"url":"https://api.github.com/repos/vitchyr/multiworld","forks_url":"https://api.github.com/repos/vitchyr/multiworld/forks","keys_url":"https://api.github.com/repos/vitchyr/multiworld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitchyr/multiworld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitchyr/multiworld/teams","hooks_url":"https://api.github.com/repos/vitchyr/multiworld/hooks","issue_events_url":"https://api.github.com/repos/vitchyr/multiworld/issues/events{/number}","events_url":"https://api.github.com/repos/vitchyr/multiworld/events","assignees_url":"https://api.github.com/repos/vitchyr/multiworld/assignees{/user}","branches_url":"https://api.github.com/repos/vitchyr/multiworld/branches{/branch}","tags_url":"https://api.github.com/repos/vitchyr/multiworld/tags","blobs_url":"https://api.github.com/repos/vitchyr/multiworld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitchyr/multiworld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitchyr/multiworld/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitchyr/multiworld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitchyr/multiworld/statuses/{sha}","languages_url":"https://api.github.com/repos/vitchyr/multiworld/languages","stargazers_url":"https://api.github.com/repos/vitchyr/multiworld/stargazers","contributors_url":"https://api.github.com/repos/vitchyr/multiworld/contributors","subscribers_url":"https://api.github.com/repos/vitchyr/multiworld/subscribers","subscription_url":"https://api.github.com/repos/vitchyr/multiworld/subscription","commits_url":"https://api.github.com/repos/vitchyr/multiworld/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitchyr/multiworld/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitchyr/multiworld/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitchyr/multiworld/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitchyr/multiworld/contents/{+path}","compare_url":"https://api.github.com/repos/vitchyr/multiworld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitchyr/multiworld/merges","archive_url":"https://api.github.com/repos/vitchyr/multiworld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitchyr/multiworld/downloads","issues_url":"https://api.github.com/repos/vitchyr/multiworld/issues{/number}","pulls_url":"https://api.github.com/repos/vitchyr/multiworld/pulls{/number}","milestones_url":"https://api.github.com/repos/vitchyr/multiworld/milestones{/number}","notifications_url":"https://api.github.com/repos/vitchyr/multiworld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitchyr/multiworld/labels{/name}","releases_url":"https://api.github.com/repos/vitchyr/multiworld/releases{/id}","deployments_url":"https://api.github.com/repos/vitchyr/multiworld/deployments","created_at":"2018-06-07T18:27:27Z","updated_at":"2018-08-22T17:21:52Z","pushed_at":"2018-08-26T08:20:57Z","git_url":"git://github.com/vitchyr/multiworld.git","ssh_url":"git@github.com:vitchyr/multiworld.git","clone_url":"https://github.com/vitchyr/multiworld.git","svn_url":"https://github.com/vitchyr/multiworld","homepage":null,"size":23372,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":2,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/20"},"html":{"href":"https://github.com/vitchyr/multiworld/pull/20"},"issue":{"href":"https://api.github.com/repos/vitchyr/multiworld/issues/20"},"comments":{"href":"https://api.github.com/repos/vitchyr/multiworld/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitchyr/multiworld/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/vitchyr/multiworld/statuses/28fb5a16b240420e3a42420ed2f7beebd9fe607b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vitchyr"}}