{"action":"created","issue":{"url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/672","repository_url":"https://api.github.com/repos/mercycorps/TolaActivity","labels_url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/672/labels{/name}","comments_url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/672/comments","events_url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/672/events","html_url":"https://github.com/mercycorps/TolaActivity/issues/672","id":369724628,"node_id":"MDU6SXNzdWUzNjk3MjQ2Mjg=","number":672,"title":"Indicator setup > Targets tab: Convert LoP target to a numeric field","user":{"login":"jennyhavah","id":33670923,"node_id":"MDQ6VXNlcjMzNjcwOTIz","avatar_url":"https://avatars3.githubusercontent.com/u/33670923?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyhavah","html_url":"https://github.com/jennyhavah","followers_url":"https://api.github.com/users/jennyhavah/followers","following_url":"https://api.github.com/users/jennyhavah/following{/other_user}","gists_url":"https://api.github.com/users/jennyhavah/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyhavah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyhavah/subscriptions","organizations_url":"https://api.github.com/users/jennyhavah/orgs","repos_url":"https://api.github.com/users/jennyhavah/repos","events_url":"https://api.github.com/users/jennyhavah/events{/privacy}","received_events_url":"https://api.github.com/users/jennyhavah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sanjuroj","id":6685499,"node_id":"MDQ6VXNlcjY2ODU0OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6685499?v=4","gravatar_id":"","url":"https://api.github.com/users/sanjuroj","html_url":"https://github.com/sanjuroj","followers_url":"https://api.github.com/users/sanjuroj/followers","following_url":"https://api.github.com/users/sanjuroj/following{/other_user}","gists_url":"https://api.github.com/users/sanjuroj/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjuroj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjuroj/subscriptions","organizations_url":"https://api.github.com/users/sanjuroj/orgs","repos_url":"https://api.github.com/users/sanjuroj/repos","events_url":"https://api.github.com/users/sanjuroj/events{/privacy}","received_events_url":"https://api.github.com/users/sanjuroj/received_events","type":"User","site_admin":false},"assignees":[{"login":"sanjuroj","id":6685499,"node_id":"MDQ6VXNlcjY2ODU0OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6685499?v=4","gravatar_id":"","url":"https://api.github.com/users/sanjuroj","html_url":"https://github.com/sanjuroj","followers_url":"https://api.github.com/users/sanjuroj/followers","following_url":"https://api.github.com/users/sanjuroj/following{/other_user}","gists_url":"https://api.github.com/users/sanjuroj/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjuroj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjuroj/subscriptions","organizations_url":"https://api.github.com/users/sanjuroj/orgs","repos_url":"https://api.github.com/users/sanjuroj/repos","events_url":"https://api.github.com/users/sanjuroj/events{/privacy}","received_events_url":"https://api.github.com/users/sanjuroj/received_events","type":"User","site_admin":false},{"login":"jennyhavah","id":33670923,"node_id":"MDQ6VXNlcjMzNjcwOTIz","avatar_url":"https://avatars3.githubusercontent.com/u/33670923?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyhavah","html_url":"https://github.com/jennyhavah","followers_url":"https://api.github.com/users/jennyhavah/followers","following_url":"https://api.github.com/users/jennyhavah/following{/other_user}","gists_url":"https://api.github.com/users/jennyhavah/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyhavah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyhavah/subscriptions","organizations_url":"https://api.github.com/users/jennyhavah/orgs","repos_url":"https://api.github.com/users/jennyhavah/repos","events_url":"https://api.github.com/users/jennyhavah/events{/privacy}","received_events_url":"https://api.github.com/users/jennyhavah/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-10-12T22:01:48Z","updated_at":"2018-12-10T22:18:22Z","closed_at":null,"author_association":"COLLABORATOR","body":"Converting the LoP target to a numeric field will afford a number of future enhancements related to periodic target setup (for example, automatically calculating the LoP instead of manually entering it) and disaggregation of results.\r\n\r\n## Step one: Back up non-numeric values\r\n- [ ] Just to be cautious, preserve a backup copy of all non-numeric LoP field values along with the associated indicator, program, and country.\r\n\r\n## Step two: Execute a script that does the following\r\n- [x] 1. Check to see if the LoP value contains non-numeric values\r\n- [x] 2. If YES, the following happens:\r\n- [x] 2.1. Append a string ABOVE any existing text in the _Rationale for target_  field, so that it's noticeable and easily deleted, \"The original LoP target value was: [value here]. (The LoP target must be a number larger than zero, and cannot include letters or punctuation.)\"\r\n- [x] 2.2. Any original text in the _Rationale for target_ field is preserved under the update message. \r\n![image](https://user-images.githubusercontent.com/33670923/48574440-09c5eb80-e8c4-11e8-83a4-3ed6a528fda9.png)\r\n- [x] 3. The non-numeric value is removed from the LoP target field.\r\n- [x] 4. Because the field is empty, the validation message we already have in place should appear, \"Please enter a number larger than zero.\"\r\n\r\n## Step three: Convert the LoP field to numeric\r\n- [x] 1. I can only enter a number.\r\n- [ ] 2. Important: I am prevented from entering any symbols, including mathematical symbols like positive and negative sign. (We prefer to capture this detail in the direction of change field.)"},"comment":{"url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/comments/445995828","html_url":"https://github.com/mercycorps/TolaActivity/issues/672#issuecomment-445995828","issue_url":"https://api.github.com/repos/mercycorps/TolaActivity/issues/672","id":445995828,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTk5NTgyOA==","user":{"login":"camgnostic","id":7941355,"node_id":"MDQ6VXNlcjc5NDEzNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7941355?v=4","gravatar_id":"","url":"https://api.github.com/users/camgnostic","html_url":"https://github.com/camgnostic","followers_url":"https://api.github.com/users/camgnostic/followers","following_url":"https://api.github.com/users/camgnostic/following{/other_user}","gists_url":"https://api.github.com/users/camgnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/camgnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camgnostic/subscriptions","organizations_url":"https://api.github.com/users/camgnostic/orgs","repos_url":"https://api.github.com/users/camgnostic/repos","events_url":"https://api.github.com/users/camgnostic/events{/privacy}","received_events_url":"https://api.github.com/users/camgnostic/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T22:18:22Z","updated_at":"2018-12-10T22:18:22Z","author_association":"COLLABORATOR","body":"Per Slack - the validation of the \"+\" sign as non-numeric is a bigger lift and may appear as a GP ticket later.  For this ticket updated the validation messaging https://github.com/mercycorps/TolaActivity/pull/958"}}
{"actor":{"display_login":"camgnostic"}}