{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/202480186","pull_request_review_id":137199029,"id":202480186,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ4MDE4Ng==","diff_hunk":"@@ -106,7 +107,35 @@ def from_cache(self, cache_location):\n         return response\n \n \n-@six.add_metaclass(abc.ABCMeta)\n+class LoginABCMeta(abc.ABCMeta):\n+    \"\"\"\n+    The goal of this metaclass is to copy the docstring and signature from\n+    ._login methods, implemented in subclasses, to a .login method that is\n+    visible by the users.\n+\n+    It also inherits from the ABCMeta metaclass as _login is an abstract\n+    method.\n+\n+    \"\"\"\n+\n+    def __new__(cls, name, bases, attrs):\n+        newcls = super(LoginABCMeta, cls).__new__(cls, name, bases, attrs)\n+\n+        if '_login' in attrs and name not in ('BaseQuery', 'QueryWithLogin'):\n+            # skip theses two classes, BaseQuery and QueryWithLogin, so\n+            # below bases[0] should always be QueryWithLogin.","path":"astroquery/query.py","position":29,"original_position":29,"commit_id":"dca280aee578ddc93ce889df9f0b6063b900452e","original_commit_id":"dca280aee578ddc93ce889df9f0b6063b900452e","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"body":"Thinking about `bases[0]`, this could fail if there are multiple level of inheritance. That's probably not the case, but I need to find a better solution.","created_at":"2018-07-13T21:42:46Z","updated_at":"2018-07-13T21:42:46Z","html_url":"https://github.com/astropy/astroquery/pull/1199#discussion_r202480186","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/1199","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/202480186"},"html":{"href":"https://github.com/astropy/astroquery/pull/1199#discussion_r202480186"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1199"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/1199","id":201402943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDAyOTQz","html_url":"https://github.com/astropy/astroquery/pull/1199","diff_url":"https://github.com/astropy/astroquery/pull/1199.diff","patch_url":"https://github.com/astropy/astroquery/pull/1199.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/1199","number":1199,"state":"open","locked":false,"title":"Add docstring and signature for login","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"body":"Fix #995.\r\n\r\n```\r\nIn [1]: from astroquery.eso import Eso\r\n\r\nIn [2]: Eso.login?\r\nSignature: Eso.login(username=None, store_password=False, reenter_password=False)\r\nDocstring:\r\nLogin to the ESO User Portal.\r\n\r\nParameters\r\n----------\r\nusername : str, optional\r\n    Username to the ESO Public Portal. If not given, it should be\r\n    specified in the config file.\r\nstore_password : bool, optional\r\n    Stores the password securely in your keyring. Default is False.\r\nreenter_password : bool, optional\r\n    Asks for the password even if it is already stored in the\r\n    keyring. This is the way to overwrite an already stored passwork\r\n    on the keyring. Default is False.\r\nFile:      ~/dev/astroquery/astroquery/query.py\r\nType:      method\r\n```","created_at":"2018-07-13T21:19:53Z","updated_at":"2018-07-13T21:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e672e8ff0cb0f34fe138d87f6427a378a1d3fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/1199/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/1199/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/1199/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/dca280aee578ddc93ce889df9f0b6063b900452e","head":{"label":"saimn:fix-login-doc","ref":"fix-login-doc","sha":"dca280aee578ddc93ce889df9f0b6063b900452e","user":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"repo":{"id":139859143,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4NTkxNDM=","name":"astroquery","full_name":"saimn/astroquery","owner":{"login":"saimn","id":311639,"node_id":"MDQ6VXNlcjMxMTYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311639?v=4","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saimn/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":true,"url":"https://api.github.com/repos/saimn/astroquery","forks_url":"https://api.github.com/repos/saimn/astroquery/forks","keys_url":"https://api.github.com/repos/saimn/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimn/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimn/astroquery/teams","hooks_url":"https://api.github.com/repos/saimn/astroquery/hooks","issue_events_url":"https://api.github.com/repos/saimn/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/saimn/astroquery/events","assignees_url":"https://api.github.com/repos/saimn/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/saimn/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/saimn/astroquery/tags","blobs_url":"https://api.github.com/repos/saimn/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimn/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimn/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimn/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimn/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/saimn/astroquery/languages","stargazers_url":"https://api.github.com/repos/saimn/astroquery/stargazers","contributors_url":"https://api.github.com/repos/saimn/astroquery/contributors","subscribers_url":"https://api.github.com/repos/saimn/astroquery/subscribers","subscription_url":"https://api.github.com/repos/saimn/astroquery/subscription","commits_url":"https://api.github.com/repos/saimn/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimn/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimn/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimn/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/saimn/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/saimn/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimn/astroquery/merges","archive_url":"https://api.github.com/repos/saimn/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimn/astroquery/downloads","issues_url":"https://api.github.com/repos/saimn/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/saimn/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/saimn/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/saimn/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimn/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/saimn/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/saimn/astroquery/deployments","created_at":"2018-07-05T14:13:08Z","updated_at":"2018-07-13T17:10:29Z","pushed_at":"2018-07-13T21:25:10Z","git_url":"git://github.com/saimn/astroquery.git","ssh_url":"git@github.com:saimn/astroquery.git","clone_url":"https://github.com/saimn/astroquery.git","svn_url":"https://github.com/saimn/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":58449,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"a516abddad1c0b355a4d645016d47d8e664caa82","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg3MjY5","name":"astroquery","full_name":"astropy/astroquery","owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astroquery/deployments","created_at":"2012-06-25T20:52:07Z","updated_at":"2018-07-13T17:08:52Z","pushed_at":"2018-07-13T21:25:11Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":58435,"stargazers_count":157,"watchers_count":157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":160,"open_issues":209,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1199"},"html":{"href":"https://github.com/astropy/astroquery/pull/1199"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1199"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1199/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1199/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1199/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/dca280aee578ddc93ce889df9f0b6063b900452e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saimn"}}