{"action":"created","issue":{"url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/301","repository_url":"https://api.github.com/repos/elastacloud/parquet-dotnet","labels_url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/301/comments","events_url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/301/events","html_url":"https://github.com/elastacloud/parquet-dotnet/pull/301","id":304834711,"number":301,"title":"code cleanup using JetBrains Rider","user":{"login":"ahives","id":1687691,"avatar_url":"https://avatars3.githubusercontent.com/u/1687691?v=4","gravatar_id":"","url":"https://api.github.com/users/ahives","html_url":"https://github.com/ahives","followers_url":"https://api.github.com/users/ahives/followers","following_url":"https://api.github.com/users/ahives/following{/other_user}","gists_url":"https://api.github.com/users/ahives/gists{/gist_id}","starred_url":"https://api.github.com/users/ahives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahives/subscriptions","organizations_url":"https://api.github.com/users/ahives/orgs","repos_url":"https://api.github.com/users/ahives/repos","events_url":"https://api.github.com/users/ahives/events{/privacy}","received_events_url":"https://api.github.com/users/ahives/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-13T16:17:15Z","updated_at":"2018-03-13T17:49:55Z","closed_at":"2018-03-13T16:33:30Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/elastacloud/parquet-dotnet/pulls/301","html_url":"https://github.com/elastacloud/parquet-dotnet/pull/301","diff_url":"https://github.com/elastacloud/parquet-dotnet/pull/301.diff","patch_url":"https://github.com/elastacloud/parquet-dotnet/pull/301.patch"},"body":"### Fixes\r\n\r\nIssue #\r\n\r\n### Description\r\n\r\nMinor refactoring to make code more readable. Current tests still pass. No new code was added.\r\n\r\n- [ ] I have included unit tests validating this fix.\r\n- [ ] I have updated markdown documentation where required.\r\n\r\n<!--\r\n I UNDERSTAND THAT NO TESTS AND NO DOCUMENTATION WILL FAIL MY PULL REQUEST\r\n-->"},"comment":{"url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/comments/372757474","html_url":"https://github.com/elastacloud/parquet-dotnet/pull/301#issuecomment-372757474","issue_url":"https://api.github.com/repos/elastacloud/parquet-dotnet/issues/301","id":372757474,"user":{"login":"aloneguid","id":3155189,"avatar_url":"https://avatars3.githubusercontent.com/u/3155189?v=4","gravatar_id":"","url":"https://api.github.com/users/aloneguid","html_url":"https://github.com/aloneguid","followers_url":"https://api.github.com/users/aloneguid/followers","following_url":"https://api.github.com/users/aloneguid/following{/other_user}","gists_url":"https://api.github.com/users/aloneguid/gists{/gist_id}","starred_url":"https://api.github.com/users/aloneguid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aloneguid/subscriptions","organizations_url":"https://api.github.com/users/aloneguid/orgs","repos_url":"https://api.github.com/users/aloneguid/repos","events_url":"https://api.github.com/users/aloneguid/events{/privacy}","received_events_url":"https://api.github.com/users/aloneguid/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T17:49:55Z","updated_at":"2018-03-13T17:49:55Z","author_association":"COLLABORATOR","body":"@ahives just wanted to make this slightly clear, apologies for short responses:\r\n\r\n1. Tabs/spaces rules and coding style is set by `.editorconfig` in this solution which is supported by all major IDEs/editors, including VS 2017, Rider, IntelliJ IDEA, VS Code etc. It's quite limited in terms of rules and nothing compared to Resharper/Rider, however it's distraction-free and gives people a wider choice of tools.\r\n2. A lot of the code is formatted in a specific way to improve it's understanding which becomes more apparent when you actually start working on it.\r\n3. I'm a big supporter of product quality, tested code and extensible architecture. Rider's way of structuring code (or any other product's) is somewhere at the very bottom of my priorities.\r\n4. I strongly believe that contributing to open source repositories is a culture of adding useful functionality to original codebase, following it's ideas, existing standards and improving functionality. I expect people to follow this approach in current repository and actively doing it myself when changing other's code. I call it \"ninja coding\" i.e. try to fit in as much as you can, so that your additions are indistinguishable from the original codebase and therefore welcomed and adopted.\r\n5. I find changing code formatting almost rude, as this project is developed 100% in spare time and it's just not nice when people get the latest update with their code reformatted.\r\n\r\nOther than that, we always welcome algorithmic and speed  improvements, or contributions of any kind. \r\n"}}
{"actor":{"display_login":"aloneguid"}}