{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/43078","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/43078/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/43078/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/43078/events","html_url":"https://github.com/ansible/ansible/pull/43078","id":343061859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODEzNjEy","number":43078,"title":"Raise exception if command timeout is triggered","user":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"c7def8","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":942378949,"node_id":"MDU6TGFiZWw5NDIzNzg5NDk=","url":"https://api.github.com/repos/ansible/ansible/labels/traceback","name":"traceback","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-20T10:48:17Z","updated_at":"2018-07-27T20:54:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/43078","html_url":"https://github.com/ansible/ansible/pull/43078","diff_url":"https://github.com/ansible/ansible/pull/43078.diff","patch_url":"https://github.com/ansible/ansible/pull/43078.patch"},"body":"\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nFixes #43076\r\n\r\nIf persistent connection timeout is triggered, riase\r\nexception which will be send over socket to module code\r\ninstead of silently shutting down the socket.\r\n<!--- If you are fixing an existing issue, please include \"Fixes #nnn\" in your\r\ncommit message and your description; but you should still explain what\r\nthe change does.-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module, plugin, module or task -->\r\nbin/ansible-connection\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\n2.7\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful. -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\nBefore:\r\n```\r\nok: [ios] => {\r\n    \"changed\": false,\r\n    \"invocation\": {\r\n        \"module_args\": {\r\n            \"auth_pass\": null,\r\n            \"authorize\": null,\r\n            \"commands\": [\r\n                \"show running-config all\"\r\n            ],\r\n            \"host\": null,\r\n            \"interval\": 1,\r\n            \"match\": \"all\",\r\n            \"password\": null,\r\n            \"port\": null,\r\n            \"provider\": null,\r\n            \"retries\": 10,\r\n            \"ssh_keyfile\": null,\r\n            \"timeout\": null,\r\n            \"username\": null,\r\n            \"wait_for\": null\r\n        }\r\n    },\r\n    \"stdout\": [\r\n        \"None\"\r\n    ],\r\n    \"stdout_lines\": [\r\n        [\r\n            \"None\"\r\n        ]\r\n    ]\r\n}\r\n```\r\nAfter:\r\n```\r\n[ios]: FAILED! => {\r\n    \"changed\": false,\r\n    \"module_stderr\": \"Traceback (most recent call last):\\n  File \\\"/var/folders/8l/27cd4l3n2vnc2cpk3498__680000gn/T/ansible_BoEKEj/ansible_module_ios_command.py\\\", line 247, in <module>\\n    main()\\n  File \\\"/var/folders/8l/27cd4l3n2vnc2cpk3498__680000gn/T/ansible_BoEKEj/ansible_module_ios_command.py\\\", line 217, in main\\n    responses = run_commands(module, commands)\\n  File \\\"/var/folders/8l/27cd4l3n2vnc2cpk3498__680000gn/T/ansible_BoEKEj/ansible_modlib.zip/ansible/module_utils/network/ios/ios.py\\\", line 125, in run_commands\\n  File \\\"/var/folders/8l/27cd4l3n2vnc2cpk3498__680000gn/T/ansible_BoEKEj/ansible_modlib.zip/ansible/module_utils/connection.py\\\", line 149, in __rpc__\\nansible.module_utils.connection.ConnectionError: command timeout triggered, timeout value is 1 secs\\n\",\r\n    \"module_stdout\": \"\",\r\n    \"msg\": \"MODULE FAILURE\",\r\n    \"rc\": 1\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/408536272","html_url":"https://github.com/ansible/ansible/pull/43078#issuecomment-408536272","issue_url":"https://api.github.com/repos/ansible/ansible/issues/43078","id":408536272,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODUzNjI3Mg==","user":{"login":"ganeshrn","id":5292461,"node_id":"MDQ6VXNlcjUyOTI0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5292461?v=4","gravatar_id":"","url":"https://api.github.com/users/ganeshrn","html_url":"https://github.com/ganeshrn","followers_url":"https://api.github.com/users/ganeshrn/followers","following_url":"https://api.github.com/users/ganeshrn/following{/other_user}","gists_url":"https://api.github.com/users/ganeshrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ganeshrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganeshrn/subscriptions","organizations_url":"https://api.github.com/users/ganeshrn/orgs","repos_url":"https://api.github.com/users/ganeshrn/repos","events_url":"https://api.github.com/users/ganeshrn/events{/privacy}","received_events_url":"https://api.github.com/users/ganeshrn/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T20:54:49Z","updated_at":"2018-07-27T20:54:49Z","author_association":"MEMBER","body":"ready_for_review"}}
{"actor":{"display_login":"ganeshrn"}}