{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/213802046","pull_request_review_id":150714695,"id":213802046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzgwMjA0Ng==","diff_hunk":"@@ -55,9 +55,9 @@ InstanceImpl::InstanceImpl(Options& options, TimeSource& time_source,\n       dispatcher_(api_->allocateDispatcher(time_source)),\n       singleton_manager_(new Singleton::ManagerImpl()),\n       handler_(new ConnectionHandlerImpl(ENVOY_LOGGER(), *dispatcher_)),\n-      random_generator_(std::move(random_generator)), listener_component_factory_(*this),\n+      random_generator_(std::move(random_generator)),\n+      secret_manager_(new Secret::SecretManagerImpl()), listener_component_factory_(*this),","path":"source/server/server.cc","position":null,"original_position":6,"commit_id":"336a950130949a0162066fbacafb5bf8ae23494b","original_commit_id":"1b8e91eed1f9012283a01671ce7f06d4ac35cda8","user":{"login":"JimmyCYJ","id":28548492,"node_id":"MDQ6VXNlcjI4NTQ4NDky","avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-08-29T19:16:26Z","updated_at":"2018-08-29T19:16:26Z","html_url":"https://github.com/envoyproxy/envoy/pull/4256#discussion_r213802046","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/213802046"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4256#discussion_r213802046"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256"}},"in_reply_to_id":213767094},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256","id":210934950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTM0OTUw","html_url":"https://github.com/envoyproxy/envoy/pull/4256","diff_url":"https://github.com/envoyproxy/envoy/pull/4256.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4256.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4256","number":4256,"state":"open","locked":false,"title":"Support Envoy to fetch secrets using SDS service.","user":{"login":"JimmyCYJ","id":28548492,"node_id":"MDQ6VXNlcjI4NTQ4NDky","avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"body":"Description: Use SDS api that fetches secrets from remote SDS server. Secrets are stored in Secret Provider. Listeners and Clusters are updated when secrets are received.\r\nRisk Level: Low\r\nTesting: Unit tests and integration tests\r\nFixes #1194\r\n\r\nSigned-off-by: Jimmy Chen jimmychen.0102@gmail.com","created_at":"2018-08-26T05:20:45Z","updated_at":"2018-08-29T19:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdfdfe35a036ded2046ffbaff9a817dc295d24de","assignee":{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},{"login":"ggreenway","id":8603643,"node_id":"MDQ6VXNlcjg2MDM2NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4256/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/336a950130949a0162066fbacafb5bf8ae23494b","head":{"label":"istio:secret_provider_context","ref":"secret_provider_context","sha":"336a950130949a0162066fbacafb5bf8ae23494b","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":107700884,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MDA4ODQ=","name":"envoy","full_name":"istio/envoy","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/envoy","description":"Fork of envoy used to cherry pick critical fixes during istio-0.2","fork":true,"url":"https://api.github.com/repos/istio/envoy","forks_url":"https://api.github.com/repos/istio/envoy/forks","keys_url":"https://api.github.com/repos/istio/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/envoy/teams","hooks_url":"https://api.github.com/repos/istio/envoy/hooks","issue_events_url":"https://api.github.com/repos/istio/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/envoy/events","assignees_url":"https://api.github.com/repos/istio/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/envoy/tags","blobs_url":"https://api.github.com/repos/istio/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/envoy/languages","stargazers_url":"https://api.github.com/repos/istio/envoy/stargazers","contributors_url":"https://api.github.com/repos/istio/envoy/contributors","subscribers_url":"https://api.github.com/repos/istio/envoy/subscribers","subscription_url":"https://api.github.com/repos/istio/envoy/subscription","commits_url":"https://api.github.com/repos/istio/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/envoy/merges","archive_url":"https://api.github.com/repos/istio/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/envoy/downloads","issues_url":"https://api.github.com/repos/istio/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/envoy/labels{/name}","releases_url":"https://api.github.com/repos/istio/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/envoy/deployments","created_at":"2017-10-20T16:25:41Z","updated_at":"2018-08-27T15:15:17Z","pushed_at":"2018-08-29T19:16:22Z","git_url":"git://github.com/istio/envoy.git","ssh_url":"git@github.com:istio/envoy.git","clone_url":"https://github.com/istio/envoy.git","svn_url":"https://github.com/istio/envoy","homepage":"https://envoyproxy.github.io/","size":61438,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"28d5f4118d60f828b1453cd8ad25033f2c8e38ab","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-08-29T19:03:58Z","pushed_at":"2018-08-29T19:16:24Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":19911,"stargazers_count":6361,"watchers_count":6361,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":838,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":838,"open_issues":329,"watchers":6361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4256"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4256"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4256/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4256/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/336a950130949a0162066fbacafb5bf8ae23494b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JimmyCYJ"}}