{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153","id":218489325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDg5MzI1","html_url":"https://github.com/simp/pupmod-simp-simplib/pull/153","diff_url":"https://github.com/simp/pupmod-simp-simplib/pull/153.diff","patch_url":"https://github.com/simp/pupmod-simp-simplib/pull/153.patch","issue_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/153","number":153,"state":"closed","locked":false,"title":"(SIMP-5383) Fix bug in `puppet_settings` fact","user":{"login":"op-ct","id":8979062,"node_id":"MDQ6VXNlcjg5NzkwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8979062?v=4","gravatar_id":"","url":"https://api.github.com/users/op-ct","html_url":"https://github.com/op-ct","followers_url":"https://api.github.com/users/op-ct/followers","following_url":"https://api.github.com/users/op-ct/following{/other_user}","gists_url":"https://api.github.com/users/op-ct/gists{/gist_id}","starred_url":"https://api.github.com/users/op-ct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/op-ct/subscriptions","organizations_url":"https://api.github.com/users/op-ct/orgs","repos_url":"https://api.github.com/users/op-ct/repos","events_url":"https://api.github.com/users/op-ct/events{/privacy}","received_events_url":"https://api.github.com/users/op-ct/received_events","type":"User","site_admin":false},"body":"Before this patch, the `puppet_settings` fact incorrectly interpolated\r\nvariables using the `[main]` section's settings instead of `[master]`.\r\n\r\nA significant consequence of this has been that the fact supplies\r\n incorrect paths for `[master]` settings, notably `server_datadir`:\r\n\r\n```sh\r\n[root@puppet ~]# puppet config print --section master server_datadir\r\n  /opt/puppetlabs/server/data/puppetserver/server_data\r\n\r\n[root@puppet ~]# facter -p puppet_settings.master.server_datadir\r\n  /opt/puppetlabs/puppet/cache/server_data\r\n```\r\n\r\nAs a consequence, `pupmod::master::sysconfig` ends up using the puppet\r\nagent's vardir instead of puppetserver's (SIMP-5021), causing the\r\npuppetserver service to fail when upgrading to new versions of\r\npuppet-agent (SIMP-5383)―particularly when upgrading from SIMP 6.1 to\r\nSIMP 6.2.\r\n\r\nThis patch fixes the issue by using `Puppet.override` to temporarily set\r\nPuppet's run_mode to each section while interpolating their settings.\r\n\r\nSIMP-5021 #close #comment Fixed bug in `puppet_settings` fact\r\nSIMP-5383 #close #comment Fixed bug in `puppet_settings` fact","created_at":"2018-09-27T00:10:08Z","updated_at":"2018-09-27T18:14:48Z","closed_at":"2018-09-27T18:14:47Z","merged_at":"2018-09-27T18:14:47Z","merge_commit_sha":"f7c4a46b8a19e6af279f42acb5f65af569ac4dd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153/commits","review_comments_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153/comments","review_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/153/comments","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/statuses/6de43407fdf5dab6a2db2052e208757ca97af7f6","head":{"label":"op-ct:SIMP-5383-fix-bug-in-puppet-settings-fact","ref":"SIMP-5383-fix-bug-in-puppet-settings-fact","sha":"6de43407fdf5dab6a2db2052e208757ca97af7f6","user":{"login":"op-ct","id":8979062,"node_id":"MDQ6VXNlcjg5NzkwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8979062?v=4","gravatar_id":"","url":"https://api.github.com/users/op-ct","html_url":"https://github.com/op-ct","followers_url":"https://api.github.com/users/op-ct/followers","following_url":"https://api.github.com/users/op-ct/following{/other_user}","gists_url":"https://api.github.com/users/op-ct/gists{/gist_id}","starred_url":"https://api.github.com/users/op-ct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/op-ct/subscriptions","organizations_url":"https://api.github.com/users/op-ct/orgs","repos_url":"https://api.github.com/users/op-ct/repos","events_url":"https://api.github.com/users/op-ct/events{/privacy}","received_events_url":"https://api.github.com/users/op-ct/received_events","type":"User","site_admin":false},"repo":{"id":46080406,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA4MDQwNg==","name":"pupmod-simp-simplib","full_name":"op-ct/pupmod-simp-simplib","private":false,"owner":{"login":"op-ct","id":8979062,"node_id":"MDQ6VXNlcjg5NzkwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8979062?v=4","gravatar_id":"","url":"https://api.github.com/users/op-ct","html_url":"https://github.com/op-ct","followers_url":"https://api.github.com/users/op-ct/followers","following_url":"https://api.github.com/users/op-ct/following{/other_user}","gists_url":"https://api.github.com/users/op-ct/gists{/gist_id}","starred_url":"https://api.github.com/users/op-ct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/op-ct/subscriptions","organizations_url":"https://api.github.com/users/op-ct/orgs","repos_url":"https://api.github.com/users/op-ct/repos","events_url":"https://api.github.com/users/op-ct/events{/privacy}","received_events_url":"https://api.github.com/users/op-ct/received_events","type":"User","site_admin":false},"html_url":"https://github.com/op-ct/pupmod-simp-simplib","description":"Common SIMP functions and classes","fork":true,"url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib","forks_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/forks","keys_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/teams","hooks_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/hooks","issue_events_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/issues/events{/number}","events_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/events","assignees_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/assignees{/user}","branches_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/branches{/branch}","tags_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/tags","blobs_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/git/refs{/sha}","trees_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/statuses/{sha}","languages_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/languages","stargazers_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/stargazers","contributors_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/contributors","subscribers_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/subscribers","subscription_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/subscription","commits_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/commits{/sha}","git_commits_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/git/commits{/sha}","comments_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/comments{/number}","issue_comment_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/issues/comments{/number}","contents_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/contents/{+path}","compare_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/merges","archive_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/downloads","issues_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/issues{/number}","pulls_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/pulls{/number}","milestones_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/milestones{/number}","notifications_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/labels{/name}","releases_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/releases{/id}","deployments_url":"https://api.github.com/repos/op-ct/pupmod-simp-simplib/deployments","created_at":"2015-11-12T20:57:53Z","updated_at":"2016-05-05T20:18:46Z","pushed_at":"2018-09-27T17:42:48Z","git_url":"git://github.com/op-ct/pupmod-simp-simplib.git","ssh_url":"git@github.com:op-ct/pupmod-simp-simplib.git","clone_url":"https://github.com/op-ct/pupmod-simp-simplib.git","svn_url":"https://github.com/op-ct/pupmod-simp-simplib","homepage":null,"size":806,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simp:master","ref":"master","sha":"e01c46d86e3af6bff29d5f34a9bdaa914d3567cf","user":{"login":"simp","id":12174186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTc0MTg2","avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"repo":{"id":44264205,"node_id":"MDEwOlJlcG9zaXRvcnk0NDI2NDIwNQ==","name":"pupmod-simp-simplib","full_name":"simp/pupmod-simp-simplib","private":false,"owner":{"login":"simp","id":12174186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTc0MTg2","avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/simp/pupmod-simp-simplib","description":"Common SIMP functions and classes","fork":false,"url":"https://api.github.com/repos/simp/pupmod-simp-simplib","forks_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/forks","keys_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/teams","hooks_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/hooks","issue_events_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/events{/number}","events_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/events","assignees_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/assignees{/user}","branches_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/branches{/branch}","tags_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/tags","blobs_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/git/refs{/sha}","trees_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/statuses/{sha}","languages_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/languages","stargazers_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/stargazers","contributors_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/contributors","subscribers_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/subscribers","subscription_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/subscription","commits_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/commits{/sha}","git_commits_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/git/commits{/sha}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/comments{/number}","issue_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/comments{/number}","contents_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/contents/{+path}","compare_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/merges","archive_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/downloads","issues_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues{/number}","pulls_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls{/number}","milestones_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/milestones{/number}","notifications_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/labels{/name}","releases_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/releases{/id}","deployments_url":"https://api.github.com/repos/simp/pupmod-simp-simplib/deployments","created_at":"2015-10-14T17:22:06Z","updated_at":"2018-09-11T17:23:39Z","pushed_at":"2018-09-27T18:14:47Z","git_url":"git://github.com/simp/pupmod-simp-simplib.git","ssh_url":"git@github.com:simp/pupmod-simp-simplib.git","clone_url":"https://github.com/simp/pupmod-simp-simplib.git","svn_url":"https://github.com/simp/pupmod-simp-simplib","homepage":null,"size":1027,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153"},"html":{"href":"https://github.com/simp/pupmod-simp-simplib/pull/153"},"issue":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/153"},"comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/simp/pupmod-simp-simplib/statuses/6de43407fdf5dab6a2db2052e208757ca97af7f6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"trevor-vaughan","id":4982601,"node_id":"MDQ6VXNlcjQ5ODI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4982601?v=4","gravatar_id":"","url":"https://api.github.com/users/trevor-vaughan","html_url":"https://github.com/trevor-vaughan","followers_url":"https://api.github.com/users/trevor-vaughan/followers","following_url":"https://api.github.com/users/trevor-vaughan/following{/other_user}","gists_url":"https://api.github.com/users/trevor-vaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-vaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-vaughan/subscriptions","organizations_url":"https://api.github.com/users/trevor-vaughan/orgs","repos_url":"https://api.github.com/users/trevor-vaughan/repos","events_url":"https://api.github.com/users/trevor-vaughan/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-vaughan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":76,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"trevor-vaughan"}}