{"action":"created","issue":{"url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/8","repository_url":"https://api.github.com/repos/gigasquid/clojure-mxnet","labels_url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/8/comments","events_url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/8/events","html_url":"https://github.com/gigasquid/clojure-mxnet/pull/8","id":334739802,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjM0NTY0","number":8,"title":"Improve styles with cljfmt","user":{"login":"agilecreativity","id":4092543,"node_id":"MDQ6VXNlcjQwOTI1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4092543?v=4","gravatar_id":"","url":"https://api.github.com/users/agilecreativity","html_url":"https://github.com/agilecreativity","followers_url":"https://api.github.com/users/agilecreativity/followers","following_url":"https://api.github.com/users/agilecreativity/following{/other_user}","gists_url":"https://api.github.com/users/agilecreativity/gists{/gist_id}","starred_url":"https://api.github.com/users/agilecreativity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agilecreativity/subscriptions","organizations_url":"https://api.github.com/users/agilecreativity/orgs","repos_url":"https://api.github.com/users/agilecreativity/repos","events_url":"https://api.github.com/users/agilecreativity/events{/privacy}","received_events_url":"https://api.github.com/users/agilecreativity/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-22T04:22:35Z","updated_at":"2018-06-22T04:36:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gigasquid/clojure-mxnet/pulls/8","html_url":"https://github.com/gigasquid/clojure-mxnet/pull/8","diff_url":"https://github.com/gigasquid/clojure-mxnet/pull/8.diff","patch_url":"https://github.com/gigasquid/clojure-mxnet/pull/8.patch"},"body":"Hi @gigasquid \r\n\r\nLeverage [cljfmt](https://github.com/weavejester/cljfmt) as ways for us to use the same style for the codebase starting with the example codes. The last commit contains the script that I use\r\n\r\n- `lein cljfmt fix` #=> run the fix\r\n\r\n#### Benefit:\r\n\r\nEveryone who would be contributor can use different editor (Emacs/Vim/Cursive, etc) but we can still contribute using the same style.\r\n\r\nThe script used:\r\n\r\n```sh\r\n#!/usr/bin/env bash\r\nfor dir in $(find . -type d -depth 1 | grep -v scripts)\r\ndo\r\n  cd $dir\r\n  lein cljfmt fix\r\n  cd ..\r\ndone\r\n```\r\nIn this PR, I created added `lein-cljfmt` to the plugins vector and then create two simple scripts\r\none to check for style, and the other for fixing the style automatically.\r\n\r\nIt is very configuration and can be adjusted to your preferred styles if you like.\r\n\r\nI created this PR to only apply the format to the example codes and would love to get your feedback.\r\nI intentionally create multiple commits so you easily review please feel free to squash/cherry-pick.\r\n\r\nIf you are ok with this example I can create another pull request to format the main source code (excluding generated code) for you to review.\r\n\r\nThanks\r\nBurin"},"comment":{"url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/comments/399318017","html_url":"https://github.com/gigasquid/clojure-mxnet/pull/8#issuecomment-399318017","issue_url":"https://api.github.com/repos/gigasquid/clojure-mxnet/issues/8","id":399318017,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTMxODAxNw==","user":{"login":"agilecreativity","id":4092543,"node_id":"MDQ6VXNlcjQwOTI1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4092543?v=4","gravatar_id":"","url":"https://api.github.com/users/agilecreativity","html_url":"https://github.com/agilecreativity","followers_url":"https://api.github.com/users/agilecreativity/followers","following_url":"https://api.github.com/users/agilecreativity/following{/other_user}","gists_url":"https://api.github.com/users/agilecreativity/gists{/gist_id}","starred_url":"https://api.github.com/users/agilecreativity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agilecreativity/subscriptions","organizations_url":"https://api.github.com/users/agilecreativity/orgs","repos_url":"https://api.github.com/users/agilecreativity/repos","events_url":"https://api.github.com/users/agilecreativity/events{/privacy}","received_events_url":"https://api.github.com/users/agilecreativity/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T04:36:03Z","updated_at":"2018-06-22T04:36:03Z","author_association":"CONTRIBUTOR","body":"Hi @gigasquid,\r\n\r\nI add two more scripts to the main project, it is slightly different than the ones in examples parts\r\n\r\n- lein-cljfmt-check\r\n- lein-cljfmt-fix\r\n\r\nIf you are ok feel free to apply the change using the `lein-cljfmt-fix` script.\r\nOr let me know if you like me to adjust anything.\r\n\r\nBest,\r\n"}}
{"actor":{"display_login":"agilecreativity"}}