{"action":"created","comment":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/242944164","pull_request_review_id":186581360,"id":242944164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjk0NDE2NA==","diff_hunk":"@@ -135,15 +135,25 @@ int ArkodeSolver::init(int nout, BoutReal tstep) {\n   bool use_precon, use_jacobian, use_vector_abstol,set_linear;\n   BoutReal start_timestep, max_timestep, min_timestep,fixed_timestep;\n   bool imex,expl,impl; // Time-integration method\n-  int MXSUB = mesh->xend - mesh->xstart + 1;\n+\n+  // Compute band_width_default from actually added fields, to allow for multiple Mesh objects\n+  //\n+  // Previous implementation was equivalent to:\n+  //   int MXSUB = mesh->xend - mesh->xstart + 1;\n+  //   int band_width_default = n3Dvars()*(MXSUB+2);\n+  int band_width_default = 0;\n+  for (auto fvar : f3d) {\n+    band_width_default += fvar.var->getNx();","path":"src/solver/impls/arkode/arkode.cxx","position":13,"original_position":13,"commit_id":"3e79e20a30b05448025c96f9b85e6efe44899d0c","original_commit_id":"3e79e20a30b05448025c96f9b85e6efe44899d0c","user":{"login":"d7919","id":1793698,"node_id":"MDQ6VXNlcjE3OTM2OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1793698?v=4","gravatar_id":"","url":"https://api.github.com/users/d7919","html_url":"https://github.com/d7919","followers_url":"https://api.github.com/users/d7919/followers","following_url":"https://api.github.com/users/d7919/following{/other_user}","gists_url":"https://api.github.com/users/d7919/gists{/gist_id}","starred_url":"https://api.github.com/users/d7919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d7919/subscriptions","organizations_url":"https://api.github.com/users/d7919/orgs","repos_url":"https://api.github.com/users/d7919/repos","events_url":"https://api.github.com/users/d7919/events{/privacy}","received_events_url":"https://api.github.com/users/d7919/received_events","type":"User","site_admin":false},"body":"Isn't `MXSUB+2 /= Field3D{}.getNx()` and if so is this change intentional (or rather why is it intended)?","created_at":"2018-12-19T14:52:15Z","updated_at":"2018-12-19T14:52:15Z","html_url":"https://github.com/boutproject/BOUT-dev/pull/1470#discussion_r242944164","pull_request_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments/242944164"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1470#discussion_r242944164"},"pull_request":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470"}}},"pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470","id":239855013,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODU1MDEz","html_url":"https://github.com/boutproject/BOUT-dev/pull/1470","diff_url":"https://github.com/boutproject/BOUT-dev/pull/1470.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/1470.patch","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1470","number":1470,"state":"open","locked":false,"title":"Use namespace for global variables 'mesh' and 'dump'","user":{"login":"johnomotani","id":3958036,"node_id":"MDQ6VXNlcjM5NTgwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3958036?v=4","gravatar_id":"","url":"https://api.github.com/users/johnomotani","html_url":"https://github.com/johnomotani","followers_url":"https://api.github.com/users/johnomotani/followers","following_url":"https://api.github.com/users/johnomotani/following{/other_user}","gists_url":"https://api.github.com/users/johnomotani/gists{/gist_id}","starred_url":"https://api.github.com/users/johnomotani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnomotani/subscriptions","organizations_url":"https://api.github.com/users/johnomotani/orgs","repos_url":"https://api.github.com/users/johnomotani/repos","events_url":"https://api.github.com/users/johnomotani/events{/privacy}","received_events_url":"https://api.github.com/users/johnomotani/received_events","type":"User","site_admin":false},"body":"* Create the namespace `bout::globals` containing `Mesh* mesh` and `Datafile dump`.\r\n* In `bout.hxx` include statement `using namespace bout::globals` so no changes are needed to user code.\r\n* Remove references to global `mesh` pointer in several places in the library code.\r\n* The global pointer (renamed to `bout::globals::mesh`) is still used in many places as a default argument or if `nullptr` is passed as a `Mesh*`.\r\n* The last place depending on `bout::globals::mesh` is the solver code. See #1471.\r\n* The only changes to the tests are that the unit tests need to include `using namespace bout::globals` because they use the global mesh.\r\n* There is an unrelated change to `test-petsc_laplace`, just getting it to work and removing the binary grid file.\r\n\r\nThis implements the suggestion in #1468.","created_at":"2018-12-19T14:28:39Z","updated_at":"2018-12-19T14:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c31105d5d2eabdec03362b4f0c4671627d6e2d53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1034012246,"node_id":"MDU6TGFiZWwxMDM0MDEyMjQ2","url":"https://api.github.com/repos/boutproject/BOUT-dev/labels/proposal","name":"proposal","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1470/comments","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/3e79e20a30b05448025c96f9b85e6efe44899d0c","head":{"label":"boutproject:namespace_globals","ref":"namespace_globals","sha":"3e79e20a30b05448025c96f9b85e6efe44899d0c","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-12-16T11:42:11Z","pushed_at":"2018-12-19T14:28:40Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":44469,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":178,"watchers":31,"default_branch":"master"}},"base":{"label":"boutproject:forward_declares","ref":"forward_declares","sha":"84158718374703c4e12fdf5e016a226b8cb2613e","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-12-16T11:42:11Z","pushed_at":"2018-12-19T14:28:40Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":44469,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":178,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1470"},"issue":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1470"},"comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/3e79e20a30b05448025c96f9b85e6efe44899d0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"d7919"}}