{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/485","repository_url":"https://api.github.com/repos/OCA/maintainer-quality-tools","labels_url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/485/labels{/name}","comments_url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/485/comments","events_url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/485/events","html_url":"https://github.com/OCA/maintainer-quality-tools/pull/485","id":258859724,"number":485,"title":"[IMP] Alow excluding specified modules from test_flake8 using env var","user":{"login":"tomeyro","id":8657959,"avatar_url":"https://avatars2.githubusercontent.com/u/8657959?v=4","gravatar_id":"","url":"https://api.github.com/users/tomeyro","html_url":"https://github.com/tomeyro","followers_url":"https://api.github.com/users/tomeyro/followers","following_url":"https://api.github.com/users/tomeyro/following{/other_user}","gists_url":"https://api.github.com/users/tomeyro/gists{/gist_id}","starred_url":"https://api.github.com/users/tomeyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomeyro/subscriptions","organizations_url":"https://api.github.com/users/tomeyro/orgs","repos_url":"https://api.github.com/users/tomeyro/repos","events_url":"https://api.github.com/users/tomeyro/events{/privacy}","received_events_url":"https://api.github.com/users/tomeyro/received_events","type":"User","site_admin":false},"labels":[{"id":121861566,"url":"https://api.github.com/repos/OCA/maintainer-quality-tools/labels/needs%20fixing","name":"needs fixing","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-19T15:16:28Z","updated_at":"2018-02-06T21:42:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OCA/maintainer-quality-tools/pulls/485","html_url":"https://github.com/OCA/maintainer-quality-tools/pull/485","diff_url":"https://github.com/OCA/maintainer-quality-tools/pull/485.diff","patch_url":"https://github.com/OCA/maintainer-quality-tools/pull/485.patch"},"body":"With this MR we will be able to use the environment variable `EXCLUDE_FLAKE8` to specify modules to be excluded from the flake8 checks.\r\n\r\nUse case: sometimes we need to ignore the warnings for some modules because they are from a third party and we don't/can't maintain them.\r\n\r\nExample:\r\n\r\n![image](https://user-images.githubusercontent.com/8657959/30599677-d6f56d22-9d22-11e7-81d0-09aa1069fce8.png)\r\n\r\nHere we are getting a lot of warnings from some third party modules, but we can skip them like this:\r\n\r\n![image](https://user-images.githubusercontent.com/8657959/30599693-eacdc88a-9d22-11e7-92ff-dd838b5e7fc3.png)\r\n\r\nAnd then we see the warnings for the modules that correspond to us to maintain, and our CI tests don't display the false alarms."},"comment":{"url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/comments/363574243","html_url":"https://github.com/OCA/maintainer-quality-tools/pull/485#issuecomment-363574243","issue_url":"https://api.github.com/repos/OCA/maintainer-quality-tools/issues/485","id":363574243,"user":{"login":"tomeyro","id":8657959,"avatar_url":"https://avatars2.githubusercontent.com/u/8657959?v=4","gravatar_id":"","url":"https://api.github.com/users/tomeyro","html_url":"https://github.com/tomeyro","followers_url":"https://api.github.com/users/tomeyro/followers","following_url":"https://api.github.com/users/tomeyro/following{/other_user}","gists_url":"https://api.github.com/users/tomeyro/gists{/gist_id}","starred_url":"https://api.github.com/users/tomeyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomeyro/subscriptions","organizations_url":"https://api.github.com/users/tomeyro/orgs","repos_url":"https://api.github.com/users/tomeyro/repos","events_url":"https://api.github.com/users/tomeyro/events{/privacy}","received_events_url":"https://api.github.com/users/tomeyro/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T21:42:16Z","updated_at":"2018-02-06T21:42:16Z","author_association":"NONE","body":"@lasley Yes. Sorry for the delay.\r\n\r\n@moylop260 Now the env var name is `EXCLUDE` and it works for both `flake8` and `pylint` tests.\r\n\r\n- `pylint`\r\n\r\n![image](https://user-images.githubusercontent.com/8657959/35885663-2dc111de-0b54-11e8-9abc-26a093c3895f.png)\r\n![image](https://user-images.githubusercontent.com/8657959/35885669-3173d578-0b54-11e8-8499-d94c0a189594.png)\r\n\r\n- `flake8`\r\n\r\n![image](https://user-images.githubusercontent.com/8657959/35885681-3a64c674-0b54-11e8-955b-14a001ccb625.png)\r\n![image](https://user-images.githubusercontent.com/8657959/35885683-3c0e79ca-0b54-11e8-9360-02b98f1babca.png)\r\n"}}
{"actor":{"display_login":"tomeyro"}}