{"action":"created","issue":{"url":"https://api.github.com/repos/leihs/leihs/issues/537","repository_url":"https://api.github.com/repos/leihs/leihs","labels_url":"https://api.github.com/repos/leihs/leihs/issues/537/labels{/name}","comments_url":"https://api.github.com/repos/leihs/leihs/issues/537/comments","events_url":"https://api.github.com/repos/leihs/leihs/issues/537/events","html_url":"https://github.com/leihs/leihs/issues/537","id":304660022,"number":537,"title":"Send submitted mail to user","user":{"login":"nadjaweisskopf","id":3356016,"avatar_url":"https://avatars0.githubusercontent.com/u/3356016?v=4","gravatar_id":"","url":"https://api.github.com/users/nadjaweisskopf","html_url":"https://github.com/nadjaweisskopf","followers_url":"https://api.github.com/users/nadjaweisskopf/followers","following_url":"https://api.github.com/users/nadjaweisskopf/following{/other_user}","gists_url":"https://api.github.com/users/nadjaweisskopf/gists{/gist_id}","starred_url":"https://api.github.com/users/nadjaweisskopf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadjaweisskopf/subscriptions","organizations_url":"https://api.github.com/users/nadjaweisskopf/orgs","repos_url":"https://api.github.com/users/nadjaweisskopf/repos","events_url":"https://api.github.com/users/nadjaweisskopf/events{/privacy}","received_events_url":"https://api.github.com/users/nadjaweisskopf/received_events","type":"User","site_admin":false},"labels":[{"id":7341808,"url":"https://api.github.com/repos/leihs/leihs/labels/enhancement","name":"enhancement","color":"009800","default":true},{"id":543587285,"url":"https://api.github.com/repos/leihs/leihs/labels/lending","name":"lending","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"nimaai","id":3205913,"avatar_url":"https://avatars1.githubusercontent.com/u/3205913?v=4","gravatar_id":"","url":"https://api.github.com/users/nimaai","html_url":"https://github.com/nimaai","followers_url":"https://api.github.com/users/nimaai/followers","following_url":"https://api.github.com/users/nimaai/following{/other_user}","gists_url":"https://api.github.com/users/nimaai/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaai/subscriptions","organizations_url":"https://api.github.com/users/nimaai/orgs","repos_url":"https://api.github.com/users/nimaai/repos","events_url":"https://api.github.com/users/nimaai/events{/privacy}","received_events_url":"https://api.github.com/users/nimaai/received_events","type":"User","site_admin":false},"assignees":[{"login":"nimaai","id":3205913,"avatar_url":"https://avatars1.githubusercontent.com/u/3205913?v=4","gravatar_id":"","url":"https://api.github.com/users/nimaai","html_url":"https://github.com/nimaai","followers_url":"https://api.github.com/users/nimaai/followers","following_url":"https://api.github.com/users/nimaai/following{/other_user}","gists_url":"https://api.github.com/users/nimaai/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaai/subscriptions","organizations_url":"https://api.github.com/users/nimaai/orgs","repos_url":"https://api.github.com/users/nimaai/repos","events_url":"https://api.github.com/users/nimaai/events{/privacy}","received_events_url":"https://api.github.com/users/nimaai/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-03-13T07:54:38Z","updated_at":"2018-03-19T14:36:42Z","closed_at":null,"author_association":"COLLABORATOR","body":"#### Expected behaviour\r\nWhen a user sends an order, he should receive a submitted msg.\r\n\r\nTo do: \r\n\r\n- [ ] send submitted msg. to user containing the text which is defined in the mail template of the pool\r\n- [ ] Write scenario and tests\r\n- [ ] Check that template from Admin-section is used for submitted msg. when creating a new pool\r\n\r\n\r\n#### Actual behaviour\r\nWe have a template for \"submitted\" but the user does not receive the mail. According to Matus the code is disabled. \r\n\r\n#### Steps to reproduce\r\n1. go to borrow section\r\n2. create an order\r\n3. send an order\r\n4. you do not receive a submitted msg. \r\n\r\n#### Related issues \r\nhttps://github.com/leihs/leihs/issues/291\r\n\r\n#### Specifications\r\n- Leihs version:\r\n- Browser version:\r\n- MySQL/PostreSQL version:"},"comment":{"url":"https://api.github.com/repos/leihs/leihs/issues/comments/374234159","html_url":"https://github.com/leihs/leihs/issues/537#issuecomment-374234159","issue_url":"https://api.github.com/repos/leihs/leihs/issues/537","id":374234159,"user":{"login":"nimaai","id":3205913,"avatar_url":"https://avatars1.githubusercontent.com/u/3205913?v=4","gravatar_id":"","url":"https://api.github.com/users/nimaai","html_url":"https://github.com/nimaai","followers_url":"https://api.github.com/users/nimaai/followers","following_url":"https://api.github.com/users/nimaai/following{/other_user}","gists_url":"https://api.github.com/users/nimaai/gists{/gist_id}","starred_url":"https://api.github.com/users/nimaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimaai/subscriptions","organizations_url":"https://api.github.com/users/nimaai/orgs","repos_url":"https://api.github.com/users/nimaai/repos","events_url":"https://api.github.com/users/nimaai/events{/privacy}","received_events_url":"https://api.github.com/users/nimaai/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T14:36:42Z","updated_at":"2018-03-19T14:36:42Z","author_association":"CONTRIBUTOR","body":"> * your order has been sent and needs to be accepted first\r\n> * amount, model names, time period\r\n> * reason\r\n\r\nThis information is configurable for each template, pool and language. Click on `List of available variables` on the edit page of a particular template and language in a particular pool.\r\n\r\n> * The mail-content only needs to be edited by the Admin, no template needed in pools\r\n\r\nNo. This contradicts our recent change in the mail setup. Each template for each language **is needed** in every pool, because only these ones are possible to use for mail delivery. The admin mail templates just ensure that when you create a new pool you have some templates to start with.\r\n\r\n> * No setting needed in Admin-section. It is sent automatically, same as all other mails sent during the lending/acceptance process.\r\n\r\nOk. So we keep `deliver_order_notifications` in admin settings for now as an exception to the above stated. I will rename it to `deliver_received_order_notifications` (or something similar) just to be explicit, because submitted order notifications will be always sent, as you suggested.\r\n\r\nThat said, we should perhaps think of providing each pool the possibility of deciding which email are sent, in long term..."}}
{"actor":{"display_login":"nimaai"}}