{"action":"created","comment":{"url":"https://api.github.com/repos/micropython/micropython/pulls/comments/184281841","pull_request_review_id":115440879,"id":184281841,"diff_hunk":"@@ -5,7 +5,7 @@\n \n #define CONFIG_TRACEMEM_RESERVE_DRAM 0x0\n #define CONFIG_BT_RESERVE_DRAM 0x0\n-#define CONFIG_ULP_COPROC_RESERVE_MEM 0\n+#define CONFIG_ULP_COPROC_RESERVE_MEM 2040","path":"ports/esp32/sdkconfig.h","position":5,"original_position":5,"commit_id":"e616d12d8344ad3fd627e59c33e1dcb3543fd07f","original_commit_id":"e616d12d8344ad3fd627e59c33e1dcb3543fd07f","user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars1.githubusercontent.com/u/6187689?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"body":"Was there a reason for the value 2040?  Why not 2048?  (The default value from the ESP IDF is 512.)\r\n\r\nAlso, isn't in necessary to define ULP_COPROC_ENABLED?","created_at":"2018-04-26T06:30:31Z","updated_at":"2018-04-26T06:31:30Z","html_url":"https://github.com/micropython/micropython/pull/3578#discussion_r184281841","pull_request_url":"https://api.github.com/repos/micropython/micropython/pulls/3578","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/184281841"},"html":{"href":"https://github.com/micropython/micropython/pull/3578#discussion_r184281841"},"pull_request":{"href":"https://api.github.com/repos/micropython/micropython/pulls/3578"}}},"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/3578","id":164180799,"html_url":"https://github.com/micropython/micropython/pull/3578","diff_url":"https://github.com/micropython/micropython/pull/3578.diff","patch_url":"https://github.com/micropython/micropython/pull/3578.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/3578","number":3578,"state":"open","locked":false,"title":"ports/esp32 add support for the ulp","user":{"login":"andynd","id":14838994,"avatar_url":"https://avatars2.githubusercontent.com/u/14838994?v=4","gravatar_id":"","url":"https://api.github.com/users/andynd","html_url":"https://github.com/andynd","followers_url":"https://api.github.com/users/andynd/followers","following_url":"https://api.github.com/users/andynd/following{/other_user}","gists_url":"https://api.github.com/users/andynd/gists{/gist_id}","starred_url":"https://api.github.com/users/andynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andynd/subscriptions","organizations_url":"https://api.github.com/users/andynd/orgs","repos_url":"https://api.github.com/users/andynd/repos","events_url":"https://api.github.com/users/andynd/events{/privacy}","received_events_url":"https://api.github.com/users/andynd/received_events","type":"User","site_admin":false},"body":"add machine.ULP() with functions load_binary, set_wakeup_period and run.\r\nadd constant machine.ULP().COPROC_RESERVE_MEM\r\nadd README.ulp.md with ulp examples","created_at":"2018-01-21T15:42:00Z","updated_at":"2018-04-26T06:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0072d7debab7ac45a56abd26fd98be89fb15c153","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/3578/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/3578/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/3578/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/e616d12d8344ad3fd627e59c33e1dcb3543fd07f","head":{"label":"andynd:ulp","ref":"ulp","sha":"e616d12d8344ad3fd627e59c33e1dcb3543fd07f","user":{"login":"andynd","id":14838994,"avatar_url":"https://avatars2.githubusercontent.com/u/14838994?v=4","gravatar_id":"","url":"https://api.github.com/users/andynd","html_url":"https://github.com/andynd","followers_url":"https://api.github.com/users/andynd/followers","following_url":"https://api.github.com/users/andynd/following{/other_user}","gists_url":"https://api.github.com/users/andynd/gists{/gist_id}","starred_url":"https://api.github.com/users/andynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andynd/subscriptions","organizations_url":"https://api.github.com/users/andynd/orgs","repos_url":"https://api.github.com/users/andynd/repos","events_url":"https://api.github.com/users/andynd/events{/privacy}","received_events_url":"https://api.github.com/users/andynd/received_events","type":"User","site_admin":false},"repo":{"id":118294546,"name":"micropython","full_name":"andynd/micropython","owner":{"login":"andynd","id":14838994,"avatar_url":"https://avatars2.githubusercontent.com/u/14838994?v=4","gravatar_id":"","url":"https://api.github.com/users/andynd","html_url":"https://github.com/andynd","followers_url":"https://api.github.com/users/andynd/followers","following_url":"https://api.github.com/users/andynd/following{/other_user}","gists_url":"https://api.github.com/users/andynd/gists{/gist_id}","starred_url":"https://api.github.com/users/andynd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andynd/subscriptions","organizations_url":"https://api.github.com/users/andynd/orgs","repos_url":"https://api.github.com/users/andynd/repos","events_url":"https://api.github.com/users/andynd/events{/privacy}","received_events_url":"https://api.github.com/users/andynd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andynd/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":true,"url":"https://api.github.com/repos/andynd/micropython","forks_url":"https://api.github.com/repos/andynd/micropython/forks","keys_url":"https://api.github.com/repos/andynd/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andynd/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andynd/micropython/teams","hooks_url":"https://api.github.com/repos/andynd/micropython/hooks","issue_events_url":"https://api.github.com/repos/andynd/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/andynd/micropython/events","assignees_url":"https://api.github.com/repos/andynd/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/andynd/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/andynd/micropython/tags","blobs_url":"https://api.github.com/repos/andynd/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andynd/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andynd/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/andynd/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andynd/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/andynd/micropython/languages","stargazers_url":"https://api.github.com/repos/andynd/micropython/stargazers","contributors_url":"https://api.github.com/repos/andynd/micropython/contributors","subscribers_url":"https://api.github.com/repos/andynd/micropython/subscribers","subscription_url":"https://api.github.com/repos/andynd/micropython/subscription","commits_url":"https://api.github.com/repos/andynd/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/andynd/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/andynd/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/andynd/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/andynd/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/andynd/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andynd/micropython/merges","archive_url":"https://api.github.com/repos/andynd/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andynd/micropython/downloads","issues_url":"https://api.github.com/repos/andynd/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/andynd/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/andynd/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/andynd/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andynd/micropython/labels{/name}","releases_url":"https://api.github.com/repos/andynd/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/andynd/micropython/deployments","created_at":"2018-01-21T01:18:15Z","updated_at":"2018-04-05T09:43:46Z","pushed_at":"2018-04-05T15:01:56Z","git_url":"git://github.com/andynd/micropython.git","ssh_url":"git@github.com:andynd/micropython.git","clone_url":"https://github.com/andynd/micropython.git","svn_url":"https://github.com/andynd/micropython","homepage":"https://micropython.org","size":33892,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"7b0a020a02595d4ca1e782c8282d01bc220c84c7","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars1.githubusercontent.com/u/6298560?v=4","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars1.githubusercontent.com/u/6298560?v=4","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/micropython/micropython/deployments","created_at":"2013-12-20T11:47:07Z","updated_at":"2018-04-25T13:18:23Z","pushed_at":"2018-04-26T05:08:06Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":"https://micropython.org","size":33819,"stargazers_count":6393,"watchers_count":6393,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1649,"mirror_url":null,"archived":false,"open_issues_count":533,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1649,"open_issues":533,"watchers":6393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/3578"},"html":{"href":"https://github.com/micropython/micropython/pull/3578"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/3578"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/3578/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/3578/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/3578/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/e616d12d8344ad3fd627e59c33e1dcb3543fd07f"}},"author_association":"NONE"}}
{"actor":{"display_login":"dpgeorge"}}