{"action":"opened","number":33,"pull_request":{"url":"https://api.github.com/repos/pnp/pnp/pulls/33","id":173937311,"html_url":"https://github.com/pnp/pnp/pull/33","diff_url":"https://github.com/pnp/pnp/pull/33.diff","patch_url":"https://github.com/pnp/pnp/pull/33.patch","issue_url":"https://api.github.com/repos/pnp/pnp/issues/33","number":33,"state":"open","locked":false,"title":"Add support for $expand in getAll (items.expand('...'))","user":{"login":"eirikb","id":241706,"avatar_url":"https://avatars2.githubusercontent.com/u/241706?v=4","gravatar_id":"","url":"https://api.github.com/users/eirikb","html_url":"https://github.com/eirikb","followers_url":"https://api.github.com/users/eirikb/followers","following_url":"https://api.github.com/users/eirikb/following{/other_user}","gists_url":"https://api.github.com/users/eirikb/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikb/subscriptions","organizations_url":"https://api.github.com/users/eirikb/orgs","repos_url":"https://api.github.com/users/eirikb/repos","events_url":"https://api.github.com/users/eirikb/events{/privacy}","received_events_url":"https://api.github.com/users/eirikb/received_events","type":"User","site_admin":false},"body":"This fix adds support for expand by adding it to list of keys\r\ncopied from `this.query`.\r\n\r\n#### Category\r\n- [ ] Bug fix?\r\n- [ ] New feature?\r\n- [ ] New sample?\r\n- [ ] Documentation update?\r\n- [x] Feature enhancement?\r\n\r\n#### What's in this Pull Request?\r\n\r\nThis PR add support for expand to the new `getAll` method.\r\nWe discussed this on gitter, and I understand that expand was deliberately excluded from `getAll` because of performance reasons.\r\nWhile I understand the decision I still would like the ability to get all data in the exact same was as with `items.get()`.\r\n\r\nThe reason I want this is that we often use pnp for small snippets (using [tick](https://www.npmjs.com/package/tick-cli)), and then we need to run expand to do one-time jobs where we need more data, even if they are slow.","created_at":"2018-03-09T07:30:49Z","updated_at":"2018-03-09T07:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pnp/pnp/pulls/33/commits","review_comments_url":"https://api.github.com/repos/pnp/pnp/pulls/33/comments","review_comment_url":"https://api.github.com/repos/pnp/pnp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pnp/pnp/issues/33/comments","statuses_url":"https://api.github.com/repos/pnp/pnp/statuses/d742b1f351b9ce27d780c606a64f1ac626536a00","head":{"label":"eirikb:dev","ref":"dev","sha":"d742b1f351b9ce27d780c606a64f1ac626536a00","user":{"login":"eirikb","id":241706,"avatar_url":"https://avatars2.githubusercontent.com/u/241706?v=4","gravatar_id":"","url":"https://api.github.com/users/eirikb","html_url":"https://github.com/eirikb","followers_url":"https://api.github.com/users/eirikb/followers","following_url":"https://api.github.com/users/eirikb/following{/other_user}","gists_url":"https://api.github.com/users/eirikb/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikb/subscriptions","organizations_url":"https://api.github.com/users/eirikb/orgs","repos_url":"https://api.github.com/users/eirikb/repos","events_url":"https://api.github.com/users/eirikb/events{/privacy}","received_events_url":"https://api.github.com/users/eirikb/received_events","type":"User","site_admin":false},"repo":{"id":124503795,"name":"pnp","full_name":"eirikb/pnp","owner":{"login":"eirikb","id":241706,"avatar_url":"https://avatars2.githubusercontent.com/u/241706?v=4","gravatar_id":"","url":"https://api.github.com/users/eirikb","html_url":"https://github.com/eirikb","followers_url":"https://api.github.com/users/eirikb/followers","following_url":"https://api.github.com/users/eirikb/following{/other_user}","gists_url":"https://api.github.com/users/eirikb/gists{/gist_id}","starred_url":"https://api.github.com/users/eirikb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirikb/subscriptions","organizations_url":"https://api.github.com/users/eirikb/orgs","repos_url":"https://api.github.com/users/eirikb/repos","events_url":"https://api.github.com/users/eirikb/events{/privacy}","received_events_url":"https://api.github.com/users/eirikb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eirikb/pnp","description":"SharePoint Patterns and Practices Reusable Client-side Libraries","fork":true,"url":"https://api.github.com/repos/eirikb/pnp","forks_url":"https://api.github.com/repos/eirikb/pnp/forks","keys_url":"https://api.github.com/repos/eirikb/pnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eirikb/pnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eirikb/pnp/teams","hooks_url":"https://api.github.com/repos/eirikb/pnp/hooks","issue_events_url":"https://api.github.com/repos/eirikb/pnp/issues/events{/number}","events_url":"https://api.github.com/repos/eirikb/pnp/events","assignees_url":"https://api.github.com/repos/eirikb/pnp/assignees{/user}","branches_url":"https://api.github.com/repos/eirikb/pnp/branches{/branch}","tags_url":"https://api.github.com/repos/eirikb/pnp/tags","blobs_url":"https://api.github.com/repos/eirikb/pnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eirikb/pnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eirikb/pnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/eirikb/pnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eirikb/pnp/statuses/{sha}","languages_url":"https://api.github.com/repos/eirikb/pnp/languages","stargazers_url":"https://api.github.com/repos/eirikb/pnp/stargazers","contributors_url":"https://api.github.com/repos/eirikb/pnp/contributors","subscribers_url":"https://api.github.com/repos/eirikb/pnp/subscribers","subscription_url":"https://api.github.com/repos/eirikb/pnp/subscription","commits_url":"https://api.github.com/repos/eirikb/pnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/eirikb/pnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/eirikb/pnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/eirikb/pnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/eirikb/pnp/contents/{+path}","compare_url":"https://api.github.com/repos/eirikb/pnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eirikb/pnp/merges","archive_url":"https://api.github.com/repos/eirikb/pnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eirikb/pnp/downloads","issues_url":"https://api.github.com/repos/eirikb/pnp/issues{/number}","pulls_url":"https://api.github.com/repos/eirikb/pnp/pulls{/number}","milestones_url":"https://api.github.com/repos/eirikb/pnp/milestones{/number}","notifications_url":"https://api.github.com/repos/eirikb/pnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eirikb/pnp/labels{/name}","releases_url":"https://api.github.com/repos/eirikb/pnp/releases{/id}","deployments_url":"https://api.github.com/repos/eirikb/pnp/deployments","created_at":"2018-03-09T07:23:02Z","updated_at":"2018-03-09T07:23:04Z","pushed_at":"2018-03-09T07:27:32Z","git_url":"git://github.com/eirikb/pnp.git","ssh_url":"git@github.com:eirikb/pnp.git","clone_url":"https://github.com/eirikb/pnp.git","svn_url":"https://github.com/eirikb/pnp","homepage":"https://pnp.github.io/pnp/","size":708,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"pnp:dev","ref":"dev","sha":"a5018dce402d28f0fa7719f9ca465d3a1004e91d","user":{"login":"pnp","id":31443929,"avatar_url":"https://avatars0.githubusercontent.com/u/31443929?v=4","gravatar_id":"","url":"https://api.github.com/users/pnp","html_url":"https://github.com/pnp","followers_url":"https://api.github.com/users/pnp/followers","following_url":"https://api.github.com/users/pnp/following{/other_user}","gists_url":"https://api.github.com/users/pnp/gists{/gist_id}","starred_url":"https://api.github.com/users/pnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnp/subscriptions","organizations_url":"https://api.github.com/users/pnp/orgs","repos_url":"https://api.github.com/users/pnp/repos","events_url":"https://api.github.com/users/pnp/events{/privacy}","received_events_url":"https://api.github.com/users/pnp/received_events","type":"Organization","site_admin":false},"repo":{"id":102124491,"name":"pnp","full_name":"pnp/pnp","owner":{"login":"pnp","id":31443929,"avatar_url":"https://avatars0.githubusercontent.com/u/31443929?v=4","gravatar_id":"","url":"https://api.github.com/users/pnp","html_url":"https://github.com/pnp","followers_url":"https://api.github.com/users/pnp/followers","following_url":"https://api.github.com/users/pnp/following{/other_user}","gists_url":"https://api.github.com/users/pnp/gists{/gist_id}","starred_url":"https://api.github.com/users/pnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnp/subscriptions","organizations_url":"https://api.github.com/users/pnp/orgs","repos_url":"https://api.github.com/users/pnp/repos","events_url":"https://api.github.com/users/pnp/events{/privacy}","received_events_url":"https://api.github.com/users/pnp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pnp/pnp","description":"SharePoint Patterns and Practices Reusable Client-side Libraries","fork":false,"url":"https://api.github.com/repos/pnp/pnp","forks_url":"https://api.github.com/repos/pnp/pnp/forks","keys_url":"https://api.github.com/repos/pnp/pnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnp/pnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnp/pnp/teams","hooks_url":"https://api.github.com/repos/pnp/pnp/hooks","issue_events_url":"https://api.github.com/repos/pnp/pnp/issues/events{/number}","events_url":"https://api.github.com/repos/pnp/pnp/events","assignees_url":"https://api.github.com/repos/pnp/pnp/assignees{/user}","branches_url":"https://api.github.com/repos/pnp/pnp/branches{/branch}","tags_url":"https://api.github.com/repos/pnp/pnp/tags","blobs_url":"https://api.github.com/repos/pnp/pnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnp/pnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnp/pnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnp/pnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnp/pnp/statuses/{sha}","languages_url":"https://api.github.com/repos/pnp/pnp/languages","stargazers_url":"https://api.github.com/repos/pnp/pnp/stargazers","contributors_url":"https://api.github.com/repos/pnp/pnp/contributors","subscribers_url":"https://api.github.com/repos/pnp/pnp/subscribers","subscription_url":"https://api.github.com/repos/pnp/pnp/subscription","commits_url":"https://api.github.com/repos/pnp/pnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnp/pnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnp/pnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnp/pnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnp/pnp/contents/{+path}","compare_url":"https://api.github.com/repos/pnp/pnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnp/pnp/merges","archive_url":"https://api.github.com/repos/pnp/pnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnp/pnp/downloads","issues_url":"https://api.github.com/repos/pnp/pnp/issues{/number}","pulls_url":"https://api.github.com/repos/pnp/pnp/pulls{/number}","milestones_url":"https://api.github.com/repos/pnp/pnp/milestones{/number}","notifications_url":"https://api.github.com/repos/pnp/pnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnp/pnp/labels{/name}","releases_url":"https://api.github.com/repos/pnp/pnp/releases{/id}","deployments_url":"https://api.github.com/repos/pnp/pnp/deployments","created_at":"2017-09-01T15:01:39Z","updated_at":"2018-03-05T18:06:45Z","pushed_at":"2018-03-08T22:06:51Z","git_url":"git://github.com/pnp/pnp.git","ssh_url":"git@github.com:pnp/pnp.git","clone_url":"https://github.com/pnp/pnp.git","svn_url":"https://github.com/pnp/pnp","homepage":"https://pnp.github.io/pnp/","size":708,"stargazers_count":20,"watchers_count":20,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":8,"watchers":20,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/pnp/pnp/pulls/33"},"html":{"href":"https://github.com/pnp/pnp/pull/33"},"issue":{"href":"https://api.github.com/repos/pnp/pnp/issues/33"},"comments":{"href":"https://api.github.com/repos/pnp/pnp/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/pnp/pnp/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/pnp/pnp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pnp/pnp/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/pnp/pnp/statuses/d742b1f351b9ce27d780c606a64f1ac626536a00"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"eirikb"}}