{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/comments/186721971","pull_request_review_id":118355463,"id":186721971,"diff_hunk":"@@ -85,14 +85,21 @@ network_serialization_test_() ->\n \n validate_test_() ->\n     {setup,\n-     fun aec_test_utils:aec_keys_setup/0,\n-     fun aec_test_utils:aec_keys_cleanup/1,\n+     fun() ->\n+             ok = meck:new(aec_chain, [passthrough]),\n+             meck:expect(aec_chain, get_top_state, 0, {ok, aec_trees:new()}),\n+             aec_test_utils:aec_keys_setup()\n+     end,","path":"apps/aecore/test/aec_blocks_tests.erl","position":10,"original_position":10,"commit_id":"889ee057bacdfcf34424aa29d8fc2981435c2f29","original_commit_id":"dcd8a33e987eb8eec333ec65f02944f711c395eb","user":{"login":"gorillainduction","id":7676988,"avatar_url":"https://avatars2.githubusercontent.com/u/7676988?v=4","gravatar_id":"","url":"https://api.github.com/users/gorillainduction","html_url":"https://github.com/gorillainduction","followers_url":"https://api.github.com/users/gorillainduction/followers","following_url":"https://api.github.com/users/gorillainduction/following{/other_user}","gists_url":"https://api.github.com/users/gorillainduction/gists{/gist_id}","starred_url":"https://api.github.com/users/gorillainduction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorillainduction/subscriptions","organizations_url":"https://api.github.com/users/gorillainduction/orgs","repos_url":"https://api.github.com/users/gorillainduction/repos","events_url":"https://api.github.com/users/gorillainduction/events{/privacy}","received_events_url":"https://api.github.com/users/gorillainduction/received_events","type":"User","site_admin":false},"body":"Yes, but you don't need the mecking of the chain, I think. No big deal, though.","created_at":"2018-05-08T13:14:43Z","updated_at":"2018-05-08T13:16:15Z","html_url":"https://github.com/aeternity/epoch/pull/1093#discussion_r186721971","pull_request_url":"https://api.github.com/repos/aeternity/epoch/pulls/1093","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments/186721971"},"html":{"href":"https://github.com/aeternity/epoch/pull/1093#discussion_r186721971"},"pull_request":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1093"}},"in_reply_to_id":186656443},"pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/1093","id":186360447,"html_url":"https://github.com/aeternity/epoch/pull/1093","diff_url":"https://github.com/aeternity/epoch/pull/1093.diff","patch_url":"https://github.com/aeternity/epoch/pull/1093.patch","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/1093","number":1093,"state":"open","locked":false,"title":"Refactoring: aetx's signers/1 -> signers/2","user":{"login":"velzevur","id":4035918,"avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false},"body":"[Pivotal story](https://www.pivotaltracker.com/story/show/157357793)\r\nChannels' transactions don't contain the signers in the tx body so we must take those from the state trees instead. This PR addresses this by providing the aetx's callback signers/1 the trees (thus making it signers/2)\r\n\r\nSince the signers may or may not be in the state trees at all (because of the channel might not be there) we are having a clear distinction between those two cases.","created_at":"2018-05-07T14:01:08Z","updated_at":"2018-05-08T13:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac6a7b926ab005964bf144640cc2654318c56626","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/epoch/pulls/1093/commits","review_comments_url":"https://api.github.com/repos/aeternity/epoch/pulls/1093/comments","review_comment_url":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/1093/comments","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/889ee057bacdfcf34424aa29d8fc2981435c2f29","head":{"label":"aeternity:PT-157357793_aetx_signers_refactoring","ref":"PT-157357793_aetx_signers_refactoring","sha":"889ee057bacdfcf34424aa29d8fc2981435c2f29","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-05-08T13:00:32Z","pushed_at":"2018-05-08T13:00:34Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":7049,"stargazers_count":513,"watchers_count":513,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":83,"open_issues":9,"watchers":513,"default_branch":"master"}},"base":{"label":"aeternity:feature-state-channels-07052018","ref":"feature-state-channels-07052018","sha":"7e598f994f995f3a558bea57ce774fb4b5360574","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-05-08T13:00:32Z","pushed_at":"2018-05-08T13:00:34Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":7049,"stargazers_count":513,"watchers_count":513,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":83,"open_issues":9,"watchers":513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1093"},"html":{"href":"https://github.com/aeternity/epoch/pull/1093"},"issue":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1093"},"comments":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1093/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1093/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1093/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/epoch/statuses/889ee057bacdfcf34424aa29d8fc2981435c2f29"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gorillainduction"}}