{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/213185109","pull_request_review_id":149966730,"id":213185109,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzE4NTEwOQ==","diff_hunk":"@@ -78,13 +78,13 @@ const (\n \tP2PKHOutputSize = 8 + 2 + 1 + 25\n )\n \n-// EstimateSerializeSize returns a worst case serialize size estimate for a\n-// signed transaction that spends a number of outputs and contains each\n-// transaction output from txOuts. The estimated size is incremented for an\n-// additional change output if changeScriptSize is greater than 0. Passing 0\n-// does not add a change output.\n+// EstimateSerializeSize returns a worst case serialize size\n+// estimate for a signed transaction that spends a number of outputs and\n+// contains each transaction output from txOuts. The estimated size is\n+// incremented for an additional change output if changeScriptSize is greater\n+// than 0. Passing 0 does not add a change output.","path":"wallet/internal/txsizes/size.go","position":null,"original_position":13,"commit_id":"44a0010a2991595ddd0e192f7089bd39dce4ab4a","original_commit_id":"5e3c70531ec2fc9a2b640620524a6b905d21af8b","user":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"body":"My bad, updating my workflow. Will improve.","created_at":"2018-08-28T05:04:48Z","updated_at":"2018-08-28T05:04:48Z","html_url":"https://github.com/decred/dcrwallet/pull/1159#discussion_r213185109","pull_request_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1159","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments/213185109"},"html":{"href":"https://github.com/decred/dcrwallet/pull/1159#discussion_r213185109"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1159"}},"in_reply_to_id":213116305},"pull_request":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/1159","id":191908687,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTA4Njg3","html_url":"https://github.com/decred/dcrwallet/pull/1159","diff_url":"https://github.com/decred/dcrwallet/pull/1159.diff","patch_url":"https://github.com/decred/dcrwallet/pull/1159.patch","issue_url":"https://api.github.com/repos/decred/dcrwallet/issues/1159","number":1159,"state":"open","locked":false,"title":"txsizes: Add EstimateSerializeSizeFromScriptSizes.","user":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"body":"This is ideal for estimating tx sizes when the tx format is known but tx outputs have not been generated yet.","created_at":"2018-06-01T00:47:34Z","updated_at":"2018-08-28T05:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e4f6a498630e31eb00c95c804544d8cc2f278e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1159/commits","review_comments_url":"https://api.github.com/repos/decred/dcrwallet/pulls/1159/comments","review_comment_url":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrwallet/issues/1159/comments","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/44a0010a2991595ddd0e192f7089bd39dce4ab4a","head":{"label":"dnldd:est_size_with_sizers","ref":"est_size_with_sizers","sha":"44a0010a2991595ddd0e192f7089bd39dce4ab4a","user":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"repo":{"id":97534962,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzNDk2Mg==","name":"dcrwallet","full_name":"dnldd/dcrwallet","owner":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnldd/dcrwallet","description":"A secure Decred wallet daemon written in Go (golang).","fork":true,"url":"https://api.github.com/repos/dnldd/dcrwallet","forks_url":"https://api.github.com/repos/dnldd/dcrwallet/forks","keys_url":"https://api.github.com/repos/dnldd/dcrwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnldd/dcrwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnldd/dcrwallet/teams","hooks_url":"https://api.github.com/repos/dnldd/dcrwallet/hooks","issue_events_url":"https://api.github.com/repos/dnldd/dcrwallet/issues/events{/number}","events_url":"https://api.github.com/repos/dnldd/dcrwallet/events","assignees_url":"https://api.github.com/repos/dnldd/dcrwallet/assignees{/user}","branches_url":"https://api.github.com/repos/dnldd/dcrwallet/branches{/branch}","tags_url":"https://api.github.com/repos/dnldd/dcrwallet/tags","blobs_url":"https://api.github.com/repos/dnldd/dcrwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnldd/dcrwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnldd/dcrwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnldd/dcrwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnldd/dcrwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/dnldd/dcrwallet/languages","stargazers_url":"https://api.github.com/repos/dnldd/dcrwallet/stargazers","contributors_url":"https://api.github.com/repos/dnldd/dcrwallet/contributors","subscribers_url":"https://api.github.com/repos/dnldd/dcrwallet/subscribers","subscription_url":"https://api.github.com/repos/dnldd/dcrwallet/subscription","commits_url":"https://api.github.com/repos/dnldd/dcrwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnldd/dcrwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnldd/dcrwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnldd/dcrwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnldd/dcrwallet/contents/{+path}","compare_url":"https://api.github.com/repos/dnldd/dcrwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnldd/dcrwallet/merges","archive_url":"https://api.github.com/repos/dnldd/dcrwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnldd/dcrwallet/downloads","issues_url":"https://api.github.com/repos/dnldd/dcrwallet/issues{/number}","pulls_url":"https://api.github.com/repos/dnldd/dcrwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/dnldd/dcrwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/dnldd/dcrwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnldd/dcrwallet/labels{/name}","releases_url":"https://api.github.com/repos/dnldd/dcrwallet/releases{/id}","deployments_url":"https://api.github.com/repos/dnldd/dcrwallet/deployments","created_at":"2017-07-18T00:39:13Z","updated_at":"2017-07-18T00:39:16Z","pushed_at":"2018-08-28T04:57:56Z","git_url":"git://github.com/dnldd/dcrwallet.git","ssh_url":"git@github.com:dnldd/dcrwallet.git","clone_url":"https://github.com/dnldd/dcrwallet.git","svn_url":"https://github.com/dnldd/dcrwallet","homepage":"https://decred.org","size":8884,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"d3358652637a2337e3f8952ef05d6419619249e0","user":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457727,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ1NzcyNw==","name":"dcrwallet","full_name":"decred/dcrwallet","owner":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrwallet","description":"A secure Decred wallet daemon written in Go (golang).","fork":true,"url":"https://api.github.com/repos/decred/dcrwallet","forks_url":"https://api.github.com/repos/decred/dcrwallet/forks","keys_url":"https://api.github.com/repos/decred/dcrwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrwallet/teams","hooks_url":"https://api.github.com/repos/decred/dcrwallet/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrwallet/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrwallet/events","assignees_url":"https://api.github.com/repos/decred/dcrwallet/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrwallet/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrwallet/tags","blobs_url":"https://api.github.com/repos/decred/dcrwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrwallet/languages","stargazers_url":"https://api.github.com/repos/decred/dcrwallet/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrwallet/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrwallet/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrwallet/subscription","commits_url":"https://api.github.com/repos/decred/dcrwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrwallet/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrwallet/merges","archive_url":"https://api.github.com/repos/decred/dcrwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrwallet/downloads","issues_url":"https://api.github.com/repos/decred/dcrwallet/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrwallet/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrwallet/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrwallet/deployments","created_at":"2016-01-26T20:40:34Z","updated_at":"2018-08-27T18:02:06Z","pushed_at":"2018-08-28T04:57:57Z","git_url":"git://github.com/decred/dcrwallet.git","ssh_url":"git@github.com:decred/dcrwallet.git","clone_url":"https://github.com/decred/dcrwallet.git","svn_url":"https://github.com/decred/dcrwallet","homepage":"https://decred.org","size":8747,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":88,"open_issues":115,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1159"},"html":{"href":"https://github.com/decred/dcrwallet/pull/1159"},"issue":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/1159"},"comments":{"href":"https://api.github.com/repos/decred/dcrwallet/issues/1159/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1159/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrwallet/pulls/1159/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrwallet/statuses/44a0010a2991595ddd0e192f7089bd39dce4ab4a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dnldd"}}