{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/217900617","pull_request_review_id":155730325,"id":217900617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkwMDYxNw==","diff_hunk":"@@ -0,0 +1,143 @@\n+#!/usr/bin/env bash\n+\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one or more\n+# contributor license agreements.  See the NOTICE file distributed with\n+# this work for additional information regarding copyright ownership.\n+# The ASF licenses this file to You under the Apache License, Version 2.0\n+# (the \"License\"); you may not use this file except in compliance with\n+# the License.  You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+#\n+# Creates a Spark release candidate. The script will update versions, tag the branch,\n+# build Spark binary packages and documentation, and upload maven artifacts to a staging\n+# repository. There is also a dry run mode where only local builds are performed, and\n+# nothing is uploaded to the ASF repos.\n+#\n+# Run with \"-h\" for options.\n+#\n+\n+set -e\n+SELF=$(cd $(dirname $0) && pwd)\n+. \"$SELF/release-util.sh\"\n+\n+function usage {\n+  local NAME=$(basename $0)\n+  cat <<EOF\n+Usage: $NAME [options]\n+\n+This script runs the release scripts inside a docker image. The image is hardcoded to be called\n+\"spark-rm\" and will be re-generated (as needed) on every invocation of this script.\n+\n+Options are:\n+\n+  -d [path]   : required: working directory (output will be written to an \"output\" directory in\n+                the working directory).\n+  -n          : dry run mode. Performs checks and local builds, but do not upload anything.\n+  -t [tag]    : tag for the spark-rm docker image to use for building (default: \"latest\").\n+  -j [path]   : path to local JDK installation to use for building. By default the script will\n+                use openjdk8 installed in the docker image.\n+  -s [step]   : runs a single step of the process; valid steps are: tag, build, docs, publish\n+EOF\n+}\n+\n+WORKDIR=\n+IMGTAG=latest\n+JAVA=\n+RELEASE_STEP=\n+while getopts \"d:hj:ns:t:\" opt; do\n+  case $opt in\n+    d) WORKDIR=\"$OPTARG\" ;;\n+    n) DRY_RUN=1 ;;\n+    t) IMGTAG=\"$OPTARG\" ;;\n+    j) JAVA=\"$OPTARG\" ;;\n+    s) RELEASE_STEP=\"$OPTARG\" ;;\n+    h) usage ;;\n+    ?) error \"Invalid option. Run with -h for help.\" ;;\n+  esac\n+done\n+\n+if [ -z \"$WORKDIR\" ] || [ ! -d \"$WORKDIR\" ]; then\n+  error \"Work directory (-d) must be defined and exist. Run with -h for help.\"\n+fi\n+\n+if [ -d \"$WORKDIR/output\" ]; then\n+  read -p \"Output directory already exists. Overwrite and continue? [y/n] \" ANSWER\n+  if [ \"$ANSWER\" != \"y\" ]; then\n+    error \"Exiting.\"\n+  fi\n+fi\n+\n+cd \"$WORKDIR\"\n+rm -rf \"$WORKDIR/output\"\n+mkdir \"$WORKDIR/output\"\n+\n+get_release_info\n+\n+# Place all RM scripts and necessary data in a local directory that must be defined in the command\n+# line. This directory is mounted into the image.\n+for f in \"$SELF\"/*; do\n+  if [ -f \"$f\" ]; then\n+    cp \"$f\" \"$WORKDIR\"\n+  fi\n+done\n+\n+GPG_KEY_FILE=\"$WORKDIR/gpg.key\"","path":"dev/create-release/do-release-docker.sh","position":94,"original_position":94,"commit_id":"745342d499ef290d5ce5484bcb2349d2be57a2fb","original_commit_id":"745342d499ef290d5ce5484bcb2349d2be57a2fb","user":{"login":"cloud-fan","id":3182036,"node_id":"MDQ6VXNlcjMxODIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3182036?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"how shall we generate this `gpg.key`?","created_at":"2018-09-16T02:56:34Z","updated_at":"2018-09-16T02:56:34Z","html_url":"https://github.com/apache/spark/pull/21515#discussion_r217900617","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21515","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/217900617"},"html":{"href":"https://github.com/apache/spark/pull/21515#discussion_r217900617"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21515"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21515","id":193745088,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzQ1MDg4","html_url":"https://github.com/apache/spark/pull/21515","diff_url":"https://github.com/apache/spark/pull/21515.diff","patch_url":"https://github.com/apache/spark/pull/21515.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21515","number":21515,"state":"closed","locked":false,"title":"[SPARK-24372][build] Add scripts to help with preparing releases.","user":{"login":"vanzin","id":1694083,"node_id":"MDQ6VXNlcjE2OTQwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"The \"do-release.sh\" script asks questions about the RC being prepared,\r\ntrying to find out as much as possible automatically, and then executes\r\nthe existing scripts with proper arguments to prepare the release. This\r\nscript was used to prepare the 2.3.1 release candidates, so was tested\r\nin that context.\r\n\r\nThe docker version runs that same script inside a docker image especially\r\ncrafted for building Spark releases. That image is based on the work\r\nby Felix C. linked in the bug. At this point is has been only midly\r\ntested.\r\n\r\nI also added a template for the vote e-mail, with placeholders for\r\nthings that need to be replaced, although there is no automation around\r\nthat for the moment. It shouldn't be hard to hook up certain things like\r\nversion and tags to this, or to figure out certain things like the\r\nrepo URL from the output of the release scripts.","created_at":"2018-06-08T23:44:03Z","updated_at":"2018-09-16T02:56:34Z","closed_at":"2018-06-22T17:43:08Z","merged_at":null,"merge_commit_sha":"5e217e66ef3e2c7308b978b551dc7301cb466517","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21515/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21515/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21515/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/745342d499ef290d5ce5484bcb2349d2be57a2fb","head":{"label":"vanzin:SPARK-24372","ref":"SPARK-24372","sha":"745342d499ef290d5ce5484bcb2349d2be57a2fb","user":{"login":"vanzin","id":1694083,"node_id":"MDQ6VXNlcjE2OTQwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"repo":{"id":18302272,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwMjI3Mg==","name":"spark","full_name":"vanzin/spark","private":false,"owner":{"login":"vanzin","id":1694083,"node_id":"MDQ6VXNlcjE2OTQwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vanzin/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/vanzin/spark","forks_url":"https://api.github.com/repos/vanzin/spark/forks","keys_url":"https://api.github.com/repos/vanzin/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanzin/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanzin/spark/teams","hooks_url":"https://api.github.com/repos/vanzin/spark/hooks","issue_events_url":"https://api.github.com/repos/vanzin/spark/issues/events{/number}","events_url":"https://api.github.com/repos/vanzin/spark/events","assignees_url":"https://api.github.com/repos/vanzin/spark/assignees{/user}","branches_url":"https://api.github.com/repos/vanzin/spark/branches{/branch}","tags_url":"https://api.github.com/repos/vanzin/spark/tags","blobs_url":"https://api.github.com/repos/vanzin/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanzin/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanzin/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanzin/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanzin/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/vanzin/spark/languages","stargazers_url":"https://api.github.com/repos/vanzin/spark/stargazers","contributors_url":"https://api.github.com/repos/vanzin/spark/contributors","subscribers_url":"https://api.github.com/repos/vanzin/spark/subscribers","subscription_url":"https://api.github.com/repos/vanzin/spark/subscription","commits_url":"https://api.github.com/repos/vanzin/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanzin/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanzin/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanzin/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanzin/spark/contents/{+path}","compare_url":"https://api.github.com/repos/vanzin/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanzin/spark/merges","archive_url":"https://api.github.com/repos/vanzin/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanzin/spark/downloads","issues_url":"https://api.github.com/repos/vanzin/spark/issues{/number}","pulls_url":"https://api.github.com/repos/vanzin/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/vanzin/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/vanzin/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanzin/spark/labels{/name}","releases_url":"https://api.github.com/repos/vanzin/spark/releases{/id}","deployments_url":"https://api.github.com/repos/vanzin/spark/deployments","created_at":"2014-03-31T17:49:25Z","updated_at":"2018-01-06T03:57:54Z","pushed_at":"2018-08-24T19:57:29Z","git_url":"git://github.com/vanzin/spark.git","ssh_url":"git@github.com:vanzin/spark.git","clone_url":"https://github.com/vanzin/spark.git","svn_url":"https://github.com/vanzin/spark","homepage":null,"size":249016,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f433ef786770e48e3594ad158ce9908f98ef0d9a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-09-16T02:20:12Z","pushed_at":"2018-09-16T00:49:20Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":281914,"stargazers_count":18785,"watchers_count":18785,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16914,"mirror_url":null,"archived":false,"open_issues_count":493,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16914,"open_issues":493,"watchers":18785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21515"},"html":{"href":"https://github.com/apache/spark/pull/21515"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21515"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21515/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21515/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21515/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/745342d499ef290d5ce5484bcb2349d2be57a2fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cloud-fan"}}