{"action":"created","comment":{"url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/comments/172469198","pull_request_review_id":101487318,"id":172469198,"diff_hunk":"@@ -67,9 +62,9 @@ const Input = (props: Props) => {\n   }\n   if (props.label) {\n     return (\n-      <Label htmlFor={domId} css={props.css} className={props.className} key={props.id}>\n-        {props.label}\n-        <InputField {...commonInputProps} key={props.id} />\n+      <Label htmlFor={forAttributeId} css={props.css} className={props.className} key={props.id}>\n+        <span>{props.label}</span>","path":"packages/components/src/Input.tsx","position":null,"original_position":31,"commit_id":"855058e301c4819317965bea37b92077fbf2f23b","original_commit_id":"855058e301c4819317965bea37b92077fbf2f23b","user":{"login":"TejasQ","id":9947422,"avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false},"body":"Why the span?","created_at":"2018-03-06T10:16:56Z","updated_at":"2018-03-06T10:17:21Z","html_url":"https://github.com/Contiamo/operational-ui/pull/342#discussion_r172469198","pull_request_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/comments/172469198"},"html":{"href":"https://github.com/Contiamo/operational-ui/pull/342#discussion_r172469198"},"pull_request":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342","id":172948064,"html_url":"https://github.com/Contiamo/operational-ui/pull/342","diff_url":"https://github.com/Contiamo/operational-ui/pull/342.diff","patch_url":"https://github.com/Contiamo/operational-ui/pull/342.patch","issue_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/342","number":342,"state":"open","locked":false,"title":"Simple idiomatic input","user":{"login":"peterszerzo","id":6738398,"avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},"body":"Fixes #321, a first of three commits aimed at making input fields simpler to style.\r\n* [x] remove `withLabel` HOC - instead, move label styling into `src/utils/mixins`, to be used across Select, DatePicker and Checkbox (separate commits).\r\n* [x] conditionally render `<label>` tag.\r\n* [x] `css` and `className` attributes should work differently whether there's a label or not. Handle this in a maintainable way.","created_at":"2018-03-05T18:26:55Z","updated_at":"2018-03-06T10:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5557ef7afa860ffff458735ea4b7bc3138a68710","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":728468963,"url":"https://api.github.com/repos/Contiamo/operational-ui/labels/%E2%9C%85%20%20%20Can%20merge","name":"✅   Can merge","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342/commits","review_comments_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342/comments","review_comment_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/342/comments","statuses_url":"https://api.github.com/repos/Contiamo/operational-ui/statuses/855058e301c4819317965bea37b92077fbf2f23b","head":{"label":"Contiamo:simpler-input","ref":"simpler-input","sha":"855058e301c4819317965bea37b92077fbf2f23b","user":{"login":"Contiamo","id":862286,"avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/Contiamo","html_url":"https://github.com/Contiamo","followers_url":"https://api.github.com/users/Contiamo/followers","following_url":"https://api.github.com/users/Contiamo/following{/other_user}","gists_url":"https://api.github.com/users/Contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/Contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Contiamo/subscriptions","organizations_url":"https://api.github.com/users/Contiamo/orgs","repos_url":"https://api.github.com/users/Contiamo/repos","events_url":"https://api.github.com/users/Contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/Contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"name":"operational-ui","full_name":"Contiamo/operational-ui","owner":{"login":"Contiamo","id":862286,"avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/Contiamo","html_url":"https://github.com/Contiamo","followers_url":"https://api.github.com/users/Contiamo/followers","following_url":"https://api.github.com/users/Contiamo/following{/other_user}","gists_url":"https://api.github.com/users/Contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/Contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Contiamo/subscriptions","organizations_url":"https://api.github.com/users/Contiamo/orgs","repos_url":"https://api.github.com/users/Contiamo/repos","events_url":"https://api.github.com/users/Contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/Contiamo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/Contiamo/operational-ui","forks_url":"https://api.github.com/repos/Contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/Contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/Contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/Contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/Contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/Contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/Contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/Contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/Contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/Contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/Contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/Contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/Contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-02-26T20:01:17Z","pushed_at":"2018-03-06T10:15:45Z","git_url":"git://github.com/Contiamo/operational-ui.git","ssh_url":"git@github.com:Contiamo/operational-ui.git","clone_url":"https://github.com/Contiamo/operational-ui.git","svn_url":"https://github.com/Contiamo/operational-ui","homepage":"https://ui.contiamo.com/","size":29823,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":16,"watchers":22,"default_branch":"master"}},"base":{"label":"Contiamo:master","ref":"master","sha":"537e133f6f6bcd5f0b3ee4ce5eaca22c1a9a61df","user":{"login":"Contiamo","id":862286,"avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/Contiamo","html_url":"https://github.com/Contiamo","followers_url":"https://api.github.com/users/Contiamo/followers","following_url":"https://api.github.com/users/Contiamo/following{/other_user}","gists_url":"https://api.github.com/users/Contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/Contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Contiamo/subscriptions","organizations_url":"https://api.github.com/users/Contiamo/orgs","repos_url":"https://api.github.com/users/Contiamo/repos","events_url":"https://api.github.com/users/Contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/Contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"name":"operational-ui","full_name":"Contiamo/operational-ui","owner":{"login":"Contiamo","id":862286,"avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/Contiamo","html_url":"https://github.com/Contiamo","followers_url":"https://api.github.com/users/Contiamo/followers","following_url":"https://api.github.com/users/Contiamo/following{/other_user}","gists_url":"https://api.github.com/users/Contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/Contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Contiamo/subscriptions","organizations_url":"https://api.github.com/users/Contiamo/orgs","repos_url":"https://api.github.com/users/Contiamo/repos","events_url":"https://api.github.com/users/Contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/Contiamo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/Contiamo/operational-ui","forks_url":"https://api.github.com/repos/Contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/Contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/Contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/Contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/Contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/Contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/Contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/Contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/Contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/Contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/Contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/Contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/Contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-02-26T20:01:17Z","pushed_at":"2018-03-06T10:15:45Z","git_url":"git://github.com/Contiamo/operational-ui.git","ssh_url":"git@github.com:Contiamo/operational-ui.git","clone_url":"https://github.com/Contiamo/operational-ui.git","svn_url":"https://github.com/Contiamo/operational-ui","homepage":"https://ui.contiamo.com/","size":29823,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":16,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342"},"html":{"href":"https://github.com/Contiamo/operational-ui/pull/342"},"issue":{"href":"https://api.github.com/repos/Contiamo/operational-ui/issues/342"},"comments":{"href":"https://api.github.com/repos/Contiamo/operational-ui/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Contiamo/operational-ui/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/Contiamo/operational-ui/statuses/855058e301c4819317965bea37b92077fbf2f23b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TejasQ"}}