{"action":"created","comment":{"url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/comments/172600918","pull_request_review_id":101645718,"id":172600918,"diff_hunk":"@@ -515,44 +512,43 @@ def join_app_task_ujs(self, exec_tasks, exec_apps, ujs_jobs):\n             u_j_s['creation_time'] = u_j_s.pop('created')\n             u_j_s['modification_time'] = u_j_s.pop('updated')\n             u_j_s['estcompl'] = j.get('estcompl', None)\n-            u_j_s['time_info'] = [u_j_s.get('creation_time'),\n-                                  u_j_s.get('modification_time'),\n-                                  u_j_s['estcompl']]\n \n-            if u_j_s.get('authstrat', None) == 'kbaseworkspace':\n-                u_j_s['wsid'] = u_j_s.get('authparam')\n+            authparam = u_j_s.pop('authparam')\n+            authstrat = u_j_s.pop('authstrat')\n+            if authstrat == 'kbaseworkspace':\n+                u_j_s['wsid'] = authparam\n \n             if u_j_s.get('desc'):\n-                desc = u_j_s['desc'].split()[-1]\n+                desc = u_j_s.pop('desc').split()[-1]\n                 if '.' in desc:\n                     u_j_s['method'] = desc\n \n             # Assuming complete, error and status all exist in the records returned\n-            if not j.get('error'):\n-                if j.get('complete'):\n+            if not u_j_s.get('error'):\n+                if u_j_s.get('complete'):\n                     u_j_s['job_state'] = 'completed'","path":"lib/kb_Metrics/metricsdb_controller.py","position":60,"original_position":60,"commit_id":"d10bbf18b4c5872f953ac232baf4f14ccf8db578","original_commit_id":"d10bbf18b4c5872f953ac232baf4f14ccf8db578","user":{"login":"qzzhang","id":19156975,"avatar_url":"https://avatars3.githubusercontent.com/u/19156975?v=4","gravatar_id":"","url":"https://api.github.com/users/qzzhang","html_url":"https://github.com/qzzhang","followers_url":"https://api.github.com/users/qzzhang/followers","following_url":"https://api.github.com/users/qzzhang/following{/other_user}","gists_url":"https://api.github.com/users/qzzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qzzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzzhang/subscriptions","organizations_url":"https://api.github.com/users/qzzhang/orgs","repos_url":"https://api.github.com/users/qzzhang/repos","events_url":"https://api.github.com/users/qzzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qzzhang/received_events","type":"User","site_admin":false},"body":"Tian: this is a good question.  No one gave me a well defined required data items to start with, except the previous appcatalog/stats plus many inputs from the PD doc. And the main data source is called 'userjobstate', so it was natural to assume that is the major data wanted.  It was the main term used for this project.  And I had assumed it was required. When performance was not an issue, it was not a big deal.  \r\n\r\nUntil yesterday, when I went through the kbase-ui call, I realized the job_state from kb_Metrics was not used.  So I am fine to remove it.\r\n\r\nHowever, as you might have noticed that Paramvir was requesting to have the client_groups displayed.  That was one of the original data items.\r\n\r\n","created_at":"2018-03-06T17:43:44Z","updated_at":"2018-03-06T17:43:44Z","html_url":"https://github.com/kbaseapps/kb_Metrics/pull/9#discussion_r172600918","pull_request_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/comments/172600918"},"html":{"href":"https://github.com/kbaseapps/kb_Metrics/pull/9#discussion_r172600918"},"pull_request":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9"}},"in_reply_to_id":172593818},"pull_request":{"url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9","id":173007760,"html_url":"https://github.com/kbaseapps/kb_Metrics/pull/9","diff_url":"https://github.com/kbaseapps/kb_Metrics/pull/9.diff","patch_url":"https://github.com/kbaseapps/kb_Metrics/pull/9.patch","issue_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/9","number":9,"state":"open","locked":false,"title":"Reduced serviced data structure for appcatalog/stats","user":{"login":"qzzhang","id":19156975,"avatar_url":"https://avatars3.githubusercontent.com/u/19156975?v=4","gravatar_id":"","url":"https://api.github.com/users/qzzhang","html_url":"https://github.com/qzzhang","followers_url":"https://api.github.com/users/qzzhang/followers","following_url":"https://api.github.com/users/qzzhang/following{/other_user}","gists_url":"https://api.github.com/users/qzzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qzzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzzhang/subscriptions","organizations_url":"https://api.github.com/users/qzzhang/orgs","repos_url":"https://api.github.com/users/qzzhang/repos","events_url":"https://api.github.com/users/qzzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qzzhang/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-05T22:39:24Z","updated_at":"2018-03-06T17:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512f2966b40a0b9c7c907cde6e9f00dd24cd13a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9/commits","review_comments_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9/comments","review_comment_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/9/comments","statuses_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/statuses/d10bbf18b4c5872f953ac232baf4f14ccf8db578","head":{"label":"qzzhang:dev","ref":"dev","sha":"d10bbf18b4c5872f953ac232baf4f14ccf8db578","user":{"login":"qzzhang","id":19156975,"avatar_url":"https://avatars3.githubusercontent.com/u/19156975?v=4","gravatar_id":"","url":"https://api.github.com/users/qzzhang","html_url":"https://github.com/qzzhang","followers_url":"https://api.github.com/users/qzzhang/followers","following_url":"https://api.github.com/users/qzzhang/following{/other_user}","gists_url":"https://api.github.com/users/qzzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qzzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzzhang/subscriptions","organizations_url":"https://api.github.com/users/qzzhang/orgs","repos_url":"https://api.github.com/users/qzzhang/repos","events_url":"https://api.github.com/users/qzzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qzzhang/received_events","type":"User","site_admin":false},"repo":{"id":123437177,"name":"kb_Metrics","full_name":"qzzhang/kb_Metrics","owner":{"login":"qzzhang","id":19156975,"avatar_url":"https://avatars3.githubusercontent.com/u/19156975?v=4","gravatar_id":"","url":"https://api.github.com/users/qzzhang","html_url":"https://github.com/qzzhang","followers_url":"https://api.github.com/users/qzzhang/followers","following_url":"https://api.github.com/users/qzzhang/following{/other_user}","gists_url":"https://api.github.com/users/qzzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qzzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzzhang/subscriptions","organizations_url":"https://api.github.com/users/qzzhang/orgs","repos_url":"https://api.github.com/users/qzzhang/repos","events_url":"https://api.github.com/users/qzzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qzzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qzzhang/kb_Metrics","description":"KBase Metrics","fork":true,"url":"https://api.github.com/repos/qzzhang/kb_Metrics","forks_url":"https://api.github.com/repos/qzzhang/kb_Metrics/forks","keys_url":"https://api.github.com/repos/qzzhang/kb_Metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qzzhang/kb_Metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qzzhang/kb_Metrics/teams","hooks_url":"https://api.github.com/repos/qzzhang/kb_Metrics/hooks","issue_events_url":"https://api.github.com/repos/qzzhang/kb_Metrics/issues/events{/number}","events_url":"https://api.github.com/repos/qzzhang/kb_Metrics/events","assignees_url":"https://api.github.com/repos/qzzhang/kb_Metrics/assignees{/user}","branches_url":"https://api.github.com/repos/qzzhang/kb_Metrics/branches{/branch}","tags_url":"https://api.github.com/repos/qzzhang/kb_Metrics/tags","blobs_url":"https://api.github.com/repos/qzzhang/kb_Metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qzzhang/kb_Metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qzzhang/kb_Metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/qzzhang/kb_Metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qzzhang/kb_Metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/qzzhang/kb_Metrics/languages","stargazers_url":"https://api.github.com/repos/qzzhang/kb_Metrics/stargazers","contributors_url":"https://api.github.com/repos/qzzhang/kb_Metrics/contributors","subscribers_url":"https://api.github.com/repos/qzzhang/kb_Metrics/subscribers","subscription_url":"https://api.github.com/repos/qzzhang/kb_Metrics/subscription","commits_url":"https://api.github.com/repos/qzzhang/kb_Metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/qzzhang/kb_Metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/qzzhang/kb_Metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/qzzhang/kb_Metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/qzzhang/kb_Metrics/contents/{+path}","compare_url":"https://api.github.com/repos/qzzhang/kb_Metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qzzhang/kb_Metrics/merges","archive_url":"https://api.github.com/repos/qzzhang/kb_Metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qzzhang/kb_Metrics/downloads","issues_url":"https://api.github.com/repos/qzzhang/kb_Metrics/issues{/number}","pulls_url":"https://api.github.com/repos/qzzhang/kb_Metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/qzzhang/kb_Metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/qzzhang/kb_Metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qzzhang/kb_Metrics/labels{/name}","releases_url":"https://api.github.com/repos/qzzhang/kb_Metrics/releases{/id}","deployments_url":"https://api.github.com/repos/qzzhang/kb_Metrics/deployments","created_at":"2018-03-01T13:16:10Z","updated_at":"2018-03-01T13:16:12Z","pushed_at":"2018-03-06T16:33:46Z","git_url":"git://github.com/qzzhang/kb_Metrics.git","ssh_url":"git@github.com:qzzhang/kb_Metrics.git","clone_url":"https://github.com/qzzhang/kb_Metrics.git","svn_url":"https://github.com/qzzhang/kb_Metrics","homepage":null,"size":387,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kbaseapps:dev","ref":"dev","sha":"639ec66821e87e648a43348ecbe7c0e79357dd02","user":{"login":"kbaseapps","id":17482783,"avatar_url":"https://avatars0.githubusercontent.com/u/17482783?v=4","gravatar_id":"","url":"https://api.github.com/users/kbaseapps","html_url":"https://github.com/kbaseapps","followers_url":"https://api.github.com/users/kbaseapps/followers","following_url":"https://api.github.com/users/kbaseapps/following{/other_user}","gists_url":"https://api.github.com/users/kbaseapps/gists{/gist_id}","starred_url":"https://api.github.com/users/kbaseapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbaseapps/subscriptions","organizations_url":"https://api.github.com/users/kbaseapps/orgs","repos_url":"https://api.github.com/users/kbaseapps/repos","events_url":"https://api.github.com/users/kbaseapps/events{/privacy}","received_events_url":"https://api.github.com/users/kbaseapps/received_events","type":"Organization","site_admin":false},"repo":{"id":108290854,"name":"kb_Metrics","full_name":"kbaseapps/kb_Metrics","owner":{"login":"kbaseapps","id":17482783,"avatar_url":"https://avatars0.githubusercontent.com/u/17482783?v=4","gravatar_id":"","url":"https://api.github.com/users/kbaseapps","html_url":"https://github.com/kbaseapps","followers_url":"https://api.github.com/users/kbaseapps/followers","following_url":"https://api.github.com/users/kbaseapps/following{/other_user}","gists_url":"https://api.github.com/users/kbaseapps/gists{/gist_id}","starred_url":"https://api.github.com/users/kbaseapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbaseapps/subscriptions","organizations_url":"https://api.github.com/users/kbaseapps/orgs","repos_url":"https://api.github.com/users/kbaseapps/repos","events_url":"https://api.github.com/users/kbaseapps/events{/privacy}","received_events_url":"https://api.github.com/users/kbaseapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kbaseapps/kb_Metrics","description":"KBase Metrics","fork":false,"url":"https://api.github.com/repos/kbaseapps/kb_Metrics","forks_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/forks","keys_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/teams","hooks_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/hooks","issue_events_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/events{/number}","events_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/events","assignees_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/assignees{/user}","branches_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/branches{/branch}","tags_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/tags","blobs_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/languages","stargazers_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/stargazers","contributors_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/contributors","subscribers_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/subscribers","subscription_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/subscription","commits_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/contents/{+path}","compare_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/merges","archive_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/downloads","issues_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues{/number}","pulls_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/labels{/name}","releases_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/releases{/id}","deployments_url":"https://api.github.com/repos/kbaseapps/kb_Metrics/deployments","created_at":"2017-10-25T15:42:20Z","updated_at":"2017-10-25T15:43:23Z","pushed_at":"2018-03-06T16:35:14Z","git_url":"git://github.com/kbaseapps/kb_Metrics.git","ssh_url":"git@github.com:kbaseapps/kb_Metrics.git","clone_url":"https://github.com/kbaseapps/kb_Metrics.git","svn_url":"https://github.com/kbaseapps/kb_Metrics","homepage":null,"size":346,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9"},"html":{"href":"https://github.com/kbaseapps/kb_Metrics/pull/9"},"issue":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/9"},"comments":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/kbaseapps/kb_Metrics/statuses/d10bbf18b4c5872f953ac232baf4f14ccf8db578"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qzzhang"}}