{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments/215770024","pull_request_review_id":153111434,"id":215770024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTc3MDAyNA==","diff_hunk":"@@ -922,6 +1033,27 @@ create_version() {\n \t\t\tcreate_tar \"$mom\"\n \t\t\tsign_manifest \"$mom\"\n \t\tfi\n+\t\t# when creating a new version we need to make an update to os-release and format\n+\t\t# files in the os-core bundle (unless otherwise specified or if bundle does not exist)\n+\t\tif [ \"$release_files\" = true ]; then\n+\t\t\toldversion=\"$version\"\n+\t\t\twhile [ \"$oldversion\" -gt 0 ] && [ ! -e \"$env_name\"/web-dir/\"$oldversion\"/Manifest.os-core ]; do\n+\t\t\t\toldversion=$(awk '/previous/ { print $2 }' \"$env_name\"/web-dir/\"$oldversion\"/Manifest.MoM)","path":"test/functional/testlib.bash","position":127,"original_position":127,"commit_id":"ca38b6d1fe16f4eb3395336e2f9b967ad6836f64","original_commit_id":"ca38b6d1fe16f4eb3395336e2f9b967ad6836f64","user":{"login":"castulo","id":2782179,"node_id":"MDQ6VXNlcjI3ODIxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2782179?v=4","gravatar_id":"","url":"https://api.github.com/users/castulo","html_url":"https://github.com/castulo","followers_url":"https://api.github.com/users/castulo/followers","following_url":"https://api.github.com/users/castulo/following{/other_user}","gists_url":"https://api.github.com/users/castulo/gists{/gist_id}","starred_url":"https://api.github.com/users/castulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castulo/subscriptions","organizations_url":"https://api.github.com/users/castulo/orgs","repos_url":"https://api.github.com/users/castulo/repos","events_url":"https://api.github.com/users/castulo/events{/privacy}","received_events_url":"https://api.github.com/users/castulo/received_events","type":"User","site_admin":false},"body":"you are right, I never thought of that, but it could happen, I'll make the change","created_at":"2018-09-06T20:40:37Z","updated_at":"2018-09-06T20:40:37Z","html_url":"https://github.com/clearlinux/swupd-client/pull/552#discussion_r215770024","pull_request_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments/215770024"},"html":{"href":"https://github.com/clearlinux/swupd-client/pull/552#discussion_r215770024"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552"}},"in_reply_to_id":215484596},"pull_request":{"url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552","id":210566808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTY2ODA4","html_url":"https://github.com/clearlinux/swupd-client/pull/552","diff_url":"https://github.com/clearlinux/swupd-client/pull/552.diff","patch_url":"https://github.com/clearlinux/swupd-client/pull/552.patch","issue_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/552","number":552,"state":"open","locked":false,"title":"Adding functions to update bundles and bump format","user":{"login":"castulo","id":2782179,"node_id":"MDQ6VXNlcjI3ODIxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2782179?v=4","gravatar_id":"","url":"https://api.github.com/users/castulo","html_url":"https://github.com/castulo","followers_url":"https://api.github.com/users/castulo/followers","following_url":"https://api.github.com/users/castulo/following{/other_user}","gists_url":"https://api.github.com/users/castulo/gists{/gist_id}","starred_url":"https://api.github.com/users/castulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castulo/subscriptions","organizations_url":"https://api.github.com/users/castulo/orgs","repos_url":"https://api.github.com/users/castulo/repos","events_url":"https://api.github.com/users/castulo/events{/privacy}","received_events_url":"https://api.github.com/users/castulo/received_events","type":"User","site_admin":false},"body":"This PR adds a couple of function which are very useful when working with tests that require multiple update versions of a bundle.\r\n- update_bundle: allow users to create different kind of updates for a bundle between two versions in the server side content.\r\n- bump_format: automatically creates an increase in the format version used in manifests, this requires two versions to be created with an update is os-core, os-core will update the os-release and format files.","created_at":"2018-08-23T20:28:52Z","updated_at":"2018-09-06T20:40:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2d14b939c6271b6d469de700118bcb3f7d1bba5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"evil-brain","id":20782529,"node_id":"MDQ6VXNlcjIwNzgyNTI5","avatar_url":"https://avatars2.githubusercontent.com/u/20782529?v=4","gravatar_id":"","url":"https://api.github.com/users/evil-brain","html_url":"https://github.com/evil-brain","followers_url":"https://api.github.com/users/evil-brain/followers","following_url":"https://api.github.com/users/evil-brain/following{/other_user}","gists_url":"https://api.github.com/users/evil-brain/gists{/gist_id}","starred_url":"https://api.github.com/users/evil-brain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evil-brain/subscriptions","organizations_url":"https://api.github.com/users/evil-brain/orgs","repos_url":"https://api.github.com/users/evil-brain/repos","events_url":"https://api.github.com/users/evil-brain/events{/privacy}","received_events_url":"https://api.github.com/users/evil-brain/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552/commits","review_comments_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552/comments","review_comment_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/552/comments","statuses_url":"https://api.github.com/repos/clearlinux/swupd-client/statuses/ca38b6d1fe16f4eb3395336e2f9b967ad6836f64","head":{"label":"castulo:testlib_update_bump","ref":"testlib_update_bump","sha":"ca38b6d1fe16f4eb3395336e2f9b967ad6836f64","user":{"login":"castulo","id":2782179,"node_id":"MDQ6VXNlcjI3ODIxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2782179?v=4","gravatar_id":"","url":"https://api.github.com/users/castulo","html_url":"https://github.com/castulo","followers_url":"https://api.github.com/users/castulo/followers","following_url":"https://api.github.com/users/castulo/following{/other_user}","gists_url":"https://api.github.com/users/castulo/gists{/gist_id}","starred_url":"https://api.github.com/users/castulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castulo/subscriptions","organizations_url":"https://api.github.com/users/castulo/orgs","repos_url":"https://api.github.com/users/castulo/repos","events_url":"https://api.github.com/users/castulo/events{/privacy}","received_events_url":"https://api.github.com/users/castulo/received_events","type":"User","site_admin":false},"repo":{"id":136248150,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNDgxNTA=","name":"swupd-client","full_name":"castulo/swupd-client","owner":{"login":"castulo","id":2782179,"node_id":"MDQ6VXNlcjI3ODIxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2782179?v=4","gravatar_id":"","url":"https://api.github.com/users/castulo","html_url":"https://github.com/castulo","followers_url":"https://api.github.com/users/castulo/followers","following_url":"https://api.github.com/users/castulo/following{/other_user}","gists_url":"https://api.github.com/users/castulo/gists{/gist_id}","starred_url":"https://api.github.com/users/castulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castulo/subscriptions","organizations_url":"https://api.github.com/users/castulo/orgs","repos_url":"https://api.github.com/users/castulo/repos","events_url":"https://api.github.com/users/castulo/events{/privacy}","received_events_url":"https://api.github.com/users/castulo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/castulo/swupd-client","description":"Software update client","fork":true,"url":"https://api.github.com/repos/castulo/swupd-client","forks_url":"https://api.github.com/repos/castulo/swupd-client/forks","keys_url":"https://api.github.com/repos/castulo/swupd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castulo/swupd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castulo/swupd-client/teams","hooks_url":"https://api.github.com/repos/castulo/swupd-client/hooks","issue_events_url":"https://api.github.com/repos/castulo/swupd-client/issues/events{/number}","events_url":"https://api.github.com/repos/castulo/swupd-client/events","assignees_url":"https://api.github.com/repos/castulo/swupd-client/assignees{/user}","branches_url":"https://api.github.com/repos/castulo/swupd-client/branches{/branch}","tags_url":"https://api.github.com/repos/castulo/swupd-client/tags","blobs_url":"https://api.github.com/repos/castulo/swupd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castulo/swupd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castulo/swupd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/castulo/swupd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castulo/swupd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/castulo/swupd-client/languages","stargazers_url":"https://api.github.com/repos/castulo/swupd-client/stargazers","contributors_url":"https://api.github.com/repos/castulo/swupd-client/contributors","subscribers_url":"https://api.github.com/repos/castulo/swupd-client/subscribers","subscription_url":"https://api.github.com/repos/castulo/swupd-client/subscription","commits_url":"https://api.github.com/repos/castulo/swupd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/castulo/swupd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/castulo/swupd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/castulo/swupd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/castulo/swupd-client/contents/{+path}","compare_url":"https://api.github.com/repos/castulo/swupd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castulo/swupd-client/merges","archive_url":"https://api.github.com/repos/castulo/swupd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castulo/swupd-client/downloads","issues_url":"https://api.github.com/repos/castulo/swupd-client/issues{/number}","pulls_url":"https://api.github.com/repos/castulo/swupd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/castulo/swupd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/castulo/swupd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castulo/swupd-client/labels{/name}","releases_url":"https://api.github.com/repos/castulo/swupd-client/releases{/id}","deployments_url":"https://api.github.com/repos/castulo/swupd-client/deployments","created_at":"2018-06-06T00:02:03Z","updated_at":"2018-08-28T00:44:36Z","pushed_at":"2018-08-28T00:45:12Z","git_url":"git://github.com/castulo/swupd-client.git","ssh_url":"git@github.com:castulo/swupd-client.git","clone_url":"https://github.com/castulo/swupd-client.git","svn_url":"https://github.com/castulo/swupd-client","homepage":null,"size":2192,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"7e52b4eb71befe8ba2657ab41d4b10bfb79121d0","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":52470178,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ3MDE3OA==","name":"swupd-client","full_name":"clearlinux/swupd-client","owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/swupd-client","description":"Software update client","fork":false,"url":"https://api.github.com/repos/clearlinux/swupd-client","forks_url":"https://api.github.com/repos/clearlinux/swupd-client/forks","keys_url":"https://api.github.com/repos/clearlinux/swupd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/swupd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/swupd-client/teams","hooks_url":"https://api.github.com/repos/clearlinux/swupd-client/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/swupd-client/events","assignees_url":"https://api.github.com/repos/clearlinux/swupd-client/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/swupd-client/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/swupd-client/tags","blobs_url":"https://api.github.com/repos/clearlinux/swupd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/swupd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/swupd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/swupd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/swupd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/swupd-client/languages","stargazers_url":"https://api.github.com/repos/clearlinux/swupd-client/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/swupd-client/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/swupd-client/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/swupd-client/subscription","commits_url":"https://api.github.com/repos/clearlinux/swupd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/swupd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/swupd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/swupd-client/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/swupd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/swupd-client/merges","archive_url":"https://api.github.com/repos/clearlinux/swupd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/swupd-client/downloads","issues_url":"https://api.github.com/repos/clearlinux/swupd-client/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/swupd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/swupd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/swupd-client/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/swupd-client/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/swupd-client/deployments","created_at":"2016-02-24T19:54:13Z","updated_at":"2018-09-05T23:15:06Z","pushed_at":"2018-09-05T23:15:04Z","git_url":"git://github.com/clearlinux/swupd-client.git","ssh_url":"git@github.com:clearlinux/swupd-client.git","clone_url":"https://github.com/clearlinux/swupd-client.git","svn_url":"https://github.com/clearlinux/swupd-client","homepage":null,"size":2167,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":64,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552"},"html":{"href":"https://github.com/clearlinux/swupd-client/pull/552"},"issue":{"href":"https://api.github.com/repos/clearlinux/swupd-client/issues/552"},"comments":{"href":"https://api.github.com/repos/clearlinux/swupd-client/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/swupd-client/statuses/ca38b6d1fe16f4eb3395336e2f9b967ad6836f64"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"castulo"}}