{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7714","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7714/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7714/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7714/events","html_url":"https://github.com/coq/coq/pull/7714","id":329632107,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODQxODU0","number":7714,"title":"Remove primitive-projection related data from the kernel","user":{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"labels":[{"id":485985791,"node_id":"MDU6TGFiZWw0ODU5ODU3OTE=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20cleanup","name":"kind: cleanup","color":"3366ff","default":false},{"id":614883102,"node_id":"MDU6TGFiZWw2MTQ4ODMxMDI=","url":"https://api.github.com/repos/coq/coq/labels/needs:%20rebase","name":"needs: rebase","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"assignees":[{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"node_id":"MDk6TWlsZXN0b25lMjY0Nzc0Mw==","number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":229,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-06-17T09:06:07Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-05T21:29:29Z","updated_at":"2018-06-17T09:45:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7714","html_url":"https://github.com/coq/coq/pull/7714","diff_url":"https://github.com/coq/coq/pull/7714.diff","patch_url":"https://github.com/coq/coq/pull/7714.patch"},"body":"This PR removes redundant or even outright wrong data from data structures going through the kernel.\r\n\r\n- `const_proj` from `const_body`: this is redundant with the data stored in the environment since #7234\r\n- `ProjectionEntry` from `constant_entry`: removal of the above fields allow to define projection bodies out of the kernel\r\n- `proj_eta` from `projection_body`: only needed by `ProjectionEntry`, no need to cache it in the kernel\r\n- `proj_body` from `projection_body`: only needed by compatibility printing and extraction.\r\n\r\nIn the last case, this is completely wrong: the generated term does not even type-check in the kernel due to the fact it uses pattern-matching over negative records.\r\n\r\nSeveral followup PRs are pending on this one, but I'm not publishing them before this one is merged not to flood everybody with PR dependencies."},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/397867182","html_url":"https://github.com/coq/coq/pull/7714#issuecomment-397867182","issue_url":"https://api.github.com/repos/coq/coq/issues/7714","id":397867182,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg2NzE4Mg==","user":{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T09:45:53Z","updated_at":"2018-06-17T09:45:53Z","author_association":"MEMBER","body":"@maximedenes Nitpicks addressed, rebased and benchmark running there: https://ci.inria.fr/coq/job/benchmark-part-of-the-branch/451/.\r\n"}}
{"actor":{"display_login":"ppedrot"}}