{"action":"closed","number":23738,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738","id":198976588,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTc2NTg4","html_url":"https://github.com/cms-sw/cmssw/pull/23738","diff_url":"https://github.com/cms-sw/cmssw/pull/23738.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23738.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23738","number":23738,"state":"closed","locked":false,"title":"Improvements and fixes for the BPH-trigger offline DQM code","user":{"login":"aboletti","id":12882645,"node_id":"MDQ6VXNlcjEyODgyNjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/12882645?v=4","gravatar_id":"","url":"https://api.github.com/users/aboletti","html_url":"https://github.com/aboletti","followers_url":"https://api.github.com/users/aboletti/followers","following_url":"https://api.github.com/users/aboletti/following{/other_user}","gists_url":"https://api.github.com/users/aboletti/gists{/gist_id}","starred_url":"https://api.github.com/users/aboletti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboletti/subscriptions","organizations_url":"https://api.github.com/users/aboletti/orgs","repos_url":"https://api.github.com/users/aboletti/repos","events_url":"https://api.github.com/users/aboletti/events{/privacy}","received_events_url":"https://api.github.com/users/aboletti/received_events","type":"User","site_admin":false},"body":"In this pull-request many features of the offline DQM code used for BPH triggers have been fixed and optimised, and few more functionalities have been added.\r\nHere a list of the major changes:\r\n\r\n- **New general structure** of the code: for each efficiency type (defined as the \"cases\" in the big \"switch\") the numerator histos are filled in a nested environment just after the denominator filling, instead of defining two separate environments with specific selection criteria for each of them.\r\n- **Fixed trigger matching** feature: the `bool BPHMonitor::matchToTrigger` function is now using the HLTConfigProvider method to access the trigger-object collections.\r\n- **New correction for prescaled triggers**: while using the reference method to produce efficiencies, if the numerator path is prescaled it would flatly decrease the resulting efficiency by that prescale value. By filling the numerator histograms with weighted events, according to that prescale, the reduction effect is corrected.\r\n- **Better tuning of the offline selections** (especially the dimuon invariant masses), to select the correct regions where to compute the efficiency. This helps in some modules to select a pure region for the signal, in other modules (based on background events) to select the appropriate kinematic region.\r\n- **Customised and optimised binning**: to reduce the global number of bins, especially where they are not needed, the binning of the histograms has been refined\r\n- **Removal of few meaningless efficiencies**: some modules defined in the list of the cff file (devoted to the L1 efficiency of dR(MuMu) cut in 2mu+trk triggers) have been removed, since their efficiency definition is not correct (using at denominator a 2mu trigger, they will always be biased by the inefficiency of the track reconstruction at HLT)","created_at":"2018-07-03T14:09:47Z","updated_at":"2018-07-12T20:54:08Z","closed_at":"2018-07-12T20:54:08Z","merged_at":"2018-07-12T20:54:08Z","merge_commit_sha":"d97b988fbc34117137b4093ae82fd9f5faad7779","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52882241,"node_id":"MDU6TGFiZWw1Mjg4MjI0MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"2cbe4e","default":false},{"id":53149121,"node_id":"MDU6TGFiZWw1MzE0OTEyMQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"2cbe4e","default":false},{"id":290514704,"node_id":"MDU6TGFiZWwyOTA1MTQ3MDQ=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"2cbe4e","default":false},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"node_id":"MDk6TWlsZXN0b25lMzIyNzYzMQ==","number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":727,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-07-12T20:54:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23738/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/51d6fc6250054ac587f033da3a5e1a0477232e8f","head":{"label":"cms-bph-trigger:OfflineDQM_June2018_IntegrationBranch-from-CMSSW_10_2_X_2018-07-02-2300","ref":"OfflineDQM_June2018_IntegrationBranch-from-CMSSW_10_2_X_2018-07-02-2300","sha":"51d6fc6250054ac587f033da3a5e1a0477232e8f","user":{"login":"cms-bph-trigger","id":26557277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTU3Mjc3","avatar_url":"https://avatars3.githubusercontent.com/u/26557277?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-bph-trigger","html_url":"https://github.com/cms-bph-trigger","followers_url":"https://api.github.com/users/cms-bph-trigger/followers","following_url":"https://api.github.com/users/cms-bph-trigger/following{/other_user}","gists_url":"https://api.github.com/users/cms-bph-trigger/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-bph-trigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-bph-trigger/subscriptions","organizations_url":"https://api.github.com/users/cms-bph-trigger/orgs","repos_url":"https://api.github.com/users/cms-bph-trigger/repos","events_url":"https://api.github.com/users/cms-bph-trigger/events{/privacy}","received_events_url":"https://api.github.com/users/cms-bph-trigger/received_events","type":"Organization","site_admin":false},"repo":{"id":85760034,"node_id":"MDEwOlJlcG9zaXRvcnk4NTc2MDAzNA==","name":"cmssw","full_name":"cms-bph-trigger/cmssw","owner":{"login":"cms-bph-trigger","id":26557277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTU3Mjc3","avatar_url":"https://avatars3.githubusercontent.com/u/26557277?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-bph-trigger","html_url":"https://github.com/cms-bph-trigger","followers_url":"https://api.github.com/users/cms-bph-trigger/followers","following_url":"https://api.github.com/users/cms-bph-trigger/following{/other_user}","gists_url":"https://api.github.com/users/cms-bph-trigger/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-bph-trigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-bph-trigger/subscriptions","organizations_url":"https://api.github.com/users/cms-bph-trigger/orgs","repos_url":"https://api.github.com/users/cms-bph-trigger/repos","events_url":"https://api.github.com/users/cms-bph-trigger/events{/privacy}","received_events_url":"https://api.github.com/users/cms-bph-trigger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-bph-trigger/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/cms-bph-trigger/cmssw","forks_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/forks","keys_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/events","assignees_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/merges","archive_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-bph-trigger/cmssw/deployments","created_at":"2017-03-21T22:29:57Z","updated_at":"2018-06-01T16:24:16Z","pushed_at":"2018-07-03T23:29:11Z","git_url":"git://github.com/cms-bph-trigger/cmssw.git","ssh_url":"git@github.com:cms-bph-trigger/cmssw.git","clone_url":"https://github.com/cms-bph-trigger/cmssw.git","svn_url":"https://github.com/cms-bph-trigger/cmssw","homepage":"http://cms-sw.github.io/","size":1003610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"4e5b4a28208f2f771708b54a9601e00dcf454d4d","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-07-12T20:46:24Z","pushed_at":"2018-07-12T20:54:08Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1021369,"stargazers_count":564,"watchers_count":564,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2626,"mirror_url":null,"archived":false,"open_issues_count":431,"license":null,"forks":2626,"open_issues":431,"watchers":564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23738"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23738"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23738/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23738/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/51d6fc6250054ac587f033da3a5e1a0477232e8f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"comments":30,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":964,"deletions":779,"changed_files":4}}
{"actor":{"display_login":"cmsbuild"}}