{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/171246358","pull_request_review_id":100063943,"id":171246358,"diff_hunk":"@@ -170,6 +170,10 @@\n                       },\n                     },\n                   },\n+                  {\n+                    name: \"AMBASSADOR_SINGLE_NAMESPACE\",","path":"kubeflow/core/ambassador.libsonnet","position":5,"original_position":5,"commit_id":"72d9ba477bd63353a933f6cadf66a8d9f99b1f6c","original_commit_id":"72d9ba477bd63353a933f6cadf66a8d9f99b1f6c","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"What's this do? Does this mean Ambassador only handles services in this namespace?\r\nIf that's so then we should probably delete the service we created to create a forwarding rule to the K8s dashboard.","created_at":"2018-02-28T13:38:49Z","updated_at":"2018-02-28T13:42:42Z","html_url":"https://github.com/kubeflow/kubeflow/pull/305#discussion_r171246358","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/171246358"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/305#discussion_r171246358"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305","id":171737198,"html_url":"https://github.com/kubeflow/kubeflow/pull/305","diff_url":"https://github.com/kubeflow/kubeflow/pull/305.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/305.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/305","number":305,"state":"open","locked":false,"title":"[WIP] Issue 239 ambassador as proxy for jupyterhub","user":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"body":"This is a fix for #239 and is still a WIP - but I thought I would make the PR available for review\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/305)\n<!-- Reviewable:end -->\n","created_at":"2018-02-27T17:49:52Z","updated_at":"2018-02-28T13:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e98dc4761671f6609bec8c0b4598043ce9ec4a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":850698616,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"ededed","default":false},{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/305/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/72d9ba477bd63353a933f6cadf66a8d9f99b1f6c","head":{"label":"kkasravi:issue_239_ambassador_as_proxy_for_jupyterhub","ref":"issue_239_ambassador_as_proxy_for_jupyterhub","sha":"72d9ba477bd63353a933f6cadf66a8d9f99b1f6c","user":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"repo":{"id":121746119,"name":"kubeflow","full_name":"kkasravi/kubeflow","owner":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkasravi/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/kkasravi/kubeflow","forks_url":"https://api.github.com/repos/kkasravi/kubeflow/forks","keys_url":"https://api.github.com/repos/kkasravi/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkasravi/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkasravi/kubeflow/teams","hooks_url":"https://api.github.com/repos/kkasravi/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kkasravi/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kkasravi/kubeflow/events","assignees_url":"https://api.github.com/repos/kkasravi/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kkasravi/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kkasravi/kubeflow/tags","blobs_url":"https://api.github.com/repos/kkasravi/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkasravi/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkasravi/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkasravi/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkasravi/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kkasravi/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kkasravi/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kkasravi/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kkasravi/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kkasravi/kubeflow/subscription","commits_url":"https://api.github.com/repos/kkasravi/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkasravi/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkasravi/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkasravi/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkasravi/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kkasravi/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkasravi/kubeflow/merges","archive_url":"https://api.github.com/repos/kkasravi/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkasravi/kubeflow/downloads","issues_url":"https://api.github.com/repos/kkasravi/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kkasravi/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kkasravi/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kkasravi/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkasravi/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kkasravi/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kkasravi/kubeflow/deployments","created_at":"2018-02-16T12:01:31Z","updated_at":"2018-02-16T12:01:33Z","pushed_at":"2018-02-27T17:31:48Z","git_url":"git://github.com/kkasravi/kubeflow.git","ssh_url":"git@github.com:kkasravi/kubeflow.git","clone_url":"https://github.com/kkasravi/kubeflow.git","svn_url":"https://github.com/kkasravi/kubeflow","homepage":"","size":99760,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"eeae9ea042ed3d92a6ee49dfc5d869ea41b08911","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-02-28T12:42:06Z","pushed_at":"2018-02-28T05:20:59Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":100014,"stargazers_count":2665,"watchers_count":2665,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":278,"open_issues":126,"watchers":2665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/305"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/305"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/72d9ba477bd63353a933f6cadf66a8d9f99b1f6c"}},"author_association":"NONE"}}
{"actor":{"display_login":"jlewi"}}