{"action":"created","comment":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/comments/193409033","pull_request_review_id":126373705,"id":193409033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQwOTAzMw==","diff_hunk":"@@ -78,8 +81,22 @@ class Btree\n \t\t\treturn true;\n \t\t}\n \t\treturn false;\n-\t}\n+\t};\n+ \tNode<T> * least_common_ancestor(Node<T> *root, T val1, T val2)\n+    {\n+\t\t// TODO: check if values are in the tree\n+\t    if ( root == nullptr ) return nullptr;\n+        if ( root->data == val1 || root->data == val2 ) return root;\n+\n+        Node<T> *left = least_common_ancestor(root->left, val1, val2);\n+        Node<T> *right = least_common_ancestor(root->right, val1, val2);\n+\n+        if( left == nullptr && right == nullptr) return nullptr;","path":"Lacrit/assignment2/binary_tree.hpp","position":94,"original_position":30,"commit_id":"8fad732c579ce94002d16d32634c9b4bc85e49ec","original_commit_id":"8fad732c579ce94002d16d32634c9b4bc85e49ec","user":{"login":"ssancho2","id":28534702,"node_id":"MDQ6VXNlcjI4NTM0NzAy","avatar_url":"https://avatars3.githubusercontent.com/u/28534702?v=4","gravatar_id":"","url":"https://api.github.com/users/ssancho2","html_url":"https://github.com/ssancho2","followers_url":"https://api.github.com/users/ssancho2/followers","following_url":"https://api.github.com/users/ssancho2/following{/other_user}","gists_url":"https://api.github.com/users/ssancho2/gists{/gist_id}","starred_url":"https://api.github.com/users/ssancho2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssancho2/subscriptions","organizations_url":"https://api.github.com/users/ssancho2/orgs","repos_url":"https://api.github.com/users/ssancho2/repos","events_url":"https://api.github.com/users/ssancho2/events{/privacy}","received_events_url":"https://api.github.com/users/ssancho2/received_events","type":"User","site_admin":false},"body":"It's more clear this way, but this line is actually not needed :)","created_at":"2018-06-06T13:29:00Z","updated_at":"2018-06-06T13:41:26Z","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15#discussion_r193409033","pull_request_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/comments/193409033"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15#discussion_r193409033"},"pull_request":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15","id":192856970,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODU2OTcw","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15","diff_url":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15.diff","patch_url":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15.patch","issue_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/15","number":15,"state":"open","locked":false,"title":"Lacrit 2","user":{"login":"Lacrit","id":22713820,"node_id":"MDQ6VXNlcjIyNzEzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/22713820?v=4","gravatar_id":"","url":"https://api.github.com/users/Lacrit","html_url":"https://github.com/Lacrit","followers_url":"https://api.github.com/users/Lacrit/followers","following_url":"https://api.github.com/users/Lacrit/following{/other_user}","gists_url":"https://api.github.com/users/Lacrit/gists{/gist_id}","starred_url":"https://api.github.com/users/Lacrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lacrit/subscriptions","organizations_url":"https://api.github.com/users/Lacrit/orgs","repos_url":"https://api.github.com/users/Lacrit/repos","events_url":"https://api.github.com/users/Lacrit/events{/privacy}","received_events_url":"https://api.github.com/users/Lacrit/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-05T22:47:39Z","updated_at":"2018-06-06T13:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7adc35fc51dd454f1ae73de2f3a4ef31bff6af8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15/commits","review_comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15/comments","review_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/15/comments","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/statuses/8fad732c579ce94002d16d32634c9b4bc85e49ec","head":{"label":"flerdacodeu:lacrit-2","ref":"lacrit-2","sha":"8fad732c579ce94002d16d32634c9b4bc85e49ec","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326673,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2NzM=","name":"CodeU-2018-Group9","full_name":"flerdacodeu/CodeU-2018-Group9","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group9","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/deployments","created_at":"2018-05-14T08:07:19Z","updated_at":"2018-06-05T09:53:49Z","pushed_at":"2018-06-06T13:17:23Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group9.git","ssh_url":"git@github.com:flerdacodeu/CodeU-2018-Group9.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group9.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group9","homepage":null,"size":81,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":1,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"flerdacodeu:master","ref":"master","sha":"d0e7f2190be79f9990575cdf32f88aa44019935a","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326673,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2NzM=","name":"CodeU-2018-Group9","full_name":"flerdacodeu/CodeU-2018-Group9","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group9","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/deployments","created_at":"2018-05-14T08:07:19Z","updated_at":"2018-06-05T09:53:49Z","pushed_at":"2018-06-06T13:17:23Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group9.git","ssh_url":"git@github.com:flerdacodeu/CodeU-2018-Group9.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group9.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group9","homepage":null,"size":81,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":1,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group9/pull/15"},"issue":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/15"},"comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group9/statuses/8fad732c579ce94002d16d32634c9b4bc85e49ec"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ssancho2"}}