{"action":"closed","number":1919,"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/1919","id":178472987,"html_url":"https://github.com/google/cadvisor/pull/1919","diff_url":"https://github.com/google/cadvisor/pull/1919.diff","patch_url":"https://github.com/google/cadvisor/pull/1919.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1919","number":1919,"state":"closed","locked":false,"title":"Fix containerd connection wait.","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Avoid cadvisor 2 seconds start up latency.\r\n\r\n/cc @abhi @miaoyq \r\n\r\nWithout this PR cadvisor will always wait for 2 seconds to confirm containerd is not there. It means that kubelet will also finish initialization 2 seconds slower. This is a regression in Kubernetes 1.9 and 1.10. We may want to cut a cherry-pick.\r\n\r\n@mtaufen Do we still care about kubelet start up latency now?\r\n\r\nSigned-off-by: Lantao Liu <lantaol@google.com>","created_at":"2018-03-30T00:42:32Z","updated_at":"2018-03-30T00:55:10Z","closed_at":"2018-03-30T00:55:10Z","merged_at":"2018-03-30T00:55:10Z","merge_commit_sha":"4edfcdda8ed5698e55b4a3b59b66daaa350c82b5","assignee":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars1.githubusercontent.com/u/3262098?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"assignees":[{"login":"dashpole","id":3262098,"avatar_url":"https://avatars1.githubusercontent.com/u/3262098?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/1919/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/1919/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1919/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/021065e3b9403116fc0a193bccc19725de8ed281","head":{"label":"Random-Liu:fix-containerd-wait","ref":"fix-containerd-wait","sha":"021065e3b9403116fc0a193bccc19725de8ed281","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"repo":{"id":56040112,"name":"cadvisor","full_name":"Random-Liu/cadvisor","owner":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Random-Liu/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/Random-Liu/cadvisor","forks_url":"https://api.github.com/repos/Random-Liu/cadvisor/forks","keys_url":"https://api.github.com/repos/Random-Liu/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Random-Liu/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Random-Liu/cadvisor/teams","hooks_url":"https://api.github.com/repos/Random-Liu/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/Random-Liu/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/Random-Liu/cadvisor/events","assignees_url":"https://api.github.com/repos/Random-Liu/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/Random-Liu/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/Random-Liu/cadvisor/tags","blobs_url":"https://api.github.com/repos/Random-Liu/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Random-Liu/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Random-Liu/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Random-Liu/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Random-Liu/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/Random-Liu/cadvisor/languages","stargazers_url":"https://api.github.com/repos/Random-Liu/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/Random-Liu/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/Random-Liu/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/Random-Liu/cadvisor/subscription","commits_url":"https://api.github.com/repos/Random-Liu/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Random-Liu/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Random-Liu/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Random-Liu/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Random-Liu/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/Random-Liu/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Random-Liu/cadvisor/merges","archive_url":"https://api.github.com/repos/Random-Liu/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Random-Liu/cadvisor/downloads","issues_url":"https://api.github.com/repos/Random-Liu/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/Random-Liu/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/Random-Liu/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/Random-Liu/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Random-Liu/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/Random-Liu/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/Random-Liu/cadvisor/deployments","created_at":"2016-04-12T07:16:17Z","updated_at":"2016-04-12T07:16:19Z","pushed_at":"2018-03-30T00:48:25Z","git_url":"git://github.com/Random-Liu/cadvisor.git","ssh_url":"git@github.com:Random-Liu/cadvisor.git","clone_url":"https://github.com/Random-Liu/cadvisor.git","svn_url":"https://github.com/Random-Liu/cadvisor","homepage":"","size":28975,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"834edaddc4680ba00ad8a9da40fb638b0c277280","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/google/cadvisor/deployments","created_at":"2014-06-09T16:36:33Z","updated_at":"2018-03-30T00:44:34Z","pushed_at":"2018-03-30T00:55:10Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":29043,"stargazers_count":7174,"watchers_count":7174,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1044,"mirror_url":null,"archived":false,"open_issues_count":260,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1044,"open_issues":260,"watchers":7174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1919"},"html":{"href":"https://github.com/google/cadvisor/pull/1919"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/1919"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/1919/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1919/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1919/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/021065e3b9403116fc0a193bccc19725de8ed281"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars1.githubusercontent.com/u/3262098?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"dashpole"}}