{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments/235571358","pull_request_review_id":177467932,"id":235571358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU3MTM1OA==","diff_hunk":"@@ -559,6 +559,7 @@ static const struct option global_opts[] = {\n \t{ \"time\", no_argument, 0, 't' },\n \t{ \"url\", required_argument, 0, 'u' },\n \t{ \"versionurl\", required_argument, 0, 'v' },\n+\t{ \"max-parallel-downloads\", required_argument, 0, 'D' },","path":"src/globals.c","position":92,"original_position":13,"commit_id":"a065a5669bf063167913340a72947ae802404f33","original_commit_id":"2bf30c550f3f912780b4aac4a444a52b6e07d3f5","user":{"login":"castulo","id":2782179,"node_id":"MDQ6VXNlcjI3ODIxNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2782179?v=4","gravatar_id":"","url":"https://api.github.com/users/castulo","html_url":"https://github.com/castulo","followers_url":"https://api.github.com/users/castulo/followers","following_url":"https://api.github.com/users/castulo/following{/other_user}","gists_url":"https://api.github.com/users/castulo/gists{/gist_id}","starred_url":"https://api.github.com/users/castulo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castulo/subscriptions","organizations_url":"https://api.github.com/users/castulo/orgs","repos_url":"https://api.github.com/users/castulo/repos","events_url":"https://api.github.com/users/castulo/events{/privacy}","received_events_url":"https://api.github.com/users/castulo/received_events","type":"User","site_admin":false},"body":"Maybe add a TODO here with the comment that D was deprecated and we should remove this option from the base code in X months","created_at":"2018-11-22T00:11:40Z","updated_at":"2018-11-22T00:11:40Z","html_url":"https://github.com/clearlinux/swupd-client/pull/714#discussion_r235571358","pull_request_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments/235571358"},"html":{"href":"https://github.com/clearlinux/swupd-client/pull/714#discussion_r235571358"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714"}}},"pull_request":{"url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714","id":232484840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDg0ODQw","html_url":"https://github.com/clearlinux/swupd-client/pull/714","diff_url":"https://github.com/clearlinux/swupd-client/pull/714.diff","patch_url":"https://github.com/clearlinux/swupd-client/pull/714.patch","issue_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/714","number":714,"state":"open","locked":false,"title":"Global","user":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"body":"There is a list of parameters in swupd that are really configuration changes that applies to almost every command (and they should apply to any command that uses any feature that this setting is configuring).\r\n\r\nBut those parameters were being set specifically for each swupd command, making it a hard task to keep documentation updated and make sure that all parameters are really added to all commands that may benefit from using them.\r\n\r\nWhen I was reviewing parameters sanitization I decided to take some time to close #571 to make our lives easier.\r\n\r\nSo this pull request consolidate parameters in global.c and fixes some sanitization problems I found.\r\n\r\nNote that we have a problem related to weird path names (#640) but this isn't a sanitization problem because that path is valid. \r\n\r\nFixes #573\r\nFixes: #571\r\n","created_at":"2018-11-20T22:51:27Z","updated_at":"2018-11-22T00:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e0440ee9e32ec0d269fa0181509ac3a57edea6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714/commits","review_comments_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714/comments","review_comment_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/714/comments","statuses_url":"https://api.github.com/repos/clearlinux/swupd-client/statuses/a065a5669bf063167913340a72947ae802404f33","head":{"label":"otaviobp:global","ref":"global","sha":"a065a5669bf063167913340a72947ae802404f33","user":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"repo":{"id":135618429,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTg0Mjk=","name":"swupd-client","full_name":"otaviobp/swupd-client","private":false,"owner":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/otaviobp/swupd-client","description":"Software update client","fork":true,"url":"https://api.github.com/repos/otaviobp/swupd-client","forks_url":"https://api.github.com/repos/otaviobp/swupd-client/forks","keys_url":"https://api.github.com/repos/otaviobp/swupd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otaviobp/swupd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otaviobp/swupd-client/teams","hooks_url":"https://api.github.com/repos/otaviobp/swupd-client/hooks","issue_events_url":"https://api.github.com/repos/otaviobp/swupd-client/issues/events{/number}","events_url":"https://api.github.com/repos/otaviobp/swupd-client/events","assignees_url":"https://api.github.com/repos/otaviobp/swupd-client/assignees{/user}","branches_url":"https://api.github.com/repos/otaviobp/swupd-client/branches{/branch}","tags_url":"https://api.github.com/repos/otaviobp/swupd-client/tags","blobs_url":"https://api.github.com/repos/otaviobp/swupd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otaviobp/swupd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otaviobp/swupd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/otaviobp/swupd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otaviobp/swupd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/otaviobp/swupd-client/languages","stargazers_url":"https://api.github.com/repos/otaviobp/swupd-client/stargazers","contributors_url":"https://api.github.com/repos/otaviobp/swupd-client/contributors","subscribers_url":"https://api.github.com/repos/otaviobp/swupd-client/subscribers","subscription_url":"https://api.github.com/repos/otaviobp/swupd-client/subscription","commits_url":"https://api.github.com/repos/otaviobp/swupd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/otaviobp/swupd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/otaviobp/swupd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/otaviobp/swupd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/otaviobp/swupd-client/contents/{+path}","compare_url":"https://api.github.com/repos/otaviobp/swupd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otaviobp/swupd-client/merges","archive_url":"https://api.github.com/repos/otaviobp/swupd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otaviobp/swupd-client/downloads","issues_url":"https://api.github.com/repos/otaviobp/swupd-client/issues{/number}","pulls_url":"https://api.github.com/repos/otaviobp/swupd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/otaviobp/swupd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/otaviobp/swupd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otaviobp/swupd-client/labels{/name}","releases_url":"https://api.github.com/repos/otaviobp/swupd-client/releases{/id}","deployments_url":"https://api.github.com/repos/otaviobp/swupd-client/deployments","created_at":"2018-05-31T18:00:12Z","updated_at":"2018-11-02T20:30:37Z","pushed_at":"2018-11-21T00:16:29Z","git_url":"git://github.com/otaviobp/swupd-client.git","ssh_url":"git@github.com:otaviobp/swupd-client.git","clone_url":"https://github.com/otaviobp/swupd-client.git","svn_url":"https://github.com/otaviobp/swupd-client","homepage":null,"size":2621,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"46ea5954fb4916c58e3ace49b81b16991af13e6f","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":52470178,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ3MDE3OA==","name":"swupd-client","full_name":"clearlinux/swupd-client","private":false,"owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clearlinux/swupd-client","description":"Software update client","fork":false,"url":"https://api.github.com/repos/clearlinux/swupd-client","forks_url":"https://api.github.com/repos/clearlinux/swupd-client/forks","keys_url":"https://api.github.com/repos/clearlinux/swupd-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/swupd-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/swupd-client/teams","hooks_url":"https://api.github.com/repos/clearlinux/swupd-client/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/swupd-client/events","assignees_url":"https://api.github.com/repos/clearlinux/swupd-client/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/swupd-client/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/swupd-client/tags","blobs_url":"https://api.github.com/repos/clearlinux/swupd-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/swupd-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/swupd-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/swupd-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/swupd-client/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/swupd-client/languages","stargazers_url":"https://api.github.com/repos/clearlinux/swupd-client/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/swupd-client/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/swupd-client/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/swupd-client/subscription","commits_url":"https://api.github.com/repos/clearlinux/swupd-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/swupd-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/swupd-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/swupd-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/swupd-client/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/swupd-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/swupd-client/merges","archive_url":"https://api.github.com/repos/clearlinux/swupd-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/swupd-client/downloads","issues_url":"https://api.github.com/repos/clearlinux/swupd-client/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/swupd-client/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/swupd-client/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/swupd-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/swupd-client/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/swupd-client/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/swupd-client/deployments","created_at":"2016-02-24T19:54:13Z","updated_at":"2018-11-20T20:31:18Z","pushed_at":"2018-11-21T20:15:39Z","git_url":"git://github.com/clearlinux/swupd-client.git","ssh_url":"git@github.com:clearlinux/swupd-client.git","clone_url":"https://github.com/clearlinux/swupd-client.git","svn_url":"https://github.com/clearlinux/swupd-client","homepage":null,"size":2587,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":45,"open_issues":84,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714"},"html":{"href":"https://github.com/clearlinux/swupd-client/pull/714"},"issue":{"href":"https://api.github.com/repos/clearlinux/swupd-client/issues/714"},"comments":{"href":"https://api.github.com/repos/clearlinux/swupd-client/issues/714/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/swupd-client/pulls/714/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/swupd-client/statuses/a065a5669bf063167913340a72947ae802404f33"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"castulo"}}