{"action":"created","issue":{"url":"https://api.github.com/repos/fulcrologic/fulcro/issues/240","repository_url":"https://api.github.com/repos/fulcrologic/fulcro","labels_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/240/comments","events_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/240/events","html_url":"https://github.com/fulcrologic/fulcro/issues/240","id":357318517,"node_id":"MDU6SXNzdWUzNTczMTg1MTc=","number":240,"title":"Optimized re-render","user":{"login":"thheller","id":144930,"node_id":"MDQ6VXNlcjE0NDkzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/144930?v=4","gravatar_id":"","url":"https://api.github.com/users/thheller","html_url":"https://github.com/thheller","followers_url":"https://api.github.com/users/thheller/followers","following_url":"https://api.github.com/users/thheller/following{/other_user}","gists_url":"https://api.github.com/users/thheller/gists{/gist_id}","starred_url":"https://api.github.com/users/thheller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thheller/subscriptions","organizations_url":"https://api.github.com/users/thheller/orgs","repos_url":"https://api.github.com/users/thheller/repos","events_url":"https://api.github.com/users/thheller/events{/privacy}","received_events_url":"https://api.github.com/users/thheller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-09-05T16:57:24Z","updated_at":"2018-09-06T17:12:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"`fulcro` as of `2.6.0` will always re-render from the root. After thinking about this for a while I must say that this is sort of a deal breaker for me.\r\n\r\nI would be fine with specifying which idents to re-render in the transaction itself or any other kind of manual optimization that could be done. Yes, I'm optimizing prematurely and I'm not running into performance issues yet but I'm not fine with doing this much unnecessary work for each render (even though that is already optimized pretty well).\r\n\r\nI can absolutely understand if this is a non-goal since it won't be an issue for most apps.\r\n\r\nAs I understand it this used to be possible though? What was the rationale for removing it?"},"comment":{"url":"https://api.github.com/repos/fulcrologic/fulcro/issues/comments/419171810","html_url":"https://github.com/fulcrologic/fulcro/issues/240#issuecomment-419171810","issue_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/240","id":419171810,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTE3MTgxMA==","user":{"login":"thheller","id":144930,"node_id":"MDQ6VXNlcjE0NDkzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/144930?v=4","gravatar_id":"","url":"https://api.github.com/users/thheller","html_url":"https://github.com/thheller","followers_url":"https://api.github.com/users/thheller/followers","following_url":"https://api.github.com/users/thheller/following{/other_user}","gists_url":"https://api.github.com/users/thheller/gists{/gist_id}","starred_url":"https://api.github.com/users/thheller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thheller/subscriptions","organizations_url":"https://api.github.com/users/thheller/orgs","repos_url":"https://api.github.com/users/thheller/repos","events_url":"https://api.github.com/users/thheller/events{/privacy}","received_events_url":"https://api.github.com/users/thheller/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T17:12:36Z","updated_at":"2018-09-06T17:12:36Z","author_association":"CONTRIBUTOR","body":"So I just took the [workspaces/example](https://github.com/nubank/workspaces/tree/master/examples/workspaces-shadow-example) (updated to 2.6) and turned on \"6x throttle\". A click on the left nav expand/collapse arrow takes 213ms. There is a suspicious slow `force-children` call in there but regardless this is not ok (in my book).\r\n\r\n![workspaces-nav-toggle](https://user-images.githubusercontent.com/144930/45173300-11a04a00-b208-11e8-8594-fe4d59d65dba.png)\r\n\r\nI have no clue why it is taking this long but I don't have access to many other fulcro apps I can profile.\r\n\r\nCan you please point to me wherever React says that you are supposed to re-render from root? I can't find that anywhere and not a single public React app I can find does that.\r\n"}}
{"actor":{"display_login":"thheller"}}