{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/20","repository_url":"https://api.github.com/repos/PowerShell/xSmbShare","labels_url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/20/comments","events_url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/20/events","html_url":"https://github.com/PowerShell/xSmbShare/pull/20","id":290054741,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0MDI4Njk2","number":20,"title":"Enhancing module","user":{"login":"twerthi","id":5552453,"node_id":"MDQ6VXNlcjU1NTI0NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5552453?v=4","gravatar_id":"","url":"https://api.github.com/users/twerthi","html_url":"https://github.com/twerthi","followers_url":"https://api.github.com/users/twerthi/followers","following_url":"https://api.github.com/users/twerthi/following{/other_user}","gists_url":"https://api.github.com/users/twerthi/gists{/gist_id}","starred_url":"https://api.github.com/users/twerthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twerthi/subscriptions","organizations_url":"https://api.github.com/users/twerthi/orgs","repos_url":"https://api.github.com/users/twerthi/repos","events_url":"https://api.github.com/users/twerthi/events{/privacy}","received_events_url":"https://api.github.com/users/twerthi/received_events","type":"User","site_admin":false},"labels":[{"id":214986396,"node_id":"MDU6TGFiZWwyMTQ5ODYzOTY=","url":"https://api.github.com/repos/PowerShell/xSmbShare/labels/waiting%20for%20author%20response","name":"waiting for author response","color":"ffff99","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-01-19T17:43:20Z","updated_at":"2018-06-20T06:28:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/PowerShell/xSmbShare/pulls/20","html_url":"https://github.com/PowerShell/xSmbShare/pull/20","diff_url":"https://github.com/PowerShell/xSmbShare/pull/20.diff","patch_url":"https://github.com/PowerShell/xSmbShare/pull/20.patch"},"body":"Added the ability to have all Access variables present, but allow for null or empty.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xsmbshare/20)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/comments/398638644","html_url":"https://github.com/PowerShell/xSmbShare/pull/20#issuecomment-398638644","issue_url":"https://api.github.com/repos/PowerShell/xSmbShare/issues/20","id":398638644,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODYzODY0NA==","user":{"login":"johlju","id":7189721,"node_id":"MDQ6VXNlcjcxODk3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7189721?v=4","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T06:28:28Z","updated_at":"2018-06-20T06:28:28Z","author_association":"CONTRIBUTOR","body":"Ah, I see what you are trying to do. I don't think this is the right approach. If a property should not be checked to be in a consistent state it should not be part of the configuration. This way if `ChangedAccess` on the target node would be anything other than an empty value the configuration would never become in a desired state. \r\nThe configuration should be built so that only the properties that should be in desired state is present. "}}
{"actor":{"display_login":"johlju"}}