{"action":"closed","number":28097,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097","id":205143806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTQzODA2","html_url":"https://github.com/cockroachdb/cockroach/pull/28097","diff_url":"https://github.com/cockroachdb/cockroach/pull/28097.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28097.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28097","number":28097,"state":"closed","locked":false,"title":"distsql: fix NULL handling in INTERSECT and EXCEPT","user":{"login":"solongordon","id":679246,"node_id":"MDQ6VXNlcjY3OTI0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/679246?v=4","gravatar_id":"","url":"https://api.github.com/users/solongordon","html_url":"https://github.com/solongordon","followers_url":"https://api.github.com/users/solongordon/followers","following_url":"https://api.github.com/users/solongordon/following{/other_user}","gists_url":"https://api.github.com/users/solongordon/gists{/gist_id}","starred_url":"https://api.github.com/users/solongordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solongordon/subscriptions","organizations_url":"https://api.github.com/users/solongordon/orgs","repos_url":"https://api.github.com/users/solongordon/repos","events_url":"https://api.github.com/users/solongordon/events{/privacy}","received_events_url":"https://api.github.com/users/solongordon/received_events","type":"User","site_admin":false},"body":"Rows with NULLs were not being handled properly in the distsql\r\nimplementation of INTERSECT (ALL) and EXCEPT (ALL). They were being\r\nincorrectly omitted from INTERSECT results and incorrectly included in\r\nEXCEPT results. This was due to those operations being implemented by\r\nthe joiners, which treat NULLs as unequal. I added a special null\r\nequality case for these set operations.\r\n\r\nFixes #27969\r\n\r\nRelease note (bug fix): Fixed incorrect NULL handling in the distributed\r\nimplementations of INTERSECT and EXCEPT.","created_at":"2018-07-31T15:01:30Z","updated_at":"2018-07-31T17:27:47Z","closed_at":"2018-07-31T17:27:47Z","merged_at":"2018-07-31T17:27:47Z","merge_commit_sha":"4b2cf49373fd031b7984696d91ac28c599d02a57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"sql-rest-prs","id":2437982,"node_id":"MDQ6VGVhbTI0Mzc5ODI=","slug":"sql-rest-prs","description":"Join this team for notifications about SQL PRs that do not fall in other buckets","privacy":"closed","url":"https://api.github.com/teams/2437982","members_url":"https://api.github.com/teams/2437982/members{/member}","repositories_url":"https://api.github.com/teams/2437982/repos","permission":"pull"},{"name":"sql-execution-prs","id":2437984,"node_id":"MDQ6VGVhbTI0Mzc5ODQ=","slug":"sql-execution-prs","description":"Join this team for notifications about SQL execution PRs","privacy":"closed","url":"https://api.github.com/teams/2437984","members_url":"https://api.github.com/teams/2437984/members{/member}","repositories_url":"https://api.github.com/teams/2437984/repos","permission":"pull"},{"name":"sql-planning-prs","id":2437986,"node_id":"MDQ6VGVhbTI0Mzc5ODY=","slug":"sql-planning-prs","description":"Join this team for notifications about SQL planning PRs","privacy":"closed","url":"https://api.github.com/teams/2437986","members_url":"https://api.github.com/teams/2437986/members{/member}","repositories_url":"https://api.github.com/teams/2437986/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28097/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4b2cf49373fd031b7984696d91ac28c599d02a57","head":{"label":"solongordon:fix-set-op-nulls","ref":"fix-set-op-nulls","sha":"4b2cf49373fd031b7984696d91ac28c599d02a57","user":{"login":"solongordon","id":679246,"node_id":"MDQ6VXNlcjY3OTI0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/679246?v=4","gravatar_id":"","url":"https://api.github.com/users/solongordon","html_url":"https://github.com/solongordon","followers_url":"https://api.github.com/users/solongordon/followers","following_url":"https://api.github.com/users/solongordon/following{/other_user}","gists_url":"https://api.github.com/users/solongordon/gists{/gist_id}","starred_url":"https://api.github.com/users/solongordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solongordon/subscriptions","organizations_url":"https://api.github.com/users/solongordon/orgs","repos_url":"https://api.github.com/users/solongordon/repos","events_url":"https://api.github.com/users/solongordon/events{/privacy}","received_events_url":"https://api.github.com/users/solongordon/received_events","type":"User","site_admin":false},"repo":{"id":110016998,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMTY5OTg=","name":"cockroach","full_name":"solongordon/cockroach","owner":{"login":"solongordon","id":679246,"node_id":"MDQ6VXNlcjY3OTI0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/679246?v=4","gravatar_id":"","url":"https://api.github.com/users/solongordon","html_url":"https://github.com/solongordon","followers_url":"https://api.github.com/users/solongordon/followers","following_url":"https://api.github.com/users/solongordon/following{/other_user}","gists_url":"https://api.github.com/users/solongordon/gists{/gist_id}","starred_url":"https://api.github.com/users/solongordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solongordon/subscriptions","organizations_url":"https://api.github.com/users/solongordon/orgs","repos_url":"https://api.github.com/users/solongordon/repos","events_url":"https://api.github.com/users/solongordon/events{/privacy}","received_events_url":"https://api.github.com/users/solongordon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solongordon/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/solongordon/cockroach","forks_url":"https://api.github.com/repos/solongordon/cockroach/forks","keys_url":"https://api.github.com/repos/solongordon/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solongordon/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solongordon/cockroach/teams","hooks_url":"https://api.github.com/repos/solongordon/cockroach/hooks","issue_events_url":"https://api.github.com/repos/solongordon/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/solongordon/cockroach/events","assignees_url":"https://api.github.com/repos/solongordon/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/solongordon/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/solongordon/cockroach/tags","blobs_url":"https://api.github.com/repos/solongordon/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solongordon/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solongordon/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/solongordon/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solongordon/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/solongordon/cockroach/languages","stargazers_url":"https://api.github.com/repos/solongordon/cockroach/stargazers","contributors_url":"https://api.github.com/repos/solongordon/cockroach/contributors","subscribers_url":"https://api.github.com/repos/solongordon/cockroach/subscribers","subscription_url":"https://api.github.com/repos/solongordon/cockroach/subscription","commits_url":"https://api.github.com/repos/solongordon/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/solongordon/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/solongordon/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/solongordon/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/solongordon/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/solongordon/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solongordon/cockroach/merges","archive_url":"https://api.github.com/repos/solongordon/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solongordon/cockroach/downloads","issues_url":"https://api.github.com/repos/solongordon/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/solongordon/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/solongordon/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/solongordon/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solongordon/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/solongordon/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/solongordon/cockroach/deployments","created_at":"2017-11-08T18:52:29Z","updated_at":"2018-03-15T16:38:16Z","pushed_at":"2018-07-31T15:28:11Z","git_url":"git://github.com/solongordon/cockroach.git","ssh_url":"git@github.com:solongordon/cockroach.git","clone_url":"https://github.com/solongordon/cockroach.git","svn_url":"https://github.com/solongordon/cockroach","homepage":"https://www.cockroachlabs.com","size":549442,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"5b8780e7b3eef3a561bc7bc1cc7e23d154138c5f","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-07-31T16:27:03Z","pushed_at":"2018-07-31T17:27:15Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1029132,"stargazers_count":13918,"watchers_count":13918,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1455,"mirror_url":null,"archived":false,"open_issues_count":1840,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1455,"open_issues":1840,"watchers":13918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/28097"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28097"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28097/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28097/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/4b2cf49373fd031b7984696d91ac28c599d02a57"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":92,"deletions":14,"changed_files":5}}
{"actor":{"display_login":"craig"}}