{"action":"closed","issue":{"url":"https://api.github.com/repos/xmartlabs/Eureka/issues/1186","repository_url":"https://api.github.com/repos/xmartlabs/Eureka","labels_url":"https://api.github.com/repos/xmartlabs/Eureka/issues/1186/labels{/name}","comments_url":"https://api.github.com/repos/xmartlabs/Eureka/issues/1186/comments","events_url":"https://api.github.com/repos/xmartlabs/Eureka/issues/1186/events","html_url":"https://github.com/xmartlabs/Eureka/issues/1186","id":248321297,"number":1186,"title":"Custom GenericMultipleSelectorRow details view controller","user":{"login":"AlexZd","id":5249914,"avatar_url":"https://avatars1.githubusercontent.com/u/5249914?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexZd","html_url":"https://github.com/AlexZd","followers_url":"https://api.github.com/users/AlexZd/followers","following_url":"https://api.github.com/users/AlexZd/following{/other_user}","gists_url":"https://api.github.com/users/AlexZd/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexZd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexZd/subscriptions","organizations_url":"https://api.github.com/users/AlexZd/orgs","repos_url":"https://api.github.com/users/AlexZd/repos","events_url":"https://api.github.com/users/AlexZd/events{/privacy}","received_events_url":"https://api.github.com/users/AlexZd/received_events","type":"User","site_admin":false},"labels":[{"id":936579237,"url":"https://api.github.com/repos/xmartlabs/Eureka/labels/row:%20PresenterRowType","name":"row: PresenterRowType","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-07T06:47:07Z","updated_at":"2018-05-17T19:26:32Z","closed_at":"2018-05-17T19:26:32Z","author_association":"NONE","body":"Hi, trying to implement custom details view controller, but in latest version `generic` was replaced to `typealias` which I can't override.\r\n\r\nIn `GenericMultipleSelectorRow` class there is\r\n```swift\r\npublic typealias PresentedController = MultipleSelectorViewController<GenericMultipleSelectorRow<T,Cell>>\r\n```\r\nand I can't override it from child, and always getting default `MultipleSelectorViewController`. In previous versions I was passing `VCType` which should be pushed and it was working fine.\r\n\r\nAlso, I tried to override block:\r\n```swift\r\npresentationMode = .show(controllerProvider: ControllerProvider.callback {\r\n                return MultipleSelectorViewController<GenericMultipleSelectorRow<T,Cell>>()\r\n        }, onDismiss: { vc in\r\n            let _ = vc.navigationController?.popViewController(animated: true)\r\n        })\r\n```\r\nwhich I also can't do, because of \r\n```swift\r\n/// Defines how the view controller will be presented, pushed, etc.\r\n    open var presentationMode: PresentationMode<PresentedController>?\r\n```\r\nand it has different type\r\n\r\nso at the end, my row is like:\r\n```swift\r\nclass _SCMultipleSelectorRow<T: Hashable, Cell: CellType>: GenericMultipleSelectorRow<T, Cell> where Cell: BaseCell, Cell: TypedCellType, Cell.Value == Set<T> {\r\n    typealias PresentedController = SCMultipleSelectorViewController<GenericMultipleSelectorRow<T,Cell>>\r\n    \r\n    public required init(tag: String?) {\r\n        super.init(tag: tag)\r\n    }\r\n}\r\n```\r\nand it does not override push view controller.\r\n\r\nI'm able to do duplicate `GenericMultipleSelectorRow` for my own project with my details VC and get it work, but I guess this wasn't idea.\r\n\r\nThank you "}}
{"actor":{"display_login":"mtnbarreto"}}