{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/6986","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/6986/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/6986/comments","events_url":"https://api.github.com/repos/minio/minio/issues/6986/events","html_url":"https://github.com/minio/minio/pull/6986","id":391591139,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDUyMDI0","number":6986,"title":"Turn off printing IPv6 endpoints when listening on all interfaces","user":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-17T07:41:21Z","updated_at":"2018-12-17T08:14:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6986","html_url":"https://github.com/minio/minio/pull/6986","diff_url":"https://github.com/minio/minio/pull/6986.diff","patch_url":"https://github.com/minio/minio/pull/6986.patch"},"body":"\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nTurn off printing IPv6 endpoints when listening on all interfaces\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nBy default when we listen on all interfaces, we print all the\r\nendpoints that at local to all interfaces including IPv6\r\naddresses. Remove IPv6 addresses in endpoint list to be\r\nprinted in endpoints unless explicitly specified with '--address'\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## Regression\r\nNo\r\n<!-- Is this PR fixing a regression? (Yes / No) -->\r\n<!-- If Yes, optionally please include minio version or commit id or PR# that caused this regression, if you have these details. -->\r\n\r\n## How Has This Been Tested?\r\nJust build and run `minio server ~/test` locally, if you have IPv6 enabled with many interfaces. Minio should print a lot of different endpoints. This PR simply turns it off. \r\n\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/447757530","html_url":"https://github.com/minio/minio/pull/6986#issuecomment-447757530","issue_url":"https://api.github.com/repos/minio/minio/issues/6986","id":447757530,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzc1NzUzMA==","user":{"login":"minio-ops","id":9169493,"node_id":"MDQ6VXNlcjkxNjk0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9169493?v=4","gravatar_id":"","url":"https://api.github.com/users/minio-ops","html_url":"https://github.com/minio-ops","followers_url":"https://api.github.com/users/minio-ops/followers","following_url":"https://api.github.com/users/minio-ops/following{/other_user}","gists_url":"https://api.github.com/users/minio-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/minio-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio-ops/subscriptions","organizations_url":"https://api.github.com/users/minio-ops/orgs","repos_url":"https://api.github.com/users/minio-ops/repos","events_url":"https://api.github.com/users/minio-ops/events{/privacy}","received_events_url":"https://api.github.com/users/minio-ops/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T08:14:38Z","updated_at":"2018-12-17T08:14:38Z","author_association":"NONE","body":"## Mint Automation\n| Test | Result |\n|:--- |:--- |\n| mint-tls.sh | :heavy_check_mark: |\n| mint-compression-xl.sh | :heavy_check_mark: |\n| mint-xl.sh | :heavy_check_mark: |\n| mint-large-bucket.sh | :heavy_check_mark: |\n| mint-worm.sh | :heavy_check_mark: |\n| mint-fs.sh | :heavy_check_mark: |\n| mint-dist-xl.sh | :heavy_check_mark: |\n| mint-compression-fs.sh | :x: [more...](#b193bda0-5096-431d-99e6-d22b542afa62) |\n<a name=\"b193bda0-5096-431d-99e6-d22b542afa62\"></a>\n### 6986-6939650/mint-compression-fs.sh.log:\n```\nRunning with\nSERVER_ENDPOINT:      minikube:30847\nACCESS_KEY:           minio\nSECRET_KEY:           ***REDACTED***\nENABLE_HTTPS:         0\nSERVER_REGION:        us-east-1\nMINT_DATA_DIR:        /mint/data\nMINT_MODE:            full\nENABLE_VIRTUAL_STYLE: 0\n\nTo get logs, run 'docker cp 28e45cd272a1:/mint/log /tmp/mint-logs'\n\n(1/13) Running awscli tests ... done in 2 minutes and 9 seconds\n(2/13) Running aws-sdk-go tests ... done in 0 seconds\n(3/13) Running aws-sdk-java tests ... done in 2 seconds\n(4/13) Running aws-sdk-php tests ... done in 41 seconds\n(5/13) Running aws-sdk-ruby tests ... done in 2 seconds\n(6/13) Running mc tests ... done in 30 seconds\n(7/13) Running minio-dotnet tests ... FAILED in 2 minutes and 34 seconds\n\nUnhandled Exception: System.AggregateException: One or more errors occurred. (Assert.Fail failed. ) ---> Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. \n   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.HandleFail(String assertionName, String message, Object[] parameters)\n   at Minio.Functional.Tests.FunctionalTest.<>c.<ListIncompleteUpload_Test2>b__85_1(Exception ex) in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 2138\n   at System.Reactive.AutoDetachObserver`1.OnErrorCore(Exception exception) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Internal\\AutoDetachObserver.cs:line 76\n   at System.Reactive.AnonymousSafeObserver`1.OnError(Exception error) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\AnonymousSafeObserver.cs:line 62\n   at System.Reactive.Linq.ObservableImpl.Throw`1._.Invoke() in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Linq\\Observable\\Throw.cs:line 42\n   at System.Reactive.Concurrency.Scheduler.Invoke(IScheduler scheduler, Action action) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Concurrency\\Scheduler.Simple.cs:line 83\n   at System.Reactive.Producer`2.SubscribeRaw(IObserver`1 observer, Boolean enableSafeguard) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Internal\\Producer.cs:line 127\n   at System.Reactive.Linq.QueryLanguage.<>c__DisplayClass330_0`1.<Create>b__0(IObserver`1 observer) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Linq\\QueryLanguage.Creation.cs:line 46\n   at System.Reactive.AnonymousObservable`1.SubscribeCore(IObserver`1 observer) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\AnonymousObservable.cs:line 37\n   at System.Reactive.ObservableBase`1.ScheduledSubscribe(IScheduler _, AutoDetachObserver`1 autoDetachObserver) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\ObservableBase.cs:line 82\n   at System.Reactive.Concurrency.CurrentThreadScheduler.Trampoline.Run(SchedulerQueue`1 queue) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Concurrency\\CurrentThreadScheduler.cs:line 126\n   at System.Reactive.Concurrency.CurrentThreadScheduler.Schedule[TState](TState state, TimeSpan dueTime, Func`3 action) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\Concurrency\\CurrentThreadScheduler.cs:line 94\n   at System.Reactive.ObservableBase`1.Subscribe(IObserver`1 observer) in D:\\a\\1\\s\\Rx.NET\\Source\\src\\System.Reactive\\ObservableBase.cs:line 51\n   at Minio.Functional.Tests.FunctionalTest.ListIncompleteUpload_Test2(MinioClient minio) in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 2136\n   --- End of inner exception stack trace ---\n   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)\n   at System.Threading.Tasks.Task.Wait()\n   at Minio.Functional.Tests.FunctionalTest.Main(String[] args) in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 241\n\nExecuted 6 out of 13 tests successfully.\n```\n"}}
{"actor":{"display_login":"minio-ops"}}