{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/25495","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25495/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25495/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25495/events","html_url":"https://github.com/cms-sw/cmssw/pull/25495","id":390736355,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDM1MDEx","number":25495,"title":"PPS proton reconstruction","user":{"login":"jan-kaspar","id":17830858,"node_id":"MDQ6VXNlcjE3ODMwODU4","avatar_url":"https://avatars0.githubusercontent.com/u/17830858?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"node_id":"MDU6TGFiZWw1Mjg4MTQ2Mw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52881671,"node_id":"MDU6TGFiZWw1Mjg4MTY3MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04","default":false},{"id":52881696,"node_id":"MDU6TGFiZWw1Mjg4MTY5Ng==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/generators-pending","name":"generators-pending","color":"fbca04","default":false},{"id":69634213,"node_id":"MDU6TGFiZWw2OTYzNDIxMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21","default":false},{"id":52881747,"node_id":"MDU6TGFiZWw1Mjg4MTc0Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131220,"node_id":"MDU6TGFiZWw1NjEzMTIyMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":435,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-12-17T16:03:39Z","due_on":null,"closed_at":null},"comments":26,"created_at":"2018-12-13T15:42:11Z","updated_at":"2018-12-17T19:46:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25495","html_url":"https://github.com/cms-sw/cmssw/pull/25495","diff_url":"https://github.com/cms-sw/cmssw/pull/25495.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25495.patch"},"body":"This PR includes elements for reconstruction of forward protons detected in the PPS subsytem.\r\n  * Data formats: `ProtonTrack` and `ProtonTrackExtra`. The former is based on `reco::Track` to reuse the existing functionality.\r\n  * Conditions formats: `LHCOpticalFunctionsCollection` with functions that describe proton propagation from the interaction point to the Roman Pots. `CTPPSBeamParameters` with relevant beam parameters, possibly calibrated with Roman Pot data.\r\n  * Reconstruction module: `RecoCTPPS/ProtonReconstruction`.\r\n  * Configuration update: proton reconstruction has been appended to the standard PPS reconstruction sequence: https://github.com/CTPPS/cmssw/blob/proton_reco_10_4_X/RecoCTPPS/Configuration/python/recoCTPPS_sequences_cff.py#L29\r\n  * Validation suite: `Validation/CTPPS` to validate all elements in the reconstruction/simulation chain.\r\n  * Test based on 2016 data: `Validation/CTPPS/test/year_2016`. Most files in this directory related to conditions data will be replaced by database in near future - several activities in this direction are already in progress, hopefully targeting 10_4_pre6. A test config to apply the reconstruction to LHC data: https://github.com/CTPPS/cmssw/blob/proton_reco_10_4_X/Validation/CTPPS/test/year_2016/proton_reconstruction_LHC_data/test_reconstruction_cfg.py\r\n\r\n`runTheMatrix -l limited` only gave errors unrelated to this PR (DAS error, xroot problems)."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/447974371","html_url":"https://github.com/cms-sw/cmssw/pull/25495#issuecomment-447974371","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25495","id":447974371,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzk3NDM3MQ==","user":{"login":"makortel","id":33993,"node_id":"MDQ6VXNlcjMzOTkz","avatar_url":"https://avatars3.githubusercontent.com/u/33993?v=4","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T19:46:56Z","updated_at":"2018-12-17T19:46:56Z","author_association":"CONTRIBUTOR","body":"> do I understand correctly that if one stream gets to a LS boundary where a piece of ES data would need to be changed, the framework will process first the remaining events from the same LS before actually changing the ES data?\r\n\r\nYes."}}
{"actor":{"display_login":"makortel"}}