{"action":"closed","number":12312,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312","id":195069322,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDY5MzIy","html_url":"https://github.com/civicrm/civicrm-core/pull/12312","diff_url":"https://github.com/civicrm/civicrm-core/pull/12312.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/12312.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12312","number":12312,"state":"closed","locked":false,"title":"Disable inline-edit of multi-record custom fields in profiles","user":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nFixes a bug when editing multirecord custom fields in a profile form.\r\n\r\nSteps to Reproduce\r\n----------------------------------------\r\n1. Create a multirecord set of custom fields for contacts (Type \"Tab with Table\")\r\n2. Create a profile; add the fields to the profile (selecting \"Include in multi-record listing?\" for each field)\r\n3. Use the profile in edit mode for an existing contact\r\n4. Once you have at least one row of values, click on a value to edit in-place.\r\n5. Javascript error.\r\n\r\nAfter\r\n---------\r\nProfile does not allow inline-edit.\r\n\r\nNotes\r\n------\r\nThis was reported on StackExchange: https://civicrm.stackexchange.com/questions/25166/disable-inline-editing-of-fields-in-profile-form","created_at":"2018-06-15T03:26:05Z","updated_at":"2018-07-15T04:07:38Z","closed_at":"2018-07-15T04:07:37Z","merged_at":"2018-07-15T04:07:37Z","merge_commit_sha":"92495721fb68aa7e8e21d6ce2e486def1288f335","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12312/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/13f7c8449ba3659b0bf9afead93418427af6a3ea","head":{"label":"colemanw:multiRecordCustomProfile","ref":"multiRecordCustomProfile","sha":"13f7c8449ba3659b0bf9afead93418427af6a3ea","user":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"repo":{"id":8513618,"node_id":"MDEwOlJlcG9zaXRvcnk4NTEzNjE4","name":"civicrm-core","full_name":"colemanw/civicrm-core","owner":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colemanw/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/colemanw/civicrm-core","forks_url":"https://api.github.com/repos/colemanw/civicrm-core/forks","keys_url":"https://api.github.com/repos/colemanw/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colemanw/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colemanw/civicrm-core/teams","hooks_url":"https://api.github.com/repos/colemanw/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/colemanw/civicrm-core/events","assignees_url":"https://api.github.com/repos/colemanw/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/colemanw/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/colemanw/civicrm-core/tags","blobs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colemanw/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/colemanw/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colemanw/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/colemanw/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/colemanw/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/colemanw/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/colemanw/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/colemanw/civicrm-core/subscription","commits_url":"https://api.github.com/repos/colemanw/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/colemanw/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/colemanw/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/colemanw/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/colemanw/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colemanw/civicrm-core/merges","archive_url":"https://api.github.com/repos/colemanw/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colemanw/civicrm-core/downloads","issues_url":"https://api.github.com/repos/colemanw/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/colemanw/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/colemanw/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/colemanw/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colemanw/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/colemanw/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/colemanw/civicrm-core/deployments","created_at":"2013-03-02T01:06:53Z","updated_at":"2015-03-27T01:09:41Z","pushed_at":"2018-07-15T02:58:26Z","git_url":"git://github.com/colemanw/civicrm-core.git","ssh_url":"git@github.com:colemanw/civicrm-core.git","clone_url":"https://github.com/colemanw/civicrm-core.git","svn_url":"https://github.com/colemanw/civicrm-core","homepage":null,"size":157786,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"c776a4e707e367a809eef6f31192becea1f0108f","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-07-14T22:37:36Z","pushed_at":"2018-07-15T04:07:37Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":162704,"stargazers_count":280,"watchers_count":280,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":100,"license":null,"forks":633,"open_issues":100,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/12312"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/12312"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/12312/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12312/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/13f7c8449ba3659b0bf9afead93418427af6a3ea"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"seamuslee001","id":6799125,"node_id":"MDQ6VXNlcjY3OTkxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"seamuslee001"}}