{"push_id":2367423374,"size":204,"distinct_size":204,"ref":"refs/heads/master","head":"c20e0f94feb42a71633212114b42c62494fd4ff0","before":"752427b7b8221bbb8304a158b2dad12b26afd7a5","commits":[{"sha":"9f7cedbe14321d24b7aee1ba969b3d23d5c9d204","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Remove the use of legacy flag and log the diff if its used\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6856812\n\nfbshipit-source-id: e4724d80702cc75c1894e348e137b24e663573d2","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/9f7cedbe14321d24b7aee1ba969b3d23d5c9d204"},{"sha":"ebc98840e93c336e8c9e4a93c78e6ca03591f0ec","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"Improved documentation for <TextInput clearButtonMode=...>\n\nSummary:\nDocumentation only. Actual behaviour was never changed.\n\nCreated from Diffusion's 'Open in Editor' feature.\n\nReviewed By: sahrens\n\nDifferential Revision: D6869466\n\nfbshipit-source-id: 6e964433bb2b04b288736a3f01244285bc8c3fe8","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/ebc98840e93c336e8c9e4a93c78e6ca03591f0ec"},{"sha":"ef596dec49975dd4f8860ad8adcd29dd23e04c14","author":{"name":"Oleg Lokhvitsky","email":"fc45619a189d16afa0d91e367fa96d65e4b453fc@fb.com"},"message":"Fix initialScrollIndex for Android\n\nReviewed By: sahrens\n\nDifferential Revision: D6885608\n\nfbshipit-source-id: c153fcb5c2552982481d8af8b9755ae035e9b293","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/ef596dec49975dd4f8860ad8adcd29dd23e04c14"},{"sha":"9e436d14399ab3bba5e302f1a4e67db92c942bf4","author":{"name":"allengleyzer","email":"b122b6aa70b968384f5f1dd3c8f177e00351fd65@gmail.com"},"message":"Added progress updates for all XMLHttpRequest upload types / fix crash on closed connection\n\nSummary:\nThis PR includes the same changes made in #16541, for addressing issues #11853/#15724. It adds upload progress updates for uploads with any request body type, and not just form-data.\n\nAdditionally, this PR also includes a commit for fixing an `IllegalStateException` when a user's connection gets closed or times out (issues #10423/#11016). Since this exception was occurring within the progress updates logic, it started being thrown more frequently as a result of adding progress updates to all uploads, which was why the original PR was reverted.\n\nTo test the upload progress updates, run the following JS to ensure events are now being dispatched:\n```\nconst fileUri = 'file:///my_file.dat';\nconst url = 'http://my_post_url.com/';\nconst xhr = new XMLHttpRequest();\n\nxhr.upload.onprogress = (event) => {\n    console.log('progress: ' + event.loaded + ' / ' + event.total);\n}\n\nxhr.onreadystatechange = () => {if (xhr.readyState === 4) console.log('done');}\n\nconsole.log('start');\n\nxhr.open('POST', url);\n\n// sending a file (wasn't sending progress)\nxhr.setRequestHeader('Content-Type', 'image/jpeg');\nxhr.send({ uri: fileUri });\n\n// sending a string (wasn't sending progress)\nxhr.setRequestHeader('Content-Type', 'text/plain');\nxhr.send(\"some big string\");\n\n// sending form data (was already working)\nxhr.setRequestHeader('Content-Type', 'multipart/form-data');\nconst formData = new FormData(); formData.append('test', 'data');\nxhr.send(formData);\n```\n\nTo test the crash fix:\nIn the RN Android project, before this change, set a breakpoint at `mRequestBody.writeTo(mBufferedSink);` of `ProgressRequestBody`, and wait a short while for a POST request with a non-null body to time out before resuming the app. Once resumed, if the connection was closed (the `closed` variable will be set to true in `RealBufferedSink`), an `IllegalStateException` will be thrown, which crashes the app. After the changes, an `IOException` will get thrown instead, which is already being properly handled.\n\nAs mentioned above, includes the same changes as #16541, with an additional commit.\n\n[ANDROID] [BUGFIX] [XMLHttpRequest] - Added progress updates for all XMLHttpRequest upload types / fix crash on closed connection\n\nPreviously, only form-data request bodies emitted upload progress updates. Now, other request body types will also emit updates. Also, Android will no longer crash on certain requests when user has a poor connection.\n\nAddresses issues: 11853/15724/10423/11016\nCloses https://github.com/facebook/react-native/pull/17312\n\nDifferential Revision: D6712377\n\nPulled By: mdvacca\n\nfbshipit-source-id: bf5adc774703e7e66f7f16707600116f67201425","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/9e436d14399ab3bba5e302f1a4e67db92c942bf4"},{"sha":"8235a49a33cc8e84cd4ba1cc15bc09eed6712b4c","author":{"name":"Brian Vaughn","email":"1a0598e024fdacbe2334e757ecafe10bcbbc70ee@fb.com"},"message":"Update react-devtools@3.1.0 in prep for React 16.3\n\nReviewed By: gaearon\n\nDifferential Revision: D6886480\n\nfbshipit-source-id: 09ca9ea8e20bc050ba30ae4e5f73495cace426f5","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/8235a49a33cc8e84cd4ba1cc15bc09eed6712b4c"},{"sha":"34b7ec82b5d22efbdaa8b74b930d3c4da87414ec","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Moved out logic to calculate size consumed on a line into seperate function\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6797640\n\nfbshipit-source-id: ad9757e7d603c0ce57f452b1e5c404037605bed9","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/34b7ec82b5d22efbdaa8b74b930d3c4da87414ec"},{"sha":"fda861a88914a008b94c12078c9e579a99929643","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Replaced first pass with a function\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6819719\n\nfbshipit-source-id: e5e77c21d1dca2255433da3388887d9db3f7b642","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/fda861a88914a008b94c12078c9e579a99929643"},{"sha":"ca91f0e3ac55cb1e7a0fa2399d594a47de80a100","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Seperate function for second pass\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6833635\n\nfbshipit-source-id: 7680a67db8bfe22f8fb86407159888882f3a3353","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/ca91f0e3ac55cb1e7a0fa2399d594a47de80a100"},{"sha":"d4517ddb9f2ad6d6175cbe6a8be2b819e4aa2c29","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Made a separate function for resolving flexible length\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6834269\n\nfbshipit-source-id: 954bc7fe8eb9256d353cdda27e5c64c076808e25","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/d4517ddb9f2ad6d6175cbe6a8be2b819e4aa2c29"},{"sha":"108f9664bffd1a4e0a7b2c2da3dc3810f1b29de2","author":{"name":"David Aurelio","email":"ff048047600c1f3e891446665b5269773d037402@fb.com"},"message":"Do not expose `BundleDownloader` from `DevServerHelper`\n\nSummary:\nAdds `downloadBundleFromURL` as a delegating method to `DevServerHelper` rather than exposing the underlying `BundleDownloader`.\n\nThe additional encapsulation will allow futher factoring of `BundleDownloader` to make logic for different delta bundler clients easier to implement and maintain.\n\nReviewed By: pakoito\n\nDifferential Revision: D6871225\n\nfbshipit-source-id: 6adcab5e69869a234baf38f1f1e60abd34d6b555","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/108f9664bffd1a4e0a7b2c2da3dc3810f1b29de2"},{"sha":"816d41718998868f276d83b0c21e17d11ad392a2","author":{"name":"Marc Horowitz","email":"5e85808dffeff32aa7915794d93d1e0510e0c781@fb.com"},"message":"Delete RCTBatchedBridge\n\nSummary:\nI've talked to several major community users, and they're all ok with deleting this\ncode.  There's several doc fixes which will make it easier for third\nparty developers which should land about the same time this will.\n\nAlso buried along with it is RCTJSCExecutor.\n\nReviewed By: javache\n\nDifferential Revision: D6880781\n\nfbshipit-source-id: b4cb1143def6fd23a96290e478fa728adbedacd3","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/816d41718998868f276d83b0c21e17d11ad392a2"},{"sha":"ce50f25d22d56f24bdb7d80a3f9a279863d5dc2a","author":{"name":"Rafael Oleza","email":"8ebf52f314f582fa070154390e7e6be53f72eff5@fb.com"},"message":"Bump metro@0.25.0\n\nReviewed By: davidaurelio\n\nDifferential Revision: D6878299\n\nfbshipit-source-id: cde26c9c9e56ee9a052f1915ad7772ae475b5e41","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/ce50f25d22d56f24bdb7d80a3f9a279863d5dc2a"},{"sha":"0f9fc4b2953d52fa1754e786dc5c74bfecbeaaca","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"`processUpdatedProperties` & `collectUpdatedProperties` was removed from RCTShadowView\n\nSummary: This is leftovers from last <Text> reimplementation; nobody uses it and it does not hooked up with UIManager.\n\nReviewed By: fkgozali\n\nDifferential Revision: D6887795\n\nfbshipit-source-id: 9e2e29af4ba959270096eeb494666d1cacaeba32","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/0f9fc4b2953d52fa1754e786dc5c74bfecbeaaca"},{"sha":"9dfa2e7f3cfa5009f6c54382e90681d99a9c3cb8","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"Removed `[ShadowView collectUpdatedFrames:]`\n\nSummary: Another juicy leftover from old Text implementation.\n\nReviewed By: fkgozali\n\nDifferential Revision: D6887942\n\nfbshipit-source-id: d0363d06d566554c03d0ae3293597daf9c387028","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/9dfa2e7f3cfa5009f6c54382e90681d99a9c3cb8"},{"sha":"c19bc7968855e85758df9e1a47dc2a52e69668ed","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"`[RCTShadowView isHidden]` was removed\n\nSummary:\nIt's unused.\nUse `display` prop instead to control visiblity of the view.\n\nReviewed By: fkgozali\n\nDifferential Revision: D6888104\n\nfbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/c19bc7968855e85758df9e1a47dc2a52e69668ed"},{"sha":"ceb1d1ca5bc7c04b9d9ad16dcd9583f05b0ef498","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"Removing our own implementation of round-to-pixel algorithm\n\nSummary:\n> Okay, I don't remember where we first met\n> But hey, admitting is the first step\n\nThis issue has a looong history.\nThe original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)\nThe problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.\nFor now, the vision is clear:\n * The basic algorithm should live in Yoga for unification and performance reasons.\n * We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.\n * We have to enable it in RN eventually.\n\nSo, this is the first step: Removing old, broken code which we don't plan to fix and use.\n\nMake React Native crisp again!\n\nReviewed By: fkgozali\n\nDifferential Revision: D6888662\n\nfbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/ceb1d1ca5bc7c04b9d9ad16dcd9583f05b0ef498"},{"sha":"114c258045ccca3a4433de206c7983b42d14c03b","author":{"name":"Valentin Shergin","email":"34b584e0550f7278343b1600922fb1d876d97e4a@fb.com"},"message":"Enabling round-to-pixel Yoga feature for RN (iOS)\n\nSummary:\nThis change enables built-in Yoga mechanism which rounds producing layout metrics to closest \"pixel\" values.\nSee previous diff for more context.\n\nReviewed By: fkgozali\n\nDifferential Revision: D6889762\n\nfbshipit-source-id: bc2eea44704db4b377e2e14fab9f67be8c935719","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/114c258045ccca3a4433de206c7983b42d14c03b"},{"sha":"9658d9f82ba536c2f39937d61b3954e3dcc6a54e","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Fixed failing snapshot test\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6901242\n\nfbshipit-source-id: 7391d6a34fa28e9f92f4ff834755a89dd876fdad","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/9658d9f82ba536c2f39937d61b3954e3dcc6a54e"},{"sha":"9daa17458a5f4ab8ead4d7c29de331f08b1a4a46","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Moved out main axis justification logic to seperate function\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6845997\n\nfbshipit-source-id: fdb64e00de39427ce1d66d4fbfd06c23c0d32bcf","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/9daa17458a5f4ab8ead4d7c29de331f08b1a4a46"},{"sha":"1475fc4856d366f8ec2027374971ed5aefcdeafa","author":{"name":"Pritesh Nandgaonkar","email":"80db9657dccb734517eb2fef673b2ba77c8fe1b5@fb.com"},"message":"Moved trailing padding and border function as a method on YGNode\n\nReviewed By: emilsjolander\n\nDifferential Revision: D6899571\n\nfbshipit-source-id: 7f686e8771d5a94aae502191516557b20c557d7c","distinct":true,"url":"https://api.github.com/repos/zhongwuzw/react-native/commits/1475fc4856d366f8ec2027374971ed5aefcdeafa"}]}
{"actor":{"display_login":"zhongwuzw"}}