{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/187170960","pull_request_review_id":118898401,"id":187170960,"diff_hunk":"@@ -0,0 +1,17 @@\n+<?php","path":"includes/discovery/sensors/current/cimc.inc.php","position":1,"original_position":1,"commit_id":"905a275ed5c816bbe9362d50e7120c593373c416","original_commit_id":"905a275ed5c816bbe9362d50e7120c593373c416","user":{"login":"laf","id":3941142,"avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"body":"Looking at this, it should be possible to do this in yaml, any reason you haven't?","created_at":"2018-05-09T20:45:57Z","updated_at":"2018-05-09T20:48:01Z","html_url":"https://github.com/librenms/librenms/pull/8591#discussion_r187170960","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/8591","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/187170960"},"html":{"href":"https://github.com/librenms/librenms/pull/8591#discussion_r187170960"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8591"}}},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/8591","id":183136827,"html_url":"https://github.com/librenms/librenms/pull/8591","diff_url":"https://github.com/librenms/librenms/pull/8591.diff","patch_url":"https://github.com/librenms/librenms/pull/8591.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/8591","number":8591,"state":"open","locked":false,"title":"Fix sensors for cimc os","user":{"login":"vivia11","id":28970851,"avatar_url":"https://avatars1.githubusercontent.com/u/28970851?v=4","gravatar_id":"","url":"https://api.github.com/users/vivia11","html_url":"https://github.com/vivia11","followers_url":"https://api.github.com/users/vivia11/followers","following_url":"https://api.github.com/users/vivia11/following{/other_user}","gists_url":"https://api.github.com/users/vivia11/gists{/gist_id}","starred_url":"https://api.github.com/users/vivia11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivia11/subscriptions","organizations_url":"https://api.github.com/users/vivia11/orgs","repos_url":"https://api.github.com/users/vivia11/repos","events_url":"https://api.github.com/users/vivia11/events{/privacy}","received_events_url":"https://api.github.com/users/vivia11/received_events","type":"User","site_admin":false},"body":"Hello all,\r\n\r\nLet me know if the snmp data isn't necessary.\r\n\r\nAdded a period that was missing on some OIDs for temperature sensing.\r\n\r\nRemoved $temp_board/cpu/mem[$oid][$index] so it is not passed to discover_sensor. It passes the values NULL anyways. The OID is appended with the index value, and then this new key is read from the $temp array. However, no such key value exists, resulting in NULL values. Instead of editing the string for each discover_sensor, I thought it would be simpler to remove it and have the values polled.\r\n\r\nI also added some more changes to the way voltage/power/current sensors were being discovered for cimc. It was originally all done in one file for current/power/voltage. However, since current is discovered first, the current sensors were being deleted and then readded again to the db once the power code was ran. I just split up the code into three individual files.\r\n\r\n \r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n","created_at":"2018-04-20T18:25:30Z","updated_at":"2018-05-09T20:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a411ce6331991e7d2e4a087458949e97d127d572","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62946216,"url":"https://api.github.com/repos/librenms/librenms/labels/Bug%20:beetle:","name":"Bug :beetle:","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/8591/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/8591/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/8591/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/905a275ed5c816bbe9362d50e7120c593373c416","head":{"label":"vivia11:cimc","ref":"cimc","sha":"905a275ed5c816bbe9362d50e7120c593373c416","user":{"login":"vivia11","id":28970851,"avatar_url":"https://avatars1.githubusercontent.com/u/28970851?v=4","gravatar_id":"","url":"https://api.github.com/users/vivia11","html_url":"https://github.com/vivia11","followers_url":"https://api.github.com/users/vivia11/followers","following_url":"https://api.github.com/users/vivia11/following{/other_user}","gists_url":"https://api.github.com/users/vivia11/gists{/gist_id}","starred_url":"https://api.github.com/users/vivia11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivia11/subscriptions","organizations_url":"https://api.github.com/users/vivia11/orgs","repos_url":"https://api.github.com/users/vivia11/repos","events_url":"https://api.github.com/users/vivia11/events{/privacy}","received_events_url":"https://api.github.com/users/vivia11/received_events","type":"User","site_admin":false},"repo":{"id":125080953,"name":"librenms","full_name":"vivia11/librenms","owner":{"login":"vivia11","id":28970851,"avatar_url":"https://avatars1.githubusercontent.com/u/28970851?v=4","gravatar_id":"","url":"https://api.github.com/users/vivia11","html_url":"https://github.com/vivia11","followers_url":"https://api.github.com/users/vivia11/followers","following_url":"https://api.github.com/users/vivia11/following{/other_user}","gists_url":"https://api.github.com/users/vivia11/gists{/gist_id}","starred_url":"https://api.github.com/users/vivia11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivia11/subscriptions","organizations_url":"https://api.github.com/users/vivia11/orgs","repos_url":"https://api.github.com/users/vivia11/repos","events_url":"https://api.github.com/users/vivia11/events{/privacy}","received_events_url":"https://api.github.com/users/vivia11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivia11/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/vivia11/librenms","forks_url":"https://api.github.com/repos/vivia11/librenms/forks","keys_url":"https://api.github.com/repos/vivia11/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivia11/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivia11/librenms/teams","hooks_url":"https://api.github.com/repos/vivia11/librenms/hooks","issue_events_url":"https://api.github.com/repos/vivia11/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/vivia11/librenms/events","assignees_url":"https://api.github.com/repos/vivia11/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/vivia11/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/vivia11/librenms/tags","blobs_url":"https://api.github.com/repos/vivia11/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivia11/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivia11/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivia11/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivia11/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/vivia11/librenms/languages","stargazers_url":"https://api.github.com/repos/vivia11/librenms/stargazers","contributors_url":"https://api.github.com/repos/vivia11/librenms/contributors","subscribers_url":"https://api.github.com/repos/vivia11/librenms/subscribers","subscription_url":"https://api.github.com/repos/vivia11/librenms/subscription","commits_url":"https://api.github.com/repos/vivia11/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivia11/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivia11/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivia11/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivia11/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/vivia11/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivia11/librenms/merges","archive_url":"https://api.github.com/repos/vivia11/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivia11/librenms/downloads","issues_url":"https://api.github.com/repos/vivia11/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/vivia11/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/vivia11/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/vivia11/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivia11/librenms/labels{/name}","releases_url":"https://api.github.com/repos/vivia11/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/vivia11/librenms/deployments","created_at":"2018-03-13T16:22:39Z","updated_at":"2018-05-03T19:46:09Z","pushed_at":"2018-05-09T18:17:05Z","git_url":"git://github.com/vivia11/librenms.git","ssh_url":"git@github.com:vivia11/librenms.git","clone_url":"https://github.com/vivia11/librenms.git","svn_url":"https://github.com/vivia11/librenms","homepage":"http://www.librenms.org/","size":128050,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"ecfdb681a9baa11e279550ef1141ee4aa0a0bd19","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2018-05-09T13:39:30Z","pushed_at":"2018-05-09T19:52:24Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":129204,"stargazers_count":1038,"watchers_count":1038,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":812,"open_issues":73,"watchers":1038,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8591"},"html":{"href":"https://github.com/librenms/librenms/pull/8591"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/8591"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/8591/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8591/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8591/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/905a275ed5c816bbe9362d50e7120c593373c416"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laf"}}