{"action":"created","comment":{"url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/comments/238024669","pull_request_review_id":180478030,"id":238024669,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAyNDY2OQ==","diff_hunk":"@@ -56,14 +56,11 @@ class JasmineAdapter {\n             return true\n         }\n \n-        const stopOnSpecFailure = this.getStopOnSpecFailure()\n-        if (stopOnSpecFailure) {\n-            try {\n-                jasmine.getEnv().stopOnSpecFailure(stopOnSpecFailure)\n-            } catch (e) {\n-                console.log('Warning: installed version of Jasmine doesn\\'t support stopOnSpecFailure')\n-            }\n-        }\n+        /**\n+         * Set whether to stop suite execution when a spec fails\n+         */\n+        const stopOnSpecFailure = !!this.jasmineNodeOpts.stopOnSpecFailure\n+        jasmine.getEnv().stopOnSpecFailure(stopOnSpecFailure)","path":"lib/adapter.js","position":8,"original_position":16,"commit_id":"885175307cd98a7a8a210bcd137ba42e4df2ac3b","original_commit_id":"0711958d4c7c409cde3d9bc53be967d64e9ad4f5","user":{"login":"finelord","id":1898278,"node_id":"MDQ6VXNlcjE4OTgyNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1898278?v=4","gravatar_id":"","url":"https://api.github.com/users/finelord","html_url":"https://github.com/finelord","followers_url":"https://api.github.com/users/finelord/followers","following_url":"https://api.github.com/users/finelord/following{/other_user}","gists_url":"https://api.github.com/users/finelord/gists{/gist_id}","starred_url":"https://api.github.com/users/finelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finelord/subscriptions","organizations_url":"https://api.github.com/users/finelord/orgs","repos_url":"https://api.github.com/users/finelord/repos","events_url":"https://api.github.com/users/finelord/events{/privacy}","received_events_url":"https://api.github.com/users/finelord/received_events","type":"User","site_admin":false},"body":"will do, first attempt failed - need to dive into a bit more","created_at":"2018-11-30T22:40:33Z","updated_at":"2018-11-30T22:40:34Z","html_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132#discussion_r238024669","pull_request_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/comments/238024669"},"html":{"href":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132#discussion_r238024669"},"pull_request":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132"}},"in_reply_to_id":238007596},"pull_request":{"url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132","id":235117434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTE3NDM0","html_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132","diff_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132.diff","patch_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132.patch","issue_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/132","number":132,"state":"open","locked":false,"title":"Add stopOnSpecFailure support","user":{"login":"finelord","id":1898278,"node_id":"MDQ6VXNlcjE4OTgyNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1898278?v=4","gravatar_id":"","url":"https://api.github.com/users/finelord","html_url":"https://github.com/finelord","followers_url":"https://api.github.com/users/finelord/followers","following_url":"https://api.github.com/users/finelord/following{/other_user}","gists_url":"https://api.github.com/users/finelord/gists{/gist_id}","starred_url":"https://api.github.com/users/finelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finelord/subscriptions","organizations_url":"https://api.github.com/users/finelord/orgs","repos_url":"https://api.github.com/users/finelord/repos","events_url":"https://api.github.com/users/finelord/events{/privacy}","received_events_url":"https://api.github.com/users/finelord/received_events","type":"User","site_admin":false},"body":"Since Jasmine 3.2, useful `stopOnSpecFailure` option became available: [documentation](https://jasmine.github.io/api/3.2/Env.html)\r\n\r\nWould be really nice to support this feature.\r\n\r\n**stopOnSpecFailure(value)**\r\n\r\nSet whether to stop suite execution when a spec fails\r\n\r\nParameters:\r\n\r\nName | Type | Description\r\n-- | -- | --\r\nvalue | Boolean | Whether to stop suite execution when a spec fails\r\n\r\n\r\n\r\n","created_at":"2018-11-30T21:16:15Z","updated_at":"2018-11-30T22:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb8a2c7bf0adb7498ca257b8466c0d61d4cd9902","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132/commits","review_comments_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132/comments","review_comment_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/132/comments","statuses_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/statuses/885175307cd98a7a8a210bcd137ba42e4df2ac3b","head":{"label":"finelord:add-stop-on-spec-failure-support","ref":"add-stop-on-spec-failure-support","sha":"885175307cd98a7a8a210bcd137ba42e4df2ac3b","user":{"login":"finelord","id":1898278,"node_id":"MDQ6VXNlcjE4OTgyNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1898278?v=4","gravatar_id":"","url":"https://api.github.com/users/finelord","html_url":"https://github.com/finelord","followers_url":"https://api.github.com/users/finelord/followers","following_url":"https://api.github.com/users/finelord/following{/other_user}","gists_url":"https://api.github.com/users/finelord/gists{/gist_id}","starred_url":"https://api.github.com/users/finelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finelord/subscriptions","organizations_url":"https://api.github.com/users/finelord/orgs","repos_url":"https://api.github.com/users/finelord/repos","events_url":"https://api.github.com/users/finelord/events{/privacy}","received_events_url":"https://api.github.com/users/finelord/received_events","type":"User","site_admin":false},"repo":{"id":159878505,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4Nzg1MDU=","name":"wdio-jasmine-framework","full_name":"finelord/wdio-jasmine-framework","private":false,"owner":{"login":"finelord","id":1898278,"node_id":"MDQ6VXNlcjE4OTgyNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1898278?v=4","gravatar_id":"","url":"https://api.github.com/users/finelord","html_url":"https://github.com/finelord","followers_url":"https://api.github.com/users/finelord/followers","following_url":"https://api.github.com/users/finelord/following{/other_user}","gists_url":"https://api.github.com/users/finelord/gists{/gist_id}","starred_url":"https://api.github.com/users/finelord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finelord/subscriptions","organizations_url":"https://api.github.com/users/finelord/orgs","repos_url":"https://api.github.com/users/finelord/repos","events_url":"https://api.github.com/users/finelord/events{/privacy}","received_events_url":"https://api.github.com/users/finelord/received_events","type":"User","site_admin":false},"html_url":"https://github.com/finelord/wdio-jasmine-framework","description":"A WebdriverIO plugin. Adapter for Jasmine testing framework.","fork":true,"url":"https://api.github.com/repos/finelord/wdio-jasmine-framework","forks_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/forks","keys_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/teams","hooks_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/hooks","issue_events_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/issues/events{/number}","events_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/events","assignees_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/assignees{/user}","branches_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/branches{/branch}","tags_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/tags","blobs_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/languages","stargazers_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/stargazers","contributors_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/contributors","subscribers_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/subscribers","subscription_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/subscription","commits_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/contents/{+path}","compare_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/merges","archive_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/downloads","issues_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/issues{/number}","pulls_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/labels{/name}","releases_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/releases{/id}","deployments_url":"https://api.github.com/repos/finelord/wdio-jasmine-framework/deployments","created_at":"2018-11-30T21:05:04Z","updated_at":"2018-11-30T21:05:06Z","pushed_at":"2018-11-30T21:35:38Z","git_url":"git://github.com/finelord/wdio-jasmine-framework.git","ssh_url":"git@github.com:finelord/wdio-jasmine-framework.git","clone_url":"https://github.com/finelord/wdio-jasmine-framework.git","svn_url":"https://github.com/finelord/wdio-jasmine-framework","homepage":"http://webdriver.io/","size":186,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webdriverio-boneyard:master","ref":"master","sha":"68306cc555043a2bfb72e50690009aa267eb108c","user":{"login":"webdriverio-boneyard","id":40491997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxOTk3","avatar_url":"https://avatars3.githubusercontent.com/u/40491997?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio-boneyard","html_url":"https://github.com/webdriverio-boneyard","followers_url":"https://api.github.com/users/webdriverio-boneyard/followers","following_url":"https://api.github.com/users/webdriverio-boneyard/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio-boneyard/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio-boneyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio-boneyard/subscriptions","organizations_url":"https://api.github.com/users/webdriverio-boneyard/orgs","repos_url":"https://api.github.com/users/webdriverio-boneyard/repos","events_url":"https://api.github.com/users/webdriverio-boneyard/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio-boneyard/received_events","type":"Organization","site_admin":false},"repo":{"id":42413027,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQxMzAyNw==","name":"wdio-jasmine-framework","full_name":"webdriverio-boneyard/wdio-jasmine-framework","private":false,"owner":{"login":"webdriverio-boneyard","id":40491997,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxOTk3","avatar_url":"https://avatars3.githubusercontent.com/u/40491997?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio-boneyard","html_url":"https://github.com/webdriverio-boneyard","followers_url":"https://api.github.com/users/webdriverio-boneyard/followers","following_url":"https://api.github.com/users/webdriverio-boneyard/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio-boneyard/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio-boneyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio-boneyard/subscriptions","organizations_url":"https://api.github.com/users/webdriverio-boneyard/orgs","repos_url":"https://api.github.com/users/webdriverio-boneyard/repos","events_url":"https://api.github.com/users/webdriverio-boneyard/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio-boneyard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework","description":"A WebdriverIO plugin. Adapter for Jasmine testing framework.","fork":false,"url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework","forks_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/forks","keys_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/teams","hooks_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/hooks","issue_events_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/events","assignees_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/tags","blobs_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/languages","stargazers_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/stargazers","contributors_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/contributors","subscribers_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/subscribers","subscription_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/subscription","commits_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/merges","archive_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/downloads","issues_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/deployments","created_at":"2015-09-13T21:08:58Z","updated_at":"2018-10-31T00:06:36Z","pushed_at":"2018-11-30T21:35:40Z","git_url":"git://github.com/webdriverio-boneyard/wdio-jasmine-framework.git","ssh_url":"git@github.com:webdriverio-boneyard/wdio-jasmine-framework.git","clone_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework.git","svn_url":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework","homepage":"http://webdriver.io/","size":183,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":7,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132"},"html":{"href":"https://github.com/webdriverio-boneyard/wdio-jasmine-framework/pull/132"},"issue":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/132"},"comments":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/webdriverio-boneyard/wdio-jasmine-framework/statuses/885175307cd98a7a8a210bcd137ba42e4df2ac3b"}},"author_association":"NONE"}}
{"actor":{"display_login":"finelord"}}