{"action":"closed","number":454,"pull_request":{"url":"https://api.github.com/repos/prebid/prebid-server/pulls/454","id":181301086,"html_url":"https://github.com/prebid/prebid-server/pull/454","diff_url":"https://github.com/prebid/prebid-server/pull/454.diff","patch_url":"https://github.com/prebid/prebid-server/pull/454.patch","issue_url":"https://api.github.com/repos/prebid/prebid-server/issues/454","number":454,"state":"closed","locked":false,"title":"Analytics packages which are... modular","user":{"login":"dbemiller","id":27972385,"avatar_url":"https://avatars2.githubusercontent.com/u/27972385?v=4","gravatar_id":"","url":"https://api.github.com/users/dbemiller","html_url":"https://github.com/dbemiller","followers_url":"https://api.github.com/users/dbemiller/followers","following_url":"https://api.github.com/users/dbemiller/following{/other_user}","gists_url":"https://api.github.com/users/dbemiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dbemiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbemiller/subscriptions","organizations_url":"https://api.github.com/users/dbemiller/orgs","repos_url":"https://api.github.com/users/dbemiller/repos","events_url":"https://api.github.com/users/dbemiller/events{/privacy}","received_events_url":"https://api.github.com/users/dbemiller/received_events","type":"User","site_admin":false},"body":"This is a strict refactoring... no functional code changes here.\r\n\r\nI need to do something like this because there's a dependency issue with the current structure.\r\n\r\nToday, the `analytics` package contains:\r\n\r\n1. Data objects (like `AuctionObject`)\r\n2. An interface whose functions use those Data objects in the contracts\r\n3. A \"constructor\" function (`NewPBSAnalytics`) that decides which analytics impls to use.\r\n\r\nBetween these three, implementations _must_ go into this same package. Otherwise `NewPBSAnalytics` depends on the impl, and the `func (i *imp) SomeFunc(a *AuctionObject)` definitions make the `impl` depend on the `AuctionObject`--which causes a cycle\r\n\r\nTo fix this, I moved `NewPBSAnalytics` into its own module. Since its job is primarily to turn a `Configuration` into an `Impl`, I named the module `analytics/config`. Now we can put implementations into their own packages... and I moved the `file_module` to prove it.\r\n\r\nWanted to get this sorted out before I started adding a new analytics module.","created_at":"2018-04-12T19:21:57Z","updated_at":"2018-04-16T18:37:38Z","closed_at":"2018-04-16T18:37:38Z","merged_at":"2018-04-16T18:37:38Z","merge_commit_sha":"f53a1c8a08092dea0461e146339a745c2d1c4c5f","assignee":{"login":"cirla","id":9155109,"avatar_url":"https://avatars2.githubusercontent.com/u/9155109?v=4","gravatar_id":"","url":"https://api.github.com/users/cirla","html_url":"https://github.com/cirla","followers_url":"https://api.github.com/users/cirla/followers","following_url":"https://api.github.com/users/cirla/following{/other_user}","gists_url":"https://api.github.com/users/cirla/gists{/gist_id}","starred_url":"https://api.github.com/users/cirla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirla/subscriptions","organizations_url":"https://api.github.com/users/cirla/orgs","repos_url":"https://api.github.com/users/cirla/repos","events_url":"https://api.github.com/users/cirla/events{/privacy}","received_events_url":"https://api.github.com/users/cirla/received_events","type":"User","site_admin":false},"assignees":[{"login":"cirla","id":9155109,"avatar_url":"https://avatars2.githubusercontent.com/u/9155109?v=4","gravatar_id":"","url":"https://api.github.com/users/cirla","html_url":"https://github.com/cirla","followers_url":"https://api.github.com/users/cirla/followers","following_url":"https://api.github.com/users/cirla/following{/other_user}","gists_url":"https://api.github.com/users/cirla/gists{/gist_id}","starred_url":"https://api.github.com/users/cirla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirla/subscriptions","organizations_url":"https://api.github.com/users/cirla/orgs","repos_url":"https://api.github.com/users/cirla/repos","events_url":"https://api.github.com/users/cirla/events{/privacy}","received_events_url":"https://api.github.com/users/cirla/received_events","type":"User","site_admin":false},{"login":"hhhjort","id":31041505,"avatar_url":"https://avatars1.githubusercontent.com/u/31041505?v=4","gravatar_id":"","url":"https://api.github.com/users/hhhjort","html_url":"https://github.com/hhhjort","followers_url":"https://api.github.com/users/hhhjort/followers","following_url":"https://api.github.com/users/hhhjort/following{/other_user}","gists_url":"https://api.github.com/users/hhhjort/gists{/gist_id}","starred_url":"https://api.github.com/users/hhhjort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhhjort/subscriptions","organizations_url":"https://api.github.com/users/hhhjort/orgs","repos_url":"https://api.github.com/users/hhhjort/repos","events_url":"https://api.github.com/users/hhhjort/events{/privacy}","received_events_url":"https://api.github.com/users/hhhjort/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":895640772,"url":"https://api.github.com/repos/prebid/prebid-server/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/prebid-server/pulls/454/commits","review_comments_url":"https://api.github.com/repos/prebid/prebid-server/pulls/454/comments","review_comment_url":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/prebid-server/issues/454/comments","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/7a54d75429e2c268c70972113c873555750de322","head":{"label":"prebid:modular-analytics","ref":"modular-analytics","sha":"7a54d75429e2c268c70972113c873555750de322","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-04-16T18:18:11Z","pushed_at":"2018-04-16T18:37:38Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7320,"stargazers_count":64,"watchers_count":64,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":69,"open_issues":44,"watchers":64,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"2c6814cfa2f2b5427def0b9c746293d3fafc70f4","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":88511474,"name":"prebid-server","full_name":"prebid/prebid-server","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/prebid-server","description":"Server side component to offload prebid processing to the cloud","fork":false,"url":"https://api.github.com/repos/prebid/prebid-server","forks_url":"https://api.github.com/repos/prebid/prebid-server/forks","keys_url":"https://api.github.com/repos/prebid/prebid-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-server/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-server/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-server/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-server/events","assignees_url":"https://api.github.com/repos/prebid/prebid-server/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-server/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-server/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-server/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-server/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-server/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-server/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-server/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-server/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-server/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-server/merges","archive_url":"https://api.github.com/repos/prebid/prebid-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-server/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-server/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-server/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-server/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-server/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-server/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-server/deployments","created_at":"2017-04-17T13:38:32Z","updated_at":"2018-04-16T18:18:11Z","pushed_at":"2018-04-16T18:37:38Z","git_url":"git://github.com/prebid/prebid-server.git","ssh_url":"git@github.com:prebid/prebid-server.git","clone_url":"https://github.com/prebid/prebid-server.git","svn_url":"https://github.com/prebid/prebid-server","homepage":null,"size":7320,"stargazers_count":64,"watchers_count":64,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":69,"open_issues":44,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/454"},"html":{"href":"https://github.com/prebid/prebid-server/pull/454"},"issue":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/454"},"comments":{"href":"https://api.github.com/repos/prebid/prebid-server/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/prebid-server/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/prebid-server/statuses/7a54d75429e2c268c70972113c873555750de322"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cirla","id":9155109,"avatar_url":"https://avatars2.githubusercontent.com/u/9155109?v=4","gravatar_id":"","url":"https://api.github.com/users/cirla","html_url":"https://github.com/cirla","followers_url":"https://api.github.com/users/cirla/followers","following_url":"https://api.github.com/users/cirla/following{/other_user}","gists_url":"https://api.github.com/users/cirla/gists{/gist_id}","starred_url":"https://api.github.com/users/cirla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cirla/subscriptions","organizations_url":"https://api.github.com/users/cirla/orgs","repos_url":"https://api.github.com/users/cirla/repos","events_url":"https://api.github.com/users/cirla/events{/privacy}","received_events_url":"https://api.github.com/users/cirla/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":221,"deletions":195,"changed_files":12}}
{"actor":{"display_login":"cirla"}}