{"action":"reopened","number":5569,"pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569","id":238135194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTM1MTk0","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5569","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5569.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5569.patch","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5569","number":5569,"state":"open","locked":false,"title":"Removed CSV Blank Field Restriction, Updated Verse Edit Save Workflow","user":{"login":"RoyalSix","id":16184018,"node_id":"MDQ6VXNlcjE2MTg0MDE4","avatar_url":"https://avatars0.githubusercontent.com/u/16184018?v=4","gravatar_id":"","url":"https://api.github.com/users/RoyalSix","html_url":"https://github.com/RoyalSix","followers_url":"https://api.github.com/users/RoyalSix/followers","following_url":"https://api.github.com/users/RoyalSix/following{/other_user}","gists_url":"https://api.github.com/users/RoyalSix/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyalSix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyalSix/subscriptions","organizations_url":"https://api.github.com/users/RoyalSix/orgs","repos_url":"https://api.github.com/users/RoyalSix/repos","events_url":"https://api.github.com/users/RoyalSix/events{/privacy}","received_events_url":"https://api.github.com/users/RoyalSix/received_events","type":"User","site_admin":false},"body":"#### Describe what your pull request addresses (Please include relevant issue numbers):\r\n- This PR adds back the functionality for the CSV export for verse edits.\r\n\r\n#### Please include detailed Test instructions for your pull request:\r\n- Ensure that normal CSV functionalities are working\r\n- Ensure that verse edit functionality is working correctly\r\n- Main feature testing:\r\n  - Import a project \r\n  - Do a verse edit\r\n  - Export the project to CSV\r\n  - Ensure that the csv includes the verse edit and has the following fields\r\n  ```\r\n    gateway Language Quote\r\n    groupId\r\n    groupName\r\n    occurence\r\n    quote\r\n```\r\n\r\n#### Standard Test Instructions for PR Review Process:\r\n\r\n- [ ] Double check unit tests that have been written\r\n- [ ] Check for documentation for code changes\r\n- [ ] Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR\r\n- [ ] Checkout the branch locally and ensure that app runs as expected\r\n  - [ ] Ensure tests pass\r\n  - [ ] Open and watch the console for errors\r\n  - [ ] Make sure all actions perform as expected\r\n  - [ ] Import and Load a new Project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Switch project to an existing project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Next time reverse the order of importing after loading an existing project\r\n- [ ] Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story\r\n- [ ] Ask Ben or Koz if you have any concerns about implementation (especially UI related)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/5569)\n<!-- Reviewable:end -->\n","created_at":"2018-12-12T18:18:56Z","updated_at":"2018-12-12T21:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02453c63ddf1d8831bddfc99e02d7dc14d58ba35","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569/commits","review_comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569/comments","review_comment_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5569/comments","statuses_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/statuses/51e87fac6765e5c24c5d0a4b5751bb7760217fdb","head":{"label":"unfoldingWord-dev:feature-jay-5377","ref":"feature-jay-5377","sha":"51e87fac6765e5c24c5d0a4b5751bb7760217fdb","user":{"login":"unfoldingWord-dev","id":11397506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk3NTA2","avatar_url":"https://avatars1.githubusercontent.com/u/11397506?v=4","gravatar_id":"","url":"https://api.github.com/users/unfoldingWord-dev","html_url":"https://github.com/unfoldingWord-dev","followers_url":"https://api.github.com/users/unfoldingWord-dev/followers","following_url":"https://api.github.com/users/unfoldingWord-dev/following{/other_user}","gists_url":"https://api.github.com/users/unfoldingWord-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/unfoldingWord-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfoldingWord-dev/subscriptions","organizations_url":"https://api.github.com/users/unfoldingWord-dev/orgs","repos_url":"https://api.github.com/users/unfoldingWord-dev/repos","events_url":"https://api.github.com/users/unfoldingWord-dev/events{/privacy}","received_events_url":"https://api.github.com/users/unfoldingWord-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":65028237,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAyODIzNw==","name":"translationCore","full_name":"unfoldingWord-dev/translationCore","private":false,"owner":{"login":"unfoldingWord-dev","id":11397506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk3NTA2","avatar_url":"https://avatars1.githubusercontent.com/u/11397506?v=4","gravatar_id":"","url":"https://api.github.com/users/unfoldingWord-dev","html_url":"https://github.com/unfoldingWord-dev","followers_url":"https://api.github.com/users/unfoldingWord-dev/followers","following_url":"https://api.github.com/users/unfoldingWord-dev/following{/other_user}","gists_url":"https://api.github.com/users/unfoldingWord-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/unfoldingWord-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfoldingWord-dev/subscriptions","organizations_url":"https://api.github.com/users/unfoldingWord-dev/orgs","repos_url":"https://api.github.com/users/unfoldingWord-dev/repos","events_url":"https://api.github.com/users/unfoldingWord-dev/events{/privacy}","received_events_url":"https://api.github.com/users/unfoldingWord-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unfoldingWord-dev/translationCore","description":"Repository for the desktop application translationCore","fork":false,"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","forks_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/forks","keys_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/teams","hooks_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/hooks","issue_events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/events{/number}","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/events","assignees_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/assignees{/user}","branches_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/branches{/branch}","tags_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/tags","blobs_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/statuses/{sha}","languages_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/languages","stargazers_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/stargazers","contributors_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/contributors","subscribers_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/subscribers","subscription_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/subscription","commits_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/contents/{+path}","compare_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/merges","archive_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/downloads","issues_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues{/number}","pulls_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls{/number}","milestones_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/milestones{/number}","notifications_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/labels{/name}","releases_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/releases{/id}","deployments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/deployments","created_at":"2016-08-05T15:14:53Z","updated_at":"2018-12-12T17:52:22Z","pushed_at":"2018-12-12T21:11:42Z","git_url":"git://github.com/unfoldingWord-dev/translationCore.git","ssh_url":"git@github.com:unfoldingWord-dev/translationCore.git","clone_url":"https://github.com/unfoldingWord-dev/translationCore.git","svn_url":"https://github.com/unfoldingWord-dev/translationCore","homepage":"","size":277152,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":523,"watchers":16,"default_branch":"develop"}},"base":{"label":"unfoldingWord-dev:develop","ref":"develop","sha":"01790533b5379017689db45dbbbc8d76b9654482","user":{"login":"unfoldingWord-dev","id":11397506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk3NTA2","avatar_url":"https://avatars1.githubusercontent.com/u/11397506?v=4","gravatar_id":"","url":"https://api.github.com/users/unfoldingWord-dev","html_url":"https://github.com/unfoldingWord-dev","followers_url":"https://api.github.com/users/unfoldingWord-dev/followers","following_url":"https://api.github.com/users/unfoldingWord-dev/following{/other_user}","gists_url":"https://api.github.com/users/unfoldingWord-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/unfoldingWord-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfoldingWord-dev/subscriptions","organizations_url":"https://api.github.com/users/unfoldingWord-dev/orgs","repos_url":"https://api.github.com/users/unfoldingWord-dev/repos","events_url":"https://api.github.com/users/unfoldingWord-dev/events{/privacy}","received_events_url":"https://api.github.com/users/unfoldingWord-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":65028237,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAyODIzNw==","name":"translationCore","full_name":"unfoldingWord-dev/translationCore","private":false,"owner":{"login":"unfoldingWord-dev","id":11397506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzk3NTA2","avatar_url":"https://avatars1.githubusercontent.com/u/11397506?v=4","gravatar_id":"","url":"https://api.github.com/users/unfoldingWord-dev","html_url":"https://github.com/unfoldingWord-dev","followers_url":"https://api.github.com/users/unfoldingWord-dev/followers","following_url":"https://api.github.com/users/unfoldingWord-dev/following{/other_user}","gists_url":"https://api.github.com/users/unfoldingWord-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/unfoldingWord-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfoldingWord-dev/subscriptions","organizations_url":"https://api.github.com/users/unfoldingWord-dev/orgs","repos_url":"https://api.github.com/users/unfoldingWord-dev/repos","events_url":"https://api.github.com/users/unfoldingWord-dev/events{/privacy}","received_events_url":"https://api.github.com/users/unfoldingWord-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unfoldingWord-dev/translationCore","description":"Repository for the desktop application translationCore","fork":false,"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","forks_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/forks","keys_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/teams","hooks_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/hooks","issue_events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/events{/number}","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/events","assignees_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/assignees{/user}","branches_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/branches{/branch}","tags_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/tags","blobs_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/statuses/{sha}","languages_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/languages","stargazers_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/stargazers","contributors_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/contributors","subscribers_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/subscribers","subscription_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/subscription","commits_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/contents/{+path}","compare_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/merges","archive_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/downloads","issues_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues{/number}","pulls_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls{/number}","milestones_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/milestones{/number}","notifications_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/labels{/name}","releases_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/releases{/id}","deployments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/deployments","created_at":"2016-08-05T15:14:53Z","updated_at":"2018-12-12T17:52:22Z","pushed_at":"2018-12-12T21:11:42Z","git_url":"git://github.com/unfoldingWord-dev/translationCore.git","ssh_url":"git@github.com:unfoldingWord-dev/translationCore.git","clone_url":"https://github.com/unfoldingWord-dev/translationCore.git","svn_url":"https://github.com/unfoldingWord-dev/translationCore","homepage":"","size":277152,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":523,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569"},"html":{"href":"https://github.com/unfoldingWord-dev/translationCore/pull/5569"},"issue":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5569"},"comments":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5569/comments"},"review_comments":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569/comments"},"review_comment":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5569/commits"},"statuses":{"href":"https://api.github.com/repos/unfoldingWord-dev/translationCore/statuses/51e87fac6765e5c24c5d0a4b5751bb7760217fdb"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":61,"deletions":105,"changed_files":9}}
{"actor":{"display_login":"RoyalSix"}}