{"action":"created","issue":{"url":"https://api.github.com/repos/RH-FMK/skt/issues/308","repository_url":"https://api.github.com/repos/RH-FMK/skt","labels_url":"https://api.github.com/repos/RH-FMK/skt/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/RH-FMK/skt/issues/308/comments","events_url":"https://api.github.com/repos/RH-FMK/skt/issues/308/events","html_url":"https://github.com/RH-FMK/skt/pull/308","id":347372576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDExOTU2","number":308,"title":"Support ordered mixture of merge arguments","user":{"login":"danghai","id":10912671,"node_id":"MDQ6VXNlcjEwOTEyNjcx","avatar_url":"https://avatars1.githubusercontent.com/u/10912671?v=4","gravatar_id":"","url":"https://api.github.com/users/danghai","html_url":"https://github.com/danghai","followers_url":"https://api.github.com/users/danghai/followers","following_url":"https://api.github.com/users/danghai/following{/other_user}","gists_url":"https://api.github.com/users/danghai/gists{/gist_id}","starred_url":"https://api.github.com/users/danghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danghai/subscriptions","organizations_url":"https://api.github.com/users/danghai/orgs","repos_url":"https://api.github.com/users/danghai/repos","events_url":"https://api.github.com/users/danghai/events{/privacy}","received_events_url":"https://api.github.com/users/danghai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2018-08-03T12:12:03Z","updated_at":"2018-08-24T09:04:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/RH-FMK/skt/pulls/308","html_url":"https://github.com/RH-FMK/skt/pull/308","diff_url":"https://github.com/RH-FMK/skt/pull/308.diff","patch_url":"https://github.com/RH-FMK/skt/pull/308.patch"},"body":"I make PR to support ordered mixture of merge arguments. It is my idea and first draft. \r\nBecause the optional argument for merge is not positional, so I introduce the `CustomAction` to get the order of merge option ( `--merge-ref`, `--patch` and `--pw`) . \r\nFor example:  \r\nif we use `--pw <PATCH1> --patch <PATCH2> --merge-ref <PATCH3> --pw <PATCH4>`\r\nThe `order_merge` stores the merge arguments by order. \r\n```\r\n[('pw', 'PATCH1'), ('patch', 'PATCH2'), ('merge-ref', 'PATCH3'), ('pw', 'PATCH4')]\r\n\r\n```\r\nI declare the `task` in `cmd_merge` following:\r\n```\r\ntask[0]: merge argument\r\ntask[1]: merge patch\r\nThe tasks will store: \r\n('pw', 'PATCH1')\r\n('patch', 'PATCH2')\r\n('merge-ref', 'PATCH3')\r\n('pw', 'PATCH4')\r\n```\r\nIt still needs to be enhanced by changing the `report_string` in order to get all information all patch. It also needs to fix the value `idx`. What do you think about this idea? Thanks"},"comment":{"url":"https://api.github.com/repos/RH-FMK/skt/issues/comments/415699788","html_url":"https://github.com/RH-FMK/skt/pull/308#issuecomment-415699788","issue_url":"https://api.github.com/repos/RH-FMK/skt/issues/308","id":415699788,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTY5OTc4OA==","user":{"login":"veruu","id":8031381,"node_id":"MDQ6VXNlcjgwMzEzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8031381?v=4","gravatar_id":"","url":"https://api.github.com/users/veruu","html_url":"https://github.com/veruu","followers_url":"https://api.github.com/users/veruu/followers","following_url":"https://api.github.com/users/veruu/following{/other_user}","gists_url":"https://api.github.com/users/veruu/gists{/gist_id}","starred_url":"https://api.github.com/users/veruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veruu/subscriptions","organizations_url":"https://api.github.com/users/veruu/orgs","repos_url":"https://api.github.com/users/veruu/repos","events_url":"https://api.github.com/users/veruu/events{/privacy}","received_events_url":"https://api.github.com/users/veruu/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T09:04:52Z","updated_at":"2018-08-24T09:04:52Z","author_association":"MEMBER","body":"I mean the thing you eg. changed in the tests - these old options are a) not a list of strings anymore and b) not used because we are iterating over `merge_queue` so it would be better to just not set them anymore and modify the tests that used them to check `merge_queue`. Is this explanation more clear?"}}
{"actor":{"display_login":"veruu"}}