{"action":"created","comment":{"url":"https://api.github.com/repos/derekparker/delve/pulls/comments/224866136","pull_request_review_id":164345035,"id":224866136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDg2NjEzNg==","diff_hunk":"@@ -114,15 +114,25 @@ func (scope *EvalScope) evalToplevelTypeCast(t ast.Expr, cfg LoadConfig) (*Varia\n \n \tcase \"string\":\n \t\tswitch argv.Kind {\n+\t\tcase reflect.String:\n+\t\t\ts := constant.StringVal(argv.Value)\n+\t\t\tv.Value = constant.MakeString(s)\n+\t\t\tv.Len = int64(len(s))\n+\t\t\treturn v, nil\n \t\tcase reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64, reflect.Int, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uint, reflect.Uintptr:\n \t\t\tb, _ := constant.Int64Val(argv.Value)\n \t\t\ts := string(b)\n \t\t\tv.Value = constant.MakeString(s)\n \t\t\tv.Len = int64(len(s))\n \t\t\treturn v, nil\n-\n-\t\tcase reflect.Slice:\n-\t\t\tswitch elemType := argv.RealType.(*godwarf.SliceType).ElemType.(type) {\n+\t\tcase reflect.Slice, reflect.Array:\n+\t\t\tvar elem interface{}","path":"pkg/proc/eval.go","position":19,"original_position":19,"commit_id":"3446d04170ce3a362eaedeb22ca1fb39e45c31c6","original_commit_id":"3446d04170ce3a362eaedeb22ca1fb39e45c31c6","user":{"login":"aarzilli","id":303620,"node_id":"MDQ6VXNlcjMwMzYyMA==","avatar_url":"https://avatars2.githubusercontent.com/u/303620?v=4","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"body":"You should be able to use `godwarf.Type` instead of `interface{}` here. I would prefer it because it's more specific.","created_at":"2018-10-12T17:47:19Z","updated_at":"2018-10-12T17:48:09Z","html_url":"https://github.com/derekparker/delve/pull/1372#discussion_r224866136","pull_request_url":"https://api.github.com/repos/derekparker/delve/pulls/1372","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments/224866136"},"html":{"href":"https://github.com/derekparker/delve/pull/1372#discussion_r224866136"},"pull_request":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1372"}}},"pull_request":{"url":"https://api.github.com/repos/derekparker/delve/pulls/1372","id":222532983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTMyOTgz","html_url":"https://github.com/derekparker/delve/pull/1372","diff_url":"https://github.com/derekparker/delve/pull/1372.diff","patch_url":"https://github.com/derekparker/delve/pull/1372.patch","issue_url":"https://api.github.com/repos/derekparker/delve/issues/1372","number":1372,"state":"open","locked":false,"title":"pkg/proc: extend conversion about `string` for array/str","user":{"login":"chainhelen","id":7046329,"node_id":"MDQ6VXNlcjcwNDYzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7046329?v=4","gravatar_id":"","url":"https://api.github.com/users/chainhelen","html_url":"https://github.com/chainhelen","followers_url":"https://api.github.com/users/chainhelen/followers","following_url":"https://api.github.com/users/chainhelen/following{/other_user}","gists_url":"https://api.github.com/users/chainhelen/gists{/gist_id}","starred_url":"https://api.github.com/users/chainhelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainhelen/subscriptions","organizations_url":"https://api.github.com/users/chainhelen/orgs","repos_url":"https://api.github.com/users/chainhelen/repos","events_url":"https://api.github.com/users/chainhelen/events{/privacy}","received_events_url":"https://api.github.com/users/chainhelen/received_events","type":"User","site_admin":false},"body":"Extend `string()`\r\n1.convert byte/rune array(not only slice) to string.\r\n2.convert string to string(itself), just like `string(str)` in go language.","created_at":"2018-10-12T17:19:35Z","updated_at":"2018-10-12T17:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a339f5bb9507764a6a1673574b65f511c7692930","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/derekparker/delve/pulls/1372/commits","review_comments_url":"https://api.github.com/repos/derekparker/delve/pulls/1372/comments","review_comment_url":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/derekparker/delve/issues/1372/comments","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/3446d04170ce3a362eaedeb22ca1fb39e45c31c6","head":{"label":"chainhelen:feature/optieval","ref":"feature/optieval","sha":"3446d04170ce3a362eaedeb22ca1fb39e45c31c6","user":{"login":"chainhelen","id":7046329,"node_id":"MDQ6VXNlcjcwNDYzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7046329?v=4","gravatar_id":"","url":"https://api.github.com/users/chainhelen","html_url":"https://github.com/chainhelen","followers_url":"https://api.github.com/users/chainhelen/followers","following_url":"https://api.github.com/users/chainhelen/following{/other_user}","gists_url":"https://api.github.com/users/chainhelen/gists{/gist_id}","starred_url":"https://api.github.com/users/chainhelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainhelen/subscriptions","organizations_url":"https://api.github.com/users/chainhelen/orgs","repos_url":"https://api.github.com/users/chainhelen/repos","events_url":"https://api.github.com/users/chainhelen/events{/privacy}","received_events_url":"https://api.github.com/users/chainhelen/received_events","type":"User","site_admin":false},"repo":{"id":148508331,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MDgzMzE=","name":"delve","full_name":"chainhelen/delve","private":false,"owner":{"login":"chainhelen","id":7046329,"node_id":"MDQ6VXNlcjcwNDYzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7046329?v=4","gravatar_id":"","url":"https://api.github.com/users/chainhelen","html_url":"https://github.com/chainhelen","followers_url":"https://api.github.com/users/chainhelen/followers","following_url":"https://api.github.com/users/chainhelen/following{/other_user}","gists_url":"https://api.github.com/users/chainhelen/gists{/gist_id}","starred_url":"https://api.github.com/users/chainhelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainhelen/subscriptions","organizations_url":"https://api.github.com/users/chainhelen/orgs","repos_url":"https://api.github.com/users/chainhelen/repos","events_url":"https://api.github.com/users/chainhelen/events{/privacy}","received_events_url":"https://api.github.com/users/chainhelen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chainhelen/delve","description":"Delve is a debugger for the Go programming language.","fork":true,"url":"https://api.github.com/repos/chainhelen/delve","forks_url":"https://api.github.com/repos/chainhelen/delve/forks","keys_url":"https://api.github.com/repos/chainhelen/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chainhelen/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chainhelen/delve/teams","hooks_url":"https://api.github.com/repos/chainhelen/delve/hooks","issue_events_url":"https://api.github.com/repos/chainhelen/delve/issues/events{/number}","events_url":"https://api.github.com/repos/chainhelen/delve/events","assignees_url":"https://api.github.com/repos/chainhelen/delve/assignees{/user}","branches_url":"https://api.github.com/repos/chainhelen/delve/branches{/branch}","tags_url":"https://api.github.com/repos/chainhelen/delve/tags","blobs_url":"https://api.github.com/repos/chainhelen/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chainhelen/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chainhelen/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/chainhelen/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chainhelen/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/chainhelen/delve/languages","stargazers_url":"https://api.github.com/repos/chainhelen/delve/stargazers","contributors_url":"https://api.github.com/repos/chainhelen/delve/contributors","subscribers_url":"https://api.github.com/repos/chainhelen/delve/subscribers","subscription_url":"https://api.github.com/repos/chainhelen/delve/subscription","commits_url":"https://api.github.com/repos/chainhelen/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/chainhelen/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/chainhelen/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/chainhelen/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/chainhelen/delve/contents/{+path}","compare_url":"https://api.github.com/repos/chainhelen/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chainhelen/delve/merges","archive_url":"https://api.github.com/repos/chainhelen/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chainhelen/delve/downloads","issues_url":"https://api.github.com/repos/chainhelen/delve/issues{/number}","pulls_url":"https://api.github.com/repos/chainhelen/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/chainhelen/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/chainhelen/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chainhelen/delve/labels{/name}","releases_url":"https://api.github.com/repos/chainhelen/delve/releases{/id}","deployments_url":"https://api.github.com/repos/chainhelen/delve/deployments","created_at":"2018-09-12T16:18:26Z","updated_at":"2018-10-09T05:58:45Z","pushed_at":"2018-10-12T17:17:19Z","git_url":"git://github.com/chainhelen/delve.git","ssh_url":"git@github.com:chainhelen/delve.git","clone_url":"https://github.com/chainhelen/delve.git","svn_url":"https://github.com/chainhelen/delve","homepage":"","size":18982,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"derekparker:master","ref":"master","sha":"74c98bc9616ad4ee324eb4d31717b61f4a6ab8ce","user":{"login":"derekparker","id":1314079,"node_id":"MDQ6VXNlcjEzMTQwNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":19994257,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk5NDI1Nw==","name":"delve","full_name":"derekparker/delve","private":false,"owner":{"login":"derekparker","id":1314079,"node_id":"MDQ6VXNlcjEzMTQwNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/derekparker/delve","description":"Delve is a debugger for the Go programming language.","fork":false,"url":"https://api.github.com/repos/derekparker/delve","forks_url":"https://api.github.com/repos/derekparker/delve/forks","keys_url":"https://api.github.com/repos/derekparker/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/delve/teams","hooks_url":"https://api.github.com/repos/derekparker/delve/hooks","issue_events_url":"https://api.github.com/repos/derekparker/delve/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/delve/events","assignees_url":"https://api.github.com/repos/derekparker/delve/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/delve/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/delve/tags","blobs_url":"https://api.github.com/repos/derekparker/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/delve/languages","stargazers_url":"https://api.github.com/repos/derekparker/delve/stargazers","contributors_url":"https://api.github.com/repos/derekparker/delve/contributors","subscribers_url":"https://api.github.com/repos/derekparker/delve/subscribers","subscription_url":"https://api.github.com/repos/derekparker/delve/subscription","commits_url":"https://api.github.com/repos/derekparker/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/delve/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/delve/merges","archive_url":"https://api.github.com/repos/derekparker/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/delve/downloads","issues_url":"https://api.github.com/repos/derekparker/delve/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/delve/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/delve/releases{/id}","deployments_url":"https://api.github.com/repos/derekparker/delve/deployments","created_at":"2014-05-20T19:24:43Z","updated_at":"2018-10-12T16:41:29Z","pushed_at":"2018-10-12T17:19:35Z","git_url":"git://github.com/derekparker/delve.git","ssh_url":"git@github.com:derekparker/delve.git","clone_url":"https://github.com/derekparker/delve.git","svn_url":"https://github.com/derekparker/delve","homepage":"","size":19473,"stargazers_count":9444,"watchers_count":9444,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":803,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":803,"open_issues":104,"watchers":9444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1372"},"html":{"href":"https://github.com/derekparker/delve/pull/1372"},"issue":{"href":"https://api.github.com/repos/derekparker/delve/issues/1372"},"comments":{"href":"https://api.github.com/repos/derekparker/delve/issues/1372/comments"},"review_comments":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1372/comments"},"review_comment":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1372/commits"},"statuses":{"href":"https://api.github.com/repos/derekparker/delve/statuses/3446d04170ce3a362eaedeb22ca1fb39e45c31c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aarzilli"}}