{"action":"created","comment":{"url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/comments/175839274","pull_request_review_id":105436392,"id":175839274,"diff_hunk":"@@ -8,6 +8,8 @@\n require 'faktory/job'\n require 'faktory/connection'\n \n+require 'active_job/queue_adapters/faktory_adapter'","path":"lib/faktory.rb","position":4,"original_position":4,"commit_id":"1684a1d8d3ae48287805eec8fd58a54ad797ffa9","original_commit_id":"1684a1d8d3ae48287805eec8fd58a54ad797ffa9","user":{"login":"jagthedrummer","id":58702,"avatar_url":"https://avatars2.githubusercontent.com/u/58702?v=4","gravatar_id":"","url":"https://api.github.com/users/jagthedrummer","html_url":"https://github.com/jagthedrummer","followers_url":"https://api.github.com/users/jagthedrummer/followers","following_url":"https://api.github.com/users/jagthedrummer/following{/other_user}","gists_url":"https://api.github.com/users/jagthedrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jagthedrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagthedrummer/subscriptions","organizations_url":"https://api.github.com/users/jagthedrummer/orgs","repos_url":"https://api.github.com/users/jagthedrummer/repos","events_url":"https://api.github.com/users/jagthedrummer/events{/privacy}","received_events_url":"https://api.github.com/users/jagthedrummer/received_events","type":"User","site_admin":false},"body":"Without this line my test rails app is unable to find the adapter and this happens when I try to queue a job.\r\n\r\n```\r\nNameError (uninitialized constant ActiveJob::QueueAdapters::FaktoryAdapter)\r\n```\r\n\r\nRails auto-loads the built in adapters like this: https://github.com/rails/rails/blob/master/activejob/lib/active_job/queue_adapters.rb#L112-L122\r\n\r\nI'm not sure how to accomplish something similar without causing AJ itself to load. Pointers appreciated.","created_at":"2018-03-20T16:42:27Z","updated_at":"2018-03-20T16:42:27Z","html_url":"https://github.com/contribsys/faktory_worker_ruby/pull/17#discussion_r175839274","pull_request_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/comments/175839274"},"html":{"href":"https://github.com/contribsys/faktory_worker_ruby/pull/17#discussion_r175839274"},"pull_request":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17"}},"in_reply_to_id":175828210},"pull_request":{"url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17","id":176090798,"html_url":"https://github.com/contribsys/faktory_worker_ruby/pull/17","diff_url":"https://github.com/contribsys/faktory_worker_ruby/pull/17.diff","patch_url":"https://github.com/contribsys/faktory_worker_ruby/pull/17.patch","issue_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/17","number":17,"state":"open","locked":false,"title":"ActiveJob Adapter","user":{"login":"jagthedrummer","id":58702,"avatar_url":"https://avatars2.githubusercontent.com/u/58702?v=4","gravatar_id":"","url":"https://api.github.com/users/jagthedrummer","html_url":"https://github.com/jagthedrummer","followers_url":"https://api.github.com/users/jagthedrummer/followers","following_url":"https://api.github.com/users/jagthedrummer/following{/other_user}","gists_url":"https://api.github.com/users/jagthedrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jagthedrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagthedrummer/subscriptions","organizations_url":"https://api.github.com/users/jagthedrummer/orgs","repos_url":"https://api.github.com/users/jagthedrummer/repos","events_url":"https://api.github.com/users/jagthedrummer/events{/privacy}","received_events_url":"https://api.github.com/users/jagthedrummer/received_events","type":"User","site_admin":false},"body":"This adds an adapter for `ActiveJob` and some very basic tests.\r\n\r\nPossible points of concern:\r\n1. New dependency on `activejob`, which seems... not quite right. Is there a better way to handle this?\r\n2. Tests may be too basic. The tests in the AJ suite are fairly extensive, but it seemed like overkill to bring in all of that...\r\n\r\nWould love to hear thoughts/suggestions/criticisms on this.\r\n\r\nFixes #15 ","created_at":"2018-03-20T05:12:32Z","updated_at":"2018-03-20T16:42:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c318c04d1e59c8c74179baae520816fd590b4b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17/commits","review_comments_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17/comments","review_comment_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/17/comments","statuses_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/statuses/1684a1d8d3ae48287805eec8fd58a54ad797ffa9","head":{"label":"jagthedrummer:jeremy/aj_adapter","ref":"jeremy/aj_adapter","sha":"1684a1d8d3ae48287805eec8fd58a54ad797ffa9","user":{"login":"jagthedrummer","id":58702,"avatar_url":"https://avatars2.githubusercontent.com/u/58702?v=4","gravatar_id":"","url":"https://api.github.com/users/jagthedrummer","html_url":"https://github.com/jagthedrummer","followers_url":"https://api.github.com/users/jagthedrummer/followers","following_url":"https://api.github.com/users/jagthedrummer/following{/other_user}","gists_url":"https://api.github.com/users/jagthedrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jagthedrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagthedrummer/subscriptions","organizations_url":"https://api.github.com/users/jagthedrummer/orgs","repos_url":"https://api.github.com/users/jagthedrummer/repos","events_url":"https://api.github.com/users/jagthedrummer/events{/privacy}","received_events_url":"https://api.github.com/users/jagthedrummer/received_events","type":"User","site_admin":false},"repo":{"id":121467153,"name":"faktory_worker_ruby","full_name":"jagthedrummer/faktory_worker_ruby","owner":{"login":"jagthedrummer","id":58702,"avatar_url":"https://avatars2.githubusercontent.com/u/58702?v=4","gravatar_id":"","url":"https://api.github.com/users/jagthedrummer","html_url":"https://github.com/jagthedrummer","followers_url":"https://api.github.com/users/jagthedrummer/followers","following_url":"https://api.github.com/users/jagthedrummer/following{/other_user}","gists_url":"https://api.github.com/users/jagthedrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jagthedrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagthedrummer/subscriptions","organizations_url":"https://api.github.com/users/jagthedrummer/orgs","repos_url":"https://api.github.com/users/jagthedrummer/repos","events_url":"https://api.github.com/users/jagthedrummer/events{/privacy}","received_events_url":"https://api.github.com/users/jagthedrummer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagthedrummer/faktory_worker_ruby","description":"Faktory worker for Ruby","fork":true,"url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby","forks_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/forks","keys_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/teams","hooks_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/hooks","issue_events_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/events","assignees_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/tags","blobs_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/languages","stargazers_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/stargazers","contributors_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/contributors","subscribers_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/subscribers","subscription_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/subscription","commits_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/merges","archive_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/downloads","issues_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/labels{/name}","releases_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jagthedrummer/faktory_worker_ruby/deployments","created_at":"2018-02-14T03:39:25Z","updated_at":"2018-02-14T03:39:27Z","pushed_at":"2018-03-20T04:58:18Z","git_url":"git://github.com/jagthedrummer/faktory_worker_ruby.git","ssh_url":"git@github.com:jagthedrummer/faktory_worker_ruby.git","clone_url":"https://github.com/jagthedrummer/faktory_worker_ruby.git","svn_url":"https://github.com/jagthedrummer/faktory_worker_ruby","homepage":"","size":78,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contribsys:master","ref":"master","sha":"218c80bf6e8606dadb8ee4d52a82ef5e57264a6e","user":{"login":"contribsys","id":8095822,"avatar_url":"https://avatars1.githubusercontent.com/u/8095822?v=4","gravatar_id":"","url":"https://api.github.com/users/contribsys","html_url":"https://github.com/contribsys","followers_url":"https://api.github.com/users/contribsys/followers","following_url":"https://api.github.com/users/contribsys/following{/other_user}","gists_url":"https://api.github.com/users/contribsys/gists{/gist_id}","starred_url":"https://api.github.com/users/contribsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contribsys/subscriptions","organizations_url":"https://api.github.com/users/contribsys/orgs","repos_url":"https://api.github.com/users/contribsys/repos","events_url":"https://api.github.com/users/contribsys/events{/privacy}","received_events_url":"https://api.github.com/users/contribsys/received_events","type":"Organization","site_admin":false},"repo":{"id":99734601,"name":"faktory_worker_ruby","full_name":"contribsys/faktory_worker_ruby","owner":{"login":"contribsys","id":8095822,"avatar_url":"https://avatars1.githubusercontent.com/u/8095822?v=4","gravatar_id":"","url":"https://api.github.com/users/contribsys","html_url":"https://github.com/contribsys","followers_url":"https://api.github.com/users/contribsys/followers","following_url":"https://api.github.com/users/contribsys/following{/other_user}","gists_url":"https://api.github.com/users/contribsys/gists{/gist_id}","starred_url":"https://api.github.com/users/contribsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contribsys/subscriptions","organizations_url":"https://api.github.com/users/contribsys/orgs","repos_url":"https://api.github.com/users/contribsys/repos","events_url":"https://api.github.com/users/contribsys/events{/privacy}","received_events_url":"https://api.github.com/users/contribsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contribsys/faktory_worker_ruby","description":"Faktory worker for Ruby","fork":false,"url":"https://api.github.com/repos/contribsys/faktory_worker_ruby","forks_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/forks","keys_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/teams","hooks_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/hooks","issue_events_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/events{/number}","events_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/events","assignees_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/assignees{/user}","branches_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/branches{/branch}","tags_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/tags","blobs_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/languages","stargazers_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/stargazers","contributors_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/contributors","subscribers_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/subscribers","subscription_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/subscription","commits_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/contents/{+path}","compare_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/merges","archive_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/downloads","issues_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues{/number}","pulls_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/labels{/name}","releases_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/releases{/id}","deployments_url":"https://api.github.com/repos/contribsys/faktory_worker_ruby/deployments","created_at":"2017-08-08T20:44:19Z","updated_at":"2018-03-19T21:55:47Z","pushed_at":"2018-03-20T05:12:33Z","git_url":"git://github.com/contribsys/faktory_worker_ruby.git","ssh_url":"git@github.com:contribsys/faktory_worker_ruby.git","clone_url":"https://github.com/contribsys/faktory_worker_ruby.git","svn_url":"https://github.com/contribsys/faktory_worker_ruby","homepage":"","size":66,"stargazers_count":124,"watchers_count":124,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":11,"open_issues":4,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17"},"html":{"href":"https://github.com/contribsys/faktory_worker_ruby/pull/17"},"issue":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/17"},"comments":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/contribsys/faktory_worker_ruby/statuses/1684a1d8d3ae48287805eec8fd58a54ad797ffa9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jagthedrummer"}}