{"action":"created","issue":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/3472","repository_url":"https://api.github.com/repos/go-gitea/gitea","labels_url":"https://api.github.com/repos/go-gitea/gitea/issues/3472/labels{/name}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/3472/comments","events_url":"https://api.github.com/repos/go-gitea/gitea/issues/3472/events","html_url":"https://github.com/go-gitea/gitea/issues/3472","id":295355313,"number":3472,"title":"`api/v1/repos/:owner/:repo/pulls/***` not implemented","user":{"login":"bkcsoft","id":4726179,"avatar_url":"https://avatars0.githubusercontent.com/u/4726179?v=4","gravatar_id":"","url":"https://api.github.com/users/bkcsoft","html_url":"https://github.com/bkcsoft","followers_url":"https://api.github.com/users/bkcsoft/followers","following_url":"https://api.github.com/users/bkcsoft/following{/other_user}","gists_url":"https://api.github.com/users/bkcsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bkcsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkcsoft/subscriptions","organizations_url":"https://api.github.com/users/bkcsoft/orgs","repos_url":"https://api.github.com/users/bkcsoft/repos","events_url":"https://api.github.com/users/bkcsoft/events{/privacy}","received_events_url":"https://api.github.com/users/bkcsoft/received_events","type":"User","site_admin":false},"labels":[{"id":512094145,"url":"https://api.github.com/repos/go-gitea/gitea/labels/kind/api","name":"kind/api","color":"5319e7","default":false},{"id":608693925,"url":"https://api.github.com/repos/go-gitea/gitea/labels/kind/regression","name":"kind/regression","color":"c92f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-08T01:36:30Z","updated_at":"2018-04-23T16:43:37Z","closed_at":null,"author_association":"OWNER","body":"- Gitea version (or commit ref): ffd0062438a07dff73c949a0a963e62c5a29abf8\r\n- Git version: N/A\r\n- Operating system: N/A\r\n- Can you reproduce the bug at https://try.gitea.io:\r\n  - [x] Yes (provide example URL): https://try.gitea.io/api/v1/repos/gitea/gitea/pulls/5/comments/\r\n  - [ ] No\r\n  - [ ] Not relevant\r\n\r\nSeems like we don't have `/pulls`-endpoints implemented at all. I do remember them being implemented before though so they must've been removed in a refactor some time ago.\r\n\r\nThe following outputs are both for the same PR `#5`\r\n```sh\r\n$ curl https://try.gitea.io/api/v1/repos/gitea/gitea/issues/5/comments/ | jq .\r\n[\r\n  {\r\n    \"id\": 2059,\r\n    \"html_url\": \"https://try.gitea.io/gitea/gitea/pulls/5#issuecomment-2059\",\r\n    \"pull_request_url\": \"https://try.gitea.io/gitea/gitea/pulls/5\",\r\n    \"issue_url\": \"\",\r\n    \"user\": {\r\n      \"id\": 4,\r\n      \"login\": \"bkc\",\r\n      \"full_name\": \"Kim \\\"BKC\\\" Carlbäcker\",\r\n      \"email\": \"kim.carlbacker@gmail.com\",\r\n      \"avatar_url\": \"https://secure.gravatar.com/avatar/d05dbfb80d6b9a461cd4578f18709a83?d=identicon\",\r\n      \"username\": \"bkc\"\r\n    },\r\n    \"body\": \"Foobar\",\r\n    \"created_at\": \"2018-02-08T01:32:01Z\",\r\n    \"updated_at\": \"2018-02-08T01:32:01Z\"\r\n  }\r\n]\r\n```\r\n```sh\r\n$ curl -v https://try.gitea.io/api/v1/repos/gitea/gitea/pulls/5/comments/\r\n[...]\r\n> GET /api/v1/repos/gitea/gitea/pulls/5/comments/ HTTP/2\r\n> Host: try.gitea.io\r\n> User-Agent: curl/7.58.0\r\n> Accept: */*\r\n> \r\n* Connection state changed (MAX_CONCURRENT_STREAMS updated)!\r\n< HTTP/2 404 \r\n< content-type: text/plain; charset=utf-8\r\n< date: Thu, 08 Feb 2018 01:35:09 GMT\r\n< set-cookie: lang=en-US; Path=/; Max-Age=2147483647\r\n< set-cookie: i_like_gitea=f71a34e0b91ce9db; Path=/; HttpOnly\r\n< set-cookie: _csrf=RSpu7TlGgDC_5rh6Fw5QyPEkcUI6MTUxODA1MzcwOTExNDM2MzQwNg%3D%3D; Path=/; Expires=Fri, 09 Feb 2018 01:35:09 GMT; HttpOnly\r\n< x-frame-options: SAMEORIGIN\r\n< content-length: 0\r\n< \r\n```"},"comment":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/comments/383642754","html_url":"https://github.com/go-gitea/gitea/issues/3472#issuecomment-383642754","issue_url":"https://api.github.com/repos/go-gitea/gitea/issues/3472","id":383642754,"user":{"login":"Dunky13","id":991668,"avatar_url":"https://avatars2.githubusercontent.com/u/991668?v=4","gravatar_id":"","url":"https://api.github.com/users/Dunky13","html_url":"https://github.com/Dunky13","followers_url":"https://api.github.com/users/Dunky13/followers","following_url":"https://api.github.com/users/Dunky13/following{/other_user}","gists_url":"https://api.github.com/users/Dunky13/gists{/gist_id}","starred_url":"https://api.github.com/users/Dunky13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dunky13/subscriptions","organizations_url":"https://api.github.com/users/Dunky13/orgs","repos_url":"https://api.github.com/users/Dunky13/repos","events_url":"https://api.github.com/users/Dunky13/events{/privacy}","received_events_url":"https://api.github.com/users/Dunky13/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T16:43:36Z","updated_at":"2018-04-23T16:43:36Z","author_association":"NONE","body":"Looking at the api folder: `routers/api/v1`/repo/` you see the files `issue.go` & `issue_comment.go`\r\n\r\nI'd expect the same for pull: `pull.go` & `pull_comment.go`\r\n\r\nBut the latter doesn't exist, and when searching through the history using:\r\n\r\n`git log --stat --all --full-history -- routers/api/v1/repo/pull.*` it only shows `pull.go` as the only edited file.\r\n\r\nIf the `pull`-endpoints were implemented, then they weren't implemented the same way as `issue`-endpoints."}}
{"actor":{"display_login":"Dunky13"}}