{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/169444011","pull_request_review_id":97971110,"id":169444011,"diff_hunk":"@@ -633,6 +637,28 @@ namespace detail {\n     return false;\n   }\n \n+  boost::optional<AirflowNetworkDistributionNode> AirLoopHVACOutdoorAirSystem_Impl::createAirflowNetworkDistributionNode()\n+  {\n+    boost::optional<AirflowNetworkDistributionNode> opt = airflowNetworkDistributionNode();\n+    if (opt) {\n+      return boost::none;\n+    }\n+    return AirflowNetworkDistributionNode(model(), handle());\n+  }\n+\n+  boost::optional<AirflowNetworkDistributionNode> AirLoopHVACOutdoorAirSystem_Impl::airflowNetworkDistributionNode() const\n+  {\n+    std::vector<AirflowNetworkDistributionNode> myAFNItems = getObject<ModelObject>().getModelObjectSources<AirflowNetworkDistributionNode>(AirflowNetworkDistributionNode::iddObjectType());\n+    auto count = myAFNItems.size();\n+    if (count == 1) {\n+      return myAFNItems[0];\n+    } else if (count > 1) {\n+      LOG(Warn, briefDescription() << \" has more than one AirflowNetwork DistributionNode attached, returning first.\");","path":"openstudiocore/src/model/AirLoopHVACOutdoorAirSystem.cpp","position":38,"original_position":38,"commit_id":"446a0ec3cb45a3f45ae6aa8ef533a3b159a78b9c","original_commit_id":"446a0ec3cb45a3f45ae6aa8ef533a3b159a78b9c","user":{"login":"macumber","id":1327850,"avatar_url":"https://avatars3.githubusercontent.com/u/1327850?v=4","gravatar_id":"","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false},"body":"An example of where a JSON format could help....","created_at":"2018-02-20T20:10:15Z","updated_at":"2018-02-20T20:10:15Z","html_url":"https://github.com/NREL/OpenStudio/pull/2747#discussion_r169444011","pull_request_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments/169444011"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/2747#discussion_r169444011"},"pull_request":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747"}},"in_reply_to_id":169439599},"pull_request":{"url":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747","id":137565809,"html_url":"https://github.com/NREL/OpenStudio/pull/2747","diff_url":"https://github.com/NREL/OpenStudio/pull/2747.diff","patch_url":"https://github.com/NREL/OpenStudio/pull/2747.patch","issue_url":"https://api.github.com/repos/NREL/OpenStudio/issues/2747","number":2747,"state":"open","locked":false,"title":"AirflowNetwork Support","user":{"login":"jasondegraw","id":4623433,"avatar_url":"https://avatars2.githubusercontent.com/u/4623433?v=4","gravatar_id":"","url":"https://api.github.com/users/jasondegraw","html_url":"https://github.com/jasondegraw","followers_url":"https://api.github.com/users/jasondegraw/followers","following_url":"https://api.github.com/users/jasondegraw/following{/other_user}","gists_url":"https://api.github.com/users/jasondegraw/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondegraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondegraw/subscriptions","organizations_url":"https://api.github.com/users/jasondegraw/orgs","repos_url":"https://api.github.com/users/jasondegraw/repos","events_url":"https://api.github.com/users/jasondegraw/events{/privacy}","received_events_url":"https://api.github.com/users/jasondegraw/received_events","type":"User","site_admin":false},"body":"This pull request adds support for most of AirflowNetwork. There are a few parts that are not wrapped because of connections to other E+ features that are not wrapped (e.g. RoomAir). There are a few more challenges yet, but after consultation with @macumber I'm submitting this now to get feedback.","created_at":"2017-08-24T22:31:30Z","updated_at":"2018-02-20T20:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a271c34167309e246e8425ab5adbe981f71d3b12","assignee":{"login":"macumber","id":1327850,"avatar_url":"https://avatars3.githubusercontent.com/u/1327850?v=4","gravatar_id":"","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false},"assignees":[{"login":"macumber","id":1327850,"avatar_url":"https://avatars3.githubusercontent.com/u/1327850?v=4","gravatar_id":"","url":"https://api.github.com/users/macumber","html_url":"https://github.com/macumber","followers_url":"https://api.github.com/users/macumber/followers","following_url":"https://api.github.com/users/macumber/following{/other_user}","gists_url":"https://api.github.com/users/macumber/gists{/gist_id}","starred_url":"https://api.github.com/users/macumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macumber/subscriptions","organizations_url":"https://api.github.com/users/macumber/orgs","repos_url":"https://api.github.com/users/macumber/repos","events_url":"https://api.github.com/users/macumber/events{/privacy}","received_events_url":"https://api.github.com/users/macumber/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nmerket","id":5325034,"avatar_url":"https://avatars2.githubusercontent.com/u/5325034?v=4","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},{"login":"shorowit","id":5861765,"avatar_url":"https://avatars2.githubusercontent.com/u/5861765?v=4","gravatar_id":"","url":"https://api.github.com/users/shorowit","html_url":"https://github.com/shorowit","followers_url":"https://api.github.com/users/shorowit/followers","following_url":"https://api.github.com/users/shorowit/following{/other_user}","gists_url":"https://api.github.com/users/shorowit/gists{/gist_id}","starred_url":"https://api.github.com/users/shorowit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shorowit/subscriptions","organizations_url":"https://api.github.com/users/shorowit/orgs","repos_url":"https://api.github.com/users/shorowit/repos","events_url":"https://api.github.com/users/shorowit/events{/privacy}","received_events_url":"https://api.github.com/users/shorowit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747/commits","review_comments_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747/comments","review_comment_url":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/issues/2747/comments","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/446a0ec3cb45a3f45ae6aa8ef533a3b159a78b9c","head":{"label":"NREL:AFN2017","ref":"AFN2017","sha":"446a0ec3cb45a3f45ae6aa8ef533a3b159a78b9c","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"name":"OpenStudio","full_name":"NREL/OpenStudio","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/OpenStudio/deployments","created_at":"2013-07-03T19:34:37Z","updated_at":"2018-02-18T22:11:32Z","pushed_at":"2018-02-20T19:45:56Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":282555,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":514,"license":null,"forks":107,"open_issues":514,"watchers":178,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"490d4c737151c1ce115d338d4fd7a3630922a67d","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":11159552,"name":"OpenStudio","full_name":"NREL/OpenStudio","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/OpenStudio","description":"OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.","fork":false,"url":"https://api.github.com/repos/NREL/OpenStudio","forks_url":"https://api.github.com/repos/NREL/OpenStudio/forks","keys_url":"https://api.github.com/repos/NREL/OpenStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/OpenStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/OpenStudio/teams","hooks_url":"https://api.github.com/repos/NREL/OpenStudio/hooks","issue_events_url":"https://api.github.com/repos/NREL/OpenStudio/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/OpenStudio/events","assignees_url":"https://api.github.com/repos/NREL/OpenStudio/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/OpenStudio/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/OpenStudio/tags","blobs_url":"https://api.github.com/repos/NREL/OpenStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/OpenStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/OpenStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/OpenStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/OpenStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/OpenStudio/languages","stargazers_url":"https://api.github.com/repos/NREL/OpenStudio/stargazers","contributors_url":"https://api.github.com/repos/NREL/OpenStudio/contributors","subscribers_url":"https://api.github.com/repos/NREL/OpenStudio/subscribers","subscription_url":"https://api.github.com/repos/NREL/OpenStudio/subscription","commits_url":"https://api.github.com/repos/NREL/OpenStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/OpenStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/OpenStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/OpenStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/OpenStudio/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/OpenStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/OpenStudio/merges","archive_url":"https://api.github.com/repos/NREL/OpenStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/OpenStudio/downloads","issues_url":"https://api.github.com/repos/NREL/OpenStudio/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/OpenStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/OpenStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/OpenStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/OpenStudio/labels{/name}","releases_url":"https://api.github.com/repos/NREL/OpenStudio/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/OpenStudio/deployments","created_at":"2013-07-03T19:34:37Z","updated_at":"2018-02-18T22:11:32Z","pushed_at":"2018-02-20T19:45:56Z","git_url":"git://github.com/NREL/OpenStudio.git","ssh_url":"git@github.com:NREL/OpenStudio.git","clone_url":"https://github.com/NREL/OpenStudio.git","svn_url":"https://github.com/NREL/OpenStudio","homepage":"https://www.openstudio.net/","size":282555,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":514,"license":null,"forks":107,"open_issues":514,"watchers":178,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747"},"html":{"href":"https://github.com/NREL/OpenStudio/pull/2747"},"issue":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/2747"},"comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/issues/2747/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/OpenStudio/pulls/2747/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/OpenStudio/statuses/446a0ec3cb45a3f45ae6aa8ef533a3b159a78b9c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"macumber"}}