{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39","id":216922473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTIyNDcz","html_url":"https://github.com/davidshare/Fast-Food-Fast/pull/39","diff_url":"https://github.com/davidshare/Fast-Food-Fast/pull/39.diff","patch_url":"https://github.com/davidshare/Fast-Food-Fast/pull/39.patch","issue_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/39","number":39,"state":"closed","locked":false,"title":"#160646442 Refactor signup route to use database","user":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nRefactor signup route to use database\r\n\r\n#### Description of Task to be completed?\r\n- install jsonwebtoken\r\n- refactor the signup method in UsersController to use database\r\n- split the signup method into three parts to improve maintainability\r\n- create password helper file for encrypting and comparing passwords\r\n- create a token helper file for generating and decoding a token\r\n- change check for duplicate email in userValidator to use database\r\n- change primary key column in tables to use SERIAL instead of INTEGER\r\n\r\n#### How should this be manually tested?\r\n- clone the repo and navigate to the root directory using the command line\r\n- on the command line type npm install to install the node modules\r\n- on the command line, type 'npm run test'\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#160646442](https://www.pivotaltracker.com/story/show/160646442)\r\n","created_at":"2018-09-20T10:33:00Z","updated_at":"2018-09-20T12:52:45Z","closed_at":"2018-09-20T12:52:45Z","merged_at":"2018-09-20T12:52:45Z","merge_commit_sha":"b9035853bbdf0d20f9a4aa6e1070e9690b4a0d68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39/commits","review_comments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39/comments","review_comment_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/39/comments","statuses_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/statuses/2e399ee35f6f91357c492afd4f218e418b0d2f82","head":{"label":"davidshare:ch-signup-db-160646442","ref":"ch-signup-db-160646442","sha":"2e399ee35f6f91357c492afd4f218e418b0d2f82","user":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"repo":{"id":147880868,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4ODA4Njg=","name":"Fast-Food-Fast","full_name":"davidshare/Fast-Food-Fast","private":false,"owner":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidshare/Fast-Food-Fast","description":null,"fork":false,"url":"https://api.github.com/repos/davidshare/Fast-Food-Fast","forks_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/forks","keys_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/teams","hooks_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/hooks","issue_events_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/events{/number}","events_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/events","assignees_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/assignees{/user}","branches_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/branches{/branch}","tags_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/tags","blobs_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/statuses/{sha}","languages_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/languages","stargazers_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/stargazers","contributors_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/contributors","subscribers_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/subscribers","subscription_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/subscription","commits_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/contents/{+path}","compare_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/merges","archive_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/downloads","issues_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues{/number}","pulls_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls{/number}","milestones_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/milestones{/number}","notifications_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/labels{/name}","releases_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/releases{/id}","deployments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/deployments","created_at":"2018-09-07T22:32:48Z","updated_at":"2018-09-20T06:35:12Z","pushed_at":"2018-09-20T12:52:45Z","git_url":"git://github.com/davidshare/Fast-Food-Fast.git","ssh_url":"git@github.com:davidshare/Fast-Food-Fast.git","clone_url":"https://github.com/davidshare/Fast-Food-Fast.git","svn_url":"https://github.com/davidshare/Fast-Food-Fast","homepage":null,"size":3663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"davidshare:develop","ref":"develop","sha":"8eccd3d7854f94358e9cf44fb650305011fff8ce","user":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"repo":{"id":147880868,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4ODA4Njg=","name":"Fast-Food-Fast","full_name":"davidshare/Fast-Food-Fast","private":false,"owner":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidshare/Fast-Food-Fast","description":null,"fork":false,"url":"https://api.github.com/repos/davidshare/Fast-Food-Fast","forks_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/forks","keys_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/teams","hooks_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/hooks","issue_events_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/events{/number}","events_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/events","assignees_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/assignees{/user}","branches_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/branches{/branch}","tags_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/tags","blobs_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/statuses/{sha}","languages_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/languages","stargazers_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/stargazers","contributors_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/contributors","subscribers_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/subscribers","subscription_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/subscription","commits_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/contents/{+path}","compare_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/merges","archive_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/downloads","issues_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues{/number}","pulls_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls{/number}","milestones_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/milestones{/number}","notifications_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/labels{/name}","releases_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/releases{/id}","deployments_url":"https://api.github.com/repos/davidshare/Fast-Food-Fast/deployments","created_at":"2018-09-07T22:32:48Z","updated_at":"2018-09-20T06:35:12Z","pushed_at":"2018-09-20T12:52:45Z","git_url":"git://github.com/davidshare/Fast-Food-Fast.git","ssh_url":"git@github.com:davidshare/Fast-Food-Fast.git","clone_url":"https://github.com/davidshare/Fast-Food-Fast.git","svn_url":"https://github.com/davidshare/Fast-Food-Fast","homepage":null,"size":3663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39"},"html":{"href":"https://github.com/davidshare/Fast-Food-Fast/pull/39"},"issue":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/39"},"comments":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/davidshare/Fast-Food-Fast/statuses/2e399ee35f6f91357c492afd4f218e418b0d2f82"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davidshare","id":25446108,"node_id":"MDQ6VXNlcjI1NDQ2MTA4","avatar_url":"https://avatars1.githubusercontent.com/u/25446108?v=4","gravatar_id":"","url":"https://api.github.com/users/davidshare","html_url":"https://github.com/davidshare","followers_url":"https://api.github.com/users/davidshare/followers","following_url":"https://api.github.com/users/davidshare/following{/other_user}","gists_url":"https://api.github.com/users/davidshare/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshare/subscriptions","organizations_url":"https://api.github.com/users/davidshare/orgs","repos_url":"https://api.github.com/users/davidshare/repos","events_url":"https://api.github.com/users/davidshare/events{/privacy}","received_events_url":"https://api.github.com/users/davidshare/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":209,"deletions":33,"changed_files":7}}
{"actor":{"display_login":"davidshare"}}