{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/174916018","pull_request_review_id":104358480,"id":174916018,"diff_hunk":"@@ -16,6 +14,16 @@\n   ],\n \n   parts(namespace):: {\n+    jupyterHubConfigMap(jupyterHubAuthenticator, disks): {\n+      local util = import \"kubeflow/core/util.libsonnet\",\n+      local diskNames = util.toArray(disks),\n+      local kubeSpawner = $.parts(namespace).kubeSpawner(jupyterHubAuthenticator, diskNames),\n+      local cm = if std.length(diskNames) == 0 then\n+        $.parts(namespace).jupyterHubConfigMapWithoutVolumes","path":"kubeflow/core/jupyterhub.libsonnet","position":22,"original_position":22,"commit_id":"bee3a4058b04ab369d7624f2bf99ccc239b77c3c","original_commit_id":"bee3a4058b04ab369d7624f2bf99ccc239b77c3c","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"body":"jupyterHubConfigMapWithoutVolumes takes a parameter named spawner, but here you are not passing any parameter to jupyterHubConfigMapWithoutVolumes","created_at":"2018-03-15T20:08:53Z","updated_at":"2018-03-15T20:09:01Z","html_url":"https://github.com/kubeflow/kubeflow/pull/431#discussion_r174916018","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/174916018"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/431#discussion_r174916018"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431","id":175272032,"html_url":"https://github.com/kubeflow/kubeflow/pull/431","diff_url":"https://github.com/kubeflow/kubeflow/pull/431.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/431.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/431","number":431,"state":"open","locked":false,"title":"Libsonnet cleanup","user":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"body":"/assign @ankushagarwal \r\n\r\nfixes #417\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/431)\n<!-- Reviewable:end -->\n","created_at":"2018-03-15T14:41:16Z","updated_at":"2018-03-15T20:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efcc7b85aecf62907e76052de3bb5b3bb2e2cf6d","assignee":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"assignees":[{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Jimexist","id":622789,"avatar_url":"https://avatars1.githubusercontent.com/u/622789?v=4","gravatar_id":"","url":"https://api.github.com/users/Jimexist","html_url":"https://github.com/Jimexist","followers_url":"https://api.github.com/users/Jimexist/followers","following_url":"https://api.github.com/users/Jimexist/following{/other_user}","gists_url":"https://api.github.com/users/Jimexist/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimexist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimexist/subscriptions","organizations_url":"https://api.github.com/users/Jimexist/orgs","repos_url":"https://api.github.com/users/Jimexist/repos","events_url":"https://api.github.com/users/Jimexist/events{/privacy}","received_events_url":"https://api.github.com/users/Jimexist/received_events","type":"User","site_admin":false},{"login":"zjj2wry","id":18045633,"avatar_url":"https://avatars2.githubusercontent.com/u/18045633?v=4","gravatar_id":"","url":"https://api.github.com/users/zjj2wry","html_url":"https://github.com/zjj2wry","followers_url":"https://api.github.com/users/zjj2wry/followers","following_url":"https://api.github.com/users/zjj2wry/following{/other_user}","gists_url":"https://api.github.com/users/zjj2wry/gists{/gist_id}","starred_url":"https://api.github.com/users/zjj2wry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjj2wry/subscriptions","organizations_url":"https://api.github.com/users/zjj2wry/orgs","repos_url":"https://api.github.com/users/zjj2wry/repos","events_url":"https://api.github.com/users/zjj2wry/events{/privacy}","received_events_url":"https://api.github.com/users/zjj2wry/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/431/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/bee3a4058b04ab369d7624f2bf99ccc239b77c3c","head":{"label":"kkasravi:libsonnet_cleanup","ref":"libsonnet_cleanup","sha":"bee3a4058b04ab369d7624f2bf99ccc239b77c3c","user":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"repo":{"id":121746119,"name":"kubeflow","full_name":"kkasravi/kubeflow","owner":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars2.githubusercontent.com/u/146453?v=4","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkasravi/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/kkasravi/kubeflow","forks_url":"https://api.github.com/repos/kkasravi/kubeflow/forks","keys_url":"https://api.github.com/repos/kkasravi/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkasravi/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkasravi/kubeflow/teams","hooks_url":"https://api.github.com/repos/kkasravi/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kkasravi/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kkasravi/kubeflow/events","assignees_url":"https://api.github.com/repos/kkasravi/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kkasravi/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kkasravi/kubeflow/tags","blobs_url":"https://api.github.com/repos/kkasravi/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkasravi/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkasravi/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkasravi/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkasravi/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kkasravi/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kkasravi/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kkasravi/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kkasravi/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kkasravi/kubeflow/subscription","commits_url":"https://api.github.com/repos/kkasravi/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkasravi/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkasravi/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkasravi/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkasravi/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kkasravi/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkasravi/kubeflow/merges","archive_url":"https://api.github.com/repos/kkasravi/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkasravi/kubeflow/downloads","issues_url":"https://api.github.com/repos/kkasravi/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kkasravi/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kkasravi/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kkasravi/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkasravi/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kkasravi/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kkasravi/kubeflow/deployments","created_at":"2018-02-16T12:01:31Z","updated_at":"2018-02-16T12:01:33Z","pushed_at":"2018-03-15T15:01:05Z","git_url":"git://github.com/kkasravi/kubeflow.git","ssh_url":"git@github.com:kkasravi/kubeflow.git","clone_url":"https://github.com/kkasravi/kubeflow.git","svn_url":"https://github.com/kkasravi/kubeflow","homepage":"","size":100208,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"79a4c3736efb4d3713bbc957eed05c4db3ee8ecd","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-03-15T18:53:29Z","pushed_at":"2018-03-15T19:54:39Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":100602,"stargazers_count":2776,"watchers_count":2776,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":307,"open_issues":154,"watchers":2776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/431"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/431"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/bee3a4058b04ab369d7624f2bf99ccc239b77c3c"}},"author_association":"NONE"}}
{"actor":{"display_login":"ankushagarwal"}}