{"action":"created","comment":{"url":"https://api.github.com/repos/xodio/xod/pulls/comments/216237516","pull_request_review_id":153670054,"id":216237516,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIzNzUxNg==","diff_hunk":"@@ -0,0 +1,22 @@\n+struct State {\n+};\n+\n+struct Type {\n+    TwoWire* wire;\n+    uint8_t addr;\n+};\n+\n+// clang-format off\n+{{ GENERATED_CODE }}\n+// clang-format on\n+\n+void evaluate(Context ctx) {\n+    auto addr = getValue<input_ADDR>(ctx);\n+    auto Wire = getValue<input_I2C>(ctx);\n+\n+    Type dev;\n+    dev.addr = addr;\n+    dev.wire = Wire;","path":"workspace/__lib__/xod-dev/ds-rtc/rtc-device/patch.cpp","position":19,"original_position":19,"commit_id":"6657ea3e803b6faa486f793c793de60e797ad04b","original_commit_id":"6657ea3e803b6faa486f793c793de60e797ad04b","user":{"login":"nkrkv","id":146383,"node_id":"MDQ6VXNlcjE0NjM4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/146383?v=4","gravatar_id":"","url":"https://api.github.com/users/nkrkv","html_url":"https://github.com/nkrkv","followers_url":"https://api.github.com/users/nkrkv/followers","following_url":"https://api.github.com/users/nkrkv/following{/other_user}","gists_url":"https://api.github.com/users/nkrkv/gists{/gist_id}","starred_url":"https://api.github.com/users/nkrkv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkrkv/subscriptions","organizations_url":"https://api.github.com/users/nkrkv/orgs","repos_url":"https://api.github.com/users/nkrkv/repos","events_url":"https://api.github.com/users/nkrkv/events{/privacy}","received_events_url":"https://api.github.com/users/nkrkv/received_events","type":"User","site_admin":false},"body":"Just a bore. There’s a shorter and arguably more clear version:\r\n\r\n```cpp\r\nType dev;\r\ndev.addr = getValue<input_ADDR>(ctx);\r\ndev.wire = getValue<input_I2C>(ctx);\r\n```","created_at":"2018-09-10T08:32:48Z","updated_at":"2018-09-10T08:34:49Z","html_url":"https://github.com/xodio/xod/pull/1438#discussion_r216237516","pull_request_url":"https://api.github.com/repos/xodio/xod/pulls/1438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xodio/xod/pulls/comments/216237516"},"html":{"href":"https://github.com/xodio/xod/pull/1438#discussion_r216237516"},"pull_request":{"href":"https://api.github.com/repos/xodio/xod/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/xodio/xod/pulls/1438","id":213970023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTcwMDIz","html_url":"https://github.com/xodio/xod/pull/1438","diff_url":"https://github.com/xodio/xod/pull/1438.diff","patch_url":"https://github.com/xodio/xod/pull/1438.patch","issue_url":"https://api.github.com/repos/xodio/xod/issues/1438","number":1438,"state":"open","locked":false,"title":"Add library `xod-dev/ds-rtc`","user":{"login":"gabbapeople","id":35202630,"node_id":"MDQ6VXNlcjM1MjAyNjMw","avatar_url":"https://avatars2.githubusercontent.com/u/35202630?v=4","gravatar_id":"","url":"https://api.github.com/users/gabbapeople","html_url":"https://github.com/gabbapeople","followers_url":"https://api.github.com/users/gabbapeople/followers","following_url":"https://api.github.com/users/gabbapeople/following{/other_user}","gists_url":"https://api.github.com/users/gabbapeople/gists{/gist_id}","starred_url":"https://api.github.com/users/gabbapeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabbapeople/subscriptions","organizations_url":"https://api.github.com/users/gabbapeople/orgs","repos_url":"https://api.github.com/users/gabbapeople/repos","events_url":"https://api.github.com/users/gabbapeople/events{/privacy}","received_events_url":"https://api.github.com/users/gabbapeople/received_events","type":"User","site_admin":false},"body":"The rework of XOD `ds1307` common-hardware nodes in order to make a `datetime` compatible RTC library.","created_at":"2018-09-07T15:50:35Z","updated_at":"2018-09-10T08:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcf0fa752be2ca63363f8992f9e50210f61c275a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xodio/xod/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/xodio/xod/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/xodio/xod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xodio/xod/issues/1438/comments","statuses_url":"https://api.github.com/repos/xodio/xod/statuses/6657ea3e803b6faa486f793c793de60e797ad04b","head":{"label":"xodio:feat-library-ds-rtc","ref":"feat-library-ds-rtc","sha":"6657ea3e803b6faa486f793c793de60e797ad04b","user":{"login":"xodio","id":22938266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTM4MjY2","avatar_url":"https://avatars0.githubusercontent.com/u/22938266?v=4","gravatar_id":"","url":"https://api.github.com/users/xodio","html_url":"https://github.com/xodio","followers_url":"https://api.github.com/users/xodio/followers","following_url":"https://api.github.com/users/xodio/following{/other_user}","gists_url":"https://api.github.com/users/xodio/gists{/gist_id}","starred_url":"https://api.github.com/users/xodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xodio/subscriptions","organizations_url":"https://api.github.com/users/xodio/orgs","repos_url":"https://api.github.com/users/xodio/repos","events_url":"https://api.github.com/users/xodio/events{/privacy}","received_events_url":"https://api.github.com/users/xodio/received_events","type":"Organization","site_admin":false},"repo":{"id":40270919,"node_id":"MDEwOlJlcG9zaXRvcnk0MDI3MDkxOQ==","name":"xod","full_name":"xodio/xod","owner":{"login":"xodio","id":22938266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTM4MjY2","avatar_url":"https://avatars0.githubusercontent.com/u/22938266?v=4","gravatar_id":"","url":"https://api.github.com/users/xodio","html_url":"https://github.com/xodio","followers_url":"https://api.github.com/users/xodio/followers","following_url":"https://api.github.com/users/xodio/following{/other_user}","gists_url":"https://api.github.com/users/xodio/gists{/gist_id}","starred_url":"https://api.github.com/users/xodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xodio/subscriptions","organizations_url":"https://api.github.com/users/xodio/orgs","repos_url":"https://api.github.com/users/xodio/repos","events_url":"https://api.github.com/users/xodio/events{/privacy}","received_events_url":"https://api.github.com/users/xodio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xodio/xod","description":"XOD IDE","fork":false,"url":"https://api.github.com/repos/xodio/xod","forks_url":"https://api.github.com/repos/xodio/xod/forks","keys_url":"https://api.github.com/repos/xodio/xod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xodio/xod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xodio/xod/teams","hooks_url":"https://api.github.com/repos/xodio/xod/hooks","issue_events_url":"https://api.github.com/repos/xodio/xod/issues/events{/number}","events_url":"https://api.github.com/repos/xodio/xod/events","assignees_url":"https://api.github.com/repos/xodio/xod/assignees{/user}","branches_url":"https://api.github.com/repos/xodio/xod/branches{/branch}","tags_url":"https://api.github.com/repos/xodio/xod/tags","blobs_url":"https://api.github.com/repos/xodio/xod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xodio/xod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xodio/xod/git/refs{/sha}","trees_url":"https://api.github.com/repos/xodio/xod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xodio/xod/statuses/{sha}","languages_url":"https://api.github.com/repos/xodio/xod/languages","stargazers_url":"https://api.github.com/repos/xodio/xod/stargazers","contributors_url":"https://api.github.com/repos/xodio/xod/contributors","subscribers_url":"https://api.github.com/repos/xodio/xod/subscribers","subscription_url":"https://api.github.com/repos/xodio/xod/subscription","commits_url":"https://api.github.com/repos/xodio/xod/commits{/sha}","git_commits_url":"https://api.github.com/repos/xodio/xod/git/commits{/sha}","comments_url":"https://api.github.com/repos/xodio/xod/comments{/number}","issue_comment_url":"https://api.github.com/repos/xodio/xod/issues/comments{/number}","contents_url":"https://api.github.com/repos/xodio/xod/contents/{+path}","compare_url":"https://api.github.com/repos/xodio/xod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xodio/xod/merges","archive_url":"https://api.github.com/repos/xodio/xod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xodio/xod/downloads","issues_url":"https://api.github.com/repos/xodio/xod/issues{/number}","pulls_url":"https://api.github.com/repos/xodio/xod/pulls{/number}","milestones_url":"https://api.github.com/repos/xodio/xod/milestones{/number}","notifications_url":"https://api.github.com/repos/xodio/xod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xodio/xod/labels{/name}","releases_url":"https://api.github.com/repos/xodio/xod/releases{/id}","deployments_url":"https://api.github.com/repos/xodio/xod/deployments","created_at":"2015-08-05T22:02:33Z","updated_at":"2018-09-09T15:41:38Z","pushed_at":"2018-09-07T16:21:27Z","git_url":"git://github.com/xodio/xod.git","ssh_url":"git@github.com:xodio/xod.git","clone_url":"https://github.com/xodio/xod.git","svn_url":"https://github.com/xodio/xod","homepage":"https://xod.io","size":44258,"stargazers_count":285,"watchers_count":285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":50,"open_issues":60,"watchers":285,"default_branch":"master"}},"base":{"label":"xodio:master","ref":"master","sha":"28c6d0ef430f930e38609157e3333d3249392fbc","user":{"login":"xodio","id":22938266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTM4MjY2","avatar_url":"https://avatars0.githubusercontent.com/u/22938266?v=4","gravatar_id":"","url":"https://api.github.com/users/xodio","html_url":"https://github.com/xodio","followers_url":"https://api.github.com/users/xodio/followers","following_url":"https://api.github.com/users/xodio/following{/other_user}","gists_url":"https://api.github.com/users/xodio/gists{/gist_id}","starred_url":"https://api.github.com/users/xodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xodio/subscriptions","organizations_url":"https://api.github.com/users/xodio/orgs","repos_url":"https://api.github.com/users/xodio/repos","events_url":"https://api.github.com/users/xodio/events{/privacy}","received_events_url":"https://api.github.com/users/xodio/received_events","type":"Organization","site_admin":false},"repo":{"id":40270919,"node_id":"MDEwOlJlcG9zaXRvcnk0MDI3MDkxOQ==","name":"xod","full_name":"xodio/xod","owner":{"login":"xodio","id":22938266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTM4MjY2","avatar_url":"https://avatars0.githubusercontent.com/u/22938266?v=4","gravatar_id":"","url":"https://api.github.com/users/xodio","html_url":"https://github.com/xodio","followers_url":"https://api.github.com/users/xodio/followers","following_url":"https://api.github.com/users/xodio/following{/other_user}","gists_url":"https://api.github.com/users/xodio/gists{/gist_id}","starred_url":"https://api.github.com/users/xodio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xodio/subscriptions","organizations_url":"https://api.github.com/users/xodio/orgs","repos_url":"https://api.github.com/users/xodio/repos","events_url":"https://api.github.com/users/xodio/events{/privacy}","received_events_url":"https://api.github.com/users/xodio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xodio/xod","description":"XOD IDE","fork":false,"url":"https://api.github.com/repos/xodio/xod","forks_url":"https://api.github.com/repos/xodio/xod/forks","keys_url":"https://api.github.com/repos/xodio/xod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xodio/xod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xodio/xod/teams","hooks_url":"https://api.github.com/repos/xodio/xod/hooks","issue_events_url":"https://api.github.com/repos/xodio/xod/issues/events{/number}","events_url":"https://api.github.com/repos/xodio/xod/events","assignees_url":"https://api.github.com/repos/xodio/xod/assignees{/user}","branches_url":"https://api.github.com/repos/xodio/xod/branches{/branch}","tags_url":"https://api.github.com/repos/xodio/xod/tags","blobs_url":"https://api.github.com/repos/xodio/xod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xodio/xod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xodio/xod/git/refs{/sha}","trees_url":"https://api.github.com/repos/xodio/xod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xodio/xod/statuses/{sha}","languages_url":"https://api.github.com/repos/xodio/xod/languages","stargazers_url":"https://api.github.com/repos/xodio/xod/stargazers","contributors_url":"https://api.github.com/repos/xodio/xod/contributors","subscribers_url":"https://api.github.com/repos/xodio/xod/subscribers","subscription_url":"https://api.github.com/repos/xodio/xod/subscription","commits_url":"https://api.github.com/repos/xodio/xod/commits{/sha}","git_commits_url":"https://api.github.com/repos/xodio/xod/git/commits{/sha}","comments_url":"https://api.github.com/repos/xodio/xod/comments{/number}","issue_comment_url":"https://api.github.com/repos/xodio/xod/issues/comments{/number}","contents_url":"https://api.github.com/repos/xodio/xod/contents/{+path}","compare_url":"https://api.github.com/repos/xodio/xod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xodio/xod/merges","archive_url":"https://api.github.com/repos/xodio/xod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xodio/xod/downloads","issues_url":"https://api.github.com/repos/xodio/xod/issues{/number}","pulls_url":"https://api.github.com/repos/xodio/xod/pulls{/number}","milestones_url":"https://api.github.com/repos/xodio/xod/milestones{/number}","notifications_url":"https://api.github.com/repos/xodio/xod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xodio/xod/labels{/name}","releases_url":"https://api.github.com/repos/xodio/xod/releases{/id}","deployments_url":"https://api.github.com/repos/xodio/xod/deployments","created_at":"2015-08-05T22:02:33Z","updated_at":"2018-09-09T15:41:38Z","pushed_at":"2018-09-07T16:21:27Z","git_url":"git://github.com/xodio/xod.git","ssh_url":"git@github.com:xodio/xod.git","clone_url":"https://github.com/xodio/xod.git","svn_url":"https://github.com/xodio/xod","homepage":"https://xod.io","size":44258,"stargazers_count":285,"watchers_count":285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":50,"open_issues":60,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xodio/xod/pulls/1438"},"html":{"href":"https://github.com/xodio/xod/pull/1438"},"issue":{"href":"https://api.github.com/repos/xodio/xod/issues/1438"},"comments":{"href":"https://api.github.com/repos/xodio/xod/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/xodio/xod/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/xodio/xod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xodio/xod/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/xodio/xod/statuses/6657ea3e803b6faa486f793c793de60e797ad04b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nkrkv"}}