{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/184015514","pull_request_review_id":115123315,"id":184015514,"diff_hunk":"@@ -309,4 +311,47 @@ public Integer call() throws Exception {\n             return ++state;\n         }\n     }\n+\n+    @Test\n+    public void submitToAllMembers_NonSerializableResponse() {","path":"hazelcast/src/test/java/com/hazelcast/executor/SmallClusterTest.java","position":22,"original_position":22,"commit_id":"4ff76666765701a927e1ed61456acfaed4171968","original_commit_id":"9ee104ba7e4ef55c1dbe52fa38a9d5c8bdbac9a4","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"body":"@mdogan Thanks for the tests. \r\n \r\n","created_at":"2018-04-25T10:47:56Z","updated_at":"2018-04-25T10:47:56Z","html_url":"https://github.com/hazelcast/hazelcast/pull/12955#discussion_r184015514","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/184015514"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/12955#discussion_r184015514"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955"}},"in_reply_to_id":183979877},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955","id":183721436,"html_url":"https://github.com/hazelcast/hazelcast/pull/12955","diff_url":"https://github.com/hazelcast/hazelcast/pull/12955.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/12955.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12955","number":12955,"state":"open","locked":false,"title":"Send the exception to caller when response of an callable not serializable","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"body":"\r\n    \r\n    When response is not serializable, it was logged on the side that\r\n    callable is running.\r\n    And the caller was waiting until operation call timeout.\r\n    \r\n    In this pr, we are sending the HazelcastSerializationException to caller.\r\n    And exception is not logged on the running side.\r\n    \r\n    Fix is related to executor service. Added a test on operation service\r\n    to show that operation service handle the issue correctly. Only wrong\r\n    usage is was on DistributedExecutorService.\r\n    \r\n    fixes https://github.com/hazelcast/hazelcast/issues/12956\r\n\r\n","created_at":"2018-04-24T12:37:17Z","updated_at":"2018-04-25T10:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"303d5283b880ce05808ac4ab25f07d62589db324","assignee":{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"assignees":[{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740690,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Defect","name":"Type: Defect","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/106","html_url":"https://github.com/hazelcast/hazelcast/milestone/106","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/106/labels","id":2867560,"number":106,"title":"3.11","description":"","creator":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"open_issues":227,"closed_issues":53,"state":"open","created_at":"2017-10-26T14:31:27Z","updated_at":"2018-04-25T10:37:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12955/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/4ff76666765701a927e1ed61456acfaed4171968","head":{"label":"sancar:fix/nonSerializableResponse/master","ref":"fix/nonSerializableResponse/master","sha":"4ff76666765701a927e1ed61456acfaed4171968","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"repo":{"id":12152804,"name":"hazelcast","full_name":"sancar/hazelcast","owner":{"login":"sancar","id":570462,"avatar_url":"https://avatars0.githubusercontent.com/u/570462?v=4","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sancar/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/sancar/hazelcast","forks_url":"https://api.github.com/repos/sancar/hazelcast/forks","keys_url":"https://api.github.com/repos/sancar/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sancar/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sancar/hazelcast/teams","hooks_url":"https://api.github.com/repos/sancar/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/sancar/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/sancar/hazelcast/events","assignees_url":"https://api.github.com/repos/sancar/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/sancar/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/sancar/hazelcast/tags","blobs_url":"https://api.github.com/repos/sancar/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sancar/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sancar/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/sancar/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sancar/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/sancar/hazelcast/languages","stargazers_url":"https://api.github.com/repos/sancar/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/sancar/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/sancar/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/sancar/hazelcast/subscription","commits_url":"https://api.github.com/repos/sancar/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/sancar/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/sancar/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/sancar/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/sancar/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/sancar/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sancar/hazelcast/merges","archive_url":"https://api.github.com/repos/sancar/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sancar/hazelcast/downloads","issues_url":"https://api.github.com/repos/sancar/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/sancar/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/sancar/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/sancar/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sancar/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/sancar/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/sancar/hazelcast/deployments","created_at":"2013-08-16T06:59:07Z","updated_at":"2018-04-05T14:16:57Z","pushed_at":"2018-04-25T10:47:16Z","git_url":"git://github.com/sancar/hazelcast.git","ssh_url":"git@github.com:sancar/hazelcast.git","clone_url":"https://github.com/sancar/hazelcast.git","svn_url":"https://github.com/sancar/hazelcast","homepage":"www.hazelcast.com","size":137176,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"0aea1a25a4fc053a3a6456ccf50cec54a6867407","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2018-04-25T10:37:33Z","pushed_at":"2018-04-25T10:47:18Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"http://www.hazelcast.org","size":128972,"stargazers_count":2552,"watchers_count":2552,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1001,"mirror_url":null,"archived":false,"open_issues_count":649,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1001,"open_issues":649,"watchers":2552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/12955"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12955"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12955/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12955/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/4ff76666765701a927e1ed61456acfaed4171968"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sancar"}}