{"action":"closed","number":5744,"pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744","id":169549705,"html_url":"https://github.com/shuyangzhou/liferay-portal/pull/5744","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/5744.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/5744.patch","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5744","number":5744,"state":"closed","locked":false,"title":"Lps 78069","user":{"login":"lanceji92674957","id":30807395,"avatar_url":"https://avatars0.githubusercontent.com/u/30807395?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceji92674957","html_url":"https://github.com/lanceji92674957","followers_url":"https://api.github.com/users/lanceji92674957/followers","following_url":"https://api.github.com/users/lanceji92674957/following{/other_user}","gists_url":"https://api.github.com/users/lanceji92674957/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceji92674957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceji92674957/subscriptions","organizations_url":"https://api.github.com/users/lanceji92674957/orgs","repos_url":"https://api.github.com/users/lanceji92674957/repos","events_url":"https://api.github.com/users/lanceji92674957/events{/privacy}","received_events_url":"https://api.github.com/users/lanceji92674957/received_events","type":"User","site_admin":false},"body":"Hi Shuyang,\r\n\r\nAfter discussion with @drewbrokke and @Preston-Crary, it makes more sense to use AggregateResourceBundleLoader.\r\nIn addition, this pull also makes the error message cleaner by showing bundle localization error messages only.\r\n\r\nThanks.\r\nLance","created_at":"2018-02-16T05:17:14Z","updated_at":"2018-02-20T18:42:22Z","closed_at":"2018-02-20T18:42:22Z","merged_at":null,"merge_commit_sha":"28954ab7c347953de306e2bc9e2290f86c669f7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744/commits","review_comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744/comments","review_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5744/comments","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/4c5c11d40a3286876d3b2ee6162ebddc40bb22fd","head":{"label":"lanceji92674957:LPS-78069","ref":"LPS-78069","sha":"4c5c11d40a3286876d3b2ee6162ebddc40bb22fd","user":{"login":"lanceji92674957","id":30807395,"avatar_url":"https://avatars0.githubusercontent.com/u/30807395?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceji92674957","html_url":"https://github.com/lanceji92674957","followers_url":"https://api.github.com/users/lanceji92674957/followers","following_url":"https://api.github.com/users/lanceji92674957/following{/other_user}","gists_url":"https://api.github.com/users/lanceji92674957/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceji92674957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceji92674957/subscriptions","organizations_url":"https://api.github.com/users/lanceji92674957/orgs","repos_url":"https://api.github.com/users/lanceji92674957/repos","events_url":"https://api.github.com/users/lanceji92674957/events{/privacy}","received_events_url":"https://api.github.com/users/lanceji92674957/received_events","type":"User","site_admin":false},"repo":{"id":99653749,"name":"liferay-portal","full_name":"lanceji92674957/liferay-portal","owner":{"login":"lanceji92674957","id":30807395,"avatar_url":"https://avatars0.githubusercontent.com/u/30807395?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceji92674957","html_url":"https://github.com/lanceji92674957","followers_url":"https://api.github.com/users/lanceji92674957/followers","following_url":"https://api.github.com/users/lanceji92674957/following{/other_user}","gists_url":"https://api.github.com/users/lanceji92674957/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceji92674957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceji92674957/subscriptions","organizations_url":"https://api.github.com/users/lanceji92674957/orgs","repos_url":"https://api.github.com/users/lanceji92674957/repos","events_url":"https://api.github.com/users/lanceji92674957/events{/privacy}","received_events_url":"https://api.github.com/users/lanceji92674957/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lanceji92674957/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/lanceji92674957/liferay-portal","forks_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/forks","keys_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/teams","hooks_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/events","assignees_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/tags","blobs_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/subscription","commits_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/merges","archive_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/downloads","issues_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/lanceji92674957/liferay-portal/deployments","created_at":"2017-08-08T05:31:45Z","updated_at":"2017-08-08T05:34:26Z","pushed_at":"2018-02-20T17:22:15Z","git_url":"git://github.com/lanceji92674957/liferay-portal.git","ssh_url":"git@github.com:lanceji92674957/liferay-portal.git","clone_url":"https://github.com/lanceji92674957/liferay-portal.git","svn_url":"https://github.com/lanceji92674957/liferay-portal","homepage":"http://liferay.com","size":12514884,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"shuyangzhou:master","ref":"master","sha":"faf87e3cddc5e80e813fce73710cd82562f2e285","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"repo":{"id":1921247,"name":"liferay-portal","full_name":"shuyangzhou/liferay-portal","owner":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuyangzhou/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal","forks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/forks","keys_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/events","assignees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/merges","archive_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/deployments","created_at":"2011-06-20T00:16:27Z","updated_at":"2018-01-15T12:31:07Z","pushed_at":"2018-02-20T18:41:51Z","git_url":"git://github.com/shuyangzhou/liferay-portal.git","ssh_url":"git@github.com:shuyangzhou/liferay-portal.git","clone_url":"https://github.com/shuyangzhou/liferay-portal.git","svn_url":"https://github.com/shuyangzhou/liferay-portal","homepage":"http://liferay.com","size":12568203,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":36,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744"},"html":{"href":"https://github.com/shuyangzhou/liferay-portal/pull/5744"},"issue":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5744"},"comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5744/comments"},"review_comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744/comments"},"review_comment":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5744/commits"},"statuses":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/4c5c11d40a3286876d3b2ee6162ebddc40bb22fd"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":3,"maintainer_can_modify":false,"commits":149,"additions":4877,"deletions":5063,"changed_files":294}}
{"actor":{"display_login":"shuyangzhou"}}