{"push_id":3097794175,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"0d2311820d50e29b83eb9f885d961f9b43dfd165","before":"f34ca9f783ec84391f22728fc150d7b7cc294968","commits":[{"sha":"76faccccbb51bb477a88ebfa3fa2a8254da37696","author":{"name":"Rod Vagg","email":"f9f03903429036ef609ed7ca822fddfa76155c29@vagg.org"},"message":"tools: don't use GH API for commit message checks\n\nFixes: https://github.com/nodejs/node/issues/24567\n\nPR-URL: https://github.com/nodejs/node/pull/24574\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Gus Caplan <me@gus.host>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>","distinct":true,"url":"https://api.github.com/repos/shakir-abdo/node/commits/76faccccbb51bb477a88ebfa3fa2a8254da37696"},{"sha":"0d2311820d50e29b83eb9f885d961f9b43dfd165","author":{"name":"Mike Samuel","email":"b0d08bfe3e749932a68a800416f0aef6cb94939a@gmail.com"},"message":"url: use SafeSet to filter known special protocols\n\nAvoids a maintenance hazard when reviewers assume that\n`hostlessProtocol` and `slashedProtocol` are disjoint.\n\nThe following may be counter-intuitive:\n\n```js\n// These objects seem to have no keys in common\nconst hostlessProtocol = { 'javascript': true };\nconst slashedProtocol = { 'http': true };\n// A reasonable reviewer may assumes bothTrue is never truthy\nfunction bothTrue(lowerProto) {\n  return hostlessProtocol[lowerProto] && slashedProtocol[lowerProto];\n}\n// But\nconsole.log(Boolean(bothTrue('constructor')));  // true\n```\n\nThis change uses SafeSet instead of plain-old objects.\n\n----\n\nRejected alternative:\n\nWe could have used object with a `null` prototype as lookup tables\nso that `lowerProto` is never treated as a key into `Object.prototype`.\n\n```js\nconst hostlessProtocol = { __proto__: null, 'javascript': true };\nconst slashedProtocol = { __proto__: null, 'http': true };\n\nfunction bothTrue(lowerProto) {\n  return hostlessProtocol[lowerProto] && slashedProtocol[lowerProto];\n}\n\nconsole.log(Boolean(bothTrue('constructor')));  // false\n```\n\nPR-URL: https://github.com/nodejs/node/pull/24703\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/shakir-abdo/node/commits/0d2311820d50e29b83eb9f885d961f9b43dfd165"}]}
{"actor":{"display_login":"pull"}}