{"action":"closed","number":2406,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406","id":230938096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTM4MDk2","html_url":"https://github.com/snapcore/snapcraft/pull/2406","diff_url":"https://github.com/snapcore/snapcraft/pull/2406.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2406.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2406","number":2406,"state":"closed","locked":false,"title":"project_loader: add git to build-packages for version: git (#2403)","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"When version is set to git, snapcraft should ensure that git makes it\r\ninto the build-packages set.\r\n\r\nLP: #1802899\r\nFixes SNAPCRAFT-7P\r\n\r\n- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [ ] Have you successfully run `./runtests.sh static`?\r\n- [ ] Have you successfully run `./runtests.sh tests/unit`?\r\n\r\n-----\r\n","created_at":"2018-11-14T18:33:45Z","updated_at":"2018-11-15T01:05:45Z","closed_at":"2018-11-15T01:05:45Z","merged_at":"2018-11-15T01:05:45Z","merge_commit_sha":"428fba8650d496915f88c8a1b36f2ccc6f3f56c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2406/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/e79bd1daabe60664d4ca3b358f735b1f777d4f82","head":{"label":"sergiusens:legacy-version-git","ref":"legacy-version-git","sha":"e79bd1daabe60664d4ca3b358f735b1f777d4f82","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"repo":{"id":45202272,"node_id":"MDEwOlJlcG9zaXRvcnk0NTIwMjI3Mg==","name":"snapcraft","full_name":"sergiusens/snapcraft","private":false,"owner":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sergiusens/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/sergiusens/snapcraft","forks_url":"https://api.github.com/repos/sergiusens/snapcraft/forks","keys_url":"https://api.github.com/repos/sergiusens/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergiusens/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergiusens/snapcraft/teams","hooks_url":"https://api.github.com/repos/sergiusens/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/sergiusens/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/sergiusens/snapcraft/events","assignees_url":"https://api.github.com/repos/sergiusens/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/sergiusens/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/sergiusens/snapcraft/tags","blobs_url":"https://api.github.com/repos/sergiusens/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergiusens/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergiusens/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergiusens/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergiusens/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/sergiusens/snapcraft/languages","stargazers_url":"https://api.github.com/repos/sergiusens/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/sergiusens/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/sergiusens/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/sergiusens/snapcraft/subscription","commits_url":"https://api.github.com/repos/sergiusens/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergiusens/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergiusens/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergiusens/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergiusens/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/sergiusens/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergiusens/snapcraft/merges","archive_url":"https://api.github.com/repos/sergiusens/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergiusens/snapcraft/downloads","issues_url":"https://api.github.com/repos/sergiusens/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/sergiusens/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/sergiusens/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/sergiusens/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergiusens/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/sergiusens/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/sergiusens/snapcraft/deployments","created_at":"2015-10-29T18:19:58Z","updated_at":"2018-09-19T09:14:30Z","pushed_at":"2018-11-14T23:50:03Z","git_url":"git://github.com/sergiusens/snapcraft.git","ssh_url":"git@github.com:sergiusens/snapcraft.git","clone_url":"https://github.com/sergiusens/snapcraft.git","svn_url":"https://github.com/sergiusens/snapcraft","homepage":null,"size":21884,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:legacy","ref":"legacy","sha":"ba859a0b9429272d113ebdac213eef0c4e58bf73","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE5OTEzNg==","name":"snapcraft","full_name":"snapcore/snapcraft","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2018-11-14T21:51:13Z","pushed_at":"2018-11-15T01:05:45Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":"https://snapcraft.io","size":21747,"stargazers_count":684,"watchers_count":684,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":269,"open_issues":69,"watchers":684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2406"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2406"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2406/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2406/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/e79bd1daabe60664d4ca3b358f735b1f777d4f82"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"sergiusens"}}