{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/memcached_store/pulls/comments/240330965","pull_request_review_id":183337029,"id":240330965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDMzMDk2NQ==","diff_hunk":"@@ -279,7 +292,7 @@ def expiration(options)\n \n       def handle_exceptions(return_value_on_error:, on_miss: return_value_on_error)\n         yield\n-      rescue Memcached::NotFound, Memcached::ConnectionDataExists\n+      rescue Memcached::NotFound, Memcached::NotStored, Memcached::ConnectionDataExists","path":"lib/active_support/cache/memcached_store.rb","position":25,"original_position":25,"commit_id":"41a1b94ed4ae879393e6fd35481e2ec446913392","original_commit_id":"41a1b94ed4ae879393e6fd35481e2ec446913392","user":{"login":"ariens-shopify","id":23177515,"node_id":"MDQ6VXNlcjIzMTc3NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/23177515?v=4","gravatar_id":"","url":"https://api.github.com/users/ariens-shopify","html_url":"https://github.com/ariens-shopify","followers_url":"https://api.github.com/users/ariens-shopify/followers","following_url":"https://api.github.com/users/ariens-shopify/following{/other_user}","gists_url":"https://api.github.com/users/ariens-shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/ariens-shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariens-shopify/subscriptions","organizations_url":"https://api.github.com/users/ariens-shopify/orgs","repos_url":"https://api.github.com/users/ariens-shopify/repos","events_url":"https://api.github.com/users/ariens-shopify/events{/privacy}","received_events_url":"https://api.github.com/users/ariens-shopify/received_events","type":"User","site_admin":false},"body":"Side note: this was the original implementation of the test for cache miss:\r\n\r\n```ruby\r\n  def test_append_with_cache_miss\r\n    refute(@cache.append('foo', 'bar'))\r\n  end\r\n```\r\n\r\n...and all tests passed because `nil` satisfies `refute`.","created_at":"2018-12-10T18:38:48Z","updated_at":"2018-12-10T18:38:48Z","html_url":"https://github.com/Shopify/memcached_store/pull/55#discussion_r240330965","pull_request_url":"https://api.github.com/repos/Shopify/memcached_store/pulls/55","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/comments/240330965"},"html":{"href":"https://github.com/Shopify/memcached_store/pull/55#discussion_r240330965"},"pull_request":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/55"}},"in_reply_to_id":240329500},"pull_request":{"url":"https://api.github.com/repos/Shopify/memcached_store/pulls/55","id":236649504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NjQ5NTA0","html_url":"https://github.com/Shopify/memcached_store/pull/55","diff_url":"https://github.com/Shopify/memcached_store/pull/55.diff","patch_url":"https://github.com/Shopify/memcached_store/pull/55.patch","issue_url":"https://api.github.com/repos/Shopify/memcached_store/issues/55","number":55,"state":"open","locked":false,"title":"Adds Append Operation","user":{"login":"ariens-shopify","id":23177515,"node_id":"MDQ6VXNlcjIzMTc3NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/23177515?v=4","gravatar_id":"","url":"https://api.github.com/users/ariens-shopify","html_url":"https://github.com/ariens-shopify","followers_url":"https://api.github.com/users/ariens-shopify/followers","following_url":"https://api.github.com/users/ariens-shopify/following{/other_user}","gists_url":"https://api.github.com/users/ariens-shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/ariens-shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariens-shopify/subscriptions","organizations_url":"https://api.github.com/users/ariens-shopify/orgs","repos_url":"https://api.github.com/users/ariens-shopify/repos","events_url":"https://api.github.com/users/ariens-shopify/events{/privacy}","received_events_url":"https://api.github.com/users/ariens-shopify/received_events","type":"User","site_admin":false},"body":"Exposes `append` as a cache operation.","created_at":"2018-12-06T19:45:32Z","updated_at":"2018-12-10T18:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49dff2fb9feaf7809264ff8b5798a5af340abc11","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rafaelfranca","id":47848,"node_id":"MDQ6VXNlcjQ3ODQ4","avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},{"login":"maximebedard","id":801405,"node_id":"MDQ6VXNlcjgwMTQwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/801405?v=4","gravatar_id":"","url":"https://api.github.com/users/maximebedard","html_url":"https://github.com/maximebedard","followers_url":"https://api.github.com/users/maximebedard/followers","following_url":"https://api.github.com/users/maximebedard/following{/other_user}","gists_url":"https://api.github.com/users/maximebedard/gists{/gist_id}","starred_url":"https://api.github.com/users/maximebedard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximebedard/subscriptions","organizations_url":"https://api.github.com/users/maximebedard/orgs","repos_url":"https://api.github.com/users/maximebedard/repos","events_url":"https://api.github.com/users/maximebedard/events{/privacy}","received_events_url":"https://api.github.com/users/maximebedard/received_events","type":"User","site_admin":false},{"login":"fbogsany","id":1551119,"node_id":"MDQ6VXNlcjE1NTExMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1551119?v=4","gravatar_id":"","url":"https://api.github.com/users/fbogsany","html_url":"https://github.com/fbogsany","followers_url":"https://api.github.com/users/fbogsany/followers","following_url":"https://api.github.com/users/fbogsany/following{/other_user}","gists_url":"https://api.github.com/users/fbogsany/gists{/gist_id}","starred_url":"https://api.github.com/users/fbogsany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbogsany/subscriptions","organizations_url":"https://api.github.com/users/fbogsany/orgs","repos_url":"https://api.github.com/users/fbogsany/repos","events_url":"https://api.github.com/users/fbogsany/events{/privacy}","received_events_url":"https://api.github.com/users/fbogsany/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/memcached_store/pulls/55/commits","review_comments_url":"https://api.github.com/repos/Shopify/memcached_store/pulls/55/comments","review_comment_url":"https://api.github.com/repos/Shopify/memcached_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/memcached_store/issues/55/comments","statuses_url":"https://api.github.com/repos/Shopify/memcached_store/statuses/41a1b94ed4ae879393e6fd35481e2ec446913392","head":{"label":"Shopify:add-append","ref":"add-append","sha":"41a1b94ed4ae879393e6fd35481e2ec446913392","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":9454067,"node_id":"MDEwOlJlcG9zaXRvcnk5NDU0MDY3","name":"memcached_store","full_name":"Shopify/memcached_store","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/memcached_store","description":"ActiveSupport MemcachedStore","fork":false,"url":"https://api.github.com/repos/Shopify/memcached_store","forks_url":"https://api.github.com/repos/Shopify/memcached_store/forks","keys_url":"https://api.github.com/repos/Shopify/memcached_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/memcached_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/memcached_store/teams","hooks_url":"https://api.github.com/repos/Shopify/memcached_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/memcached_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/memcached_store/events","assignees_url":"https://api.github.com/repos/Shopify/memcached_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/memcached_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/memcached_store/tags","blobs_url":"https://api.github.com/repos/Shopify/memcached_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/memcached_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/memcached_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/memcached_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/memcached_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/memcached_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/memcached_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/memcached_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/memcached_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/memcached_store/subscription","commits_url":"https://api.github.com/repos/Shopify/memcached_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/memcached_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/memcached_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/memcached_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/memcached_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/memcached_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/memcached_store/merges","archive_url":"https://api.github.com/repos/Shopify/memcached_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/memcached_store/downloads","issues_url":"https://api.github.com/repos/Shopify/memcached_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/memcached_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/memcached_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/memcached_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/memcached_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/memcached_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/memcached_store/deployments","created_at":"2013-04-15T17:24:22Z","updated_at":"2018-10-31T15:28:01Z","pushed_at":"2018-12-10T18:13:15Z","git_url":"git://github.com/Shopify/memcached_store.git","ssh_url":"git@github.com:Shopify/memcached_store.git","clone_url":"https://github.com/Shopify/memcached_store.git","svn_url":"https://github.com/Shopify/memcached_store","homepage":"","size":177,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":1,"watchers":27,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"535f4640e185aa805a1db7de9c622351956bdc4f","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":9454067,"node_id":"MDEwOlJlcG9zaXRvcnk5NDU0MDY3","name":"memcached_store","full_name":"Shopify/memcached_store","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/memcached_store","description":"ActiveSupport MemcachedStore","fork":false,"url":"https://api.github.com/repos/Shopify/memcached_store","forks_url":"https://api.github.com/repos/Shopify/memcached_store/forks","keys_url":"https://api.github.com/repos/Shopify/memcached_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/memcached_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/memcached_store/teams","hooks_url":"https://api.github.com/repos/Shopify/memcached_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/memcached_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/memcached_store/events","assignees_url":"https://api.github.com/repos/Shopify/memcached_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/memcached_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/memcached_store/tags","blobs_url":"https://api.github.com/repos/Shopify/memcached_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/memcached_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/memcached_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/memcached_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/memcached_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/memcached_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/memcached_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/memcached_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/memcached_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/memcached_store/subscription","commits_url":"https://api.github.com/repos/Shopify/memcached_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/memcached_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/memcached_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/memcached_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/memcached_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/memcached_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/memcached_store/merges","archive_url":"https://api.github.com/repos/Shopify/memcached_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/memcached_store/downloads","issues_url":"https://api.github.com/repos/Shopify/memcached_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/memcached_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/memcached_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/memcached_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/memcached_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/memcached_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/memcached_store/deployments","created_at":"2013-04-15T17:24:22Z","updated_at":"2018-10-31T15:28:01Z","pushed_at":"2018-12-10T18:13:15Z","git_url":"git://github.com/Shopify/memcached_store.git","ssh_url":"git@github.com:Shopify/memcached_store.git","clone_url":"https://github.com/Shopify/memcached_store.git","svn_url":"https://github.com/Shopify/memcached_store","homepage":"","size":177,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/55"},"html":{"href":"https://github.com/Shopify/memcached_store/pull/55"},"issue":{"href":"https://api.github.com/repos/Shopify/memcached_store/issues/55"},"comments":{"href":"https://api.github.com/repos/Shopify/memcached_store/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/memcached_store/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/memcached_store/statuses/41a1b94ed4ae879393e6fd35481e2ec446913392"}},"author_association":"NONE"}}
{"actor":{"display_login":"ariens-shopify"}}