{"action":"opened","number":168,"pull_request":{"url":"https://api.github.com/repos/polkadot-js/apps/pulls/168","id":205314731,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzE0NzMx","html_url":"https://github.com/polkadot-js/apps/pull/168","diff_url":"https://github.com/polkadot-js/apps/pull/168.diff","patch_url":"https://github.com/polkadot-js/apps/pull/168.patch","issue_url":"https://api.github.com/repos/polkadot-js/apps/issues/168","number":168,"state":"open","locked":false,"title":"fix: Fixes Issue #144. Balance to submit with transaction changed to string","user":{"login":"ltfschoen","id":6226175,"node_id":"MDQ6VXNlcjYyMjYxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6226175?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfschoen","html_url":"https://github.com/ltfschoen","followers_url":"https://api.github.com/users/ltfschoen/followers","following_url":"https://api.github.com/users/ltfschoen/following{/other_user}","gists_url":"https://api.github.com/users/ltfschoen/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfschoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfschoen/subscriptions","organizations_url":"https://api.github.com/users/ltfschoen/orgs","repos_url":"https://api.github.com/users/ltfschoen/repos","events_url":"https://api.github.com/users/ltfschoen/events{/privacy}","received_events_url":"https://api.github.com/users/ltfschoen/received_events","type":"User","site_admin":false},"body":"- Placeholder indicates acceptable range of values to user in the interim until form validation incorporated.\r\n- Max value must be the balance of the account minus one, otherwise the Polkadot Node will give error `Runtime: proposer's balance too low`.\r\n- Min value must be above 0.000000000000001, otherwise the Polkadot Node will give error `Runtime: proposer's balance too low`\r\n\r\n- adds internationalisation\r\n- adds maxLength to input field depending on whether poc-1 (64bit) or latest (128bit) chain used\r\npassed down api chain data via props\r\n- adds unit tests for balance input field\r\n- adds balance input field validation to only accept numbers\r\n\r\n**Problems i'm having include:** a couple of the new unit tests that I added are not all passing but don't understand why. it's to do with comparing the maximum unsigned 64bit or 128bit value of the balance depending on what chain they are using (i.e. poc-1 or latest)\r\nwhen i add && maxBN64Bit.gte(inputBN) or && maxBN128Bit.gte(inputBN) it doesn't appear\r\nto work correctly, as in the UI it doesn't allow the length of the balance to be as long as I would expect. I tried breakpoint debugging but couldn't figure it out. I've just commented their usage out in the meantime\r\n\r\n![screen shot 2018-07-12 at 9 53 03 pm](https://user-images.githubusercontent.com/6226175/42658835-cb7bcd90-8626-11e8-8723-4d3d0eb114c5.png)\r\n\r\n**Review Comments**\r\n* [ ] - Not quite there yet, it allows invalid values to bubble up.","created_at":"2018-08-01T05:46:07Z","updated_at":"2018-08-01T05:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/polkadot-js/apps/pulls/168/commits","review_comments_url":"https://api.github.com/repos/polkadot-js/apps/pulls/168/comments","review_comment_url":"https://api.github.com/repos/polkadot-js/apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/polkadot-js/apps/issues/168/comments","statuses_url":"https://api.github.com/repos/polkadot-js/apps/statuses/832326a0b2993000c5038249906dd8925601d764","head":{"label":"polkadot-js:luke-144-extrinsics-with-high-balance-restarts-webpage","ref":"luke-144-extrinsics-with-high-balance-restarts-webpage","sha":"832326a0b2993000c5038249906dd8925601d764","user":{"login":"polkadot-js","id":33775474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/33775474?v=4","gravatar_id":"","url":"https://api.github.com/users/polkadot-js","html_url":"https://github.com/polkadot-js","followers_url":"https://api.github.com/users/polkadot-js/followers","following_url":"https://api.github.com/users/polkadot-js/following{/other_user}","gists_url":"https://api.github.com/users/polkadot-js/gists{/gist_id}","starred_url":"https://api.github.com/users/polkadot-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polkadot-js/subscriptions","organizations_url":"https://api.github.com/users/polkadot-js/orgs","repos_url":"https://api.github.com/users/polkadot-js/repos","events_url":"https://api.github.com/users/polkadot-js/events{/privacy}","received_events_url":"https://api.github.com/users/polkadot-js/received_events","type":"Organization","site_admin":false},"repo":{"id":128733562,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3MzM1NjI=","name":"apps","full_name":"polkadot-js/apps","owner":{"login":"polkadot-js","id":33775474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/33775474?v=4","gravatar_id":"","url":"https://api.github.com/users/polkadot-js","html_url":"https://github.com/polkadot-js","followers_url":"https://api.github.com/users/polkadot-js/followers","following_url":"https://api.github.com/users/polkadot-js/following{/other_user}","gists_url":"https://api.github.com/users/polkadot-js/gists{/gist_id}","starred_url":"https://api.github.com/users/polkadot-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polkadot-js/subscriptions","organizations_url":"https://api.github.com/users/polkadot-js/orgs","repos_url":"https://api.github.com/users/polkadot-js/repos","events_url":"https://api.github.com/users/polkadot-js/events{/privacy}","received_events_url":"https://api.github.com/users/polkadot-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/polkadot-js/apps","description":"Basic Polkadot/Substrate UI for interacting with a node","fork":false,"url":"https://api.github.com/repos/polkadot-js/apps","forks_url":"https://api.github.com/repos/polkadot-js/apps/forks","keys_url":"https://api.github.com/repos/polkadot-js/apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polkadot-js/apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polkadot-js/apps/teams","hooks_url":"https://api.github.com/repos/polkadot-js/apps/hooks","issue_events_url":"https://api.github.com/repos/polkadot-js/apps/issues/events{/number}","events_url":"https://api.github.com/repos/polkadot-js/apps/events","assignees_url":"https://api.github.com/repos/polkadot-js/apps/assignees{/user}","branches_url":"https://api.github.com/repos/polkadot-js/apps/branches{/branch}","tags_url":"https://api.github.com/repos/polkadot-js/apps/tags","blobs_url":"https://api.github.com/repos/polkadot-js/apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polkadot-js/apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polkadot-js/apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/polkadot-js/apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polkadot-js/apps/statuses/{sha}","languages_url":"https://api.github.com/repos/polkadot-js/apps/languages","stargazers_url":"https://api.github.com/repos/polkadot-js/apps/stargazers","contributors_url":"https://api.github.com/repos/polkadot-js/apps/contributors","subscribers_url":"https://api.github.com/repos/polkadot-js/apps/subscribers","subscription_url":"https://api.github.com/repos/polkadot-js/apps/subscription","commits_url":"https://api.github.com/repos/polkadot-js/apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/polkadot-js/apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/polkadot-js/apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/polkadot-js/apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/polkadot-js/apps/contents/{+path}","compare_url":"https://api.github.com/repos/polkadot-js/apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polkadot-js/apps/merges","archive_url":"https://api.github.com/repos/polkadot-js/apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polkadot-js/apps/downloads","issues_url":"https://api.github.com/repos/polkadot-js/apps/issues{/number}","pulls_url":"https://api.github.com/repos/polkadot-js/apps/pulls{/number}","milestones_url":"https://api.github.com/repos/polkadot-js/apps/milestones{/number}","notifications_url":"https://api.github.com/repos/polkadot-js/apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polkadot-js/apps/labels{/name}","releases_url":"https://api.github.com/repos/polkadot-js/apps/releases{/id}","deployments_url":"https://api.github.com/repos/polkadot-js/apps/deployments","created_at":"2018-04-09T07:41:34Z","updated_at":"2018-07-31T13:34:56Z","pushed_at":"2018-08-01T05:42:55Z","git_url":"git://github.com/polkadot-js/apps.git","ssh_url":"git@github.com:polkadot-js/apps.git","clone_url":"https://github.com/polkadot-js/apps.git","svn_url":"https://github.com/polkadot-js/apps","homepage":"https://polkadot.js.org/apps/","size":24781,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":6,"open_issues":38,"watchers":16,"default_branch":"master"}},"base":{"label":"polkadot-js:master","ref":"master","sha":"fb9d0153c244152d0b480e36c212526a740d8980","user":{"login":"polkadot-js","id":33775474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/33775474?v=4","gravatar_id":"","url":"https://api.github.com/users/polkadot-js","html_url":"https://github.com/polkadot-js","followers_url":"https://api.github.com/users/polkadot-js/followers","following_url":"https://api.github.com/users/polkadot-js/following{/other_user}","gists_url":"https://api.github.com/users/polkadot-js/gists{/gist_id}","starred_url":"https://api.github.com/users/polkadot-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polkadot-js/subscriptions","organizations_url":"https://api.github.com/users/polkadot-js/orgs","repos_url":"https://api.github.com/users/polkadot-js/repos","events_url":"https://api.github.com/users/polkadot-js/events{/privacy}","received_events_url":"https://api.github.com/users/polkadot-js/received_events","type":"Organization","site_admin":false},"repo":{"id":128733562,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3MzM1NjI=","name":"apps","full_name":"polkadot-js/apps","owner":{"login":"polkadot-js","id":33775474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/33775474?v=4","gravatar_id":"","url":"https://api.github.com/users/polkadot-js","html_url":"https://github.com/polkadot-js","followers_url":"https://api.github.com/users/polkadot-js/followers","following_url":"https://api.github.com/users/polkadot-js/following{/other_user}","gists_url":"https://api.github.com/users/polkadot-js/gists{/gist_id}","starred_url":"https://api.github.com/users/polkadot-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polkadot-js/subscriptions","organizations_url":"https://api.github.com/users/polkadot-js/orgs","repos_url":"https://api.github.com/users/polkadot-js/repos","events_url":"https://api.github.com/users/polkadot-js/events{/privacy}","received_events_url":"https://api.github.com/users/polkadot-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/polkadot-js/apps","description":"Basic Polkadot/Substrate UI for interacting with a node","fork":false,"url":"https://api.github.com/repos/polkadot-js/apps","forks_url":"https://api.github.com/repos/polkadot-js/apps/forks","keys_url":"https://api.github.com/repos/polkadot-js/apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polkadot-js/apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polkadot-js/apps/teams","hooks_url":"https://api.github.com/repos/polkadot-js/apps/hooks","issue_events_url":"https://api.github.com/repos/polkadot-js/apps/issues/events{/number}","events_url":"https://api.github.com/repos/polkadot-js/apps/events","assignees_url":"https://api.github.com/repos/polkadot-js/apps/assignees{/user}","branches_url":"https://api.github.com/repos/polkadot-js/apps/branches{/branch}","tags_url":"https://api.github.com/repos/polkadot-js/apps/tags","blobs_url":"https://api.github.com/repos/polkadot-js/apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polkadot-js/apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polkadot-js/apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/polkadot-js/apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polkadot-js/apps/statuses/{sha}","languages_url":"https://api.github.com/repos/polkadot-js/apps/languages","stargazers_url":"https://api.github.com/repos/polkadot-js/apps/stargazers","contributors_url":"https://api.github.com/repos/polkadot-js/apps/contributors","subscribers_url":"https://api.github.com/repos/polkadot-js/apps/subscribers","subscription_url":"https://api.github.com/repos/polkadot-js/apps/subscription","commits_url":"https://api.github.com/repos/polkadot-js/apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/polkadot-js/apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/polkadot-js/apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/polkadot-js/apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/polkadot-js/apps/contents/{+path}","compare_url":"https://api.github.com/repos/polkadot-js/apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polkadot-js/apps/merges","archive_url":"https://api.github.com/repos/polkadot-js/apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polkadot-js/apps/downloads","issues_url":"https://api.github.com/repos/polkadot-js/apps/issues{/number}","pulls_url":"https://api.github.com/repos/polkadot-js/apps/pulls{/number}","milestones_url":"https://api.github.com/repos/polkadot-js/apps/milestones{/number}","notifications_url":"https://api.github.com/repos/polkadot-js/apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polkadot-js/apps/labels{/name}","releases_url":"https://api.github.com/repos/polkadot-js/apps/releases{/id}","deployments_url":"https://api.github.com/repos/polkadot-js/apps/deployments","created_at":"2018-04-09T07:41:34Z","updated_at":"2018-07-31T13:34:56Z","pushed_at":"2018-08-01T05:42:55Z","git_url":"git://github.com/polkadot-js/apps.git","ssh_url":"git@github.com:polkadot-js/apps.git","clone_url":"https://github.com/polkadot-js/apps.git","svn_url":"https://github.com/polkadot-js/apps","homepage":"https://polkadot.js.org/apps/","size":24781,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":6,"open_issues":38,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/polkadot-js/apps/pulls/168"},"html":{"href":"https://github.com/polkadot-js/apps/pull/168"},"issue":{"href":"https://api.github.com/repos/polkadot-js/apps/issues/168"},"comments":{"href":"https://api.github.com/repos/polkadot-js/apps/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/polkadot-js/apps/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/polkadot-js/apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/polkadot-js/apps/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/polkadot-js/apps/statuses/832326a0b2993000c5038249906dd8925601d764"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":153,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"ltfschoen"}}