{"action":"closed","number":794,"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-tools/pulls/794","id":193745017,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzQ1MDE3","html_url":"https://github.com/firebase/firebase-tools/pull/794","diff_url":"https://github.com/firebase/firebase-tools/pull/794.diff","patch_url":"https://github.com/firebase/firebase-tools/pull/794.patch","issue_url":"https://api.github.com/repos/firebase/firebase-tools/issues/794","number":794,"state":"closed","locked":false,"title":"expose firestore.rules check independent from deploy","user":{"login":"eleith","id":284832,"node_id":"MDQ6VXNlcjI4NDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/284832?v=4","gravatar_id":"","url":"https://api.github.com/users/eleith","html_url":"https://github.com/eleith","followers_url":"https://api.github.com/users/eleith/followers","following_url":"https://api.github.com/users/eleith/following{/other_user}","gists_url":"https://api.github.com/users/eleith/gists{/gist_id}","starred_url":"https://api.github.com/users/eleith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleith/subscriptions","organizations_url":"https://api.github.com/users/eleith/orgs","repos_url":"https://api.github.com/users/eleith/repos","events_url":"https://api.github.com/users/eleith/events{/privacy}","received_events_url":"https://api.github.com/users/eleith/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nthis PR exposes the firestore.rules compilation check that is coupled with the deploy step.\r\n\r\nby exposing this step, you can test that the rules are in good shape as a pre-hook, within your testing stage of your CI or just for fun.\r\n\r\nsuch a command would prevent a \"gotcha\" where during deploy in a CI pipeline, you get a compilation failure. \r\n\t \r\n### Scenarios Tested\r\n\r\nran the command on a working firestore.rules and exit with 0\r\nran the command on a malformed firestore.rules and did not exit with 0\r\n\r\n### Sample Commands\r\n\r\nfirebase firestore:rules:check","created_at":"2018-06-08T23:43:13Z","updated_at":"2018-06-22T00:20:20Z","closed_at":"2018-06-22T00:20:19Z","merged_at":null,"merge_commit_sha":"ba11e59298e76dab740ef312e8fc94642e3a67e8","assignee":{"login":"mbleigh","id":1022,"node_id":"MDQ6VXNlcjEwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1022?v=4","gravatar_id":"","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbleigh","id":1022,"node_id":"MDQ6VXNlcjEwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1022?v=4","gravatar_id":"","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mbleigh","id":1022,"node_id":"MDQ6VXNlcjEwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1022?v=4","gravatar_id":"","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/794/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/794/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-tools/issues/794/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-tools/statuses/48b1ddc7301806b9fdd5f5a01739037daf806e16","head":{"label":"eleith:eleith/expose-firestore-rules-check","ref":"eleith/expose-firestore-rules-check","sha":"48b1ddc7301806b9fdd5f5a01739037daf806e16","user":{"login":"eleith","id":284832,"node_id":"MDQ6VXNlcjI4NDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/284832?v=4","gravatar_id":"","url":"https://api.github.com/users/eleith","html_url":"https://github.com/eleith","followers_url":"https://api.github.com/users/eleith/followers","following_url":"https://api.github.com/users/eleith/following{/other_user}","gists_url":"https://api.github.com/users/eleith/gists{/gist_id}","starred_url":"https://api.github.com/users/eleith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleith/subscriptions","organizations_url":"https://api.github.com/users/eleith/orgs","repos_url":"https://api.github.com/users/eleith/repos","events_url":"https://api.github.com/users/eleith/events{/privacy}","received_events_url":"https://api.github.com/users/eleith/received_events","type":"User","site_admin":false},"repo":{"id":136673006,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NzMwMDY=","name":"firebase-tools","full_name":"eleith/firebase-tools","owner":{"login":"eleith","id":284832,"node_id":"MDQ6VXNlcjI4NDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/284832?v=4","gravatar_id":"","url":"https://api.github.com/users/eleith","html_url":"https://github.com/eleith","followers_url":"https://api.github.com/users/eleith/followers","following_url":"https://api.github.com/users/eleith/following{/other_user}","gists_url":"https://api.github.com/users/eleith/gists{/gist_id}","starred_url":"https://api.github.com/users/eleith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleith/subscriptions","organizations_url":"https://api.github.com/users/eleith/orgs","repos_url":"https://api.github.com/users/eleith/repos","events_url":"https://api.github.com/users/eleith/events{/privacy}","received_events_url":"https://api.github.com/users/eleith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eleith/firebase-tools","description":"The Firebase Command Line Tools","fork":true,"url":"https://api.github.com/repos/eleith/firebase-tools","forks_url":"https://api.github.com/repos/eleith/firebase-tools/forks","keys_url":"https://api.github.com/repos/eleith/firebase-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eleith/firebase-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eleith/firebase-tools/teams","hooks_url":"https://api.github.com/repos/eleith/firebase-tools/hooks","issue_events_url":"https://api.github.com/repos/eleith/firebase-tools/issues/events{/number}","events_url":"https://api.github.com/repos/eleith/firebase-tools/events","assignees_url":"https://api.github.com/repos/eleith/firebase-tools/assignees{/user}","branches_url":"https://api.github.com/repos/eleith/firebase-tools/branches{/branch}","tags_url":"https://api.github.com/repos/eleith/firebase-tools/tags","blobs_url":"https://api.github.com/repos/eleith/firebase-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eleith/firebase-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eleith/firebase-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/eleith/firebase-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eleith/firebase-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/eleith/firebase-tools/languages","stargazers_url":"https://api.github.com/repos/eleith/firebase-tools/stargazers","contributors_url":"https://api.github.com/repos/eleith/firebase-tools/contributors","subscribers_url":"https://api.github.com/repos/eleith/firebase-tools/subscribers","subscription_url":"https://api.github.com/repos/eleith/firebase-tools/subscription","commits_url":"https://api.github.com/repos/eleith/firebase-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/eleith/firebase-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/eleith/firebase-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/eleith/firebase-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/eleith/firebase-tools/contents/{+path}","compare_url":"https://api.github.com/repos/eleith/firebase-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eleith/firebase-tools/merges","archive_url":"https://api.github.com/repos/eleith/firebase-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eleith/firebase-tools/downloads","issues_url":"https://api.github.com/repos/eleith/firebase-tools/issues{/number}","pulls_url":"https://api.github.com/repos/eleith/firebase-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/eleith/firebase-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/eleith/firebase-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eleith/firebase-tools/labels{/name}","releases_url":"https://api.github.com/repos/eleith/firebase-tools/releases{/id}","deployments_url":"https://api.github.com/repos/eleith/firebase-tools/deployments","created_at":"2018-06-08T22:55:19Z","updated_at":"2018-06-08T22:55:21Z","pushed_at":"2018-06-08T23:45:32Z","git_url":"git://github.com/eleith/firebase-tools.git","ssh_url":"git@github.com:eleith/firebase-tools.git","clone_url":"https://github.com/eleith/firebase-tools.git","svn_url":"https://github.com/eleith/firebase-tools","homepage":"","size":1387,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"592a288d3b23cbcde2faa41b5635a746f14f18c7","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":15402300,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMjMwMA==","name":"firebase-tools","full_name":"firebase/firebase-tools","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-tools","description":"The Firebase Command Line Tools","fork":false,"url":"https://api.github.com/repos/firebase/firebase-tools","forks_url":"https://api.github.com/repos/firebase/firebase-tools/forks","keys_url":"https://api.github.com/repos/firebase/firebase-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-tools/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-tools/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-tools/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-tools/events","assignees_url":"https://api.github.com/repos/firebase/firebase-tools/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-tools/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-tools/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-tools/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-tools/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-tools/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-tools/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-tools/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-tools/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-tools/merges","archive_url":"https://api.github.com/repos/firebase/firebase-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-tools/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-tools/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-tools/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-tools/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-tools/deployments","created_at":"2013-12-23T18:53:04Z","updated_at":"2018-06-21T23:44:45Z","pushed_at":"2018-06-21T23:46:04Z","git_url":"git://github.com/firebase/firebase-tools.git","ssh_url":"git@github.com:firebase/firebase-tools.git","clone_url":"https://github.com/firebase/firebase-tools.git","svn_url":"https://github.com/firebase/firebase-tools","homepage":"","size":1390,"stargazers_count":1122,"watchers_count":1122,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":189,"open_issues":114,"watchers":1122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/794"},"html":{"href":"https://github.com/firebase/firebase-tools/pull/794"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-tools/issues/794"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-tools/issues/794/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/794/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/794/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-tools/statuses/48b1ddc7301806b9fdd5f5a01739037daf806e16"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":16,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"mbleigh"}}