{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/comments/190671432","pull_request_review_id":123098882,"id":190671432,"diff_hunk":"@@ -81,39 +76,11 @@ static Sharding forString(final String sharding)\n     /**\n      * Generate shards. This needs to be deterministic!\n      *\n-     * @param multiPolygon\n+     * @param surface\n      *            The bounds to limit the shards.\n      * @return The shards {@link Iterable}.\n      */\n-    default Iterable<? extends Shard> shards(final MultiPolygon multiPolygon)","path":"src/main/java/org/openstreetmap/atlas/geography/sharding/Sharding.java","position":29,"original_position":29,"commit_id":"1318eb0aece18fdef296fce813035d849c6c8c29","original_commit_id":"1318eb0aece18fdef296fce813035d849c6c8c29","user":{"login":"jklamer","id":9659948,"avatar_url":"https://avatars1.githubusercontent.com/u/9659948?v=4","gravatar_id":"","url":"https://api.github.com/users/jklamer","html_url":"https://github.com/jklamer","followers_url":"https://api.github.com/users/jklamer/followers","following_url":"https://api.github.com/users/jklamer/following{/other_user}","gists_url":"https://api.github.com/users/jklamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jklamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklamer/subscriptions","organizations_url":"https://api.github.com/users/jklamer/orgs","repos_url":"https://api.github.com/users/jklamer/repos","events_url":"https://api.github.com/users/jklamer/events{/privacy}","received_events_url":"https://api.github.com/users/jklamer/received_events","type":"User","site_admin":false},"body":"Both Polygon and MultiPolygon are GeometricSurfaces. That interface contains the contract for the overlapping logic that is in this default function. Ideally, all MultiPolygon intersection is handled by the shape class and no implementation knowledge is needed. Deleting this removes duplicate work and prevents it breaking if MultiPolygon implementation is ever changed. ","created_at":"2018-05-24T17:38:45Z","updated_at":"2018-05-24T17:38:45Z","html_url":"https://github.com/osmlab/atlas/pull/130#discussion_r190671432","pull_request_url":"https://api.github.com/repos/osmlab/atlas/pulls/130","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments/190671432"},"html":{"href":"https://github.com/osmlab/atlas/pull/130#discussion_r190671432"},"pull_request":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/130"}},"in_reply_to_id":190663016},"pull_request":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/130","id":189792722,"html_url":"https://github.com/osmlab/atlas/pull/130","diff_url":"https://github.com/osmlab/atlas/pull/130.diff","patch_url":"https://github.com/osmlab/atlas/pull/130.patch","issue_url":"https://api.github.com/repos/osmlab/atlas/issues/130","number":130,"state":"open","locked":false,"title":"Geometric surface for sharding","user":{"login":"jklamer","id":9659948,"avatar_url":"https://avatars1.githubusercontent.com/u/9659948?v=4","gravatar_id":"","url":"https://api.github.com/users/jklamer","html_url":"https://github.com/jklamer","followers_url":"https://api.github.com/users/jklamer/followers","following_url":"https://api.github.com/users/jklamer/following{/other_user}","gists_url":"https://api.github.com/users/jklamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jklamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklamer/subscriptions","organizations_url":"https://api.github.com/users/jklamer/orgs","repos_url":"https://api.github.com/users/jklamer/repos","events_url":"https://api.github.com/users/jklamer/events{/privacy}","received_events_url":"https://api.github.com/users/jklamer/received_events","type":"User","site_admin":false},"body":"Use GeometricSurface to simplify and expand sharding code. ","created_at":"2018-05-22T21:07:40Z","updated_at":"2018-05-24T17:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cfb519225740f375702471c77866fe0c4565549","assignee":{"login":"jwpgage","id":17519075,"avatar_url":"https://avatars0.githubusercontent.com/u/17519075?v=4","gravatar_id":"","url":"https://api.github.com/users/jwpgage","html_url":"https://github.com/jwpgage","followers_url":"https://api.github.com/users/jwpgage/followers","following_url":"https://api.github.com/users/jwpgage/following{/other_user}","gists_url":"https://api.github.com/users/jwpgage/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpgage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpgage/subscriptions","organizations_url":"https://api.github.com/users/jwpgage/orgs","repos_url":"https://api.github.com/users/jwpgage/repos","events_url":"https://api.github.com/users/jwpgage/events{/privacy}","received_events_url":"https://api.github.com/users/jwpgage/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwpgage","id":17519075,"avatar_url":"https://avatars0.githubusercontent.com/u/17519075?v=4","gravatar_id":"","url":"https://api.github.com/users/jwpgage","html_url":"https://github.com/jwpgage","followers_url":"https://api.github.com/users/jwpgage/followers","following_url":"https://api.github.com/users/jwpgage/following{/other_user}","gists_url":"https://api.github.com/users/jwpgage/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpgage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpgage/subscriptions","organizations_url":"https://api.github.com/users/jwpgage/orgs","repos_url":"https://api.github.com/users/jwpgage/repos","events_url":"https://api.github.com/users/jwpgage/events{/privacy}","received_events_url":"https://api.github.com/users/jwpgage/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/atlas/pulls/130/commits","review_comments_url":"https://api.github.com/repos/osmlab/atlas/pulls/130/comments","review_comment_url":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/atlas/issues/130/comments","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/1318eb0aece18fdef296fce813035d849c6c8c29","head":{"label":"jklamer:GeometricSurfaceInSharding","ref":"GeometricSurfaceInSharding","sha":"1318eb0aece18fdef296fce813035d849c6c8c29","user":{"login":"jklamer","id":9659948,"avatar_url":"https://avatars1.githubusercontent.com/u/9659948?v=4","gravatar_id":"","url":"https://api.github.com/users/jklamer","html_url":"https://github.com/jklamer","followers_url":"https://api.github.com/users/jklamer/followers","following_url":"https://api.github.com/users/jklamer/following{/other_user}","gists_url":"https://api.github.com/users/jklamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jklamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklamer/subscriptions","organizations_url":"https://api.github.com/users/jklamer/orgs","repos_url":"https://api.github.com/users/jklamer/repos","events_url":"https://api.github.com/users/jklamer/events{/privacy}","received_events_url":"https://api.github.com/users/jklamer/received_events","type":"User","site_admin":false},"repo":{"id":102770658,"name":"atlas","full_name":"jklamer/atlas","owner":{"login":"jklamer","id":9659948,"avatar_url":"https://avatars1.githubusercontent.com/u/9659948?v=4","gravatar_id":"","url":"https://api.github.com/users/jklamer","html_url":"https://github.com/jklamer","followers_url":"https://api.github.com/users/jklamer/followers","following_url":"https://api.github.com/users/jklamer/following{/other_user}","gists_url":"https://api.github.com/users/jklamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jklamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklamer/subscriptions","organizations_url":"https://api.github.com/users/jklamer/orgs","repos_url":"https://api.github.com/users/jklamer/repos","events_url":"https://api.github.com/users/jklamer/events{/privacy}","received_events_url":"https://api.github.com/users/jklamer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklamer/atlas","description":"OSM in memory","fork":true,"url":"https://api.github.com/repos/jklamer/atlas","forks_url":"https://api.github.com/repos/jklamer/atlas/forks","keys_url":"https://api.github.com/repos/jklamer/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklamer/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklamer/atlas/teams","hooks_url":"https://api.github.com/repos/jklamer/atlas/hooks","issue_events_url":"https://api.github.com/repos/jklamer/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/jklamer/atlas/events","assignees_url":"https://api.github.com/repos/jklamer/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/jklamer/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/jklamer/atlas/tags","blobs_url":"https://api.github.com/repos/jklamer/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklamer/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklamer/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklamer/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklamer/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/jklamer/atlas/languages","stargazers_url":"https://api.github.com/repos/jklamer/atlas/stargazers","contributors_url":"https://api.github.com/repos/jklamer/atlas/contributors","subscribers_url":"https://api.github.com/repos/jklamer/atlas/subscribers","subscription_url":"https://api.github.com/repos/jklamer/atlas/subscription","commits_url":"https://api.github.com/repos/jklamer/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklamer/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklamer/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklamer/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklamer/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/jklamer/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklamer/atlas/merges","archive_url":"https://api.github.com/repos/jklamer/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklamer/atlas/downloads","issues_url":"https://api.github.com/repos/jklamer/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/jklamer/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/jklamer/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/jklamer/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklamer/atlas/labels{/name}","releases_url":"https://api.github.com/repos/jklamer/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/jklamer/atlas/deployments","created_at":"2017-09-07T18:15:31Z","updated_at":"2018-05-22T20:46:03Z","pushed_at":"2018-05-22T21:42:05Z","git_url":"git://github.com/jklamer/atlas.git","ssh_url":"git@github.com:jklamer/atlas.git","clone_url":"https://github.com/jklamer/atlas.git","svn_url":"https://github.com/jklamer/atlas","homepage":null,"size":52633,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"osmlab:dev","ref":"dev","sha":"41df9d4cb5aa281e3d74f6f398b829185930007e","user":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":99717758,"name":"atlas","full_name":"osmlab/atlas","owner":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmlab/atlas","description":"OSM in memory","fork":false,"url":"https://api.github.com/repos/osmlab/atlas","forks_url":"https://api.github.com/repos/osmlab/atlas/forks","keys_url":"https://api.github.com/repos/osmlab/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/atlas/teams","hooks_url":"https://api.github.com/repos/osmlab/atlas/hooks","issue_events_url":"https://api.github.com/repos/osmlab/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/atlas/events","assignees_url":"https://api.github.com/repos/osmlab/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/atlas/tags","blobs_url":"https://api.github.com/repos/osmlab/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/atlas/languages","stargazers_url":"https://api.github.com/repos/osmlab/atlas/stargazers","contributors_url":"https://api.github.com/repos/osmlab/atlas/contributors","subscribers_url":"https://api.github.com/repos/osmlab/atlas/subscribers","subscription_url":"https://api.github.com/repos/osmlab/atlas/subscription","commits_url":"https://api.github.com/repos/osmlab/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/atlas/merges","archive_url":"https://api.github.com/repos/osmlab/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/atlas/downloads","issues_url":"https://api.github.com/repos/osmlab/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/atlas/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/atlas/deployments","created_at":"2017-08-08T17:14:27Z","updated_at":"2018-05-24T16:48:24Z","pushed_at":"2018-05-24T16:53:30Z","git_url":"git://github.com/osmlab/atlas.git","ssh_url":"git@github.com:osmlab/atlas.git","clone_url":"https://github.com/osmlab/atlas.git","svn_url":"https://github.com/osmlab/atlas","homepage":null,"size":52619,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":27,"open_issues":10,"watchers":63,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/130"},"html":{"href":"https://github.com/osmlab/atlas/pull/130"},"issue":{"href":"https://api.github.com/repos/osmlab/atlas/issues/130"},"comments":{"href":"https://api.github.com/repos/osmlab/atlas/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/atlas/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/atlas/statuses/1318eb0aece18fdef296fce813035d849c6c8c29"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jklamer"}}