{"action":"created","comment":{"url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/comments/211779402","pull_request_review_id":148274659,"id":211779402,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc3OTQwMg==","diff_hunk":"@@ -347,11 +318,74 @@ func changeDetected(parent *CloudEndpoint, children *CloudEndpointControllerRequ\n \t\t\t\t}\n \t\t\t}\n \t\t}\n+\n+\t\tif parent.Spec.OpenAPISpecConfigMap.Name != \"\" {\n+\t\t\tspecData, err := getConfigMapSpecData(parent.ObjectMeta.Namespace, parent.Spec.OpenAPISpecConfigMap.Name, parent.Spec.OpenAPISpecConfigMap.Key)\n+\t\t\tif err != nil || toSha1(specData) != status.ConfigMapHash {\n+\t\t\t\tlog.Printf(\"[DEBUG][%s] Changed because configmap spec changed.\", parent.Name)\n+\t\t\t\tchanged = true\n+\t\t\t}\n+\t\t}\n \t}\n \n \treturn changed\n }\n \n+func getTargetIngress(parent *CloudEndpoint) (string, []string, error) {\n+\tvar target string\n+\tvar jwtAudiences []string\n+\n+\tingress, err := config.clientset.ExtensionsV1beta1().Ingresses(parent.Spec.TargetIngress.Namespace).Get(parent.Spec.TargetIngress.Name, metav1.GetOptions{})\n+\tif err != nil {\n+\t\tlog.Printf(\"[INFO][%s] waiting for Ingress %s\", parent.Name, parent.Spec.TargetIngress.Name)\n+\t\treturn \"\", nil, err","path":"cmd/cloud-endpoints-controller/main.go","position":188,"original_position":188,"commit_id":"d441adfb40e265248b5b6004848bfaf6ea5f3024","original_commit_id":"d441adfb40e265248b5b6004848bfaf6ea5f3024","user":{"login":"danisla","id":323725,"node_id":"MDQ6VXNlcjMyMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"body":"This should be returning a nil error, not the actual error because waiting for ingress is a nominal state, not a fatal error.\r\n\r\nThis func should only return a non-nill error if something off-nominal happened.","created_at":"2018-08-21T22:25:57Z","updated_at":"2018-08-21T22:25:57Z","html_url":"https://github.com/danisla/cloud-endpoints-controller/pull/6#discussion_r211779402","pull_request_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/comments/211779402"},"html":{"href":"https://github.com/danisla/cloud-endpoints-controller/pull/6#discussion_r211779402"},"pull_request":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6","id":209957811,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTU3ODEx","html_url":"https://github.com/danisla/cloud-endpoints-controller/pull/6","diff_url":"https://github.com/danisla/cloud-endpoints-controller/pull/6.diff","patch_url":"https://github.com/danisla/cloud-endpoints-controller/pull/6.patch","issue_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/6","number":6,"state":"open","locked":false,"title":"  Add template-ified spec for CloudEndpoint manifest and for ConfigMap.","user":{"login":"johnlabarge","id":965310,"node_id":"MDQ6VXNlcjk2NTMxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/965310?v=4","gravatar_id":"","url":"https://api.github.com/users/johnlabarge","html_url":"https://github.com/johnlabarge","followers_url":"https://api.github.com/users/johnlabarge/followers","following_url":"https://api.github.com/users/johnlabarge/following{/other_user}","gists_url":"https://api.github.com/users/johnlabarge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnlabarge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnlabarge/subscriptions","organizations_url":"https://api.github.com/users/johnlabarge/orgs","repos_url":"https://api.github.com/users/johnlabarge/repos","events_url":"https://api.github.com/users/johnlabarge/events{/privacy}","received_events_url":"https://api.github.com/users/johnlabarge/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-21T21:14:07Z","updated_at":"2018-08-21T22:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d00d17848b930dddbf4844d9dadb22f7fecb5bdd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6/commits","review_comments_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6/comments","review_comment_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/6/comments","statuses_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/statuses/d441adfb40e265248b5b6004848bfaf6ea5f3024","head":{"label":"johnlabarge:template-spec","ref":"template-spec","sha":"d441adfb40e265248b5b6004848bfaf6ea5f3024","user":{"login":"johnlabarge","id":965310,"node_id":"MDQ6VXNlcjk2NTMxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/965310?v=4","gravatar_id":"","url":"https://api.github.com/users/johnlabarge","html_url":"https://github.com/johnlabarge","followers_url":"https://api.github.com/users/johnlabarge/followers","following_url":"https://api.github.com/users/johnlabarge/following{/other_user}","gists_url":"https://api.github.com/users/johnlabarge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnlabarge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnlabarge/subscriptions","organizations_url":"https://api.github.com/users/johnlabarge/orgs","repos_url":"https://api.github.com/users/johnlabarge/repos","events_url":"https://api.github.com/users/johnlabarge/events{/privacy}","received_events_url":"https://api.github.com/users/johnlabarge/received_events","type":"User","site_admin":false},"repo":{"id":143477756,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0Nzc3NTY=","name":"cloud-endpoints-controller","full_name":"johnlabarge/cloud-endpoints-controller","owner":{"login":"johnlabarge","id":965310,"node_id":"MDQ6VXNlcjk2NTMxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/965310?v=4","gravatar_id":"","url":"https://api.github.com/users/johnlabarge","html_url":"https://github.com/johnlabarge","followers_url":"https://api.github.com/users/johnlabarge/followers","following_url":"https://api.github.com/users/johnlabarge/following{/other_user}","gists_url":"https://api.github.com/users/johnlabarge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnlabarge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnlabarge/subscriptions","organizations_url":"https://api.github.com/users/johnlabarge/orgs","repos_url":"https://api.github.com/users/johnlabarge/repos","events_url":"https://api.github.com/users/johnlabarge/events{/privacy}","received_events_url":"https://api.github.com/users/johnlabarge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnlabarge/cloud-endpoints-controller","description":"Cloud Endpoints CRD and controller for Kubernetes","fork":true,"url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller","forks_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/forks","keys_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/teams","hooks_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/hooks","issue_events_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/issues/events{/number}","events_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/events","assignees_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/assignees{/user}","branches_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/branches{/branch}","tags_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/tags","blobs_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/languages","stargazers_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/stargazers","contributors_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/contributors","subscribers_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/subscribers","subscription_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/subscription","commits_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/contents/{+path}","compare_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/merges","archive_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/downloads","issues_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/issues{/number}","pulls_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/labels{/name}","releases_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/releases{/id}","deployments_url":"https://api.github.com/repos/johnlabarge/cloud-endpoints-controller/deployments","created_at":"2018-08-03T22:15:25Z","updated_at":"2018-08-13T14:54:25Z","pushed_at":"2018-08-21T22:05:46Z","git_url":"git://github.com/johnlabarge/cloud-endpoints-controller.git","ssh_url":"git@github.com:johnlabarge/cloud-endpoints-controller.git","clone_url":"https://github.com/johnlabarge/cloud-endpoints-controller.git","svn_url":"https://github.com/johnlabarge/cloud-endpoints-controller","homepage":null,"size":566,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danisla:master","ref":"master","sha":"766fe0466440b8fdc62fe1e6b6e2730d19d5f3b6","user":{"login":"danisla","id":323725,"node_id":"MDQ6VXNlcjMyMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"repo":{"id":126248721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNDg3MjE=","name":"cloud-endpoints-controller","full_name":"danisla/cloud-endpoints-controller","owner":{"login":"danisla","id":323725,"node_id":"MDQ6VXNlcjMyMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danisla/cloud-endpoints-controller","description":"Cloud Endpoints CRD and controller for Kubernetes","fork":false,"url":"https://api.github.com/repos/danisla/cloud-endpoints-controller","forks_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/forks","keys_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/teams","hooks_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/hooks","issue_events_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/events{/number}","events_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/events","assignees_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/assignees{/user}","branches_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/branches{/branch}","tags_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/tags","blobs_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/languages","stargazers_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/stargazers","contributors_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/contributors","subscribers_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/subscribers","subscription_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/subscription","commits_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/contents/{+path}","compare_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/merges","archive_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/downloads","issues_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues{/number}","pulls_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/labels{/name}","releases_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/releases{/id}","deployments_url":"https://api.github.com/repos/danisla/cloud-endpoints-controller/deployments","created_at":"2018-03-21T22:36:37Z","updated_at":"2018-08-15T17:23:33Z","pushed_at":"2018-08-21T22:05:48Z","git_url":"git://github.com/danisla/cloud-endpoints-controller.git","ssh_url":"git@github.com:danisla/cloud-endpoints-controller.git","clone_url":"https://github.com/danisla/cloud-endpoints-controller.git","svn_url":"https://github.com/danisla/cloud-endpoints-controller","homepage":null,"size":566,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6"},"html":{"href":"https://github.com/danisla/cloud-endpoints-controller/pull/6"},"issue":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/6"},"comments":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/danisla/cloud-endpoints-controller/statuses/d441adfb40e265248b5b6004848bfaf6ea5f3024"}},"author_association":"NONE"}}
{"actor":{"display_login":"danisla"}}