{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56","id":232646415,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjQ2NDE1","html_url":"https://github.com/jobec/django-auth-adfs/pull/56","diff_url":"https://github.com/jobec/django-auth-adfs/pull/56.diff","patch_url":"https://github.com/jobec/django-auth-adfs/pull/56.patch","issue_url":"https://api.github.com/repos/jobec/django-auth-adfs/issues/56","number":56,"state":"closed","locked":false,"title":"Client secret support","user":{"login":"quozd","id":2129162,"node_id":"MDQ6VXNlcjIxMjkxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2129162?v=4","gravatar_id":"","url":"https://api.github.com/users/quozd","html_url":"https://github.com/quozd","followers_url":"https://api.github.com/users/quozd/followers","following_url":"https://api.github.com/users/quozd/following{/other_user}","gists_url":"https://api.github.com/users/quozd/gists{/gist_id}","starred_url":"https://api.github.com/users/quozd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozd/subscriptions","organizations_url":"https://api.github.com/users/quozd/orgs","repos_url":"https://api.github.com/users/quozd/repos","events_url":"https://api.github.com/users/quozd/events{/privacy}","received_events_url":"https://api.github.com/users/quozd/received_events","type":"User","site_admin":false},"body":"Adds client_secret support.\r\n\r\nI also moved config loading from `__init__` to `authenticate` method. I think It's not a good idea to make network calls while object initialization as it's not obvious. Also it breaks tests which use `client.force_login` (force_login initializes all auth backends) if ADFS is not available, e.g. in separate private network.\r\n\r\nCloses #52","created_at":"2018-11-21T12:30:01Z","updated_at":"2018-11-21T20:14:17Z","closed_at":"2018-11-21T20:14:17Z","merged_at":"2018-11-21T20:14:17Z","merge_commit_sha":"900c16a5aa8c0869c56405f494fa1c0418b0ce33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56/commits","review_comments_url":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56/comments","review_comment_url":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jobec/django-auth-adfs/issues/56/comments","statuses_url":"https://api.github.com/repos/jobec/django-auth-adfs/statuses/e7b91dd26852fb55633c4c1e42f4d02e96e5baaf","head":{"label":"quozd:master","ref":"master","sha":"e7b91dd26852fb55633c4c1e42f4d02e96e5baaf","user":{"login":"quozd","id":2129162,"node_id":"MDQ6VXNlcjIxMjkxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2129162?v=4","gravatar_id":"","url":"https://api.github.com/users/quozd","html_url":"https://github.com/quozd","followers_url":"https://api.github.com/users/quozd/followers","following_url":"https://api.github.com/users/quozd/following{/other_user}","gists_url":"https://api.github.com/users/quozd/gists{/gist_id}","starred_url":"https://api.github.com/users/quozd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozd/subscriptions","organizations_url":"https://api.github.com/users/quozd/orgs","repos_url":"https://api.github.com/users/quozd/repos","events_url":"https://api.github.com/users/quozd/events{/privacy}","received_events_url":"https://api.github.com/users/quozd/received_events","type":"User","site_admin":false},"repo":{"id":157342380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczNDIzODA=","name":"django-auth-adfs","full_name":"quozd/django-auth-adfs","private":false,"owner":{"login":"quozd","id":2129162,"node_id":"MDQ6VXNlcjIxMjkxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2129162?v=4","gravatar_id":"","url":"https://api.github.com/users/quozd","html_url":"https://github.com/quozd","followers_url":"https://api.github.com/users/quozd/followers","following_url":"https://api.github.com/users/quozd/following{/other_user}","gists_url":"https://api.github.com/users/quozd/gists{/gist_id}","starred_url":"https://api.github.com/users/quozd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozd/subscriptions","organizations_url":"https://api.github.com/users/quozd/orgs","repos_url":"https://api.github.com/users/quozd/repos","events_url":"https://api.github.com/users/quozd/events{/privacy}","received_events_url":"https://api.github.com/users/quozd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/quozd/django-auth-adfs","description":"A Django authentication backend for Microsoft ADFS","fork":true,"url":"https://api.github.com/repos/quozd/django-auth-adfs","forks_url":"https://api.github.com/repos/quozd/django-auth-adfs/forks","keys_url":"https://api.github.com/repos/quozd/django-auth-adfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quozd/django-auth-adfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quozd/django-auth-adfs/teams","hooks_url":"https://api.github.com/repos/quozd/django-auth-adfs/hooks","issue_events_url":"https://api.github.com/repos/quozd/django-auth-adfs/issues/events{/number}","events_url":"https://api.github.com/repos/quozd/django-auth-adfs/events","assignees_url":"https://api.github.com/repos/quozd/django-auth-adfs/assignees{/user}","branches_url":"https://api.github.com/repos/quozd/django-auth-adfs/branches{/branch}","tags_url":"https://api.github.com/repos/quozd/django-auth-adfs/tags","blobs_url":"https://api.github.com/repos/quozd/django-auth-adfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quozd/django-auth-adfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quozd/django-auth-adfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/quozd/django-auth-adfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quozd/django-auth-adfs/statuses/{sha}","languages_url":"https://api.github.com/repos/quozd/django-auth-adfs/languages","stargazers_url":"https://api.github.com/repos/quozd/django-auth-adfs/stargazers","contributors_url":"https://api.github.com/repos/quozd/django-auth-adfs/contributors","subscribers_url":"https://api.github.com/repos/quozd/django-auth-adfs/subscribers","subscription_url":"https://api.github.com/repos/quozd/django-auth-adfs/subscription","commits_url":"https://api.github.com/repos/quozd/django-auth-adfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/quozd/django-auth-adfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/quozd/django-auth-adfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/quozd/django-auth-adfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/quozd/django-auth-adfs/contents/{+path}","compare_url":"https://api.github.com/repos/quozd/django-auth-adfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quozd/django-auth-adfs/merges","archive_url":"https://api.github.com/repos/quozd/django-auth-adfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quozd/django-auth-adfs/downloads","issues_url":"https://api.github.com/repos/quozd/django-auth-adfs/issues{/number}","pulls_url":"https://api.github.com/repos/quozd/django-auth-adfs/pulls{/number}","milestones_url":"https://api.github.com/repos/quozd/django-auth-adfs/milestones{/number}","notifications_url":"https://api.github.com/repos/quozd/django-auth-adfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quozd/django-auth-adfs/labels{/name}","releases_url":"https://api.github.com/repos/quozd/django-auth-adfs/releases{/id}","deployments_url":"https://api.github.com/repos/quozd/django-auth-adfs/deployments","created_at":"2018-11-13T08:00:56Z","updated_at":"2018-11-21T20:11:46Z","pushed_at":"2018-11-21T20:11:44Z","git_url":"git://github.com/quozd/django-auth-adfs.git","ssh_url":"git@github.com:quozd/django-auth-adfs.git","clone_url":"https://github.com/quozd/django-auth-adfs.git","svn_url":"https://github.com/quozd/django-auth-adfs","homepage":"","size":1566,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jobec:master","ref":"master","sha":"f5a138f3eb9ba79f4a762e24f068c66a2f6c4279","user":{"login":"jobec","id":16192496,"node_id":"MDQ6VXNlcjE2MTkyNDk2","avatar_url":"https://avatars3.githubusercontent.com/u/16192496?v=4","gravatar_id":"","url":"https://api.github.com/users/jobec","html_url":"https://github.com/jobec","followers_url":"https://api.github.com/users/jobec/followers","following_url":"https://api.github.com/users/jobec/following{/other_user}","gists_url":"https://api.github.com/users/jobec/gists{/gist_id}","starred_url":"https://api.github.com/users/jobec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobec/subscriptions","organizations_url":"https://api.github.com/users/jobec/orgs","repos_url":"https://api.github.com/users/jobec/repos","events_url":"https://api.github.com/users/jobec/events{/privacy}","received_events_url":"https://api.github.com/users/jobec/received_events","type":"User","site_admin":false},"repo":{"id":51428483,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQyODQ4Mw==","name":"django-auth-adfs","full_name":"jobec/django-auth-adfs","private":false,"owner":{"login":"jobec","id":16192496,"node_id":"MDQ6VXNlcjE2MTkyNDk2","avatar_url":"https://avatars3.githubusercontent.com/u/16192496?v=4","gravatar_id":"","url":"https://api.github.com/users/jobec","html_url":"https://github.com/jobec","followers_url":"https://api.github.com/users/jobec/followers","following_url":"https://api.github.com/users/jobec/following{/other_user}","gists_url":"https://api.github.com/users/jobec/gists{/gist_id}","starred_url":"https://api.github.com/users/jobec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobec/subscriptions","organizations_url":"https://api.github.com/users/jobec/orgs","repos_url":"https://api.github.com/users/jobec/repos","events_url":"https://api.github.com/users/jobec/events{/privacy}","received_events_url":"https://api.github.com/users/jobec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jobec/django-auth-adfs","description":"A Django authentication backend for Microsoft ADFS","fork":false,"url":"https://api.github.com/repos/jobec/django-auth-adfs","forks_url":"https://api.github.com/repos/jobec/django-auth-adfs/forks","keys_url":"https://api.github.com/repos/jobec/django-auth-adfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jobec/django-auth-adfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jobec/django-auth-adfs/teams","hooks_url":"https://api.github.com/repos/jobec/django-auth-adfs/hooks","issue_events_url":"https://api.github.com/repos/jobec/django-auth-adfs/issues/events{/number}","events_url":"https://api.github.com/repos/jobec/django-auth-adfs/events","assignees_url":"https://api.github.com/repos/jobec/django-auth-adfs/assignees{/user}","branches_url":"https://api.github.com/repos/jobec/django-auth-adfs/branches{/branch}","tags_url":"https://api.github.com/repos/jobec/django-auth-adfs/tags","blobs_url":"https://api.github.com/repos/jobec/django-auth-adfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jobec/django-auth-adfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jobec/django-auth-adfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jobec/django-auth-adfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jobec/django-auth-adfs/statuses/{sha}","languages_url":"https://api.github.com/repos/jobec/django-auth-adfs/languages","stargazers_url":"https://api.github.com/repos/jobec/django-auth-adfs/stargazers","contributors_url":"https://api.github.com/repos/jobec/django-auth-adfs/contributors","subscribers_url":"https://api.github.com/repos/jobec/django-auth-adfs/subscribers","subscription_url":"https://api.github.com/repos/jobec/django-auth-adfs/subscription","commits_url":"https://api.github.com/repos/jobec/django-auth-adfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jobec/django-auth-adfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jobec/django-auth-adfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jobec/django-auth-adfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jobec/django-auth-adfs/contents/{+path}","compare_url":"https://api.github.com/repos/jobec/django-auth-adfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jobec/django-auth-adfs/merges","archive_url":"https://api.github.com/repos/jobec/django-auth-adfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jobec/django-auth-adfs/downloads","issues_url":"https://api.github.com/repos/jobec/django-auth-adfs/issues{/number}","pulls_url":"https://api.github.com/repos/jobec/django-auth-adfs/pulls{/number}","milestones_url":"https://api.github.com/repos/jobec/django-auth-adfs/milestones{/number}","notifications_url":"https://api.github.com/repos/jobec/django-auth-adfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jobec/django-auth-adfs/labels{/name}","releases_url":"https://api.github.com/repos/jobec/django-auth-adfs/releases{/id}","deployments_url":"https://api.github.com/repos/jobec/django-auth-adfs/deployments","created_at":"2016-02-10T08:15:03Z","updated_at":"2018-11-16T21:00:38Z","pushed_at":"2018-11-21T20:14:17Z","git_url":"git://github.com/jobec/django-auth-adfs.git","ssh_url":"git@github.com:jobec/django-auth-adfs.git","clone_url":"https://github.com/jobec/django-auth-adfs.git","svn_url":"https://github.com/jobec/django-auth-adfs","homepage":"","size":1575,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":17,"open_issues":2,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56"},"html":{"href":"https://github.com/jobec/django-auth-adfs/pull/56"},"issue":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/issues/56"},"comments":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/jobec/django-auth-adfs/statuses/e7b91dd26852fb55633c4c1e42f4d02e96e5baaf"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jobec","id":16192496,"node_id":"MDQ6VXNlcjE2MTkyNDk2","avatar_url":"https://avatars3.githubusercontent.com/u/16192496?v=4","gravatar_id":"","url":"https://api.github.com/users/jobec","html_url":"https://github.com/jobec","followers_url":"https://api.github.com/users/jobec/followers","following_url":"https://api.github.com/users/jobec/following{/other_user}","gists_url":"https://api.github.com/users/jobec/gists{/gist_id}","starred_url":"https://api.github.com/users/jobec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobec/subscriptions","organizations_url":"https://api.github.com/users/jobec/orgs","repos_url":"https://api.github.com/users/jobec/repos","events_url":"https://api.github.com/users/jobec/events{/privacy}","received_events_url":"https://api.github.com/users/jobec/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":15,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"jobec"}}