{"action":"closed","issue":{"url":"https://api.github.com/repos/apple/foundationdb/issues/990","repository_url":"https://api.github.com/repos/apple/foundationdb","labels_url":"https://api.github.com/repos/apple/foundationdb/issues/990/labels{/name}","comments_url":"https://api.github.com/repos/apple/foundationdb/issues/990/comments","events_url":"https://api.github.com/repos/apple/foundationdb/issues/990/events","html_url":"https://github.com/apple/foundationdb/issues/990","id":394710824,"node_id":"MDU6SXNzdWUzOTQ3MTA4MjQ=","number":990,"title":"Problem building on Mac: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Werror,-Wtautological-undefined-compare]","user":{"login":"szhou1234","id":12614590,"node_id":"MDQ6VXNlcjEyNjE0NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/12614590?v=4","gravatar_id":"","url":"https://api.github.com/users/szhou1234","html_url":"https://github.com/szhou1234","followers_url":"https://api.github.com/users/szhou1234/followers","following_url":"https://api.github.com/users/szhou1234/following{/other_user}","gists_url":"https://api.github.com/users/szhou1234/gists{/gist_id}","starred_url":"https://api.github.com/users/szhou1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szhou1234/subscriptions","organizations_url":"https://api.github.com/users/szhou1234/orgs","repos_url":"https://api.github.com/users/szhou1234/repos","events_url":"https://api.github.com/users/szhou1234/events{/privacy}","received_events_url":"https://api.github.com/users/szhou1234/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-28T20:11:09Z","updated_at":"2019-01-01T01:52:02Z","closed_at":"2019-01-01T01:52:02Z","author_association":"NONE","body":"This seems to be caused by a recent change in the last few weeks. I can create a PR.\r\n\r\nEnvironment:\r\n\r\n```➜  foundationdb git:(master) ✗ clang --version\r\nApple LLVM version 10.0.0 (clang-1000.11.45.5)\r\nTarget: x86_64-apple-darwin17.7.0\r\nThread model: posix\r\nInstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin\r\n```\r\n\r\nError:\r\n```\r\nCompiling      fdbserver/DataDistribution.actor.g.cpp\r\nfdbserver/DataDistribution.actor.cpp:157:7: error: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Werror,-Wtautological-undefined-compare]\r\n                if (this == NULL || machineIDs.empty()) return \"[unset]\";\r\n                    ^~~~    ~~~~\r\nfdbserver/DataDistribution.actor.cpp:214:7: error: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Werror,-Wtautological-undefined-compare]\r\n                if (this == NULL || serverIDs.empty()) return \"[unset]\";\r\n                    ^~~~    ~~~~\r\n2 errors generated.\r\nmake: *** [.objs/fdbserver/DataDistribution.actor.g.cpp.o] Error 1\r\n```"}}
{"actor":{"display_login":"szhou1234"}}