{"action":"closed","issue":{"url":"https://api.github.com/repos/nodegit/nodegit/issues/1566","repository_url":"https://api.github.com/repos/nodegit/nodegit","labels_url":"https://api.github.com/repos/nodegit/nodegit/issues/1566/labels{/name}","comments_url":"https://api.github.com/repos/nodegit/nodegit/issues/1566/comments","events_url":"https://api.github.com/repos/nodegit/nodegit/issues/1566/events","html_url":"https://github.com/nodegit/nodegit/issues/1566","id":368000873,"node_id":"MDU6SXNzdWUzNjgwMDA4NzM=","number":1566,"title":"OpenSSL is still mean spirited on latest on MacOS","user":{"login":"maxkorp","id":1302526,"node_id":"MDQ6VXNlcjEzMDI1MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1302526?v=4","gravatar_id":"","url":"https://api.github.com/users/maxkorp","html_url":"https://github.com/maxkorp","followers_url":"https://api.github.com/users/maxkorp/followers","following_url":"https://api.github.com/users/maxkorp/following{/other_user}","gists_url":"https://api.github.com/users/maxkorp/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkorp/subscriptions","organizations_url":"https://api.github.com/users/maxkorp/orgs","repos_url":"https://api.github.com/users/maxkorp/repos","events_url":"https://api.github.com/users/maxkorp/events{/privacy}","received_events_url":"https://api.github.com/users/maxkorp/received_events","type":"User","site_admin":false},"labels":[{"id":96309555,"node_id":"MDU6TGFiZWw5NjMwOTU1NQ==","url":"https://api.github.com/repos/nodegit/nodegit/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":151688865,"node_id":"MDU6TGFiZWwxNTE2ODg4NjU=","url":"https://api.github.com/repos/nodegit/nodegit/labels/Build","name":"Build","color":"77dd77","default":false},{"id":334402291,"node_id":"MDU6TGFiZWwzMzQ0MDIyOTE=","url":"https://api.github.com/repos/nodegit/nodegit/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":52,"created_at":"2018-10-09T00:47:26Z","updated_at":"2018-10-19T19:59:09Z","closed_at":"2018-10-19T19:59:09Z","author_association":"MEMBER","body":"## System information\r\n  - node version: v10.11.0\r\n  - npm or yarn version: npm 6.4.1\r\n  - OS/version/architechture: Darwin x86 18.0.0\r\n  - Applicable nodegit version: Master (0.23.0-alpha.1)\r\n\r\nTrying to build locally (`npx run rebuild`) libssh2 fails to configure (even with openssl headers linked in the ldflags) 3 times in a row, and then the build just continues.\r\n\r\n```\r\nnodegit git:(generation-cleanup) npx node-gyp build\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@3.8.0\r\ngyp info using node@10.11.0 | darwin | x64\r\ngyp info spawn make\r\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\n  ACTION binding_gyp_configureLibssh2_target_configure .\r\n[nodegit] Configuring libssh2.\r\n{ Error: Command failed: /Users/maxkorp/development/personal/nodegit/vendor/libssh2/configure\r\nconfigure: error: No crypto library found!\r\nTry --with-libssl-prefix=PATH\r\n or --with-libgcrypt-prefix=PATH\r\n or --with-libmbedtls-prefix=PATH\r\n or --with-wincng on Windows\r\n\r\n    at ChildProcess.exithandler (child_process.js:289:12)\r\n    at ChildProcess.emit (events.js:182:13)\r\n    at maybeClose (internal/child_process.js:962:16)\r\n    at Socket.stream.socket.on (internal/child_process.js:381:11)\r\n    at Socket.emit (events.js:182:13)\r\n    at Pipe._handle.close (net.js:606:12)\r\n  killed: false,\r\n  code: 1,\r\n  signal: null,\r\n  cmd:\r\n   '/Users/maxkorp/development/personal/nodegit/vendor/libssh2/configure' }\r\nconfigure: error: No crypto library found!\r\nTry --with-libssl-prefix=PATH\r\n or --with-libgcrypt-prefix=PATH\r\n or --with-libmbedtls-prefix=PATH\r\n or --with-wincng on Windows\r\n\r\n(node:28790) UnhandledPromiseRejectionWarning: Error: Command failed: /Users/maxkorp/development/personal/nodegit/vendor/libssh2/configure\r\nconfigure: error: No crypto library found!\r\nTry --with-libssl-prefix=PATH\r\n or --with-libgcrypt-prefix=PATH\r\n or --with-libmbedtls-prefix=PATH\r\n or --with-wincng on Windows\r\n\r\n    at ChildProcess.exithandler (child_process.js:289:12)\r\n    at ChildProcess.emit (events.js:182:13)\r\n    at maybeClose (internal/child_process.js:962:16)\r\n    at Socket.stream.socket.on (internal/child_process.js:381:11)\r\n    at Socket.emit (events.js:182:13)\r\n    at Pipe._handle.close (net.js:606:12)\r\n(node:28790) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)\r\n(node:28790) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.\r\n  CC(target) Release/obj.target/libgit2/vendor/libgit2/src/pack-objects.o\r\n  CC(target) Release/obj.target/libgit2/vendor/libgit2/src/pack.o\r\n  CC(target) Release/obj.target/libgit2/vendor/libgit2/src/parse.o\r\n  CC(target) Release/obj.target/libgit2/vendor/libgit2/src/patch_generate.o\r\n  CC(target) Release/obj.target/libgit2/vendor/libgit2/src/patch_parse.o\r\n../vendor/libgit2/src/patch_parse.c:461:12: warning: unused function\r\n      'parse_number' [-Wunused-function]\r\nstatic int parse_number(git_off_t *out, git_patch_parse_ctx *ctx)\r\n           ^\r\n1 warning generated.\r\n\r\n... and so on\r\n```\r\n\r\nSomething is bork. \r\n\r\nI installed and linked to openssl via brew.\r\n```\r\nbrew install openssl\r\nexport LDFLAGS=\"-L/usr/local/opt/openssl/lib\"\r\nexport CPPFLAGS=\"-I/usr/local/opt/openssl/include\"\r\n```\r\n\r\nThis was working pre node-v10 PR. "}}
{"actor":{"display_login":"implausible"}}