{"action":"created","issue":{"url":"https://api.github.com/repos/ostreedev/ostree/issues/1655","repository_url":"https://api.github.com/repos/ostreedev/ostree","labels_url":"https://api.github.com/repos/ostreedev/ostree/issues/1655/labels{/name}","comments_url":"https://api.github.com/repos/ostreedev/ostree/issues/1655/comments","events_url":"https://api.github.com/repos/ostreedev/ostree/issues/1655/events","html_url":"https://github.com/ostreedev/ostree/pull/1655","id":336300153,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Nzg2NDQ4","number":1655,"title":"OstreeMutableTree: Add parent pointer and fix bug","user":{"login":"wmanley","id":494659,"node_id":"MDQ6VXNlcjQ5NDY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/494659?v=4","gravatar_id":"","url":"https://api.github.com/users/wmanley","html_url":"https://github.com/wmanley","followers_url":"https://api.github.com/users/wmanley/followers","following_url":"https://api.github.com/users/wmanley/following{/other_user}","gists_url":"https://api.github.com/users/wmanley/gists{/gist_id}","starred_url":"https://api.github.com/users/wmanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmanley/subscriptions","organizations_url":"https://api.github.com/users/wmanley/orgs","repos_url":"https://api.github.com/users/wmanley/repos","events_url":"https://api.github.com/users/wmanley/events{/privacy}","received_events_url":"https://api.github.com/users/wmanley/received_events","type":"User","site_admin":false},"labels":[{"id":559669455,"node_id":"MDU6TGFiZWw1NTk2Njk0NTU=","url":"https://api.github.com/repos/ostreedev/ostree/labels/homu/approved","name":"homu/approved","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-06-27T16:24:24Z","updated_at":"2018-06-29T22:07:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ostreedev/ostree/pulls/1655","html_url":"https://github.com/ostreedev/ostree/pull/1655","diff_url":"https://github.com/ostreedev/ostree/pull/1655.diff","patch_url":"https://github.com/ostreedev/ostree/pull/1655.patch"},"body":"This is preparatory work for #1643.  The commits were originally on #1643 and I've added a fixup to address some of the comments from there.  I split this out as it's own PR as requested by @jlebon.\r\n\r\nThis implements a TODO item from\r\n`ostree_mutable_tree_get_contents_checksum`.  We now no-longer invalidate\r\nthe dirtree contents checksum at `get_contents_checksum` time - we\r\ninvalidate it when the mtree is modified.  This is implemented by keeping\r\na pointer to the parent directory in each `OstreeMutableTree`.  This gives\r\nus stronger invariants on `contents_checksum`.\r\n\r\nFor even stronger guarantees about invariants we could make\r\n`ostree_repo_write_mtree` or similar a member of `OstreeMutableTree` and\r\nremove `ostree_mutable_tree_set_metadata_checksum`.\r\n\r\nI've fixed a bug here too.  We now invalidate parent's contents\r\nchecksum when our metadata checksum changes, whereas we didn't before."},"comment":{"url":"https://api.github.com/repos/ostreedev/ostree/issues/comments/401486068","html_url":"https://github.com/ostreedev/ostree/pull/1655#issuecomment-401486068","issue_url":"https://api.github.com/repos/ostreedev/ostree/issues/1655","id":401486068,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ4NjA2OA==","user":{"login":"rh-atomic-bot","id":14112924,"node_id":"MDQ6VXNlcjE0MTEyOTI0","avatar_url":"https://avatars1.githubusercontent.com/u/14112924?v=4","gravatar_id":"","url":"https://api.github.com/users/rh-atomic-bot","html_url":"https://github.com/rh-atomic-bot","followers_url":"https://api.github.com/users/rh-atomic-bot/followers","following_url":"https://api.github.com/users/rh-atomic-bot/following{/other_user}","gists_url":"https://api.github.com/users/rh-atomic-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/rh-atomic-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rh-atomic-bot/subscriptions","organizations_url":"https://api.github.com/users/rh-atomic-bot/orgs","repos_url":"https://api.github.com/users/rh-atomic-bot/repos","events_url":"https://api.github.com/users/rh-atomic-bot/events{/privacy}","received_events_url":"https://api.github.com/users/rh-atomic-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T22:07:50Z","updated_at":"2018-06-29T22:07:50Z","author_association":"COLLABORATOR","body":":sunny: Test successful - [status-atomicjenkins](https://s3.amazonaws.com/aos-ci/ghprb/ostreedev/ostree/488365f9bf296bf8e56d571b0abfcae638ac0a3f.1530310070322513152/index.html)\nApproved by: cgwalters\nPushing 488365f9bf296bf8e56d571b0abfcae638ac0a3f to master..."}}
{"actor":{"display_login":"rh-atomic-bot"}}