{"action":"closed","number":479,"pull_request":{"url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479","id":184009255,"html_url":"https://github.com/algolia/algoliasearch-magento-2/pull/479","diff_url":"https://github.com/algolia/algoliasearch-magento-2/pull/479.diff","patch_url":"https://github.com/algolia/algoliasearch-magento-2/pull/479.patch","issue_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/479","number":479,"state":"closed","locked":false,"title":"Fixed exploding of line breaks where \\r\\n was used instead of \\n","user":{"login":"peterjaap","id":431360,"avatar_url":"https://avatars2.githubusercontent.com/u/431360?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjaap","html_url":"https://github.com/peterjaap","followers_url":"https://api.github.com/users/peterjaap/followers","following_url":"https://api.github.com/users/peterjaap/following{/other_user}","gists_url":"https://api.github.com/users/peterjaap/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjaap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjaap/subscriptions","organizations_url":"https://api.github.com/users/peterjaap/orgs","repos_url":"https://api.github.com/users/peterjaap/repos","events_url":"https://api.github.com/users/peterjaap/events{/privacy}","received_events_url":"https://api.github.com/users/peterjaap/received_events","type":"User","site_admin":false},"body":"<!--\r\n  Thanks for submitting a pull request!\r\n  Please provide enough information so that others can review your pull request.\r\n-->\r\n\r\n**Summary**\r\nWe noticed the prevent backend rendering functionality did not work correctly; the pages for the Googlebot did not include the HTML of Magento's category listing. We found that it was due to a `\\r\\n` being present in the `algoliasearch_advanced/advanced/backend_rendering_allowed_user_agents`  value. Probably due to somebody on Windows editing that text. The code only split on `\\n`, thereby getting `Googlebot\\r` and `Bingbot` as a result. `Googlebot\\r` does not match in the user agent string `Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)` and there it *will* prevent backend rendering.\r\n\r\n<!--\r\n  Explain the **motivation** for making this change.\r\n  What existing problem does the pull request solve?\r\n  Are there any linked issues?\r\n-->\r\n\r\n**Result**\r\nBackend rendering is *not* prevented for Googlebot.\r\n\r\n<!--\r\n  Demonstrate the code is solid.\r\n  Example: The exact commands you ran and their output,\r\n  screenshots / videos if the pull request changes UI.\r\n-->","created_at":"2018-04-25T11:50:08Z","updated_at":"2018-04-26T10:59:14Z","closed_at":"2018-04-26T10:59:14Z","merged_at":"2018-04-26T10:59:14Z","merge_commit_sha":"77f313926fbc301c7c05e5387a7c57a32d5fbfc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479/commits","review_comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479/comments","review_comment_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/479/comments","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/statuses/787a60f8f38c4e93805e7c2e3196f9c0e947e2d4","head":{"label":"peterjaap:fix-explode-line-breaks","ref":"fix-explode-line-breaks","sha":"787a60f8f38c4e93805e7c2e3196f9c0e947e2d4","user":{"login":"peterjaap","id":431360,"avatar_url":"https://avatars2.githubusercontent.com/u/431360?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjaap","html_url":"https://github.com/peterjaap","followers_url":"https://api.github.com/users/peterjaap/followers","following_url":"https://api.github.com/users/peterjaap/following{/other_user}","gists_url":"https://api.github.com/users/peterjaap/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjaap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjaap/subscriptions","organizations_url":"https://api.github.com/users/peterjaap/orgs","repos_url":"https://api.github.com/users/peterjaap/repos","events_url":"https://api.github.com/users/peterjaap/events{/privacy}","received_events_url":"https://api.github.com/users/peterjaap/received_events","type":"User","site_admin":false},"repo":{"id":130998097,"name":"algoliasearch-magento-2","full_name":"peterjaap/algoliasearch-magento-2","owner":{"login":"peterjaap","id":431360,"avatar_url":"https://avatars2.githubusercontent.com/u/431360?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjaap","html_url":"https://github.com/peterjaap","followers_url":"https://api.github.com/users/peterjaap/followers","following_url":"https://api.github.com/users/peterjaap/following{/other_user}","gists_url":"https://api.github.com/users/peterjaap/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjaap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjaap/subscriptions","organizations_url":"https://api.github.com/users/peterjaap/orgs","repos_url":"https://api.github.com/users/peterjaap/repos","events_url":"https://api.github.com/users/peterjaap/events{/privacy}","received_events_url":"https://api.github.com/users/peterjaap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterjaap/algoliasearch-magento-2","description":"Algolia Search integration for Magento 2","fork":true,"url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2","forks_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/forks","keys_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/teams","hooks_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/hooks","issue_events_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/issues/events{/number}","events_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/events","assignees_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/assignees{/user}","branches_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/branches{/branch}","tags_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/tags","blobs_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/statuses/{sha}","languages_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/languages","stargazers_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/stargazers","contributors_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/contributors","subscribers_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/subscribers","subscription_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/subscription","commits_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/contents/{+path}","compare_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/merges","archive_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/downloads","issues_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/issues{/number}","pulls_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/pulls{/number}","milestones_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/milestones{/number}","notifications_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/labels{/name}","releases_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/releases{/id}","deployments_url":"https://api.github.com/repos/peterjaap/algoliasearch-magento-2/deployments","created_at":"2018-04-25T11:45:04Z","updated_at":"2018-04-25T11:45:06Z","pushed_at":"2018-04-25T11:46:04Z","git_url":"git://github.com/peterjaap/algoliasearch-magento-2.git","ssh_url":"git@github.com:peterjaap/algoliasearch-magento-2.git","clone_url":"https://github.com/peterjaap/algoliasearch-magento-2.git","svn_url":"https://github.com/peterjaap/algoliasearch-magento-2","homepage":"https://community.algolia.com/magento","size":8925,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"algolia:master","ref":"master","sha":"3268d362b45175161e9ae5f8393efbb428285a1a","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":54131069,"name":"algoliasearch-magento-2","full_name":"algolia/algoliasearch-magento-2","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/algoliasearch-magento-2","description":"Algolia Search integration for Magento 2","fork":false,"url":"https://api.github.com/repos/algolia/algoliasearch-magento-2","forks_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/forks","keys_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/teams","hooks_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/hooks","issue_events_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/events","assignees_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/tags","blobs_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/languages","stargazers_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/stargazers","contributors_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/contributors","subscribers_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/subscribers","subscription_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/subscription","commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/merges","archive_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/downloads","issues_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/labels{/name}","releases_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/algoliasearch-magento-2/deployments","created_at":"2016-03-17T15:48:56Z","updated_at":"2018-04-20T08:18:38Z","pushed_at":"2018-04-26T10:59:14Z","git_url":"git://github.com/algolia/algoliasearch-magento-2.git","ssh_url":"git@github.com:algolia/algoliasearch-magento-2.git","clone_url":"https://github.com/algolia/algoliasearch-magento-2.git","svn_url":"https://github.com/algolia/algoliasearch-magento-2","homepage":"https://community.algolia.com/magento","size":8924,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":54,"open_issues":22,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479"},"html":{"href":"https://github.com/algolia/algoliasearch-magento-2/pull/479"},"issue":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/479"},"comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/algoliasearch-magento-2/statuses/787a60f8f38c4e93805e7c2e3196f9c0e947e2d4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JanPetr","id":1058144,"avatar_url":"https://avatars3.githubusercontent.com/u/1058144?v=4","gravatar_id":"","url":"https://api.github.com/users/JanPetr","html_url":"https://github.com/JanPetr","followers_url":"https://api.github.com/users/JanPetr/followers","following_url":"https://api.github.com/users/JanPetr/following{/other_user}","gists_url":"https://api.github.com/users/JanPetr/gists{/gist_id}","starred_url":"https://api.github.com/users/JanPetr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanPetr/subscriptions","organizations_url":"https://api.github.com/users/JanPetr/orgs","repos_url":"https://api.github.com/users/JanPetr/repos","events_url":"https://api.github.com/users/JanPetr/events{/privacy}","received_events_url":"https://api.github.com/users/JanPetr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"JanPetr"}}