{"action":"created","issue":{"url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/47","repository_url":"https://api.github.com/repos/coderedcorp/coderedcms","labels_url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/47/comments","events_url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/47/events","html_url":"https://github.com/coderedcorp/coderedcms/issues/47","id":389895371,"node_id":"MDU6SXNzdWUzODk4OTUzNzE=","number":47,"title":"Shuttering Peregrine: useful features?","user":{"login":"FlipperPA","id":68164,"node_id":"MDQ6VXNlcjY4MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/68164?v=4","gravatar_id":"","url":"https://api.github.com/users/FlipperPA","html_url":"https://github.com/FlipperPA","followers_url":"https://api.github.com/users/FlipperPA/followers","following_url":"https://api.github.com/users/FlipperPA/following{/other_user}","gists_url":"https://api.github.com/users/FlipperPA/gists{/gist_id}","starred_url":"https://api.github.com/users/FlipperPA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlipperPA/subscriptions","organizations_url":"https://api.github.com/users/FlipperPA/orgs","repos_url":"https://api.github.com/users/FlipperPA/repos","events_url":"https://api.github.com/users/FlipperPA/events{/privacy}","received_events_url":"https://api.github.com/users/FlipperPA/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-11T18:28:00Z","updated_at":"2018-12-11T20:14:35Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hey team,\r\n\r\nI'm thinking about shuttering Peregrine and putting my efforts here so we're not duplicating a lot of effort, and y'all are farther along than me: https://github.com/flipperpa/peregrine/\r\n\r\nThere are a few features I think would be worth implementing here that are already completed in Peregrine, and wanted your feedback before I started working:\r\n\r\n- embeds with automatic Bootstrap 4 size detection has worked really well in practice: https://github.com/FlipperPA/peregrine/blob/master/peregrine/templates/wagtailembeds/embed_frontend.html\r\n- ability to only keep a certain number of revisions from a setting: https://github.com/FlipperPA/peregrine/blob/master/peregrine/wagtail_hooks.py#L22\r\n- integration with Wagtail Code Block, for consistent syntax highlighted code blocks both in the editor and front end\r\n\r\nDo these three sound like PRs that would be worth putting together? Great work, as always!"},"comment":{"url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/comments/446346027","html_url":"https://github.com/coderedcorp/coderedcms/issues/47#issuecomment-446346027","issue_url":"https://api.github.com/repos/coderedcorp/coderedcms/issues/47","id":446346027,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjM0NjAyNw==","user":{"login":"vsalvino","id":13453401,"node_id":"MDQ6VXNlcjEzNDUzNDAx","avatar_url":"https://avatars3.githubusercontent.com/u/13453401?v=4","gravatar_id":"","url":"https://api.github.com/users/vsalvino","html_url":"https://github.com/vsalvino","followers_url":"https://api.github.com/users/vsalvino/followers","following_url":"https://api.github.com/users/vsalvino/following{/other_user}","gists_url":"https://api.github.com/users/vsalvino/gists{/gist_id}","starred_url":"https://api.github.com/users/vsalvino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsalvino/subscriptions","organizations_url":"https://api.github.com/users/vsalvino/orgs","repos_url":"https://api.github.com/users/vsalvino/repos","events_url":"https://api.github.com/users/vsalvino/events{/privacy}","received_events_url":"https://api.github.com/users/vsalvino/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T20:14:35Z","updated_at":"2018-12-11T20:14:35Z","author_association":"CONTRIBUTOR","body":"Thanks for getting so involved! I really appreciate all the effort you've been sharing with us :)\r\n\r\n* Bootstrap 4 embeds: I like what you've done. We actually should probably remove our \"embed video\" block and replace it with wagtail's native EmbedBlock, which is much more robust, and then extend the default EmbedBlock template to use Bootstrap4 styling. I like how you detect content sizes. I will create an issue for this describing what needs to happen.\r\n* For revision history, I would be inclined to not include this in CodeRed CMS. Something like this would probably be better implement on a project-by-project basis.\r\n* There is already an issue for the code block. I think the solution here is that we will remove our Formatted Code Block from the default streamfield, and provide a way or a hook of some sort to easily add blocks in a la carte. At that point you would be able to pull in any block from any pip package."}}
{"actor":{"display_login":"vsalvino"}}