{"push_id":2388847754,"size":20,"distinct_size":6,"ref":"refs/heads/ledger-cyclic-dep","head":"a15faa6b43e6ed6c4ed70df2f2df56978dd1be1a","before":"325c6c07cf99ea56e218198eef72229361bbb1af","commits":[{"sha":"9a6be3da2508441f5d712e4875cf41ee2096e210","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"wallet_manager: fixed typo deviuce/device.hpp","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/9a6be3da2508441f5d712e4875cf41ee2096e210"},{"sha":"7c81cc495f9be565d8de4aab70e573b0584fec42","author":{"name":"MoroccanMalinois","email":"156116436a57f5649948be0ca8c3bba70cd7c709@protonmail.com"},"message":"Dockerfile: add boost locale","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/7c81cc495f9be565d8de4aab70e573b0584fec42"},{"sha":"557a6fb6eab0828596a34c3b1fb90cb164545ca1","author":{"name":"moneromooo-monero","email":"20a0b2642d0f725bb69b35852162142ea448855d@users.noreply.github.com"},"message":"cn_deserialize: link with device and ringct","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/557a6fb6eab0828596a34c3b1fb90cb164545ca1"},{"sha":"49c70962eeb113a2399ba4fe8a6778565c9dac78","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"device: remove dependency on readline","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/49c70962eeb113a2399ba4fe8a6778565c9dac78"},{"sha":"55a65f3269826b9e1cc6a3fb2770b8bc4761e39b","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"Wallet API: corrected testnet/mainnet ordering","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/55a65f3269826b9e1cc6a3fb2770b8bc4761e39b"},{"sha":"04a0cc89cf30f5c5c9a5c88c5e3c1b10a2c0f7e4","author":{"name":"moneromooo-monero","email":"20a0b2642d0f725bb69b35852162142ea448855d@users.noreply.github.com"},"message":"slow-hash: fix uint64 type typo","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/04a0cc89cf30f5c5c9a5c88c5e3c1b10a2c0f7e4"},{"sha":"38657fd0e9bfe67e30aa011d8ec0585e27a3af2d","author":{"name":"moneromooo-monero","email":"20a0b2642d0f725bb69b35852162142ea448855d@users.noreply.github.com"},"message":"Bump min ring size from 5 to 7 from v7","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/38657fd0e9bfe67e30aa011d8ec0585e27a3af2d"},{"sha":"60c8544e77d5dc4ed27094a7c599be07b8fee709","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3347\n\n9a6be3da wallet_manager: fixed typo deviuce/device.hpp (stoffu)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/60c8544e77d5dc4ed27094a7c599be07b8fee709"},{"sha":"5d80f38e369d4a07050d47e1305dca6ea9912943","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3356\n\n7c81cc49 Dockerfile: add boost locale (MoroccanMalinois)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/5d80f38e369d4a07050d47e1305dca6ea9912943"},{"sha":"220cb62ca4e641e76e29608b47df0753c610b35d","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3357\n\n557a6fb6 cn_deserialize: link with device and ringct (moneromooo-monero)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/220cb62ca4e641e76e29608b47df0753c610b35d"},{"sha":"f4cf613e34ff9c67d837e00029e9a47975e17dd2","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3362\n\n49c70962 device: remove dependency on readline (stoffu)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/f4cf613e34ff9c67d837e00029e9a47975e17dd2"},{"sha":"3a12f2588ad42d5f496774dc2f0d4f4db34d84b9","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3365\n\n55a65f32 Wallet API: corrected testnet/mainnet ordering (stoffu)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/3a12f2588ad42d5f496774dc2f0d4f4db34d84b9"},{"sha":"546e380cab9d4bbc5050038d1238a7c7140bbbcf","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3370\n\n04a0cc89 slow-hash: fix uint64 type typo (moneromooo-monero)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/546e380cab9d4bbc5050038d1238a7c7140bbbcf"},{"sha":"e9f41e405f1f75533ef6e9d5adc76ba41dd29e8c","author":{"name":"Riccardo Spagni","email":"cc830a6ec875a915bf032795273ec149cb070b21@spagni.net"},"message":"Merge pull request #3368\n\n38657fd0 Bump min ring size from 5 to 7 from v7 (moneromooo-monero)","distinct":false,"url":"https://api.github.com/repos/stoffu/monero/commits/e9f41e405f1f75533ef6e9d5adc76ba41dd29e8c"},{"sha":"706d26b72208a2c9ba9a4221fca5c4179a201e75","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"device: made function prototypes consistent with pre-#3303 codebase","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/706d26b72208a2c9ba9a4221fca5c4179a201e75"},{"sha":"6c8a810d3c5a033c34f78a4f5cb9421e0421104b","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"device: untangle cyclic depenency\n\nWhen #3303 was merged, a cyclic dependency chain was generated:\n\n    libdevice <- libcncrypto <- libringct <- libdevice\n\nThis was because libdevice needs access to a set of basic crypto operations\nimplemented in libringct such as scalarmultBase(), while libringct also needs\naccess to abstracted crypto operations implemented in libdevice such as\necdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct\ninto libringct_basic and libringct, where the basic crypto ops previously in\nlibringct are moved into libringct_basic. The cyclic dependency is now resolved\nthanks to this separation:\n\n    libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct\n\nThis eliminates the need for crypto_device.cpp and rctOps_device.cpp.\n\nAlso, many abstracted interfaces of hw::device such as encrypt_payment_id() and\nget_subaddress_secret_key() were previously implemented in libcryptonote_basic\n(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,\nwhich is odd because libdevice is supposed to be independent of libcryptonote_basic.\nTherefore, those functions were moved to device_default.cpp.","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/6c8a810d3c5a033c34f78a4f5cb9421e0421104b"},{"sha":"ce04df910123f994e9ff5bf25849f2829cfe0c0d","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"keypair::generate: always require hw::device to avoid possible mistake","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/ce04df910123f994e9ff5bf25849f2829cfe0c0d"},{"sha":"6adae13f57183a47d762f19373ee93bfcf3fadbd","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"crypto: revert odd namespace changes made in #3303","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/6adae13f57183a47d762f19373ee93bfcf3fadbd"},{"sha":"098ec1f44e5d7f6e1d36c666b56e20835e52de15","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"chacha: call prehashed version explicitly as generate_chacha_key_prehashed\nhash: add prehashed version cn_slow_hash_prehashed\nslow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not\nslow-hash: add support for prehashed version for the other 3 platforms","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/098ec1f44e5d7f6e1d36c666b56e20835e52de15"},{"sha":"a15faa6b43e6ed6c4ed70df2f2df56978dd1be1a","author":{"name":"stoffu","email":"4dfbd903ac34113a48c00d2aa4e58dfcb0064833@protonmail.ch"},"message":"wallet2: check_tx_key() shouldn't require hardware encryption","distinct":true,"url":"https://api.github.com/repos/stoffu/monero/commits/a15faa6b43e6ed6c4ed70df2f2df56978dd1be1a"}]}
{"actor":{"display_login":"stoffu"}}