{"action":"closed","number":275,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275","id":209581922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTgxOTIy","html_url":"https://github.com/open-source-economics/taxdata/pull/275","diff_url":"https://github.com/open-source-economics/taxdata/pull/275.diff","patch_url":"https://github.com/open-source-economics/taxdata/pull/275.patch","issue_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/275","number":275,"state":"closed","locked":false,"title":"Impute itemized expense amounts for non-itemizers in PUF data","user":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"body":"This pull request does what the title says.  The fact that there are no itemized expense amounts for non-itemizers is inherent in the PUF, which is a sample of tax returns.  This lack of itemized expenses for non-itemizers makes it impossible to produce sensible estimates of policy reforms that reduce the standard deduction, which has forced us to develop a set of warning messages that are costly to maintain and confusing to some users.  See issue #32 for a discussion of an earlier attempt to impute these missing data.\r\n\r\nRead the docstring a the top of the new `puf_data/impute_itmexp.py` file for a description of the methods used to conduct the imputation.\r\n\r\nNote that the `impute_itmexp.py` logic was developed with the DUMP and CALIBRATING variables set to True, but they have all been set to False for production work.   This [comment](https://github.com/open-source-economics/taxdata/pull/275#issuecomment-414394981) shows the full DUMP output.\r\n\r\nAlso, note that even though this pull request generates a different `puf.csv` file, and therefore, triggers the make of the PUF weights and ratios files, the new versions of those two files are exactly the same as they are on the master branch.\r\n\r\nThere will be a corresponding Tax-Calculator pull request that uses the new `puf.csv` file and eliminates the warning messages about lower the values of the standard deduction policy parameters.","created_at":"2018-08-20T16:51:14Z","updated_at":"2018-08-24T19:09:04Z","closed_at":"2018-08-24T19:09:04Z","merged_at":"2018-08-24T19:09:04Z","merge_commit_sha":"74b34a0bb6db79791a31971c80924f586c9869ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":920795451,"node_id":"MDU6TGFiZWw5MjA3OTU0NTE=","url":"https://api.github.com/repos/open-source-economics/taxdata/labels/PUF","name":"PUF","color":"005b5b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/275/comments","statuses_url":"https://api.github.com/repos/open-source-economics/taxdata/statuses/d9921172e12782b41b908e502c806f650da83557","head":{"label":"martinholmer:impute-itmexp","ref":"impute-itmexp","sha":"d9921172e12782b41b908e502c806f650da83557","user":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"repo":{"id":48387309,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM4NzMwOQ==","name":"taxdata","full_name":"martinholmer/taxdata","owner":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinholmer/taxdata","description":null,"fork":true,"url":"https://api.github.com/repos/martinholmer/taxdata","forks_url":"https://api.github.com/repos/martinholmer/taxdata/forks","keys_url":"https://api.github.com/repos/martinholmer/taxdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinholmer/taxdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinholmer/taxdata/teams","hooks_url":"https://api.github.com/repos/martinholmer/taxdata/hooks","issue_events_url":"https://api.github.com/repos/martinholmer/taxdata/issues/events{/number}","events_url":"https://api.github.com/repos/martinholmer/taxdata/events","assignees_url":"https://api.github.com/repos/martinholmer/taxdata/assignees{/user}","branches_url":"https://api.github.com/repos/martinholmer/taxdata/branches{/branch}","tags_url":"https://api.github.com/repos/martinholmer/taxdata/tags","blobs_url":"https://api.github.com/repos/martinholmer/taxdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinholmer/taxdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinholmer/taxdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinholmer/taxdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinholmer/taxdata/statuses/{sha}","languages_url":"https://api.github.com/repos/martinholmer/taxdata/languages","stargazers_url":"https://api.github.com/repos/martinholmer/taxdata/stargazers","contributors_url":"https://api.github.com/repos/martinholmer/taxdata/contributors","subscribers_url":"https://api.github.com/repos/martinholmer/taxdata/subscribers","subscription_url":"https://api.github.com/repos/martinholmer/taxdata/subscription","commits_url":"https://api.github.com/repos/martinholmer/taxdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinholmer/taxdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinholmer/taxdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinholmer/taxdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinholmer/taxdata/contents/{+path}","compare_url":"https://api.github.com/repos/martinholmer/taxdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinholmer/taxdata/merges","archive_url":"https://api.github.com/repos/martinholmer/taxdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinholmer/taxdata/downloads","issues_url":"https://api.github.com/repos/martinholmer/taxdata/issues{/number}","pulls_url":"https://api.github.com/repos/martinholmer/taxdata/pulls{/number}","milestones_url":"https://api.github.com/repos/martinholmer/taxdata/milestones{/number}","notifications_url":"https://api.github.com/repos/martinholmer/taxdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinholmer/taxdata/labels{/name}","releases_url":"https://api.github.com/repos/martinholmer/taxdata/releases{/id}","deployments_url":"https://api.github.com/repos/martinholmer/taxdata/deployments","created_at":"2015-12-21T18:25:11Z","updated_at":"2018-08-14T20:44:54Z","pushed_at":"2018-08-21T12:35:27Z","git_url":"git://github.com/martinholmer/taxdata.git","ssh_url":"git@github.com:martinholmer/taxdata.git","clone_url":"https://github.com/martinholmer/taxdata.git","svn_url":"https://github.com/martinholmer/taxdata","homepage":null,"size":2457597,"stargazers_count":0,"watchers_count":0,"language":"SAS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"11ab8de01e2dca9598ce733fb05858e42122868d","user":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":38842143,"node_id":"MDEwOlJlcG9zaXRvcnkzODg0MjE0Mw==","name":"taxdata","full_name":"open-source-economics/taxdata","owner":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/taxdata","description":null,"fork":false,"url":"https://api.github.com/repos/open-source-economics/taxdata","forks_url":"https://api.github.com/repos/open-source-economics/taxdata/forks","keys_url":"https://api.github.com/repos/open-source-economics/taxdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/taxdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/taxdata/teams","hooks_url":"https://api.github.com/repos/open-source-economics/taxdata/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/taxdata/events","assignees_url":"https://api.github.com/repos/open-source-economics/taxdata/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/taxdata/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/taxdata/tags","blobs_url":"https://api.github.com/repos/open-source-economics/taxdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/taxdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/taxdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/taxdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/taxdata/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/taxdata/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/taxdata/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/taxdata/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/taxdata/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/taxdata/subscription","commits_url":"https://api.github.com/repos/open-source-economics/taxdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/taxdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/taxdata/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/taxdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/taxdata/merges","archive_url":"https://api.github.com/repos/open-source-economics/taxdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/taxdata/downloads","issues_url":"https://api.github.com/repos/open-source-economics/taxdata/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/taxdata/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/taxdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/taxdata/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/taxdata/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/taxdata/deployments","created_at":"2015-07-09T19:56:06Z","updated_at":"2018-08-23T13:25:07Z","pushed_at":"2018-08-24T19:09:04Z","git_url":"git://github.com/open-source-economics/taxdata.git","ssh_url":"git@github.com:open-source-economics/taxdata.git","clone_url":"https://github.com/open-source-economics/taxdata.git","svn_url":"https://github.com/open-source-economics/taxdata","homepage":null,"size":2457574,"stargazers_count":7,"watchers_count":7,"language":"SAS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":22,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275"},"html":{"href":"https://github.com/open-source-economics/taxdata/pull/275"},"issue":{"href":"https://api.github.com/repos/open-source-economics/taxdata/issues/275"},"comments":{"href":"https://api.github.com/repos/open-source-economics/taxdata/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/taxdata/statuses/d9921172e12782b41b908e502c806f650da83557"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"comments":16,"review_comments":2,"maintainer_can_modify":false,"commits":25,"additions":337,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"martinholmer"}}