{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/murphy/pulls/comments/245401814","pull_request_review_id":189504126,"id":245401814,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQwMTgxNA==","diff_hunk":"@@ -502,6 +508,7 @@ const getStream = function(name) {\n \n const resetLiveStream = function(name) {\n   console.log('resetting stream:', name);\n+  delete manifest[name];","path":"live-hls.js","position":52,"original_position":52,"commit_id":"a00427860424668389830fa24252323b10db8d24","original_commit_id":"a00427860424668389830fa24252323b10db8d24","user":{"login":"tomruggs","id":982343,"node_id":"MDQ6VXNlcjk4MjM0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/982343?v=4","gravatar_id":"","url":"https://api.github.com/users/tomruggs","html_url":"https://github.com/tomruggs","followers_url":"https://api.github.com/users/tomruggs/followers","following_url":"https://api.github.com/users/tomruggs/following{/other_user}","gists_url":"https://api.github.com/users/tomruggs/gists{/gist_id}","starred_url":"https://api.github.com/users/tomruggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomruggs/subscriptions","organizations_url":"https://api.github.com/users/tomruggs/orgs","repos_url":"https://api.github.com/users/tomruggs/repos","events_url":"https://api.github.com/users/tomruggs/events{/privacy}","received_events_url":"https://api.github.com/users/tomruggs/received_events","type":"User","site_admin":false},"body":"Same goes for stopLiveStream below.","created_at":"2019-01-04T19:46:57Z","updated_at":"2019-01-04T19:46:57Z","html_url":"https://github.com/videojs/murphy/pull/17#discussion_r245401814","pull_request_url":"https://api.github.com/repos/videojs/murphy/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/videojs/murphy/pulls/comments/245401814"},"html":{"href":"https://github.com/videojs/murphy/pull/17#discussion_r245401814"},"pull_request":{"href":"https://api.github.com/repos/videojs/murphy/pulls/17"}},"in_reply_to_id":245401758},"pull_request":{"url":"https://api.github.com/repos/videojs/murphy/pulls/17","id":242354718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzU0NzE4","html_url":"https://github.com/videojs/murphy/pull/17","diff_url":"https://github.com/videojs/murphy/pull/17.diff","patch_url":"https://github.com/videojs/murphy/pull/17.patch","issue_url":"https://api.github.com/repos/videojs/murphy/issues/17","number":17,"state":"open","locked":false,"title":"Make stream stopping and resetting work when the associated query params are passed.","user":{"login":"tomruggs","id":982343,"node_id":"MDQ6VXNlcjk4MjM0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/982343?v=4","gravatar_id":"","url":"https://api.github.com/users/tomruggs","html_url":"https://github.com/tomruggs","followers_url":"https://api.github.com/users/tomruggs/followers","following_url":"https://api.github.com/users/tomruggs/following{/other_user}","gists_url":"https://api.github.com/users/tomruggs/gists{/gist_id}","starred_url":"https://api.github.com/users/tomruggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomruggs/subscriptions","organizations_url":"https://api.github.com/users/tomruggs/orgs","repos_url":"https://api.github.com/users/tomruggs/repos","events_url":"https://api.github.com/users/tomruggs/events{/privacy}","received_events_url":"https://api.github.com/users/tomruggs/received_events","type":"User","site_admin":false},"body":"Given that query params are all treated as strings the previous comparisons never matched.  This also adds buttons to the UI for stopping and resetting.","created_at":"2019-01-04T19:43:04Z","updated_at":"2019-01-04T19:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ba273fc680189b2c76c1b474a4f75b56262a5f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/murphy/pulls/17/commits","review_comments_url":"https://api.github.com/repos/videojs/murphy/pulls/17/comments","review_comment_url":"https://api.github.com/repos/videojs/murphy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/murphy/issues/17/comments","statuses_url":"https://api.github.com/repos/videojs/murphy/statuses/a00427860424668389830fa24252323b10db8d24","head":{"label":"videojs:fix-reset","ref":"fix-reset","sha":"a00427860424668389830fa24252323b10db8d24","user":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":72046121,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA0NjEyMQ==","name":"murphy","full_name":"videojs/murphy","private":false,"owner":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/videojs/murphy","description":"Live Stream error simulator","fork":true,"url":"https://api.github.com/repos/videojs/murphy","forks_url":"https://api.github.com/repos/videojs/murphy/forks","keys_url":"https://api.github.com/repos/videojs/murphy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/murphy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/murphy/teams","hooks_url":"https://api.github.com/repos/videojs/murphy/hooks","issue_events_url":"https://api.github.com/repos/videojs/murphy/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/murphy/events","assignees_url":"https://api.github.com/repos/videojs/murphy/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/murphy/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/murphy/tags","blobs_url":"https://api.github.com/repos/videojs/murphy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/murphy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/murphy/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/murphy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/murphy/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/murphy/languages","stargazers_url":"https://api.github.com/repos/videojs/murphy/stargazers","contributors_url":"https://api.github.com/repos/videojs/murphy/contributors","subscribers_url":"https://api.github.com/repos/videojs/murphy/subscribers","subscription_url":"https://api.github.com/repos/videojs/murphy/subscription","commits_url":"https://api.github.com/repos/videojs/murphy/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/murphy/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/murphy/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/murphy/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/murphy/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/murphy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/murphy/merges","archive_url":"https://api.github.com/repos/videojs/murphy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/murphy/downloads","issues_url":"https://api.github.com/repos/videojs/murphy/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/murphy/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/murphy/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/murphy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/murphy/labels{/name}","releases_url":"https://api.github.com/repos/videojs/murphy/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/murphy/deployments","created_at":"2016-10-26T21:30:56Z","updated_at":"2019-01-04T15:19:34Z","pushed_at":"2019-01-04T19:43:04Z","git_url":"git://github.com/videojs/murphy.git","ssh_url":"git@github.com:videojs/murphy.git","clone_url":"https://github.com/videojs/murphy.git","svn_url":"https://github.com/videojs/murphy","homepage":null,"size":71896,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":10,"open_issues":5,"watchers":32,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"7ee72b5616aa99f649f52313b138766a03e22880","user":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":72046121,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA0NjEyMQ==","name":"murphy","full_name":"videojs/murphy","private":false,"owner":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/videojs/murphy","description":"Live Stream error simulator","fork":true,"url":"https://api.github.com/repos/videojs/murphy","forks_url":"https://api.github.com/repos/videojs/murphy/forks","keys_url":"https://api.github.com/repos/videojs/murphy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/murphy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/murphy/teams","hooks_url":"https://api.github.com/repos/videojs/murphy/hooks","issue_events_url":"https://api.github.com/repos/videojs/murphy/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/murphy/events","assignees_url":"https://api.github.com/repos/videojs/murphy/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/murphy/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/murphy/tags","blobs_url":"https://api.github.com/repos/videojs/murphy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/murphy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/murphy/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/murphy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/murphy/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/murphy/languages","stargazers_url":"https://api.github.com/repos/videojs/murphy/stargazers","contributors_url":"https://api.github.com/repos/videojs/murphy/contributors","subscribers_url":"https://api.github.com/repos/videojs/murphy/subscribers","subscription_url":"https://api.github.com/repos/videojs/murphy/subscription","commits_url":"https://api.github.com/repos/videojs/murphy/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/murphy/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/murphy/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/murphy/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/murphy/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/murphy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/murphy/merges","archive_url":"https://api.github.com/repos/videojs/murphy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/murphy/downloads","issues_url":"https://api.github.com/repos/videojs/murphy/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/murphy/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/murphy/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/murphy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/murphy/labels{/name}","releases_url":"https://api.github.com/repos/videojs/murphy/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/murphy/deployments","created_at":"2016-10-26T21:30:56Z","updated_at":"2019-01-04T15:19:34Z","pushed_at":"2019-01-04T19:43:04Z","git_url":"git://github.com/videojs/murphy.git","ssh_url":"git@github.com:videojs/murphy.git","clone_url":"https://github.com/videojs/murphy.git","svn_url":"https://github.com/videojs/murphy","homepage":null,"size":71896,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":10,"open_issues":5,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/murphy/pulls/17"},"html":{"href":"https://github.com/videojs/murphy/pull/17"},"issue":{"href":"https://api.github.com/repos/videojs/murphy/issues/17"},"comments":{"href":"https://api.github.com/repos/videojs/murphy/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/murphy/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/murphy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/murphy/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/murphy/statuses/a00427860424668389830fa24252323b10db8d24"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tomruggs"}}