{"action":"closed","number":498,"pull_request":{"url":"https://api.github.com/repos/accounts-js/accounts/pulls/498","id":231214470,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjE0NDcw","html_url":"https://github.com/accounts-js/accounts/pull/498","diff_url":"https://github.com/accounts-js/accounts/pull/498.diff","patch_url":"https://github.com/accounts-js/accounts/pull/498.patch","issue_url":"https://api.github.com/repos/accounts-js/accounts/issues/498","number":498,"state":"closed","locked":false,"title":"User enumeration","user":{"login":"pradel","id":5749437,"node_id":"MDQ6VXNlcjU3NDk0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/5749437?v=4","gravatar_id":"","url":"https://api.github.com/users/pradel","html_url":"https://github.com/pradel","followers_url":"https://api.github.com/users/pradel/followers","following_url":"https://api.github.com/users/pradel/following{/other_user}","gists_url":"https://api.github.com/users/pradel/gists{/gist_id}","starred_url":"https://api.github.com/users/pradel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradel/subscriptions","organizations_url":"https://api.github.com/users/pradel/orgs","repos_url":"https://api.github.com/users/pradel/repos","events_url":"https://api.github.com/users/pradel/events{/privacy}","received_events_url":"https://api.github.com/users/pradel/received_events","type":"User","site_admin":false},"body":"Close #337 \r\n\r\n- **Breaking change:** new server options `ambiguousErrorMessages` that default to true.\r\nWhen this option is true all the messages that allow user enumeration are hidden:\r\n- when trying to login with wrong credentials before was throwing with `User not found`, now `Invalid credentials`\r\n- when trying to send an email to reset the password if the user email is not found fail silently\r\n- when trying to send an email to verify the password if the user email is not found fail silently\r\n- when trying to create a new user, we return null to the client instead of the user id (the transports are intercepting the id and return null) if user already exist the function will fail silently\r\n- when trying to impersonate, we return `{ authorized: false }`\r\n- **Breaking change:** the register route of the `rest-express` package now return the userId as a string instead of `{ userId: ''}`\r\n","created_at":"2018-11-15T14:31:40Z","updated_at":"2018-11-16T15:51:46Z","closed_at":"2018-11-16T15:51:46Z","merged_at":"2018-11-16T15:51:46Z","merge_commit_sha":"d7d1c2e14ce49e13ab006376d6daeaec122c5e02","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidyaha","id":2580920,"node_id":"MDQ6VXNlcjI1ODA5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2580920?v=4","gravatar_id":"","url":"https://api.github.com/users/davidyaha","html_url":"https://github.com/davidyaha","followers_url":"https://api.github.com/users/davidyaha/followers","following_url":"https://api.github.com/users/davidyaha/following{/other_user}","gists_url":"https://api.github.com/users/davidyaha/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyaha/subscriptions","organizations_url":"https://api.github.com/users/davidyaha/orgs","repos_url":"https://api.github.com/users/davidyaha/repos","events_url":"https://api.github.com/users/davidyaha/events{/privacy}","received_events_url":"https://api.github.com/users/davidyaha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/accounts-js/accounts/pulls/498/commits","review_comments_url":"https://api.github.com/repos/accounts-js/accounts/pulls/498/comments","review_comment_url":"https://api.github.com/repos/accounts-js/accounts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/accounts-js/accounts/issues/498/comments","statuses_url":"https://api.github.com/repos/accounts-js/accounts/statuses/dea593963c0ea48fa978fd81cd115fc64aaa6eb9","head":{"label":"accounts-js:feature/user-enumeration","ref":"feature/user-enumeration","sha":"dea593963c0ea48fa978fd81cd115fc64aaa6eb9","user":{"login":"accounts-js","id":20859029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU5MDI5","avatar_url":"https://avatars1.githubusercontent.com/u/20859029?v=4","gravatar_id":"","url":"https://api.github.com/users/accounts-js","html_url":"https://github.com/accounts-js","followers_url":"https://api.github.com/users/accounts-js/followers","following_url":"https://api.github.com/users/accounts-js/following{/other_user}","gists_url":"https://api.github.com/users/accounts-js/gists{/gist_id}","starred_url":"https://api.github.com/users/accounts-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accounts-js/subscriptions","organizations_url":"https://api.github.com/users/accounts-js/orgs","repos_url":"https://api.github.com/users/accounts-js/repos","events_url":"https://api.github.com/users/accounts-js/events{/privacy}","received_events_url":"https://api.github.com/users/accounts-js/received_events","type":"Organization","site_admin":false},"repo":{"id":70207011,"node_id":"MDEwOlJlcG9zaXRvcnk3MDIwNzAxMQ==","name":"accounts","full_name":"accounts-js/accounts","private":false,"owner":{"login":"accounts-js","id":20859029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU5MDI5","avatar_url":"https://avatars1.githubusercontent.com/u/20859029?v=4","gravatar_id":"","url":"https://api.github.com/users/accounts-js","html_url":"https://github.com/accounts-js","followers_url":"https://api.github.com/users/accounts-js/followers","following_url":"https://api.github.com/users/accounts-js/following{/other_user}","gists_url":"https://api.github.com/users/accounts-js/gists{/gist_id}","starred_url":"https://api.github.com/users/accounts-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accounts-js/subscriptions","organizations_url":"https://api.github.com/users/accounts-js/orgs","repos_url":"https://api.github.com/users/accounts-js/repos","events_url":"https://api.github.com/users/accounts-js/events{/privacy}","received_events_url":"https://api.github.com/users/accounts-js/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/accounts-js/accounts","description":"Fullstack authentication and accounts-management for Javascript.","fork":false,"url":"https://api.github.com/repos/accounts-js/accounts","forks_url":"https://api.github.com/repos/accounts-js/accounts/forks","keys_url":"https://api.github.com/repos/accounts-js/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/accounts-js/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/accounts-js/accounts/teams","hooks_url":"https://api.github.com/repos/accounts-js/accounts/hooks","issue_events_url":"https://api.github.com/repos/accounts-js/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/accounts-js/accounts/events","assignees_url":"https://api.github.com/repos/accounts-js/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/accounts-js/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/accounts-js/accounts/tags","blobs_url":"https://api.github.com/repos/accounts-js/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/accounts-js/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/accounts-js/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/accounts-js/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/accounts-js/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/accounts-js/accounts/languages","stargazers_url":"https://api.github.com/repos/accounts-js/accounts/stargazers","contributors_url":"https://api.github.com/repos/accounts-js/accounts/contributors","subscribers_url":"https://api.github.com/repos/accounts-js/accounts/subscribers","subscription_url":"https://api.github.com/repos/accounts-js/accounts/subscription","commits_url":"https://api.github.com/repos/accounts-js/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/accounts-js/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/accounts-js/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/accounts-js/accounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/accounts-js/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/accounts-js/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/accounts-js/accounts/merges","archive_url":"https://api.github.com/repos/accounts-js/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/accounts-js/accounts/downloads","issues_url":"https://api.github.com/repos/accounts-js/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/accounts-js/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/accounts-js/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/accounts-js/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/accounts-js/accounts/labels{/name}","releases_url":"https://api.github.com/repos/accounts-js/accounts/releases{/id}","deployments_url":"https://api.github.com/repos/accounts-js/accounts/deployments","created_at":"2016-10-07T01:43:23Z","updated_at":"2018-11-16T05:11:53Z","pushed_at":"2018-11-16T15:51:45Z","git_url":"git://github.com/accounts-js/accounts.git","ssh_url":"git@github.com:accounts-js/accounts.git","clone_url":"https://github.com/accounts-js/accounts.git","svn_url":"https://github.com/accounts-js/accounts","homepage":"https://accounts-js.netlify.com","size":4286,"stargazers_count":287,"watchers_count":287,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":32,"watchers":287,"default_branch":"master"}},"base":{"label":"accounts-js:master","ref":"master","sha":"61d5427278b559d516ca31d29362a34cc0d2f038","user":{"login":"accounts-js","id":20859029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU5MDI5","avatar_url":"https://avatars1.githubusercontent.com/u/20859029?v=4","gravatar_id":"","url":"https://api.github.com/users/accounts-js","html_url":"https://github.com/accounts-js","followers_url":"https://api.github.com/users/accounts-js/followers","following_url":"https://api.github.com/users/accounts-js/following{/other_user}","gists_url":"https://api.github.com/users/accounts-js/gists{/gist_id}","starred_url":"https://api.github.com/users/accounts-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accounts-js/subscriptions","organizations_url":"https://api.github.com/users/accounts-js/orgs","repos_url":"https://api.github.com/users/accounts-js/repos","events_url":"https://api.github.com/users/accounts-js/events{/privacy}","received_events_url":"https://api.github.com/users/accounts-js/received_events","type":"Organization","site_admin":false},"repo":{"id":70207011,"node_id":"MDEwOlJlcG9zaXRvcnk3MDIwNzAxMQ==","name":"accounts","full_name":"accounts-js/accounts","private":false,"owner":{"login":"accounts-js","id":20859029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODU5MDI5","avatar_url":"https://avatars1.githubusercontent.com/u/20859029?v=4","gravatar_id":"","url":"https://api.github.com/users/accounts-js","html_url":"https://github.com/accounts-js","followers_url":"https://api.github.com/users/accounts-js/followers","following_url":"https://api.github.com/users/accounts-js/following{/other_user}","gists_url":"https://api.github.com/users/accounts-js/gists{/gist_id}","starred_url":"https://api.github.com/users/accounts-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accounts-js/subscriptions","organizations_url":"https://api.github.com/users/accounts-js/orgs","repos_url":"https://api.github.com/users/accounts-js/repos","events_url":"https://api.github.com/users/accounts-js/events{/privacy}","received_events_url":"https://api.github.com/users/accounts-js/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/accounts-js/accounts","description":"Fullstack authentication and accounts-management for Javascript.","fork":false,"url":"https://api.github.com/repos/accounts-js/accounts","forks_url":"https://api.github.com/repos/accounts-js/accounts/forks","keys_url":"https://api.github.com/repos/accounts-js/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/accounts-js/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/accounts-js/accounts/teams","hooks_url":"https://api.github.com/repos/accounts-js/accounts/hooks","issue_events_url":"https://api.github.com/repos/accounts-js/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/accounts-js/accounts/events","assignees_url":"https://api.github.com/repos/accounts-js/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/accounts-js/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/accounts-js/accounts/tags","blobs_url":"https://api.github.com/repos/accounts-js/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/accounts-js/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/accounts-js/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/accounts-js/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/accounts-js/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/accounts-js/accounts/languages","stargazers_url":"https://api.github.com/repos/accounts-js/accounts/stargazers","contributors_url":"https://api.github.com/repos/accounts-js/accounts/contributors","subscribers_url":"https://api.github.com/repos/accounts-js/accounts/subscribers","subscription_url":"https://api.github.com/repos/accounts-js/accounts/subscription","commits_url":"https://api.github.com/repos/accounts-js/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/accounts-js/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/accounts-js/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/accounts-js/accounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/accounts-js/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/accounts-js/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/accounts-js/accounts/merges","archive_url":"https://api.github.com/repos/accounts-js/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/accounts-js/accounts/downloads","issues_url":"https://api.github.com/repos/accounts-js/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/accounts-js/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/accounts-js/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/accounts-js/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/accounts-js/accounts/labels{/name}","releases_url":"https://api.github.com/repos/accounts-js/accounts/releases{/id}","deployments_url":"https://api.github.com/repos/accounts-js/accounts/deployments","created_at":"2016-10-07T01:43:23Z","updated_at":"2018-11-16T05:11:53Z","pushed_at":"2018-11-16T15:51:45Z","git_url":"git://github.com/accounts-js/accounts.git","ssh_url":"git@github.com:accounts-js/accounts.git","clone_url":"https://github.com/accounts-js/accounts.git","svn_url":"https://github.com/accounts-js/accounts","homepage":"https://accounts-js.netlify.com","size":4286,"stargazers_count":287,"watchers_count":287,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":32,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/accounts-js/accounts/pulls/498"},"html":{"href":"https://github.com/accounts-js/accounts/pull/498"},"issue":{"href":"https://api.github.com/repos/accounts-js/accounts/issues/498"},"comments":{"href":"https://api.github.com/repos/accounts-js/accounts/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/accounts-js/accounts/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/accounts-js/accounts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/accounts-js/accounts/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/accounts-js/accounts/statuses/dea593963c0ea48fa978fd81cd115fc64aaa6eb9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pradel","id":5749437,"node_id":"MDQ6VXNlcjU3NDk0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/5749437?v=4","gravatar_id":"","url":"https://api.github.com/users/pradel","html_url":"https://github.com/pradel","followers_url":"https://api.github.com/users/pradel/followers","following_url":"https://api.github.com/users/pradel/following{/other_user}","gists_url":"https://api.github.com/users/pradel/gists{/gist_id}","starred_url":"https://api.github.com/users/pradel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradel/subscriptions","organizations_url":"https://api.github.com/users/pradel/orgs","repos_url":"https://api.github.com/users/pradel/repos","events_url":"https://api.github.com/users/pradel/events{/privacy}","received_events_url":"https://api.github.com/users/pradel/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":78,"deletions":10,"changed_files":12}}
{"actor":{"display_login":"pradel"}}