{"action":"created","comment":{"url":"https://api.github.com/repos/luna/luna-manager/pulls/comments/240642568","pull_request_review_id":183717723,"id":240642568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDY0MjU2OA==","diff_hunk":"@@ -247,11 +251,19 @@ downloadExternalPkgs cfgFolderPath resolvedApp opts = do\n \n     pkgs <- forM pkgUrls $ \\pu -> do\n         archive     <- downloadFromURL pu \"External package: \"\n-        folder      <- Archive.unpack 1.0 \"unpacking_progress\" archive\n-        dirContents <- Shelly.ls folder\n-        forM dirContents $ \\f -> do\n-            Shelly.cp_r f tgtPath\n-            return $ tgtPath </> filename f\n+        let pkgName = FP.fromText $ Text.takeWhile (/= '-')\n+                    $ Shelly.toTextIgnore $ FP.basename $ FP.filename archive\n+        folder      <- Archive.unpack 1.0 \"unpacking_progress\" archive (Just pkgName)\n+        case extension archive of\n+            Just \"gz\" -> do","path":"luna-manager/src/Luna/Manager/Command/CreatePackage.hs","position":104,"original_position":104,"commit_id":"c248a296d1b4522e0c0a9223110baf0bf98ed472","original_commit_id":"c248a296d1b4522e0c0a9223110baf0bf98ed472","user":{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false},"body":"Fair point.","created_at":"2018-12-11T14:55:00Z","updated_at":"2018-12-11T14:55:00Z","html_url":"https://github.com/luna/luna-manager/pull/223#discussion_r240642568","pull_request_url":"https://api.github.com/repos/luna/luna-manager/pulls/223","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/comments/240642568"},"html":{"href":"https://github.com/luna/luna-manager/pull/223#discussion_r240642568"},"pull_request":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/223"}},"in_reply_to_id":240629811},"pull_request":{"url":"https://api.github.com/repos/luna/luna-manager/pulls/223","id":237671433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjcxNDMz","html_url":"https://github.com/luna/luna-manager/pull/223","diff_url":"https://github.com/luna/luna-manager/pull/223.diff","patch_url":"https://github.com/luna/luna-manager/pull/223.patch","issue_url":"https://api.github.com/repos/luna/luna-manager/issues/223","number":223,"state":"open","locked":false,"title":"Correctly including dataframes, dry run option","user":{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false},"body":"This should fix the issues with incorrectly unpacking the dataframes package with `tar`. Eventually, the unpacking logic should be rewritten (or at least heavily refactor), because there is a lot of dead code and overall clutter.\r\n\r\nThe dry-run option doesn't rebuild any haskell code while building the package. Instead, it takes the existing `dist` and simply copies stuff.\r\n\r\nAs an added value, this also removes some of the warnings about unused imports.\r\n\r\n**NOTE:** this needs to wait for https://github.com/luna/luna-studio/pull/1314 ","created_at":"2018-12-11T13:03:47Z","updated_at":"2018-12-11T14:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"406b8228187b7bb1884149164d3bf8e7a6dc9ade","assignee":{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false},"assignees":[{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sylwiabr","id":12892578,"node_id":"MDQ6VXNlcjEyODkyNTc4","avatar_url":"https://avatars2.githubusercontent.com/u/12892578?v=4","gravatar_id":"","url":"https://api.github.com/users/sylwiabr","html_url":"https://github.com/sylwiabr","followers_url":"https://api.github.com/users/sylwiabr/followers","following_url":"https://api.github.com/users/sylwiabr/following{/other_user}","gists_url":"https://api.github.com/users/sylwiabr/gists{/gist_id}","starred_url":"https://api.github.com/users/sylwiabr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylwiabr/subscriptions","organizations_url":"https://api.github.com/users/sylwiabr/orgs","repos_url":"https://api.github.com/users/sylwiabr/repos","events_url":"https://api.github.com/users/sylwiabr/events{/privacy}","received_events_url":"https://api.github.com/users/sylwiabr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/luna/luna-manager/pulls/223/commits","review_comments_url":"https://api.github.com/repos/luna/luna-manager/pulls/223/comments","review_comment_url":"https://api.github.com/repos/luna/luna-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luna/luna-manager/issues/223/comments","statuses_url":"https://api.github.com/repos/luna/luna-manager/statuses/c248a296d1b4522e0c0a9223110baf0bf98ed472","head":{"label":"luna:dry-run","ref":"dry-run","sha":"c248a296d1b4522e0c0a9223110baf0bf98ed472","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":94810002,"node_id":"MDEwOlJlcG9zaXRvcnk5NDgxMDAwMg==","name":"luna-manager","full_name":"luna/luna-manager","private":false,"owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luna/luna-manager","description":"Luna Manager provides install / uninstall / update and maintain utilities over all Luna related ecosystem.","fork":false,"url":"https://api.github.com/repos/luna/luna-manager","forks_url":"https://api.github.com/repos/luna/luna-manager/forks","keys_url":"https://api.github.com/repos/luna/luna-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/luna-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/luna-manager/teams","hooks_url":"https://api.github.com/repos/luna/luna-manager/hooks","issue_events_url":"https://api.github.com/repos/luna/luna-manager/issues/events{/number}","events_url":"https://api.github.com/repos/luna/luna-manager/events","assignees_url":"https://api.github.com/repos/luna/luna-manager/assignees{/user}","branches_url":"https://api.github.com/repos/luna/luna-manager/branches{/branch}","tags_url":"https://api.github.com/repos/luna/luna-manager/tags","blobs_url":"https://api.github.com/repos/luna/luna-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/luna-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/luna-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/luna-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/luna-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/luna-manager/languages","stargazers_url":"https://api.github.com/repos/luna/luna-manager/stargazers","contributors_url":"https://api.github.com/repos/luna/luna-manager/contributors","subscribers_url":"https://api.github.com/repos/luna/luna-manager/subscribers","subscription_url":"https://api.github.com/repos/luna/luna-manager/subscription","commits_url":"https://api.github.com/repos/luna/luna-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/luna-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/luna-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/luna-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/luna-manager/contents/{+path}","compare_url":"https://api.github.com/repos/luna/luna-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/luna-manager/merges","archive_url":"https://api.github.com/repos/luna/luna-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/luna-manager/downloads","issues_url":"https://api.github.com/repos/luna/luna-manager/issues{/number}","pulls_url":"https://api.github.com/repos/luna/luna-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/luna-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/luna-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/luna-manager/labels{/name}","releases_url":"https://api.github.com/repos/luna/luna-manager/releases{/id}","deployments_url":"https://api.github.com/repos/luna/luna-manager/deployments","created_at":"2017-06-19T18:49:41Z","updated_at":"2018-12-06T11:08:22Z","pushed_at":"2018-12-11T13:03:47Z","git_url":"git://github.com/luna/luna-manager.git","ssh_url":"git@github.com:luna/luna-manager.git","clone_url":"https://github.com/luna/luna-manager.git","svn_url":"https://github.com/luna/luna-manager","homepage":null,"size":608,"stargazers_count":42,"watchers_count":42,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":30,"watchers":42,"default_branch":"master"}},"base":{"label":"luna:master","ref":"master","sha":"e6cd12def7608dab48f6e9fef50ea2ff398f99b5","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":94810002,"node_id":"MDEwOlJlcG9zaXRvcnk5NDgxMDAwMg==","name":"luna-manager","full_name":"luna/luna-manager","private":false,"owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luna/luna-manager","description":"Luna Manager provides install / uninstall / update and maintain utilities over all Luna related ecosystem.","fork":false,"url":"https://api.github.com/repos/luna/luna-manager","forks_url":"https://api.github.com/repos/luna/luna-manager/forks","keys_url":"https://api.github.com/repos/luna/luna-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/luna-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/luna-manager/teams","hooks_url":"https://api.github.com/repos/luna/luna-manager/hooks","issue_events_url":"https://api.github.com/repos/luna/luna-manager/issues/events{/number}","events_url":"https://api.github.com/repos/luna/luna-manager/events","assignees_url":"https://api.github.com/repos/luna/luna-manager/assignees{/user}","branches_url":"https://api.github.com/repos/luna/luna-manager/branches{/branch}","tags_url":"https://api.github.com/repos/luna/luna-manager/tags","blobs_url":"https://api.github.com/repos/luna/luna-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/luna-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/luna-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/luna-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/luna-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/luna-manager/languages","stargazers_url":"https://api.github.com/repos/luna/luna-manager/stargazers","contributors_url":"https://api.github.com/repos/luna/luna-manager/contributors","subscribers_url":"https://api.github.com/repos/luna/luna-manager/subscribers","subscription_url":"https://api.github.com/repos/luna/luna-manager/subscription","commits_url":"https://api.github.com/repos/luna/luna-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/luna-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/luna-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/luna-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/luna-manager/contents/{+path}","compare_url":"https://api.github.com/repos/luna/luna-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/luna-manager/merges","archive_url":"https://api.github.com/repos/luna/luna-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/luna-manager/downloads","issues_url":"https://api.github.com/repos/luna/luna-manager/issues{/number}","pulls_url":"https://api.github.com/repos/luna/luna-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/luna-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/luna-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/luna-manager/labels{/name}","releases_url":"https://api.github.com/repos/luna/luna-manager/releases{/id}","deployments_url":"https://api.github.com/repos/luna/luna-manager/deployments","created_at":"2017-06-19T18:49:41Z","updated_at":"2018-12-06T11:08:22Z","pushed_at":"2018-12-11T13:03:47Z","git_url":"git://github.com/luna/luna-manager.git","ssh_url":"git@github.com:luna/luna-manager.git","clone_url":"https://github.com/luna/luna-manager.git","svn_url":"https://github.com/luna/luna-manager","homepage":null,"size":608,"stargazers_count":42,"watchers_count":42,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":30,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/223"},"html":{"href":"https://github.com/luna/luna-manager/pull/223"},"issue":{"href":"https://api.github.com/repos/luna/luna-manager/issues/223"},"comments":{"href":"https://api.github.com/repos/luna/luna-manager/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luna/luna-manager/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/luna/luna-manager/statuses/c248a296d1b4522e0c0a9223110baf0bf98ed472"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"piotrMocz"}}