{"action":"created","comment":{"url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments/172796885","pull_request_review_id":101873851,"id":172796885,"diff_hunk":"@@ -106,7 +153,7 @@ RUN rm -f /tmp/resources/overlays/README.txt && \\\n     fi;\n \n # Optionally remove Tomcat manager, docs, and examples\n-ARG TOMCAT_EXTRAS=true\n+#ARG TOMCAT_EXTRAS=true #moved to docker-compose.yml\n RUN if [ \"$TOMCAT_EXTRAS\" = false ]; then \\","path":"Dockerfile","position":96,"original_position":96,"commit_id":"87bad6031924c2d8abcca65f803646043a4efcef","original_commit_id":"87bad6031924c2d8abcca65f803646043a4efcef","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"body":"It should always be true. The arguments are substituted when building the image. So in the docker-compose, it would be \r\n```\r\n    args:\r\n      - ORACLE_JDK=true\r\n      - TOMCAT_EXTRAS=false\r\n```\r\n","created_at":"2018-03-07T10:22:06Z","updated_at":"2018-03-07T10:22:06Z","html_url":"https://github.com/kartoza/docker-geoserver/pull/28#discussion_r172796885","pull_request_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments/172796885"},"html":{"href":"https://github.com/kartoza/docker-geoserver/pull/28#discussion_r172796885"},"pull_request":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28"}},"in_reply_to_id":172773852},"pull_request":{"url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28","id":171226147,"html_url":"https://github.com/kartoza/docker-geoserver/pull/28","diff_url":"https://github.com/kartoza/docker-geoserver/pull/28.diff","patch_url":"https://github.com/kartoza/docker-geoserver/pull/28.patch","issue_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/28","number":28,"state":"open","locked":false,"title":"Added extra options for geoserver","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"body":"* Added a download script to install plugins in Geoserver. The script should be run before building the image. Some common plugins should be preinstalled in the image (ie control-flow, GDAL, WPS, Image pyramid)\r\n* Added GDAL data directory and environment variables to ensure when a user installs the Gdal plugins Geoserver recognizes them.\r\n* Moved the java environment settings to the docker file so that the image contains built-in optimizations.\r\n* Modified build script so that when building the image locally you only specify the GeoServer version once in the download script and it changes all occurrences in other files. Example Dockerfile and download.sh.\r\n* Added more instructions in the readme including how to use a persistent storage with sample data from GeoServer war file.\r\n* Added a sample file for use with the control flow module.\r\n* Install libjpeg-turbo- An extension which provides a significant performance enhancement for JPEG encoding in GeoServer WMS output\r\n* Install extra fonts which are used by SLD with graphic markers\r\n","created_at":"2018-02-25T11:49:56Z","updated_at":"2018-03-07T10:22:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad0f1db3747dc49c79c4fe6a3d74f407c51fc70e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28/commits","review_comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28/comments","review_comment_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/28/comments","statuses_url":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/87bad6031924c2d8abcca65f803646043a4efcef","head":{"label":"NyakudyaA:master","ref":"master","sha":"87bad6031924c2d8abcca65f803646043a4efcef","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"repo":{"id":122829232,"name":"docker-geoserver","full_name":"NyakudyaA/docker-geoserver","owner":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NyakudyaA/docker-geoserver","description":"A docker recipe for GeoServer","fork":true,"url":"https://api.github.com/repos/NyakudyaA/docker-geoserver","forks_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/forks","keys_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/teams","hooks_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/hooks","issue_events_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/events","assignees_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/tags","blobs_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/languages","stargazers_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/stargazers","contributors_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/contributors","subscribers_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/subscribers","subscription_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/subscription","commits_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/merges","archive_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/downloads","issues_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/labels{/name}","releases_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/deployments","created_at":"2018-02-25T11:18:19Z","updated_at":"2018-02-25T11:18:21Z","pushed_at":"2018-03-05T13:46:36Z","git_url":"git://github.com/NyakudyaA/docker-geoserver.git","ssh_url":"git@github.com:NyakudyaA/docker-geoserver.git","clone_url":"https://github.com/NyakudyaA/docker-geoserver.git","svn_url":"https://github.com/NyakudyaA/docker-geoserver","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kartoza:master","ref":"master","sha":"8624bdbd64639979533671147fb610a9918500e5","user":{"login":"kartoza","id":7395888,"avatar_url":"https://avatars3.githubusercontent.com/u/7395888?v=4","gravatar_id":"","url":"https://api.github.com/users/kartoza","html_url":"https://github.com/kartoza","followers_url":"https://api.github.com/users/kartoza/followers","following_url":"https://api.github.com/users/kartoza/following{/other_user}","gists_url":"https://api.github.com/users/kartoza/gists{/gist_id}","starred_url":"https://api.github.com/users/kartoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartoza/subscriptions","organizations_url":"https://api.github.com/users/kartoza/orgs","repos_url":"https://api.github.com/users/kartoza/repos","events_url":"https://api.github.com/users/kartoza/events{/privacy}","received_events_url":"https://api.github.com/users/kartoza/received_events","type":"Organization","site_admin":false},"repo":{"id":21318833,"name":"docker-geoserver","full_name":"kartoza/docker-geoserver","owner":{"login":"kartoza","id":7395888,"avatar_url":"https://avatars3.githubusercontent.com/u/7395888?v=4","gravatar_id":"","url":"https://api.github.com/users/kartoza","html_url":"https://github.com/kartoza","followers_url":"https://api.github.com/users/kartoza/followers","following_url":"https://api.github.com/users/kartoza/following{/other_user}","gists_url":"https://api.github.com/users/kartoza/gists{/gist_id}","starred_url":"https://api.github.com/users/kartoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartoza/subscriptions","organizations_url":"https://api.github.com/users/kartoza/orgs","repos_url":"https://api.github.com/users/kartoza/repos","events_url":"https://api.github.com/users/kartoza/events{/privacy}","received_events_url":"https://api.github.com/users/kartoza/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kartoza/docker-geoserver","description":"A docker recipe for GeoServer","fork":false,"url":"https://api.github.com/repos/kartoza/docker-geoserver","forks_url":"https://api.github.com/repos/kartoza/docker-geoserver/forks","keys_url":"https://api.github.com/repos/kartoza/docker-geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kartoza/docker-geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kartoza/docker-geoserver/teams","hooks_url":"https://api.github.com/repos/kartoza/docker-geoserver/hooks","issue_events_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/kartoza/docker-geoserver/events","assignees_url":"https://api.github.com/repos/kartoza/docker-geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/kartoza/docker-geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/kartoza/docker-geoserver/tags","blobs_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/kartoza/docker-geoserver/languages","stargazers_url":"https://api.github.com/repos/kartoza/docker-geoserver/stargazers","contributors_url":"https://api.github.com/repos/kartoza/docker-geoserver/contributors","subscribers_url":"https://api.github.com/repos/kartoza/docker-geoserver/subscribers","subscription_url":"https://api.github.com/repos/kartoza/docker-geoserver/subscription","commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/kartoza/docker-geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/kartoza/docker-geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kartoza/docker-geoserver/merges","archive_url":"https://api.github.com/repos/kartoza/docker-geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kartoza/docker-geoserver/downloads","issues_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/kartoza/docker-geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/kartoza/docker-geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kartoza/docker-geoserver/labels{/name}","releases_url":"https://api.github.com/repos/kartoza/docker-geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/kartoza/docker-geoserver/deployments","created_at":"2014-06-29T07:37:20Z","updated_at":"2018-03-02T01:50:29Z","pushed_at":"2018-03-07T08:49:19Z","git_url":"git://github.com/kartoza/docker-geoserver.git","ssh_url":"git@github.com:kartoza/docker-geoserver.git","clone_url":"https://github.com/kartoza/docker-geoserver.git","svn_url":"https://github.com/kartoza/docker-geoserver","homepage":null,"size":49,"stargazers_count":80,"watchers_count":80,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":64,"open_issues":2,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28"},"html":{"href":"https://github.com/kartoza/docker-geoserver/pull/28"},"issue":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/issues/28"},"comments":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/87bad6031924c2d8abcca65f803646043a4efcef"}},"author_association":"NONE"}}
{"actor":{"display_login":"NyakudyaA"}}