{"action":"created","issue":{"url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/99","repository_url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr","labels_url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/99/comments","events_url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/99/events","html_url":"https://github.com/nlmixrdevelopment/nlmixr/issues/99","id":378301593,"node_id":"MDU6SXNzdWUzNzgzMDE1OTM=","number":99,"title":"Make Tests Cross-Platform","user":{"login":"billdenney","id":10359931,"node_id":"MDQ6VXNlcjEwMzU5OTMx","avatar_url":"https://avatars1.githubusercontent.com/u/10359931?v=4","gravatar_id":"","url":"https://api.github.com/users/billdenney","html_url":"https://github.com/billdenney","followers_url":"https://api.github.com/users/billdenney/followers","following_url":"https://api.github.com/users/billdenney/following{/other_user}","gists_url":"https://api.github.com/users/billdenney/gists{/gist_id}","starred_url":"https://api.github.com/users/billdenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billdenney/subscriptions","organizations_url":"https://api.github.com/users/billdenney/orgs","repos_url":"https://api.github.com/users/billdenney/repos","events_url":"https://api.github.com/users/billdenney/events{/privacy}","received_events_url":"https://api.github.com/users/billdenney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2018-11-07T14:05:23Z","updated_at":"2018-11-27T03:57:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The tests currently don't all succeed on platforms other than Windows.  It would be helpful if they ran successfully to very similar results (e.g. with a tolerance <5% and ideally <1%) across platforms.  This discussion was started in RichardHooijmaijers/nlmixr.docker#2, but the cross-platform nature applies more to this repository (and, \"Hi, @mattfidler\" to make sure you see the connection here).\r\n\r\nInitial testing succeeded with 196 tests and failed 11 (with an odd error that appears related to testthat and not nlmixr making me not certain that the numbers are everything).  Your concerns. are correct; most values are <=3% off.\r\n\r\nThe only result that looked truly concerning that I saw off hand was from `test-model68.R`:\r\n\r\n```\r\n── 9. Failure: ODE (@test-model68.R#78)  ──────────────────────────────────────────\r\nsignif(as.numeric(z[4, \"StdDev\"]), 3) not equal to 0.000205.\r\n1/1 mismatches\r\n[1] 1.79e-07 - 0.000205 == -0.000205\r\n```\r\n\r\n(FYI, this was with my docker image not the stock image.  Results could be slightly different in the stock docker image because of slightly different versions of the underlying libraries.)\r\n\r\nMy initial thought is that increasing the required precision for `pnlsTol` (e.g. to 0.01) may help."},"comment":{"url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/comments/441895940","html_url":"https://github.com/nlmixrdevelopment/nlmixr/issues/99#issuecomment-441895940","issue_url":"https://api.github.com/repos/nlmixrdevelopment/nlmixr/issues/99","id":441895940,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTg5NTk0MA==","user":{"login":"mattfidler","id":514778,"node_id":"MDQ6VXNlcjUxNDc3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/514778?v=4","gravatar_id":"","url":"https://api.github.com/users/mattfidler","html_url":"https://github.com/mattfidler","followers_url":"https://api.github.com/users/mattfidler/followers","following_url":"https://api.github.com/users/mattfidler/following{/other_user}","gists_url":"https://api.github.com/users/mattfidler/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfidler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfidler/subscriptions","organizations_url":"https://api.github.com/users/mattfidler/orgs","repos_url":"https://api.github.com/users/mattfidler/repos","events_url":"https://api.github.com/users/mattfidler/events{/privacy}","received_events_url":"https://api.github.com/users/mattfidler/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T03:57:53Z","updated_at":"2018-11-27T03:57:53Z","author_association":"CONTRIBUTOR","body":"I'm not sure;  Are you running this in paralell?\r\n\r\nPerhaps I can run on my system to help."}}
{"actor":{"display_login":"mattfidler"}}