{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/189077202","pull_request_review_id":121186304,"id":189077202,"diff_hunk":"@@ -19,21 +20,63 @@ class er;\n \n namespace CoordinateMaps {\n \n-/// \\ingroup CoordinateMapsGroup\n-/// Two dimensional map from the unit square to a wedge, which is constructed\n-/// by interpolating between a circular arc of radius `radius_of_circle` and a\n-/// flat face which is circumscribed by a circular arc of radius\n-/// `radius_of_other`. These arcs extend \\f$\\pi/2\\f$ in angle, and can be\n-/// oriented along the +/- x or y axis. The choice of using either equiangular\n-/// or equidistant coordinates along the arcs is specifiable with\n-/// `with_equiangular_map`. For a more detailed discussion, see the\n-/// documentation for Wedge3D.\n+/*!\n+ * \\ingroup CoordinateMapsGroup\n+ *\n+ * \\brief Two dimensional map from the logical square to a wedge, which is used\n+ * by domains which use disks or annuli.\n+ *\n+ * \\details The coordinate map is constructed by\n+ * linearly interpolating between a bulged arc which is circumscribed by a\n+ * circular arc of radius `radius_outer` and a bulged arc which is\n+ * circumscribed by a circular arc of radius `radius_inner`. These arcs can be\n+ * made to be straight or circular, based on the value of `circularity_inner`\n+ * or `circularity_outer`, which can take on values between 0 (for straight)\n+ * and 1 (for circular). These arcs extend \\f$\\pi/2\\f$ in angle, and can be\n+ * oriented along the +/- x or y axis. The choice of using either equiangular\n+ * or equidistant coordinates along the arcs is specifiable with\n+ * `with_equiangular_map`. For a more detailed discussion, see the\n+ * documentation for Wedge3D, where the default logical coordinate that points\n+ * in the radial direction is zeta, and one may set either of the two other\n+ * logical coordinates to zero to obtain an equivalent Wedge2D map. In terms\n+ * of the variables defined in Wedge2D (the circularity \\f$c\\f$ and the radius\n+ * \\f$R\\f$), the mapping is:\n+ *\n+ *  \\f[\\vec{x}(\\xi,\\eta) =","path":"src/Domain/CoordinateMaps/Wedge2D.hpp","position":47,"original_position":47,"commit_id":"fd77085308a02e8321d8e52ba0df61cf7e7b3ec3","original_commit_id":"fd77085308a02e8321d8e52ba0df61cf7e7b3ec3","user":{"login":"kidder","id":1264082,"avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"body":"define H and rho","created_at":"2018-05-17T19:39:19Z","updated_at":"2018-05-17T19:41:22Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/681#discussion_r189077202","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/189077202"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/681#discussion_r189077202"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681","id":186086351,"html_url":"https://github.com/sxs-collaboration/spectre/pull/681","diff_url":"https://github.com/sxs-collaboration/spectre/pull/681.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/681.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/681","number":681,"state":"open","locked":false,"title":"Add Cylinder Domain","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars3.githubusercontent.com/u/27026354?v=4","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nA useful Domain for testing.\r\nAlso revamps Wedge2D to be more similar in functionality to Wedge3D\r\nThis closes #421 and #422 \r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- Follows [code review guidelines](https://sxs-collaboration.github.io/spectre/code_review_guide.html)\r\n- Code has documentation and unit tests\r\n- Private member variables have a trailing underscore\r\n- Do not use [Hungarian notation](https://en.wikipedia.org/wiki/Hungarian_notation), e.g. `double* pd_blah` is bad\r\n- Header order:\r\n  1. hpp corresponding to cpp (only in cpp files)\r\n  2. Blank line (only in cpp files)\r\n  3. STL and externals (in alphabetical order)\r\n  4. Blank line\r\n  5. SpECTRE includes (in alphabetical order)\r\n- File lists in CMake are alphabetical\r\n- Correct `noexcept` specification for functions (if unsure, mark `noexcept`)\r\n- Mark objects `const` whenever possible\r\n- Almost always `auto`, except with expression templates, i.e. `DataVector`\r\n- All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.\r\n- Make sure error messages are helpful, e.g. \"The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant.\"\r\n- Prefix commits addressing PR requests with `fixup`. These commits are flagged\r\n  by Travis so we do not accidentally merge them.\r\n- Include what you use, prefer forward declarations in hpp files.\r\n- Explicitly make numbers floating point, e.g. `2.` or `2.0` over `2`\r\n- Use `Tensor`'s non-member get if the indices are constant expressions, e.g.\r\n  `get<1>(tensor)`\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n","created_at":"2018-05-04T19:53:26Z","updated_at":"2018-05-17T19:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b89242ef80ea5f80d3e2c44adf4a75819e2f416","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/681/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/fd77085308a02e8321d8e52ba0df61cf7e7b3ec3","head":{"label":"gsb76:gab_add_cylinder","ref":"gab_add_cylinder","sha":"fd77085308a02e8321d8e52ba0df61cf7e7b3ec3","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars3.githubusercontent.com/u/27026354?v=4","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"repo":{"id":94911327,"name":"spectre","full_name":"gsb76/spectre","owner":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars3.githubusercontent.com/u/27026354?v=4","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsb76/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/gsb76/spectre","forks_url":"https://api.github.com/repos/gsb76/spectre/forks","keys_url":"https://api.github.com/repos/gsb76/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsb76/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsb76/spectre/teams","hooks_url":"https://api.github.com/repos/gsb76/spectre/hooks","issue_events_url":"https://api.github.com/repos/gsb76/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/gsb76/spectre/events","assignees_url":"https://api.github.com/repos/gsb76/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/gsb76/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/gsb76/spectre/tags","blobs_url":"https://api.github.com/repos/gsb76/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsb76/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsb76/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsb76/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsb76/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/gsb76/spectre/languages","stargazers_url":"https://api.github.com/repos/gsb76/spectre/stargazers","contributors_url":"https://api.github.com/repos/gsb76/spectre/contributors","subscribers_url":"https://api.github.com/repos/gsb76/spectre/subscribers","subscription_url":"https://api.github.com/repos/gsb76/spectre/subscription","commits_url":"https://api.github.com/repos/gsb76/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsb76/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsb76/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsb76/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsb76/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/gsb76/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsb76/spectre/merges","archive_url":"https://api.github.com/repos/gsb76/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsb76/spectre/downloads","issues_url":"https://api.github.com/repos/gsb76/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/gsb76/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/gsb76/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/gsb76/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsb76/spectre/labels{/name}","releases_url":"https://api.github.com/repos/gsb76/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/gsb76/spectre/deployments","created_at":"2017-06-20T16:16:01Z","updated_at":"2017-06-20T16:16:03Z","pushed_at":"2018-05-16T22:46:58Z","git_url":"git://github.com/gsb76/spectre.git","ssh_url":"git@github.com:gsb76/spectre.git","clone_url":"https://github.com/gsb76/spectre.git","svn_url":"https://github.com/gsb76/spectre","homepage":null,"size":6767,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"5e2a6a775e99971efd338c386c63b5759a85ca3a","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-05-17T00:10:00Z","pushed_at":"2018-05-17T19:34:47Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":9891,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":73,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/681"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/681"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/fd77085308a02e8321d8e52ba0df61cf7e7b3ec3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kidder"}}