{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/comments/241995783","pull_request_review_id":185403541,"id":241995783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk5NTc4Mw==","diff_hunk":"@@ -57,7 +57,12 @@ build_uboot_files() {\n   git checkout $commit >> \"$build_log\" 2>&1\n \n   make --quiet distclean >> \"$build_log\"\n-  make --quiet rpi_3_32b_defconfig >> \"$build_log\" 2>&1\n+  if [ \"$2\" = \"raspberrypi3\" ]; then","path":"rpi-convert-stage-5.sh","position":14,"original_position":14,"commit_id":"ecb49d182e5dbdd0202612eaeb79cb607f619ade","original_commit_id":"ecb49d182e5dbdd0202612eaeb79cb607f619ade","user":{"login":"apodogrocki","id":16663797,"node_id":"MDQ6VXNlcjE2NjYzNzk3","avatar_url":"https://avatars0.githubusercontent.com/u/16663797?v=4","gravatar_id":"","url":"https://api.github.com/users/apodogrocki","html_url":"https://github.com/apodogrocki","followers_url":"https://api.github.com/users/apodogrocki/followers","following_url":"https://api.github.com/users/apodogrocki/following{/other_user}","gists_url":"https://api.github.com/users/apodogrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/apodogrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apodogrocki/subscriptions","organizations_url":"https://api.github.com/users/apodogrocki/orgs","repos_url":"https://api.github.com/users/apodogrocki/repos","events_url":"https://api.github.com/users/apodogrocki/events{/privacy}","received_events_url":"https://api.github.com/users/apodogrocki/received_events","type":"User","site_admin":false},"body":"Yes, exactly. Only remember about `==` for comparison.","created_at":"2018-12-16T20:59:48Z","updated_at":"2018-12-16T20:59:48Z","html_url":"https://github.com/mendersoftware/mender-convert/pull/59#discussion_r241995783","pull_request_url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/comments/241995783"},"html":{"href":"https://github.com/mendersoftware/mender-convert/pull/59#discussion_r241995783"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59"}},"in_reply_to_id":240949190},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59","id":237371134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzcxMTM0","html_url":"https://github.com/mendersoftware/mender-convert/pull/59","diff_url":"https://github.com/mendersoftware/mender-convert/pull/59.diff","patch_url":"https://github.com/mendersoftware/mender-convert/pull/59.patch","issue_url":"https://api.github.com/repos/mendersoftware/mender-convert/issues/59","number":59,"state":"open","locked":false,"title":"Added support for rpi0","user":{"login":"nandra","id":41572,"node_id":"MDQ6VXNlcjQxNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/41572?v=4","gravatar_id":"","url":"https://api.github.com/users/nandra","html_url":"https://github.com/nandra","followers_url":"https://api.github.com/users/nandra/followers","following_url":"https://api.github.com/users/nandra/following{/other_user}","gists_url":"https://api.github.com/users/nandra/gists{/gist_id}","starred_url":"https://api.github.com/users/nandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandra/subscriptions","organizations_url":"https://api.github.com/users/nandra/orgs","repos_url":"https://api.github.com/users/nandra/repos","events_url":"https://api.github.com/users/nandra/events{/privacy}","received_events_url":"https://api.github.com/users/nandra/received_events","type":"User","site_admin":false},"body":"Added few tweaks to have support for rpi0. With actual mender-convert master I anyway get crash when staring mender like:\r\n```Nov 13 14:05:20 raspberrypi systemd[1]: Started Mender OTA update service.\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Main process exited, code=killed, status=11/SEGV\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Service hold-off time over, scheduling restart.\r\nNov 13 14:05:20 raspberrypi systemd[1]: Stopped Mender OTA update service.\r\nNov 13 14:05:20 raspberrypi systemd[1]: Started Mender OTA update service.\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Main process exited, code=killed, status=11/SEGV\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:20 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Service hold-off time over, scheduling restart.\r\nNov 13 14:05:21 raspberrypi systemd[1]: Stopped Mender OTA update service.\r\nNov 13 14:05:21 raspberrypi systemd[1]: Started Mender OTA update service.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Main process exited, code=killed, status=11/SEGV\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Service hold-off time over, scheduling restart.\r\nNov 13 14:05:21 raspberrypi systemd[1]: Stopped Mender OTA update service.\r\nNov 13 14:05:21 raspberrypi systemd[1]: Started Mender OTA update service.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Main process exited, code=killed, status=11/SEGV\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:21 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Service hold-off time over, scheduling restart.\r\nNov 13 14:05:22 raspberrypi systemd[1]: Stopped Mender OTA update service.\r\nNov 13 14:05:22 raspberrypi systemd[1]: Started Mender OTA update service.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Main process exited, code=killed, status=11/SEGV\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Service hold-off time over, scheduling restart.\r\nNov 13 14:05:22 raspberrypi systemd[1]: Stopped Mender OTA update service.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Start request repeated too quickly.\r\nNov 13 14:05:22 raspberrypi systemd[1]: Failed to start Mender OTA update service.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Unit entered failed state.\r\nNov 13 14:05:22 raspberrypi systemd[1]: mender.service: Failed with result 'signal'.\r\n\r\n```\r\n\r\neven reading of version failed:\r\n```\r\npi@raspberrypi:~$ mender -version\r\nSegmentation fault\r\n```\r\n\r\nAny ideas? I'm using raspbian lite (so maybe something is missing there)? Thanks.","created_at":"2018-12-10T15:55:10Z","updated_at":"2018-12-16T20:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0669bfde79a528267637ecf2a63d44522f981ccf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/mender-convert/issues/59/comments","statuses_url":"https://api.github.com/repos/mendersoftware/mender-convert/statuses/ecb49d182e5dbdd0202612eaeb79cb607f619ade","head":{"label":"nandra:mender-convert-rpi0w","ref":"mender-convert-rpi0w","sha":"ecb49d182e5dbdd0202612eaeb79cb607f619ade","user":{"login":"nandra","id":41572,"node_id":"MDQ6VXNlcjQxNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/41572?v=4","gravatar_id":"","url":"https://api.github.com/users/nandra","html_url":"https://github.com/nandra","followers_url":"https://api.github.com/users/nandra/followers","following_url":"https://api.github.com/users/nandra/following{/other_user}","gists_url":"https://api.github.com/users/nandra/gists{/gist_id}","starred_url":"https://api.github.com/users/nandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandra/subscriptions","organizations_url":"https://api.github.com/users/nandra/orgs","repos_url":"https://api.github.com/users/nandra/repos","events_url":"https://api.github.com/users/nandra/events{/privacy}","received_events_url":"https://api.github.com/users/nandra/received_events","type":"User","site_admin":false},"repo":{"id":149180186,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxODAxODY=","name":"mender-conversion-tools","full_name":"nandra/mender-conversion-tools","private":false,"owner":{"login":"nandra","id":41572,"node_id":"MDQ6VXNlcjQxNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/41572?v=4","gravatar_id":"","url":"https://api.github.com/users/nandra","html_url":"https://github.com/nandra","followers_url":"https://api.github.com/users/nandra/followers","following_url":"https://api.github.com/users/nandra/following{/other_user}","gists_url":"https://api.github.com/users/nandra/gists{/gist_id}","starred_url":"https://api.github.com/users/nandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandra/subscriptions","organizations_url":"https://api.github.com/users/nandra/orgs","repos_url":"https://api.github.com/users/nandra/repos","events_url":"https://api.github.com/users/nandra/events{/privacy}","received_events_url":"https://api.github.com/users/nandra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nandra/mender-conversion-tools","description":null,"fork":true,"url":"https://api.github.com/repos/nandra/mender-conversion-tools","forks_url":"https://api.github.com/repos/nandra/mender-conversion-tools/forks","keys_url":"https://api.github.com/repos/nandra/mender-conversion-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nandra/mender-conversion-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nandra/mender-conversion-tools/teams","hooks_url":"https://api.github.com/repos/nandra/mender-conversion-tools/hooks","issue_events_url":"https://api.github.com/repos/nandra/mender-conversion-tools/issues/events{/number}","events_url":"https://api.github.com/repos/nandra/mender-conversion-tools/events","assignees_url":"https://api.github.com/repos/nandra/mender-conversion-tools/assignees{/user}","branches_url":"https://api.github.com/repos/nandra/mender-conversion-tools/branches{/branch}","tags_url":"https://api.github.com/repos/nandra/mender-conversion-tools/tags","blobs_url":"https://api.github.com/repos/nandra/mender-conversion-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nandra/mender-conversion-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nandra/mender-conversion-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/nandra/mender-conversion-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nandra/mender-conversion-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/nandra/mender-conversion-tools/languages","stargazers_url":"https://api.github.com/repos/nandra/mender-conversion-tools/stargazers","contributors_url":"https://api.github.com/repos/nandra/mender-conversion-tools/contributors","subscribers_url":"https://api.github.com/repos/nandra/mender-conversion-tools/subscribers","subscription_url":"https://api.github.com/repos/nandra/mender-conversion-tools/subscription","commits_url":"https://api.github.com/repos/nandra/mender-conversion-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/nandra/mender-conversion-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/nandra/mender-conversion-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/nandra/mender-conversion-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/nandra/mender-conversion-tools/contents/{+path}","compare_url":"https://api.github.com/repos/nandra/mender-conversion-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nandra/mender-conversion-tools/merges","archive_url":"https://api.github.com/repos/nandra/mender-conversion-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nandra/mender-conversion-tools/downloads","issues_url":"https://api.github.com/repos/nandra/mender-conversion-tools/issues{/number}","pulls_url":"https://api.github.com/repos/nandra/mender-conversion-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/nandra/mender-conversion-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/nandra/mender-conversion-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nandra/mender-conversion-tools/labels{/name}","releases_url":"https://api.github.com/repos/nandra/mender-conversion-tools/releases{/id}","deployments_url":"https://api.github.com/repos/nandra/mender-conversion-tools/deployments","created_at":"2018-09-17T19:54:44Z","updated_at":"2018-09-17T19:54:46Z","pushed_at":"2018-12-10T15:52:42Z","git_url":"git://github.com/nandra/mender-conversion-tools.git","ssh_url":"git@github.com:nandra/mender-conversion-tools.git","clone_url":"https://github.com/nandra/mender-conversion-tools.git","svn_url":"https://github.com/nandra/mender-conversion-tools","homepage":null,"size":438,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"7bfcdcc826d5d36d46be1ae762298ee82f4a9d2f","user":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":137469060,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NjkwNjA=","name":"mender-convert","full_name":"mendersoftware/mender-convert","private":false,"owner":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mendersoftware/mender-convert","description":"An easy way to integrate the Mender client into an existing image","fork":false,"url":"https://api.github.com/repos/mendersoftware/mender-convert","forks_url":"https://api.github.com/repos/mendersoftware/mender-convert/forks","keys_url":"https://api.github.com/repos/mendersoftware/mender-convert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/mender-convert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/mender-convert/teams","hooks_url":"https://api.github.com/repos/mendersoftware/mender-convert/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/mender-convert/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/mender-convert/events","assignees_url":"https://api.github.com/repos/mendersoftware/mender-convert/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/mender-convert/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/mender-convert/tags","blobs_url":"https://api.github.com/repos/mendersoftware/mender-convert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/mender-convert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/mender-convert/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/mender-convert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/mender-convert/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/mender-convert/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/mender-convert/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/mender-convert/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/mender-convert/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/mender-convert/subscription","commits_url":"https://api.github.com/repos/mendersoftware/mender-convert/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/mender-convert/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/mender-convert/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/mender-convert/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/mender-convert/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/mender-convert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/mender-convert/merges","archive_url":"https://api.github.com/repos/mendersoftware/mender-convert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/mender-convert/downloads","issues_url":"https://api.github.com/repos/mendersoftware/mender-convert/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/mender-convert/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/mender-convert/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/mender-convert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/mender-convert/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/mender-convert/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/mender-convert/deployments","created_at":"2018-06-15T09:32:53Z","updated_at":"2018-12-14T19:30:55Z","pushed_at":"2018-12-14T19:30:53Z","git_url":"git://github.com/mendersoftware/mender-convert.git","ssh_url":"git@github.com:mendersoftware/mender-convert.git","clone_url":"https://github.com/mendersoftware/mender-convert.git","svn_url":"https://github.com/mendersoftware/mender-convert","homepage":"","size":457,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59"},"html":{"href":"https://github.com/mendersoftware/mender-convert/pull/59"},"issue":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/issues/59"},"comments":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/mender-convert/statuses/ecb49d182e5dbdd0202612eaeb79cb607f619ade"}},"author_association":"NONE"}}
{"actor":{"display_login":"apodogrocki"}}