{"action":"created","issue":{"url":"https://api.github.com/repos/pangeamedia/crumb/issues/1","repository_url":"https://api.github.com/repos/pangeamedia/crumb","labels_url":"https://api.github.com/repos/pangeamedia/crumb/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/pangeamedia/crumb/issues/1/comments","events_url":"https://api.github.com/repos/pangeamedia/crumb/issues/1/events","html_url":"https://github.com/pangeamedia/crumb/pull/1","id":301077306,"number":1,"title":"Auto generate fix","user":{"login":"jspath","id":430219,"avatar_url":"https://avatars1.githubusercontent.com/u/430219?v=4","gravatar_id":"","url":"https://api.github.com/users/jspath","html_url":"https://github.com/jspath","followers_url":"https://api.github.com/users/jspath/followers","following_url":"https://api.github.com/users/jspath/following{/other_user}","gists_url":"https://api.github.com/users/jspath/gists{/gist_id}","starred_url":"https://api.github.com/users/jspath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspath/subscriptions","organizations_url":"https://api.github.com/users/jspath/orgs","repos_url":"https://api.github.com/users/jspath/repos","events_url":"https://api.github.com/users/jspath/events{/privacy}","received_events_url":"https://api.github.com/users/jspath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-28T15:52:17Z","updated_at":"2018-03-01T15:21:27Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/pangeamedia/crumb/pulls/1","html_url":"https://github.com/pangeamedia/crumb/pull/1","diff_url":"https://github.com/pangeamedia/crumb/pull/1.diff","patch_url":"https://github.com/pangeamedia/crumb/pull/1.patch"},"body":"Related crumb issues:\r\nhttps://github.com/hapijs/crumb/issues/108\r\nhttps://github.com/hapijs/crumb/issues/94\r\n\r\nSetting autoGenerate to false not only disabled automatically setting the cookie for every route, it also resulted in not READING the cookie for every route.\r\n\r\nThe problem is that the author combined READING the cookie with SETTING the cookie.\r\n\r\nMy solution, so far, is to ensure that we always try to READ the cookie, even if we aren't going to be SETTING (autoGenerating) the cookie.\r\n\r\nI'm thinking that a better solution may be to separate the reading and setting so that they don't both reside in a function called generate, which seems weird to me."},"comment":{"url":"https://api.github.com/repos/pangeamedia/crumb/issues/comments/369625724","html_url":"https://github.com/pangeamedia/crumb/pull/1#issuecomment-369625724","issue_url":"https://api.github.com/repos/pangeamedia/crumb/issues/1","id":369625724,"user":{"login":"jspath","id":430219,"avatar_url":"https://avatars1.githubusercontent.com/u/430219?v=4","gravatar_id":"","url":"https://api.github.com/users/jspath","html_url":"https://github.com/jspath","followers_url":"https://api.github.com/users/jspath/followers","following_url":"https://api.github.com/users/jspath/following{/other_user}","gists_url":"https://api.github.com/users/jspath/gists{/gist_id}","starred_url":"https://api.github.com/users/jspath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspath/subscriptions","organizations_url":"https://api.github.com/users/jspath/orgs","repos_url":"https://api.github.com/users/jspath/repos","events_url":"https://api.github.com/users/jspath/events{/privacy}","received_events_url":"https://api.github.com/users/jspath/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T15:21:27Z","updated_at":"2018-03-01T15:21:27Z","author_association":"COLLABORATOR","body":"As of right now, the public api used by the app does not require CSRF tokens, since they are all GET requests.\r\n\r\nIf we added any POST or PUT requests to the public API, we'd have to start worrying about CSRF tokens for end-users ... from what I can tell about how the crumb plugin works."}}
{"actor":{"display_login":"jspath"}}