{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64526","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64526/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64526/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64526/events","html_url":"https://github.com/kubernetes/kubernetes/pull/64526","id":327859729,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTUwNDk5","number":64526,"title":"Add scheduler throughput metric","user":{"login":"misterikkit","id":1796778,"node_id":"MDQ6VXNlcjE3OTY3Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1796778?v=4","gravatar_id":"","url":"https://api.github.com/users/misterikkit","html_url":"https://github.com/misterikkit","followers_url":"https://api.github.com/users/misterikkit/followers","following_url":"https://api.github.com/users/misterikkit/following{/other_user}","gists_url":"https://api.github.com/users/misterikkit/gists{/gist_id}","starred_url":"https://api.github.com/users/misterikkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterikkit/subscriptions","organizations_url":"https://api.github.com/users/misterikkit/orgs","repos_url":"https://api.github.com/users/misterikkit/repos","events_url":"https://api.github.com/users/misterikkit/events{/privacy}","received_events_url":"https://api.github.com/users/misterikkit/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778118404,"node_id":"MDU6TGFiZWw3NzgxMTg0MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lifecycle/stale","name":"lifecycle/stale","color":"795548","default":false},{"id":240247879,"node_id":"MDU6TGFiZWwyNDAyNDc4Nzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":482207917,"node_id":"MDU6TGFiZWw0ODIyMDc5MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-30T19:03:32Z","updated_at":"2018-09-15T00:11:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64526","html_url":"https://github.com/kubernetes/kubernetes/pull/64526","diff_url":"https://github.com/kubernetes/kubernetes/pull/64526.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64526.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis adds a counter to the scheduler that can be used to calculate\r\nthroughput.\r\n\r\nWe already measure scheduler latency, but throughput was missing. This\r\nshould be considered a key metric for the scheduler.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nWe have not been following best practices or even consistent naming in scheduler metrics up to this point. We can't reasonably change existing metrics, but I would like to choose good, consistent names going forward.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAdd prometheus metric for scheduling throughput.\r\n```\r\n\r\n/sig scheduling\r\n/sig instrumentation"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/421514739","html_url":"https://github.com/kubernetes/kubernetes/pull/64526#issuecomment-421514739","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64526","id":421514739,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTUxNDczOQ==","user":{"login":"bsalamat","id":14308438,"node_id":"MDQ6VXNlcjE0MzA4NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T00:11:23Z","updated_at":"2018-09-15T00:11:23Z","author_association":"CONTRIBUTOR","body":"/remove-lifecycle stale "}}
{"actor":{"display_login":"bsalamat"}}