{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/209043926","pull_request_review_id":144982014,"id":209043926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTA0MzkyNg==","diff_hunk":"@@ -100,6 +100,17 @@ describe(\"<RadioGroup>\", () => {\n         assert.lengthOf(group.find(Radio), 2);\n     });\n \n+    it(\"passes custom classNames to options\", () => {\n+        const OPTIONS = [{ className: \"apple\", value: \"a\" }, { className: \"banana\", value: \"b\" }];\n+        const group = mount(<RadioGroup onChange={emptyHandler} options={OPTIONS} selectedValue=\"a\" />);\n+        assert.strictEqual(findRadio(group, { value: \"a\" }).prop(\"className\"), \"apple\");\n+        assert.strictEqual(findRadio(group, { value: \"b\" }).prop(\"className\"), \"banana\");","path":"packages/core/test/controls/radioGroupTests.tsx","position":8,"original_position":8,"commit_id":"d57644d81f6749ce801203423337db57b3188a7f","original_commit_id":"d57644d81f6749ce801203423337db57b3188a7f","user":{"login":"giladgray","id":464822,"node_id":"MDQ6VXNlcjQ2NDgyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"enzyme provides `wrapper.hasClass(name): boolean`, but this is ok as error messages will be different.","created_at":"2018-08-09T19:00:48Z","updated_at":"2018-08-09T19:03:35Z","html_url":"https://github.com/palantir/blueprint/pull/2783#discussion_r209043926","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/2783","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/209043926"},"html":{"href":"https://github.com/palantir/blueprint/pull/2783#discussion_r209043926"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2783"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/2783","id":207152645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTUyNjQ1","html_url":"https://github.com/palantir/blueprint/pull/2783","diff_url":"https://github.com/palantir/blueprint/pull/2783.diff","patch_url":"https://github.com/palantir/blueprint/pull/2783.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/2783","number":2783,"state":"open","locked":false,"title":"[RadioGroup] [HtmlSelect] Fix: Pass custom className to options","user":{"login":"cmslewis","id":443450,"node_id":"MDQ6VXNlcjQ0MzQ1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/443450?v=4","gravatar_id":"","url":"https://api.github.com/users/cmslewis","html_url":"https://github.com/cmslewis","followers_url":"https://api.github.com/users/cmslewis/followers","following_url":"https://api.github.com/users/cmslewis/following{/other_user}","gists_url":"https://api.github.com/users/cmslewis/gists{/gist_id}","starred_url":"https://api.github.com/users/cmslewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmslewis/subscriptions","organizations_url":"https://api.github.com/users/cmslewis/orgs","repos_url":"https://api.github.com/users/cmslewis/repos","events_url":"https://api.github.com/users/cmslewis/events{/privacy}","received_events_url":"https://api.github.com/users/cmslewis/received_events","type":"User","site_admin":false},"body":"#### Fixes #2782 \r\n\r\n#### Checklist\r\n\r\n- [x] Include tests\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- 🐛 Fix regression: `<RadioGroup>` passes custom `className` to its options\r\n- 🐛 Fix regression: `<HtmlSelect>` passes custom `className` to its options\r\n\r\n#### Reviewers should focus on:\r\n\r\nNothing in particular. Should be simple.\r\n\r\n#### Screenshot\r\n\r\nN/A","created_at":"2018-08-08T22:13:17Z","updated_at":"2018-08-09T19:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a52248e4aee47157dda2f4114fb8f06d3b911fc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/2783/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/2783/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/2783/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/d57644d81f6749ce801203423337db57b3188a7f","head":{"label":"palantir:cl/2782-radio-classname","ref":"cl/2782-radio-classname","sha":"d57644d81f6749ce801203423337db57b3188a7f","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzOTg3Mg==","name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-08-09T18:57:53Z","pushed_at":"2018-08-09T18:57:53Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":68069,"stargazers_count":10178,"watchers_count":10178,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":698,"mirror_url":null,"archived":false,"open_issues_count":253,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":698,"open_issues":253,"watchers":10178,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"213584da8c2f914a73fbb343e87cc8e779482c86","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzOTg3Mg==","name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-08-09T18:57:53Z","pushed_at":"2018-08-09T18:57:53Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":68069,"stargazers_count":10178,"watchers_count":10178,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":698,"mirror_url":null,"archived":false,"open_issues_count":253,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":698,"open_issues":253,"watchers":10178,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2783"},"html":{"href":"https://github.com/palantir/blueprint/pull/2783"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2783"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2783/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2783/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2783/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/d57644d81f6749ce801203423337db57b3188a7f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giladgray"}}