{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/199879628","pull_request_review_id":134085512,"id":199879628,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg3OTYyOA==","diff_hunk":"@@ -733,6 +738,10 @@\n       &[type=\"password\"] {\n       /* -- Input Fields: password input field -- */\n         font-family: Verdana, sans-serif;\n+\n+        &:placeholder-shown {","path":"assets/sass/okta-theme.scss","position":25,"original_position":25,"commit_id":"92576dd8a3c98cb15090c1723abad7818e3908f5","original_commit_id":"92576dd8a3c98cb15090c1723abad7818e3908f5","user":{"login":"nikhilvenkatraman-okta","id":23267876,"node_id":"MDQ6VXNlcjIzMjY3ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/23267876?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilvenkatraman-okta","html_url":"https://github.com/nikhilvenkatraman-okta","followers_url":"https://api.github.com/users/nikhilvenkatraman-okta/followers","following_url":"https://api.github.com/users/nikhilvenkatraman-okta/following{/other_user}","gists_url":"https://api.github.com/users/nikhilvenkatraman-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilvenkatraman-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilvenkatraman-okta/subscriptions","organizations_url":"https://api.github.com/users/nikhilvenkatraman-okta/orgs","repos_url":"https://api.github.com/users/nikhilvenkatraman-okta/repos","events_url":"https://api.github.com/users/nikhilvenkatraman-okta/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilvenkatraman-okta/received_events","type":"User","site_admin":false},"body":"Fixes [OKTA-176404](https://oktainc.atlassian.net/browse/OKTA-176404) . This is because we use a different font for password field https://github.com/okta/okta-signin-widget/blob/master/assets/sass/okta-theme.scss#L735. Setting the font to `proxima` when we field is empty to avoid the jump seen in the label.","created_at":"2018-07-03T16:51:41Z","updated_at":"2018-07-03T16:51:42Z","html_url":"https://github.com/okta/okta-signin-widget/pull/489#discussion_r199879628","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/199879628"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/489#discussion_r199879628"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489","id":197883853,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODgzODUz","html_url":"https://github.com/okta/okta-signin-widget/pull/489","diff_url":"https://github.com/okta/okta-signin-widget/pull/489.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/489.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/489","number":489,"state":"open","locked":false,"title":"UX Improvements for password toggle","user":{"login":"nikhilvenkatraman-okta","id":23267876,"node_id":"MDQ6VXNlcjIzMjY3ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/23267876?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilvenkatraman-okta","html_url":"https://github.com/nikhilvenkatraman-okta","followers_url":"https://api.github.com/users/nikhilvenkatraman-okta/followers","following_url":"https://api.github.com/users/nikhilvenkatraman-okta/following{/other_user}","gists_url":"https://api.github.com/users/nikhilvenkatraman-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilvenkatraman-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilvenkatraman-okta/subscriptions","organizations_url":"https://api.github.com/users/nikhilvenkatraman-okta/orgs","repos_url":"https://api.github.com/users/nikhilvenkatraman-okta/repos","events_url":"https://api.github.com/users/nikhilvenkatraman-okta/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilvenkatraman-okta/received_events","type":"User","site_admin":false},"body":"- Make target area for eyeicon bigger so that its easier to click on mobile and add cursor pointer for desktop [OKTA-173752](https://oktainc.atlassian.net/browse/OKTA-173752)\r\n\r\nhttps://okta.box.com/s/2uklsmquhui5rr3mmxqkmfqv6l4re0pw\r\n\r\n- Added padding to input to address issue for long passwords [OKTA-177309](https://oktainc.atlassian.net/browse/OKTA-177309)\r\n\r\nBefore: \r\n<img width=\"448\" alt=\"screen shot 2018-06-29 at 1 32 38 pm\" src=\"https://user-images.githubusercontent.com/23267876/42113683-fa5947e0-7ba0-11e8-80c8-d9806bf0bf91.png\">\r\n\r\nAfter: \r\n<img width=\"441\" alt=\"screen shot 2018-06-29 at 1 32 46 pm\" src=\"https://user-images.githubusercontent.com/23267876/42113679-f61df572-7ba0-11e8-95d0-de914ab3fc66.png\">\r\n\r\n- Wrapped login page specific style overrides under `.primary-auth` classname which fixes and applies the style overrides only to login page where we have tooltip and need more space on the right [OKTA-175118](https://oktainc.atlassian.net/browse/OKTA-175118)\r\nBefore: \r\n\r\n<img width=\"490\" alt=\"screen shot 2018-06-29 at 1 35 16 pm\" src=\"https://user-images.githubusercontent.com/23267876/42113755-5678613c-7ba1-11e8-8ad7-7d64a656a356.png\">\r\n\r\nAfter: \r\n\r\n<img width=\"442\" alt=\"screen shot 2018-06-29 at 1 40 03 pm\" src=\"https://user-images.githubusercontent.com/23267876/42113936-fe91cf16-7ba1-11e8-88b4-baebb49897ee.png\">\r\n\r\n\r\n@hor-kanchan-okta @johnintrater-okta @mauriciocastillosilva-okta @eugenebakaiev-okta \r\n","created_at":"2018-06-27T23:57:32Z","updated_at":"2018-07-03T16:51:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de7889c87de48add5c435e5d808a63a8e21b31e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mauriciocastillosilva-okta","id":6979296,"node_id":"MDQ6VXNlcjY5NzkyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6979296?v=4","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/489/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/92576dd8a3c98cb15090c1723abad7818e3908f5","head":{"label":"nikhilvenkatraman-okta:nv-OKTA-173752-password-toggle-mobile-ux","ref":"nv-OKTA-173752-password-toggle-mobile-ux","sha":"92576dd8a3c98cb15090c1723abad7818e3908f5","user":{"login":"nikhilvenkatraman-okta","id":23267876,"node_id":"MDQ6VXNlcjIzMjY3ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/23267876?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilvenkatraman-okta","html_url":"https://github.com/nikhilvenkatraman-okta","followers_url":"https://api.github.com/users/nikhilvenkatraman-okta/followers","following_url":"https://api.github.com/users/nikhilvenkatraman-okta/following{/other_user}","gists_url":"https://api.github.com/users/nikhilvenkatraman-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilvenkatraman-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilvenkatraman-okta/subscriptions","organizations_url":"https://api.github.com/users/nikhilvenkatraman-okta/orgs","repos_url":"https://api.github.com/users/nikhilvenkatraman-okta/repos","events_url":"https://api.github.com/users/nikhilvenkatraman-okta/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilvenkatraman-okta/received_events","type":"User","site_admin":false},"repo":{"id":74056869,"node_id":"MDEwOlJlcG9zaXRvcnk3NDA1Njg2OQ==","name":"okta-signin-widget","full_name":"nikhilvenkatraman-okta/okta-signin-widget","owner":{"login":"nikhilvenkatraman-okta","id":23267876,"node_id":"MDQ6VXNlcjIzMjY3ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/23267876?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilvenkatraman-okta","html_url":"https://github.com/nikhilvenkatraman-okta","followers_url":"https://api.github.com/users/nikhilvenkatraman-okta/followers","following_url":"https://api.github.com/users/nikhilvenkatraman-okta/following{/other_user}","gists_url":"https://api.github.com/users/nikhilvenkatraman-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilvenkatraman-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilvenkatraman-okta/subscriptions","organizations_url":"https://api.github.com/users/nikhilvenkatraman-okta/orgs","repos_url":"https://api.github.com/users/nikhilvenkatraman-okta/repos","events_url":"https://api.github.com/users/nikhilvenkatraman-okta/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilvenkatraman-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhilvenkatraman-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/nikhilvenkatraman-okta/okta-signin-widget/deployments","created_at":"2016-11-17T18:47:28Z","updated_at":"2016-11-17T18:47:31Z","pushed_at":"2018-07-03T16:15:26Z","git_url":"git://github.com/nikhilvenkatraman-okta/okta-signin-widget.git","ssh_url":"git@github.com:nikhilvenkatraman-okta/okta-signin-widget.git","clone_url":"https://github.com/nikhilvenkatraman-okta/okta-signin-widget.git","svn_url":"https://github.com/nikhilvenkatraman-okta/okta-signin-widget","homepage":null,"size":19174,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"098cca7ce0d61d0165f20946aa916fedb9081f85","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-07-01T16:54:14Z","pushed_at":"2018-07-03T16:15:27Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":19174,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":79,"open_issues":49,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/489"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/489"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/92576dd8a3c98cb15090c1723abad7818e3908f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nikhilvenkatraman-okta"}}