{"action":"created","comment":{"url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/comments/236327091","pull_request_review_id":178379273,"id":236327091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMyNzA5MQ==","diff_hunk":"@@ -39,33 +51,23 @@ public DisclaimerDataLoader(IDataLoadService dataLoadService)\n         public Task<Collection<Disclaimer>> Load(bool forceRefresh, Language forLanguage, Location forLocation, Action<string> errorLogAction = null)\n         {\n             _lastLoadedLocation = forLocation;\n-            _lastLoadedLanguage = forLanguage;\n-\n-            Action<Collection<Disclaimer>> worker = pages =>\n-            {\n-                foreach (var page in pages)\n-                {\n-                    page.PrimaryKey = Page.GenerateKey(page.Id, forLocation, forLanguage);\n-\n-                    if (!\"\".Equals(page.ParentJsonId) && page.ParentJsonId != null)\n-                    {\n-                        page.ParentId = Page.GenerateKey(page.ParentJsonId, forLocation, forLanguage);\n-                    }\n-                }\n-            };\n-\n-            // action which will be executed on the merged list of loaded and cached data\n-            Action<Collection<Disclaimer>> persistWorker = pages =>\n+            _lastLoadedLanguage = forLanguage;\r\n+\r\n+            FileName = _lastLoadedLocation.NameWithoutStreetPrefix + \"_\" + _lastLoadedLanguage.ShortName + \"_\" + _FileNameConst + \".json\";\r\n+\r\n+            return DataLoaderProvider.ExecuteLoadMethod(forceRefresh, this, () => Helper(), errorLogAction);\r\n+        }\r\n+\r\n+        private Task<Collection<Disclaimer>> Helper()\n+        {\n+            Collection<Disclaimer> c = new Collection<Disclaimer>();\n+            return Task.Run(() =>\n             {\n-                // remove all pages which status is \"trash\"\n-                var itemsToRemove = pages.Where(x => x.Status == \"trash\").ToList();\n-                foreach (var page in itemsToRemove)\n-                {\n-                    pages.Remove(page);\n-                }\n-            };\n-\n-            return DataLoaderProvider.ExecuteLoadMethod(forceRefresh, this, () => _dataLoadService.GetDisclaimers(forLanguage, forLocation, new UpdateTime(LastUpdated.Ticks)), errorLogAction, worker, persistWorker);\n+                Disclaimer d = _dataLoadService.GetDisclaimer(_lastLoadedLanguage, _lastLoadedLocation).Result;","path":"Integreat/Integreat.Shared/Data/Loader/Targets/DisclaimerDataLoader.cs","position":72,"original_position":72,"commit_id":"d4c32709da1cfbd6f3da24d08f0dc19649083221","original_commit_id":"d4c32709da1cfbd6f3da24d08f0dc19649083221","user":{"login":"thimmy687","id":7715216,"node_id":"MDQ6VXNlcjc3MTUyMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7715216?v=4","gravatar_id":"","url":"https://api.github.com/users/thimmy687","html_url":"https://github.com/thimmy687","followers_url":"https://api.github.com/users/thimmy687/followers","following_url":"https://api.github.com/users/thimmy687/following{/other_user}","gists_url":"https://api.github.com/users/thimmy687/gists{/gist_id}","starred_url":"https://api.github.com/users/thimmy687/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thimmy687/subscriptions","organizations_url":"https://api.github.com/users/thimmy687/orgs","repos_url":"https://api.github.com/users/thimmy687/repos","events_url":"https://api.github.com/users/thimmy687/events{/privacy}","received_events_url":"https://api.github.com/users/thimmy687/received_events","type":"User","site_admin":false},"body":"I guess also here is 'var' ok? ","created_at":"2018-11-26T16:29:22Z","updated_at":"2018-11-26T16:44:59Z","html_url":"https://github.com/Integreat/app-cross_platform/pull/440#discussion_r236327091","pull_request_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/comments/236327091"},"html":{"href":"https://github.com/Integreat/app-cross_platform/pull/440#discussion_r236327091"},"pull_request":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440","id":233390539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzkwNTM5","html_url":"https://github.com/Integreat/app-cross_platform/pull/440","diff_url":"https://github.com/Integreat/app-cross_platform/pull/440.diff","patch_url":"https://github.com/Integreat/app-cross_platform/pull/440.patch","issue_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/440","number":440,"state":"open","locked":false,"title":"Apiv3","user":{"login":"Simple-codinger","id":10844097,"node_id":"MDQ6VXNlcjEwODQ0MDk3","avatar_url":"https://avatars1.githubusercontent.com/u/10844097?v=4","gravatar_id":"","url":"https://api.github.com/users/Simple-codinger","html_url":"https://github.com/Simple-codinger","followers_url":"https://api.github.com/users/Simple-codinger/followers","following_url":"https://api.github.com/users/Simple-codinger/following{/other_user}","gists_url":"https://api.github.com/users/Simple-codinger/gists{/gist_id}","starred_url":"https://api.github.com/users/Simple-codinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simple-codinger/subscriptions","organizations_url":"https://api.github.com/users/Simple-codinger/orgs","repos_url":"https://api.github.com/users/Simple-codinger/repos","events_url":"https://api.github.com/users/Simple-codinger/events{/privacy}","received_events_url":"https://api.github.com/users/Simple-codinger/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-25T18:03:59Z","updated_at":"2018-11-26T16:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085bfa67ed29bc16c36891f01a7b4c49c6a50bdb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Schedulaar","id":7025199,"node_id":"MDQ6VXNlcjcwMjUxOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7025199?v=4","gravatar_id":"","url":"https://api.github.com/users/Schedulaar","html_url":"https://github.com/Schedulaar","followers_url":"https://api.github.com/users/Schedulaar/followers","following_url":"https://api.github.com/users/Schedulaar/following{/other_user}","gists_url":"https://api.github.com/users/Schedulaar/gists{/gist_id}","starred_url":"https://api.github.com/users/Schedulaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schedulaar/subscriptions","organizations_url":"https://api.github.com/users/Schedulaar/orgs","repos_url":"https://api.github.com/users/Schedulaar/repos","events_url":"https://api.github.com/users/Schedulaar/events{/privacy}","received_events_url":"https://api.github.com/users/Schedulaar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440/commits","review_comments_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440/comments","review_comment_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/440/comments","statuses_url":"https://api.github.com/repos/Integreat/app-cross_platform/statuses/d4c32709da1cfbd6f3da24d08f0dc19649083221","head":{"label":"Integreat:APIv3","ref":"APIv3","sha":"d4c32709da1cfbd6f3da24d08f0dc19649083221","user":{"login":"Integreat","id":15210781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEwNzgx","avatar_url":"https://avatars0.githubusercontent.com/u/15210781?v=4","gravatar_id":"","url":"https://api.github.com/users/Integreat","html_url":"https://github.com/Integreat","followers_url":"https://api.github.com/users/Integreat/followers","following_url":"https://api.github.com/users/Integreat/following{/other_user}","gists_url":"https://api.github.com/users/Integreat/gists{/gist_id}","starred_url":"https://api.github.com/users/Integreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Integreat/subscriptions","organizations_url":"https://api.github.com/users/Integreat/orgs","repos_url":"https://api.github.com/users/Integreat/repos","events_url":"https://api.github.com/users/Integreat/events{/privacy}","received_events_url":"https://api.github.com/users/Integreat/received_events","type":"Organization","site_admin":false},"repo":{"id":46445664,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQ0NTY2NA==","name":"app-cross_platform","full_name":"Integreat/app-cross_platform","private":false,"owner":{"login":"Integreat","id":15210781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEwNzgx","avatar_url":"https://avatars0.githubusercontent.com/u/15210781?v=4","gravatar_id":"","url":"https://api.github.com/users/Integreat","html_url":"https://github.com/Integreat","followers_url":"https://api.github.com/users/Integreat/followers","following_url":"https://api.github.com/users/Integreat/following{/other_user}","gists_url":"https://api.github.com/users/Integreat/gists{/gist_id}","starred_url":"https://api.github.com/users/Integreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Integreat/subscriptions","organizations_url":"https://api.github.com/users/Integreat/orgs","repos_url":"https://api.github.com/users/Integreat/repos","events_url":"https://api.github.com/users/Integreat/events{/privacy}","received_events_url":"https://api.github.com/users/Integreat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Integreat/app-cross_platform","description":"Mobile guide for refugees - app frontend","fork":false,"url":"https://api.github.com/repos/Integreat/app-cross_platform","forks_url":"https://api.github.com/repos/Integreat/app-cross_platform/forks","keys_url":"https://api.github.com/repos/Integreat/app-cross_platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Integreat/app-cross_platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Integreat/app-cross_platform/teams","hooks_url":"https://api.github.com/repos/Integreat/app-cross_platform/hooks","issue_events_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/events{/number}","events_url":"https://api.github.com/repos/Integreat/app-cross_platform/events","assignees_url":"https://api.github.com/repos/Integreat/app-cross_platform/assignees{/user}","branches_url":"https://api.github.com/repos/Integreat/app-cross_platform/branches{/branch}","tags_url":"https://api.github.com/repos/Integreat/app-cross_platform/tags","blobs_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Integreat/app-cross_platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Integreat/app-cross_platform/languages","stargazers_url":"https://api.github.com/repos/Integreat/app-cross_platform/stargazers","contributors_url":"https://api.github.com/repos/Integreat/app-cross_platform/contributors","subscribers_url":"https://api.github.com/repos/Integreat/app-cross_platform/subscribers","subscription_url":"https://api.github.com/repos/Integreat/app-cross_platform/subscription","commits_url":"https://api.github.com/repos/Integreat/app-cross_platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Integreat/app-cross_platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Integreat/app-cross_platform/contents/{+path}","compare_url":"https://api.github.com/repos/Integreat/app-cross_platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Integreat/app-cross_platform/merges","archive_url":"https://api.github.com/repos/Integreat/app-cross_platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Integreat/app-cross_platform/downloads","issues_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues{/number}","pulls_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Integreat/app-cross_platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Integreat/app-cross_platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Integreat/app-cross_platform/labels{/name}","releases_url":"https://api.github.com/repos/Integreat/app-cross_platform/releases{/id}","deployments_url":"https://api.github.com/repos/Integreat/app-cross_platform/deployments","created_at":"2015-11-18T20:31:28Z","updated_at":"2018-11-14T21:31:50Z","pushed_at":"2018-11-25T18:04:00Z","git_url":"git://github.com/Integreat/app-cross_platform.git","ssh_url":"git@github.com:Integreat/app-cross_platform.git","clone_url":"https://github.com/Integreat/app-cross_platform.git","svn_url":"https://github.com/Integreat/app-cross_platform","homepage":"http://integreat-app.de/","size":19770,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":53,"license":null,"forks":1,"open_issues":53,"watchers":10,"default_branch":"dev"}},"base":{"label":"Integreat:dev","ref":"dev","sha":"ea4c1916a75d8edbd4c088872222259f43a6358d","user":{"login":"Integreat","id":15210781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEwNzgx","avatar_url":"https://avatars0.githubusercontent.com/u/15210781?v=4","gravatar_id":"","url":"https://api.github.com/users/Integreat","html_url":"https://github.com/Integreat","followers_url":"https://api.github.com/users/Integreat/followers","following_url":"https://api.github.com/users/Integreat/following{/other_user}","gists_url":"https://api.github.com/users/Integreat/gists{/gist_id}","starred_url":"https://api.github.com/users/Integreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Integreat/subscriptions","organizations_url":"https://api.github.com/users/Integreat/orgs","repos_url":"https://api.github.com/users/Integreat/repos","events_url":"https://api.github.com/users/Integreat/events{/privacy}","received_events_url":"https://api.github.com/users/Integreat/received_events","type":"Organization","site_admin":false},"repo":{"id":46445664,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQ0NTY2NA==","name":"app-cross_platform","full_name":"Integreat/app-cross_platform","private":false,"owner":{"login":"Integreat","id":15210781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEwNzgx","avatar_url":"https://avatars0.githubusercontent.com/u/15210781?v=4","gravatar_id":"","url":"https://api.github.com/users/Integreat","html_url":"https://github.com/Integreat","followers_url":"https://api.github.com/users/Integreat/followers","following_url":"https://api.github.com/users/Integreat/following{/other_user}","gists_url":"https://api.github.com/users/Integreat/gists{/gist_id}","starred_url":"https://api.github.com/users/Integreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Integreat/subscriptions","organizations_url":"https://api.github.com/users/Integreat/orgs","repos_url":"https://api.github.com/users/Integreat/repos","events_url":"https://api.github.com/users/Integreat/events{/privacy}","received_events_url":"https://api.github.com/users/Integreat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Integreat/app-cross_platform","description":"Mobile guide for refugees - app frontend","fork":false,"url":"https://api.github.com/repos/Integreat/app-cross_platform","forks_url":"https://api.github.com/repos/Integreat/app-cross_platform/forks","keys_url":"https://api.github.com/repos/Integreat/app-cross_platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Integreat/app-cross_platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Integreat/app-cross_platform/teams","hooks_url":"https://api.github.com/repos/Integreat/app-cross_platform/hooks","issue_events_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/events{/number}","events_url":"https://api.github.com/repos/Integreat/app-cross_platform/events","assignees_url":"https://api.github.com/repos/Integreat/app-cross_platform/assignees{/user}","branches_url":"https://api.github.com/repos/Integreat/app-cross_platform/branches{/branch}","tags_url":"https://api.github.com/repos/Integreat/app-cross_platform/tags","blobs_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Integreat/app-cross_platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Integreat/app-cross_platform/languages","stargazers_url":"https://api.github.com/repos/Integreat/app-cross_platform/stargazers","contributors_url":"https://api.github.com/repos/Integreat/app-cross_platform/contributors","subscribers_url":"https://api.github.com/repos/Integreat/app-cross_platform/subscribers","subscription_url":"https://api.github.com/repos/Integreat/app-cross_platform/subscription","commits_url":"https://api.github.com/repos/Integreat/app-cross_platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Integreat/app-cross_platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Integreat/app-cross_platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Integreat/app-cross_platform/contents/{+path}","compare_url":"https://api.github.com/repos/Integreat/app-cross_platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Integreat/app-cross_platform/merges","archive_url":"https://api.github.com/repos/Integreat/app-cross_platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Integreat/app-cross_platform/downloads","issues_url":"https://api.github.com/repos/Integreat/app-cross_platform/issues{/number}","pulls_url":"https://api.github.com/repos/Integreat/app-cross_platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Integreat/app-cross_platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Integreat/app-cross_platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Integreat/app-cross_platform/labels{/name}","releases_url":"https://api.github.com/repos/Integreat/app-cross_platform/releases{/id}","deployments_url":"https://api.github.com/repos/Integreat/app-cross_platform/deployments","created_at":"2015-11-18T20:31:28Z","updated_at":"2018-11-14T21:31:50Z","pushed_at":"2018-11-25T18:04:00Z","git_url":"git://github.com/Integreat/app-cross_platform.git","ssh_url":"git@github.com:Integreat/app-cross_platform.git","clone_url":"https://github.com/Integreat/app-cross_platform.git","svn_url":"https://github.com/Integreat/app-cross_platform","homepage":"http://integreat-app.de/","size":19770,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":53,"license":null,"forks":1,"open_issues":53,"watchers":10,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440"},"html":{"href":"https://github.com/Integreat/app-cross_platform/pull/440"},"issue":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/issues/440"},"comments":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/Integreat/app-cross_platform/statuses/d4c32709da1cfbd6f3da24d08f0dc19649083221"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thimmy687"}}