{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/174189759","pull_request_review_id":103499778,"id":174189759,"diff_hunk":"@@ -141,7 +143,11 @@ func startCmd(c *cli.Context) error {\n \t\tif lastError != nil {\n \t\t\tfmt.Fprintln(os.Stderr, lastError)\n \t\t}\n-\t\tlastError = ctr.Cleanup()\n+\t\t// We can only do this if we attached\n+\t\t// Otherwise the container is probably still running\n+\t\tif attach && tty {\n+\t\t\tlastError = ctr.Cleanup()","path":"cmd/podman/start.go","position":42,"original_position":42,"commit_id":"5de77e1ffa014c2e2d75f9c488f6828a6bcd02d8","original_commit_id":"5de77e1ffa014c2e2d75f9c488f6828a6bcd02d8","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars3.githubusercontent.com/u/2000835?v=4","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Add comment then so future rhatdan does not add this.","created_at":"2018-03-13T16:06:09Z","updated_at":"2018-03-13T16:06:10Z","html_url":"https://github.com/projectatomic/libpod/pull/482#discussion_r174189759","pull_request_url":"https://api.github.com/repos/projectatomic/libpod/pulls/482","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments/174189759"},"html":{"href":"https://github.com/projectatomic/libpod/pull/482#discussion_r174189759"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/482"}},"in_reply_to_id":174184446},"pull_request":{"url":"https://api.github.com/repos/projectatomic/libpod/pulls/482","id":174704062,"html_url":"https://github.com/projectatomic/libpod/pull/482","diff_url":"https://github.com/projectatomic/libpod/pull/482.diff","patch_url":"https://github.com/projectatomic/libpod/pull/482.patch","issue_url":"https://api.github.com/repos/projectatomic/libpod/issues/482","number":482,"state":"open","locked":false,"title":"Implement container restarting","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"Wire in logic for restarting containers","created_at":"2018-03-13T15:49:58Z","updated_at":"2018-03-13T16:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"116d950319a7369e71defc0188e0d737e011a00b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/libpod/pulls/482/commits","review_comments_url":"https://api.github.com/repos/projectatomic/libpod/pulls/482/comments","review_comment_url":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/libpod/issues/482/comments","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/5de77e1ffa014c2e2d75f9c488f6828a6bcd02d8","head":{"label":"mheon:restart_final","ref":"restart_final","sha":"5de77e1ffa014c2e2d75f9c488f6828a6bcd02d8","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"repo":{"id":109146470,"name":"libpod","full_name":"mheon/libpod","owner":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mheon/libpod","description":"libpod is a library used to create container pods.","fork":true,"url":"https://api.github.com/repos/mheon/libpod","forks_url":"https://api.github.com/repos/mheon/libpod/forks","keys_url":"https://api.github.com/repos/mheon/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mheon/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mheon/libpod/teams","hooks_url":"https://api.github.com/repos/mheon/libpod/hooks","issue_events_url":"https://api.github.com/repos/mheon/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/mheon/libpod/events","assignees_url":"https://api.github.com/repos/mheon/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/mheon/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/mheon/libpod/tags","blobs_url":"https://api.github.com/repos/mheon/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mheon/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mheon/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/mheon/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mheon/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/mheon/libpod/languages","stargazers_url":"https://api.github.com/repos/mheon/libpod/stargazers","contributors_url":"https://api.github.com/repos/mheon/libpod/contributors","subscribers_url":"https://api.github.com/repos/mheon/libpod/subscribers","subscription_url":"https://api.github.com/repos/mheon/libpod/subscription","commits_url":"https://api.github.com/repos/mheon/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/mheon/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/mheon/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/mheon/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/mheon/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/mheon/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mheon/libpod/merges","archive_url":"https://api.github.com/repos/mheon/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mheon/libpod/downloads","issues_url":"https://api.github.com/repos/mheon/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/mheon/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/mheon/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/mheon/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mheon/libpod/labels{/name}","releases_url":"https://api.github.com/repos/mheon/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/mheon/libpod/deployments","created_at":"2017-11-01T15:08:55Z","updated_at":"2017-11-01T17:57:49Z","pushed_at":"2018-03-13T15:49:32Z","git_url":"git://github.com/mheon/libpod.git","ssh_url":"git@github.com:mheon/libpod.git","clone_url":"https://github.com/mheon/libpod.git","svn_url":"https://github.com/mheon/libpod","homepage":null,"size":9319,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"ce30acf1a0de78ad335652f8e34070f8850c68d1","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":109145553,"name":"libpod","full_name":"projectatomic/libpod","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/libpod","description":"libpod is a library used to create container pods.","fork":false,"url":"https://api.github.com/repos/projectatomic/libpod","forks_url":"https://api.github.com/repos/projectatomic/libpod/forks","keys_url":"https://api.github.com/repos/projectatomic/libpod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/libpod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/libpod/teams","hooks_url":"https://api.github.com/repos/projectatomic/libpod/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/libpod/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/libpod/events","assignees_url":"https://api.github.com/repos/projectatomic/libpod/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/libpod/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/libpod/tags","blobs_url":"https://api.github.com/repos/projectatomic/libpod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/libpod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/libpod/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/libpod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/libpod/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/libpod/languages","stargazers_url":"https://api.github.com/repos/projectatomic/libpod/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/libpod/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/libpod/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/libpod/subscription","commits_url":"https://api.github.com/repos/projectatomic/libpod/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/libpod/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/libpod/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/libpod/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/libpod/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/libpod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/libpod/merges","archive_url":"https://api.github.com/repos/projectatomic/libpod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/libpod/downloads","issues_url":"https://api.github.com/repos/projectatomic/libpod/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/libpod/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/libpod/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/libpod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/libpod/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/libpod/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/libpod/deployments","created_at":"2017-11-01T15:01:27Z","updated_at":"2018-03-13T13:54:31Z","pushed_at":"2018-03-13T15:49:59Z","git_url":"git://github.com/projectatomic/libpod.git","ssh_url":"git@github.com:projectatomic/libpod.git","clone_url":"https://github.com/projectatomic/libpod.git","svn_url":"https://github.com/projectatomic/libpod","homepage":null,"size":9218,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":35,"open_issues":41,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/482"},"html":{"href":"https://github.com/projectatomic/libpod/pull/482"},"issue":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/482"},"comments":{"href":"https://api.github.com/repos/projectatomic/libpod/issues/482/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/482/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/libpod/pulls/482/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/libpod/statuses/5de77e1ffa014c2e2d75f9c488f6828a6bcd02d8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rhatdan"}}