{"action":"closed","number":5094,"pull_request":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/5094","id":241202668,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjAyNjY4","html_url":"https://github.com/codecombat/codecombat/pull/5094","diff_url":"https://github.com/codecombat/codecombat/pull/5094.diff","patch_url":"https://github.com/codecombat/codecombat/pull/5094.patch","issue_url":"https://api.github.com/repos/codecombat/codecombat/issues/5094","number":5094,"state":"closed","locked":false,"title":"Reduce diplomat comment errors","user":{"login":"AndrewJakubowicz","id":15080861,"node_id":"MDQ6VXNlcjE1MDgwODYx","avatar_url":"https://avatars3.githubusercontent.com/u/15080861?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewJakubowicz","html_url":"https://github.com/AndrewJakubowicz","followers_url":"https://api.github.com/users/AndrewJakubowicz/followers","following_url":"https://api.github.com/users/AndrewJakubowicz/following{/other_user}","gists_url":"https://api.github.com/users/AndrewJakubowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewJakubowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewJakubowicz/subscriptions","organizations_url":"https://api.github.com/users/AndrewJakubowicz/orgs","repos_url":"https://api.github.com/users/AndrewJakubowicz/repos","events_url":"https://api.github.com/users/AndrewJakubowicz/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewJakubowicz/received_events","type":"User","site_admin":false},"body":"A common error is when a diplomat forgets or accidentally doesn't remove the comment from the parent key of the translation.\r\n\r\nI.e.\r\n```\r\n# a:\r\n  b: \"translation\"\r\n```\r\n\r\nWhen it should be:\r\n```\r\na:\r\n  b: \"translation\"\r\n```\r\n\r\nWhen `a` is commented, `b` becomes attached to the wrong parent key. This test catches this issue.\r\n\r\nA slight complication introduced by this test is that it will become harder to delete translations from the `en.coffee` file, requiring the translation to be deleted across all languages to make this test pass again. I think this is a fair trade off as more errors are introduced via the translation process than removing translations. \r\n\r\n\r\nThere is also a translation fix in this pull request.","created_at":"2018-12-27T18:27:33Z","updated_at":"2018-12-27T19:11:46Z","closed_at":"2018-12-27T19:11:46Z","merged_at":"2018-12-27T19:11:46Z","merge_commit_sha":"9c3b596f8768fde1d6bdd0138a032ef579fd3426","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codecombat/codecombat/pulls/5094/commits","review_comments_url":"https://api.github.com/repos/codecombat/codecombat/pulls/5094/comments","review_comment_url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codecombat/codecombat/issues/5094/comments","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/49b874c9030afa3a5e4bbf853c30aace270bd410","head":{"label":"codecombat:translation-test","ref":"translation-test","sha":"49b874c9030afa3a5e4bbf853c30aace270bd410","user":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5MzQzMA==","name":"codecombat","full_name":"codecombat/codecombat","private":false,"owner":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2018-12-27T10:39:47Z","pushed_at":"2018-12-27T19:11:46Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":225872,"stargazers_count":6553,"watchers_count":6553,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3324,"mirror_url":null,"archived":false,"open_issues_count":372,"license":null,"forks":3324,"open_issues":372,"watchers":6553,"default_branch":"master"}},"base":{"label":"codecombat:master","ref":"master","sha":"246f8efa142207c9fc9316408d55ff36a41b7c73","user":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5MzQzMA==","name":"codecombat","full_name":"codecombat/codecombat","private":false,"owner":{"login":"codecombat","id":5795842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTU4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5795842?v=4","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2018-12-27T10:39:47Z","pushed_at":"2018-12-27T19:11:46Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":225872,"stargazers_count":6553,"watchers_count":6553,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3324,"mirror_url":null,"archived":false,"open_issues_count":372,"license":null,"forks":3324,"open_issues":372,"watchers":6553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/5094"},"html":{"href":"https://github.com/codecombat/codecombat/pull/5094"},"issue":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/5094"},"comments":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/5094/comments"},"review_comments":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/5094/comments"},"review_comment":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/5094/commits"},"statuses":{"href":"https://api.github.com/repos/codecombat/codecombat/statuses/49b874c9030afa3a5e4bbf853c30aace270bd410"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AndrewJakubowicz","id":15080861,"node_id":"MDQ6VXNlcjE1MDgwODYx","avatar_url":"https://avatars3.githubusercontent.com/u/15080861?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewJakubowicz","html_url":"https://github.com/AndrewJakubowicz","followers_url":"https://api.github.com/users/AndrewJakubowicz/followers","following_url":"https://api.github.com/users/AndrewJakubowicz/following{/other_user}","gists_url":"https://api.github.com/users/AndrewJakubowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewJakubowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewJakubowicz/subscriptions","organizations_url":"https://api.github.com/users/AndrewJakubowicz/orgs","repos_url":"https://api.github.com/users/AndrewJakubowicz/repos","events_url":"https://api.github.com/users/AndrewJakubowicz/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewJakubowicz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"AndrewJakubowicz"}}