{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments/227472199","pull_request_review_id":167521356,"id":227472199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzQ3MjE5OQ==","diff_hunk":"@@ -370,7 +379,7 @@ cd ../../../infra/terraform/platform\n \n   ```\n   cd ../../../infra/kops/clusters/$ENVNAME","path":"README.md","position":57,"original_position":57,"commit_id":"dfddf9e2b89756cc61659891658c346d733d6f53","original_commit_id":"dfddf9e2b89756cc61659891658c346d733d6f53","user":{"login":"davidread","id":307612,"node_id":"MDQ6VXNlcjMwNzYxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/307612?v=4","gravatar_id":"","url":"https://api.github.com/users/davidread","html_url":"https://github.com/davidread","followers_url":"https://api.github.com/users/davidread/followers","following_url":"https://api.github.com/users/davidread/following{/other_user}","gists_url":"https://api.github.com/users/davidread/gists{/gist_id}","starred_url":"https://api.github.com/users/davidread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidread/subscriptions","organizations_url":"https://api.github.com/users/davidread/orgs","repos_url":"https://api.github.com/users/davidread/repos","events_url":"https://api.github.com/users/davidread/events{/privacy}","received_events_url":"https://api.github.com/users/davidread/received_events","type":"User","site_admin":false},"body":"am not sure why that looks like I removed an indent - it's still 2 spaces...","created_at":"2018-10-23T16:34:42Z","updated_at":"2018-10-23T16:34:42Z","html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208#discussion_r227472199","pull_request_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments/227472199"},"html":{"href":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208#discussion_r227472199"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208"}},"in_reply_to_id":227471509},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208","id":225073738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDczNzM4","html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208","diff_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208.diff","patch_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208.patch","issue_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/208","number":208,"state":"open","locked":false,"title":"Add kops cluster template and python script to obtain values from Terraform","user":{"login":"kerin","id":38736,"node_id":"MDQ6VXNlcjM4NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/38736?v=4","gravatar_id":"","url":"https://api.github.com/users/kerin","html_url":"https://github.com/kerin","followers_url":"https://api.github.com/users/kerin/followers","following_url":"https://api.github.com/users/kerin/following{/other_user}","gists_url":"https://api.github.com/users/kerin/gists{/gist_id}","starred_url":"https://api.github.com/users/kerin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerin/subscriptions","organizations_url":"https://api.github.com/users/kerin/orgs","repos_url":"https://api.github.com/users/kerin/repos","events_url":"https://api.github.com/users/kerin/events{/privacy}","received_events_url":"https://api.github.com/users/kerin/received_events","type":"User","site_admin":false},"body":"Currently we generate and update kops `ClusterSpec` YAML file via a combination of bash, yq and jq, which is quite difficult to work with. This PR replaces that setup with [kops templating](https://github.com/kubernetes/kops/blob/master/docs/cluster_template.md) and a relatively small python script which gets output JSON from terraform, transforms it into a structure suitable for kops, and renders a complete `ClusterSpec` file.\r\n\r\nThis PR is currently just an initial version created to preview proposed changes early and does not cover generation or management of `InstanceGroup` spec files for nodes and bastions, so is not yet ready to merge.","created_at":"2018-10-23T14:57:38Z","updated_at":"2018-10-23T16:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acecf3801f57ae153c231c0bde12341897f68304","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":889726344,"node_id":"MDU6TGFiZWw4ODk3MjYzNDQ=","url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/labels/dontmergeyet","name":"dontmergeyet","color":"dd6174","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/208/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/dfddf9e2b89756cc61659891658c346d733d6f53","head":{"label":"ministryofjustice:kops-templating","ref":"kops-templating","sha":"dfddf9e2b89756cc61659891658c346d733d6f53","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":77397761,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM5Nzc2MQ==","name":"analytics-platform-ops","full_name":"ministryofjustice/analytics-platform-ops","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/analytics-platform-ops","description":"Ops and deployment resources for MOJ Analytics platform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/deployments","created_at":"2016-12-26T17:27:30Z","updated_at":"2018-10-11T05:50:03Z","pushed_at":"2018-10-23T15:22:40Z","git_url":"git://github.com/ministryofjustice/analytics-platform-ops.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-ops.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-ops.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-ops","homepage":"","size":2608,"stargazers_count":9,"watchers_count":9,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":9,"watchers":9,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"41ff2904abdbb355c8836bb69a1a43c61a2cca9c","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":77397761,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM5Nzc2MQ==","name":"analytics-platform-ops","full_name":"ministryofjustice/analytics-platform-ops","private":false,"owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ministryofjustice/analytics-platform-ops","description":"Ops and deployment resources for MOJ Analytics platform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/deployments","created_at":"2016-12-26T17:27:30Z","updated_at":"2018-10-11T05:50:03Z","pushed_at":"2018-10-23T15:22:40Z","git_url":"git://github.com/ministryofjustice/analytics-platform-ops.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-ops.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-ops.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-ops","homepage":"","size":2608,"stargazers_count":9,"watchers_count":9,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":9,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208"},"html":{"href":"https://github.com/ministryofjustice/analytics-platform-ops/pull/208"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/208"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/dfddf9e2b89756cc61659891658c346d733d6f53"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidread"}}