{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/241605542","pull_request_review_id":184920671,"id":241605542,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTYwNTU0Mg==","diff_hunk":"@@ -267,6 +267,10 @@ export class Validators {\n     };\n   }\n \n+  private static getLength(value: any): number {\n+    return (value.length || (value.length == 0)) ? value.length : value.toString().length;","path":"packages/forms/src/validators.ts","position":14,"original_position":14,"commit_id":"4bb8241febe082aa3807c7b134525c9072ef7a0c","original_commit_id":"4bb8241febe082aa3807c7b134525c9072ef7a0c","user":{"login":"kara","id":3871688,"node_id":"MDQ6VXNlcjM4NzE2ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},"body":"This would have strange behavior for values that are objects (e.g. custom value accessors). They would all stringify as `object Object`, so they'd have a length of 15.  Depending on the minLength, that would mean objects sometimes pass and sometimes fail (and fail with an error message that prints \"15\"). \r\n\r\nCurrently, object values will render the `minLength` check inert, so we should probably keep it consistent.","created_at":"2018-12-14T00:00:41Z","updated_at":"2018-12-14T00:09:04Z","html_url":"https://github.com/angular/angular/pull/25678#discussion_r241605542","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/25678","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/241605542"},"html":{"href":"https://github.com/angular/angular/pull/25678#discussion_r241605542"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/25678"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/25678","id":210972510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTcyNTEw","html_url":"https://github.com/angular/angular/pull/25678","diff_url":"https://github.com/angular/angular/pull/25678.diff","patch_url":"https://github.com/angular/angular/pull/25678.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/25678","number":25678,"state":"open","locked":false,"title":"fix(forms): minLength validator treats zero value as zero length (#23…","user":{"login":"csmehta","id":5392276,"node_id":"MDQ6VXNlcjUzOTIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5392276?v=4","gravatar_id":"","url":"https://api.github.com/users/csmehta","html_url":"https://github.com/csmehta","followers_url":"https://api.github.com/users/csmehta/followers","following_url":"https://api.github.com/users/csmehta/following{/other_user}","gists_url":"https://api.github.com/users/csmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/csmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmehta/subscriptions","organizations_url":"https://api.github.com/users/csmehta/orgs","repos_url":"https://api.github.com/users/csmehta/repos","events_url":"https://api.github.com/users/csmehta/events{/privacy}","received_events_url":"https://api.github.com/users/csmehta/received_events","type":"User","site_admin":false},"body":"…749)\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: #23749\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-08-26T21:41:50Z","updated_at":"2018-12-14T00:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223e2c76761539b0f7ced04c343e346cdc8353fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":393879365,"node_id":"MDU6TGFiZWwzOTM4NzkzNjU=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20forms","name":"comp: forms","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/25678/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/25678/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/25678/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/4bb8241febe082aa3807c7b134525c9072ef7a0c","head":{"label":"csmehta:fix-minlength-validator","ref":"fix-minlength-validator","sha":"4bb8241febe082aa3807c7b134525c9072ef7a0c","user":{"login":"csmehta","id":5392276,"node_id":"MDQ6VXNlcjUzOTIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5392276?v=4","gravatar_id":"","url":"https://api.github.com/users/csmehta","html_url":"https://github.com/csmehta","followers_url":"https://api.github.com/users/csmehta/followers","following_url":"https://api.github.com/users/csmehta/following{/other_user}","gists_url":"https://api.github.com/users/csmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/csmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmehta/subscriptions","organizations_url":"https://api.github.com/users/csmehta/orgs","repos_url":"https://api.github.com/users/csmehta/repos","events_url":"https://api.github.com/users/csmehta/events{/privacy}","received_events_url":"https://api.github.com/users/csmehta/received_events","type":"User","site_admin":false},"repo":{"id":137497801,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0OTc4MDE=","name":"angular","full_name":"csmehta/angular","private":false,"owner":{"login":"csmehta","id":5392276,"node_id":"MDQ6VXNlcjUzOTIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5392276?v=4","gravatar_id":"","url":"https://api.github.com/users/csmehta","html_url":"https://github.com/csmehta","followers_url":"https://api.github.com/users/csmehta/followers","following_url":"https://api.github.com/users/csmehta/following{/other_user}","gists_url":"https://api.github.com/users/csmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/csmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmehta/subscriptions","organizations_url":"https://api.github.com/users/csmehta/orgs","repos_url":"https://api.github.com/users/csmehta/repos","events_url":"https://api.github.com/users/csmehta/events{/privacy}","received_events_url":"https://api.github.com/users/csmehta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/csmehta/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/csmehta/angular","forks_url":"https://api.github.com/repos/csmehta/angular/forks","keys_url":"https://api.github.com/repos/csmehta/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csmehta/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csmehta/angular/teams","hooks_url":"https://api.github.com/repos/csmehta/angular/hooks","issue_events_url":"https://api.github.com/repos/csmehta/angular/issues/events{/number}","events_url":"https://api.github.com/repos/csmehta/angular/events","assignees_url":"https://api.github.com/repos/csmehta/angular/assignees{/user}","branches_url":"https://api.github.com/repos/csmehta/angular/branches{/branch}","tags_url":"https://api.github.com/repos/csmehta/angular/tags","blobs_url":"https://api.github.com/repos/csmehta/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csmehta/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csmehta/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/csmehta/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csmehta/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/csmehta/angular/languages","stargazers_url":"https://api.github.com/repos/csmehta/angular/stargazers","contributors_url":"https://api.github.com/repos/csmehta/angular/contributors","subscribers_url":"https://api.github.com/repos/csmehta/angular/subscribers","subscription_url":"https://api.github.com/repos/csmehta/angular/subscription","commits_url":"https://api.github.com/repos/csmehta/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/csmehta/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/csmehta/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/csmehta/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/csmehta/angular/contents/{+path}","compare_url":"https://api.github.com/repos/csmehta/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csmehta/angular/merges","archive_url":"https://api.github.com/repos/csmehta/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csmehta/angular/downloads","issues_url":"https://api.github.com/repos/csmehta/angular/issues{/number}","pulls_url":"https://api.github.com/repos/csmehta/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/csmehta/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/csmehta/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csmehta/angular/labels{/name}","releases_url":"https://api.github.com/repos/csmehta/angular/releases{/id}","deployments_url":"https://api.github.com/repos/csmehta/angular/deployments","created_at":"2018-06-15T14:34:47Z","updated_at":"2018-06-21T03:11:50Z","pushed_at":"2018-08-28T05:31:57Z","git_url":"git://github.com/csmehta/angular.git","ssh_url":"git@github.com:csmehta/angular.git","clone_url":"https://github.com/csmehta/angular.git","svn_url":"https://github.com/csmehta/angular","homepage":"https://angular.io","size":84274,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"0024d68add9268044093fc09ca9bfc3c0cbfb8e6","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-12-13T23:54:35Z","pushed_at":"2018-12-13T23:52:59Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":96016,"stargazers_count":43488,"watchers_count":43488,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11152,"mirror_url":null,"archived":false,"open_issues_count":2608,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11152,"open_issues":2608,"watchers":43488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/25678"},"html":{"href":"https://github.com/angular/angular/pull/25678"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/25678"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/25678/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/25678/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/25678/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/4bb8241febe082aa3807c7b134525c9072ef7a0c"}},"author_association":"NONE"}}
{"actor":{"display_login":"kara"}}