{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/4265","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/4265/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4265/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/4265/events","html_url":"https://github.com/prometheus/prometheus/pull/4265","id":331910447,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTIxMDMw","number":4265,"title":"Pass group-by names in ReadHints","user":{"login":"henridf","id":1022041,"node_id":"MDQ6VXNlcjEwMjIwNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1022041?v=4","gravatar_id":"","url":"https://api.github.com/users/henridf","html_url":"https://github.com/henridf","followers_url":"https://api.github.com/users/henridf/followers","following_url":"https://api.github.com/users/henridf/following{/other_user}","gists_url":"https://api.github.com/users/henridf/gists{/gist_id}","starred_url":"https://api.github.com/users/henridf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henridf/subscriptions","organizations_url":"https://api.github.com/users/henridf/orgs","repos_url":"https://api.github.com/users/henridf/repos","events_url":"https://api.github.com/users/henridf/events{/privacy}","received_events_url":"https://api.github.com/users/henridf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-13T09:20:26Z","updated_at":"2018-06-13T10:30:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4265","html_url":"https://github.com/prometheus/prometheus/pull/4265","diff_url":"https://github.com/prometheus/prometheus/pull/4265.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4265.patch"},"body":"This PR adds a list of group-by fields to SelectParams and ReadHints. For example for the query `sum by (url, app)(my_gauge)` that list would be `[url, app]`.\r\n\r\nThis is needed in order for our (sysdig) remote read backend to allow grouping by fields that are derived metadata and that would not otherwise be returned. There may be other uses for it in other contexts.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/396891590","html_url":"https://github.com/prometheus/prometheus/pull/4265#issuecomment-396891590","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4265","id":396891590,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njg5MTU5MA==","user":{"login":"henridf","id":1022041,"node_id":"MDQ6VXNlcjEwMjIwNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1022041?v=4","gravatar_id":"","url":"https://api.github.com/users/henridf","html_url":"https://github.com/henridf","followers_url":"https://api.github.com/users/henridf/followers","following_url":"https://api.github.com/users/henridf/following{/other_user}","gists_url":"https://api.github.com/users/henridf/gists{/gist_id}","starred_url":"https://api.github.com/users/henridf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henridf/subscriptions","organizations_url":"https://api.github.com/users/henridf/orgs","repos_url":"https://api.github.com/users/henridf/repos","events_url":"https://api.github.com/users/henridf/events{/privacy}","received_events_url":"https://api.github.com/users/henridf/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T10:30:53Z","updated_at":"2018-06-13T10:30:53Z","author_association":"CONTRIBUTOR","body":"> This sounds a bit off semantically. Hints should never change the end results that a user sees, they should only enable optimisations.\r\n\r\nThere's already a precedent where SelectParams _do_ change the results (in Thanos). \r\n\r\nWhat's the difference between ReadHints and SelectParams in that respect? (I should probably have asked that question when the name came up \r\n in https://github.com/prometheus/prometheus/pull/4122#pullrequestreview-116263721 ...)\r\n"}}
{"actor":{"display_login":"henridf"}}