{"action":"created","comment":{"url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/comments/198496093","pull_request_review_id":132435024,"id":198496093,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ5NjA5Mw==","diff_hunk":"@@ -125,17 +125,17 @@ export default class Morpheme {\n    */\n   matchingValues (feature) {\n     let matches = []\n+\n     if (feature && this.features.hasOwnProperty(feature.type)) {\n       const morphemeValue = this.features[feature.type]\n-      for (const featureValue of feature.values) {\n-        if (morphemeValue.values.includes(featureValue)) {\n-          matches.push(featureValue)\n-        }\n+\n+      if (morphemeValue.value === feature.value) {","path":"lib/morpheme.js","position":12,"original_position":12,"commit_id":"9dc06b379b0fd6463f6b871f19f4c755b639f8f8","original_commit_id":"7fc687cc71fb56d8cdc4a91c7e77974101e9002c","user":{"login":"irina060981","id":12377640,"node_id":"MDQ6VXNlcjEyMzc3NjQw","avatar_url":"https://avatars1.githubusercontent.com/u/12377640?v=4","gravatar_id":"","url":"https://api.github.com/users/irina060981","html_url":"https://github.com/irina060981","followers_url":"https://api.github.com/users/irina060981/followers","following_url":"https://api.github.com/users/irina060981/following{/other_user}","gists_url":"https://api.github.com/users/irina060981/gists{/gist_id}","starred_url":"https://api.github.com/users/irina060981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irina060981/subscriptions","organizations_url":"https://api.github.com/users/irina060981/orgs","repos_url":"https://api.github.com/users/irina060981/repos","events_url":"https://api.github.com/users/irina060981/events{/privacy}","received_events_url":"https://api.github.com/users/irina060981/received_events","type":"User","site_admin":false},"body":"may be I will combine it with the prior logic - first check value = value and if it fails check through the for statement\r\n\r\nwhat do you think?\r\n","created_at":"2018-06-27T13:32:37Z","updated_at":"2018-06-27T13:32:38Z","html_url":"https://github.com/alpheios-project/inflection-tables/pull/52#discussion_r198496093","pull_request_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/comments/198496093"},"html":{"href":"https://github.com/alpheios-project/inflection-tables/pull/52#discussion_r198496093"},"pull_request":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52"}},"in_reply_to_id":198485752},"pull_request":{"url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52","id":197430027,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDMwMDI3","html_url":"https://github.com/alpheios-project/inflection-tables/pull/52","diff_url":"https://github.com/alpheios-project/inflection-tables/pull/52.diff","patch_url":"https://github.com/alpheios-project/inflection-tables/pull/52.patch","issue_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/52","number":52,"state":"open","locked":false,"title":"greek numerals table Issue#32","user":{"login":"irina060981","id":12377640,"node_id":"MDQ6VXNlcjEyMzc3NjQw","avatar_url":"https://avatars1.githubusercontent.com/u/12377640?v=4","gravatar_id":"","url":"https://api.github.com/users/irina060981","html_url":"https://github.com/irina060981","followers_url":"https://api.github.com/users/irina060981/followers","following_url":"https://api.github.com/users/irina060981/following{/other_user}","gists_url":"https://api.github.com/users/irina060981/gists{/gist_id}","starred_url":"https://api.github.com/users/irina060981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irina060981/subscriptions","organizations_url":"https://api.github.com/users/irina060981/orgs","repos_url":"https://api.github.com/users/irina060981/repos","events_url":"https://api.github.com/users/irina060981/events{/privacy}","received_events_url":"https://api.github.com/users/irina060981/received_events","type":"User","site_admin":false},"body":"1) created in converter.js a part for greek numeral\r\n\r\n2) converted alph-infl-numeral.xml to forms.csv and footnotes.csv\r\n\r\n3) added addNumeralForms to greek-language-dataset.js with special object this.numeralFullFormValues with forms for lemmas for using in matchingValues to save forms inside a lemma\r\n\r\n4) created greek-numeral-view.js\r\n\r\n5) changed matchingValues to use with numeralFullFormValues  and to  compare value (not values)\r\n\r\nit need to be used with - https://github.com/alpheios-project/data-models/pull/36\r\n","created_at":"2018-06-26T13:50:35Z","updated_at":"2018-06-27T13:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e407ddb70623210d8273847b0f8e9909a0e1bfc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52/commits","review_comments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52/comments","review_comment_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/52/comments","statuses_url":"https://api.github.com/repos/alpheios-project/inflection-tables/statuses/9dc06b379b0fd6463f6b871f19f4c755b639f8f8","head":{"label":"alpheios-project:issue#32","ref":"issue#32","sha":"9dc06b379b0fd6463f6b871f19f4c755b639f8f8","user":{"login":"alpheios-project","id":3856688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTY2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3856688?v=4","gravatar_id":"","url":"https://api.github.com/users/alpheios-project","html_url":"https://github.com/alpheios-project","followers_url":"https://api.github.com/users/alpheios-project/followers","following_url":"https://api.github.com/users/alpheios-project/following{/other_user}","gists_url":"https://api.github.com/users/alpheios-project/gists{/gist_id}","starred_url":"https://api.github.com/users/alpheios-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpheios-project/subscriptions","organizations_url":"https://api.github.com/users/alpheios-project/orgs","repos_url":"https://api.github.com/users/alpheios-project/repos","events_url":"https://api.github.com/users/alpheios-project/events{/privacy}","received_events_url":"https://api.github.com/users/alpheios-project/received_events","type":"Organization","site_admin":false},"repo":{"id":93889924,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg4OTkyNA==","name":"inflection-tables","full_name":"alpheios-project/inflection-tables","owner":{"login":"alpheios-project","id":3856688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTY2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3856688?v=4","gravatar_id":"","url":"https://api.github.com/users/alpheios-project","html_url":"https://github.com/alpheios-project","followers_url":"https://api.github.com/users/alpheios-project/followers","following_url":"https://api.github.com/users/alpheios-project/following{/other_user}","gists_url":"https://api.github.com/users/alpheios-project/gists{/gist_id}","starred_url":"https://api.github.com/users/alpheios-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpheios-project/subscriptions","organizations_url":"https://api.github.com/users/alpheios-project/orgs","repos_url":"https://api.github.com/users/alpheios-project/repos","events_url":"https://api.github.com/users/alpheios-project/events{/privacy}","received_events_url":"https://api.github.com/users/alpheios-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alpheios-project/inflection-tables","description":"Inflection Table Library","fork":false,"url":"https://api.github.com/repos/alpheios-project/inflection-tables","forks_url":"https://api.github.com/repos/alpheios-project/inflection-tables/forks","keys_url":"https://api.github.com/repos/alpheios-project/inflection-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alpheios-project/inflection-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alpheios-project/inflection-tables/teams","hooks_url":"https://api.github.com/repos/alpheios-project/inflection-tables/hooks","issue_events_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/events{/number}","events_url":"https://api.github.com/repos/alpheios-project/inflection-tables/events","assignees_url":"https://api.github.com/repos/alpheios-project/inflection-tables/assignees{/user}","branches_url":"https://api.github.com/repos/alpheios-project/inflection-tables/branches{/branch}","tags_url":"https://api.github.com/repos/alpheios-project/inflection-tables/tags","blobs_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alpheios-project/inflection-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/alpheios-project/inflection-tables/languages","stargazers_url":"https://api.github.com/repos/alpheios-project/inflection-tables/stargazers","contributors_url":"https://api.github.com/repos/alpheios-project/inflection-tables/contributors","subscribers_url":"https://api.github.com/repos/alpheios-project/inflection-tables/subscribers","subscription_url":"https://api.github.com/repos/alpheios-project/inflection-tables/subscription","commits_url":"https://api.github.com/repos/alpheios-project/inflection-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/alpheios-project/inflection-tables/contents/{+path}","compare_url":"https://api.github.com/repos/alpheios-project/inflection-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alpheios-project/inflection-tables/merges","archive_url":"https://api.github.com/repos/alpheios-project/inflection-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alpheios-project/inflection-tables/downloads","issues_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues{/number}","pulls_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/alpheios-project/inflection-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/alpheios-project/inflection-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alpheios-project/inflection-tables/labels{/name}","releases_url":"https://api.github.com/repos/alpheios-project/inflection-tables/releases{/id}","deployments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/deployments","created_at":"2017-06-09T19:18:03Z","updated_at":"2018-06-25T13:31:04Z","pushed_at":"2018-06-27T13:06:27Z","git_url":"git://github.com/alpheios-project/inflection-tables.git","ssh_url":"git@github.com:alpheios-project/inflection-tables.git","clone_url":"https://github.com/alpheios-project/inflection-tables.git","svn_url":"https://github.com/alpheios-project/inflection-tables","homepage":null,"size":4508,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"alpheios-project:master","ref":"master","sha":"1a65882615b62318be55085ca2965e078ceb4096","user":{"login":"alpheios-project","id":3856688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTY2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3856688?v=4","gravatar_id":"","url":"https://api.github.com/users/alpheios-project","html_url":"https://github.com/alpheios-project","followers_url":"https://api.github.com/users/alpheios-project/followers","following_url":"https://api.github.com/users/alpheios-project/following{/other_user}","gists_url":"https://api.github.com/users/alpheios-project/gists{/gist_id}","starred_url":"https://api.github.com/users/alpheios-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpheios-project/subscriptions","organizations_url":"https://api.github.com/users/alpheios-project/orgs","repos_url":"https://api.github.com/users/alpheios-project/repos","events_url":"https://api.github.com/users/alpheios-project/events{/privacy}","received_events_url":"https://api.github.com/users/alpheios-project/received_events","type":"Organization","site_admin":false},"repo":{"id":93889924,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg4OTkyNA==","name":"inflection-tables","full_name":"alpheios-project/inflection-tables","owner":{"login":"alpheios-project","id":3856688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTY2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3856688?v=4","gravatar_id":"","url":"https://api.github.com/users/alpheios-project","html_url":"https://github.com/alpheios-project","followers_url":"https://api.github.com/users/alpheios-project/followers","following_url":"https://api.github.com/users/alpheios-project/following{/other_user}","gists_url":"https://api.github.com/users/alpheios-project/gists{/gist_id}","starred_url":"https://api.github.com/users/alpheios-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpheios-project/subscriptions","organizations_url":"https://api.github.com/users/alpheios-project/orgs","repos_url":"https://api.github.com/users/alpheios-project/repos","events_url":"https://api.github.com/users/alpheios-project/events{/privacy}","received_events_url":"https://api.github.com/users/alpheios-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alpheios-project/inflection-tables","description":"Inflection Table Library","fork":false,"url":"https://api.github.com/repos/alpheios-project/inflection-tables","forks_url":"https://api.github.com/repos/alpheios-project/inflection-tables/forks","keys_url":"https://api.github.com/repos/alpheios-project/inflection-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alpheios-project/inflection-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alpheios-project/inflection-tables/teams","hooks_url":"https://api.github.com/repos/alpheios-project/inflection-tables/hooks","issue_events_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/events{/number}","events_url":"https://api.github.com/repos/alpheios-project/inflection-tables/events","assignees_url":"https://api.github.com/repos/alpheios-project/inflection-tables/assignees{/user}","branches_url":"https://api.github.com/repos/alpheios-project/inflection-tables/branches{/branch}","tags_url":"https://api.github.com/repos/alpheios-project/inflection-tables/tags","blobs_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alpheios-project/inflection-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/alpheios-project/inflection-tables/languages","stargazers_url":"https://api.github.com/repos/alpheios-project/inflection-tables/stargazers","contributors_url":"https://api.github.com/repos/alpheios-project/inflection-tables/contributors","subscribers_url":"https://api.github.com/repos/alpheios-project/inflection-tables/subscribers","subscription_url":"https://api.github.com/repos/alpheios-project/inflection-tables/subscription","commits_url":"https://api.github.com/repos/alpheios-project/inflection-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/alpheios-project/inflection-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/alpheios-project/inflection-tables/contents/{+path}","compare_url":"https://api.github.com/repos/alpheios-project/inflection-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alpheios-project/inflection-tables/merges","archive_url":"https://api.github.com/repos/alpheios-project/inflection-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alpheios-project/inflection-tables/downloads","issues_url":"https://api.github.com/repos/alpheios-project/inflection-tables/issues{/number}","pulls_url":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/alpheios-project/inflection-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/alpheios-project/inflection-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alpheios-project/inflection-tables/labels{/name}","releases_url":"https://api.github.com/repos/alpheios-project/inflection-tables/releases{/id}","deployments_url":"https://api.github.com/repos/alpheios-project/inflection-tables/deployments","created_at":"2017-06-09T19:18:03Z","updated_at":"2018-06-25T13:31:04Z","pushed_at":"2018-06-27T13:06:27Z","git_url":"git://github.com/alpheios-project/inflection-tables.git","ssh_url":"git@github.com:alpheios-project/inflection-tables.git","clone_url":"https://github.com/alpheios-project/inflection-tables.git","svn_url":"https://github.com/alpheios-project/inflection-tables","homepage":null,"size":4508,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52"},"html":{"href":"https://github.com/alpheios-project/inflection-tables/pull/52"},"issue":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/52"},"comments":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/alpheios-project/inflection-tables/statuses/9dc06b379b0fd6463f6b871f19f4c755b639f8f8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"irina060981"}}