{"action":"closed","number":52681,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681","id":240638163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjM4MTYz","html_url":"https://github.com/NixOS/nixpkgs/pull/52681","diff_url":"https://github.com/NixOS/nixpkgs/pull/52681.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/52681.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52681","number":52681,"state":"closed","locked":false,"title":"flexget: 2.17.14 -> 2.17.20","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\ncloses #52529 \r\n\r\nI have removed some entries from `propagatedBuildInputs` that can't be found in https://github.com/Flexget/Flexget/blob/2.17.20/requirements.in. However, I'm not sure whether they're just some optional requirements and should be added back.\r\n\r\nThe `delugeSupport` argument has been removed as deluge support is handled by the `deluge-client` library which we can always install.\r\n\r\nI did not test this thoroughly because I'm not a Flexget user. Feel free to do so in my place.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\ncc @sjau ","created_at":"2018-12-22T14:36:14Z","updated_at":"2018-12-23T15:30:58Z","closed_at":"2018-12-23T15:30:58Z","merged_at":"2018-12-23T15:30:58Z","merge_commit_sha":"0c75ad784c83196861918042348bee6edb87afb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52681/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/50198795dc44e7ef602892949f257147a0aa10f5","head":{"label":"dotlambda:flexget-2.17.20","ref":"flexget-2.17.20","sha":"50198795dc44e7ef602892949f257147a0aa10f5","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"repo":{"id":95651842,"node_id":"MDEwOlJlcG9zaXRvcnk5NTY1MTg0Mg==","name":"nixpkgs","full_name":"dotlambda/nixpkgs","private":false,"owner":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dotlambda/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dotlambda/nixpkgs","forks_url":"https://api.github.com/repos/dotlambda/nixpkgs/forks","keys_url":"https://api.github.com/repos/dotlambda/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotlambda/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotlambda/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dotlambda/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dotlambda/nixpkgs/events","assignees_url":"https://api.github.com/repos/dotlambda/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dotlambda/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotlambda/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotlambda/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dotlambda/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dotlambda/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotlambda/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotlambda/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dotlambda/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotlambda/nixpkgs/merges","archive_url":"https://api.github.com/repos/dotlambda/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotlambda/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dotlambda/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotlambda/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotlambda/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotlambda/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dotlambda/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dotlambda/nixpkgs/deployments","created_at":"2017-06-28T09:21:37Z","updated_at":"2018-08-22T23:02:37Z","pushed_at":"2018-12-23T14:10:41Z","git_url":"git://github.com/dotlambda/nixpkgs.git","ssh_url":"git@github.com:dotlambda/nixpkgs.git","clone_url":"https://github.com/dotlambda/nixpkgs.git","svn_url":"https://github.com/dotlambda/nixpkgs","homepage":null,"size":827223,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"db5399b18834397a18552679d6e934968b558d0b","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-12-23T15:23:28Z","pushed_at":"2018-12-23T15:30:58Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":906033,"stargazers_count":3117,"watchers_count":3117,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3269,"mirror_url":null,"archived":false,"open_issues_count":3452,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3269,"open_issues":3452,"watchers":3117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/52681"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52681"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52681/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52681/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/50198795dc44e7ef602892949f257147a0aa10f5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":29,"changed_files":1}}
{"actor":{"display_login":"dotlambda"}}