{"action":"created","issue":{"url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/211","repository_url":"https://api.github.com/repos/cornerstonejs/cornerstone","labels_url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/211/comments","events_url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/211/events","html_url":"https://github.com/cornerstonejs/cornerstone/pull/211","id":288745558,"number":211,"title":"IHE Consistent Presentation of Images","user":{"login":"jdnarvaez","id":3358381,"avatar_url":"https://avatars3.githubusercontent.com/u/3358381?v=4","gravatar_id":"","url":"https://api.github.com/users/jdnarvaez","html_url":"https://github.com/jdnarvaez","followers_url":"https://api.github.com/users/jdnarvaez/followers","following_url":"https://api.github.com/users/jdnarvaez/following{/other_user}","gists_url":"https://api.github.com/users/jdnarvaez/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnarvaez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnarvaez/subscriptions","organizations_url":"https://api.github.com/users/jdnarvaez/orgs","repos_url":"https://api.github.com/users/jdnarvaez/repos","events_url":"https://api.github.com/users/jdnarvaez/events{/privacy}","received_events_url":"https://api.github.com/users/jdnarvaez/received_events","type":"User","site_admin":false},"labels":[{"id":86671138,"url":"https://api.github.com/repos/cornerstonejs/cornerstone/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"swederik","id":607793,"avatar_url":"https://avatars3.githubusercontent.com/u/607793?v=4","gravatar_id":"","url":"https://api.github.com/users/swederik","html_url":"https://github.com/swederik","followers_url":"https://api.github.com/users/swederik/followers","following_url":"https://api.github.com/users/swederik/following{/other_user}","gists_url":"https://api.github.com/users/swederik/gists{/gist_id}","starred_url":"https://api.github.com/users/swederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swederik/subscriptions","organizations_url":"https://api.github.com/users/swederik/orgs","repos_url":"https://api.github.com/users/swederik/repos","events_url":"https://api.github.com/users/swederik/events{/privacy}","received_events_url":"https://api.github.com/users/swederik/received_events","type":"User","site_admin":false},"assignees":[{"login":"swederik","id":607793,"avatar_url":"https://avatars3.githubusercontent.com/u/607793?v=4","gravatar_id":"","url":"https://api.github.com/users/swederik","html_url":"https://github.com/swederik","followers_url":"https://api.github.com/users/swederik/followers","following_url":"https://api.github.com/users/swederik/following{/other_user}","gists_url":"https://api.github.com/users/swederik/gists{/gist_id}","starred_url":"https://api.github.com/users/swederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swederik/subscriptions","organizations_url":"https://api.github.com/users/swederik/orgs","repos_url":"https://api.github.com/users/swederik/repos","events_url":"https://api.github.com/users/swederik/events{/privacy}","received_events_url":"https://api.github.com/users/swederik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-01-15T23:50:43Z","updated_at":"2018-03-27T05:39:57Z","closed_at":"2018-03-27T04:09:55Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cornerstonejs/cornerstone/pulls/211","html_url":"https://github.com/cornerstonejs/cornerstone/pull/211","diff_url":"https://github.com/cornerstonejs/cornerstone/pull/211.diff","patch_url":"https://github.com/cornerstonejs/cornerstone/pull/211.patch"},"body":"This PR addresses a number of rendering issues and adds some extra functionality. The goal here was to provide functionality to pass the test set for the IHE Consistent Presentation of Images test plan based upon their image display test cases data sets and documents.\r\n\r\nMESA/IHE Spec: http://ihewiki.wustl.edu/wiki/index.php/MESA/Image_Display#Image_Display_Test_521:_Consistent_Presentation_of_Images\r\nTest Case Resource: http://ihedoc.wustl.edu/mesasoftware/12.x/display_consistency/index.html\r\n\r\nDefects addressed:\r\n\r\n- Proper display of images with a pixel representation of 1 (2's complement)\r\n- Perform inversion of images that are MONOCHROME1. This has to be performed in the correct order in the pipeline or else the image will be displayed incorrectly when LUTs are used\r\n\r\nFunctionality added:\r\n\r\n- Auto window level based on output values\r\n- Modality and VOI LUT transformations in web GL as opposed to only supporting slope/intercept and window specifications.\r\n- Support of a `displayedArea` attribute on the viewport that will allow for the specification of the GSPS displayed area module attributes and perform the correct transformations on the image. This includes sub areas, rotations, aspect ratios, etc. The specification of these attributes mirrors the DICOM spec, and I can provide a separate PR that reads a presentation state and generates a cornerstone viewport object, but since most of the DICOM processing is done elsewhere for cornerstone it did not seem appropriate to include here.\r\n\r\nThis implementation passes *most* test cases. For WebGL, cases 18 & 19 fail for Modality LUTs and cases 5, 9, 10, fail for VOI LUTs still. For the canvas implementation, cases 18 & 19 fail for Modality LUTs. I may very well be overlooking something simple in these cases, but I haven't addressed them yet. \r\n\r\nI have implementations for rendering text annotations, graphic annotations, display shutters, and overlays to facilitate the passage of those test cases in the IHE spec, but these seem suited for the cornerstoneTools repository. "},"comment":{"url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/comments/376403374","html_url":"https://github.com/cornerstonejs/cornerstone/pull/211#issuecomment-376403374","issue_url":"https://api.github.com/repos/cornerstonejs/cornerstone/issues/211","id":376403374,"user":{"login":"Zaid-Safadi","id":10813109,"avatar_url":"https://avatars2.githubusercontent.com/u/10813109?v=4","gravatar_id":"","url":"https://api.github.com/users/Zaid-Safadi","html_url":"https://github.com/Zaid-Safadi","followers_url":"https://api.github.com/users/Zaid-Safadi/followers","following_url":"https://api.github.com/users/Zaid-Safadi/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Safadi/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Safadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Safadi/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Safadi/orgs","repos_url":"https://api.github.com/users/Zaid-Safadi/repos","events_url":"https://api.github.com/users/Zaid-Safadi/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Safadi/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T05:39:57Z","updated_at":"2018-03-27T05:39:57Z","author_association":"COLLABORATOR","body":"The new \"displayed-area\" branch is now created with the \"Displayed Area\" feature changes cherry-picked into it. @jdnarvaez , please feel free to validate the branch and provide your comments. I still like to perform some tests before merging to master.\r\n"}}
{"actor":{"display_login":"Zaid-Safadi"}}