{"action":"created","comment":{"url":"https://api.github.com/repos/h2o/h2o/pulls/comments/218936162","pull_request_review_id":156986913,"id":218936162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODkzNjE2Mg==","diff_hunk":"@@ -455,7 +482,7 @@ static int handle_incoming_request(h2o_http2_conn_t *conn, h2o_http2_stream_t *s\n         return 0;\n     }\n \n-    if (stream->_req_body.body == NULL) {\n+    if (stream->_req_body.body == NULL || (header_exists_map & H2O_HPACK_PARSE_HEADERS_PROTOCOL_EXISTS) != 0) {","path":"lib/http2/connection.c","position":73,"original_position":73,"commit_id":"c75d9a353e689b2c7582ab9f62c3019a84d53c11","original_commit_id":"bd925d20f6d45d9e9095d477c89f843536634672","user":{"login":"i110","id":969287,"node_id":"MDQ6VXNlcjk2OTI4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/969287?v=4","gravatar_id":"","url":"https://api.github.com/users/i110","html_url":"https://github.com/i110","followers_url":"https://api.github.com/users/i110/followers","following_url":"https://api.github.com/users/i110/following{/other_user}","gists_url":"https://api.github.com/users/i110/gists{/gist_id}","starred_url":"https://api.github.com/users/i110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i110/subscriptions","organizations_url":"https://api.github.com/users/i110/orgs","repos_url":"https://api.github.com/users/i110/repos","events_url":"https://api.github.com/users/i110/events{/privacy}","received_events_url":"https://api.github.com/users/i110/received_events","type":"User","site_admin":false},"body":"Added doc comment at https://github.com/h2o/h2o/pull/1768/commits/b393eccaf173109cceedefb986ea519ad1306640.\r\n\r\n> as well as looking into how the states are used and if we have a chance in simplifying the design.\r\nI think the current design is most simple, because we have to receive websocket connect request from client and reply 200 response like ordinal request-response flow. While exchanging websocket DATA frames, the stream state is `SEND_BODY`.\r\n","created_at":"2018-09-19T19:34:55Z","updated_at":"2018-09-19T19:34:55Z","html_url":"https://github.com/h2o/h2o/pull/1768#discussion_r218936162","pull_request_url":"https://api.github.com/repos/h2o/h2o/pulls/1768","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/h2o/h2o/pulls/comments/218936162"},"html":{"href":"https://github.com/h2o/h2o/pull/1768#discussion_r218936162"},"pull_request":{"href":"https://api.github.com/repos/h2o/h2o/pulls/1768"}},"in_reply_to_id":210799583},"pull_request":{"url":"https://api.github.com/repos/h2o/h2o/pulls/1768","id":191025177,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDI1MTc3","html_url":"https://github.com/h2o/h2o/pull/1768","diff_url":"https://github.com/h2o/h2o/pull/1768.diff","patch_url":"https://github.com/h2o/h2o/pull/1768.patch","issue_url":"https://api.github.com/repos/h2o/h2o/issues/1768","number":1768,"state":"open","locked":false,"title":"websockets upon h2","user":{"login":"i110","id":969287,"node_id":"MDQ6VXNlcjk2OTI4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/969287?v=4","gravatar_id":"","url":"https://api.github.com/users/i110","html_url":"https://github.com/i110","followers_url":"https://api.github.com/users/i110/followers","following_url":"https://api.github.com/users/i110/following{/other_user}","gists_url":"https://api.github.com/users/i110/gists{/gist_id}","starred_url":"https://api.github.com/users/i110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i110/subscriptions","organizations_url":"https://api.github.com/users/i110/orgs","repos_url":"https://api.github.com/users/i110/repos","events_url":"https://api.github.com/users/i110/events{/privacy}","received_events_url":"https://api.github.com/users/i110/received_events","type":"User","site_admin":false},"body":"This PR implements `Bootstrapping WebSockets with HTTP/2` (https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-05): allows h2 clients to initiate websocket connection in h2 streams.","created_at":"2018-05-29T03:28:44Z","updated_at":"2018-09-19T19:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4693535b3d32bb70cafa28e6777f9a1474d39224","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/h2o/h2o/pulls/1768/commits","review_comments_url":"https://api.github.com/repos/h2o/h2o/pulls/1768/comments","review_comment_url":"https://api.github.com/repos/h2o/h2o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2o/h2o/issues/1768/comments","statuses_url":"https://api.github.com/repos/h2o/h2o/statuses/c75d9a353e689b2c7582ab9f62c3019a84d53c11","head":{"label":"h2o:i110/websockets-h2","ref":"i110/websockets-h2","sha":"c75d9a353e689b2c7582ab9f62c3019a84d53c11","user":{"login":"h2o","id":9275116,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzUxMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9275116?v=4","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"repo":{"id":23029617,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAyOTYxNw==","name":"h2o","full_name":"h2o/h2o","private":false,"owner":{"login":"h2o","id":9275116,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzUxMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9275116?v=4","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2o/h2o","description":"H2O - the optimized HTTP/1, HTTP/2 server","fork":false,"url":"https://api.github.com/repos/h2o/h2o","forks_url":"https://api.github.com/repos/h2o/h2o/forks","keys_url":"https://api.github.com/repos/h2o/h2o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2o/h2o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2o/h2o/teams","hooks_url":"https://api.github.com/repos/h2o/h2o/hooks","issue_events_url":"https://api.github.com/repos/h2o/h2o/issues/events{/number}","events_url":"https://api.github.com/repos/h2o/h2o/events","assignees_url":"https://api.github.com/repos/h2o/h2o/assignees{/user}","branches_url":"https://api.github.com/repos/h2o/h2o/branches{/branch}","tags_url":"https://api.github.com/repos/h2o/h2o/tags","blobs_url":"https://api.github.com/repos/h2o/h2o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2o/h2o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2o/h2o/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2o/h2o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2o/h2o/statuses/{sha}","languages_url":"https://api.github.com/repos/h2o/h2o/languages","stargazers_url":"https://api.github.com/repos/h2o/h2o/stargazers","contributors_url":"https://api.github.com/repos/h2o/h2o/contributors","subscribers_url":"https://api.github.com/repos/h2o/h2o/subscribers","subscription_url":"https://api.github.com/repos/h2o/h2o/subscription","commits_url":"https://api.github.com/repos/h2o/h2o/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2o/h2o/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2o/h2o/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2o/h2o/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2o/h2o/contents/{+path}","compare_url":"https://api.github.com/repos/h2o/h2o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2o/h2o/merges","archive_url":"https://api.github.com/repos/h2o/h2o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2o/h2o/downloads","issues_url":"https://api.github.com/repos/h2o/h2o/issues{/number}","pulls_url":"https://api.github.com/repos/h2o/h2o/pulls{/number}","milestones_url":"https://api.github.com/repos/h2o/h2o/milestones{/number}","notifications_url":"https://api.github.com/repos/h2o/h2o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2o/h2o/labels{/name}","releases_url":"https://api.github.com/repos/h2o/h2o/releases{/id}","deployments_url":"https://api.github.com/repos/h2o/h2o/deployments","created_at":"2014-08-16T23:59:03Z","updated_at":"2018-09-19T17:47:23Z","pushed_at":"2018-09-19T19:30:07Z","git_url":"git://github.com/h2o/h2o.git","ssh_url":"git@github.com:h2o/h2o.git","clone_url":"https://github.com/h2o/h2o.git","svn_url":"https://github.com/h2o/h2o","homepage":"https://h2o.examp1e.net","size":94637,"stargazers_count":7774,"watchers_count":7774,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":593,"mirror_url":null,"archived":false,"open_issues_count":410,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":593,"open_issues":410,"watchers":7774,"default_branch":"master"}},"base":{"label":"h2o:master","ref":"master","sha":"167f66021f3ebfda7c857da7a2f26e5f2e14063d","user":{"login":"h2o","id":9275116,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzUxMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9275116?v=4","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"repo":{"id":23029617,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAyOTYxNw==","name":"h2o","full_name":"h2o/h2o","private":false,"owner":{"login":"h2o","id":9275116,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzUxMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9275116?v=4","gravatar_id":"","url":"https://api.github.com/users/h2o","html_url":"https://github.com/h2o","followers_url":"https://api.github.com/users/h2o/followers","following_url":"https://api.github.com/users/h2o/following{/other_user}","gists_url":"https://api.github.com/users/h2o/gists{/gist_id}","starred_url":"https://api.github.com/users/h2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2o/subscriptions","organizations_url":"https://api.github.com/users/h2o/orgs","repos_url":"https://api.github.com/users/h2o/repos","events_url":"https://api.github.com/users/h2o/events{/privacy}","received_events_url":"https://api.github.com/users/h2o/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2o/h2o","description":"H2O - the optimized HTTP/1, HTTP/2 server","fork":false,"url":"https://api.github.com/repos/h2o/h2o","forks_url":"https://api.github.com/repos/h2o/h2o/forks","keys_url":"https://api.github.com/repos/h2o/h2o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2o/h2o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2o/h2o/teams","hooks_url":"https://api.github.com/repos/h2o/h2o/hooks","issue_events_url":"https://api.github.com/repos/h2o/h2o/issues/events{/number}","events_url":"https://api.github.com/repos/h2o/h2o/events","assignees_url":"https://api.github.com/repos/h2o/h2o/assignees{/user}","branches_url":"https://api.github.com/repos/h2o/h2o/branches{/branch}","tags_url":"https://api.github.com/repos/h2o/h2o/tags","blobs_url":"https://api.github.com/repos/h2o/h2o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2o/h2o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2o/h2o/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2o/h2o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2o/h2o/statuses/{sha}","languages_url":"https://api.github.com/repos/h2o/h2o/languages","stargazers_url":"https://api.github.com/repos/h2o/h2o/stargazers","contributors_url":"https://api.github.com/repos/h2o/h2o/contributors","subscribers_url":"https://api.github.com/repos/h2o/h2o/subscribers","subscription_url":"https://api.github.com/repos/h2o/h2o/subscription","commits_url":"https://api.github.com/repos/h2o/h2o/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2o/h2o/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2o/h2o/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2o/h2o/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2o/h2o/contents/{+path}","compare_url":"https://api.github.com/repos/h2o/h2o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2o/h2o/merges","archive_url":"https://api.github.com/repos/h2o/h2o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2o/h2o/downloads","issues_url":"https://api.github.com/repos/h2o/h2o/issues{/number}","pulls_url":"https://api.github.com/repos/h2o/h2o/pulls{/number}","milestones_url":"https://api.github.com/repos/h2o/h2o/milestones{/number}","notifications_url":"https://api.github.com/repos/h2o/h2o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2o/h2o/labels{/name}","releases_url":"https://api.github.com/repos/h2o/h2o/releases{/id}","deployments_url":"https://api.github.com/repos/h2o/h2o/deployments","created_at":"2014-08-16T23:59:03Z","updated_at":"2018-09-19T17:47:23Z","pushed_at":"2018-09-19T19:30:07Z","git_url":"git://github.com/h2o/h2o.git","ssh_url":"git@github.com:h2o/h2o.git","clone_url":"https://github.com/h2o/h2o.git","svn_url":"https://github.com/h2o/h2o","homepage":"https://h2o.examp1e.net","size":94637,"stargazers_count":7774,"watchers_count":7774,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":593,"mirror_url":null,"archived":false,"open_issues_count":410,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":593,"open_issues":410,"watchers":7774,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2o/h2o/pulls/1768"},"html":{"href":"https://github.com/h2o/h2o/pull/1768"},"issue":{"href":"https://api.github.com/repos/h2o/h2o/issues/1768"},"comments":{"href":"https://api.github.com/repos/h2o/h2o/issues/1768/comments"},"review_comments":{"href":"https://api.github.com/repos/h2o/h2o/pulls/1768/comments"},"review_comment":{"href":"https://api.github.com/repos/h2o/h2o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2o/h2o/pulls/1768/commits"},"statuses":{"href":"https://api.github.com/repos/h2o/h2o/statuses/c75d9a353e689b2c7582ab9f62c3019a84d53c11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"i110"}}