{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/244657377","pull_request_review_id":188578603,"id":244657377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY1NzM3Nw==","diff_hunk":"@@ -18,13 +18,13 @@\n package org.apache.spark.sql.hive.thriftserver\n \n import java.io._\n-import java.util.{ArrayList => JArrayList, Locale}\n+import java.util.{ArrayList, Locale}","path":"sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala","position":5,"original_position":5,"commit_id":"e091dae86450ce74b7f7c106709353b84b7e806a","original_commit_id":"e091dae86450ce74b7f7c106709353b84b7e806a","user":{"login":"gatorsmile","id":11567269,"node_id":"MDQ6VXNlcjExNTY3MjY5","avatar_url":"https://avatars1.githubusercontent.com/u/11567269?v=4","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"keep this unchanged?","created_at":"2019-01-02T03:06:51Z","updated_at":"2019-01-02T03:52:16Z","html_url":"https://github.com/apache/spark/pull/23276#discussion_r244657377","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/23276","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/244657377"},"html":{"href":"https://github.com/apache/spark/pull/23276#discussion_r244657377"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/23276"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23276","id":237356001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzU2MDAx","html_url":"https://github.com/apache/spark/pull/23276","diff_url":"https://github.com/apache/spark/pull/23276.diff","patch_url":"https://github.com/apache/spark/pull/23276.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/23276","number":23276,"state":"open","locked":false,"title":"[SPARK-26321][SQL] Split a SQL in correct way","user":{"login":"sadhen","id":1267865,"node_id":"MDQ6VXNlcjEyNjc4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1267865?v=4","gravatar_id":"","url":"https://api.github.com/users/sadhen","html_url":"https://github.com/sadhen","followers_url":"https://api.github.com/users/sadhen/followers","following_url":"https://api.github.com/users/sadhen/following{/other_user}","gists_url":"https://api.github.com/users/sadhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sadhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadhen/subscriptions","organizations_url":"https://api.github.com/users/sadhen/orgs","repos_url":"https://api.github.com/users/sadhen/repos","events_url":"https://api.github.com/users/sadhen/events{/privacy}","received_events_url":"https://api.github.com/users/sadhen/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nSplit a SQL in correct way\r\n\r\n## How was this patch tested?\r\nManually tested:\r\n```\r\n$ ./build/mvn -Phive-thriftserver -DskipTests package\r\n$ bin/spark-sql\r\n> select \"^;^\";\r\n```\r\n\r\nThe expected result is `^;^` . However, Spark master will split the SQL by `;`. As as result, `select \"^` is not a valid SQL.\r\n\r\n```\r\nspark-sql> select \"\\\";\";\r\n\";\r\nspark-sql> select \"\\';\";\r\n';\r\n```\r\n\r\nUnit Tests:\r\n```\r\n$ build/sbt -Phive-thriftserver\r\n> project hive-thriftserver\r\n> testOnly *SparkSQLCLIDriverSuite\r\n> project catalyst\r\n> testOnly *StringUtilsSuite\r\n```\r\n\r\n## TODO\r\nPolish the code on SignalHandler. However, it should be another PR.\r\n\r\n+ [x] Fix the failed tests.\r\n+ [x] Polish StringUtils.split and add more unit tests\r\n+ [x] Add scaladoc\r\n+ [x] Handling comments","created_at":"2018-12-10T15:15:16Z","updated_at":"2019-01-02T03:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2448f938400cff86eed6b7a8acb44a6d0fffdfb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/23276/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/23276/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/23276/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e091dae86450ce74b7f7c106709353b84b7e806a","head":{"label":"sadhen:fix/cli","ref":"fix/cli","sha":"e091dae86450ce74b7f7c106709353b84b7e806a","user":{"login":"sadhen","id":1267865,"node_id":"MDQ6VXNlcjEyNjc4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1267865?v=4","gravatar_id":"","url":"https://api.github.com/users/sadhen","html_url":"https://github.com/sadhen","followers_url":"https://api.github.com/users/sadhen/followers","following_url":"https://api.github.com/users/sadhen/following{/other_user}","gists_url":"https://api.github.com/users/sadhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sadhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadhen/subscriptions","organizations_url":"https://api.github.com/users/sadhen/orgs","repos_url":"https://api.github.com/users/sadhen/repos","events_url":"https://api.github.com/users/sadhen/events{/privacy}","received_events_url":"https://api.github.com/users/sadhen/received_events","type":"User","site_admin":false},"repo":{"id":129335609,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMzU2MDk=","name":"spark","full_name":"sadhen/spark","private":false,"owner":{"login":"sadhen","id":1267865,"node_id":"MDQ6VXNlcjEyNjc4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1267865?v=4","gravatar_id":"","url":"https://api.github.com/users/sadhen","html_url":"https://github.com/sadhen","followers_url":"https://api.github.com/users/sadhen/followers","following_url":"https://api.github.com/users/sadhen/following{/other_user}","gists_url":"https://api.github.com/users/sadhen/gists{/gist_id}","starred_url":"https://api.github.com/users/sadhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadhen/subscriptions","organizations_url":"https://api.github.com/users/sadhen/orgs","repos_url":"https://api.github.com/users/sadhen/repos","events_url":"https://api.github.com/users/sadhen/events{/privacy}","received_events_url":"https://api.github.com/users/sadhen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sadhen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sadhen/spark","forks_url":"https://api.github.com/repos/sadhen/spark/forks","keys_url":"https://api.github.com/repos/sadhen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sadhen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sadhen/spark/teams","hooks_url":"https://api.github.com/repos/sadhen/spark/hooks","issue_events_url":"https://api.github.com/repos/sadhen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sadhen/spark/events","assignees_url":"https://api.github.com/repos/sadhen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sadhen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sadhen/spark/tags","blobs_url":"https://api.github.com/repos/sadhen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sadhen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sadhen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sadhen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sadhen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sadhen/spark/languages","stargazers_url":"https://api.github.com/repos/sadhen/spark/stargazers","contributors_url":"https://api.github.com/repos/sadhen/spark/contributors","subscribers_url":"https://api.github.com/repos/sadhen/spark/subscribers","subscription_url":"https://api.github.com/repos/sadhen/spark/subscription","commits_url":"https://api.github.com/repos/sadhen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sadhen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sadhen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sadhen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sadhen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sadhen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sadhen/spark/merges","archive_url":"https://api.github.com/repos/sadhen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sadhen/spark/downloads","issues_url":"https://api.github.com/repos/sadhen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sadhen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sadhen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sadhen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sadhen/spark/labels{/name}","releases_url":"https://api.github.com/repos/sadhen/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sadhen/spark/deployments","created_at":"2018-04-13T02:18:26Z","updated_at":"2018-04-13T02:18:52Z","pushed_at":"2018-12-24T11:23:28Z","git_url":"git://github.com/sadhen/spark.git","ssh_url":"git@github.com:sadhen/spark.git","clone_url":"https://github.com/sadhen/spark.git","svn_url":"https://github.com/sadhen/spark","homepage":null,"size":286491,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9794923272c26ee5ba760a57718a368c33d09f04","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2019-01-02T03:42:19Z","pushed_at":"2019-01-02T03:33:39Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":"","size":290255,"stargazers_count":20081,"watchers_count":20081,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17816,"mirror_url":null,"archived":false,"open_issues_count":458,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17816,"open_issues":458,"watchers":20081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/23276"},"html":{"href":"https://github.com/apache/spark/pull/23276"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/23276"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/23276/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/23276/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/23276/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e091dae86450ce74b7f7c106709353b84b7e806a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gatorsmile"}}