{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/241152800","pull_request_review_id":184353574,"id":241152800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTE1MjgwMA==","diff_hunk":"@@ -2625,7 +2625,7 @@ static CFSocketRef _CFSocketCreateWithNative(CFAllocatorRef allocator, CFSocketN\n #endif\n         pthread_create(&tid, &attr, __CFSocketManager, 0);\n         pthread_attr_destroy(&attr);\n-//warning CF: we dont actually know that a pthread_t is the same size as void *\n+//warning CF: we dont actually know that a _CFThreadRef is the same size as void *","path":"CoreFoundation/RunLoop.subproj/CFSocket.c","position":36,"original_position":36,"commit_id":"69dcd056ea39a308866be90c812b3cdeb6d4407e","original_commit_id":"69dcd056ea39a308866be90c812b3cdeb6d4407e","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"Is CF built assuming C11 or does it attempt to compatible with C99?  If so, I'm happy to add the assertion.","created_at":"2018-12-12T19:24:44Z","updated_at":"2018-12-12T19:24:45Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1805#discussion_r241152800","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/241152800"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1805#discussion_r241152800"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805"}},"in_reply_to_id":241151773},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805","id":238108341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTA4MzQx","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1805","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1805.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1805.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1805","number":1805,"state":"open","locked":false,"title":"Windows Port Continuation","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"This replaces some of the threading types to allow us to use the Windows threading model rather than POSIX threads.  This is still incomplete, but these should also be pretty safe without changing the semantics for the other platforms.","created_at":"2018-12-12T16:50:44Z","updated_at":"2018-12-12T19:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5be05257a3d94ec768a32abaac66f6c286a31665","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1805/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/69dcd056ea39a308866be90c812b3cdeb6d4407e","head":{"label":"compnerd:windows-3","ref":"windows-3","sha":"69dcd056ea39a308866be90c812b3cdeb6d4407e","user":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"repo":{"id":58845407,"node_id":"MDEwOlJlcG9zaXRvcnk1ODg0NTQwNw==","name":"swift-corelibs-foundation","full_name":"compnerd/swift-corelibs-foundation","private":false,"owner":{"login":"compnerd","id":63311,"node_id":"MDQ6VXNlcjYzMzEx","avatar_url":"https://avatars3.githubusercontent.com/u/63311?v=4","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/compnerd/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/compnerd/swift-corelibs-foundation/deployments","created_at":"2016-05-15T05:17:54Z","updated_at":"2018-12-12T07:11:52Z","pushed_at":"2018-12-12T18:12:57Z","git_url":"git://github.com/compnerd/swift-corelibs-foundation.git","ssh_url":"git@github.com:compnerd/swift-corelibs-foundation.git","clone_url":"https://github.com/compnerd/swift-corelibs-foundation.git","svn_url":"https://github.com/compnerd/swift-corelibs-foundation","homepage":"swift.org","size":14106,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"b5d216e2ef7299faed12f404654f1f514eb8138a","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2Mzg5MA==","name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2018-12-12T18:13:46Z","pushed_at":"2018-12-12T18:12:59Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":14509,"stargazers_count":3195,"watchers_count":3195,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":779,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":779,"open_issues":33,"watchers":3195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1805"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1805"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1805/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1805/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/69dcd056ea39a308866be90c812b3cdeb6d4407e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"compnerd"}}