{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node-chakracore/issues/534","repository_url":"https://api.github.com/repos/nodejs/node-chakracore","labels_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/534/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/534/comments","events_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/534/events","html_url":"https://github.com/nodejs/node-chakracore/pull/534","id":320095200,"number":534,"title":"deps: ensure that uv handles are cleaned up before freeing them","user":{"login":"MSLaguana","id":14098340,"avatar_url":"https://avatars0.githubusercontent.com/u/14098340?v=4","gravatar_id":"","url":"https://api.github.com/users/MSLaguana","html_url":"https://github.com/MSLaguana","followers_url":"https://api.github.com/users/MSLaguana/followers","following_url":"https://api.github.com/users/MSLaguana/following{/other_user}","gists_url":"https://api.github.com/users/MSLaguana/gists{/gist_id}","starred_url":"https://api.github.com/users/MSLaguana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSLaguana/subscriptions","organizations_url":"https://api.github.com/users/MSLaguana/orgs","repos_url":"https://api.github.com/users/MSLaguana/repos","events_url":"https://api.github.com/users/MSLaguana/events{/privacy}","received_events_url":"https://api.github.com/users/MSLaguana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T22:00:45Z","updated_at":"2018-05-03T22:01:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/534","html_url":"https://github.com/nodejs/node-chakracore/pull/534","diff_url":"https://github.com/nodejs/node-chakracore/pull/534.diff","patch_url":"https://github.com/nodejs/node-chakracore/pull/534.patch"},"body":"Our IsolateShim has a few libuv handles in it which form part of\r\na list of handles. When the shim is freed, we close the handles,\r\nbut without running the UV loop they don't get properly cleaned up\r\nand so we could run into use-after-free situations.\r\n\r\nThis is unlikely to have impacted normal node scenarios since we\r\ndo not support multiple isolates at the same time, but it impacts\r\ncctest which creates several isolates in sequence.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node-chakracore/issues/comments/386450653","html_url":"https://github.com/nodejs/node-chakracore/pull/534#issuecomment-386450653","issue_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/534","id":386450653,"user":{"login":"MSLaguana","id":14098340,"avatar_url":"https://avatars0.githubusercontent.com/u/14098340?v=4","gravatar_id":"","url":"https://api.github.com/users/MSLaguana","html_url":"https://github.com/MSLaguana","followers_url":"https://api.github.com/users/MSLaguana/followers","following_url":"https://api.github.com/users/MSLaguana/following{/other_user}","gists_url":"https://api.github.com/users/MSLaguana/gists{/gist_id}","starred_url":"https://api.github.com/users/MSLaguana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSLaguana/subscriptions","organizations_url":"https://api.github.com/users/MSLaguana/orgs","repos_url":"https://api.github.com/users/MSLaguana/repos","events_url":"https://api.github.com/users/MSLaguana/events{/privacy}","received_events_url":"https://api.github.com/users/MSLaguana/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T22:01:36Z","updated_at":"2018-05-03T22:01:36Z","author_association":"CONTRIBUTOR","body":"CI: https://ci.nodejs.org/job/chakracore-test-pull-request/254/"}}
{"actor":{"display_login":"MSLaguana"}}