{"action":"closed","number":1865,"pull_request":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865","id":176984375,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1865","diff_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1865.diff","patch_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1865.patch","issue_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1865","number":1865,"state":"closed","locked":false,"title":"TapToPlace: add events for placement of objects","user":{"login":"joaocpaiva","id":24846248,"avatar_url":"https://avatars0.githubusercontent.com/u/24846248?v=4","gravatar_id":"","url":"https://api.github.com/users/joaocpaiva","html_url":"https://github.com/joaocpaiva","followers_url":"https://api.github.com/users/joaocpaiva/followers","following_url":"https://api.github.com/users/joaocpaiva/following{/other_user}","gists_url":"https://api.github.com/users/joaocpaiva/gists{/gist_id}","starred_url":"https://api.github.com/users/joaocpaiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaocpaiva/subscriptions","organizations_url":"https://api.github.com/users/joaocpaiva/orgs","repos_url":"https://api.github.com/users/joaocpaiva/repos","events_url":"https://api.github.com/users/joaocpaiva/events{/privacy}","received_events_url":"https://api.github.com/users/joaocpaiva/received_events","type":"User","site_admin":false},"body":"Uses interface to route events for every object that is placed. It fires one event when placement starts and another once placement is completed.\r\n\r\nUsed TapToPlace test scene to validate the events are triggered as expected.\r\n\r\nThis change comes as result of functionality I required for my scenario and I am sure it can be useful for other developers (as I have seen mentioned in other threads such as [PR 1222](https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1222))\r\n\r\nChanges\r\n- Fixes: #1221","created_at":"2018-03-23T06:32:10Z","updated_at":"2018-04-09T10:56:38Z","closed_at":"2018-04-09T10:56:38Z","merged_at":"2018-04-09T10:56:38Z","merge_commit_sha":"3350969e1c38c79f4fcd4783c0e6cbb1af4b1fdd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidkline-ms","id":13281406,"avatar_url":"https://avatars2.githubusercontent.com/u/13281406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkline-ms","html_url":"https://github.com/davidkline-ms","followers_url":"https://api.github.com/users/davidkline-ms/followers","following_url":"https://api.github.com/users/davidkline-ms/following{/other_user}","gists_url":"https://api.github.com/users/davidkline-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkline-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkline-ms/subscriptions","organizations_url":"https://api.github.com/users/davidkline-ms/orgs","repos_url":"https://api.github.com/users/davidkline-ms/repos","events_url":"https://api.github.com/users/davidkline-ms/events{/privacy}","received_events_url":"https://api.github.com/users/davidkline-ms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":769313068,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Ready%20for%20Review","name":"Ready for Review","color":"88f91d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1865/comments","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/b5ccba3e08276d0c1b570b546f8444c070e752ce","head":{"label":"joaocpaiva:joaocpaiva/mrtk_taptoplace_events","ref":"joaocpaiva/mrtk_taptoplace_events","sha":"b5ccba3e08276d0c1b570b546f8444c070e752ce","user":{"login":"joaocpaiva","id":24846248,"avatar_url":"https://avatars0.githubusercontent.com/u/24846248?v=4","gravatar_id":"","url":"https://api.github.com/users/joaocpaiva","html_url":"https://github.com/joaocpaiva","followers_url":"https://api.github.com/users/joaocpaiva/followers","following_url":"https://api.github.com/users/joaocpaiva/following{/other_user}","gists_url":"https://api.github.com/users/joaocpaiva/gists{/gist_id}","starred_url":"https://api.github.com/users/joaocpaiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaocpaiva/subscriptions","organizations_url":"https://api.github.com/users/joaocpaiva/orgs","repos_url":"https://api.github.com/users/joaocpaiva/repos","events_url":"https://api.github.com/users/joaocpaiva/events{/privacy}","received_events_url":"https://api.github.com/users/joaocpaiva/received_events","type":"User","site_admin":false},"repo":{"id":126214416,"name":"MixedRealityToolkit-Unity","full_name":"joaocpaiva/MixedRealityToolkit-Unity","owner":{"login":"joaocpaiva","id":24846248,"avatar_url":"https://avatars0.githubusercontent.com/u/24846248?v=4","gravatar_id":"","url":"https://api.github.com/users/joaocpaiva","html_url":"https://github.com/joaocpaiva","followers_url":"https://api.github.com/users/joaocpaiva/followers","following_url":"https://api.github.com/users/joaocpaiva/following{/other_user}","gists_url":"https://api.github.com/users/joaocpaiva/gists{/gist_id}","starred_url":"https://api.github.com/users/joaocpaiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaocpaiva/subscriptions","organizations_url":"https://api.github.com/users/joaocpaiva/orgs","repos_url":"https://api.github.com/users/joaocpaiva/repos","events_url":"https://api.github.com/users/joaocpaiva/events{/privacy}","received_events_url":"https://api.github.com/users/joaocpaiva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":true,"url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/joaocpaiva/MixedRealityToolkit-Unity/deployments","created_at":"2018-03-21T17:12:47Z","updated_at":"2018-03-21T17:13:04Z","pushed_at":"2018-03-28T20:08:23Z","git_url":"git://github.com/joaocpaiva/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:joaocpaiva/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/joaocpaiva/MixedRealityToolkit-Unity","homepage":"","size":581411,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:Dev_Working_Branch","ref":"Dev_Working_Branch","sha":"24e9561457abe43c968965b4ed425850537f5abb","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"name":"MixedRealityToolkit-Unity","full_name":"Microsoft/MixedRealityToolkit-Unity","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","description":"MixedRealityToolkit-Unity uses code from the base MixedRealityToolkit repository and makes it easier to consume in Unity.","fork":false,"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2018-04-09T08:15:28Z","pushed_at":"2018-04-09T10:56:38Z","git_url":"git://github.com/Microsoft/MixedRealityToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/MixedRealityToolkit-Unity.git","clone_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity.git","svn_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity","homepage":"","size":603567,"stargazers_count":1628,"watchers_count":1628,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":796,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":796,"open_issues":344,"watchers":1628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865"},"html":{"href":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1865"},"issue":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1865"},"comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/1865/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/1865/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/statuses/b5ccba3e08276d0c1b570b546f8444c070e752ce"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"SimonDarksideJ","id":1793042,"avatar_url":"https://avatars0.githubusercontent.com/u/1793042?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonDarksideJ","html_url":"https://github.com/SimonDarksideJ","followers_url":"https://api.github.com/users/SimonDarksideJ/followers","following_url":"https://api.github.com/users/SimonDarksideJ/following{/other_user}","gists_url":"https://api.github.com/users/SimonDarksideJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDarksideJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDarksideJ/subscriptions","organizations_url":"https://api.github.com/users/SimonDarksideJ/orgs","repos_url":"https://api.github.com/users/SimonDarksideJ/repos","events_url":"https://api.github.com/users/SimonDarksideJ/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDarksideJ/received_events","type":"User","site_admin":false},"comments":0,"review_comments":17,"maintainer_can_modify":false,"commits":8,"additions":161,"deletions":8,"changed_files":8}}
{"actor":{"display_login":"SimonDarksideJ"}}