{"push_id":2961417682,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"55ff29accb8313232e5a1a6cf5d7a54681579073","before":"79549236b644e839dc672aaf5964add580c6caa4","commits":[{"sha":"95165ec1e1116f5675c8410f230ecce95af86c6d","author":{"name":"Andrew Jeffery","email":"f8d12726b50f34e506b99227014c92d61d1be0a5@au1.ibm.com"},"message":"Revert \"sio: Add test for availability - LPC error tweak\"\n\nThis reverts commit 627379aeaa27e30d66ebb0aecf218708d465162c, which\nincorrectly attempted to account for LPC errors during testing for SIO\nabsence. The broken patch interprets the OPBM status as LPCHC status and\nexpects an LPCHC SYNC Abnormal error, however as it's the OPBM status\nthat indicates the error we never hit the LPCHC error path to populate\nthe errl with the error RC expected by the SIO driver.\n\nChange-Id: Ib993d4a2b9b4e5018d9273a1c82f8b5c21ec9a25\nSigned-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>\nReviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67459\nTested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>\nTested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>\nTested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>\nTested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>\nReviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>","distinct":true,"url":"https://api.github.com/repos/open-power/hostboot/commits/95165ec1e1116f5675c8410f230ecce95af86c6d"},{"sha":"55ff29accb8313232e5a1a6cf5d7a54681579073","author":{"name":"Andrew Jeffery","email":"f8d12726b50f34e506b99227014c92d61d1be0a5@au1.ibm.com"},"message":"sio: Add test for availability\n\nSome components can continue to operate in the face of the SuperIO\ncontroller being unavailable on the LPC bus (specifically, the UART and\nboot flag processing). Other components require it present (AST-based\nSFC implementations and the AST mailbox). Components in the latter\ncategory can just fail with an errl when they attempt to access the\ncontroller, but for those in the former category we add an isAvailable()\nfunction in the SIO namespace to sidestep dealing with errors.\n\nSpecifically, isAvailable() tests for the expected error when the\nSuperIO controller is disabled, and returns an errlHndl_t if any other\nerror occurs. This way true LPC errors are propagated to the caller to\ncommit as desired.\n\nFor the moment *all* errors produced by the SIO::isAvailable() LPC bus\naccess will result in the SIO code assuming the device is absent. We\nshould be more precise about this, but the hardware behaviour seen under\nhostboot currently prevents us from being more specific. This problem is\nhighlighted by a FIXME block in the implementation of\nSIO::isAvailable().\n\nChange-Id: Id30a09b48586d2054e0cdae625ee23df68ac2aa3\nSigned-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>\nReviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67460\nTested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>\nTested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>\nTested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>\nTested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>\nReviewed-by: Corey V. Swenson <cswenson@us.ibm.com>\nReviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>","distinct":true,"url":"https://api.github.com/repos/open-power/hostboot/commits/55ff29accb8313232e5a1a6cf5d7a54681579073"}]}
{"actor":{"display_login":"wghoffa"}}