{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8707","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8707/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8707/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8707/events","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8707","id":368346644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTQ2MDMw","number":8707,"title":"Fix accessibility issues in footer and refactor","user":{"login":"jbalboni","id":634932,"node_id":"MDQ6VXNlcjYzNDkzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/634932?v=4","gravatar_id":"","url":"https://api.github.com/users/jbalboni","html_url":"https://github.com/jbalboni","followers_url":"https://api.github.com/users/jbalboni/followers","following_url":"https://api.github.com/users/jbalboni/following{/other_user}","gists_url":"https://api.github.com/users/jbalboni/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalboni/subscriptions","organizations_url":"https://api.github.com/users/jbalboni/orgs","repos_url":"https://api.github.com/users/jbalboni/repos","events_url":"https://api.github.com/users/jbalboni/events{/privacy}","received_events_url":"https://api.github.com/users/jbalboni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-09T18:48:54Z","updated_at":"2018-10-10T16:16:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/8707","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8707","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8707.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8707.patch"},"body":"## Description\r\n\r\nThis PR is doing four things:\r\n\r\n1. Fixes the markup so that links can be moved through by screen readers correctly (https://github.com/department-of-veterans-affairs/vets.gov-team/issues/13859)\r\n2. Removes the flexbox based re-ordering in favor of separate markup for mobile/desktop versions (https://github.com/department-of-veterans-affairs/vets.gov-team/issues/13607)\r\n3. Refactors the footer into multiple components and to limit React conditionals\r\n4. Consolidates footer styles into a new footer sass file that replaces the existing footer file\r\n   - There's still some refactoring here, I mostly stayed away from refactoring the styles\r\n\r\nThe refactor is focused on trying to reduce the React fanciness in the footer code because we probably want to move to a React-less solution in the future to reduce our JS payload. This pushes us in that direction by making the vast majority of the markup static.\r\n\r\nThe less than ideal thing about this refactoring is that we have separate markup for the desktop and mobile footers, both of which are in the DOM and just hidden or shown depending on screen size.\r\n\r\nThe reason for this is that to make the content understandable for screen readers, we need the markup to be different. We need to use normal accordion markup for mobile and a more basic groups of lists approach for the normal footer.\r\n\r\n## Testing done\r\nTested locally at different breakpoints, tested in VoiceOver\r\n\r\n## Screenshots\r\n\r\n![screen shot 2018-10-09 at 2 49 39 pm](https://user-images.githubusercontent.com/634932/46691302-9220e480-cbd2-11e8-84cc-2a488ca2f9b8.png)\r\n![screen shot 2018-10-09 at 2 49 28 pm](https://user-images.githubusercontent.com/634932/46691303-9220e480-cbd2-11e8-8176-1d2ed1c50b36.png)\r\n\r\n## Acceptance criteria\r\n- [x] Footer still looks the same at different breakpoints\r\n- [ ] Screen readers can read through the links in the footer correctly\r\n- [x] Tab order follows the markup order in the mobile menu\r\n\r\n## Definition of done\r\n- [x] Events are logged appropriately\r\n- [x] Documentation has been updated, if applicable\r\n- [x] A link has been provided to the originating GitHub issue (or connected to it via ZenHub)\r\n- [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs\r\n"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments/428635779","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/8707#issuecomment-428635779","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/8707","id":428635779,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODYzNTc3OQ==","user":{"login":"ncksllvn","id":1915775,"node_id":"MDQ6VXNlcjE5MTU3NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1915775?v=4","gravatar_id":"","url":"https://api.github.com/users/ncksllvn","html_url":"https://github.com/ncksllvn","followers_url":"https://api.github.com/users/ncksllvn/followers","following_url":"https://api.github.com/users/ncksllvn/following{/other_user}","gists_url":"https://api.github.com/users/ncksllvn/gists{/gist_id}","starred_url":"https://api.github.com/users/ncksllvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncksllvn/subscriptions","organizations_url":"https://api.github.com/users/ncksllvn/orgs","repos_url":"https://api.github.com/users/ncksllvn/repos","events_url":"https://api.github.com/users/ncksllvn/events{/privacy}","received_events_url":"https://api.github.com/users/ncksllvn/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T16:16:31Z","updated_at":"2018-10-10T16:16:31Z","author_association":"CONTRIBUTOR","body":"@jbalboni There is this [partials](https://github.com/department-of-veterans-affairs/vets-website/tree/master/src/applications/proxy-rewrite/partials) folder that we could possibly leverage, but yeah, at the moment I'm not positive on how crossover between Metalsmith/React components will work and don't really want to get into it until the CMS deployment is set up. "}}
{"actor":{"display_login":"ncksllvn"}}