{"action":"opened","number":554,"pull_request":{"url":"https://api.github.com/repos/codeontap/gen3/pulls/554","id":225407692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDA3Njky","html_url":"https://github.com/codeontap/gen3/pull/554","diff_url":"https://github.com/codeontap/gen3/pull/554.diff","patch_url":"https://github.com/codeontap/gen3/pull/554.patch","issue_url":"https://api.github.com/repos/codeontap/gen3/issues/554","number":554,"state":"open","locked":false,"title":"Ensure StackOutputs and SSH Keys reference their account and region","user":{"login":"roleyfoley","id":16523764,"node_id":"MDQ6VXNlcjE2NTIzNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16523764?v=4","gravatar_id":"","url":"https://api.github.com/users/roleyfoley","html_url":"https://github.com/roleyfoley","followers_url":"https://api.github.com/users/roleyfoley/followers","following_url":"https://api.github.com/users/roleyfoley/following{/other_user}","gists_url":"https://api.github.com/users/roleyfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/roleyfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roleyfoley/subscriptions","organizations_url":"https://api.github.com/users/roleyfoley/orgs","repos_url":"https://api.github.com/users/roleyfoley/repos","events_url":"https://api.github.com/users/roleyfoley/events{/privacy}","received_events_url":"https://api.github.com/users/roleyfoley/received_events","type":"User","site_admin":false},"body":"When deploying the same environment to a new account or to multiple regions we need to have separate encyrpted ssh keys for each account-region combination for the environment-segment. \r\n\r\nThis PR adds this behaviour for the creation of new ssh keys and upgrades the existing CMDB update existing ssh keys \r\n\r\nAlong with this, older stack output files didn't reference the account in the file name. This PR adds an upgrade step which renames all stack output files to include the account-region combination. \r\n\r\nIt also checks that the minimum stack output values are available in the stack outputs file itself. \r\n\r\n**Since we cannot easily determine the accountId for the stack output files, any files without the minimum stack outputs will raise an error and they will need to be added manually to the CMDB** ","created_at":"2018-10-24T13:40:37Z","updated_at":"2018-10-24T13:40:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codeontap/gen3/pulls/554/commits","review_comments_url":"https://api.github.com/repos/codeontap/gen3/pulls/554/comments","review_comment_url":"https://api.github.com/repos/codeontap/gen3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeontap/gen3/issues/554/comments","statuses_url":"https://api.github.com/repos/codeontap/gen3/statuses/ecea8914a0c2bd1fd4e66539e1b8ba6a0321fb8e","head":{"label":"roleyfoley:fix-reference-lookup-legacy","ref":"fix-reference-lookup-legacy","sha":"ecea8914a0c2bd1fd4e66539e1b8ba6a0321fb8e","user":{"login":"roleyfoley","id":16523764,"node_id":"MDQ6VXNlcjE2NTIzNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16523764?v=4","gravatar_id":"","url":"https://api.github.com/users/roleyfoley","html_url":"https://github.com/roleyfoley","followers_url":"https://api.github.com/users/roleyfoley/followers","following_url":"https://api.github.com/users/roleyfoley/following{/other_user}","gists_url":"https://api.github.com/users/roleyfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/roleyfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roleyfoley/subscriptions","organizations_url":"https://api.github.com/users/roleyfoley/orgs","repos_url":"https://api.github.com/users/roleyfoley/repos","events_url":"https://api.github.com/users/roleyfoley/events{/privacy}","received_events_url":"https://api.github.com/users/roleyfoley/received_events","type":"User","site_admin":false},"repo":{"id":127077870,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNzc4NzA=","name":"gen3","full_name":"roleyfoley/gen3","private":false,"owner":{"login":"roleyfoley","id":16523764,"node_id":"MDQ6VXNlcjE2NTIzNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16523764?v=4","gravatar_id":"","url":"https://api.github.com/users/roleyfoley","html_url":"https://github.com/roleyfoley","followers_url":"https://api.github.com/users/roleyfoley/followers","following_url":"https://api.github.com/users/roleyfoley/following{/other_user}","gists_url":"https://api.github.com/users/roleyfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/roleyfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roleyfoley/subscriptions","organizations_url":"https://api.github.com/users/roleyfoley/orgs","repos_url":"https://api.github.com/users/roleyfoley/repos","events_url":"https://api.github.com/users/roleyfoley/events{/privacy}","received_events_url":"https://api.github.com/users/roleyfoley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/roleyfoley/gen3","description":"Framework for managing cloud infrastructure via templates. It is part of the broader CodeOnTap devops framework. ","fork":true,"url":"https://api.github.com/repos/roleyfoley/gen3","forks_url":"https://api.github.com/repos/roleyfoley/gen3/forks","keys_url":"https://api.github.com/repos/roleyfoley/gen3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roleyfoley/gen3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roleyfoley/gen3/teams","hooks_url":"https://api.github.com/repos/roleyfoley/gen3/hooks","issue_events_url":"https://api.github.com/repos/roleyfoley/gen3/issues/events{/number}","events_url":"https://api.github.com/repos/roleyfoley/gen3/events","assignees_url":"https://api.github.com/repos/roleyfoley/gen3/assignees{/user}","branches_url":"https://api.github.com/repos/roleyfoley/gen3/branches{/branch}","tags_url":"https://api.github.com/repos/roleyfoley/gen3/tags","blobs_url":"https://api.github.com/repos/roleyfoley/gen3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roleyfoley/gen3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roleyfoley/gen3/git/refs{/sha}","trees_url":"https://api.github.com/repos/roleyfoley/gen3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roleyfoley/gen3/statuses/{sha}","languages_url":"https://api.github.com/repos/roleyfoley/gen3/languages","stargazers_url":"https://api.github.com/repos/roleyfoley/gen3/stargazers","contributors_url":"https://api.github.com/repos/roleyfoley/gen3/contributors","subscribers_url":"https://api.github.com/repos/roleyfoley/gen3/subscribers","subscription_url":"https://api.github.com/repos/roleyfoley/gen3/subscription","commits_url":"https://api.github.com/repos/roleyfoley/gen3/commits{/sha}","git_commits_url":"https://api.github.com/repos/roleyfoley/gen3/git/commits{/sha}","comments_url":"https://api.github.com/repos/roleyfoley/gen3/comments{/number}","issue_comment_url":"https://api.github.com/repos/roleyfoley/gen3/issues/comments{/number}","contents_url":"https://api.github.com/repos/roleyfoley/gen3/contents/{+path}","compare_url":"https://api.github.com/repos/roleyfoley/gen3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roleyfoley/gen3/merges","archive_url":"https://api.github.com/repos/roleyfoley/gen3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roleyfoley/gen3/downloads","issues_url":"https://api.github.com/repos/roleyfoley/gen3/issues{/number}","pulls_url":"https://api.github.com/repos/roleyfoley/gen3/pulls{/number}","milestones_url":"https://api.github.com/repos/roleyfoley/gen3/milestones{/number}","notifications_url":"https://api.github.com/repos/roleyfoley/gen3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roleyfoley/gen3/labels{/name}","releases_url":"https://api.github.com/repos/roleyfoley/gen3/releases{/id}","deployments_url":"https://api.github.com/repos/roleyfoley/gen3/deployments","created_at":"2018-03-28T03:22:19Z","updated_at":"2018-05-14T06:25:17Z","pushed_at":"2018-10-24T13:33:16Z","git_url":"git://github.com/roleyfoley/gen3.git","ssh_url":"git@github.com:roleyfoley/gen3.git","clone_url":"https://github.com/roleyfoley/gen3.git","svn_url":"https://github.com/roleyfoley/gen3","homepage":"","size":7636,"stargazers_count":0,"watchers_count":0,"language":"FreeMarker","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v5.0-beta"}},"base":{"label":"codeontap:master","ref":"master","sha":"a02ce6052721330e928e257ef8065583329b89dc","user":{"login":"codeontap","id":18094234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MDk0MjM0","avatar_url":"https://avatars0.githubusercontent.com/u/18094234?v=4","gravatar_id":"","url":"https://api.github.com/users/codeontap","html_url":"https://github.com/codeontap","followers_url":"https://api.github.com/users/codeontap/followers","following_url":"https://api.github.com/users/codeontap/following{/other_user}","gists_url":"https://api.github.com/users/codeontap/gists{/gist_id}","starred_url":"https://api.github.com/users/codeontap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeontap/subscriptions","organizations_url":"https://api.github.com/users/codeontap/orgs","repos_url":"https://api.github.com/users/codeontap/repos","events_url":"https://api.github.com/users/codeontap/events{/privacy}","received_events_url":"https://api.github.com/users/codeontap/received_events","type":"Organization","site_admin":false},"repo":{"id":75681209,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY4MTIwOQ==","name":"gen3","full_name":"codeontap/gen3","private":false,"owner":{"login":"codeontap","id":18094234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MDk0MjM0","avatar_url":"https://avatars0.githubusercontent.com/u/18094234?v=4","gravatar_id":"","url":"https://api.github.com/users/codeontap","html_url":"https://github.com/codeontap","followers_url":"https://api.github.com/users/codeontap/followers","following_url":"https://api.github.com/users/codeontap/following{/other_user}","gists_url":"https://api.github.com/users/codeontap/gists{/gist_id}","starred_url":"https://api.github.com/users/codeontap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeontap/subscriptions","organizations_url":"https://api.github.com/users/codeontap/orgs","repos_url":"https://api.github.com/users/codeontap/repos","events_url":"https://api.github.com/users/codeontap/events{/privacy}","received_events_url":"https://api.github.com/users/codeontap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codeontap/gen3","description":"Framework for managing cloud infrastructure via templates. It is part of the broader CodeOnTap devops framework. ","fork":false,"url":"https://api.github.com/repos/codeontap/gen3","forks_url":"https://api.github.com/repos/codeontap/gen3/forks","keys_url":"https://api.github.com/repos/codeontap/gen3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeontap/gen3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeontap/gen3/teams","hooks_url":"https://api.github.com/repos/codeontap/gen3/hooks","issue_events_url":"https://api.github.com/repos/codeontap/gen3/issues/events{/number}","events_url":"https://api.github.com/repos/codeontap/gen3/events","assignees_url":"https://api.github.com/repos/codeontap/gen3/assignees{/user}","branches_url":"https://api.github.com/repos/codeontap/gen3/branches{/branch}","tags_url":"https://api.github.com/repos/codeontap/gen3/tags","blobs_url":"https://api.github.com/repos/codeontap/gen3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeontap/gen3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeontap/gen3/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeontap/gen3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeontap/gen3/statuses/{sha}","languages_url":"https://api.github.com/repos/codeontap/gen3/languages","stargazers_url":"https://api.github.com/repos/codeontap/gen3/stargazers","contributors_url":"https://api.github.com/repos/codeontap/gen3/contributors","subscribers_url":"https://api.github.com/repos/codeontap/gen3/subscribers","subscription_url":"https://api.github.com/repos/codeontap/gen3/subscription","commits_url":"https://api.github.com/repos/codeontap/gen3/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeontap/gen3/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeontap/gen3/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeontap/gen3/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeontap/gen3/contents/{+path}","compare_url":"https://api.github.com/repos/codeontap/gen3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeontap/gen3/merges","archive_url":"https://api.github.com/repos/codeontap/gen3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeontap/gen3/downloads","issues_url":"https://api.github.com/repos/codeontap/gen3/issues{/number}","pulls_url":"https://api.github.com/repos/codeontap/gen3/pulls{/number}","milestones_url":"https://api.github.com/repos/codeontap/gen3/milestones{/number}","notifications_url":"https://api.github.com/repos/codeontap/gen3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeontap/gen3/labels{/name}","releases_url":"https://api.github.com/repos/codeontap/gen3/releases{/id}","deployments_url":"https://api.github.com/repos/codeontap/gen3/deployments","created_at":"2016-12-06T01:12:49Z","updated_at":"2018-10-24T12:05:58Z","pushed_at":"2018-10-24T12:05:56Z","git_url":"git://github.com/codeontap/gen3.git","ssh_url":"git@github.com:codeontap/gen3.git","clone_url":"https://github.com/codeontap/gen3.git","svn_url":"https://github.com/codeontap/gen3","homepage":"","size":7216,"stargazers_count":2,"watchers_count":2,"language":"FreeMarker","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":29,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeontap/gen3/pulls/554"},"html":{"href":"https://github.com/codeontap/gen3/pull/554"},"issue":{"href":"https://api.github.com/repos/codeontap/gen3/issues/554"},"comments":{"href":"https://api.github.com/repos/codeontap/gen3/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/codeontap/gen3/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/codeontap/gen3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeontap/gen3/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/codeontap/gen3/statuses/ecea8914a0c2bd1fd4e66539e1b8ba6a0321fb8e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":108,"deletions":12,"changed_files":4}}
{"actor":{"display_login":"roleyfoley"}}