{"action":"created","issue":{"url":"https://api.github.com/repos/PAHFIT/pahfit/issues/28","repository_url":"https://api.github.com/repos/PAHFIT/pahfit","labels_url":"https://api.github.com/repos/PAHFIT/pahfit/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/PAHFIT/pahfit/issues/28/comments","events_url":"https://api.github.com/repos/PAHFIT/pahfit/issues/28/events","html_url":"https://github.com/PAHFIT/pahfit/issues/28","id":372763153,"node_id":"MDU6SXNzdWUzNzI3NjMxNTM=","number":28,"title":"Use astropy.units?","user":{"login":"karllark","id":1554536,"node_id":"MDQ6VXNlcjE1NTQ1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554536?v=4","gravatar_id":"","url":"https://api.github.com/users/karllark","html_url":"https://github.com/karllark","followers_url":"https://api.github.com/users/karllark/followers","following_url":"https://api.github.com/users/karllark/following{/other_user}","gists_url":"https://api.github.com/users/karllark/gists{/gist_id}","starred_url":"https://api.github.com/users/karllark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karllark/subscriptions","organizations_url":"https://api.github.com/users/karllark/orgs","repos_url":"https://api.github.com/users/karllark/repos","events_url":"https://api.github.com/users/karllark/events{/privacy}","received_events_url":"https://api.github.com/users/karllark/received_events","type":"User","site_admin":false},"labels":[{"id":589645933,"node_id":"MDU6TGFiZWw1ODk2NDU5MzM=","url":"https://api.github.com/repos/PAHFIT/pahfit/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T01:17:17Z","updated_at":"2018-10-24T15:02:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We could use astropy.units to specify the units of the spectra.  Then we could ensure they are in the units we expect.  It may even be transparent through the use of the astropy.models as long as we setup things correctly.  Worth thinking about."},"comment":{"url":"https://api.github.com/repos/PAHFIT/pahfit/issues/comments/432695970","html_url":"https://github.com/PAHFIT/pahfit/issues/28#issuecomment-432695970","issue_url":"https://api.github.com/repos/PAHFIT/pahfit/issues/28","id":432695970,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY5NTk3MA==","user":{"login":"karllark","id":1554536,"node_id":"MDQ6VXNlcjE1NTQ1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554536?v=4","gravatar_id":"","url":"https://api.github.com/users/karllark","html_url":"https://github.com/karllark","followers_url":"https://api.github.com/users/karllark/followers","following_url":"https://api.github.com/users/karllark/following{/other_user}","gists_url":"https://api.github.com/users/karllark/gists{/gist_id}","starred_url":"https://api.github.com/users/karllark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karllark/subscriptions","organizations_url":"https://api.github.com/users/karllark/orgs","repos_url":"https://api.github.com/users/karllark/repos","events_url":"https://api.github.com/users/karllark/events{/privacy}","received_events_url":"https://api.github.com/users/karllark/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T15:02:06Z","updated_at":"2018-10-24T15:02:06Z","author_association":"CONTRIBUTOR","body":"Yes, astropy.units can handle a wide range of units.  Basically, as long as the user specifies the wavelength and spectral units, we can use astropy.units to convert our preferred units.  And convert back to the user specified units for output.  And we could also have default units if they are not specified (probably with a warning stating what defaults are  being assumed)."}}
{"actor":{"display_login":"karllark"}}