{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/205230177","pull_request_review_id":140459649,"id":205230177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTIzMDE3Nw==","diff_hunk":"@@ -20,29 +20,28 @@ package main\n \n import (\n \t\"flag\"\n-\t\"os\"\n-\t\"os/signal\"\n-\t\"syscall\"\n-\t\"time\"\n-\n+\t\"fmt\"\n \t\"github.com/golang/glog\"\n-\n \tapiv1 \"k8s.io/api/core/v1\"\n \tapiextensionsclient \"k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset\"\n \t\"k8s.io/apimachinery/pkg/util/clock\"\n \tclientset \"k8s.io/client-go/kubernetes\"\n \t_ \"k8s.io/client-go/plugin/pkg/client/auth/gcp\"\n \t\"k8s.io/client-go/rest\"\n \t\"k8s.io/client-go/tools/clientcmd\"\n-\n \tcrdclientset \"k8s.io/spark-on-k8s-operator/pkg/client/clientset/versioned\"\n \tcrdinformers \"k8s.io/spark-on-k8s-operator/pkg/client/informers/externalversions\"\n \t\"k8s.io/spark-on-k8s-operator/pkg/controller/scheduledsparkapplication\"\n \t\"k8s.io/spark-on-k8s-operator/pkg/controller/sparkapplication\"\n \t\"k8s.io/spark-on-k8s-operator/pkg/crd\"\n \tssacrd \"k8s.io/spark-on-k8s-operator/pkg/crd/scheduledsparkapplication\"\n \tsacrd \"k8s.io/spark-on-k8s-operator/pkg/crd/sparkapplication\"\n+\t\"k8s.io/spark-on-k8s-operator/pkg/util\"\n \t\"k8s.io/spark-on-k8s-operator/pkg/webhook\"\n+\t\"os\"","path":"main.go","position":29,"original_position":29,"commit_id":"f12028a1b738d7c7efe575a655eb4d92dd0872e4","original_commit_id":"f12028a1b738d7c7efe575a655eb4d92dd0872e4","user":{"login":"liyinan926","id":3709137,"node_id":"MDQ6VXNlcjM3MDkxMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3709137?v=4","gravatar_id":"","url":"https://api.github.com/users/liyinan926","html_url":"https://github.com/liyinan926","followers_url":"https://api.github.com/users/liyinan926/followers","following_url":"https://api.github.com/users/liyinan926/following{/other_user}","gists_url":"https://api.github.com/users/liyinan926/gists{/gist_id}","starred_url":"https://api.github.com/users/liyinan926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyinan926/subscriptions","organizations_url":"https://api.github.com/users/liyinan926/orgs","repos_url":"https://api.github.com/users/liyinan926/repos","events_url":"https://api.github.com/users/liyinan926/events{/privacy}","received_events_url":"https://api.github.com/users/liyinan926/received_events","type":"User","site_admin":false},"body":"Built-ion packages should come at the top.","created_at":"2018-07-25T19:12:40Z","updated_at":"2018-07-25T19:38:14Z","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227#discussion_r205230177","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments/205230177"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227#discussion_r205230177"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227","id":203336978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzM2OTc4","html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227","diff_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227.diff","patch_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227","number":227,"state":"open","locked":false,"title":"SparkOperator: Prometheus Metrics Integration","user":{"login":"akhurana001","id":34587798,"node_id":"MDQ6VXNlcjM0NTg3Nzk4","avatar_url":"https://avatars0.githubusercontent.com/u/34587798?v=4","gravatar_id":"","url":"https://api.github.com/users/akhurana001","html_url":"https://github.com/akhurana001","followers_url":"https://api.github.com/users/akhurana001/followers","following_url":"https://api.github.com/users/akhurana001/following{/other_user}","gists_url":"https://api.github.com/users/akhurana001/gists{/gist_id}","starred_url":"https://api.github.com/users/akhurana001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhurana001/subscriptions","organizations_url":"https://api.github.com/users/akhurana001/orgs","repos_url":"https://api.github.com/users/akhurana001/repos","events_url":"https://api.github.com/users/akhurana001/events{/privacy}","received_events_url":"https://api.github.com/users/akhurana001/received_events","type":"User","site_admin":false},"body":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/67","created_at":"2018-07-23T20:39:36Z","updated_at":"2018-07-25T19:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"465501cea4364b1a48fb55deea3bd80a5d13b6d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/f12028a1b738d7c7efe575a655eb4d92dd0872e4","head":{"label":"lyft:metrics","ref":"metrics","sha":"f12028a1b738d7c7efe575a655eb4d92dd0872e4","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":131327922,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMjc5MjI=","name":"spark-on-k8s-operator","full_name":"lyft/spark-on-k8s-operator","owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/spark-on-k8s-operator","description":"Fork of open-source project to allow launching containerized Spark on Kubernetes","fork":true,"url":"https://api.github.com/repos/lyft/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/spark-on-k8s-operator/deployments","created_at":"2018-04-27T17:48:01Z","updated_at":"2018-07-19T22:10:39Z","pushed_at":"2018-07-23T20:36:01Z","git_url":"git://github.com/lyft/spark-on-k8s-operator.git","ssh_url":"git@github.com:lyft/spark-on-k8s-operator.git","clone_url":"https://github.com/lyft/spark-on-k8s-operator.git","svn_url":"https://github.com/lyft/spark-on-k8s-operator","homepage":"","size":730,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"7e878578ad722b474a59cc66e9ea867beef44da1","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":116165188,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjUxODg=","name":"spark-on-k8s-operator","full_name":"GoogleCloudPlatform/spark-on-k8s-operator","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","description":"Kubernetes CRD operator for specifying and running Apache Spark applications idiomatically on Kubernetes. ","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/deployments","created_at":"2018-01-03T17:43:16Z","updated_at":"2018-07-25T04:14:16Z","pushed_at":"2018-07-23T21:27:24Z","git_url":"git://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","ssh_url":"git@github.com:GoogleCloudPlatform/spark-on-k8s-operator.git","clone_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator.git","svn_url":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator","homepage":"","size":693,"stargazers_count":144,"watchers_count":144,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":30,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227"},"html":{"href":"https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/227"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/spark-on-k8s-operator/statuses/f12028a1b738d7c7efe575a655eb4d92dd0872e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liyinan926"}}