{"action":"created","comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/215040100","pull_request_review_id":152220155,"id":215040100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA0MDEwMA==","diff_hunk":"@@ -0,0 +1,119 @@\n+#!/usr/bin/env python\n+#\n+# Public Domain 2014-2018 MongoDB, Inc.\n+# Public Domain 2008-2014 WiredTiger, Inc.\n+#\n+# This is free and unencumbered software released into the public domain.\n+#\n+# Anyone is free to copy, modify, publish, use, compile, sell, or\n+# distribute this software, either in source code form or as a compiled\n+# binary, for any purpose, commercial or non-commercial, and by any\n+# means.\n+#\n+# In jurisdictions that recognize copyright laws, the author or authors\n+# of this software dedicate any and all copyright interest in the\n+# software to the public domain. We make this dedication for the benefit\n+# of the public at large and to the detriment of our heirs and\n+# successors. We intend this dedication to be an overt act of\n+# relinquishment in perpetuity of all present and future rights to this\n+# software under copyright law.\n+#\n+# THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+# IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n+# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR\n+# OTHER DEALINGS IN THE SOFTWARE.\n+#\n+# test_backup09.py\n+#   Verify opening a backup cursor forces a log file switch.\n+#\n+\n+import os, shutil\n+import wiredtiger, wttest\n+from wtscenario import make_scenarios\n+\n+class test_backup09(wttest.WiredTigerTestCase):\n+    conn_config = 'config_base=false,create,log=(enabled)'\n+    uri = 'table:coll1'\n+    dir = 'backup.dir'\n+\n+    types = [\n+        ('checkpoint', {'checkpoint': True}),\n+        ('no_checkpoint', {'checkpoint': False}),\n+    ]\n+    scenarios = make_scenarios(types)\n+\n+    def data_and_start_backup(self):\n+        self.session.create(self.uri, 'key_format=i,value_format=i')\n+\n+        cursor = self.session.open_cursor(self.uri)\n+        doc_id = 0\n+\n+        for i in range(10):\n+            doc_id += 1\n+            cursor[doc_id] = doc_id\n+\n+        if self.checkpoint:\n+            self.session.checkpoint()\n+\n+        for i in range(10):\n+            doc_id += 1\n+            cursor[doc_id] = doc_id\n+\n+        last_doc_in_backup = doc_id\n+        self.assertEqual(1, len(filter(lambda x: x.startswith('WiredTigerLog.'),\n+                                        os.listdir('.'))))\n+        backup_cursor = self.session.open_cursor('backup:')\n+        # Opening a backup cursor will immediately force a new log file.","path":"test/suite/test_backup09.py","position":69,"original_position":69,"commit_id":"8b423cbcf1b317bf617ff54f787e1d7f3b544bd6","original_commit_id":"8b423cbcf1b317bf617ff54f787e1d7f3b544bd6","user":{"login":"dgottlieb","id":71458,"node_id":"MDQ6VXNlcjcxNDU4","avatar_url":"https://avatars0.githubusercontent.com/u/71458?v=4","gravatar_id":"","url":"https://api.github.com/users/dgottlieb","html_url":"https://github.com/dgottlieb","followers_url":"https://api.github.com/users/dgottlieb/followers","following_url":"https://api.github.com/users/dgottlieb/following{/other_user}","gists_url":"https://api.github.com/users/dgottlieb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgottlieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgottlieb/subscriptions","organizations_url":"https://api.github.com/users/dgottlieb/orgs","repos_url":"https://api.github.com/users/dgottlieb/repos","events_url":"https://api.github.com/users/dgottlieb/events{/privacy}","received_events_url":"https://api.github.com/users/dgottlieb/received_events","type":"User","site_admin":false},"body":"FWIW, removing the line that forces the log write fixed some scenarios in the txn test (but not all).","created_at":"2018-09-04T19:33:25Z","updated_at":"2018-09-04T19:33:26Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4265#discussion_r215040100","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/215040100"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4265#discussion_r215040100"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265"}},"in_reply_to_id":214888560},"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265","id":212173581,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTczNTgx","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4265","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/4265.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/4265.patch","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4265","number":4265,"state":"open","locked":false,"title":"WT-4177 Force a log switch when opening a backup cursor.","user":{"login":"dgottlieb","id":71458,"node_id":"MDQ6VXNlcjcxNDU4","avatar_url":"https://avatars0.githubusercontent.com/u/71458?v=4","gravatar_id":"","url":"https://api.github.com/users/dgottlieb","html_url":"https://github.com/dgottlieb","followers_url":"https://api.github.com/users/dgottlieb/followers","following_url":"https://api.github.com/users/dgottlieb/following{/other_user}","gists_url":"https://api.github.com/users/dgottlieb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgottlieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgottlieb/subscriptions","organizations_url":"https://api.github.com/users/dgottlieb/orgs","repos_url":"https://api.github.com/users/dgottlieb/repos","events_url":"https://api.github.com/users/dgottlieb/events{/privacy}","received_events_url":"https://api.github.com/users/dgottlieb/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-30T18:40:19Z","updated_at":"2018-09-04T19:33:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"473d1d5a65737202feb2f473071108457033c3dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265/commits","review_comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265/comments","review_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4265/comments","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/8b423cbcf1b317bf617ff54f787e1d7f3b544bd6","head":{"label":"wiredtiger:wt-4177-backup-cursor-forces-log-switch","ref":"wt-4177-backup-cursor-forces-log-switch","sha":"8b423cbcf1b317bf617ff54f787e1d7f3b544bd6","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-09-04T13:30:31Z","pushed_at":"2018-09-04T19:12:02Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83405,"stargazers_count":1238,"watchers_count":1238,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":211,"open_issues":9,"watchers":1238,"default_branch":"master"}},"base":{"label":"wiredtiger:develop","ref":"develop","sha":"09cf335eb8d1d690d2bafa83a91a4f985fa9df75","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-09-04T13:30:31Z","pushed_at":"2018-09-04T19:12:02Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83405,"stargazers_count":1238,"watchers_count":1238,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":211,"open_issues":9,"watchers":1238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4265"},"issue":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4265"},"comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4265/comments"},"review_comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265/comments"},"review_comment":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4265/commits"},"statuses":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/8b423cbcf1b317bf617ff54f787e1d7f3b544bd6"}},"author_association":"NONE"}}
{"actor":{"display_login":"dgottlieb"}}