{"action":"created","issue":{"url":"https://api.github.com/repos/mautic/mautic/issues/5880","repository_url":"https://api.github.com/repos/mautic/mautic","labels_url":"https://api.github.com/repos/mautic/mautic/issues/5880/labels{/name}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/5880/comments","events_url":"https://api.github.com/repos/mautic/mautic/issues/5880/events","html_url":"https://github.com/mautic/mautic/pull/5880","id":310048141,"number":5880,"title":"Php extensions","user":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars2.githubusercontent.com/u/1235442?v=4","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"labels":[{"id":154414515,"url":"https://api.github.com/repos/mautic/mautic/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":197691504,"url":"https://api.github.com/repos/mautic/mautic/labels/Ready%20To%20Test","name":"Ready To Test","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mautic/mautic/milestones/44","html_url":"https://github.com/mautic/mautic/milestone/44","labels_url":"https://api.github.com/repos/mautic/mautic/milestones/44/labels","id":3209824,"number":44,"title":"2.14.0","description":null,"creator":{"login":"dbhurley","id":5251425,"avatar_url":"https://avatars1.githubusercontent.com/u/5251425?v=4","gravatar_id":"","url":"https://api.github.com/users/dbhurley","html_url":"https://github.com/dbhurley","followers_url":"https://api.github.com/users/dbhurley/followers","following_url":"https://api.github.com/users/dbhurley/following{/other_user}","gists_url":"https://api.github.com/users/dbhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbhurley/subscriptions","organizations_url":"https://api.github.com/users/dbhurley/orgs","repos_url":"https://api.github.com/users/dbhurley/repos","events_url":"https://api.github.com/users/dbhurley/events{/privacy}","received_events_url":"https://api.github.com/users/dbhurley/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":2,"state":"open","created_at":"2018-03-22T16:56:09Z","updated_at":"2018-04-24T13:17:22Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-03-30T11:53:36Z","updated_at":"2018-04-24T14:12:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/5880","html_url":"https://github.com/mautic/mautic/pull/5880","diff_url":"https://github.com/mautic/mautic/pull/5880.diff","patch_url":"https://github.com/mautic/mautic/pull/5880.patch"},"body":"[//]: # ( Please answer the following questions: )\r\n\r\n| Q  | A\r\n| --- | ---\r\n| Bug fix? | Kinda\r\n| New feature? | N\r\n| Automated tests included? | /\r\n| Related user documentation PR URL | readme.md\r\n| Related developer documentation PR URL | composer.json\r\n| Issues addressed (#s or URLs) | improves https://github.com/mautic/mautic/issues/5145 and https://github.com/mautic/mautic/issues/4390\r\n| BC breaks? | Hope not\r\n| Deprecations? | N\r\n\r\n[//]: # ( Note that all new features should have a related user and/or developer documentation PR in their respective repositories. )\r\n\r\n[//]: # ( Required: )\r\n#### Description:\r\nI've read about https://github.com/dg/php-extensions-finder which finds all special functions in the repository including all dependencies and tried it on the Mautic repository. This PR is the result. \r\n\r\nFeel free to run it too. It's simple and the output gives all references to those functions so one can guess for what they are needed. That's how I divided them into required, required-dev and in the readme into recommended. Recommended are those that are needed for one specific feature. Like MS Excel export for example.\r\n\r\n[//]: # ( As applicable: )\r\n#### Steps to reproduce the bug:\r\n1. Disable for example `ext-json` from your server.\r\n2. Restart server.\r\n3. Run `composer install` and no error will be thrown.\r\n4. Your Mautic instance will be broken because json_* functions aren't defined.\r\n\r\n#### Steps to test this PR:\r\n1. Apply this PR\r\n2. Run `composer install` again. An error message will tell you that you are missing the required `ext-json`.\r\n"},"comment":{"url":"https://api.github.com/repos/mautic/mautic/issues/comments/383946516","html_url":"https://github.com/mautic/mautic/pull/5880#issuecomment-383946516","issue_url":"https://api.github.com/repos/mautic/mautic/issues/5880","id":383946516,"user":{"login":"Maxell92","id":1649279,"avatar_url":"https://avatars3.githubusercontent.com/u/1649279?v=4","gravatar_id":"","url":"https://api.github.com/users/Maxell92","html_url":"https://github.com/Maxell92","followers_url":"https://api.github.com/users/Maxell92/followers","following_url":"https://api.github.com/users/Maxell92/following{/other_user}","gists_url":"https://api.github.com/users/Maxell92/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxell92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxell92/subscriptions","organizations_url":"https://api.github.com/users/Maxell92/orgs","repos_url":"https://api.github.com/users/Maxell92/repos","events_url":"https://api.github.com/users/Maxell92/events{/privacy}","received_events_url":"https://api.github.com/users/Maxell92/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T14:12:31Z","updated_at":"2018-04-24T14:12:31Z","author_association":"CONTRIBUTOR","body":"I tried this PR and have several issues:\r\n1) You need to require packages correctly (`composer require`), otherwise there is an error:\r\n`Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.`\r\nThis means that no error appears event if I turn off any extension because `composer install` uses `lock` file and not `json`.\r\n2) I have several issues now:\r\n`The requested PHP extension ext-zend opcache * is missing from your system`\r\n`The requested PHP extension ext-apcu * is missing from your system.`\r\n`The requested PHP extension ext-igbinary * is missing from your system.`\r\n`The requested PHP extension ext-xdebug * is missing from your system.`\r\n\r\nI am not sure if this is really my mistake. I can easily install these extensions, but I work with Mautic for a few months and no issue appeared. So maybe this is a BC? Are we sure Mautic cannot run correctly without these extensions?\r\nI am pretty sure that I do not need `Xdebug` extension at least :)"}}
{"actor":{"display_login":"Maxell92"}}