{"action":"created","issue":{"url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1773","repository_url":"https://api.github.com/repos/xtermjs/xterm.js","labels_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1773/labels{/name}","comments_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1773/comments","events_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1773/events","html_url":"https://github.com/xtermjs/xterm.js/issues/1773","id":375921322,"node_id":"MDU6SXNzdWUzNzU5MjEzMjI=","number":1773,"title":"drawBoldTextInBrightColors is not taken into account with DOM renderer","user":{"login":"astefanutti","id":366207,"node_id":"MDQ6VXNlcjM2NjIwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/366207?v=4","gravatar_id":"","url":"https://api.github.com/users/astefanutti","html_url":"https://github.com/astefanutti","followers_url":"https://api.github.com/users/astefanutti/followers","following_url":"https://api.github.com/users/astefanutti/following{/other_user}","gists_url":"https://api.github.com/users/astefanutti/gists{/gist_id}","starred_url":"https://api.github.com/users/astefanutti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefanutti/subscriptions","organizations_url":"https://api.github.com/users/astefanutti/orgs","repos_url":"https://api.github.com/users/astefanutti/repos","events_url":"https://api.github.com/users/astefanutti/events{/privacy}","received_events_url":"https://api.github.com/users/astefanutti/received_events","type":"User","site_admin":false},"labels":[{"id":509611814,"node_id":"MDU6TGFiZWw1MDk2MTE4MTQ=","url":"https://api.github.com/repos/xtermjs/xterm.js/labels/area/renderer","name":"area/renderer","color":"1d76db","default":false},{"id":717305401,"node_id":"MDU6TGFiZWw3MTczMDU0MDE=","url":"https://api.github.com/repos/xtermjs/xterm.js/labels/good%20first%20issue","name":"good first issue","color":"0e8a16","default":true},{"id":559726399,"node_id":"MDU6TGFiZWw1NTk3MjYzOTk=","url":"https://api.github.com/repos/xtermjs/xterm.js/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true},{"id":87998136,"node_id":"MDU6TGFiZWw4Nzk5ODEzNg==","url":"https://api.github.com/repos/xtermjs/xterm.js/labels/type/bug","name":"type/bug","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-31T11:40:31Z","updated_at":"2018-11-01T21:08:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Details\r\n- Browser and browser version: Chrome 70\r\n- OS version: Mac OS X\r\n- xterm.js version: 3.8.0\r\n\r\n### Steps to reproduce\r\n\r\n1. Set `drawBoldTextInBrightColors` to `false` and `rendererType` to `dom`\r\n2. Bold characters are still rendered brighter\r\n\r\nIt works as expected with the canvas renderer."},"comment":{"url":"https://api.github.com/repos/xtermjs/xterm.js/issues/comments/435187828","html_url":"https://github.com/xtermjs/xterm.js/issues/1773#issuecomment-435187828","issue_url":"https://api.github.com/repos/xtermjs/xterm.js/issues/1773","id":435187828,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTE4NzgyOA==","user":{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T21:08:19Z","updated_at":"2018-11-01T21:08:19Z","author_association":"MEMBER","body":"Ah, on Windows you can do it by installing WSL (if not already), running that shell by running `bash` then running these:\r\n\r\n```\r\necho -e '\\x1b[31mRed normal\\x1b[0m'\r\necho -e '\\x1b[31;1mRed bold\\x1b[0m'\r\n```\r\n\r\nTo print the bright colors:\r\n\r\n```\r\necho -e '\\x1b[91mBright red normal\\x1b[0m'\r\necho -e '\\x1b[91;1mBright red bold\\x1b[0m'\r\n```"}}
{"actor":{"display_login":"Tyriar"}}