{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10725","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10725/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10725/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10725/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10725","id":371978420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzAzNDc2","number":10725,"title":"net: tls: Do not assume PSK id is NULL terminated","user":{"login":"rlubos","id":22167799,"node_id":"MDQ6VXNlcjIyMTY3Nzk5","avatar_url":"https://avatars0.githubusercontent.com/u/22167799?v=4","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"labels":[{"id":700751655,"node_id":"MDU6TGFiZWw3MDA3NTE2NTU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Networking","name":"area: Networking","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-19T14:20:02Z","updated_at":"2018-10-19T14:49:52Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10725","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10725","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10725.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10725.patch"},"body":"Current TLS socket implementation assumed that PSK ID stored in manager is NULL terminated. It's actually better to store only the string content, as the string length is stored as well. This approach is less confusing, when a user is not operating on C strings but on a non-NULL terminated byte array.\r\n\r\nNo samples are affected with the change, as there are no samples using PSK atuhentication yet (it's added in reworked MQTT sample pending on PR).\r\n\r\nSigned-off-by: Robert Lubos <robert.lubos@nordicsemi.no>"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/431389406","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10725#issuecomment-431389406","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10725","id":431389406,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTM4OTQwNg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T14:49:52Z","updated_at":"2018-10-19T14:49:52Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=h1) Report\n> Merging [#10725](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=desc) into [master](https://codecov.io/gh/zephyrproject-rtos/zephyr/commit/02e217df506bfb2d096168eb4dbaec8126f64197?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725/graphs/tree.svg?width=650&token=ftaqgO8OOj&height=150&src=pr)](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master   #10725   +/-   ##\n=======================================\n  Coverage   53.26%   53.26%           \n=======================================\n  Files         215      215           \n  Lines       25829    25829           \n  Branches     5697     5697           \n=======================================\n  Hits        13758    13758           \n  Misses       9754     9754           \n  Partials     2317     2317\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=footer). Last update [02e217d...92ab8b0](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}