{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/177727154","pull_request_review_id":107650266,"id":177727154,"diff_hunk":"@@ -263,19 +272,22 @@ def parse(input):\n \n \n class MavenDownloader:\n-    def __init__(self, module, base=\"http://repo1.maven.org/maven2\"):\n+    def __init__(self, module, base=\"http://repo1.maven.org/maven2\", local=False):\n         self.module = module\n         if base.endswith(\"/\"):\n             base = base.rstrip(\"/\")\n         self.base = base\n+        self.local = local","path":"lib/ansible/modules/packaging/language/maven_artifact.py","position":40,"original_position":32,"commit_id":"768e743aa768ca2f928a03106e6b487c4f4dae49","original_commit_id":"4d5d5badf46862402909946c32cea63577d28c1b","user":{"login":"gmaes","id":1036717,"avatar_url":"https://avatars2.githubusercontent.com/u/1036717?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaes","html_url":"https://github.com/gmaes","followers_url":"https://api.github.com/users/gmaes/followers","following_url":"https://api.github.com/users/gmaes/following{/other_user}","gists_url":"https://api.github.com/users/gmaes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaes/subscriptions","organizations_url":"https://api.github.com/users/gmaes/orgs","repos_url":"https://api.github.com/users/gmaes/repos","events_url":"https://api.github.com/users/gmaes/events{/privacy}","received_events_url":"https://api.github.com/users/gmaes/received_events","type":"User","site_admin":false},"body":"Ok for next time","created_at":"2018-03-28T12:12:24Z","updated_at":"2018-03-28T12:12:24Z","html_url":"https://github.com/ansible/ansible/pull/36159#discussion_r177727154","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/36159","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/177727154"},"html":{"href":"https://github.com/ansible/ansible/pull/36159#discussion_r177727154"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36159"}},"in_reply_to_id":177678597},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36159","id":169077509,"html_url":"https://github.com/ansible/ansible/pull/36159","diff_url":"https://github.com/ansible/ansible/pull/36159.diff","patch_url":"https://github.com/ansible/ansible/pull/36159.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36159","number":36159,"state":"open","locked":false,"title":"#29334 handle maven local repo","user":{"login":"gmaes","id":1036717,"avatar_url":"https://avatars2.githubusercontent.com/u/1036717?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaes","html_url":"https://github.com/gmaes","followers_url":"https://api.github.com/users/gmaes/followers","following_url":"https://api.github.com/users/gmaes/following{/other_user}","gists_url":"https://api.github.com/users/gmaes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaes/subscriptions","organizations_url":"https://api.github.com/users/gmaes/orgs","repos_url":"https://api.github.com/users/gmaes/repos","events_url":"https://api.github.com/users/gmaes/events{/privacy}","received_events_url":"https://api.github.com/users/gmaes/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\n\r\nFixes #29334 and #34309 (duplicate).\r\nAllow to download artifacts from a local maven repository.\r\n\r\n<!---\r\nIf you are fixing an existing issue, please include \"Fixes #nnn\" in your\r\ncommit message and your description; but you should still explain what\r\nthe change does.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module, plugin, module or task -->\r\nmodule: **maven_artifact**\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.4.2.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = [u'/home/gmaes/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/lib/python2.7/dist-packages/ansible\r\n  executable location = /usr/bin/ansible\r\n  python version = 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!---\r\nInclude additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful.\r\n  -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\nDistributor ID:\tUbuntu\r\nDescription:\tUbuntu 17.10\r\nRelease:\t17.10\r\nCodename:\tartful\r\n```\r\n","created_at":"2018-02-14T10:53:15Z","updated_at":"2018-03-28T12:12:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a542553b9b53df82de54af34f203132d3445037","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":785271699,"url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":468273802,"url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/36159/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/36159/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36159/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/768e743aa768ca2f928a03106e6b487c4f4dae49","head":{"label":"gmaes:maven_artifact-local-repo","ref":"maven_artifact-local-repo","sha":"768e743aa768ca2f928a03106e6b487c4f4dae49","user":{"login":"gmaes","id":1036717,"avatar_url":"https://avatars2.githubusercontent.com/u/1036717?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaes","html_url":"https://github.com/gmaes","followers_url":"https://api.github.com/users/gmaes/followers","following_url":"https://api.github.com/users/gmaes/following{/other_user}","gists_url":"https://api.github.com/users/gmaes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaes/subscriptions","organizations_url":"https://api.github.com/users/gmaes/orgs","repos_url":"https://api.github.com/users/gmaes/repos","events_url":"https://api.github.com/users/gmaes/events{/privacy}","received_events_url":"https://api.github.com/users/gmaes/received_events","type":"User","site_admin":false},"repo":{"id":120881460,"name":"ansible","full_name":"gmaes/ansible","owner":{"login":"gmaes","id":1036717,"avatar_url":"https://avatars2.githubusercontent.com/u/1036717?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaes","html_url":"https://github.com/gmaes","followers_url":"https://api.github.com/users/gmaes/followers","following_url":"https://api.github.com/users/gmaes/following{/other_user}","gists_url":"https://api.github.com/users/gmaes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaes/subscriptions","organizations_url":"https://api.github.com/users/gmaes/orgs","repos_url":"https://api.github.com/users/gmaes/repos","events_url":"https://api.github.com/users/gmaes/events{/privacy}","received_events_url":"https://api.github.com/users/gmaes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmaes/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/gmaes/ansible","forks_url":"https://api.github.com/repos/gmaes/ansible/forks","keys_url":"https://api.github.com/repos/gmaes/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmaes/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmaes/ansible/teams","hooks_url":"https://api.github.com/repos/gmaes/ansible/hooks","issue_events_url":"https://api.github.com/repos/gmaes/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/gmaes/ansible/events","assignees_url":"https://api.github.com/repos/gmaes/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/gmaes/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/gmaes/ansible/tags","blobs_url":"https://api.github.com/repos/gmaes/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmaes/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmaes/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmaes/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmaes/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/gmaes/ansible/languages","stargazers_url":"https://api.github.com/repos/gmaes/ansible/stargazers","contributors_url":"https://api.github.com/repos/gmaes/ansible/contributors","subscribers_url":"https://api.github.com/repos/gmaes/ansible/subscribers","subscription_url":"https://api.github.com/repos/gmaes/ansible/subscription","commits_url":"https://api.github.com/repos/gmaes/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmaes/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmaes/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmaes/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmaes/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/gmaes/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmaes/ansible/merges","archive_url":"https://api.github.com/repos/gmaes/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmaes/ansible/downloads","issues_url":"https://api.github.com/repos/gmaes/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/gmaes/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/gmaes/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/gmaes/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmaes/ansible/labels{/name}","releases_url":"https://api.github.com/repos/gmaes/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/gmaes/ansible/deployments","created_at":"2018-02-09T08:52:32Z","updated_at":"2018-02-09T08:53:01Z","pushed_at":"2018-03-28T12:07:52Z","git_url":"git://github.com/gmaes/ansible.git","ssh_url":"git@github.com:gmaes/ansible.git","clone_url":"https://github.com/gmaes/ansible.git","svn_url":"https://github.com/gmaes/ansible","homepage":"https://www.ansible.com/","size":113044,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"447b342662b966b1b4885fddca950ec341670c69","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-03-28T12:12:18Z","pushed_at":"2018-03-28T12:07:59Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":121896,"stargazers_count":29237,"watchers_count":29237,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10637,"mirror_url":null,"archived":false,"open_issues_count":4938,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10637,"open_issues":4938,"watchers":29237,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36159"},"html":{"href":"https://github.com/ansible/ansible/pull/36159"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/36159"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/36159/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36159/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36159/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/768e743aa768ca2f928a03106e6b487c4f4dae49"}},"author_association":"NONE"}}
{"actor":{"display_login":"gmaes"}}