{"action":"created","issue":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/5892","repository_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j","labels_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/5892/labels{/name}","comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/5892/comments","events_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/5892/events","html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/5892","id":340637680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDAxMDk4","number":5892,"title":"Nd4j/cooindex ravel unravel","user":{"login":"emillynge","id":7023052,"node_id":"MDQ6VXNlcjcwMjMwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7023052?v=4","gravatar_id":"","url":"https://api.github.com/users/emillynge","html_url":"https://github.com/emillynge","followers_url":"https://api.github.com/users/emillynge/followers","following_url":"https://api.github.com/users/emillynge/following{/other_user}","gists_url":"https://api.github.com/users/emillynge/gists{/gist_id}","starred_url":"https://api.github.com/users/emillynge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emillynge/subscriptions","organizations_url":"https://api.github.com/users/emillynge/orgs","repos_url":"https://api.github.com/users/emillynge/repos","events_url":"https://api.github.com/users/emillynge/events{/privacy}","received_events_url":"https://api.github.com/users/emillynge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-12T13:27:41Z","updated_at":"2018-08-03T03:05:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/5892","html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/5892","diff_url":"https://github.com/deeplearning4j/deeplearning4j/pull/5892.diff","patch_url":"https://github.com/deeplearning4j/deeplearning4j/pull/5892.patch"},"body":"Dear Maintainers, Please accept this PR that implements ravel/unravel of COO indexes, copying the behaviour of `numpy.ravel_multi_index` and `numpy.unravel_index`.\r\n\r\nNumpy docs for  [ravel_multi_index](https://docs.scipy.org/doc/numpy/reference/generated/numpy.ravel_multi_index.html)\r\nand  [unravel_index](https://docs.scipy.org/doc/numpy/reference/generated/numpy.unravel_index.html)\r\n\r\nCurrently 2 TODOs are outstanding.\r\n\r\n1. Take into account SparseShapeInformation\r\n2. Take into account 'C' / 'F' order.  \r\n\r\nbut these are not critical\r\n\r\n(2) is more or less solved already since ShapeInfoBuffer more less defines this property anyways.\r\n(1) should maybe be taken into account, but doing that is not straight forward, since this essentially requires throwing out any indexes not included in the view. Throwing out means that we cannot know for certain what the length of the raveled indices should be.\r\n"},"comment":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/comments/410130932","html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/5892#issuecomment-410130932","issue_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/5892","id":410130932,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDEzMDkzMg==","user":{"login":"raver119","id":12250879,"node_id":"MDQ6VXNlcjEyMjUwODc5","avatar_url":"https://avatars2.githubusercontent.com/u/12250879?v=4","gravatar_id":"","url":"https://api.github.com/users/raver119","html_url":"https://github.com/raver119","followers_url":"https://api.github.com/users/raver119/followers","following_url":"https://api.github.com/users/raver119/following{/other_user}","gists_url":"https://api.github.com/users/raver119/gists{/gist_id}","starred_url":"https://api.github.com/users/raver119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raver119/subscriptions","organizations_url":"https://api.github.com/users/raver119/orgs","repos_url":"https://api.github.com/users/raver119/repos","events_url":"https://api.github.com/users/raver119/events{/privacy}","received_events_url":"https://api.github.com/users/raver119/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T03:05:50Z","updated_at":"2018-08-03T03:05:50Z","author_association":"CONTRIBUTOR","body":"There's lots of failures i don't see on current master 😞 "}}
{"actor":{"display_login":"raver119"}}