{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27115","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27115/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27115/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27115/events","html_url":"https://github.com/cockroachdb/cockroach/pull/27115","id":337738395,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODQ0NTE5","number":27115,"title":"build: relieve the Makefile of release configurations","user":{"login":"benesch","id":882976,"node_id":"MDQ6VXNlcjg4Mjk3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/882976?v=4","gravatar_id":"","url":"https://api.github.com/users/benesch","html_url":"https://github.com/benesch","followers_url":"https://api.github.com/users/benesch/followers","following_url":"https://api.github.com/users/benesch/following{/other_user}","gists_url":"https://api.github.com/users/benesch/gists{/gist_id}","starred_url":"https://api.github.com/users/benesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benesch/subscriptions","organizations_url":"https://api.github.com/users/benesch/orgs","repos_url":"https://api.github.com/users/benesch/repos","events_url":"https://api.github.com/users/benesch/events{/privacy}","received_events_url":"https://api.github.com/users/benesch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-03T04:06:01Z","updated_at":"2018-07-03T05:13:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/27115","html_url":"https://github.com/cockroachdb/cockroach/pull/27115","diff_url":"https://github.com/cockroachdb/cockroach/pull/27115.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/27115.patch"},"body":"The Makefile previously hard-coded some \"release configurations\", that is,\r\ncollections of compiler paths and flags for building releases that targeted\r\nvarious platforms with various features enabled, like MemorySanitizer (MSan)\r\nand static linking.\r\n\r\nThese release configurations do not belong in Make. The logic was exceptionally\r\nhard to follow, for one. The release configurations also hardcoded paths to\r\ncompiler toolchains in the builder image; they were entirely unsable unless\r\nrunning Make within the builder image.\r\n\r\nInstead, Make should provide the tools to apply a release configuration. This\r\npatch exposes a set of variables (XCC, XCMAKE_SYSTEM_NAME, etc.) that control\r\ncross-compilation. A new program, mkrelease, is baked into the builder image\r\nand sets these variables appropriately. It is appropriate for mkrelease to\r\nhardcode paths to compiler toolchains as it is *part* of the builder image.\r\n\r\nThis improves readability and provides a nice separation of concerns."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/402015221","html_url":"https://github.com/cockroachdb/cockroach/pull/27115#issuecomment-402015221","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27115","id":402015221,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjAxNTIyMQ==","user":{"login":"tschottdorf","id":5076964,"node_id":"MDQ6VXNlcjUwNzY5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T05:13:03Z","updated_at":"2018-07-03T05:13:03Z","author_association":"MEMBER","body":"LGTM on the approach and the parts that I've looked at LGTM, but someone else should take a look as well.\n\n---\n\nReviewed 9 of 9 files at r1.\nReview status: :shipit: complete! 0 of 0 LGTMs obtained\n\n---\n\n*[build/builder/mkrelease.go, line 1 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/27115#-LGTXEeMErypSqQs16VX:-LGTXEeMErypSqQs16VY:bb6ht2i) ([raw file](https://github.com/cockroachdb/cockroach/blob/eae59d5215fda83a6e82571905be56dc4f16e8c3/build/builder/mkrelease.go#L1)):*\n> ```Go\n> // Copyright 2017 The Cockroach Authors.\n> ```\n\n2018\n\n---\n\n*[build/builder/mkrelease.go, line 144 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/27115#-LGTYYjG-Zr4xfISL_65:-LGTYYjG-Zr4xfISL_66:b-oifqsv) ([raw file](https://github.com/cockroachdb/cockroach/blob/eae59d5215fda83a6e82571905be56dc4f16e8c3/build/builder/mkrelease.go#L144)):*\n> ```Go\n> \t\tout = append(out, shellEscape(e))\n> \t}\n> \tout = append(out, \"make\")\n> ```\n\ns/\"make\"/cmd/\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/cockroachdb/cockroach/27115#-:-LGTYCHk0uMd1wkR8Qt8:bsnlkci)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tschottdorf"}}