{"action":"created","issue":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/304","repository_url":"https://api.github.com/repos/HEP-FCC/FCCSW","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/304/comments","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/304/events","html_url":"https://github.com/HEP-FCC/FCCSW/pull/304","id":308608826,"number":304,"title":"Test Config Improvements","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars1.githubusercontent.com/u/5057884?v=4","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-26T14:58:10Z","updated_at":"2018-03-26T15:02:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/304","html_url":"https://github.com/HEP-FCC/FCCSW/pull/304","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/304.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/304.patch"},"body":"Fixes Issue #287.\r\n\r\nChanges proposed in this pull-request:\r\n\r\n- Remove all mentions of the Gaudi ParticlePropertySvc that isn't used anymore\r\n-  Remove minbiaspool.py, which is expensive to test, doesn't add test coverage and is superseded by the configs in FCChhSimJobs\r\n- Starting to end the practice of constructing tools by name instead of their python variable\r\n```\r\nconfiguredTool = ToolType(\"ToolName\", someParameter=4.)\r\nalgorithm = AlgorithmType(\"AlgorithmName\", theTool=\"ToolType/ToolName\") # This is fine for default constructed tools, but error-prone if you configure the tool in this configuration!\r\nalgorithm = AlgorithmType(\"AlgorithmName\", theTool=configuredTool) # better\r\n```\r\n\r\n\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments/376197778","html_url":"https://github.com/HEP-FCC/FCCSW/pull/304#issuecomment-376197778","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/304","id":376197778,"user":{"login":"phsft-bot","id":25639015,"avatar_url":"https://avatars1.githubusercontent.com/u/25639015?v=4","gravatar_id":"","url":"https://api.github.com/users/phsft-bot","html_url":"https://github.com/phsft-bot","followers_url":"https://api.github.com/users/phsft-bot/followers","following_url":"https://api.github.com/users/phsft-bot/following{/other_user}","gists_url":"https://api.github.com/users/phsft-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/phsft-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsft-bot/subscriptions","organizations_url":"https://api.github.com/users/phsft-bot/orgs","repos_url":"https://api.github.com/users/phsft-bot/repos","events_url":"https://api.github.com/users/phsft-bot/events{/privacy}","received_events_url":"https://api.github.com/users/phsft-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T15:02:31Z","updated_at":"2018-03-26T15:02:31Z","author_association":"NONE","body":"Starting build on `slc6`/`gcc62` \n[How to customize builds](https://github.com/phsft-bot/build-configuration/blob/master/README.md)"}}
{"actor":{"display_login":"phsft-bot"}}