{"action":"created","comment":{"url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/comments/235698044","pull_request_review_id":177622319,"id":235698044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY5ODA0NA==","diff_hunk":"@@ -87,7 +87,13 @@ class Tooltip extends HtmlContent {\n     this.d3TooltipInner.classed('top bottom', false)\n     this.d3TooltipInner.classed(verticalAlign, true)\n \n-    let innerRect = Object.assign({ }, targetRect || d3TargetElement.node().getBoundingClientRect())\n+    const obj = targetRect || d3TargetElement.node().getBoundingClientRect()\n+    let innerRect = {\n+      x: obj.x,\n+      y: obj.y,\n+      width: obj.width,\n+      height: obj.height\n+    }","path":"visualizer/tooltip.js","position":11,"original_position":11,"commit_id":"1e3757ec2344015cd3e0a05b9ca002488bc89422","original_commit_id":"1e3757ec2344015cd3e0a05b9ca002488bc89422","user":{"login":"AlanSl","id":29628323,"node_id":"MDQ6VXNlcjI5NjI4MzIz","avatar_url":"https://avatars0.githubusercontent.com/u/29628323?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanSl","html_url":"https://github.com/AlanSl","followers_url":"https://api.github.com/users/AlanSl/followers","following_url":"https://api.github.com/users/AlanSl/following{/other_user}","gists_url":"https://api.github.com/users/AlanSl/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanSl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanSl/subscriptions","organizations_url":"https://api.github.com/users/AlanSl/orgs","repos_url":"https://api.github.com/users/AlanSl/repos","events_url":"https://api.github.com/users/AlanSl/events{/privacy}","received_events_url":"https://api.github.com/users/AlanSl/received_events","type":"User","site_admin":false},"body":"Both `obj` and `innerRect` don't seem to do anything except hold those four properties for the scope of this function, so we could make it cleaner and clearer with:\r\n\r\n```\r\n   let {\r\n      x,\r\n      y,\r\n      width,\r\n      height\r\n    } = targetRect || d3TargetElement.node().getBoundingClientRect()\r\n```\r\n\r\n...then replace `innerRect.x` with `x`, `innerRect.width` with `width` etc.","created_at":"2018-11-22T11:51:42Z","updated_at":"2018-11-22T11:52:26Z","html_url":"https://github.com/nearform/node-clinic-flame/pull/46#discussion_r235698044","pull_request_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/comments/235698044"},"html":{"href":"https://github.com/nearform/node-clinic-flame/pull/46#discussion_r235698044"},"pull_request":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46","id":232944618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTQ0NjE4","html_url":"https://github.com/nearform/node-clinic-flame/pull/46","diff_url":"https://github.com/nearform/node-clinic-flame/pull/46.diff","patch_url":"https://github.com/nearform/node-clinic-flame/pull/46.patch","issue_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/46","number":46,"state":"open","locked":false,"title":"Fix/tooltip fixes","user":{"login":"cuginoAle","id":1298616,"node_id":"MDQ6VXNlcjEyOTg2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1298616?v=4","gravatar_id":"","url":"https://api.github.com/users/cuginoAle","html_url":"https://github.com/cuginoAle","followers_url":"https://api.github.com/users/cuginoAle/followers","following_url":"https://api.github.com/users/cuginoAle/following{/other_user}","gists_url":"https://api.github.com/users/cuginoAle/gists{/gist_id}","starred_url":"https://api.github.com/users/cuginoAle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuginoAle/subscriptions","organizations_url":"https://api.github.com/users/cuginoAle/orgs","repos_url":"https://api.github.com/users/cuginoAle/repos","events_url":"https://api.github.com/users/cuginoAle/events{/privacy}","received_events_url":"https://api.github.com/users/cuginoAle/received_events","type":"User","site_admin":false},"body":"This PR fixes the [bug noted here](https://github.com/nearform/node-clinic-flame/issues/47)\r\nThe issue was caused by the incorrect use of `Object.assign`, [as explained here](https://stackoverflow.com/questions/42713229/why-are-properties-of-this-object-domrect-inaccessible-to-standard-javascript)\r\n\r\nThis PR also fixes the tooltip positioning issue we had on the `Stack-bar` (mainly when hovering over very large frames, see screenshot) \r\n![screenshot 2018-11-22 at 12 20 11](https://user-images.githubusercontent.com/1298616/48899867-13fe6180-ee51-11e8-9987-9f0d75da3bc2.png)\r\n\r\n","created_at":"2018-11-22T11:21:39Z","updated_at":"2018-11-22T11:52:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e278d35f9f178ddad2870fab3c97a393d21f150","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46/commits","review_comments_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46/comments","review_comment_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/46/comments","statuses_url":"https://api.github.com/repos/nearform/node-clinic-flame/statuses/1e3757ec2344015cd3e0a05b9ca002488bc89422","head":{"label":"nearform:fix/tooltip_fixes","ref":"fix/tooltip_fixes","sha":"1e3757ec2344015cd3e0a05b9ca002488bc89422","user":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"repo":{"id":141301537,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMDE1Mzc=","name":"node-clinic-flame","full_name":"nearform/node-clinic-flame","private":false,"owner":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nearform/node-clinic-flame","description":"Programmable interface to `clinic flame`","fork":false,"url":"https://api.github.com/repos/nearform/node-clinic-flame","forks_url":"https://api.github.com/repos/nearform/node-clinic-flame/forks","keys_url":"https://api.github.com/repos/nearform/node-clinic-flame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearform/node-clinic-flame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearform/node-clinic-flame/teams","hooks_url":"https://api.github.com/repos/nearform/node-clinic-flame/hooks","issue_events_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/events{/number}","events_url":"https://api.github.com/repos/nearform/node-clinic-flame/events","assignees_url":"https://api.github.com/repos/nearform/node-clinic-flame/assignees{/user}","branches_url":"https://api.github.com/repos/nearform/node-clinic-flame/branches{/branch}","tags_url":"https://api.github.com/repos/nearform/node-clinic-flame/tags","blobs_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearform/node-clinic-flame/statuses/{sha}","languages_url":"https://api.github.com/repos/nearform/node-clinic-flame/languages","stargazers_url":"https://api.github.com/repos/nearform/node-clinic-flame/stargazers","contributors_url":"https://api.github.com/repos/nearform/node-clinic-flame/contributors","subscribers_url":"https://api.github.com/repos/nearform/node-clinic-flame/subscribers","subscription_url":"https://api.github.com/repos/nearform/node-clinic-flame/subscription","commits_url":"https://api.github.com/repos/nearform/node-clinic-flame/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearform/node-clinic-flame/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearform/node-clinic-flame/contents/{+path}","compare_url":"https://api.github.com/repos/nearform/node-clinic-flame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearform/node-clinic-flame/merges","archive_url":"https://api.github.com/repos/nearform/node-clinic-flame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearform/node-clinic-flame/downloads","issues_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues{/number}","pulls_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls{/number}","milestones_url":"https://api.github.com/repos/nearform/node-clinic-flame/milestones{/number}","notifications_url":"https://api.github.com/repos/nearform/node-clinic-flame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearform/node-clinic-flame/labels{/name}","releases_url":"https://api.github.com/repos/nearform/node-clinic-flame/releases{/id}","deployments_url":"https://api.github.com/repos/nearform/node-clinic-flame/deployments","created_at":"2018-07-17T14:30:23Z","updated_at":"2018-11-22T11:07:31Z","pushed_at":"2018-11-22T11:21:40Z","git_url":"git://github.com/nearform/node-clinic-flame.git","ssh_url":"git@github.com:nearform/node-clinic-flame.git","clone_url":"https://github.com/nearform/node-clinic-flame.git","svn_url":"https://github.com/nearform/node-clinic-flame","homepage":"https://clinicjs.org","size":465,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":11,"watchers":6,"default_branch":"master"}},"base":{"label":"nearform:master","ref":"master","sha":"aaff708a4a46728bfa10b92e111ea8ecb244cddb","user":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"repo":{"id":141301537,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMDE1Mzc=","name":"node-clinic-flame","full_name":"nearform/node-clinic-flame","private":false,"owner":{"login":"nearform","id":1544687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDQ2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1544687?v=4","gravatar_id":"","url":"https://api.github.com/users/nearform","html_url":"https://github.com/nearform","followers_url":"https://api.github.com/users/nearform/followers","following_url":"https://api.github.com/users/nearform/following{/other_user}","gists_url":"https://api.github.com/users/nearform/gists{/gist_id}","starred_url":"https://api.github.com/users/nearform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nearform/subscriptions","organizations_url":"https://api.github.com/users/nearform/orgs","repos_url":"https://api.github.com/users/nearform/repos","events_url":"https://api.github.com/users/nearform/events{/privacy}","received_events_url":"https://api.github.com/users/nearform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nearform/node-clinic-flame","description":"Programmable interface to `clinic flame`","fork":false,"url":"https://api.github.com/repos/nearform/node-clinic-flame","forks_url":"https://api.github.com/repos/nearform/node-clinic-flame/forks","keys_url":"https://api.github.com/repos/nearform/node-clinic-flame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nearform/node-clinic-flame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nearform/node-clinic-flame/teams","hooks_url":"https://api.github.com/repos/nearform/node-clinic-flame/hooks","issue_events_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/events{/number}","events_url":"https://api.github.com/repos/nearform/node-clinic-flame/events","assignees_url":"https://api.github.com/repos/nearform/node-clinic-flame/assignees{/user}","branches_url":"https://api.github.com/repos/nearform/node-clinic-flame/branches{/branch}","tags_url":"https://api.github.com/repos/nearform/node-clinic-flame/tags","blobs_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/refs{/sha}","trees_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nearform/node-clinic-flame/statuses/{sha}","languages_url":"https://api.github.com/repos/nearform/node-clinic-flame/languages","stargazers_url":"https://api.github.com/repos/nearform/node-clinic-flame/stargazers","contributors_url":"https://api.github.com/repos/nearform/node-clinic-flame/contributors","subscribers_url":"https://api.github.com/repos/nearform/node-clinic-flame/subscribers","subscription_url":"https://api.github.com/repos/nearform/node-clinic-flame/subscription","commits_url":"https://api.github.com/repos/nearform/node-clinic-flame/commits{/sha}","git_commits_url":"https://api.github.com/repos/nearform/node-clinic-flame/git/commits{/sha}","comments_url":"https://api.github.com/repos/nearform/node-clinic-flame/comments{/number}","issue_comment_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues/comments{/number}","contents_url":"https://api.github.com/repos/nearform/node-clinic-flame/contents/{+path}","compare_url":"https://api.github.com/repos/nearform/node-clinic-flame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nearform/node-clinic-flame/merges","archive_url":"https://api.github.com/repos/nearform/node-clinic-flame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nearform/node-clinic-flame/downloads","issues_url":"https://api.github.com/repos/nearform/node-clinic-flame/issues{/number}","pulls_url":"https://api.github.com/repos/nearform/node-clinic-flame/pulls{/number}","milestones_url":"https://api.github.com/repos/nearform/node-clinic-flame/milestones{/number}","notifications_url":"https://api.github.com/repos/nearform/node-clinic-flame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nearform/node-clinic-flame/labels{/name}","releases_url":"https://api.github.com/repos/nearform/node-clinic-flame/releases{/id}","deployments_url":"https://api.github.com/repos/nearform/node-clinic-flame/deployments","created_at":"2018-07-17T14:30:23Z","updated_at":"2018-11-22T11:07:31Z","pushed_at":"2018-11-22T11:21:40Z","git_url":"git://github.com/nearform/node-clinic-flame.git","ssh_url":"git@github.com:nearform/node-clinic-flame.git","clone_url":"https://github.com/nearform/node-clinic-flame.git","svn_url":"https://github.com/nearform/node-clinic-flame","homepage":"https://clinicjs.org","size":465,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46"},"html":{"href":"https://github.com/nearform/node-clinic-flame/pull/46"},"issue":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/issues/46"},"comments":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/nearform/node-clinic-flame/statuses/1e3757ec2344015cd3e0a05b9ca002488bc89422"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlanSl"}}