{"action":"closed","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/217","repository_url":"https://api.github.com/repos/openzipkin/zipkin-js","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/217/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/217/events","html_url":"https://github.com/openzipkin/zipkin-js/issues/217","id":328464175,"node_id":"MDU6SXNzdWUzMjg0NjQxNzU=","number":217,"title":"Remove http.url in favor of http.path in express middleware","user":{"login":"jcchavezs","id":3075074,"node_id":"MDQ6VXNlcjMwNzUwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3075074?v=4","gravatar_id":"","url":"https://api.github.com/users/jcchavezs","html_url":"https://github.com/jcchavezs","followers_url":"https://api.github.com/users/jcchavezs/followers","following_url":"https://api.github.com/users/jcchavezs/following{/other_user}","gists_url":"https://api.github.com/users/jcchavezs/gists{/gist_id}","starred_url":"https://api.github.com/users/jcchavezs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcchavezs/subscriptions","organizations_url":"https://api.github.com/users/jcchavezs/orgs","repos_url":"https://api.github.com/users/jcchavezs/repos","events_url":"https://api.github.com/users/jcchavezs/events{/privacy}","received_events_url":"https://api.github.com/users/jcchavezs/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-01T10:24:46Z","updated_at":"2018-07-03T04:38:36Z","closed_at":"2018-07-03T04:38:36Z","author_association":"CONTRIBUTOR","body":"At the moment, Zipkin JS is including `http.url` as annotation including all query strings. This has som privacy issues (e.g. passing e-mails or tokens in query parameters) so most zipkin instrumentations include the `http.path` instead.\r\n\r\n- [zipkin-go](https://github.com/openzipkin/zipkin-go/blob/e260ab9d9af33ad4d9267be78add1d8a62806f74/middleware/http/server.go#L95)\r\n- [zipkin-php](https://github.com/jcchavezs/zipkin-instrumentation-symfony/blob/master/src/ZipkinBundle/Middleware.php#L81)\r\n- [zipkin-ruby](https://github.com/openzipkin/zipkin-ruby/blob/e2f429976a7bfddbe908743bc2c9c2ec0b64afb4/CHANGELOG.md#0184)\r\n\r\nPing @pchiwan @adriancole "}}
{"actor":{"display_login":"adriancole"}}