{"action":"closed","number":56983,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983","id":157388609,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU3Mzg4NjA5","html_url":"https://github.com/kubernetes/kubernetes/pull/56983","diff_url":"https://github.com/kubernetes/kubernetes/pull/56983.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56983.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56983","number":56983,"state":"closed","locked":false,"title":"refactor kubelet long function, extract addAdmitHandler func","user":{"login":"oulinbao","id":7589619,"node_id":"MDQ6VXNlcjc1ODk2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7589619?v=4","gravatar_id":"","url":"https://api.github.com/users/oulinbao","html_url":"https://github.com/oulinbao","followers_url":"https://api.github.com/users/oulinbao/followers","following_url":"https://api.github.com/users/oulinbao/following{/other_user}","gists_url":"https://api.github.com/users/oulinbao/gists{/gist_id}","starred_url":"https://api.github.com/users/oulinbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulinbao/subscriptions","organizations_url":"https://api.github.com/users/oulinbao/orgs","repos_url":"https://api.github.com/users/oulinbao/repos","events_url":"https://api.github.com/users/oulinbao/events{/privacy}","received_events_url":"https://api.github.com/users/oulinbao/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nrefactor long func\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nNone\r\n```\r\n","created_at":"2017-12-09T14:00:11Z","updated_at":"2018-06-03T01:17:18Z","closed_at":"2018-06-03T01:17:18Z","merged_at":null,"merge_commit_sha":"428d64d30c0cb31cb3c6316170a3f3a9477e7afe","assignee":{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"assignees":[{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":778118402,"node_id":"MDU6TGFiZWw3NzgxMTg0MDI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false},{"id":240247879,"node_id":"MDU6TGFiZWwyNDAyNDc4Nzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56983/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ca78cb06ae24a7a95689f5ac698c0c5ca55c50d5","head":{"label":"oulinbao:refactor_kubelet_admithandler","ref":"refactor_kubelet_admithandler","sha":"ca78cb06ae24a7a95689f5ac698c0c5ca55c50d5","user":{"login":"oulinbao","id":7589619,"node_id":"MDQ6VXNlcjc1ODk2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7589619?v=4","gravatar_id":"","url":"https://api.github.com/users/oulinbao","html_url":"https://github.com/oulinbao","followers_url":"https://api.github.com/users/oulinbao/followers","following_url":"https://api.github.com/users/oulinbao/following{/other_user}","gists_url":"https://api.github.com/users/oulinbao/gists{/gist_id}","starred_url":"https://api.github.com/users/oulinbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulinbao/subscriptions","organizations_url":"https://api.github.com/users/oulinbao/orgs","repos_url":"https://api.github.com/users/oulinbao/repos","events_url":"https://api.github.com/users/oulinbao/events{/privacy}","received_events_url":"https://api.github.com/users/oulinbao/received_events","type":"User","site_admin":false},"repo":{"id":70657057,"node_id":"MDEwOlJlcG9zaXRvcnk3MDY1NzA1Nw==","name":"kubernetes","full_name":"oulinbao/kubernetes","owner":{"login":"oulinbao","id":7589619,"node_id":"MDQ6VXNlcjc1ODk2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7589619?v=4","gravatar_id":"","url":"https://api.github.com/users/oulinbao","html_url":"https://github.com/oulinbao","followers_url":"https://api.github.com/users/oulinbao/followers","following_url":"https://api.github.com/users/oulinbao/following{/other_user}","gists_url":"https://api.github.com/users/oulinbao/gists{/gist_id}","starred_url":"https://api.github.com/users/oulinbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulinbao/subscriptions","organizations_url":"https://api.github.com/users/oulinbao/orgs","repos_url":"https://api.github.com/users/oulinbao/repos","events_url":"https://api.github.com/users/oulinbao/events{/privacy}","received_events_url":"https://api.github.com/users/oulinbao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oulinbao/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/oulinbao/kubernetes","forks_url":"https://api.github.com/repos/oulinbao/kubernetes/forks","keys_url":"https://api.github.com/repos/oulinbao/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oulinbao/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oulinbao/kubernetes/teams","hooks_url":"https://api.github.com/repos/oulinbao/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/oulinbao/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/oulinbao/kubernetes/events","assignees_url":"https://api.github.com/repos/oulinbao/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/oulinbao/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/oulinbao/kubernetes/tags","blobs_url":"https://api.github.com/repos/oulinbao/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oulinbao/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oulinbao/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/oulinbao/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oulinbao/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/oulinbao/kubernetes/languages","stargazers_url":"https://api.github.com/repos/oulinbao/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/oulinbao/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/oulinbao/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/oulinbao/kubernetes/subscription","commits_url":"https://api.github.com/repos/oulinbao/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/oulinbao/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/oulinbao/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/oulinbao/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/oulinbao/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/oulinbao/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oulinbao/kubernetes/merges","archive_url":"https://api.github.com/repos/oulinbao/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oulinbao/kubernetes/downloads","issues_url":"https://api.github.com/repos/oulinbao/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/oulinbao/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/oulinbao/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/oulinbao/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oulinbao/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/oulinbao/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/oulinbao/kubernetes/deployments","created_at":"2016-10-12T03:02:24Z","updated_at":"2016-10-12T03:03:01Z","pushed_at":"2017-12-19T23:39:58Z","git_url":"git://github.com/oulinbao/kubernetes.git","ssh_url":"git@github.com:oulinbao/kubernetes.git","clone_url":"https://github.com/oulinbao/kubernetes.git","svn_url":"https://github.com/oulinbao/kubernetes","homepage":"http://kubernetes.io","size":517109,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"bb72237375dfb32f2928e39354a42c40afc98fc1","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-06-03T00:31:15Z","pushed_at":"2018-06-02T23:41:48Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":783220,"stargazers_count":37103,"watchers_count":37103,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13004,"mirror_url":null,"archived":false,"open_issues_count":3245,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13004,"open_issues":3245,"watchers":37103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/56983"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56983"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56983/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56983/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ca78cb06ae24a7a95689f5ac698c0c5ca55c50d5"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":64,"deletions":52,"changed_files":1}}
{"actor":{"display_login":"k8s-ci-robot"}}