{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/comments/204192314","pull_request_review_id":139238233,"id":204192314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5MjMxNA==","diff_hunk":"@@ -234,12 +237,17 @@ public WrappingData(final Cipher cipher, final byte[] extraInfo) {\n     }\n \n     private static class Rsa extends JceMasterKey {\n+        private static final Pattern SUPPORTED_TRANSFORMATIONS =","path":"src/main/java/com/amazonaws/encryptionsdk/jce/JceMasterKey.java","position":21,"original_position":21,"commit_id":"36ddfe70d573b6ee63c8d10f7012191564d88b01","original_commit_id":"36ddfe70d573b6ee63c8d10f7012191564d88b01","user":{"login":"lizroth","id":30636882,"node_id":"MDQ6VXNlcjMwNjM2ODgy","avatar_url":"https://avatars3.githubusercontent.com/u/30636882?v=4","gravatar_id":"","url":"https://api.github.com/users/lizroth","html_url":"https://github.com/lizroth","followers_url":"https://api.github.com/users/lizroth/followers","following_url":"https://api.github.com/users/lizroth/following{/other_user}","gists_url":"https://api.github.com/users/lizroth/gists{/gist_id}","starred_url":"https://api.github.com/users/lizroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizroth/subscriptions","organizations_url":"https://api.github.com/users/lizroth/orgs","repos_url":"https://api.github.com/users/lizroth/repos","events_url":"https://api.github.com/users/lizroth/events{/privacy}","received_events_url":"https://api.github.com/users/lizroth/received_events","type":"User","site_admin":false},"body":"It might be nice to have some kind of test coverage for this in general in the future to make sure we warn / don't warn as intended","created_at":"2018-07-20T23:49:00Z","updated_at":"2018-07-20T23:49:45Z","html_url":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59#discussion_r204192314","pull_request_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/comments/204192314"},"html":{"href":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59#discussion_r204192314"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59","id":202977897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTc3ODk3","html_url":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59","diff_url":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59.diff","patch_url":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59.patch","issue_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/59","number":59,"state":"open","locked":false,"title":"Log a warning when an unsupported asym algorithm is used with JceMasterKey","user":{"login":"SalusaSecondus","id":829871,"node_id":"MDQ6VXNlcjgyOTg3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/829871?v=4","gravatar_id":"","url":"https://api.github.com/users/SalusaSecondus","html_url":"https://github.com/SalusaSecondus","followers_url":"https://api.github.com/users/SalusaSecondus/followers","following_url":"https://api.github.com/users/SalusaSecondus/following{/other_user}","gists_url":"https://api.github.com/users/SalusaSecondus/gists{/gist_id}","starred_url":"https://api.github.com/users/SalusaSecondus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalusaSecondus/subscriptions","organizations_url":"https://api.github.com/users/SalusaSecondus/orgs","repos_url":"https://api.github.com/users/SalusaSecondus/repos","events_url":"https://api.github.com/users/SalusaSecondus/events{/privacy}","received_events_url":"https://api.github.com/users/SalusaSecondus/received_events","type":"User","site_admin":false},"body":"This is to fix #56 \r\n\r\nI have manually verified that all existing tests pass as well as manual verification that a logged warning appears if and only if an unsupported algorithm is used with `JceMasterKey`.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","created_at":"2018-07-20T23:40:05Z","updated_at":"2018-07-20T23:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66d2e1ecd636c6ed64a202887823ad97ca96bce4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/59/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/statuses/36ddfe70d573b6ee63c8d10f7012191564d88b01","head":{"label":"SalusaSecondus:issue-56","ref":"issue-56","sha":"36ddfe70d573b6ee63c8d10f7012191564d88b01","user":{"login":"SalusaSecondus","id":829871,"node_id":"MDQ6VXNlcjgyOTg3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/829871?v=4","gravatar_id":"","url":"https://api.github.com/users/SalusaSecondus","html_url":"https://github.com/SalusaSecondus","followers_url":"https://api.github.com/users/SalusaSecondus/followers","following_url":"https://api.github.com/users/SalusaSecondus/following{/other_user}","gists_url":"https://api.github.com/users/SalusaSecondus/gists{/gist_id}","starred_url":"https://api.github.com/users/SalusaSecondus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalusaSecondus/subscriptions","organizations_url":"https://api.github.com/users/SalusaSecondus/orgs","repos_url":"https://api.github.com/users/SalusaSecondus/repos","events_url":"https://api.github.com/users/SalusaSecondus/events{/privacy}","received_events_url":"https://api.github.com/users/SalusaSecondus/received_events","type":"User","site_admin":false},"repo":{"id":112532209,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MzIyMDk=","name":"aws-encryption-sdk-java","full_name":"SalusaSecondus/aws-encryption-sdk-java","owner":{"login":"SalusaSecondus","id":829871,"node_id":"MDQ6VXNlcjgyOTg3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/829871?v=4","gravatar_id":"","url":"https://api.github.com/users/SalusaSecondus","html_url":"https://github.com/SalusaSecondus","followers_url":"https://api.github.com/users/SalusaSecondus/followers","following_url":"https://api.github.com/users/SalusaSecondus/following{/other_user}","gists_url":"https://api.github.com/users/SalusaSecondus/gists{/gist_id}","starred_url":"https://api.github.com/users/SalusaSecondus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalusaSecondus/subscriptions","organizations_url":"https://api.github.com/users/SalusaSecondus/orgs","repos_url":"https://api.github.com/users/SalusaSecondus/repos","events_url":"https://api.github.com/users/SalusaSecondus/events{/privacy}","received_events_url":"https://api.github.com/users/SalusaSecondus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SalusaSecondus/aws-encryption-sdk-java","description":"AWS Encryption SDK","fork":true,"url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java","forks_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/forks","keys_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/teams","hooks_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/events","assignees_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/tags","blobs_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/languages","stargazers_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/subscription","commits_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/merges","archive_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/downloads","issues_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/SalusaSecondus/aws-encryption-sdk-java/deployments","created_at":"2017-11-29T21:53:30Z","updated_at":"2018-07-20T22:33:40Z","pushed_at":"2018-07-20T23:37:27Z","git_url":"git://github.com/SalusaSecondus/aws-encryption-sdk-java.git","ssh_url":"git@github.com:SalusaSecondus/aws-encryption-sdk-java.git","clone_url":"https://github.com/SalusaSecondus/aws-encryption-sdk-java.git","svn_url":"https://github.com/SalusaSecondus/aws-encryption-sdk-java","homepage":"https://docs.aws.amazon.com/encryption-sdk/latest/developer-guide/introduction.html","size":851,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"7d5ab6eef428364286c50b969ef89766be6207ee","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":53990057,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk5MDA1Nw==","name":"aws-encryption-sdk-java","full_name":"awslabs/aws-encryption-sdk-java","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-encryption-sdk-java","description":"AWS Encryption SDK","fork":false,"url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java","forks_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/forks","keys_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/events","assignees_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/merges","archive_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/deployments","created_at":"2016-03-16T01:09:51Z","updated_at":"2018-07-13T23:17:03Z","pushed_at":"2018-07-20T23:40:06Z","git_url":"git://github.com/awslabs/aws-encryption-sdk-java.git","ssh_url":"git@github.com:awslabs/aws-encryption-sdk-java.git","clone_url":"https://github.com/awslabs/aws-encryption-sdk-java.git","svn_url":"https://github.com/awslabs/aws-encryption-sdk-java","homepage":"https://docs.aws.amazon.com/encryption-sdk/latest/developer-guide/introduction.html","size":849,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":13,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59"},"html":{"href":"https://github.com/awslabs/aws-encryption-sdk-java/pull/59"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/59"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-encryption-sdk-java/statuses/36ddfe70d573b6ee63c8d10f7012191564d88b01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lizroth"}}