{"action":"created","issue":{"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/244","repository_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus","labels_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/244/comments","events_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/244/events","html_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/244","id":349409192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTMxNDIy","number":244,"title":"221 reject write message if job id in use","user":{"login":"michele-brambilla","id":17079797,"node_id":"MDQ6VXNlcjE3MDc5Nzk3","avatar_url":"https://avatars0.githubusercontent.com/u/17079797?v=4","gravatar_id":"","url":"https://api.github.com/users/michele-brambilla","html_url":"https://github.com/michele-brambilla","followers_url":"https://api.github.com/users/michele-brambilla/followers","following_url":"https://api.github.com/users/michele-brambilla/following{/other_user}","gists_url":"https://api.github.com/users/michele-brambilla/gists{/gist_id}","starred_url":"https://api.github.com/users/michele-brambilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michele-brambilla/subscriptions","organizations_url":"https://api.github.com/users/michele-brambilla/orgs","repos_url":"https://api.github.com/users/michele-brambilla/repos","events_url":"https://api.github.com/users/michele-brambilla/events{/privacy}","received_events_url":"https://api.github.com/users/michele-brambilla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-10T07:43:14Z","updated_at":"2018-08-10T07:56:21Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/pulls/244","html_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/244","diff_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/244.diff","patch_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/244.patch"},"body":"### Description of work\r\n\r\nEach writing task must be tagged with a unique ID. So far a bug allowed two different task to have the same ID, causing different misbehaviours. In this PR we introduce a fix that reject the \"write new\" command if the jobID is already in use.\r\n\r\n### Issue\r\n\r\nCloses #221 \r\n\r\n### Acceptance Criteria\r\n\r\n- the file writer should accept \"write new\" commands with different jobID\r\n- if a \"write new\" command is received but the jobID is already in use should drop the command\r\n\r\n---\r\n\r\n## Code Review (To be filled in by the reviewer only)\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Do the changes function as described and is it robust?\r\n\r\n---\r\n\r\n## Nominate for Group Code Review (Anyone can nominate it)\r\nIndicate if you think the code should be reviewed in a Thursday code review session.\r\n\r\n- [ ] Recommend for group code review\r\n\r\nAlso, nominate it on the code_review Slack channel (does someone want to automate this?).\r\n"},"comment":{"url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/comments/412006514","html_url":"https://github.com/ess-dmsc/kafka-to-nexus/pull/244#issuecomment-412006514","issue_url":"https://api.github.com/repos/ess-dmsc/kafka-to-nexus/issues/244","id":412006514,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAwNjUxNA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T07:56:21Z","updated_at":"2018-08-10T07:56:21Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ess-dmsc/kafka-to-nexus/pull/244?src=pr&el=h1) Report\n> Merging [#244](https://codecov.io/gh/ess-dmsc/kafka-to-nexus/pull/244?src=pr&el=desc) into [master](https://codecov.io/gh/ess-dmsc/kafka-to-nexus/commit/8130e282411a240f99c997afcd91ee477c378245?src=pr&el=desc) will **decrease** coverage by `0.05%`.\n> The diff coverage is `16.66%`.\n\n\n```diff\n@@            Coverage Diff             @@\n##           master     #244      +/-   ##\n==========================================\n- Coverage   49.87%   49.82%   -0.06%     \n==========================================\n  Files          72       72              \n  Lines        3641     3647       +6     \n==========================================\n+ Hits         1816     1817       +1     \n- Misses       1825     1830       +5\n```\n\n| [Impacted Files](https://codecov.io/gh/ess-dmsc/kafka-to-nexus/pull/244?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/CommandHandler.cpp](https://codecov.io/gh/ess-dmsc/kafka-to-nexus/pull/244/diff?src=pr&el=tree#diff-c3JjL0NvbW1hbmRIYW5kbGVyLmNwcA==) | `54.77% <16.66%> (-0.86%)` | :arrow_down: |\n\n\n"}}
{"actor":{"display_login":"codecov-io"}}