{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/176138247","pull_request_review_id":105788914,"id":176138247,"diff_hunk":"@@ -16,19 +16,8 @@\n static void\n fatal_common(const char *message)\n {\n-#if HAVE_SYSLOG\n-    syslog(LOG_ALERT, \"%s\", message);\n-#endif\n-\n-    fprintf(debug_log, \"FATAL: %s\\n\", message);\n-\n-    if (Debug::log_stderr > 0 && debug_log != stderr)\n-        fprintf(stderr, \"FATAL: %s\\n\", message);\n-\n-    fprintf(debug_log, \"Squid Cache (Version %s): Terminated abnormally.\\n\",\n-            version_string);\n-\n-    fflush(debug_log);","path":"src/fatal.cc","position":16,"original_position":16,"commit_id":"bbc09bff09bc93cac5e23bdd90b2ca39a323011d","original_commit_id":"6e729aafb1804228d7b769aff2d5986ffef9b715","user":{"login":"chtsanti","id":30215174,"avatar_url":"https://avatars2.githubusercontent.com/u/30215174?v=4","gravatar_id":"","url":"https://api.github.com/users/chtsanti","html_url":"https://github.com/chtsanti","followers_url":"https://api.github.com/users/chtsanti/followers","following_url":"https://api.github.com/users/chtsanti/following{/other_user}","gists_url":"https://api.github.com/users/chtsanti/gists{/gist_id}","starred_url":"https://api.github.com/users/chtsanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtsanti/subscriptions","organizations_url":"https://api.github.com/users/chtsanti/orgs","repos_url":"https://api.github.com/users/chtsanti/repos","events_url":"https://api.github.com/users/chtsanti/events{/privacy}","received_events_url":"https://api.github.com/users/chtsanti/received_events","type":"User","site_admin":false},"body":"Alex, all of your requests for changes should addressed in my latest patch. \r\nPlease  review.\r\n","created_at":"2018-03-21T16:00:41Z","updated_at":"2018-03-21T16:00:42Z","html_url":"https://github.com/squid-cache/squid/pull/179#discussion_r176138247","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/176138247"},"html":{"href":"https://github.com/squid-cache/squid/pull/179#discussion_r176138247"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/179"}},"in_reply_to_id":175500316},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/179","id":175877171,"html_url":"https://github.com/squid-cache/squid/pull/179","diff_url":"https://github.com/squid-cache/squid/pull/179.diff","patch_url":"https://github.com/squid-cache/squid/pull/179.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/179","number":179,"state":"open","locked":false,"title":"Add timestamps to (most) FATAL messages","user":{"login":"chtsanti","id":30215174,"avatar_url":"https://avatars2.githubusercontent.com/u/30215174?v=4","gravatar_id":"","url":"https://api.github.com/users/chtsanti","html_url":"https://github.com/chtsanti","followers_url":"https://api.github.com/users/chtsanti/followers","following_url":"https://api.github.com/users/chtsanti/following{/other_user}","gists_url":"https://api.github.com/users/chtsanti/gists{/gist_id}","starred_url":"https://api.github.com/users/chtsanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtsanti/subscriptions","organizations_url":"https://api.github.com/users/chtsanti/orgs","repos_url":"https://api.github.com/users/chtsanti/repos","events_url":"https://api.github.com/users/chtsanti/events{/privacy}","received_events_url":"https://api.github.com/users/chtsanti/received_events","type":"User","site_admin":false},"body":"Reliable timestamp information is often critical for triage. We can use\r\nthe existing debugs() interface to add timestamps to FATAL messages. The\r\naffected code already calls such risky functions as storeDirWriteCleanLogs()\r\nso calling debugs() instead of printing directly to files/syslog should\r\nnot make things worse.\r\n\r\nFATAL messages that were also logged to syslog (at LOG_ALERT level) are\r\nstill logged to syslog (at that same level, but now with the usual\r\nSquid-generated prefix). Such syslog alerts can now be easily triggered\r\nvia a new ForceAlert() API.\r\n\r\nAlso treat segmentation faults, bus errors, and other signal-based\r\nsudden deaths the same as most other FATAL errors -- log them to syslog.\r\n\r\nThis is a Measurement Factory project.","created_at":"2018-03-19T11:55:21Z","updated_at":"2018-03-21T16:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20ecae2af33871c9c9c43d3614c719ae36ba7045","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":827658663,"url":"https://api.github.com/repos/squid-cache/squid/labels/M-failed-description","name":"M-failed-description","color":"6f42c1","default":false},{"id":666339686,"url":"https://api.github.com/repos/squid-cache/squid/labels/S-waiting-for-author","name":"S-waiting-for-author","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/179/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/179/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/179/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/bbc09bff09bc93cac5e23bdd90b2ca39a323011d","head":{"label":"measurement-factory:SQUID-362-FATALs-missing-timestamps-master","ref":"SQUID-362-FATALs-missing-timestamps-master","sha":"bbc09bff09bc93cac5e23bdd90b2ca39a323011d","user":{"login":"measurement-factory","id":5461029,"avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"repo":{"id":97358214,"name":"squid","full_name":"measurement-factory/squid","owner":{"login":"measurement-factory","id":5461029,"avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-factory/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/measurement-factory/squid","forks_url":"https://api.github.com/repos/measurement-factory/squid/forks","keys_url":"https://api.github.com/repos/measurement-factory/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-factory/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-factory/squid/teams","hooks_url":"https://api.github.com/repos/measurement-factory/squid/hooks","issue_events_url":"https://api.github.com/repos/measurement-factory/squid/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-factory/squid/events","assignees_url":"https://api.github.com/repos/measurement-factory/squid/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-factory/squid/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-factory/squid/tags","blobs_url":"https://api.github.com/repos/measurement-factory/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-factory/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-factory/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-factory/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-factory/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-factory/squid/languages","stargazers_url":"https://api.github.com/repos/measurement-factory/squid/stargazers","contributors_url":"https://api.github.com/repos/measurement-factory/squid/contributors","subscribers_url":"https://api.github.com/repos/measurement-factory/squid/subscribers","subscription_url":"https://api.github.com/repos/measurement-factory/squid/subscription","commits_url":"https://api.github.com/repos/measurement-factory/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-factory/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-factory/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-factory/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-factory/squid/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-factory/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-factory/squid/merges","archive_url":"https://api.github.com/repos/measurement-factory/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-factory/squid/downloads","issues_url":"https://api.github.com/repos/measurement-factory/squid/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-factory/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-factory/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-factory/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-factory/squid/labels{/name}","releases_url":"https://api.github.com/repos/measurement-factory/squid/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-factory/squid/deployments","created_at":"2017-07-16T03:46:50Z","updated_at":"2017-07-16T03:46:58Z","pushed_at":"2018-03-21T09:14:24Z","git_url":"git://github.com/measurement-factory/squid.git","ssh_url":"git@github.com:measurement-factory/squid.git","clone_url":"https://github.com/measurement-factory/squid.git","svn_url":"https://github.com/measurement-factory/squid","homepage":"http://www.squid-cache.org/","size":170241,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"d0c5cf9e998fd662875604da01b0ae410734860e","user":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"name":"squid","full_name":"squid-cache/squid","owner":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2018-03-20T10:55:02Z","pushed_at":"2018-03-21T13:36:49Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":161912,"stargazers_count":303,"watchers_count":303,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":121,"open_issues":21,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/179"},"html":{"href":"https://github.com/squid-cache/squid/pull/179"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/179"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/bbc09bff09bc93cac5e23bdd90b2ca39a323011d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chtsanti"}}