{"action":"created","comment":{"url":"https://api.github.com/repos/fyookball/electrum/pulls/comments/203387306","pull_request_review_id":138265045,"id":203387306,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzM4NzMwNg==","diff_hunk":"@@ -255,11 +256,15 @@ def to_ui_string(self, hex_only = False):\n                     def lookup(x):\n                         return OpCodes.reverseLookup.get(x, ('('+str(x)+')'))\n                     if isinstance(op, tuple):\n-                        ret += lookup(op[0]) + \" \" + op[1].decode('utf-8')\n+                        try:\n+                            opData = op[1].decode('utf-8')\n+                        except:\n+                            opData = op[1].hex() if isinstance(op[1], bytes) else str(op[1])","path":"lib/address.py","position":null,"original_position":18,"commit_id":"a8c646e6dbd88fab968825eda86af8036bab2d96","original_commit_id":"244e47891170989958fa2a96e19a9b30071a6e96","user":{"login":"kyuupichan","id":3319176,"node_id":"MDQ6VXNlcjMzMTkxNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3319176?v=4","gravatar_id":"","url":"https://api.github.com/users/kyuupichan","html_url":"https://github.com/kyuupichan","followers_url":"https://api.github.com/users/kyuupichan/followers","following_url":"https://api.github.com/users/kyuupichan/following{/other_user}","gists_url":"https://api.github.com/users/kyuupichan/gists{/gist_id}","starred_url":"https://api.github.com/users/kyuupichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyuupichan/subscriptions","organizations_url":"https://api.github.com/users/kyuupichan/orgs","repos_url":"https://api.github.com/users/kyuupichan/repos","events_url":"https://api.github.com/users/kyuupichan/events{/privacy}","received_events_url":"https://api.github.com/users/kyuupichan/received_events","type":"User","site_admin":false},"body":"It's our code, all in our control.  It should only be doing one thing.  I find it frustrating when the code is made more spaghetti-like (and Electrum is just that) with superstitious code rather than just ensuring it's well-defined and enforcing it.","created_at":"2018-07-18T13:54:12Z","updated_at":"2018-07-18T13:54:12Z","html_url":"https://github.com/fyookball/electrum/pull/801#discussion_r203387306","pull_request_url":"https://api.github.com/repos/fyookball/electrum/pulls/801","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/comments/203387306"},"html":{"href":"https://github.com/fyookball/electrum/pull/801#discussion_r203387306"},"pull_request":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/801"}},"in_reply_to_id":203319816},"pull_request":{"url":"https://api.github.com/repos/fyookball/electrum/pulls/801","id":202178963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTc4OTYz","html_url":"https://github.com/fyookball/electrum/pull/801","diff_url":"https://github.com/fyookball/electrum/pull/801.diff","patch_url":"https://github.com/fyookball/electrum/pull/801.patch","issue_url":"https://api.github.com/repos/fyookball/electrum/issues/801","number":801,"state":"open","locked":false,"title":"Fixes #800","user":{"login":"cculianu","id":266627,"node_id":"MDQ6VXNlcjI2NjYyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/266627?v=4","gravatar_id":"","url":"https://api.github.com/users/cculianu","html_url":"https://github.com/cculianu","followers_url":"https://api.github.com/users/cculianu/followers","following_url":"https://api.github.com/users/cculianu/following{/other_user}","gists_url":"https://api.github.com/users/cculianu/gists{/gist_id}","starred_url":"https://api.github.com/users/cculianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cculianu/subscriptions","organizations_url":"https://api.github.com/users/cculianu/orgs","repos_url":"https://api.github.com/users/cculianu/repos","events_url":"https://api.github.com/users/cculianu/events{/privacy}","received_events_url":"https://api.github.com/users/cculianu/received_events","type":"User","site_admin":false},"body":"Fixes unicode decode errors for ScriptOutputs in OP_RETURN txs.","created_at":"2018-07-18T08:44:49Z","updated_at":"2018-07-18T13:54:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a93c796ef8363130dd19cd8f689adc190f0632e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fyookball/electrum/pulls/801/commits","review_comments_url":"https://api.github.com/repos/fyookball/electrum/pulls/801/comments","review_comment_url":"https://api.github.com/repos/fyookball/electrum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fyookball/electrum/issues/801/comments","statuses_url":"https://api.github.com/repos/fyookball/electrum/statuses/a8c646e6dbd88fab968825eda86af8036bab2d96","head":{"label":"cculianu:fix_800","ref":"fix_800","sha":"a8c646e6dbd88fab968825eda86af8036bab2d96","user":{"login":"cculianu","id":266627,"node_id":"MDQ6VXNlcjI2NjYyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/266627?v=4","gravatar_id":"","url":"https://api.github.com/users/cculianu","html_url":"https://github.com/cculianu","followers_url":"https://api.github.com/users/cculianu/followers","following_url":"https://api.github.com/users/cculianu/following{/other_user}","gists_url":"https://api.github.com/users/cculianu/gists{/gist_id}","starred_url":"https://api.github.com/users/cculianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cculianu/subscriptions","organizations_url":"https://api.github.com/users/cculianu/orgs","repos_url":"https://api.github.com/users/cculianu/repos","events_url":"https://api.github.com/users/cculianu/events{/privacy}","received_events_url":"https://api.github.com/users/cculianu/received_events","type":"User","site_admin":false},"repo":{"id":114484686,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0ODQ2ODY=","name":"electrum","full_name":"cculianu/electrum","owner":{"login":"cculianu","id":266627,"node_id":"MDQ6VXNlcjI2NjYyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/266627?v=4","gravatar_id":"","url":"https://api.github.com/users/cculianu","html_url":"https://github.com/cculianu","followers_url":"https://api.github.com/users/cculianu/followers","following_url":"https://api.github.com/users/cculianu/following{/other_user}","gists_url":"https://api.github.com/users/cculianu/gists{/gist_id}","starred_url":"https://api.github.com/users/cculianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cculianu/subscriptions","organizations_url":"https://api.github.com/users/cculianu/orgs","repos_url":"https://api.github.com/users/cculianu/repos","events_url":"https://api.github.com/users/cculianu/events{/privacy}","received_events_url":"https://api.github.com/users/cculianu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cculianu/electrum","description":"Electron Cash; Bitcoin Cash thin client","fork":true,"url":"https://api.github.com/repos/cculianu/electrum","forks_url":"https://api.github.com/repos/cculianu/electrum/forks","keys_url":"https://api.github.com/repos/cculianu/electrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cculianu/electrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cculianu/electrum/teams","hooks_url":"https://api.github.com/repos/cculianu/electrum/hooks","issue_events_url":"https://api.github.com/repos/cculianu/electrum/issues/events{/number}","events_url":"https://api.github.com/repos/cculianu/electrum/events","assignees_url":"https://api.github.com/repos/cculianu/electrum/assignees{/user}","branches_url":"https://api.github.com/repos/cculianu/electrum/branches{/branch}","tags_url":"https://api.github.com/repos/cculianu/electrum/tags","blobs_url":"https://api.github.com/repos/cculianu/electrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cculianu/electrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cculianu/electrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/cculianu/electrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cculianu/electrum/statuses/{sha}","languages_url":"https://api.github.com/repos/cculianu/electrum/languages","stargazers_url":"https://api.github.com/repos/cculianu/electrum/stargazers","contributors_url":"https://api.github.com/repos/cculianu/electrum/contributors","subscribers_url":"https://api.github.com/repos/cculianu/electrum/subscribers","subscription_url":"https://api.github.com/repos/cculianu/electrum/subscription","commits_url":"https://api.github.com/repos/cculianu/electrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/cculianu/electrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/cculianu/electrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/cculianu/electrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/cculianu/electrum/contents/{+path}","compare_url":"https://api.github.com/repos/cculianu/electrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cculianu/electrum/merges","archive_url":"https://api.github.com/repos/cculianu/electrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cculianu/electrum/downloads","issues_url":"https://api.github.com/repos/cculianu/electrum/issues{/number}","pulls_url":"https://api.github.com/repos/cculianu/electrum/pulls{/number}","milestones_url":"https://api.github.com/repos/cculianu/electrum/milestones{/number}","notifications_url":"https://api.github.com/repos/cculianu/electrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cculianu/electrum/labels{/name}","releases_url":"https://api.github.com/repos/cculianu/electrum/releases{/id}","deployments_url":"https://api.github.com/repos/cculianu/electrum/deployments","created_at":"2017-12-16T19:19:28Z","updated_at":"2018-07-18T09:09:09Z","pushed_at":"2018-07-18T10:41:27Z","git_url":"git://github.com/cculianu/electrum.git","ssh_url":"git@github.com:cculianu/electrum.git","clone_url":"https://github.com/cculianu/electrum.git","svn_url":"https://github.com/cculianu/electrum","homepage":"http://www.electroncash.org","size":34282,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"fyookball:master","ref":"master","sha":"9bf4f8b215170e044dc8122a7fac887319b8f761","user":{"login":"fyookball","id":7663756,"node_id":"MDQ6VXNlcjc2NjM3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7663756?v=4","gravatar_id":"","url":"https://api.github.com/users/fyookball","html_url":"https://github.com/fyookball","followers_url":"https://api.github.com/users/fyookball/followers","following_url":"https://api.github.com/users/fyookball/following{/other_user}","gists_url":"https://api.github.com/users/fyookball/gists{/gist_id}","starred_url":"https://api.github.com/users/fyookball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyookball/subscriptions","organizations_url":"https://api.github.com/users/fyookball/orgs","repos_url":"https://api.github.com/users/fyookball/repos","events_url":"https://api.github.com/users/fyookball/events{/privacy}","received_events_url":"https://api.github.com/users/fyookball/received_events","type":"User","site_admin":false},"repo":{"id":98333687,"node_id":"MDEwOlJlcG9zaXRvcnk5ODMzMzY4Nw==","name":"electrum","full_name":"fyookball/electrum","owner":{"login":"fyookball","id":7663756,"node_id":"MDQ6VXNlcjc2NjM3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7663756?v=4","gravatar_id":"","url":"https://api.github.com/users/fyookball","html_url":"https://github.com/fyookball","followers_url":"https://api.github.com/users/fyookball/followers","following_url":"https://api.github.com/users/fyookball/following{/other_user}","gists_url":"https://api.github.com/users/fyookball/gists{/gist_id}","starred_url":"https://api.github.com/users/fyookball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyookball/subscriptions","organizations_url":"https://api.github.com/users/fyookball/orgs","repos_url":"https://api.github.com/users/fyookball/repos","events_url":"https://api.github.com/users/fyookball/events{/privacy}","received_events_url":"https://api.github.com/users/fyookball/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fyookball/electrum","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/fyookball/electrum","forks_url":"https://api.github.com/repos/fyookball/electrum/forks","keys_url":"https://api.github.com/repos/fyookball/electrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fyookball/electrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fyookball/electrum/teams","hooks_url":"https://api.github.com/repos/fyookball/electrum/hooks","issue_events_url":"https://api.github.com/repos/fyookball/electrum/issues/events{/number}","events_url":"https://api.github.com/repos/fyookball/electrum/events","assignees_url":"https://api.github.com/repos/fyookball/electrum/assignees{/user}","branches_url":"https://api.github.com/repos/fyookball/electrum/branches{/branch}","tags_url":"https://api.github.com/repos/fyookball/electrum/tags","blobs_url":"https://api.github.com/repos/fyookball/electrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fyookball/electrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fyookball/electrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fyookball/electrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fyookball/electrum/statuses/{sha}","languages_url":"https://api.github.com/repos/fyookball/electrum/languages","stargazers_url":"https://api.github.com/repos/fyookball/electrum/stargazers","contributors_url":"https://api.github.com/repos/fyookball/electrum/contributors","subscribers_url":"https://api.github.com/repos/fyookball/electrum/subscribers","subscription_url":"https://api.github.com/repos/fyookball/electrum/subscription","commits_url":"https://api.github.com/repos/fyookball/electrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fyookball/electrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fyookball/electrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fyookball/electrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fyookball/electrum/contents/{+path}","compare_url":"https://api.github.com/repos/fyookball/electrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fyookball/electrum/merges","archive_url":"https://api.github.com/repos/fyookball/electrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fyookball/electrum/downloads","issues_url":"https://api.github.com/repos/fyookball/electrum/issues{/number}","pulls_url":"https://api.github.com/repos/fyookball/electrum/pulls{/number}","milestones_url":"https://api.github.com/repos/fyookball/electrum/milestones{/number}","notifications_url":"https://api.github.com/repos/fyookball/electrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fyookball/electrum/labels{/name}","releases_url":"https://api.github.com/repos/fyookball/electrum/releases{/id}","deployments_url":"https://api.github.com/repos/fyookball/electrum/deployments","created_at":"2017-07-25T17:40:55Z","updated_at":"2018-07-18T09:08:58Z","pushed_at":"2018-07-18T10:41:28Z","git_url":"git://github.com/fyookball/electrum.git","ssh_url":"git@github.com:fyookball/electrum.git","clone_url":"https://github.com/fyookball/electrum.git","svn_url":"https://github.com/fyookball/electrum","homepage":null,"size":27740,"stargazers_count":182,"watchers_count":182,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":76,"open_issues":29,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/801"},"html":{"href":"https://github.com/fyookball/electrum/pull/801"},"issue":{"href":"https://api.github.com/repos/fyookball/electrum/issues/801"},"comments":{"href":"https://api.github.com/repos/fyookball/electrum/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fyookball/electrum/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/fyookball/electrum/statuses/a8c646e6dbd88fab968825eda86af8036bab2d96"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kyuupichan"}}