{"action":"created","issue":{"url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/113","repository_url":"https://api.github.com/repos/FairRootGroup/FairMQ","labels_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/113/comments","events_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/113/events","html_url":"https://github.com/FairRootGroup/FairMQ/pull/113","id":376386177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjE0MDYw","number":113,"title":"Add tests for network tools and channel validation","user":{"login":"rbx","id":1915061,"node_id":"MDQ6VXNlcjE5MTUwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1915061?v=4","gravatar_id":"","url":"https://api.github.com/users/rbx","html_url":"https://github.com/rbx","followers_url":"https://api.github.com/users/rbx/followers","following_url":"https://api.github.com/users/rbx/following{/other_user}","gists_url":"https://api.github.com/users/rbx/gists{/gist_id}","starred_url":"https://api.github.com/users/rbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbx/subscriptions","organizations_url":"https://api.github.com/users/rbx/orgs","repos_url":"https://api.github.com/users/rbx/repos","events_url":"https://api.github.com/users/rbx/events{/privacy}","received_events_url":"https://api.github.com/users/rbx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-01T13:11:41Z","updated_at":"2018-11-01T13:19:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/113","html_url":"https://github.com/FairRootGroup/FairMQ/pull/113","diff_url":"https://github.com/FairRootGroup/FairMQ/pull/113.diff","patch_url":"https://github.com/FairRootGroup/FairMQ/pull/113.patch"},"body":"- Add test for interface IP detection tools\r\n- Add test for channel validation\r\n\r\nAlso remove code duplication in network tools and fix wrong string size in channel validation.\r\n\r\n---\r\n\r\nChecklist:\r\n\r\n* [x] Rebased against `dev` branch\r\n* [x] My name is in the resp. CONTRIBUTORS/AUTHORS file\r\n* [x] Followed [the seven rules of great commit messages](https://chris.beams.io/posts/git-commit/#seven-rules)\r\n"},"comment":{"url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/comments/435038450","html_url":"https://github.com/FairRootGroup/FairMQ/pull/113#issuecomment-435038450","issue_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/113","id":435038450,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTAzODQ1MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-01T13:19:41Z","updated_at":"2018-11-01T13:19:41Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113?src=pr&el=h1) Report\n> Merging [#113](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113?src=pr&el=desc) into [dev](https://codecov.io/gh/FairRootGroup/FairMQ/commit/5e4876c947e291fe5d6e40acba03afda8f0c6aed?src=pr&el=desc) will **increase** coverage by `1.65%`.\n> The diff coverage is `77.77%`.\n\n```diff\n@@            Coverage Diff            @@\n##             dev     #113      +/-   ##\n=========================================\n+ Coverage   72.4%   74.06%   +1.65%     \n=========================================\n  Files         71       71              \n  Lines       4124     4083      -41     \n=========================================\n+ Hits        2986     3024      +38     \n+ Misses      1138     1059      -79\n```\n\n| [Impacted Files](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [fairmq/FairMQChannel.cxx](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUUNoYW5uZWwuY3h4) | `67.57% <100%> (+19.87%)` | :arrow_up: |\n| [fairmq/tools/Network.cxx](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL3Rvb2xzL05ldHdvcmsuY3h4) | `71.18% <75%> (+51.18%)` | :arrow_up: |\n| [fairmq/FairMQUnmanagedRegion.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUVVubWFuYWdlZFJlZ2lvbi5o) | `0% <0%> (-100%)` | :arrow_down: |\n| [fairmq/FairMQTransportFactory.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUVRyYW5zcG9ydEZhY3RvcnkuaA==) | `0% <0%> (-100%)` | :arrow_down: |\n| [fairmq/tools/RateLimit.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL3Rvb2xzL1JhdGVMaW1pdC5o) | `0% <0%> (-85.19%)` | :arrow_down: |\n| [fairmq/FairMQChannel.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUUNoYW5uZWwuaA==) | `0% <0%> (-80%)` | :arrow_down: |\n| [fairmq/FairMQSocket.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUVNvY2tldC5o) | `0% <0%> (-66.67%)` | :arrow_down: |\n| [fairmq/tools/CppSTL.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL3Rvb2xzL0NwcFNUTC5o) | `0% <0%> (-50%)` | :arrow_down: |\n| [fairmq/MemoryResources.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL01lbW9yeVJlc291cmNlcy5o) | `0% <0%> (-50%)` | :arrow_down: |\n| [fairmq/FairMQParts.h](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree#diff-ZmFpcm1xL0ZhaXJNUVBhcnRzLmg=) | `33.33% <0%> (-33.34%)` | :arrow_down: |\n| ... and [8 more](https://codecov.io/gh/FairRootGroup/FairMQ/pull/113/diff?src=pr&el=tree-more) | |\n"}}
{"actor":{"display_login":"codecov"}}