{"action":"created","comment":{"url":"https://api.github.com/repos/whitfin/cachex/pulls/comments/202525128","pull_request_review_id":137248563,"id":202525128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUyNTEyOA==","diff_hunk":"@@ -91,13 +97,7 @@ defmodule Cachex.Services.Courier do\n   #\n   # This will update all processes waiting for the result of the\n   # specified task, and remove the task from the tracked state.\n-  def handle_info({ :notify, key, result }, { cache, tasks }) do\n-    normalized = normalize_commit(result)\n-\n-    with { :commit, val } <- normalized do\n-      Put.execute(cache, key, val, const(:notify_false))\n-    end\n-\n+  def handle_info({ :notify, key, normalized }, { cache, tasks }) do","path":"lib/cachex/services/courier.ex","position":26,"original_position":26,"commit_id":"7372f28badcc910d5a6c57760ffbfa2a96221bb3","original_commit_id":"7372f28badcc910d5a6c57760ffbfa2a96221bb3","user":{"login":"whitfin","id":5376378,"node_id":"MDQ6VXNlcjUzNzYzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5376378?v=4","gravatar_id":"","url":"https://api.github.com/users/whitfin","html_url":"https://github.com/whitfin","followers_url":"https://api.github.com/users/whitfin/followers","following_url":"https://api.github.com/users/whitfin/following{/other_user}","gists_url":"https://api.github.com/users/whitfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whitfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitfin/subscriptions","organizations_url":"https://api.github.com/users/whitfin/orgs","repos_url":"https://api.github.com/users/whitfin/repos","events_url":"https://api.github.com/users/whitfin/events{/privacy}","received_events_url":"https://api.github.com/users/whitfin/received_events","type":"User","site_admin":false},"body":"Can you please change `normalized` back to `result`?","created_at":"2018-07-14T21:05:26Z","updated_at":"2018-07-14T21:09:12Z","html_url":"https://github.com/whitfin/cachex/pull/193#discussion_r202525128","pull_request_url":"https://api.github.com/repos/whitfin/cachex/pulls/193","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/comments/202525128"},"html":{"href":"https://github.com/whitfin/cachex/pull/193#discussion_r202525128"},"pull_request":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/whitfin/cachex/pulls/193","id":201448293,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQ4Mjkz","html_url":"https://github.com/whitfin/cachex/pull/193","diff_url":"https://github.com/whitfin/cachex/pull/193.diff","patch_url":"https://github.com/whitfin/cachex/pull/193.patch","issue_url":"https://api.github.com/repos/whitfin/cachex/issues/193","number":193,"state":"open","locked":false,"title":"Fix a race that can result in unnecessary fallback executions","user":{"login":"ivan","id":4458,"node_id":"MDQ6VXNlcjQ0NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4458?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan","html_url":"https://github.com/ivan","followers_url":"https://api.github.com/users/ivan/followers","following_url":"https://api.github.com/users/ivan/following{/other_user}","gists_url":"https://api.github.com/users/ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan/subscriptions","organizations_url":"https://api.github.com/users/ivan/orgs","repos_url":"https://api.github.com/users/ivan/repos","events_url":"https://api.github.com/users/ivan/events{/privacy}","received_events_url":"https://api.github.com/users/ivan/received_events","type":"User","site_admin":false},"body":"This fixes #192.\r\n\r\nI confirmed that the new test fails with `lib/cachex/services/courier.ex` from the previous commit, e719293bbd80c8b17b8af4e5e79102ed74ef84a7.","created_at":"2018-07-14T11:40:57Z","updated_at":"2018-07-14T21:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7620857df20a70ffb8e3d0fc18aac01a5b46060b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/whitfin/cachex/pulls/193/commits","review_comments_url":"https://api.github.com/repos/whitfin/cachex/pulls/193/comments","review_comment_url":"https://api.github.com/repos/whitfin/cachex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whitfin/cachex/issues/193/comments","statuses_url":"https://api.github.com/repos/whitfin/cachex/statuses/7372f28badcc910d5a6c57760ffbfa2a96221bb3","head":{"label":"ivan:fix-fallback-race","ref":"fix-fallback-race","sha":"7372f28badcc910d5a6c57760ffbfa2a96221bb3","user":{"login":"ivan","id":4458,"node_id":"MDQ6VXNlcjQ0NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4458?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan","html_url":"https://github.com/ivan","followers_url":"https://api.github.com/users/ivan/followers","following_url":"https://api.github.com/users/ivan/following{/other_user}","gists_url":"https://api.github.com/users/ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan/subscriptions","organizations_url":"https://api.github.com/users/ivan/orgs","repos_url":"https://api.github.com/users/ivan/repos","events_url":"https://api.github.com/users/ivan/events{/privacy}","received_events_url":"https://api.github.com/users/ivan/received_events","type":"User","site_admin":false},"repo":{"id":140813620,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4MTM2MjA=","name":"cachex","full_name":"ivan/cachex","owner":{"login":"ivan","id":4458,"node_id":"MDQ6VXNlcjQ0NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4458?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan","html_url":"https://github.com/ivan","followers_url":"https://api.github.com/users/ivan/followers","following_url":"https://api.github.com/users/ivan/following{/other_user}","gists_url":"https://api.github.com/users/ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan/subscriptions","organizations_url":"https://api.github.com/users/ivan/orgs","repos_url":"https://api.github.com/users/ivan/repos","events_url":"https://api.github.com/users/ivan/events{/privacy}","received_events_url":"https://api.github.com/users/ivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivan/cachex","description":"A powerful caching library for Elixir with support for transactions, fallbacks and expirations -","fork":true,"url":"https://api.github.com/repos/ivan/cachex","forks_url":"https://api.github.com/repos/ivan/cachex/forks","keys_url":"https://api.github.com/repos/ivan/cachex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivan/cachex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivan/cachex/teams","hooks_url":"https://api.github.com/repos/ivan/cachex/hooks","issue_events_url":"https://api.github.com/repos/ivan/cachex/issues/events{/number}","events_url":"https://api.github.com/repos/ivan/cachex/events","assignees_url":"https://api.github.com/repos/ivan/cachex/assignees{/user}","branches_url":"https://api.github.com/repos/ivan/cachex/branches{/branch}","tags_url":"https://api.github.com/repos/ivan/cachex/tags","blobs_url":"https://api.github.com/repos/ivan/cachex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivan/cachex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivan/cachex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivan/cachex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivan/cachex/statuses/{sha}","languages_url":"https://api.github.com/repos/ivan/cachex/languages","stargazers_url":"https://api.github.com/repos/ivan/cachex/stargazers","contributors_url":"https://api.github.com/repos/ivan/cachex/contributors","subscribers_url":"https://api.github.com/repos/ivan/cachex/subscribers","subscription_url":"https://api.github.com/repos/ivan/cachex/subscription","commits_url":"https://api.github.com/repos/ivan/cachex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivan/cachex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivan/cachex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivan/cachex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivan/cachex/contents/{+path}","compare_url":"https://api.github.com/repos/ivan/cachex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivan/cachex/merges","archive_url":"https://api.github.com/repos/ivan/cachex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivan/cachex/downloads","issues_url":"https://api.github.com/repos/ivan/cachex/issues{/number}","pulls_url":"https://api.github.com/repos/ivan/cachex/pulls{/number}","milestones_url":"https://api.github.com/repos/ivan/cachex/milestones{/number}","notifications_url":"https://api.github.com/repos/ivan/cachex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivan/cachex/labels{/name}","releases_url":"https://api.github.com/repos/ivan/cachex/releases{/id}","deployments_url":"https://api.github.com/repos/ivan/cachex/deployments","created_at":"2018-07-13T07:35:14Z","updated_at":"2018-07-13T07:35:16Z","pushed_at":"2018-07-14T12:14:28Z","git_url":"git://github.com/ivan/cachex.git","ssh_url":"git@github.com:ivan/cachex.git","clone_url":"https://github.com/ivan/cachex.git","svn_url":"https://github.com/ivan/cachex","homepage":"https://hexdocs.pm/cachex/","size":1054,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whitfin:master","ref":"master","sha":"e719293bbd80c8b17b8af4e5e79102ed74ef84a7","user":{"login":"whitfin","id":5376378,"node_id":"MDQ6VXNlcjUzNzYzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5376378?v=4","gravatar_id":"","url":"https://api.github.com/users/whitfin","html_url":"https://github.com/whitfin","followers_url":"https://api.github.com/users/whitfin/followers","following_url":"https://api.github.com/users/whitfin/following{/other_user}","gists_url":"https://api.github.com/users/whitfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whitfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitfin/subscriptions","organizations_url":"https://api.github.com/users/whitfin/orgs","repos_url":"https://api.github.com/users/whitfin/repos","events_url":"https://api.github.com/users/whitfin/events{/privacy}","received_events_url":"https://api.github.com/users/whitfin/received_events","type":"User","site_admin":false},"repo":{"id":51771177,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc3MTE3Nw==","name":"cachex","full_name":"whitfin/cachex","owner":{"login":"whitfin","id":5376378,"node_id":"MDQ6VXNlcjUzNzYzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5376378?v=4","gravatar_id":"","url":"https://api.github.com/users/whitfin","html_url":"https://github.com/whitfin","followers_url":"https://api.github.com/users/whitfin/followers","following_url":"https://api.github.com/users/whitfin/following{/other_user}","gists_url":"https://api.github.com/users/whitfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whitfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitfin/subscriptions","organizations_url":"https://api.github.com/users/whitfin/orgs","repos_url":"https://api.github.com/users/whitfin/repos","events_url":"https://api.github.com/users/whitfin/events{/privacy}","received_events_url":"https://api.github.com/users/whitfin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whitfin/cachex","description":"A powerful caching library for Elixir with support for transactions, fallbacks and expirations -","fork":false,"url":"https://api.github.com/repos/whitfin/cachex","forks_url":"https://api.github.com/repos/whitfin/cachex/forks","keys_url":"https://api.github.com/repos/whitfin/cachex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whitfin/cachex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whitfin/cachex/teams","hooks_url":"https://api.github.com/repos/whitfin/cachex/hooks","issue_events_url":"https://api.github.com/repos/whitfin/cachex/issues/events{/number}","events_url":"https://api.github.com/repos/whitfin/cachex/events","assignees_url":"https://api.github.com/repos/whitfin/cachex/assignees{/user}","branches_url":"https://api.github.com/repos/whitfin/cachex/branches{/branch}","tags_url":"https://api.github.com/repos/whitfin/cachex/tags","blobs_url":"https://api.github.com/repos/whitfin/cachex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whitfin/cachex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whitfin/cachex/git/refs{/sha}","trees_url":"https://api.github.com/repos/whitfin/cachex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whitfin/cachex/statuses/{sha}","languages_url":"https://api.github.com/repos/whitfin/cachex/languages","stargazers_url":"https://api.github.com/repos/whitfin/cachex/stargazers","contributors_url":"https://api.github.com/repos/whitfin/cachex/contributors","subscribers_url":"https://api.github.com/repos/whitfin/cachex/subscribers","subscription_url":"https://api.github.com/repos/whitfin/cachex/subscription","commits_url":"https://api.github.com/repos/whitfin/cachex/commits{/sha}","git_commits_url":"https://api.github.com/repos/whitfin/cachex/git/commits{/sha}","comments_url":"https://api.github.com/repos/whitfin/cachex/comments{/number}","issue_comment_url":"https://api.github.com/repos/whitfin/cachex/issues/comments{/number}","contents_url":"https://api.github.com/repos/whitfin/cachex/contents/{+path}","compare_url":"https://api.github.com/repos/whitfin/cachex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whitfin/cachex/merges","archive_url":"https://api.github.com/repos/whitfin/cachex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whitfin/cachex/downloads","issues_url":"https://api.github.com/repos/whitfin/cachex/issues{/number}","pulls_url":"https://api.github.com/repos/whitfin/cachex/pulls{/number}","milestones_url":"https://api.github.com/repos/whitfin/cachex/milestones{/number}","notifications_url":"https://api.github.com/repos/whitfin/cachex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whitfin/cachex/labels{/name}","releases_url":"https://api.github.com/repos/whitfin/cachex/releases{/id}","deployments_url":"https://api.github.com/repos/whitfin/cachex/deployments","created_at":"2016-02-15T17:06:20Z","updated_at":"2018-07-13T17:05:01Z","pushed_at":"2018-07-14T12:14:30Z","git_url":"git://github.com/whitfin/cachex.git","ssh_url":"git@github.com:whitfin/cachex.git","clone_url":"https://github.com/whitfin/cachex.git","svn_url":"https://github.com/whitfin/cachex","homepage":"https://hexdocs.pm/cachex/","size":1052,"stargazers_count":469,"watchers_count":469,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":4,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/193"},"html":{"href":"https://github.com/whitfin/cachex/pull/193"},"issue":{"href":"https://api.github.com/repos/whitfin/cachex/issues/193"},"comments":{"href":"https://api.github.com/repos/whitfin/cachex/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whitfin/cachex/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/whitfin/cachex/statuses/7372f28badcc910d5a6c57760ffbfa2a96221bb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"whitfin"}}