{"action":"created","comment":{"url":"https://api.github.com/repos/TricksterGuy/complx/pulls/comments/219706256","pull_request_review_id":157946663,"id":219706256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcwNjI1Ng==","diff_hunk":"@@ -1,6 +1,7 @@\n import lc3_unit_test_case\n import unittest\n-\n+import xmlrunner","path":"pylc3/unittest/lc3_unit_test_case_test.py","position":4,"original_position":4,"commit_id":"c0cfe300b2e33e2c9d3c96542495a568065c3f31","original_commit_id":"46010c7d138186e30ded5a6fdebac48d5e7d7578","user":{"login":"skyman","id":1408354,"node_id":"MDQ6VXNlcjE0MDgzNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1408354?v=4","gravatar_id":"","url":"https://api.github.com/users/skyman","html_url":"https://github.com/skyman","followers_url":"https://api.github.com/users/skyman/followers","following_url":"https://api.github.com/users/skyman/following{/other_user}","gists_url":"https://api.github.com/users/skyman/gists{/gist_id}","starred_url":"https://api.github.com/users/skyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyman/subscriptions","organizations_url":"https://api.github.com/users/skyman/orgs","repos_url":"https://api.github.com/users/skyman/repos","events_url":"https://api.github.com/users/skyman/events{/privacy}","received_events_url":"https://api.github.com/users/skyman/received_events","type":"User","site_admin":false},"body":"Not really, no. I'll remove that.","created_at":"2018-09-23T17:55:45Z","updated_at":"2018-09-23T17:55:45Z","html_url":"https://github.com/TricksterGuy/complx/pull/113#discussion_r219706256","pull_request_url":"https://api.github.com/repos/TricksterGuy/complx/pulls/113","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/comments/219706256"},"html":{"href":"https://github.com/TricksterGuy/complx/pull/113#discussion_r219706256"},"pull_request":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/113"}},"in_reply_to_id":219706241},"pull_request":{"url":"https://api.github.com/repos/TricksterGuy/complx/pulls/113","id":217520669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTIwNjY5","html_url":"https://github.com/TricksterGuy/complx/pull/113","diff_url":"https://github.com/TricksterGuy/complx/pull/113.diff","patch_url":"https://github.com/TricksterGuy/complx/pull/113.patch","issue_url":"https://api.github.com/repos/TricksterGuy/complx/issues/113","number":113,"state":"open","locked":false,"title":"pyLC3 deployment edits","user":{"login":"skyman","id":1408354,"node_id":"MDQ6VXNlcjE0MDgzNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1408354?v=4","gravatar_id":"","url":"https://api.github.com/users/skyman","html_url":"https://github.com/skyman","followers_url":"https://api.github.com/users/skyman/followers","following_url":"https://api.github.com/users/skyman/following{/other_user}","gists_url":"https://api.github.com/users/skyman/gists{/gist_id}","starred_url":"https://api.github.com/users/skyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyman/subscriptions","organizations_url":"https://api.github.com/users/skyman/orgs","repos_url":"https://api.github.com/users/skyman/repos","events_url":"https://api.github.com/users/skyman/events{/privacy}","received_events_url":"https://api.github.com/users/skyman/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis PR does the following:\r\n\r\n- Make as2obj, lc3runner etc optional through an enable flag\r\n- Make UI plugins compile only when complx is compiled\r\n- Support scikit-build builds for pylc3 as a python extension\r\n- Make castXML path configurable (through CMake cache variable) useful for Macs\r\n- Use six for python 2-3 differences\r\n- Add requirements files\r\n- Rewrite install.sh file for python dependencies\r\n\r\nWhen merged these allow for easy installation through a PyPI package onto any Python environment both on Linux and Mac.","created_at":"2018-09-23T17:25:57Z","updated_at":"2018-09-23T17:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbbdd80010c75e679b37903fb1d97639c082e36e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TricksterGuy/complx/pulls/113/commits","review_comments_url":"https://api.github.com/repos/TricksterGuy/complx/pulls/113/comments","review_comment_url":"https://api.github.com/repos/TricksterGuy/complx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TricksterGuy/complx/issues/113/comments","statuses_url":"https://api.github.com/repos/TricksterGuy/complx/statuses/c0cfe300b2e33e2c9d3c96542495a568065c3f31","head":{"label":"skyman:master","ref":"master","sha":"c0cfe300b2e33e2c9d3c96542495a568065c3f31","user":{"login":"skyman","id":1408354,"node_id":"MDQ6VXNlcjE0MDgzNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1408354?v=4","gravatar_id":"","url":"https://api.github.com/users/skyman","html_url":"https://github.com/skyman","followers_url":"https://api.github.com/users/skyman/followers","following_url":"https://api.github.com/users/skyman/following{/other_user}","gists_url":"https://api.github.com/users/skyman/gists{/gist_id}","starred_url":"https://api.github.com/users/skyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyman/subscriptions","organizations_url":"https://api.github.com/users/skyman/orgs","repos_url":"https://api.github.com/users/skyman/repos","events_url":"https://api.github.com/users/skyman/events{/privacy}","received_events_url":"https://api.github.com/users/skyman/received_events","type":"User","site_admin":false},"repo":{"id":149362505,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjI1MDU=","name":"complx","full_name":"skyman/complx","private":false,"owner":{"login":"skyman","id":1408354,"node_id":"MDQ6VXNlcjE0MDgzNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1408354?v=4","gravatar_id":"","url":"https://api.github.com/users/skyman","html_url":"https://github.com/skyman","followers_url":"https://api.github.com/users/skyman/followers","following_url":"https://api.github.com/users/skyman/following{/other_user}","gists_url":"https://api.github.com/users/skyman/gists{/gist_id}","starred_url":"https://api.github.com/users/skyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyman/subscriptions","organizations_url":"https://api.github.com/users/skyman/orgs","repos_url":"https://api.github.com/users/skyman/repos","events_url":"https://api.github.com/users/skyman/events{/privacy}","received_events_url":"https://api.github.com/users/skyman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skyman/complx","description":"Extensible LC-3 Simulator (GUI and CLI), Assembler, and Autograder/Test Framework written in C++.  Mainly used in CS2110 at Georgia Tech","fork":true,"url":"https://api.github.com/repos/skyman/complx","forks_url":"https://api.github.com/repos/skyman/complx/forks","keys_url":"https://api.github.com/repos/skyman/complx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyman/complx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyman/complx/teams","hooks_url":"https://api.github.com/repos/skyman/complx/hooks","issue_events_url":"https://api.github.com/repos/skyman/complx/issues/events{/number}","events_url":"https://api.github.com/repos/skyman/complx/events","assignees_url":"https://api.github.com/repos/skyman/complx/assignees{/user}","branches_url":"https://api.github.com/repos/skyman/complx/branches{/branch}","tags_url":"https://api.github.com/repos/skyman/complx/tags","blobs_url":"https://api.github.com/repos/skyman/complx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyman/complx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyman/complx/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyman/complx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyman/complx/statuses/{sha}","languages_url":"https://api.github.com/repos/skyman/complx/languages","stargazers_url":"https://api.github.com/repos/skyman/complx/stargazers","contributors_url":"https://api.github.com/repos/skyman/complx/contributors","subscribers_url":"https://api.github.com/repos/skyman/complx/subscribers","subscription_url":"https://api.github.com/repos/skyman/complx/subscription","commits_url":"https://api.github.com/repos/skyman/complx/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyman/complx/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyman/complx/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyman/complx/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyman/complx/contents/{+path}","compare_url":"https://api.github.com/repos/skyman/complx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyman/complx/merges","archive_url":"https://api.github.com/repos/skyman/complx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyman/complx/downloads","issues_url":"https://api.github.com/repos/skyman/complx/issues{/number}","pulls_url":"https://api.github.com/repos/skyman/complx/pulls{/number}","milestones_url":"https://api.github.com/repos/skyman/complx/milestones{/number}","notifications_url":"https://api.github.com/repos/skyman/complx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyman/complx/labels{/name}","releases_url":"https://api.github.com/repos/skyman/complx/releases{/id}","deployments_url":"https://api.github.com/repos/skyman/complx/deployments","created_at":"2018-09-18T23:05:13Z","updated_at":"2018-09-23T17:54:37Z","pushed_at":"2018-09-23T17:54:35Z","git_url":"git://github.com/skyman/complx.git","ssh_url":"git@github.com:skyman/complx.git","clone_url":"https://github.com/skyman/complx.git","svn_url":"https://github.com/skyman/complx","homepage":"","size":9207,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TricksterGuy:master","ref":"master","sha":"cb3cfd19fd7ba092d1dfde94d53d368d6356a2e6","user":{"login":"TricksterGuy","id":824564,"node_id":"MDQ6VXNlcjgyNDU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/824564?v=4","gravatar_id":"","url":"https://api.github.com/users/TricksterGuy","html_url":"https://github.com/TricksterGuy","followers_url":"https://api.github.com/users/TricksterGuy/followers","following_url":"https://api.github.com/users/TricksterGuy/following{/other_user}","gists_url":"https://api.github.com/users/TricksterGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/TricksterGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TricksterGuy/subscriptions","organizations_url":"https://api.github.com/users/TricksterGuy/orgs","repos_url":"https://api.github.com/users/TricksterGuy/repos","events_url":"https://api.github.com/users/TricksterGuy/events{/privacy}","received_events_url":"https://api.github.com/users/TricksterGuy/received_events","type":"User","site_admin":false},"repo":{"id":12988956,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4ODk1Ng==","name":"complx","full_name":"TricksterGuy/complx","private":false,"owner":{"login":"TricksterGuy","id":824564,"node_id":"MDQ6VXNlcjgyNDU2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/824564?v=4","gravatar_id":"","url":"https://api.github.com/users/TricksterGuy","html_url":"https://github.com/TricksterGuy","followers_url":"https://api.github.com/users/TricksterGuy/followers","following_url":"https://api.github.com/users/TricksterGuy/following{/other_user}","gists_url":"https://api.github.com/users/TricksterGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/TricksterGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TricksterGuy/subscriptions","organizations_url":"https://api.github.com/users/TricksterGuy/orgs","repos_url":"https://api.github.com/users/TricksterGuy/repos","events_url":"https://api.github.com/users/TricksterGuy/events{/privacy}","received_events_url":"https://api.github.com/users/TricksterGuy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TricksterGuy/complx","description":"Extensible LC-3 Simulator (GUI and CLI), Assembler, and Autograder/Test Framework written in C++.  Mainly used in CS2110 at Georgia Tech","fork":false,"url":"https://api.github.com/repos/TricksterGuy/complx","forks_url":"https://api.github.com/repos/TricksterGuy/complx/forks","keys_url":"https://api.github.com/repos/TricksterGuy/complx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TricksterGuy/complx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TricksterGuy/complx/teams","hooks_url":"https://api.github.com/repos/TricksterGuy/complx/hooks","issue_events_url":"https://api.github.com/repos/TricksterGuy/complx/issues/events{/number}","events_url":"https://api.github.com/repos/TricksterGuy/complx/events","assignees_url":"https://api.github.com/repos/TricksterGuy/complx/assignees{/user}","branches_url":"https://api.github.com/repos/TricksterGuy/complx/branches{/branch}","tags_url":"https://api.github.com/repos/TricksterGuy/complx/tags","blobs_url":"https://api.github.com/repos/TricksterGuy/complx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TricksterGuy/complx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TricksterGuy/complx/git/refs{/sha}","trees_url":"https://api.github.com/repos/TricksterGuy/complx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TricksterGuy/complx/statuses/{sha}","languages_url":"https://api.github.com/repos/TricksterGuy/complx/languages","stargazers_url":"https://api.github.com/repos/TricksterGuy/complx/stargazers","contributors_url":"https://api.github.com/repos/TricksterGuy/complx/contributors","subscribers_url":"https://api.github.com/repos/TricksterGuy/complx/subscribers","subscription_url":"https://api.github.com/repos/TricksterGuy/complx/subscription","commits_url":"https://api.github.com/repos/TricksterGuy/complx/commits{/sha}","git_commits_url":"https://api.github.com/repos/TricksterGuy/complx/git/commits{/sha}","comments_url":"https://api.github.com/repos/TricksterGuy/complx/comments{/number}","issue_comment_url":"https://api.github.com/repos/TricksterGuy/complx/issues/comments{/number}","contents_url":"https://api.github.com/repos/TricksterGuy/complx/contents/{+path}","compare_url":"https://api.github.com/repos/TricksterGuy/complx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TricksterGuy/complx/merges","archive_url":"https://api.github.com/repos/TricksterGuy/complx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TricksterGuy/complx/downloads","issues_url":"https://api.github.com/repos/TricksterGuy/complx/issues{/number}","pulls_url":"https://api.github.com/repos/TricksterGuy/complx/pulls{/number}","milestones_url":"https://api.github.com/repos/TricksterGuy/complx/milestones{/number}","notifications_url":"https://api.github.com/repos/TricksterGuy/complx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TricksterGuy/complx/labels{/name}","releases_url":"https://api.github.com/repos/TricksterGuy/complx/releases{/id}","deployments_url":"https://api.github.com/repos/TricksterGuy/complx/deployments","created_at":"2013-09-21T03:45:26Z","updated_at":"2018-09-18T01:54:04Z","pushed_at":"2018-09-23T17:54:37Z","git_url":"git://github.com/TricksterGuy/complx.git","ssh_url":"git@github.com:TricksterGuy/complx.git","clone_url":"https://github.com/TricksterGuy/complx.git","svn_url":"https://github.com/TricksterGuy/complx","homepage":"","size":9169,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":22,"open_issues":31,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/113"},"html":{"href":"https://github.com/TricksterGuy/complx/pull/113"},"issue":{"href":"https://api.github.com/repos/TricksterGuy/complx/issues/113"},"comments":{"href":"https://api.github.com/repos/TricksterGuy/complx/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TricksterGuy/complx/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/TricksterGuy/complx/statuses/c0cfe300b2e33e2c9d3c96542495a568065c3f31"}},"author_association":"NONE"}}
{"actor":{"display_login":"skyman"}}