{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-router/issues/307","repository_url":"https://api.github.com/repos/vaadin/vaadin-router","labels_url":"https://api.github.com/repos/vaadin/vaadin-router/issues/307/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-router/issues/307/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-router/issues/307/events","html_url":"https://github.com/vaadin/vaadin-router/issues/307","id":379307780,"node_id":"MDU6SXNzdWUzNzkzMDc3ODA=","number":307,"title":"\"page not found\" when the matching route is not under the first matching parent","user":{"login":"vlukashov","id":22416150,"node_id":"MDQ6VXNlcjIyNDE2MTUw","avatar_url":"https://avatars3.githubusercontent.com/u/22416150?v=4","gravatar_id":"","url":"https://api.github.com/users/vlukashov","html_url":"https://github.com/vlukashov","followers_url":"https://api.github.com/users/vlukashov/followers","following_url":"https://api.github.com/users/vlukashov/following{/other_user}","gists_url":"https://api.github.com/users/vlukashov/gists{/gist_id}","starred_url":"https://api.github.com/users/vlukashov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlukashov/subscriptions","organizations_url":"https://api.github.com/users/vlukashov/orgs","repos_url":"https://api.github.com/users/vlukashov/repos","events_url":"https://api.github.com/users/vlukashov/events{/privacy}","received_events_url":"https://api.github.com/users/vlukashov/received_events","type":"User","site_admin":false},"labels":[{"id":872025648,"node_id":"MDU6TGFiZWw4NzIwMjU2NDg=","url":"https://api.github.com/repos/vaadin/vaadin-router/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-09T20:18:42Z","updated_at":"2018-11-21T22:53:11Z","closed_at":null,"author_association":"COLLABORATOR","body":"With the routes config below Vaadin Router should render `<x-layout-b><x-b></x-b></x-layout-b>` for the `/b` pathname. However, currently it throws `Error: [Vaadin.Router] Page not found (/b)`.\r\n\r\n```javascript\r\n// describe('parent layouts rendering', () => {\r\nit('should render the matching child route even if it is not under the first matching parent', async() => {\r\n  router.setRoutes([\r\n    {\r\n      path: '/',\r\n      component: 'x-layout-a',\r\n      children: [\r\n        { path: '/a', component: 'x-a' },\r\n      ]\r\n    },\r\n    {\r\n      path: '/',\r\n      component: 'x-layout-b',\r\n      children: [\r\n        { path: '/b', component: 'x-b', }\r\n      ]\r\n    },\r\n  ]);\r\n\r\n  await router.render('/b');\r\n\r\n  verifyActiveRoutes(router, ['/', '/b']);\r\n  checkOutlet(['x-layout-b', 'x-b']);\r\n});\r\n```"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-router/issues/comments/440838254","html_url":"https://github.com/vaadin/vaadin-router/issues/307#issuecomment-440838254","issue_url":"https://api.github.com/repos/vaadin/vaadin-router/issues/307","id":440838254,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDgzODI1NA==","user":{"login":"ZempTime","id":3596468,"node_id":"MDQ6VXNlcjM1OTY0Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/3596468?v=4","gravatar_id":"","url":"https://api.github.com/users/ZempTime","html_url":"https://github.com/ZempTime","followers_url":"https://api.github.com/users/ZempTime/followers","following_url":"https://api.github.com/users/ZempTime/following{/other_user}","gists_url":"https://api.github.com/users/ZempTime/gists{/gist_id}","starred_url":"https://api.github.com/users/ZempTime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZempTime/subscriptions","organizations_url":"https://api.github.com/users/ZempTime/orgs","repos_url":"https://api.github.com/users/ZempTime/repos","events_url":"https://api.github.com/users/ZempTime/events{/privacy}","received_events_url":"https://api.github.com/users/ZempTime/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T22:53:11Z","updated_at":"2018-11-21T22:53:11Z","author_association":"NONE","body":"Right [here](https://github.com/vaadin/vaadin-router/blob/master/src/resolver/resolver.js#L146) it will match correctly against `/b` child route, then `parent` will override `matches.value.route` and set it back to an `/a`-related route object"}}
{"actor":{"display_login":"ZempTime"}}