{"action":"created","comment":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/comments/176584738","pull_request_review_id":106316968,"id":176584738,"diff_hunk":"@@ -62,10 +63,11 @@ pub struct Histogram {\n     /// Array of buckets in which to count latencies.\n     ///\n     /// The upper bound of a given bucket `i` is given in `BUCKET_BOUNDS[i]`.\n-    buckets: [u32; NUM_BUCKETS],\n+    // TODO: consider using `prometheus::Counter` rather than `Wrapping<u32>`?\n+    buckets: [Wrapping<u32>; NUM_BUCKETS],","path":"proxy/src/telemetry/metrics/latency.rs","position":15,"original_position":15,"commit_id":"9f09545b72bccfce692de1cafc1359ee427ed52f","original_commit_id":"9f09545b72bccfce692de1cafc1359ee427ed52f","user":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"body":"The histogram bucket counts were made 32-bits initially because this is how they were defined in the push metrics protobuf IDL, to reduce wire size.\r\n\r\nI'd be happy to make them 64-bit values as well when the push metrics reporter is removed. I suppose I could also modify the push metrics reporter to accept 64-bit counts and cast them to `u32`, but I'd prefer to not touch that code at all, as it's slated to be removed very soon.","created_at":"2018-03-22T21:58:34Z","updated_at":"2018-03-22T21:58:34Z","html_url":"https://github.com/runconduit/conduit/pull/603#discussion_r176584738","pull_request_url":"https://api.github.com/repos/runconduit/conduit/pulls/603","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments/176584738"},"html":{"href":"https://github.com/runconduit/conduit/pull/603#discussion_r176584738"},"pull_request":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/603"}},"in_reply_to_id":176568356},"pull_request":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/603","id":176894710,"html_url":"https://github.com/runconduit/conduit/pull/603","diff_url":"https://github.com/runconduit/conduit/pull/603.diff","patch_url":"https://github.com/runconduit/conduit/pull/603.patch","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/603","number":603,"state":"open","locked":false,"title":"All counters in proxy telemetry wrap on overflows","user":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"body":"In #602, @olix0r suggested that telemetry counters should wrap on overflows, as \"most timeseries systems (like prometheus) are designed to handle this case gracefully.\"\r\n\r\nThis PR changes counters to use explicitly wrapping arithmetic.\r\n\r\nCloses #602.","created_at":"2018-03-22T20:05:53Z","updated_at":"2018-03-22T21:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4b9b97fddf7db320ea797324e7cf13fc1fb888f","assignee":{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"assignees":[{"login":"hawkw","id":2796466,"avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"olix0r","id":240738,"avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},{"login":"adleong","id":3979810,"avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":773709989,"url":"https://api.github.com/repos/runconduit/conduit/labels/area/proxy","name":"area/proxy","color":"0052CC","default":false},{"id":846665358,"url":"https://api.github.com/repos/runconduit/conduit/labels/area/telemetry","name":"area/telemetry","color":"0052CC","default":false},{"id":866158135,"url":"https://api.github.com/repos/runconduit/conduit/labels/review","name":"review","color":"f4bffc","default":false}],"milestone":{"url":"https://api.github.com/repos/runconduit/conduit/milestones/6","html_url":"https://github.com/runconduit/conduit/milestone/6","labels_url":"https://api.github.com/repos/runconduit/conduit/milestones/6/labels","id":3106026,"number":6,"title":"0.4.0","description":"Automatic TLS; Prometheus++","creator":{"login":"wmorgan","id":4026,"avatar_url":"https://avatars0.githubusercontent.com/u/4026?v=4","gravatar_id":"","url":"https://api.github.com/users/wmorgan","html_url":"https://github.com/wmorgan","followers_url":"https://api.github.com/users/wmorgan/followers","following_url":"https://api.github.com/users/wmorgan/following{/other_user}","gists_url":"https://api.github.com/users/wmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmorgan/subscriptions","organizations_url":"https://api.github.com/users/wmorgan/orgs","repos_url":"https://api.github.com/users/wmorgan/repos","events_url":"https://api.github.com/users/wmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/wmorgan/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":23,"state":"open","created_at":"2018-02-11T18:30:59Z","updated_at":"2018-03-22T21:17:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/runconduit/conduit/pulls/603/commits","review_comments_url":"https://api.github.com/repos/runconduit/conduit/pulls/603/comments","review_comment_url":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/603/comments","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/9f09545b72bccfce692de1cafc1359ee427ed52f","head":{"label":"runconduit:eliza/wrapping-counters","ref":"eliza/wrapping-counters","sha":"9f09545b72bccfce692de1cafc1359ee427ed52f","user":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-03-22T21:17:14Z","pushed_at":"2018-03-22T21:53:03Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":4057,"stargazers_count":1285,"watchers_count":1285,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":68,"open_issues":140,"watchers":1285,"default_branch":"master"}},"base":{"label":"runconduit:master","ref":"master","sha":"b90668a0b558c4d9a74a1f23dedd6cf5941a35e7","user":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-03-22T21:17:14Z","pushed_at":"2018-03-22T21:53:03Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":4057,"stargazers_count":1285,"watchers_count":1285,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":68,"open_issues":140,"watchers":1285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/603"},"html":{"href":"https://github.com/runconduit/conduit/pull/603"},"issue":{"href":"https://api.github.com/repos/runconduit/conduit/issues/603"},"comments":{"href":"https://api.github.com/repos/runconduit/conduit/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/runconduit/conduit/statuses/9f09545b72bccfce692de1cafc1359ee427ed52f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hawkw"}}