{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/161","repository_url":"https://api.github.com/repos/JuliaTime/TimeZones.jl","labels_url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/161/comments","events_url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/161/events","html_url":"https://github.com/JuliaTime/TimeZones.jl/pull/161","id":381162378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTk1Mzcz","number":161,"title":"Use runtime paths for TimeZones data","user":{"login":"green-nsk","id":8025586,"node_id":"MDQ6VXNlcjgwMjU1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8025586?v=4","gravatar_id":"","url":"https://api.github.com/users/green-nsk","html_url":"https://github.com/green-nsk","followers_url":"https://api.github.com/users/green-nsk/followers","following_url":"https://api.github.com/users/green-nsk/following{/other_user}","gists_url":"https://api.github.com/users/green-nsk/gists{/gist_id}","starred_url":"https://api.github.com/users/green-nsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/green-nsk/subscriptions","organizations_url":"https://api.github.com/users/green-nsk/orgs","repos_url":"https://api.github.com/users/green-nsk/repos","events_url":"https://api.github.com/users/green-nsk/events{/privacy}","received_events_url":"https://api.github.com/users/green-nsk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-15T13:32:29Z","updated_at":"2018-11-15T15:39:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/pulls/161","html_url":"https://github.com/JuliaTime/TimeZones.jl/pull/161","diff_url":"https://github.com/JuliaTime/TimeZones.jl/pull/161.diff","patch_url":"https://github.com/JuliaTime/TimeZones.jl/pull/161.patch"},"body":"We build an embedded julia image that is distributed across multiple machines. Fixing paths at precompilation time doesn't really work in this scenario and I couldn't find a better or less intrusive solution.\r\n\r\nOne possible option was to override constant paths in `__init__()`, but julia spits warnings at that and I couldn't really override all constants this way (namely some bits under TzData). Another alternative was to not define constants globally, and only define them in `__init__()`, but that would require even more extensive changes."},"comment":{"url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/comments/439083874","html_url":"https://github.com/JuliaTime/TimeZones.jl/pull/161#issuecomment-439083874","issue_url":"https://api.github.com/repos/JuliaTime/TimeZones.jl/issues/161","id":439083874,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA4Mzg3NA==","user":{"login":"green-nsk","id":8025586,"node_id":"MDQ6VXNlcjgwMjU1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8025586?v=4","gravatar_id":"","url":"https://api.github.com/users/green-nsk","html_url":"https://github.com/green-nsk","followers_url":"https://api.github.com/users/green-nsk/followers","following_url":"https://api.github.com/users/green-nsk/following{/other_user}","gists_url":"https://api.github.com/users/green-nsk/gists{/gist_id}","starred_url":"https://api.github.com/users/green-nsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/green-nsk/subscriptions","organizations_url":"https://api.github.com/users/green-nsk/orgs","repos_url":"https://api.github.com/users/green-nsk/repos","events_url":"https://api.github.com/users/green-nsk/events{/privacy}","received_events_url":"https://api.github.com/users/green-nsk/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T15:39:59Z","updated_at":"2018-11-15T15:39:59Z","author_association":"NONE","body":"I don't know if precise error message is meaningful because we're using an old version of the package. But we're hitting this exception due to PKG_PATH being build server path to julia: https://github.com/JuliaTime/TimeZones.jl/blob/master/src/TimeZones.jl#L70\r\n\r\nI'd be glad to replace Pkg.dir() call with something else, but `joinpath(@__DIR__, \"..\")` doesn't seem to cut it because again value of __DIR__ is picked up at precompile time and not valid at runtime.\r\n"}}
{"actor":{"display_login":"green-nsk"}}