{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/179810328","pull_request_review_id":110127965,"id":179810328,"diff_hunk":"@@ -39,10 +40,11 @@ To use this version of counting,\n Update in nGraph\n ================\n \n-We use the same approach with nGraph. During training, we include all\n-the weights as arguments to the training function and return the\n-updated weights along with any other results. If we are doing a more\n-complex form of training, such as using momentum, we would add the\n-momementum tensors are additional arguments and add their updated\n-values as additional results. The simple case is illiustrated in the\n-trainable model how to.\n+In working with nGraph-based construction of graphs, updating takes \n+the same approach. During training, we include all the weights as \n+arguments to the training function and return the updated weights \n+along with any other results. For more complex forms of training, \n+such as those using momentum, we would add the momementum tensors \n+as additional arguments and include their updated values as additional \n+results. A simple case is illiustrated in the documentation for how ","path":"doc/sphinx/source/howto/update.rst","position":45,"original_position":45,"commit_id":"55849e1b9e4aecf8f18c19b5092c46b61e39d7c1","original_commit_id":"55849e1b9e4aecf8f18c19b5092c46b61e39d7c1","user":{"login":"aprocter","id":680992,"avatar_url":"https://avatars3.githubusercontent.com/u/680992?v=4","gravatar_id":"","url":"https://api.github.com/users/aprocter","html_url":"https://github.com/aprocter","followers_url":"https://api.github.com/users/aprocter/followers","following_url":"https://api.github.com/users/aprocter/following{/other_user}","gists_url":"https://api.github.com/users/aprocter/gists{/gist_id}","starred_url":"https://api.github.com/users/aprocter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprocter/subscriptions","organizations_url":"https://api.github.com/users/aprocter/orgs","repos_url":"https://api.github.com/users/aprocter/repos","events_url":"https://api.github.com/users/aprocter/events{/privacy}","received_events_url":"https://api.github.com/users/aprocter/received_events","type":"User","site_admin":false},"body":"Typo: `illiustrated`","created_at":"2018-04-06T16:30:22Z","updated_at":"2018-04-06T16:49:33Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/813#discussion_r179810328","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/179810328"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/813#discussion_r179810328"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813","id":179498144,"html_url":"https://github.com/NervanaSystems/ngraph/pull/813","diff_url":"https://github.com/NervanaSystems/ngraph/pull/813.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/813.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/813","number":813,"state":"open","locked":false,"title":"Editing so far for review and feedback","user":{"login":"indie","id":50558,"avatar_url":"https://avatars0.githubusercontent.com/u/50558?v=4","gravatar_id":"","url":"https://api.github.com/users/indie","html_url":"https://github.com/indie","followers_url":"https://api.github.com/users/indie/followers","following_url":"https://api.github.com/users/indie/following{/other_user}","gists_url":"https://api.github.com/users/indie/gists{/gist_id}","starred_url":"https://api.github.com/users/indie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indie/subscriptions","organizations_url":"https://api.github.com/users/indie/orgs","repos_url":"https://api.github.com/users/indie/repos","events_url":"https://api.github.com/users/indie/events{/privacy}","received_events_url":"https://api.github.com/users/indie/received_events","type":"User","site_admin":false},"body":"This is a more in-depth review / edit of the new content added to documentation recently in our \"How to\" section.  ","created_at":"2018-04-04T20:07:10Z","updated_at":"2018-04-06T16:49:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f7891d40ea42b18b51a6d155413b6ab9e28cdd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/813/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/55849e1b9e4aecf8f18c19b5092c46b61e39d7c1","head":{"label":"NervanaSystems:leona/04_04","ref":"leona/04_04","sha":"55849e1b9e4aecf8f18c19b5092c46b61e39d7c1","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-04-06T15:04:26Z","pushed_at":"2018-04-06T15:56:42Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":36821,"stargazers_count":347,"watchers_count":347,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":27,"watchers":347,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"ddcfbda836f9e3b337214ec368e08a8f9353995a","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"name":"ngraph","full_name":"NervanaSystems/ngraph","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-04-06T15:04:26Z","pushed_at":"2018-04-06T15:56:42Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":36821,"stargazers_count":347,"watchers_count":347,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":27,"watchers":347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/813"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/813"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/55849e1b9e4aecf8f18c19b5092c46b61e39d7c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aprocter"}}