{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments/189096120","pull_request_review_id":121210164,"id":189096120,"diff_hunk":"@@ -202,3 +203,25 @@ func (c Comments) getTags(name, sep string) []string {\n \t}\n \treturn tags\n }\n+\n+// parseByteValue returns the literal digital number values from a byte array\n+func parseByteValue(b []byte) string {\n+\tres := \"\"\n+\telem := fmt.Sprintf(\"%v\", b)","path":"cmd/internal/codegen/parse/util.go","position":21,"original_position":16,"commit_id":"4746c85249ff664124bb160c8c96e735698a3475","original_commit_id":"23884392d98c98e35927269cd07c477008305bfa","user":{"login":"anfernee","id":174200,"avatar_url":"https://avatars3.githubusercontent.com/u/174200?v=4","gravatar_id":"","url":"https://api.github.com/users/anfernee","html_url":"https://github.com/anfernee","followers_url":"https://api.github.com/users/anfernee/followers","following_url":"https://api.github.com/users/anfernee/following{/other_user}","gists_url":"https://api.github.com/users/anfernee/gists{/gist_id}","starred_url":"https://api.github.com/users/anfernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anfernee/subscriptions","organizations_url":"https://api.github.com/users/anfernee/orgs","repos_url":"https://api.github.com/users/anfernee/repos","events_url":"https://api.github.com/users/anfernee/events{/privacy}","received_events_url":"https://api.github.com/users/anfernee/received_events","type":"User","site_admin":false},"body":"@fanzhangio I think you do the this without calling `fmt.Printf` where you assume the fmt format is like `[n n n n]`, which is pretty unreliable and less efficient. Here you simply need to print out the number and connect them with commas. ","created_at":"2018-05-17T20:47:45Z","updated_at":"2018-05-17T20:47:46Z","html_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/150#discussion_r189096120","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments/189096120"},"html":{"href":"https://github.com/kubernetes-sigs/kubebuilder/pull/150#discussion_r189096120"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150"}},"in_reply_to_id":188759220},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150","id":187889593,"html_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/150","diff_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/150.diff","patch_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/150.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/150","number":150,"state":"open","locked":false,"title":"Add more support for CRD validation","user":{"login":"fanzhangio","id":22812247,"avatar_url":"https://avatars3.githubusercontent.com/u/22812247?v=4","gravatar_id":"","url":"https://api.github.com/users/fanzhangio","html_url":"https://github.com/fanzhangio","followers_url":"https://api.github.com/users/fanzhangio/followers","following_url":"https://api.github.com/users/fanzhangio/following{/other_user}","gists_url":"https://api.github.com/users/fanzhangio/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzhangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzhangio/subscriptions","organizations_url":"https://api.github.com/users/fanzhangio/orgs","repos_url":"https://api.github.com/users/fanzhangio/repos","events_url":"https://api.github.com/users/fanzhangio/events{/privacy}","received_events_url":"https://api.github.com/users/fanzhangio/received_events","type":"User","site_admin":false},"body":"#128 ","created_at":"2018-05-14T16:55:19Z","updated_at":"2018-05-17T20:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feb34329ac6bb36fe3aae7c7a5f87ff5d39174f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":867761741,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":869731433,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/150/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/4746c85249ff664124bb160c8c96e735698a3475","head":{"label":"fanzhangio:issue128","ref":"issue128","sha":"4746c85249ff664124bb160c8c96e735698a3475","user":{"login":"fanzhangio","id":22812247,"avatar_url":"https://avatars3.githubusercontent.com/u/22812247?v=4","gravatar_id":"","url":"https://api.github.com/users/fanzhangio","html_url":"https://github.com/fanzhangio","followers_url":"https://api.github.com/users/fanzhangio/followers","following_url":"https://api.github.com/users/fanzhangio/following{/other_user}","gists_url":"https://api.github.com/users/fanzhangio/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzhangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzhangio/subscriptions","organizations_url":"https://api.github.com/users/fanzhangio/orgs","repos_url":"https://api.github.com/users/fanzhangio/repos","events_url":"https://api.github.com/users/fanzhangio/events{/privacy}","received_events_url":"https://api.github.com/users/fanzhangio/received_events","type":"User","site_admin":false},"repo":{"id":128004650,"name":"kubebuilder","full_name":"fanzhangio/kubebuilder","owner":{"login":"fanzhangio","id":22812247,"avatar_url":"https://avatars3.githubusercontent.com/u/22812247?v=4","gravatar_id":"","url":"https://api.github.com/users/fanzhangio","html_url":"https://github.com/fanzhangio","followers_url":"https://api.github.com/users/fanzhangio/followers","following_url":"https://api.github.com/users/fanzhangio/following{/other_user}","gists_url":"https://api.github.com/users/fanzhangio/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzhangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzhangio/subscriptions","organizations_url":"https://api.github.com/users/fanzhangio/orgs","repos_url":"https://api.github.com/users/fanzhangio/repos","events_url":"https://api.github.com/users/fanzhangio/events{/privacy}","received_events_url":"https://api.github.com/users/fanzhangio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fanzhangio/kubebuilder","description":"Kubebuilder","fork":true,"url":"https://api.github.com/repos/fanzhangio/kubebuilder","forks_url":"https://api.github.com/repos/fanzhangio/kubebuilder/forks","keys_url":"https://api.github.com/repos/fanzhangio/kubebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanzhangio/kubebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanzhangio/kubebuilder/teams","hooks_url":"https://api.github.com/repos/fanzhangio/kubebuilder/hooks","issue_events_url":"https://api.github.com/repos/fanzhangio/kubebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/fanzhangio/kubebuilder/events","assignees_url":"https://api.github.com/repos/fanzhangio/kubebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/fanzhangio/kubebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/fanzhangio/kubebuilder/tags","blobs_url":"https://api.github.com/repos/fanzhangio/kubebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanzhangio/kubebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanzhangio/kubebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanzhangio/kubebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanzhangio/kubebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/fanzhangio/kubebuilder/languages","stargazers_url":"https://api.github.com/repos/fanzhangio/kubebuilder/stargazers","contributors_url":"https://api.github.com/repos/fanzhangio/kubebuilder/contributors","subscribers_url":"https://api.github.com/repos/fanzhangio/kubebuilder/subscribers","subscription_url":"https://api.github.com/repos/fanzhangio/kubebuilder/subscription","commits_url":"https://api.github.com/repos/fanzhangio/kubebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanzhangio/kubebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanzhangio/kubebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanzhangio/kubebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanzhangio/kubebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/fanzhangio/kubebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanzhangio/kubebuilder/merges","archive_url":"https://api.github.com/repos/fanzhangio/kubebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanzhangio/kubebuilder/downloads","issues_url":"https://api.github.com/repos/fanzhangio/kubebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/fanzhangio/kubebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/fanzhangio/kubebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/fanzhangio/kubebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanzhangio/kubebuilder/labels{/name}","releases_url":"https://api.github.com/repos/fanzhangio/kubebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/fanzhangio/kubebuilder/deployments","created_at":"2018-04-04T03:58:28Z","updated_at":"2018-05-14T17:08:34Z","pushed_at":"2018-05-17T11:34:19Z","git_url":"git://github.com/fanzhangio/kubebuilder.git","ssh_url":"git@github.com:fanzhangio/kubebuilder.git","clone_url":"https://github.com/fanzhangio/kubebuilder.git","svn_url":"https://github.com/fanzhangio/kubebuilder","homepage":null,"size":54891,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"fbeb43668c60926cb98ca33eb65c8ac156c9b3f4","user":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":125275487,"name":"kubebuilder","full_name":"kubernetes-sigs/kubebuilder","owner":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/kubebuilder","description":"Kubebuilder","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder","forks_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/deployments","created_at":"2018-03-14T21:26:14Z","updated_at":"2018-05-17T17:13:13Z","pushed_at":"2018-05-17T19:24:12Z","git_url":"git://github.com/kubernetes-sigs/kubebuilder.git","ssh_url":"git@github.com:kubernetes-sigs/kubebuilder.git","clone_url":"https://github.com/kubernetes-sigs/kubebuilder.git","svn_url":"https://github.com/kubernetes-sigs/kubebuilder","homepage":null,"size":54880,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":21,"open_issues":25,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150"},"html":{"href":"https://github.com/kubernetes-sigs/kubebuilder/pull/150"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/150"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/4746c85249ff664124bb160c8c96e735698a3475"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anfernee"}}