{"action":"opened","number":12614,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12614","id":174123447,"html_url":"https://github.com/highfidelity/hifi/pull/12614","diff_url":"https://github.com/highfidelity/hifi/pull/12614.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12614.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12614","number":12614,"state":"open","locked":false,"title":"Loghandler","user":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"body":"Changed LogHandler to maintain QRegExps rather than rebuild them on each message. Also use stl containers instead of Qt ones.\r\n\r\nOn Ubuntu there is no longer a crash in a global destructor when a regexp is created, since that call doesn't exist. In two tests one exited normally and one crashed in another Qt destructor, probably because the main thread had ended before the network and SendQueue threads. Previously the crash was 100% if the audio agent had connected to the interface.\r\n\r\nhttps://highfidelity.manuscript.com/f/cases/13035/\r\n\r\nhttps://highfidelity.sp.backtrace.io/dashboard/highfidelity/project/LinuxDomainServer/debugger/238244?frameID=17693&threadID=4920&variableID=","created_at":"2018-03-09T22:22:50Z","updated_at":"2018-03-09T22:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12614/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12614/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12614/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/626a91403417775930e892b51ee1dd23a1f7a559","head":{"label":"SimonWalton-HiFi:loghandler","ref":"loghandler","sha":"626a91403417775930e892b51ee1dd23a1f7a559","user":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"repo":{"id":122272443,"name":"hifi","full_name":"SimonWalton-HiFi/hifi","owner":{"login":"SimonWalton-HiFi","id":36682372,"avatar_url":"https://avatars0.githubusercontent.com/u/36682372?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWalton-HiFi","html_url":"https://github.com/SimonWalton-HiFi","followers_url":"https://api.github.com/users/SimonWalton-HiFi/followers","following_url":"https://api.github.com/users/SimonWalton-HiFi/following{/other_user}","gists_url":"https://api.github.com/users/SimonWalton-HiFi/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWalton-HiFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWalton-HiFi/subscriptions","organizations_url":"https://api.github.com/users/SimonWalton-HiFi/orgs","repos_url":"https://api.github.com/users/SimonWalton-HiFi/repos","events_url":"https://api.github.com/users/SimonWalton-HiFi/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWalton-HiFi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonWalton-HiFi/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/SimonWalton-HiFi/hifi","forks_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/forks","keys_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/teams","hooks_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/hooks","issue_events_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/events","assignees_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/tags","blobs_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/languages","stargazers_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/stargazers","contributors_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/contributors","subscribers_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/subscribers","subscription_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/subscription","commits_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/merges","archive_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/downloads","issues_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/labels{/name}","releases_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/SimonWalton-HiFi/hifi/deployments","created_at":"2018-02-21T00:01:45Z","updated_at":"2018-02-21T00:02:03Z","pushed_at":"2018-03-09T21:39:44Z","git_url":"git://github.com/SimonWalton-HiFi/hifi.git","ssh_url":"git@github.com:SimonWalton-HiFi/hifi.git","clone_url":"https://github.com/SimonWalton-HiFi/hifi.git","svn_url":"https://github.com/SimonWalton-HiFi/hifi","homepage":"","size":463137,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"42a686ad934d86876be7945038e75beb4140a7fa","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-03-08T21:16:27Z","pushed_at":"2018-03-09T21:59:46Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":463936,"stargazers_count":593,"watchers_count":593,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":394,"open_issues":137,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12614"},"html":{"href":"https://github.com/highfidelity/hifi/pull/12614"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12614"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12614/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12614/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12614/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/626a91403417775930e892b51ee1dd23a1f7a559"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":9,"additions":42,"deletions":46,"changed_files":3}}
{"actor":{"display_login":"SimonWalton-HiFi"}}