{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/208268951","pull_request_review_id":144042676,"id":208268951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI2ODk1MQ==","diff_hunk":"@@ -2229,7 +2250,12 @@ def do_subproject(self, dirname, kwargs):\n             incpath = ' => '.join(fullstack)\n             raise InvalidCode('Recursive include of subprojects: %s.' % incpath)\n         if dirname in self.subprojects:\n-            return self.subprojects[dirname]\n+            subproject = self.subprojects[dirname]\n+\n+            if required and not subproject.found():\n+                raise InterpreterException('Subproject \"%s\" required but not found.' % (dirname))","path":"mesonbuild/interpreter.py","position":64,"original_position":64,"commit_id":"ead8d447f0d2f44a7b3f290aa72203058f7ef7a0","original_commit_id":"16d2537f2053555534c09362d0c4ab2dcf1a0adb","user":{"login":"thiblahute","id":83553,"node_id":"MDQ6VXNlcjgzNTUz","avatar_url":"https://avatars1.githubusercontent.com/u/83553?v=4","gravatar_id":"","url":"https://api.github.com/users/thiblahute","html_url":"https://github.com/thiblahute","followers_url":"https://api.github.com/users/thiblahute/followers","following_url":"https://api.github.com/users/thiblahute/following{/other_user}","gists_url":"https://api.github.com/users/thiblahute/gists{/gist_id}","starred_url":"https://api.github.com/users/thiblahute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiblahute/subscriptions","organizations_url":"https://api.github.com/users/thiblahute/orgs","repos_url":"https://api.github.com/users/thiblahute/repos","events_url":"https://api.github.com/users/thiblahute/events{/privacy}","received_events_url":"https://api.github.com/users/thiblahute/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-08-07T15:06:36Z","updated_at":"2018-08-07T15:06:36Z","html_url":"https://github.com/mesonbuild/meson/pull/3885#discussion_r208268951","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3885","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/208268951"},"html":{"href":"https://github.com/mesonbuild/meson/pull/3885#discussion_r208268951"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3885"}},"in_reply_to_id":208245134},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/3885","id":201359352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzU5MzUy","html_url":"https://github.com/mesonbuild/meson/pull/3885","diff_url":"https://github.com/mesonbuild/meson/pull/3885.diff","patch_url":"https://github.com/mesonbuild/meson/pull/3885.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/3885","number":3885,"state":"open","locked":false,"title":"Add a `required` argument to `subproject`","user":{"login":"thiblahute","id":83553,"node_id":"MDQ6VXNlcjgzNTUz","avatar_url":"https://avatars1.githubusercontent.com/u/83553?v=4","gravatar_id":"","url":"https://api.github.com/users/thiblahute","html_url":"https://github.com/thiblahute","followers_url":"https://api.github.com/users/thiblahute/followers","following_url":"https://api.github.com/users/thiblahute/following{/other_user}","gists_url":"https://api.github.com/users/thiblahute/gists{/gist_id}","starred_url":"https://api.github.com/users/thiblahute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiblahute/subscriptions","organizations_url":"https://api.github.com/users/thiblahute/orgs","repos_url":"https://api.github.com/users/thiblahute/repos","events_url":"https://api.github.com/users/thiblahute/events{/privacy}","received_events_url":"https://api.github.com/users/thiblahute/received_events","type":"User","site_admin":false},"body":"Allowing to use the new \"feature\" option type and allowing not to fail\r\non subproject if it is not necessary to fail.\r\n\r\nBy default subprojects are \"required\" so previous behaviour is not\r\nchanged.\r\n\r\nFixes #3880","created_at":"2018-07-13T17:55:23Z","updated_at":"2018-08-07T15:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e627ad7d4c850f30bec1f91df38b2ef1753528f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3885/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3885/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/3885/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/ead8d447f0d2f44a7b3f290aa72203058f7ef7a0","head":{"label":"thiblahute:master","ref":"master","sha":"ead8d447f0d2f44a7b3f290aa72203058f7ef7a0","user":{"login":"thiblahute","id":83553,"node_id":"MDQ6VXNlcjgzNTUz","avatar_url":"https://avatars1.githubusercontent.com/u/83553?v=4","gravatar_id":"","url":"https://api.github.com/users/thiblahute","html_url":"https://github.com/thiblahute","followers_url":"https://api.github.com/users/thiblahute/followers","following_url":"https://api.github.com/users/thiblahute/following{/other_user}","gists_url":"https://api.github.com/users/thiblahute/gists{/gist_id}","starred_url":"https://api.github.com/users/thiblahute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiblahute/subscriptions","organizations_url":"https://api.github.com/users/thiblahute/orgs","repos_url":"https://api.github.com/users/thiblahute/repos","events_url":"https://api.github.com/users/thiblahute/events{/privacy}","received_events_url":"https://api.github.com/users/thiblahute/received_events","type":"User","site_admin":false},"repo":{"id":35685120,"node_id":"MDEwOlJlcG9zaXRvcnkzNTY4NTEyMA==","name":"meson","full_name":"thiblahute/meson","owner":{"login":"thiblahute","id":83553,"node_id":"MDQ6VXNlcjgzNTUz","avatar_url":"https://avatars1.githubusercontent.com/u/83553?v=4","gravatar_id":"","url":"https://api.github.com/users/thiblahute","html_url":"https://github.com/thiblahute","followers_url":"https://api.github.com/users/thiblahute/followers","following_url":"https://api.github.com/users/thiblahute/following{/other_user}","gists_url":"https://api.github.com/users/thiblahute/gists{/gist_id}","starred_url":"https://api.github.com/users/thiblahute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiblahute/subscriptions","organizations_url":"https://api.github.com/users/thiblahute/orgs","repos_url":"https://api.github.com/users/thiblahute/repos","events_url":"https://api.github.com/users/thiblahute/events{/privacy}","received_events_url":"https://api.github.com/users/thiblahute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thiblahute/meson","description":"The Meson Build System","fork":true,"url":"https://api.github.com/repos/thiblahute/meson","forks_url":"https://api.github.com/repos/thiblahute/meson/forks","keys_url":"https://api.github.com/repos/thiblahute/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thiblahute/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thiblahute/meson/teams","hooks_url":"https://api.github.com/repos/thiblahute/meson/hooks","issue_events_url":"https://api.github.com/repos/thiblahute/meson/issues/events{/number}","events_url":"https://api.github.com/repos/thiblahute/meson/events","assignees_url":"https://api.github.com/repos/thiblahute/meson/assignees{/user}","branches_url":"https://api.github.com/repos/thiblahute/meson/branches{/branch}","tags_url":"https://api.github.com/repos/thiblahute/meson/tags","blobs_url":"https://api.github.com/repos/thiblahute/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thiblahute/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thiblahute/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/thiblahute/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thiblahute/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/thiblahute/meson/languages","stargazers_url":"https://api.github.com/repos/thiblahute/meson/stargazers","contributors_url":"https://api.github.com/repos/thiblahute/meson/contributors","subscribers_url":"https://api.github.com/repos/thiblahute/meson/subscribers","subscription_url":"https://api.github.com/repos/thiblahute/meson/subscription","commits_url":"https://api.github.com/repos/thiblahute/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/thiblahute/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/thiblahute/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/thiblahute/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/thiblahute/meson/contents/{+path}","compare_url":"https://api.github.com/repos/thiblahute/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thiblahute/meson/merges","archive_url":"https://api.github.com/repos/thiblahute/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thiblahute/meson/downloads","issues_url":"https://api.github.com/repos/thiblahute/meson/issues{/number}","pulls_url":"https://api.github.com/repos/thiblahute/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/thiblahute/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/thiblahute/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thiblahute/meson/labels{/name}","releases_url":"https://api.github.com/repos/thiblahute/meson/releases{/id}","deployments_url":"https://api.github.com/repos/thiblahute/meson/deployments","created_at":"2015-05-15T16:40:52Z","updated_at":"2018-08-07T15:06:30Z","pushed_at":"2018-08-07T15:06:26Z","git_url":"git://github.com/thiblahute/meson.git","ssh_url":"git@github.com:thiblahute/meson.git","clone_url":"https://github.com/thiblahute/meson.git","svn_url":"https://github.com/thiblahute/meson","homepage":null,"size":16484,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"c0c2455e3c2536f18ada80a0f738659508f012c1","user":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc4NDIzMg==","name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2018-08-07T13:39:37Z","pushed_at":"2018-08-07T15:06:29Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":"http://mesonbuild.com","size":17056,"stargazers_count":1581,"watchers_count":1581,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":406,"mirror_url":null,"archived":false,"open_issues_count":788,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":406,"open_issues":788,"watchers":1581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3885"},"html":{"href":"https://github.com/mesonbuild/meson/pull/3885"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/3885"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/3885/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3885/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3885/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/ead8d447f0d2f44a7b3f290aa72203058f7ef7a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thiblahute"}}