{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/comments/215828757","pull_request_review_id":153183329,"id":215828757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgyODc1Nw==","diff_hunk":"@@ -1301,6 +1403,18 @@ dependencies = [\n  \"quick-error 1.2.2 (registry+https://github.com/rust-lang/crates.io-index)\",\n ]\n \n+[[package]]\n+name = \"ring\"\n+version = \"0.8.1\"","path":"Cargo.lock","position":185,"original_position":185,"commit_id":"9ecb73e77c6adb6332b61b8dd8d737215be926b3","original_commit_id":"9ecb73e77c6adb6332b61b8dd8d737215be926b3","user":{"login":"rfk","id":34695,"node_id":"MDQ6VXNlcjM0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"body":"Both travis-ci and I are getting build failures like:\r\n\r\n```\r\n          /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.12.1/crypto/curve25519/curve25519.c:4693: multiple definition of `GFp_x25519_public_from_private'\r\n          /home/travis/build/mozilla-services/syncstorage-rs/target/debug/deps/libring-ae014aa1941bdf5c.rlib(curve25519.o):/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.8.1/crypto/curve25519/curve25519.c:4712: first defined here\r\n```\r\n\r\nCould be because this is introducing a second version of `ring`, and both versions can't be compiled together into a single binary?","created_at":"2018-09-07T02:16:04Z","updated_at":"2018-09-07T02:16:04Z","html_url":"https://github.com/mozilla-services/syncstorage-rs/pull/20#discussion_r215828757","pull_request_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/comments/215828757"},"html":{"href":"https://github.com/mozilla-services/syncstorage-rs/pull/20#discussion_r215828757"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20","id":211820829,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODIwODI5","html_url":"https://github.com/mozilla-services/syncstorage-rs/pull/20","diff_url":"https://github.com/mozilla-services/syncstorage-rs/pull/20.diff","patch_url":"https://github.com/mozilla-services/syncstorage-rs/pull/20.patch","issue_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/20","number":20,"state":"open","locked":false,"title":"WIP: hawk authentication","user":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"body":"Fixes #19.\r\n\r\nI didn't quite manage to get this finished today, mostly because I wasted a few hours writing parsing logic for the Hawk header, only to eventually RTFM and notice the hawk crate already implements that via the `FromStr` trait. Sigh.\r\n\r\nAnyway, I wanted to post this as a WIP so that @rfk can hopefully cast his eye over the crypto logic while I'm away. As you'll see Ryan, I've left your excellent (and long) comment in place for now, interjected with my attempts to implement each section of it. There are a couple of places where I'm not sure I understood you correctly, so I'll call those out in the inline comments.\r\n\r\nIf I have time after I've packed my bag tomorrow, I might see if I can wire it into the request mechanism and write some tests for it. If I do get to that point I'll comment here and remove the WIP. But, being realistic, I probably won't get to that point.\r\n\r\nSee you all next week! 😄","created_at":"2018-08-29T16:52:35Z","updated_at":"2018-09-07T02:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2b940829850e056a93a3129120cc78dc2131382","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/20/comments","statuses_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/statuses/9ecb73e77c6adb6332b61b8dd8d737215be926b3","head":{"label":"philbooth:hawk-authentication","ref":"hawk-authentication","sha":"9ecb73e77c6adb6332b61b8dd8d737215be926b3","user":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"repo":{"id":142356624,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNTY2MjQ=","name":"syncstorage-rs","full_name":"philbooth/syncstorage-rs","owner":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philbooth/syncstorage-rs","description":"Sync Storage server in Rust","fork":true,"url":"https://api.github.com/repos/philbooth/syncstorage-rs","forks_url":"https://api.github.com/repos/philbooth/syncstorage-rs/forks","keys_url":"https://api.github.com/repos/philbooth/syncstorage-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philbooth/syncstorage-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philbooth/syncstorage-rs/teams","hooks_url":"https://api.github.com/repos/philbooth/syncstorage-rs/hooks","issue_events_url":"https://api.github.com/repos/philbooth/syncstorage-rs/issues/events{/number}","events_url":"https://api.github.com/repos/philbooth/syncstorage-rs/events","assignees_url":"https://api.github.com/repos/philbooth/syncstorage-rs/assignees{/user}","branches_url":"https://api.github.com/repos/philbooth/syncstorage-rs/branches{/branch}","tags_url":"https://api.github.com/repos/philbooth/syncstorage-rs/tags","blobs_url":"https://api.github.com/repos/philbooth/syncstorage-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philbooth/syncstorage-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philbooth/syncstorage-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/philbooth/syncstorage-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philbooth/syncstorage-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/philbooth/syncstorage-rs/languages","stargazers_url":"https://api.github.com/repos/philbooth/syncstorage-rs/stargazers","contributors_url":"https://api.github.com/repos/philbooth/syncstorage-rs/contributors","subscribers_url":"https://api.github.com/repos/philbooth/syncstorage-rs/subscribers","subscription_url":"https://api.github.com/repos/philbooth/syncstorage-rs/subscription","commits_url":"https://api.github.com/repos/philbooth/syncstorage-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/philbooth/syncstorage-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/philbooth/syncstorage-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/philbooth/syncstorage-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/philbooth/syncstorage-rs/contents/{+path}","compare_url":"https://api.github.com/repos/philbooth/syncstorage-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philbooth/syncstorage-rs/merges","archive_url":"https://api.github.com/repos/philbooth/syncstorage-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philbooth/syncstorage-rs/downloads","issues_url":"https://api.github.com/repos/philbooth/syncstorage-rs/issues{/number}","pulls_url":"https://api.github.com/repos/philbooth/syncstorage-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/philbooth/syncstorage-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/philbooth/syncstorage-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philbooth/syncstorage-rs/labels{/name}","releases_url":"https://api.github.com/repos/philbooth/syncstorage-rs/releases{/id}","deployments_url":"https://api.github.com/repos/philbooth/syncstorage-rs/deployments","created_at":"2018-07-25T21:38:35Z","updated_at":"2018-08-28T12:30:59Z","pushed_at":"2018-09-06T13:29:52Z","git_url":"git://github.com/philbooth/syncstorage-rs.git","ssh_url":"git@github.com:philbooth/syncstorage-rs.git","clone_url":"https://github.com/philbooth/syncstorage-rs.git","svn_url":"https://github.com/philbooth/syncstorage-rs","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"5f7e1dd887eb7ef78fffcfec07d08b6545b63ed2","user":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":141760806,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NjA4MDY=","name":"syncstorage-rs","full_name":"mozilla-services/syncstorage-rs","owner":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/syncstorage-rs","description":"Sync Storage server in Rust","fork":false,"url":"https://api.github.com/repos/mozilla-services/syncstorage-rs","forks_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/forks","keys_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/teams","hooks_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/events","assignees_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/tags","blobs_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/subscription","commits_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/merges","archive_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/downloads","issues_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/syncstorage-rs/deployments","created_at":"2018-07-20T21:46:57Z","updated_at":"2018-08-24T15:53:39Z","pushed_at":"2018-09-06T13:29:53Z","git_url":"git://github.com/mozilla-services/syncstorage-rs.git","ssh_url":"git@github.com:mozilla-services/syncstorage-rs.git","clone_url":"https://github.com/mozilla-services/syncstorage-rs.git","svn_url":"https://github.com/mozilla-services/syncstorage-rs","homepage":null,"size":96,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20"},"html":{"href":"https://github.com/mozilla-services/syncstorage-rs/pull/20"},"issue":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/20"},"comments":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/syncstorage-rs/statuses/9ecb73e77c6adb6332b61b8dd8d737215be926b3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rfk"}}