{"action":"created","comment":{"url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/comments/245043736","pull_request_review_id":189055162,"id":245043736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA0MzczNg==","diff_hunk":"@@ -21,6 +23,9 @@ def __init__(self, keeper, address, password=None):\n         self.address = address\n         self.password = password\n \n+    def sign_hash(self, msg_hash):","path":"squid_py/ocean/account.py","position":21,"original_position":21,"commit_id":"7bb1aea7ceca16fb6d39d926538bbb9be093df08","original_commit_id":"7bb1aea7ceca16fb6d39d926538bbb9be093df08","user":{"login":"eruizgar91","id":3496824,"node_id":"MDQ6VXNlcjM0OTY4MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3496824?v=4","gravatar_id":"","url":"https://api.github.com/users/eruizgar91","html_url":"https://github.com/eruizgar91","followers_url":"https://api.github.com/users/eruizgar91/followers","following_url":"https://api.github.com/users/eruizgar91/following{/other_user}","gists_url":"https://api.github.com/users/eruizgar91/gists{/gist_id}","starred_url":"https://api.github.com/users/eruizgar91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eruizgar91/subscriptions","organizations_url":"https://api.github.com/users/eruizgar91/orgs","repos_url":"https://api.github.com/users/eruizgar91/repos","events_url":"https://api.github.com/users/eruizgar91/events{/privacy}","received_events_url":"https://api.github.com/users/eruizgar91/received_events","type":"User","site_admin":false},"body":"Could you add doc in this method?\r\n","created_at":"2019-01-03T15:54:47Z","updated_at":"2019-01-03T15:58:03Z","html_url":"https://github.com/oceanprotocol/squid-py/pull/210#discussion_r245043736","pull_request_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/comments/245043736"},"html":{"href":"https://github.com/oceanprotocol/squid-py/pull/210#discussion_r245043736"},"pull_request":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210","id":242018535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDE4NTM1","html_url":"https://github.com/oceanprotocol/squid-py/pull/210","diff_url":"https://github.com/oceanprotocol/squid-py/pull/210.diff","patch_url":"https://github.com/oceanprotocol/squid-py/pull/210.patch","issue_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/210","number":210,"state":"open","locked":false,"title":"refactor/160-unique-class-responsibility","user":{"login":"ssallam","id":36411297,"node_id":"MDQ6VXNlcjM2NDExMjk3","avatar_url":"https://avatars1.githubusercontent.com/u/36411297?v=4","gravatar_id":"","url":"https://api.github.com/users/ssallam","html_url":"https://github.com/ssallam","followers_url":"https://api.github.com/users/ssallam/followers","following_url":"https://api.github.com/users/ssallam/following{/other_user}","gists_url":"https://api.github.com/users/ssallam/gists{/gist_id}","starred_url":"https://api.github.com/users/ssallam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssallam/subscriptions","organizations_url":"https://api.github.com/users/ssallam/orgs","repos_url":"https://api.github.com/users/ssallam/repos","events_url":"https://api.github.com/users/ssallam/events{/privacy}","received_events_url":"https://api.github.com/users/ssallam/received_events","type":"User","site_admin":false},"body":"Refactor classes to have unique responsibilities.\r\n\r\nThis is a breaking change, the main ocean interface is changed.\r\n`Ocean` takes a single optional argument; a `Config` instance.","created_at":"2019-01-03T14:59:39Z","updated_at":"2019-01-03T15:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"908b4ed3161dc63863d25bbdd3c3415d8fa2921a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Maintainers","id":2702044,"node_id":"MDQ6VGVhbTI3MDIwNDQ=","slug":"maintainers","description":"","privacy":"closed","url":"https://api.github.com/teams/2702044","members_url":"https://api.github.com/teams/2702044/members{/member}","repositories_url":"https://api.github.com/teams/2702044/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210/commits","review_comments_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210/comments","review_comment_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/210/comments","statuses_url":"https://api.github.com/repos/oceanprotocol/squid-py/statuses/7bb1aea7ceca16fb6d39d926538bbb9be093df08","head":{"label":"oceanprotocol:refactor/160-unique-class-responsibility","ref":"refactor/160-unique-class-responsibility","sha":"7bb1aea7ceca16fb6d39d926538bbb9be093df08","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":144822121,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MjIxMjE=","name":"squid-py","full_name":"oceanprotocol/squid-py","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/squid-py","description":"🦑 Python client library for Ocean Protocol","fork":false,"url":"https://api.github.com/repos/oceanprotocol/squid-py","forks_url":"https://api.github.com/repos/oceanprotocol/squid-py/forks","keys_url":"https://api.github.com/repos/oceanprotocol/squid-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/squid-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/squid-py/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/squid-py/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/squid-py/events","assignees_url":"https://api.github.com/repos/oceanprotocol/squid-py/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/squid-py/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/squid-py/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/squid-py/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/squid-py/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/squid-py/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/squid-py/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/squid-py/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/squid-py/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/squid-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/squid-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/squid-py/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/squid-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/squid-py/merges","archive_url":"https://api.github.com/repos/oceanprotocol/squid-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/squid-py/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/squid-py/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/squid-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/squid-py/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/squid-py/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/squid-py/deployments","created_at":"2018-08-15T07:44:51Z","updated_at":"2019-01-02T14:18:27Z","pushed_at":"2019-01-03T15:16:01Z","git_url":"git://github.com/oceanprotocol/squid-py.git","ssh_url":"git@github.com:oceanprotocol/squid-py.git","clone_url":"https://github.com/oceanprotocol/squid-py.git","svn_url":"https://github.com/oceanprotocol/squid-py","homepage":"","size":3696,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":25,"watchers":20,"default_branch":"develop"}},"base":{"label":"oceanprotocol:develop","ref":"develop","sha":"c8098ab9746705a955111a52e27b981dbc38be48","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":144822121,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MjIxMjE=","name":"squid-py","full_name":"oceanprotocol/squid-py","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/squid-py","description":"🦑 Python client library for Ocean Protocol","fork":false,"url":"https://api.github.com/repos/oceanprotocol/squid-py","forks_url":"https://api.github.com/repos/oceanprotocol/squid-py/forks","keys_url":"https://api.github.com/repos/oceanprotocol/squid-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/squid-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/squid-py/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/squid-py/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/squid-py/events","assignees_url":"https://api.github.com/repos/oceanprotocol/squid-py/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/squid-py/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/squid-py/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/squid-py/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/squid-py/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/squid-py/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/squid-py/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/squid-py/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/squid-py/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/squid-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/squid-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/squid-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/squid-py/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/squid-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/squid-py/merges","archive_url":"https://api.github.com/repos/oceanprotocol/squid-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/squid-py/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/squid-py/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/squid-py/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/squid-py/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/squid-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/squid-py/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/squid-py/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/squid-py/deployments","created_at":"2018-08-15T07:44:51Z","updated_at":"2019-01-02T14:18:27Z","pushed_at":"2019-01-03T15:16:01Z","git_url":"git://github.com/oceanprotocol/squid-py.git","ssh_url":"git@github.com:oceanprotocol/squid-py.git","clone_url":"https://github.com/oceanprotocol/squid-py.git","svn_url":"https://github.com/oceanprotocol/squid-py","homepage":"","size":3696,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":25,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210"},"html":{"href":"https://github.com/oceanprotocol/squid-py/pull/210"},"issue":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/issues/210"},"comments":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/oceanprotocol/squid-py/statuses/7bb1aea7ceca16fb6d39d926538bbb9be093df08"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eruizgar91"}}