{"action":"created","comment":{"url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments/228509346","pull_request_review_id":168800595,"id":228509346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODUwOTM0Ng==","diff_hunk":"@@ -55,13 +55,25 @@ open class AKConvolution: AKNode, AKToggleable, AKComponent, AKInput {\n             strongSelf.internalAU = avAudioUnit.auAudioUnit as? AKAudioUnitType\n             input?.connect(to: strongSelf)\n             strongSelf.internalAU?.setPartitionLength(Int32(partitionLength))\n+            strongSelf.readAudioFile()\n+            strongSelf.internalAU?.initConvolutionEngine()\n+            strongSelf.internalAU?.start()\n         }\n     }\n \n     // MARK: - Control\n \n     /// Function to start, play, or activate the node, all do the same thing\n     @objc open func start() {\n+        internalAU?.start()\n+    }\n+    \n+    /// Function to stop or bypass the node, both are equivalent\n+    @objc open func stop() {\n+        internalAU?.stop()\n+    }\n+    ","path":"AudioKit/Common/Nodes/Effects/Reverb/Convolution/AKConvolution.swift","position":21,"original_position":21,"commit_id":"5a0bb1218f95a9a5d3d22e1cf4975241b097325c","original_commit_id":"5a0bb1218f95a9a5d3d22e1cf4975241b097325c","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)","created_at":"2018-10-26T12:33:52Z","updated_at":"2018-10-26T12:33:52Z","html_url":"https://github.com/AudioKit/AudioKit/pull/1553#discussion_r228509346","pull_request_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments/228509346"},"html":{"href":"https://github.com/AudioKit/AudioKit/pull/1553#discussion_r228509346"},"pull_request":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553"}}},"pull_request":{"url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553","id":226081937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDgxOTM3","html_url":"https://github.com/AudioKit/AudioKit/pull/1553","diff_url":"https://github.com/AudioKit/AudioKit/pull/1553.diff","patch_url":"https://github.com/AudioKit/AudioKit/pull/1553.patch","issue_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/1553","number":1553,"state":"open","locked":false,"title":"Fix EXC_BAD_ACCESS in AKConvolution processing","user":{"login":"Bautastein","id":1619844,"node_id":"MDQ6VXNlcjE2MTk4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1619844?v=4","gravatar_id":"","url":"https://api.github.com/users/Bautastein","html_url":"https://github.com/Bautastein","followers_url":"https://api.github.com/users/Bautastein/followers","following_url":"https://api.github.com/users/Bautastein/following{/other_user}","gists_url":"https://api.github.com/users/Bautastein/gists{/gist_id}","starred_url":"https://api.github.com/users/Bautastein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bautastein/subscriptions","organizations_url":"https://api.github.com/users/Bautastein/orgs","repos_url":"https://api.github.com/users/Bautastein/repos","events_url":"https://api.github.com/users/Bautastein/events{/privacy}","received_events_url":"https://api.github.com/users/Bautastein/received_events","type":"User","site_admin":false},"body":"Before this fix, if start() is called on an instance of AKConvolution\r\nbefore inserting it into the audio processing chain, there will be an\r\nEXC_BAD_ACCESS in sp_conv_compute. If start() is called immediately\r\nafter inserting it into the chain, a race condition will cause the same\r\nfailure to occur inconsistently.\r\n\r\nThe fix does not change functionality or interface of any AudioKit Swift\r\nclasses. It does add one new member function and changes the\r\nfunctionality of the internal AU classes AKConvolutionAudioUnit and\r\nAKConvolutionDSPKernel.\r\n\r\nThe bug is caused by resources (conv0, conv1) being allocated in the\r\ninit() function of the AKConvolutionDSPKernel, and initialized in the\r\nstart() function. As init() gets called again when the AKNode is\r\ninserted into the sound chain, new resources are allocated for the same\r\nvariables, and then used uninitialized during sound processing. This\r\ncould be solved by moving both allocation and initialization into the\r\nstart() function, but this may cause further race conditions, and if\r\nstart() is called again during processing, new EXC_BAD_ACCESS faults\r\nwill probably occur.\r\n\r\nThis fix instead ensures both allocation and initialization is performed\r\nduring construction of the AKConvolution class, so the object is\r\nready-to-use after construction. However, this must be done in a\r\ncallback method which is not guaranteed to be finished when the\r\nconstructor returns. For this reason, the fix makes\r\nAKConvolutionDSPKernel turned off by default after construction, and\r\nthen it's turned on at the end of the callback, when all resources are\r\nallocated and initialized.","created_at":"2018-10-26T12:33:42Z","updated_at":"2018-10-26T12:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dbb518c8f51b81f722dcbd2cc34c6f6826782a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553/commits","review_comments_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553/comments","review_comment_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/1553/comments","statuses_url":"https://api.github.com/repos/AudioKit/AudioKit/statuses/5a0bb1218f95a9a5d3d22e1cf4975241b097325c","head":{"label":"Bautastein:fix_convolution_BAD_ACCESS_bug","ref":"fix_convolution_BAD_ACCESS_bug","sha":"5a0bb1218f95a9a5d3d22e1cf4975241b097325c","user":{"login":"Bautastein","id":1619844,"node_id":"MDQ6VXNlcjE2MTk4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1619844?v=4","gravatar_id":"","url":"https://api.github.com/users/Bautastein","html_url":"https://github.com/Bautastein","followers_url":"https://api.github.com/users/Bautastein/followers","following_url":"https://api.github.com/users/Bautastein/following{/other_user}","gists_url":"https://api.github.com/users/Bautastein/gists{/gist_id}","starred_url":"https://api.github.com/users/Bautastein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bautastein/subscriptions","organizations_url":"https://api.github.com/users/Bautastein/orgs","repos_url":"https://api.github.com/users/Bautastein/repos","events_url":"https://api.github.com/users/Bautastein/events{/privacy}","received_events_url":"https://api.github.com/users/Bautastein/received_events","type":"User","site_admin":false},"repo":{"id":154694826,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2OTQ4MjY=","name":"AudioKit","full_name":"Bautastein/AudioKit","private":false,"owner":{"login":"Bautastein","id":1619844,"node_id":"MDQ6VXNlcjE2MTk4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1619844?v=4","gravatar_id":"","url":"https://api.github.com/users/Bautastein","html_url":"https://github.com/Bautastein","followers_url":"https://api.github.com/users/Bautastein/followers","following_url":"https://api.github.com/users/Bautastein/following{/other_user}","gists_url":"https://api.github.com/users/Bautastein/gists{/gist_id}","starred_url":"https://api.github.com/users/Bautastein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bautastein/subscriptions","organizations_url":"https://api.github.com/users/Bautastein/orgs","repos_url":"https://api.github.com/users/Bautastein/repos","events_url":"https://api.github.com/users/Bautastein/events{/privacy}","received_events_url":"https://api.github.com/users/Bautastein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bautastein/AudioKit","description":"Swift audio synthesis, processing, & analysis platform for iOS, macOS and tvOS","fork":true,"url":"https://api.github.com/repos/Bautastein/AudioKit","forks_url":"https://api.github.com/repos/Bautastein/AudioKit/forks","keys_url":"https://api.github.com/repos/Bautastein/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bautastein/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bautastein/AudioKit/teams","hooks_url":"https://api.github.com/repos/Bautastein/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/Bautastein/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/Bautastein/AudioKit/events","assignees_url":"https://api.github.com/repos/Bautastein/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/Bautastein/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/Bautastein/AudioKit/tags","blobs_url":"https://api.github.com/repos/Bautastein/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bautastein/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bautastein/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bautastein/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bautastein/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Bautastein/AudioKit/languages","stargazers_url":"https://api.github.com/repos/Bautastein/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/Bautastein/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/Bautastein/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/Bautastein/AudioKit/subscription","commits_url":"https://api.github.com/repos/Bautastein/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bautastein/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bautastein/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bautastein/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bautastein/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/Bautastein/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bautastein/AudioKit/merges","archive_url":"https://api.github.com/repos/Bautastein/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bautastein/AudioKit/downloads","issues_url":"https://api.github.com/repos/Bautastein/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/Bautastein/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Bautastein/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Bautastein/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bautastein/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/Bautastein/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/Bautastein/AudioKit/deployments","created_at":"2018-10-25T15:29:46Z","updated_at":"2018-10-25T15:29:54Z","pushed_at":"2018-10-26T12:24:23Z","git_url":"git://github.com/Bautastein/AudioKit.git","ssh_url":"git@github.com:Bautastein/AudioKit.git","clone_url":"https://github.com/Bautastein/AudioKit.git","svn_url":"https://github.com/Bautastein/AudioKit","homepage":"http://audiokit.io/","size":217291,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AudioKit:develop","ref":"develop","sha":"8ddf4f71e401dd1a69e591ffa2afb708136c7b72","user":{"login":"AudioKit","id":6593633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1OTM2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6593633?v=4","gravatar_id":"","url":"https://api.github.com/users/AudioKit","html_url":"https://github.com/AudioKit","followers_url":"https://api.github.com/users/AudioKit/followers","following_url":"https://api.github.com/users/AudioKit/following{/other_user}","gists_url":"https://api.github.com/users/AudioKit/gists{/gist_id}","starred_url":"https://api.github.com/users/AudioKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudioKit/subscriptions","organizations_url":"https://api.github.com/users/AudioKit/orgs","repos_url":"https://api.github.com/users/AudioKit/repos","events_url":"https://api.github.com/users/AudioKit/events{/privacy}","received_events_url":"https://api.github.com/users/AudioKit/received_events","type":"Organization","site_admin":false},"repo":{"id":16096528,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NjUyOA==","name":"AudioKit","full_name":"AudioKit/AudioKit","private":false,"owner":{"login":"AudioKit","id":6593633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1OTM2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6593633?v=4","gravatar_id":"","url":"https://api.github.com/users/AudioKit","html_url":"https://github.com/AudioKit","followers_url":"https://api.github.com/users/AudioKit/followers","following_url":"https://api.github.com/users/AudioKit/following{/other_user}","gists_url":"https://api.github.com/users/AudioKit/gists{/gist_id}","starred_url":"https://api.github.com/users/AudioKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudioKit/subscriptions","organizations_url":"https://api.github.com/users/AudioKit/orgs","repos_url":"https://api.github.com/users/AudioKit/repos","events_url":"https://api.github.com/users/AudioKit/events{/privacy}","received_events_url":"https://api.github.com/users/AudioKit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AudioKit/AudioKit","description":"Swift audio synthesis, processing, & analysis platform for iOS, macOS and tvOS","fork":false,"url":"https://api.github.com/repos/AudioKit/AudioKit","forks_url":"https://api.github.com/repos/AudioKit/AudioKit/forks","keys_url":"https://api.github.com/repos/AudioKit/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudioKit/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudioKit/AudioKit/teams","hooks_url":"https://api.github.com/repos/AudioKit/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/AudioKit/AudioKit/events","assignees_url":"https://api.github.com/repos/AudioKit/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/AudioKit/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/AudioKit/AudioKit/tags","blobs_url":"https://api.github.com/repos/AudioKit/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudioKit/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudioKit/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudioKit/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudioKit/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/AudioKit/AudioKit/languages","stargazers_url":"https://api.github.com/repos/AudioKit/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/AudioKit/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/AudioKit/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/AudioKit/AudioKit/subscription","commits_url":"https://api.github.com/repos/AudioKit/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudioKit/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudioKit/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudioKit/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/AudioKit/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudioKit/AudioKit/merges","archive_url":"https://api.github.com/repos/AudioKit/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudioKit/AudioKit/downloads","issues_url":"https://api.github.com/repos/AudioKit/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/AudioKit/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/AudioKit/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudioKit/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/AudioKit/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/AudioKit/AudioKit/deployments","created_at":"2014-01-21T08:16:07Z","updated_at":"2018-10-26T08:55:54Z","pushed_at":"2018-10-26T12:33:43Z","git_url":"git://github.com/AudioKit/AudioKit.git","ssh_url":"git@github.com:AudioKit/AudioKit.git","clone_url":"https://github.com/AudioKit/AudioKit.git","svn_url":"https://github.com/AudioKit/AudioKit","homepage":"http://audiokit.io/","size":217293,"stargazers_count":5956,"watchers_count":5956,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":898,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":898,"open_issues":8,"watchers":5956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553"},"html":{"href":"https://github.com/AudioKit/AudioKit/pull/1553"},"issue":{"href":"https://api.github.com/repos/AudioKit/AudioKit/issues/1553"},"comments":{"href":"https://api.github.com/repos/AudioKit/AudioKit/issues/1553/comments"},"review_comments":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553/comments"},"review_comment":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1553/commits"},"statuses":{"href":"https://api.github.com/repos/AudioKit/AudioKit/statuses/5a0bb1218f95a9a5d3d22e1cf4975241b097325c"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}