{"action":"created","issue":{"url":"https://api.github.com/repos/eBay/skin/issues/391","repository_url":"https://api.github.com/repos/eBay/skin","labels_url":"https://api.github.com/repos/eBay/skin/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/eBay/skin/issues/391/comments","events_url":"https://api.github.com/repos/eBay/skin/issues/391/events","html_url":"https://github.com/eBay/skin/issues/391","id":362311417,"node_id":"MDU6SXNzdWUzNjIzMTE0MTc=","number":391,"title":"Button: text should wrap when fixed width is applied","user":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"labels":[{"id":659666609,"node_id":"MDU6TGFiZWw2NTk2NjY2MDk=","url":"https://api.github.com/repos/eBay/skin/labels/module:%20button","name":"module: button","color":"147133","default":false},{"id":1065132486,"node_id":"MDU6TGFiZWwxMDY1MTMyNDg2","url":"https://api.github.com/repos/eBay/skin/labels/sprint:%2017","name":"sprint: 17","color":"ffe7ec","default":false},{"id":659666657,"node_id":"MDU6TGFiZWw2NTk2NjY2NTc=","url":"https://api.github.com/repos/eBay/skin/labels/status:%20in%20progress","name":"status: in progress","color":"c7c7c7","default":false}],"state":"open","locked":false,"assignee":{"login":"seangates","id":105656,"node_id":"MDQ6VXNlcjEwNTY1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/105656?v=4","gravatar_id":"","url":"https://api.github.com/users/seangates","html_url":"https://github.com/seangates","followers_url":"https://api.github.com/users/seangates/followers","following_url":"https://api.github.com/users/seangates/following{/other_user}","gists_url":"https://api.github.com/users/seangates/gists{/gist_id}","starred_url":"https://api.github.com/users/seangates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seangates/subscriptions","organizations_url":"https://api.github.com/users/seangates/orgs","repos_url":"https://api.github.com/users/seangates/repos","events_url":"https://api.github.com/users/seangates/events{/privacy}","received_events_url":"https://api.github.com/users/seangates/received_events","type":"User","site_admin":false},"assignees":[{"login":"seangates","id":105656,"node_id":"MDQ6VXNlcjEwNTY1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/105656?v=4","gravatar_id":"","url":"https://api.github.com/users/seangates","html_url":"https://github.com/seangates","followers_url":"https://api.github.com/users/seangates/followers","following_url":"https://api.github.com/users/seangates/following{/other_user}","gists_url":"https://api.github.com/users/seangates/gists{/gist_id}","starred_url":"https://api.github.com/users/seangates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seangates/subscriptions","organizations_url":"https://api.github.com/users/seangates/orgs","repos_url":"https://api.github.com/users/seangates/repos","events_url":"https://api.github.com/users/seangates/events{/privacy}","received_events_url":"https://api.github.com/users/seangates/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eBay/skin/milestones/14","html_url":"https://github.com/eBay/skin/milestone/14","labels_url":"https://api.github.com/repos/eBay/skin/milestones/14/labels","id":3254103,"node_id":"MDk6TWlsZXN0b25lMzI1NDEwMw==","number":14,"title":"6.1.0","description":"Flyout Notice (DS6), Pill (new)","creator":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":3,"state":"open","created_at":"2018-04-09T21:11:02Z","updated_at":"2018-09-24T17:30:07Z","due_on":"2018-09-28T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-09-20T18:36:53Z","updated_at":"2018-09-24T21:39:47Z","closed_at":null,"author_association":"MEMBER","body":"We had a lot of back and forth on this, and for a long time I didn't want to allow text wrapping of buttons (because it looks crap), but given that the native behaviour of an HTML button is to wrap when a fixed width is applied, then I think we should cater for this. Note that because we set a fixed height by default on our buttons (to align properly with other form controls, across browsers) we may need to utilize a modifier to set the height back to auto."},"comment":{"url":"https://api.github.com/repos/eBay/skin/issues/comments/424134931","html_url":"https://github.com/eBay/skin/issues/391#issuecomment-424134931","issue_url":"https://api.github.com/repos/eBay/skin/issues/391","id":424134931,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDEzNDkzMQ==","user":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T21:39:47Z","updated_at":"2018-09-24T21:39:47Z","author_association":"MEMBER","body":"On the Skin side, I think we should just let buttons and pills wrap to as many lines as the content needs. On the EbayUI side we can add the logic to truncate/trim if necessary."}}
{"actor":{"display_login":"ianmcburnie"}}