{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/10645","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/10645/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/10645/comments","events_url":"https://api.github.com/repos/apple/swift/issues/10645/events","html_url":"https://github.com/apple/swift/pull/10645","id":239019994,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI3ODIwMTA5","number":10645,"title":"[stdlib] Add benchmarks for Character's unicodeScalars view","user":{"login":"dabrahams","id":44065,"node_id":"MDQ6VXNlcjQ0MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/44065?v=4","gravatar_id":"","url":"https://api.github.com/users/dabrahams","html_url":"https://github.com/dabrahams","followers_url":"https://api.github.com/users/dabrahams/followers","following_url":"https://api.github.com/users/dabrahams/following{/other_user}","gists_url":"https://api.github.com/users/dabrahams/gists{/gist_id}","starred_url":"https://api.github.com/users/dabrahams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabrahams/subscriptions","organizations_url":"https://api.github.com/users/dabrahams/orgs","repos_url":"https://api.github.com/users/dabrahams/repos","events_url":"https://api.github.com/users/dabrahams/events{/privacy}","received_events_url":"https://api.github.com/users/dabrahams/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-28T00:28:07Z","updated_at":"2018-12-12T23:13:55Z","closed_at":"2017-06-28T00:49:11Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/10645","html_url":"https://github.com/apple/swift/pull/10645","diff_url":"https://github.com/apple/swift/pull/10645.diff","patch_url":"https://github.com/apple/swift/pull/10645.patch"},"body":"In local testing, these benchmark results change as follows due to f212fac7171:\r\n\r\n<details open>\r\n  <summary>Regression (20)</summary>\r\n\r\nTEST                                              | OLD    | NEW    | DELTA   | SPEEDUP\r\n---                                               | ---    | ---    | ---     | ---\r\nCharIteration_utf16_unicodeScalars                | 33074  | 79510  | +140.4% | **0.42x**\r\nCharIteration_utf16_unicodeScalars_Backwards      | 73826  | 115515 | +56.5%  | **0.64x**\r\n\r\n</details>\r\n\r\n<details open>\r\n  <summary>Improvement (43)</summary>\r\n\r\nTEST                                              | OLD    | NEW    | DELTA   | SPEEDUP\r\n---                                               | ---    | ---    | ---     | ---\r\nCharIndexing_korean_unicodeScalars                | 118425 | 10360  | -91.3%  | **11.43x**\r\nCharIndexing_tweet_unicodeScalars_Backwards       | 226366 | 19850  | -91.2%  | **11.40x**\r\nCharIndexing_tweet_unicodeScalars                 | 240596 | 21178  | -91.2%  | **11.36x**\r\nCharIndexing_japanese_unicodeScalars_Backwards    | 136265 | 12032  | -91.2%  | **11.33x**\r\nCharIndexing_chinese_unicodeScalars               | 92226  | 8146   | -91.2%  | **11.32x**\r\nCharIndexing_russian_unicodeScalars               | 100908 | 8948   | -91.1%  | **11.28x**\r\nCharIndexing_japanese_unicodeScalars              | 145414 | 12895  | -91.1%  | **11.28x**\r\nCharIndexing_ascii_unicodeScalars                 | 121438 | 10779  | -91.1%  | **11.27x**\r\nCharIndexing_russian_unicodeScalars_Backwards     | 94190  | 8367   | -91.1%  | **11.26x**\r\nCharIndexing_korean_unicodeScalars_Backwards      | 110175 | 9803   | -91.1%  | **11.24x**\r\nCharIndexing_chinese_unicodeScalars_Backwards     | 86479  | 7715   | -91.1%  | **11.21x**\r\nCharIndexing_ascii_unicodeScalars_Backwards       | 113255 | 10132  | -91.1%  | **11.18x**\r\nCharIteration_ascii_unicodeScalars_Backwards      | 114873 | 13701  | -88.1%  | **8.38x**\r\nCharIteration_chinese_unicodeScalars_Backwards    | 85778  | 10411  | -87.9%  | **8.24x**\r\nCharIteration_russian_unicodeScalars_Backwards    | 94504  | 11471  | -87.9%  | **8.24x**\r\nCharIteration_japanese_unicodeScalars_Backwards   | 136231 | 16569  | -87.8%  | **8.22x**\r\nCharIteration_tweet_unicodeScalars_Backwards      | 222907 | 27165  | -87.8%  | **8.21x**\r\nCharIteration_korean_unicodeScalars_Backwards     | 110132 | 13443  | -87.8%  | **8.19x**\r\nCharIteration_korean_unicodeScalars               | 79540  | 11859  | -85.1%  | **6.71x**\r\nCharIteration_russian_unicodeScalars              | 68209  | 10211  | -85.0%  | **6.68x**\r\nCharIteration_japanese_unicodeScalars             | 98016  | 14690  | -85.0%  | **6.67x**\r\nCharIteration_tweet_unicodeScalars                | 161177 | 24227  | -85.0%  | **6.65x**\r\nCharIteration_chinese_unicodeScalars              | 61702  | 9278   | -85.0%  | **6.65x**\r\nCharIteration_ascii_unicodeScalars                | 81049  | 12218  | -84.9%  | **6.63x**\r\n\r\n</details>\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/446780093","html_url":"https://github.com/apple/swift/pull/10645#issuecomment-446780093","issue_url":"https://api.github.com/repos/apple/swift/issues/10645","id":446780093,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njc4MDA5Mw==","user":{"login":"palimondo","id":1046899,"node_id":"MDQ6VXNlcjEwNDY4OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1046899?v=4","gravatar_id":"","url":"https://api.github.com/users/palimondo","html_url":"https://github.com/palimondo","followers_url":"https://api.github.com/users/palimondo/followers","following_url":"https://api.github.com/users/palimondo/following{/other_user}","gists_url":"https://api.github.com/users/palimondo/gists{/gist_id}","starred_url":"https://api.github.com/users/palimondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palimondo/subscriptions","organizations_url":"https://api.github.com/users/palimondo/orgs","repos_url":"https://api.github.com/users/palimondo/repos","events_url":"https://api.github.com/users/palimondo/events{/privacy}","received_events_url":"https://api.github.com/users/palimondo/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T23:13:55Z","updated_at":"2018-12-12T23:13:55Z","author_association":"COLLABORATOR","body":"How realistic is testing iteration over `Character`'s `unicodeScalar` view from `Array`, and not directly from `String`?"}}
{"actor":{"display_login":"palimondo"}}