{"action":"closed","number":842,"pull_request":{"url":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842","id":150255931,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUwMjU1OTMx","html_url":"https://github.com/react-native-community/react-native-video/pull/842","diff_url":"https://github.com/react-native-community/react-native-video/pull/842.diff","patch_url":"https://github.com/react-native-community/react-native-video/pull/842.patch","issue_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/842","number":842,"state":"closed","locked":false,"title":" Fixed wrong orientation on Android","user":{"login":"timhonders","id":1888761,"node_id":"MDQ6VXNlcjE4ODg3NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1888761?v=4","gravatar_id":"","url":"https://api.github.com/users/timhonders","html_url":"https://github.com/timhonders","followers_url":"https://api.github.com/users/timhonders/followers","following_url":"https://api.github.com/users/timhonders/following{/other_user}","gists_url":"https://api.github.com/users/timhonders/gists{/gist_id}","starred_url":"https://api.github.com/users/timhonders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhonders/subscriptions","organizations_url":"https://api.github.com/users/timhonders/orgs","repos_url":"https://api.github.com/users/timhonders/repos","events_url":"https://api.github.com/users/timhonders/events{/privacy}","received_events_url":"https://api.github.com/users/timhonders/received_events","type":"User","site_admin":false},"body":"Android uses rotationDegrees to tell the orientation of the video.\r\n\r\nThe width and height are always landscape mode even if a video is portrait.\r\n\r\n**Fix:**\r\nTo determine the orientation i check rotation Degrees.\r\nIOS always has rotation = 0, so when it is 0 fallback to the old method.\r\n","created_at":"2017-11-02T10:40:57Z","updated_at":"2018-06-10T18:11:13Z","closed_at":"2018-06-10T18:11:13Z","merged_at":null,"merge_commit_sha":"ccc1ea1a5e0c233839838974648711a88be19125","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842/commits","review_comments_url":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842/comments","review_comment_url":"https://api.github.com/repos/react-native-community/react-native-video/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/842/comments","statuses_url":"https://api.github.com/repos/react-native-community/react-native-video/statuses/020c047ebcc409f41944fa3de9b0ea97f5cff183","head":{"label":"timhonders:master","ref":"master","sha":"020c047ebcc409f41944fa3de9b0ea97f5cff183","user":{"login":"timhonders","id":1888761,"node_id":"MDQ6VXNlcjE4ODg3NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1888761?v=4","gravatar_id":"","url":"https://api.github.com/users/timhonders","html_url":"https://github.com/timhonders","followers_url":"https://api.github.com/users/timhonders/followers","following_url":"https://api.github.com/users/timhonders/following{/other_user}","gists_url":"https://api.github.com/users/timhonders/gists{/gist_id}","starred_url":"https://api.github.com/users/timhonders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhonders/subscriptions","organizations_url":"https://api.github.com/users/timhonders/orgs","repos_url":"https://api.github.com/users/timhonders/repos","events_url":"https://api.github.com/users/timhonders/events{/privacy}","received_events_url":"https://api.github.com/users/timhonders/received_events","type":"User","site_admin":false},"repo":{"id":109100526,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxMDA1MjY=","name":"react-native-video","full_name":"timhonders/react-native-video","owner":{"login":"timhonders","id":1888761,"node_id":"MDQ6VXNlcjE4ODg3NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1888761?v=4","gravatar_id":"","url":"https://api.github.com/users/timhonders","html_url":"https://github.com/timhonders","followers_url":"https://api.github.com/users/timhonders/followers","following_url":"https://api.github.com/users/timhonders/following{/other_user}","gists_url":"https://api.github.com/users/timhonders/gists{/gist_id}","starred_url":"https://api.github.com/users/timhonders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhonders/subscriptions","organizations_url":"https://api.github.com/users/timhonders/orgs","repos_url":"https://api.github.com/users/timhonders/repos","events_url":"https://api.github.com/users/timhonders/events{/privacy}","received_events_url":"https://api.github.com/users/timhonders/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timhonders/react-native-video","description":"A <Video /> component for react-native","fork":true,"url":"https://api.github.com/repos/timhonders/react-native-video","forks_url":"https://api.github.com/repos/timhonders/react-native-video/forks","keys_url":"https://api.github.com/repos/timhonders/react-native-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timhonders/react-native-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timhonders/react-native-video/teams","hooks_url":"https://api.github.com/repos/timhonders/react-native-video/hooks","issue_events_url":"https://api.github.com/repos/timhonders/react-native-video/issues/events{/number}","events_url":"https://api.github.com/repos/timhonders/react-native-video/events","assignees_url":"https://api.github.com/repos/timhonders/react-native-video/assignees{/user}","branches_url":"https://api.github.com/repos/timhonders/react-native-video/branches{/branch}","tags_url":"https://api.github.com/repos/timhonders/react-native-video/tags","blobs_url":"https://api.github.com/repos/timhonders/react-native-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timhonders/react-native-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timhonders/react-native-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/timhonders/react-native-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timhonders/react-native-video/statuses/{sha}","languages_url":"https://api.github.com/repos/timhonders/react-native-video/languages","stargazers_url":"https://api.github.com/repos/timhonders/react-native-video/stargazers","contributors_url":"https://api.github.com/repos/timhonders/react-native-video/contributors","subscribers_url":"https://api.github.com/repos/timhonders/react-native-video/subscribers","subscription_url":"https://api.github.com/repos/timhonders/react-native-video/subscription","commits_url":"https://api.github.com/repos/timhonders/react-native-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/timhonders/react-native-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/timhonders/react-native-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/timhonders/react-native-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/timhonders/react-native-video/contents/{+path}","compare_url":"https://api.github.com/repos/timhonders/react-native-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timhonders/react-native-video/merges","archive_url":"https://api.github.com/repos/timhonders/react-native-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timhonders/react-native-video/downloads","issues_url":"https://api.github.com/repos/timhonders/react-native-video/issues{/number}","pulls_url":"https://api.github.com/repos/timhonders/react-native-video/pulls{/number}","milestones_url":"https://api.github.com/repos/timhonders/react-native-video/milestones{/number}","notifications_url":"https://api.github.com/repos/timhonders/react-native-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timhonders/react-native-video/labels{/name}","releases_url":"https://api.github.com/repos/timhonders/react-native-video/releases{/id}","deployments_url":"https://api.github.com/repos/timhonders/react-native-video/deployments","created_at":"2017-11-01T07:26:27Z","updated_at":"2017-11-01T07:26:29Z","pushed_at":"2017-11-02T10:31:24Z","git_url":"git://github.com/timhonders/react-native-video.git","ssh_url":"git@github.com:timhonders/react-native-video.git","clone_url":"https://github.com/timhonders/react-native-video.git","svn_url":"https://github.com/timhonders/react-native-video","homepage":"https://www.npmjs.com/package/react-native-video","size":10044,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-native-community:master","ref":"master","sha":"f73b7a04843fb5b17fb4fbedbe593c225594ab3b","user":{"login":"react-native-community","id":20269980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjY5OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"repo":{"id":33166041,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE2NjA0MQ==","name":"react-native-video","full_name":"react-native-community/react-native-video","owner":{"login":"react-native-community","id":20269980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjY5OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-native-community/react-native-video","description":"A <Video /> component for react-native","fork":false,"url":"https://api.github.com/repos/react-native-community/react-native-video","forks_url":"https://api.github.com/repos/react-native-community/react-native-video/forks","keys_url":"https://api.github.com/repos/react-native-community/react-native-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-native-community/react-native-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-native-community/react-native-video/teams","hooks_url":"https://api.github.com/repos/react-native-community/react-native-video/hooks","issue_events_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/events{/number}","events_url":"https://api.github.com/repos/react-native-community/react-native-video/events","assignees_url":"https://api.github.com/repos/react-native-community/react-native-video/assignees{/user}","branches_url":"https://api.github.com/repos/react-native-community/react-native-video/branches{/branch}","tags_url":"https://api.github.com/repos/react-native-community/react-native-video/tags","blobs_url":"https://api.github.com/repos/react-native-community/react-native-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-native-community/react-native-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-native-community/react-native-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-native-community/react-native-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-native-community/react-native-video/statuses/{sha}","languages_url":"https://api.github.com/repos/react-native-community/react-native-video/languages","stargazers_url":"https://api.github.com/repos/react-native-community/react-native-video/stargazers","contributors_url":"https://api.github.com/repos/react-native-community/react-native-video/contributors","subscribers_url":"https://api.github.com/repos/react-native-community/react-native-video/subscribers","subscription_url":"https://api.github.com/repos/react-native-community/react-native-video/subscription","commits_url":"https://api.github.com/repos/react-native-community/react-native-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-native-community/react-native-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-native-community/react-native-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-native-community/react-native-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-native-community/react-native-video/contents/{+path}","compare_url":"https://api.github.com/repos/react-native-community/react-native-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-native-community/react-native-video/merges","archive_url":"https://api.github.com/repos/react-native-community/react-native-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-native-community/react-native-video/downloads","issues_url":"https://api.github.com/repos/react-native-community/react-native-video/issues{/number}","pulls_url":"https://api.github.com/repos/react-native-community/react-native-video/pulls{/number}","milestones_url":"https://api.github.com/repos/react-native-community/react-native-video/milestones{/number}","notifications_url":"https://api.github.com/repos/react-native-community/react-native-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-native-community/react-native-video/labels{/name}","releases_url":"https://api.github.com/repos/react-native-community/react-native-video/releases{/id}","deployments_url":"https://api.github.com/repos/react-native-community/react-native-video/deployments","created_at":"2015-03-31T05:08:38Z","updated_at":"2018-06-10T18:05:50Z","pushed_at":"2018-06-10T18:05:44Z","git_url":"git://github.com/react-native-community/react-native-video.git","ssh_url":"git@github.com:react-native-community/react-native-video.git","clone_url":"https://github.com/react-native-community/react-native-video.git","svn_url":"https://github.com/react-native-community/react-native-video","homepage":"https://www.npmjs.com/package/react-native-video","size":10233,"stargazers_count":2964,"watchers_count":2964,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":975,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":975,"open_issues":377,"watchers":2964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842"},"html":{"href":"https://github.com/react-native-community/react-native-video/pull/842"},"issue":{"href":"https://api.github.com/repos/react-native-community/react-native-video/issues/842"},"comments":{"href":"https://api.github.com/repos/react-native-community/react-native-video/issues/842/comments"},"review_comments":{"href":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842/comments"},"review_comment":{"href":"https://api.github.com/repos/react-native-community/react-native-video/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-native-community/react-native-video/pulls/842/commits"},"statuses":{"href":"https://api.github.com/repos/react-native-community/react-native-video/statuses/020c047ebcc409f41944fa3de9b0ea97f5cff183"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":24,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"cobarx"}}