{"action":"closed","number":1550,"pull_request":{"url":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550","id":204497005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDk3MDA1","html_url":"https://github.com/inorichi/tachiyomi/pull/1550","diff_url":"https://github.com/inorichi/tachiyomi/pull/1550.diff","patch_url":"https://github.com/inorichi/tachiyomi/pull/1550.patch","issue_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/1550","number":1550,"state":"closed","locked":false,"title":"New reader","user":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"body":"This is a complete rewrite of the old reader in order to fix a few annoying bugs and add new features.\r\n\r\nI've surely missed some issues that are fixed with this PR, so please comment here if you find any.\r\n\r\nTest APKs will be uploaded and updated here whenever there's a significant progress. Feedback will be appreciated. If you already use the dev version, you'll have to overwrite the installation, but you can safely use this version because the old reader is untouched and there's a setting to toggle the new one.\r\n\r\n**Beta 1**: [link](https://github.com/inorichi/tachiyomi/files/2259845/app-standard-debug.apk.zip)\r\n**Beta 2**: [link](https://github.com/inorichi/tachiyomi/files/2263411/app-standard-debug.apk.zip)\r\n**Beta 3**: [link](https://github.com/inorichi/tachiyomi/files/2270153/app-standard-debug.apk.zip)\r\n**Beta 4**: [link](https://github.com/inorichi/tachiyomi/files/2286144/app-standard-debug.apk.zip)\r\n**Beta 5**: [link](https://github.com/inorichi/tachiyomi/files/2321476/app-standard-debug.apk.zip)\r\n**Beta 6**: [link](https://github.com/inorichi/tachiyomi/files/2340010/app-standard-debug.apk.zip)\r\n\r\n\r\nTODO:\r\n\r\n- [x] Implement basic reader functionality\r\n- [x] Add a setting to test the new reader\r\n- [x] Webtoon: Zoom the entire view instead of individual images (subsampling is disabled. Fixes #930)\r\n- [x] Pager: properly support R2L reader without view rotations (Fixes #1253)\r\n- [x] Pager: implement vertical reader with the support library's ViewPager and coordinates swapping\r\n- [x] Pager: disable built-in keys navigation (Probably fixes #1135)\r\n- [x] Support animated GIFs (crop borders and scale types are not supported. Fixes #569)\r\n- [x] Include an additional page for chapter transitions \r\n- [x] Lazy load pages (up to 7 pages ahead can be loaded. Fixes #1545)\r\n- [x] Preload next chapter pages when reaching the end\r\n- [x] Preload previous chapter pages when the transition page is active\r\n- [x] Load compressed formats without ContentProviders. Add a recycle method to release resources when appropiate (Fixes #1331)\r\n- [x] Notify state of the chapter transition loading. Show a retry button if it fails\r\n- [x] Use a determinate progress bar component without text\r\n- [x] Show initial progress bar when the reader is opened\r\n- [x] Save chapter progress and mark as read\r\n- [x] Update tracking services\r\n- [x] Update history\r\n- [x] Restore background color but through themes instead of runtime checks\r\n- [x] Restore reader settings dialog. Consider using a bottom sheet instead, it'd fix #1360\r\n- [x] Restore reader brightness and color filter feature and dialog\r\n- [x] Restore reader menu animation\r\n- [x] Restore fullscreen reading\r\n- [x] Restore long tap on page\r\n- [x] Restore volume keys navigation\r\n- [x] Restore delete downloaded chapters\r\n- [x] Disable volume keys navigation when the menu is open (Fixes #1381)\r\n- [x] Webtoon: require the bottom edge of a page to be visible before marking it as active page (Fixes #1547)\r\n- [x] Color filter sheet: Use another layout for landscape mode (Fixes #1528)\r\n- [x] Update Image decoder with fork that supports WebP\r\n- [x] Improve image sharing, avoid using `Uri` to support all the possible sources (Fixes #1516,   fixes #1115 and fixes #928)\r\n- [x] Add a progress dialog that prevents interaction when the next/prev chapter button is clicked\r\n- [x] Pager: change pages with scroll wheel events (Fixes #1580)\r\n- [x] Documentation\r\n- [ ] Improve UX of the chapter transitions page for both pager and webtoon readers (future PR)\r\n","created_at":"2018-07-27T17:46:01Z","updated_at":"2018-09-01T15:13:00Z","closed_at":"2018-09-01T15:13:00Z","merged_at":"2018-09-01T15:12:59Z","merge_commit_sha":"18f89cc341d85dbb734d370077307d33a8454f6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550/commits","review_comments_url":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550/comments","review_comment_url":"https://api.github.com/repos/inorichi/tachiyomi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/1550/comments","statuses_url":"https://api.github.com/repos/inorichi/tachiyomi/statuses/802f00a50ca3f7403e4887669421713a243a8bbf","head":{"label":"inorichi:new-reader","ref":"new-reader","sha":"802f00a50ca3f7403e4887669421713a243a8bbf","user":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"repo":{"id":43807251,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgwNzI1MQ==","name":"tachiyomi","full_name":"inorichi/tachiyomi","owner":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inorichi/tachiyomi","description":"Free and open source manga reader for Android","fork":false,"url":"https://api.github.com/repos/inorichi/tachiyomi","forks_url":"https://api.github.com/repos/inorichi/tachiyomi/forks","keys_url":"https://api.github.com/repos/inorichi/tachiyomi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inorichi/tachiyomi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inorichi/tachiyomi/teams","hooks_url":"https://api.github.com/repos/inorichi/tachiyomi/hooks","issue_events_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/events{/number}","events_url":"https://api.github.com/repos/inorichi/tachiyomi/events","assignees_url":"https://api.github.com/repos/inorichi/tachiyomi/assignees{/user}","branches_url":"https://api.github.com/repos/inorichi/tachiyomi/branches{/branch}","tags_url":"https://api.github.com/repos/inorichi/tachiyomi/tags","blobs_url":"https://api.github.com/repos/inorichi/tachiyomi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inorichi/tachiyomi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inorichi/tachiyomi/git/refs{/sha}","trees_url":"https://api.github.com/repos/inorichi/tachiyomi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inorichi/tachiyomi/statuses/{sha}","languages_url":"https://api.github.com/repos/inorichi/tachiyomi/languages","stargazers_url":"https://api.github.com/repos/inorichi/tachiyomi/stargazers","contributors_url":"https://api.github.com/repos/inorichi/tachiyomi/contributors","subscribers_url":"https://api.github.com/repos/inorichi/tachiyomi/subscribers","subscription_url":"https://api.github.com/repos/inorichi/tachiyomi/subscription","commits_url":"https://api.github.com/repos/inorichi/tachiyomi/commits{/sha}","git_commits_url":"https://api.github.com/repos/inorichi/tachiyomi/git/commits{/sha}","comments_url":"https://api.github.com/repos/inorichi/tachiyomi/comments{/number}","issue_comment_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/comments{/number}","contents_url":"https://api.github.com/repos/inorichi/tachiyomi/contents/{+path}","compare_url":"https://api.github.com/repos/inorichi/tachiyomi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inorichi/tachiyomi/merges","archive_url":"https://api.github.com/repos/inorichi/tachiyomi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inorichi/tachiyomi/downloads","issues_url":"https://api.github.com/repos/inorichi/tachiyomi/issues{/number}","pulls_url":"https://api.github.com/repos/inorichi/tachiyomi/pulls{/number}","milestones_url":"https://api.github.com/repos/inorichi/tachiyomi/milestones{/number}","notifications_url":"https://api.github.com/repos/inorichi/tachiyomi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inorichi/tachiyomi/labels{/name}","releases_url":"https://api.github.com/repos/inorichi/tachiyomi/releases{/id}","deployments_url":"https://api.github.com/repos/inorichi/tachiyomi/deployments","created_at":"2015-10-07T09:51:12Z","updated_at":"2018-08-31T19:17:56Z","pushed_at":"2018-09-01T15:12:59Z","git_url":"git://github.com/inorichi/tachiyomi.git","ssh_url":"git@github.com:inorichi/tachiyomi.git","clone_url":"https://github.com/inorichi/tachiyomi.git","svn_url":"https://github.com/inorichi/tachiyomi","homepage":"","size":8362,"stargazers_count":1905,"watchers_count":1905,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":344,"open_issues":231,"watchers":1905,"default_branch":"master"}},"base":{"label":"inorichi:master","ref":"master","sha":"7c99ae1b3bdea954c8291e1659702ed5b0bae627","user":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"repo":{"id":43807251,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgwNzI1MQ==","name":"tachiyomi","full_name":"inorichi/tachiyomi","owner":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inorichi/tachiyomi","description":"Free and open source manga reader for Android","fork":false,"url":"https://api.github.com/repos/inorichi/tachiyomi","forks_url":"https://api.github.com/repos/inorichi/tachiyomi/forks","keys_url":"https://api.github.com/repos/inorichi/tachiyomi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inorichi/tachiyomi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inorichi/tachiyomi/teams","hooks_url":"https://api.github.com/repos/inorichi/tachiyomi/hooks","issue_events_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/events{/number}","events_url":"https://api.github.com/repos/inorichi/tachiyomi/events","assignees_url":"https://api.github.com/repos/inorichi/tachiyomi/assignees{/user}","branches_url":"https://api.github.com/repos/inorichi/tachiyomi/branches{/branch}","tags_url":"https://api.github.com/repos/inorichi/tachiyomi/tags","blobs_url":"https://api.github.com/repos/inorichi/tachiyomi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inorichi/tachiyomi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inorichi/tachiyomi/git/refs{/sha}","trees_url":"https://api.github.com/repos/inorichi/tachiyomi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inorichi/tachiyomi/statuses/{sha}","languages_url":"https://api.github.com/repos/inorichi/tachiyomi/languages","stargazers_url":"https://api.github.com/repos/inorichi/tachiyomi/stargazers","contributors_url":"https://api.github.com/repos/inorichi/tachiyomi/contributors","subscribers_url":"https://api.github.com/repos/inorichi/tachiyomi/subscribers","subscription_url":"https://api.github.com/repos/inorichi/tachiyomi/subscription","commits_url":"https://api.github.com/repos/inorichi/tachiyomi/commits{/sha}","git_commits_url":"https://api.github.com/repos/inorichi/tachiyomi/git/commits{/sha}","comments_url":"https://api.github.com/repos/inorichi/tachiyomi/comments{/number}","issue_comment_url":"https://api.github.com/repos/inorichi/tachiyomi/issues/comments{/number}","contents_url":"https://api.github.com/repos/inorichi/tachiyomi/contents/{+path}","compare_url":"https://api.github.com/repos/inorichi/tachiyomi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inorichi/tachiyomi/merges","archive_url":"https://api.github.com/repos/inorichi/tachiyomi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inorichi/tachiyomi/downloads","issues_url":"https://api.github.com/repos/inorichi/tachiyomi/issues{/number}","pulls_url":"https://api.github.com/repos/inorichi/tachiyomi/pulls{/number}","milestones_url":"https://api.github.com/repos/inorichi/tachiyomi/milestones{/number}","notifications_url":"https://api.github.com/repos/inorichi/tachiyomi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inorichi/tachiyomi/labels{/name}","releases_url":"https://api.github.com/repos/inorichi/tachiyomi/releases{/id}","deployments_url":"https://api.github.com/repos/inorichi/tachiyomi/deployments","created_at":"2015-10-07T09:51:12Z","updated_at":"2018-08-31T19:17:56Z","pushed_at":"2018-09-01T15:12:59Z","git_url":"git://github.com/inorichi/tachiyomi.git","ssh_url":"git@github.com:inorichi/tachiyomi.git","clone_url":"https://github.com/inorichi/tachiyomi.git","svn_url":"https://github.com/inorichi/tachiyomi","homepage":"","size":8362,"stargazers_count":1905,"watchers_count":1905,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":344,"open_issues":231,"watchers":1905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550"},"html":{"href":"https://github.com/inorichi/tachiyomi/pull/1550"},"issue":{"href":"https://api.github.com/repos/inorichi/tachiyomi/issues/1550"},"comments":{"href":"https://api.github.com/repos/inorichi/tachiyomi/issues/1550/comments"},"review_comments":{"href":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550/comments"},"review_comment":{"href":"https://api.github.com/repos/inorichi/tachiyomi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inorichi/tachiyomi/pulls/1550/commits"},"statuses":{"href":"https://api.github.com/repos/inorichi/tachiyomi/statuses/802f00a50ca3f7403e4887669421713a243a8bbf"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"inorichi","id":3521738,"node_id":"MDQ6VXNlcjM1MjE3Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3521738?v=4","gravatar_id":"","url":"https://api.github.com/users/inorichi","html_url":"https://github.com/inorichi","followers_url":"https://api.github.com/users/inorichi/followers","following_url":"https://api.github.com/users/inorichi/following{/other_user}","gists_url":"https://api.github.com/users/inorichi/gists{/gist_id}","starred_url":"https://api.github.com/users/inorichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inorichi/subscriptions","organizations_url":"https://api.github.com/users/inorichi/orgs","repos_url":"https://api.github.com/users/inorichi/repos","events_url":"https://api.github.com/users/inorichi/events{/privacy}","received_events_url":"https://api.github.com/users/inorichi/received_events","type":"User","site_admin":false},"comments":21,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":6807,"deletions":7136,"changed_files":105}}
{"actor":{"display_login":"inorichi"}}