{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97","id":228992904,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTkyOTA0","html_url":"https://github.com/qxf2/qxf2-page-object-model/pull/97","diff_url":"https://github.com/qxf2/qxf2-page-object-model/pull/97.diff","patch_url":"https://github.com/qxf2/qxf2-page-object-model/pull/97.patch","issue_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/97","number":97,"state":"closed","locked":false,"title":"Run the Mobile app test in CircleCI","user":{"login":"indiranell","id":22164284,"node_id":"MDQ6VXNlcjIyMTY0Mjg0","avatar_url":"https://avatars0.githubusercontent.com/u/22164284?v=4","gravatar_id":"","url":"https://api.github.com/users/indiranell","html_url":"https://github.com/indiranell","followers_url":"https://api.github.com/users/indiranell/followers","following_url":"https://api.github.com/users/indiranell/following{/other_user}","gists_url":"https://api.github.com/users/indiranell/gists{/gist_id}","starred_url":"https://api.github.com/users/indiranell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiranell/subscriptions","organizations_url":"https://api.github.com/users/indiranell/orgs","repos_url":"https://api.github.com/users/indiranell/repos","events_url":"https://api.github.com/users/indiranell/events{/privacy}","received_events_url":"https://api.github.com/users/indiranell/received_events","type":"User","site_admin":false},"body":"The goal is to run the mobile app test using BrowserStack in CircleCI. During this process encountered two issues which were fixed. \r\n1) One is removing user input option from the mobile test and get app_path as a conftest option and \r\n2) Include a check to remove spaces from the app_name in the saucec_upload method too(earlier we included this check only in run_mobile method)\r\n\r\nChanges made in circleci/config.yml file:\r\n\r\n* Cloned the bitcoin app in the circle config.yml \r\n* Setting env variable for getting the app_path in the .yml \r\n* Updated the pytest command to include a parameter for app_path.\r\n\r\nChanges made in conftest.py:\r\n\r\n* Added a new option '-N' to for getting the app_path\r\n* Added new pytest fixture for app_path\r\n\r\nChanges made in test_mobile_bitcoin_app.py:\r\n\r\n* Removed the code to accept input from the user\r\n* Added app_path parameter in the test method\r\n\r\nChanges made to the DriverFactory.py:\r\n\r\n* Added a check to see if the upload response status_code is 200 in sauce_upload() method and return result_flag \r\n* Included the condition to check for spaces in apk file in sauce_upload method also so that we upload the file without spaces\r\n\r\nKindly review.","created_at":"2018-11-07T11:10:03Z","updated_at":"2018-11-13T04:42:35Z","closed_at":"2018-11-13T04:42:35Z","merged_at":"2018-11-13T04:42:35Z","merge_commit_sha":"cc5c0f1ba443b8194335f642eaa852e7a2199167","assignee":{"login":"indiranell","id":22164284,"node_id":"MDQ6VXNlcjIyMTY0Mjg0","avatar_url":"https://avatars0.githubusercontent.com/u/22164284?v=4","gravatar_id":"","url":"https://api.github.com/users/indiranell","html_url":"https://github.com/indiranell","followers_url":"https://api.github.com/users/indiranell/followers","following_url":"https://api.github.com/users/indiranell/following{/other_user}","gists_url":"https://api.github.com/users/indiranell/gists{/gist_id}","starred_url":"https://api.github.com/users/indiranell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiranell/subscriptions","organizations_url":"https://api.github.com/users/indiranell/orgs","repos_url":"https://api.github.com/users/indiranell/repos","events_url":"https://api.github.com/users/indiranell/events{/privacy}","received_events_url":"https://api.github.com/users/indiranell/received_events","type":"User","site_admin":false},"assignees":[{"login":"indiranell","id":22164284,"node_id":"MDQ6VXNlcjIyMTY0Mjg0","avatar_url":"https://avatars0.githubusercontent.com/u/22164284?v=4","gravatar_id":"","url":"https://api.github.com/users/indiranell","html_url":"https://github.com/indiranell","followers_url":"https://api.github.com/users/indiranell/followers","following_url":"https://api.github.com/users/indiranell/following{/other_user}","gists_url":"https://api.github.com/users/indiranell/gists{/gist_id}","starred_url":"https://api.github.com/users/indiranell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiranell/subscriptions","organizations_url":"https://api.github.com/users/indiranell/orgs","repos_url":"https://api.github.com/users/indiranell/repos","events_url":"https://api.github.com/users/indiranell/events{/privacy}","received_events_url":"https://api.github.com/users/indiranell/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"avinash010","id":15868709,"node_id":"MDQ6VXNlcjE1ODY4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/15868709?v=4","gravatar_id":"","url":"https://api.github.com/users/avinash010","html_url":"https://github.com/avinash010","followers_url":"https://api.github.com/users/avinash010/followers","following_url":"https://api.github.com/users/avinash010/following{/other_user}","gists_url":"https://api.github.com/users/avinash010/gists{/gist_id}","starred_url":"https://api.github.com/users/avinash010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avinash010/subscriptions","organizations_url":"https://api.github.com/users/avinash010/orgs","repos_url":"https://api.github.com/users/avinash010/repos","events_url":"https://api.github.com/users/avinash010/events{/privacy}","received_events_url":"https://api.github.com/users/avinash010/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97/commits","review_comments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97/comments","review_comment_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/97/comments","statuses_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/statuses/1cd841633015cf83fb47d8e7cc4c34d894152b8a","head":{"label":"qxf2:bitcoin_test_circleci","ref":"bitcoin_test_circleci","sha":"1cd841633015cf83fb47d8e7cc4c34d894152b8a","user":{"login":"qxf2","id":4759449,"node_id":"MDQ6VXNlcjQ3NTk0NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4759449?v=4","gravatar_id":"","url":"https://api.github.com/users/qxf2","html_url":"https://github.com/qxf2","followers_url":"https://api.github.com/users/qxf2/followers","following_url":"https://api.github.com/users/qxf2/following{/other_user}","gists_url":"https://api.github.com/users/qxf2/gists{/gist_id}","starred_url":"https://api.github.com/users/qxf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxf2/subscriptions","organizations_url":"https://api.github.com/users/qxf2/orgs","repos_url":"https://api.github.com/users/qxf2/repos","events_url":"https://api.github.com/users/qxf2/events{/privacy}","received_events_url":"https://api.github.com/users/qxf2/received_events","type":"User","site_admin":false},"repo":{"id":77039202,"node_id":"MDEwOlJlcG9zaXRvcnk3NzAzOTIwMg==","name":"qxf2-page-object-model","full_name":"qxf2/qxf2-page-object-model","private":false,"owner":{"login":"qxf2","id":4759449,"node_id":"MDQ6VXNlcjQ3NTk0NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4759449?v=4","gravatar_id":"","url":"https://api.github.com/users/qxf2","html_url":"https://github.com/qxf2","followers_url":"https://api.github.com/users/qxf2/followers","following_url":"https://api.github.com/users/qxf2/following{/other_user}","gists_url":"https://api.github.com/users/qxf2/gists{/gist_id}","starred_url":"https://api.github.com/users/qxf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxf2/subscriptions","organizations_url":"https://api.github.com/users/qxf2/orgs","repos_url":"https://api.github.com/users/qxf2/repos","events_url":"https://api.github.com/users/qxf2/events{/privacy}","received_events_url":"https://api.github.com/users/qxf2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qxf2/qxf2-page-object-model","description":"Write Selenium and Appium tests in Python using the Page Object pattern. This Pythonic GUI and API test automation framework will help you get started with QA automation quickly. It comes with many useful integrations like - email, BrowserStack, Slack, TestRail, etc. This repository is developed and maintained by Qxf2 Services (https://qxf2.com). ","fork":false,"url":"https://api.github.com/repos/qxf2/qxf2-page-object-model","forks_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/forks","keys_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/teams","hooks_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/hooks","issue_events_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/events{/number}","events_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/events","assignees_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/assignees{/user}","branches_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/branches{/branch}","tags_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/tags","blobs_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/statuses/{sha}","languages_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/languages","stargazers_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/stargazers","contributors_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/contributors","subscribers_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/subscribers","subscription_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/subscription","commits_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/contents/{+path}","compare_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/merges","archive_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/downloads","issues_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues{/number}","pulls_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls{/number}","milestones_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/milestones{/number}","notifications_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/labels{/name}","releases_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/releases{/id}","deployments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/deployments","created_at":"2016-12-21T09:50:23Z","updated_at":"2018-11-06T08:22:55Z","pushed_at":"2018-11-13T04:42:35Z","git_url":"git://github.com/qxf2/qxf2-page-object-model.git","ssh_url":"git@github.com:qxf2/qxf2-page-object-model.git","clone_url":"https://github.com/qxf2/qxf2-page-object-model.git","svn_url":"https://github.com/qxf2/qxf2-page-object-model","homepage":"","size":1622,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":5,"watchers":47,"default_branch":"master"}},"base":{"label":"qxf2:master","ref":"master","sha":"3a0033928bd530e361a79cdab3d43f439ae19974","user":{"login":"qxf2","id":4759449,"node_id":"MDQ6VXNlcjQ3NTk0NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4759449?v=4","gravatar_id":"","url":"https://api.github.com/users/qxf2","html_url":"https://github.com/qxf2","followers_url":"https://api.github.com/users/qxf2/followers","following_url":"https://api.github.com/users/qxf2/following{/other_user}","gists_url":"https://api.github.com/users/qxf2/gists{/gist_id}","starred_url":"https://api.github.com/users/qxf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxf2/subscriptions","organizations_url":"https://api.github.com/users/qxf2/orgs","repos_url":"https://api.github.com/users/qxf2/repos","events_url":"https://api.github.com/users/qxf2/events{/privacy}","received_events_url":"https://api.github.com/users/qxf2/received_events","type":"User","site_admin":false},"repo":{"id":77039202,"node_id":"MDEwOlJlcG9zaXRvcnk3NzAzOTIwMg==","name":"qxf2-page-object-model","full_name":"qxf2/qxf2-page-object-model","private":false,"owner":{"login":"qxf2","id":4759449,"node_id":"MDQ6VXNlcjQ3NTk0NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4759449?v=4","gravatar_id":"","url":"https://api.github.com/users/qxf2","html_url":"https://github.com/qxf2","followers_url":"https://api.github.com/users/qxf2/followers","following_url":"https://api.github.com/users/qxf2/following{/other_user}","gists_url":"https://api.github.com/users/qxf2/gists{/gist_id}","starred_url":"https://api.github.com/users/qxf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxf2/subscriptions","organizations_url":"https://api.github.com/users/qxf2/orgs","repos_url":"https://api.github.com/users/qxf2/repos","events_url":"https://api.github.com/users/qxf2/events{/privacy}","received_events_url":"https://api.github.com/users/qxf2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qxf2/qxf2-page-object-model","description":"Write Selenium and Appium tests in Python using the Page Object pattern. This Pythonic GUI and API test automation framework will help you get started with QA automation quickly. It comes with many useful integrations like - email, BrowserStack, Slack, TestRail, etc. This repository is developed and maintained by Qxf2 Services (https://qxf2.com). ","fork":false,"url":"https://api.github.com/repos/qxf2/qxf2-page-object-model","forks_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/forks","keys_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/teams","hooks_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/hooks","issue_events_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/events{/number}","events_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/events","assignees_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/assignees{/user}","branches_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/branches{/branch}","tags_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/tags","blobs_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/statuses/{sha}","languages_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/languages","stargazers_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/stargazers","contributors_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/contributors","subscribers_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/subscribers","subscription_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/subscription","commits_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/contents/{+path}","compare_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/merges","archive_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/downloads","issues_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues{/number}","pulls_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls{/number}","milestones_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/milestones{/number}","notifications_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/labels{/name}","releases_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/releases{/id}","deployments_url":"https://api.github.com/repos/qxf2/qxf2-page-object-model/deployments","created_at":"2016-12-21T09:50:23Z","updated_at":"2018-11-06T08:22:55Z","pushed_at":"2018-11-13T04:42:35Z","git_url":"git://github.com/qxf2/qxf2-page-object-model.git","ssh_url":"git@github.com:qxf2/qxf2-page-object-model.git","clone_url":"https://github.com/qxf2/qxf2-page-object-model.git","svn_url":"https://github.com/qxf2/qxf2-page-object-model","homepage":"","size":1622,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":5,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97"},"html":{"href":"https://github.com/qxf2/qxf2-page-object-model/pull/97"},"issue":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/97"},"comments":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/qxf2/qxf2-page-object-model/statuses/1cd841633015cf83fb47d8e7cc4c34d894152b8a"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"raddhakrishnan","id":36443969,"node_id":"MDQ6VXNlcjM2NDQzOTY5","avatar_url":"https://avatars1.githubusercontent.com/u/36443969?v=4","gravatar_id":"","url":"https://api.github.com/users/raddhakrishnan","html_url":"https://github.com/raddhakrishnan","followers_url":"https://api.github.com/users/raddhakrishnan/followers","following_url":"https://api.github.com/users/raddhakrishnan/following{/other_user}","gists_url":"https://api.github.com/users/raddhakrishnan/gists{/gist_id}","starred_url":"https://api.github.com/users/raddhakrishnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raddhakrishnan/subscriptions","organizations_url":"https://api.github.com/users/raddhakrishnan/orgs","repos_url":"https://api.github.com/users/raddhakrishnan/repos","events_url":"https://api.github.com/users/raddhakrishnan/events{/privacy}","received_events_url":"https://api.github.com/users/raddhakrishnan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":19,"additions":32,"deletions":12,"changed_files":4}}
{"actor":{"display_login":"raddhakrishnan"}}