{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/221676270","pull_request_review_id":160382701,"id":221676270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTY3NjI3MA==","diff_hunk":"@@ -0,0 +1,81 @@\n+# MCU name\n+#MCU = at90usb1286\n+MCU = atmega32u4\n+\n+# Processor frequency.\n+#     This will define a symbol, F_CPU, in all source code files equal to the\n+#     processor frequency in Hz. You can then use this symbol in your source code to\n+#     calculate timings. Do NOT tack on a 'UL' at the end, this will be done\n+#     automatically to create a 32-bit value in your source code.\n+#\n+#     This will be an integer division of F_USB below, as it is sourced by\n+#     F_USB after it has run through any CPU prescalers. Note that this value\n+#     does not *change* the processor frequency - it should merely be updated to\n+#     reflect the processor speed set externally so that the code can use accurate\n+#     software delays.\n+F_CPU = 16000000\n+\n+\n+#\n+# LUFA specific\n+#\n+# Target architecture (see library \"Board Types\" documentation).\n+ARCH = AVR8\n+\n+# Input clock frequency.\n+#     This will define a symbol, F_USB, in all source code files equal to the\n+#     input clock frequency (before any prescaling is performed) in Hz. This value may\n+#     differ from F_CPU if prescaling is used on the latter, and is required as the\n+#     raw input clock is fed directly to the PLL sections of the AVR for high speed\n+#     clock generation for the USB and other AVR subsections. Do NOT tack on a 'UL'\n+#     at the end, this will be done automatically to create a 32-bit value in your\n+#     source code.\n+#\n+#     If no clock division is performed on the input clock inside the AVR (via the\n+#     CPU clock adjust registers or the clock division fuses), this will be equal to F_CPU.\n+F_USB = $(F_CPU)\n+\n+# Interrupt driven control endpoint task(+60)\n+OPT_DEFS += -DINTERRUPT_CONTROL_ENDPOINT\n+\n+\n+# Bootloader selection\n+#   Teensy       halfkay\n+#   Pro Micro    caterina\n+#   Atmel DFU    atmel-dfu\n+#   LUFA DFU     lufa-dfu\n+#   QMK DFU      qmk-dfu\n+#   atmega32a    bootloadHID\n+BOOTLOADER = atmel-dfu\n+\n+\n+# If you don't know the bootloader type, then you can specify the\n+# Boot Section Size in *bytes* by uncommenting out the OPT_DEFS line\n+#   Teensy halfKay      512\n+#   Teensy++ halfKay    1024\n+#   Atmel DFU loader    4096\n+#   LUFA bootloader     4096\n+#   USBaspLoader        2048\n+# OPT_DEFS += -DBOOTLOADER_SIZE=4096","path":"keyboards/kbd4x/rules.mk","position":59,"original_position":59,"commit_id":"aaf4a9406cc0fb852ba2dc4b113f52db3074e028","original_commit_id":"fcf95b61ed3378d4c68b5ad4c234473870dae8fb","user":{"login":"drashna","id":2584963,"node_id":"MDQ6VXNlcjI1ODQ5NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2584963?v=4","gravatar_id":"","url":"https://api.github.com/users/drashna","html_url":"https://github.com/drashna","followers_url":"https://api.github.com/users/drashna/followers","following_url":"https://api.github.com/users/drashna/following{/other_user}","gists_url":"https://api.github.com/users/drashna/gists{/gist_id}","starred_url":"https://api.github.com/users/drashna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drashna/subscriptions","organizations_url":"https://api.github.com/users/drashna/orgs","repos_url":"https://api.github.com/users/drashna/repos","events_url":"https://api.github.com/users/drashna/events{/privacy}","received_events_url":"https://api.github.com/users/drashna/received_events","type":"User","site_admin":false},"body":"@mechmerlin The bootloader type is specified, so we don't need the actual size.\r\n\r\nIn fact, because the bootloader is set, the size gets defined here: \r\n\r\nhttps://github.com/qmk/qmk_firmware/blob/master/bootloader.mk#L32-L41","created_at":"2018-10-01T16:38:18Z","updated_at":"2018-10-01T16:38:32Z","html_url":"https://github.com/qmk/qmk_firmware/pull/4036#discussion_r221676270","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/221676270"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4036#discussion_r221676270"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036"}},"in_reply_to_id":221663164},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036","id":219404917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDA0OTE3","html_url":"https://github.com/qmk/qmk_firmware/pull/4036","diff_url":"https://github.com/qmk/qmk_firmware/pull/4036.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4036.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4036","number":4036,"state":"open","locked":false,"title":"Add support for the KBD4x","user":{"login":"sevenseacat","id":543859,"node_id":"MDQ6VXNlcjU0Mzg1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/543859?v=4","gravatar_id":"","url":"https://api.github.com/users/sevenseacat","html_url":"https://github.com/sevenseacat","followers_url":"https://api.github.com/users/sevenseacat/followers","following_url":"https://api.github.com/users/sevenseacat/following{/other_user}","gists_url":"https://api.github.com/users/sevenseacat/gists{/gist_id}","starred_url":"https://api.github.com/users/sevenseacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevenseacat/subscriptions","organizations_url":"https://api.github.com/users/sevenseacat/orgs","repos_url":"https://api.github.com/users/sevenseacat/repos","events_url":"https://api.github.com/users/sevenseacat/events{/privacy}","received_events_url":"https://api.github.com/users/sevenseacat/received_events","type":"User","site_admin":false},"body":"I think I've got everything right here-  have taken the default keymap and wiring information from http://qmkeyboard.cn/.\r\n\r\nI flashed my own KBD4x with a slightly modified version of the default keymap, and all of the functionality still worked!","created_at":"2018-10-01T14:51:03Z","updated_at":"2018-10-01T16:38:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4c2676741e965d5bf9f8f0462091f5a1984d2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4036/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/aaf4a9406cc0fb852ba2dc4b113f52db3074e028","head":{"label":"sevenseacat:feature/kbd4x","ref":"feature/kbd4x","sha":"aaf4a9406cc0fb852ba2dc4b113f52db3074e028","user":{"login":"sevenseacat","id":543859,"node_id":"MDQ6VXNlcjU0Mzg1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/543859?v=4","gravatar_id":"","url":"https://api.github.com/users/sevenseacat","html_url":"https://github.com/sevenseacat","followers_url":"https://api.github.com/users/sevenseacat/followers","following_url":"https://api.github.com/users/sevenseacat/following{/other_user}","gists_url":"https://api.github.com/users/sevenseacat/gists{/gist_id}","starred_url":"https://api.github.com/users/sevenseacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevenseacat/subscriptions","organizations_url":"https://api.github.com/users/sevenseacat/orgs","repos_url":"https://api.github.com/users/sevenseacat/repos","events_url":"https://api.github.com/users/sevenseacat/events{/privacy}","received_events_url":"https://api.github.com/users/sevenseacat/received_events","type":"User","site_admin":false},"repo":{"id":151102953,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMDI5NTM=","name":"qmk_firmware","full_name":"sevenseacat/qmk_firmware","private":false,"owner":{"login":"sevenseacat","id":543859,"node_id":"MDQ6VXNlcjU0Mzg1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/543859?v=4","gravatar_id":"","url":"https://api.github.com/users/sevenseacat","html_url":"https://github.com/sevenseacat","followers_url":"https://api.github.com/users/sevenseacat/followers","following_url":"https://api.github.com/users/sevenseacat/following{/other_user}","gists_url":"https://api.github.com/users/sevenseacat/gists{/gist_id}","starred_url":"https://api.github.com/users/sevenseacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevenseacat/subscriptions","organizations_url":"https://api.github.com/users/sevenseacat/orgs","repos_url":"https://api.github.com/users/sevenseacat/repos","events_url":"https://api.github.com/users/sevenseacat/events{/privacy}","received_events_url":"https://api.github.com/users/sevenseacat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sevenseacat/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":true,"url":"https://api.github.com/repos/sevenseacat/qmk_firmware","forks_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/forks","keys_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/events","assignees_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/merges","archive_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/sevenseacat/qmk_firmware/deployments","created_at":"2018-10-01T14:31:44Z","updated_at":"2018-10-01T14:32:06Z","pushed_at":"2018-10-01T16:12:44Z","git_url":"git://github.com/sevenseacat/qmk_firmware.git","ssh_url":"git@github.com:sevenseacat/qmk_firmware.git","clone_url":"https://github.com/sevenseacat/qmk_firmware.git","svn_url":"https://github.com/sevenseacat/qmk_firmware","homepage":"http://qmk.fm","size":104449,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"a398d2cece1ee69006cf26e9a86fbf38e1acb0d1","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","private":false,"owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-10-01T16:34:43Z","pushed_at":"2018-10-01T16:35:42Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":104440,"stargazers_count":3018,"watchers_count":3018,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5591,"mirror_url":null,"archived":false,"open_issues_count":372,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5591,"open_issues":372,"watchers":3018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4036"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4036"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4036/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4036/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/aaf4a9406cc0fb852ba2dc4b113f52db3074e028"}},"author_association":"NONE"}}
{"actor":{"display_login":"drashna"}}