{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/232431982","pull_request_review_id":173639159,"id":232431982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQzMTk4Mg==","diff_hunk":"@@ -294,7 +296,6 @@ func (d *Driver) RecoverTask(handle *drivers.TaskHandle) error {\n \tgo h.run()\n \treturn nil\n }\n-","path":"drivers/rawexec/driver.go","position":14,"original_position":14,"commit_id":"991147ab1703a3d5686a2052d844f275983b4618","original_commit_id":"991147ab1703a3d5686a2052d844f275983b4618","user":{"login":"dantoml","id":1330683,"node_id":"MDQ6VXNlcjEzMzA2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1330683?v=4","gravatar_id":"","url":"https://api.github.com/users/dantoml","html_url":"https://github.com/dantoml","followers_url":"https://api.github.com/users/dantoml/followers","following_url":"https://api.github.com/users/dantoml/following{/other_user}","gists_url":"https://api.github.com/users/dantoml/gists{/gist_id}","starred_url":"https://api.github.com/users/dantoml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantoml/subscriptions","organizations_url":"https://api.github.com/users/dantoml/orgs","repos_url":"https://api.github.com/users/dantoml/repos","events_url":"https://api.github.com/users/dantoml/events{/privacy}","received_events_url":"https://api.github.com/users/dantoml/received_events","type":"User","site_admin":false},"body":"accidental rm, will remove this from the diff","created_at":"2018-11-10T00:47:16Z","updated_at":"2018-11-10T00:47:16Z","html_url":"https://github.com/hashicorp/nomad/pull/4859#discussion_r232431982","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4859","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/232431982"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4859#discussion_r232431982"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4859"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/4859","id":229856841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODU2ODQx","html_url":"https://github.com/hashicorp/nomad/pull/4859","diff_url":"https://github.com/hashicorp/nomad/pull/4859.diff","patch_url":"https://github.com/hashicorp/nomad/pull/4859.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/4859","number":4859,"state":"open","locked":false,"title":"rawexec: Only use cgroups when running as root.","user":{"login":"dantoml","id":1330683,"node_id":"MDQ6VXNlcjEzMzA2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1330683?v=4","gravatar_id":"","url":"https://api.github.com/users/dantoml","html_url":"https://github.com/dantoml","followers_url":"https://api.github.com/users/dantoml/followers","following_url":"https://api.github.com/users/dantoml/following{/other_user}","gists_url":"https://api.github.com/users/dantoml/gists{/gist_id}","starred_url":"https://api.github.com/users/dantoml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantoml/subscriptions","organizations_url":"https://api.github.com/users/dantoml/orgs","repos_url":"https://api.github.com/users/dantoml/repos","events_url":"https://api.github.com/users/dantoml/events{/privacy}","received_events_url":"https://api.github.com/users/dantoml/received_events","type":"User","site_admin":false},"body":"If Nomad is not running as root, we should not try to use cgroups for pid\nfreezing.\n\nThis originally was implemented pre-driver-support in\nhttps://github.com/hashicorp/nomad/blob/v0.8.6/client/driver/raw_exec.go#L120-L130","created_at":"2018-11-10T00:45:22Z","updated_at":"2018-11-10T00:47:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c3afe2ca3dee525c2f39d5dbe41d8dbc5c358d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4859/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4859/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/4859/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/991147ab1703a3d5686a2052d844f275983b4618","head":{"label":"hashicorp:b-rawexec-cgroups-root","ref":"b-rawexec-cgroups-root","sha":"991147ab1703a3d5686a2052d844f275983b4618","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY1MzQzMA==","name":"nomad","full_name":"hashicorp/nomad","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-11-09T22:36:42Z","pushed_at":"2018-11-10T00:45:22Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":113753,"stargazers_count":3990,"watchers_count":3990,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":782,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":782,"open_issues":451,"watchers":3990,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"31045da9bedfde4a416d271718e645d6ca0bc716","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY1MzQzMA==","name":"nomad","full_name":"hashicorp/nomad","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-11-09T22:36:42Z","pushed_at":"2018-11-10T00:45:22Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":113753,"stargazers_count":3990,"watchers_count":3990,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":782,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":782,"open_issues":451,"watchers":3990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4859"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4859"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4859"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4859/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4859/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4859/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/991147ab1703a3d5686a2052d844f275983b4618"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dantoml"}}