{"action":"closed","number":5080,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/5080","id":197670051,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjcwMDUx","html_url":"https://github.com/serverless/serverless/pull/5080","diff_url":"https://github.com/serverless/serverless/pull/5080.diff","patch_url":"https://github.com/serverless/serverless/pull/5080.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/5080","number":5080,"state":"closed","locked":false,"title":"add PRIVATE endpointType","user":{"login":"ijin","id":93147,"node_id":"MDQ6VXNlcjkzMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/93147?v=4","gravatar_id":"","url":"https://api.github.com/users/ijin","html_url":"https://github.com/ijin","followers_url":"https://api.github.com/users/ijin/followers","following_url":"https://api.github.com/users/ijin/following{/other_user}","gists_url":"https://api.github.com/users/ijin/gists{/gist_id}","starred_url":"https://api.github.com/users/ijin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijin/subscriptions","organizations_url":"https://api.github.com/users/ijin/orgs","repos_url":"https://api.github.com/users/ijin/repos","events_url":"https://api.github.com/users/ijin/events{/privacy}","received_events_url":"https://api.github.com/users/ijin/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nAdded `PRIVATE` [endpointType](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-restapi-endpointconfiguration.html) for API Gateway\r\n\r\nCloses #5063 #5052\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\nAdded `PRIVATE` to `validEndpointTypes` const variable with more specific tests.\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* Cloud Configuration - List cloud resources and show that the correct configuration is in place (e.g. AWS CLI commands)\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n```yaml:serverless.yml\r\nservice: private-endpoint-test\r\nprovider:\r\n  name: aws\r\n  runtime: nodejs6.10\r\n  endpointType: private\r\n\r\nfunctions:\r\n  helloWorld:\r\n    handler: handler.hello\r\n    events:\r\n      - http:\r\n          path: hello\r\n          method: get\r\n```\r\n\r\n```shell\r\n$ aws --region us-east-1 apigateway get-rest-apis \r\n\r\n{\r\n    \"items\": [\r\n        {\r\n            \"id\": \"gxq77iec19\",\r\n            \"name\": \"dev-private-gw-test\",\r\n            \"createdDate\": 1530087544,\r\n            \"apiKeySource\": \"HEADER\",\r\n            \"endpointConfiguration\": {\r\n                \"types\": [\r\n                    \"PRIVATE\"\r\n                ]\r\n            }\r\n        }\r\n    ]\r\n}\r\n```\r\n\r\n## Todos:\r\n\r\n- [x] Write tests\r\n- [x] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config / commands / resources\r\n- [x] Enable \"Allow edits from maintainers\" for this PR\r\n- [x] Update the messages below\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO","created_at":"2018-06-27T09:28:40Z","updated_at":"2018-07-03T00:07:19Z","closed_at":"2018-07-03T00:07:19Z","merged_at":"2018-07-03T00:07:19Z","merge_commit_sha":"2416c68bab14cc883e8a4f0ee93c39c88f43c51b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484058097,"node_id":"MDU6TGFiZWw0ODQwNTgwOTc=","url":"https://api.github.com/repos/serverless/serverless/labels/stage/in-review","name":"stage/in-review","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/serverless/serverless/milestones/43","html_url":"https://github.com/serverless/serverless/milestone/43","labels_url":"https://api.github.com/repos/serverless/serverless/milestones/43/labels","id":3295356,"node_id":"MDk6TWlsZXN0b25lMzI5NTM1Ng==","number":43,"title":"1.28","description":"","creator":{"login":"HyperBrain","id":5524702,"node_id":"MDQ6VXNlcjU1MjQ3MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5524702?v=4","gravatar_id":"","url":"https://api.github.com/users/HyperBrain","html_url":"https://github.com/HyperBrain","followers_url":"https://api.github.com/users/HyperBrain/followers","following_url":"https://api.github.com/users/HyperBrain/following{/other_user}","gists_url":"https://api.github.com/users/HyperBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperBrain/subscriptions","organizations_url":"https://api.github.com/users/HyperBrain/orgs","repos_url":"https://api.github.com/users/HyperBrain/repos","events_url":"https://api.github.com/users/HyperBrain/events{/privacy}","received_events_url":"https://api.github.com/users/HyperBrain/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":24,"state":"open","created_at":"2018-04-25T07:38:02Z","updated_at":"2018-07-03T00:07:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/5080/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/5080/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/5080/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/38fe02ef81ac60967852dd4489e5f6dfec3ce3b3","head":{"label":"ijin:private-endpoint","ref":"private-endpoint","sha":"38fe02ef81ac60967852dd4489e5f6dfec3ce3b3","user":{"login":"ijin","id":93147,"node_id":"MDQ6VXNlcjkzMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/93147?v=4","gravatar_id":"","url":"https://api.github.com/users/ijin","html_url":"https://github.com/ijin","followers_url":"https://api.github.com/users/ijin/followers","following_url":"https://api.github.com/users/ijin/following{/other_user}","gists_url":"https://api.github.com/users/ijin/gists{/gist_id}","starred_url":"https://api.github.com/users/ijin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijin/subscriptions","organizations_url":"https://api.github.com/users/ijin/orgs","repos_url":"https://api.github.com/users/ijin/repos","events_url":"https://api.github.com/users/ijin/events{/privacy}","received_events_url":"https://api.github.com/users/ijin/received_events","type":"User","site_admin":false},"repo":{"id":118924599,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5MjQ1OTk=","name":"serverless","full_name":"ijin/serverless","owner":{"login":"ijin","id":93147,"node_id":"MDQ6VXNlcjkzMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/93147?v=4","gravatar_id":"","url":"https://api.github.com/users/ijin","html_url":"https://github.com/ijin","followers_url":"https://api.github.com/users/ijin/followers","following_url":"https://api.github.com/users/ijin/following{/other_user}","gists_url":"https://api.github.com/users/ijin/gists{/gist_id}","starred_url":"https://api.github.com/users/ijin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijin/subscriptions","organizations_url":"https://api.github.com/users/ijin/orgs","repos_url":"https://api.github.com/users/ijin/repos","events_url":"https://api.github.com/users/ijin/events{/privacy}","received_events_url":"https://api.github.com/users/ijin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijin/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/ijin/serverless","forks_url":"https://api.github.com/repos/ijin/serverless/forks","keys_url":"https://api.github.com/repos/ijin/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijin/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijin/serverless/teams","hooks_url":"https://api.github.com/repos/ijin/serverless/hooks","issue_events_url":"https://api.github.com/repos/ijin/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/ijin/serverless/events","assignees_url":"https://api.github.com/repos/ijin/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/ijin/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/ijin/serverless/tags","blobs_url":"https://api.github.com/repos/ijin/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijin/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijin/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijin/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijin/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/ijin/serverless/languages","stargazers_url":"https://api.github.com/repos/ijin/serverless/stargazers","contributors_url":"https://api.github.com/repos/ijin/serverless/contributors","subscribers_url":"https://api.github.com/repos/ijin/serverless/subscribers","subscription_url":"https://api.github.com/repos/ijin/serverless/subscription","commits_url":"https://api.github.com/repos/ijin/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijin/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijin/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijin/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijin/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/ijin/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijin/serverless/merges","archive_url":"https://api.github.com/repos/ijin/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijin/serverless/downloads","issues_url":"https://api.github.com/repos/ijin/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/ijin/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/ijin/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/ijin/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijin/serverless/labels{/name}","releases_url":"https://api.github.com/repos/ijin/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/ijin/serverless/deployments","created_at":"2018-01-25T14:39:59Z","updated_at":"2018-01-25T14:40:03Z","pushed_at":"2018-06-27T10:08:11Z","git_url":"git://github.com/ijin/serverless.git","ssh_url":"git@github.com:ijin/serverless.git","clone_url":"https://github.com/ijin/serverless.git","svn_url":"https://github.com/ijin/serverless","homepage":"http://www.serverless.com","size":78343,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"6da3a9d9e4e2923fa81cf0c385ba1a9c27ddc072","user":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"node_id":"MDEwOlJlcG9zaXRvcnkzNDMwMjY5OA==","name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzQyNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2018-07-02T22:16:45Z","pushed_at":"2018-07-03T00:07:19Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":78969,"stargazers_count":24348,"watchers_count":24348,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2590,"mirror_url":null,"archived":false,"open_issues_count":593,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2590,"open_issues":593,"watchers":24348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/5080"},"html":{"href":"https://github.com/serverless/serverless/pull/5080"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/5080"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/5080/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/5080/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/5080/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/38fe02ef81ac60967852dd4489e5f6dfec3ce3b3"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"horike37","id":1301012,"node_id":"MDQ6VXNlcjEzMDEwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1301012?v=4","gravatar_id":"","url":"https://api.github.com/users/horike37","html_url":"https://github.com/horike37","followers_url":"https://api.github.com/users/horike37/followers","following_url":"https://api.github.com/users/horike37/following{/other_user}","gists_url":"https://api.github.com/users/horike37/gists{/gist_id}","starred_url":"https://api.github.com/users/horike37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horike37/subscriptions","organizations_url":"https://api.github.com/users/horike37/orgs","repos_url":"https://api.github.com/users/horike37/repos","events_url":"https://api.github.com/users/horike37/events{/privacy}","received_events_url":"https://api.github.com/users/horike37/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"horike37"}}