{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/comments/215073821","pull_request_review_id":152262113,"id":215073821,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA3MzgyMQ==","diff_hunk":"@@ -1,18 +1,38 @@\n Running the Functional Tests\n-==\n+============================\n+\n+Functional tests run against a set of Docker containers that mimic the AWS stack this service runs on\n+in production.\n+\n+To run the functional tests with a Python 2.7 image, do this:\n \n ```bash\n-> docker build -t fsm -f tests/functional/Dockerfile .\n-> docker build -t fsm_docker_runner -f tools/experimental/Dockerfile.fsm_docker_runner .\n-> docker build -t dev_ecs -f tools/experimental/Dockerfile.dev_ecs .\n-> docker run \\\n+$ docker build -t fsm_docker_runner -f tools/experimental/Dockerfile.fsm_docker_runner .","path":"tests/functional/README.md","position":15,"original_position":15,"commit_id":"e5d2a96f3d83eae9eb25b6710f3a7aa281972824","original_commit_id":"e5d2a96f3d83eae9eb25b6710f3a7aa281972824","user":{"login":"shawnrusaw-wf","id":1690698,"node_id":"MDQ6VXNlcjE2OTA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1690698?v=4","gravatar_id":"","url":"https://api.github.com/users/shawnrusaw-wf","html_url":"https://github.com/shawnrusaw-wf","followers_url":"https://api.github.com/users/shawnrusaw-wf/followers","following_url":"https://api.github.com/users/shawnrusaw-wf/following{/other_user}","gists_url":"https://api.github.com/users/shawnrusaw-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnrusaw-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnrusaw-wf/subscriptions","organizations_url":"https://api.github.com/users/shawnrusaw-wf/orgs","repos_url":"https://api.github.com/users/shawnrusaw-wf/repos","events_url":"https://api.github.com/users/shawnrusaw-wf/events{/privacy}","received_events_url":"https://api.github.com/users/shawnrusaw-wf/received_events","type":"User","site_admin":false},"body":"`Dockerfile.fsm_docker_runner` and `Dockerfile.dev_ecs` need py3 versions too","created_at":"2018-09-04T21:31:42Z","updated_at":"2018-09-04T21:31:42Z","html_url":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30#discussion_r215073821","pull_request_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/comments/215073821"},"html":{"href":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30#discussion_r215073821"},"pull_request":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30","id":211232130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjMyMTMw","html_url":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30","diff_url":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30.diff","patch_url":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30.patch","issue_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/30","number":30,"state":"open","locked":false,"title":"Add Pyton 3 support","user":{"login":"aaronkavlie-wf","id":7768348,"node_id":"MDQ6VXNlcjc3NjgzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7768348?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronkavlie-wf","html_url":"https://github.com/aaronkavlie-wf","followers_url":"https://api.github.com/users/aaronkavlie-wf/followers","following_url":"https://api.github.com/users/aaronkavlie-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronkavlie-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronkavlie-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronkavlie-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronkavlie-wf/orgs","repos_url":"https://api.github.com/users/aaronkavlie-wf/repos","events_url":"https://api.github.com/users/aaronkavlie-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronkavlie-wf/received_events","type":"User","site_admin":false},"body":"Description\r\n========\r\nThis PR adds suport for Python 3, while maintaining compatibility with Python 2.7.\r\nIt adds a Python 3.6 build target, so the tests run against both 2.7 and 3.6.\r\n\r\nTesting\r\n=====\r\n\r\nTry the functional testing guidelines (`tests/functional/README.md`, expanded in this PR) and ensure that functional tests pass both with a Python 2.7 virtualenv / Python 2.7 Docker container, and Python 3.6 virtualenv / Python 3.6 Docker container.\r\n\r\nCode Review\r\n==========\r\n@shawnrusaw-wf @markmadej-wk ","created_at":"2018-08-27T21:09:15Z","updated_at":"2018-09-04T21:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4964be0d91119c134f4c3ac69f2a3bd24c30a039","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":496391372,"node_id":"MDU6TGFiZWw0OTYzOTEzNzI=","url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/labels/InfoSec%20Review%20Required","name":"InfoSec Review Required","color":"4D6584","default":false},{"id":496391375,"node_id":"MDU6TGFiZWw0OTYzOTEzNzU=","url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/labels/Merge%20Requirements%20Unmet","name":"Merge Requirements Unmet","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/30/comments","statuses_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/statuses/e5d2a96f3d83eae9eb25b6710f3a7aa281972824","head":{"label":"aaronkavlie-wf:python_3","ref":"python_3","sha":"e5d2a96f3d83eae9eb25b6710f3a7aa281972824","user":{"login":"aaronkavlie-wf","id":7768348,"node_id":"MDQ6VXNlcjc3NjgzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7768348?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronkavlie-wf","html_url":"https://github.com/aaronkavlie-wf","followers_url":"https://api.github.com/users/aaronkavlie-wf/followers","following_url":"https://api.github.com/users/aaronkavlie-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronkavlie-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronkavlie-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronkavlie-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronkavlie-wf/orgs","repos_url":"https://api.github.com/users/aaronkavlie-wf/repos","events_url":"https://api.github.com/users/aaronkavlie-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronkavlie-wf/received_events","type":"User","site_admin":false},"repo":{"id":146354522,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzNTQ1MjI=","name":"aws-lambda-fsm-workflows","full_name":"aaronkavlie-wf/aws-lambda-fsm-workflows","owner":{"login":"aaronkavlie-wf","id":7768348,"node_id":"MDQ6VXNlcjc3NjgzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7768348?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronkavlie-wf","html_url":"https://github.com/aaronkavlie-wf","followers_url":"https://api.github.com/users/aaronkavlie-wf/followers","following_url":"https://api.github.com/users/aaronkavlie-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronkavlie-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronkavlie-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronkavlie-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronkavlie-wf/orgs","repos_url":"https://api.github.com/users/aaronkavlie-wf/repos","events_url":"https://api.github.com/users/aaronkavlie-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronkavlie-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronkavlie-wf/aws-lambda-fsm-workflows","description":"A Python framework for developing finite state machine-based workflows on AWS Lambda.","fork":true,"url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows","forks_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/forks","keys_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/teams","hooks_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/hooks","issue_events_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/issues/events{/number}","events_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/events","assignees_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/assignees{/user}","branches_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/branches{/branch}","tags_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/tags","blobs_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/languages","stargazers_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/stargazers","contributors_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/contributors","subscribers_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/subscribers","subscription_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/subscription","commits_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/contents/{+path}","compare_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/merges","archive_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/downloads","issues_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/issues{/number}","pulls_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/labels{/name}","releases_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/releases{/id}","deployments_url":"https://api.github.com/repos/aaronkavlie-wf/aws-lambda-fsm-workflows/deployments","created_at":"2018-08-27T21:07:21Z","updated_at":"2018-08-27T21:07:23Z","pushed_at":"2018-08-31T22:10:06Z","git_url":"git://github.com/aaronkavlie-wf/aws-lambda-fsm-workflows.git","ssh_url":"git@github.com:aaronkavlie-wf/aws-lambda-fsm-workflows.git","clone_url":"https://github.com/aaronkavlie-wf/aws-lambda-fsm-workflows.git","svn_url":"https://github.com/aaronkavlie-wf/aws-lambda-fsm-workflows","homepage":"","size":2066,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"ea3120a8bc9fc9ea93c68f3d972f3f01e036c96f","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":73727788,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcyNzc4OA==","name":"aws-lambda-fsm-workflows","full_name":"Workiva/aws-lambda-fsm-workflows","owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/aws-lambda-fsm-workflows","description":"A Python framework for developing finite state machine-based workflows on AWS Lambda.","fork":false,"url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows","forks_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/forks","keys_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/teams","hooks_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/hooks","issue_events_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/events","assignees_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/tags","blobs_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/languages","stargazers_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/stargazers","contributors_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/contributors","subscribers_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/subscribers","subscription_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/subscription","commits_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/merges","archive_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/downloads","issues_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/deployments","created_at":"2016-11-14T17:03:44Z","updated_at":"2018-08-30T22:00:23Z","pushed_at":"2018-08-31T22:10:16Z","git_url":"git://github.com/Workiva/aws-lambda-fsm-workflows.git","ssh_url":"git@github.com:Workiva/aws-lambda-fsm-workflows.git","clone_url":"https://github.com/Workiva/aws-lambda-fsm-workflows.git","svn_url":"https://github.com/Workiva/aws-lambda-fsm-workflows","homepage":"","size":2030,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30"},"html":{"href":"https://github.com/Workiva/aws-lambda-fsm-workflows/pull/30"},"issue":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/30"},"comments":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/aws-lambda-fsm-workflows/statuses/e5d2a96f3d83eae9eb25b6710f3a7aa281972824"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shawnrusaw-wf"}}