{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/12168","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/12168/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/12168/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/12168/events","html_url":"https://github.com/fastlane/fastlane/pull/12168","id":308498403,"number":12168,"title":"Patch 1","user":{"login":"adamcohenrose","id":104097,"avatar_url":"https://avatars3.githubusercontent.com/u/104097?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcohenrose","html_url":"https://github.com/adamcohenrose","followers_url":"https://api.github.com/users/adamcohenrose/followers","following_url":"https://api.github.com/users/adamcohenrose/following{/other_user}","gists_url":"https://api.github.com/users/adamcohenrose/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcohenrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcohenrose/subscriptions","organizations_url":"https://api.github.com/users/adamcohenrose/orgs","repos_url":"https://api.github.com/users/adamcohenrose/repos","events_url":"https://api.github.com/users/adamcohenrose/events{/privacy}","received_events_url":"https://api.github.com/users/adamcohenrose/received_events","type":"User","site_admin":false},"labels":[{"id":560541068,"url":"https://api.github.com/repos/fastlane/fastlane/labels/cla:%20no","name":"cla: no","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-26T09:36:16Z","updated_at":"2018-03-26T09:37:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/12168","html_url":"https://github.com/fastlane/fastlane/pull/12168","diff_url":"https://github.com/fastlane/fastlane/pull/12168.diff","patch_url":"https://github.com/fastlane/fastlane/pull/12168.patch"},"body":"<!-- Thanks for contributing to _fastlane_! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->\r\n\r\n### Checklist\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\n<!-- Why is this change required? What problem does it solve? -->\r\n<!-- If it fixes an open issue, please link to the issue here. -->\r\n<!-- Please describe in detail how you tested your changes. -->\r\n\r\nscreengrab currently builds up (and verifies) an android environment and then ignores it when calling adb -- assuming that adb is on the path (and failing when it isn't!).\r\n\r\nThis patch uses the android environment that has already been verified to run adb.\r\n\r\n### Description\r\n<!-- Describe your changes in detail -->\r\n\r\n1. Pick up the standard Android SDK environment variable. According to https://developer.android.com/studio/command-line/variables.html the environment variable should be ANDROID_SDK_ROOT, not ANDROID_SDK.\r\n\r\n2. Use AndroidEnvironment when calling adb: Previously adb had to be on the PATH to work, even if android_home had been configured properly and adb had been found earlier on."},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/376106199","html_url":"https://github.com/fastlane/fastlane/pull/12168#issuecomment-376106199","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/12168","id":376106199,"user":{"login":"adamcohenrose","id":104097,"avatar_url":"https://avatars3.githubusercontent.com/u/104097?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcohenrose","html_url":"https://github.com/adamcohenrose","followers_url":"https://api.github.com/users/adamcohenrose/followers","following_url":"https://api.github.com/users/adamcohenrose/following{/other_user}","gists_url":"https://api.github.com/users/adamcohenrose/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcohenrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcohenrose/subscriptions","organizations_url":"https://api.github.com/users/adamcohenrose/orgs","repos_url":"https://api.github.com/users/adamcohenrose/repos","events_url":"https://api.github.com/users/adamcohenrose/events{/privacy}","received_events_url":"https://api.github.com/users/adamcohenrose/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T09:37:51Z","updated_at":"2018-03-26T09:37:51Z","author_association":"NONE","body":"I signed the CLA"}}
{"actor":{"display_login":"adamcohenrose"}}