{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/skeema/tengo/pulls/7","id":191584120,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTg0MTIw","html_url":"https://github.com/skeema/tengo/pull/7","diff_url":"https://github.com/skeema/tengo/pull/7.diff","patch_url":"https://github.com/skeema/tengo/pull/7.patch","issue_url":"https://api.github.com/repos/skeema/tengo/issues/7","number":7,"state":"closed","locked":false,"title":"Remove caching and simplify method args and returns","user":{"login":"evanelias","id":71920,"node_id":"MDQ6VXNlcjcxOTIw","avatar_url":"https://avatars1.githubusercontent.com/u/71920?v=4","gravatar_id":"","url":"https://api.github.com/users/evanelias","html_url":"https://github.com/evanelias","followers_url":"https://api.github.com/users/evanelias/followers","following_url":"https://api.github.com/users/evanelias/following{/other_user}","gists_url":"https://api.github.com/users/evanelias/gists{/gist_id}","starred_url":"https://api.github.com/users/evanelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanelias/subscriptions","organizations_url":"https://api.github.com/users/evanelias/orgs","repos_url":"https://api.github.com/users/evanelias/repos","events_url":"https://api.github.com/users/evanelias/events{/privacy}","received_events_url":"https://api.github.com/users/evanelias/received_events","type":"User","site_admin":false},"body":"This PR removes the internal caching of instances and schemas, and simplifies the args and/or return values of several methods by removing lazy-loading. The built-in caching and lazy-loading added too much complexity for too little benefit. Callers should implement more appropriate special-purpose caching if ever needed.\r\n\r\nThis is a breaking API change, which is acceptable since Go La Tengo is still pre-1.0. The following method signatures or return semantics changed:\r\n\r\n* NewInstance() no longer de-duplicates instances, and no longer errors upon creating a duplicate instance with different auth or params.\r\n* Instance.HasSchema() now returns an error if its query fails\r\n* The following methods now take string args instead of structs:\r\n  * Instance.ShowCreateTable()\r\n  * Instance.TableSize()\r\n  * Instance.TableHasRows()\r\n  * Instance.DropSchema()\r\n  * Instance.AlterSchema()\r\n  * Instance.DropTablesInSchema()\r\n  * Instance.CloneSchema()\r\n* The following methods no longer possibly return an error:\r\n  * NewSchemaDiff()\r\n  * Schema.TablesByName()\r\n  * Schema.Table()\r\n* Schema.OverridesServerCharSet() now takes an Instance as an arg\r\n* The following methods have been replaced with identically-named exported fields:\r\n  * Schema.Tables()\r\n  * Table.CreateStatement()\r\n* The following methods have been removed entirely, as they are no longer needed now that there's no internal caching:\r\n  * Schema.PurgeTableCache()\r\n  * Schema.CachedCopy()\r\n","created_at":"2018-05-30T21:19:44Z","updated_at":"2018-05-30T21:39:18Z","closed_at":"2018-05-30T21:39:18Z","merged_at":"2018-05-30T21:39:18Z","merge_commit_sha":"b71e847379e45a87aa33c6ef6c140bb7b4a9d9b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skeema/tengo/pulls/7/commits","review_comments_url":"https://api.github.com/repos/skeema/tengo/pulls/7/comments","review_comment_url":"https://api.github.com/repos/skeema/tengo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skeema/tengo/issues/7/comments","statuses_url":"https://api.github.com/repos/skeema/tengo/statuses/d5cce2d24702a2a2f9854a2ccb82cd497eef72bc","head":{"label":"skeema:remove-caching","ref":"remove-caching","sha":"d5cce2d24702a2a2f9854a2ccb82cd497eef72bc","user":{"login":"skeema","id":18493113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDkzMTEz","avatar_url":"https://avatars1.githubusercontent.com/u/18493113?v=4","gravatar_id":"","url":"https://api.github.com/users/skeema","html_url":"https://github.com/skeema","followers_url":"https://api.github.com/users/skeema/followers","following_url":"https://api.github.com/users/skeema/following{/other_user}","gists_url":"https://api.github.com/users/skeema/gists{/gist_id}","starred_url":"https://api.github.com/users/skeema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeema/subscriptions","organizations_url":"https://api.github.com/users/skeema/orgs","repos_url":"https://api.github.com/users/skeema/repos","events_url":"https://api.github.com/users/skeema/events{/privacy}","received_events_url":"https://api.github.com/users/skeema/received_events","type":"Organization","site_admin":false},"repo":{"id":71289686,"node_id":"MDEwOlJlcG9zaXRvcnk3MTI4OTY4Ng==","name":"tengo","full_name":"skeema/tengo","owner":{"login":"skeema","id":18493113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDkzMTEz","avatar_url":"https://avatars1.githubusercontent.com/u/18493113?v=4","gravatar_id":"","url":"https://api.github.com/users/skeema","html_url":"https://github.com/skeema","followers_url":"https://api.github.com/users/skeema/followers","following_url":"https://api.github.com/users/skeema/following{/other_user}","gists_url":"https://api.github.com/users/skeema/gists{/gist_id}","starred_url":"https://api.github.com/users/skeema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeema/subscriptions","organizations_url":"https://api.github.com/users/skeema/orgs","repos_url":"https://api.github.com/users/skeema/repos","events_url":"https://api.github.com/users/skeema/events{/privacy}","received_events_url":"https://api.github.com/users/skeema/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skeema/tengo","description":"Go La Tengo: a MySQL automation library","fork":false,"url":"https://api.github.com/repos/skeema/tengo","forks_url":"https://api.github.com/repos/skeema/tengo/forks","keys_url":"https://api.github.com/repos/skeema/tengo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skeema/tengo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skeema/tengo/teams","hooks_url":"https://api.github.com/repos/skeema/tengo/hooks","issue_events_url":"https://api.github.com/repos/skeema/tengo/issues/events{/number}","events_url":"https://api.github.com/repos/skeema/tengo/events","assignees_url":"https://api.github.com/repos/skeema/tengo/assignees{/user}","branches_url":"https://api.github.com/repos/skeema/tengo/branches{/branch}","tags_url":"https://api.github.com/repos/skeema/tengo/tags","blobs_url":"https://api.github.com/repos/skeema/tengo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skeema/tengo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skeema/tengo/git/refs{/sha}","trees_url":"https://api.github.com/repos/skeema/tengo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skeema/tengo/statuses/{sha}","languages_url":"https://api.github.com/repos/skeema/tengo/languages","stargazers_url":"https://api.github.com/repos/skeema/tengo/stargazers","contributors_url":"https://api.github.com/repos/skeema/tengo/contributors","subscribers_url":"https://api.github.com/repos/skeema/tengo/subscribers","subscription_url":"https://api.github.com/repos/skeema/tengo/subscription","commits_url":"https://api.github.com/repos/skeema/tengo/commits{/sha}","git_commits_url":"https://api.github.com/repos/skeema/tengo/git/commits{/sha}","comments_url":"https://api.github.com/repos/skeema/tengo/comments{/number}","issue_comment_url":"https://api.github.com/repos/skeema/tengo/issues/comments{/number}","contents_url":"https://api.github.com/repos/skeema/tengo/contents/{+path}","compare_url":"https://api.github.com/repos/skeema/tengo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skeema/tengo/merges","archive_url":"https://api.github.com/repos/skeema/tengo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skeema/tengo/downloads","issues_url":"https://api.github.com/repos/skeema/tengo/issues{/number}","pulls_url":"https://api.github.com/repos/skeema/tengo/pulls{/number}","milestones_url":"https://api.github.com/repos/skeema/tengo/milestones{/number}","notifications_url":"https://api.github.com/repos/skeema/tengo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skeema/tengo/labels{/name}","releases_url":"https://api.github.com/repos/skeema/tengo/releases{/id}","deployments_url":"https://api.github.com/repos/skeema/tengo/deployments","created_at":"2016-10-18T20:43:34Z","updated_at":"2018-05-25T19:33:54Z","pushed_at":"2018-05-30T21:39:18Z","git_url":"git://github.com/skeema/tengo.git","ssh_url":"git@github.com:skeema/tengo.git","clone_url":"https://github.com/skeema/tengo.git","svn_url":"https://github.com/skeema/tengo","homepage":null,"size":161,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"skeema:master","ref":"master","sha":"653a9fcc5a0816fdd0c17018779f8d32a0d2359f","user":{"login":"skeema","id":18493113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDkzMTEz","avatar_url":"https://avatars1.githubusercontent.com/u/18493113?v=4","gravatar_id":"","url":"https://api.github.com/users/skeema","html_url":"https://github.com/skeema","followers_url":"https://api.github.com/users/skeema/followers","following_url":"https://api.github.com/users/skeema/following{/other_user}","gists_url":"https://api.github.com/users/skeema/gists{/gist_id}","starred_url":"https://api.github.com/users/skeema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeema/subscriptions","organizations_url":"https://api.github.com/users/skeema/orgs","repos_url":"https://api.github.com/users/skeema/repos","events_url":"https://api.github.com/users/skeema/events{/privacy}","received_events_url":"https://api.github.com/users/skeema/received_events","type":"Organization","site_admin":false},"repo":{"id":71289686,"node_id":"MDEwOlJlcG9zaXRvcnk3MTI4OTY4Ng==","name":"tengo","full_name":"skeema/tengo","owner":{"login":"skeema","id":18493113,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDkzMTEz","avatar_url":"https://avatars1.githubusercontent.com/u/18493113?v=4","gravatar_id":"","url":"https://api.github.com/users/skeema","html_url":"https://github.com/skeema","followers_url":"https://api.github.com/users/skeema/followers","following_url":"https://api.github.com/users/skeema/following{/other_user}","gists_url":"https://api.github.com/users/skeema/gists{/gist_id}","starred_url":"https://api.github.com/users/skeema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeema/subscriptions","organizations_url":"https://api.github.com/users/skeema/orgs","repos_url":"https://api.github.com/users/skeema/repos","events_url":"https://api.github.com/users/skeema/events{/privacy}","received_events_url":"https://api.github.com/users/skeema/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skeema/tengo","description":"Go La Tengo: a MySQL automation library","fork":false,"url":"https://api.github.com/repos/skeema/tengo","forks_url":"https://api.github.com/repos/skeema/tengo/forks","keys_url":"https://api.github.com/repos/skeema/tengo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skeema/tengo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skeema/tengo/teams","hooks_url":"https://api.github.com/repos/skeema/tengo/hooks","issue_events_url":"https://api.github.com/repos/skeema/tengo/issues/events{/number}","events_url":"https://api.github.com/repos/skeema/tengo/events","assignees_url":"https://api.github.com/repos/skeema/tengo/assignees{/user}","branches_url":"https://api.github.com/repos/skeema/tengo/branches{/branch}","tags_url":"https://api.github.com/repos/skeema/tengo/tags","blobs_url":"https://api.github.com/repos/skeema/tengo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skeema/tengo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skeema/tengo/git/refs{/sha}","trees_url":"https://api.github.com/repos/skeema/tengo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skeema/tengo/statuses/{sha}","languages_url":"https://api.github.com/repos/skeema/tengo/languages","stargazers_url":"https://api.github.com/repos/skeema/tengo/stargazers","contributors_url":"https://api.github.com/repos/skeema/tengo/contributors","subscribers_url":"https://api.github.com/repos/skeema/tengo/subscribers","subscription_url":"https://api.github.com/repos/skeema/tengo/subscription","commits_url":"https://api.github.com/repos/skeema/tengo/commits{/sha}","git_commits_url":"https://api.github.com/repos/skeema/tengo/git/commits{/sha}","comments_url":"https://api.github.com/repos/skeema/tengo/comments{/number}","issue_comment_url":"https://api.github.com/repos/skeema/tengo/issues/comments{/number}","contents_url":"https://api.github.com/repos/skeema/tengo/contents/{+path}","compare_url":"https://api.github.com/repos/skeema/tengo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skeema/tengo/merges","archive_url":"https://api.github.com/repos/skeema/tengo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skeema/tengo/downloads","issues_url":"https://api.github.com/repos/skeema/tengo/issues{/number}","pulls_url":"https://api.github.com/repos/skeema/tengo/pulls{/number}","milestones_url":"https://api.github.com/repos/skeema/tengo/milestones{/number}","notifications_url":"https://api.github.com/repos/skeema/tengo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skeema/tengo/labels{/name}","releases_url":"https://api.github.com/repos/skeema/tengo/releases{/id}","deployments_url":"https://api.github.com/repos/skeema/tengo/deployments","created_at":"2016-10-18T20:43:34Z","updated_at":"2018-05-25T19:33:54Z","pushed_at":"2018-05-30T21:39:18Z","git_url":"git://github.com/skeema/tengo.git","ssh_url":"git@github.com:skeema/tengo.git","clone_url":"https://github.com/skeema/tengo.git","svn_url":"https://github.com/skeema/tengo","homepage":null,"size":161,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skeema/tengo/pulls/7"},"html":{"href":"https://github.com/skeema/tengo/pull/7"},"issue":{"href":"https://api.github.com/repos/skeema/tengo/issues/7"},"comments":{"href":"https://api.github.com/repos/skeema/tengo/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/skeema/tengo/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/skeema/tengo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skeema/tengo/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/skeema/tengo/statuses/d5cce2d24702a2a2f9854a2ccb82cd497eef72bc"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"evanelias","id":71920,"node_id":"MDQ6VXNlcjcxOTIw","avatar_url":"https://avatars1.githubusercontent.com/u/71920?v=4","gravatar_id":"","url":"https://api.github.com/users/evanelias","html_url":"https://github.com/evanelias","followers_url":"https://api.github.com/users/evanelias/followers","following_url":"https://api.github.com/users/evanelias/following{/other_user}","gists_url":"https://api.github.com/users/evanelias/gists{/gist_id}","starred_url":"https://api.github.com/users/evanelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanelias/subscriptions","organizations_url":"https://api.github.com/users/evanelias/orgs","repos_url":"https://api.github.com/users/evanelias/repos","events_url":"https://api.github.com/users/evanelias/events{/privacy}","received_events_url":"https://api.github.com/users/evanelias/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":555,"deletions":786,"changed_files":12}}
{"actor":{"display_login":"evanelias"}}