{"action":"created","issue":{"url":"https://api.github.com/repos/filebrowser/filebrowser/issues/399","repository_url":"https://api.github.com/repos/filebrowser/filebrowser","labels_url":"https://api.github.com/repos/filebrowser/filebrowser/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/filebrowser/filebrowser/issues/399/comments","events_url":"https://api.github.com/repos/filebrowser/filebrowser/issues/399/events","html_url":"https://github.com/filebrowser/filebrowser/pull/399","id":315542538,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNTI3MjU4","number":399,"title":"drop package.json, use yarn instad of npm, add build_in_docker.sh","user":{"login":"1138-4EB","id":6628437,"node_id":"MDQ6VXNlcjY2Mjg0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6628437?v=4","gravatar_id":"","url":"https://api.github.com/users/1138-4EB","html_url":"https://github.com/1138-4EB","followers_url":"https://api.github.com/users/1138-4EB/followers","following_url":"https://api.github.com/users/1138-4EB/following{/other_user}","gists_url":"https://api.github.com/users/1138-4EB/gists{/gist_id}","starred_url":"https://api.github.com/users/1138-4EB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1138-4EB/subscriptions","organizations_url":"https://api.github.com/users/1138-4EB/orgs","repos_url":"https://api.github.com/users/1138-4EB/repos","events_url":"https://api.github.com/users/1138-4EB/events{/privacy}","received_events_url":"https://api.github.com/users/1138-4EB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"1138-4EB","id":6628437,"node_id":"MDQ6VXNlcjY2Mjg0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6628437?v=4","gravatar_id":"","url":"https://api.github.com/users/1138-4EB","html_url":"https://github.com/1138-4EB","followers_url":"https://api.github.com/users/1138-4EB/followers","following_url":"https://api.github.com/users/1138-4EB/following{/other_user}","gists_url":"https://api.github.com/users/1138-4EB/gists{/gist_id}","starred_url":"https://api.github.com/users/1138-4EB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1138-4EB/subscriptions","organizations_url":"https://api.github.com/users/1138-4EB/orgs","repos_url":"https://api.github.com/users/1138-4EB/repos","events_url":"https://api.github.com/users/1138-4EB/events{/privacy}","received_events_url":"https://api.github.com/users/1138-4EB/received_events","type":"User","site_admin":false},"assignees":[{"login":"1138-4EB","id":6628437,"node_id":"MDQ6VXNlcjY2Mjg0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6628437?v=4","gravatar_id":"","url":"https://api.github.com/users/1138-4EB","html_url":"https://github.com/1138-4EB","followers_url":"https://api.github.com/users/1138-4EB/followers","following_url":"https://api.github.com/users/1138-4EB/following{/other_user}","gists_url":"https://api.github.com/users/1138-4EB/gists{/gist_id}","starred_url":"https://api.github.com/users/1138-4EB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1138-4EB/subscriptions","organizations_url":"https://api.github.com/users/1138-4EB/orgs","repos_url":"https://api.github.com/users/1138-4EB/repos","events_url":"https://api.github.com/users/1138-4EB/events{/privacy}","received_events_url":"https://api.github.com/users/1138-4EB/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2018-04-18T15:58:29Z","updated_at":"2018-07-23T08:20:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/filebrowser/filebrowser/pulls/399","html_url":"https://github.com/filebrowser/filebrowser/pull/399","diff_url":"https://github.com/filebrowser/filebrowser/pull/399.diff","patch_url":"https://github.com/filebrowser/filebrowser/pull/399.patch"},"body":"I found no info about how one should proceed to modify the frontend and rebuild filebrowser. It seems that `package.json` is used, which requires to push resources either to the npm or to a git repo. Moreover, because `node_modules` is removed in `build.sh`, any local changes are deleted.\r\n\r\nThis PR follows a different approach. `frontend` is expected to be a subdir of this repo, but ignored through `.gitignore`. When `build.sh` is executed, the frontend is cloned if not present. `dist` is always cleared. Then, dependencies of the frontend are downloaded/updated and the frontend is built. Last, because the path to the rice box is changed in ` filebrowser.go`, the content of `dist` can be packed directly.\r\n\r\nFor those users that don't want to install nodejs and npm/yarn locally, `build_in_docker.sh` is provided. It runs a `golang:alpine` container, installs the required dependencies and executes `build.sh`. Indeed, an image name `hacdias/filebrowser:dev` can be provided, in order to avoid installing the tools each time."},"comment":{"url":"https://api.github.com/repos/filebrowser/filebrowser/issues/comments/406978435","html_url":"https://github.com/filebrowser/filebrowser/pull/399#issuecomment-406978435","issue_url":"https://api.github.com/repos/filebrowser/filebrowser/issues/399","id":406978435,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjk3ODQzNQ==","user":{"login":"hacdias","id":5447088,"node_id":"MDQ6VXNlcjU0NDcwODg=","avatar_url":"https://avatars2.githubusercontent.com/u/5447088?v=4","gravatar_id":"","url":"https://api.github.com/users/hacdias","html_url":"https://github.com/hacdias","followers_url":"https://api.github.com/users/hacdias/followers","following_url":"https://api.github.com/users/hacdias/following{/other_user}","gists_url":"https://api.github.com/users/hacdias/gists{/gist_id}","starred_url":"https://api.github.com/users/hacdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hacdias/subscriptions","organizations_url":"https://api.github.com/users/hacdias/orgs","repos_url":"https://api.github.com/users/hacdias/repos","events_url":"https://api.github.com/users/hacdias/events{/privacy}","received_events_url":"https://api.github.com/users/hacdias/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T08:20:52Z","updated_at":"2018-07-23T08:20:52Z","author_association":"MEMBER","body":"@1138-4EB I'm not sure if Caddy server supports vendor folders either. Let us ask @mholt 😄 "}}
{"actor":{"display_login":"hacdias"}}