{"action":"created","comment":{"url":"https://api.github.com/repos/python-visualization/folium/pulls/comments/218013953","pull_request_review_id":155856106,"id":218013953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODAxMzk1Mw==","diff_hunk":"@@ -232,7 +232,7 @@ class VegaLite(Element):\n \n     def __init__(self, data, width=None, height=None,\n                  left='0%', top='0%', position='relative'):\n-        super(VegaLite, self).__init__()\n+        super(self.__class__, self).__init__()","path":"folium/features.py","position":5,"original_position":5,"commit_id":"08f9d43ab24d7b0f805d12a5e45861aebb318860","original_commit_id":"08f9d43ab24d7b0f805d12a5e45861aebb318860","user":{"login":"JarnoRFB","id":8550270,"node_id":"MDQ6VXNlcjg1NTAyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/8550270?v=4","gravatar_id":"","url":"https://api.github.com/users/JarnoRFB","html_url":"https://github.com/JarnoRFB","followers_url":"https://api.github.com/users/JarnoRFB/followers","following_url":"https://api.github.com/users/JarnoRFB/following{/other_user}","gists_url":"https://api.github.com/users/JarnoRFB/gists{/gist_id}","starred_url":"https://api.github.com/users/JarnoRFB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarnoRFB/subscriptions","organizations_url":"https://api.github.com/users/JarnoRFB/orgs","repos_url":"https://api.github.com/users/JarnoRFB/repos","events_url":"https://api.github.com/users/JarnoRFB/events{/privacy}","received_events_url":"https://api.github.com/users/JarnoRFB/received_events","type":"User","site_admin":false},"body":"I somehow got a strange error at some point, when I used `VegaLite` instead of `self.__class__`, but I can revert that.","created_at":"2018-09-17T10:08:24Z","updated_at":"2018-09-17T10:08:24Z","html_url":"https://github.com/python-visualization/folium/pull/959#discussion_r218013953","pull_request_url":"https://api.github.com/repos/python-visualization/folium/pulls/959","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/comments/218013953"},"html":{"href":"https://github.com/python-visualization/folium/pull/959#discussion_r218013953"},"pull_request":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/959"}},"in_reply_to_id":218002731},"pull_request":{"url":"https://api.github.com/repos/python-visualization/folium/pulls/959","id":214758519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzU4NTE5","html_url":"https://github.com/python-visualization/folium/pull/959","diff_url":"https://github.com/python-visualization/folium/pull/959.diff","patch_url":"https://github.com/python-visualization/folium/pull/959.patch","issue_url":"https://api.github.com/repos/python-visualization/folium/issues/959","number":959,"state":"open","locked":false,"title":"Use newer vega versions for altair compatibility","user":{"login":"JarnoRFB","id":8550270,"node_id":"MDQ6VXNlcjg1NTAyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/8550270?v=4","gravatar_id":"","url":"https://api.github.com/users/JarnoRFB","html_url":"https://github.com/JarnoRFB","followers_url":"https://api.github.com/users/JarnoRFB/followers","following_url":"https://api.github.com/users/JarnoRFB/following{/other_user}","gists_url":"https://api.github.com/users/JarnoRFB/gists{/gist_id}","starred_url":"https://api.github.com/users/JarnoRFB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarnoRFB/subscriptions","organizations_url":"https://api.github.com/users/JarnoRFB/orgs","repos_url":"https://api.github.com/users/JarnoRFB/repos","events_url":"https://api.github.com/users/JarnoRFB/events{/privacy}","received_events_url":"https://api.github.com/users/JarnoRFB/received_events","type":"User","site_admin":false},"body":"Newer versions of vega, vega-lite and vega-embed are used to allow the \r\nusage of altair 2.x. Additionally,\r\nthe JavaScript for embedding is adapted. jsdelivr is used instead of\r\ncloudflare, since it allows to specify the newest minor version very\r\nnicely and it is recommended by the vega-lite docs\r\nhttps://vega.github.io/vega-lite/usage/embed.html#cdn","created_at":"2018-09-11T20:36:11Z","updated_at":"2018-09-17T10:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd46f6d959e5079bf30d42e983db38e4286d56f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-visualization/folium/pulls/959/commits","review_comments_url":"https://api.github.com/repos/python-visualization/folium/pulls/959/comments","review_comment_url":"https://api.github.com/repos/python-visualization/folium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-visualization/folium/issues/959/comments","statuses_url":"https://api.github.com/repos/python-visualization/folium/statuses/08f9d43ab24d7b0f805d12a5e45861aebb318860","head":{"label":"JarnoRFB:feature/vega-version-update","ref":"feature/vega-version-update","sha":"08f9d43ab24d7b0f805d12a5e45861aebb318860","user":{"login":"JarnoRFB","id":8550270,"node_id":"MDQ6VXNlcjg1NTAyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/8550270?v=4","gravatar_id":"","url":"https://api.github.com/users/JarnoRFB","html_url":"https://github.com/JarnoRFB","followers_url":"https://api.github.com/users/JarnoRFB/followers","following_url":"https://api.github.com/users/JarnoRFB/following{/other_user}","gists_url":"https://api.github.com/users/JarnoRFB/gists{/gist_id}","starred_url":"https://api.github.com/users/JarnoRFB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarnoRFB/subscriptions","organizations_url":"https://api.github.com/users/JarnoRFB/orgs","repos_url":"https://api.github.com/users/JarnoRFB/repos","events_url":"https://api.github.com/users/JarnoRFB/events{/privacy}","received_events_url":"https://api.github.com/users/JarnoRFB/received_events","type":"User","site_admin":false},"repo":{"id":148312973,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMTI5NzM=","name":"folium","full_name":"JarnoRFB/folium","private":false,"owner":{"login":"JarnoRFB","id":8550270,"node_id":"MDQ6VXNlcjg1NTAyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/8550270?v=4","gravatar_id":"","url":"https://api.github.com/users/JarnoRFB","html_url":"https://github.com/JarnoRFB","followers_url":"https://api.github.com/users/JarnoRFB/followers","following_url":"https://api.github.com/users/JarnoRFB/following{/other_user}","gists_url":"https://api.github.com/users/JarnoRFB/gists{/gist_id}","starred_url":"https://api.github.com/users/JarnoRFB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarnoRFB/subscriptions","organizations_url":"https://api.github.com/users/JarnoRFB/orgs","repos_url":"https://api.github.com/users/JarnoRFB/repos","events_url":"https://api.github.com/users/JarnoRFB/events{/privacy}","received_events_url":"https://api.github.com/users/JarnoRFB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JarnoRFB/folium","description":"Python Data. Leaflet.js Maps. ","fork":true,"url":"https://api.github.com/repos/JarnoRFB/folium","forks_url":"https://api.github.com/repos/JarnoRFB/folium/forks","keys_url":"https://api.github.com/repos/JarnoRFB/folium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JarnoRFB/folium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JarnoRFB/folium/teams","hooks_url":"https://api.github.com/repos/JarnoRFB/folium/hooks","issue_events_url":"https://api.github.com/repos/JarnoRFB/folium/issues/events{/number}","events_url":"https://api.github.com/repos/JarnoRFB/folium/events","assignees_url":"https://api.github.com/repos/JarnoRFB/folium/assignees{/user}","branches_url":"https://api.github.com/repos/JarnoRFB/folium/branches{/branch}","tags_url":"https://api.github.com/repos/JarnoRFB/folium/tags","blobs_url":"https://api.github.com/repos/JarnoRFB/folium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JarnoRFB/folium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JarnoRFB/folium/git/refs{/sha}","trees_url":"https://api.github.com/repos/JarnoRFB/folium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JarnoRFB/folium/statuses/{sha}","languages_url":"https://api.github.com/repos/JarnoRFB/folium/languages","stargazers_url":"https://api.github.com/repos/JarnoRFB/folium/stargazers","contributors_url":"https://api.github.com/repos/JarnoRFB/folium/contributors","subscribers_url":"https://api.github.com/repos/JarnoRFB/folium/subscribers","subscription_url":"https://api.github.com/repos/JarnoRFB/folium/subscription","commits_url":"https://api.github.com/repos/JarnoRFB/folium/commits{/sha}","git_commits_url":"https://api.github.com/repos/JarnoRFB/folium/git/commits{/sha}","comments_url":"https://api.github.com/repos/JarnoRFB/folium/comments{/number}","issue_comment_url":"https://api.github.com/repos/JarnoRFB/folium/issues/comments{/number}","contents_url":"https://api.github.com/repos/JarnoRFB/folium/contents/{+path}","compare_url":"https://api.github.com/repos/JarnoRFB/folium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JarnoRFB/folium/merges","archive_url":"https://api.github.com/repos/JarnoRFB/folium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JarnoRFB/folium/downloads","issues_url":"https://api.github.com/repos/JarnoRFB/folium/issues{/number}","pulls_url":"https://api.github.com/repos/JarnoRFB/folium/pulls{/number}","milestones_url":"https://api.github.com/repos/JarnoRFB/folium/milestones{/number}","notifications_url":"https://api.github.com/repos/JarnoRFB/folium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JarnoRFB/folium/labels{/name}","releases_url":"https://api.github.com/repos/JarnoRFB/folium/releases{/id}","deployments_url":"https://api.github.com/repos/JarnoRFB/folium/deployments","created_at":"2018-09-11T12:22:44Z","updated_at":"2018-09-11T12:22:47Z","pushed_at":"2018-09-11T20:33:11Z","git_url":"git://github.com/JarnoRFB/folium.git","ssh_url":"git@github.com:JarnoRFB/folium.git","clone_url":"https://github.com/JarnoRFB/folium.git","svn_url":"https://github.com/JarnoRFB/folium","homepage":"http://python-visualization.github.io/folium/","size":74420,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-visualization:master","ref":"master","sha":"25bfd5c976ed97ae2c95142c1c07c709e10a41ea","user":{"login":"python-visualization","id":9969242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjkyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9969242?v=4","gravatar_id":"","url":"https://api.github.com/users/python-visualization","html_url":"https://github.com/python-visualization","followers_url":"https://api.github.com/users/python-visualization/followers","following_url":"https://api.github.com/users/python-visualization/following{/other_user}","gists_url":"https://api.github.com/users/python-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/python-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-visualization/subscriptions","organizations_url":"https://api.github.com/users/python-visualization/orgs","repos_url":"https://api.github.com/users/python-visualization/repos","events_url":"https://api.github.com/users/python-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/python-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":9952134,"node_id":"MDEwOlJlcG9zaXRvcnk5OTUyMTM0","name":"folium","full_name":"python-visualization/folium","private":false,"owner":{"login":"python-visualization","id":9969242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjkyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9969242?v=4","gravatar_id":"","url":"https://api.github.com/users/python-visualization","html_url":"https://github.com/python-visualization","followers_url":"https://api.github.com/users/python-visualization/followers","following_url":"https://api.github.com/users/python-visualization/following{/other_user}","gists_url":"https://api.github.com/users/python-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/python-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-visualization/subscriptions","organizations_url":"https://api.github.com/users/python-visualization/orgs","repos_url":"https://api.github.com/users/python-visualization/repos","events_url":"https://api.github.com/users/python-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/python-visualization/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python-visualization/folium","description":"Python Data. Leaflet.js Maps. ","fork":false,"url":"https://api.github.com/repos/python-visualization/folium","forks_url":"https://api.github.com/repos/python-visualization/folium/forks","keys_url":"https://api.github.com/repos/python-visualization/folium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-visualization/folium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-visualization/folium/teams","hooks_url":"https://api.github.com/repos/python-visualization/folium/hooks","issue_events_url":"https://api.github.com/repos/python-visualization/folium/issues/events{/number}","events_url":"https://api.github.com/repos/python-visualization/folium/events","assignees_url":"https://api.github.com/repos/python-visualization/folium/assignees{/user}","branches_url":"https://api.github.com/repos/python-visualization/folium/branches{/branch}","tags_url":"https://api.github.com/repos/python-visualization/folium/tags","blobs_url":"https://api.github.com/repos/python-visualization/folium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-visualization/folium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-visualization/folium/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-visualization/folium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-visualization/folium/statuses/{sha}","languages_url":"https://api.github.com/repos/python-visualization/folium/languages","stargazers_url":"https://api.github.com/repos/python-visualization/folium/stargazers","contributors_url":"https://api.github.com/repos/python-visualization/folium/contributors","subscribers_url":"https://api.github.com/repos/python-visualization/folium/subscribers","subscription_url":"https://api.github.com/repos/python-visualization/folium/subscription","commits_url":"https://api.github.com/repos/python-visualization/folium/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-visualization/folium/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-visualization/folium/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-visualization/folium/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-visualization/folium/contents/{+path}","compare_url":"https://api.github.com/repos/python-visualization/folium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-visualization/folium/merges","archive_url":"https://api.github.com/repos/python-visualization/folium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-visualization/folium/downloads","issues_url":"https://api.github.com/repos/python-visualization/folium/issues{/number}","pulls_url":"https://api.github.com/repos/python-visualization/folium/pulls{/number}","milestones_url":"https://api.github.com/repos/python-visualization/folium/milestones{/number}","notifications_url":"https://api.github.com/repos/python-visualization/folium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-visualization/folium/labels{/name}","releases_url":"https://api.github.com/repos/python-visualization/folium/releases{/id}","deployments_url":"https://api.github.com/repos/python-visualization/folium/deployments","created_at":"2013-05-09T04:21:35Z","updated_at":"2018-09-17T02:02:12Z","pushed_at":"2018-09-17T10:05:40Z","git_url":"git://github.com/python-visualization/folium.git","ssh_url":"git@github.com:python-visualization/folium.git","clone_url":"https://github.com/python-visualization/folium.git","svn_url":"https://github.com/python-visualization/folium","homepage":"http://python-visualization.github.io/folium/","size":74431,"stargazers_count":3286,"watchers_count":3286,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":886,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":886,"open_issues":78,"watchers":3286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/959"},"html":{"href":"https://github.com/python-visualization/folium/pull/959"},"issue":{"href":"https://api.github.com/repos/python-visualization/folium/issues/959"},"comments":{"href":"https://api.github.com/repos/python-visualization/folium/issues/959/comments"},"review_comments":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/959/comments"},"review_comment":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/959/commits"},"statuses":{"href":"https://api.github.com/repos/python-visualization/folium/statuses/08f9d43ab24d7b0f805d12a5e45861aebb318860"}},"author_association":"NONE"}}
{"actor":{"display_login":"JarnoRFB"}}