{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/devkitPro/libogc/pulls/33","id":182455533,"html_url":"https://github.com/devkitPro/libogc/pull/33","diff_url":"https://github.com/devkitPro/libogc/pull/33.diff","patch_url":"https://github.com/devkitPro/libogc/pull/33.patch","issue_url":"https://api.github.com/repos/devkitPro/libogc/issues/33","number":33,"state":"closed","locked":false,"title":"libogc/si: Expose SI_SetXY() and SI_SetSamplingRate() in the public header","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"These were likely intended to be exposed, but were missed or forgotten about. If anything, `SI_SetSamplingRate()` was very likely intended to be exposed, as it sets the internal `sampling_rate` variable that `SI_RefreshSamplingRate()` uses (and this function is already exposed). Without it, any time `SI_RefreshSamplingRate()` is called, it would reset the sampling rate to zero, which is likely not always desirable.","created_at":"2018-04-18T11:58:54Z","updated_at":"2018-04-19T21:57:19Z","closed_at":"2018-04-19T21:57:19Z","merged_at":"2018-04-19T21:57:19Z","merge_commit_sha":"dca8c033002fb488f109f2b0fa1bac0fb96db368","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devkitPro/libogc/pulls/33/commits","review_comments_url":"https://api.github.com/repos/devkitPro/libogc/pulls/33/comments","review_comment_url":"https://api.github.com/repos/devkitPro/libogc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devkitPro/libogc/issues/33/comments","statuses_url":"https://api.github.com/repos/devkitPro/libogc/statuses/d6ddde6598b3c8c86f9fa6887ca0c9d5bff1d1f0","head":{"label":"lioncash:si","ref":"si","sha":"d6ddde6598b3c8c86f9fa6887ca0c9d5bff1d1f0","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"repo":{"id":129677890,"name":"libogc","full_name":"lioncash/libogc","owner":{"login":"lioncash","id":712067,"avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lioncash/libogc","description":"C Library for Wii and Gamecube homebrew","fork":true,"url":"https://api.github.com/repos/lioncash/libogc","forks_url":"https://api.github.com/repos/lioncash/libogc/forks","keys_url":"https://api.github.com/repos/lioncash/libogc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lioncash/libogc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lioncash/libogc/teams","hooks_url":"https://api.github.com/repos/lioncash/libogc/hooks","issue_events_url":"https://api.github.com/repos/lioncash/libogc/issues/events{/number}","events_url":"https://api.github.com/repos/lioncash/libogc/events","assignees_url":"https://api.github.com/repos/lioncash/libogc/assignees{/user}","branches_url":"https://api.github.com/repos/lioncash/libogc/branches{/branch}","tags_url":"https://api.github.com/repos/lioncash/libogc/tags","blobs_url":"https://api.github.com/repos/lioncash/libogc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lioncash/libogc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lioncash/libogc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lioncash/libogc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lioncash/libogc/statuses/{sha}","languages_url":"https://api.github.com/repos/lioncash/libogc/languages","stargazers_url":"https://api.github.com/repos/lioncash/libogc/stargazers","contributors_url":"https://api.github.com/repos/lioncash/libogc/contributors","subscribers_url":"https://api.github.com/repos/lioncash/libogc/subscribers","subscription_url":"https://api.github.com/repos/lioncash/libogc/subscription","commits_url":"https://api.github.com/repos/lioncash/libogc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lioncash/libogc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lioncash/libogc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lioncash/libogc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lioncash/libogc/contents/{+path}","compare_url":"https://api.github.com/repos/lioncash/libogc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lioncash/libogc/merges","archive_url":"https://api.github.com/repos/lioncash/libogc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lioncash/libogc/downloads","issues_url":"https://api.github.com/repos/lioncash/libogc/issues{/number}","pulls_url":"https://api.github.com/repos/lioncash/libogc/pulls{/number}","milestones_url":"https://api.github.com/repos/lioncash/libogc/milestones{/number}","notifications_url":"https://api.github.com/repos/lioncash/libogc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lioncash/libogc/labels{/name}","releases_url":"https://api.github.com/repos/lioncash/libogc/releases{/id}","deployments_url":"https://api.github.com/repos/lioncash/libogc/deployments","created_at":"2018-04-16T03:12:24Z","updated_at":"2018-04-16T03:12:27Z","pushed_at":"2018-04-18T13:10:41Z","git_url":"git://github.com/lioncash/libogc.git","ssh_url":"git@github.com:lioncash/libogc.git","clone_url":"https://github.com/lioncash/libogc.git","svn_url":"https://github.com/lioncash/libogc","homepage":"http://devkitpro.org/viewforum.php?f=7","size":3146,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devkitPro:master","ref":"master","sha":"2b659d31d1ea46e229d5b109812aacd9a2964ae1","user":{"login":"devkitPro","id":7538897,"avatar_url":"https://avatars3.githubusercontent.com/u/7538897?v=4","gravatar_id":"","url":"https://api.github.com/users/devkitPro","html_url":"https://github.com/devkitPro","followers_url":"https://api.github.com/users/devkitPro/followers","following_url":"https://api.github.com/users/devkitPro/following{/other_user}","gists_url":"https://api.github.com/users/devkitPro/gists{/gist_id}","starred_url":"https://api.github.com/users/devkitPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devkitPro/subscriptions","organizations_url":"https://api.github.com/users/devkitPro/orgs","repos_url":"https://api.github.com/users/devkitPro/repos","events_url":"https://api.github.com/users/devkitPro/events{/privacy}","received_events_url":"https://api.github.com/users/devkitPro/received_events","type":"Organization","site_admin":false},"repo":{"id":28180403,"name":"libogc","full_name":"devkitPro/libogc","owner":{"login":"devkitPro","id":7538897,"avatar_url":"https://avatars3.githubusercontent.com/u/7538897?v=4","gravatar_id":"","url":"https://api.github.com/users/devkitPro","html_url":"https://github.com/devkitPro","followers_url":"https://api.github.com/users/devkitPro/followers","following_url":"https://api.github.com/users/devkitPro/following{/other_user}","gists_url":"https://api.github.com/users/devkitPro/gists{/gist_id}","starred_url":"https://api.github.com/users/devkitPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devkitPro/subscriptions","organizations_url":"https://api.github.com/users/devkitPro/orgs","repos_url":"https://api.github.com/users/devkitPro/repos","events_url":"https://api.github.com/users/devkitPro/events{/privacy}","received_events_url":"https://api.github.com/users/devkitPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devkitPro/libogc","description":"C Library for Wii and Gamecube homebrew","fork":false,"url":"https://api.github.com/repos/devkitPro/libogc","forks_url":"https://api.github.com/repos/devkitPro/libogc/forks","keys_url":"https://api.github.com/repos/devkitPro/libogc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devkitPro/libogc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devkitPro/libogc/teams","hooks_url":"https://api.github.com/repos/devkitPro/libogc/hooks","issue_events_url":"https://api.github.com/repos/devkitPro/libogc/issues/events{/number}","events_url":"https://api.github.com/repos/devkitPro/libogc/events","assignees_url":"https://api.github.com/repos/devkitPro/libogc/assignees{/user}","branches_url":"https://api.github.com/repos/devkitPro/libogc/branches{/branch}","tags_url":"https://api.github.com/repos/devkitPro/libogc/tags","blobs_url":"https://api.github.com/repos/devkitPro/libogc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devkitPro/libogc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devkitPro/libogc/git/refs{/sha}","trees_url":"https://api.github.com/repos/devkitPro/libogc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devkitPro/libogc/statuses/{sha}","languages_url":"https://api.github.com/repos/devkitPro/libogc/languages","stargazers_url":"https://api.github.com/repos/devkitPro/libogc/stargazers","contributors_url":"https://api.github.com/repos/devkitPro/libogc/contributors","subscribers_url":"https://api.github.com/repos/devkitPro/libogc/subscribers","subscription_url":"https://api.github.com/repos/devkitPro/libogc/subscription","commits_url":"https://api.github.com/repos/devkitPro/libogc/commits{/sha}","git_commits_url":"https://api.github.com/repos/devkitPro/libogc/git/commits{/sha}","comments_url":"https://api.github.com/repos/devkitPro/libogc/comments{/number}","issue_comment_url":"https://api.github.com/repos/devkitPro/libogc/issues/comments{/number}","contents_url":"https://api.github.com/repos/devkitPro/libogc/contents/{+path}","compare_url":"https://api.github.com/repos/devkitPro/libogc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devkitPro/libogc/merges","archive_url":"https://api.github.com/repos/devkitPro/libogc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devkitPro/libogc/downloads","issues_url":"https://api.github.com/repos/devkitPro/libogc/issues{/number}","pulls_url":"https://api.github.com/repos/devkitPro/libogc/pulls{/number}","milestones_url":"https://api.github.com/repos/devkitPro/libogc/milestones{/number}","notifications_url":"https://api.github.com/repos/devkitPro/libogc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devkitPro/libogc/labels{/name}","releases_url":"https://api.github.com/repos/devkitPro/libogc/releases{/id}","deployments_url":"https://api.github.com/repos/devkitPro/libogc/deployments","created_at":"2014-12-18T11:13:41Z","updated_at":"2018-04-19T21:56:35Z","pushed_at":"2018-04-19T21:57:18Z","git_url":"git://github.com/devkitPro/libogc.git","ssh_url":"git@github.com:devkitPro/libogc.git","clone_url":"https://github.com/devkitPro/libogc.git","svn_url":"https://github.com/devkitPro/libogc","homepage":"http://devkitpro.org/viewforum.php?f=7","size":3125,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":2,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devkitPro/libogc/pulls/33"},"html":{"href":"https://github.com/devkitPro/libogc/pull/33"},"issue":{"href":"https://api.github.com/repos/devkitPro/libogc/issues/33"},"comments":{"href":"https://api.github.com/repos/devkitPro/libogc/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/devkitPro/libogc/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/devkitPro/libogc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devkitPro/libogc/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/devkitPro/libogc/statuses/d6ddde6598b3c8c86f9fa6887ca0c9d5bff1d1f0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"WinterMute","id":101194,"avatar_url":"https://avatars3.githubusercontent.com/u/101194?v=4","gravatar_id":"","url":"https://api.github.com/users/WinterMute","html_url":"https://github.com/WinterMute","followers_url":"https://api.github.com/users/WinterMute/followers","following_url":"https://api.github.com/users/WinterMute/following{/other_user}","gists_url":"https://api.github.com/users/WinterMute/gists{/gist_id}","starred_url":"https://api.github.com/users/WinterMute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WinterMute/subscriptions","organizations_url":"https://api.github.com/users/WinterMute/orgs","repos_url":"https://api.github.com/users/WinterMute/repos","events_url":"https://api.github.com/users/WinterMute/events{/privacy}","received_events_url":"https://api.github.com/users/WinterMute/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"WinterMute"}}