{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/182716937","pull_request_review_id":113568436,"id":182716937,"diff_hunk":"@@ -227,450 +244,490 @@ mbedtls_ecp_keypair;\n  *\n  * Change this value to 0 to reduce peak memory usage.\n  */\n-#define MBEDTLS_ECP_FIXED_POINT_OPTIM  1   /**< Enable fixed-point speed-up */\n+#define MBEDTLS_ECP_FIXED_POINT_OPTIM  1   /**< Enable fixed-point speed-up. */\n #endif /* MBEDTLS_ECP_FIXED_POINT_OPTIM */\n \n /* \\} name SECTION: Module settings */\n \n /*\n  * Point formats, from RFC 4492's enum ECPointFormat\n  */\n-#define MBEDTLS_ECP_PF_UNCOMPRESSED    0   /**< Uncompressed point format */\n-#define MBEDTLS_ECP_PF_COMPRESSED      1   /**< Compressed point format */\n+#define MBEDTLS_ECP_PF_UNCOMPRESSED    0   /**< Uncompressed point format. */\n+#define MBEDTLS_ECP_PF_COMPRESSED      1   /**< Compressed point format. */\n \n /*\n  * Some other constants from RFC 4492\n  */\n-#define MBEDTLS_ECP_TLS_NAMED_CURVE    3   /**< ECCurveType's named_curve */\n+#define MBEDTLS_ECP_TLS_NAMED_CURVE    3   /**< The named_curve of ECCurveType. */\n \n /**\n- * \\brief           Get the list of supported curves in order of preferrence\n- *                  (full information)\n+ * \\brief           This function retrieves the information defined in\n+ *                  mbedtls_ecp_curve_info()for all supported curves in order\n+ *                  of preference.\n  *\n- * \\return          A statically allocated array, the last entry is 0.\n+ * \\return          A statically allocated array. The last entry is 0.\n  */\n const mbedtls_ecp_curve_info *mbedtls_ecp_curve_list( void );\n \n /**\n- * \\brief           Get the list of supported curves in order of preferrence\n- *                  (grp_id only)\n+ * \\brief           This function retrieves the grp_id of all supported curves\n+ *                  in order of preference.\n  *\n  * \\return          A statically allocated array,\n  *                  terminated with MBEDTLS_ECP_DP_NONE.\n  */\n const mbedtls_ecp_group_id *mbedtls_ecp_grp_id_list( void );\n \n /**\n- * \\brief           Get curve information from an internal group identifier\n+ * \\brief           This function retrieves curve information from an internal\n+ *                  group identifier.\n  *\n- * \\param grp_id    A MBEDTLS_ECP_DP_XXX value\n+ * \\param grp_id    An \\c MBEDTLS_ECP_DP_XXX value.\n  *\n- * \\return          The associated curve information or NULL\n+ * \\return          The associated curve information, or NULL.\n  */\n const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_grp_id( mbedtls_ecp_group_id grp_id );\n \n /**\n- * \\brief           Get curve information from a TLS NamedCurve value\n+ * \\brief           This function retrieves curve information from a TLS \n+ *                  NamedCurve value.\n  *\n- * \\param tls_id    A MBEDTLS_ECP_DP_XXX value\n+ * \\param tls_id    An \\c MBEDTLS_ECP_DP_XXX value.\n  *\n- * \\return          The associated curve information or NULL\n+ * \\return          The associated curve information, or NULL.\n  */\n const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_tls_id( uint16_t tls_id );\n \n /**\n- * \\brief           Get curve information from a human-readable name\n+ * \\brief           This function retrieves curve information from a \n+ *                  human-readable name.\n  *\n- * \\param name      The name\n+ * \\param name      The human-readable name.\n  *\n- * \\return          The associated curve information or NULL\n+ * \\return          The associated curve information, or NULL.\n  */\n const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_name( const char *name );\n \n /**\n- * \\brief           Initialize a point (as zero)\n+ * \\brief           This function initializes a point as zero.\n+ *\n+ * \\param pt        The point to initialize.\n  */\n void mbedtls_ecp_point_init( mbedtls_ecp_point *pt );\n \n /**\n- * \\brief           Initialize a group (to something meaningless)\n+ * \\brief           This function initializes a group to something meaningless.","path":"include/mbedtls/ecp.h","position":374,"original_position":374,"commit_id":"d3c9bfcbeb02fdb89097d33326a6d1efd52c6a73","original_commit_id":"d3c9bfcbeb02fdb89097d33326a6d1efd52c6a73","user":{"login":"RosZad","id":30112862,"avatar_url":"https://avatars2.githubusercontent.com/u/30112862?v=4","gravatar_id":"","url":"https://api.github.com/users/RosZad","html_url":"https://github.com/RosZad","followers_url":"https://api.github.com/users/RosZad/followers","following_url":"https://api.github.com/users/RosZad/following{/other_user}","gists_url":"https://api.github.com/users/RosZad/gists{/gist_id}","starred_url":"https://api.github.com/users/RosZad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RosZad/subscriptions","organizations_url":"https://api.github.com/users/RosZad/orgs","repos_url":"https://api.github.com/users/RosZad/repos","events_url":"https://api.github.com/users/RosZad/events{/privacy}","received_events_url":"https://api.github.com/users/RosZad/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-04-19T11:38:34Z","updated_at":"2018-04-19T11:38:34Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1578#discussion_r182716937","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/182716937"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1578#discussion_r182716937"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578"}},"in_reply_to_id":182364327},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578","id":182112406,"html_url":"https://github.com/ARMmbed/mbedtls/pull/1578","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1578.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1578.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1578","number":1578,"state":"open","locked":false,"title":"Update ecp.h","user":{"login":"RosZad","id":30112862,"avatar_url":"https://avatars2.githubusercontent.com/u/30112862?v=4","gravatar_id":"","url":"https://api.github.com/users/RosZad","html_url":"https://github.com/RosZad","followers_url":"https://api.github.com/users/RosZad/followers","following_url":"https://api.github.com/users/RosZad/following{/other_user}","gists_url":"https://api.github.com/users/RosZad/gists{/gist_id}","starred_url":"https://api.github.com/users/RosZad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RosZad/subscriptions","organizations_url":"https://api.github.com/users/RosZad/orgs","repos_url":"https://api.github.com/users/RosZad/repos","events_url":"https://api.github.com/users/RosZad/events{/privacy}","received_events_url":"https://api.github.com/users/RosZad/received_events","type":"User","site_admin":false},"body":"Fully reviewed and standardized to match other files (file description, functions, parameters, enums, writing guidelines, etc.)","created_at":"2018-04-17T09:57:17Z","updated_at":"2018-04-19T11:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ce94277658ea18beceffa4707d322c7fecc0e61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820027428,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/Arm%20Contribution","name":"Arm Contribution","color":"66e0ff","default":false},{"id":19280386,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":705358813,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1578/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/d3c9bfcbeb02fdb89097d33326a6d1efd52c6a73","head":{"label":"RosZad:patch-31","ref":"patch-31","sha":"d3c9bfcbeb02fdb89097d33326a6d1efd52c6a73","user":{"login":"RosZad","id":30112862,"avatar_url":"https://avatars2.githubusercontent.com/u/30112862?v=4","gravatar_id":"","url":"https://api.github.com/users/RosZad","html_url":"https://github.com/RosZad","followers_url":"https://api.github.com/users/RosZad/followers","following_url":"https://api.github.com/users/RosZad/following{/other_user}","gists_url":"https://api.github.com/users/RosZad/gists{/gist_id}","starred_url":"https://api.github.com/users/RosZad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RosZad/subscriptions","organizations_url":"https://api.github.com/users/RosZad/orgs","repos_url":"https://api.github.com/users/RosZad/repos","events_url":"https://api.github.com/users/RosZad/events{/privacy}","received_events_url":"https://api.github.com/users/RosZad/received_events","type":"User","site_admin":false},"repo":{"id":118446724,"name":"mbedtls","full_name":"RosZad/mbedtls","owner":{"login":"RosZad","id":30112862,"avatar_url":"https://avatars2.githubusercontent.com/u/30112862?v=4","gravatar_id":"","url":"https://api.github.com/users/RosZad","html_url":"https://github.com/RosZad","followers_url":"https://api.github.com/users/RosZad/followers","following_url":"https://api.github.com/users/RosZad/following{/other_user}","gists_url":"https://api.github.com/users/RosZad/gists{/gist_id}","starred_url":"https://api.github.com/users/RosZad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RosZad/subscriptions","organizations_url":"https://api.github.com/users/RosZad/orgs","repos_url":"https://api.github.com/users/RosZad/repos","events_url":"https://api.github.com/users/RosZad/events{/privacy}","received_events_url":"https://api.github.com/users/RosZad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RosZad/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/RosZad/mbedtls","forks_url":"https://api.github.com/repos/RosZad/mbedtls/forks","keys_url":"https://api.github.com/repos/RosZad/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RosZad/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RosZad/mbedtls/teams","hooks_url":"https://api.github.com/repos/RosZad/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/RosZad/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/RosZad/mbedtls/events","assignees_url":"https://api.github.com/repos/RosZad/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/RosZad/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/RosZad/mbedtls/tags","blobs_url":"https://api.github.com/repos/RosZad/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RosZad/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RosZad/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/RosZad/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RosZad/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/RosZad/mbedtls/languages","stargazers_url":"https://api.github.com/repos/RosZad/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/RosZad/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/RosZad/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/RosZad/mbedtls/subscription","commits_url":"https://api.github.com/repos/RosZad/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/RosZad/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/RosZad/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/RosZad/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/RosZad/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/RosZad/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RosZad/mbedtls/merges","archive_url":"https://api.github.com/repos/RosZad/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RosZad/mbedtls/downloads","issues_url":"https://api.github.com/repos/RosZad/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/RosZad/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/RosZad/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/RosZad/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RosZad/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/RosZad/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/RosZad/mbedtls/deployments","created_at":"2018-01-22T11:12:39Z","updated_at":"2018-01-22T11:12:44Z","pushed_at":"2018-04-18T14:10:03Z","git_url":"git://github.com/RosZad/mbedtls.git","ssh_url":"git@github.com:RosZad/mbedtls.git","clone_url":"https://github.com/RosZad/mbedtls.git","svn_url":"https://github.com/RosZad/mbedtls","homepage":"https://tls.mbed.org","size":25493,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"4ca9a457561fc774ca54898a72754bf53d60dba2","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-04-19T10:03:03Z","pushed_at":"2018-04-18T20:30:07Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":26458,"stargazers_count":1350,"watchers_count":1350,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":835,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":835,"open_issues":428,"watchers":1350,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1578"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1578"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1578/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1578/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/d3c9bfcbeb02fdb89097d33326a6d1efd52c6a73"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RosZad"}}