{"push_id":2588382117,"size":70,"distinct_size":70,"ref":"refs/heads/master","head":"aa02b297444755a08fb2414e2189f9b61fd23d2d","before":"b8dee3277475b01095a7baf87a0d94a59b736d81","commits":[{"sha":"9e13aeae327e2c0bda9b6fa4e52537320a7ff2fe","author":{"name":"Alex Robinson","email":"e522668276737e0807508286ee469559f9379f53@gmail.com"},"message":"sql: Include mandatory FROM keyword in EXPORT help text\n\nTouches #25223\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/9e13aeae327e2c0bda9b6fa4e52537320a7ff2fe"},{"sha":"d2c47642105308147462960d2bc8cffef8ef022c","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"scripts: always use CCACHE on gceworker\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/d2c47642105308147462960d2bc8cffef8ef022c"},{"sha":"89d4795dd5f693b34aad20a1e1dbc38b70374da4","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"scripts: set dev license on gceworker creation\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/89d4795dd5f693b34aad20a1e1dbc38b70374da4"},{"sha":"4412d54ab62073886b4b2293c55f0971f5b89331","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"server: log on SET CLUSTER SETTING mismatch\n\nTouches #25761.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/4412d54ab62073886b4b2293c55f0971f5b89331"},{"sha":"54c3e5dd493c5e830e3b6b7864e94d4adff3e9ed","author":{"name":"marc","email":"d33c80bc45d65303e33ca83108a9952b745af9ef@cockroachlabs.com"},"message":"k8s: upgrade configs to 2.0.2","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/54c3e5dd493c5e830e3b6b7864e94d4adff3e9ed"},{"sha":"034d3887e6aebb85ed38ac0f3376eae2fd994709","author":{"name":"marc","email":"d33c80bc45d65303e33ca83108a9952b745af9ef@cockroachlabs.com"},"message":"rhel: update to 2.0.2","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/034d3887e6aebb85ed38ac0f3376eae2fd994709"},{"sha":"60a08c1719aebcd4e6ed6673e5f751e665875eca","author":{"name":"Masha Schneider","email":"9a19271f701eeb7a4e6dffa6a484ec27a6e51a66@cockroachlabs.com"},"message":"workload: add partition affinity to TPCC workload\n\nBefore there was no good way to run multiple TPCC workloads against one\ncluster because we couldn't peg the load generator to a specific range\nof warehouses.\n\nNow TPCC has a flag to set parition affinity for paritioned tables, so\nthat it will only run against warehouses in one partition while knowing\nthat it's a subset of the total warehouses. This will keep the total\ncluster TPMC within the correct bounds.\n\nCloses #25087\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/60a08c1719aebcd4e6ed6673e5f751e665875eca"},{"sha":"45de80897d5a66fb29b6db537e3949b5b21dfc26","author":{"name":"Matt Jibson","email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com"},"message":"jobs: stop checking most job times against each other\n\nThis isn't safe due to clock jumps and isn't worth fixing anyway.\n\nFixes #24719\nFixes #24720\nFixes #24721\nFixes #24806\nFixes #24973\nFixes #25118\nFixes #25119\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/45de80897d5a66fb29b6db537e3949b5b21dfc26"},{"sha":"228d1273b4dc42eb47b68000cd3f2ffb1a2a7509","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Update errors to match 2.0\n\nUpdate a couple of errors so that text matches 2.0.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/228d1273b4dc42eb47b68000cd3f2ffb1a2a7509"},{"sha":"3a9914988395171dd7be1c8d5e8849abcf05b36b","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"sql: Split aggregate logic test so that it can be reused\n\nThis commit splits the aggregate logic test into multiple parts:\n\n  logic_test/aggregate\n    This part excludes EXPLAIN and SHOW TRACE queries, since their output\n    only applies to the heuristic planner. These queries often fail with the\n    cost-based optimizer, which often uses a different execution plan. With\n    the EXPLAIN and SHOW TRACE queries removed, this test can now be\n    successfully run using the cost-based optimizer (\"opt\" config).\n\n  planner_test/aggregate\n    This part includes all the EXPLAIN and SHOW TRACE queries that were\n    removed from the original logic_test. The expected output is the same\n    as it originally was; namely the plans that the heuristic planner\n    derives.\n\n  opt/exec/execbuilder\n    This part is analogous to the planner_test part, except that the EXPLAIN\n    and SHOW TRACE queries run with the cost-based optimizer. Most of these\n    tests had already been copied to the `opt` packages, so this commit just\n    copies a few additional tests that never made it over, as well as delete\n    redundant tests that are already part of the logic_test suite.\n\nThere are still 150+ other tests to split. This commit serves as the template\nfor how that will be done. Once the larger team is happy with the methodology,\nwe'll begin the work of migrating the other tests.\n\nWith this change, while we do lose the convenience of having execution output\npaired with EXPLAIN/TRACE output, we gain the ability to run the same set of\nlogic tests against a wider variety of configurations. By doing so, we stick\nmore closely to the spirit of the original SQLite sqllogictest methodology.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/3a9914988395171dd7be1c8d5e8849abcf05b36b"},{"sha":"a12c1d86859809415f6ea880e84fee93af33985b","author":{"name":"Matt Tracy","email":"1fa2ef4755a9226cb9a0a4840bd89b158ac71391@cockroachlabs.com"},"message":"ts: Switch tests over to new query model\n\nCompletes the new query model (by adding support for near-current-time\nfiltering) and swaps tests for tsdb completely to the new query model.\n\n+ Adds support for filtering data points for \"incomplete\" sample\nperiods, which had a tendency to create persistent artifacts on our time\nseries graphs. In the old query system this was being done using two\ndifferent methods, one for downsampled points and another for points\nwhich are not being downsampled. The new model uses a single method for\nfiltering both types of points.\n+ Adjust TS tests model to handle incomplete sample filtering.\n+ Adds new tests for incomplete sample filtering, which were not present\nat all for the old model.\n+ Swaps over tsdb model tests to only use the new query model - this is\nnecessary because the new tests would not pass on the old model.\n+ Adds new unit test for the downsampling code of the new query model.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/a12c1d86859809415f6ea880e84fee93af33985b"},{"sha":"6c68ad6889545a7aa05bf20701010feeb4504f65","author":{"name":"Matt Tracy","email":"1fa2ef4755a9226cb9a0a4840bd89b158ac71391@cockroachlabs.com"},"message":"ts: Swap to new Query implementation.\n\nSwap to new query implementation, removing the old query implementation\ncompletely.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/6c68ad6889545a7aa05bf20701010feeb4504f65"},{"sha":"450a34b0c708af3ef2796cdba185d2100359ef40","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Change Cast optimizer expression to use column type\n\nThe Cast opt expression's target cast type is currently a datum type.\nHowever, this means that SQL types such as VARCHAR(128) and SMALLINT\nare converted to datum types that discard their width information. This\nleads to incorrect behavior for queries like:\n\n  SELECT 'hello'::VARCHAR(2)\n\nThis query should return 'he', but currently returns 'hello', because\nthe cast has been mapped to the STRING datum type, causing the width to\nbe ignored.\n\nThis commit updates the Cast optimizer expression to use a column type\nrather than a datum type. The EliminateCast rule changes to only discard\nthe Cast if doing so will not lose type information. A new\nTryCastTargetToDatumType method in the coltypes package can now be used\nto determine  whether a particular Cast operation will lose type\ninformation.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/450a34b0c708af3ef2796cdba185d2100359ef40"},{"sha":"36c1f98869d7f67a96166643ce1425104731e717","author":{"name":"Solon Gordon","email":"d094ebad5aad5ff73e8bc3d2d3255e9c9f2f189a@cockroachlabs.com"},"message":"distsql: support lookup join on secondary index\n\njoinReader now supports lookup joins on secondary indexes. This was a\ntrivial change for queries where all the output columns are included in\nthe secondary index. I just modified the physical planner to specify the\nsecondary index in the JoinReaderSpec and removed checks which prevented\nsecondary indexes from being used.\n\nThe more complicated situation is when we want to do a lookup join\nagainst a non-covering index. In this case, the logical planner plans an\nindex join before the inner join, but we want to perform the lookup join\nfirst. We now handle this by only planning the lookup join during\nphysical planning, not the index join. During execution, the joinReader\ndetects that there are output columns not covered by the secondary\nindex, and it performs primary index lookups as necessary to retrieve\nthe additional columns.\n\nFixes #25431\n\nRelease note (sql change): The experimental lookup join feature now\nsupports secondary indexes.","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/36c1f98869d7f67a96166643ce1425104731e717"},{"sha":"b6d56983fe4166d3f12c2af0bbfe4438ac9a3aaa","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"cmd/roachtest: add testSpec.MinVersion\n\nAllow tests to specify the minimum cockroach version they require to\nrun. If the build version (auto-detected using git or specified by the\n`--build-tag` flag) is less than the min version specified for the test,\nthe test is skipped. For example, if `upgrade/oldVersion=v2.0.0` (which\nhas a min version of `v2.1.0`) is run on the `release-2.0` branch we\nsee:\n\n    === RUN   upgrade/oldVersion=v2.0.0/nodes=5 [unstable,skip]\n    --- SKIP: upgrade/oldVersion=v2.0.0/nodes=5 (0.00s)\n        build-version (2.0.2) < min-version (2.1.0-0)\n\nFixes #25740\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/b6d56983fe4166d3f12c2af0bbfe4438ac9a3aaa"},{"sha":"c138ab71b396962dd207048d9e2dbefe4a9f7a50","author":{"name":"Pete Vilter","email":"bff6eb38fad1cf5d6b7237e52df7fff6aecbd405@cockroachlabs.com"},"message":"ui: add top-level LoginContainer: require login before rendering anything\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/c138ab71b396962dd207048d9e2dbefe4a9f7a50"},{"sha":"c840d73d7cf39dcb6d7906f3649cda9b61959b71","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: refactor LoginState to manage enabled/disabled\n\nThis allows us to have one object representing both \"is login enabled?\"\nand \"does this user have access?\" state questions.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/c840d73d7cf39dcb6d7906f3649cda9b61959b71"},{"sha":"29db67403dbea39c4229651cdffc4987c9ad3269","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: redirect to login page when not authned\n\nPreviously, the login page was swapped in for the content of a page if\na user was not logged in.  This changes the behavior to instead redirect\nto a free standing login page.\n\nThe original URL accessed is stashed in the query parameter redirectTo,\nand after authentication the user is returned to that page.\n\nRelease note: None.","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/29db67403dbea39c4229651cdffc4987c9ad3269"},{"sha":"c0ee127fcafc5c233dde562f4ba8421387029012","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: redact URLs encoded in query parameters\n\nPrevent URLs from slipping though the analytics redactions if the are\nencoded in a query parameter, as with the login redirect param.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/c0ee127fcafc5c233dde562f4ba8421387029012"},{"sha":"672df850e6de1478a26fd7d9f78177a52c3c8975","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25796\n\n25796: opt: Change Cast operator to use column type r=andy-kimball a=andy-kimball\n\nopt: Change Cast optimizer expression to use column type\r\n\r\nThe Cast opt expression's target cast type is currently a datum type.\r\nHowever, this means that SQL types such as VARCHAR(128) and SMALLINT\r\nare converted to datum types that discard their width information. This\r\nleads to incorrect behavior for queries like:\r\n\r\n  SELECT 'hello'::VARCHAR(2)\r\n\r\nThis query should return 'he', but currently returns 'hello', because\r\nthe cast has been mapped to the STRING datum type, causing the width to\r\nbe ignored.\r\n\r\nThis commit updates the Cast optimizer expression to use a column type\r\nrather than a datum type. The EliminateCast rule changes to only discard\r\nthe Cast if doing so will not lose type information. A new\r\nTryCastTargetToDatumType method in the coltypes package can now be used\r\nto determine  whether a particular Cast operation will lose type\r\ninformation.\r\n\r\nRelease note: None\n\nCo-authored-by: Andrew Kimball <andyk@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/672df850e6de1478a26fd7d9f78177a52c3c8975"}]}
{"actor":{"display_login":"bdarnell"}}