{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/590","repository_url":"https://api.github.com/repos/bazelbuild/rules_scala","labels_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/590/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/590/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/590/events","html_url":"https://github.com/bazelbuild/rules_scala/pull/590","id":351923780,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzcyOTcy","number":590,"title":"changed explicit references of external workspaces to bind","user":{"login":"ittaiz","id":1378327,"node_id":"MDQ6VXNlcjEzNzgzMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1378327?v=4","gravatar_id":"","url":"https://api.github.com/users/ittaiz","html_url":"https://github.com/ittaiz","followers_url":"https://api.github.com/users/ittaiz/followers","following_url":"https://api.github.com/users/ittaiz/following{/other_user}","gists_url":"https://api.github.com/users/ittaiz/gists{/gist_id}","starred_url":"https://api.github.com/users/ittaiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ittaiz/subscriptions","organizations_url":"https://api.github.com/users/ittaiz/orgs","repos_url":"https://api.github.com/users/ittaiz/repos","events_url":"https://api.github.com/users/ittaiz/events{/privacy}","received_events_url":"https://api.github.com/users/ittaiz/received_events","type":"User","site_admin":false},"labels":[{"id":330860803,"node_id":"MDU6TGFiZWwzMzA4NjA4MDM=","url":"https://api.github.com/repos/bazelbuild/rules_scala/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-19T18:30:09Z","updated_at":"2018-08-22T17:01:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/pulls/590","html_url":"https://github.com/bazelbuild/rules_scala/pull/590","diff_url":"https://github.com/bazelbuild/rules_scala/pull/590.diff","patch_url":"https://github.com/bazelbuild/rules_scala/pull/590.patch"},"body":"@johnynek @jhnj I'm trying to upgrade to the latest rules_scala and am encountering some difficulties.\r\nWe are using our own custom versions of dependencies and so don't call `scala_repositories`. \r\nWhat  we've been doing up until now is `bind` to the required points by rules_scala.\r\n\r\nAfter applying the below changes the project compiles. \r\nI'm not certain they should be merged into master since my gut tells me we're trying to phase out the `bind`s in favor of the `declare_scalac_provider` but I'm not sure we're there.\r\n1. Do we want to phase out `bind`s in favor of custom scalac_provider/scala_provider?\r\n2. How can one declare their own scalac_provider? Currently it's a private attribute\r\n3. Sounds like `//src/java/io/bazel/rulesscala/scalac` needs to change one way or another. Use `bind`s or  somehow depend on the `scalac_provider` and take from it the `default_repl_classpath` (need to decide what to do about commons_io).\r\n\r\nWould really appreciate your help on this,\r\nIttai"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/comments/415104279","html_url":"https://github.com/bazelbuild/rules_scala/pull/590#issuecomment-415104279","issue_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/590","id":415104279,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTEwNDI3OQ==","user":{"login":"ittaiz","id":1378327,"node_id":"MDQ6VXNlcjEzNzgzMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1378327?v=4","gravatar_id":"","url":"https://api.github.com/users/ittaiz","html_url":"https://github.com/ittaiz","followers_url":"https://api.github.com/users/ittaiz/followers","following_url":"https://api.github.com/users/ittaiz/following{/other_user}","gists_url":"https://api.github.com/users/ittaiz/gists{/gist_id}","starred_url":"https://api.github.com/users/ittaiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ittaiz/subscriptions","organizations_url":"https://api.github.com/users/ittaiz/orgs","repos_url":"https://api.github.com/users/ittaiz/repos","events_url":"https://api.github.com/users/ittaiz/events{/privacy}","received_events_url":"https://api.github.com/users/ittaiz/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T17:01:25Z","updated_at":"2018-08-22T17:01:25Z","author_association":"MEMBER","body":"That was my initial hunch.\nThis PR is to show what we needed to do.\nA PR to the readme sounds great.\nI’ll probably try it out on Sunday (AFK for a couple of days) and if it\nworks then we’ll close this one.\nOn Wed, 22 Aug 2018 at 17:35 P. Oscar Boykin <notifications@github.com>\nwrote:\n\n> Sorry @ittaiz <https://github.com/ittaiz> I didn’t look till now.\n>\n> So can I instead make a PR to the readme later today that shows you how to\n> set things up with the scala provider? We also customize but do it using\n> the provider. If we merge this we basically revert most of the scala\n> provider but leave the mechanism around.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bazelbuild/rules_scala/pull/590#issuecomment-415054271>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABUIF8sum4CkYS4JN0Av1xnbBc-EjeyJks5uTWwmgaJpZM4WDERv>\n> .\n>\n"}}
{"actor":{"display_login":"ittaiz"}}