{"action":"created","issue":{"url":"https://api.github.com/repos/spack/spack/issues/10026","repository_url":"https://api.github.com/repos/spack/spack","labels_url":"https://api.github.com/repos/spack/spack/issues/10026/labels{/name}","comments_url":"https://api.github.com/repos/spack/spack/issues/10026/comments","events_url":"https://api.github.com/repos/spack/spack/issues/10026/events","html_url":"https://github.com/spack/spack/pull/10026","id":387824193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjI3NTQw","number":10026,"title":"Fftw issue 7372","user":{"login":"payerle","id":19287807,"node_id":"MDQ6VXNlcjE5Mjg3ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/19287807?v=4","gravatar_id":"","url":"https://api.github.com/users/payerle","html_url":"https://github.com/payerle","followers_url":"https://api.github.com/users/payerle/followers","following_url":"https://api.github.com/users/payerle/following{/other_user}","gists_url":"https://api.github.com/users/payerle/gists{/gist_id}","starred_url":"https://api.github.com/users/payerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payerle/subscriptions","organizations_url":"https://api.github.com/users/payerle/orgs","repos_url":"https://api.github.com/users/payerle/repos","events_url":"https://api.github.com/users/payerle/events{/privacy}","received_events_url":"https://api.github.com/users/payerle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-05T15:57:42Z","updated_at":"2018-12-05T19:08:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/10026","html_url":"https://github.com/spack/spack/pull/10026","diff_url":"https://github.com/spack/spack/pull/10026.diff","patch_url":"https://github.com/spack/spack/pull/10026.patch"},"body":"This is to address https://github.com/spack/spack/issues/7372\r\n\r\nBasically, fftw 2.1.5 ships with a config.h in source tree with all options commented out.  The #includes in other source files will pick up this incorrect config.h instead of the one in the build directory and therefore have bad defines.  In particular, F77_FUNC_ does not get defined, causing the bulk of fftwf77.c to be skipped due to an #ifdef so functions are missing in libdfftw.so\r\n\r\nTo fix, the configure method now renames fftw/config.h in source tree if it is found.\r\n\r\nAlso encountered some errors due to inconsistent handling of quad/long-double variant flags between configure and the build, check, and install methods.  Made consistent."},"comment":{"url":"https://api.github.com/repos/spack/spack/issues/comments/444604993","html_url":"https://github.com/spack/spack/pull/10026#issuecomment-444604993","issue_url":"https://api.github.com/repos/spack/spack/issues/10026","id":444604993,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDYwNDk5Mw==","user":{"login":"payerle","id":19287807,"node_id":"MDQ6VXNlcjE5Mjg3ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/19287807?v=4","gravatar_id":"","url":"https://api.github.com/users/payerle","html_url":"https://github.com/payerle","followers_url":"https://api.github.com/users/payerle/followers","following_url":"https://api.github.com/users/payerle/following{/other_user}","gists_url":"https://api.github.com/users/payerle/gists{/gist_id}","starred_url":"https://api.github.com/users/payerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payerle/subscriptions","organizations_url":"https://api.github.com/users/payerle/orgs","repos_url":"https://api.github.com/users/payerle/repos","events_url":"https://api.github.com/users/payerle/events{/privacy}","received_events_url":"https://api.github.com/users/payerle/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T19:08:57Z","updated_at":"2018-12-05T19:08:57Z","author_association":"NONE","body":"Based on OOB email feedback from Todd Gamblin, using patch() method instead of configure() as\r\nis a more reasonable location for this."}}
{"actor":{"display_login":"payerle"}}