{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/241582703","pull_request_review_id":184895567,"id":241582703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU4MjcwMw==","diff_hunk":"@@ -175,6 +175,12 @@ def test_transpose(self):\n         x = torch.tensor([[0.0, 1.0], [2.0, 3.0]], requires_grad=True)\n         self.assertONNX(lambda x: x.transpose(0, 1).transpose(1, 0), x)\n \n+    def test_scatter(self):\n+        data = torch.zeros(3, 3)\n+        updates = torch.randn(2, 3)\n+        indices=torch.tensor([[1,0,2],[0,2,1],])\n+        self.assertONNX(lambda x: x.scatter_(0, indices, updates), data)","path":"test/onnx/test_operators.py","position":8,"original_position":8,"commit_id":"e1266f33fa9e2316255da8ad5bbf7d6ac993a3b1","original_commit_id":"e1266f33fa9e2316255da8ad5bbf7d6ac993a3b1","user":{"login":"jamesr66a","id":4685384,"node_id":"MDQ6VXNlcjQ2ODUzODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4685384?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesr66a","html_url":"https://github.com/jamesr66a","followers_url":"https://api.github.com/users/jamesr66a/followers","following_url":"https://api.github.com/users/jamesr66a/following{/other_user}","gists_url":"https://api.github.com/users/jamesr66a/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesr66a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesr66a/subscriptions","organizations_url":"https://api.github.com/users/jamesr66a/orgs","repos_url":"https://api.github.com/users/jamesr66a/repos","events_url":"https://api.github.com/users/jamesr66a/events{/privacy}","received_events_url":"https://api.github.com/users/jamesr66a/received_events","type":"User","site_admin":false},"body":"We should be supporting x.scatter(), not x.scatter_(). Note `scatter()` is defined here https://fburl.com/owk2hefy and will likely need to be moved to ATen ","created_at":"2018-12-13T22:20:15Z","updated_at":"2018-12-13T22:20:19Z","html_url":"https://github.com/pytorch/pytorch/pull/15179#discussion_r241582703","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/241582703"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15179#discussion_r241582703"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15179"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/15179","id":238516637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTE2NjM3","html_url":"https://github.com/pytorch/pytorch/pull/15179","diff_url":"https://github.com/pytorch/pytorch/pull/15179.diff","patch_url":"https://github.com/pytorch/pytorch/pull/15179.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/15179","number":15179,"state":"open","locked":false,"title":"[ONNX]Add scatter symbolic in pytorch & Remove _force_outplace=True in jit trace","user":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"body":"This pr add symbolic and relative testcase of scatter op, and since we already have RemoveInplaceOp in C.jit, we should not force an op to be outplace when tracing.","created_at":"2018-12-13T20:10:16Z","updated_at":"2018-12-13T22:20:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba17017b8dbfb4a41265307bbd2f0182dc89211","assignee":null,"assignees":[],"requested_reviewers":[{"login":"suo","id":1617424,"node_id":"MDQ6VXNlcjE2MTc0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1617424?v=4","gravatar_id":"","url":"https://api.github.com/users/suo","html_url":"https://github.com/suo","followers_url":"https://api.github.com/users/suo/followers","following_url":"https://api.github.com/users/suo/following{/other_user}","gists_url":"https://api.github.com/users/suo/gists{/gist_id}","starred_url":"https://api.github.com/users/suo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suo/subscriptions","organizations_url":"https://api.github.com/users/suo/orgs","repos_url":"https://api.github.com/users/suo/repos","events_url":"https://api.github.com/users/suo/events{/privacy}","received_events_url":"https://api.github.com/users/suo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15179/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15179/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/15179/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/e1266f33fa9e2316255da8ad5bbf7d6ac993a3b1","head":{"label":"zrphercule:add_scatter","ref":"add_scatter","sha":"e1266f33fa9e2316255da8ad5bbf7d6ac993a3b1","user":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"repo":{"id":136061479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNjE0Nzk=","name":"pytorch","full_name":"zrphercule/pytorch","private":false,"owner":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zrphercule/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/zrphercule/pytorch","forks_url":"https://api.github.com/repos/zrphercule/pytorch/forks","keys_url":"https://api.github.com/repos/zrphercule/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zrphercule/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zrphercule/pytorch/teams","hooks_url":"https://api.github.com/repos/zrphercule/pytorch/hooks","issue_events_url":"https://api.github.com/repos/zrphercule/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/zrphercule/pytorch/events","assignees_url":"https://api.github.com/repos/zrphercule/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/zrphercule/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/zrphercule/pytorch/tags","blobs_url":"https://api.github.com/repos/zrphercule/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zrphercule/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zrphercule/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/zrphercule/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zrphercule/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/zrphercule/pytorch/languages","stargazers_url":"https://api.github.com/repos/zrphercule/pytorch/stargazers","contributors_url":"https://api.github.com/repos/zrphercule/pytorch/contributors","subscribers_url":"https://api.github.com/repos/zrphercule/pytorch/subscribers","subscription_url":"https://api.github.com/repos/zrphercule/pytorch/subscription","commits_url":"https://api.github.com/repos/zrphercule/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/zrphercule/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/zrphercule/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/zrphercule/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/zrphercule/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/zrphercule/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zrphercule/pytorch/merges","archive_url":"https://api.github.com/repos/zrphercule/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zrphercule/pytorch/downloads","issues_url":"https://api.github.com/repos/zrphercule/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/zrphercule/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/zrphercule/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/zrphercule/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zrphercule/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/zrphercule/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/zrphercule/pytorch/deployments","created_at":"2018-06-04T17:40:26Z","updated_at":"2018-12-11T19:40:59Z","pushed_at":"2018-12-13T20:07:10Z","git_url":"git://github.com/zrphercule/pytorch.git","ssh_url":"git@github.com:zrphercule/pytorch.git","clone_url":"https://github.com/zrphercule/pytorch.git","svn_url":"https://github.com/zrphercule/pytorch","homepage":"http://pytorch.org","size":91600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"f61612206cee9e00011ba9945be771ddc1673092","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-12-13T22:20:18Z","pushed_at":"2018-12-13T22:18:56Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":95133,"stargazers_count":22648,"watchers_count":22648,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5369,"mirror_url":null,"archived":false,"open_issues_count":2297,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5369,"open_issues":2297,"watchers":22648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15179"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15179"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15179"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15179/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15179/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15179/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/e1266f33fa9e2316255da8ad5bbf7d6ac993a3b1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jamesr66a"}}