{"action":"closed","number":3690,"pull_request":{"url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690","id":173674726,"html_url":"https://github.com/react-navigation/react-navigation/pull/3690","diff_url":"https://github.com/react-navigation/react-navigation/pull/3690.diff","patch_url":"https://github.com/react-navigation/react-navigation/pull/3690.patch","issue_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/3690","number":3690,"state":"closed","locked":false,"title":"fix: Dimensions.addEventListener & removeEventListener in old version…","user":{"login":"Creemli","id":5566981,"avatar_url":"https://avatars2.githubusercontent.com/u/5566981?v=4","gravatar_id":"","url":"https://api.github.com/users/Creemli","html_url":"https://github.com/Creemli","followers_url":"https://api.github.com/users/Creemli/followers","following_url":"https://api.github.com/users/Creemli/following{/other_user}","gists_url":"https://api.github.com/users/Creemli/gists{/gist_id}","starred_url":"https://api.github.com/users/Creemli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Creemli/subscriptions","organizations_url":"https://api.github.com/users/Creemli/orgs","repos_url":"https://api.github.com/users/Creemli/repos","events_url":"https://api.github.com/users/Creemli/events{/privacy}","received_events_url":"https://api.github.com/users/Creemli/received_events","type":"User","site_admin":false},"body":"… of react-native\r\n\r\nPlease provide enough information so that others can review your pull request:\r\n\r\nExplain the motivation for making this change. What existing problem does the pull request solve?\r\n\r\nFix the error about Dismensions.addEventListener when use this package with react-native@0.42 and before. Since the peerDependencies defined in package.json are:\r\n\r\n \"peerDependencies\": {\r\n    \"react\": \"*\",\r\n    \"react-native\": \"*\"\r\n  }\r\nTest plan (required)\r\n\r\nDemonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.\r\n\r\nMake sure you test on both platforms if your change affects both platforms.\r\n\r\nThe code must pass tests.\r\n\r\nCode formatting\r\n\r\nLook around. Match the style of the rest of the codebase.","created_at":"2018-03-08T08:37:40Z","updated_at":"2018-03-09T19:37:59Z","closed_at":"2018-03-09T19:37:59Z","merged_at":null,"merge_commit_sha":"2629dfd891fdfd2f8d4963db9ddd3dc41cb144a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690/commits","review_comments_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690/comments","review_comment_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/3690/comments","statuses_url":"https://api.github.com/repos/react-navigation/react-navigation/statuses/567e8fa93932d41a00cd470e9bb1ab0c0aa3005b","head":{"label":"Creemli:master","ref":"master","sha":"567e8fa93932d41a00cd470e9bb1ab0c0aa3005b","user":{"login":"Creemli","id":5566981,"avatar_url":"https://avatars2.githubusercontent.com/u/5566981?v=4","gravatar_id":"","url":"https://api.github.com/users/Creemli","html_url":"https://github.com/Creemli","followers_url":"https://api.github.com/users/Creemli/followers","following_url":"https://api.github.com/users/Creemli/following{/other_user}","gists_url":"https://api.github.com/users/Creemli/gists{/gist_id}","starred_url":"https://api.github.com/users/Creemli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Creemli/subscriptions","organizations_url":"https://api.github.com/users/Creemli/orgs","repos_url":"https://api.github.com/users/Creemli/repos","events_url":"https://api.github.com/users/Creemli/events{/privacy}","received_events_url":"https://api.github.com/users/Creemli/received_events","type":"User","site_admin":false},"repo":{"id":124355664,"name":"react-navigation","full_name":"Creemli/react-navigation","owner":{"login":"Creemli","id":5566981,"avatar_url":"https://avatars2.githubusercontent.com/u/5566981?v=4","gravatar_id":"","url":"https://api.github.com/users/Creemli","html_url":"https://github.com/Creemli","followers_url":"https://api.github.com/users/Creemli/followers","following_url":"https://api.github.com/users/Creemli/following{/other_user}","gists_url":"https://api.github.com/users/Creemli/gists{/gist_id}","starred_url":"https://api.github.com/users/Creemli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Creemli/subscriptions","organizations_url":"https://api.github.com/users/Creemli/orgs","repos_url":"https://api.github.com/users/Creemli/repos","events_url":"https://api.github.com/users/Creemli/events{/privacy}","received_events_url":"https://api.github.com/users/Creemli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Creemli/react-navigation","description":"Routing and navigation for your React Native apps","fork":true,"url":"https://api.github.com/repos/Creemli/react-navigation","forks_url":"https://api.github.com/repos/Creemli/react-navigation/forks","keys_url":"https://api.github.com/repos/Creemli/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Creemli/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Creemli/react-navigation/teams","hooks_url":"https://api.github.com/repos/Creemli/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/Creemli/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/Creemli/react-navigation/events","assignees_url":"https://api.github.com/repos/Creemli/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/Creemli/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/Creemli/react-navigation/tags","blobs_url":"https://api.github.com/repos/Creemli/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Creemli/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Creemli/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Creemli/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Creemli/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/Creemli/react-navigation/languages","stargazers_url":"https://api.github.com/repos/Creemli/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/Creemli/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/Creemli/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/Creemli/react-navigation/subscription","commits_url":"https://api.github.com/repos/Creemli/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Creemli/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Creemli/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Creemli/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Creemli/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/Creemli/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Creemli/react-navigation/merges","archive_url":"https://api.github.com/repos/Creemli/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Creemli/react-navigation/downloads","issues_url":"https://api.github.com/repos/Creemli/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/Creemli/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/Creemli/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/Creemli/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Creemli/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/Creemli/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/Creemli/react-navigation/deployments","created_at":"2018-03-08T07:44:28Z","updated_at":"2018-03-08T07:44:30Z","pushed_at":"2018-03-08T08:36:36Z","git_url":"git://github.com/Creemli/react-navigation.git","ssh_url":"git@github.com:Creemli/react-navigation.git","clone_url":"https://github.com/Creemli/react-navigation.git","svn_url":"https://github.com/Creemli/react-navigation","homepage":"https://reactnavigation.org","size":10081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-navigation:master","ref":"master","sha":"bdda6fa5be2cbdef2a1f4f5b3a65fa4518003c27","user":{"login":"react-navigation","id":29647600,"avatar_url":"https://avatars2.githubusercontent.com/u/29647600?v=4","gravatar_id":"","url":"https://api.github.com/users/react-navigation","html_url":"https://github.com/react-navigation","followers_url":"https://api.github.com/users/react-navigation/followers","following_url":"https://api.github.com/users/react-navigation/following{/other_user}","gists_url":"https://api.github.com/users/react-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/react-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-navigation/subscriptions","organizations_url":"https://api.github.com/users/react-navigation/orgs","repos_url":"https://api.github.com/users/react-navigation/repos","events_url":"https://api.github.com/users/react-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/react-navigation/received_events","type":"Organization","site_admin":false},"repo":{"id":80149262,"name":"react-navigation","full_name":"react-navigation/react-navigation","owner":{"login":"react-navigation","id":29647600,"avatar_url":"https://avatars2.githubusercontent.com/u/29647600?v=4","gravatar_id":"","url":"https://api.github.com/users/react-navigation","html_url":"https://github.com/react-navigation","followers_url":"https://api.github.com/users/react-navigation/followers","following_url":"https://api.github.com/users/react-navigation/following{/other_user}","gists_url":"https://api.github.com/users/react-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/react-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-navigation/subscriptions","organizations_url":"https://api.github.com/users/react-navigation/orgs","repos_url":"https://api.github.com/users/react-navigation/repos","events_url":"https://api.github.com/users/react-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/react-navigation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-navigation/react-navigation","description":"Routing and navigation for your React Native apps","fork":false,"url":"https://api.github.com/repos/react-navigation/react-navigation","forks_url":"https://api.github.com/repos/react-navigation/react-navigation/forks","keys_url":"https://api.github.com/repos/react-navigation/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-navigation/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-navigation/react-navigation/teams","hooks_url":"https://api.github.com/repos/react-navigation/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/react-navigation/react-navigation/events","assignees_url":"https://api.github.com/repos/react-navigation/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/react-navigation/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/react-navigation/react-navigation/tags","blobs_url":"https://api.github.com/repos/react-navigation/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-navigation/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-navigation/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-navigation/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-navigation/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/react-navigation/react-navigation/languages","stargazers_url":"https://api.github.com/repos/react-navigation/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/react-navigation/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/react-navigation/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/react-navigation/react-navigation/subscription","commits_url":"https://api.github.com/repos/react-navigation/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-navigation/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-navigation/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-navigation/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/react-navigation/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-navigation/react-navigation/merges","archive_url":"https://api.github.com/repos/react-navigation/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-navigation/react-navigation/downloads","issues_url":"https://api.github.com/repos/react-navigation/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/react-navigation/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/react-navigation/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-navigation/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/react-navigation/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/react-navigation/react-navigation/deployments","created_at":"2017-01-26T19:51:40Z","updated_at":"2018-03-09T19:20:10Z","pushed_at":"2018-03-09T19:33:18Z","git_url":"git://github.com/react-navigation/react-navigation.git","ssh_url":"git@github.com:react-navigation/react-navigation.git","clone_url":"https://github.com/react-navigation/react-navigation.git","svn_url":"https://github.com/react-navigation/react-navigation","homepage":"https://reactnavigation.org","size":10082,"stargazers_count":10343,"watchers_count":10343,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2276,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":2276,"open_issues":129,"watchers":10343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690"},"html":{"href":"https://github.com/react-navigation/react-navigation/pull/3690"},"issue":{"href":"https://api.github.com/repos/react-navigation/react-navigation/issues/3690"},"comments":{"href":"https://api.github.com/repos/react-navigation/react-navigation/issues/3690/comments"},"review_comments":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690/comments"},"review_comment":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3690/commits"},"statuses":{"href":"https://api.github.com/repos/react-navigation/react-navigation/statuses/567e8fa93932d41a00cd470e9bb1ab0c0aa3005b"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"brentvatne"}}