{"push_id":2535017903,"size":57,"distinct_size":57,"ref":"refs/heads/master","head":"36f716db432ea1a8994bd20d8842e8ee29a6fc87","before":"3a760212cb306655780a2c3be6412890ba5cf89b","commits":[{"sha":"0c22c000efc1cd15f2a8ee61d837878916cd8f6f","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Add an entry in the docs about remapping CTRL-R in completion mode","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/0c22c000efc1cd15f2a8ee61d837878916cd8f6f"},{"sha":"d3381411a047a216a1df5d33e2d8551ef611b157","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2946 - micbou:docs-ctrl-r-remap, r=puremourning\n\n[READY] Add an entry in the docs about remapping CTRL-R in completion mode\n\nThe `<C-R>` key cannot be remapped in YCM's completion mode (`<C-X><C-U>`) due to a Vim limitation. Add an entry in the FAQ about this.\n\nCloses https://github.com/Valloric/YouCompleteMe/issues/2943.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2946)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/d3381411a047a216a1df5d33e2d8551ef611b157"},{"sha":"30866264482d8a113c8821730906832bff7279a8","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Fix index error when applying a chunk at the end of file\n\nWhen sending a request to the server, we add a newline to the buffer contents\nto match what gets saved to disk. If the server generates a chunk containing\nthat newline, this chunk goes past the Vim buffer contents since there is\nactually no new line, which raises an IndexError exception when applying the\nchunk. We fix the issue by recomputing the end position of where the chunk is\napplied and by removing all trailing characters in the chunk.","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/30866264482d8a113c8821730906832bff7279a8"},{"sha":"788c293aee78c6ab60cbc06bbc3339e7b2bff98f","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2951 - micbou:replace-chunk-out-of-range, r=puremourning\n\n[READY] Fix index error when applying a chunk at the end of file\n\nWhen sending a request to the server, [we add a newline to the buffer contents to match what gets saved to disk](https://github.com/Valloric/YouCompleteMe/blob/d3381411a047a216a1df5d33e2d8551ef611b157/python/ycm/vimsupport.py#L117). If the server generates a chunk containing that newline, this chunk goes past the Vim buffer contents since there is actually no new line, which raises an `IndexError` exception when applying the chunk. We fix the issue by recomputing the end position of where the chunk is applied and by removing all trailing characters in the chunk.\n\nSteps to reproduce the issue:\n - create a `Test.java` file with the following contents:\n```java\npackage Test;$\n$\n```\nwhere `$` represents an end of line;\n - issue the `:YcmCompleter Format` command.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2951)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/788c293aee78c6ab60cbc06bbc3339e7b2bff98f"},{"sha":"ca8211a64b7fdb4f6f66ce13af558f17b1d8d31b","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Fix column clamping when highlighting diagnostics on Python 3","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/ca8211a64b7fdb4f6f66ce13af558f17b1d8d31b"},{"sha":"37965fe311e91502038abf811977b33a360d1954","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2956 - micbou:fix-column-clamping-python3, r=puremourning\n\n[READY] Fix column clamping when highlighting diagnostics on Python 3\n\nWe need to convert the Vim buffer to bytes in the `LineAndColumnNumbersClamped` function to correctly compute the length of the line as a byte offset (and not a Unicode offset) on Python 3.\n\nBefore:\n\n![column-clamping-before](https://user-images.githubusercontent.com/10026824/37876087-01f38dde-3048-11e8-93aa-0ce284b09b55.png)\nAfter:\n\n![column-clamping-after](https://user-images.githubusercontent.com/10026824/37876089-056db49e-3048-11e8-9d84-540fe67e6689.png)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2956)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/37965fe311e91502038abf811977b33a360d1954"},{"sha":"9408ccec5d40094eb864dbb17047901250a1d04f","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Fix Refactoring Commands link in table of contents","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/9408ccec5d40094eb864dbb17047901250a1d04f"},{"sha":"dc341aab58a251a00bfdbb86fdf90178e82ba6c6","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2957 - micbou:refactoring-commands-readme, r=puremourning\n\n[READY] Fix Refactoring Commands link in table of contents\n\nI broke it in PR https://github.com/Valloric/YouCompleteMe/pull/2900.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2957)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/dc341aab58a251a00bfdbb86fdf90178e82ba6c6"},{"sha":"866693ef8045182e92168d5c657ca05c68e19f24","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Refactor CompleteDone logic\n\nMove CompleteDone logic to the CompletionRequest class.","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/866693ef8045182e92168d5c657ca05c68e19f24"},{"sha":"c1815a9b2d07282a5e6cab485e0a54c0896dd629","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2963 - micbou:refactor-completedone-logic, r=puremourning\n\n[READY] Refactor CompleteDone logic\n\nSince the `CompleteDone` code only depends on the completion request, it makes sense to move its logic to the `CompletionRequest` class. This is also going to help fixing the issue where a FixIt is applied twice when selecting a completion:\n\n![completedone-bug](https://user-images.githubusercontent.com/10026824/38029281-bc09d224-3295-11e8-9976-d4dd031f2cca.gif)\n\nFinally, this reduces the time it takes to run the tests because the ycmd server is not started anymore in the `postcomplete` tests.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2963)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/c1815a9b2d07282a5e6cab485e0a54c0896dd629"},{"sha":"6f9366d150a3dc1f5671ed93bbb7cddc580281e0","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Check if completion is allowed on character events","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/6f9366d150a3dc1f5671ed93bbb7cddc580281e0"},{"sha":"1bda165728082c07a627c218c4a7275f0eff7e9d","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Mention Universal Ctags in docs","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/1bda165728082c07a627c218c4a7275f0eff7e9d"},{"sha":"e8477c16b604303383d36793dfb7e8bbe22097bf","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2972 - micbou:universal-ctags, r=puremourning\n\n[READY] Mention Universal Ctags in docs\n\nCloses https://github.com/Valloric/YouCompleteMe/issues/2971.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2972)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/e8477c16b604303383d36793dfb7e8bbe22097bf"},{"sha":"3b115831a07f2bea861861b8924ad6ea027862a7","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Fix applying fixit twice after completion","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/3b115831a07f2bea861861b8924ad6ea027862a7"},{"sha":"05f7f1c6f04706513940a0e0fb52d041917dfac3","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Remove Java from the GoToImplementation command in docs","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/05f7f1c6f04706513940a0e0fb52d041917dfac3"},{"sha":"cacc8e0d92b2b950673522c211b6c4338aec1852","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Remove unnecessary lists and fix options link in docs","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/cacc8e0d92b2b950673522c211b6c4338aec1852"},{"sha":"de8c8f64414ff6c37dbce99b239645c011f6f1d8","author":{"name":"micbou","email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com"},"message":"Add GoToType command to documentation","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/de8c8f64414ff6c37dbce99b239645c011f6f1d8"},{"sha":"b63604c8e94aee29775902bdf4b992b6e4d3cdbb","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2980 - micbou:remove-goto-implementation-java-docs, r=puremourning\n\n[READY] Remove Java from the GoToImplementation command in docs\n\nThe Java completer does not provide a `GoToImplementation` command.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2980)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/b63604c8e94aee29775902bdf4b992b6e4d3cdbb"},{"sha":"820affe6d931e2a592cee38bbb07c35962dc0c23","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2981 - micbou:remove-unnecessary-lists-docs, r=puremourning\n\n[READY] Remove unnecessary lists and fix options link in docs\n\nTwo small improvements to the documentation.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2981)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/820affe6d931e2a592cee38bbb07c35962dc0c23"},{"sha":"45502e5108ce43b09aff75121d6fdf32c02b1c2d","author":{"name":"zzbot","email":"89656db7aad922be8784579ff21e62a668dc4737@markovic.io"},"message":"Auto merge of #2970 - micbou:duplicate-fixits, r=puremourning\n\n[READY] Fix applying fixit twice after completion\n\nFixes the issue mentioned in PR https://github.com/Valloric/YouCompleteMe/pull/2963 for Vim 8.0.1493 and later. I don't think it's worth the trouble to fix the issue for older versions.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2970)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/vinod-mv/vim_you_complete_me/commits/45502e5108ce43b09aff75121d6fdf32c02b1c2d"}]}
{"actor":{"display_login":"vinod-mv"}}