{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/178773590","pull_request_review_id":108886125,"id":178773590,"diff_hunk":"@@ -81,35 +81,59 @@ int mhz19_init(mhz19_t *dev, const mhz19_params_t *params)\n     return MHZ19_OK;\n }\n \n-int mhz19_get_ppm(mhz19_t *dev, int16_t *ppm)\n+/*","path":"drivers/mhz19/mhz19.c","position":null,"original_position":5,"commit_id":"785e866163777f2eb8235235f64dad10aa7908b6","original_commit_id":"785e866163777f2eb8235235f64dad10aa7908b6","user":{"login":"basilfx","id":815976,"avatar_url":"https://avatars3.githubusercontent.com/u/815976?v=4","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"body":"I think you need `/**`.","created_at":"2018-04-03T10:07:03Z","updated_at":"2018-04-03T10:07:42Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8648#discussion_r178773590","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/178773590"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8648#discussion_r178773590"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648","id":171629849,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8648","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8648.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8648.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8648","number":8648,"state":"open","locked":false,"title":"drivers: MH-Z19: initial support","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\n\r\nThe MH-Z19 is a relative cheap (15 euro) CO2 ppm sensor. This PR adds basic support for reading the CO2 measurement over the UART interface. Saul integration is provided with this PR.\r\n\r\nAs UART is asynchronous, I had to implement a bit of synchronisation and timeout support in the driver itself. This is the reason two mutexes are used and the reason the const keyword had to be dropped in the saul interface.\r\n\r\n### Issues/PRs references\r\n\r\nNone","created_at":"2018-02-27T11:06:12Z","updated_at":"2018-04-03T10:07:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a3a6c72510e8338bcb09fe590d7ec17301aa57d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":94299733,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/NEEDS%20SQUASHING","name":"NEEDS SQUASHING","color":"009800","default":false},{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":135467271,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false},{"id":97458574,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/new%20feature","name":"new feature","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8648/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/785e866163777f2eb8235235f64dad10aa7908b6","head":{"label":"bergzand:pr/mh-z19","ref":"pr/mh-z19","sha":"785e866163777f2eb8235235f64dad10aa7908b6","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"repo":{"id":73482253,"name":"RIOT","full_name":"bergzand/RIOT","owner":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bergzand/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/bergzand/RIOT","forks_url":"https://api.github.com/repos/bergzand/RIOT/forks","keys_url":"https://api.github.com/repos/bergzand/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bergzand/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bergzand/RIOT/teams","hooks_url":"https://api.github.com/repos/bergzand/RIOT/hooks","issue_events_url":"https://api.github.com/repos/bergzand/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/bergzand/RIOT/events","assignees_url":"https://api.github.com/repos/bergzand/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/bergzand/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/bergzand/RIOT/tags","blobs_url":"https://api.github.com/repos/bergzand/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bergzand/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bergzand/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/bergzand/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bergzand/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/bergzand/RIOT/languages","stargazers_url":"https://api.github.com/repos/bergzand/RIOT/stargazers","contributors_url":"https://api.github.com/repos/bergzand/RIOT/contributors","subscribers_url":"https://api.github.com/repos/bergzand/RIOT/subscribers","subscription_url":"https://api.github.com/repos/bergzand/RIOT/subscription","commits_url":"https://api.github.com/repos/bergzand/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/bergzand/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/bergzand/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/bergzand/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/bergzand/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/bergzand/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bergzand/RIOT/merges","archive_url":"https://api.github.com/repos/bergzand/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bergzand/RIOT/downloads","issues_url":"https://api.github.com/repos/bergzand/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/bergzand/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/bergzand/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/bergzand/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bergzand/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/bergzand/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/bergzand/RIOT/deployments","created_at":"2016-11-11T14:02:28Z","updated_at":"2018-03-17T18:22:43Z","pushed_at":"2018-03-28T15:55:47Z","git_url":"git://github.com/bergzand/RIOT.git","ssh_url":"git@github.com:bergzand/RIOT.git","clone_url":"https://github.com/bergzand/RIOT.git","svn_url":"https://github.com/bergzand/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":51034,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"ce807173ffab81cc2946a8de572eacb50c0e5e54","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-04-03T09:37:37Z","pushed_at":"2018-04-03T09:48:05Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":50424,"stargazers_count":1715,"watchers_count":1715,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1031,"mirror_url":null,"archived":false,"open_issues_count":727,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1031,"open_issues":727,"watchers":1715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8648"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8648"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8648/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8648/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/785e866163777f2eb8235235f64dad10aa7908b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"basilfx"}}