{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/177171659","pull_request_review_id":106998943,"id":177171659,"diff_hunk":"@@ -0,0 +1,35 @@\n+// Copyright (c) 2017 The Bitcoin Core developers\n+// Distributed under the MIT software license, see the accompanying\n+// file COPYING or http://www.opensource.org/licenses/mit-license.php.\n+\n+#ifndef WALLETINITINTERFACE_H\n+#define WALLETINITINTERFACE_H\n+\n+#include <string>\n+\n+class CScheduler;\n+class CRPCTable;\n+\n+class WalletInitInterface {","path":"src/walletinitinterface.h","position":13,"original_position":13,"commit_id":"b3e482c65c5c4697b38bba6006dbcdc3c1bba836","original_commit_id":"ff29f04040339d8994c7ca1265fbdece25ce6527","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"body":"Thanks! Done.","created_at":"2018-03-26T17:26:15Z","updated_at":"2018-03-26T17:26:15Z","html_url":"https://github.com/bitcoin/bitcoin/pull/10762#discussion_r177171659","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/177171659"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10762#discussion_r177171659"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762"}},"in_reply_to_id":176864483},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762","id":129371241,"html_url":"https://github.com/bitcoin/bitcoin/pull/10762","diff_url":"https://github.com/bitcoin/bitcoin/pull/10762.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10762.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10762","number":10762,"state":"open","locked":false,"title":"[wallet] Remove Wallet dependencies from init.cpp","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"body":"This continues the work of #7965. This PR, along with several others, would remove the remaining dependencies from libbitcoin_server.a on libbitcoin_wallet.a.\r\n\r\nTo create the interface, I've just translated all the old init.cpp wallet function calls into an interface class. I've not done any thinking about whether it makes sense to change that interface by combining/splitting those calls. This is a purely internal interface, so there's no problem in changing it later.","created_at":"2017-07-07T10:04:01Z","updated_at":"2018-03-26T17:26:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d74677a29e1efcd6e2070757fbf998e77401c3d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false},{"id":149424,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10762/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b3e482c65c5c4697b38bba6006dbcdc3c1bba836","head":{"label":"jnewbery:walletinit","ref":"walletinit","sha":"b3e482c65c5c4697b38bba6006dbcdc3c1bba836","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"repo":{"id":68248485,"name":"bitcoin","full_name":"jnewbery/bitcoin","owner":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnewbery/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jnewbery/bitcoin","forks_url":"https://api.github.com/repos/jnewbery/bitcoin/forks","keys_url":"https://api.github.com/repos/jnewbery/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnewbery/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnewbery/bitcoin/teams","hooks_url":"https://api.github.com/repos/jnewbery/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jnewbery/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jnewbery/bitcoin/events","assignees_url":"https://api.github.com/repos/jnewbery/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jnewbery/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jnewbery/bitcoin/tags","blobs_url":"https://api.github.com/repos/jnewbery/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnewbery/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnewbery/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnewbery/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnewbery/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jnewbery/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jnewbery/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jnewbery/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jnewbery/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jnewbery/bitcoin/subscription","commits_url":"https://api.github.com/repos/jnewbery/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnewbery/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnewbery/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnewbery/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnewbery/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jnewbery/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnewbery/bitcoin/merges","archive_url":"https://api.github.com/repos/jnewbery/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnewbery/bitcoin/downloads","issues_url":"https://api.github.com/repos/jnewbery/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jnewbery/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jnewbery/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jnewbery/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnewbery/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jnewbery/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jnewbery/bitcoin/deployments","created_at":"2016-09-14T22:29:05Z","updated_at":"2016-09-14T22:29:18Z","pushed_at":"2018-03-26T17:26:05Z","git_url":"git://github.com/jnewbery/bitcoin.git","ssh_url":"git@github.com:jnewbery/bitcoin.git","clone_url":"https://github.com/jnewbery/bitcoin.git","svn_url":"https://github.com/jnewbery/bitcoin","homepage":"https://bitcoin.org/en/download","size":108076,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c948dc8f4285e27d8c0f3553d9d427b2a7b01b77","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-03-26T16:11:26Z","pushed_at":"2018-03-26T17:26:08Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":103331,"stargazers_count":29819,"watchers_count":29819,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":17858,"mirror_url":null,"archived":false,"open_issues_count":815,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17858,"open_issues":815,"watchers":29819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10762"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10762"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10762/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10762/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b3e482c65c5c4697b38bba6006dbcdc3c1bba836"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jnewbery"}}