{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/comments/167728345","pull_request_review_id":95975805,"id":167728345,"diff_hunk":"@@ -127,6 +128,17 @@ class BrowserNavigationOverlay @JvmOverloads constructor(\n         navButtonForward.isFocusable = canGoForward\n \n         navUrlInput.setText(navigationProvider?.getCurrentUrl())\n+\n+        updateFocusOnNavigation()\n+    }\n+\n+    private fun updateFocusOnNavigation() {","path":"app/src/main/java/org/mozilla/focus/widget/BrowserNavigationOverlay.kt","position":132,"original_position":34,"commit_id":"6ed013fd531660da8f51d7a2342cd81995702807","original_commit_id":"4c125d9e6c318b5a432bfd82d1b8610bac40cb62","user":{"login":"mcomella","id":759372,"avatar_url":"https://avatars3.githubusercontent.com/u/759372?v=4","gravatar_id":"","url":"https://api.github.com/users/mcomella","html_url":"https://github.com/mcomella","followers_url":"https://api.github.com/users/mcomella/followers","following_url":"https://api.github.com/users/mcomella/following{/other_user}","gists_url":"https://api.github.com/users/mcomella/gists{/gist_id}","starred_url":"https://api.github.com/users/mcomella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcomella/subscriptions","organizations_url":"https://api.github.com/users/mcomella/orgs","repos_url":"https://api.github.com/users/mcomella/repos","events_url":"https://api.github.com/users/mcomella/events{/privacy}","received_events_url":"https://api.github.com/users/mcomella/received_events","type":"User","site_admin":false},"body":"I think requesting focus in the same method where we set focusability is confusing, e.g. if I'm writing new code and I want to update the focused state but not change focus, I'd probably call `updateNavigationButtons` without realizing it might request focus.\r\n\r\nFor example, one bug I think might exist in your patch is that `onPageStarted` will request focus every time, which may not be desirable, e.g. we have the overlay open, the page moves loads a new URL after some timeout, and then the focus changes inside the overlay.\r\n\r\nWe should request focus specifically when it's needed, which is only when the drawer is initially shown, if i'm not mistaken.","created_at":"2018-02-13T00:19:55Z","updated_at":"2018-02-13T00:51:29Z","html_url":"https://github.com/mozilla-mobile/firefox-tv/pull/479#discussion_r167728345","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/comments/167728345"},"html":{"href":"https://github.com/mozilla-mobile/firefox-tv/pull/479#discussion_r167728345"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479","id":168382700,"html_url":"https://github.com/mozilla-mobile/firefox-tv/pull/479","diff_url":"https://github.com/mozilla-mobile/firefox-tv/pull/479.diff","patch_url":"https://github.com/mozilla-mobile/firefox-tv/pull/479.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/479","number":479,"state":"open","locked":false,"title":"Nav overlay","user":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"body":"Adds the overlay, rips out the drawer.","created_at":"2018-02-10T03:05:11Z","updated_at":"2018-02-13T00:51:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5ca73c32dd1e4746f732a57cd68338d54f7140d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/479/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/statuses/6ed013fd531660da8f51d7a2342cd81995702807","head":{"label":"liuche:v2-nav-overlay","ref":"v2-nav-overlay","sha":"6ed013fd531660da8f51d7a2342cd81995702807","user":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"repo":{"id":114934108,"name":"firefox-tv","full_name":"liuche/firefox-tv","owner":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liuche/firefox-tv","description":"Firefox for Amazon's Fire TV","fork":true,"url":"https://api.github.com/repos/liuche/firefox-tv","forks_url":"https://api.github.com/repos/liuche/firefox-tv/forks","keys_url":"https://api.github.com/repos/liuche/firefox-tv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liuche/firefox-tv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liuche/firefox-tv/teams","hooks_url":"https://api.github.com/repos/liuche/firefox-tv/hooks","issue_events_url":"https://api.github.com/repos/liuche/firefox-tv/issues/events{/number}","events_url":"https://api.github.com/repos/liuche/firefox-tv/events","assignees_url":"https://api.github.com/repos/liuche/firefox-tv/assignees{/user}","branches_url":"https://api.github.com/repos/liuche/firefox-tv/branches{/branch}","tags_url":"https://api.github.com/repos/liuche/firefox-tv/tags","blobs_url":"https://api.github.com/repos/liuche/firefox-tv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liuche/firefox-tv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liuche/firefox-tv/git/refs{/sha}","trees_url":"https://api.github.com/repos/liuche/firefox-tv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liuche/firefox-tv/statuses/{sha}","languages_url":"https://api.github.com/repos/liuche/firefox-tv/languages","stargazers_url":"https://api.github.com/repos/liuche/firefox-tv/stargazers","contributors_url":"https://api.github.com/repos/liuche/firefox-tv/contributors","subscribers_url":"https://api.github.com/repos/liuche/firefox-tv/subscribers","subscription_url":"https://api.github.com/repos/liuche/firefox-tv/subscription","commits_url":"https://api.github.com/repos/liuche/firefox-tv/commits{/sha}","git_commits_url":"https://api.github.com/repos/liuche/firefox-tv/git/commits{/sha}","comments_url":"https://api.github.com/repos/liuche/firefox-tv/comments{/number}","issue_comment_url":"https://api.github.com/repos/liuche/firefox-tv/issues/comments{/number}","contents_url":"https://api.github.com/repos/liuche/firefox-tv/contents/{+path}","compare_url":"https://api.github.com/repos/liuche/firefox-tv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liuche/firefox-tv/merges","archive_url":"https://api.github.com/repos/liuche/firefox-tv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liuche/firefox-tv/downloads","issues_url":"https://api.github.com/repos/liuche/firefox-tv/issues{/number}","pulls_url":"https://api.github.com/repos/liuche/firefox-tv/pulls{/number}","milestones_url":"https://api.github.com/repos/liuche/firefox-tv/milestones{/number}","notifications_url":"https://api.github.com/repos/liuche/firefox-tv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liuche/firefox-tv/labels{/name}","releases_url":"https://api.github.com/repos/liuche/firefox-tv/releases{/id}","deployments_url":"https://api.github.com/repos/liuche/firefox-tv/deployments","created_at":"2017-12-20T21:46:59Z","updated_at":"2017-12-20T21:47:03Z","pushed_at":"2018-02-13T00:43:36Z","git_url":"git://github.com/liuche/firefox-tv.git","ssh_url":"git@github.com:liuche/firefox-tv.git","clone_url":"https://github.com/liuche/firefox-tv.git","svn_url":"https://github.com/liuche/firefox-tv","homepage":"https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/","size":96135,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"faa7cca303720f8ef5363a4a3316849c233a1707","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":114038082,"name":"firefox-tv","full_name":"mozilla-mobile/firefox-tv","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-tv","description":"Firefox for Amazon's Fire TV","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-tv","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-tv/deployments","created_at":"2017-12-12T20:53:46Z","updated_at":"2018-02-08T00:23:44Z","pushed_at":"2018-02-13T00:43:37Z","git_url":"git://github.com/mozilla-mobile/firefox-tv.git","ssh_url":"git@github.com:mozilla-mobile/firefox-tv.git","clone_url":"https://github.com/mozilla-mobile/firefox-tv.git","svn_url":"https://github.com/mozilla-mobile/firefox-tv","homepage":"https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/","size":95755,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":8,"open_issues":124,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479"},"html":{"href":"https://github.com/mozilla-mobile/firefox-tv/pull/479"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/479"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-tv/statuses/6ed013fd531660da8f51d7a2342cd81995702807"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcomella"}}