{"action":"created","comment":{"url":"https://api.github.com/repos/brave/sync/pulls/comments/244393964","pull_request_review_id":188358146,"id":244393964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM5Mzk2NA==","diff_hunk":"@@ -28,14 +28,14 @@ npm run start\n ## Testing\n \n The sync client uses Browserify to transform Node js into browser js. To unittest\n-the library in a browser (default: electron), run `npm browsertest`.\n-To test in a different browser run `npm browsertest -- --browser chrome`.\n+the library in a browser (default: electron), run `npm run browsertest`.\n+To test in a different browser run `npm run browsertest -- --browser chrome`.\n Results appear in both the browser inspector and your terminal.\n \n To run tests in Node, just do `npm test`.\n \n To do a basic client/server integration test against the production server, run\n-`npm run client` and navigate to `http://localhost:8000/`). The page\n+`npm run client` and navigate to `http://localhost:4000/`). The page","path":"README.md","position":14,"original_position":14,"commit_id":"07105690a188b476f831b393a94768e5a438ee05","original_commit_id":"07105690a188b476f831b393a94768e5a438ee05","user":{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"body":"This shouldn't change since `run client` runs `python -m SimpleHTTPServer` which runs on 8000 by default. ","created_at":"2018-12-28T19:45:01Z","updated_at":"2018-12-28T19:45:02Z","html_url":"https://github.com/brave/sync/pull/268#discussion_r244393964","pull_request_url":"https://api.github.com/repos/brave/sync/pulls/268","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/sync/pulls/comments/244393964"},"html":{"href":"https://github.com/brave/sync/pull/268#discussion_r244393964"},"pull_request":{"href":"https://api.github.com/repos/brave/sync/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/brave/sync/pulls/268","id":241236342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjM2MzQy","html_url":"https://github.com/brave/sync/pull/268","diff_url":"https://github.com/brave/sync/pull/268.diff","patch_url":"https://github.com/brave/sync/pull/268.patch","issue_url":"https://api.github.com/repos/brave/sync/issues/268","number":268,"state":"open","locked":false,"title":"README fixes","user":{"login":"samartnik","id":30602739,"node_id":"MDQ6VXNlcjMwNjAyNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/30602739?v=4","gravatar_id":"","url":"https://api.github.com/users/samartnik","html_url":"https://github.com/samartnik","followers_url":"https://api.github.com/users/samartnik/followers","following_url":"https://api.github.com/users/samartnik/following{/other_user}","gists_url":"https://api.github.com/users/samartnik/gists{/gist_id}","starred_url":"https://api.github.com/users/samartnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samartnik/subscriptions","organizations_url":"https://api.github.com/users/samartnik/orgs","repos_url":"https://api.github.com/users/samartnik/repos","events_url":"https://api.github.com/users/samartnik/events{/privacy}","received_events_url":"https://api.github.com/users/samartnik/received_events","type":"User","site_admin":false},"body":"These are just suggestions. From my experience I was't able to run command `npm browsertest` and get any info from `localhost:8000`","created_at":"2018-12-27T22:58:54Z","updated_at":"2018-12-28T19:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f6aa64710d5882d3b654c30fc5433e86570d17","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SergeyZhukovsky","id":12011303,"node_id":"MDQ6VXNlcjEyMDExMzAz","avatar_url":"https://avatars2.githubusercontent.com/u/12011303?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyZhukovsky","html_url":"https://github.com/SergeyZhukovsky","followers_url":"https://api.github.com/users/SergeyZhukovsky/followers","following_url":"https://api.github.com/users/SergeyZhukovsky/following{/other_user}","gists_url":"https://api.github.com/users/SergeyZhukovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyZhukovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyZhukovsky/subscriptions","organizations_url":"https://api.github.com/users/SergeyZhukovsky/orgs","repos_url":"https://api.github.com/users/SergeyZhukovsky/repos","events_url":"https://api.github.com/users/SergeyZhukovsky/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyZhukovsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/sync/pulls/268/commits","review_comments_url":"https://api.github.com/repos/brave/sync/pulls/268/comments","review_comment_url":"https://api.github.com/repos/brave/sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/sync/issues/268/comments","statuses_url":"https://api.github.com/repos/brave/sync/statuses/07105690a188b476f831b393a94768e5a438ee05","head":{"label":"samartnik:readme_fix","ref":"readme_fix","sha":"07105690a188b476f831b393a94768e5a438ee05","user":{"login":"samartnik","id":30602739,"node_id":"MDQ6VXNlcjMwNjAyNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/30602739?v=4","gravatar_id":"","url":"https://api.github.com/users/samartnik","html_url":"https://github.com/samartnik","followers_url":"https://api.github.com/users/samartnik/followers","following_url":"https://api.github.com/users/samartnik/following{/other_user}","gists_url":"https://api.github.com/users/samartnik/gists{/gist_id}","starred_url":"https://api.github.com/users/samartnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samartnik/subscriptions","organizations_url":"https://api.github.com/users/samartnik/orgs","repos_url":"https://api.github.com/users/samartnik/repos","events_url":"https://api.github.com/users/samartnik/events{/privacy}","received_events_url":"https://api.github.com/users/samartnik/received_events","type":"User","site_admin":false},"repo":{"id":129260637,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyNjA2Mzc=","name":"sync","full_name":"samartnik/sync","private":false,"owner":{"login":"samartnik","id":30602739,"node_id":"MDQ6VXNlcjMwNjAyNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/30602739?v=4","gravatar_id":"","url":"https://api.github.com/users/samartnik","html_url":"https://github.com/samartnik","followers_url":"https://api.github.com/users/samartnik/followers","following_url":"https://api.github.com/users/samartnik/following{/other_user}","gists_url":"https://api.github.com/users/samartnik/gists{/gist_id}","starred_url":"https://api.github.com/users/samartnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samartnik/subscriptions","organizations_url":"https://api.github.com/users/samartnik/orgs","repos_url":"https://api.github.com/users/samartnik/repos","events_url":"https://api.github.com/users/samartnik/events{/privacy}","received_events_url":"https://api.github.com/users/samartnik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samartnik/sync","description":"cross platform, client encrypted, cloud data sync 🔼✨🔮✨🔼","fork":true,"url":"https://api.github.com/repos/samartnik/sync","forks_url":"https://api.github.com/repos/samartnik/sync/forks","keys_url":"https://api.github.com/repos/samartnik/sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samartnik/sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samartnik/sync/teams","hooks_url":"https://api.github.com/repos/samartnik/sync/hooks","issue_events_url":"https://api.github.com/repos/samartnik/sync/issues/events{/number}","events_url":"https://api.github.com/repos/samartnik/sync/events","assignees_url":"https://api.github.com/repos/samartnik/sync/assignees{/user}","branches_url":"https://api.github.com/repos/samartnik/sync/branches{/branch}","tags_url":"https://api.github.com/repos/samartnik/sync/tags","blobs_url":"https://api.github.com/repos/samartnik/sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samartnik/sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samartnik/sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/samartnik/sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samartnik/sync/statuses/{sha}","languages_url":"https://api.github.com/repos/samartnik/sync/languages","stargazers_url":"https://api.github.com/repos/samartnik/sync/stargazers","contributors_url":"https://api.github.com/repos/samartnik/sync/contributors","subscribers_url":"https://api.github.com/repos/samartnik/sync/subscribers","subscription_url":"https://api.github.com/repos/samartnik/sync/subscription","commits_url":"https://api.github.com/repos/samartnik/sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/samartnik/sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/samartnik/sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/samartnik/sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/samartnik/sync/contents/{+path}","compare_url":"https://api.github.com/repos/samartnik/sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samartnik/sync/merges","archive_url":"https://api.github.com/repos/samartnik/sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samartnik/sync/downloads","issues_url":"https://api.github.com/repos/samartnik/sync/issues{/number}","pulls_url":"https://api.github.com/repos/samartnik/sync/pulls{/number}","milestones_url":"https://api.github.com/repos/samartnik/sync/milestones{/number}","notifications_url":"https://api.github.com/repos/samartnik/sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samartnik/sync/labels{/name}","releases_url":"https://api.github.com/repos/samartnik/sync/releases{/id}","deployments_url":"https://api.github.com/repos/samartnik/sync/deployments","created_at":"2018-04-12T14:04:03Z","updated_at":"2018-04-12T14:04:05Z","pushed_at":"2018-12-27T22:56:24Z","git_url":"git://github.com/samartnik/sync.git","ssh_url":"git@github.com:samartnik/sync.git","clone_url":"https://github.com/samartnik/sync.git","svn_url":"https://github.com/samartnik/sync","homepage":"","size":1705,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"brave:staging","ref":"staging","sha":"b01cea43306f8d1c319c4f7a03bbc8f4ef867db7","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":74005806,"node_id":"MDEwOlJlcG9zaXRvcnk3NDAwNTgwNg==","name":"sync","full_name":"brave/sync","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/sync","description":"cross platform, client encrypted, cloud data sync 🔼✨🔮✨🔼","fork":false,"url":"https://api.github.com/repos/brave/sync","forks_url":"https://api.github.com/repos/brave/sync/forks","keys_url":"https://api.github.com/repos/brave/sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/sync/teams","hooks_url":"https://api.github.com/repos/brave/sync/hooks","issue_events_url":"https://api.github.com/repos/brave/sync/issues/events{/number}","events_url":"https://api.github.com/repos/brave/sync/events","assignees_url":"https://api.github.com/repos/brave/sync/assignees{/user}","branches_url":"https://api.github.com/repos/brave/sync/branches{/branch}","tags_url":"https://api.github.com/repos/brave/sync/tags","blobs_url":"https://api.github.com/repos/brave/sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/sync/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/sync/languages","stargazers_url":"https://api.github.com/repos/brave/sync/stargazers","contributors_url":"https://api.github.com/repos/brave/sync/contributors","subscribers_url":"https://api.github.com/repos/brave/sync/subscribers","subscription_url":"https://api.github.com/repos/brave/sync/subscription","commits_url":"https://api.github.com/repos/brave/sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/sync/contents/{+path}","compare_url":"https://api.github.com/repos/brave/sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/sync/merges","archive_url":"https://api.github.com/repos/brave/sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/sync/downloads","issues_url":"https://api.github.com/repos/brave/sync/issues{/number}","pulls_url":"https://api.github.com/repos/brave/sync/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/sync/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/sync/labels{/name}","releases_url":"https://api.github.com/repos/brave/sync/releases{/id}","deployments_url":"https://api.github.com/repos/brave/sync/deployments","created_at":"2016-11-17T08:24:52Z","updated_at":"2018-12-25T16:03:20Z","pushed_at":"2018-12-27T22:58:55Z","git_url":"git://github.com/brave/sync.git","ssh_url":"git@github.com:brave/sync.git","clone_url":"https://github.com/brave/sync.git","svn_url":"https://github.com/brave/sync","homepage":"","size":1777,"stargazers_count":122,"watchers_count":122,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":28,"open_issues":66,"watchers":122,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/sync/pulls/268"},"html":{"href":"https://github.com/brave/sync/pull/268"},"issue":{"href":"https://api.github.com/repos/brave/sync/issues/268"},"comments":{"href":"https://api.github.com/repos/brave/sync/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/sync/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/sync/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/brave/sync/statuses/07105690a188b476f831b393a94768e5a438ee05"}},"author_association":"NONE"}}
{"actor":{"display_login":"diracdeltas"}}