{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71209","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71209/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71209/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71209/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71209","id":382213081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTcxNjUy","number":71209,"title":"Add an impersonation test case to the audit E2E test","user":{"login":"dczombera","id":2528506,"node_id":"MDQ6VXNlcjI1Mjg1MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2528506?v=4","gravatar_id":"","url":"https://api.github.com/users/dczombera","html_url":"https://github.com/dczombera","followers_url":"https://api.github.com/users/dczombera/followers","following_url":"https://api.github.com/users/dczombera/following{/other_user}","gists_url":"https://api.github.com/users/dczombera/gists{/gist_id}","starred_url":"https://api.github.com/users/dczombera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dczombera/subscriptions","organizations_url":"https://api.github.com/users/dczombera/orgs","repos_url":"https://api.github.com/users/dczombera/repos","events_url":"https://api.github.com/users/dczombera/events{/privacy}","received_events_url":"https://api.github.com/users/dczombera/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":496752468,"node_id":"MDU6TGFiZWw0OTY3NTI0Njg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/failing-test","name":"kind/failing-test","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":1086787260,"node_id":"MDU6TGFiZWwxMDg2Nzg3MjYw","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":357119284,"node_id":"MDU6TGFiZWwzNTcxMTkyODQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/auth","name":"sig/auth","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"tallclair","id":29742491,"node_id":"MDQ6VXNlcjI5NzQyNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false},"assignees":[{"login":"tallclair","id":29742491,"node_id":"MDQ6VXNlcjI5NzQyNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-11-19T13:24:14Z","updated_at":"2018-11-29T18:50:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71209","html_url":"https://github.com/kubernetes/kubernetes/pull/71209","diff_url":"https://github.com/kubernetes/kubernetes/pull/71209.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71209.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind failing-test\r\n\r\n\r\n**What this PR does / why we need it**:\r\nAdd impersonation test to the audit E2E test \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #70198 \r\n\r\n**Special notes for your reviewer**:\r\nI have added just one test for the impersonation where I list the pods and check the for the `ImpersonatedUser` field. I wasn't sure if this is enough or if I should add more. \r\nAlso, when parsing the `ImpersonatedUser` struct in `parseAuditLine` I followed the way how it was done with the `User` struct (i.e. only extracting the user name, not the group)\r\n\r\n**Does this PR introduce a user-facing change?**: \r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n/sig auth\r\n\r\ncc  @tallclair "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/442948916","html_url":"https://github.com/kubernetes/kubernetes/pull/71209#issuecomment-442948916","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71209","id":442948916,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjk0ODkxNg==","user":{"login":"tallclair","id":29742491,"node_id":"MDQ6VXNlcjI5NzQyNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T18:50:04Z","updated_at":"2018-11-29T18:50:04Z","author_association":"MEMBER","body":"The test failures just look like flakes. Probably unrelated."}}
{"actor":{"display_login":"tallclair"}}