{"action":"created","comment":{"url":"https://api.github.com/repos/igas/faker/pulls/comments/228942034","pull_request_review_id":169321571,"id":228942034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk0MjAzNA==","diff_hunk":"@@ -273,5 +273,22 @@ defmodule Faker.Util do\n     end\n   end\n \n+  @doc \"\"\"\n+  Removes both single and double quotes from the given string.\n+\n+  ## Examples\n+\n+      iex> Faker.Util.remove_special_characters(\"f'oo\")\n+      \"foo\"\n+      iex> Faker.Util.remove_special_characters(~s(f\"o'o))\n+      \"foo\"\n+  \"\"\"\n+  @spec remove_special_characters(binary) :: binary\n+  def remove_special_characters(string) do","path":"lib/faker/util.ex","position":24,"original_position":24,"commit_id":"95b3bed768e7d6a855d629436537e6c9cb7b6a08","original_commit_id":"95b3bed768e7d6a855d629436537e6c9cb7b6a08","user":{"login":"jc00ke","id":18191,"node_id":"MDQ6VXNlcjE4MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/18191?v=4","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"body":"I wasn't able to test it in isolation because it was a private function, which is why I pulled it out. Would you be open to renaming it to `remove_quote_characters` or something like that?","created_at":"2018-10-29T14:15:12Z","updated_at":"2018-10-29T14:15:13Z","html_url":"https://github.com/igas/faker/pull/212#discussion_r228942034","pull_request_url":"https://api.github.com/repos/igas/faker/pulls/212","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/igas/faker/pulls/comments/228942034"},"html":{"href":"https://github.com/igas/faker/pull/212#discussion_r228942034"},"pull_request":{"href":"https://api.github.com/repos/igas/faker/pulls/212"}},"in_reply_to_id":228806186},"pull_request":{"url":"https://api.github.com/repos/igas/faker/pulls/212","id":226213952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjEzOTUy","html_url":"https://github.com/igas/faker/pull/212","diff_url":"https://github.com/igas/faker/pull/212.diff","patch_url":"https://github.com/igas/faker/pull/212.patch","issue_url":"https://api.github.com/repos/igas/faker/issues/212","number":212,"state":"open","locked":false,"title":"Changed: fixed removal of `'` from Internet","user":{"login":"jc00ke","id":18191,"node_id":"MDQ6VXNlcjE4MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/18191?v=4","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"body":"Moved the implementation to `Faker.Util`.\r\n\r\nFixes #211\r\n\r\nI've added:\r\n\r\n- [x] CHANGELOG.md\r\n","created_at":"2018-10-26T20:15:54Z","updated_at":"2018-10-29T14:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8e1bc40191d7f32e17a3249d77e9370843e3904","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/igas/faker/pulls/212/commits","review_comments_url":"https://api.github.com/repos/igas/faker/pulls/212/comments","review_comment_url":"https://api.github.com/repos/igas/faker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igas/faker/issues/212/comments","statuses_url":"https://api.github.com/repos/igas/faker/statuses/95b3bed768e7d6a855d629436537e6c9cb7b6a08","head":{"label":"jc00ke:remove-single-quote-in-internet-names","ref":"remove-single-quote-in-internet-names","sha":"95b3bed768e7d6a855d629436537e6c9cb7b6a08","user":{"login":"jc00ke","id":18191,"node_id":"MDQ6VXNlcjE4MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/18191?v=4","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"repo":{"id":154887047,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4ODcwNDc=","name":"faker","full_name":"jc00ke/faker","private":false,"owner":{"login":"jc00ke","id":18191,"node_id":"MDQ6VXNlcjE4MTkx","avatar_url":"https://avatars0.githubusercontent.com/u/18191?v=4","gravatar_id":"","url":"https://api.github.com/users/jc00ke","html_url":"https://github.com/jc00ke","followers_url":"https://api.github.com/users/jc00ke/followers","following_url":"https://api.github.com/users/jc00ke/following{/other_user}","gists_url":"https://api.github.com/users/jc00ke/gists{/gist_id}","starred_url":"https://api.github.com/users/jc00ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc00ke/subscriptions","organizations_url":"https://api.github.com/users/jc00ke/orgs","repos_url":"https://api.github.com/users/jc00ke/repos","events_url":"https://api.github.com/users/jc00ke/events{/privacy}","received_events_url":"https://api.github.com/users/jc00ke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jc00ke/faker","description":"Faker is a pure Elixir library for generating fake data.","fork":true,"url":"https://api.github.com/repos/jc00ke/faker","forks_url":"https://api.github.com/repos/jc00ke/faker/forks","keys_url":"https://api.github.com/repos/jc00ke/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jc00ke/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jc00ke/faker/teams","hooks_url":"https://api.github.com/repos/jc00ke/faker/hooks","issue_events_url":"https://api.github.com/repos/jc00ke/faker/issues/events{/number}","events_url":"https://api.github.com/repos/jc00ke/faker/events","assignees_url":"https://api.github.com/repos/jc00ke/faker/assignees{/user}","branches_url":"https://api.github.com/repos/jc00ke/faker/branches{/branch}","tags_url":"https://api.github.com/repos/jc00ke/faker/tags","blobs_url":"https://api.github.com/repos/jc00ke/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jc00ke/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jc00ke/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jc00ke/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jc00ke/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/jc00ke/faker/languages","stargazers_url":"https://api.github.com/repos/jc00ke/faker/stargazers","contributors_url":"https://api.github.com/repos/jc00ke/faker/contributors","subscribers_url":"https://api.github.com/repos/jc00ke/faker/subscribers","subscription_url":"https://api.github.com/repos/jc00ke/faker/subscription","commits_url":"https://api.github.com/repos/jc00ke/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jc00ke/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jc00ke/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jc00ke/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jc00ke/faker/contents/{+path}","compare_url":"https://api.github.com/repos/jc00ke/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jc00ke/faker/merges","archive_url":"https://api.github.com/repos/jc00ke/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jc00ke/faker/downloads","issues_url":"https://api.github.com/repos/jc00ke/faker/issues{/number}","pulls_url":"https://api.github.com/repos/jc00ke/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/jc00ke/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/jc00ke/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jc00ke/faker/labels{/name}","releases_url":"https://api.github.com/repos/jc00ke/faker/releases{/id}","deployments_url":"https://api.github.com/repos/jc00ke/faker/deployments","created_at":"2018-10-26T19:53:36Z","updated_at":"2018-10-26T19:53:38Z","pushed_at":"2018-10-26T20:15:25Z","git_url":"git://github.com/jc00ke/faker.git","ssh_url":"git@github.com:jc00ke/faker.git","clone_url":"https://github.com/jc00ke/faker.git","svn_url":"https://github.com/jc00ke/faker","homepage":"","size":558,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"igas:master","ref":"master","sha":"b964ad1aceeff867e0011b994bc97c89e36183bd","user":{"login":"igas","id":175652,"node_id":"MDQ6VXNlcjE3NTY1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/175652?v=4","gravatar_id":"","url":"https://api.github.com/users/igas","html_url":"https://github.com/igas","followers_url":"https://api.github.com/users/igas/followers","following_url":"https://api.github.com/users/igas/following{/other_user}","gists_url":"https://api.github.com/users/igas/gists{/gist_id}","starred_url":"https://api.github.com/users/igas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igas/subscriptions","organizations_url":"https://api.github.com/users/igas/orgs","repos_url":"https://api.github.com/users/igas/repos","events_url":"https://api.github.com/users/igas/events{/privacy}","received_events_url":"https://api.github.com/users/igas/received_events","type":"User","site_admin":false},"repo":{"id":18573162,"node_id":"MDEwOlJlcG9zaXRvcnkxODU3MzE2Mg==","name":"faker","full_name":"igas/faker","private":false,"owner":{"login":"igas","id":175652,"node_id":"MDQ6VXNlcjE3NTY1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/175652?v=4","gravatar_id":"","url":"https://api.github.com/users/igas","html_url":"https://github.com/igas","followers_url":"https://api.github.com/users/igas/followers","following_url":"https://api.github.com/users/igas/following{/other_user}","gists_url":"https://api.github.com/users/igas/gists{/gist_id}","starred_url":"https://api.github.com/users/igas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igas/subscriptions","organizations_url":"https://api.github.com/users/igas/orgs","repos_url":"https://api.github.com/users/igas/repos","events_url":"https://api.github.com/users/igas/events{/privacy}","received_events_url":"https://api.github.com/users/igas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/igas/faker","description":"Faker is a pure Elixir library for generating fake data.","fork":false,"url":"https://api.github.com/repos/igas/faker","forks_url":"https://api.github.com/repos/igas/faker/forks","keys_url":"https://api.github.com/repos/igas/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igas/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igas/faker/teams","hooks_url":"https://api.github.com/repos/igas/faker/hooks","issue_events_url":"https://api.github.com/repos/igas/faker/issues/events{/number}","events_url":"https://api.github.com/repos/igas/faker/events","assignees_url":"https://api.github.com/repos/igas/faker/assignees{/user}","branches_url":"https://api.github.com/repos/igas/faker/branches{/branch}","tags_url":"https://api.github.com/repos/igas/faker/tags","blobs_url":"https://api.github.com/repos/igas/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igas/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igas/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/igas/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igas/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/igas/faker/languages","stargazers_url":"https://api.github.com/repos/igas/faker/stargazers","contributors_url":"https://api.github.com/repos/igas/faker/contributors","subscribers_url":"https://api.github.com/repos/igas/faker/subscribers","subscription_url":"https://api.github.com/repos/igas/faker/subscription","commits_url":"https://api.github.com/repos/igas/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/igas/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/igas/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/igas/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/igas/faker/contents/{+path}","compare_url":"https://api.github.com/repos/igas/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igas/faker/merges","archive_url":"https://api.github.com/repos/igas/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igas/faker/downloads","issues_url":"https://api.github.com/repos/igas/faker/issues{/number}","pulls_url":"https://api.github.com/repos/igas/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/igas/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/igas/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igas/faker/labels{/name}","releases_url":"https://api.github.com/repos/igas/faker/releases{/id}","deployments_url":"https://api.github.com/repos/igas/faker/deployments","created_at":"2014-04-08T20:05:26Z","updated_at":"2018-10-29T06:00:40Z","pushed_at":"2018-10-29T06:01:25Z","git_url":"git://github.com/igas/faker.git","ssh_url":"git@github.com:igas/faker.git","clone_url":"https://github.com/igas/faker.git","svn_url":"https://github.com/igas/faker","homepage":"","size":560,"stargazers_count":430,"watchers_count":430,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":90,"open_issues":9,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igas/faker/pulls/212"},"html":{"href":"https://github.com/igas/faker/pull/212"},"issue":{"href":"https://api.github.com/repos/igas/faker/issues/212"},"comments":{"href":"https://api.github.com/repos/igas/faker/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/igas/faker/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/igas/faker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igas/faker/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/igas/faker/statuses/95b3bed768e7d6a855d629436537e6c9cb7b6a08"}},"author_association":"NONE"}}
{"actor":{"display_login":"jc00ke"}}