{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/244909493","pull_request_review_id":188896938,"id":244909493,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDkwOTQ5Mw==","diff_hunk":"@@ -192,7 +192,10 @@ void addInputs(Node* n, const char* name, const ArrayRef<double>& value) {\n }\n \n void addOutput(Node* node, const at::Tensor& output) {\n-  Value* value = node->addOutput();\n+  setOutput(node->addOutput(), output);","path":"torch/csrc/jit/tracer.cpp","position":5,"original_position":5,"commit_id":"a989e8f812b967f31e5032c4331b34bbaa7af052","original_commit_id":"a989e8f812b967f31e5032c4331b34bbaa7af052","user":{"login":"suo","id":1617424,"node_id":"MDQ6VXNlcjE2MTc0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1617424?v=4","gravatar_id":"","url":"https://api.github.com/users/suo","html_url":"https://github.com/suo","followers_url":"https://api.github.com/users/suo/followers","following_url":"https://api.github.com/users/suo/following{/other_user}","gists_url":"https://api.github.com/users/suo/gists{/gist_id}","starred_url":"https://api.github.com/users/suo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suo/subscriptions","organizations_url":"https://api.github.com/users/suo/orgs","repos_url":"https://api.github.com/users/suo/repos","events_url":"https://api.github.com/users/suo/events{/privacy}","received_events_url":"https://api.github.com/users/suo/received_events","type":"User","site_admin":false},"body":"why even have `addOutput` then?","created_at":"2019-01-03T04:04:14Z","updated_at":"2019-01-03T04:04:30Z","html_url":"https://github.com/pytorch/pytorch/pull/15690#discussion_r244909493","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15690","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/244909493"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15690#discussion_r244909493"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15690"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/15690","id":241901209,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTAxMjA5","html_url":"https://github.com/pytorch/pytorch/pull/15690","diff_url":"https://github.com/pytorch/pytorch/pull/15690.diff","patch_url":"https://github.com/pytorch/pytorch/pull/15690.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/15690","number":15690,"state":"open","locked":false,"title":"[jit] trace s_copy_","user":{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},"body":"s_copy_ was previously special-cased for out of place tracing.\r\nThis adds support for inplace tracing, which fixes tracing of\r\ninception_v3\r\n\r\nFixes #15216","created_at":"2019-01-03T04:02:12Z","updated_at":"2019-01-03T04:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97136e675b69699126612ea25c9ba3d6b19d765a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":679953983,"node_id":"MDU6TGFiZWw2Nzk5NTM5ODM=","url":"https://api.github.com/repos/pytorch/pytorch/labels/jit","name":"jit","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15690/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/15690/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/15690/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/a989e8f812b967f31e5032c4331b34bbaa7af052","head":{"label":"zdevito:pr/inception","ref":"pr/inception","sha":"a989e8f812b967f31e5032c4331b34bbaa7af052","user":{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},"repo":{"id":93195556,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE5NTU1Ng==","name":"pytorch","full_name":"zdevito/pytorch","private":false,"owner":{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zdevito/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/zdevito/pytorch","forks_url":"https://api.github.com/repos/zdevito/pytorch/forks","keys_url":"https://api.github.com/repos/zdevito/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zdevito/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zdevito/pytorch/teams","hooks_url":"https://api.github.com/repos/zdevito/pytorch/hooks","issue_events_url":"https://api.github.com/repos/zdevito/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/zdevito/pytorch/events","assignees_url":"https://api.github.com/repos/zdevito/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/zdevito/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/zdevito/pytorch/tags","blobs_url":"https://api.github.com/repos/zdevito/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zdevito/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zdevito/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/zdevito/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zdevito/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/zdevito/pytorch/languages","stargazers_url":"https://api.github.com/repos/zdevito/pytorch/stargazers","contributors_url":"https://api.github.com/repos/zdevito/pytorch/contributors","subscribers_url":"https://api.github.com/repos/zdevito/pytorch/subscribers","subscription_url":"https://api.github.com/repos/zdevito/pytorch/subscription","commits_url":"https://api.github.com/repos/zdevito/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/zdevito/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/zdevito/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/zdevito/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/zdevito/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/zdevito/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zdevito/pytorch/merges","archive_url":"https://api.github.com/repos/zdevito/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zdevito/pytorch/downloads","issues_url":"https://api.github.com/repos/zdevito/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/zdevito/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/zdevito/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/zdevito/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zdevito/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/zdevito/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/zdevito/pytorch/deployments","created_at":"2017-06-02T19:00:07Z","updated_at":"2018-11-13T19:07:38Z","pushed_at":"2019-01-03T04:02:03Z","git_url":"git://github.com/zdevito/pytorch.git","ssh_url":"git@github.com:zdevito/pytorch.git","clone_url":"https://github.com/zdevito/pytorch.git","svn_url":"https://github.com/zdevito/pytorch","homepage":"http://pytorch.org","size":95401,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"e2549cbc0101fc4f376f3226b0002625a397da14","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-01-03T04:00:05Z","pushed_at":"2019-01-03T04:02:12Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":97910,"stargazers_count":23373,"watchers_count":23373,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5544,"mirror_url":null,"archived":false,"open_issues_count":2401,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5544,"open_issues":2401,"watchers":23373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15690"},"html":{"href":"https://github.com/pytorch/pytorch/pull/15690"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15690"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/15690/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15690/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/15690/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/a989e8f812b967f31e5032c4331b34bbaa7af052"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"suo"}}