{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/188631682","pull_request_review_id":120647953,"id":188631682,"diff_hunk":"@@ -68,7 +68,7 @@ def addRecords(self, records=None, jsonFile=None):\n         f.write(json.dumps(jsondata))\n \n \n-def MakeDNServer(obj, name, filename=\"dns_file.json\", port=False, IP='127.0.0.1', rr=False, default=None, options={}):\n+def MakeDNServer(obj, name, filename=\"dns_file.json\", port=False, ip='127.0.0.1', rr=False, default=None, ipv6=False, options={}):","path":"tests/gold_tests/autest-site/microDNS.test.ext","position":5,"original_position":5,"commit_id":"d95b4bd0996b96784c8db24573367be93d8530d5","original_commit_id":"d95b4bd0996b96784c8db24573367be93d8530d5","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars2.githubusercontent.com/u/1545753?v=4","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"body":"This seems a bad API design choice to me. The family should be taken from the `ip` parameter, not specified separately. If you want to allow selection of special addresses by family, use the same technique as in C/C++ - reserve keywords such as \"IP_LOOPBACK\" or \"IP_ADDR_ANY\" to indicate such things.","created_at":"2018-05-16T13:49:36Z","updated_at":"2018-05-16T13:49:36Z","html_url":"https://github.com/apache/trafficserver/pull/3658#discussion_r188631682","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/3658","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/188631682"},"html":{"href":"https://github.com/apache/trafficserver/pull/3658#discussion_r188631682"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3658"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/3658","id":187946677,"html_url":"https://github.com/apache/trafficserver/pull/3658","diff_url":"https://github.com/apache/trafficserver/pull/3658.diff","patch_url":"https://github.com/apache/trafficserver/pull/3658.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/3658","number":3658,"state":"open","locked":false,"title":"IPv6 for microserver and microDNS","user":{"login":"macisasandwich","id":4216191,"avatar_url":"https://avatars0.githubusercontent.com/u/4216191?v=4","gravatar_id":"","url":"https://api.github.com/users/macisasandwich","html_url":"https://github.com/macisasandwich","followers_url":"https://api.github.com/users/macisasandwich/followers","following_url":"https://api.github.com/users/macisasandwich/following{/other_user}","gists_url":"https://api.github.com/users/macisasandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/macisasandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisasandwich/subscriptions","organizations_url":"https://api.github.com/users/macisasandwich/orgs","repos_url":"https://api.github.com/users/macisasandwich/repos","events_url":"https://api.github.com/users/macisasandwich/events{/privacy}","received_events_url":"https://api.github.com/users/macisasandwich/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-14T20:48:50Z","updated_at":"2018-05-16T13:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5ea7d21ac912cb96521de2fe6a11e8712b5af64","assignee":{"login":"macisasandwich","id":4216191,"avatar_url":"https://avatars0.githubusercontent.com/u/4216191?v=4","gravatar_id":"","url":"https://api.github.com/users/macisasandwich","html_url":"https://github.com/macisasandwich","followers_url":"https://api.github.com/users/macisasandwich/followers","following_url":"https://api.github.com/users/macisasandwich/following{/other_user}","gists_url":"https://api.github.com/users/macisasandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/macisasandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisasandwich/subscriptions","organizations_url":"https://api.github.com/users/macisasandwich/orgs","repos_url":"https://api.github.com/users/macisasandwich/repos","events_url":"https://api.github.com/users/macisasandwich/events{/privacy}","received_events_url":"https://api.github.com/users/macisasandwich/received_events","type":"User","site_admin":false},"assignees":[{"login":"macisasandwich","id":4216191,"avatar_url":"https://avatars0.githubusercontent.com/u/4216191?v=4","gravatar_id":"","url":"https://api.github.com/users/macisasandwich","html_url":"https://github.com/macisasandwich","followers_url":"https://api.github.com/users/macisasandwich/followers","following_url":"https://api.github.com/users/macisasandwich/following{/other_user}","gists_url":"https://api.github.com/users/macisasandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/macisasandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisasandwich/subscriptions","organizations_url":"https://api.github.com/users/macisasandwich/orgs","repos_url":"https://api.github.com/users/macisasandwich/repos","events_url":"https://api.github.com/users/macisasandwich/events{/privacy}","received_events_url":"https://api.github.com/users/macisasandwich/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":375368497,"url":"https://api.github.com/repos/apache/trafficserver/labels/Tests","name":"Tests","color":"c2e0c6","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/6","html_url":"https://github.com/apache/trafficserver/milestone/6","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/6/labels","id":1763406,"number":6,"title":"8.0.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars1.githubusercontent.com/u/202131?v=4","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":1158,"state":"open","created_at":"2016-05-12T22:13:34Z","updated_at":"2018-05-16T11:34:43Z","due_on":"2018-06-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/3658/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/3658/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/3658/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/d95b4bd0996b96784c8db24573367be93d8530d5","head":{"label":"macisasandwich:v6ServerDNS","ref":"v6ServerDNS","sha":"d95b4bd0996b96784c8db24573367be93d8530d5","user":{"login":"macisasandwich","id":4216191,"avatar_url":"https://avatars0.githubusercontent.com/u/4216191?v=4","gravatar_id":"","url":"https://api.github.com/users/macisasandwich","html_url":"https://github.com/macisasandwich","followers_url":"https://api.github.com/users/macisasandwich/followers","following_url":"https://api.github.com/users/macisasandwich/following{/other_user}","gists_url":"https://api.github.com/users/macisasandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/macisasandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisasandwich/subscriptions","organizations_url":"https://api.github.com/users/macisasandwich/orgs","repos_url":"https://api.github.com/users/macisasandwich/repos","events_url":"https://api.github.com/users/macisasandwich/events{/privacy}","received_events_url":"https://api.github.com/users/macisasandwich/received_events","type":"User","site_admin":false},"repo":{"id":99732174,"name":"trafficserver","full_name":"macisasandwich/trafficserver","owner":{"login":"macisasandwich","id":4216191,"avatar_url":"https://avatars0.githubusercontent.com/u/4216191?v=4","gravatar_id":"","url":"https://api.github.com/users/macisasandwich","html_url":"https://github.com/macisasandwich","followers_url":"https://api.github.com/users/macisasandwich/followers","following_url":"https://api.github.com/users/macisasandwich/following{/other_user}","gists_url":"https://api.github.com/users/macisasandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/macisasandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisasandwich/subscriptions","organizations_url":"https://api.github.com/users/macisasandwich/orgs","repos_url":"https://api.github.com/users/macisasandwich/repos","events_url":"https://api.github.com/users/macisasandwich/events{/privacy}","received_events_url":"https://api.github.com/users/macisasandwich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macisasandwich/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/macisasandwich/trafficserver","forks_url":"https://api.github.com/repos/macisasandwich/trafficserver/forks","keys_url":"https://api.github.com/repos/macisasandwich/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macisasandwich/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macisasandwich/trafficserver/teams","hooks_url":"https://api.github.com/repos/macisasandwich/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/macisasandwich/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/macisasandwich/trafficserver/events","assignees_url":"https://api.github.com/repos/macisasandwich/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/macisasandwich/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/macisasandwich/trafficserver/tags","blobs_url":"https://api.github.com/repos/macisasandwich/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macisasandwich/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macisasandwich/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/macisasandwich/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macisasandwich/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/macisasandwich/trafficserver/languages","stargazers_url":"https://api.github.com/repos/macisasandwich/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/macisasandwich/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/macisasandwich/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/macisasandwich/trafficserver/subscription","commits_url":"https://api.github.com/repos/macisasandwich/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/macisasandwich/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/macisasandwich/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/macisasandwich/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/macisasandwich/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/macisasandwich/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macisasandwich/trafficserver/merges","archive_url":"https://api.github.com/repos/macisasandwich/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macisasandwich/trafficserver/downloads","issues_url":"https://api.github.com/repos/macisasandwich/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/macisasandwich/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/macisasandwich/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/macisasandwich/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macisasandwich/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/macisasandwich/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/macisasandwich/trafficserver/deployments","created_at":"2017-08-08T20:11:59Z","updated_at":"2018-03-29T15:46:59Z","pushed_at":"2018-05-15T18:44:50Z","git_url":"git://github.com/macisasandwich/trafficserver.git","ssh_url":"git@github.com:macisasandwich/trafficserver.git","clone_url":"https://github.com/macisasandwich/trafficserver.git","svn_url":"https://github.com/macisasandwich/trafficserver","homepage":null,"size":82302,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1e801bfe6bf0fc07d16d84afb9f9d6a1d8845493","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2018-05-16T11:23:10Z","pushed_at":"2018-05-16T12:24:21Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":84364,"stargazers_count":706,"watchers_count":706,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":514,"mirror_url":null,"archived":false,"open_issues_count":292,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":514,"open_issues":292,"watchers":706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3658"},"html":{"href":"https://github.com/apache/trafficserver/pull/3658"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/3658"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/3658/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3658/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/3658/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/d95b4bd0996b96784c8db24573367be93d8530d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SolidWallOfCode"}}