{"action":"created","comment":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments/204562991","pull_request_review_id":139665512,"id":204562991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU2Mjk5MQ==","diff_hunk":"@@ -40,11 +40,11 @@ def show\n     # generate facet collection list for collection page only\n     models = @document[\"active_fedora_model_ssi\"]\n     if models.include?(\"DamsAssembledCollection\") || models.include?(\"DamsProvenanceCollection\") || models.include?(\"DamsProvenanceCollectionPart\") \n-        other_rights_fquery = \"(otherRights_tesim:localDisplay OR otherRights_tesim:metadataDisplay)\"\n-        collection_solr_params = { :q => \"collections_tesim:#{params[:id]}\", :fq => other_rights_fquery, :rows => 1 }\n-        collection_response, collection_documents = get_search_results(collection_solr_params)\n+        collection_solr_params = build_params(\"collections_tesim:#{params[:id]}\", metadata_only_fquery)\n+        collection_response = raw_solr(collection_solr_params)\n         @metadata_only = !collection_response.response['numFound'].zero?\n-\n+        @mix_objects = mix_objects?(params[:id], collection_response.response['numFound']) if @metadata_only","path":"app/controllers/dams_resource_controller.rb","position":11,"original_position":11,"commit_id":"b1d806622c38c1ee6502041df03d35c61d564986","original_commit_id":"b1d806622c38c1ee6502041df03d35c61d564986","user":{"login":"mcritchlow","id":67506,"node_id":"MDQ6VXNlcjY3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/67506?v=4","gravatar_id":"","url":"https://api.github.com/users/mcritchlow","html_url":"https://github.com/mcritchlow","followers_url":"https://api.github.com/users/mcritchlow/followers","following_url":"https://api.github.com/users/mcritchlow/following{/other_user}","gists_url":"https://api.github.com/users/mcritchlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mcritchlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcritchlow/subscriptions","organizations_url":"https://api.github.com/users/mcritchlow/orgs","repos_url":"https://api.github.com/users/mcritchlow/repos","events_url":"https://api.github.com/users/mcritchlow/events{/privacy}","received_events_url":"https://api.github.com/users/mcritchlow/received_events","type":"User","site_admin":false},"body":"Oh, I'm sorry. I missed this https://github.com/ucsdlib/damspas/pull/494/files#diff-c0623f718c6b24f20f5334d0d4eaf8d5R45 where you explicitly check for this. \r\n\r\nPerhaps what I wonder about then is if the default `nil` value and conditional to check for it are needed in `mix_objects?`? Is there any way then for that method to be called with there _aren't_ any results? ","created_at":"2018-07-23T21:41:27Z","updated_at":"2018-07-23T21:41:27Z","html_url":"https://github.com/ucsdlib/damspas/pull/494#discussion_r204562991","pull_request_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/494","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments/204562991"},"html":{"href":"https://github.com/ucsdlib/damspas/pull/494#discussion_r204562991"},"pull_request":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/494"}},"in_reply_to_id":204544243},"pull_request":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/494","id":202398655,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzk4NjU1","html_url":"https://github.com/ucsdlib/damspas/pull/494","diff_url":"https://github.com/ucsdlib/damspas/pull/494.diff","patch_url":"https://github.com/ucsdlib/damspas/pull/494.patch","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/494","number":494,"state":"open","locked":false,"title":"Add different access text for mixed objects metadata-only collection","user":{"login":"VivianChu","id":1864660,"node_id":"MDQ6VXNlcjE4NjQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1864660?v=4","gravatar_id":"","url":"https://api.github.com/users/VivianChu","html_url":"https://github.com/VivianChu","followers_url":"https://api.github.com/users/VivianChu/followers","following_url":"https://api.github.com/users/VivianChu/following{/other_user}","gists_url":"https://api.github.com/users/VivianChu/gists{/gist_id}","starred_url":"https://api.github.com/users/VivianChu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VivianChu/subscriptions","organizations_url":"https://api.github.com/users/VivianChu/orgs","repos_url":"https://api.github.com/users/VivianChu/repos","events_url":"https://api.github.com/users/VivianChu/events{/privacy}","received_events_url":"https://api.github.com/users/VivianChu/received_events","type":"User","site_admin":false},"body":"Fixes #483 \r\n\r\n#### Local Checklist\r\n- [x] Tests written and passing locally?\r\n- [x] Code style checked?\r\n- [x] QA-ed locally?\r\n- [x] Rebased with `master` branch?\r\n- [ ] Configuration updated (if needed)?\r\n- [ ] Documentation updated (if needed)?\r\n\r\n#### What does this PR do?\r\n \r\nIt will display \"Some items restricted\" access type for collection with mixed objects.\r\n\r\n##### Why are we doing this? Any context of related work?\r\n\r\nReferences #483 \r\n\r\n#### Screenshots\r\n\r\n![mixedcollection](https://user-images.githubusercontent.com/1864660/42911466-df70062c-8a9f-11e8-81e5-76a213a89ebc.png)\r\n\r\n\r\n\r\n\r\n@ucsdlib/developers - please review\r\n","created_at":"2018-07-18T22:33:51Z","updated_at":"2018-07-23T21:41:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8580736fd2ef5d868e4b18da46779d947c603bc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/494/commits","review_comments_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/494/comments","review_comment_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/494/comments","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/b1d806622c38c1ee6502041df03d35c61d564986","head":{"label":"ucsdlib:feature/mixed_collection","ref":"feature/mixed_collection","sha":"b1d806622c38c1ee6502041df03d35c61d564986","user":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4NzkyNg==","name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","deployments_url":"https://api.github.com/repos/ucsdlib/damspas/deployments","created_at":"2014-02-28T14:07:19Z","updated_at":"2018-07-23T18:00:34Z","pushed_at":"2018-07-23T19:21:53Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":36266,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":45,"watchers":5,"default_branch":"develop"}},"base":{"label":"ucsdlib:develop","ref":"develop","sha":"21ae16a14063c52319ac25c967a244674f6977b8","user":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4NzkyNg==","name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","deployments_url":"https://api.github.com/repos/ucsdlib/damspas/deployments","created_at":"2014-02-28T14:07:19Z","updated_at":"2018-07-23T18:00:34Z","pushed_at":"2018-07-23T19:21:53Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":36266,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":45,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/494"},"html":{"href":"https://github.com/ucsdlib/damspas/pull/494"},"issue":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/494"},"comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/ucsdlib/damspas/statuses/b1d806622c38c1ee6502041df03d35c61d564986"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcritchlow"}}