{"action":"created","issue":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3640","repository_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3640/labels{/name}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3640/comments","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3640/events","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3640","id":343424169,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDY3ODU0","number":3640,"title":"Allow chest to work with any cell","user":{"login":"fscan","id":5208596,"node_id":"MDQ6VXNlcjUyMDg1OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5208596?v=4","gravatar_id":"","url":"https://api.github.com/users/fscan","html_url":"https://github.com/fscan","followers_url":"https://api.github.com/users/fscan/followers","following_url":"https://api.github.com/users/fscan/following{/other_user}","gists_url":"https://api.github.com/users/fscan/gists{/gist_id}","starred_url":"https://api.github.com/users/fscan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscan/subscriptions","organizations_url":"https://api.github.com/users/fscan/orgs","repos_url":"https://api.github.com/users/fscan/repos","events_url":"https://api.github.com/users/fscan/events{/privacy}","received_events_url":"https://api.github.com/users/fscan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-22T17:34:42Z","updated_at":"2018-07-22T17:39:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3640","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3640","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3640.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3640.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments/406883907","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3640#issuecomment-406883907","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3640","id":406883907,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg4MzkwNw==","user":{"login":"orod-org","id":14347709,"node_id":"MDQ6VXNlcjE0MzQ3NzA5","avatar_url":"https://avatars0.githubusercontent.com/u/14347709?v=4","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T17:39:01Z","updated_at":"2018-07-22T17:39:01Z","author_association":"NONE","body":"SonarQube analysis reported 8 issues\n* ![CRITICAL][CRITICAL] 1 critical\n* ![MAJOR][MAJOR] 3 major\n* ![MINOR][MINOR] 4 minor\n\nWatch the comments in this conversation to review them.\n\n#### 6 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [TileChest.java#L224](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L224): Rename \"cellHandler\" which hides the field declared at line 123. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AHiddenFieldCheck)\n1. ![MAJOR][MAJOR] [TileChest.java#L754](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L754): Remove this expression which always evaluates to \"true\" [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS2589)\n1. ![MAJOR][MAJOR] [TileChest.java#L757](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L757): Remove this expression which always evaluates to \"true\" [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS2589)\n1. ![MINOR][MINOR] [TileChest.java#L260](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L260): Replace the type specification in this constructor call with the diamond operator (\"<>\"). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS2293)\n1. ![MINOR][MINOR] [TileChest.java#L263](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L263): Replace the type specification in this constructor call with the diamond operator (\"<>\"). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS2293)\n1. ![MINOR][MINOR] [TileChest.java#L676](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/fdc04b4b5be586f1c2b7a818e35695a6e5ae01a7/src/main/java/appeng/tile/storage/TileChest.java#L676): Redundant 'public' modifier. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=checkstyle%3Acom.puppycrawl.tools.checkstyle.checks.modifier.RedundantModifierCheck)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"orod-org"}}