{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/209216610","pull_request_review_id":145187753,"id":209216610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIxNjYxMA==","diff_hunk":"@@ -0,0 +1,49 @@\n+/*\n+ * Minio Cloud Storage, (C) 2018 Minio, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package rpc\n+\n+import (\n+\t\"bytes\"\n+\t\"sync\"\n+)\n+\n+// A Pool is a type-safe wrapper around a sync.Pool.\n+type Pool struct {\n+\tp *sync.Pool\n+}\n+\n+// NewPool constructs a new Pool.\n+func NewPool() Pool {\n+\treturn Pool{p: &sync.Pool{\n+\t\tNew: func() interface{} {\n+\t\t\treturn &bytes.Buffer{}\n+\t\t},\n+\t}}\n+}\n+\n+// Get retrieves a bytes.Buffer from the pool, creating one if necessary.\n+func (p Pool) Get() *bytes.Buffer {\n+\tbuf := p.p.Get().(*bytes.Buffer)\n+\tbuf.Reset()","path":"cmd/rpc/pool.go","position":41,"original_position":41,"commit_id":"d147f65473203749c4eb19558c8c910c8ed7b3b5","original_commit_id":"d147f65473203749c4eb19558c8c910c8ed7b3b5","user":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"Doesn't hurt to do it again. ","created_at":"2018-08-10T10:31:33Z","updated_at":"2018-08-10T10:31:34Z","html_url":"https://github.com/minio/minio/pull/6266#discussion_r209216610","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/6266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/209216610"},"html":{"href":"https://github.com/minio/minio/pull/6266#discussion_r209216610"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/6266"}},"in_reply_to_id":209181284},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6266","id":207265135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjY1MTM1","html_url":"https://github.com/minio/minio/pull/6266","diff_url":"https://github.com/minio/minio/pull/6266.diff","patch_url":"https://github.com/minio/minio/pull/6266.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6266","number":6266,"state":"open","locked":false,"title":"Allow for proper garbage collection by pooling bytes.Buffer","user":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nAllow for proper garbage collection by pooling bytes.Buffer\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nReduce memory usage by allowing quick GC sweeps.\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\nManually\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-08-09T10:08:59Z","updated_at":"2018-08-10T10:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd830b32824c689b2124ba2a34b6abcea229f2cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6266/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6266/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6266/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/d147f65473203749c4eb19558c8c910c8ed7b3b5","head":{"label":"harshavardhana:rpc-optimizations","ref":"rpc-optimizations","sha":"d147f65473203749c4eb19558c8c910c8ed7b3b5","user":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"repo":{"id":29261868,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTg2OA==","name":"minio","full_name":"harshavardhana/minio","owner":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshavardhana/minio","description":"Minio is open source Object Storage inspired from Amazon S3 API and Haystack Object Format","fork":true,"url":"https://api.github.com/repos/harshavardhana/minio","forks_url":"https://api.github.com/repos/harshavardhana/minio/forks","keys_url":"https://api.github.com/repos/harshavardhana/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshavardhana/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshavardhana/minio/teams","hooks_url":"https://api.github.com/repos/harshavardhana/minio/hooks","issue_events_url":"https://api.github.com/repos/harshavardhana/minio/issues/events{/number}","events_url":"https://api.github.com/repos/harshavardhana/minio/events","assignees_url":"https://api.github.com/repos/harshavardhana/minio/assignees{/user}","branches_url":"https://api.github.com/repos/harshavardhana/minio/branches{/branch}","tags_url":"https://api.github.com/repos/harshavardhana/minio/tags","blobs_url":"https://api.github.com/repos/harshavardhana/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshavardhana/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshavardhana/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshavardhana/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshavardhana/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/harshavardhana/minio/languages","stargazers_url":"https://api.github.com/repos/harshavardhana/minio/stargazers","contributors_url":"https://api.github.com/repos/harshavardhana/minio/contributors","subscribers_url":"https://api.github.com/repos/harshavardhana/minio/subscribers","subscription_url":"https://api.github.com/repos/harshavardhana/minio/subscription","commits_url":"https://api.github.com/repos/harshavardhana/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshavardhana/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshavardhana/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshavardhana/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshavardhana/minio/contents/{+path}","compare_url":"https://api.github.com/repos/harshavardhana/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshavardhana/minio/merges","archive_url":"https://api.github.com/repos/harshavardhana/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshavardhana/minio/downloads","issues_url":"https://api.github.com/repos/harshavardhana/minio/issues{/number}","pulls_url":"https://api.github.com/repos/harshavardhana/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/harshavardhana/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/harshavardhana/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshavardhana/minio/labels{/name}","releases_url":"https://api.github.com/repos/harshavardhana/minio/releases{/id}","deployments_url":"https://api.github.com/repos/harshavardhana/minio/deployments","created_at":"2015-01-14T19:32:24Z","updated_at":"2016-12-15T12:35:45Z","pushed_at":"2018-08-09T22:04:55Z","git_url":"git://github.com/harshavardhana/minio.git","ssh_url":"git@github.com:harshavardhana/minio.git","clone_url":"https://github.com/harshavardhana/minio.git","svn_url":"https://github.com/harshavardhana/minio","homepage":"http://minio.io","size":41308,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"pr_out_minio_dl_minio_io_changes_do_not_merge_until_webcli"}},"base":{"label":"minio:master","ref":"master","sha":"64f2c6181312a951905533a04820f4817aa0441b","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-08-10T10:09:48Z","pushed_at":"2018-08-10T08:15:24Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":39606,"stargazers_count":12410,"watchers_count":12410,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1092,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1092,"open_issues":139,"watchers":12410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6266"},"html":{"href":"https://github.com/minio/minio/pull/6266"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6266"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6266/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6266/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6266/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/d147f65473203749c4eb19558c8c910c8ed7b3b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"harshavardhana"}}