{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/pub/pulls/comments/181918720","pull_request_review_id":112627999,"id":181918720,"diff_hunk":"@@ -0,0 +1,10 @@\n+// Copyright (c) 2018, the Dart project authors.  Please see the AUTHORS file\n+// for details. All rights reserved. Use of this source code is governed by a\n+// BSD-style license that can be found in the LICENSE file.\n+\n+/// Like the AssetId class from barback but without the barback dependency.\n+class AssetId {","path":"lib/src/asset/id.dart","position":6,"original_position":6,"commit_id":"bcc70cdad61dd1e10a6a3d72387a6e2f811ad2f2","original_commit_id":"5baf95503dea2aa274e00699fa5bd287bda026cc","user":{"login":"natebosch","id":7528195,"avatar_url":"https://avatars3.githubusercontent.com/u/7528195?v=4","gravatar_id":"","url":"https://api.github.com/users/natebosch","html_url":"https://github.com/natebosch","followers_url":"https://api.github.com/users/natebosch/followers","following_url":"https://api.github.com/users/natebosch/following{/other_user}","gists_url":"https://api.github.com/users/natebosch/gists{/gist_id}","starred_url":"https://api.github.com/users/natebosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebosch/subscriptions","organizations_url":"https://api.github.com/users/natebosch/orgs","repos_url":"https://api.github.com/users/natebosch/repos","events_url":"https://api.github.com/users/natebosch/events{/privacy}","received_events_url":"https://api.github.com/users/natebosch/received_events","type":"User","site_admin":false},"body":"I tried that at first and hit at least one case where we were storing a collection of AssetIds and lost context of their associated packages.\r\n\r\nI can take another look, but I'd prefer to do that in a new PR.","created_at":"2018-04-16T23:57:04Z","updated_at":"2018-04-16T23:57:04Z","html_url":"https://github.com/dart-lang/pub/pull/1871#discussion_r181918720","pull_request_url":"https://api.github.com/repos/dart-lang/pub/pulls/1871","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/comments/181918720"},"html":{"href":"https://github.com/dart-lang/pub/pull/1871#discussion_r181918720"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/1871"}},"in_reply_to_id":181913538},"pull_request":{"url":"https://api.github.com/repos/dart-lang/pub/pulls/1871","id":181623322,"html_url":"https://github.com/dart-lang/pub/pull/1871","diff_url":"https://github.com/dart-lang/pub/pull/1871.diff","patch_url":"https://github.com/dart-lang/pub/pull/1871.patch","issue_url":"https://api.github.com/repos/dart-lang/pub/issues/1871","number":1871,"state":"open","locked":false,"title":"Drop build and serve","user":{"login":"natebosch","id":7528195,"avatar_url":"https://avatars3.githubusercontent.com/u/7528195?v=4","gravatar_id":"","url":"https://api.github.com/users/natebosch","html_url":"https://github.com/natebosch","followers_url":"https://api.github.com/users/natebosch/followers","following_url":"https://api.github.com/users/natebosch/following{/other_user}","gists_url":"https://api.github.com/users/natebosch/gists{/gist_id}","starred_url":"https://api.github.com/users/natebosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebosch/subscriptions","organizations_url":"https://api.github.com/users/natebosch/orgs","repos_url":"https://api.github.com/users/natebosch/repos","events_url":"https://api.github.com/users/natebosch/events{/privacy}","received_events_url":"https://api.github.com/users/natebosch/received_events","type":"User","site_admin":false},"body":"Closes #1857 \r\n\r\n- Drop `lib/src/{barback,dartdevc,asset}` and relevant tests\r\n- Add `lib/src/asset/id.dart` since non-building code uses this type\r\n  from barback.\r\n- Clean up analyzer errors, droping any code paths that relate to\r\n  dealing with Transformers, for example the `run` command's ability to\r\n  run with transformed code, or any parsing and plumbing for transformer\r\n  config.\r\n- Clean up any tests that were checking behavior of transformers or the\r\n  build or serve command.\r\n- Remove any dependencies for which I could no longer find an import.","created_at":"2018-04-14T01:14:02Z","updated_at":"2018-04-16T23:57:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"657e19bfcaef8786a2bb30c1d8253387339d5e95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jakemac53","id":984921,"avatar_url":"https://avatars3.githubusercontent.com/u/984921?v=4","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":421017922,"url":"https://api.github.com/repos/dart-lang/pub/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/pub/pulls/1871/commits","review_comments_url":"https://api.github.com/repos/dart-lang/pub/pulls/1871/comments","review_comment_url":"https://api.github.com/repos/dart-lang/pub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/pub/issues/1871/comments","statuses_url":"https://api.github.com/repos/dart-lang/pub/statuses/bcc70cdad61dd1e10a6a3d72387a6e2f811ad2f2","head":{"label":"dart-lang:kill-build","ref":"kill-build","sha":"bcc70cdad61dd1e10a6a3d72387a6e2f811ad2f2","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":35700184,"name":"pub","full_name":"dart-lang/pub","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/pub","description":"The package manager for Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/pub","forks_url":"https://api.github.com/repos/dart-lang/pub/forks","keys_url":"https://api.github.com/repos/dart-lang/pub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/pub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/pub/teams","hooks_url":"https://api.github.com/repos/dart-lang/pub/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/pub/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/pub/events","assignees_url":"https://api.github.com/repos/dart-lang/pub/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/pub/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/pub/tags","blobs_url":"https://api.github.com/repos/dart-lang/pub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/pub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/pub/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/pub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/pub/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/pub/languages","stargazers_url":"https://api.github.com/repos/dart-lang/pub/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/pub/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/pub/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/pub/subscription","commits_url":"https://api.github.com/repos/dart-lang/pub/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/pub/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/pub/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/pub/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/pub/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/pub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/pub/merges","archive_url":"https://api.github.com/repos/dart-lang/pub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/pub/downloads","issues_url":"https://api.github.com/repos/dart-lang/pub/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/pub/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/pub/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/pub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/pub/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/pub/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/pub/deployments","created_at":"2015-05-15T22:36:26Z","updated_at":"2018-04-14T17:36:55Z","pushed_at":"2018-04-16T23:54:35Z","git_url":"git://github.com/dart-lang/pub.git","ssh_url":"git@github.com:dart-lang/pub.git","clone_url":"https://github.com/dart-lang/pub.git","svn_url":"https://github.com/dart-lang/pub","homepage":"https://www.dartlang.org/tools/pub","size":5998,"stargazers_count":66,"watchers_count":66,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":39,"open_issues":82,"watchers":66,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"7f0650299fe0cec722aae09b7e090d45c287e8e6","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":35700184,"name":"pub","full_name":"dart-lang/pub","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/pub","description":"The package manager for Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/pub","forks_url":"https://api.github.com/repos/dart-lang/pub/forks","keys_url":"https://api.github.com/repos/dart-lang/pub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/pub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/pub/teams","hooks_url":"https://api.github.com/repos/dart-lang/pub/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/pub/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/pub/events","assignees_url":"https://api.github.com/repos/dart-lang/pub/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/pub/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/pub/tags","blobs_url":"https://api.github.com/repos/dart-lang/pub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/pub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/pub/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/pub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/pub/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/pub/languages","stargazers_url":"https://api.github.com/repos/dart-lang/pub/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/pub/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/pub/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/pub/subscription","commits_url":"https://api.github.com/repos/dart-lang/pub/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/pub/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/pub/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/pub/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/pub/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/pub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/pub/merges","archive_url":"https://api.github.com/repos/dart-lang/pub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/pub/downloads","issues_url":"https://api.github.com/repos/dart-lang/pub/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/pub/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/pub/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/pub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/pub/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/pub/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/pub/deployments","created_at":"2015-05-15T22:36:26Z","updated_at":"2018-04-14T17:36:55Z","pushed_at":"2018-04-16T23:54:35Z","git_url":"git://github.com/dart-lang/pub.git","ssh_url":"git@github.com:dart-lang/pub.git","clone_url":"https://github.com/dart-lang/pub.git","svn_url":"https://github.com/dart-lang/pub","homepage":"https://www.dartlang.org/tools/pub","size":5998,"stargazers_count":66,"watchers_count":66,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":39,"open_issues":82,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/1871"},"html":{"href":"https://github.com/dart-lang/pub/pull/1871"},"issue":{"href":"https://api.github.com/repos/dart-lang/pub/issues/1871"},"comments":{"href":"https://api.github.com/repos/dart-lang/pub/issues/1871/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/1871/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/pub/pulls/1871/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/pub/statuses/bcc70cdad61dd1e10a6a3d72387a6e2f811ad2f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"natebosch"}}