{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5","id":233575943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTc1OTQz","html_url":"https://github.com/mtrajvm/CV-project/pull/5","diff_url":"https://github.com/mtrajvm/CV-project/pull/5.diff","patch_url":"https://github.com/mtrajvm/CV-project/pull/5.patch","issue_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/5","number":5,"state":"closed","locked":false,"title":"Completed full user authentication.","user":{"login":"AbbasWadiwala","id":44192635,"node_id":"MDQ6VXNlcjQ0MTkyNjM1","avatar_url":"https://avatars1.githubusercontent.com/u/44192635?v=4","gravatar_id":"","url":"https://api.github.com/users/AbbasWadiwala","html_url":"https://github.com/AbbasWadiwala","followers_url":"https://api.github.com/users/AbbasWadiwala/followers","following_url":"https://api.github.com/users/AbbasWadiwala/following{/other_user}","gists_url":"https://api.github.com/users/AbbasWadiwala/gists{/gist_id}","starred_url":"https://api.github.com/users/AbbasWadiwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbbasWadiwala/subscriptions","organizations_url":"https://api.github.com/users/AbbasWadiwala/orgs","repos_url":"https://api.github.com/users/AbbasWadiwala/repos","events_url":"https://api.github.com/users/AbbasWadiwala/events{/privacy}","received_events_url":"https://api.github.com/users/AbbasWadiwala/received_events","type":"User","site_admin":false},"body":"All parts of the web site are authenticated by user and authorities.\r\nAdded many more Restfull controllers to divide each account types\r\naccess.\r\nchanged finding user by name instead of id making front end easier.\r\n\r\n- [x] code\r\n- [x] manual test\r\n- [x] review","created_at":"2018-11-26T14:26:27Z","updated_at":"2018-11-26T14:49:41Z","closed_at":"2018-11-26T14:49:41Z","merged_at":"2018-11-26T14:49:41Z","merge_commit_sha":"0a0ad77b46e0ed5b595b0a4131c411674a248c43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mtrajvm/CV-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/5/comments","statuses_url":"https://api.github.com/repos/mtrajvm/CV-project/statuses/90a9abf85c4d13723b3080c5396e6ccc82106824","head":{"label":"mtrajvm:SpringBoot-UserAccountType-FeatureBranch","ref":"SpringBoot-UserAccountType-FeatureBranch","sha":"90a9abf85c4d13723b3080c5396e6ccc82106824","user":{"login":"mtrajvm","id":45171960,"node_id":"MDQ6VXNlcjQ1MTcxOTYw","avatar_url":"https://avatars2.githubusercontent.com/u/45171960?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrajvm","html_url":"https://github.com/mtrajvm","followers_url":"https://api.github.com/users/mtrajvm/followers","following_url":"https://api.github.com/users/mtrajvm/following{/other_user}","gists_url":"https://api.github.com/users/mtrajvm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrajvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrajvm/subscriptions","organizations_url":"https://api.github.com/users/mtrajvm/orgs","repos_url":"https://api.github.com/users/mtrajvm/repos","events_url":"https://api.github.com/users/mtrajvm/events{/privacy}","received_events_url":"https://api.github.com/users/mtrajvm/received_events","type":"User","site_admin":false},"repo":{"id":158229633,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyMjk2MzM=","name":"CV-project","full_name":"mtrajvm/CV-project","private":false,"owner":{"login":"mtrajvm","id":45171960,"node_id":"MDQ6VXNlcjQ1MTcxOTYw","avatar_url":"https://avatars2.githubusercontent.com/u/45171960?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrajvm","html_url":"https://github.com/mtrajvm","followers_url":"https://api.github.com/users/mtrajvm/followers","following_url":"https://api.github.com/users/mtrajvm/following{/other_user}","gists_url":"https://api.github.com/users/mtrajvm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrajvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrajvm/subscriptions","organizations_url":"https://api.github.com/users/mtrajvm/orgs","repos_url":"https://api.github.com/users/mtrajvm/repos","events_url":"https://api.github.com/users/mtrajvm/events{/privacy}","received_events_url":"https://api.github.com/users/mtrajvm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mtrajvm/CV-project","description":null,"fork":false,"url":"https://api.github.com/repos/mtrajvm/CV-project","forks_url":"https://api.github.com/repos/mtrajvm/CV-project/forks","keys_url":"https://api.github.com/repos/mtrajvm/CV-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtrajvm/CV-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtrajvm/CV-project/teams","hooks_url":"https://api.github.com/repos/mtrajvm/CV-project/hooks","issue_events_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/events{/number}","events_url":"https://api.github.com/repos/mtrajvm/CV-project/events","assignees_url":"https://api.github.com/repos/mtrajvm/CV-project/assignees{/user}","branches_url":"https://api.github.com/repos/mtrajvm/CV-project/branches{/branch}","tags_url":"https://api.github.com/repos/mtrajvm/CV-project/tags","blobs_url":"https://api.github.com/repos/mtrajvm/CV-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtrajvm/CV-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtrajvm/CV-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtrajvm/CV-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtrajvm/CV-project/statuses/{sha}","languages_url":"https://api.github.com/repos/mtrajvm/CV-project/languages","stargazers_url":"https://api.github.com/repos/mtrajvm/CV-project/stargazers","contributors_url":"https://api.github.com/repos/mtrajvm/CV-project/contributors","subscribers_url":"https://api.github.com/repos/mtrajvm/CV-project/subscribers","subscription_url":"https://api.github.com/repos/mtrajvm/CV-project/subscription","commits_url":"https://api.github.com/repos/mtrajvm/CV-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtrajvm/CV-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtrajvm/CV-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtrajvm/CV-project/contents/{+path}","compare_url":"https://api.github.com/repos/mtrajvm/CV-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtrajvm/CV-project/merges","archive_url":"https://api.github.com/repos/mtrajvm/CV-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtrajvm/CV-project/downloads","issues_url":"https://api.github.com/repos/mtrajvm/CV-project/issues{/number}","pulls_url":"https://api.github.com/repos/mtrajvm/CV-project/pulls{/number}","milestones_url":"https://api.github.com/repos/mtrajvm/CV-project/milestones{/number}","notifications_url":"https://api.github.com/repos/mtrajvm/CV-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtrajvm/CV-project/labels{/name}","releases_url":"https://api.github.com/repos/mtrajvm/CV-project/releases{/id}","deployments_url":"https://api.github.com/repos/mtrajvm/CV-project/deployments","created_at":"2018-11-19T13:40:50Z","updated_at":"2018-11-23T15:03:29Z","pushed_at":"2018-11-26T14:49:41Z","git_url":"git://github.com/mtrajvm/CV-project.git","ssh_url":"git@github.com:mtrajvm/CV-project.git","clone_url":"https://github.com/mtrajvm/CV-project.git","svn_url":"https://github.com/mtrajvm/CV-project","homepage":null,"size":22796,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mtrajvm:master","ref":"master","sha":"f9c03f69635a3c4a7ec40db9ad98f551ee54f4bb","user":{"login":"mtrajvm","id":45171960,"node_id":"MDQ6VXNlcjQ1MTcxOTYw","avatar_url":"https://avatars2.githubusercontent.com/u/45171960?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrajvm","html_url":"https://github.com/mtrajvm","followers_url":"https://api.github.com/users/mtrajvm/followers","following_url":"https://api.github.com/users/mtrajvm/following{/other_user}","gists_url":"https://api.github.com/users/mtrajvm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrajvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrajvm/subscriptions","organizations_url":"https://api.github.com/users/mtrajvm/orgs","repos_url":"https://api.github.com/users/mtrajvm/repos","events_url":"https://api.github.com/users/mtrajvm/events{/privacy}","received_events_url":"https://api.github.com/users/mtrajvm/received_events","type":"User","site_admin":false},"repo":{"id":158229633,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyMjk2MzM=","name":"CV-project","full_name":"mtrajvm/CV-project","private":false,"owner":{"login":"mtrajvm","id":45171960,"node_id":"MDQ6VXNlcjQ1MTcxOTYw","avatar_url":"https://avatars2.githubusercontent.com/u/45171960?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrajvm","html_url":"https://github.com/mtrajvm","followers_url":"https://api.github.com/users/mtrajvm/followers","following_url":"https://api.github.com/users/mtrajvm/following{/other_user}","gists_url":"https://api.github.com/users/mtrajvm/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrajvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrajvm/subscriptions","organizations_url":"https://api.github.com/users/mtrajvm/orgs","repos_url":"https://api.github.com/users/mtrajvm/repos","events_url":"https://api.github.com/users/mtrajvm/events{/privacy}","received_events_url":"https://api.github.com/users/mtrajvm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mtrajvm/CV-project","description":null,"fork":false,"url":"https://api.github.com/repos/mtrajvm/CV-project","forks_url":"https://api.github.com/repos/mtrajvm/CV-project/forks","keys_url":"https://api.github.com/repos/mtrajvm/CV-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtrajvm/CV-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtrajvm/CV-project/teams","hooks_url":"https://api.github.com/repos/mtrajvm/CV-project/hooks","issue_events_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/events{/number}","events_url":"https://api.github.com/repos/mtrajvm/CV-project/events","assignees_url":"https://api.github.com/repos/mtrajvm/CV-project/assignees{/user}","branches_url":"https://api.github.com/repos/mtrajvm/CV-project/branches{/branch}","tags_url":"https://api.github.com/repos/mtrajvm/CV-project/tags","blobs_url":"https://api.github.com/repos/mtrajvm/CV-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtrajvm/CV-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtrajvm/CV-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtrajvm/CV-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtrajvm/CV-project/statuses/{sha}","languages_url":"https://api.github.com/repos/mtrajvm/CV-project/languages","stargazers_url":"https://api.github.com/repos/mtrajvm/CV-project/stargazers","contributors_url":"https://api.github.com/repos/mtrajvm/CV-project/contributors","subscribers_url":"https://api.github.com/repos/mtrajvm/CV-project/subscribers","subscription_url":"https://api.github.com/repos/mtrajvm/CV-project/subscription","commits_url":"https://api.github.com/repos/mtrajvm/CV-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtrajvm/CV-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtrajvm/CV-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtrajvm/CV-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtrajvm/CV-project/contents/{+path}","compare_url":"https://api.github.com/repos/mtrajvm/CV-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtrajvm/CV-project/merges","archive_url":"https://api.github.com/repos/mtrajvm/CV-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtrajvm/CV-project/downloads","issues_url":"https://api.github.com/repos/mtrajvm/CV-project/issues{/number}","pulls_url":"https://api.github.com/repos/mtrajvm/CV-project/pulls{/number}","milestones_url":"https://api.github.com/repos/mtrajvm/CV-project/milestones{/number}","notifications_url":"https://api.github.com/repos/mtrajvm/CV-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtrajvm/CV-project/labels{/name}","releases_url":"https://api.github.com/repos/mtrajvm/CV-project/releases{/id}","deployments_url":"https://api.github.com/repos/mtrajvm/CV-project/deployments","created_at":"2018-11-19T13:40:50Z","updated_at":"2018-11-23T15:03:29Z","pushed_at":"2018-11-26T14:49:41Z","git_url":"git://github.com/mtrajvm/CV-project.git","ssh_url":"git@github.com:mtrajvm/CV-project.git","clone_url":"https://github.com/mtrajvm/CV-project.git","svn_url":"https://github.com/mtrajvm/CV-project","homepage":null,"size":22796,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5"},"html":{"href":"https://github.com/mtrajvm/CV-project/pull/5"},"issue":{"href":"https://api.github.com/repos/mtrajvm/CV-project/issues/5"},"comments":{"href":"https://api.github.com/repos/mtrajvm/CV-project/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mtrajvm/CV-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mtrajvm/CV-project/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mtrajvm/CV-project/statuses/90a9abf85c4d13723b3080c5396e6ccc82106824"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AbbasWadiwala","id":44192635,"node_id":"MDQ6VXNlcjQ0MTkyNjM1","avatar_url":"https://avatars1.githubusercontent.com/u/44192635?v=4","gravatar_id":"","url":"https://api.github.com/users/AbbasWadiwala","html_url":"https://github.com/AbbasWadiwala","followers_url":"https://api.github.com/users/AbbasWadiwala/followers","following_url":"https://api.github.com/users/AbbasWadiwala/following{/other_user}","gists_url":"https://api.github.com/users/AbbasWadiwala/gists{/gist_id}","starred_url":"https://api.github.com/users/AbbasWadiwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbbasWadiwala/subscriptions","organizations_url":"https://api.github.com/users/AbbasWadiwala/orgs","repos_url":"https://api.github.com/users/AbbasWadiwala/repos","events_url":"https://api.github.com/users/AbbasWadiwala/events{/privacy}","received_events_url":"https://api.github.com/users/AbbasWadiwala/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":172,"deletions":38,"changed_files":12}}
{"actor":{"display_login":"AbbasWadiwala"}}