{"action":"created","comment":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/comments/194873892","pull_request_review_id":128130385,"id":194873892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDg3Mzg5Mg==","diff_hunk":"@@ -677,6 +674,10 @@ static void clear_nonces_hashtable(struct miner_pool_data *miner)\n \n static int share_can_be_accepted(struct miner_pool_data *miner, xdag_hash_t share, uint64_t task_index)\n {\n+\tif(!miner) {","path":"client/pool.c","position":81,"original_position":81,"commit_id":"d834f41130f9269d8061389eb531ec29271b9e5d","original_commit_id":"d834f41130f9269d8061389eb531ec29271b9e5d","user":{"login":"jonano614","id":6870809,"node_id":"MDQ6VXNlcjY4NzA4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6870809?v=4","gravatar_id":"","url":"https://api.github.com/users/jonano614","html_url":"https://github.com/jonano614","followers_url":"https://api.github.com/users/jonano614/followers","following_url":"https://api.github.com/users/jonano614/following{/other_user}","gists_url":"https://api.github.com/users/jonano614/gists{/gist_id}","starred_url":"https://api.github.com/users/jonano614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonano614/subscriptions","organizations_url":"https://api.github.com/users/jonano614/orgs","repos_url":"https://api.github.com/users/jonano614/repos","events_url":"https://api.github.com/users/jonano614/events{/privacy}","received_events_url":"https://api.github.com/users/jonano614/received_events","type":"User","site_admin":false},"body":"Thanks Marco, I rereviewed that logic and find out, that if conn_data->miner is NULL - pool will crash in share_can_be_accepted function and never get calculate_nopaid_shares function.","created_at":"2018-06-12T20:14:59Z","updated_at":"2018-06-12T20:14:59Z","html_url":"https://github.com/XDagger/xdag/pull/211#discussion_r194873892","pull_request_url":"https://api.github.com/repos/XDagger/xdag/pulls/211","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments/194873892"},"html":{"href":"https://github.com/XDagger/xdag/pull/211#discussion_r194873892"},"pull_request":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/211","id":194393518,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzkzNTE4","html_url":"https://github.com/XDagger/xdag/pull/211","diff_url":"https://github.com/XDagger/xdag/pull/211.diff","patch_url":"https://github.com/XDagger/xdag/pull/211.patch","issue_url":"https://api.github.com/repos/XDagger/xdag/issues/211","number":211,"state":"open","locked":false,"title":"Windows compilation is fixed. Some modifications and fixes.","user":{"login":"jonano614","id":6870809,"node_id":"MDQ6VXNlcjY4NzA4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6870809?v=4","gravatar_id":"","url":"https://api.github.com/users/jonano614","html_url":"https://github.com/jonano614","followers_url":"https://api.github.com/users/jonano614/followers","following_url":"https://api.github.com/users/jonano614/following{/other_user}","gists_url":"https://api.github.com/users/jonano614/gists{/gist_id}","starred_url":"https://api.github.com/users/jonano614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonano614/subscriptions","organizations_url":"https://api.github.com/users/jonano614/orgs","repos_url":"https://api.github.com/users/jonano614/repos","events_url":"https://api.github.com/users/jonano614/events{/privacy}","received_events_url":"https://api.github.com/users/jonano614/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-12T20:09:56Z","updated_at":"2018-06-12T20:14:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e81cff64dff656161092be48c31e2a4c4487938","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/XDagger/xdag/pulls/211/commits","review_comments_url":"https://api.github.com/repos/XDagger/xdag/pulls/211/comments","review_comment_url":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XDagger/xdag/issues/211/comments","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/d834f41130f9269d8061389eb531ec29271b9e5d","head":{"label":"jonano614:hashrate_reports_fixes","ref":"hashrate_reports_fixes","sha":"d834f41130f9269d8061389eb531ec29271b9e5d","user":{"login":"jonano614","id":6870809,"node_id":"MDQ6VXNlcjY4NzA4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6870809?v=4","gravatar_id":"","url":"https://api.github.com/users/jonano614","html_url":"https://github.com/jonano614","followers_url":"https://api.github.com/users/jonano614/followers","following_url":"https://api.github.com/users/jonano614/following{/other_user}","gists_url":"https://api.github.com/users/jonano614/gists{/gist_id}","starred_url":"https://api.github.com/users/jonano614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonano614/subscriptions","organizations_url":"https://api.github.com/users/jonano614/orgs","repos_url":"https://api.github.com/users/jonano614/repos","events_url":"https://api.github.com/users/jonano614/events{/privacy}","received_events_url":"https://api.github.com/users/jonano614/received_events","type":"User","site_admin":false},"repo":{"id":121957209,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5NTcyMDk=","name":"xdag","full_name":"jonano614/xdag","owner":{"login":"jonano614","id":6870809,"node_id":"MDQ6VXNlcjY4NzA4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6870809?v=4","gravatar_id":"","url":"https://api.github.com/users/jonano614","html_url":"https://github.com/jonano614","followers_url":"https://api.github.com/users/jonano614/followers","following_url":"https://api.github.com/users/jonano614/following{/other_user}","gists_url":"https://api.github.com/users/jonano614/gists{/gist_id}","starred_url":"https://api.github.com/users/jonano614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonano614/subscriptions","organizations_url":"https://api.github.com/users/jonano614/orgs","repos_url":"https://api.github.com/users/jonano614/repos","events_url":"https://api.github.com/users/jonano614/events{/privacy}","received_events_url":"https://api.github.com/users/jonano614/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonano614/xdag","description":"Official XDag repository","fork":true,"url":"https://api.github.com/repos/jonano614/xdag","forks_url":"https://api.github.com/repos/jonano614/xdag/forks","keys_url":"https://api.github.com/repos/jonano614/xdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonano614/xdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonano614/xdag/teams","hooks_url":"https://api.github.com/repos/jonano614/xdag/hooks","issue_events_url":"https://api.github.com/repos/jonano614/xdag/issues/events{/number}","events_url":"https://api.github.com/repos/jonano614/xdag/events","assignees_url":"https://api.github.com/repos/jonano614/xdag/assignees{/user}","branches_url":"https://api.github.com/repos/jonano614/xdag/branches{/branch}","tags_url":"https://api.github.com/repos/jonano614/xdag/tags","blobs_url":"https://api.github.com/repos/jonano614/xdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonano614/xdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonano614/xdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonano614/xdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonano614/xdag/statuses/{sha}","languages_url":"https://api.github.com/repos/jonano614/xdag/languages","stargazers_url":"https://api.github.com/repos/jonano614/xdag/stargazers","contributors_url":"https://api.github.com/repos/jonano614/xdag/contributors","subscribers_url":"https://api.github.com/repos/jonano614/xdag/subscribers","subscription_url":"https://api.github.com/repos/jonano614/xdag/subscription","commits_url":"https://api.github.com/repos/jonano614/xdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonano614/xdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonano614/xdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonano614/xdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonano614/xdag/contents/{+path}","compare_url":"https://api.github.com/repos/jonano614/xdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonano614/xdag/merges","archive_url":"https://api.github.com/repos/jonano614/xdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonano614/xdag/downloads","issues_url":"https://api.github.com/repos/jonano614/xdag/issues{/number}","pulls_url":"https://api.github.com/repos/jonano614/xdag/pulls{/number}","milestones_url":"https://api.github.com/repos/jonano614/xdag/milestones{/number}","notifications_url":"https://api.github.com/repos/jonano614/xdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonano614/xdag/labels{/name}","releases_url":"https://api.github.com/repos/jonano614/xdag/releases{/id}","deployments_url":"https://api.github.com/repos/jonano614/xdag/deployments","created_at":"2018-02-18T14:04:51Z","updated_at":"2018-04-17T13:57:54Z","pushed_at":"2018-06-12T20:07:33Z","git_url":"git://github.com/jonano614/xdag.git","ssh_url":"git@github.com:jonano614/xdag.git","clone_url":"https://github.com/jonano614/xdag.git","svn_url":"https://github.com/jonano614/xdag","homepage":"http://xdag.org/","size":5590,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"XDagger:develop","ref":"develop","sha":"bc7c5f5bcc7ad154d55bd489f1afb801814bb2d2","user":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"repo":{"id":117907222,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDcyMjI=","name":"xdag","full_name":"XDagger/xdag","owner":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XDagger/xdag","description":"Official XDag repository","fork":true,"url":"https://api.github.com/repos/XDagger/xdag","forks_url":"https://api.github.com/repos/XDagger/xdag/forks","keys_url":"https://api.github.com/repos/XDagger/xdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XDagger/xdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XDagger/xdag/teams","hooks_url":"https://api.github.com/repos/XDagger/xdag/hooks","issue_events_url":"https://api.github.com/repos/XDagger/xdag/issues/events{/number}","events_url":"https://api.github.com/repos/XDagger/xdag/events","assignees_url":"https://api.github.com/repos/XDagger/xdag/assignees{/user}","branches_url":"https://api.github.com/repos/XDagger/xdag/branches{/branch}","tags_url":"https://api.github.com/repos/XDagger/xdag/tags","blobs_url":"https://api.github.com/repos/XDagger/xdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XDagger/xdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XDagger/xdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/XDagger/xdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/{sha}","languages_url":"https://api.github.com/repos/XDagger/xdag/languages","stargazers_url":"https://api.github.com/repos/XDagger/xdag/stargazers","contributors_url":"https://api.github.com/repos/XDagger/xdag/contributors","subscribers_url":"https://api.github.com/repos/XDagger/xdag/subscribers","subscription_url":"https://api.github.com/repos/XDagger/xdag/subscription","commits_url":"https://api.github.com/repos/XDagger/xdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/XDagger/xdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/XDagger/xdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/XDagger/xdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/XDagger/xdag/contents/{+path}","compare_url":"https://api.github.com/repos/XDagger/xdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XDagger/xdag/merges","archive_url":"https://api.github.com/repos/XDagger/xdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XDagger/xdag/downloads","issues_url":"https://api.github.com/repos/XDagger/xdag/issues{/number}","pulls_url":"https://api.github.com/repos/XDagger/xdag/pulls{/number}","milestones_url":"https://api.github.com/repos/XDagger/xdag/milestones{/number}","notifications_url":"https://api.github.com/repos/XDagger/xdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XDagger/xdag/labels{/name}","releases_url":"https://api.github.com/repos/XDagger/xdag/releases{/id}","deployments_url":"https://api.github.com/repos/XDagger/xdag/deployments","created_at":"2018-01-17T23:55:56Z","updated_at":"2018-06-12T15:24:07Z","pushed_at":"2018-06-12T20:09:57Z","git_url":"git://github.com/XDagger/xdag.git","ssh_url":"git@github.com:XDagger/xdag.git","clone_url":"https://github.com/XDagger/xdag.git","svn_url":"https://github.com/XDagger/xdag","homepage":"http://xdag.io","size":5675,"stargazers_count":173,"watchers_count":173,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":75,"open_issues":22,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/211"},"html":{"href":"https://github.com/XDagger/xdag/pull/211"},"issue":{"href":"https://api.github.com/repos/XDagger/xdag/issues/211"},"comments":{"href":"https://api.github.com/repos/XDagger/xdag/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/XDagger/xdag/statuses/d834f41130f9269d8061389eb531ec29271b9e5d"}},"author_association":"NONE"}}
{"actor":{"display_login":"jonano614"}}