{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/207579587","pull_request_review_id":143225207,"id":207579587,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzU3OTU4Nw==","diff_hunk":"@@ -214,12 +214,9 @@ in\n             }\n           ];\n         # Always provide a smb.conf to shut up programs like smbclient and smbspool.\n-        environment.etc = singleton\n-          { source =\n-              if cfg.enable then configFile\n-              else pkgs.writeText \"smb-dummy.conf\" \"# Samba is disabled.\";\n-            target = \"samba/smb.conf\";\n-          };\n+        environment.etc.\"samba/smb.conf\".source =\n+          if cfg.enable then configFile\n+          else mkOptionDefault (pkgs.writeText \"smb-dummy.conf\" \"# Samba is disabled.\");","path":"nixos/modules/services/network-filesystems/samba.nix","position":12,"original_position":12,"commit_id":"0537c5a380c270f1b9dbba6493d0c8b5dcb6fe54","original_commit_id":"0537c5a380c270f1b9dbba6493d0c8b5dcb6fe54","user":{"login":"jfrankenau","id":2736480,"node_id":"MDQ6VXNlcjI3MzY0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2736480?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrankenau","html_url":"https://github.com/jfrankenau","followers_url":"https://api.github.com/users/jfrankenau/followers","following_url":"https://api.github.com/users/jfrankenau/following{/other_user}","gists_url":"https://api.github.com/users/jfrankenau/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrankenau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrankenau/subscriptions","organizations_url":"https://api.github.com/users/jfrankenau/orgs","repos_url":"https://api.github.com/users/jfrankenau/repos","events_url":"https://api.github.com/users/jfrankenau/events{/privacy}","received_events_url":"https://api.github.com/users/jfrankenau/received_events","type":"User","site_admin":false},"body":"Yes, I had a look at this bit of code as well and can only assume that `mkOverride` is doing magic. I've just tried it again and get the following error:\r\n\r\n    The unique option `environment.etc.samba/smb.conf.source' is defined multiple times, in …","created_at":"2018-08-03T15:20:03Z","updated_at":"2018-08-03T15:20:04Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44238#discussion_r207579587","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/207579587"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44238#discussion_r207579587"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238"}},"in_reply_to_id":207391385},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238","id":204888464,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODg4NDY0","html_url":"https://github.com/NixOS/nixpkgs/pull/44238","diff_url":"https://github.com/NixOS/nixpkgs/pull/44238.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44238.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44238","number":44238,"state":"open","locked":false,"title":"nixos/samba: allow dummy conf file to be overridden","user":{"login":"jfrankenau","id":2736480,"node_id":"MDQ6VXNlcjI3MzY0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2736480?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrankenau","html_url":"https://github.com/jfrankenau","followers_url":"https://api.github.com/users/jfrankenau/followers","following_url":"https://api.github.com/users/jfrankenau/following{/other_user}","gists_url":"https://api.github.com/users/jfrankenau/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrankenau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrankenau/subscriptions","organizations_url":"https://api.github.com/users/jfrankenau/orgs","repos_url":"https://api.github.com/users/jfrankenau/repos","events_url":"https://api.github.com/users/jfrankenau/events{/privacy}","received_events_url":"https://api.github.com/users/jfrankenau/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThis allows configuring samba clients on systems without a samba server by using mkForce.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nAlternatively, we could add an option like `dummyConfigText` to this module.","created_at":"2018-07-30T18:20:36Z","updated_at":"2018-08-03T15:20:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b94c7c7b1c785d14c0d2d1431128da9a4258d298","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44238/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0537c5a380c270f1b9dbba6493d0c8b5dcb6fe54","head":{"label":"jfrankenau:samba-conf-override","ref":"samba-conf-override","sha":"0537c5a380c270f1b9dbba6493d0c8b5dcb6fe54","user":{"login":"jfrankenau","id":2736480,"node_id":"MDQ6VXNlcjI3MzY0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2736480?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrankenau","html_url":"https://github.com/jfrankenau","followers_url":"https://api.github.com/users/jfrankenau/followers","following_url":"https://api.github.com/users/jfrankenau/following{/other_user}","gists_url":"https://api.github.com/users/jfrankenau/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrankenau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrankenau/subscriptions","organizations_url":"https://api.github.com/users/jfrankenau/orgs","repos_url":"https://api.github.com/users/jfrankenau/repos","events_url":"https://api.github.com/users/jfrankenau/events{/privacy}","received_events_url":"https://api.github.com/users/jfrankenau/received_events","type":"User","site_admin":false},"repo":{"id":95666435,"node_id":"MDEwOlJlcG9zaXRvcnk5NTY2NjQzNQ==","name":"nixpkgs","full_name":"jfrankenau/nixpkgs","owner":{"login":"jfrankenau","id":2736480,"node_id":"MDQ6VXNlcjI3MzY0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2736480?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrankenau","html_url":"https://github.com/jfrankenau","followers_url":"https://api.github.com/users/jfrankenau/followers","following_url":"https://api.github.com/users/jfrankenau/following{/other_user}","gists_url":"https://api.github.com/users/jfrankenau/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrankenau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrankenau/subscriptions","organizations_url":"https://api.github.com/users/jfrankenau/orgs","repos_url":"https://api.github.com/users/jfrankenau/repos","events_url":"https://api.github.com/users/jfrankenau/events{/privacy}","received_events_url":"https://api.github.com/users/jfrankenau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfrankenau/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/jfrankenau/nixpkgs","forks_url":"https://api.github.com/repos/jfrankenau/nixpkgs/forks","keys_url":"https://api.github.com/repos/jfrankenau/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfrankenau/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfrankenau/nixpkgs/teams","hooks_url":"https://api.github.com/repos/jfrankenau/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/jfrankenau/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/jfrankenau/nixpkgs/events","assignees_url":"https://api.github.com/repos/jfrankenau/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/jfrankenau/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/jfrankenau/nixpkgs/tags","blobs_url":"https://api.github.com/repos/jfrankenau/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfrankenau/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfrankenau/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfrankenau/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfrankenau/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/jfrankenau/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/jfrankenau/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/jfrankenau/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/jfrankenau/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/jfrankenau/nixpkgs/subscription","commits_url":"https://api.github.com/repos/jfrankenau/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfrankenau/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfrankenau/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfrankenau/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfrankenau/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/jfrankenau/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfrankenau/nixpkgs/merges","archive_url":"https://api.github.com/repos/jfrankenau/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfrankenau/nixpkgs/downloads","issues_url":"https://api.github.com/repos/jfrankenau/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/jfrankenau/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/jfrankenau/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/jfrankenau/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfrankenau/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/jfrankenau/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/jfrankenau/nixpkgs/deployments","created_at":"2017-06-28T12:24:53Z","updated_at":"2018-08-03T13:57:44Z","pushed_at":"2018-08-03T13:57:42Z","git_url":"git://github.com/jfrankenau/nixpkgs.git","ssh_url":"git@github.com:jfrankenau/nixpkgs.git","clone_url":"https://github.com/jfrankenau/nixpkgs.git","svn_url":"https://github.com/jfrankenau/nixpkgs","homepage":null,"size":748370,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"7c585235ff66634137c61991c9b05f9de2b48e44","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-03T15:04:02Z","pushed_at":"2018-08-03T15:19:44Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":830247,"stargazers_count":2611,"watchers_count":2611,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2915,"mirror_url":null,"archived":false,"open_issues_count":3040,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2915,"open_issues":3040,"watchers":2611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44238"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44238"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44238/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44238/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0537c5a380c270f1b9dbba6493d0c8b5dcb6fe54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfrankenau"}}