{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/200813922","pull_request_review_id":135206092,"id":200813922,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgxMzkyMg==","diff_hunk":"@@ -136,6 +136,13 @@\n     - docker\n requirements:\n     - python >= 2.7\n+    - docker-py >= 1.7.0","path":"lib/ansible/modules/cloud/docker/docker_swarm.py","position":4,"original_position":4,"commit_id":"cde45c0765118657d5b033175e71abb6206be4af","original_commit_id":"cde45c0765118657d5b033175e71abb6206be4af","user":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"body":"Hmm, good question; the code also uses the `log_driver` parameter of `create_swarm_spec`, which has (according to the change log) only introduced in 2.6.0; I'll bump it up to that for now. @tbouvet: do you know more details?","created_at":"2018-07-07T14:36:29Z","updated_at":"2018-07-07T14:36:29Z","html_url":"https://github.com/ansible/ansible/pull/42457#discussion_r200813922","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/42457","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/200813922"},"html":{"href":"https://github.com/ansible/ansible/pull/42457#discussion_r200813922"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/42457"}},"in_reply_to_id":200808731},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/42457","id":199888282,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODg4Mjgy","html_url":"https://github.com/ansible/ansible/pull/42457","diff_url":"https://github.com/ansible/ansible/pull/42457.diff","patch_url":"https://github.com/ansible/ansible/pull/42457.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/42457","number":42457,"state":"open","locked":false,"title":"Docker modules: improve documentation on docker vs. docker-py Python package requirements","user":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThe original (semi-)official Python module for working with docker was called [docker-py](https://pypi.org/project/docker-py/), which exists up to version 1.10.6. It has been [renamed/superseeded](https://github.com/docker/docker-py/issues/1310) to/by the [docker](https://pypi.org/project/docker/) module, which starts with version 2.0.0.\r\n\r\nThis (and the fact that this is not mentioned on either of the pypi pages; though such a note was apparently [added](https://github.com/docker/docker-py/issues/1431), but later got lost again) leads to a lot of confusion, which can be seen for example in #42162 and #42258. A lot of people seem to believe since the requirements and error messages only mention `python-py`, that the modules do not work with the Python `docker` module (which is wrong, except if this is caused by a bug -- but that should not be fixed by adjusting the requirements). On the other hand, `python-py` is still required for Python 2.6, since Python 2.6 support was dropped before the first release of `docker`.\r\n\r\nThis PR tries to clean up the documentation by adding a disclaimer in the requirements section of every module mentioning both `docker` and `docker-py` (recommending `docker` if Python 2.6 is not required), and updates the error messages in the common code in `module_utils/docker_common.py` to also mention `docker` and not just `docker-py`.\r\n\r\nSuperseeds #42370 and #42394. Fixes #42258.\r\nCC @samdoran, @kassiansun.\r\n\r\nI would appreciate it if some of the docker module maintainers could take a look at this in more detail. Thanks.\r\n\r\n##### ISSUE TYPE\r\n - Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/module_utils/docker_common.py\r\ndocker_container\r\ndocker_image\r\ndocker_image_facts\r\ndocker_login\r\ndocker_network\r\ndocker_secret\r\ndocker_service\r\ndocker_swarm\r\ndocker_volume\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.6.1\r\n```\r\n","created_at":"2018-07-07T09:06:08Z","updated_at":"2018-07-07T14:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bec2aea39f12874d816ec654a7ba89811f6ce300","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":500715204,"node_id":"MDU6TGFiZWw1MDA3MTUyMDQ=","url":"https://api.github.com/repos/ansible/ansible/labels/docker","name":"docker","color":"c5def5","default":false},{"id":849212023,"node_id":"MDU6TGFiZWw4NDkyMTIwMjM=","url":"https://api.github.com/repos/ansible/ansible/labels/docs","name":"docs","color":"0052cc","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/42457/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/42457/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/42457/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/cde45c0765118657d5b033175e71abb6206be4af","head":{"label":"felixfontein:docker-improve-requirement-docs","ref":"docker-improve-requirement-docs","sha":"cde45c0765118657d5b033175e71abb6206be4af","user":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"repo":{"id":51219776,"node_id":"MDEwOlJlcG9zaXRvcnk1MTIxOTc3Ng==","name":"ansible","full_name":"felixfontein/ansible","owner":{"login":"felixfontein","id":5781356,"node_id":"MDQ6VXNlcjU3ODEzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixfontein/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/felixfontein/ansible","forks_url":"https://api.github.com/repos/felixfontein/ansible/forks","keys_url":"https://api.github.com/repos/felixfontein/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixfontein/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixfontein/ansible/teams","hooks_url":"https://api.github.com/repos/felixfontein/ansible/hooks","issue_events_url":"https://api.github.com/repos/felixfontein/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/felixfontein/ansible/events","assignees_url":"https://api.github.com/repos/felixfontein/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/felixfontein/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/felixfontein/ansible/tags","blobs_url":"https://api.github.com/repos/felixfontein/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixfontein/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixfontein/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixfontein/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixfontein/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/felixfontein/ansible/languages","stargazers_url":"https://api.github.com/repos/felixfontein/ansible/stargazers","contributors_url":"https://api.github.com/repos/felixfontein/ansible/contributors","subscribers_url":"https://api.github.com/repos/felixfontein/ansible/subscribers","subscription_url":"https://api.github.com/repos/felixfontein/ansible/subscription","commits_url":"https://api.github.com/repos/felixfontein/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixfontein/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixfontein/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixfontein/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixfontein/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/felixfontein/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixfontein/ansible/merges","archive_url":"https://api.github.com/repos/felixfontein/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixfontein/ansible/downloads","issues_url":"https://api.github.com/repos/felixfontein/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/felixfontein/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/felixfontein/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/felixfontein/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixfontein/ansible/labels{/name}","releases_url":"https://api.github.com/repos/felixfontein/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/felixfontein/ansible/deployments","created_at":"2016-02-06T20:16:02Z","updated_at":"2018-07-07T08:24:38Z","pushed_at":"2018-07-07T09:35:37Z","git_url":"git://github.com/felixfontein/ansible.git","ssh_url":"git@github.com:felixfontein/ansible.git","clone_url":"https://github.com/felixfontein/ansible.git","svn_url":"https://github.com/felixfontein/ansible","homepage":"http://ansible.com/","size":118125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"1d1595b990641b6a3446c6a94ddf992ef9cfac39","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-07-07T13:52:08Z","pushed_at":"2018-07-07T14:21:27Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":134287,"stargazers_count":31176,"watchers_count":31176,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11911,"mirror_url":null,"archived":false,"open_issues_count":5193,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11911,"open_issues":5193,"watchers":31176,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/42457"},"html":{"href":"https://github.com/ansible/ansible/pull/42457"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/42457"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/42457/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/42457/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/42457/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/cde45c0765118657d5b033175e71abb6206be4af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"felixfontein"}}