{"action":"created","comment":{"url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments/177399582","pull_request_review_id":107255618,"id":177399582,"diff_hunk":"@@ -29,11 +29,11 @@ namespace TrenchBroom {\n     namespace View {\n         const Command::CommandType SnapBrushVerticesCommand::Type = Command::freeType();\n \n-        SnapBrushVerticesCommand::Ptr SnapBrushVerticesCommand::snap(size_t snapTo) {\n+        SnapBrushVerticesCommand::Ptr SnapBrushVerticesCommand::snap(FloatType snapTo) {","path":"common/src/View/SnapBrushVerticesCommand.cpp","position":5,"original_position":5,"commit_id":"f7b84b12f071b619ac05f7c29d1293f453d92bba","original_commit_id":"f7b84b12f071b619ac05f7c29d1293f453d92bba","user":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"body":"Please add `const` modifier.","created_at":"2018-03-27T12:07:17Z","updated_at":"2018-03-27T12:09:17Z","html_url":"https://github.com/kduske/TrenchBroom/pull/2116#discussion_r177399582","pull_request_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments/177399582"},"html":{"href":"https://github.com/kduske/TrenchBroom/pull/2116#discussion_r177399582"},"pull_request":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116"}}},"pull_request":{"url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116","id":177379411,"html_url":"https://github.com/kduske/TrenchBroom/pull/2116","diff_url":"https://github.com/kduske/TrenchBroom/pull/2116.diff","patch_url":"https://github.com/kduske/TrenchBroom/pull/2116.patch","issue_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/2116","number":2116,"state":"open","locked":false,"title":"1723: Support grid 0.5, 0.25, 0.125","user":{"login":"ericwa","id":239161,"avatar_url":"https://avatars1.githubusercontent.com/u/239161?v=4","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"body":"Fixes #1723 \r\n\r\nThings I tested:\r\n- snapping a totally off-grid brush to 0.125, this worked\r\n- menu and toolbar, increase/decrease grid size shortcuts\r\n\r\nI'm not totally sure about the change in `Grid::moveDelta` or the cast I added to `snap()`.\r\nThe tests should probably be expanded a bit as well before merging","created_at":"2018-03-26T08:52:20Z","updated_at":"2018-03-27T12:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eb0cd4c1c943dac4f99749818658739924645c1","assignee":{"login":"ericwa","id":239161,"avatar_url":"https://avatars1.githubusercontent.com/u/239161?v=4","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"assignees":[{"login":"ericwa","id":239161,"avatar_url":"https://avatars1.githubusercontent.com/u/239161?v=4","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":507324566,"url":"https://api.github.com/repos/kduske/TrenchBroom/labels/Status:In%20Progress","name":"Status:In Progress","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/kduske/TrenchBroom/milestones/17","html_url":"https://github.com/kduske/TrenchBroom/milestone/17","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/milestones/17/labels","id":734710,"number":17,"title":"2.1.0","description":"","creator":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":29,"state":"open","created_at":"2014-07-28T20:52:28Z","updated_at":"2018-03-26T15:04:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116/commits","review_comments_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116/comments","review_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/2116/comments","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/f7b84b12f071b619ac05f7c29d1293f453d92bba","head":{"label":"kduske:feature/1723","ref":"feature/1723","sha":"f7b84b12f071b619ac05f7c29d1293f453d92bba","user":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"repo":{"id":4003232,"name":"TrenchBroom","full_name":"kduske/TrenchBroom","owner":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kduske/TrenchBroom","description":"Cross-Platform Level Editor","fork":false,"url":"https://api.github.com/repos/kduske/TrenchBroom","forks_url":"https://api.github.com/repos/kduske/TrenchBroom/forks","keys_url":"https://api.github.com/repos/kduske/TrenchBroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kduske/TrenchBroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kduske/TrenchBroom/teams","hooks_url":"https://api.github.com/repos/kduske/TrenchBroom/hooks","issue_events_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/events{/number}","events_url":"https://api.github.com/repos/kduske/TrenchBroom/events","assignees_url":"https://api.github.com/repos/kduske/TrenchBroom/assignees{/user}","branches_url":"https://api.github.com/repos/kduske/TrenchBroom/branches{/branch}","tags_url":"https://api.github.com/repos/kduske/TrenchBroom/tags","blobs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kduske/TrenchBroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kduske/TrenchBroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/{sha}","languages_url":"https://api.github.com/repos/kduske/TrenchBroom/languages","stargazers_url":"https://api.github.com/repos/kduske/TrenchBroom/stargazers","contributors_url":"https://api.github.com/repos/kduske/TrenchBroom/contributors","subscribers_url":"https://api.github.com/repos/kduske/TrenchBroom/subscribers","subscription_url":"https://api.github.com/repos/kduske/TrenchBroom/subscription","commits_url":"https://api.github.com/repos/kduske/TrenchBroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kduske/TrenchBroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/kduske/TrenchBroom/contents/{+path}","compare_url":"https://api.github.com/repos/kduske/TrenchBroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kduske/TrenchBroom/merges","archive_url":"https://api.github.com/repos/kduske/TrenchBroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kduske/TrenchBroom/downloads","issues_url":"https://api.github.com/repos/kduske/TrenchBroom/issues{/number}","pulls_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls{/number}","milestones_url":"https://api.github.com/repos/kduske/TrenchBroom/milestones{/number}","notifications_url":"https://api.github.com/repos/kduske/TrenchBroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/labels{/name}","releases_url":"https://api.github.com/repos/kduske/TrenchBroom/releases{/id}","deployments_url":"https://api.github.com/repos/kduske/TrenchBroom/deployments","created_at":"2012-04-12T09:39:51Z","updated_at":"2018-03-23T19:56:40Z","pushed_at":"2018-03-26T18:17:58Z","git_url":"git://github.com/kduske/TrenchBroom.git","ssh_url":"git@github.com:kduske/TrenchBroom.git","clone_url":"https://github.com/kduske/TrenchBroom.git","svn_url":"https://github.com/kduske/TrenchBroom","homepage":"kristianduske.com/trenchbroom","size":112290,"stargazers_count":332,"watchers_count":332,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":176,"license":null,"forks":39,"open_issues":176,"watchers":332,"default_branch":"master"}},"base":{"label":"kduske:master","ref":"master","sha":"1df5e7d31d1510a5e68d002d61766036b81c37a5","user":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"repo":{"id":4003232,"name":"TrenchBroom","full_name":"kduske/TrenchBroom","owner":{"login":"kduske","id":186061,"avatar_url":"https://avatars3.githubusercontent.com/u/186061?v=4","gravatar_id":"","url":"https://api.github.com/users/kduske","html_url":"https://github.com/kduske","followers_url":"https://api.github.com/users/kduske/followers","following_url":"https://api.github.com/users/kduske/following{/other_user}","gists_url":"https://api.github.com/users/kduske/gists{/gist_id}","starred_url":"https://api.github.com/users/kduske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kduske/subscriptions","organizations_url":"https://api.github.com/users/kduske/orgs","repos_url":"https://api.github.com/users/kduske/repos","events_url":"https://api.github.com/users/kduske/events{/privacy}","received_events_url":"https://api.github.com/users/kduske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kduske/TrenchBroom","description":"Cross-Platform Level Editor","fork":false,"url":"https://api.github.com/repos/kduske/TrenchBroom","forks_url":"https://api.github.com/repos/kduske/TrenchBroom/forks","keys_url":"https://api.github.com/repos/kduske/TrenchBroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kduske/TrenchBroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kduske/TrenchBroom/teams","hooks_url":"https://api.github.com/repos/kduske/TrenchBroom/hooks","issue_events_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/events{/number}","events_url":"https://api.github.com/repos/kduske/TrenchBroom/events","assignees_url":"https://api.github.com/repos/kduske/TrenchBroom/assignees{/user}","branches_url":"https://api.github.com/repos/kduske/TrenchBroom/branches{/branch}","tags_url":"https://api.github.com/repos/kduske/TrenchBroom/tags","blobs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kduske/TrenchBroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kduske/TrenchBroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kduske/TrenchBroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kduske/TrenchBroom/statuses/{sha}","languages_url":"https://api.github.com/repos/kduske/TrenchBroom/languages","stargazers_url":"https://api.github.com/repos/kduske/TrenchBroom/stargazers","contributors_url":"https://api.github.com/repos/kduske/TrenchBroom/contributors","subscribers_url":"https://api.github.com/repos/kduske/TrenchBroom/subscribers","subscription_url":"https://api.github.com/repos/kduske/TrenchBroom/subscription","commits_url":"https://api.github.com/repos/kduske/TrenchBroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kduske/TrenchBroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kduske/TrenchBroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kduske/TrenchBroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/kduske/TrenchBroom/contents/{+path}","compare_url":"https://api.github.com/repos/kduske/TrenchBroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kduske/TrenchBroom/merges","archive_url":"https://api.github.com/repos/kduske/TrenchBroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kduske/TrenchBroom/downloads","issues_url":"https://api.github.com/repos/kduske/TrenchBroom/issues{/number}","pulls_url":"https://api.github.com/repos/kduske/TrenchBroom/pulls{/number}","milestones_url":"https://api.github.com/repos/kduske/TrenchBroom/milestones{/number}","notifications_url":"https://api.github.com/repos/kduske/TrenchBroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kduske/TrenchBroom/labels{/name}","releases_url":"https://api.github.com/repos/kduske/TrenchBroom/releases{/id}","deployments_url":"https://api.github.com/repos/kduske/TrenchBroom/deployments","created_at":"2012-04-12T09:39:51Z","updated_at":"2018-03-23T19:56:40Z","pushed_at":"2018-03-26T18:17:58Z","git_url":"git://github.com/kduske/TrenchBroom.git","ssh_url":"git@github.com:kduske/TrenchBroom.git","clone_url":"https://github.com/kduske/TrenchBroom.git","svn_url":"https://github.com/kduske/TrenchBroom","homepage":"kristianduske.com/trenchbroom","size":112290,"stargazers_count":332,"watchers_count":332,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":176,"license":null,"forks":39,"open_issues":176,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116"},"html":{"href":"https://github.com/kduske/TrenchBroom/pull/2116"},"issue":{"href":"https://api.github.com/repos/kduske/TrenchBroom/issues/2116"},"comments":{"href":"https://api.github.com/repos/kduske/TrenchBroom/issues/2116/comments"},"review_comments":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116/comments"},"review_comment":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kduske/TrenchBroom/pulls/2116/commits"},"statuses":{"href":"https://api.github.com/repos/kduske/TrenchBroom/statuses/f7b84b12f071b619ac05f7c29d1293f453d92bba"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kduske"}}