{"action":"created","issue":{"url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/60","repository_url":"https://api.github.com/repos/charlesq34/frustum-pointnets","labels_url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/60/comments","events_url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/60/events","html_url":"https://github.com/charlesq34/frustum-pointnets/issues/60","id":371251590,"node_id":"MDU6SXNzdWUzNzEyNTE1OTA=","number":60,"title":"wrong corner loss calculation","user":{"login":"lzljzys","id":7969099,"node_id":"MDQ6VXNlcjc5NjkwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7969099?v=4","gravatar_id":"","url":"https://api.github.com/users/lzljzys","html_url":"https://github.com/lzljzys","followers_url":"https://api.github.com/users/lzljzys/followers","following_url":"https://api.github.com/users/lzljzys/following{/other_user}","gists_url":"https://api.github.com/users/lzljzys/gists{/gist_id}","starred_url":"https://api.github.com/users/lzljzys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzljzys/subscriptions","organizations_url":"https://api.github.com/users/lzljzys/orgs","repos_url":"https://api.github.com/users/lzljzys/repos","events_url":"https://api.github.com/users/lzljzys/events{/privacy}","received_events_url":"https://api.github.com/users/lzljzys/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-17T20:22:13Z","updated_at":"2018-10-29T00:59:32Z","closed_at":null,"author_association":"NONE","body":"https://github.com/charlesq34/frustum-pointnets/blob/2ffdd345e1fce4775ecb508d207e0ad465bcca80/models/model_util.py#L384-L385\r\n\r\nCurrently, the corner points used to calculate corners_dist is a mix of both gt and gt_flip, which seems to be incorrect.\r\nIt should be only from one of these two, i.e. the one with minimum distance sum over 8 points."},"comment":{"url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/comments/433759524","html_url":"https://github.com/charlesq34/frustum-pointnets/issues/60#issuecomment-433759524","issue_url":"https://api.github.com/repos/charlesq34/frustum-pointnets/issues/60","id":433759524,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc1OTUyNA==","user":{"login":"kwea123","id":11364490,"node_id":"MDQ6VXNlcjExMzY0NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/11364490?v=4","gravatar_id":"","url":"https://api.github.com/users/kwea123","html_url":"https://github.com/kwea123","followers_url":"https://api.github.com/users/kwea123/followers","following_url":"https://api.github.com/users/kwea123/following{/other_user}","gists_url":"https://api.github.com/users/kwea123/gists{/gist_id}","starred_url":"https://api.github.com/users/kwea123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwea123/subscriptions","organizations_url":"https://api.github.com/users/kwea123/orgs","repos_url":"https://api.github.com/users/kwea123/repos","events_url":"https://api.github.com/users/kwea123/events{/privacy}","received_events_url":"https://api.github.com/users/kwea123/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T00:59:32Z","updated_at":"2018-10-29T00:59:32Z","author_association":"NONE","body":"Alright I understand it now; I also thought it outputs B*1..\r\nYou are right, the shape is B*8, and the correct way should be to apply a `tf.reduce_mean` or `tf.maximum` to combine these 8 corner distances before taking `tf.minimum`?"}}
{"actor":{"display_login":"kwea123"}}