{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/1950","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/1950/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/1950/comments","events_url":"https://api.github.com/repos/google/googletest/issues/1950/events","html_url":"https://github.com/google/googletest/pull/1950","id":376271436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTI2NDIz","number":1950,"title":"Updating Sample Makefile to Specify C++11","user":{"login":"benjamincarman","id":40589324,"node_id":"MDQ6VXNlcjQwNTg5MzI0","avatar_url":"https://avatars2.githubusercontent.com/u/40589324?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamincarman","html_url":"https://github.com/benjamincarman","followers_url":"https://api.github.com/users/benjamincarman/followers","following_url":"https://api.github.com/users/benjamincarman/following{/other_user}","gists_url":"https://api.github.com/users/benjamincarman/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamincarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamincarman/subscriptions","organizations_url":"https://api.github.com/users/benjamincarman/orgs","repos_url":"https://api.github.com/users/benjamincarman/repos","events_url":"https://api.github.com/users/benjamincarman/events{/privacy}","received_events_url":"https://api.github.com/users/benjamincarman/received_events","type":"User","site_admin":false},"labels":[{"id":1005990523,"node_id":"MDU6TGFiZWwxMDA1OTkwNTIz","url":"https://api.github.com/repos/google/googletest/labels/cla:%20yes","name":"cla: yes","color":"8bed95","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-01T06:34:40Z","updated_at":"2018-11-01T18:07:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/1950","html_url":"https://github.com/google/googletest/pull/1950","diff_url":"https://github.com/google/googletest/pull/1950.diff","patch_url":"https://github.com/google/googletest/pull/1950.patch"},"body":"Added a line to the sample Makefile in googletest/googletest/make to specify the use of C++11 in CXXFLAGS as required by googletest. This flag is required on some systems to make sure C++11 is used and it should be automatically included in the sample Makefile in order for it to run out of the box."},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/435132098","html_url":"https://github.com/google/googletest/pull/1950#issuecomment-435132098","issue_url":"https://api.github.com/repos/google/googletest/issues/1950","id":435132098,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTEzMjA5OA==","user":{"login":"benjamincarman","id":40589324,"node_id":"MDQ6VXNlcjQwNTg5MzI0","avatar_url":"https://avatars2.githubusercontent.com/u/40589324?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamincarman","html_url":"https://github.com/benjamincarman","followers_url":"https://api.github.com/users/benjamincarman/followers","following_url":"https://api.github.com/users/benjamincarman/following{/other_user}","gists_url":"https://api.github.com/users/benjamincarman/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamincarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamincarman/subscriptions","organizations_url":"https://api.github.com/users/benjamincarman/orgs","repos_url":"https://api.github.com/users/benjamincarman/repos","events_url":"https://api.github.com/users/benjamincarman/events{/privacy}","received_events_url":"https://api.github.com/users/benjamincarman/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T18:07:32Z","updated_at":"2018-11-01T18:07:32Z","author_association":"NONE","body":"If someone were to run the sample unit test directly with this Makefile, it would likely result in a string of errors due to the lack of specified C++11 compilation. The first few might appear as follows:\r\n\r\n<img width=\"824\" alt=\"firstgtesterrors\" src=\"https://user-images.githubusercontent.com/40589324/47867928-56e09280-ddd9-11e8-9f2a-dddf436df300.png\">\r\netc. etc.\r\n<img width=\"797\" alt=\"gtestfatalerror\" src=\"https://user-images.githubusercontent.com/40589324/47867935-5ba54680-ddd9-11e8-83bc-9caa48c72d7f.png\">\r\n\r\nSimply adding the C++11 flag to this makefile allows new users of Googletest the ability to quickly run its sample unit tests out of the box through this given Makefile, without any compilation errors."}}
{"actor":{"display_login":"benjamincarman"}}