{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/29102","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/29102/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/29102/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/29102/events","html_url":"https://github.com/JuliaLang/julia/pull/29102","id":358354032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTMwNjUy","number":29102,"title":"Change signatures that help is showing (revive #25672, fix #20064)","user":{"login":"thofma","id":11231648,"node_id":"MDQ6VXNlcjExMjMxNjQ4","avatar_url":"https://avatars0.githubusercontent.com/u/11231648?v=4","gravatar_id":"","url":"https://api.github.com/users/thofma","html_url":"https://github.com/thofma","followers_url":"https://api.github.com/users/thofma/followers","following_url":"https://api.github.com/users/thofma/following{/other_user}","gists_url":"https://api.github.com/users/thofma/gists{/gist_id}","starred_url":"https://api.github.com/users/thofma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thofma/subscriptions","organizations_url":"https://api.github.com/users/thofma/orgs","repos_url":"https://api.github.com/users/thofma/repos","events_url":"https://api.github.com/users/thofma/events{/privacy}","received_events_url":"https://api.github.com/users/thofma/received_events","type":"User","site_admin":false},"labels":[{"id":229907793,"node_id":"MDU6TGFiZWwyMjk5MDc3OTM=","url":"https://api.github.com/repos/JuliaLang/julia/labels/docsystem","name":"docsystem","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-09-09T06:29:17Z","updated_at":"2018-09-18T21:29:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/29102","html_url":"https://github.com/JuliaLang/julia/pull/29102","diff_url":"https://github.com/JuliaLang/julia/pull/29102.diff","patch_url":"https://github.com/JuliaLang/julia/pull/29102.patch"},"body":"This is a rebased version of #25672, which fixes the regression noticed in #20064.\r\n\r\nI hope you don't mind @KristofferC \r\n\r\nI used the check suggested by Jameson and added tests.\r\n\r\nHere is the old and new behavior\r\n\r\n### 1.0/master\r\n```julia\r\nhelp?> +(::Dates.Date, ::Dates.Time)\r\n  +(x, y...)\r\n\r\n  Addition operator. x+y+z+... calls this function with all arguments, i.e. +(x, y, z, ...).\r\n\r\n  Examples\r\n  ≡≡≡≡≡≡≡≡≡≡\r\n\r\n  julia> 1 + 20 + 4\r\n  25\r\n  \r\n  julia> +(1, 20, 4)\r\n  25\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  dt::Date + t::Time -> DateTime\r\n\r\n  The addition of a Date with a Time produces a DateTime. The hour, minute, second, and millisecond parts of\r\n  the Time are used along with the year, month, and day of the Date to create the new DateTime. Non-zero\r\n  microseconds or nanoseconds in the Time type will result in an InexactError being thrown.\r\n```\r\n\r\n### This PR\r\n```julia\r\nhelp?> +(::Dates.Date, ::Dates.Time)\r\n  dt::Date + t::Time -> DateTime\r\n\r\n  The addition of a Date with a Time produces a DateTime. The hour, minute, second, and millisecond parts of\r\n  the Time are used along with the year, month, and day of the Date to create the new DateTime. Non-zero\r\n  microseconds or nanoseconds in the Time type will result in an InexactError being thrown.\r\n```\r\n\r\nConsider\r\n```julia\r\n\"\"\"\r\nfoobar\r\n\"\"\"\r\nfunction foobar end\r\n\r\n\"\"\"\r\nNumber\r\n\"\"\"\r\nfoobar(x::Number) = x\r\n\r\n\"\"\"\r\nReal\r\n\"\"\"\r\nfoobar(x::Real) = x\r\n\r\n\r\n\"\"\"\r\nInt\r\n\"\"\"\r\nfoobar(x::Int) = x\r\n\r\n\r\n\"\"\"\r\nReal, Int\r\n\"\"\"\r\nfoobar(x::Real, y::Int) = x\r\n```\r\n\r\n### 1.0/master\r\n```julia\r\nhelp?> foobar(1)\r\n  Number\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Real\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Int\r\n\r\nhelp?> foobar(::Real)\r\n  Number\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Real\r\n\r\nhelp?> foobar(::Real, ::Real)\r\n  Number\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Real\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Int\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Real, Int\r\n```\r\n\r\n### This PR\r\n```julia\r\nhelp?> foobar(1)\r\n  Int\r\n\r\nhelp?> foobar(2.0)\r\n  Real\r\n\r\nhelp?> foobar(2.0, 1)\r\n  Real, Int\r\nhelp?> foobar(::Real)\r\n  Real\r\n\r\n  ───────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n\r\n  Int\r\n\r\nhelp?> foobar(::Real, ::Real)\r\n  Real, Int\r\n```\r\n\r\nShould be squashed when merged."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/422562382","html_url":"https://github.com/JuliaLang/julia/pull/29102#issuecomment-422562382","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/29102","id":422562382,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjU2MjM4Mg==","user":{"login":"mortenpi","id":147757,"node_id":"MDQ6VXNlcjE0Nzc1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/147757?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenpi","html_url":"https://github.com/mortenpi","followers_url":"https://api.github.com/users/mortenpi/followers","following_url":"https://api.github.com/users/mortenpi/following{/other_user}","gists_url":"https://api.github.com/users/mortenpi/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenpi/subscriptions","organizations_url":"https://api.github.com/users/mortenpi/orgs","repos_url":"https://api.github.com/users/mortenpi/repos","events_url":"https://api.github.com/users/mortenpi/events{/privacy}","received_events_url":"https://api.github.com/users/mortenpi/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T21:29:12Z","updated_at":"2018-09-18T21:29:12Z","author_association":"CONTRIBUTOR","body":"@thofma I am not actually very familiar the docsystem code in Documenter, but as a general principle, Documenter should behave similarly to the REPL I'd say. If there is / will be a difference between them, please do open an issue in Documenter for this. Or if you'd willing to PR the fix, that would be even more awesome.\r\n\r\nAlso, if we can offload as much of the docsystem logic to Base, instead of duplicating it in Documenter, that would be good too. There's maybe a reason why Documenter does not use `Docs.doc`, but I think it would be worth looking into if we can get rid of this apparently duplication."}}
{"actor":{"display_login":"mortenpi"}}