{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/579","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/579/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/579/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/579/events","html_url":"https://github.com/openshift/installer/pull/579","id":375744236,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTE5NDY1","number":579,"title":"WIP: cmd/openshift-install/create: Destroy bootstrap on bootstrap-complete","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959731323,"node_id":"MDU6TGFiZWw5NTk3MzEzMjM=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":959730581,"node_id":"MDU6TGFiZWw5NTk3MzA1ODE=","url":"https://api.github.com/repos/openshift/installer/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-31T00:01:51Z","updated_at":"2018-10-31T00:12:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/579","html_url":"https://github.com/openshift/installer/pull/579","diff_url":"https://github.com/openshift/installer/pull/579.diff","patch_url":"https://github.com/openshift/installer/pull/579.patch"},"body":"Builds on #574; review that first.\n\nOnce the cluster is up, the bootstrap stuff is just a waste of resources.  With this commit we make a reasonable effort to wait for the `bootstrap-complete` event, and, if we see it, we tear down the bootstrap resources.\n\nThe Kubernetes client initialization is based on [this example][1] and the local `wait.go` is based on kubernetes/kubernetes#50102.  Both of those are, like this project, under the Apache 2.0 license.  Once kubernetes/kubernetes#50102 lands, we can drop the local `wait.go` and use the upstream implementation.\n\nStill a few FIXME nits to deal with, but I thought I'd put it up for initial review.\n\n[1]: https://github.com/kubernetes/client-go/blob/v9.0.0/examples/out-of-cluster-client-configuration/main.go\n[2]: https://github.com/kubernetes/kubernetes/pull/50102/files"},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/434516190","html_url":"https://github.com/openshift/installer/pull/579#issuecomment-434516190","issue_url":"https://api.github.com/repos/openshift/installer/issues/579","id":434516190,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDUxNjE5MA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T00:12:27Z","updated_at":"2018-10-31T00:12:27Z","author_association":"NONE","body":"@wking: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/gofmt | ce15364a7f6d5fadc3f79304260053a4c07b9e9e | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/579/pull-ci-openshift-installer-master-gofmt/861) | `/test gofmt`\nci/prow/golint | ce15364a7f6d5fadc3f79304260053a4c07b9e9e | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/579/pull-ci-openshift-installer-master-golint/861) | `/test golint`\nci/prow/e2e-aws | ce15364a7f6d5fadc3f79304260053a4c07b9e9e | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/579/pull-ci-openshift-installer-master-e2e-aws/1026) | `/test e2e-aws`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_installer/579). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/wking). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/installer/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}