{"action":"created","comment":{"url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/comments/175383325","pull_request_review_id":104901063,"id":175383325,"diff_hunk":"@@ -154,23 +184,27 @@ bool CacheOrBust::Worker::do_get(\n \n   if (tokens.size() < 2)\n     return sess->printf(\"CLIENT_ERROR missing key\\r\\n\");\n-  if (tokens.size() < 3)","path":"ktcacheorbust.cc","position":93,"original_position":93,"commit_id":"7e5efdc7530029b6fa8d0943afd98d0229ca44db","original_commit_id":"7e5efdc7530029b6fa8d0943afd98d0229ca44db","user":{"login":"WolverineFan","id":676544,"avatar_url":"https://avatars3.githubusercontent.com/u/676544?v=4","gravatar_id":"","url":"https://api.github.com/users/WolverineFan","html_url":"https://github.com/WolverineFan","followers_url":"https://api.github.com/users/WolverineFan/followers","following_url":"https://api.github.com/users/WolverineFan/following{/other_user}","gists_url":"https://api.github.com/users/WolverineFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WolverineFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WolverineFan/subscriptions","organizations_url":"https://api.github.com/users/WolverineFan/orgs","repos_url":"https://api.github.com/users/WolverineFan/repos","events_url":"https://api.github.com/users/WolverineFan/events{/privacy}","received_events_url":"https://api.github.com/users/WolverineFan/received_events","type":"User","site_admin":false},"body":"It happens later","created_at":"2018-03-19T10:15:50Z","updated_at":"2018-03-19T10:15:50Z","html_url":"https://github.com/Magnetic/cacheorbust/pull/1#discussion_r175383325","pull_request_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/comments/175383325"},"html":{"href":"https://github.com/Magnetic/cacheorbust/pull/1#discussion_r175383325"},"pull_request":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1"}},"in_reply_to_id":175348817},"pull_request":{"url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1","id":175118916,"html_url":"https://github.com/Magnetic/cacheorbust/pull/1","diff_url":"https://github.com/Magnetic/cacheorbust/pull/1.diff","patch_url":"https://github.com/Magnetic/cacheorbust/pull/1.patch","issue_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/1","number":1,"state":"open","locked":false,"title":"API alterations for mcrouter","user":{"login":"WolverineFan","id":676544,"avatar_url":"https://avatars3.githubusercontent.com/u/676544?v=4","gravatar_id":"","url":"https://api.github.com/users/WolverineFan","html_url":"https://github.com/WolverineFan","followers_url":"https://api.github.com/users/WolverineFan/followers","following_url":"https://api.github.com/users/WolverineFan/following{/other_user}","gists_url":"https://api.github.com/users/WolverineFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WolverineFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WolverineFan/subscriptions","organizations_url":"https://api.github.com/users/WolverineFan/orgs","repos_url":"https://api.github.com/users/WolverineFan/repos","events_url":"https://api.github.com/users/WolverineFan/events{/privacy}","received_events_url":"https://api.github.com/users/WolverineFan/received_events","type":"User","site_admin":false},"body":"* Add support for setting a `url_prefix` in the cacheorbust config instead of having to pass 2 parameters to `get` (which mcrouter doesn't support)\r\n* Added support for stripping a leading `strip_prefix` from the key so we can use mcrouter's prefix routing \r\n* Add support for `version` (which seems to be used by mcrouter to check health)\r\nto direct keys to different pools\r\n* Add support for `log_keys` which will log keys to INFO\r\n* Print out the settings on startup\r\n* Bump version to 0.4.0\r\n","created_at":"2018-03-15T00:19:11Z","updated_at":"2018-03-19T10:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41c5eb4b4cf9eed830bc17549355c75fdf8ed73e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/1/comments","statuses_url":"https://api.github.com/repos/Magnetic/cacheorbust/statuses/7e5efdc7530029b6fa8d0943afd98d0229ca44db","head":{"label":"Magnetic:jy-mcrouter-compatibility","ref":"jy-mcrouter-compatibility","sha":"7e5efdc7530029b6fa8d0943afd98d0229ca44db","user":{"login":"Magnetic","id":414543,"avatar_url":"https://avatars1.githubusercontent.com/u/414543?v=4","gravatar_id":"","url":"https://api.github.com/users/Magnetic","html_url":"https://github.com/Magnetic","followers_url":"https://api.github.com/users/Magnetic/followers","following_url":"https://api.github.com/users/Magnetic/following{/other_user}","gists_url":"https://api.github.com/users/Magnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetic/subscriptions","organizations_url":"https://api.github.com/users/Magnetic/orgs","repos_url":"https://api.github.com/users/Magnetic/repos","events_url":"https://api.github.com/users/Magnetic/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetic/received_events","type":"Organization","site_admin":false},"repo":{"id":36449561,"name":"cacheorbust","full_name":"Magnetic/cacheorbust","owner":{"login":"Magnetic","id":414543,"avatar_url":"https://avatars1.githubusercontent.com/u/414543?v=4","gravatar_id":"","url":"https://api.github.com/users/Magnetic","html_url":"https://github.com/Magnetic","followers_url":"https://api.github.com/users/Magnetic/followers","following_url":"https://api.github.com/users/Magnetic/following{/other_user}","gists_url":"https://api.github.com/users/Magnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetic/subscriptions","organizations_url":"https://api.github.com/users/Magnetic/orgs","repos_url":"https://api.github.com/users/Magnetic/repos","events_url":"https://api.github.com/users/Magnetic/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Magnetic/cacheorbust","description":null,"fork":false,"url":"https://api.github.com/repos/Magnetic/cacheorbust","forks_url":"https://api.github.com/repos/Magnetic/cacheorbust/forks","keys_url":"https://api.github.com/repos/Magnetic/cacheorbust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magnetic/cacheorbust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magnetic/cacheorbust/teams","hooks_url":"https://api.github.com/repos/Magnetic/cacheorbust/hooks","issue_events_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/events{/number}","events_url":"https://api.github.com/repos/Magnetic/cacheorbust/events","assignees_url":"https://api.github.com/repos/Magnetic/cacheorbust/assignees{/user}","branches_url":"https://api.github.com/repos/Magnetic/cacheorbust/branches{/branch}","tags_url":"https://api.github.com/repos/Magnetic/cacheorbust/tags","blobs_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magnetic/cacheorbust/statuses/{sha}","languages_url":"https://api.github.com/repos/Magnetic/cacheorbust/languages","stargazers_url":"https://api.github.com/repos/Magnetic/cacheorbust/stargazers","contributors_url":"https://api.github.com/repos/Magnetic/cacheorbust/contributors","subscribers_url":"https://api.github.com/repos/Magnetic/cacheorbust/subscribers","subscription_url":"https://api.github.com/repos/Magnetic/cacheorbust/subscription","commits_url":"https://api.github.com/repos/Magnetic/cacheorbust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magnetic/cacheorbust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magnetic/cacheorbust/contents/{+path}","compare_url":"https://api.github.com/repos/Magnetic/cacheorbust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magnetic/cacheorbust/merges","archive_url":"https://api.github.com/repos/Magnetic/cacheorbust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magnetic/cacheorbust/downloads","issues_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues{/number}","pulls_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls{/number}","milestones_url":"https://api.github.com/repos/Magnetic/cacheorbust/milestones{/number}","notifications_url":"https://api.github.com/repos/Magnetic/cacheorbust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magnetic/cacheorbust/labels{/name}","releases_url":"https://api.github.com/repos/Magnetic/cacheorbust/releases{/id}","deployments_url":"https://api.github.com/repos/Magnetic/cacheorbust/deployments","created_at":"2015-05-28T15:55:12Z","updated_at":"2018-03-15T21:04:35Z","pushed_at":"2018-03-15T21:10:44Z","git_url":"git://github.com/Magnetic/cacheorbust.git","ssh_url":"git@github.com:Magnetic/cacheorbust.git","clone_url":"https://github.com/Magnetic/cacheorbust.git","svn_url":"https://github.com/Magnetic/cacheorbust","homepage":null,"size":283,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Magnetic:master","ref":"master","sha":"e86d1cf058ec7c6269211f733d33e1faef027998","user":{"login":"Magnetic","id":414543,"avatar_url":"https://avatars1.githubusercontent.com/u/414543?v=4","gravatar_id":"","url":"https://api.github.com/users/Magnetic","html_url":"https://github.com/Magnetic","followers_url":"https://api.github.com/users/Magnetic/followers","following_url":"https://api.github.com/users/Magnetic/following{/other_user}","gists_url":"https://api.github.com/users/Magnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetic/subscriptions","organizations_url":"https://api.github.com/users/Magnetic/orgs","repos_url":"https://api.github.com/users/Magnetic/repos","events_url":"https://api.github.com/users/Magnetic/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetic/received_events","type":"Organization","site_admin":false},"repo":{"id":36449561,"name":"cacheorbust","full_name":"Magnetic/cacheorbust","owner":{"login":"Magnetic","id":414543,"avatar_url":"https://avatars1.githubusercontent.com/u/414543?v=4","gravatar_id":"","url":"https://api.github.com/users/Magnetic","html_url":"https://github.com/Magnetic","followers_url":"https://api.github.com/users/Magnetic/followers","following_url":"https://api.github.com/users/Magnetic/following{/other_user}","gists_url":"https://api.github.com/users/Magnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnetic/subscriptions","organizations_url":"https://api.github.com/users/Magnetic/orgs","repos_url":"https://api.github.com/users/Magnetic/repos","events_url":"https://api.github.com/users/Magnetic/events{/privacy}","received_events_url":"https://api.github.com/users/Magnetic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Magnetic/cacheorbust","description":null,"fork":false,"url":"https://api.github.com/repos/Magnetic/cacheorbust","forks_url":"https://api.github.com/repos/Magnetic/cacheorbust/forks","keys_url":"https://api.github.com/repos/Magnetic/cacheorbust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magnetic/cacheorbust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magnetic/cacheorbust/teams","hooks_url":"https://api.github.com/repos/Magnetic/cacheorbust/hooks","issue_events_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/events{/number}","events_url":"https://api.github.com/repos/Magnetic/cacheorbust/events","assignees_url":"https://api.github.com/repos/Magnetic/cacheorbust/assignees{/user}","branches_url":"https://api.github.com/repos/Magnetic/cacheorbust/branches{/branch}","tags_url":"https://api.github.com/repos/Magnetic/cacheorbust/tags","blobs_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magnetic/cacheorbust/statuses/{sha}","languages_url":"https://api.github.com/repos/Magnetic/cacheorbust/languages","stargazers_url":"https://api.github.com/repos/Magnetic/cacheorbust/stargazers","contributors_url":"https://api.github.com/repos/Magnetic/cacheorbust/contributors","subscribers_url":"https://api.github.com/repos/Magnetic/cacheorbust/subscribers","subscription_url":"https://api.github.com/repos/Magnetic/cacheorbust/subscription","commits_url":"https://api.github.com/repos/Magnetic/cacheorbust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magnetic/cacheorbust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magnetic/cacheorbust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magnetic/cacheorbust/contents/{+path}","compare_url":"https://api.github.com/repos/Magnetic/cacheorbust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magnetic/cacheorbust/merges","archive_url":"https://api.github.com/repos/Magnetic/cacheorbust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magnetic/cacheorbust/downloads","issues_url":"https://api.github.com/repos/Magnetic/cacheorbust/issues{/number}","pulls_url":"https://api.github.com/repos/Magnetic/cacheorbust/pulls{/number}","milestones_url":"https://api.github.com/repos/Magnetic/cacheorbust/milestones{/number}","notifications_url":"https://api.github.com/repos/Magnetic/cacheorbust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magnetic/cacheorbust/labels{/name}","releases_url":"https://api.github.com/repos/Magnetic/cacheorbust/releases{/id}","deployments_url":"https://api.github.com/repos/Magnetic/cacheorbust/deployments","created_at":"2015-05-28T15:55:12Z","updated_at":"2018-03-15T21:04:35Z","pushed_at":"2018-03-15T21:10:44Z","git_url":"git://github.com/Magnetic/cacheorbust.git","ssh_url":"git@github.com:Magnetic/cacheorbust.git","clone_url":"https://github.com/Magnetic/cacheorbust.git","svn_url":"https://github.com/Magnetic/cacheorbust","homepage":null,"size":283,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1"},"html":{"href":"https://github.com/Magnetic/cacheorbust/pull/1"},"issue":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/issues/1"},"comments":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Magnetic/cacheorbust/statuses/7e5efdc7530029b6fa8d0943afd98d0229ca44db"}},"author_association":"NONE"}}
{"actor":{"display_login":"WolverineFan"}}