{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-http/pulls/comments/173083333","pull_request_review_id":102209941,"id":173083333,"diff_hunk":"@@ -0,0 +1,61 @@\n+/*\n+ * Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com>\n+ */\n+\n+package docs\n+\n+import java.lang.reflect.Method\n+\n+import akka.annotation.ApiMayChange\n+import org.reflections.Reflections\n+import org.reflections.scanners.{ MethodAnnotationsScanner, TypeAnnotationsScanner }\n+import org.reflections.util.{ ClasspathHelper, ConfigurationBuilder }\n+import org.scalatest.{ Matchers, WordSpec }\n+\n+import scala.collection.JavaConverters._\n+import scala.collection.mutable\n+import scala.io.Source\n+\n+class ApiMayChangeDocCheckerSpec extends WordSpec with Matchers {\n+\n+  def prettifyName(clazz: Class[_]): String = {\n+    clazz.getCanonicalName.replaceAll(\"\\\\$minus\", \"-\").split(\"\\\\$\")(0)\n+  }\n+\n+  // As Specs, Directives and HttpApp inherit get all directives methods, we skip those as they are not really bringing any extra info\n+  def removeClassesToIgnore(method: Method): Boolean = {\n+    Seq(\"Spec\", \".Directives\", \".HttpApp\").exists(method.getDeclaringClass.getCanonicalName.contains)\n+  }\n+\n+  def collectMissing(docPage: Seq[String])(set: Set[String], name: String): Set[String] = {\n+    if (docPage.exists(line => line.contains(name)))\n+      set\n+    else\n+      set + name\n+  }\n+\n+  \"compatibility-guidelines.md doc page\" should {\n+    val reflections = new Reflections(new ConfigurationBuilder()\n+      .setUrls(ClasspathHelper.forPackage(\"akka.http\"))\n+      .setScanners(\n+        new TypeAnnotationsScanner(),\n+        new MethodAnnotationsScanner()))\n+    val docPage = Source.fromFile(\"docs/src/main/paradox/compatibility-guidelines.md\").getLines().toList","path":"docs/src/test/scala/docs/ApiMayChangeDocCheckerSpec.scala","position":51,"original_position":43,"commit_id":"34285a6db9504ee2d5424c9e8515c308ba5782c9","original_commit_id":"3810fcfde4501434188ce48801bd59533f319358","user":{"login":"jlprat","id":3337739,"avatar_url":"https://avatars0.githubusercontent.com/u/3337739?v=4","gravatar_id":"","url":"https://api.github.com/users/jlprat","html_url":"https://github.com/jlprat","followers_url":"https://api.github.com/users/jlprat/followers","following_url":"https://api.github.com/users/jlprat/following{/other_user}","gists_url":"https://api.github.com/users/jlprat/gists{/gist_id}","starred_url":"https://api.github.com/users/jlprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlprat/subscriptions","organizations_url":"https://api.github.com/users/jlprat/orgs","repos_url":"https://api.github.com/users/jlprat/repos","events_url":"https://api.github.com/users/jlprat/events{/privacy}","received_events_url":"https://api.github.com/users/jlprat/received_events","type":"User","site_admin":false},"body":"I think it should be closed, you are right","created_at":"2018-03-08T07:43:12Z","updated_at":"2018-03-08T07:43:12Z","html_url":"https://github.com/akka/akka-http/pull/1910#discussion_r173083333","pull_request_url":"https://api.github.com/repos/akka/akka-http/pulls/1910","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments/173083333"},"html":{"href":"https://github.com/akka/akka-http/pull/1910#discussion_r173083333"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1910"}},"in_reply_to_id":173042453},"pull_request":{"url":"https://api.github.com/repos/akka/akka-http/pulls/1910","id":173495615,"html_url":"https://github.com/akka/akka-http/pull/1910","diff_url":"https://github.com/akka/akka-http/pull/1910.diff","patch_url":"https://github.com/akka/akka-http/pull/1910.patch","issue_url":"https://api.github.com/repos/akka/akka-http/issues/1910","number":1910,"state":"open","locked":false,"title":"List APIs that may change #1106","user":{"login":"jlprat","id":3337739,"avatar_url":"https://avatars0.githubusercontent.com/u/3337739?v=4","gravatar_id":"","url":"https://api.github.com/users/jlprat","html_url":"https://github.com/jlprat","followers_url":"https://api.github.com/users/jlprat/followers","following_url":"https://api.github.com/users/jlprat/following{/other_user}","gists_url":"https://api.github.com/users/jlprat/gists{/gist_id}","starred_url":"https://api.github.com/users/jlprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlprat/subscriptions","organizations_url":"https://api.github.com/users/jlprat/orgs","repos_url":"https://api.github.com/users/jlprat/repos","events_url":"https://api.github.com/users/jlprat/events{/privacy}","received_events_url":"https://api.github.com/users/jlprat/received_events","type":"User","site_admin":false},"body":"Refs: #1106\r\nAdd the list of APIs that are marked as `@ApiMayChange`","created_at":"2018-03-07T16:00:27Z","updated_at":"2018-03-08T07:43:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"386469c0e5e854c615b50a6707ce3eeb3c3404d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":436853346,"url":"https://api.github.com/repos/akka/akka-http/labels/2%20-%20pick%20next","name":"2 - pick next","color":"1d76db","default":false},{"id":441434590,"url":"https://api.github.com/repos/akka/akka-http/labels/validating","name":"validating","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-http/pulls/1910/commits","review_comments_url":"https://api.github.com/repos/akka/akka-http/pulls/1910/comments","review_comment_url":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-http/issues/1910/comments","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/34285a6db9504ee2d5424c9e8515c308ba5782c9","head":{"label":"jlprat:non-stable-components","ref":"non-stable-components","sha":"34285a6db9504ee2d5424c9e8515c308ba5782c9","user":{"login":"jlprat","id":3337739,"avatar_url":"https://avatars0.githubusercontent.com/u/3337739?v=4","gravatar_id":"","url":"https://api.github.com/users/jlprat","html_url":"https://github.com/jlprat","followers_url":"https://api.github.com/users/jlprat/followers","following_url":"https://api.github.com/users/jlprat/following{/other_user}","gists_url":"https://api.github.com/users/jlprat/gists{/gist_id}","starred_url":"https://api.github.com/users/jlprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlprat/subscriptions","organizations_url":"https://api.github.com/users/jlprat/orgs","repos_url":"https://api.github.com/users/jlprat/repos","events_url":"https://api.github.com/users/jlprat/events{/privacy}","received_events_url":"https://api.github.com/users/jlprat/received_events","type":"User","site_admin":false},"repo":{"id":72833610,"name":"akka-http","full_name":"jlprat/akka-http","owner":{"login":"jlprat","id":3337739,"avatar_url":"https://avatars0.githubusercontent.com/u/3337739?v=4","gravatar_id":"","url":"https://api.github.com/users/jlprat","html_url":"https://github.com/jlprat","followers_url":"https://api.github.com/users/jlprat/followers","following_url":"https://api.github.com/users/jlprat/following{/other_user}","gists_url":"https://api.github.com/users/jlprat/gists{/gist_id}","starred_url":"https://api.github.com/users/jlprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlprat/subscriptions","organizations_url":"https://api.github.com/users/jlprat/orgs","repos_url":"https://api.github.com/users/jlprat/repos","events_url":"https://api.github.com/users/jlprat/events{/privacy}","received_events_url":"https://api.github.com/users/jlprat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlprat/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":true,"url":"https://api.github.com/repos/jlprat/akka-http","forks_url":"https://api.github.com/repos/jlprat/akka-http/forks","keys_url":"https://api.github.com/repos/jlprat/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlprat/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlprat/akka-http/teams","hooks_url":"https://api.github.com/repos/jlprat/akka-http/hooks","issue_events_url":"https://api.github.com/repos/jlprat/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/jlprat/akka-http/events","assignees_url":"https://api.github.com/repos/jlprat/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/jlprat/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/jlprat/akka-http/tags","blobs_url":"https://api.github.com/repos/jlprat/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlprat/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlprat/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlprat/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlprat/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/jlprat/akka-http/languages","stargazers_url":"https://api.github.com/repos/jlprat/akka-http/stargazers","contributors_url":"https://api.github.com/repos/jlprat/akka-http/contributors","subscribers_url":"https://api.github.com/repos/jlprat/akka-http/subscribers","subscription_url":"https://api.github.com/repos/jlprat/akka-http/subscription","commits_url":"https://api.github.com/repos/jlprat/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlprat/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlprat/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlprat/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlprat/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/jlprat/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlprat/akka-http/merges","archive_url":"https://api.github.com/repos/jlprat/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlprat/akka-http/downloads","issues_url":"https://api.github.com/repos/jlprat/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/jlprat/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/jlprat/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/jlprat/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlprat/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/jlprat/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/jlprat/akka-http/deployments","created_at":"2016-11-04T09:34:08Z","updated_at":"2016-11-04T09:34:10Z","pushed_at":"2018-03-08T07:36:27Z","git_url":"git://github.com/jlprat/akka-http.git","ssh_url":"git@github.com:jlprat/akka-http.git","clone_url":"https://github.com/jlprat/akka-http.git","svn_url":"https://github.com/jlprat/akka-http","homepage":"http://akka.io","size":11205,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"59e5fdb24c6b6457b9b3156abfa652f32a4fd4b1","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":66077955,"name":"akka-http","full_name":"akka/akka-http","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":false,"url":"https://api.github.com/repos/akka/akka-http","forks_url":"https://api.github.com/repos/akka/akka-http/forks","keys_url":"https://api.github.com/repos/akka/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-http/teams","hooks_url":"https://api.github.com/repos/akka/akka-http/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-http/events","assignees_url":"https://api.github.com/repos/akka/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-http/tags","blobs_url":"https://api.github.com/repos/akka/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-http/languages","stargazers_url":"https://api.github.com/repos/akka/akka-http/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-http/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-http/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-http/subscription","commits_url":"https://api.github.com/repos/akka/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-http/merges","archive_url":"https://api.github.com/repos/akka/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-http/downloads","issues_url":"https://api.github.com/repos/akka/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-http/deployments","created_at":"2016-08-19T11:33:36Z","updated_at":"2018-03-08T01:25:14Z","pushed_at":"2018-03-08T07:36:29Z","git_url":"git://github.com/akka/akka-http.git","ssh_url":"git@github.com:akka/akka-http.git","clone_url":"https://github.com/akka/akka-http.git","svn_url":"https://github.com/akka/akka-http","homepage":"http://akka.io","size":9831,"stargazers_count":608,"watchers_count":608,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":282,"mirror_url":null,"archived":false,"open_issues_count":454,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":282,"open_issues":454,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1910"},"html":{"href":"https://github.com/akka/akka-http/pull/1910"},"issue":{"href":"https://api.github.com/repos/akka/akka-http/issues/1910"},"comments":{"href":"https://api.github.com/repos/akka/akka-http/issues/1910/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1910/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1910/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-http/statuses/34285a6db9504ee2d5424c9e8515c308ba5782c9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlprat"}}