{"action":"created","comment":{"url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments/213821793","pull_request_review_id":150708046,"id":213821793,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzgyMTc5Mw==","diff_hunk":"@@ -0,0 +1,131 @@\n+/*\n+Copyright 2018 Pressinfra SRL\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package mysqlcluster\n+\n+import (\n+\t\"k8s.io/apimachinery/pkg/util/intstr\"\n+)\n+\n+const (\n+\t// MysqlPortName represents the mysql port name.\n+\tMysqlPortName = \"mysql\"\n+\t// MysqlPort is the default mysql port.\n+\tMysqlPort = 3306\n+\n+\t// HelperXtrabackupPortName is name of the port on which we take backups\n+\tHelperXtrabackupPortName = \"xtrabackup\"\n+\t// HelperXtrabackupPort is the port on which we serve backups\n+\tHelperXtrabackupPort = 3307\n+\n+\t// OrcTopologyDir path where orc conf secret is mounted\n+\tOrcTopologyDir = \"/var/run/orc-topology\"\n+\n+\trStrLen = 18\n+\n+\t// ConfigVersion is the mysql config that needs to be updated if configs\n+\t// change\n+\tConfigVersion = \"2018-03-23:12:33\"\n+\n+\t// HelperServerPort represents the port on which http server will run\n+\tHelperServerPort = 8088\n+\t// HelperServerProbePath the probe path\n+\tHelperServerProbePath = \"/health\"\n+\n+\t//ExporterPortName the name of the metrics exporter port\n+\tExporterPortName = \"prometheus\"\n+\t// ExporterPort is the port on which metrics exporter expose metrics\n+\tExporterPort = 9104\n+\t// ExporterPath is the path on which metrics are expose\n+\tExporterPath = \"/metrics\"\n+\n+\t// HelperDbName represent the database name that is used by operator to\n+\t// manage the mysql cluster. This database contains a table with\n+\t// initialization history and table managed by pt-heartbeat. Be aware that\n+\t// when changeing this value to update the orchestrator chart value for\n+\t// SlaveLagQuery in hack/charts/mysql-operator/values.yaml.\n+\tHelperDbName = \"sys_operator\"\n+)\n+\n+var (\n+\t// TargetPort is the mysql port that is set for headless service and should be string\n+\tTargetPort = intstr.FromInt(MysqlPort)\n+\t// ExporterTargetPort is the port on which metrics exporter expose metrics\n+\tExporterTargetPort = intstr.FromInt(ExporterPort)\n+\n+\t// MysqlMasterSlaveConfigs contains configs for both master and slave\n+\tMysqlMasterSlaveConfigs = map[string]string{","path":"pkg/syncers/mysqlcluster/settings.go","position":70,"original_position":70,"commit_id":"1f7491047b86ead4e9aecdb3785a7f7c35c78a5b","original_commit_id":"1f7491047b86ead4e9aecdb3785a7f7c35c78a5b","user":{"login":"calind","id":266375,"node_id":"MDQ6VXNlcjI2NjM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266375?v=4","gravatar_id":"","url":"https://api.github.com/users/calind","html_url":"https://github.com/calind","followers_url":"https://api.github.com/users/calind/followers","following_url":"https://api.github.com/users/calind/following{/other_user}","gists_url":"https://api.github.com/users/calind/gists{/gist_id}","starred_url":"https://api.github.com/users/calind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calind/subscriptions","organizations_url":"https://api.github.com/users/calind/orgs","repos_url":"https://api.github.com/users/calind/repos","events_url":"https://api.github.com/users/calind/events{/privacy}","received_events_url":"https://api.github.com/users/calind/received_events","type":"User","site_admin":false},"body":"These should stay in `pkg/apis/mysql/v1alpha1/mysqlcluster_defaults.go`","created_at":"2018-08-29T20:25:20Z","updated_at":"2018-08-29T20:42:33Z","html_url":"https://github.com/presslabs/mysql-operator/pull/109#discussion_r213821793","pull_request_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments/213821793"},"html":{"href":"https://github.com/presslabs/mysql-operator/pull/109#discussion_r213821793"},"pull_request":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109","id":211717876,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzE3ODc2","html_url":"https://github.com/presslabs/mysql-operator/pull/109","diff_url":"https://github.com/presslabs/mysql-operator/pull/109.diff","patch_url":"https://github.com/presslabs/mysql-operator/pull/109.patch","issue_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/109","number":109,"state":"open","locked":false,"title":"[kubebuilder] Add mysqlcluster controller","user":{"login":"AMecea","id":11756727,"node_id":"MDQ6VXNlcjExNzU2NzI3","avatar_url":"https://avatars3.githubusercontent.com/u/11756727?v=4","gravatar_id":"","url":"https://api.github.com/users/AMecea","html_url":"https://github.com/AMecea","followers_url":"https://api.github.com/users/AMecea/followers","following_url":"https://api.github.com/users/AMecea/following{/other_user}","gists_url":"https://api.github.com/users/AMecea/gists{/gist_id}","starred_url":"https://api.github.com/users/AMecea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMecea/subscriptions","organizations_url":"https://api.github.com/users/AMecea/orgs","repos_url":"https://api.github.com/users/AMecea/repos","events_url":"https://api.github.com/users/AMecea/events{/privacy}","received_events_url":"https://api.github.com/users/AMecea/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-29T11:22:18Z","updated_at":"2018-08-29T20:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d905cdf7847a17b8407d8124cb4c22ec441feaca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109/commits","review_comments_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109/comments","review_comment_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/109/comments","statuses_url":"https://api.github.com/repos/presslabs/mysql-operator/statuses/1f7491047b86ead4e9aecdb3785a7f7c35c78a5b","head":{"label":"presslabs:kb-mc-1","ref":"kb-mc-1","sha":"1f7491047b86ead4e9aecdb3785a7f7c35c78a5b","user":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":109712767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MTI3Njc=","name":"mysql-operator","full_name":"presslabs/mysql-operator","owner":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/presslabs/mysql-operator","description":"Bulletproof MySQL on Kubernetes","fork":false,"url":"https://api.github.com/repos/presslabs/mysql-operator","forks_url":"https://api.github.com/repos/presslabs/mysql-operator/forks","keys_url":"https://api.github.com/repos/presslabs/mysql-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/presslabs/mysql-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/presslabs/mysql-operator/teams","hooks_url":"https://api.github.com/repos/presslabs/mysql-operator/hooks","issue_events_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/events{/number}","events_url":"https://api.github.com/repos/presslabs/mysql-operator/events","assignees_url":"https://api.github.com/repos/presslabs/mysql-operator/assignees{/user}","branches_url":"https://api.github.com/repos/presslabs/mysql-operator/branches{/branch}","tags_url":"https://api.github.com/repos/presslabs/mysql-operator/tags","blobs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/presslabs/mysql-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/presslabs/mysql-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/presslabs/mysql-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/presslabs/mysql-operator/languages","stargazers_url":"https://api.github.com/repos/presslabs/mysql-operator/stargazers","contributors_url":"https://api.github.com/repos/presslabs/mysql-operator/contributors","subscribers_url":"https://api.github.com/repos/presslabs/mysql-operator/subscribers","subscription_url":"https://api.github.com/repos/presslabs/mysql-operator/subscription","commits_url":"https://api.github.com/repos/presslabs/mysql-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/presslabs/mysql-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/presslabs/mysql-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/presslabs/mysql-operator/contents/{+path}","compare_url":"https://api.github.com/repos/presslabs/mysql-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/presslabs/mysql-operator/merges","archive_url":"https://api.github.com/repos/presslabs/mysql-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/presslabs/mysql-operator/downloads","issues_url":"https://api.github.com/repos/presslabs/mysql-operator/issues{/number}","pulls_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/presslabs/mysql-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/presslabs/mysql-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/presslabs/mysql-operator/labels{/name}","releases_url":"https://api.github.com/repos/presslabs/mysql-operator/releases{/id}","deployments_url":"https://api.github.com/repos/presslabs/mysql-operator/deployments","created_at":"2017-11-06T15:24:51Z","updated_at":"2018-08-29T18:13:06Z","pushed_at":"2018-08-29T14:21:18Z","git_url":"git://github.com/presslabs/mysql-operator.git","ssh_url":"git@github.com:presslabs/mysql-operator.git","clone_url":"https://github.com/presslabs/mysql-operator.git","svn_url":"https://github.com/presslabs/mysql-operator","homepage":"https://www.presslabs.com","size":42156,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":29,"watchers":36,"default_branch":"master"}},"base":{"label":"presslabs:kubebuilder","ref":"kubebuilder","sha":"0e92dd3c40bc3ac0f837c3ff77bb8bf7929ea338","user":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":109712767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MTI3Njc=","name":"mysql-operator","full_name":"presslabs/mysql-operator","owner":{"login":"presslabs","id":1033395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1033395?v=4","gravatar_id":"","url":"https://api.github.com/users/presslabs","html_url":"https://github.com/presslabs","followers_url":"https://api.github.com/users/presslabs/followers","following_url":"https://api.github.com/users/presslabs/following{/other_user}","gists_url":"https://api.github.com/users/presslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/presslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presslabs/subscriptions","organizations_url":"https://api.github.com/users/presslabs/orgs","repos_url":"https://api.github.com/users/presslabs/repos","events_url":"https://api.github.com/users/presslabs/events{/privacy}","received_events_url":"https://api.github.com/users/presslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/presslabs/mysql-operator","description":"Bulletproof MySQL on Kubernetes","fork":false,"url":"https://api.github.com/repos/presslabs/mysql-operator","forks_url":"https://api.github.com/repos/presslabs/mysql-operator/forks","keys_url":"https://api.github.com/repos/presslabs/mysql-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/presslabs/mysql-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/presslabs/mysql-operator/teams","hooks_url":"https://api.github.com/repos/presslabs/mysql-operator/hooks","issue_events_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/events{/number}","events_url":"https://api.github.com/repos/presslabs/mysql-operator/events","assignees_url":"https://api.github.com/repos/presslabs/mysql-operator/assignees{/user}","branches_url":"https://api.github.com/repos/presslabs/mysql-operator/branches{/branch}","tags_url":"https://api.github.com/repos/presslabs/mysql-operator/tags","blobs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/presslabs/mysql-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/presslabs/mysql-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/presslabs/mysql-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/presslabs/mysql-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/presslabs/mysql-operator/languages","stargazers_url":"https://api.github.com/repos/presslabs/mysql-operator/stargazers","contributors_url":"https://api.github.com/repos/presslabs/mysql-operator/contributors","subscribers_url":"https://api.github.com/repos/presslabs/mysql-operator/subscribers","subscription_url":"https://api.github.com/repos/presslabs/mysql-operator/subscription","commits_url":"https://api.github.com/repos/presslabs/mysql-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/presslabs/mysql-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/presslabs/mysql-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/presslabs/mysql-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/presslabs/mysql-operator/contents/{+path}","compare_url":"https://api.github.com/repos/presslabs/mysql-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/presslabs/mysql-operator/merges","archive_url":"https://api.github.com/repos/presslabs/mysql-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/presslabs/mysql-operator/downloads","issues_url":"https://api.github.com/repos/presslabs/mysql-operator/issues{/number}","pulls_url":"https://api.github.com/repos/presslabs/mysql-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/presslabs/mysql-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/presslabs/mysql-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/presslabs/mysql-operator/labels{/name}","releases_url":"https://api.github.com/repos/presslabs/mysql-operator/releases{/id}","deployments_url":"https://api.github.com/repos/presslabs/mysql-operator/deployments","created_at":"2017-11-06T15:24:51Z","updated_at":"2018-08-29T18:13:06Z","pushed_at":"2018-08-29T14:21:18Z","git_url":"git://github.com/presslabs/mysql-operator.git","ssh_url":"git@github.com:presslabs/mysql-operator.git","clone_url":"https://github.com/presslabs/mysql-operator.git","svn_url":"https://github.com/presslabs/mysql-operator","homepage":"https://www.presslabs.com","size":42156,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":29,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109"},"html":{"href":"https://github.com/presslabs/mysql-operator/pull/109"},"issue":{"href":"https://api.github.com/repos/presslabs/mysql-operator/issues/109"},"comments":{"href":"https://api.github.com/repos/presslabs/mysql-operator/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/presslabs/mysql-operator/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/presslabs/mysql-operator/statuses/1f7491047b86ead4e9aecdb3785a7f7c35c78a5b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"calind"}}