{"action":"created","issue":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/171","repository_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding","labels_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/171/comments","events_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/171/events","html_url":"https://github.com/prysmaticlabs/geth-sharding/pull/171","id":331447488,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTczMjU3","number":171,"title":"Random transaction generator","user":{"login":"rawfalafel","id":202157,"node_id":"MDQ6VXNlcjIwMjE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/202157?v=4","gravatar_id":"","url":"https://api.github.com/users/rawfalafel","html_url":"https://github.com/rawfalafel","followers_url":"https://api.github.com/users/rawfalafel/followers","following_url":"https://api.github.com/users/rawfalafel/following{/other_user}","gists_url":"https://api.github.com/users/rawfalafel/gists{/gist_id}","starred_url":"https://api.github.com/users/rawfalafel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawfalafel/subscriptions","organizations_url":"https://api.github.com/users/rawfalafel/orgs","repos_url":"https://api.github.com/users/rawfalafel/repos","events_url":"https://api.github.com/users/rawfalafel/events{/privacy}","received_events_url":"https://api.github.com/users/rawfalafel/received_events","type":"User","site_admin":false},"labels":[{"id":829519703,"node_id":"MDU6TGFiZWw4Mjk1MTk3MDM=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/In%20Progress","name":"In Progress","color":"bfdadc","default":false},{"id":878285942,"node_id":"MDU6TGFiZWw4NzgyODU5NDI=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Phase%201","name":"Phase 1","color":"31edab","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-12T05:57:38Z","updated_at":"2018-06-13T07:43:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/171","html_url":"https://github.com/prysmaticlabs/geth-sharding/pull/171","diff_url":"https://github.com/prysmaticlabs/geth-sharding/pull/171.diff","patch_url":"https://github.com/prysmaticlabs/geth-sharding/pull/171.patch"},"body":":wave: this PR isn't ready for review yet but I need help defining the requirements for this PR. \r\n\r\nWhat kind of transactions should get sent through the feed? This branch just throws a random byte array into a `types.Transaction` object. Should the generator be smarter in order to target specific code paths on the other side of the event feed?\r\n\r\nAlso, should the generator be configurable? Would be nice if we could send transactions from `geth console` by having it read transactions from a JSON file. @rauljordan also mentioned making the intervals more random.\r\n\r\n#125, #161, and possibly others could take advantage of a transaction generator but the requirements aren't clear to me, so I'm leaning towards keeping this simple and extensible for the next dev."},"comment":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/comments/396845605","html_url":"https://github.com/prysmaticlabs/geth-sharding/pull/171#issuecomment-396845605","issue_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/171","id":396845605,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njg0NTYwNQ==","user":{"login":"rawfalafel","id":202157,"node_id":"MDQ6VXNlcjIwMjE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/202157?v=4","gravatar_id":"","url":"https://api.github.com/users/rawfalafel","html_url":"https://github.com/rawfalafel","followers_url":"https://api.github.com/users/rawfalafel/followers","following_url":"https://api.github.com/users/rawfalafel/following{/other_user}","gists_url":"https://api.github.com/users/rawfalafel/gists{/gist_id}","starred_url":"https://api.github.com/users/rawfalafel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawfalafel/subscriptions","organizations_url":"https://api.github.com/users/rawfalafel/orgs","repos_url":"https://api.github.com/users/rawfalafel/repos","events_url":"https://api.github.com/users/rawfalafel/events{/privacy}","received_events_url":"https://api.github.com/users/rawfalafel/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T07:43:57Z","updated_at":"2018-06-13T07:43:57Z","author_association":"NONE","body":"Thanks for the clarification @prestonvanloon @rauljordan! \r\n\r\nThis PR is ready to review. The logic is incredibly simple; send a random transaction through the event feed every 5 seconds, and instruct the proposer to subscribe to the feed and propose a collation using that transaction. I tested the goroutine by spinning up my own node."}}
{"actor":{"display_login":"rawfalafel"}}