{"action":"created","comment":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/comments/227046639","pull_request_review_id":166999768,"id":227046639,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA0NjYzOQ==","diff_hunk":"@@ -19,6 +19,7 @@ class TmHelper {\n             operatingSystem: Platform.OS,\n             osVersion: Platform.Version\n         };\n+        if (__DEV__) baseProps.eventTime = Date.now();","path":"app/telemetry/helpers.js","position":4,"original_position":4,"commit_id":"c6726c4998d868ede730c057366d9144799b6d6e","original_commit_id":"c6726c4998d868ede730c057366d9144799b6d6e","user":{"login":"Karim94","id":15848096,"node_id":"MDQ6VXNlcjE1ODQ4MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/15848096?v=4","gravatar_id":"","url":"https://api.github.com/users/Karim94","html_url":"https://github.com/Karim94","followers_url":"https://api.github.com/users/Karim94/followers","following_url":"https://api.github.com/users/Karim94/following{/other_user}","gists_url":"https://api.github.com/users/Karim94/gists{/gist_id}","starred_url":"https://api.github.com/users/Karim94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karim94/subscriptions","organizations_url":"https://api.github.com/users/Karim94/orgs","repos_url":"https://api.github.com/users/Karim94/repos","events_url":"https://api.github.com/users/Karim94/events{/privacy}","received_events_url":"https://api.github.com/users/Karim94/received_events","type":"User","site_admin":false},"body":"We decided to have it on SDK for both prod and dev. Lucas will do it so I'm going to remove it from mobile code.","created_at":"2018-10-22T16:35:03Z","updated_at":"2018-10-22T16:35:03Z","html_url":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351#discussion_r227046639","pull_request_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/comments/227046639"},"html":{"href":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351#discussion_r227046639"},"pull_request":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351"}},"in_reply_to_id":226780253},"pull_request":{"url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351","id":224401296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDAxMjk2","html_url":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351","diff_url":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351.diff","patch_url":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351.patch","issue_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/351","number":351,"state":"open","locked":false,"title":"Chore refactor telemetry components","user":{"login":"Karim94","id":15848096,"node_id":"MDQ6VXNlcjE1ODQ4MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/15848096?v=4","gravatar_id":"","url":"https://api.github.com/users/Karim94","html_url":"https://github.com/Karim94","followers_url":"https://api.github.com/users/Karim94/followers","following_url":"https://api.github.com/users/Karim94/following{/other_user}","gists_url":"https://api.github.com/users/Karim94/gists{/gist_id}","starred_url":"https://api.github.com/users/Karim94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karim94/subscriptions","organizations_url":"https://api.github.com/users/Karim94/orgs","repos_url":"https://api.github.com/users/Karim94/repos","events_url":"https://api.github.com/users/Karim94/events{/privacy}","received_events_url":"https://api.github.com/users/Karim94/received_events","type":"User","site_admin":false},"body":"#### Relevant info and issue/PR links \r\nhttps://app.clubhouse.io/peerio/story/14421/client-telemetry-make-telemetry-a-local-parameter-for-components\r\nhttps://github.com/PeerioTechnologies/peerio-icebear/pull/335\r\nShared components now include the \"location\" property. This is because telemetry properties are now passed to each component.\r\n#### Testing instructions  \r\nVerify that properties being sent by shared components are still the correct ones.\r\n\r\n----\r\n### Repository owner\r\n\r\n- [ ] Was tested and can be merged.\r\n- [ ] PR name follows conventional changelog format.\r\n\r\n[PR guideline](https://github.com/PeerioTechnologies/peerio-icebear/blob/dev/docs/CONTRIBUTING.md)\r\n","created_at":"2018-10-19T20:26:21Z","updated_at":"2018-10-22T16:35:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c7ab2a81d7da6025751e06f54b62c6a2be46ad1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351/commits","review_comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351/comments","review_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/351/comments","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/statuses/c6726c4998d868ede730c057366d9144799b6d6e","head":{"label":"PeerioTechnologies:chore-refactor-telemetry-components","ref":"chore-refactor-telemetry-components","sha":"c6726c4998d868ede730c057366d9144799b6d6e","user":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":63129246,"node_id":"MDEwOlJlcG9zaXRvcnk2MzEyOTI0Ng==","name":"peerio-mobile","full_name":"PeerioTechnologies/peerio-mobile","private":false,"owner":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PeerioTechnologies/peerio-mobile","description":"Peerio 2 for iOS & Android","fork":false,"url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile","forks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/forks","keys_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/teams","hooks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/hooks","issue_events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/events","assignees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/tags","blobs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/languages","stargazers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/stargazers","contributors_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/contributors","subscribers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/subscribers","subscription_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/subscription","commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/merges","archive_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/downloads","issues_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/labels{/name}","releases_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/deployments","created_at":"2016-07-12T05:32:51Z","updated_at":"2018-10-22T16:24:27Z","pushed_at":"2018-10-22T16:24:24Z","git_url":"git://github.com/PeerioTechnologies/peerio-mobile.git","ssh_url":"git@github.com:PeerioTechnologies/peerio-mobile.git","clone_url":"https://github.com/PeerioTechnologies/peerio-mobile.git","svn_url":"https://github.com/PeerioTechnologies/peerio-mobile","homepage":"https://peerio.com","size":33424,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":8,"watchers":7,"default_branch":"dev"}},"base":{"label":"PeerioTechnologies:dev","ref":"dev","sha":"77fccfe5c0cc6ba9a0d21e6ad726caf5a073ce6a","user":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":63129246,"node_id":"MDEwOlJlcG9zaXRvcnk2MzEyOTI0Ng==","name":"peerio-mobile","full_name":"PeerioTechnologies/peerio-mobile","private":false,"owner":{"login":"PeerioTechnologies","id":8494251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTQyNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8494251?v=4","gravatar_id":"","url":"https://api.github.com/users/PeerioTechnologies","html_url":"https://github.com/PeerioTechnologies","followers_url":"https://api.github.com/users/PeerioTechnologies/followers","following_url":"https://api.github.com/users/PeerioTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/PeerioTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/PeerioTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeerioTechnologies/subscriptions","organizations_url":"https://api.github.com/users/PeerioTechnologies/orgs","repos_url":"https://api.github.com/users/PeerioTechnologies/repos","events_url":"https://api.github.com/users/PeerioTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/PeerioTechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PeerioTechnologies/peerio-mobile","description":"Peerio 2 for iOS & Android","fork":false,"url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile","forks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/forks","keys_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/teams","hooks_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/hooks","issue_events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/events","assignees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/tags","blobs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/languages","stargazers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/stargazers","contributors_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/contributors","subscribers_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/subscribers","subscription_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/subscription","commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/merges","archive_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/downloads","issues_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/labels{/name}","releases_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/deployments","created_at":"2016-07-12T05:32:51Z","updated_at":"2018-10-22T16:24:27Z","pushed_at":"2018-10-22T16:24:24Z","git_url":"git://github.com/PeerioTechnologies/peerio-mobile.git","ssh_url":"git@github.com:PeerioTechnologies/peerio-mobile.git","clone_url":"https://github.com/PeerioTechnologies/peerio-mobile.git","svn_url":"https://github.com/PeerioTechnologies/peerio-mobile","homepage":"https://peerio.com","size":33424,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":8,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351"},"html":{"href":"https://github.com/PeerioTechnologies/peerio-mobile/pull/351"},"issue":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/351"},"comments":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/PeerioTechnologies/peerio-mobile/statuses/c6726c4998d868ede730c057366d9144799b6d6e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Karim94"}}