{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/10529","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/10529/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/10529/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/10529/events","html_url":"https://github.com/magento/magento2/issues/10529","id":250025695,"node_id":"MDU6SXNzdWUyNTAwMjU2OTU=","number":10529,"title":"Redis backed sessions expire in 60 seconds when cookie lifetime is set to 0","user":{"login":"ekuusela","id":596493,"node_id":"MDQ6VXNlcjU5NjQ5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/596493?v=4","gravatar_id":"","url":"https://api.github.com/users/ekuusela","html_url":"https://github.com/ekuusela","followers_url":"https://api.github.com/users/ekuusela/followers","following_url":"https://api.github.com/users/ekuusela/following{/other_user}","gists_url":"https://api.github.com/users/ekuusela/gists{/gist_id}","starred_url":"https://api.github.com/users/ekuusela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekuusela/subscriptions","organizations_url":"https://api.github.com/users/ekuusela/orgs","repos_url":"https://api.github.com/users/ekuusela/repos","events_url":"https://api.github.com/users/ekuusela/events{/privacy}","received_events_url":"https://api.github.com/users/ekuusela/received_events","type":"User","site_admin":false},"labels":[{"id":686420665,"node_id":"MDU6TGFiZWw2ODY0MjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Clear%20Description","name":"Issue: Clear Description","color":"0e8a16","default":false},{"id":686476746,"node_id":"MDU6TGFiZWw2ODY0NzY3NDY=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Confirmed","name":"Issue: Confirmed","color":"0e8a16","default":false},{"id":688811200,"node_id":"MDU6TGFiZWw2ODg4MTEyMDA=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Format%20is%20valid","name":"Issue: Format is valid","color":"0e8a16","default":false},{"id":21716835,"node_id":"MDU6TGFiZWwyMTcxNjgzNQ==","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Ready%20for%20Work","name":"Issue: Ready for Work","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"engcom-backlog-andrii","id":41946904,"node_id":"MDQ6VXNlcjQxOTQ2OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/41946904?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-backlog-andrii","html_url":"https://github.com/engcom-backlog-andrii","followers_url":"https://api.github.com/users/engcom-backlog-andrii/followers","following_url":"https://api.github.com/users/engcom-backlog-andrii/following{/other_user}","gists_url":"https://api.github.com/users/engcom-backlog-andrii/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-backlog-andrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-backlog-andrii/subscriptions","organizations_url":"https://api.github.com/users/engcom-backlog-andrii/orgs","repos_url":"https://api.github.com/users/engcom-backlog-andrii/repos","events_url":"https://api.github.com/users/engcom-backlog-andrii/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-backlog-andrii/received_events","type":"User","site_admin":false},"assignees":[{"login":"engcom-backlog-andrii","id":41946904,"node_id":"MDQ6VXNlcjQxOTQ2OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/41946904?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-backlog-andrii","html_url":"https://github.com/engcom-backlog-andrii","followers_url":"https://api.github.com/users/engcom-backlog-andrii/followers","following_url":"https://api.github.com/users/engcom-backlog-andrii/following{/other_user}","gists_url":"https://api.github.com/users/engcom-backlog-andrii/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-backlog-andrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-backlog-andrii/subscriptions","organizations_url":"https://api.github.com/users/engcom-backlog-andrii/orgs","repos_url":"https://api.github.com/users/engcom-backlog-andrii/repos","events_url":"https://api.github.com/users/engcom-backlog-andrii/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-backlog-andrii/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-08-14T13:08:42Z","updated_at":"2018-12-20T14:46:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Setting cookie lifetime to 0 should keep the session open until browser is closed. However, the cookie lifetime value is used as a parameter to the redis's EXPIRE function (after making sure it falls within the configured min/max values, where 60 seconds is the default minimum). Instead, cookie lifetime of zero should be a special case.\r\n\r\nSome relevant code:\r\n- getLifetime() function at magento2/lib/internal/Magento/Framework/Session/SaveHandler/Redis/Config.php\r\n- getLifetime() function at magento2/vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php.\r\n\r\n### Preconditions\r\n1. Magento 2.1.8 with redis configured as session storage\r\n2. Set cookie lifetime to 0 in Stores -> Configuration -> General -> Web\r\n\r\n### Steps to reproduce\r\n1. Navigate to some page in the store frontend and monitor redis for \"expire\" commands\r\n2. Observe that they are set to expire in 60 seconds, causing users to log out and visitor carts to get emptied in the same timeframe\r\n\r\n### Expected result\r\n1. Redis backed sessions should last until the browser closed (or some reasonable timeframe).\r\n\r\n### Actual result\r\n1. Redis backed sessions expire in 60 seconds.\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/449022266","html_url":"https://github.com/magento/magento2/issues/10529#issuecomment-449022266","issue_url":"https://api.github.com/repos/magento/magento2/issues/10529","id":449022266,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTAyMjI2Ng==","user":{"login":"engcom-backlog-andrii","id":41946904,"node_id":"MDQ6VXNlcjQxOTQ2OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/41946904?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-backlog-andrii","html_url":"https://github.com/engcom-backlog-andrii","followers_url":"https://api.github.com/users/engcom-backlog-andrii/followers","following_url":"https://api.github.com/users/engcom-backlog-andrii/following{/other_user}","gists_url":"https://api.github.com/users/engcom-backlog-andrii/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-backlog-andrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-backlog-andrii/subscriptions","organizations_url":"https://api.github.com/users/engcom-backlog-andrii/orgs","repos_url":"https://api.github.com/users/engcom-backlog-andrii/repos","events_url":"https://api.github.com/users/engcom-backlog-andrii/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-backlog-andrii/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T14:46:25Z","updated_at":"2018-12-20T14:46:25Z","author_association":"NONE","body":"@keharper, can you help us by providing information about https://github.com/magento-obsessive-owls/devdocs_internal/pull/1?\r\nThe merge was probably made somewhere between 20/Sep/18 25/Sep/18."}}
{"actor":{"display_login":"engcom-backlog-andrii"}}