{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/eigen/issues/2598","repository_url":"https://api.github.com/repos/artsy/eigen","labels_url":"https://api.github.com/repos/artsy/eigen/issues/2598/labels{/name}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/2598/comments","events_url":"https://api.github.com/repos/artsy/eigen/issues/2598/events","html_url":"https://github.com/artsy/eigen/pull/2598","id":318562619,"number":2598,"title":"[WIP] Bid Status Redesign","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars3.githubusercontent.com/u/498212?v=4","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars2.githubusercontent.com/u/9088720?v=4","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"assignees":[{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars2.githubusercontent.com/u/9088720?v=4","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-27T22:02:38Z","updated_at":"2018-04-27T22:05:26Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/artsy/eigen/pulls/2598","html_url":"https://github.com/artsy/eigen/pull/2598","diff_url":"https://github.com/artsy/eigen/pull/2598.diff","patch_url":"https://github.com/artsy/eigen/pull/2598.patch"},"body":"This is a work-in-progress pull request to address [PURCHASE-18](https://artsyproduct.atlassian.net/browse/PURCHASE-18), which is a snappy new redesign of the artwork view's bid-status views. It is a work-in-progress because I still have the following to do:\r\n\r\n- [ ] Centre the Buyer's Premium label.\r\n- [ ] I have some clarifications I need to get from @briansw on Monday.\r\n- [ ] Write and update unit tests (CI will initially fail, if there are any test for this view).\r\n\r\nHere's what I've got so far:\r\n\r\n![simulator screen shot - iphone x - 2018-04-27 at 17 41 42](https://user-images.githubusercontent.com/498212/39386849-87bb7876-4a44-11e8-94d5-28e9ca0c8e4f.png)\r\n\r\nI did look into simplifying `ARArtworkPriceRowView` to consolidate view logic, but it is quite a misused class, basically a container for each a left- and right-aligned label, on one-line. It wasn't worth the effort to accommodate all the edge cases.\r\n\r\n@erikdstock I forgot to ask to pair on this 😬 Let's sit down and I'll take you through the changes in-person."},"comment":{"url":"https://api.github.com/repos/artsy/eigen/issues/comments/385105937","html_url":"https://github.com/artsy/eigen/pull/2598#issuecomment-385105937","issue_url":"https://api.github.com/repos/artsy/eigen/issues/2598","id":385105937,"user":{"login":"ArtsyOpenSource","id":12397828,"avatar_url":"https://avatars2.githubusercontent.com/u/12397828?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtsyOpenSource","html_url":"https://github.com/ArtsyOpenSource","followers_url":"https://api.github.com/users/ArtsyOpenSource/followers","following_url":"https://api.github.com/users/ArtsyOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/ArtsyOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtsyOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtsyOpenSource/subscriptions","organizations_url":"https://api.github.com/users/ArtsyOpenSource/orgs","repos_url":"https://api.github.com/users/ArtsyOpenSource/repos","events_url":"https://api.github.com/users/ArtsyOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/ArtsyOpenSource/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T22:05:26Z","updated_at":"2018-04-27T22:05:26Z","author_association":"NONE","body":"<!--\n  0 Errors\n  2 Warnings: PR is classed as Work in Progr...\n  0 Messages\n  0 Markdowns\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          2 Warnings\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">PR is classed as Work in Progress</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">Needs testing on a Phone if change is non-trivial</td>\n    </tr>\n  </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_travis\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"ArtsyOpenSource"}}