{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/dune/pulls/comments/172408649","pull_request_review_id":101418117,"id":172408649,"diff_hunk":"@@ -128,6 +128,8 @@ module Fmt = struct\n   let list = Format.pp_print_list\n   let string s ppf = Format.pp_print_string ppf s\n \n+  let nl = Format.pp_print_newline","path":"src/import.ml","position":4,"original_position":4,"commit_id":"14c1037761bea0da21f6f8e1a2a25a5e7113b8e5","original_commit_id":"14c1037761bea0da21f6f8e1a2a25a5e7113b8e5","user":{"login":"rgrinberg","id":139003,"avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"body":"I can find a few other use cases very fast if you'd like. I just refrained from touching unrelated bits of the code :)","created_at":"2018-03-06T04:45:26Z","updated_at":"2018-03-06T04:45:26Z","html_url":"https://github.com/ocaml/dune/pull/579#discussion_r172408649","pull_request_url":"https://api.github.com/repos/ocaml/dune/pulls/579","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments/172408649"},"html":{"href":"https://github.com/ocaml/dune/pull/579#discussion_r172408649"},"pull_request":{"href":"https://api.github.com/repos/ocaml/dune/pulls/579"}},"in_reply_to_id":172347245},"pull_request":{"url":"https://api.github.com/repos/ocaml/dune/pulls/579","id":172679524,"html_url":"https://github.com/ocaml/dune/pull/579","diff_url":"https://github.com/ocaml/dune/pull/579.diff","patch_url":"https://github.com/ocaml/dune/pull/579.patch","issue_url":"https://api.github.com/repos/ocaml/dune/issues/579","number":579,"state":"open","locked":false,"title":"Introduce private type for module name","user":{"login":"rgrinberg","id":139003,"avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"body":"Again, the coercions don't work so cleanly in 4.02.3. Should we also intern the module names?","created_at":"2018-03-03T18:05:23Z","updated_at":"2018-03-06T04:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5ff76ea4c2db31a759c3979c1e49a041c3feb53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/dune/pulls/579/commits","review_comments_url":"https://api.github.com/repos/ocaml/dune/pulls/579/comments","review_comment_url":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/dune/issues/579/comments","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/14c1037761bea0da21f6f8e1a2a25a5e7113b8e5","head":{"label":"rgrinberg:module-name-private","ref":"module-name-private","sha":"14c1037761bea0da21f6f8e1a2a25a5e7113b8e5","user":{"login":"rgrinberg","id":139003,"avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"repo":{"id":81893852,"name":"jbuilder","full_name":"rgrinberg/jbuilder","owner":{"login":"rgrinberg","id":139003,"avatar_url":"https://avatars3.githubusercontent.com/u/139003?v=4","gravatar_id":"","url":"https://api.github.com/users/rgrinberg","html_url":"https://github.com/rgrinberg","followers_url":"https://api.github.com/users/rgrinberg/followers","following_url":"https://api.github.com/users/rgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/rgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrinberg/subscriptions","organizations_url":"https://api.github.com/users/rgrinberg/orgs","repos_url":"https://api.github.com/users/rgrinberg/repos","events_url":"https://api.github.com/users/rgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/rgrinberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgrinberg/jbuilder","description":"Release build system","fork":true,"url":"https://api.github.com/repos/rgrinberg/jbuilder","forks_url":"https://api.github.com/repos/rgrinberg/jbuilder/forks","keys_url":"https://api.github.com/repos/rgrinberg/jbuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgrinberg/jbuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgrinberg/jbuilder/teams","hooks_url":"https://api.github.com/repos/rgrinberg/jbuilder/hooks","issue_events_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues/events{/number}","events_url":"https://api.github.com/repos/rgrinberg/jbuilder/events","assignees_url":"https://api.github.com/repos/rgrinberg/jbuilder/assignees{/user}","branches_url":"https://api.github.com/repos/rgrinberg/jbuilder/branches{/branch}","tags_url":"https://api.github.com/repos/rgrinberg/jbuilder/tags","blobs_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgrinberg/jbuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/rgrinberg/jbuilder/languages","stargazers_url":"https://api.github.com/repos/rgrinberg/jbuilder/stargazers","contributors_url":"https://api.github.com/repos/rgrinberg/jbuilder/contributors","subscribers_url":"https://api.github.com/repos/rgrinberg/jbuilder/subscribers","subscription_url":"https://api.github.com/repos/rgrinberg/jbuilder/subscription","commits_url":"https://api.github.com/repos/rgrinberg/jbuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgrinberg/jbuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgrinberg/jbuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgrinberg/jbuilder/contents/{+path}","compare_url":"https://api.github.com/repos/rgrinberg/jbuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgrinberg/jbuilder/merges","archive_url":"https://api.github.com/repos/rgrinberg/jbuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgrinberg/jbuilder/downloads","issues_url":"https://api.github.com/repos/rgrinberg/jbuilder/issues{/number}","pulls_url":"https://api.github.com/repos/rgrinberg/jbuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/rgrinberg/jbuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/rgrinberg/jbuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgrinberg/jbuilder/labels{/name}","releases_url":"https://api.github.com/repos/rgrinberg/jbuilder/releases{/id}","deployments_url":"https://api.github.com/repos/rgrinberg/jbuilder/deployments","created_at":"2017-02-14T02:11:03Z","updated_at":"2017-02-14T02:11:05Z","pushed_at":"2018-03-05T16:52:23Z","git_url":"git://github.com/rgrinberg/jbuilder.git","ssh_url":"git@github.com:rgrinberg/jbuilder.git","clone_url":"https://github.com/rgrinberg/jbuilder.git","svn_url":"https://github.com/rgrinberg/jbuilder","homepage":"","size":2998,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"5ded45faf0221051c8d1403b6e8ca5758226f607","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":72368050,"name":"dune","full_name":"ocaml/dune","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/dune","description":"A composable build system for OCaml","fork":false,"url":"https://api.github.com/repos/ocaml/dune","forks_url":"https://api.github.com/repos/ocaml/dune/forks","keys_url":"https://api.github.com/repos/ocaml/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/dune/teams","hooks_url":"https://api.github.com/repos/ocaml/dune/hooks","issue_events_url":"https://api.github.com/repos/ocaml/dune/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/dune/events","assignees_url":"https://api.github.com/repos/ocaml/dune/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/dune/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/dune/tags","blobs_url":"https://api.github.com/repos/ocaml/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/dune/languages","stargazers_url":"https://api.github.com/repos/ocaml/dune/stargazers","contributors_url":"https://api.github.com/repos/ocaml/dune/contributors","subscribers_url":"https://api.github.com/repos/ocaml/dune/subscribers","subscription_url":"https://api.github.com/repos/ocaml/dune/subscription","commits_url":"https://api.github.com/repos/ocaml/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/dune/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/dune/merges","archive_url":"https://api.github.com/repos/ocaml/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/dune/downloads","issues_url":"https://api.github.com/repos/ocaml/dune/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/dune/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/dune/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/dune/deployments","created_at":"2016-10-30T18:42:23Z","updated_at":"2018-03-06T03:04:00Z","pushed_at":"2018-03-05T19:01:18Z","git_url":"git://github.com/ocaml/dune.git","ssh_url":"git@github.com:ocaml/dune.git","clone_url":"https://github.com/ocaml/dune.git","svn_url":"https://github.com/ocaml/dune","homepage":"","size":2965,"stargazers_count":285,"watchers_count":285,"language":"OCaml","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":56,"open_issues":124,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/579"},"html":{"href":"https://github.com/ocaml/dune/pull/579"},"issue":{"href":"https://api.github.com/repos/ocaml/dune/issues/579"},"comments":{"href":"https://api.github.com/repos/ocaml/dune/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/dune/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/dune/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/dune/statuses/14c1037761bea0da21f6f8e1a2a25a5e7113b8e5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rgrinberg"}}