{"action":"closed","number":272,"pull_request":{"url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272","id":222671778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjcxNzc4","html_url":"https://github.com/turbinesFoam/turbinesFoam/pull/272","diff_url":"https://github.com/turbinesFoam/turbinesFoam/pull/272.diff","patch_url":"https://github.com/turbinesFoam/turbinesFoam/pull/272.patch","issue_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/272","number":272,"state":"closed","locked":false,"title":"Adding conventional thrust and tangential coefficient for AFTAL","user":{"login":"daa-mec","id":36315332,"node_id":"MDQ6VXNlcjM2MzE1MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/36315332?v=4","gravatar_id":"","url":"https://api.github.com/users/daa-mec","html_url":"https://github.com/daa-mec","followers_url":"https://api.github.com/users/daa-mec/followers","following_url":"https://api.github.com/users/daa-mec/following{/other_user}","gists_url":"https://api.github.com/users/daa-mec/gists{/gist_id}","starred_url":"https://api.github.com/users/daa-mec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daa-mec/subscriptions","organizations_url":"https://api.github.com/users/daa-mec/orgs","repos_url":"https://api.github.com/users/daa-mec/repos","events_url":"https://api.github.com/users/daa-mec/events{/privacy}","received_events_url":"https://api.github.com/users/daa-mec/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI added the functionality to export thrust and tangential coefficients Ct and Cn for AFTAL.\r\nWhat I did was pass the pitch (twist) angle into the element dictionary within `actuatorLineSource::createElements()` and then I just calculate the inflow velocity angle (that I defined as `inflowVelAngle_` ) by adding the twist to the angle of attack. Once this angle was defined, I used it to calculate the thrust and tangential coefficient from the lift and drag coefficients. To this end, I added some additional functions on  `profileData.C` and `actuatorLineElement.C`.\r\n\r\nNote that, I decided to use `twist_` when passing the pitch (twist) to the elements dictionary since I saw the issue #271. and also #183  which I think derived at the end in the introduction of the chord-wise and normal component already included.\r\n\r\n\r\nThe values are also corrected by the `endEffectFactor_` and are written with `writePerf()` alongside all the element's performance parameters.\r\n\r\nWhat is left I think is:\r\n-check if there is any conflict when working with cross flow turbines\r\n-adding a switch to turn it on or off depending on the type of turbine (axial or cross flow).\r\n-decide what variable names should be used. I used Ctan (instead of Ct for tangential) and Cth (instead of Cn for thrust) since Cn is used for the projection on the normal to the chord.\r\n\r\nI run a preliminary test with the NREL-VI experiment. WIth glauert correction.  But I only used singleRe and the values are shown below. I think using multiRe would improve the approximation towards the root of the blade, and the Shen correction factor towards the tip. I will see.\r\n\r\n![nrel-vi_cn_r_tsr7 43nrel1](https://user-images.githubusercontent.com/36315332/46909306-0e475f00-cf28-11e8-9af7-3d2a78138822.png)\r\n![nrel-vi_ct_r_tsr7 43nrel1](https://user-images.githubusercontent.com/36315332/46909307-0edff580-cf28-11e8-910d-570b43210781.png)\r\n","created_at":"2018-10-13T19:49:33Z","updated_at":"2018-11-04T22:39:47Z","closed_at":"2018-11-04T22:39:47Z","merged_at":null,"merge_commit_sha":"14c22483a72d17cbe42668646ab688d42f9f896b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272/commits","review_comments_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272/comments","review_comment_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/272/comments","statuses_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/statuses/b69530ba96b8b87b3cd2ca3997b1420cd1ca259a","head":{"label":"daa-mec:AFTAL-Thrust-Tangential-Coefficients","ref":"AFTAL-Thrust-Tangential-Coefficients","sha":"b69530ba96b8b87b3cd2ca3997b1420cd1ca259a","user":{"login":"daa-mec","id":36315332,"node_id":"MDQ6VXNlcjM2MzE1MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/36315332?v=4","gravatar_id":"","url":"https://api.github.com/users/daa-mec","html_url":"https://github.com/daa-mec","followers_url":"https://api.github.com/users/daa-mec/followers","following_url":"https://api.github.com/users/daa-mec/following{/other_user}","gists_url":"https://api.github.com/users/daa-mec/gists{/gist_id}","starred_url":"https://api.github.com/users/daa-mec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daa-mec/subscriptions","organizations_url":"https://api.github.com/users/daa-mec/orgs","repos_url":"https://api.github.com/users/daa-mec/repos","events_url":"https://api.github.com/users/daa-mec/events{/privacy}","received_events_url":"https://api.github.com/users/daa-mec/received_events","type":"User","site_admin":false},"repo":{"id":152810716,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTA3MTY=","name":"turbinesFoam","full_name":"daa-mec/turbinesFoam","private":false,"owner":{"login":"daa-mec","id":36315332,"node_id":"MDQ6VXNlcjM2MzE1MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/36315332?v=4","gravatar_id":"","url":"https://api.github.com/users/daa-mec","html_url":"https://github.com/daa-mec","followers_url":"https://api.github.com/users/daa-mec/followers","following_url":"https://api.github.com/users/daa-mec/following{/other_user}","gists_url":"https://api.github.com/users/daa-mec/gists{/gist_id}","starred_url":"https://api.github.com/users/daa-mec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daa-mec/subscriptions","organizations_url":"https://api.github.com/users/daa-mec/orgs","repos_url":"https://api.github.com/users/daa-mec/repos","events_url":"https://api.github.com/users/daa-mec/events{/privacy}","received_events_url":"https://api.github.com/users/daa-mec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/daa-mec/turbinesFoam","description":"Actuator line modeling extension library for OpenFOAM.","fork":true,"url":"https://api.github.com/repos/daa-mec/turbinesFoam","forks_url":"https://api.github.com/repos/daa-mec/turbinesFoam/forks","keys_url":"https://api.github.com/repos/daa-mec/turbinesFoam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daa-mec/turbinesFoam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daa-mec/turbinesFoam/teams","hooks_url":"https://api.github.com/repos/daa-mec/turbinesFoam/hooks","issue_events_url":"https://api.github.com/repos/daa-mec/turbinesFoam/issues/events{/number}","events_url":"https://api.github.com/repos/daa-mec/turbinesFoam/events","assignees_url":"https://api.github.com/repos/daa-mec/turbinesFoam/assignees{/user}","branches_url":"https://api.github.com/repos/daa-mec/turbinesFoam/branches{/branch}","tags_url":"https://api.github.com/repos/daa-mec/turbinesFoam/tags","blobs_url":"https://api.github.com/repos/daa-mec/turbinesFoam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daa-mec/turbinesFoam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daa-mec/turbinesFoam/git/refs{/sha}","trees_url":"https://api.github.com/repos/daa-mec/turbinesFoam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daa-mec/turbinesFoam/statuses/{sha}","languages_url":"https://api.github.com/repos/daa-mec/turbinesFoam/languages","stargazers_url":"https://api.github.com/repos/daa-mec/turbinesFoam/stargazers","contributors_url":"https://api.github.com/repos/daa-mec/turbinesFoam/contributors","subscribers_url":"https://api.github.com/repos/daa-mec/turbinesFoam/subscribers","subscription_url":"https://api.github.com/repos/daa-mec/turbinesFoam/subscription","commits_url":"https://api.github.com/repos/daa-mec/turbinesFoam/commits{/sha}","git_commits_url":"https://api.github.com/repos/daa-mec/turbinesFoam/git/commits{/sha}","comments_url":"https://api.github.com/repos/daa-mec/turbinesFoam/comments{/number}","issue_comment_url":"https://api.github.com/repos/daa-mec/turbinesFoam/issues/comments{/number}","contents_url":"https://api.github.com/repos/daa-mec/turbinesFoam/contents/{+path}","compare_url":"https://api.github.com/repos/daa-mec/turbinesFoam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daa-mec/turbinesFoam/merges","archive_url":"https://api.github.com/repos/daa-mec/turbinesFoam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daa-mec/turbinesFoam/downloads","issues_url":"https://api.github.com/repos/daa-mec/turbinesFoam/issues{/number}","pulls_url":"https://api.github.com/repos/daa-mec/turbinesFoam/pulls{/number}","milestones_url":"https://api.github.com/repos/daa-mec/turbinesFoam/milestones{/number}","notifications_url":"https://api.github.com/repos/daa-mec/turbinesFoam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daa-mec/turbinesFoam/labels{/name}","releases_url":"https://api.github.com/repos/daa-mec/turbinesFoam/releases{/id}","deployments_url":"https://api.github.com/repos/daa-mec/turbinesFoam/deployments","created_at":"2018-10-12T21:44:24Z","updated_at":"2018-10-29T14:48:07Z","pushed_at":"2018-10-31T19:31:40Z","git_url":"git://github.com/daa-mec/turbinesFoam.git","ssh_url":"git@github.com:daa-mec/turbinesFoam.git","clone_url":"https://github.com/daa-mec/turbinesFoam.git","svn_url":"https://github.com/daa-mec/turbinesFoam","homepage":"","size":2415,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"turbinesFoam:master","ref":"master","sha":"2cf96e50814e595f972938df81364e4fa2570090","user":{"login":"turbinesFoam","id":10404114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDA0MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/10404114?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinesFoam","html_url":"https://github.com/turbinesFoam","followers_url":"https://api.github.com/users/turbinesFoam/followers","following_url":"https://api.github.com/users/turbinesFoam/following{/other_user}","gists_url":"https://api.github.com/users/turbinesFoam/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinesFoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinesFoam/subscriptions","organizations_url":"https://api.github.com/users/turbinesFoam/orgs","repos_url":"https://api.github.com/users/turbinesFoam/repos","events_url":"https://api.github.com/users/turbinesFoam/events{/privacy}","received_events_url":"https://api.github.com/users/turbinesFoam/received_events","type":"Organization","site_admin":false},"repo":{"id":21178017,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE3ODAxNw==","name":"turbinesFoam","full_name":"turbinesFoam/turbinesFoam","private":false,"owner":{"login":"turbinesFoam","id":10404114,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDA0MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/10404114?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinesFoam","html_url":"https://github.com/turbinesFoam","followers_url":"https://api.github.com/users/turbinesFoam/followers","following_url":"https://api.github.com/users/turbinesFoam/following{/other_user}","gists_url":"https://api.github.com/users/turbinesFoam/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinesFoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinesFoam/subscriptions","organizations_url":"https://api.github.com/users/turbinesFoam/orgs","repos_url":"https://api.github.com/users/turbinesFoam/repos","events_url":"https://api.github.com/users/turbinesFoam/events{/privacy}","received_events_url":"https://api.github.com/users/turbinesFoam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/turbinesFoam/turbinesFoam","description":"Actuator line modeling extension library for OpenFOAM.","fork":false,"url":"https://api.github.com/repos/turbinesFoam/turbinesFoam","forks_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/forks","keys_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/teams","hooks_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/hooks","issue_events_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/events{/number}","events_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/events","assignees_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/assignees{/user}","branches_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/branches{/branch}","tags_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/tags","blobs_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/git/refs{/sha}","trees_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/statuses/{sha}","languages_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/languages","stargazers_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/stargazers","contributors_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/contributors","subscribers_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/subscribers","subscription_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/subscription","commits_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/commits{/sha}","git_commits_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/git/commits{/sha}","comments_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/comments{/number}","issue_comment_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/comments{/number}","contents_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/contents/{+path}","compare_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/merges","archive_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/downloads","issues_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues{/number}","pulls_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls{/number}","milestones_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/milestones{/number}","notifications_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/labels{/name}","releases_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/releases{/id}","deployments_url":"https://api.github.com/repos/turbinesFoam/turbinesFoam/deployments","created_at":"2014-06-24T19:30:49Z","updated_at":"2018-11-01T22:51:44Z","pushed_at":"2018-10-31T18:53:32Z","git_url":"git://github.com/turbinesFoam/turbinesFoam.git","ssh_url":"git@github.com:turbinesFoam/turbinesFoam.git","clone_url":"https://github.com/turbinesFoam/turbinesFoam.git","svn_url":"https://github.com/turbinesFoam/turbinesFoam","homepage":"","size":2367,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":24,"open_issues":88,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272"},"html":{"href":"https://github.com/turbinesFoam/turbinesFoam/pull/272"},"issue":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/272"},"comments":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/turbinesFoam/turbinesFoam/statuses/b69530ba96b8b87b3cd2ca3997b1420cd1ca259a"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":9,"review_comments":15,"maintainer_can_modify":false,"commits":7,"additions":148,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"petebachant"}}