{"action":"created","comment":{"url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/comments/228758423","pull_request_review_id":169102688,"id":228758423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1ODQyMw==","diff_hunk":"@@ -5,15 +5,24 @@\n except ImportError:\n     import unittest\n \n+\n class ProjectTests(unittest.TestCase):\n \n     # ./Docker or docker/Docker\n     def test_docker_dir(self):\n-        self.assertEqual(True, os.path.isdir(\"./Dockerfile\") || os.path.isdir(\"./docker/Dockerfile\"))\n+        self.assertEqual(\n+            True,\n+            os.path.isdir(\"./Dockerfile\")\n+            or os.path.isdir(\"./docker/Dockerfile\"),\n+        )\n \n     # ./docker-compose.yml or ./docker/docker-compose.yml\n     def test_docker_compose(self):\n-        self.assertEqual(True, os.path.isfile('./docker-compose.yml') || os.path.isfile('./docker/docker-compose.yml'))\n+        self.assertEqual(","path":"test/test_project.py","position":null,"original_position":19,"commit_id":"4974e7e0198f7eb8b84bf20c948ef88dcc823a72","original_commit_id":"899f3bba054a3cc1128aa92eb37d0c3764a9ac6c","user":{"login":"42B","id":37713517,"node_id":"MDQ6VXNlcjM3NzEzNTE3","avatar_url":"https://avatars0.githubusercontent.com/u/37713517?v=4","gravatar_id":"","url":"https://api.github.com/users/42B","html_url":"https://github.com/42B","followers_url":"https://api.github.com/users/42B/followers","following_url":"https://api.github.com/users/42B/following{/other_user}","gists_url":"https://api.github.com/users/42B/gists{/gist_id}","starred_url":"https://api.github.com/users/42B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/42B/subscriptions","organizations_url":"https://api.github.com/users/42B/orgs","repos_url":"https://api.github.com/users/42B/repos","events_url":"https://api.github.com/users/42B/events{/privacy}","received_events_url":"https://api.github.com/users/42B/received_events","type":"User","site_admin":false},"body":"@hugovk \r\n\r\nYour logic doesn't make sense, you have essentially a duplicate PR that you refuse to close... why?","created_at":"2018-10-28T18:05:53Z","updated_at":"2018-10-28T18:05:53Z","html_url":"https://github.com/sendgrid/smtpapi-python/pull/86#discussion_r228758423","pull_request_url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/comments/228758423"},"html":{"href":"https://github.com/sendgrid/smtpapi-python/pull/86#discussion_r228758423"},"pull_request":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86"}},"in_reply_to_id":228730357},"pull_request":{"url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86","id":224474917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDc0OTE3","html_url":"https://github.com/sendgrid/smtpapi-python/pull/86","diff_url":"https://github.com/sendgrid/smtpapi-python/pull/86.diff","patch_url":"https://github.com/sendgrid/smtpapi-python/pull/86.patch","issue_url":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/86","number":86,"state":"open","locked":false,"title":"Fix and add flake8 to CI","user":{"login":"hugovk","id":1324225,"node_id":"MDQ6VXNlcjEzMjQyMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1324225?v=4","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"body":"<!--\r\nWe appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.\r\n\r\n\r\nPlease enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!\r\ne.g. \r\nFixes #1\r\nCloses #2\r\n-->\r\n# Fixes https://github.com/sendgrid/smtpapi-python/issues/49\r\n\r\n### Checklist\r\n- [x] I have made a material change to the repo (functionality, testing, spelling, grammar)\r\n- [x] I have read the [Contribution Guide] and my PR follows them.\r\n- [x] I updated my branch with the master branch.\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [n/a] I have added necessary documentation about the functionality in the appropriate .md file\r\n- [n/a] I have added in line documentation to the code I modified\r\n\r\n### Short description of what this PR does:\r\n- Run `flake8` (=`pyflakes` for bugs and `pycodestyle` for PEP 8 and style) on the CI to enforce compliance\r\n- Fix code to pass `flake8`\r\n- `flake8` doesn't support Python 2.6 (just drop it: https://github.com/sendgrid/smtpapi-python/pull/83)\r\n- Fix a typo in the test_lisence.py filename\r\n- Make test_license.py use the `unittest` class for consistency\r\n- In tests, use Python's 'or', not '||'\r\n- Replaces and closes stalled https://github.com/sendgrid/smtpapi-python/pull/50.\r\n\r\nThere some overlap between `test_license_year` in `test/test_license.py` and `test_license_year` in `test/__init__.py`. Should they be merged somehow?\r\n\r\n","created_at":"2018-10-20T13:31:46Z","updated_at":"2018-10-28T18:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee4b5072af19372c80bb4c9ceda14e34e19d58bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":378653040,"node_id":"MDU6TGFiZWwzNzg2NTMwNDA=","url":"https://api.github.com/repos/sendgrid/smtpapi-python/labels/status:%20code%20review%20request","name":"status: code review request","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86/commits","review_comments_url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86/comments","review_comment_url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/86/comments","statuses_url":"https://api.github.com/repos/sendgrid/smtpapi-python/statuses/4974e7e0198f7eb8b84bf20c948ef88dcc823a72","head":{"label":"hugovk:flake8","ref":"flake8","sha":"4974e7e0198f7eb8b84bf20c948ef88dcc823a72","user":{"login":"hugovk","id":1324225,"node_id":"MDQ6VXNlcjEzMjQyMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1324225?v=4","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"repo":{"id":151149242,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExNDkyNDI=","name":"smtpapi-python","full_name":"hugovk/smtpapi-python","private":false,"owner":{"login":"hugovk","id":1324225,"node_id":"MDQ6VXNlcjEzMjQyMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1324225?v=4","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hugovk/smtpapi-python","description":"SendGrid's smtpapi library in Python","fork":true,"url":"https://api.github.com/repos/hugovk/smtpapi-python","forks_url":"https://api.github.com/repos/hugovk/smtpapi-python/forks","keys_url":"https://api.github.com/repos/hugovk/smtpapi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hugovk/smtpapi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hugovk/smtpapi-python/teams","hooks_url":"https://api.github.com/repos/hugovk/smtpapi-python/hooks","issue_events_url":"https://api.github.com/repos/hugovk/smtpapi-python/issues/events{/number}","events_url":"https://api.github.com/repos/hugovk/smtpapi-python/events","assignees_url":"https://api.github.com/repos/hugovk/smtpapi-python/assignees{/user}","branches_url":"https://api.github.com/repos/hugovk/smtpapi-python/branches{/branch}","tags_url":"https://api.github.com/repos/hugovk/smtpapi-python/tags","blobs_url":"https://api.github.com/repos/hugovk/smtpapi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hugovk/smtpapi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hugovk/smtpapi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/hugovk/smtpapi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hugovk/smtpapi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/hugovk/smtpapi-python/languages","stargazers_url":"https://api.github.com/repos/hugovk/smtpapi-python/stargazers","contributors_url":"https://api.github.com/repos/hugovk/smtpapi-python/contributors","subscribers_url":"https://api.github.com/repos/hugovk/smtpapi-python/subscribers","subscription_url":"https://api.github.com/repos/hugovk/smtpapi-python/subscription","commits_url":"https://api.github.com/repos/hugovk/smtpapi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/hugovk/smtpapi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/hugovk/smtpapi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/hugovk/smtpapi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/hugovk/smtpapi-python/contents/{+path}","compare_url":"https://api.github.com/repos/hugovk/smtpapi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hugovk/smtpapi-python/merges","archive_url":"https://api.github.com/repos/hugovk/smtpapi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hugovk/smtpapi-python/downloads","issues_url":"https://api.github.com/repos/hugovk/smtpapi-python/issues{/number}","pulls_url":"https://api.github.com/repos/hugovk/smtpapi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/hugovk/smtpapi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/hugovk/smtpapi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hugovk/smtpapi-python/labels{/name}","releases_url":"https://api.github.com/repos/hugovk/smtpapi-python/releases{/id}","deployments_url":"https://api.github.com/repos/hugovk/smtpapi-python/deployments","created_at":"2018-10-01T19:48:32Z","updated_at":"2018-10-27T20:41:21Z","pushed_at":"2018-10-28T18:05:26Z","git_url":"git://github.com/hugovk/smtpapi-python.git","ssh_url":"git@github.com:hugovk/smtpapi-python.git","clone_url":"https://github.com/hugovk/smtpapi-python.git","svn_url":"https://github.com/hugovk/smtpapi-python","homepage":"https://sendgrid.com","size":195,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sendgrid:master","ref":"master","sha":"97cca3460802d62d288c06353d4f687d3c0e7ed6","user":{"login":"sendgrid","id":181234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/181234?v=4","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":15412515,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMjUxNQ==","name":"smtpapi-python","full_name":"sendgrid/smtpapi-python","private":false,"owner":{"login":"sendgrid","id":181234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/181234?v=4","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sendgrid/smtpapi-python","description":"SendGrid's smtpapi library in Python","fork":false,"url":"https://api.github.com/repos/sendgrid/smtpapi-python","forks_url":"https://api.github.com/repos/sendgrid/smtpapi-python/forks","keys_url":"https://api.github.com/repos/sendgrid/smtpapi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sendgrid/smtpapi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sendgrid/smtpapi-python/teams","hooks_url":"https://api.github.com/repos/sendgrid/smtpapi-python/hooks","issue_events_url":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/events{/number}","events_url":"https://api.github.com/repos/sendgrid/smtpapi-python/events","assignees_url":"https://api.github.com/repos/sendgrid/smtpapi-python/assignees{/user}","branches_url":"https://api.github.com/repos/sendgrid/smtpapi-python/branches{/branch}","tags_url":"https://api.github.com/repos/sendgrid/smtpapi-python/tags","blobs_url":"https://api.github.com/repos/sendgrid/smtpapi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sendgrid/smtpapi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sendgrid/smtpapi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/sendgrid/smtpapi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sendgrid/smtpapi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/sendgrid/smtpapi-python/languages","stargazers_url":"https://api.github.com/repos/sendgrid/smtpapi-python/stargazers","contributors_url":"https://api.github.com/repos/sendgrid/smtpapi-python/contributors","subscribers_url":"https://api.github.com/repos/sendgrid/smtpapi-python/subscribers","subscription_url":"https://api.github.com/repos/sendgrid/smtpapi-python/subscription","commits_url":"https://api.github.com/repos/sendgrid/smtpapi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/sendgrid/smtpapi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/sendgrid/smtpapi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/sendgrid/smtpapi-python/contents/{+path}","compare_url":"https://api.github.com/repos/sendgrid/smtpapi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sendgrid/smtpapi-python/merges","archive_url":"https://api.github.com/repos/sendgrid/smtpapi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sendgrid/smtpapi-python/downloads","issues_url":"https://api.github.com/repos/sendgrid/smtpapi-python/issues{/number}","pulls_url":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/sendgrid/smtpapi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/sendgrid/smtpapi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sendgrid/smtpapi-python/labels{/name}","releases_url":"https://api.github.com/repos/sendgrid/smtpapi-python/releases{/id}","deployments_url":"https://api.github.com/repos/sendgrid/smtpapi-python/deployments","created_at":"2013-12-24T05:57:42Z","updated_at":"2018-10-22T23:18:55Z","pushed_at":"2018-10-28T18:05:28Z","git_url":"git://github.com/sendgrid/smtpapi-python.git","ssh_url":"git@github.com:sendgrid/smtpapi-python.git","clone_url":"https://github.com/sendgrid/smtpapi-python.git","svn_url":"https://github.com/sendgrid/smtpapi-python","homepage":"https://sendgrid.com","size":184,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":31,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86"},"html":{"href":"https://github.com/sendgrid/smtpapi-python/pull/86"},"issue":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/86"},"comments":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/sendgrid/smtpapi-python/statuses/4974e7e0198f7eb8b84bf20c948ef88dcc823a72"}},"author_association":"NONE"}}
{"actor":{"display_login":"42B"}}