{"action":"created","comment":{"url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/comments/169800883","pull_request_review_id":98387971,"id":169800883,"diff_hunk":"@@ -0,0 +1,33 @@\n+version: 0.2\n+\n+phases:\n+  install:\n+    commands:\n+      - sudo apt-get update\n+      - sudo apt-get install apt-transport-https\n+      - curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -\n+      - echo \"deb https://dl.yarnpkg.com/debian/ stable main\" | sudo tee /etc/apt/sources.list.d/yarn.list\n+      - sudo apt-get update && sudo apt-get install yarn\n+  pre_build:\n+    commands:\n+      - yarn install\n+  build:\n+    commands:\n+      - yarn build:all\n+      - ./node_modules/mocha/bin/mocha -r ts-node/register test/**/*.spec.ts\n+  post_build:\n+    commands:\n+      - >-\n+        if [ $CODEBUILD_SOURCE_VERSION == master ]; then","path":"buildspec.yml","position":21,"original_position":21,"commit_id":"40f83ad2f4bf63c4d3eb80e187056e76f892e061","original_commit_id":"40f83ad2f4bf63c4d3eb80e187056e76f892e061","user":{"login":"Reltre","id":5009737,"avatar_url":"https://avatars2.githubusercontent.com/u/5009737?v=4","gravatar_id":"","url":"https://api.github.com/users/Reltre","html_url":"https://github.com/Reltre","followers_url":"https://api.github.com/users/Reltre/followers","following_url":"https://api.github.com/users/Reltre/following{/other_user}","gists_url":"https://api.github.com/users/Reltre/gists{/gist_id}","starred_url":"https://api.github.com/users/Reltre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reltre/subscriptions","organizations_url":"https://api.github.com/users/Reltre/orgs","repos_url":"https://api.github.com/users/Reltre/repos","events_url":"https://api.github.com/users/Reltre/events{/privacy}","received_events_url":"https://api.github.com/users/Reltre/received_events","type":"User","site_admin":false},"body":"Huh, I'll have to keep an eye on those logs, I didn't notice that. Well, it didn't result in an error for me. I wonder if the logical AND may be causing the issue? The shell may be thinking, \"then -> do this STOP && do this thing\", after the conditional. But, I figured the semi-colon and `fi` would demarcate that, so I didn't bother grouping with parentheses there.","created_at":"2018-02-21T22:37:11Z","updated_at":"2018-02-21T22:37:11Z","html_url":"https://github.com/fuego-starter/fuego-photos/pull/7#discussion_r169800883","pull_request_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/comments/169800883"},"html":{"href":"https://github.com/fuego-starter/fuego-photos/pull/7#discussion_r169800883"},"pull_request":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7"}},"in_reply_to_id":169797153},"pull_request":{"url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7","id":169877628,"html_url":"https://github.com/fuego-starter/fuego-photos/pull/7","diff_url":"https://github.com/fuego-starter/fuego-photos/pull/7.diff","patch_url":"https://github.com/fuego-starter/fuego-photos/pull/7.patch","issue_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/7","number":7,"state":"closed","locked":false,"title":"Add CD","user":{"login":"Reltre","id":5009737,"avatar_url":"https://avatars2.githubusercontent.com/u/5009737?v=4","gravatar_id":"","url":"https://api.github.com/users/Reltre","html_url":"https://github.com/Reltre","followers_url":"https://api.github.com/users/Reltre/followers","following_url":"https://api.github.com/users/Reltre/following{/other_user}","gists_url":"https://api.github.com/users/Reltre/gists{/gist_id}","starred_url":"https://api.github.com/users/Reltre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reltre/subscriptions","organizations_url":"https://api.github.com/users/Reltre/orgs","repos_url":"https://api.github.com/users/Reltre/repos","events_url":"https://api.github.com/users/Reltre/events{/privacy}","received_events_url":"https://api.github.com/users/Reltre/received_events","type":"User","site_admin":false},"body":"This PR updates our Code Build setup to deploy if a push (or merge) to master is made. This is done in the post_build phase. \r\n\r\nI'm uncertain if a valid access and secret token are needed for CB to do this or if that value is already stored in the CB instance, considering that we did create it after all. This will have to be tested when this PR is merged, or perhaps with a minor push to master after the CI PR is merged.\r\n\r\nI did notice one issue. The webhook that grabs the GH code to be tested is running twice when commits are associated with a PR. Right now the webhook is configured to work when a push to any branch happens and when a PR is open or altered. That's probably the issue. We could just remove the event of push and only run tests when working with a PR. Only issue this might present is tests not being run with direct pushes to master, though ideally those are few and far between.","created_at":"2018-02-19T04:48:02Z","updated_at":"2018-02-21T22:37:11Z","closed_at":"2018-02-21T22:37:03Z","merged_at":null,"merge_commit_sha":"be37a48557e3a447625cba7fcb1d23354bf6f038","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7/commits","review_comments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7/comments","review_comment_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/7/comments","statuses_url":"https://api.github.com/repos/fuego-starter/fuego-photos/statuses/40f83ad2f4bf63c4d3eb80e187056e76f892e061","head":{"label":"fuego-starter:add_cd","ref":"add_cd","sha":"40f83ad2f4bf63c4d3eb80e187056e76f892e061","user":{"login":"fuego-starter","id":35211861,"avatar_url":"https://avatars0.githubusercontent.com/u/35211861?v=4","gravatar_id":"","url":"https://api.github.com/users/fuego-starter","html_url":"https://github.com/fuego-starter","followers_url":"https://api.github.com/users/fuego-starter/followers","following_url":"https://api.github.com/users/fuego-starter/following{/other_user}","gists_url":"https://api.github.com/users/fuego-starter/gists{/gist_id}","starred_url":"https://api.github.com/users/fuego-starter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuego-starter/subscriptions","organizations_url":"https://api.github.com/users/fuego-starter/orgs","repos_url":"https://api.github.com/users/fuego-starter/repos","events_url":"https://api.github.com/users/fuego-starter/events{/privacy}","received_events_url":"https://api.github.com/users/fuego-starter/received_events","type":"Organization","site_admin":false},"repo":{"id":116632684,"name":"fuego-photos","full_name":"fuego-starter/fuego-photos","owner":{"login":"fuego-starter","id":35211861,"avatar_url":"https://avatars0.githubusercontent.com/u/35211861?v=4","gravatar_id":"","url":"https://api.github.com/users/fuego-starter","html_url":"https://github.com/fuego-starter","followers_url":"https://api.github.com/users/fuego-starter/followers","following_url":"https://api.github.com/users/fuego-starter/following{/other_user}","gists_url":"https://api.github.com/users/fuego-starter/gists{/gist_id}","starred_url":"https://api.github.com/users/fuego-starter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuego-starter/subscriptions","organizations_url":"https://api.github.com/users/fuego-starter/orgs","repos_url":"https://api.github.com/users/fuego-starter/repos","events_url":"https://api.github.com/users/fuego-starter/events{/privacy}","received_events_url":"https://api.github.com/users/fuego-starter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fuego-starter/fuego-photos","description":"Back end handler for user auth and photo uploading to S3","fork":false,"url":"https://api.github.com/repos/fuego-starter/fuego-photos","forks_url":"https://api.github.com/repos/fuego-starter/fuego-photos/forks","keys_url":"https://api.github.com/repos/fuego-starter/fuego-photos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuego-starter/fuego-photos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuego-starter/fuego-photos/teams","hooks_url":"https://api.github.com/repos/fuego-starter/fuego-photos/hooks","issue_events_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/events{/number}","events_url":"https://api.github.com/repos/fuego-starter/fuego-photos/events","assignees_url":"https://api.github.com/repos/fuego-starter/fuego-photos/assignees{/user}","branches_url":"https://api.github.com/repos/fuego-starter/fuego-photos/branches{/branch}","tags_url":"https://api.github.com/repos/fuego-starter/fuego-photos/tags","blobs_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuego-starter/fuego-photos/statuses/{sha}","languages_url":"https://api.github.com/repos/fuego-starter/fuego-photos/languages","stargazers_url":"https://api.github.com/repos/fuego-starter/fuego-photos/stargazers","contributors_url":"https://api.github.com/repos/fuego-starter/fuego-photos/contributors","subscribers_url":"https://api.github.com/repos/fuego-starter/fuego-photos/subscribers","subscription_url":"https://api.github.com/repos/fuego-starter/fuego-photos/subscription","commits_url":"https://api.github.com/repos/fuego-starter/fuego-photos/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuego-starter/fuego-photos/contents/{+path}","compare_url":"https://api.github.com/repos/fuego-starter/fuego-photos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuego-starter/fuego-photos/merges","archive_url":"https://api.github.com/repos/fuego-starter/fuego-photos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuego-starter/fuego-photos/downloads","issues_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues{/number}","pulls_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls{/number}","milestones_url":"https://api.github.com/repos/fuego-starter/fuego-photos/milestones{/number}","notifications_url":"https://api.github.com/repos/fuego-starter/fuego-photos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuego-starter/fuego-photos/labels{/name}","releases_url":"https://api.github.com/repos/fuego-starter/fuego-photos/releases{/id}","deployments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/deployments","created_at":"2018-01-08T05:12:05Z","updated_at":"2018-01-17T19:00:05Z","pushed_at":"2018-02-19T05:24:48Z","git_url":"git://github.com/fuego-starter/fuego-photos.git","ssh_url":"git@github.com:fuego-starter/fuego-photos.git","clone_url":"https://github.com/fuego-starter/fuego-photos.git","svn_url":"https://github.com/fuego-starter/fuego-photos","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fuego-starter:master","ref":"master","sha":"6a76fdcc7553d9d19174d83513700872dd649484","user":{"login":"fuego-starter","id":35211861,"avatar_url":"https://avatars0.githubusercontent.com/u/35211861?v=4","gravatar_id":"","url":"https://api.github.com/users/fuego-starter","html_url":"https://github.com/fuego-starter","followers_url":"https://api.github.com/users/fuego-starter/followers","following_url":"https://api.github.com/users/fuego-starter/following{/other_user}","gists_url":"https://api.github.com/users/fuego-starter/gists{/gist_id}","starred_url":"https://api.github.com/users/fuego-starter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuego-starter/subscriptions","organizations_url":"https://api.github.com/users/fuego-starter/orgs","repos_url":"https://api.github.com/users/fuego-starter/repos","events_url":"https://api.github.com/users/fuego-starter/events{/privacy}","received_events_url":"https://api.github.com/users/fuego-starter/received_events","type":"Organization","site_admin":false},"repo":{"id":116632684,"name":"fuego-photos","full_name":"fuego-starter/fuego-photos","owner":{"login":"fuego-starter","id":35211861,"avatar_url":"https://avatars0.githubusercontent.com/u/35211861?v=4","gravatar_id":"","url":"https://api.github.com/users/fuego-starter","html_url":"https://github.com/fuego-starter","followers_url":"https://api.github.com/users/fuego-starter/followers","following_url":"https://api.github.com/users/fuego-starter/following{/other_user}","gists_url":"https://api.github.com/users/fuego-starter/gists{/gist_id}","starred_url":"https://api.github.com/users/fuego-starter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuego-starter/subscriptions","organizations_url":"https://api.github.com/users/fuego-starter/orgs","repos_url":"https://api.github.com/users/fuego-starter/repos","events_url":"https://api.github.com/users/fuego-starter/events{/privacy}","received_events_url":"https://api.github.com/users/fuego-starter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fuego-starter/fuego-photos","description":"Back end handler for user auth and photo uploading to S3","fork":false,"url":"https://api.github.com/repos/fuego-starter/fuego-photos","forks_url":"https://api.github.com/repos/fuego-starter/fuego-photos/forks","keys_url":"https://api.github.com/repos/fuego-starter/fuego-photos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuego-starter/fuego-photos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuego-starter/fuego-photos/teams","hooks_url":"https://api.github.com/repos/fuego-starter/fuego-photos/hooks","issue_events_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/events{/number}","events_url":"https://api.github.com/repos/fuego-starter/fuego-photos/events","assignees_url":"https://api.github.com/repos/fuego-starter/fuego-photos/assignees{/user}","branches_url":"https://api.github.com/repos/fuego-starter/fuego-photos/branches{/branch}","tags_url":"https://api.github.com/repos/fuego-starter/fuego-photos/tags","blobs_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuego-starter/fuego-photos/statuses/{sha}","languages_url":"https://api.github.com/repos/fuego-starter/fuego-photos/languages","stargazers_url":"https://api.github.com/repos/fuego-starter/fuego-photos/stargazers","contributors_url":"https://api.github.com/repos/fuego-starter/fuego-photos/contributors","subscribers_url":"https://api.github.com/repos/fuego-starter/fuego-photos/subscribers","subscription_url":"https://api.github.com/repos/fuego-starter/fuego-photos/subscription","commits_url":"https://api.github.com/repos/fuego-starter/fuego-photos/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuego-starter/fuego-photos/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuego-starter/fuego-photos/contents/{+path}","compare_url":"https://api.github.com/repos/fuego-starter/fuego-photos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuego-starter/fuego-photos/merges","archive_url":"https://api.github.com/repos/fuego-starter/fuego-photos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuego-starter/fuego-photos/downloads","issues_url":"https://api.github.com/repos/fuego-starter/fuego-photos/issues{/number}","pulls_url":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls{/number}","milestones_url":"https://api.github.com/repos/fuego-starter/fuego-photos/milestones{/number}","notifications_url":"https://api.github.com/repos/fuego-starter/fuego-photos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuego-starter/fuego-photos/labels{/name}","releases_url":"https://api.github.com/repos/fuego-starter/fuego-photos/releases{/id}","deployments_url":"https://api.github.com/repos/fuego-starter/fuego-photos/deployments","created_at":"2018-01-08T05:12:05Z","updated_at":"2018-01-17T19:00:05Z","pushed_at":"2018-02-19T05:24:48Z","git_url":"git://github.com/fuego-starter/fuego-photos.git","ssh_url":"git@github.com:fuego-starter/fuego-photos.git","clone_url":"https://github.com/fuego-starter/fuego-photos.git","svn_url":"https://github.com/fuego-starter/fuego-photos","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7"},"html":{"href":"https://github.com/fuego-starter/fuego-photos/pull/7"},"issue":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/7"},"comments":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/fuego-starter/fuego-photos/statuses/40f83ad2f4bf63c4d3eb80e187056e76f892e061"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Reltre"}}