{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/230821996","pull_request_review_id":171646278,"id":230821996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgyMTk5Ng==","diff_hunk":"@@ -61,9 +61,9 @@ def __init__(self, target,  notify=None, macros=None, build_profile=None,\n         elif target.core.startswith(\"Cortex-M23\"):\n             self.cpu = [\"-mcpu=cortex-m23\"]\n         elif target.core.startswith(\"Cortex-M33F\"):\n-            self.cpu = [\"-mcpu=cortex-m33\"]\n+             self.cpu = [\"-mcpu=cortex-m33+nodsp\"]","path":"tools/toolchains/gcc.py","position":5,"original_position":5,"commit_id":"a0629cc58ecf2a36cdb9d32e93ba868474e07e8c","original_commit_id":"a0629cc58ecf2a36cdb9d32e93ba868474e07e8c","user":{"login":"deepikabhavnani","id":28542450,"node_id":"MDQ6VXNlcjI4NTQyNDUw","avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n            self.cpu = [\"-mcpu=cortex-m33+nodsp\"]\r\n```","created_at":"2018-11-05T16:38:42Z","updated_at":"2018-11-05T16:38:43Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8449#discussion_r230821996","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/230821996"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8449#discussion_r230821996"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449","id":223541039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTQxMDM5","html_url":"https://github.com/ARMmbed/mbed-os/pull/8449","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8449.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8449.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8449","number":8449,"state":"open","locked":false,"title":"TOOLS : Add missing M33 and M33F in python scripts","user":{"login":"jeromecoutant","id":12710147,"node_id":"MDQ6VXNlcjEyNzEwMTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12710147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromecoutant","html_url":"https://github.com/jeromecoutant","followers_url":"https://api.github.com/users/jeromecoutant/followers","following_url":"https://api.github.com/users/jeromecoutant/following{/other_user}","gists_url":"https://api.github.com/users/jeromecoutant/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromecoutant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromecoutant/subscriptions","organizations_url":"https://api.github.com/users/jeromecoutant/orgs","repos_url":"https://api.github.com/users/jeromecoutant/repos","events_url":"https://api.github.com/users/jeromecoutant/events{/privacy}","received_events_url":"https://api.github.com/users/jeromecoutant/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nTried to complete CORTEX_M33 coverage in python scripts.\r\n\r\n\r\n### Pull request type\r\n\r\n    [X] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-10-17T10:02:47Z","updated_at":"2018-11-05T16:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65939ed5bdaad5321368af2d363942103c805f4d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"theotherjimmy","id":685409,"node_id":"MDQ6VXNlcjY4NTQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8449/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/a0629cc58ecf2a36cdb9d32e93ba868474e07e8c","head":{"label":"jeromecoutant:PR_M33","ref":"PR_M33","sha":"a0629cc58ecf2a36cdb9d32e93ba868474e07e8c","user":{"login":"jeromecoutant","id":12710147,"node_id":"MDQ6VXNlcjEyNzEwMTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12710147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromecoutant","html_url":"https://github.com/jeromecoutant","followers_url":"https://api.github.com/users/jeromecoutant/followers","following_url":"https://api.github.com/users/jeromecoutant/following{/other_user}","gists_url":"https://api.github.com/users/jeromecoutant/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromecoutant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromecoutant/subscriptions","organizations_url":"https://api.github.com/users/jeromecoutant/orgs","repos_url":"https://api.github.com/users/jeromecoutant/repos","events_url":"https://api.github.com/users/jeromecoutant/events{/privacy}","received_events_url":"https://api.github.com/users/jeromecoutant/received_events","type":"User","site_admin":false},"repo":{"id":56680851,"node_id":"MDEwOlJlcG9zaXRvcnk1NjY4MDg1MQ==","name":"mbed","full_name":"jeromecoutant/mbed","private":false,"owner":{"login":"jeromecoutant","id":12710147,"node_id":"MDQ6VXNlcjEyNzEwMTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12710147?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromecoutant","html_url":"https://github.com/jeromecoutant","followers_url":"https://api.github.com/users/jeromecoutant/followers","following_url":"https://api.github.com/users/jeromecoutant/following{/other_user}","gists_url":"https://api.github.com/users/jeromecoutant/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromecoutant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromecoutant/subscriptions","organizations_url":"https://api.github.com/users/jeromecoutant/orgs","repos_url":"https://api.github.com/users/jeromecoutant/repos","events_url":"https://api.github.com/users/jeromecoutant/events{/privacy}","received_events_url":"https://api.github.com/users/jeromecoutant/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeromecoutant/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/jeromecoutant/mbed","forks_url":"https://api.github.com/repos/jeromecoutant/mbed/forks","keys_url":"https://api.github.com/repos/jeromecoutant/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeromecoutant/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeromecoutant/mbed/teams","hooks_url":"https://api.github.com/repos/jeromecoutant/mbed/hooks","issue_events_url":"https://api.github.com/repos/jeromecoutant/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/jeromecoutant/mbed/events","assignees_url":"https://api.github.com/repos/jeromecoutant/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/jeromecoutant/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/jeromecoutant/mbed/tags","blobs_url":"https://api.github.com/repos/jeromecoutant/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeromecoutant/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeromecoutant/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeromecoutant/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeromecoutant/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/jeromecoutant/mbed/languages","stargazers_url":"https://api.github.com/repos/jeromecoutant/mbed/stargazers","contributors_url":"https://api.github.com/repos/jeromecoutant/mbed/contributors","subscribers_url":"https://api.github.com/repos/jeromecoutant/mbed/subscribers","subscription_url":"https://api.github.com/repos/jeromecoutant/mbed/subscription","commits_url":"https://api.github.com/repos/jeromecoutant/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeromecoutant/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeromecoutant/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeromecoutant/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeromecoutant/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/jeromecoutant/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeromecoutant/mbed/merges","archive_url":"https://api.github.com/repos/jeromecoutant/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeromecoutant/mbed/downloads","issues_url":"https://api.github.com/repos/jeromecoutant/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/jeromecoutant/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/jeromecoutant/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/jeromecoutant/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeromecoutant/mbed/labels{/name}","releases_url":"https://api.github.com/repos/jeromecoutant/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/jeromecoutant/mbed/deployments","created_at":"2016-04-20T11:20:08Z","updated_at":"2018-09-17T17:04:26Z","pushed_at":"2018-11-05T16:28:06Z","git_url":"git://github.com/jeromecoutant/mbed.git","ssh_url":"git@github.com:jeromecoutant/mbed.git","clone_url":"https://github.com/jeromecoutant/mbed.git","svn_url":"https://github.com/jeromecoutant/mbed","homepage":"","size":226621,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"0e6eac5faac44ea9d9276ef6b0cdcd7bcc73116c","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-11-05T16:19:09Z","pushed_at":"2018-11-05T16:28:08Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":237918,"stargazers_count":2029,"watchers_count":2029,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1660,"mirror_url":null,"archived":false,"open_issues_count":401,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1660,"open_issues":401,"watchers":2029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8449"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8449"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8449/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8449/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/a0629cc58ecf2a36cdb9d32e93ba868474e07e8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deepikabhavnani"}}