{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/hollow/pulls/comments/192495271","pull_request_review_id":125291855,"id":192495271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQ5NTI3MQ==","diff_hunk":"@@ -89,6 +89,11 @@ public void validate(ReadState readState) {\n \t\thandleEndValidation(statusBuilder, Status.SUCCESS, \"\");\n \t}\n \n+\t@Override","path":"hollow/src/main/java/com/netflix/hollow/api/producer/validation/DuplicateDataDetectionValidator.java","position":4,"original_position":4,"commit_id":"e054bdf99a4b60b80d7a0dc134b972a1112195a5","original_commit_id":"e054bdf99a4b60b80d7a0dc134b972a1112195a5","user":{"login":"toolbear","id":358202,"node_id":"MDQ6VXNlcjM1ODIwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/358202?v=4","gravatar_id":"","url":"https://api.github.com/users/toolbear","html_url":"https://github.com/toolbear","followers_url":"https://api.github.com/users/toolbear/followers","following_url":"https://api.github.com/users/toolbear/following{/other_user}","gists_url":"https://api.github.com/users/toolbear/gists{/gist_id}","starred_url":"https://api.github.com/users/toolbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolbear/subscriptions","organizations_url":"https://api.github.com/users/toolbear/orgs","repos_url":"https://api.github.com/users/toolbear/repos","events_url":"https://api.github.com/users/toolbear/events{/privacy}","received_events_url":"https://api.github.com/users/toolbear/received_events","type":"User","site_admin":false},"body":"...and this can go away and rely on the default method","created_at":"2018-06-01T19:35:11Z","updated_at":"2018-06-01T19:39:53Z","html_url":"https://github.com/Netflix/hollow/pull/208#discussion_r192495271","pull_request_url":"https://api.github.com/repos/Netflix/hollow/pulls/208","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/comments/192495271"},"html":{"href":"https://github.com/Netflix/hollow/pull/208#discussion_r192495271"},"pull_request":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/hollow/pulls/208","id":183734851,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNzM0ODUx","html_url":"https://github.com/Netflix/hollow/pull/208","diff_url":"https://github.com/Netflix/hollow/pull/208.diff","patch_url":"https://github.com/Netflix/hollow/pull/208.patch","issue_url":"https://api.github.com/repos/Netflix/hollow/issues/208","number":208,"state":"open","locked":false,"title":"introduce RecordCountValidator variance at runtime","user":{"login":"rpalcolea","id":1625920,"node_id":"MDQ6VXNlcjE2MjU5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1625920?v=4","gravatar_id":"","url":"https://api.github.com/users/rpalcolea","html_url":"https://github.com/rpalcolea","followers_url":"https://api.github.com/users/rpalcolea/followers","following_url":"https://api.github.com/users/rpalcolea/following{/other_user}","gists_url":"https://api.github.com/users/rpalcolea/gists{/gist_id}","starred_url":"https://api.github.com/users/rpalcolea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpalcolea/subscriptions","organizations_url":"https://api.github.com/users/rpalcolea/orgs","repos_url":"https://api.github.com/users/rpalcolea/repos","events_url":"https://api.github.com/users/rpalcolea/events{/privacy}","received_events_url":"https://api.github.com/users/rpalcolea/received_events","type":"User","site_admin":false},"body":"This is for https://github.com/Netflix/hollow/issues/204\r\n\r\nIntroduces a breaking change in the `Validator` by adding `lock` method.\r\n\r\nThe idea would be that users could do some changes to their validators on runtime and once a cycle gets into the validation state, this would happen:\r\n\r\n```\r\nvalidator.lock();\r\nvalidator.validate(readState);\r\n```\r\n\r\nFrom the `RecordCountVarianceValidator`, `lock` assigns the `allowableVariancePercent` to `cycleAllowableVariancePercent` which is used for the validation. This way, `allowableVariancePercent` could change any time via `updateVariancePercent` without affecting the current cycle.\r\n\r\nOther idea in order to prevent breaking changes:\r\n\r\n* Introduce a `ValidatorV2` interface (same way it happened with the `Listeners`) which would contain `validate(readState)` and `lock`. \r\n* Introduce a `DynamicRecordCountVarianceValidator` that uses `ValidatorV2` and has the functionality in https://github.com/Netflix/hollow/issues/204.\r\n\r\nI'm also asking myself if `lock` is a good name or perhaps use something like `prepareForReadStateValidation` to keep the semantics\r\n\r\nThoughts @toolbear @akhaku ?","created_at":"2018-04-24T13:24:21Z","updated_at":"2018-06-01T19:39:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e01b80baf0f38df3a0b752e0521b0b53e982d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/hollow/pulls/208/commits","review_comments_url":"https://api.github.com/repos/Netflix/hollow/pulls/208/comments","review_comment_url":"https://api.github.com/repos/Netflix/hollow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/hollow/issues/208/comments","statuses_url":"https://api.github.com/repos/Netflix/hollow/statuses/e054bdf99a4b60b80d7a0dc134b972a1112195a5","head":{"label":"rpalcolea:RecordCountValidator-variance-runtime","ref":"RecordCountValidator-variance-runtime","sha":"e054bdf99a4b60b80d7a0dc134b972a1112195a5","user":{"login":"rpalcolea","id":1625920,"node_id":"MDQ6VXNlcjE2MjU5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1625920?v=4","gravatar_id":"","url":"https://api.github.com/users/rpalcolea","html_url":"https://github.com/rpalcolea","followers_url":"https://api.github.com/users/rpalcolea/followers","following_url":"https://api.github.com/users/rpalcolea/following{/other_user}","gists_url":"https://api.github.com/users/rpalcolea/gists{/gist_id}","starred_url":"https://api.github.com/users/rpalcolea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpalcolea/subscriptions","organizations_url":"https://api.github.com/users/rpalcolea/orgs","repos_url":"https://api.github.com/users/rpalcolea/repos","events_url":"https://api.github.com/users/rpalcolea/events{/privacy}","received_events_url":"https://api.github.com/users/rpalcolea/received_events","type":"User","site_admin":false},"repo":{"id":101247182,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNDcxODI=","name":"hollow","full_name":"rpalcolea/hollow","owner":{"login":"rpalcolea","id":1625920,"node_id":"MDQ6VXNlcjE2MjU5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1625920?v=4","gravatar_id":"","url":"https://api.github.com/users/rpalcolea","html_url":"https://github.com/rpalcolea","followers_url":"https://api.github.com/users/rpalcolea/followers","following_url":"https://api.github.com/users/rpalcolea/following{/other_user}","gists_url":"https://api.github.com/users/rpalcolea/gists{/gist_id}","starred_url":"https://api.github.com/users/rpalcolea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpalcolea/subscriptions","organizations_url":"https://api.github.com/users/rpalcolea/orgs","repos_url":"https://api.github.com/users/rpalcolea/repos","events_url":"https://api.github.com/users/rpalcolea/events{/privacy}","received_events_url":"https://api.github.com/users/rpalcolea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpalcolea/hollow","description":"Hollow is a java library and toolset for disseminating in-memory datasets from a single producer to many consumers for high performance read-only access.","fork":true,"url":"https://api.github.com/repos/rpalcolea/hollow","forks_url":"https://api.github.com/repos/rpalcolea/hollow/forks","keys_url":"https://api.github.com/repos/rpalcolea/hollow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpalcolea/hollow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpalcolea/hollow/teams","hooks_url":"https://api.github.com/repos/rpalcolea/hollow/hooks","issue_events_url":"https://api.github.com/repos/rpalcolea/hollow/issues/events{/number}","events_url":"https://api.github.com/repos/rpalcolea/hollow/events","assignees_url":"https://api.github.com/repos/rpalcolea/hollow/assignees{/user}","branches_url":"https://api.github.com/repos/rpalcolea/hollow/branches{/branch}","tags_url":"https://api.github.com/repos/rpalcolea/hollow/tags","blobs_url":"https://api.github.com/repos/rpalcolea/hollow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpalcolea/hollow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpalcolea/hollow/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpalcolea/hollow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpalcolea/hollow/statuses/{sha}","languages_url":"https://api.github.com/repos/rpalcolea/hollow/languages","stargazers_url":"https://api.github.com/repos/rpalcolea/hollow/stargazers","contributors_url":"https://api.github.com/repos/rpalcolea/hollow/contributors","subscribers_url":"https://api.github.com/repos/rpalcolea/hollow/subscribers","subscription_url":"https://api.github.com/repos/rpalcolea/hollow/subscription","commits_url":"https://api.github.com/repos/rpalcolea/hollow/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpalcolea/hollow/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpalcolea/hollow/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpalcolea/hollow/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpalcolea/hollow/contents/{+path}","compare_url":"https://api.github.com/repos/rpalcolea/hollow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpalcolea/hollow/merges","archive_url":"https://api.github.com/repos/rpalcolea/hollow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpalcolea/hollow/downloads","issues_url":"https://api.github.com/repos/rpalcolea/hollow/issues{/number}","pulls_url":"https://api.github.com/repos/rpalcolea/hollow/pulls{/number}","milestones_url":"https://api.github.com/repos/rpalcolea/hollow/milestones{/number}","notifications_url":"https://api.github.com/repos/rpalcolea/hollow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpalcolea/hollow/labels{/name}","releases_url":"https://api.github.com/repos/rpalcolea/hollow/releases{/id}","deployments_url":"https://api.github.com/repos/rpalcolea/hollow/deployments","created_at":"2017-08-24T02:52:05Z","updated_at":"2017-08-24T02:52:09Z","pushed_at":"2018-05-04T14:35:25Z","git_url":"git://github.com/rpalcolea/hollow.git","ssh_url":"git@github.com:rpalcolea/hollow.git","clone_url":"https://github.com/rpalcolea/hollow.git","svn_url":"https://github.com/rpalcolea/hollow","homepage":null,"size":3781,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"062b80dbc1cdd40ebc98ed1874ef60171a46deea","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":75422566,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQyMjU2Ng==","name":"hollow","full_name":"Netflix/hollow","owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/hollow","description":"Hollow is a java library and toolset for disseminating in-memory datasets from a single producer to many consumers for high performance read-only access.","fork":false,"url":"https://api.github.com/repos/Netflix/hollow","forks_url":"https://api.github.com/repos/Netflix/hollow/forks","keys_url":"https://api.github.com/repos/Netflix/hollow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/hollow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/hollow/teams","hooks_url":"https://api.github.com/repos/Netflix/hollow/hooks","issue_events_url":"https://api.github.com/repos/Netflix/hollow/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/hollow/events","assignees_url":"https://api.github.com/repos/Netflix/hollow/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/hollow/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/hollow/tags","blobs_url":"https://api.github.com/repos/Netflix/hollow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/hollow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/hollow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/hollow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/hollow/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/hollow/languages","stargazers_url":"https://api.github.com/repos/Netflix/hollow/stargazers","contributors_url":"https://api.github.com/repos/Netflix/hollow/contributors","subscribers_url":"https://api.github.com/repos/Netflix/hollow/subscribers","subscription_url":"https://api.github.com/repos/Netflix/hollow/subscription","commits_url":"https://api.github.com/repos/Netflix/hollow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/hollow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/hollow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/hollow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/hollow/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/hollow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/hollow/merges","archive_url":"https://api.github.com/repos/Netflix/hollow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/hollow/downloads","issues_url":"https://api.github.com/repos/Netflix/hollow/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/hollow/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/hollow/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/hollow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/hollow/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/hollow/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/hollow/deployments","created_at":"2016-12-02T18:56:43Z","updated_at":"2018-06-01T01:58:02Z","pushed_at":"2018-06-01T19:32:08Z","git_url":"git://github.com/Netflix/hollow.git","ssh_url":"git@github.com:Netflix/hollow.git","clone_url":"https://github.com/Netflix/hollow.git","svn_url":"https://github.com/Netflix/hollow","homepage":null,"size":4104,"stargazers_count":674,"watchers_count":674,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":27,"watchers":674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/208"},"html":{"href":"https://github.com/Netflix/hollow/pull/208"},"issue":{"href":"https://api.github.com/repos/Netflix/hollow/issues/208"},"comments":{"href":"https://api.github.com/repos/Netflix/hollow/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/hollow/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/hollow/statuses/e054bdf99a4b60b80d7a0dc134b972a1112195a5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"toolbear"}}