{"action":"created","issue":{"url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/101","repository_url":"https://api.github.com/repos/sonyxperiadev/bug_tracker","labels_url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/101/comments","events_url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/101/events","html_url":"https://github.com/sonyxperiadev/bug_tracker/issues/101","id":305923963,"node_id":"MDU6SXNzdWUzMDU5MjM5NjM=","number":101,"title":"[Nile] - Android 8.1 - FPC is not recognised (on devices using Egistec HW)","user":{"login":"jerpelea","id":7842698,"node_id":"MDQ6VXNlcjc4NDI2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7842698?v=4","gravatar_id":"","url":"https://api.github.com/users/jerpelea","html_url":"https://github.com/jerpelea","followers_url":"https://api.github.com/users/jerpelea/followers","following_url":"https://api.github.com/users/jerpelea/following{/other_user}","gists_url":"https://api.github.com/users/jerpelea/gists{/gist_id}","starred_url":"https://api.github.com/users/jerpelea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerpelea/subscriptions","organizations_url":"https://api.github.com/users/jerpelea/orgs","repos_url":"https://api.github.com/users/jerpelea/repos","events_url":"https://api.github.com/users/jerpelea/events{/privacy}","received_events_url":"https://api.github.com/users/jerpelea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-16T13:16:56Z","updated_at":"2018-11-16T09:09:10Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Platform:** Nile\r\n**Device:** XA2, XA2 Ultra\r\n**Kernel version:** 4.4\r\n**Android version:** 8.x\r\n\r\n**Description**\r\nIn settings there is no Fingerprint option \r\n\r\n**Symptoms**\r\nIn settings there is no Fingerprint option \r\n\r\n**How to reproduce**\r\nOpen settings "},"comment":{"url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/comments/439328654","html_url":"https://github.com/sonyxperiadev/bug_tracker/issues/101#issuecomment-439328654","issue_url":"https://api.github.com/repos/sonyxperiadev/bug_tracker/issues/101","id":439328654,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTMyODY1NA==","user":{"login":"MarijnS95","id":2325264,"node_id":"MDQ6VXNlcjIzMjUyNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2325264?v=4","gravatar_id":"","url":"https://api.github.com/users/MarijnS95","html_url":"https://github.com/MarijnS95","followers_url":"https://api.github.com/users/MarijnS95/followers","following_url":"https://api.github.com/users/MarijnS95/following{/other_user}","gists_url":"https://api.github.com/users/MarijnS95/gists{/gist_id}","starred_url":"https://api.github.com/users/MarijnS95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarijnS95/subscriptions","organizations_url":"https://api.github.com/users/MarijnS95/orgs","repos_url":"https://api.github.com/users/MarijnS95/repos","events_url":"https://api.github.com/users/MarijnS95/events{/privacy}","received_events_url":"https://api.github.com/users/MarijnS95/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T09:09:10Z","updated_at":"2018-11-16T09:09:10Z","author_association":"NONE","body":"@dimitar10 Sorry for the huge delay. A couple high-priority projects depleted all my free time the past month. Luckily the proper (re)implementation is nicely underway, with only the large operations (enumerate/authenticate) to be finished (apparently I haven't mentioned here that I had a working-but-messy HAL weeks ago). With all the information gathered thus far it's only a matter of writing code now :smile:. Looks like that's going to be finished this weekend, after which you should be able to fetch the code, compile, and test it. Before I forget: fpc needs to be disabled in the kernel, and the proper `user:group` must be set on `/dev/esfp0`.\r\n\r\nThen there's more changes before this can be fully merged/integrated with SODP:\r\n- Find out if we can merge the kernel drivers (they are incredibly similar, already checked that) and reuse the sodp `/dev/fingerprint` interface.\r\n- Figure out how to detect which fingerprint sensor is installed on the device. Stock kernel uses [this](https://github.com/sonyxperiadev/kernel-copyleft/blob/84596bf99ed5dd9debbda2d53aece967672e5a3d/drivers/cei/cei_hw_id.c#L150-L174), but according to others this does not work (eg. always returning `0`). If we have such a method it is as simple as switching between the two (C++ class-)implementations of `BiometricsFingerprint` within the HAL at runtime (though one of the kernel drivers should be disabled: right now the fpc driver sets some power settings first, causing an error in the et510 driver).\r\n- (Depending on the driver merge) Update SEPolicy for the new paths.\r\n\r\nSo for now there's not much to help with until I finish the remaining bits and push it to github. At that point, feel free to test the implementation, review the code (my design/architecture skills aren't where I want them to be), and think along with the aforementioned points."}}
{"actor":{"display_login":"MarijnS95"}}