{"action":"created","comment":{"url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/comments/208248366","pull_request_review_id":144016910,"id":208248366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI0ODM2Ng==","diff_hunk":"@@ -2016,6 +2016,18 @@\n                       {\n                         \"name\": \"y\",\n                         \"type\": \"i8\"\n+\t\t\t\t\t  },\n+                      {\n+                        \"name\": \"direction\",\n+                        \"type\": \"i8\"\n+\t\t\t\t\t  },\n+                      {\n+                        \"name\": \"hasDisplayName\",\n+                        \"type\": \"bool\"\n+                      },\n+                      {\n+                        \"name\": \"displayName\",\n+                        \"type\": [\"option\", \"string\"]","path":"data/pc/1.13/protocol.json","position":2093,"original_position":26,"commit_id":"50c7895adda860cc6a9f47ca2b65c184cee738a4","original_commit_id":"990e931275095bf3912fc7b1a4b6a9653482b981","user":{"login":"AnthonyTsang","id":5319739,"node_id":"MDQ6VXNlcjUzMTk3Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5319739?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyTsang","html_url":"https://github.com/AnthonyTsang","followers_url":"https://api.github.com/users/AnthonyTsang/followers","following_url":"https://api.github.com/users/AnthonyTsang/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyTsang/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyTsang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyTsang/subscriptions","organizations_url":"https://api.github.com/users/AnthonyTsang/orgs","repos_url":"https://api.github.com/users/AnthonyTsang/repos","events_url":"https://api.github.com/users/AnthonyTsang/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyTsang/received_events","type":"User","site_admin":false},"body":"Say we have a packet\r\n```\r\n01 02 03 04 05 \r\n```\r\nthere are 5 bytes in total.\r\nAssume boolean takes 1 byte and string takes 4 bytes.\r\n\r\n```\r\n{\r\n  \"name\": \"displayName\",\r\n  \"type\": [\"option\", \"string\"]\r\n}\r\n```\r\nmeans the first byte is a boolean flag and the rest is a string. It correctly parses the packet and name the last 4 bytes to \"displayName\".\r\n\r\nWhereas,\r\n```\r\n{\r\n  \"name\": \"hasDispalyName\",\r\n  \"type\": \"bool\"\r\n},\r\n{\r\n  \"name\": \"displayName\",\r\n  \"type\": [\"option\", \"string\"]\r\n}\r\n```\r\nMeans the first byte is a boolean flag and name it to `hasDispalyName`. The next byte is another boolean flag, and the rest of the bytes is a string but only 3 bytes left, so there is a mismatch.","created_at":"2018-08-07T14:16:25Z","updated_at":"2018-08-07T14:16:25Z","html_url":"https://github.com/PrismarineJS/minecraft-data/pull/201#discussion_r208248366","pull_request_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/comments/208248366"},"html":{"href":"https://github.com/PrismarineJS/minecraft-data/pull/201#discussion_r208248366"},"pull_request":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201"}},"in_reply_to_id":208239831},"pull_request":{"url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201","id":206240817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQwODE3","html_url":"https://github.com/PrismarineJS/minecraft-data/pull/201","diff_url":"https://github.com/PrismarineJS/minecraft-data/pull/201.diff","patch_url":"https://github.com/PrismarineJS/minecraft-data/pull/201.patch","issue_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/201","number":201,"state":"open","locked":false,"title":"1.13 Support","user":{"login":"lluiscab","id":7149212,"node_id":"MDQ6VXNlcjcxNDkyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7149212?v=4","gravatar_id":"","url":"https://api.github.com/users/lluiscab","html_url":"https://github.com/lluiscab","followers_url":"https://api.github.com/users/lluiscab/followers","following_url":"https://api.github.com/users/lluiscab/following{/other_user}","gists_url":"https://api.github.com/users/lluiscab/gists{/gist_id}","starred_url":"https://api.github.com/users/lluiscab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluiscab/subscriptions","organizations_url":"https://api.github.com/users/lluiscab/orgs","repos_url":"https://api.github.com/users/lluiscab/repos","events_url":"https://api.github.com/users/lluiscab/events{/privacy}","received_events_url":"https://api.github.com/users/lluiscab/received_events","type":"User","site_admin":false},"body":"On my way to fix #200 \r\n\r\n## TO DO List:\r\n\r\n- [x] Fix indentation\r\n\r\n### Login state\r\n\r\n#### Client\r\n- [x] 0x04 login_plugin_request\r\n\r\n#### Server\r\n- [x] 0x02 login_plugin_response\r\n\r\n### Play state\r\n\r\n#### Client\r\n- [x] 0x11 declare_commands\r\n- [x] 0x1d nbt_query_response\r\n- [x] 0x31 face_player\r\n- [x] 0x4c stop_sound\r\n- [x] 0x54 declare_recipes\r\n- [x] 0x55 tags\r\n\r\n#### Server\r\n- [x] 0x01 query_block_nbt\r\n- [x] 0x0b edit_book\r\n- [x] 0x0c query_entity_nbt\r\n- [x] 0x15 pick_item\r\n- [x] 0x1c name_item\r\n- [x] 0x1f select_trade\r\n- [x] 0x20 set_beacon_effect\r\n- [x] 0x22 update_command_block\r\n- [x] 0x23 update_command_block_minecart\r\n- [x] 0x25 update_structure_block\r\n","created_at":"2018-08-05T14:15:13Z","updated_at":"2018-08-07T14:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef417e0ee55558bc94320070e59eebc22b91c6d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201/commits","review_comments_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201/comments","review_comment_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/201/comments","statuses_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/statuses/50c7895adda860cc6a9f47ca2b65c184cee738a4","head":{"label":"lluiscab:1.13","ref":"1.13","sha":"50c7895adda860cc6a9f47ca2b65c184cee738a4","user":{"login":"lluiscab","id":7149212,"node_id":"MDQ6VXNlcjcxNDkyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7149212?v=4","gravatar_id":"","url":"https://api.github.com/users/lluiscab","html_url":"https://github.com/lluiscab","followers_url":"https://api.github.com/users/lluiscab/followers","following_url":"https://api.github.com/users/lluiscab/following{/other_user}","gists_url":"https://api.github.com/users/lluiscab/gists{/gist_id}","starred_url":"https://api.github.com/users/lluiscab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluiscab/subscriptions","organizations_url":"https://api.github.com/users/lluiscab/orgs","repos_url":"https://api.github.com/users/lluiscab/repos","events_url":"https://api.github.com/users/lluiscab/events{/privacy}","received_events_url":"https://api.github.com/users/lluiscab/received_events","type":"User","site_admin":false},"repo":{"id":143615227,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MTUyMjc=","name":"minecraft-data","full_name":"lluiscab/minecraft-data","owner":{"login":"lluiscab","id":7149212,"node_id":"MDQ6VXNlcjcxNDkyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7149212?v=4","gravatar_id":"","url":"https://api.github.com/users/lluiscab","html_url":"https://github.com/lluiscab","followers_url":"https://api.github.com/users/lluiscab/followers","following_url":"https://api.github.com/users/lluiscab/following{/other_user}","gists_url":"https://api.github.com/users/lluiscab/gists{/gist_id}","starred_url":"https://api.github.com/users/lluiscab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluiscab/subscriptions","organizations_url":"https://api.github.com/users/lluiscab/orgs","repos_url":"https://api.github.com/users/lluiscab/repos","events_url":"https://api.github.com/users/lluiscab/events{/privacy}","received_events_url":"https://api.github.com/users/lluiscab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lluiscab/minecraft-data","description":"Language independent module providing minecraft data for minecraft clients, servers and libraries.","fork":true,"url":"https://api.github.com/repos/lluiscab/minecraft-data","forks_url":"https://api.github.com/repos/lluiscab/minecraft-data/forks","keys_url":"https://api.github.com/repos/lluiscab/minecraft-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lluiscab/minecraft-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lluiscab/minecraft-data/teams","hooks_url":"https://api.github.com/repos/lluiscab/minecraft-data/hooks","issue_events_url":"https://api.github.com/repos/lluiscab/minecraft-data/issues/events{/number}","events_url":"https://api.github.com/repos/lluiscab/minecraft-data/events","assignees_url":"https://api.github.com/repos/lluiscab/minecraft-data/assignees{/user}","branches_url":"https://api.github.com/repos/lluiscab/minecraft-data/branches{/branch}","tags_url":"https://api.github.com/repos/lluiscab/minecraft-data/tags","blobs_url":"https://api.github.com/repos/lluiscab/minecraft-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lluiscab/minecraft-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lluiscab/minecraft-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/lluiscab/minecraft-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lluiscab/minecraft-data/statuses/{sha}","languages_url":"https://api.github.com/repos/lluiscab/minecraft-data/languages","stargazers_url":"https://api.github.com/repos/lluiscab/minecraft-data/stargazers","contributors_url":"https://api.github.com/repos/lluiscab/minecraft-data/contributors","subscribers_url":"https://api.github.com/repos/lluiscab/minecraft-data/subscribers","subscription_url":"https://api.github.com/repos/lluiscab/minecraft-data/subscription","commits_url":"https://api.github.com/repos/lluiscab/minecraft-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/lluiscab/minecraft-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/lluiscab/minecraft-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/lluiscab/minecraft-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/lluiscab/minecraft-data/contents/{+path}","compare_url":"https://api.github.com/repos/lluiscab/minecraft-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lluiscab/minecraft-data/merges","archive_url":"https://api.github.com/repos/lluiscab/minecraft-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lluiscab/minecraft-data/downloads","issues_url":"https://api.github.com/repos/lluiscab/minecraft-data/issues{/number}","pulls_url":"https://api.github.com/repos/lluiscab/minecraft-data/pulls{/number}","milestones_url":"https://api.github.com/repos/lluiscab/minecraft-data/milestones{/number}","notifications_url":"https://api.github.com/repos/lluiscab/minecraft-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lluiscab/minecraft-data/labels{/name}","releases_url":"https://api.github.com/repos/lluiscab/minecraft-data/releases{/id}","deployments_url":"https://api.github.com/repos/lluiscab/minecraft-data/deployments","created_at":"2018-08-05T13:30:15Z","updated_at":"2018-08-05T13:30:17Z","pushed_at":"2018-08-07T14:09:52Z","git_url":"git://github.com/lluiscab/minecraft-data.git","ssh_url":"git@github.com:lluiscab/minecraft-data.git","clone_url":"https://github.com/lluiscab/minecraft-data.git","svn_url":"https://github.com/lluiscab/minecraft-data","homepage":"http://minecraft-data.prismarine.js.org/","size":2072,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrismarineJS:master","ref":"master","sha":"dee6969743c79b50d66770b8e2ed2aa67762d014","user":{"login":"PrismarineJS","id":11053411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDUzNDEx","avatar_url":"https://avatars1.githubusercontent.com/u/11053411?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismarineJS","html_url":"https://github.com/PrismarineJS","followers_url":"https://api.github.com/users/PrismarineJS/followers","following_url":"https://api.github.com/users/PrismarineJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismarineJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismarineJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismarineJS/subscriptions","organizations_url":"https://api.github.com/users/PrismarineJS/orgs","repos_url":"https://api.github.com/users/PrismarineJS/repos","events_url":"https://api.github.com/users/PrismarineJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismarineJS/received_events","type":"Organization","site_admin":false},"repo":{"id":32741498,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc0MTQ5OA==","name":"minecraft-data","full_name":"PrismarineJS/minecraft-data","owner":{"login":"PrismarineJS","id":11053411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDUzNDEx","avatar_url":"https://avatars1.githubusercontent.com/u/11053411?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismarineJS","html_url":"https://github.com/PrismarineJS","followers_url":"https://api.github.com/users/PrismarineJS/followers","following_url":"https://api.github.com/users/PrismarineJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismarineJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismarineJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismarineJS/subscriptions","organizations_url":"https://api.github.com/users/PrismarineJS/orgs","repos_url":"https://api.github.com/users/PrismarineJS/repos","events_url":"https://api.github.com/users/PrismarineJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismarineJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrismarineJS/minecraft-data","description":"Language independent module providing minecraft data for minecraft clients, servers and libraries.","fork":false,"url":"https://api.github.com/repos/PrismarineJS/minecraft-data","forks_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/forks","keys_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/teams","hooks_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/hooks","issue_events_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/events{/number}","events_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/events","assignees_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/assignees{/user}","branches_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/branches{/branch}","tags_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/tags","blobs_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/languages","stargazers_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/stargazers","contributors_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/contributors","subscribers_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/subscribers","subscription_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/subscription","commits_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/contents/{+path}","compare_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/merges","archive_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/downloads","issues_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues{/number}","pulls_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/labels{/name}","releases_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/releases{/id}","deployments_url":"https://api.github.com/repos/PrismarineJS/minecraft-data/deployments","created_at":"2015-03-23T15:38:19Z","updated_at":"2018-07-30T13:14:08Z","pushed_at":"2018-08-07T14:09:54Z","git_url":"git://github.com/PrismarineJS/minecraft-data.git","ssh_url":"git@github.com:PrismarineJS/minecraft-data.git","clone_url":"https://github.com/PrismarineJS/minecraft-data.git","svn_url":"https://github.com/PrismarineJS/minecraft-data","homepage":"http://minecraft-data.prismarine.js.org/","size":2749,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":64,"license":null,"forks":28,"open_issues":64,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201"},"html":{"href":"https://github.com/PrismarineJS/minecraft-data/pull/201"},"issue":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/201"},"comments":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/PrismarineJS/minecraft-data/statuses/50c7895adda860cc6a9f47ca2b65c184cee738a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"AnthonyTsang"}}