{"action":"closed","number":1640,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1640","id":171969076,"html_url":"https://github.com/ocaml/ocaml/pull/1640","diff_url":"https://github.com/ocaml/ocaml/pull/1640.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1640.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1640","number":1640,"state":"closed","locked":false,"title":"ocamldep: colored error message for -sort","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars1.githubusercontent.com/u/7689388?v=4","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"body":"This small PR is a follow-up to #1578 : it aligns the appearance of the error message for `ocamldep -sort` with the ones raised for parsing errors. In order to avoid duplicating code (notably the color setup), it exposes `Location.print_error_prefix` function since the available error printing functions were not really a good fit here.","created_at":"2018-02-28T14:29:56Z","updated_at":"2018-02-28T18:48:51Z","closed_at":"2018-02-28T18:48:51Z","merged_at":"2018-02-28T18:48:51Z","merge_commit_sha":"5515a5f3b05b32c8361909b71e40da317f6cbade","assignee":{"login":"diml","id":1251584,"avatar_url":"https://avatars1.githubusercontent.com/u/1251584?v=4","gravatar_id":"","url":"https://api.github.com/users/diml","html_url":"https://github.com/diml","followers_url":"https://api.github.com/users/diml/followers","following_url":"https://api.github.com/users/diml/following{/other_user}","gists_url":"https://api.github.com/users/diml/gists{/gist_id}","starred_url":"https://api.github.com/users/diml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diml/subscriptions","organizations_url":"https://api.github.com/users/diml/orgs","repos_url":"https://api.github.com/users/diml/repos","events_url":"https://api.github.com/users/diml/events{/privacy}","received_events_url":"https://api.github.com/users/diml/received_events","type":"User","site_admin":false},"assignees":[{"login":"diml","id":1251584,"avatar_url":"https://avatars1.githubusercontent.com/u/1251584?v=4","gravatar_id":"","url":"https://api.github.com/users/diml","html_url":"https://github.com/diml","followers_url":"https://api.github.com/users/diml/followers","following_url":"https://api.github.com/users/diml/following{/other_user}","gists_url":"https://api.github.com/users/diml/gists{/gist_id}","starred_url":"https://api.github.com/users/diml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diml/subscriptions","organizations_url":"https://api.github.com/users/diml/orgs","repos_url":"https://api.github.com/users/diml/repos","events_url":"https://api.github.com/users/diml/events{/privacy}","received_events_url":"https://api.github.com/users/diml/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":489423308,"url":"https://api.github.com/repos/ocaml/ocaml/labels/no-change-entry-needed","name":"no-change-entry-needed","color":"FFFFFF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1640/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1640/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1640/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/b494ac7b06f827c637f7701ecdb1a4df3933f972","head":{"label":"Octachron:colored_ocamldep_cycle_error","ref":"colored_ocamldep_cycle_error","sha":"b494ac7b06f827c637f7701ecdb1a4df3933f972","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars1.githubusercontent.com/u/7689388?v=4","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"repo":{"id":20154083,"name":"ocaml","full_name":"Octachron/ocaml","owner":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars1.githubusercontent.com/u/7689388?v=4","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Octachron/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/Octachron/ocaml","forks_url":"https://api.github.com/repos/Octachron/ocaml/forks","keys_url":"https://api.github.com/repos/Octachron/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Octachron/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Octachron/ocaml/teams","hooks_url":"https://api.github.com/repos/Octachron/ocaml/hooks","issue_events_url":"https://api.github.com/repos/Octachron/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/Octachron/ocaml/events","assignees_url":"https://api.github.com/repos/Octachron/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/Octachron/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/Octachron/ocaml/tags","blobs_url":"https://api.github.com/repos/Octachron/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Octachron/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Octachron/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Octachron/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Octachron/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Octachron/ocaml/languages","stargazers_url":"https://api.github.com/repos/Octachron/ocaml/stargazers","contributors_url":"https://api.github.com/repos/Octachron/ocaml/contributors","subscribers_url":"https://api.github.com/repos/Octachron/ocaml/subscribers","subscription_url":"https://api.github.com/repos/Octachron/ocaml/subscription","commits_url":"https://api.github.com/repos/Octachron/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Octachron/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Octachron/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Octachron/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Octachron/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/Octachron/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Octachron/ocaml/merges","archive_url":"https://api.github.com/repos/Octachron/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Octachron/ocaml/downloads","issues_url":"https://api.github.com/repos/Octachron/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/Octachron/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Octachron/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Octachron/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Octachron/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/Octachron/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/Octachron/ocaml/deployments","created_at":"2014-05-25T12:35:17Z","updated_at":"2018-02-26T14:30:53Z","pushed_at":"2018-02-28T14:08:17Z","git_url":"git://github.com/Octachron/ocaml.git","ssh_url":"git@github.com:Octachron/ocaml.git","clone_url":"https://github.com/Octachron/ocaml.git","svn_url":"https://github.com/Octachron/ocaml","homepage":null,"size":173435,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"e6df2bb1cd7ac9460fbaf15048ba6dce6f8b3f05","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-02-28T17:57:40Z","pushed_at":"2018-02-28T18:48:51Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":161442,"stargazers_count":1717,"watchers_count":1717,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":441,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":441,"open_issues":162,"watchers":1717,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1640"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1640"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1640"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1640/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1640/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1640/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/b494ac7b06f827c637f7701ecdb1a4df3933f972"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gasche","id":426238,"avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"gasche"}}