{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1484","repository_url":"https://api.github.com/repos/apple/swift-corelibs-foundation","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1484/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1484/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1484/events","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1484","id":306630493,"number":1484,"title":"[string] Wean off of no-longer-supported String non-API","user":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-19T20:52:02Z","updated_at":"2018-03-21T21:03:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1484","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1484","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1484.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1484.patch"},"body":"String's _core disappeared, but we kept around a mock-up of it as a\r\nfaux-SPI to avoid breaking Foundation. However, it does not fully\r\nmodel String, and the illusion is broken from small string support."},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments/375094683","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1484#issuecomment-375094683","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1484","id":375094683,"user":{"login":"itaiferber","id":33716,"avatar_url":"https://avatars3.githubusercontent.com/u/33716?v=4","gravatar_id":"","url":"https://api.github.com/users/itaiferber","html_url":"https://github.com/itaiferber","followers_url":"https://api.github.com/users/itaiferber/followers","following_url":"https://api.github.com/users/itaiferber/following{/other_user}","gists_url":"https://api.github.com/users/itaiferber/gists{/gist_id}","starred_url":"https://api.github.com/users/itaiferber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaiferber/subscriptions","organizations_url":"https://api.github.com/users/itaiferber/orgs","repos_url":"https://api.github.com/users/itaiferber/repos","events_url":"https://api.github.com/users/itaiferber/events{/privacy}","received_events_url":"https://api.github.com/users/itaiferber/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T21:03:03Z","updated_at":"2018-03-21T21:03:03Z","author_association":"CONTRIBUTOR","body":"@airspeedswift The second — no one externally should be using `_fastCStringContents`, same as on Darwin. We use `_fastCStringContents` as a fast-path internally in many places on Darwin, so the idea would be to enable the same optimizations here. If this was unsafe, I agree that we should find out what this was doing, and either try to enable it through the correct API, or learn why it was wrong.\r\n\r\nBut again, I didn't write this, so I don't know the specifics. @phausler would know best."}}
{"actor":{"display_login":"itaiferber"}}