{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/204134096","pull_request_review_id":139166986,"id":204134096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEzNDA5Ng==","diff_hunk":"@@ -1735,7 +1737,14 @@ class OSD : public Dispatcher,\n       auto &&sdata = osd->shards[shard_index];\n       assert(sdata);\n       Mutex::Locker l(sdata->shard_lock);\n-      return sdata->pqueue->empty();\n+      return sdata->pqueue->empty() && sdata->context_queue.empty();\n+    }\n+\n+    void handle_oncommits(list<Context*>& oncommits) {\n+      if (!oncommits.empty()) {","path":"src/osd/OSD.h","position":29,"original_position":29,"commit_id":"0e04e661e3121297a877e6e7bcf8da277789e569","original_commit_id":"db5b046677226a31e6753d3b3507778b1db647d6","user":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"Does this 'if' actually help anything?","created_at":"2018-07-20T18:34:37Z","updated_at":"2018-07-20T18:34:37Z","html_url":"https://github.com/ceph/ceph/pull/22739#discussion_r204134096","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/22739","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/204134096"},"html":{"href":"https://github.com/ceph/ceph/pull/22739#discussion_r204134096"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22739"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/22739","id":197771297,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzcxMjk3","html_url":"https://github.com/ceph/ceph/pull/22739","diff_url":"https://github.com/ceph/ceph/pull/22739.diff","patch_url":"https://github.com/ceph/ceph/pull/22739.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/22739","number":22739,"state":"open","locked":false,"title":"[RFC]os/bluestore: make osd shard-thread do oncommits.","user":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"body":"The benefits:\r\na)remove finisher threads\r\nb)avoid racing of pg lock.\r\nFor some workload, this can decreased performance.\r\n\r\nSigned-off-by: Jianpeng Ma <jianpeng.ma@intel.com>","created_at":"2018-06-27T15:29:04Z","updated_at":"2018-07-20T18:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d025465f6136efe903bdaaf010ded488cfc08fa2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jdurgin","id":1022584,"node_id":"MDQ6VXNlcjEwMjI1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1022584?v=4","gravatar_id":"","url":"https://api.github.com/users/jdurgin","html_url":"https://github.com/jdurgin","followers_url":"https://api.github.com/users/jdurgin/followers","following_url":"https://api.github.com/users/jdurgin/following{/other_user}","gists_url":"https://api.github.com/users/jdurgin/gists{/gist_id}","starred_url":"https://api.github.com/users/jdurgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdurgin/subscriptions","organizations_url":"https://api.github.com/users/jdurgin/orgs","repos_url":"https://api.github.com/users/jdurgin/repos","events_url":"https://api.github.com/users/jdurgin/events{/privacy}","received_events_url":"https://api.github.com/users/jdurgin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":204137300,"node_id":"MDU6TGFiZWwyMDQxMzczMDA=","url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/22739/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/22739/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/22739/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/0e04e661e3121297a877e6e7bcf8da277789e569","head":{"label":"majianpeng:osd-shardthread-do-bluestore-oncommits","ref":"osd-shardthread-do-bluestore-oncommits","sha":"0e04e661e3121297a877e6e7bcf8da277789e569","user":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"repo":{"id":22190447,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5MDQ0Nw==","name":"ceph","full_name":"majianpeng/ceph","owner":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majianpeng/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/majianpeng/ceph","forks_url":"https://api.github.com/repos/majianpeng/ceph/forks","keys_url":"https://api.github.com/repos/majianpeng/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majianpeng/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majianpeng/ceph/teams","hooks_url":"https://api.github.com/repos/majianpeng/ceph/hooks","issue_events_url":"https://api.github.com/repos/majianpeng/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/majianpeng/ceph/events","assignees_url":"https://api.github.com/repos/majianpeng/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/majianpeng/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/majianpeng/ceph/tags","blobs_url":"https://api.github.com/repos/majianpeng/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majianpeng/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majianpeng/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/majianpeng/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majianpeng/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/majianpeng/ceph/languages","stargazers_url":"https://api.github.com/repos/majianpeng/ceph/stargazers","contributors_url":"https://api.github.com/repos/majianpeng/ceph/contributors","subscribers_url":"https://api.github.com/repos/majianpeng/ceph/subscribers","subscription_url":"https://api.github.com/repos/majianpeng/ceph/subscription","commits_url":"https://api.github.com/repos/majianpeng/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/majianpeng/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/majianpeng/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/majianpeng/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/majianpeng/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/majianpeng/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majianpeng/ceph/merges","archive_url":"https://api.github.com/repos/majianpeng/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majianpeng/ceph/downloads","issues_url":"https://api.github.com/repos/majianpeng/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/majianpeng/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/majianpeng/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/majianpeng/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majianpeng/ceph/labels{/name}","releases_url":"https://api.github.com/repos/majianpeng/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/majianpeng/ceph/deployments","created_at":"2014-07-24T01:10:00Z","updated_at":"2018-07-17T01:04:19Z","pushed_at":"2018-07-17T01:04:15Z","git_url":"git://github.com/majianpeng/ceph.git","ssh_url":"git@github.com:majianpeng/ceph.git","clone_url":"https://github.com/majianpeng/ceph.git","svn_url":"https://github.com/majianpeng/ceph","homepage":"http://ceph.com","size":272017,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"69725446c869ec0cce1cbdd4ba39a705846287b9","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-07-20T18:27:10Z","pushed_at":"2018-07-20T18:24:52Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":299376,"stargazers_count":4821,"watchers_count":4821,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2534,"mirror_url":null,"archived":false,"open_issues_count":719,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2534,"open_issues":719,"watchers":4821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22739"},"html":{"href":"https://github.com/ceph/ceph/pull/22739"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/22739"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/22739/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22739/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22739/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/0e04e661e3121297a877e6e7bcf8da277789e569"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"liewegas"}}