{"action":"created","issue":{"url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/79","repository_url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook","labels_url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/79/comments","events_url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/79/events","html_url":"https://github.com/lmiller1990/vue-testing-handbook/pull/79","id":374367782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDg1MzI3","number":79,"title":"Fix js in markdown","user":{"login":"paparent","id":64377,"node_id":"MDQ6VXNlcjY0Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/64377?v=4","gravatar_id":"","url":"https://api.github.com/users/paparent","html_url":"https://github.com/paparent","followers_url":"https://api.github.com/users/paparent/followers","following_url":"https://api.github.com/users/paparent/following{/other_user}","gists_url":"https://api.github.com/users/paparent/gists{/gist_id}","starred_url":"https://api.github.com/users/paparent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparent/subscriptions","organizations_url":"https://api.github.com/users/paparent/orgs","repos_url":"https://api.github.com/users/paparent/repos","events_url":"https://api.github.com/users/paparent/events{/privacy}","received_events_url":"https://api.github.com/users/paparent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T12:45:56Z","updated_at":"2018-10-28T13:41:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/pulls/79","html_url":"https://github.com/lmiller1990/vue-testing-handbook/pull/79","diff_url":"https://github.com/lmiller1990/vue-testing-handbook/pull/79.diff","patch_url":"https://github.com/lmiller1990/vue-testing-handbook/pull/79.patch"},"body":"Hi ! \r\n\r\nYour comment in my last PR made me think: There should be a way to lint js in Markdown.. And here it is ! \r\n\r\nI put `no-undef` for *.md files so we don't have to be perfect JS. I had to add `export default {}` to make it valid tho !\r\n\r\nUnfortunately it doesn't support vue :( https://github.com/eslint/eslint-plugin-markdown/issues/82\r\n"},"comment":{"url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/comments/433706289","html_url":"https://github.com/lmiller1990/vue-testing-handbook/pull/79#issuecomment-433706289","issue_url":"https://api.github.com/repos/lmiller1990/vue-testing-handbook/issues/79","id":433706289,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcwNjI4OQ==","user":{"login":"lmiller1990","id":19196536,"node_id":"MDQ6VXNlcjE5MTk2NTM2","avatar_url":"https://avatars1.githubusercontent.com/u/19196536?v=4","gravatar_id":"","url":"https://api.github.com/users/lmiller1990","html_url":"https://github.com/lmiller1990","followers_url":"https://api.github.com/users/lmiller1990/followers","following_url":"https://api.github.com/users/lmiller1990/following{/other_user}","gists_url":"https://api.github.com/users/lmiller1990/gists{/gist_id}","starred_url":"https://api.github.com/users/lmiller1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmiller1990/subscriptions","organizations_url":"https://api.github.com/users/lmiller1990/orgs","repos_url":"https://api.github.com/users/lmiller1990/repos","events_url":"https://api.github.com/users/lmiller1990/events{/privacy}","received_events_url":"https://api.github.com/users/lmiller1990/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T13:41:33Z","updated_at":"2018-10-28T13:41:33Z","author_association":"OWNER","body":"hmm, interesting idea. I do like the idea of linting the JS - I'll pull this and try it out in the next day or so, interested to see what kind of errors it does/doesn't pick up.\r\n\r\nI think adding `export default` is a good solution. Do you think adding a comment like this:\r\n\r\n```js\r\nexport default {\r\n  // ...\r\n  methods: {\r\n}\r\n```\r\n\r\nwould make it more clear? My intuition is it should be clear the snippet is not a complete component, but just a snippet. But I don't have a strong opinion about it.\r\n\r\nGreat work though! Again, will pull this down and see how effective it is. I definitely want to merge this in soon."}}
{"actor":{"display_login":"lmiller1990"}}