{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/225291811","pull_request_review_id":164863861,"id":225291811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTI5MTgxMQ==","diff_hunk":"@@ -0,0 +1,75 @@\n+﻿// ----------------------------------------------------------------------------------\n+//\n+// Copyright Microsoft Corporation\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+// http://www.apache.org/licenses/LICENSE-2.0\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+// ----------------------------------------------------------------------------------\n+\n+using Microsoft.Azure.Commands.Network.Models;\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Management.Automation;\n+\n+namespace Microsoft.Azure.Commands.Network\n+{\n+    [Cmdlet(\"Remove\", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + \"ApplicationGatewayCustomError\"),\n+        OutputType(typeof(PSApplicationGatewayCustomError))]\n+    public class RemoveAzureApplicationGatewayCustomerErrorCommand : NetworkBaseCmdlet\n+    {\n+        [Parameter(\n+                Mandatory = true,\n+                HelpMessage = \"Status code of the application gateway customer error.\")]\n+        [ValidateNotNullOrEmpty]\n+        public string StatusCode { get; set; }\n+\n+        [Parameter(\n+             Mandatory = false,\n+             ValueFromPipeline = true,\n+             HelpMessage = \"The Application Gateway\")]\n+        public PSApplicationGateway ApplicationGateway { get; set; }","path":"src/ResourceManager/Network/Commands.Network/ApplicationGateway/CustomError/RemoveAzureApplicationGatewayCustomerErrorCommand.cs","position":37,"original_position":37,"commit_id":"e303598d3ca3fa78161e5ba4174879ad06bef861","original_commit_id":"e303598d3ca3fa78161e5ba4174879ad06bef861","user":{"login":"praries880","id":35941423,"node_id":"MDQ6VXNlcjM1OTQxNDIz","avatar_url":"https://avatars2.githubusercontent.com/u/35941423?v=4","gravatar_id":"","url":"https://api.github.com/users/praries880","html_url":"https://github.com/praries880","followers_url":"https://api.github.com/users/praries880/followers","following_url":"https://api.github.com/users/praries880/following{/other_user}","gists_url":"https://api.github.com/users/praries880/gists{/gist_id}","starred_url":"https://api.github.com/users/praries880/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praries880/subscriptions","organizations_url":"https://api.github.com/users/praries880/orgs","repos_url":"https://api.github.com/users/praries880/repos","events_url":"https://api.github.com/users/praries880/events{/privacy}","received_events_url":"https://api.github.com/users/praries880/received_events","type":"User","site_admin":false},"body":"The user should have to specify one or the other and not both or none of them.. right?\r\n\r\nCorrect way to handle that is to put the params `applicationgateway` and `httplistener` in their own parameter sets and mark them as mandatory.","created_at":"2018-10-15T19:42:00Z","updated_at":"2018-10-15T19:47:54Z","html_url":"https://github.com/Azure/azure-powershell/pull/7448#discussion_r225291811","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/225291811"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7448#discussion_r225291811"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448","id":219775974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Nzc1OTc0","html_url":"https://github.com/Azure/azure-powershell/pull/7448","diff_url":"https://github.com/Azure/azure-powershell/pull/7448.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7448.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7448","number":7448,"state":"open","locked":false,"title":"appgw custom error cmdlet","user":{"login":"KaiChiLin","id":40705071,"node_id":"MDQ6VXNlcjQwNzA1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/40705071?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiChiLin","html_url":"https://github.com/KaiChiLin","followers_url":"https://api.github.com/users/KaiChiLin/followers","following_url":"https://api.github.com/users/KaiChiLin/following{/other_user}","gists_url":"https://api.github.com/users/KaiChiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiChiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiChiLin/subscriptions","organizations_url":"https://api.github.com/users/KaiChiLin/orgs","repos_url":"https://api.github.com/users/KaiChiLin/repos","events_url":"https://api.github.com/users/KaiChiLin/events{/privacy}","received_events_url":"https://api.github.com/users/KaiChiLin/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\nCmdlet review:\r\nhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/178\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [x] If applicable, the changes made in the PR have proper test coverage\r\n- [x] For public API changes to cmdlets:\r\n    - [x] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)\r\n    - [x] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-10-02T16:58:50Z","updated_at":"2018-10-15T19:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44ce288680e47b7ca04137ab4e54ae8991dc866a","assignee":{"login":"KaiChiLin","id":40705071,"node_id":"MDQ6VXNlcjQwNzA1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/40705071?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiChiLin","html_url":"https://github.com/KaiChiLin","followers_url":"https://api.github.com/users/KaiChiLin/followers","following_url":"https://api.github.com/users/KaiChiLin/following{/other_user}","gists_url":"https://api.github.com/users/KaiChiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiChiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiChiLin/subscriptions","organizations_url":"https://api.github.com/users/KaiChiLin/orgs","repos_url":"https://api.github.com/users/KaiChiLin/repos","events_url":"https://api.github.com/users/KaiChiLin/events{/privacy}","received_events_url":"https://api.github.com/users/KaiChiLin/received_events","type":"User","site_admin":false},"assignees":[{"login":"KaiChiLin","id":40705071,"node_id":"MDQ6VXNlcjQwNzA1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/40705071?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiChiLin","html_url":"https://github.com/KaiChiLin","followers_url":"https://api.github.com/users/KaiChiLin/followers","following_url":"https://api.github.com/users/KaiChiLin/following{/other_user}","gists_url":"https://api.github.com/users/KaiChiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiChiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiChiLin/subscriptions","organizations_url":"https://api.github.com/users/KaiChiLin/orgs","repos_url":"https://api.github.com/users/KaiChiLin/repos","events_url":"https://api.github.com/users/KaiChiLin/events{/privacy}","received_events_url":"https://api.github.com/users/KaiChiLin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":494979808,"node_id":"MDU6TGFiZWw0OTQ5Nzk4MDg=","url":"https://api.github.com/repos/Azure/azure-powershell/labels/Merge%20Conflicts","name":"Merge Conflicts","color":"b60205","default":false},{"id":1056158818,"node_id":"MDU6TGFiZWwxMDU2MTU4ODE4","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7448/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/e303598d3ca3fa78161e5ba4174879ad06bef861","head":{"label":"KaiChiLin:network-october-release","ref":"network-october-release","sha":"e303598d3ca3fa78161e5ba4174879ad06bef861","user":{"login":"KaiChiLin","id":40705071,"node_id":"MDQ6VXNlcjQwNzA1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/40705071?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiChiLin","html_url":"https://github.com/KaiChiLin","followers_url":"https://api.github.com/users/KaiChiLin/followers","following_url":"https://api.github.com/users/KaiChiLin/following{/other_user}","gists_url":"https://api.github.com/users/KaiChiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiChiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiChiLin/subscriptions","organizations_url":"https://api.github.com/users/KaiChiLin/orgs","repos_url":"https://api.github.com/users/KaiChiLin/repos","events_url":"https://api.github.com/users/KaiChiLin/events{/privacy}","received_events_url":"https://api.github.com/users/KaiChiLin/received_events","type":"User","site_admin":false},"repo":{"id":143330903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMzA5MDM=","name":"azure-powershell","full_name":"KaiChiLin/azure-powershell","private":false,"owner":{"login":"KaiChiLin","id":40705071,"node_id":"MDQ6VXNlcjQwNzA1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/40705071?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiChiLin","html_url":"https://github.com/KaiChiLin","followers_url":"https://api.github.com/users/KaiChiLin/followers","following_url":"https://api.github.com/users/KaiChiLin/following{/other_user}","gists_url":"https://api.github.com/users/KaiChiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiChiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiChiLin/subscriptions","organizations_url":"https://api.github.com/users/KaiChiLin/orgs","repos_url":"https://api.github.com/users/KaiChiLin/repos","events_url":"https://api.github.com/users/KaiChiLin/events{/privacy}","received_events_url":"https://api.github.com/users/KaiChiLin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KaiChiLin/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/KaiChiLin/azure-powershell","forks_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/forks","keys_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/teams","hooks_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/events","assignees_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/tags","blobs_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/subscription","commits_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/merges","archive_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/downloads","issues_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/KaiChiLin/azure-powershell/deployments","created_at":"2018-08-02T18:24:10Z","updated_at":"2018-09-21T22:31:46Z","pushed_at":"2018-10-12T23:33:10Z","git_url":"git://github.com/KaiChiLin/azure-powershell.git","ssh_url":"git@github.com:KaiChiLin/azure-powershell.git","clone_url":"https://github.com/KaiChiLin/azure-powershell.git","svn_url":"https://github.com/KaiChiLin/azure-powershell","homepage":null,"size":612401,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:network-october-release","ref":"network-october-release","sha":"6dfec46537f48ca1d228cbe335153bc36a4d7b9e","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-10-15T19:34:23Z","pushed_at":"2018-10-15T19:42:09Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":625421,"stargazers_count":1173,"watchers_count":1173,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"archived":false,"open_issues_count":723,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1242,"open_issues":723,"watchers":1173,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7448"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7448"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7448/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7448/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/e303598d3ca3fa78161e5ba4174879ad06bef861"}},"author_association":"NONE"}}
{"actor":{"display_login":"praries880"}}