{"action":"created","comment":{"url":"https://api.github.com/repos/zold-io/zold/pulls/comments/200785963","pull_request_review_id":135175034,"id":200785963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDc4NTk2Mw==","diff_hunk":"@@ -116,4 +116,42 @@ def test_remote_trim_with_tolerate\n       assert_equal(1, remotes.all.count)\n     end\n   end\n+\n+  # @todo #329:30min Verify that the nodes that are being selected are\n+  #  really the strongest ones. The strongest nodes are the ones with\n+  #  the highest score.\n+  def test_select_selects_the_strongest_nodes","path":"test/commands/test_remote.rb","position":8,"original_position":8,"commit_id":"57f969c1558075a2356dc2436f2eadca28d3acc3","original_commit_id":"57f969c1558075a2356dc2436f2eadca28d3acc3","user":{"login":"ledestin","id":1990075,"node_id":"MDQ6VXNlcjE5OTAwNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1990075?v=4","gravatar_id":"","url":"https://api.github.com/users/ledestin","html_url":"https://github.com/ledestin","followers_url":"https://api.github.com/users/ledestin/followers","following_url":"https://api.github.com/users/ledestin/following{/other_user}","gists_url":"https://api.github.com/users/ledestin/gists{/gist_id}","starred_url":"https://api.github.com/users/ledestin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledestin/subscriptions","organizations_url":"https://api.github.com/users/ledestin/orgs","repos_url":"https://api.github.com/users/ledestin/repos","events_url":"https://api.github.com/users/ledestin/events{/privacy}","received_events_url":"https://api.github.com/users/ledestin/received_events","type":"User","site_admin":false},"body":"@botanicus got you. In RSpec you could say `describe '#select'`.","created_at":"2018-07-06T22:38:01Z","updated_at":"2018-07-06T22:38:01Z","html_url":"https://github.com/zold-io/zold/pull/355#discussion_r200785963","pull_request_url":"https://api.github.com/repos/zold-io/zold/pulls/355","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zold-io/zold/pulls/comments/200785963"},"html":{"href":"https://github.com/zold-io/zold/pull/355#discussion_r200785963"},"pull_request":{"href":"https://api.github.com/repos/zold-io/zold/pulls/355"}},"in_reply_to_id":200781187},"pull_request":{"url":"https://api.github.com/repos/zold-io/zold/pulls/355","id":199758284,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzU4Mjg0","html_url":"https://github.com/zold-io/zold/pull/355","diff_url":"https://github.com/zold-io/zold/pull/355.diff","patch_url":"https://github.com/zold-io/zold/pull/355.patch","issue_url":"https://api.github.com/repos/zold-io/zold/issues/355","number":355,"state":"open","locked":false,"title":"Select the strongest nodes #329","user":{"login":"botanicus","id":6171,"node_id":"MDQ6VXNlcjYxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6171?v=4","gravatar_id":"","url":"https://api.github.com/users/botanicus","html_url":"https://github.com/botanicus","followers_url":"https://api.github.com/users/botanicus/followers","following_url":"https://api.github.com/users/botanicus/following{/other_user}","gists_url":"https://api.github.com/users/botanicus/gists{/gist_id}","starred_url":"https://api.github.com/users/botanicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botanicus/subscriptions","organizations_url":"https://api.github.com/users/botanicus/orgs","repos_url":"https://api.github.com/users/botanicus/repos","events_url":"https://api.github.com/users/botanicus/events{/privacy}","received_events_url":"https://api.github.com/users/botanicus/received_events","type":"User","site_admin":false},"body":"This PR implements selecting the strongest nodes as described in #329.","created_at":"2018-07-06T14:08:05Z","updated_at":"2018-07-06T22:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e67e3e9ef86e5e68a2687c66fd1c0b1b90427117","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":937984717,"node_id":"MDU6TGFiZWw5Mzc5ODQ3MTc=","url":"https://api.github.com/repos/zold-io/zold/labels/scope","name":"scope","color":"3a6622","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zold-io/zold/pulls/355/commits","review_comments_url":"https://api.github.com/repos/zold-io/zold/pulls/355/comments","review_comment_url":"https://api.github.com/repos/zold-io/zold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zold-io/zold/issues/355/comments","statuses_url":"https://api.github.com/repos/zold-io/zold/statuses/57f969c1558075a2356dc2436f2eadca28d3acc3","head":{"label":"botanicus:329","ref":"329","sha":"57f969c1558075a2356dc2436f2eadca28d3acc3","user":{"login":"botanicus","id":6171,"node_id":"MDQ6VXNlcjYxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6171?v=4","gravatar_id":"","url":"https://api.github.com/users/botanicus","html_url":"https://github.com/botanicus","followers_url":"https://api.github.com/users/botanicus/followers","following_url":"https://api.github.com/users/botanicus/following{/other_user}","gists_url":"https://api.github.com/users/botanicus/gists{/gist_id}","starred_url":"https://api.github.com/users/botanicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botanicus/subscriptions","organizations_url":"https://api.github.com/users/botanicus/orgs","repos_url":"https://api.github.com/users/botanicus/repos","events_url":"https://api.github.com/users/botanicus/events{/privacy}","received_events_url":"https://api.github.com/users/botanicus/received_events","type":"User","site_admin":false},"repo":{"id":138692346,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2OTIzNDY=","name":"zold","full_name":"botanicus/zold","owner":{"login":"botanicus","id":6171,"node_id":"MDQ6VXNlcjYxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6171?v=4","gravatar_id":"","url":"https://api.github.com/users/botanicus","html_url":"https://github.com/botanicus","followers_url":"https://api.github.com/users/botanicus/followers","following_url":"https://api.github.com/users/botanicus/following{/other_user}","gists_url":"https://api.github.com/users/botanicus/gists{/gist_id}","starred_url":"https://api.github.com/users/botanicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botanicus/subscriptions","organizations_url":"https://api.github.com/users/botanicus/orgs","repos_url":"https://api.github.com/users/botanicus/repos","events_url":"https://api.github.com/users/botanicus/events{/privacy}","received_events_url":"https://api.github.com/users/botanicus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/botanicus/zold","description":"A Fast Cryptocurrency for Micro Payments","fork":true,"url":"https://api.github.com/repos/botanicus/zold","forks_url":"https://api.github.com/repos/botanicus/zold/forks","keys_url":"https://api.github.com/repos/botanicus/zold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/botanicus/zold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/botanicus/zold/teams","hooks_url":"https://api.github.com/repos/botanicus/zold/hooks","issue_events_url":"https://api.github.com/repos/botanicus/zold/issues/events{/number}","events_url":"https://api.github.com/repos/botanicus/zold/events","assignees_url":"https://api.github.com/repos/botanicus/zold/assignees{/user}","branches_url":"https://api.github.com/repos/botanicus/zold/branches{/branch}","tags_url":"https://api.github.com/repos/botanicus/zold/tags","blobs_url":"https://api.github.com/repos/botanicus/zold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/botanicus/zold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/botanicus/zold/git/refs{/sha}","trees_url":"https://api.github.com/repos/botanicus/zold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/botanicus/zold/statuses/{sha}","languages_url":"https://api.github.com/repos/botanicus/zold/languages","stargazers_url":"https://api.github.com/repos/botanicus/zold/stargazers","contributors_url":"https://api.github.com/repos/botanicus/zold/contributors","subscribers_url":"https://api.github.com/repos/botanicus/zold/subscribers","subscription_url":"https://api.github.com/repos/botanicus/zold/subscription","commits_url":"https://api.github.com/repos/botanicus/zold/commits{/sha}","git_commits_url":"https://api.github.com/repos/botanicus/zold/git/commits{/sha}","comments_url":"https://api.github.com/repos/botanicus/zold/comments{/number}","issue_comment_url":"https://api.github.com/repos/botanicus/zold/issues/comments{/number}","contents_url":"https://api.github.com/repos/botanicus/zold/contents/{+path}","compare_url":"https://api.github.com/repos/botanicus/zold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/botanicus/zold/merges","archive_url":"https://api.github.com/repos/botanicus/zold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/botanicus/zold/downloads","issues_url":"https://api.github.com/repos/botanicus/zold/issues{/number}","pulls_url":"https://api.github.com/repos/botanicus/zold/pulls{/number}","milestones_url":"https://api.github.com/repos/botanicus/zold/milestones{/number}","notifications_url":"https://api.github.com/repos/botanicus/zold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/botanicus/zold/labels{/name}","releases_url":"https://api.github.com/repos/botanicus/zold/releases{/id}","deployments_url":"https://api.github.com/repos/botanicus/zold/deployments","created_at":"2018-06-26T06:09:27Z","updated_at":"2018-07-03T03:24:42Z","pushed_at":"2018-07-06T21:58:20Z","git_url":"git://github.com/botanicus/zold.git","ssh_url":"git@github.com:botanicus/zold.git","clone_url":"https://github.com/botanicus/zold.git","svn_url":"https://github.com/botanicus/zold","homepage":"http://www.zold.io","size":1802,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zold-io:master","ref":"master","sha":"d3ee24da97397704bfd3d54872f1c4c0305f62e7","user":{"login":"zold-io","id":39849919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODQ5OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/39849919?v=4","gravatar_id":"","url":"https://api.github.com/users/zold-io","html_url":"https://github.com/zold-io","followers_url":"https://api.github.com/users/zold-io/followers","following_url":"https://api.github.com/users/zold-io/following{/other_user}","gists_url":"https://api.github.com/users/zold-io/gists{/gist_id}","starred_url":"https://api.github.com/users/zold-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zold-io/subscriptions","organizations_url":"https://api.github.com/users/zold-io/orgs","repos_url":"https://api.github.com/users/zold-io/repos","events_url":"https://api.github.com/users/zold-io/events{/privacy}","received_events_url":"https://api.github.com/users/zold-io/received_events","type":"Organization","site_admin":false},"repo":{"id":119125227,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMjUyMjc=","name":"zold","full_name":"zold-io/zold","owner":{"login":"zold-io","id":39849919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODQ5OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/39849919?v=4","gravatar_id":"","url":"https://api.github.com/users/zold-io","html_url":"https://github.com/zold-io","followers_url":"https://api.github.com/users/zold-io/followers","following_url":"https://api.github.com/users/zold-io/following{/other_user}","gists_url":"https://api.github.com/users/zold-io/gists{/gist_id}","starred_url":"https://api.github.com/users/zold-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zold-io/subscriptions","organizations_url":"https://api.github.com/users/zold-io/orgs","repos_url":"https://api.github.com/users/zold-io/repos","events_url":"https://api.github.com/users/zold-io/events{/privacy}","received_events_url":"https://api.github.com/users/zold-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zold-io/zold","description":"A Fast Cryptocurrency for Micro Payments","fork":false,"url":"https://api.github.com/repos/zold-io/zold","forks_url":"https://api.github.com/repos/zold-io/zold/forks","keys_url":"https://api.github.com/repos/zold-io/zold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zold-io/zold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zold-io/zold/teams","hooks_url":"https://api.github.com/repos/zold-io/zold/hooks","issue_events_url":"https://api.github.com/repos/zold-io/zold/issues/events{/number}","events_url":"https://api.github.com/repos/zold-io/zold/events","assignees_url":"https://api.github.com/repos/zold-io/zold/assignees{/user}","branches_url":"https://api.github.com/repos/zold-io/zold/branches{/branch}","tags_url":"https://api.github.com/repos/zold-io/zold/tags","blobs_url":"https://api.github.com/repos/zold-io/zold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zold-io/zold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zold-io/zold/git/refs{/sha}","trees_url":"https://api.github.com/repos/zold-io/zold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zold-io/zold/statuses/{sha}","languages_url":"https://api.github.com/repos/zold-io/zold/languages","stargazers_url":"https://api.github.com/repos/zold-io/zold/stargazers","contributors_url":"https://api.github.com/repos/zold-io/zold/contributors","subscribers_url":"https://api.github.com/repos/zold-io/zold/subscribers","subscription_url":"https://api.github.com/repos/zold-io/zold/subscription","commits_url":"https://api.github.com/repos/zold-io/zold/commits{/sha}","git_commits_url":"https://api.github.com/repos/zold-io/zold/git/commits{/sha}","comments_url":"https://api.github.com/repos/zold-io/zold/comments{/number}","issue_comment_url":"https://api.github.com/repos/zold-io/zold/issues/comments{/number}","contents_url":"https://api.github.com/repos/zold-io/zold/contents/{+path}","compare_url":"https://api.github.com/repos/zold-io/zold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zold-io/zold/merges","archive_url":"https://api.github.com/repos/zold-io/zold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zold-io/zold/downloads","issues_url":"https://api.github.com/repos/zold-io/zold/issues{/number}","pulls_url":"https://api.github.com/repos/zold-io/zold/pulls{/number}","milestones_url":"https://api.github.com/repos/zold-io/zold/milestones{/number}","notifications_url":"https://api.github.com/repos/zold-io/zold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zold-io/zold/labels{/name}","releases_url":"https://api.github.com/repos/zold-io/zold/releases{/id}","deployments_url":"https://api.github.com/repos/zold-io/zold/deployments","created_at":"2018-01-27T02:31:37Z","updated_at":"2018-07-06T11:43:15Z","pushed_at":"2018-07-06T21:58:22Z","git_url":"git://github.com/zold-io/zold.git","ssh_url":"git@github.com:zold-io/zold.git","clone_url":"https://github.com/zold-io/zold.git","svn_url":"https://github.com/zold-io/zold","homepage":"http://www.zold.io","size":1797,"stargazers_count":42,"watchers_count":42,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22,"open_issues":103,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zold-io/zold/pulls/355"},"html":{"href":"https://github.com/zold-io/zold/pull/355"},"issue":{"href":"https://api.github.com/repos/zold-io/zold/issues/355"},"comments":{"href":"https://api.github.com/repos/zold-io/zold/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/zold-io/zold/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/zold-io/zold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zold-io/zold/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/zold-io/zold/statuses/57f969c1558075a2356dc2436f2eadca28d3acc3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ledestin"}}