{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34672","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34672/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34672/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34672/events","html_url":"https://github.com/NixOS/nixpkgs/pull/34672","id":294846765,"number":34672,"title":"buildLinux: add overrides for modules","user":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-06T17:30:21Z","updated_at":"2018-02-14T03:19:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34672","html_url":"https://github.com/NixOS/nixpkgs/pull/34672","diff_url":"https://github.com/NixOS/nixpkgs/pull/34672.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/34672.patch"},"body":"Follow up PR of https://github.com/NixOS/nixpkgs/pull/34351\r\n\r\n- Easy override of autoModules and preferBuiltin parameters (currently living in `hostSystem` set).\r\n\r\n###### Motivation for this change\r\nMake it easier to configure the kernel (overriding platforms is 'hard').\r\nOne question in the previous PR was should we delete kernelAutoModules/kernelPreferBuiltin from the hostPlatform.platform.* ?\r\nSome platforms may prefer to have builtin modules because crosscompiling is faster and having to install modules separataly would be a pain so it might make sense. Not too sure though.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/365483605","html_url":"https://github.com/NixOS/nixpkgs/pull/34672#issuecomment-365483605","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34672","id":365483605,"user":{"login":"teto","id":886074,"avatar_url":"https://avatars0.githubusercontent.com/u/886074?v=4","gravatar_id":"","url":"https://api.github.com/users/teto","html_url":"https://github.com/teto","followers_url":"https://api.github.com/users/teto/followers","following_url":"https://api.github.com/users/teto/following{/other_user}","gists_url":"https://api.github.com/users/teto/gists{/gist_id}","starred_url":"https://api.github.com/users/teto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teto/subscriptions","organizations_url":"https://api.github.com/users/teto/orgs","repos_url":"https://api.github.com/users/teto/repos","events_url":"https://api.github.com/users/teto/events{/privacy}","received_events_url":"https://api.github.com/users/teto/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T03:19:15Z","updated_at":"2018-02-14T03:19:15Z","author_association":"CONTRIBUTOR","body":"@vcunat I tried to fix the useless parameters you mentioned in my previous PR. I hope it's good now."}}
{"actor":{"display_login":"teto"}}