{"action":"created","issue":{"url":"https://api.github.com/repos/segmentio/kafka-go/issues/152","repository_url":"https://api.github.com/repos/segmentio/kafka-go","labels_url":"https://api.github.com/repos/segmentio/kafka-go/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/segmentio/kafka-go/issues/152/comments","events_url":"https://api.github.com/repos/segmentio/kafka-go/issues/152/events","html_url":"https://github.com/segmentio/kafka-go/pull/152","id":384853100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTU2Nzk1","number":152,"title":"Small fix to Dialer to set the ServerName in tls.Config if it is empty.","user":{"login":"pkedy","id":714039,"node_id":"MDQ6VXNlcjcxNDAzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/714039?v=4","gravatar_id":"","url":"https://api.github.com/users/pkedy","html_url":"https://github.com/pkedy","followers_url":"https://api.github.com/users/pkedy/followers","following_url":"https://api.github.com/users/pkedy/following{/other_user}","gists_url":"https://api.github.com/users/pkedy/gists{/gist_id}","starred_url":"https://api.github.com/users/pkedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkedy/subscriptions","organizations_url":"https://api.github.com/users/pkedy/orgs","repos_url":"https://api.github.com/users/pkedy/repos","events_url":"https://api.github.com/users/pkedy/events{/privacy}","received_events_url":"https://api.github.com/users/pkedy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-27T15:34:49Z","updated_at":"2018-12-11T20:57:29Z","closed_at":"2018-11-27T16:12:10Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/segmentio/kafka-go/pulls/152","html_url":"https://github.com/segmentio/kafka-go/pull/152","diff_url":"https://github.com/segmentio/kafka-go/pull/152.diff","patch_url":"https://github.com/segmentio/kafka-go/pull/152.patch"},"body":"Without this tweak, I was seeing the TLS client handshake error below.\r\n\r\n```\r\ntls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\r\n```\r\n\r\nI added same approach to inferring the ServerName from the address that is in `DialWithDialer` of `tls.go`."},"comment":{"url":"https://api.github.com/repos/segmentio/kafka-go/issues/comments/446359032","html_url":"https://github.com/segmentio/kafka-go/pull/152#issuecomment-446359032","issue_url":"https://api.github.com/repos/segmentio/kafka-go/issues/152","id":446359032,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjM1OTAzMg==","user":{"login":"pkedy","id":714039,"node_id":"MDQ6VXNlcjcxNDAzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/714039?v=4","gravatar_id":"","url":"https://api.github.com/users/pkedy","html_url":"https://github.com/pkedy","followers_url":"https://api.github.com/users/pkedy/followers","following_url":"https://api.github.com/users/pkedy/following{/other_user}","gists_url":"https://api.github.com/users/pkedy/gists{/gist_id}","starred_url":"https://api.github.com/users/pkedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkedy/subscriptions","organizations_url":"https://api.github.com/users/pkedy/orgs","repos_url":"https://api.github.com/users/pkedy/repos","events_url":"https://api.github.com/users/pkedy/events{/privacy}","received_events_url":"https://api.github.com/users/pkedy/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T20:57:29Z","updated_at":"2018-12-11T20:57:29Z","author_association":"CONTRIBUTOR","body":"@achille-roussel Do you think you could create a new release tag from master so dep / go mod pick it up?"}}
{"actor":{"display_login":"pkedy"}}