{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/185920012","pull_request_review_id":117409258,"id":185920012,"diff_hunk":"@@ -28,21 +29,21 @@\n  * instance index and guids. Later are necessary to allow discrimination and aggregation of app metrics by external\n  * metrics collection and visualizaiton tools.\n  *\n+ * Use the management.metrics.cloud.stream.app.common.tags.enabled=false property to disable inserting those tags.\n+ *\n  * @author Christian Tzolov\n  */\n @Configuration\n+@ConditionalOnProperty(name = \"management.metrics.cloud.stream.app.common.tags.enabled\", havingValue = \"true\", matchIfMissing = true)\n public class SpringCloudStreamMicrometerCommonTags {\n \n-\t@Value(\"${spring.cloud.dataflow.cluster.name:default}\")\n-\tprivate String clusterName;\n-\n \t@Value(\"${spring.cloud.dataflow.stream.name:unknown}\")\n \tprivate String streamName;\n \n \t@Value(\"${spring.cloud.dataflow.stream.app.label:unknown}\")\n \tprivate String applicationName;\n \n-\t@Value(\"${instance.index:unknown}\")\n+\t@Value(\"${instance.index:0}\")","path":"common/app-starters-micrometer-common/src/main/java/org/springframework/cloud/stream/app/micrometer/common/SpringCloudStreamMicrometerCommonTags.java","position":30,"original_position":30,"commit_id":"77c638456e8cd0d5e7ff6480128c43d6f167c606","original_commit_id":"b5b02f81459c31b2fbfefc0593cdeb672ddd2e49","user":{"login":"markpollack","id":247466,"avatar_url":"https://avatars1.githubusercontent.com/u/247466?v=4","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"body":"So `${spring.application.index:${INSTANCE_INDEX:null}}` maybe enough.  Not sure if upper cased `SPRING_APPLICATION_INDEX` needs to be there as well for cf.\r\n`${vcap.application.instance_index:${spring.application.index:${INSTANCE_INDEX:null}}}` would work on CF though.\r\n","created_at":"2018-05-03T20:02:28Z","updated_at":"2018-05-03T20:02:28Z","html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/40#discussion_r185920012","pull_request_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/185920012"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/40#discussion_r185920012"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40"}},"in_reply_to_id":185623189},"pull_request":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40","id":185388210,"html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/40","diff_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/40.diff","patch_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/40.patch","issue_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/40","number":40,"state":"open","locked":false,"title":"Add CF micrometer tags","user":{"login":"tzolov","id":1351573,"avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"body":"Resolves #37\r\n - CF tags are activated only on 'cloud' profile\r\n - Allow CF tags to be disabled with management.metrics.cloud.stream.app.cf.tags.enabled=true. Enabled by default\r\n - SCDF common tags to be disabled with management.metrics.cloud.stream.app.common.tags.enabled=true. Enabled by default\r\n - Improve test coverage for all enabled/disabled use cases cases","created_at":"2018-05-02T09:53:38Z","updated_at":"2018-05-03T20:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c881f096b0dbccd80328f0955ea44dbce03b4e95","assignee":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars1.githubusercontent.com/u/50398?v=4","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"assignees":[{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars1.githubusercontent.com/u/50398?v=4","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},{"login":"markpollack","id":247466,"avatar_url":"https://avatars1.githubusercontent.com/u/247466?v=4","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":535323636,"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels/in%20pr","name":"in pr","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40/commits","review_comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40/comments","review_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/40/comments","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/77c638456e8cd0d5e7ff6480128c43d6f167c606","head":{"label":"tzolov:gh-37-micrometer-CF-common-tags","ref":"gh-37-micrometer-CF-common-tags","sha":"77c638456e8cd0d5e7ff6480128c43d6f167c606","user":{"login":"tzolov","id":1351573,"avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"repo":{"id":120959535,"name":"core","full_name":"tzolov/core","owner":{"login":"tzolov","id":1351573,"avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tzolov/core","description":"Core components shared by other projects in the app starters organization","fork":true,"url":"https://api.github.com/repos/tzolov/core","forks_url":"https://api.github.com/repos/tzolov/core/forks","keys_url":"https://api.github.com/repos/tzolov/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzolov/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzolov/core/teams","hooks_url":"https://api.github.com/repos/tzolov/core/hooks","issue_events_url":"https://api.github.com/repos/tzolov/core/issues/events{/number}","events_url":"https://api.github.com/repos/tzolov/core/events","assignees_url":"https://api.github.com/repos/tzolov/core/assignees{/user}","branches_url":"https://api.github.com/repos/tzolov/core/branches{/branch}","tags_url":"https://api.github.com/repos/tzolov/core/tags","blobs_url":"https://api.github.com/repos/tzolov/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzolov/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzolov/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzolov/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzolov/core/statuses/{sha}","languages_url":"https://api.github.com/repos/tzolov/core/languages","stargazers_url":"https://api.github.com/repos/tzolov/core/stargazers","contributors_url":"https://api.github.com/repos/tzolov/core/contributors","subscribers_url":"https://api.github.com/repos/tzolov/core/subscribers","subscription_url":"https://api.github.com/repos/tzolov/core/subscription","commits_url":"https://api.github.com/repos/tzolov/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzolov/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzolov/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzolov/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzolov/core/contents/{+path}","compare_url":"https://api.github.com/repos/tzolov/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzolov/core/merges","archive_url":"https://api.github.com/repos/tzolov/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzolov/core/downloads","issues_url":"https://api.github.com/repos/tzolov/core/issues{/number}","pulls_url":"https://api.github.com/repos/tzolov/core/pulls{/number}","milestones_url":"https://api.github.com/repos/tzolov/core/milestones{/number}","notifications_url":"https://api.github.com/repos/tzolov/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzolov/core/labels{/name}","releases_url":"https://api.github.com/repos/tzolov/core/releases{/id}","deployments_url":"https://api.github.com/repos/tzolov/core/deployments","created_at":"2018-02-09T21:51:10Z","updated_at":"2018-04-28T13:53:54Z","pushed_at":"2018-05-02T21:12:24Z","git_url":"git://github.com/tzolov/core.git","ssh_url":"git@github.com:tzolov/core.git","clone_url":"https://github.com/tzolov/core.git","svn_url":"https://github.com/tzolov/core","homepage":null,"size":220,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud-stream-app-starters:master","ref":"master","sha":"849b067de0cb5c07a0046c9378c1630effff2811","user":{"login":"spring-cloud-stream-app-starters","id":22753134,"avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"repo":{"id":70517478,"name":"core","full_name":"spring-cloud-stream-app-starters/core","owner":{"login":"spring-cloud-stream-app-starters","id":22753134,"avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud-stream-app-starters/core","description":"Core components shared by other projects in the app starters organization","fork":false,"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core","forks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/forks","keys_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/teams","hooks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/events","assignees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/tags","blobs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/languages","stargazers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscription","commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/merges","archive_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/downloads","issues_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/deployments","created_at":"2016-10-10T18:37:48Z","updated_at":"2018-04-19T03:09:43Z","pushed_at":"2018-05-02T21:12:25Z","git_url":"git://github.com/spring-cloud-stream-app-starters/core.git","ssh_url":"git@github.com:spring-cloud-stream-app-starters/core.git","clone_url":"https://github.com/spring-cloud-stream-app-starters/core.git","svn_url":"https://github.com/spring-cloud-stream-app-starters/core","homepage":null,"size":197,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/40"},"issue":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/40"},"comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/77c638456e8cd0d5e7ff6480128c43d6f167c606"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markpollack"}}