{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/218091246","pull_request_review_id":155952300,"id":218091246,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODA5MTI0Ng==","diff_hunk":"@@ -1,3 +1,4 @@\n+import Base: isidentifier, is_id_start_char, is_id_char","path":"src/deprecated.jl","position":1,"original_position":1,"commit_id":"11c004ad2e0aa4441747e48886fdbcce47c8cda8","original_commit_id":"11c004ad2e0aa4441747e48886fdbcce47c8cda8","user":{"login":"nalimilan","id":1120448,"node_id":"MDQ6VXNlcjExMjA0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"I hadn't noticed this. Better fully qualify these, so that we can remove the deprecations separately without having unrelated code at the top of the file.","created_at":"2018-09-17T14:28:41Z","updated_at":"2018-09-17T14:28:41Z","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1509#discussion_r218091246","pull_request_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/218091246"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1509#discussion_r218091246"},"pull_request":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509","id":215737554,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzM3NTU0","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1509","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1509.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1509.patch","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1509","number":1509,"state":"open","locked":false,"title":"identifier function and related code to deprecated","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"body":"This PR cleans up some deprecated functionality and moves it to deprecated section.\r\n\r\n@nalimilan also `colmissing` and `countmissing` functions are not used in DataFrames.jl except one place in tests and they are not exported. Do we want to keep them?","created_at":"2018-09-15T00:15:26Z","updated_at":"2018-09-17T14:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e09028301dc620a3e7f8dc6000dce3ae864779a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509/commits","review_comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509/comments","review_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1509/comments","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/11c004ad2e0aa4441747e48886fdbcce47c8cda8","head":{"label":"bkamins:deprecate_identifier","ref":"deprecate_identifier","sha":"11c004ad2e0aa4441747e48886fdbcce47c8cda8","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"repo":{"id":112845765,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4NDU3NjU=","name":"DataFrames.jl","full_name":"bkamins/DataFrames.jl","private":false,"owner":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bkamins/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":true,"url":"https://api.github.com/repos/bkamins/DataFrames.jl","forks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/bkamins/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkamins/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkamins/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/bkamins/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkamins/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/bkamins/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/bkamins/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkamins/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/bkamins/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkamins/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/bkamins/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/bkamins/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/bkamins/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkamins/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/bkamins/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/deployments","created_at":"2017-12-02T13:50:44Z","updated_at":"2018-08-31T19:19:15Z","pushed_at":"2018-09-17T14:21:17Z","git_url":"git://github.com/bkamins/DataFrames.jl.git","ssh_url":"git@github.com:bkamins/DataFrames.jl.git","clone_url":"https://github.com/bkamins/DataFrames.jl.git","svn_url":"https://github.com/bkamins/DataFrames.jl","homepage":"","size":9365,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaData:master","ref":"master","sha":"b5e55945fd275278168c862d13c0678cafb59bc7","user":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"repo":{"id":4992873,"node_id":"MDEwOlJlcG9zaXRvcnk0OTkyODcz","name":"DataFrames.jl","full_name":"JuliaData/DataFrames.jl","private":false,"owner":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaData/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":false,"url":"https://api.github.com/repos/JuliaData/DataFrames.jl","forks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/deployments","created_at":"2012-07-11T18:00:09Z","updated_at":"2018-09-17T13:18:08Z","pushed_at":"2018-09-17T14:21:19Z","git_url":"git://github.com/JuliaData/DataFrames.jl.git","ssh_url":"git@github.com:JuliaData/DataFrames.jl.git","clone_url":"https://github.com/JuliaData/DataFrames.jl.git","svn_url":"https://github.com/JuliaData/DataFrames.jl","homepage":"","size":9455,"stargazers_count":514,"watchers_count":514,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":207,"open_issues":103,"watchers":514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1509"},"issue":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1509"},"comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1509/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1509/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/11c004ad2e0aa4441747e48886fdbcce47c8cda8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nalimilan"}}