{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/tls-interop/pulls/comments/218853251","pull_request_review_id":156884581,"id":218853251,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg1MzI1MQ==","diff_hunk":"@@ -17,3 +24,181 @@ fn flatten_unittest() {\n     let flat = flatten(&mat);\n     assert_eq!(6, flat.len());\n }\n+\n+#[test]\n+fn nss_loopback_simple() {\n+    inner_test_simple(ConfigType::NssLoopback);\n+}\n+\n+#[test]\n+fn nss_client_vs_boring_server_simple() {\n+    inner_test_simple(ConfigType::BsslServer);\n+}\n+\n+#[test]\n+fn nss_client_vs_ossl_server_simple() {\n+    inner_test_simple(ConfigType::OsslClient);\n+}\n+\n+#[test]\n+fn nss_server_vs_boring_client_simple() {\n+    inner_test_simple(ConfigType::BsslClient);\n+}\n+\n+#[test]\n+fn nss_server_vs_ossl_client_simple() {\n+    inner_test_simple(ConfigType::OsslClient);\n+}\n+\n+#[test]\n+fn nss_loopback_all_test_cases() {\n+    inner_test_all_cases(ConfigType::NssLoopback)\n+}\n+\n+#[test]\n+fn nss_server_vs_boring_client_all_test_cases() {\n+    inner_test_all_cases(ConfigType::BsslClient)\n+}\n+\n+#[test]\n+fn boring_server_vs_nss_client_all_test_cases() {\n+    inner_test_all_cases(ConfigType::BsslServer)\n+}\n+\n+#[test]\n+fn ossl_server_vs_nss_client_all_test_cases() {\n+    inner_test_all_cases(ConfigType::OsslServer)\n+}\n+\n+#[test]\n+fn nss_server_vs_ossl_client_all_test_cases() {\n+    inner_test_all_cases(ConfigType::OsslClient)\n+}","path":"src/tests.rs","position":64,"original_position":64,"commit_id":"a21f45000ada5bac69845fa0661ccffcc3de752e","original_commit_id":"db99bccff9ac23697b75b356dfc79fc1a925607c","user":{"login":"jallmann","id":35806322,"node_id":"MDQ6VXNlcjM1ODA2MzIy","avatar_url":"https://avatars3.githubusercontent.com/u/35806322?v=4","gravatar_id":"","url":"https://api.github.com/users/jallmann","html_url":"https://github.com/jallmann","followers_url":"https://api.github.com/users/jallmann/followers","following_url":"https://api.github.com/users/jallmann/following{/other_user}","gists_url":"https://api.github.com/users/jallmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jallmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jallmann/subscriptions","organizations_url":"https://api.github.com/users/jallmann/orgs","repos_url":"https://api.github.com/users/jallmann/repos","events_url":"https://api.github.com/users/jallmann/events{/privacy}","received_events_url":"https://api.github.com/users/jallmann/received_events","type":"User","site_admin":false},"body":"Opened an issue to address this in the future. \r\nhttps://github.com/mozilla/tls-interop/issues/8","created_at":"2018-09-19T15:32:53Z","updated_at":"2018-09-19T15:32:53Z","html_url":"https://github.com/mozilla/tls-interop/pull/5#discussion_r218853251","pull_request_url":"https://api.github.com/repos/mozilla/tls-interop/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/comments/218853251"},"html":{"href":"https://github.com/mozilla/tls-interop/pull/5#discussion_r218853251"},"pull_request":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/5"}},"in_reply_to_id":215461869},"pull_request":{"url":"https://api.github.com/repos/mozilla/tls-interop/pulls/5","id":210308813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzA4ODEz","html_url":"https://github.com/mozilla/tls-interop/pull/5","diff_url":"https://github.com/mozilla/tls-interop/pull/5.diff","patch_url":"https://github.com/mozilla/tls-interop/pull/5.patch","issue_url":"https://api.github.com/repos/mozilla/tls-interop/issues/5","number":5,"state":"open","locked":false,"title":"This is what NSS runs in CI","user":{"login":"martinthomson","id":67641,"node_id":"MDQ6VXNlcjY3NjQx","avatar_url":"https://avatars1.githubusercontent.com/u/67641?v=4","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"If this isn't good - and I'm not qualified to say, nor inclined to review the entire lot - then we have a problem.\r\n\r\n@franziskuskiefer or @jallmann might be able to provide input on the changes.","created_at":"2018-08-23T01:47:30Z","updated_at":"2018-09-19T15:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793ce52136cf8818ddd9a834423cef442a42d94a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/tls-interop/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mozilla/tls-interop/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mozilla/tls-interop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/tls-interop/issues/5/comments","statuses_url":"https://api.github.com/repos/mozilla/tls-interop/statuses/a21f45000ada5bac69845fa0661ccffcc3de752e","head":{"label":"jallmann:master","ref":"master","sha":"a21f45000ada5bac69845fa0661ccffcc3de752e","user":{"login":"jallmann","id":35806322,"node_id":"MDQ6VXNlcjM1ODA2MzIy","avatar_url":"https://avatars3.githubusercontent.com/u/35806322?v=4","gravatar_id":"","url":"https://api.github.com/users/jallmann","html_url":"https://github.com/jallmann","followers_url":"https://api.github.com/users/jallmann/followers","following_url":"https://api.github.com/users/jallmann/following{/other_user}","gists_url":"https://api.github.com/users/jallmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jallmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jallmann/subscriptions","organizations_url":"https://api.github.com/users/jallmann/orgs","repos_url":"https://api.github.com/users/jallmann/repos","events_url":"https://api.github.com/users/jallmann/events{/privacy}","received_events_url":"https://api.github.com/users/jallmann/received_events","type":"User","site_admin":false},"repo":{"id":131833132,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4MzMxMzI=","name":"tls-interop","full_name":"jallmann/tls-interop","private":false,"owner":{"login":"jallmann","id":35806322,"node_id":"MDQ6VXNlcjM1ODA2MzIy","avatar_url":"https://avatars3.githubusercontent.com/u/35806322?v=4","gravatar_id":"","url":"https://api.github.com/users/jallmann","html_url":"https://github.com/jallmann","followers_url":"https://api.github.com/users/jallmann/followers","following_url":"https://api.github.com/users/jallmann/following{/other_user}","gists_url":"https://api.github.com/users/jallmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jallmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jallmann/subscriptions","organizations_url":"https://api.github.com/users/jallmann/orgs","repos_url":"https://api.github.com/users/jallmann/repos","events_url":"https://api.github.com/users/jallmann/events{/privacy}","received_events_url":"https://api.github.com/users/jallmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jallmann/tls-interop","description":null,"fork":true,"url":"https://api.github.com/repos/jallmann/tls-interop","forks_url":"https://api.github.com/repos/jallmann/tls-interop/forks","keys_url":"https://api.github.com/repos/jallmann/tls-interop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jallmann/tls-interop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jallmann/tls-interop/teams","hooks_url":"https://api.github.com/repos/jallmann/tls-interop/hooks","issue_events_url":"https://api.github.com/repos/jallmann/tls-interop/issues/events{/number}","events_url":"https://api.github.com/repos/jallmann/tls-interop/events","assignees_url":"https://api.github.com/repos/jallmann/tls-interop/assignees{/user}","branches_url":"https://api.github.com/repos/jallmann/tls-interop/branches{/branch}","tags_url":"https://api.github.com/repos/jallmann/tls-interop/tags","blobs_url":"https://api.github.com/repos/jallmann/tls-interop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jallmann/tls-interop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jallmann/tls-interop/git/refs{/sha}","trees_url":"https://api.github.com/repos/jallmann/tls-interop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jallmann/tls-interop/statuses/{sha}","languages_url":"https://api.github.com/repos/jallmann/tls-interop/languages","stargazers_url":"https://api.github.com/repos/jallmann/tls-interop/stargazers","contributors_url":"https://api.github.com/repos/jallmann/tls-interop/contributors","subscribers_url":"https://api.github.com/repos/jallmann/tls-interop/subscribers","subscription_url":"https://api.github.com/repos/jallmann/tls-interop/subscription","commits_url":"https://api.github.com/repos/jallmann/tls-interop/commits{/sha}","git_commits_url":"https://api.github.com/repos/jallmann/tls-interop/git/commits{/sha}","comments_url":"https://api.github.com/repos/jallmann/tls-interop/comments{/number}","issue_comment_url":"https://api.github.com/repos/jallmann/tls-interop/issues/comments{/number}","contents_url":"https://api.github.com/repos/jallmann/tls-interop/contents/{+path}","compare_url":"https://api.github.com/repos/jallmann/tls-interop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jallmann/tls-interop/merges","archive_url":"https://api.github.com/repos/jallmann/tls-interop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jallmann/tls-interop/downloads","issues_url":"https://api.github.com/repos/jallmann/tls-interop/issues{/number}","pulls_url":"https://api.github.com/repos/jallmann/tls-interop/pulls{/number}","milestones_url":"https://api.github.com/repos/jallmann/tls-interop/milestones{/number}","notifications_url":"https://api.github.com/repos/jallmann/tls-interop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jallmann/tls-interop/labels{/name}","releases_url":"https://api.github.com/repos/jallmann/tls-interop/releases{/id}","deployments_url":"https://api.github.com/repos/jallmann/tls-interop/deployments","created_at":"2018-05-02T10:07:57Z","updated_at":"2018-09-17T13:17:51Z","pushed_at":"2018-09-17T13:18:41Z","git_url":"git://github.com/jallmann/tls-interop.git","ssh_url":"git@github.com:jallmann/tls-interop.git","clone_url":"https://github.com/jallmann/tls-interop.git","svn_url":"https://github.com/jallmann/tls-interop","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c4b66ea2bf8efa12c5e609c24eedde2819d084a3","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":78570873,"node_id":"MDEwOlJlcG9zaXRvcnk3ODU3MDg3Mw==","name":"tls-interop","full_name":"mozilla/tls-interop","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/tls-interop","description":null,"fork":false,"url":"https://api.github.com/repos/mozilla/tls-interop","forks_url":"https://api.github.com/repos/mozilla/tls-interop/forks","keys_url":"https://api.github.com/repos/mozilla/tls-interop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/tls-interop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/tls-interop/teams","hooks_url":"https://api.github.com/repos/mozilla/tls-interop/hooks","issue_events_url":"https://api.github.com/repos/mozilla/tls-interop/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/tls-interop/events","assignees_url":"https://api.github.com/repos/mozilla/tls-interop/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/tls-interop/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/tls-interop/tags","blobs_url":"https://api.github.com/repos/mozilla/tls-interop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/tls-interop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/tls-interop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/tls-interop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/tls-interop/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/tls-interop/languages","stargazers_url":"https://api.github.com/repos/mozilla/tls-interop/stargazers","contributors_url":"https://api.github.com/repos/mozilla/tls-interop/contributors","subscribers_url":"https://api.github.com/repos/mozilla/tls-interop/subscribers","subscription_url":"https://api.github.com/repos/mozilla/tls-interop/subscription","commits_url":"https://api.github.com/repos/mozilla/tls-interop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/tls-interop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/tls-interop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/tls-interop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/tls-interop/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/tls-interop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/tls-interop/merges","archive_url":"https://api.github.com/repos/mozilla/tls-interop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/tls-interop/downloads","issues_url":"https://api.github.com/repos/mozilla/tls-interop/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/tls-interop/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/tls-interop/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/tls-interop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/tls-interop/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/tls-interop/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/tls-interop/deployments","created_at":"2017-01-10T20:25:28Z","updated_at":"2018-09-05T23:04:17Z","pushed_at":"2018-09-17T13:17:51Z","git_url":"git://github.com/mozilla/tls-interop.git","ssh_url":"git@github.com:mozilla/tls-interop.git","clone_url":"https://github.com/mozilla/tls-interop.git","svn_url":"https://github.com/mozilla/tls-interop","homepage":null,"size":8,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":5,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/5"},"html":{"href":"https://github.com/mozilla/tls-interop/pull/5"},"issue":{"href":"https://api.github.com/repos/mozilla/tls-interop/issues/5"},"comments":{"href":"https://api.github.com/repos/mozilla/tls-interop/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/tls-interop/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/tls-interop/statuses/a21f45000ada5bac69845fa0661ccffcc3de752e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jallmann"}}