{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/239797538","pull_request_review_id":182679788,"id":239797538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc5NzUzOA==","diff_hunk":"@@ -16,6 +16,7 @@ modules=default_login_policy,default_guest_policy,default_oauth_policy,default_b\n [default_login_policy]\n description=Username/password login\n type=Authentication::Login\n+source_id=local","path":"conf/portal_modules.conf.defaults","position":4,"original_position":4,"commit_id":"e50313f44dda4977f6e7f9d1ecf9c7f3647bdd8f","original_commit_id":"e50313f44dda4977f6e7f9d1ecf9c7f3647bdd8f","user":{"login":"nqb","id":10830260,"node_id":"MDQ6VXNlcjEwODMwMjYw","avatar_url":"https://avatars2.githubusercontent.com/u/10830260?v=4","gravatar_id":"","url":"https://api.github.com/users/nqb","html_url":"https://github.com/nqb","followers_url":"https://api.github.com/users/nqb/followers","following_url":"https://api.github.com/users/nqb/following{/other_user}","gists_url":"https://api.github.com/users/nqb/gists{/gist_id}","starred_url":"https://api.github.com/users/nqb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nqb/subscriptions","organizations_url":"https://api.github.com/users/nqb/orgs","repos_url":"https://api.github.com/users/nqb/repos","events_url":"https://api.github.com/users/nqb/events{/privacy}","received_events_url":"https://api.github.com/users/nqb/received_events","type":"User","site_admin":false},"body":"> The sources on the connection profile are used if not sources are put in source_id\r\n\r\n![screenshot from 2018-12-07 13-53-29](https://user-images.githubusercontent.com/10830260/49648806-7fd2f380-fa27-11e8-9465-fbf853bad159.png)\r\n\r\nThere is no help text that mentioned that the source on the connection profiles will be used.","created_at":"2018-12-07T12:54:40Z","updated_at":"2018-12-07T12:54:40Z","html_url":"https://github.com/inverse-inc/packetfence/pull/3827#discussion_r239797538","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/239797538"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/3827#discussion_r239797538"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827"}},"in_reply_to_id":238290183},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827","id":235466754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDY2NzU0","html_url":"https://github.com/inverse-inc/packetfence/pull/3827","diff_url":"https://github.com/inverse-inc/packetfence/pull/3827.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/3827.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/3827","number":3827,"state":"open","locked":false,"title":"Change defaults conf files: portal_modules, profiles and switches","user":{"login":"nqb","id":10830260,"node_id":"MDQ6VXNlcjEwODMwMjYw","avatar_url":"https://avatars2.githubusercontent.com/u/10830260?v=4","gravatar_id":"","url":"https://api.github.com/users/nqb","html_url":"https://github.com/nqb","followers_url":"https://api.github.com/users/nqb/followers","following_url":"https://api.github.com/users/nqb/following{/other_user}","gists_url":"https://api.github.com/users/nqb/gists{/gist_id}","starred_url":"https://api.github.com/users/nqb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nqb/subscriptions","organizations_url":"https://api.github.com/users/nqb/orgs","repos_url":"https://api.github.com/users/nqb/repos","events_url":"https://api.github.com/users/nqb/events{/privacy}","received_events_url":"https://api.github.com/users/nqb/received_events","type":"User","site_admin":false},"body":"# Description\r\nChange defaults in portal_modules, profiles and switches conf files to simplify configuration.\r\n\r\n# Impacts\r\n- Portal modules\r\n- Network switches\r\n- Connection profiles\r\n- Upgrades ?\r\n\r\n# Issue\r\nfixes #3702 \r\n\r\n# Delete branch after merge\r\nYES\r\n\r\n# Checklist\r\n[n/a]\r\n\r\n# NEWS file entries\r\n## Enhancements\r\n* Simplify configuration of portal modules, connection profiles and switches\r\n\r\n","created_at":"2018-12-03T14:29:46Z","updated_at":"2018-12-07T12:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69259037b73d52f7fdbd615db0e9a517e1e27b10","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jrouzierinverse","id":2727473,"node_id":"MDQ6VXNlcjI3Mjc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2727473?v=4","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":641685661,"node_id":"MDU6TGFiZWw2NDE2ODU2NjE=","url":"https://api.github.com/repos/inverse-inc/packetfence/labels/Priority:%20Medium","name":"Priority: Medium","color":"b60205","default":false},{"id":586478,"node_id":"MDU6TGFiZWw1ODY0Nzg=","url":"https://api.github.com/repos/inverse-inc/packetfence/labels/Type:%20Feature%20/%20Enhancement","name":"Type: Feature / Enhancement","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/32","html_url":"https://github.com/inverse-inc/packetfence/milestone/32","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/32/labels","id":3648462,"node_id":"MDk6TWlsZXN0b25lMzY0ODQ2Mg==","number":32,"title":"PacketFence-8.3","description":"","creator":{"login":"julsemaan","id":3857942,"node_id":"MDQ6VXNlcjM4NTc5NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3857942?v=4","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"open_issues":195,"closed_issues":12,"state":"open","created_at":"2018-09-12T12:46:51Z","updated_at":"2018-12-07T12:53:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/3827/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/e50313f44dda4977f6e7f9d1ecf9c7f3647bdd8f","head":{"label":"inverse-inc:feature/change-defaults","ref":"feature/change-defaults","sha":"e50313f44dda4977f6e7f9d1ecf9c7f3647bdd8f","user":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1NjU4","name":"packetfence","full_name":"inverse-inc/packetfence","private":false,"owner":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2018-12-07T12:53:21Z","pushed_at":"2018-12-07T12:53:12Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":242445,"stargazers_count":516,"watchers_count":516,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":162,"open_issues":329,"watchers":516,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"f7f382043eb1eaf98f5fac82b64a8707fd692dca","user":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1NjU4","name":"packetfence","full_name":"inverse-inc/packetfence","private":false,"owner":{"login":"inverse-inc","id":1203154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDMxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1203154?v=4","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2018-12-07T12:53:21Z","pushed_at":"2018-12-07T12:53:12Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":242445,"stargazers_count":516,"watchers_count":516,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":162,"open_issues":329,"watchers":516,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/3827"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/3827"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/3827/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/3827/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/e50313f44dda4977f6e7f9d1ecf9c7f3647bdd8f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nqb"}}