{"action":"created","issue":{"url":"https://api.github.com/repos/jadu/pulsar/issues/823","repository_url":"https://api.github.com/repos/jadu/pulsar","labels_url":"https://api.github.com/repos/jadu/pulsar/issues/823/labels{/name}","comments_url":"https://api.github.com/repos/jadu/pulsar/issues/823/comments","events_url":"https://api.github.com/repos/jadu/pulsar/issues/823/events","html_url":"https://github.com/jadu/pulsar/pull/823","id":319869797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1Njc3NTc2","number":823,"title":"Big Funkin' Accessibility Test","user":{"login":"Stanton","id":18653,"node_id":"MDQ6VXNlcjE4NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/18653?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanton","html_url":"https://github.com/Stanton","followers_url":"https://api.github.com/users/Stanton/followers","following_url":"https://api.github.com/users/Stanton/following{/other_user}","gists_url":"https://api.github.com/users/Stanton/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanton/subscriptions","organizations_url":"https://api.github.com/users/Stanton/orgs","repos_url":"https://api.github.com/users/Stanton/repos","events_url":"https://api.github.com/users/Stanton/events{/privacy}","received_events_url":"https://api.github.com/users/Stanton/received_events","type":"User","site_admin":false},"labels":[{"id":771163932,"node_id":"MDU6TGFiZWw3NzExNjM5MzI=","url":"https://api.github.com/repos/jadu/pulsar/labels/a11y","name":"a11y","color":"82ea38","default":false}],"state":"open","locked":false,"assignee":{"login":"Stanton","id":18653,"node_id":"MDQ6VXNlcjE4NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/18653?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanton","html_url":"https://github.com/Stanton","followers_url":"https://api.github.com/users/Stanton/followers","following_url":"https://api.github.com/users/Stanton/following{/other_user}","gists_url":"https://api.github.com/users/Stanton/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanton/subscriptions","organizations_url":"https://api.github.com/users/Stanton/orgs","repos_url":"https://api.github.com/users/Stanton/repos","events_url":"https://api.github.com/users/Stanton/events{/privacy}","received_events_url":"https://api.github.com/users/Stanton/received_events","type":"User","site_admin":false},"assignees":[{"login":"Stanton","id":18653,"node_id":"MDQ6VXNlcjE4NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/18653?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanton","html_url":"https://github.com/Stanton","followers_url":"https://api.github.com/users/Stanton/followers","following_url":"https://api.github.com/users/Stanton/following{/other_user}","gists_url":"https://api.github.com/users/Stanton/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanton/subscriptions","organizations_url":"https://api.github.com/users/Stanton/orgs","repos_url":"https://api.github.com/users/Stanton/repos","events_url":"https://api.github.com/users/Stanton/events{/privacy}","received_events_url":"https://api.github.com/users/Stanton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-03T10:44:20Z","updated_at":"2018-08-13T07:49:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jadu/pulsar/pulls/823","html_url":"https://github.com/jadu/pulsar/pull/823","diff_url":"https://github.com/jadu/pulsar/pull/823.diff","patch_url":"https://github.com/jadu/pulsar/pull/823.patch"},"body":"## Changes which need to filter down to Continuum products\r\n\r\n| Component | Reason | Change | \r\n| ---- | ---- | ---- |\r\n| Forms / Colour picker | Unlabelled input | There is a hidden input (by display:none) which has no label and is not required to be interacted with, this has been changed to `type=\"hidden\"` to allow it to continue unlabelled |\r\n| Forms / Toggle Switch | WCAG 2.0, Level A: 4.1.2 | There are two label elements in this control, both were using the same value passed to the helper. One of them now appends to the passed value, e.g. 'toggle $value' to stop the error regarding duplicated labels |\r\n| Help Text Component | WCAG 2.0, Level A: 4.1.2 | Change the open/close controls to use `<button>` rather than `<a>` |\r\n| Navigation | WCAG 2.0, Level A: 4.1.2 | Change the default href for the main branding image (top left) to be `/` instead of `#` |\r\n| Notifications | WCAG 2.0, Level A: 4.1.2 | Change the notification toggle (bell icon) to use `<button>` rather than an `<a>` |\r\n|  | WCAG 2.0, Level A: 4.1.2 | Change the notification 'dismiss all' action to use `<button>` rather than an `<a>` |\r\n|  | WCAG 2.0, Level A: 4.1.2 | Change the notification 'view all' action to use `<button>` rather than an `<a>` |\r\n| User Guides | WCAG 2.0, Level A: 4.1.2 | Change the user guides button to use a `<button>` rather than an `<a>`\r\n\r\n## Breaking change checklist\r\n\r\nThe following points should be considered as an early-warning of introducing a breaking change to a Continuum platform product. This is not an exhaustive list of what constitutes a breaking change.\r\n\r\n| Does this pull request... | Yes / No |\r\n| ---- | ---- |\r\n| require changes to `main.js` | ✅ No |\r\n| require changes to `index.js` | ✅ No |\r\n| require changes to `pulsar.scss` | ✅ No |\r\n| require changes to `gruntfile.js` | ✅ No |\r\n| require changes to `package.json` (not including dev dependencies) | ✅ No |\r\n| require changes to `base.html.twig` (or other core views like header/footer) | ✅ No |\r\n| require new arguments to be passed to a js component | ✅ No |\r\n| require markup changes to maintain functionality | ✅ No - multiple markup changes are required to implement these accessibility changes, they're not strictly required for maintain functionality so currently don't constitute a breaking change |"},"comment":{"url":"https://api.github.com/repos/jadu/pulsar/issues/comments/412435753","html_url":"https://github.com/jadu/pulsar/pull/823#issuecomment-412435753","issue_url":"https://api.github.com/repos/jadu/pulsar/issues/823","id":412435753,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQzNTc1Mw==","user":{"login":"Stanton","id":18653,"node_id":"MDQ6VXNlcjE4NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/18653?v=4","gravatar_id":"","url":"https://api.github.com/users/Stanton","html_url":"https://github.com/Stanton","followers_url":"https://api.github.com/users/Stanton/followers","following_url":"https://api.github.com/users/Stanton/following{/other_user}","gists_url":"https://api.github.com/users/Stanton/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanton/subscriptions","organizations_url":"https://api.github.com/users/Stanton/orgs","repos_url":"https://api.github.com/users/Stanton/repos","events_url":"https://api.github.com/users/Stanton/events{/privacy}","received_events_url":"https://api.github.com/users/Stanton/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T07:49:01Z","updated_at":"2018-08-13T07:49:01Z","author_association":"MEMBER","body":"Ready for re-review @jamesjacobs @mikedevelops "}}
{"actor":{"display_login":"Stanton"}}