{"action":"opened","number":2408,"pull_request":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408","id":197579845,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTc5ODQ1","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2408","diff_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2408.diff","patch_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2408.patch","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2408","number":2408,"state":"open","locked":false,"title":"Remove impossible route","user":{"login":"mkllnk","id":3524483,"node_id":"MDQ6VXNlcjM1MjQ0ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3524483?v=4","gravatar_id":"","url":"https://api.github.com/users/mkllnk","html_url":"https://github.com/mkllnk","followers_url":"https://api.github.com/users/mkllnk/followers","following_url":"https://api.github.com/users/mkllnk/following{/other_user}","gists_url":"https://api.github.com/users/mkllnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mkllnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkllnk/subscriptions","organizations_url":"https://api.github.com/users/mkllnk/orgs","repos_url":"https://api.github.com/users/mkllnk/repos","events_url":"https://api.github.com/users/mkllnk/events{/privacy}","received_events_url":"https://api.github.com/users/mkllnk/received_events","type":"User","site_admin":false},"body":"#### What? Why?\r\n\r\nI randomly came across this impossible entry in our routes: `get \"/#/login\"`\r\n\r\nHash fragments are not part of the http request and not sent to the\r\nserver. So the routes will never see a hash fragment which means that\r\nthis route is never used.\r\n\r\n#### What should we test?\r\n\r\nLogging in from a few different screens.\r\n\r\n#### Release notes\r\n\r\nRemoved unused code.","created_at":"2018-06-26T23:36:05Z","updated_at":"2018-06-26T23:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"mkllnk","id":3524483,"node_id":"MDQ6VXNlcjM1MjQ0ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3524483?v=4","gravatar_id":"","url":"https://api.github.com/users/mkllnk","html_url":"https://github.com/mkllnk","followers_url":"https://api.github.com/users/mkllnk/followers","following_url":"https://api.github.com/users/mkllnk/following{/other_user}","gists_url":"https://api.github.com/users/mkllnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mkllnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkllnk/subscriptions","organizations_url":"https://api.github.com/users/mkllnk/orgs","repos_url":"https://api.github.com/users/mkllnk/repos","events_url":"https://api.github.com/users/mkllnk/events{/privacy}","received_events_url":"https://api.github.com/users/mkllnk/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkllnk","id":3524483,"node_id":"MDQ6VXNlcjM1MjQ0ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3524483?v=4","gravatar_id":"","url":"https://api.github.com/users/mkllnk","html_url":"https://github.com/mkllnk","followers_url":"https://api.github.com/users/mkllnk/followers","following_url":"https://api.github.com/users/mkllnk/following{/other_user}","gists_url":"https://api.github.com/users/mkllnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mkllnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkllnk/subscriptions","organizations_url":"https://api.github.com/users/mkllnk/orgs","repos_url":"https://api.github.com/users/mkllnk/repos","events_url":"https://api.github.com/users/mkllnk/events{/privacy}","received_events_url":"https://api.github.com/users/mkllnk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408/commits","review_comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408/comments","review_comment_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2408/comments","statuses_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/14b7bca3198fdd28ea4f7f37cc4ca740cced2c57","head":{"label":"mkllnk:cleanup-route","ref":"cleanup-route","sha":"14b7bca3198fdd28ea4f7f37cc4ca740cced2c57","user":{"login":"mkllnk","id":3524483,"node_id":"MDQ6VXNlcjM1MjQ0ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3524483?v=4","gravatar_id":"","url":"https://api.github.com/users/mkllnk","html_url":"https://github.com/mkllnk","followers_url":"https://api.github.com/users/mkllnk/followers","following_url":"https://api.github.com/users/mkllnk/following{/other_user}","gists_url":"https://api.github.com/users/mkllnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mkllnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkllnk/subscriptions","organizations_url":"https://api.github.com/users/mkllnk/orgs","repos_url":"https://api.github.com/users/mkllnk/repos","events_url":"https://api.github.com/users/mkllnk/events{/privacy}","received_events_url":"https://api.github.com/users/mkllnk/received_events","type":"User","site_admin":false},"repo":{"id":56657154,"node_id":"MDEwOlJlcG9zaXRvcnk1NjY1NzE1NA==","name":"openfoodnetwork","full_name":"mkllnk/openfoodnetwork","owner":{"login":"mkllnk","id":3524483,"node_id":"MDQ6VXNlcjM1MjQ0ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3524483?v=4","gravatar_id":"","url":"https://api.github.com/users/mkllnk","html_url":"https://github.com/mkllnk","followers_url":"https://api.github.com/users/mkllnk/followers","following_url":"https://api.github.com/users/mkllnk/following{/other_user}","gists_url":"https://api.github.com/users/mkllnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mkllnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkllnk/subscriptions","organizations_url":"https://api.github.com/users/mkllnk/orgs","repos_url":"https://api.github.com/users/mkllnk/repos","events_url":"https://api.github.com/users/mkllnk/events{/privacy}","received_events_url":"https://api.github.com/users/mkllnk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkllnk/openfoodnetwork","description":"Connect suppliers, distributors and consumers for the sale and purchase of local produce","fork":true,"url":"https://api.github.com/repos/mkllnk/openfoodnetwork","forks_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/forks","keys_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/teams","hooks_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/hooks","issue_events_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/events","assignees_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/tags","blobs_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/languages","stargazers_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/stargazers","contributors_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/contributors","subscribers_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/subscribers","subscription_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/subscription","commits_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/merges","archive_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/downloads","issues_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/labels{/name}","releases_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/mkllnk/openfoodnetwork/deployments","created_at":"2016-04-20T05:11:43Z","updated_at":"2018-06-14T22:45:16Z","pushed_at":"2018-06-26T23:31:52Z","git_url":"git://github.com/mkllnk/openfoodnetwork.git","ssh_url":"git@github.com:mkllnk/openfoodnetwork.git","clone_url":"https://github.com/mkllnk/openfoodnetwork.git","svn_url":"https://github.com/mkllnk/openfoodnetwork","homepage":"http://openfoodnetwork.org/","size":37613,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfoodfoundation:master","ref":"master","sha":"eb9064f5be3433ed72f708c32bccbaa635a2988d","user":{"login":"openfoodfoundation","id":2578987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzg5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2578987?v=4","gravatar_id":"","url":"https://api.github.com/users/openfoodfoundation","html_url":"https://github.com/openfoodfoundation","followers_url":"https://api.github.com/users/openfoodfoundation/followers","following_url":"https://api.github.com/users/openfoodfoundation/following{/other_user}","gists_url":"https://api.github.com/users/openfoodfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/openfoodfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfoodfoundation/subscriptions","organizations_url":"https://api.github.com/users/openfoodfoundation/orgs","repos_url":"https://api.github.com/users/openfoodfoundation/repos","events_url":"https://api.github.com/users/openfoodfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/openfoodfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":6257856,"node_id":"MDEwOlJlcG9zaXRvcnk2MjU3ODU2","name":"openfoodnetwork","full_name":"openfoodfoundation/openfoodnetwork","owner":{"login":"openfoodfoundation","id":2578987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzg5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2578987?v=4","gravatar_id":"","url":"https://api.github.com/users/openfoodfoundation","html_url":"https://github.com/openfoodfoundation","followers_url":"https://api.github.com/users/openfoodfoundation/followers","following_url":"https://api.github.com/users/openfoodfoundation/following{/other_user}","gists_url":"https://api.github.com/users/openfoodfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/openfoodfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfoodfoundation/subscriptions","organizations_url":"https://api.github.com/users/openfoodfoundation/orgs","repos_url":"https://api.github.com/users/openfoodfoundation/repos","events_url":"https://api.github.com/users/openfoodfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/openfoodfoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openfoodfoundation/openfoodnetwork","description":"Connect suppliers, distributors and consumers for the sale and purchase of local produce","fork":false,"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","forks_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/forks","keys_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/teams","hooks_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/hooks","issue_events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/events","assignees_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/tags","blobs_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/languages","stargazers_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/stargazers","contributors_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/contributors","subscribers_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/subscribers","subscription_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/subscription","commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/merges","archive_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/downloads","issues_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/labels{/name}","releases_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/deployments","created_at":"2012-10-17T07:56:23Z","updated_at":"2018-06-26T23:12:26Z","pushed_at":"2018-06-26T23:29:59Z","git_url":"git://github.com/openfoodfoundation/openfoodnetwork.git","ssh_url":"git@github.com:openfoodfoundation/openfoodnetwork.git","clone_url":"https://github.com/openfoodfoundation/openfoodnetwork.git","svn_url":"https://github.com/openfoodfoundation/openfoodnetwork","homepage":"http://openfoodnetwork.org/","size":37717,"stargazers_count":286,"watchers_count":286,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":477,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":188,"open_issues":477,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408"},"html":{"href":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2408"},"issue":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2408"},"comments":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2408/comments"},"review_comments":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408/comments"},"review_comment":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2408/commits"},"statuses":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/14b7bca3198fdd28ea4f7f37cc4ca740cced2c57"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mkllnk"}}