{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16073","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16073/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16073/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16073/events","html_url":"https://github.com/home-assistant/home-assistant/pull/16073","id":352105035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDk4Njc4","number":16073,"title":"Create gitignore on version upgrade","user":{"login":"balloob","id":1444314,"node_id":"MDQ6VXNlcjE0NDQzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"balloob","id":1444314,"node_id":"MDQ6VXNlcjE0NDQzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"assignees":[{"login":"balloob","id":1444314,"node_id":"MDQ6VXNlcjE0NDQzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-08-20T12:02:04Z","updated_at":"2018-08-20T19:15:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16073","html_url":"https://github.com/home-assistant/home-assistant/pull/16073","diff_url":"https://github.com/home-assistant/home-assistant/pull/16073.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/16073.patch"},"body":"## Description:\r\nI saw a tweet with someone sharing their config and it contained a secrets file. This is something we should actively try to avoid, as people might end up publishing their secrets to GitHub (not good!).\r\n\r\nWhenever a user does a version upgrade, we'll check if the user is storing their config in git. If so, we're going to read the `.gitignore` file and make sure both `.storage` and `secrets.yaml` are in it. If not, we add them and add a warning to their UI.\r\n\r\n![screen shot 2018-08-20 at 1 29 01 pm](https://user-images.githubusercontent.com/1444314/44340768-2ea5f080-a486-11e8-8dec-dc6402fe60ec.png)\r\n\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/414430662","html_url":"https://github.com/home-assistant/home-assistant/pull/16073#issuecomment-414430662","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16073","id":414430662,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQzMDY2Mg==","user":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T19:15:56Z","updated_at":"2018-08-20T19:15:56Z","author_association":"CONTRIBUTOR","body":"Fell like too ambitious,  I will prefer have a notification pop up rather than change .gitignore. But it will be fine too add a new .gitignore if there is no one."}}
{"actor":{"display_login":"awarecan"}}