{"action":"created","issue":{"url":"https://api.github.com/repos/jenkins-x/jx/issues/2558","repository_url":"https://api.github.com/repos/jenkins-x/jx","labels_url":"https://api.github.com/repos/jenkins-x/jx/issues/2558/labels{/name}","comments_url":"https://api.github.com/repos/jenkins-x/jx/issues/2558/comments","events_url":"https://api.github.com/repos/jenkins-x/jx/issues/2558/events","html_url":"https://github.com/jenkins-x/jx/pull/2558","id":393131998,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjM4ODg5","number":2558,"title":"bug(controller buildnumbers): Remove encoding of PipelineActivity.Name","user":{"login":"markawm","id":42846990,"node_id":"MDQ6VXNlcjQyODQ2OTkw","avatar_url":"https://avatars2.githubusercontent.com/u/42846990?v=4","gravatar_id":"","url":"https://api.github.com/users/markawm","html_url":"https://github.com/markawm","followers_url":"https://api.github.com/users/markawm/followers","following_url":"https://api.github.com/users/markawm/following{/other_user}","gists_url":"https://api.github.com/users/markawm/gists{/gist_id}","starred_url":"https://api.github.com/users/markawm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markawm/subscriptions","organizations_url":"https://api.github.com/users/markawm/orgs","repos_url":"https://api.github.com/users/markawm/repos","events_url":"https://api.github.com/users/markawm/events{/privacy}","received_events_url":"https://api.github.com/users/markawm/received_events","type":"User","site_admin":false},"labels":[{"id":1019526670,"node_id":"MDU6TGFiZWwxMDE5NTI2Njcw","url":"https://api.github.com/repos/jenkins-x/jx/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":1012676885,"node_id":"MDU6TGFiZWwxMDEyNjc2ODg1","url":"https://api.github.com/repos/jenkins-x/jx/labels/size/S","name":"size/S","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"amuniz","id":1017585,"node_id":"MDQ6VXNlcjEwMTc1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1017585?v=4","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"assignees":[{"login":"garethjevans","id":158150,"node_id":"MDQ6VXNlcjE1ODE1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/158150?v=4","gravatar_id":"","url":"https://api.github.com/users/garethjevans","html_url":"https://github.com/garethjevans","followers_url":"https://api.github.com/users/garethjevans/followers","following_url":"https://api.github.com/users/garethjevans/following{/other_user}","gists_url":"https://api.github.com/users/garethjevans/gists{/gist_id}","starred_url":"https://api.github.com/users/garethjevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethjevans/subscriptions","organizations_url":"https://api.github.com/users/garethjevans/orgs","repos_url":"https://api.github.com/users/garethjevans/repos","events_url":"https://api.github.com/users/garethjevans/events{/privacy}","received_events_url":"https://api.github.com/users/garethjevans/received_events","type":"User","site_admin":false},{"login":"amuniz","id":1017585,"node_id":"MDQ6VXNlcjEwMTc1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1017585?v=4","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},{"login":"mikecirioli","id":8135503,"node_id":"MDQ6VXNlcjgxMzU1MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8135503?v=4","gravatar_id":"","url":"https://api.github.com/users/mikecirioli","html_url":"https://github.com/mikecirioli","followers_url":"https://api.github.com/users/mikecirioli/followers","following_url":"https://api.github.com/users/mikecirioli/following{/other_user}","gists_url":"https://api.github.com/users/mikecirioli/gists{/gist_id}","starred_url":"https://api.github.com/users/mikecirioli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikecirioli/subscriptions","organizations_url":"https://api.github.com/users/mikecirioli/orgs","repos_url":"https://api.github.com/users/mikecirioli/repos","events_url":"https://api.github.com/users/mikecirioli/events{/privacy}","received_events_url":"https://api.github.com/users/mikecirioli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-20T16:59:39Z","updated_at":"2018-12-21T14:49:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jenkins-x/jx/pulls/2558","html_url":"https://github.com/jenkins-x/jx/pull/2558","diff_url":"https://github.com/jenkins-x/jx/pull/2558.diff","patch_url":"https://github.com/jenkins-x/jx/pull/2558.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first PR, read our contributor guidelines https://jenkins-x.io/contribute/\r\n2. Follow these instructions to write commit messages http://karma-runner.github.io/3.0/dev/git-commit-msg.html\r\n3. Follow these instructions to write tests https://jenkins-x.io/contribute/development/#testing\r\n4. You can trigger the tests for your PR with /test bdd\r\n5. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n#### Submitter checklist\r\n\r\n- [x] Change is code complete and matches issue description.\r\n- [ ] Change is covered by existing or new tests.\r\n\r\n#### Description\r\n\r\nPreviously added some encoding of upper case letters in org/repo/branch to form legal K8S Name values, but this isn't working\r\nproperly. Removing that for now, so that the workaround in Prow (to ToLower everything) can be removed - as ultimately this is\r\ncausing occasional duplicate pipeline refs in PipelineActivities.\r\n\r\n\r\n#### Special notes for the reviewer(s)\r\n\r\n\r\n#### Which issue this PR fixes\r\n\r\nfixes #\r\n\r\n<!--\r\noptional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/jenkins-x/jx/issues/comments/449407673","html_url":"https://github.com/jenkins-x/jx/pull/2558#issuecomment-449407673","issue_url":"https://api.github.com/repos/jenkins-x/jx/issues/2558","id":449407673,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQwNzY3Mw==","user":{"login":"jenkins-x-bot","id":35031835,"node_id":"MDQ6VXNlcjM1MDMxODM1","avatar_url":"https://avatars0.githubusercontent.com/u/35031835?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-x-bot","html_url":"https://github.com/jenkins-x-bot","followers_url":"https://api.github.com/users/jenkins-x-bot/followers","following_url":"https://api.github.com/users/jenkins-x-bot/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-x-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-x-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-x-bot/subscriptions","organizations_url":"https://api.github.com/users/jenkins-x-bot/orgs","repos_url":"https://api.github.com/users/jenkins-x-bot/repos","events_url":"https://api.github.com/users/jenkins-x-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-x-bot/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T14:49:51Z","updated_at":"2018-12-21T14:49:51Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/jenkins-x/jx/pull/2558#issuecomment-449407639\" title=\"LGTM\">garethjevans</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/jenkins-x/jx/blob/master/OWNERS)~~ [garethjevans]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"jenkins-x-bot"}}