{"action":"created","comment":{"url":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments/240784840","pull_request_review_id":183895366,"id":240784840,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc4NDg0MA==","diff_hunk":"@@ -0,0 +1,721 @@\n+global:\n+    feature_order: function () { return feature.sort_rank; }\n+    sdk_api_key: ''\n+\n+fonts:\n+    Montserrat:\n+        url: https://fonts.gstatic.com/s/montserrat/v7/zhcz-_WihjSQC0oHJ9TCYL3hpw3pgy2gAi-Ip7WPMi0.woff\n+    Open Sans:\n+        - weight: 400\n+          url: https://fonts.gstatic.com/s/opensans/v13/wMws1cEtxWZc6AZZIpiqWALUuEpTyoUstqEm5AMlJo4.woff\n+        - weight: 400\n+          style: italic\n+          url: https://fonts.gstatic.com/s/opensans/v13/O4NhV7_qs9r9seTo7fnsVLO3LdcAZYWl9Si6vvxL-qU.woff\n+\n+scene:\n+    background:\n+        color: '#f0ebeb'\n+cameras:\n+    iso-camera:\n+        # Manhattan\n+        position: [-74.00976419448854, 40.70532700869127, 16]\n+        type: isometric\n+        axis: [0, 1]\n+        active: false\n+    perspective-camera:\n+        # Manhattan\n+        position: [-74.00976419448854, 40.70532700869127, 16]\n+        type: perspective\n+        fov: 45\n+        max_tilt: [[2, 0], [16, 90]]\n+        active: true\n+\n+lights:\n+    light1:\n+        type: directional\n+        origin: world\n+        direction: [1, 1, -1]\n+        diffuse: [.3, .3, .3, 1.]\n+        ambient: [0.7, 0.7, 0.7, 1.]\n+\n+textures:\n+    pois:\n+        url: img/poi_icons_32.png\n+        sprites:\n+            plane: [0, 0, 32, 32]\n+            tree: [0, 185, 32, 32]\n+            sunburst: [0, 629, 32, 32]\n+            restaurant: [0, 777, 32, 32]\n+            cafe: [0, 814, 32, 32]\n+            museum: [0, 518, 32, 32]\n+            bar: [0, 887, 32, 32]\n+            train: [0, 74, 32, 32]\n+            bus: [0, 148, 32, 32]\n+            hospital: [0, 444, 32, 32]\n+            parking: [0, 1073, 32, 32]\n+            info: [0, 1110, 32, 32]\n+            hotel: [0, 259, 32, 32]\n+            bookstore: [0, 333, 32, 32]\n+            shield: [0, 1142, 32, 32]\n+            arrow: [1, 1175, 22, 22]\n+\n+styles:\n+    icons:\n+        base: points\n+        texture: pois\n+    heightglow:\n+        base: polygons\n+        blend: translucent\n+        blend_order: -2\n+        lighting: vertex\n+        shaders:\n+            blocks:\n+                color: \"color.rgb += vec3(worldPosition().z / 800.);\"\n+    heightglowline:\n+        base: lines\n+        blend_order: -1\n+        mix: heightglow\n+    dashed:\n+        base: lines\n+        dash: [3.0, 0.3]\n+    transit-lines:\n+        base: lines\n+        blend: overlay\n+        blend_order: -2\n+        shaders:\n+            blocks:\n+                filter: |\n+                    color.rgb *= 1.25; // pump up the colors\n+                    color.a = 0.5;     // translucent\n+        draw: # default draw parameters\n+            color: function() { return feature.colour || 'gray'; }\n+            width: 6px\n+            outline:\n+                color: [.8, .8, .8]\n+                width: 1px\n+            interactive: true\n+\n+sources:\n+    stamen-terrain:\n+        type: Raster\n+        #url: http://a.tile.stamen.com/terrain-background/{z}/{x}/{y}.jpg\n+        url: http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png","path":"scenes/scene-with-disabled-stamen-raster.yaml","position":7,"original_position":102,"commit_id":"18fd3986ffeb0456a6403e52f223e0b790e42e9d","original_commit_id":"936cf6100e83ae3c4218ecd7c8f600cd9351fad7","user":{"login":"matteblair","id":3371850,"node_id":"MDQ6VXNlcjMzNzE4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3371850?v=4","gravatar_id":"","url":"https://api.github.com/users/matteblair","html_url":"https://github.com/matteblair","followers_url":"https://api.github.com/users/matteblair/followers","following_url":"https://api.github.com/users/matteblair/following{/other_user}","gists_url":"https://api.github.com/users/matteblair/gists{/gist_id}","starred_url":"https://api.github.com/users/matteblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteblair/subscriptions","organizations_url":"https://api.github.com/users/matteblair/orgs","repos_url":"https://api.github.com/users/matteblair/repos","events_url":"https://api.github.com/users/matteblair/events{/privacy}","received_events_url":"https://api.github.com/users/matteblair/received_events","type":"User","site_admin":false},"body":"Less importantly, the source doesn't seem to be using the stamen URL and the origin of the tiles isn't actually relevant to the test.","created_at":"2018-12-11T20:47:14Z","updated_at":"2018-12-11T20:47:14Z","html_url":"https://github.com/tangrams/tangram-es/pull/1975#discussion_r240784840","pull_request_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments/240784840"},"html":{"href":"https://github.com/tangrams/tangram-es/pull/1975#discussion_r240784840"},"pull_request":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975"}},"in_reply_to_id":240777954},"pull_request":{"url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975","id":237451364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDUxMzY0","html_url":"https://github.com/tangrams/tangram-es/pull/1975","diff_url":"https://github.com/tangrams/tangram-es/pull/1975.diff","patch_url":"https://github.com/tangrams/tangram-es/pull/1975.patch","issue_url":"https://api.github.com/repos/tangrams/tangram-es/issues/1975","number":1975,"state":"open","locked":false,"title":"Disable tile loading for datasources with layer disabled","user":{"login":"tallytalwar","id":360641,"node_id":"MDQ6VXNlcjM2MDY0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/360641?v=4","gravatar_id":"","url":"https://api.github.com/users/tallytalwar","html_url":"https://github.com/tallytalwar","followers_url":"https://api.github.com/users/tallytalwar/followers","following_url":"https://api.github.com/users/tallytalwar/following{/other_user}","gists_url":"https://api.github.com/users/tallytalwar/gists{/gist_id}","starred_url":"https://api.github.com/users/tallytalwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallytalwar/subscriptions","organizations_url":"https://api.github.com/users/tallytalwar/orgs","repos_url":"https://api.github.com/users/tallytalwar/repos","events_url":"https://api.github.com/users/tallytalwar/events{/privacy}","received_events_url":"https://api.github.com/users/tallytalwar/received_events","type":"User","site_admin":false},"body":"Fixes #1973\r\n\r\ncc. @polar","created_at":"2018-12-10T20:13:13Z","updated_at":"2018-12-11T20:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7bd6eaa784213ec2fb71b512067bb679b653eb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975/commits","review_comments_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975/comments","review_comment_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/issues/1975/comments","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/18fd3986ffeb0456a6403e52f223e0b790e42e9d","head":{"label":"tangrams:do-not-fetch-tiles-from-disabled-layers","ref":"do-not-fetch-tiles-from-disabled-layers","sha":"18fd3986ffeb0456a6403e52f223e0b790e42e9d","user":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":23391501,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM5MTUwMQ==","name":"tangram-es","full_name":"tangrams/tangram-es","private":false,"owner":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tangrams/tangram-es","description":"2D and 3D map renderer using OpenGL ES","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-es","forks_url":"https://api.github.com/repos/tangrams/tangram-es/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-es/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-es/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-es/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-es/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-es/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-es/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-es/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-es/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-es/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-es/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-es/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-es/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-es/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-es/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-es/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-es/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-es/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-es/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-es/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-es/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-es/deployments","created_at":"2014-08-27T13:56:56Z","updated_at":"2018-12-11T18:57:34Z","pushed_at":"2018-12-11T20:32:22Z","git_url":"git://github.com/tangrams/tangram-es.git","ssh_url":"git@github.com:tangrams/tangram-es.git","clone_url":"https://github.com/tangrams/tangram-es.git","svn_url":"https://github.com/tangrams/tangram-es","homepage":"","size":39559,"stargazers_count":464,"watchers_count":464,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":155,"open_issues":141,"watchers":464,"default_branch":"master"}},"base":{"label":"tangrams:master","ref":"master","sha":"6f336e3fb147ec5cc4c751f9b863b476d3320dc5","user":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":23391501,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM5MTUwMQ==","name":"tangram-es","full_name":"tangrams/tangram-es","private":false,"owner":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tangrams/tangram-es","description":"2D and 3D map renderer using OpenGL ES","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-es","forks_url":"https://api.github.com/repos/tangrams/tangram-es/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-es/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-es/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-es/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-es/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-es/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-es/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-es/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-es/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-es/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-es/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-es/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-es/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-es/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-es/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-es/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-es/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-es/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-es/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-es/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-es/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-es/deployments","created_at":"2014-08-27T13:56:56Z","updated_at":"2018-12-11T18:57:34Z","pushed_at":"2018-12-11T20:32:22Z","git_url":"git://github.com/tangrams/tangram-es.git","ssh_url":"git@github.com:tangrams/tangram-es.git","clone_url":"https://github.com/tangrams/tangram-es.git","svn_url":"https://github.com/tangrams/tangram-es","homepage":"","size":39559,"stargazers_count":464,"watchers_count":464,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":155,"open_issues":141,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975"},"html":{"href":"https://github.com/tangrams/tangram-es/pull/1975"},"issue":{"href":"https://api.github.com/repos/tangrams/tangram-es/issues/1975"},"comments":{"href":"https://api.github.com/repos/tangrams/tangram-es/issues/1975/comments"},"review_comments":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975/comments"},"review_comment":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1975/commits"},"statuses":{"href":"https://api.github.com/repos/tangrams/tangram-es/statuses/18fd3986ffeb0456a6403e52f223e0b790e42e9d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matteblair"}}