{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/7707","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/7707/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/7707/comments","events_url":"https://api.github.com/repos/helm/charts/issues/7707/events","html_url":"https://github.com/helm/charts/pull/7707","id":359743037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTY0OTA5","number":7707,"title":"[incubator/fluent-cloudwatch] Fix bug and Support EC2 instance role ","user":{"login":"masahiro331","id":20438853,"node_id":"MDQ6VXNlcjIwNDM4ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20438853?v=4","gravatar_id":"","url":"https://api.github.com/users/masahiro331","html_url":"https://github.com/masahiro331","followers_url":"https://api.github.com/users/masahiro331/followers","following_url":"https://api.github.com/users/masahiro331/following{/other_user}","gists_url":"https://api.github.com/users/masahiro331/gists{/gist_id}","starred_url":"https://api.github.com/users/masahiro331/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masahiro331/subscriptions","organizations_url":"https://api.github.com/users/masahiro331/orgs","repos_url":"https://api.github.com/users/masahiro331/repos","events_url":"https://api.github.com/users/masahiro331/events{/privacy}","received_events_url":"https://api.github.com/users/masahiro331/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false}],"state":"open","locked":false,"assignee":{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"assignees":[{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-13T04:59:20Z","updated_at":"2018-09-27T14:00:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7707","html_url":"https://github.com/helm/charts/pull/7707","diff_url":"https://github.com/helm/charts/pull/7707.diff","patch_url":"https://github.com/helm/charts/pull/7707.patch"},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n1. I want to use EC2 instance iam role. Now,  when arnRole and awsCredentials are empty, using \"<AWS_ACCESS_KEY_ID>\", \"<AWS_SECRET_ACCESS_KEY>\". \r\n2. This pull request fixes default authorization header issue that empty credential,\r\n \"<AWS_ACCESS_KEY_ID>\\n\", is always used without customized credential setting. It enable to use EC2 instance role credential by default. \r\n\r\nThis is error log. \r\n```\r\n2018-09-13 01:51:26 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2018-09-13 01:51:27 +0000 error_class=\"ArgumentError\" error=\"header field value cannot include CR/LF\" plugin_id=\"object:2ab5bbf17b10\"\r\n  2018-09-13 01:51:26 +0000 [warn]: /usr/lib/ruby/2.4.0/net/http/header.rb:25:in `block in initialize_http_header'\r\n  2018-09-13 01:51:26 +0000 [warn]: /usr/lib/ruby/2.4.0/net/http/header.rb:16:in `each'\r\n  2018-09-13 01:51:26 +0000 [warn]: /usr/lib/ruby/2.4.0/net/http/header.rb:16:in `initialize_http_header'\r\n  2018-09-13 01:51:26 +0000 [warn]: /usr/lib/ruby/2.4.0/net/http/generic_request.rb:44:in `initialize'\r\n  2018-09-13 01:51:26 +0000 [warn]: /usr/lib/ruby/2.4.0/net/http/request.rb:15:in `initialize'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:146:in `new'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:146:in `build_net_request'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:74:in `block in transmit'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:126:in `block in session'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/connection_pool.rb:100:in `session_for'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:121:in `session'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:73:in `transmit'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/net_http/handler.rb:47:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/plugins/content_length.rb:12:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/json/error_handler.rb:8:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/signature_v4.rb:66:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/helpful_socket_errors.rb:10:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/retry_errors.rb:138:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/json/handler.rb:11:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/user_agent.rb:13:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/plugins/endpoint.rb:45:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/param_validator.rb:24:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/plugins/raise_response_errors.rb:14:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/idempotency_token.rb:17:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/param_converter.rb:24:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/aws-sdk-core/plugins/response_paging.rb:10:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/plugins/response_target.rb:23:in `call'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-core-3.22.1/lib/seahorse/client/request.rb:70:in `send_request'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/aws-sdk-cloudwatchlogs-1.4.0/lib/aws-sdk-cloudwatchlogs/client.rb:736:in `describe_log_groups'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluent-plugin-cloudwatch-logs-0.4.5/lib/fluent/plugin/out_cloudwatch_logs.rb:403:in `log_group_exists?'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluent-plugin-cloudwatch-logs-0.4.5/lib/fluent/plugin/out_cloudwatch_logs.rb:152:in `block in write'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluent-plugin-cloudwatch-logs-0.4.5/lib/fluent/plugin/out_cloudwatch_logs.rb:144:in `each'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluent-plugin-cloudwatch-logs-0.4.5/lib/fluent/plugin/out_cloudwatch_logs.rb:144:in `write'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluentd-0.12.43/lib/fluent/buffer.rb:354:in `write_chunk'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluentd-0.12.43/lib/fluent/buffer.rb:333:in `pop'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluentd-0.12.43/lib/fluent/output.rb:342:in `try_flush'\r\n  2018-09-13 01:51:26 +0000 [warn]: /fluentd/vendor/bundle/ruby/2.4.0/gems/fluentd-0.12.43/lib/fluent/output.rb:149:in `run'\r\n```\r\n\r\ndump /usr/lib/ruby/2.4.0/net/http/header.rb:16 \"key: #{key}, value: #{value}\" \r\n```\r\n\"key: authorization, value: AWS4-HMAC-SHA256 Credential=<AWS_ACCESS_KEY_ID>\\n/20180913/ap-northeast-1/logs/aws4_request, SignedHeaders=content-type;host;x-amz-content-sha256;x-amz-date;x-amz-target, Signature=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\"\r\n```\r\nenv[\"AWS_ACCESS_KEY_ID\"] == \"<AWS_ACCESS_KEY_ID>\\n\"\r\n\r\n\r\n**Which issue this PR fixes** : \r\nThis is related to the issue helm/helm#3410\r\n\r\nfixes #5810\r\nfixes #4732\r\n\r\n\r\n**Special notes for your reviewer**:\r\n@jmcarp\r\n@icereval \r\n@kenden \r\n\r\nthank you!!"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/425103629","html_url":"https://github.com/helm/charts/pull/7707#issuecomment-425103629","issue_url":"https://api.github.com/repos/helm/charts/issues/7707","id":425103629,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTEwMzYyOQ==","user":{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T14:00:04Z","updated_at":"2018-09-27T14:00:04Z","author_association":"COLLABORATOR","body":"works locally\r\n\r\n/lgtm"}}
{"actor":{"display_login":"cpanato"}}