{"action":"created","issue":{"url":"https://api.github.com/repos/Starcounter/Images/issues/116","repository_url":"https://api.github.com/repos/Starcounter/Images","labels_url":"https://api.github.com/repos/Starcounter/Images/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/Starcounter/Images/issues/116/comments","events_url":"https://api.github.com/repos/Starcounter/Images/issues/116/events","html_url":"https://github.com/Starcounter/Images/pull/116","id":246879840,"number":116,"title":"C# mapping file separated from the app","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars0.githubusercontent.com/u/566463?v=4","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"alemoi","id":208134,"avatar_url":"https://avatars1.githubusercontent.com/u/208134?v=4","gravatar_id":"","url":"https://api.github.com/users/alemoi","html_url":"https://github.com/alemoi","followers_url":"https://api.github.com/users/alemoi/followers","following_url":"https://api.github.com/users/alemoi/following{/other_user}","gists_url":"https://api.github.com/users/alemoi/gists{/gist_id}","starred_url":"https://api.github.com/users/alemoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alemoi/subscriptions","organizations_url":"https://api.github.com/users/alemoi/orgs","repos_url":"https://api.github.com/users/alemoi/repos","events_url":"https://api.github.com/users/alemoi/events{/privacy}","received_events_url":"https://api.github.com/users/alemoi/received_events","type":"User","site_admin":false},"assignees":[{"login":"alemoi","id":208134,"avatar_url":"https://avatars1.githubusercontent.com/u/208134?v=4","gravatar_id":"","url":"https://api.github.com/users/alemoi","html_url":"https://github.com/alemoi","followers_url":"https://api.github.com/users/alemoi/followers","following_url":"https://api.github.com/users/alemoi/following{/other_user}","gists_url":"https://api.github.com/users/alemoi/gists{/gist_id}","starred_url":"https://api.github.com/users/alemoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alemoi/subscriptions","organizations_url":"https://api.github.com/users/alemoi/orgs","repos_url":"https://api.github.com/users/alemoi/repos","events_url":"https://api.github.com/users/alemoi/events{/privacy}","received_events_url":"https://api.github.com/users/alemoi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-07-31T20:49:55Z","updated_at":"2018-05-22T14:13:46Z","closed_at":"2018-05-22T14:13:46Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Starcounter/Images/pulls/116","html_url":"https://github.com/Starcounter/Images/pull/116","diff_url":"https://github.com/Starcounter/Images/pull/116.diff","patch_url":"https://github.com/Starcounter/Images/pull/116.patch"},"body":":construction: **work in progress**\r\n\r\nAs part of the blending discussion (https://github.com/Starcounter/RebelsLounge/issues/154 step 2), I have tried to separate the calls to `Blender.MapUri` from the app code. \r\n\r\n## The good \r\n\r\nStarcounter supports loading uncompiled single file C#.\r\n\r\nRun it using `star Images_Map.cs`\r\n\r\n## The bad\r\n\r\nIt requires starting the map C# file manually after starting the app actual app. \r\n\r\n## The ugly\r\n\r\nUnfortunately, the proposal in this PR currently doesn't work. That is because the syntax `Blender.MapUri<T>` requires the reference to the type. In case of this app, the type comes from Simplified DLL.\r\n\r\nAny proposals how to solve that?\r\n\r\nWe could either:\r\n\r\n1. Use the fully qualified name of the type as a string.\r\n2. Turn the mapping file into a compiled project instead of a single file.\r\n\r\nI am leaning towards 1.\r\n\r\n## Big question\r\n\r\nWould we be comfortable in applying this in all our prefab apps and asking our customers to do the same?\r\n\r\ncc @StarcounterApps/starcounter , @alemoi "},"comment":{"url":"https://api.github.com/repos/Starcounter/Images/issues/comments/391005950","html_url":"https://github.com/Starcounter/Images/pull/116#issuecomment-391005950","issue_url":"https://api.github.com/repos/Starcounter/Images/issues/116","id":391005950,"user":{"login":"alemoi","id":208134,"avatar_url":"https://avatars1.githubusercontent.com/u/208134?v=4","gravatar_id":"","url":"https://api.github.com/users/alemoi","html_url":"https://github.com/alemoi","followers_url":"https://api.github.com/users/alemoi/followers","following_url":"https://api.github.com/users/alemoi/following{/other_user}","gists_url":"https://api.github.com/users/alemoi/gists{/gist_id}","starred_url":"https://api.github.com/users/alemoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alemoi/subscriptions","organizations_url":"https://api.github.com/users/alemoi/orgs","repos_url":"https://api.github.com/users/alemoi/repos","events_url":"https://api.github.com/users/alemoi/events{/privacy}","received_events_url":"https://api.github.com/users/alemoi/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T14:13:46Z","updated_at":"2018-05-22T14:13:46Z","author_association":"CONTRIBUTOR","body":"I think this issue is a bit outdated. We decided that Blending should be declarative and not contain code. There is a working solution already with `blend.json` startup file: https://github.com/Starcounter/RebelsLounge/issues/154#issuecomment-348373966\r\nDocumented here: https://docs.starcounter.io/guides/blendable-web-apps/view-attaching#separate-blending-rules-in-json"}}
{"actor":{"display_login":"alemoi"}}