{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/168631468","pull_request_review_id":97032608,"id":168631468,"diff_hunk":"@@ -0,0 +1,134 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#include \"DataStructures/Tensor/Tensor.hpp\"\n+#include \"PointwiseFunctions/GeneralRelativity/Ricci.hpp\"\n+#include \"tests/Unit/PointwiseFunctions/GeneralRelativity/GrTestHelpers.hpp\"\n+#include \"tests/Unit/TestHelpers.hpp\"\n+\n+namespace {\n+void test_1d_spatial_ricci(const DataVector& used_for_size) {\n+  constexpr size_t spatial_dim = 1;\n+  const auto ricci = gr::ricci_tensor(\n+      make_spatial_christoffel_second_kind<spatial_dim>(0.),\n+      make_deriv_spatial_christoffel_second_kind<spatial_dim>(0.));\n+  CHECK(ricci.get(0, 0) == approx(0.));\n+\n+  check_tensor_doubles_equals_tensor_datavectors(","path":"tests/Unit/PointwiseFunctions/GeneralRelativity/Test_Ricci.cpp","position":17,"original_position":17,"commit_id":"a05063d79074c66b44edda28e925e11c99c8b119","original_commit_id":"a05063d79074c66b44edda28e925e11c99c8b119","user":{"login":"kidder","id":1264082,"avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"body":"rinse, repeat","created_at":"2018-02-15T22:43:40Z","updated_at":"2018-02-15T22:45:55Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/495#discussion_r168631468","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/168631468"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/495#discussion_r168631468"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495"}},"in_reply_to_id":168631429},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495","id":165286595,"html_url":"https://github.com/sxs-collaboration/spectre/pull/495","diff_url":"https://github.com/sxs-collaboration/spectre/pull/495.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/495.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/495","number":495,"state":"open","locked":false,"title":"Add code to compute Ricci tensor","user":{"login":"geoffrey4444","id":867015,"avatar_url":"https://avatars1.githubusercontent.com/u/867015?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffrey4444","html_url":"https://github.com/geoffrey4444","followers_url":"https://api.github.com/users/geoffrey4444/followers","following_url":"https://api.github.com/users/geoffrey4444/following{/other_user}","gists_url":"https://api.github.com/users/geoffrey4444/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffrey4444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffrey4444/subscriptions","organizations_url":"https://api.github.com/users/geoffrey4444/orgs","repos_url":"https://api.github.com/users/geoffrey4444/repos","events_url":"https://api.github.com/users/geoffrey4444/events{/privacy}","received_events_url":"https://api.github.com/users/geoffrey4444/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nThis pull request adds code in PointwiseFunctions/GeneralRelativity to compute the Ricci scalar from Christoffel2ndKind and its derivative. \r\n\r\nSupporting this functionality, I also do the following:\r\n\r\n  - Add necessary tensor aliases for derivatives of Christoffel2ndKind\r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] Follows [code review guidelines](https://sxs-collaboration.github.io/spectre/code_review_guide.html)\r\n- [ ] Code has documentation and unit tests\r\n- [ ] Private member variables have a trailing underscore\r\n- [ ] Do not use [Hungarian notation](https://en.wikipedia.org/wiki/Hungarian_notation), e.g. `double* pd_blah` is bad\r\n- [ ] Header order:\r\n  1. hpp corresponding to cpp (only in cpp files)\r\n  2. Blank line (only in cpp files)\r\n  3. STL and externals (in alphabetical order)\r\n  4. Blank line\r\n  5. SpECTRE includes (in alphabetical order)\r\n- [ ] File lists in CMake are alphabetical\r\n- [ ] Correct `noexcept` specification for functions (if unsure, mark `noexcept`)\r\n- [ ] Mark objects `const` whenever possible\r\n- [ ] Almost always `auto`, except with expression templates, i.e. `DataVector`\r\n- [ ] All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.\r\n- [ ] Make sure error messages are helpful, e.g. \"The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant.\"\r\n- [ ] Prefix commits addressing PR requests with `fixup`\r\n\r\n\r\n### Further comments\r\n\r\nI based my code for Ricci*pp on Christoffel*pp. Similarly, when I changed other files, I based my changes on prior functionality.","created_at":"2018-01-26T04:04:16Z","updated_at":"2018-02-15T22:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2087cacf5eef7062157e8c0b54e5accae07b6c14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/495/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a05063d79074c66b44edda28e925e11c99c8b119","head":{"label":"geoffrey4444:curvature","ref":"curvature","sha":"a05063d79074c66b44edda28e925e11c99c8b119","user":{"login":"geoffrey4444","id":867015,"avatar_url":"https://avatars1.githubusercontent.com/u/867015?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffrey4444","html_url":"https://github.com/geoffrey4444","followers_url":"https://api.github.com/users/geoffrey4444/followers","following_url":"https://api.github.com/users/geoffrey4444/following{/other_user}","gists_url":"https://api.github.com/users/geoffrey4444/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffrey4444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffrey4444/subscriptions","organizations_url":"https://api.github.com/users/geoffrey4444/orgs","repos_url":"https://api.github.com/users/geoffrey4444/repos","events_url":"https://api.github.com/users/geoffrey4444/events{/privacy}","received_events_url":"https://api.github.com/users/geoffrey4444/received_events","type":"User","site_admin":false},"repo":{"id":107001957,"name":"spectre","full_name":"geoffrey4444/spectre","owner":{"login":"geoffrey4444","id":867015,"avatar_url":"https://avatars1.githubusercontent.com/u/867015?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffrey4444","html_url":"https://github.com/geoffrey4444","followers_url":"https://api.github.com/users/geoffrey4444/followers","following_url":"https://api.github.com/users/geoffrey4444/following{/other_user}","gists_url":"https://api.github.com/users/geoffrey4444/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffrey4444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffrey4444/subscriptions","organizations_url":"https://api.github.com/users/geoffrey4444/orgs","repos_url":"https://api.github.com/users/geoffrey4444/repos","events_url":"https://api.github.com/users/geoffrey4444/events{/privacy}","received_events_url":"https://api.github.com/users/geoffrey4444/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geoffrey4444/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/geoffrey4444/spectre","forks_url":"https://api.github.com/repos/geoffrey4444/spectre/forks","keys_url":"https://api.github.com/repos/geoffrey4444/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoffrey4444/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoffrey4444/spectre/teams","hooks_url":"https://api.github.com/repos/geoffrey4444/spectre/hooks","issue_events_url":"https://api.github.com/repos/geoffrey4444/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/geoffrey4444/spectre/events","assignees_url":"https://api.github.com/repos/geoffrey4444/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/geoffrey4444/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/geoffrey4444/spectre/tags","blobs_url":"https://api.github.com/repos/geoffrey4444/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoffrey4444/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoffrey4444/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoffrey4444/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoffrey4444/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/geoffrey4444/spectre/languages","stargazers_url":"https://api.github.com/repos/geoffrey4444/spectre/stargazers","contributors_url":"https://api.github.com/repos/geoffrey4444/spectre/contributors","subscribers_url":"https://api.github.com/repos/geoffrey4444/spectre/subscribers","subscription_url":"https://api.github.com/repos/geoffrey4444/spectre/subscription","commits_url":"https://api.github.com/repos/geoffrey4444/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoffrey4444/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoffrey4444/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoffrey4444/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoffrey4444/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/geoffrey4444/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoffrey4444/spectre/merges","archive_url":"https://api.github.com/repos/geoffrey4444/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoffrey4444/spectre/downloads","issues_url":"https://api.github.com/repos/geoffrey4444/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/geoffrey4444/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/geoffrey4444/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/geoffrey4444/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoffrey4444/spectre/labels{/name}","releases_url":"https://api.github.com/repos/geoffrey4444/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/geoffrey4444/spectre/deployments","created_at":"2017-10-15T10:19:27Z","updated_at":"2017-10-15T10:19:29Z","pushed_at":"2018-02-15T01:34:42Z","git_url":"git://github.com/geoffrey4444/spectre.git","ssh_url":"git@github.com:geoffrey4444/spectre.git","clone_url":"https://github.com/geoffrey4444/spectre.git","svn_url":"https://github.com/geoffrey4444/spectre","homepage":null,"size":5207,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"3f4b4d0c18bb13e87014cea7ea961827340ec465","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-02-14T23:05:42Z","pushed_at":"2018-02-15T17:25:54Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":7479,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":79,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/495"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/495"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a05063d79074c66b44edda28e925e11c99c8b119"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kidder"}}