{"action":"created","comment":{"url":"https://api.github.com/repos/metabrainz/picard/pulls/comments/206646662","pull_request_review_id":142099684,"id":206646662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY0NjY2Mg==","diff_hunk":"@@ -357,7 +357,7 @@ def sorttracknum(item):\n             try:\n                 return int(item.tracknumber)\n             except:\n-                return item.tracknumber\n+                return item.tracknumber or 0","path":"picard/ui/infodialog.py","position":5,"original_position":5,"commit_id":"8e41abe1d81b019dadad60ec20af5ec6124b774c","original_commit_id":"8e41abe1d81b019dadad60ec20af5ec6124b774c","user":{"login":"samj1912","id":16130816,"node_id":"MDQ6VXNlcjE2MTMwODE2","avatar_url":"https://avatars1.githubusercontent.com/u/16130816?v=4","gravatar_id":"","url":"https://api.github.com/users/samj1912","html_url":"https://github.com/samj1912","followers_url":"https://api.github.com/users/samj1912/followers","following_url":"https://api.github.com/users/samj1912/following{/other_user}","gists_url":"https://api.github.com/users/samj1912/gists{/gist_id}","starred_url":"https://api.github.com/users/samj1912/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samj1912/subscriptions","organizations_url":"https://api.github.com/users/samj1912/orgs","repos_url":"https://api.github.com/users/samj1912/repos","events_url":"https://api.github.com/users/samj1912/events{/privacy}","received_events_url":"https://api.github.com/users/samj1912/received_events","type":"User","site_admin":false},"body":"Cant we directly return 0 here?","created_at":"2018-07-31T19:00:17Z","updated_at":"2018-07-31T19:00:17Z","html_url":"https://github.com/metabrainz/picard/pull/915#discussion_r206646662","pull_request_url":"https://api.github.com/repos/metabrainz/picard/pulls/915","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/comments/206646662"},"html":{"href":"https://github.com/metabrainz/picard/pull/915#discussion_r206646662"},"pull_request":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/915"}}},"pull_request":{"url":"https://api.github.com/repos/metabrainz/picard/pulls/915","id":205079536,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDc5NTM2","html_url":"https://github.com/metabrainz/picard/pull/915","diff_url":"https://github.com/metabrainz/picard/pull/915.diff","patch_url":"https://github.com/metabrainz/picard/pull/915.patch","issue_url":"https://api.github.com/repos/metabrainz/picard/issues/915","number":915,"state":"open","locked":false,"title":"PICARD-1302, PICARD-1303, PICARD-1304: Fix crashes","user":{"login":"antlarr","id":4385446,"node_id":"MDQ6VXNlcjQzODU0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4385446?v=4","gravatar_id":"","url":"https://api.github.com/users/antlarr","html_url":"https://github.com/antlarr","followers_url":"https://api.github.com/users/antlarr/followers","following_url":"https://api.github.com/users/antlarr/following{/other_user}","gists_url":"https://api.github.com/users/antlarr/gists{/gist_id}","starred_url":"https://api.github.com/users/antlarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlarr/subscriptions","organizations_url":"https://api.github.com/users/antlarr/orgs","repos_url":"https://api.github.com/users/antlarr/repos","events_url":"https://api.github.com/users/antlarr/events{/privacy}","received_events_url":"https://api.github.com/users/antlarr/received_events","type":"User","site_admin":false},"body":"# Summary\r\n\r\nFix two crashes.\r\n\r\n* This is a…\r\n    * [x] Bug fix\r\n    * [ ] Feature addition\r\n    * [ ] Refactoring\r\n    * [ ] Minor / simple change (like a typo)\r\n    * [ ] Other\r\n* **Describe this change in 1-2 sentences**:\r\n\r\n# Problem\r\n\r\n- Fix crash when using drag&drop from Google Images to the coverartbox widget due to code not being fully ported from Qt4 to Qt5.\r\n- Fix crash due to KeyError exceptions when trying to match a cluster with a release that doesn't have any track in musicbrainz.\r\n- Fix crash when a cluster has a file with track number and a file without any track number information and the user opens the info dialog on the cluster.\r\n\r\n# Solution\r\n\r\n- Ported code to Qt5\r\n- Catch and handle exceptions properly\r\n- Treat files with no track number as having track number 0.","created_at":"2018-07-31T11:22:52Z","updated_at":"2018-07-31T19:00:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e3036d82790a98c0124caacb4d8ecd66974848b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metabrainz/picard/pulls/915/commits","review_comments_url":"https://api.github.com/repos/metabrainz/picard/pulls/915/comments","review_comment_url":"https://api.github.com/repos/metabrainz/picard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabrainz/picard/issues/915/comments","statuses_url":"https://api.github.com/repos/metabrainz/picard/statuses/8e41abe1d81b019dadad60ec20af5ec6124b774c","head":{"label":"antlarr:fix-crashes","ref":"fix-crashes","sha":"8e41abe1d81b019dadad60ec20af5ec6124b774c","user":{"login":"antlarr","id":4385446,"node_id":"MDQ6VXNlcjQzODU0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4385446?v=4","gravatar_id":"","url":"https://api.github.com/users/antlarr","html_url":"https://github.com/antlarr","followers_url":"https://api.github.com/users/antlarr/followers","following_url":"https://api.github.com/users/antlarr/following{/other_user}","gists_url":"https://api.github.com/users/antlarr/gists{/gist_id}","starred_url":"https://api.github.com/users/antlarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlarr/subscriptions","organizations_url":"https://api.github.com/users/antlarr/orgs","repos_url":"https://api.github.com/users/antlarr/repos","events_url":"https://api.github.com/users/antlarr/events{/privacy}","received_events_url":"https://api.github.com/users/antlarr/received_events","type":"User","site_admin":false},"repo":{"id":81325899,"node_id":"MDEwOlJlcG9zaXRvcnk4MTMyNTg5OQ==","name":"picard","full_name":"antlarr/picard","owner":{"login":"antlarr","id":4385446,"node_id":"MDQ6VXNlcjQzODU0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4385446?v=4","gravatar_id":"","url":"https://api.github.com/users/antlarr","html_url":"https://github.com/antlarr","followers_url":"https://api.github.com/users/antlarr/followers","following_url":"https://api.github.com/users/antlarr/following{/other_user}","gists_url":"https://api.github.com/users/antlarr/gists{/gist_id}","starred_url":"https://api.github.com/users/antlarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlarr/subscriptions","organizations_url":"https://api.github.com/users/antlarr/orgs","repos_url":"https://api.github.com/users/antlarr/repos","events_url":"https://api.github.com/users/antlarr/events{/privacy}","received_events_url":"https://api.github.com/users/antlarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antlarr/picard","description":"MusicBrainz Picard","fork":true,"url":"https://api.github.com/repos/antlarr/picard","forks_url":"https://api.github.com/repos/antlarr/picard/forks","keys_url":"https://api.github.com/repos/antlarr/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antlarr/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antlarr/picard/teams","hooks_url":"https://api.github.com/repos/antlarr/picard/hooks","issue_events_url":"https://api.github.com/repos/antlarr/picard/issues/events{/number}","events_url":"https://api.github.com/repos/antlarr/picard/events","assignees_url":"https://api.github.com/repos/antlarr/picard/assignees{/user}","branches_url":"https://api.github.com/repos/antlarr/picard/branches{/branch}","tags_url":"https://api.github.com/repos/antlarr/picard/tags","blobs_url":"https://api.github.com/repos/antlarr/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antlarr/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antlarr/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/antlarr/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antlarr/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/antlarr/picard/languages","stargazers_url":"https://api.github.com/repos/antlarr/picard/stargazers","contributors_url":"https://api.github.com/repos/antlarr/picard/contributors","subscribers_url":"https://api.github.com/repos/antlarr/picard/subscribers","subscription_url":"https://api.github.com/repos/antlarr/picard/subscription","commits_url":"https://api.github.com/repos/antlarr/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/antlarr/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/antlarr/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/antlarr/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/antlarr/picard/contents/{+path}","compare_url":"https://api.github.com/repos/antlarr/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antlarr/picard/merges","archive_url":"https://api.github.com/repos/antlarr/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antlarr/picard/downloads","issues_url":"https://api.github.com/repos/antlarr/picard/issues{/number}","pulls_url":"https://api.github.com/repos/antlarr/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/antlarr/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/antlarr/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antlarr/picard/labels{/name}","releases_url":"https://api.github.com/repos/antlarr/picard/releases{/id}","deployments_url":"https://api.github.com/repos/antlarr/picard/deployments","created_at":"2017-02-08T12:05:45Z","updated_at":"2018-07-31T10:49:51Z","pushed_at":"2018-07-31T16:28:23Z","git_url":"git://github.com/antlarr/picard.git","ssh_url":"git@github.com:antlarr/picard.git","clone_url":"https://github.com/antlarr/picard.git","svn_url":"https://github.com/antlarr/picard","homepage":"https://picard.musicbrainz.org","size":27325,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metabrainz:master","ref":"master","sha":"f93f8380bf48d5d5bf97ae2b3055712193613e13","user":{"login":"metabrainz","id":293421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzQyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/293421?v=4","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"repo":{"id":2218679,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE4Njc5","name":"picard","full_name":"metabrainz/picard","owner":{"login":"metabrainz","id":293421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzQyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/293421?v=4","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabrainz/picard","description":"MusicBrainz Picard","fork":false,"url":"https://api.github.com/repos/metabrainz/picard","forks_url":"https://api.github.com/repos/metabrainz/picard/forks","keys_url":"https://api.github.com/repos/metabrainz/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabrainz/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabrainz/picard/teams","hooks_url":"https://api.github.com/repos/metabrainz/picard/hooks","issue_events_url":"https://api.github.com/repos/metabrainz/picard/issues/events{/number}","events_url":"https://api.github.com/repos/metabrainz/picard/events","assignees_url":"https://api.github.com/repos/metabrainz/picard/assignees{/user}","branches_url":"https://api.github.com/repos/metabrainz/picard/branches{/branch}","tags_url":"https://api.github.com/repos/metabrainz/picard/tags","blobs_url":"https://api.github.com/repos/metabrainz/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabrainz/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabrainz/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabrainz/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabrainz/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/metabrainz/picard/languages","stargazers_url":"https://api.github.com/repos/metabrainz/picard/stargazers","contributors_url":"https://api.github.com/repos/metabrainz/picard/contributors","subscribers_url":"https://api.github.com/repos/metabrainz/picard/subscribers","subscription_url":"https://api.github.com/repos/metabrainz/picard/subscription","commits_url":"https://api.github.com/repos/metabrainz/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabrainz/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabrainz/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabrainz/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabrainz/picard/contents/{+path}","compare_url":"https://api.github.com/repos/metabrainz/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabrainz/picard/merges","archive_url":"https://api.github.com/repos/metabrainz/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabrainz/picard/downloads","issues_url":"https://api.github.com/repos/metabrainz/picard/issues{/number}","pulls_url":"https://api.github.com/repos/metabrainz/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/metabrainz/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/metabrainz/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabrainz/picard/labels{/name}","releases_url":"https://api.github.com/repos/metabrainz/picard/releases{/id}","deployments_url":"https://api.github.com/repos/metabrainz/picard/deployments","created_at":"2011-08-16T22:30:23Z","updated_at":"2018-07-30T12:07:46Z","pushed_at":"2018-07-31T16:28:25Z","git_url":"git://github.com/metabrainz/picard.git","ssh_url":"git@github.com:metabrainz/picard.git","clone_url":"https://github.com/metabrainz/picard.git","svn_url":"https://github.com/metabrainz/picard","homepage":"https://picard.musicbrainz.org","size":27323,"stargazers_count":1493,"watchers_count":1493,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":239,"open_issues":7,"watchers":1493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/915"},"html":{"href":"https://github.com/metabrainz/picard/pull/915"},"issue":{"href":"https://api.github.com/repos/metabrainz/picard/issues/915"},"comments":{"href":"https://api.github.com/repos/metabrainz/picard/issues/915/comments"},"review_comments":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/915/comments"},"review_comment":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabrainz/picard/pulls/915/commits"},"statuses":{"href":"https://api.github.com/repos/metabrainz/picard/statuses/8e41abe1d81b019dadad60ec20af5ec6124b774c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samj1912"}}