{"action":"created","issue":{"url":"https://api.github.com/repos/prestodb/presto/issues/12049","repository_url":"https://api.github.com/repos/prestodb/presto","labels_url":"https://api.github.com/repos/prestodb/presto/issues/12049/labels{/name}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/12049/comments","events_url":"https://api.github.com/repos/prestodb/presto/issues/12049/events","html_url":"https://github.com/prestodb/presto/issues/12049","id":389896885,"node_id":"MDU6SXNzdWUzODk4OTY4ODU=","number":12049,"title":"Verifier: sort arrays before comparing","user":{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"labels":[{"id":1158098121,"node_id":"MDU6TGFiZWwxMTU4MDk4MTIx","url":"https://api.github.com/repos/prestodb/presto/labels/verifier","name":"verifier","color":"fcffba","default":false}],"state":"open","locked":false,"assignee":{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-11T18:32:04Z","updated_at":"2018-12-12T01:17:35Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"To avoid false positives when comparing query results Verifier rounds floating point values: `checksum(round(c, 3))`. Similar technique is necessary for array types to avoid flagging arrays that differ only in the order of the elements. E.g. Verifier should use `checksum(array_sort(c))` instead of `checksum(c)`.\r\n\r\nCC: @nezihyigitbasi @ggreg @zaynoon"},"comment":{"url":"https://api.github.com/repos/prestodb/presto/issues/comments/446424899","html_url":"https://github.com/prestodb/presto/issues/12049#issuecomment-446424899","issue_url":"https://api.github.com/repos/prestodb/presto/issues/12049","id":446424899,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQyNDg5OQ==","user":{"login":"rongrong","id":1448363,"node_id":"MDQ6VXNlcjE0NDgzNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1448363?v=4","gravatar_id":"","url":"https://api.github.com/users/rongrong","html_url":"https://github.com/rongrong","followers_url":"https://api.github.com/users/rongrong/followers","following_url":"https://api.github.com/users/rongrong/following{/other_user}","gists_url":"https://api.github.com/users/rongrong/gists{/gist_id}","starred_url":"https://api.github.com/users/rongrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongrong/subscriptions","organizations_url":"https://api.github.com/users/rongrong/orgs","repos_url":"https://api.github.com/users/rongrong/repos","events_url":"https://api.github.com/users/rongrong/events{/privacy}","received_events_url":"https://api.github.com/users/rongrong/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T01:17:35Z","updated_at":"2018-12-12T01:17:35Z","author_association":"CONTRIBUTOR","body":"The problem with only compute a checksum for sorted array is it might hide errors. When the expected output should be ordered and the checksum does not match without sorting, it's actually a correctness issue that would be hidden if you only report the sorted checksum. Unless we could know from analyzing the query whether the result should be ordered, we can not safely assume `array_sort(a)` is equivalent to `a`."}}
{"actor":{"display_login":"rongrong"}}