{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/12879","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/12879/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/12879/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/12879/events","html_url":"https://github.com/magento/magento2/pull/12879","id":284473270,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYwMDcwODAx","number":12879,"title":"Fix issue #12866: Can't Disable Advanced Reporting","user":{"login":"nfourteen","id":14304240,"node_id":"MDQ6VXNlcjE0MzA0MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/14304240?v=4","gravatar_id":"","url":"https://api.github.com/users/nfourteen","html_url":"https://github.com/nfourteen","followers_url":"https://api.github.com/users/nfourteen/followers","following_url":"https://api.github.com/users/nfourteen/following{/other_user}","gists_url":"https://api.github.com/users/nfourteen/gists{/gist_id}","starred_url":"https://api.github.com/users/nfourteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfourteen/subscriptions","organizations_url":"https://api.github.com/users/nfourteen/orgs","repos_url":"https://api.github.com/users/nfourteen/repos","events_url":"https://api.github.com/users/nfourteen/events{/privacy}","received_events_url":"https://api.github.com/users/nfourteen/received_events","type":"User","site_admin":false},"labels":[{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false},{"id":686477126,"node_id":"MDU6TGFiZWw2ODY0NzcxMjY=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.2.x","name":"Reproduced on 2.2.x","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"VladimirZaets","id":8035672,"node_id":"MDQ6VXNlcjgwMzU2NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/8035672?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirZaets","html_url":"https://github.com/VladimirZaets","followers_url":"https://api.github.com/users/VladimirZaets/followers","following_url":"https://api.github.com/users/VladimirZaets/following{/other_user}","gists_url":"https://api.github.com/users/VladimirZaets/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirZaets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirZaets/subscriptions","organizations_url":"https://api.github.com/users/VladimirZaets/orgs","repos_url":"https://api.github.com/users/VladimirZaets/repos","events_url":"https://api.github.com/users/VladimirZaets/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirZaets/received_events","type":"User","site_admin":false},"assignees":[{"login":"VladimirZaets","id":8035672,"node_id":"MDQ6VXNlcjgwMzU2NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/8035672?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirZaets","html_url":"https://github.com/VladimirZaets","followers_url":"https://api.github.com/users/VladimirZaets/followers","following_url":"https://api.github.com/users/VladimirZaets/following{/other_user}","gists_url":"https://api.github.com/users/VladimirZaets/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirZaets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirZaets/subscriptions","organizations_url":"https://api.github.com/users/VladimirZaets/orgs","repos_url":"https://api.github.com/users/VladimirZaets/repos","events_url":"https://api.github.com/users/VladimirZaets/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirZaets/received_events","type":"User","site_admin":false},{"login":"slavvka","id":9741905,"node_id":"MDQ6VXNlcjk3NDE5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/9741905?v=4","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-12-25T23:17:32Z","updated_at":"2018-10-19T18:15:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/12879","html_url":"https://github.com/magento/magento2/pull/12879","diff_url":"https://github.com/magento/magento2/pull/12879.diff","patch_url":"https://github.com/magento/magento2/pull/12879.patch"},"body":"### Description\r\n\r\nDisable Magento_Analytics (aka Advanced Reporting) by default and provide clearer message if an industry is not provided.\r\n\r\n### Fixed Issues (if relevant)\r\n\r\n1. [magento/magento2#12866](https://github.com/magento/magento2/issues/12866): Can't Disable Advanced Reporting\r\n\r\n\r\n### Manual testing scenarios\r\n\r\n1. Install new Magento 2.2 instance and `Stores > Configuration > General > Advanced Reporting > Advanced Reporting Service` should be set to Disable after install\r\n2. Go to `Stores > Configuration > General > Advanced Reporting` and change **Advanced Reporting Service** to Enable/Disable and press **Save Config**. If an **Industry** is not provided, then the `Please select an industry.` error message is shown rather than `Please select a vertical.` \r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/431452089","html_url":"https://github.com/magento/magento2/pull/12879#issuecomment-431452089","issue_url":"https://api.github.com/repos/magento/magento2/issues/12879","id":431452089,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQ1MjA4OQ==","user":{"login":"nfourteen","id":14304240,"node_id":"MDQ6VXNlcjE0MzA0MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/14304240?v=4","gravatar_id":"","url":"https://api.github.com/users/nfourteen","html_url":"https://github.com/nfourteen","followers_url":"https://api.github.com/users/nfourteen/followers","following_url":"https://api.github.com/users/nfourteen/following{/other_user}","gists_url":"https://api.github.com/users/nfourteen/gists{/gist_id}","starred_url":"https://api.github.com/users/nfourteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfourteen/subscriptions","organizations_url":"https://api.github.com/users/nfourteen/orgs","repos_url":"https://api.github.com/users/nfourteen/repos","events_url":"https://api.github.com/users/nfourteen/events{/privacy}","received_events_url":"https://api.github.com/users/nfourteen/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T18:15:20Z","updated_at":"2018-10-19T18:15:20Z","author_association":"CONTRIBUTOR","body":"@slavvka This is a Magento core problem and an issue that needs to be fixed. However, since it's a Magento problem, I don't know how the PM wants to proceed. So, I'd be happy to fix Magento core code, but I need some direction as to which way Magento would like to proceed. Please stop closing this PR because it is a issue that needs to be resolved.\r\n\r\nPlease have the PM review issue [#12866](https://github.com/magento/magento2/issues/12866) and advise which proposed solution should would be acceptable or if another solution is desired. "}}
{"actor":{"display_login":"nfourteen"}}