{"action":"created","comment":{"url":"https://api.github.com/repos/EOSIO/fc/pulls/comments/211057016","pull_request_review_id":147410882,"id":211057016,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA1NzAxNg==","diff_hunk":"@@ -350,10 +376,45 @@ class http_client_impl {\n       return result;\n    }\n \n+   /*\n+      Unix URLs work a little special here. They'll originally be in the format of\n+      unix:///home/spoonincode/eosio-wallet/keosd.sock/v1/wallet/sign_digest\n+      for example. When the fc::url is given to http_client in post_sync(), this will\n+      have proto=unix and host=/home/spoonincode/eosio-wallet/keosd.sock/v1/wallet/sign_digest","path":"src/network/http/http_client.cpp","position":76,"original_position":76,"commit_id":"7101626c715a1c88fee83043bd4c5fa1ccb95751","original_commit_id":"7101626c715a1c88fee83043bd4c5fa1ccb95751","user":{"login":"jgiszczak","id":15825116,"node_id":"MDQ6VXNlcjE1ODI1MTE2","avatar_url":"https://avatars2.githubusercontent.com/u/15825116?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiszczak","html_url":"https://github.com/jgiszczak","followers_url":"https://api.github.com/users/jgiszczak/followers","following_url":"https://api.github.com/users/jgiszczak/following{/other_user}","gists_url":"https://api.github.com/users/jgiszczak/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiszczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiszczak/subscriptions","organizations_url":"https://api.github.com/users/jgiszczak/orgs","repos_url":"https://api.github.com/users/jgiszczak/repos","events_url":"https://api.github.com/users/jgiszczak/events{/privacy}","received_events_url":"https://api.github.com/users/jgiszczak/received_events","type":"User","site_admin":false},"body":"In the context of Github, it obviously is an example.  In bare source code, I didn't think it was completely obvious that 'spoonincode' is someone's username.\r\n\r\n`host=/home/username/eosio-wallet/keosd.sock/v1/wallet/sign_digest` is more generic.  Likewise for two lines above.","created_at":"2018-08-18T00:11:04Z","updated_at":"2018-08-18T00:11:04Z","html_url":"https://github.com/EOSIO/fc/pull/12#discussion_r211057016","pull_request_url":"https://api.github.com/repos/EOSIO/fc/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/comments/211057016"},"html":{"href":"https://github.com/EOSIO/fc/pull/12#discussion_r211057016"},"pull_request":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/12"}},"in_reply_to_id":210988427},"pull_request":{"url":"https://api.github.com/repos/EOSIO/fc/pulls/12","id":208667591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjY3NTkx","html_url":"https://github.com/EOSIO/fc/pull/12","diff_url":"https://github.com/EOSIO/fc/pull/12.diff","patch_url":"https://github.com/EOSIO/fc/pull/12.patch","issue_url":"https://api.github.com/repos/EOSIO/fc/issues/12","number":12,"state":"open","locked":false,"title":"A handful of fc changes to support unix sockets for HTTP RPC","user":{"login":"spoonincode","id":32485495,"node_id":"MDQ6VXNlcjMyNDg1NDk1","avatar_url":"https://avatars0.githubusercontent.com/u/32485495?v=4","gravatar_id":"","url":"https://api.github.com/users/spoonincode","html_url":"https://github.com/spoonincode","followers_url":"https://api.github.com/users/spoonincode/followers","following_url":"https://api.github.com/users/spoonincode/following{/other_user}","gists_url":"https://api.github.com/users/spoonincode/gists{/gist_id}","starred_url":"https://api.github.com/users/spoonincode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spoonincode/subscriptions","organizations_url":"https://api.github.com/users/spoonincode/orgs","repos_url":"https://api.github.com/users/spoonincode/repos","events_url":"https://api.github.com/users/spoonincode/events{/privacy}","received_events_url":"https://api.github.com/users/spoonincode/received_events","type":"User","site_admin":false},"body":"This PR includes the handful of changes I made to fc to support unix socket endpoints for HTTP RPC between keosd & cleos/nodeos. Most of these are pretty straightforward so I'd recommend reading each commit piecemeal.","created_at":"2018-08-15T20:09:45Z","updated_at":"2018-08-18T00:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65bc2e0fdc1e97c2322a6419211db83261567959","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EOSIO/fc/pulls/12/commits","review_comments_url":"https://api.github.com/repos/EOSIO/fc/pulls/12/comments","review_comment_url":"https://api.github.com/repos/EOSIO/fc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EOSIO/fc/issues/12/comments","statuses_url":"https://api.github.com/repos/EOSIO/fc/statuses/7101626c715a1c88fee83043bd4c5fa1ccb95751","head":{"label":"EOSIO:unix_socket_fc_changes","ref":"unix_socket_fc_changes","sha":"7101626c715a1c88fee83043bd4c5fa1ccb95751","user":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":136088403,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODg0MDM=","name":"fc","full_name":"EOSIO/fc","owner":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EOSIO/fc","description":null,"fork":false,"url":"https://api.github.com/repos/EOSIO/fc","forks_url":"https://api.github.com/repos/EOSIO/fc/forks","keys_url":"https://api.github.com/repos/EOSIO/fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/fc/teams","hooks_url":"https://api.github.com/repos/EOSIO/fc/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/fc/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/fc/events","assignees_url":"https://api.github.com/repos/EOSIO/fc/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/fc/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/fc/tags","blobs_url":"https://api.github.com/repos/EOSIO/fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/fc/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/fc/languages","stargazers_url":"https://api.github.com/repos/EOSIO/fc/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/fc/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/fc/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/fc/subscription","commits_url":"https://api.github.com/repos/EOSIO/fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/fc/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/fc/merges","archive_url":"https://api.github.com/repos/EOSIO/fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/fc/downloads","issues_url":"https://api.github.com/repos/EOSIO/fc/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/fc/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/fc/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/fc/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/fc/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/fc/deployments","created_at":"2018-06-04T22:10:24Z","updated_at":"2018-08-17T18:49:03Z","pushed_at":"2018-08-17T18:49:04Z","git_url":"git://github.com/EOSIO/fc.git","ssh_url":"git@github.com:EOSIO/fc.git","clone_url":"https://github.com/EOSIO/fc.git","svn_url":"https://github.com/EOSIO/fc","homepage":null,"size":920,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":5,"watchers":13,"default_branch":"master"}},"base":{"label":"EOSIO:master","ref":"master","sha":"a6b2756b100098296f7548a191e6210e770b7b3a","user":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"repo":{"id":136088403,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODg0MDM=","name":"fc","full_name":"EOSIO/fc","owner":{"login":"EOSIO","id":26932212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/26932212?v=4","gravatar_id":"","url":"https://api.github.com/users/EOSIO","html_url":"https://github.com/EOSIO","followers_url":"https://api.github.com/users/EOSIO/followers","following_url":"https://api.github.com/users/EOSIO/following{/other_user}","gists_url":"https://api.github.com/users/EOSIO/gists{/gist_id}","starred_url":"https://api.github.com/users/EOSIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EOSIO/subscriptions","organizations_url":"https://api.github.com/users/EOSIO/orgs","repos_url":"https://api.github.com/users/EOSIO/repos","events_url":"https://api.github.com/users/EOSIO/events{/privacy}","received_events_url":"https://api.github.com/users/EOSIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EOSIO/fc","description":null,"fork":false,"url":"https://api.github.com/repos/EOSIO/fc","forks_url":"https://api.github.com/repos/EOSIO/fc/forks","keys_url":"https://api.github.com/repos/EOSIO/fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EOSIO/fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EOSIO/fc/teams","hooks_url":"https://api.github.com/repos/EOSIO/fc/hooks","issue_events_url":"https://api.github.com/repos/EOSIO/fc/issues/events{/number}","events_url":"https://api.github.com/repos/EOSIO/fc/events","assignees_url":"https://api.github.com/repos/EOSIO/fc/assignees{/user}","branches_url":"https://api.github.com/repos/EOSIO/fc/branches{/branch}","tags_url":"https://api.github.com/repos/EOSIO/fc/tags","blobs_url":"https://api.github.com/repos/EOSIO/fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EOSIO/fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EOSIO/fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/EOSIO/fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EOSIO/fc/statuses/{sha}","languages_url":"https://api.github.com/repos/EOSIO/fc/languages","stargazers_url":"https://api.github.com/repos/EOSIO/fc/stargazers","contributors_url":"https://api.github.com/repos/EOSIO/fc/contributors","subscribers_url":"https://api.github.com/repos/EOSIO/fc/subscribers","subscription_url":"https://api.github.com/repos/EOSIO/fc/subscription","commits_url":"https://api.github.com/repos/EOSIO/fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/EOSIO/fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/EOSIO/fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/EOSIO/fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/EOSIO/fc/contents/{+path}","compare_url":"https://api.github.com/repos/EOSIO/fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EOSIO/fc/merges","archive_url":"https://api.github.com/repos/EOSIO/fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EOSIO/fc/downloads","issues_url":"https://api.github.com/repos/EOSIO/fc/issues{/number}","pulls_url":"https://api.github.com/repos/EOSIO/fc/pulls{/number}","milestones_url":"https://api.github.com/repos/EOSIO/fc/milestones{/number}","notifications_url":"https://api.github.com/repos/EOSIO/fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EOSIO/fc/labels{/name}","releases_url":"https://api.github.com/repos/EOSIO/fc/releases{/id}","deployments_url":"https://api.github.com/repos/EOSIO/fc/deployments","created_at":"2018-06-04T22:10:24Z","updated_at":"2018-08-17T18:49:03Z","pushed_at":"2018-08-17T18:49:04Z","git_url":"git://github.com/EOSIO/fc.git","ssh_url":"git@github.com:EOSIO/fc.git","clone_url":"https://github.com/EOSIO/fc.git","svn_url":"https://github.com/EOSIO/fc","homepage":null,"size":920,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/12"},"html":{"href":"https://github.com/EOSIO/fc/pull/12"},"issue":{"href":"https://api.github.com/repos/EOSIO/fc/issues/12"},"comments":{"href":"https://api.github.com/repos/EOSIO/fc/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EOSIO/fc/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/EOSIO/fc/statuses/7101626c715a1c88fee83043bd4c5fa1ccb95751"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jgiszczak"}}