{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/224943406","pull_request_review_id":164443991,"id":224943406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk0MzQwNg==","diff_hunk":"@@ -381,7 +441,7 @@ void CSGShape::_notification(int p_what) {\n \t\t\tparent->_make_dirty();\n \t\tparent = NULL;\n \n-\t\tif (use_collision && is_root_shape()) {\n+\t\tif (use_collision && is_root_shape() && root_collision_instance.is_valid()) {","path":"modules/csg/csg_shape.cpp","position":91,"original_position":91,"commit_id":"7eeb4bbd455aa45a3ed63bb653951ac079cbfe65","original_commit_id":"7eeb4bbd455aa45a3ed63bb653951ac079cbfe65","user":{"login":"cyclopsian","id":43323938,"node_id":"MDQ6VXNlcjQzMzIzOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/43323938?v=4","gravatar_id":"","url":"https://api.github.com/users/cyclopsian","html_url":"https://github.com/cyclopsian","followers_url":"https://api.github.com/users/cyclopsian/followers","following_url":"https://api.github.com/users/cyclopsian/following{/other_user}","gists_url":"https://api.github.com/users/cyclopsian/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclopsian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclopsian/subscriptions","organizations_url":"https://api.github.com/users/cyclopsian/orgs","repos_url":"https://api.github.com/users/cyclopsian/repos","events_url":"https://api.github.com/users/cyclopsian/events{/privacy}","received_events_url":"https://api.github.com/users/cyclopsian/received_events","type":"User","site_admin":false},"body":"Fixes a separate issue with a NULL free error that could happen when a CSG shape with use_collision enabled was moved inside another shape:\r\n\r\n```\r\nERROR: free: Invalid ID\r\n   At: modules/bullet/bullet_physics_server.cpp:1536\r\n```","created_at":"2018-10-13T00:37:33Z","updated_at":"2018-10-13T00:37:33Z","html_url":"https://github.com/godotengine/godot/pull/22973#discussion_r224943406","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/22973","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/224943406"},"html":{"href":"https://github.com/godotengine/godot/pull/22973#discussion_r224943406"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22973"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/22973","id":222615942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjE1OTQy","html_url":"https://github.com/godotengine/godot/pull/22973","diff_url":"https://github.com/godotengine/godot/pull/22973.diff","patch_url":"https://github.com/godotengine/godot/pull/22973.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/22973","number":22973,"state":"open","locked":false,"title":"Add support for collision layers and masks in CSG shapes","user":{"login":"cyclopsian","id":43323938,"node_id":"MDQ6VXNlcjQzMzIzOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/43323938?v=4","gravatar_id":"","url":"https://api.github.com/users/cyclopsian","html_url":"https://github.com/cyclopsian","followers_url":"https://api.github.com/users/cyclopsian/followers","following_url":"https://api.github.com/users/cyclopsian/following{/other_user}","gists_url":"https://api.github.com/users/cyclopsian/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclopsian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclopsian/subscriptions","organizations_url":"https://api.github.com/users/cyclopsian/orgs","repos_url":"https://api.github.com/users/cyclopsian/repos","events_url":"https://api.github.com/users/cyclopsian/events{/privacy}","received_events_url":"https://api.github.com/users/cyclopsian/received_events","type":"User","site_admin":false},"body":"Code mostly copied from PhysicsBody. Not having this kind of hampers the usability of CSG shapes, so it might make sense to have it for 3.1.","created_at":"2018-10-13T00:36:29Z","updated_at":"2018-10-13T00:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4068978e5bffcf13a76eca2efa3722b42c1affd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/22973/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/22973/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/22973/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/7eeb4bbd455aa45a3ed63bb653951ac079cbfe65","head":{"label":"cyclopsian:csg-collision-fix","ref":"csg-collision-fix","sha":"7eeb4bbd455aa45a3ed63bb653951ac079cbfe65","user":{"login":"cyclopsian","id":43323938,"node_id":"MDQ6VXNlcjQzMzIzOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/43323938?v=4","gravatar_id":"","url":"https://api.github.com/users/cyclopsian","html_url":"https://github.com/cyclopsian","followers_url":"https://api.github.com/users/cyclopsian/followers","following_url":"https://api.github.com/users/cyclopsian/following{/other_user}","gists_url":"https://api.github.com/users/cyclopsian/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclopsian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclopsian/subscriptions","organizations_url":"https://api.github.com/users/cyclopsian/orgs","repos_url":"https://api.github.com/users/cyclopsian/repos","events_url":"https://api.github.com/users/cyclopsian/events{/privacy}","received_events_url":"https://api.github.com/users/cyclopsian/received_events","type":"User","site_admin":false},"repo":{"id":152818862,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTg4NjI=","name":"godot","full_name":"cyclopsian/godot","private":false,"owner":{"login":"cyclopsian","id":43323938,"node_id":"MDQ6VXNlcjQzMzIzOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/43323938?v=4","gravatar_id":"","url":"https://api.github.com/users/cyclopsian","html_url":"https://github.com/cyclopsian","followers_url":"https://api.github.com/users/cyclopsian/followers","following_url":"https://api.github.com/users/cyclopsian/following{/other_user}","gists_url":"https://api.github.com/users/cyclopsian/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclopsian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclopsian/subscriptions","organizations_url":"https://api.github.com/users/cyclopsian/orgs","repos_url":"https://api.github.com/users/cyclopsian/repos","events_url":"https://api.github.com/users/cyclopsian/events{/privacy}","received_events_url":"https://api.github.com/users/cyclopsian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cyclopsian/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/cyclopsian/godot","forks_url":"https://api.github.com/repos/cyclopsian/godot/forks","keys_url":"https://api.github.com/repos/cyclopsian/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyclopsian/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyclopsian/godot/teams","hooks_url":"https://api.github.com/repos/cyclopsian/godot/hooks","issue_events_url":"https://api.github.com/repos/cyclopsian/godot/issues/events{/number}","events_url":"https://api.github.com/repos/cyclopsian/godot/events","assignees_url":"https://api.github.com/repos/cyclopsian/godot/assignees{/user}","branches_url":"https://api.github.com/repos/cyclopsian/godot/branches{/branch}","tags_url":"https://api.github.com/repos/cyclopsian/godot/tags","blobs_url":"https://api.github.com/repos/cyclopsian/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyclopsian/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyclopsian/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyclopsian/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyclopsian/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/cyclopsian/godot/languages","stargazers_url":"https://api.github.com/repos/cyclopsian/godot/stargazers","contributors_url":"https://api.github.com/repos/cyclopsian/godot/contributors","subscribers_url":"https://api.github.com/repos/cyclopsian/godot/subscribers","subscription_url":"https://api.github.com/repos/cyclopsian/godot/subscription","commits_url":"https://api.github.com/repos/cyclopsian/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyclopsian/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyclopsian/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyclopsian/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyclopsian/godot/contents/{+path}","compare_url":"https://api.github.com/repos/cyclopsian/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyclopsian/godot/merges","archive_url":"https://api.github.com/repos/cyclopsian/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyclopsian/godot/downloads","issues_url":"https://api.github.com/repos/cyclopsian/godot/issues{/number}","pulls_url":"https://api.github.com/repos/cyclopsian/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/cyclopsian/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/cyclopsian/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyclopsian/godot/labels{/name}","releases_url":"https://api.github.com/repos/cyclopsian/godot/releases{/id}","deployments_url":"https://api.github.com/repos/cyclopsian/godot/deployments","created_at":"2018-10-12T23:56:00Z","updated_at":"2018-10-12T23:56:11Z","pushed_at":"2018-10-12T23:59:09Z","git_url":"git://github.com/cyclopsian/godot.git","ssh_url":"git@github.com:cyclopsian/godot.git","clone_url":"https://github.com/cyclopsian/godot.git","svn_url":"https://github.com/cyclopsian/godot","homepage":"https://godotengine.org","size":265466,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"43c28681add010b5daccbcfde3e3065d7be7b52c","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDk4MQ==","name":"godot","full_name":"godotengine/godot","private":false,"owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2018-10-12T23:51:37Z","pushed_at":"2018-10-13T00:36:30Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":265466,"stargazers_count":16983,"watchers_count":16983,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3508,"mirror_url":null,"archived":false,"open_issues_count":4027,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3508,"open_issues":4027,"watchers":16983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22973"},"html":{"href":"https://github.com/godotengine/godot/pull/22973"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/22973"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/22973/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22973/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22973/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/7eeb4bbd455aa45a3ed63bb653951ac079cbfe65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cyclopsian"}}