{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57743","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57743/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57743/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57743/events","html_url":"https://github.com/kubernetes/kubernetes/pull/57743","id":285408415,"number":57743,"title":"fix error message about DeleteOptions","user":{"login":"CaoShuFeng","id":20855209,"avatar_url":"https://avatars0.githubusercontent.com/u/20855209?v=4","gravatar_id":"","url":"https://api.github.com/users/CaoShuFeng","html_url":"https://github.com/CaoShuFeng","followers_url":"https://api.github.com/users/CaoShuFeng/followers","following_url":"https://api.github.com/users/CaoShuFeng/following{/other_user}","gists_url":"https://api.github.com/users/CaoShuFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/CaoShuFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaoShuFeng/subscriptions","organizations_url":"https://api.github.com/users/CaoShuFeng/orgs","repos_url":"https://api.github.com/users/CaoShuFeng/repos","events_url":"https://api.github.com/users/CaoShuFeng/events{/privacy}","received_events_url":"https://api.github.com/users/CaoShuFeng/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"assignees":[{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},{"login":"markturansky","id":8001968,"avatar_url":"https://avatars3.githubusercontent.com/u/8001968?v=4","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-01-02T11:30:42Z","updated_at":"2018-03-20T13:48:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57743","html_url":"https://github.com/kubernetes/kubernetes/pull/57743","diff_url":"https://github.com/kubernetes/kubernetes/pull/57743.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/57743.patch"},"body":"Before this change:\r\n```shell\r\n$ curl -k  -XDELETE  -H \"Accept: application/json\" -H \"Content-Type: application/json\" -H \"User-Agent: kubectl/v1.10.0 (linux/amd64) kubernetes/d7e5bd1\" http://172.16.29.130:8080/apis/extensions/v1beta1/namespaces/default/deployments/nginx --data '{\"propagationPolicy\":\"Background11111\"}'\r\n{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\" \\\"\\\" is invalid: []: Invalid value: v1.DeleteOptions{TypeMeta:v1.TypeMeta{Kind:\\\"\\\", APIVersion:\\\"\\\"}, GracePeriodSeconds:(*int64)(nil), Preconditions:(*v1.Preconditions)(nil), OrphanDependents:(*bool)(nil), PropagationPolicy:(*v1.DeletionPropagation)(0xc429aa9ed0)}: DeletionPropagation need to be one of \\\"Foreground\\\", \\\"Background\\\", \\\"Orphan\\\" or nil\",\"reason\":\"Invalid\",\"details\":{\"causes\":[{\"reason\":\"FieldValueInvalid\",\"message\":\"Invalid value: v1.DeleteOptions{TypeMeta:v1.TypeMeta{Kind:\\\"\\\", APIVersion:\\\"\\\"}, GracePeriodSeconds:(*int64)(nil), Preconditions:(*v1.Preconditions)(nil), OrphanDependents:(*bool)(nil), PropagationPolicy:(*v1.DeletionPropagation)(0xc429aa9ed0)}: DeletionPropagation need to be one of \\\"Foreground\\\", \\\"Background\\\", \\\"Orphan\\\" or nil\",\"field\":\"[]\"}]},\"code\":422}\r\n```\r\nAfter this change:\r\n```shell\r\n$ curl -k  -XDELETE  -H \"Accept: application/json\" -H \"Content-Type: application/json\" -H \"User-Agent: kubectl/v1.10.0 (linux/amd64) kubernetes/d7e5bd1\" http://172.16.29.130:8080/apis/extensions/v1beta1/namespaces/default/deployments/nginx --data '{\"propagationPolicy\":\"Background11111\"}'\r\n{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"DeleteOptions.meta.k8s.io \\\"\\\" is invalid: propagationPolicy: Unsupported value: \\\"Foreground1111\\\": supported values: \\\"Foreground\\\", \\\"Background\\\", \\\"Orphan\\\", \\\"nil\\\"\",\"reason\":\"Invalid\",\"details\":{\"group\":\"meta.k8s.io\",\"kind\":\"DeleteOptions\",\"causes\":[{\"reason\":\"FieldValueNotSupported\",\"message\":\"Unsupported value: \\\"Foreground1111\\\": supported values: \\\"Foreground\\\", \\\"Background\\\", \\\"Orphan\\\", \\\"nil\\\"\",\"field\":\"propagationPolicy\"}]},\"code\":422}\r\n```\r\n\r\n**Release note**:\r\n```\r\nNONE\r\n```\r\n\r\n  "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/374604000","html_url":"https://github.com/kubernetes/kubernetes/pull/57743#issuecomment-374604000","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57743","id":374604000,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T13:48:56Z","updated_at":"2018-03-20T13:48:56Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/57743#\" title=\"Author self-approved\">CaoShuFeng</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/57743#issuecomment-374603958\" title=\"LGTM\">deads2k</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apimachinery/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/OWNERS)~~ [deads2k]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/OWNERS)~~ [deads2k]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}