{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/60","repository_url":"https://api.github.com/repos/apollographql/apollo-link-rest","labels_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/60/comments","events_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/60/events","html_url":"https://github.com/apollographql/apollo-link-rest/issues/60","id":291915961,"number":60,"title":"Feature Discussion: Adding automatic typename inference","user":{"login":"sky-franciscogoncalves","id":33831763,"avatar_url":"https://avatars1.githubusercontent.com/u/33831763?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-franciscogoncalves","html_url":"https://github.com/sky-franciscogoncalves","followers_url":"https://api.github.com/users/sky-franciscogoncalves/followers","following_url":"https://api.github.com/users/sky-franciscogoncalves/following{/other_user}","gists_url":"https://api.github.com/users/sky-franciscogoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-franciscogoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-franciscogoncalves/subscriptions","organizations_url":"https://api.github.com/users/sky-franciscogoncalves/orgs","repos_url":"https://api.github.com/users/sky-franciscogoncalves/repos","events_url":"https://api.github.com/users/sky-franciscogoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/sky-franciscogoncalves/received_events","type":"User","site_admin":false},"labels":[{"id":762337060,"url":"https://api.github.com/repos/apollographql/apollo-link-rest/labels/enhancement%F0%9F%92%A1","name":"enhancement💡","color":"84b6eb","default":false},{"id":762337064,"url":"https://api.github.com/repos/apollographql/apollo-link-rest/labels/question%E2%9D%94","name":"question❔","color":"cc317c","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apollographql/apollo-link-rest/milestones/3","html_url":"https://github.com/apollographql/apollo-link-rest/milestone/3","labels_url":"https://api.github.com/repos/apollographql/apollo-link-rest/milestones/3/labels","id":3326305,"number":3,"title":"v0.3.0","description":"","creator":{"login":"fbartho","id":209712,"avatar_url":"https://avatars2.githubusercontent.com/u/209712?v=4","gravatar_id":"","url":"https://api.github.com/users/fbartho","html_url":"https://github.com/fbartho","followers_url":"https://api.github.com/users/fbartho/followers","following_url":"https://api.github.com/users/fbartho/following{/other_user}","gists_url":"https://api.github.com/users/fbartho/gists{/gist_id}","starred_url":"https://api.github.com/users/fbartho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbartho/subscriptions","organizations_url":"https://api.github.com/users/fbartho/orgs","repos_url":"https://api.github.com/users/fbartho/repos","events_url":"https://api.github.com/users/fbartho/events{/privacy}","received_events_url":"https://api.github.com/users/fbartho/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":7,"state":"open","created_at":"2018-05-07T17:07:22Z","updated_at":"2018-05-22T20:26:37Z","due_on":"2018-05-23T07:00:00Z","closed_at":null},"comments":18,"created_at":"2018-01-26T14:23:27Z","updated_at":"2018-05-22T20:26:37Z","closed_at":"2018-05-22T20:26:37Z","author_association":"NONE","body":"Hi,\r\n\r\nAfter @fbartho's PR (#55) to add typenames to nested objects, I expected it to be able to automatically infer typenames based on the objects' property name. However, this wasn't the case. \r\n\r\nAfter talking with him on Slack, he suggested that I opened an issue so that we can discuss if this would be viable as the property could rarely match the TypeName.\r\n\r\nIn my use case, this would allow to rapidly connect a GraphQL client to a REST server, while providing only the necessary custom __typenames using @fbartho's implementation.\r\n\r\nI did an implementation of this feature and I will open a PR shortly. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/comments/391129061","html_url":"https://github.com/apollographql/apollo-link-rest/issues/60#issuecomment-391129061","issue_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/60","id":391129061,"user":{"login":"fbartho","id":209712,"avatar_url":"https://avatars2.githubusercontent.com/u/209712?v=4","gravatar_id":"","url":"https://api.github.com/users/fbartho","html_url":"https://github.com/fbartho","followers_url":"https://api.github.com/users/fbartho/followers","following_url":"https://api.github.com/users/fbartho/following{/other_user}","gists_url":"https://api.github.com/users/fbartho/gists{/gist_id}","starred_url":"https://api.github.com/users/fbartho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbartho/subscriptions","organizations_url":"https://api.github.com/users/fbartho/orgs","repos_url":"https://api.github.com/users/fbartho/repos","events_url":"https://api.github.com/users/fbartho/events{/privacy}","received_events_url":"https://api.github.com/users/fbartho/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T20:26:37Z","updated_at":"2018-05-22T20:26:37Z","author_association":"COLLABORATOR","body":"There has been no action on this thread since February, and we separately opened #72 to implement the manual `@type(name: …)` directive, so I'm comfortable closing this ticket as done for now. Please re-open if you want to continue discussing techniques for truly \"automatic\" typename inference -- especially if we can think of a safe, standard way of doing that. -- I think our discussion didn't find that technique."}}
{"actor":{"display_login":"fbartho"}}