{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/179528844","pull_request_review_id":109790566,"id":179528844,"diff_hunk":"@@ -96,78 +97,88 @@ $ kill -9 ETCD_1_PID\n ```\n \n ```shell\n-$ kubectl get pods -l \"component=${RELEASE-NAME}-etcd\"\n-NAME                 READY     STATUS        RESTARTS   AGE\n-etcd-0               1/1       Running       0          54s\n-etcd-2               1/1       Running       0          51s\n+$ kubectl get pods -l app=etcd,release=${RELEASE_NAME}\n+NAME                READY     STATUS    RESTARTS   AGE\n+my-release-etcd-0   1/1       Running   0          3m\n+my-release-etcd-2   1/1       Running   0          2m\n ```\n \n After a while:\n \n ```shell\n-$ kubectl get pods -l \"component=${RELEASE-NAME}-etcd\"\n-NAME                 READY     STATUS    RESTARTS   AGE\n-etcd-0               1/1       Running   0          1m\n-etcd-1               1/1       Running   0          20s\n-etcd-2               1/1       Running   0          1m\n+$ kubectl get pods -l app=etcd,release=${RELEASE_NAME}\n+NAME                READY     STATUS    RESTARTS   AGE\n+my-release-etcd-0   1/1       Running   0          3m\n+my-release-etcd-1   1/1       Running   1          20s\n+my-release-etcd-2   1/1       Running   0          2m\n ```\n \n-You can check state of re-joining from ``etcd-1``'s logs:\n+You can check state of re-joining from ``my-release-etcd-1``'s logs:\n \n ```shell\n-$ kubectl logs etcd-1\n-Waiting for etcd-0.etcd to come up\n-Waiting for etcd-1.etcd to come up\n-ping: bad address 'etcd-1.etcd'\n-Waiting for etcd-1.etcd to come up\n-Waiting for etcd-2.etcd to come up\n-Re-joining etcd member\n-Updated member with ID 7fd61f3f79d97779 in cluster\n-2016-06-20 11:04:14.962169 I | etcdmain: etcd Version: 2.2.5\n-2016-06-20 11:04:14.962287 I | etcdmain: Git SHA: bc9ddf2\n+$ kubectl logs my-release-etcd-1\n++ hostname\n++ HOSTNAME=my-release-etcd-1\n++ ip r+  get 1\n+awk '{print $NF;exit}'\n++ IP=172.17.0.8\n++ PROTO=https\n++ SET_ID=3\n++ '[' -e /etcd/member_id ]\n++ '[' 3 -ge 1 ]\n++ await_host my-release-etcd-1.my-release-etcd.default\n++ echo 'Waiting for [my-release-etcd-1.my-release-etcd.default] to come up '\n++ true\n++ echo -n .\n++ ping -W 1 -c 1 my-release-etcd-1.my-release-etcd.default\n+Waiting for [my-release-etcd-1.my-release-etcd.default] to come up\n+ping: bad address 'my-release-etcd-1.my-release-etcd.default'\n++ sleep 1s\n++ true\n++ echo -n .\n++ ping -W 1 -c 1 my-release-etcd-1.my-release-etcd.default\n++ break\n++ echo -n ' done'\n++ add_member\n ...\n ```\n \n-## Scaling using kubectl\n-\n-This is for reference. Scaling should be managed by `helm upgrade`\n+## Scaling using Helm\n \n-The etcd cluster can be scale up by running ``kubectl patch`` or ``kubectl edit``. For instance,\n+Scaling is managed by `helm upgrade`.\n \n-```sh\n-$ kubectl get pods -l \"component=${RELEASE-NAME}-etcd\"\n-NAME      READY     STATUS    RESTARTS   AGE\n-etcd-0    1/1       Running   0          7m\n-etcd-1    1/1       Running   0          7m\n-etcd-2    1/1       Running   0          6m\n+The etcd cluster can be scale up by chaning the number of replicas in the","path":"incubator/etcd/README.md","position":194,"original_position":194,"commit_id":"1521a3dcb4a1320c08086f19111755f57caf76de","original_commit_id":"1521a3dcb4a1320c08086f19111755f57caf76de","user":{"login":"timstoop","id":729432,"avatar_url":"https://avatars2.githubusercontent.com/u/729432?v=4","gravatar_id":"","url":"https://api.github.com/users/timstoop","html_url":"https://github.com/timstoop","followers_url":"https://api.github.com/users/timstoop/followers","following_url":"https://api.github.com/users/timstoop/following{/other_user}","gists_url":"https://api.github.com/users/timstoop/gists{/gist_id}","starred_url":"https://api.github.com/users/timstoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstoop/subscriptions","organizations_url":"https://api.github.com/users/timstoop/orgs","repos_url":"https://api.github.com/users/timstoop/repos","events_url":"https://api.github.com/users/timstoop/events{/privacy}","received_events_url":"https://api.github.com/users/timstoop/received_events","type":"User","site_admin":false},"body":"And \"can be scaled up\" (scale -> scaled)","created_at":"2018-04-05T16:47:43Z","updated_at":"2018-04-05T16:47:43Z","html_url":"https://github.com/kubernetes/charts/pull/4678#discussion_r179528844","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/4678","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/179528844"},"html":{"href":"https://github.com/kubernetes/charts/pull/4678#discussion_r179528844"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4678"}},"in_reply_to_id":179513769},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/4678","id":179353831,"html_url":"https://github.com/kubernetes/charts/pull/4678","diff_url":"https://github.com/kubernetes/charts/pull/4678.diff","patch_url":"https://github.com/kubernetes/charts/pull/4678.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/4678","number":4678,"state":"open","locked":false,"title":"[incubator/etcd] Fixed rejoining and discovery","user":{"login":"hiddeco","id":10063039,"avatar_url":"https://avatars1.githubusercontent.com/u/10063039?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddeco","html_url":"https://github.com/hiddeco","followers_url":"https://api.github.com/users/hiddeco/followers","following_url":"https://api.github.com/users/hiddeco/following{/other_user}","gists_url":"https://api.github.com/users/hiddeco/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddeco/subscriptions","organizations_url":"https://api.github.com/users/hiddeco/orgs","repos_url":"https://api.github.com/users/hiddeco/repos","events_url":"https://api.github.com/users/hiddeco/events{/privacy}","received_events_url":"https://api.github.com/users/hiddeco/received_events","type":"User","site_admin":false},"body":":warning: **Supersedes #2864 as it's stale** :warning: \r\n\r\n**Based upon:**\r\n- https://github.com/kubernetes/charts/pull/2864\r\n- https://github.com/rtluckie/kubernetes-charts/commit/5a2777c21593ceca13169de8e2dadf97fce4b8c8\r\n\r\n**Changes:**\r\n- rejoining and discovery fixes\r\n- peer TLS support\r\n- anti-affinity rules\r\n- other best practices","created_at":"2018-04-04T10:59:16Z","updated_at":"2018-04-05T16:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4181eac6abb88ade2a5f0cb8e2249289b7846d39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":678010043,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/4678/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/4678/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/4678/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/1521a3dcb4a1320c08086f19111755f57caf76de","head":{"label":"hiddeco:etcd-rejoining","ref":"etcd-rejoining","sha":"1521a3dcb4a1320c08086f19111755f57caf76de","user":{"login":"hiddeco","id":10063039,"avatar_url":"https://avatars1.githubusercontent.com/u/10063039?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddeco","html_url":"https://github.com/hiddeco","followers_url":"https://api.github.com/users/hiddeco/followers","following_url":"https://api.github.com/users/hiddeco/following{/other_user}","gists_url":"https://api.github.com/users/hiddeco/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddeco/subscriptions","organizations_url":"https://api.github.com/users/hiddeco/orgs","repos_url":"https://api.github.com/users/hiddeco/repos","events_url":"https://api.github.com/users/hiddeco/events{/privacy}","received_events_url":"https://api.github.com/users/hiddeco/received_events","type":"User","site_admin":false},"repo":{"id":122319761,"name":"charts","full_name":"hiddeco/charts","owner":{"login":"hiddeco","id":10063039,"avatar_url":"https://avatars1.githubusercontent.com/u/10063039?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddeco","html_url":"https://github.com/hiddeco","followers_url":"https://api.github.com/users/hiddeco/followers","following_url":"https://api.github.com/users/hiddeco/following{/other_user}","gists_url":"https://api.github.com/users/hiddeco/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddeco/subscriptions","organizations_url":"https://api.github.com/users/hiddeco/orgs","repos_url":"https://api.github.com/users/hiddeco/repos","events_url":"https://api.github.com/users/hiddeco/events{/privacy}","received_events_url":"https://api.github.com/users/hiddeco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiddeco/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/hiddeco/charts","forks_url":"https://api.github.com/repos/hiddeco/charts/forks","keys_url":"https://api.github.com/repos/hiddeco/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiddeco/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiddeco/charts/teams","hooks_url":"https://api.github.com/repos/hiddeco/charts/hooks","issue_events_url":"https://api.github.com/repos/hiddeco/charts/issues/events{/number}","events_url":"https://api.github.com/repos/hiddeco/charts/events","assignees_url":"https://api.github.com/repos/hiddeco/charts/assignees{/user}","branches_url":"https://api.github.com/repos/hiddeco/charts/branches{/branch}","tags_url":"https://api.github.com/repos/hiddeco/charts/tags","blobs_url":"https://api.github.com/repos/hiddeco/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiddeco/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiddeco/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiddeco/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiddeco/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/hiddeco/charts/languages","stargazers_url":"https://api.github.com/repos/hiddeco/charts/stargazers","contributors_url":"https://api.github.com/repos/hiddeco/charts/contributors","subscribers_url":"https://api.github.com/repos/hiddeco/charts/subscribers","subscription_url":"https://api.github.com/repos/hiddeco/charts/subscription","commits_url":"https://api.github.com/repos/hiddeco/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiddeco/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiddeco/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiddeco/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiddeco/charts/contents/{+path}","compare_url":"https://api.github.com/repos/hiddeco/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiddeco/charts/merges","archive_url":"https://api.github.com/repos/hiddeco/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiddeco/charts/downloads","issues_url":"https://api.github.com/repos/hiddeco/charts/issues{/number}","pulls_url":"https://api.github.com/repos/hiddeco/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/hiddeco/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/hiddeco/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiddeco/charts/labels{/name}","releases_url":"https://api.github.com/repos/hiddeco/charts/releases{/id}","deployments_url":"https://api.github.com/repos/hiddeco/charts/deployments","created_at":"2018-02-21T10:05:21Z","updated_at":"2018-02-21T10:05:25Z","pushed_at":"2018-04-05T11:39:19Z","git_url":"git://github.com/hiddeco/charts.git","ssh_url":"git@github.com:hiddeco/charts.git","clone_url":"https://github.com/hiddeco/charts.git","svn_url":"https://github.com/hiddeco/charts","homepage":"","size":4987,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8ac5cb273449f7a9cd74c74b8f9460a56c774f38","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-04-05T16:46:44Z","pushed_at":"2018-04-05T16:40:09Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":5242,"stargazers_count":2699,"watchers_count":2699,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2264,"mirror_url":null,"archived":false,"open_issues_count":545,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2264,"open_issues":545,"watchers":2699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4678"},"html":{"href":"https://github.com/kubernetes/charts/pull/4678"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/4678"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/4678/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4678/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4678/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/1521a3dcb4a1320c08086f19111755f57caf76de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timstoop"}}