{"action":"opened","issue":{"url":"https://api.github.com/repos/mate-desktop/atril/issues/346","repository_url":"https://api.github.com/repos/mate-desktop/atril","labels_url":"https://api.github.com/repos/mate-desktop/atril/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/mate-desktop/atril/issues/346/comments","events_url":"https://api.github.com/repos/mate-desktop/atril/issues/346/events","html_url":"https://github.com/mate-desktop/atril/issues/346","id":391296080,"node_id":"MDU6SXNzdWUzOTEyOTYwODA=","number":346,"title":"Strange places found by PVS studio","user":{"login":"shlyakpavel","id":19782228,"node_id":"MDQ6VXNlcjE5NzgyMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/19782228?v=4","gravatar_id":"","url":"https://api.github.com/users/shlyakpavel","html_url":"https://github.com/shlyakpavel","followers_url":"https://api.github.com/users/shlyakpavel/followers","following_url":"https://api.github.com/users/shlyakpavel/following{/other_user}","gists_url":"https://api.github.com/users/shlyakpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/shlyakpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlyakpavel/subscriptions","organizations_url":"https://api.github.com/users/shlyakpavel/orgs","repos_url":"https://api.github.com/users/shlyakpavel/repos","events_url":"https://api.github.com/users/shlyakpavel/events{/privacy}","received_events_url":"https://api.github.com/users/shlyakpavel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T22:09:11Z","updated_at":"2018-12-14T22:09:11Z","closed_at":null,"author_association":"NONE","body":"This is totally senseless. Please, inspect the code if original author has meant something else\r\nhttps://github.com/mate-desktop/atril/blob/29fc232c5a7f28af4d3162d7ceebb65d9bd6b1e0/libdocument/ev-document-factory.c#L139\r\nIt is possible that break is missing here. Consider removing useless line otherwise\r\nhttps://github.com/mate-desktop/atril/blob/29fc232c5a7f28af4d3162d7ceebb65d9bd6b1e0/backend/pdf/ev-poppler.cc#L703\r\nIt is also possible that is is not a good idea to do memset before checking tf_buf against null pointer here\r\nhttps://github.com/mate-desktop/atril/blob/29fc232c5a7f28af4d3162d7ceebb65d9bd6b1e0/backend/tiff/tiff2ps.c#L1545\r\nThe expression is always false here\r\nhttps://github.com/mate-desktop/atril/blob/29fc232c5a7f28af4d3162d7ceebb65d9bd6b1e0/shell/ev-message-area.c#L173\r\nPay attention to the if statement here\r\nhttps://github.com/mate-desktop/atril/blob/29fc232c5a7f28af4d3162d7ceebb65d9bd6b1e0/shell/ev-window.c#L1564-L1566\r\nIt has identical sub-expressions surrounding || operator\r\nAnyway, thank you guys for the great things you do!\r\nHave a nice day :)"}}
{"actor":{"display_login":"shlyakpavel"}}