{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/249","repository_url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl","labels_url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/249/comments","events_url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/249/events","html_url":"https://github.com/JuliaGraphics/Cairo.jl/pull/249","id":352490259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Nzg4MTI2","number":249,"title":"Redesign the CairoSurface type","user":{"login":"tknopp","id":3109172,"node_id":"MDQ6VXNlcjMxMDkxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3109172?v=4","gravatar_id":"","url":"https://api.github.com/users/tknopp","html_url":"https://github.com/tknopp","followers_url":"https://api.github.com/users/tknopp/followers","following_url":"https://api.github.com/users/tknopp/following{/other_user}","gists_url":"https://api.github.com/users/tknopp/gists{/gist_id}","starred_url":"https://api.github.com/users/tknopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknopp/subscriptions","organizations_url":"https://api.github.com/users/tknopp/orgs","repos_url":"https://api.github.com/users/tknopp/repos","events_url":"https://api.github.com/users/tknopp/events{/privacy}","received_events_url":"https://api.github.com/users/tknopp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-21T11:04:04Z","updated_at":"2018-08-21T16:40:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/pulls/249","html_url":"https://github.com/JuliaGraphics/Cairo.jl/pull/249","diff_url":"https://github.com/JuliaGraphics/Cairo.jl/pull/249.diff","patch_url":"https://github.com/JuliaGraphics/Cairo.jl/pull/249.patch"},"body":"This fixes #248 by holding a reference to the IO stream in the `CairoSurface` type. I made `CairoSurface` abstract and introduced three concrete types: `CairoSurfaceBase`. `CairoSurfaceImage` and `CairoSurfaceIOStream` since they hold different things and encoding this all into a single type gets a mess. "},"comment":{"url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/comments/414740470","html_url":"https://github.com/JuliaGraphics/Cairo.jl/pull/249#issuecomment-414740470","issue_url":"https://api.github.com/repos/JuliaGraphics/Cairo.jl/issues/249","id":414740470,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc0MDQ3MA==","user":{"login":"tkelman","id":5934628,"node_id":"MDQ6VXNlcjU5MzQ2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/5934628?v=4","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T16:40:19Z","updated_at":"2018-08-21T16:40:19Z","author_association":"CONTRIBUTOR","body":"re-enabling the source build that was too-hastily commented out and released without review\n________________________________\nFrom: Andreas Lobinger <notifications@github.com>\nSent: Tuesday, August 21, 2018 9:01:42 AM\nTo: JuliaGraphics/Cairo.jl\nCc: Tony Kelman; Mention\nSubject: Re: [JuliaGraphics/Cairo.jl] Redesign the CairoSurface type (#249)\n\n\n@tkelman<https://github.com/tkelman> Which BinDeps change?\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub<https://github.com/JuliaGraphics/Cairo.jl/pull/249#issuecomment-414727338>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFqOJPb6YMTXoFcOkVBXkKijj6QyQcpWks5uTC7mgaJpZM4WFj1n>.\n"}}
{"actor":{"display_login":"tkelman"}}