{"action":"created","comment":{"url":"https://api.github.com/repos/brpc/brpc/pulls/comments/200233907","pull_request_review_id":133179821,"id":200233907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIzMzkwNw==","diff_hunk":"@@ -146,7 +146,7 @@ void SendRpcResponse(int64_t correlation_id,\n         span->set_start_send_us(butil::cpuwide_time_us());\n     }\n     Socket* sock = accessor.get_sending_socket();\n-    ScopedMethodStatus method_status(method_status_raw);\n+    ScopedMethodStatus method_status(method_status_raw, cntl, start_parse_us);","path":"src/brpc/policy/baidu_rpc_protocol.cpp","position":5,"original_position":5,"commit_id":"5c8221a8afbf5bd978982957f0d83bf4d6b8a677","original_commit_id":"5c8221a8afbf5bd978982957f0d83bf4d6b8a677","user":{"login":"jamesge","id":6566535,"node_id":"MDQ6VXNlcjY1NjY1MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6566535?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesge","html_url":"https://github.com/jamesge","followers_url":"https://api.github.com/users/jamesge/followers","following_url":"https://api.github.com/users/jamesge/following{/other_user}","gists_url":"https://api.github.com/users/jamesge/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesge/subscriptions","organizations_url":"https://api.github.com/users/jamesge/orgs","repos_url":"https://api.github.com/users/jamesge/repos","events_url":"https://api.github.com/users/jamesge/events{/privacy}","received_events_url":"https://api.github.com/users/jamesge/received_events","type":"User","site_admin":false},"body":"位置不对，注意下一行的recycle_cntl，cntl会先析构的。","created_at":"2018-07-05T05:00:38Z","updated_at":"2018-07-05T05:03:16Z","html_url":"https://github.com/brpc/brpc/pull/380#discussion_r200233907","pull_request_url":"https://api.github.com/repos/brpc/brpc/pulls/380","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brpc/brpc/pulls/comments/200233907"},"html":{"href":"https://github.com/brpc/brpc/pull/380#discussion_r200233907"},"pull_request":{"href":"https://api.github.com/repos/brpc/brpc/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/brpc/brpc/pulls/380","id":198232298,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjMyMjk4","html_url":"https://github.com/brpc/brpc/pull/380","diff_url":"https://github.com/brpc/brpc/pull/380.diff","patch_url":"https://github.com/brpc/brpc/pull/380.patch","issue_url":"https://api.github.com/repos/brpc/brpc/issues/380","number":380,"state":"open","locked":false,"title":"Auto concurrency limiter","user":{"login":"TousakaRin","id":8801314,"node_id":"MDQ6VXNlcjg4MDEzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8801314?v=4","gravatar_id":"","url":"https://api.github.com/users/TousakaRin","html_url":"https://github.com/TousakaRin","followers_url":"https://api.github.com/users/TousakaRin/followers","following_url":"https://api.github.com/users/TousakaRin/following{/other_user}","gists_url":"https://api.github.com/users/TousakaRin/gists{/gist_id}","starred_url":"https://api.github.com/users/TousakaRin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TousakaRin/subscriptions","organizations_url":"https://api.github.com/users/TousakaRin/orgs","repos_url":"https://api.github.com/users/TousakaRin/repos","events_url":"https://api.github.com/users/TousakaRin/events{/privacy}","received_events_url":"https://api.github.com/users/TousakaRin/received_events","type":"User","site_admin":false},"body":"增加了自动限流：\r\n1.  将 ServerOptions.max_concurrency = 10 扩展了：max_concurrency=\"10\", 及 max_concurrency=“auto”\r\n2.  修改了AddConcurrency, RemoveConcurrency、OnRequested\r\n3.  修改了 ScopedMethodStatus、 OnResponded的接口\r\n4.  增加了constant_concurrency_limiter和gradient_concurrency_limiter，用于并发控制。\r\n    ","created_at":"2018-06-29T07:07:01Z","updated_at":"2018-07-05T05:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"419082be4e0f1cb2a9b8b5115accf3b1d4f3c703","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brpc/brpc/pulls/380/commits","review_comments_url":"https://api.github.com/repos/brpc/brpc/pulls/380/comments","review_comment_url":"https://api.github.com/repos/brpc/brpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brpc/brpc/issues/380/comments","statuses_url":"https://api.github.com/repos/brpc/brpc/statuses/5c8221a8afbf5bd978982957f0d83bf4d6b8a677","head":{"label":"TousakaRin:auto_concurrency_limiter","ref":"auto_concurrency_limiter","sha":"5c8221a8afbf5bd978982957f0d83bf4d6b8a677","user":{"login":"TousakaRin","id":8801314,"node_id":"MDQ6VXNlcjg4MDEzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8801314?v=4","gravatar_id":"","url":"https://api.github.com/users/TousakaRin","html_url":"https://github.com/TousakaRin","followers_url":"https://api.github.com/users/TousakaRin/followers","following_url":"https://api.github.com/users/TousakaRin/following{/other_user}","gists_url":"https://api.github.com/users/TousakaRin/gists{/gist_id}","starred_url":"https://api.github.com/users/TousakaRin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TousakaRin/subscriptions","organizations_url":"https://api.github.com/users/TousakaRin/orgs","repos_url":"https://api.github.com/users/TousakaRin/repos","events_url":"https://api.github.com/users/TousakaRin/events{/privacy}","received_events_url":"https://api.github.com/users/TousakaRin/received_events","type":"User","site_admin":false},"repo":{"id":139089602,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwODk2MDI=","name":"brpc","full_name":"TousakaRin/brpc","owner":{"login":"TousakaRin","id":8801314,"node_id":"MDQ6VXNlcjg4MDEzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8801314?v=4","gravatar_id":"","url":"https://api.github.com/users/TousakaRin","html_url":"https://github.com/TousakaRin","followers_url":"https://api.github.com/users/TousakaRin/followers","following_url":"https://api.github.com/users/TousakaRin/following{/other_user}","gists_url":"https://api.github.com/users/TousakaRin/gists{/gist_id}","starred_url":"https://api.github.com/users/TousakaRin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TousakaRin/subscriptions","organizations_url":"https://api.github.com/users/TousakaRin/orgs","repos_url":"https://api.github.com/users/TousakaRin/repos","events_url":"https://api.github.com/users/TousakaRin/events{/privacy}","received_events_url":"https://api.github.com/users/TousakaRin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TousakaRin/brpc","description":"Industrial-grade RPC framework used throughout Baidu, with 1,000,000+ instances and thousands kinds of services, called \"baidu-rpc\" inside Baidu.","fork":true,"url":"https://api.github.com/repos/TousakaRin/brpc","forks_url":"https://api.github.com/repos/TousakaRin/brpc/forks","keys_url":"https://api.github.com/repos/TousakaRin/brpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TousakaRin/brpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TousakaRin/brpc/teams","hooks_url":"https://api.github.com/repos/TousakaRin/brpc/hooks","issue_events_url":"https://api.github.com/repos/TousakaRin/brpc/issues/events{/number}","events_url":"https://api.github.com/repos/TousakaRin/brpc/events","assignees_url":"https://api.github.com/repos/TousakaRin/brpc/assignees{/user}","branches_url":"https://api.github.com/repos/TousakaRin/brpc/branches{/branch}","tags_url":"https://api.github.com/repos/TousakaRin/brpc/tags","blobs_url":"https://api.github.com/repos/TousakaRin/brpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TousakaRin/brpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TousakaRin/brpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/TousakaRin/brpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TousakaRin/brpc/statuses/{sha}","languages_url":"https://api.github.com/repos/TousakaRin/brpc/languages","stargazers_url":"https://api.github.com/repos/TousakaRin/brpc/stargazers","contributors_url":"https://api.github.com/repos/TousakaRin/brpc/contributors","subscribers_url":"https://api.github.com/repos/TousakaRin/brpc/subscribers","subscription_url":"https://api.github.com/repos/TousakaRin/brpc/subscription","commits_url":"https://api.github.com/repos/TousakaRin/brpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/TousakaRin/brpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/TousakaRin/brpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/TousakaRin/brpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/TousakaRin/brpc/contents/{+path}","compare_url":"https://api.github.com/repos/TousakaRin/brpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TousakaRin/brpc/merges","archive_url":"https://api.github.com/repos/TousakaRin/brpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TousakaRin/brpc/downloads","issues_url":"https://api.github.com/repos/TousakaRin/brpc/issues{/number}","pulls_url":"https://api.github.com/repos/TousakaRin/brpc/pulls{/number}","milestones_url":"https://api.github.com/repos/TousakaRin/brpc/milestones{/number}","notifications_url":"https://api.github.com/repos/TousakaRin/brpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TousakaRin/brpc/labels{/name}","releases_url":"https://api.github.com/repos/TousakaRin/brpc/releases{/id}","deployments_url":"https://api.github.com/repos/TousakaRin/brpc/deployments","created_at":"2018-06-29T02:12:00Z","updated_at":"2018-06-29T02:12:05Z","pushed_at":"2018-06-29T12:36:58Z","git_url":"git://github.com/TousakaRin/brpc.git","ssh_url":"git@github.com:TousakaRin/brpc.git","clone_url":"https://github.com/TousakaRin/brpc.git","svn_url":"https://github.com/TousakaRin/brpc","homepage":"","size":25319,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brpc:master","ref":"master","sha":"87592e12337c4474886234a0d0b71b053e28d936","user":{"login":"brpc","id":31610676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjEwNjc2","avatar_url":"https://avatars2.githubusercontent.com/u/31610676?v=4","gravatar_id":"","url":"https://api.github.com/users/brpc","html_url":"https://github.com/brpc","followers_url":"https://api.github.com/users/brpc/followers","following_url":"https://api.github.com/users/brpc/following{/other_user}","gists_url":"https://api.github.com/users/brpc/gists{/gist_id}","starred_url":"https://api.github.com/users/brpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brpc/subscriptions","organizations_url":"https://api.github.com/users/brpc/orgs","repos_url":"https://api.github.com/users/brpc/repos","events_url":"https://api.github.com/users/brpc/events{/privacy}","received_events_url":"https://api.github.com/users/brpc/received_events","type":"Organization","site_admin":false},"repo":{"id":102343794,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNDM3OTQ=","name":"brpc","full_name":"brpc/brpc","owner":{"login":"brpc","id":31610676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjEwNjc2","avatar_url":"https://avatars2.githubusercontent.com/u/31610676?v=4","gravatar_id":"","url":"https://api.github.com/users/brpc","html_url":"https://github.com/brpc","followers_url":"https://api.github.com/users/brpc/followers","following_url":"https://api.github.com/users/brpc/following{/other_user}","gists_url":"https://api.github.com/users/brpc/gists{/gist_id}","starred_url":"https://api.github.com/users/brpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brpc/subscriptions","organizations_url":"https://api.github.com/users/brpc/orgs","repos_url":"https://api.github.com/users/brpc/repos","events_url":"https://api.github.com/users/brpc/events{/privacy}","received_events_url":"https://api.github.com/users/brpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brpc/brpc","description":"Industrial-grade RPC framework used throughout Baidu, with 1,000,000+ instances and thousands kinds of services, called \"baidu-rpc\" inside Baidu.","fork":false,"url":"https://api.github.com/repos/brpc/brpc","forks_url":"https://api.github.com/repos/brpc/brpc/forks","keys_url":"https://api.github.com/repos/brpc/brpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brpc/brpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brpc/brpc/teams","hooks_url":"https://api.github.com/repos/brpc/brpc/hooks","issue_events_url":"https://api.github.com/repos/brpc/brpc/issues/events{/number}","events_url":"https://api.github.com/repos/brpc/brpc/events","assignees_url":"https://api.github.com/repos/brpc/brpc/assignees{/user}","branches_url":"https://api.github.com/repos/brpc/brpc/branches{/branch}","tags_url":"https://api.github.com/repos/brpc/brpc/tags","blobs_url":"https://api.github.com/repos/brpc/brpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brpc/brpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brpc/brpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/brpc/brpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brpc/brpc/statuses/{sha}","languages_url":"https://api.github.com/repos/brpc/brpc/languages","stargazers_url":"https://api.github.com/repos/brpc/brpc/stargazers","contributors_url":"https://api.github.com/repos/brpc/brpc/contributors","subscribers_url":"https://api.github.com/repos/brpc/brpc/subscribers","subscription_url":"https://api.github.com/repos/brpc/brpc/subscription","commits_url":"https://api.github.com/repos/brpc/brpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/brpc/brpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/brpc/brpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/brpc/brpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/brpc/brpc/contents/{+path}","compare_url":"https://api.github.com/repos/brpc/brpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brpc/brpc/merges","archive_url":"https://api.github.com/repos/brpc/brpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brpc/brpc/downloads","issues_url":"https://api.github.com/repos/brpc/brpc/issues{/number}","pulls_url":"https://api.github.com/repos/brpc/brpc/pulls{/number}","milestones_url":"https://api.github.com/repos/brpc/brpc/milestones{/number}","notifications_url":"https://api.github.com/repos/brpc/brpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brpc/brpc/labels{/name}","releases_url":"https://api.github.com/repos/brpc/brpc/releases{/id}","deployments_url":"https://api.github.com/repos/brpc/brpc/deployments","created_at":"2017-09-04T09:28:47Z","updated_at":"2018-07-05T03:36:02Z","pushed_at":"2018-07-04T15:43:28Z","git_url":"git://github.com/brpc/brpc.git","ssh_url":"git@github.com:brpc/brpc.git","clone_url":"https://github.com/brpc/brpc.git","svn_url":"https://github.com/brpc/brpc","homepage":"","size":25348,"stargazers_count":7117,"watchers_count":7117,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1594,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1594,"open_issues":75,"watchers":7117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brpc/brpc/pulls/380"},"html":{"href":"https://github.com/brpc/brpc/pull/380"},"issue":{"href":"https://api.github.com/repos/brpc/brpc/issues/380"},"comments":{"href":"https://api.github.com/repos/brpc/brpc/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/brpc/brpc/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/brpc/brpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brpc/brpc/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/brpc/brpc/statuses/5c8221a8afbf5bd978982957f0d83bf4d6b8a677"}},"author_association":"NONE"}}
{"actor":{"display_login":"jamesge"}}