{"action":"created","comment":{"url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/comments/192450796","pull_request_review_id":125236800,"id":192450796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQ1MDc5Ng==","diff_hunk":"@@ -28,27 +28,82 @@ Page Header Component\n \tUsage:\n \t<div class=\"PageHeader (PageHeader--responsive-[s/m/l])\">\n \t\t<div class=\"PageHeader__container\">\n-\t\t\t<a class=\"PageHeader__logo\" href=\"//www.dreamhost.com\"><img src=\"https://www.dreamhost.com/assets/images/logo.dreamhost.white.svg\" width=\"157\" height=\"23\"></a>\n-\t\t\t<ul class=\"PageHeader__nav PageHeader__only-show-large\">\n+\t\t\t<a class=\"PageHeader__logo ( PageHeader__logo--internal - add for internal facing / user logged into DreamHost Properties ) \" href=\"//www.dreamhost.com\"></a>\n+\t\t\t<ul class=\"PageHeader__nav\">\n \t\t\t\t<li><a class=\"PageHeader__nav-link is-active\" href=\"#\">Link</a></li>\n \t\t\t</ul>\n-\t\t\t<ul class=\"PageHeader__subnav PageHeader__only-show-small t-right\">\n-\t\t\t\t<li><button class=\"PageHeader__subnav-link js-toggle-mobile-menu\">\n-\t\t\t\t\t<svg class=\"Icon Icon-hamburger\" viewBox=\"0 0 24 18\">\n-\t\t\t\t\t\t<path d=\"M0 5.9L0 7.1C0 7.1 0 7.1 0 7.1L24 7.1C24 7.1 24 7.1 24 7.1L24 5.9C24 5.9 24 5.9 24 5.9L0 5.9C0 5.9 0 5.9 0 5.9ZM0 0.9L0 2.1C0 2.1 0 2.1 0 2.1L24 2.1C24 2.1 24 2.1 24 2.1L24 0.9C24 0.9 24 0.9 24 0.9L0 0.9C0 0.9 0 0.9 0 0.9ZM0 15.9L0 17.1C0 17.1 0 17.1 0 17.1L24 17.1C24 17.1 24 17.1 24 17.1L24 15.9C24 15.9 24 15.9 24 15.9L0 15.9C0 15.9 0 15.9 0 15.9ZM0 12.2C0 12.2 24 12.2 24 12.2L24 10.9C24 10.9 0 10.9 0 10.9L0 12.2Z\"></path>\n-\t\t\t\t\t</svg><!-- remove whitespace\n-\t\t\t\t\t-->Menu\n-\t\t\t\t</button></li>\n+\t\t\t<ul class=\"PageHeader__subnav\">\n+\t\t\t\t<li><div class=\"PageHeader__menu-toggle js-toggle-mobile-menu\"><span></span><span></span><span></span></div></li>\n \t\t\t</ul>\n \t\t</div>\n \t</div>\n \n */\n \n .PageHeader {\n-\tpadding: convertScaleToRem(3.5) 0;\n+\tposition: relative;\n+\tpadding: 1.75rem 1.75rem 3.5rem 1.75rem;\n \tbackground: $c-b700;\n \tcolor: #fff;\n+\n+\t&.PageHeader--transparent{\n+\t\tbackground: transparent;\n+\t}\n+\n+}\n+\n+.PageHeader__menu-toggle {\n+\tmargin: convertScaleToRem(0.5) 0 0 0;\n+\tdisplay: inline-block;\n+\theight: 15px;\n+\twidth: 20px;\n+\tvertical-align: middle;\n+\tposition: relative;\n+\n+\t&:hover {\n+\t\tcursor: pointer;\n+\t}\n+\n+\tspan {","path":"src/scss/modules/_page-header.scss","position":50,"original_position":50,"commit_id":"970e0b0af1476470eef17be34f1cab62ca2eb715","original_commit_id":"970e0b0af1476470eef17be34f1cab62ca2eb715","user":{"login":"sfowles","id":8948879,"node_id":"MDQ6VXNlcjg5NDg4Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8948879?v=4","gravatar_id":"","url":"https://api.github.com/users/sfowles","html_url":"https://github.com/sfowles","followers_url":"https://api.github.com/users/sfowles/followers","following_url":"https://api.github.com/users/sfowles/following{/other_user}","gists_url":"https://api.github.com/users/sfowles/gists{/gist_id}","starred_url":"https://api.github.com/users/sfowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfowles/subscriptions","organizations_url":"https://api.github.com/users/sfowles/orgs","repos_url":"https://api.github.com/users/sfowles/repos","events_url":"https://api.github.com/users/sfowles/events{/privacy}","received_events_url":"https://api.github.com/users/sfowles/received_events","type":"User","site_admin":false},"body":"Ah cool, in that case I think it would be great to include class names for clarity, and also to consider making use of pseudo elements in order to reduce the number of empty containers. Some great examples here https://jonsuh.com/hamburgers/","created_at":"2018-06-01T16:36:34Z","updated_at":"2018-06-01T16:36:34Z","html_url":"https://github.com/dreamhost/dreamhost.css/pull/194#discussion_r192450796","pull_request_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/comments/192450796"},"html":{"href":"https://github.com/dreamhost/dreamhost.css/pull/194#discussion_r192450796"},"pull_request":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194"}},"in_reply_to_id":192424159},"pull_request":{"url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194","id":191860138,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODYwMTM4","html_url":"https://github.com/dreamhost/dreamhost.css/pull/194","diff_url":"https://github.com/dreamhost/dreamhost.css/pull/194.diff","patch_url":"https://github.com/dreamhost/dreamhost.css/pull/194.patch","issue_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/194","number":194,"state":"open","locked":false,"title":"Dh pageheader","user":{"login":"christopherleckie","id":5073839,"node_id":"MDQ6VXNlcjUwNzM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/5073839?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherleckie","html_url":"https://github.com/christopherleckie","followers_url":"https://api.github.com/users/christopherleckie/followers","following_url":"https://api.github.com/users/christopherleckie/following{/other_user}","gists_url":"https://api.github.com/users/christopherleckie/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherleckie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherleckie/subscriptions","organizations_url":"https://api.github.com/users/christopherleckie/orgs","repos_url":"https://api.github.com/users/christopherleckie/repos","events_url":"https://api.github.com/users/christopherleckie/events{/privacy}","received_events_url":"https://api.github.com/users/christopherleckie/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-31T20:07:52Z","updated_at":"2018-06-01T16:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ff9ac22c5026931790fc7e6aeb5d2f6b100d96a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BillyH80","id":16493866,"node_id":"MDQ6VXNlcjE2NDkzODY2","avatar_url":"https://avatars0.githubusercontent.com/u/16493866?v=4","gravatar_id":"","url":"https://api.github.com/users/BillyH80","html_url":"https://github.com/BillyH80","followers_url":"https://api.github.com/users/BillyH80/followers","following_url":"https://api.github.com/users/BillyH80/following{/other_user}","gists_url":"https://api.github.com/users/BillyH80/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyH80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyH80/subscriptions","organizations_url":"https://api.github.com/users/BillyH80/orgs","repos_url":"https://api.github.com/users/BillyH80/repos","events_url":"https://api.github.com/users/BillyH80/events{/privacy}","received_events_url":"https://api.github.com/users/BillyH80/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194/commits","review_comments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194/comments","review_comment_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/194/comments","statuses_url":"https://api.github.com/repos/dreamhost/dreamhost.css/statuses/970e0b0af1476470eef17be34f1cab62ca2eb715","head":{"label":"dreamhost:dh-pageheader","ref":"dh-pageheader","sha":"970e0b0af1476470eef17be34f1cab62ca2eb715","user":{"login":"dreamhost","id":1339138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzkxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1339138?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamhost","html_url":"https://github.com/dreamhost","followers_url":"https://api.github.com/users/dreamhost/followers","following_url":"https://api.github.com/users/dreamhost/following{/other_user}","gists_url":"https://api.github.com/users/dreamhost/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamhost/subscriptions","organizations_url":"https://api.github.com/users/dreamhost/orgs","repos_url":"https://api.github.com/users/dreamhost/repos","events_url":"https://api.github.com/users/dreamhost/events{/privacy}","received_events_url":"https://api.github.com/users/dreamhost/received_events","type":"Organization","site_admin":false},"repo":{"id":73852475,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg1MjQ3NQ==","name":"dreamhost.css","full_name":"dreamhost/dreamhost.css","owner":{"login":"dreamhost","id":1339138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzkxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1339138?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamhost","html_url":"https://github.com/dreamhost","followers_url":"https://api.github.com/users/dreamhost/followers","following_url":"https://api.github.com/users/dreamhost/following{/other_user}","gists_url":"https://api.github.com/users/dreamhost/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamhost/subscriptions","organizations_url":"https://api.github.com/users/dreamhost/orgs","repos_url":"https://api.github.com/users/dreamhost/repos","events_url":"https://api.github.com/users/dreamhost/events{/privacy}","received_events_url":"https://api.github.com/users/dreamhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dreamhost/dreamhost.css","description":null,"fork":false,"url":"https://api.github.com/repos/dreamhost/dreamhost.css","forks_url":"https://api.github.com/repos/dreamhost/dreamhost.css/forks","keys_url":"https://api.github.com/repos/dreamhost/dreamhost.css/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dreamhost/dreamhost.css/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dreamhost/dreamhost.css/teams","hooks_url":"https://api.github.com/repos/dreamhost/dreamhost.css/hooks","issue_events_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/events{/number}","events_url":"https://api.github.com/repos/dreamhost/dreamhost.css/events","assignees_url":"https://api.github.com/repos/dreamhost/dreamhost.css/assignees{/user}","branches_url":"https://api.github.com/repos/dreamhost/dreamhost.css/branches{/branch}","tags_url":"https://api.github.com/repos/dreamhost/dreamhost.css/tags","blobs_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/refs{/sha}","trees_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dreamhost/dreamhost.css/statuses/{sha}","languages_url":"https://api.github.com/repos/dreamhost/dreamhost.css/languages","stargazers_url":"https://api.github.com/repos/dreamhost/dreamhost.css/stargazers","contributors_url":"https://api.github.com/repos/dreamhost/dreamhost.css/contributors","subscribers_url":"https://api.github.com/repos/dreamhost/dreamhost.css/subscribers","subscription_url":"https://api.github.com/repos/dreamhost/dreamhost.css/subscription","commits_url":"https://api.github.com/repos/dreamhost/dreamhost.css/commits{/sha}","git_commits_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/commits{/sha}","comments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/comments{/number}","issue_comment_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/comments{/number}","contents_url":"https://api.github.com/repos/dreamhost/dreamhost.css/contents/{+path}","compare_url":"https://api.github.com/repos/dreamhost/dreamhost.css/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dreamhost/dreamhost.css/merges","archive_url":"https://api.github.com/repos/dreamhost/dreamhost.css/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dreamhost/dreamhost.css/downloads","issues_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues{/number}","pulls_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls{/number}","milestones_url":"https://api.github.com/repos/dreamhost/dreamhost.css/milestones{/number}","notifications_url":"https://api.github.com/repos/dreamhost/dreamhost.css/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dreamhost/dreamhost.css/labels{/name}","releases_url":"https://api.github.com/repos/dreamhost/dreamhost.css/releases{/id}","deployments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/deployments","created_at":"2016-11-15T20:29:17Z","updated_at":"2018-05-31T23:17:31Z","pushed_at":"2018-05-31T23:20:31Z","git_url":"git://github.com/dreamhost/dreamhost.css.git","ssh_url":"git@github.com:dreamhost/dreamhost.css.git","clone_url":"https://github.com/dreamhost/dreamhost.css.git","svn_url":"https://github.com/dreamhost/dreamhost.css","homepage":"http://dreamhost.design","size":7901,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"dreamhost:master","ref":"master","sha":"4bd2a67861c57784a215f082f9363c147b2b87d2","user":{"login":"dreamhost","id":1339138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzkxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1339138?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamhost","html_url":"https://github.com/dreamhost","followers_url":"https://api.github.com/users/dreamhost/followers","following_url":"https://api.github.com/users/dreamhost/following{/other_user}","gists_url":"https://api.github.com/users/dreamhost/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamhost/subscriptions","organizations_url":"https://api.github.com/users/dreamhost/orgs","repos_url":"https://api.github.com/users/dreamhost/repos","events_url":"https://api.github.com/users/dreamhost/events{/privacy}","received_events_url":"https://api.github.com/users/dreamhost/received_events","type":"Organization","site_admin":false},"repo":{"id":73852475,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg1MjQ3NQ==","name":"dreamhost.css","full_name":"dreamhost/dreamhost.css","owner":{"login":"dreamhost","id":1339138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzkxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1339138?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamhost","html_url":"https://github.com/dreamhost","followers_url":"https://api.github.com/users/dreamhost/followers","following_url":"https://api.github.com/users/dreamhost/following{/other_user}","gists_url":"https://api.github.com/users/dreamhost/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamhost/subscriptions","organizations_url":"https://api.github.com/users/dreamhost/orgs","repos_url":"https://api.github.com/users/dreamhost/repos","events_url":"https://api.github.com/users/dreamhost/events{/privacy}","received_events_url":"https://api.github.com/users/dreamhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dreamhost/dreamhost.css","description":null,"fork":false,"url":"https://api.github.com/repos/dreamhost/dreamhost.css","forks_url":"https://api.github.com/repos/dreamhost/dreamhost.css/forks","keys_url":"https://api.github.com/repos/dreamhost/dreamhost.css/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dreamhost/dreamhost.css/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dreamhost/dreamhost.css/teams","hooks_url":"https://api.github.com/repos/dreamhost/dreamhost.css/hooks","issue_events_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/events{/number}","events_url":"https://api.github.com/repos/dreamhost/dreamhost.css/events","assignees_url":"https://api.github.com/repos/dreamhost/dreamhost.css/assignees{/user}","branches_url":"https://api.github.com/repos/dreamhost/dreamhost.css/branches{/branch}","tags_url":"https://api.github.com/repos/dreamhost/dreamhost.css/tags","blobs_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/refs{/sha}","trees_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dreamhost/dreamhost.css/statuses/{sha}","languages_url":"https://api.github.com/repos/dreamhost/dreamhost.css/languages","stargazers_url":"https://api.github.com/repos/dreamhost/dreamhost.css/stargazers","contributors_url":"https://api.github.com/repos/dreamhost/dreamhost.css/contributors","subscribers_url":"https://api.github.com/repos/dreamhost/dreamhost.css/subscribers","subscription_url":"https://api.github.com/repos/dreamhost/dreamhost.css/subscription","commits_url":"https://api.github.com/repos/dreamhost/dreamhost.css/commits{/sha}","git_commits_url":"https://api.github.com/repos/dreamhost/dreamhost.css/git/commits{/sha}","comments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/comments{/number}","issue_comment_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/comments{/number}","contents_url":"https://api.github.com/repos/dreamhost/dreamhost.css/contents/{+path}","compare_url":"https://api.github.com/repos/dreamhost/dreamhost.css/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dreamhost/dreamhost.css/merges","archive_url":"https://api.github.com/repos/dreamhost/dreamhost.css/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dreamhost/dreamhost.css/downloads","issues_url":"https://api.github.com/repos/dreamhost/dreamhost.css/issues{/number}","pulls_url":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls{/number}","milestones_url":"https://api.github.com/repos/dreamhost/dreamhost.css/milestones{/number}","notifications_url":"https://api.github.com/repos/dreamhost/dreamhost.css/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dreamhost/dreamhost.css/labels{/name}","releases_url":"https://api.github.com/repos/dreamhost/dreamhost.css/releases{/id}","deployments_url":"https://api.github.com/repos/dreamhost/dreamhost.css/deployments","created_at":"2016-11-15T20:29:17Z","updated_at":"2018-05-31T23:17:31Z","pushed_at":"2018-05-31T23:20:31Z","git_url":"git://github.com/dreamhost/dreamhost.css.git","ssh_url":"git@github.com:dreamhost/dreamhost.css.git","clone_url":"https://github.com/dreamhost/dreamhost.css.git","svn_url":"https://github.com/dreamhost/dreamhost.css","homepage":"http://dreamhost.design","size":7901,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194"},"html":{"href":"https://github.com/dreamhost/dreamhost.css/pull/194"},"issue":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/194"},"comments":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/dreamhost/dreamhost.css/statuses/970e0b0af1476470eef17be34f1cab62ca2eb715"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sfowles"}}