{"action":"created","issue":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1020","repository_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1020/labels{/name}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1020/comments","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1020/events","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1020","id":350271456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTYxOTQ0","number":1020,"title":"hv: treewide: fix 'Shifting value too far'","user":{"login":"shiqingg","id":25377381,"node_id":"MDQ6VXNlcjI1Mzc3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/25377381?v=4","gravatar_id":"","url":"https://api.github.com/users/shiqingg","html_url":"https://github.com/shiqingg","followers_url":"https://api.github.com/users/shiqingg/followers","following_url":"https://api.github.com/users/shiqingg/following{/other_user}","gists_url":"https://api.github.com/users/shiqingg/gists{/gist_id}","starred_url":"https://api.github.com/users/shiqingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiqingg/subscriptions","organizations_url":"https://api.github.com/users/shiqingg/orgs","repos_url":"https://api.github.com/users/shiqingg/repos","events_url":"https://api.github.com/users/shiqingg/events{/privacy}","received_events_url":"https://api.github.com/users/shiqingg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-14T03:51:11Z","updated_at":"2018-08-14T05:05:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1020","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1020","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1020.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1020.patch"},"body":"MISRA-C requires that shift operation cannot exceed the word length.\r\n\r\nWhat this patch does:\r\n- Add the pre condition for 'init_lapic' regarding to 'pcpu_id'\r\n  Currently, max 8 physical cpus are supported.\r\n  Re-design will be required if we would like to support more physical\r\n   cpus.\r\n  So, add the pre condition here to avoid the unintentional shift\r\n   operation mistakes.\r\n\r\n- Replace the id type with uint8_t in 'vlapic_build_id'\r\n  - For VM0, it uses 'lapic_id' as its id, which is uint8_t.\r\n  - For non VM0, it uses 'vcpu_id' as its id, which is uint16_t.\r\n    Cast this id to uint8_t to make sure there is no loss of data after\r\n     left shifting 24U.\r\n\r\nSigned-off-by: Shiqing Gao <shiqing.gao@intel.com>\r\nAcked-by: Eddie Dong <eddie.dong@intel.com>"},"comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments/412755666","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1020#issuecomment-412755666","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1020","id":412755666,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc1NTY2Ng==","user":{"login":"lijinxia","id":25069444,"node_id":"MDQ6VXNlcjI1MDY5NDQ0","avatar_url":"https://avatars1.githubusercontent.com/u/25069444?v=4","gravatar_id":"","url":"https://api.github.com/users/lijinxia","html_url":"https://github.com/lijinxia","followers_url":"https://api.github.com/users/lijinxia/followers","following_url":"https://api.github.com/users/lijinxia/following{/other_user}","gists_url":"https://api.github.com/users/lijinxia/gists{/gist_id}","starred_url":"https://api.github.com/users/lijinxia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lijinxia/subscriptions","organizations_url":"https://api.github.com/users/lijinxia/orgs","repos_url":"https://api.github.com/users/lijinxia/repos","events_url":"https://api.github.com/users/lijinxia/events{/privacy}","received_events_url":"https://api.github.com/users/lijinxia/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T05:05:37Z","updated_at":"2018-08-14T05:05:37Z","author_association":"CONTRIBUTOR","body":"Verified+1"}}
{"actor":{"display_login":"lijinxia"}}