{"action":"created","comment":{"url":"https://api.github.com/repos/heetch/regula/pulls/comments/239168829","pull_request_review_id":181887128,"id":239168829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTE2ODgyOQ==","diff_hunk":"@@ -55,7 +63,46 @@ func (s *RulesetService) List(ctx context.Context, prefix string, limit int, con\n \n \toptions = append(options, clientv3.WithLimit(int64(limit)))\n \n-\tresp, err := s.Client.KV.Get(ctx, s.rulesetsPath(key, \"\"), options...)\n+\tif pathsOnly {\n+\t\treturn s.listPaths(ctx, key, prefix, limit, options)\n+\t}\n+\treturn s.listRulesets(ctx, key, prefix, limit, options)\n+}\n+\n+func (s *RulesetService) listPaths(ctx context.Context, key, prefix string, limit int, opts []clientv3.OpOption) (*store.RulesetEntries, error) {","path":"store/etcd/rulesets.go","position":62,"original_position":48,"commit_id":"185bffe391094e2cb739f705d664413d0e9e6786","original_commit_id":"48661afc1fb6f066310e21956b60470d01c897fd","user":{"login":"asdine","id":2102036,"node_id":"MDQ6VXNlcjIxMDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2102036?v=4","gravatar_id":"","url":"https://api.github.com/users/asdine","html_url":"https://github.com/asdine","followers_url":"https://api.github.com/users/asdine/followers","following_url":"https://api.github.com/users/asdine/following{/other_user}","gists_url":"https://api.github.com/users/asdine/gists{/gist_id}","starred_url":"https://api.github.com/users/asdine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdine/subscriptions","organizations_url":"https://api.github.com/users/asdine/orgs","repos_url":"https://api.github.com/users/asdine/repos","events_url":"https://api.github.com/users/asdine/events{/privacy}","received_events_url":"https://api.github.com/users/asdine/received_events","type":"User","site_admin":false},"body":"Nevermind, it's not worth it because of the `continue` token. Removing it would remove a lot of code from the `listRulesets` method which makes it not interesting anymore to factorize","created_at":"2018-12-05T17:45:29Z","updated_at":"2018-12-05T17:45:30Z","html_url":"https://github.com/heetch/regula/pull/43#discussion_r239168829","pull_request_url":"https://api.github.com/repos/heetch/regula/pulls/43","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heetch/regula/pulls/comments/239168829"},"html":{"href":"https://github.com/heetch/regula/pull/43#discussion_r239168829"},"pull_request":{"href":"https://api.github.com/repos/heetch/regula/pulls/43"}},"in_reply_to_id":239128616},"pull_request":{"url":"https://api.github.com/repos/heetch/regula/pulls/43","id":232686335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjg2MzM1","html_url":"https://github.com/heetch/regula/pull/43","diff_url":"https://github.com/heetch/regula/pull/43.diff","patch_url":"https://github.com/heetch/regula/pull/43.patch","issue_url":"https://api.github.com/repos/heetch/regula/issues/43","number":43,"state":"open","locked":false,"title":"Add paths parameter to listing endpoint","user":{"login":"YassineE","id":4570448,"node_id":"MDQ6VXNlcjQ1NzA0NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4570448?v=4","gravatar_id":"","url":"https://api.github.com/users/YassineE","html_url":"https://github.com/YassineE","followers_url":"https://api.github.com/users/YassineE/followers","following_url":"https://api.github.com/users/YassineE/following{/other_user}","gists_url":"https://api.github.com/users/YassineE/gists{/gist_id}","starred_url":"https://api.github.com/users/YassineE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YassineE/subscriptions","organizations_url":"https://api.github.com/users/YassineE/orgs","repos_url":"https://api.github.com/users/YassineE/repos","events_url":"https://api.github.com/users/YassineE/events{/privacy}","received_events_url":"https://api.github.com/users/YassineE/received_events","type":"User","site_admin":false},"body":"Fix #22 ","created_at":"2018-11-21T14:37:00Z","updated_at":"2018-12-05T17:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0fb06a78848060153537bf048797227240e17e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1121710918,"node_id":"MDU6TGFiZWwxMTIxNzEwOTE4","url":"https://api.github.com/repos/heetch/regula/labels/api","name":"api","color":"f97a93","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/heetch/regula/pulls/43/commits","review_comments_url":"https://api.github.com/repos/heetch/regula/pulls/43/comments","review_comment_url":"https://api.github.com/repos/heetch/regula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heetch/regula/issues/43/comments","statuses_url":"https://api.github.com/repos/heetch/regula/statuses/185bffe391094e2cb739f705d664413d0e9e6786","head":{"label":"heetch:issue-22","ref":"issue-22","sha":"185bffe391094e2cb739f705d664413d0e9e6786","user":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"repo":{"id":144961806,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5NjE4MDY=","name":"regula","full_name":"heetch/regula","private":false,"owner":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heetch/regula","description":"Business Rules Engine","fork":false,"url":"https://api.github.com/repos/heetch/regula","forks_url":"https://api.github.com/repos/heetch/regula/forks","keys_url":"https://api.github.com/repos/heetch/regula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heetch/regula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heetch/regula/teams","hooks_url":"https://api.github.com/repos/heetch/regula/hooks","issue_events_url":"https://api.github.com/repos/heetch/regula/issues/events{/number}","events_url":"https://api.github.com/repos/heetch/regula/events","assignees_url":"https://api.github.com/repos/heetch/regula/assignees{/user}","branches_url":"https://api.github.com/repos/heetch/regula/branches{/branch}","tags_url":"https://api.github.com/repos/heetch/regula/tags","blobs_url":"https://api.github.com/repos/heetch/regula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heetch/regula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heetch/regula/git/refs{/sha}","trees_url":"https://api.github.com/repos/heetch/regula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heetch/regula/statuses/{sha}","languages_url":"https://api.github.com/repos/heetch/regula/languages","stargazers_url":"https://api.github.com/repos/heetch/regula/stargazers","contributors_url":"https://api.github.com/repos/heetch/regula/contributors","subscribers_url":"https://api.github.com/repos/heetch/regula/subscribers","subscription_url":"https://api.github.com/repos/heetch/regula/subscription","commits_url":"https://api.github.com/repos/heetch/regula/commits{/sha}","git_commits_url":"https://api.github.com/repos/heetch/regula/git/commits{/sha}","comments_url":"https://api.github.com/repos/heetch/regula/comments{/number}","issue_comment_url":"https://api.github.com/repos/heetch/regula/issues/comments{/number}","contents_url":"https://api.github.com/repos/heetch/regula/contents/{+path}","compare_url":"https://api.github.com/repos/heetch/regula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heetch/regula/merges","archive_url":"https://api.github.com/repos/heetch/regula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heetch/regula/downloads","issues_url":"https://api.github.com/repos/heetch/regula/issues{/number}","pulls_url":"https://api.github.com/repos/heetch/regula/pulls{/number}","milestones_url":"https://api.github.com/repos/heetch/regula/milestones{/number}","notifications_url":"https://api.github.com/repos/heetch/regula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heetch/regula/labels{/name}","releases_url":"https://api.github.com/repos/heetch/regula/releases{/id}","deployments_url":"https://api.github.com/repos/heetch/regula/deployments","created_at":"2018-08-16T08:47:05Z","updated_at":"2018-12-04T14:18:52Z","pushed_at":"2018-12-05T16:52:59Z","git_url":"git://github.com/heetch/regula.git","ssh_url":"git@github.com:heetch/regula.git","clone_url":"https://github.com/heetch/regula.git","svn_url":"https://github.com/heetch/regula","homepage":"https://regula.readthedocs.io/en/latest/","size":662,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":16,"default_branch":"master"}},"base":{"label":"heetch:release-v0.6.0","ref":"release-v0.6.0","sha":"1c023123b0e97994c4ebd1db42f18b4c0a7d104c","user":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"repo":{"id":144961806,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5NjE4MDY=","name":"regula","full_name":"heetch/regula","private":false,"owner":{"login":"heetch","id":5992314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTIzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5992314?v=4","gravatar_id":"","url":"https://api.github.com/users/heetch","html_url":"https://github.com/heetch","followers_url":"https://api.github.com/users/heetch/followers","following_url":"https://api.github.com/users/heetch/following{/other_user}","gists_url":"https://api.github.com/users/heetch/gists{/gist_id}","starred_url":"https://api.github.com/users/heetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heetch/subscriptions","organizations_url":"https://api.github.com/users/heetch/orgs","repos_url":"https://api.github.com/users/heetch/repos","events_url":"https://api.github.com/users/heetch/events{/privacy}","received_events_url":"https://api.github.com/users/heetch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heetch/regula","description":"Business Rules Engine","fork":false,"url":"https://api.github.com/repos/heetch/regula","forks_url":"https://api.github.com/repos/heetch/regula/forks","keys_url":"https://api.github.com/repos/heetch/regula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heetch/regula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heetch/regula/teams","hooks_url":"https://api.github.com/repos/heetch/regula/hooks","issue_events_url":"https://api.github.com/repos/heetch/regula/issues/events{/number}","events_url":"https://api.github.com/repos/heetch/regula/events","assignees_url":"https://api.github.com/repos/heetch/regula/assignees{/user}","branches_url":"https://api.github.com/repos/heetch/regula/branches{/branch}","tags_url":"https://api.github.com/repos/heetch/regula/tags","blobs_url":"https://api.github.com/repos/heetch/regula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heetch/regula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heetch/regula/git/refs{/sha}","trees_url":"https://api.github.com/repos/heetch/regula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heetch/regula/statuses/{sha}","languages_url":"https://api.github.com/repos/heetch/regula/languages","stargazers_url":"https://api.github.com/repos/heetch/regula/stargazers","contributors_url":"https://api.github.com/repos/heetch/regula/contributors","subscribers_url":"https://api.github.com/repos/heetch/regula/subscribers","subscription_url":"https://api.github.com/repos/heetch/regula/subscription","commits_url":"https://api.github.com/repos/heetch/regula/commits{/sha}","git_commits_url":"https://api.github.com/repos/heetch/regula/git/commits{/sha}","comments_url":"https://api.github.com/repos/heetch/regula/comments{/number}","issue_comment_url":"https://api.github.com/repos/heetch/regula/issues/comments{/number}","contents_url":"https://api.github.com/repos/heetch/regula/contents/{+path}","compare_url":"https://api.github.com/repos/heetch/regula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heetch/regula/merges","archive_url":"https://api.github.com/repos/heetch/regula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heetch/regula/downloads","issues_url":"https://api.github.com/repos/heetch/regula/issues{/number}","pulls_url":"https://api.github.com/repos/heetch/regula/pulls{/number}","milestones_url":"https://api.github.com/repos/heetch/regula/milestones{/number}","notifications_url":"https://api.github.com/repos/heetch/regula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heetch/regula/labels{/name}","releases_url":"https://api.github.com/repos/heetch/regula/releases{/id}","deployments_url":"https://api.github.com/repos/heetch/regula/deployments","created_at":"2018-08-16T08:47:05Z","updated_at":"2018-12-04T14:18:52Z","pushed_at":"2018-12-05T16:52:59Z","git_url":"git://github.com/heetch/regula.git","ssh_url":"git@github.com:heetch/regula.git","clone_url":"https://github.com/heetch/regula.git","svn_url":"https://github.com/heetch/regula","homepage":"https://regula.readthedocs.io/en/latest/","size":662,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heetch/regula/pulls/43"},"html":{"href":"https://github.com/heetch/regula/pull/43"},"issue":{"href":"https://api.github.com/repos/heetch/regula/issues/43"},"comments":{"href":"https://api.github.com/repos/heetch/regula/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/heetch/regula/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/heetch/regula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heetch/regula/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/heetch/regula/statuses/185bffe391094e2cb739f705d664413d0e9e6786"}},"author_association":"NONE"}}
{"actor":{"display_login":"asdine"}}