{"action":"created","issue":{"url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/918","repository_url":"https://api.github.com/repos/JoshClose/CsvHelper","labels_url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/918/labels{/name}","comments_url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/918/comments","events_url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/918/events","html_url":"https://github.com/JoshClose/CsvHelper/issues/918","id":295942767,"node_id":"MDU6SXNzdWUyOTU5NDI3Njc=","number":918,"title":"Change delimiter to use culture specific list separator","user":{"login":"JoshClose","id":114971,"node_id":"MDQ6VXNlcjExNDk3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/114971?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshClose","html_url":"https://github.com/JoshClose","followers_url":"https://api.github.com/users/JoshClose/followers","following_url":"https://api.github.com/users/JoshClose/following{/other_user}","gists_url":"https://api.github.com/users/JoshClose/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshClose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshClose/subscriptions","organizations_url":"https://api.github.com/users/JoshClose/orgs","repos_url":"https://api.github.com/users/JoshClose/repos","events_url":"https://api.github.com/users/JoshClose/events{/privacy}","received_events_url":"https://api.github.com/users/JoshClose/received_events","type":"User","site_admin":false},"labels":[{"id":28497476,"node_id":"MDU6TGFiZWwyODQ5NzQ3Ng==","url":"https://api.github.com/repos/JoshClose/CsvHelper/labels/feature","name":"feature","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-09T17:08:48Z","updated_at":"2018-07-13T04:44:35Z","closed_at":null,"author_association":"OWNER","body":"This may need to be switched to use `CultureInfo.CurrentCulture.TextInfo.ListSeparator` by default. This library should just work out of the box, but doesn't for some cultures.\r\n\r\nAll unit tests would need to specifically set the delimiter to work in other cultures, or the delimiter being written would have to change to `CultureInfo.CurrentCulture.TextInfo.ListSeparator`. The former is probably easier.\r\n\r\n#610 "},"comment":{"url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/comments/404724057","html_url":"https://github.com/JoshClose/CsvHelper/issues/918#issuecomment-404724057","issue_url":"https://api.github.com/repos/JoshClose/CsvHelper/issues/918","id":404724057,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDcyNDA1Nw==","user":{"login":"jamesdoran","id":1106150,"node_id":"MDQ6VXNlcjExMDYxNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1106150?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesdoran","html_url":"https://github.com/jamesdoran","followers_url":"https://api.github.com/users/jamesdoran/followers","following_url":"https://api.github.com/users/jamesdoran/following{/other_user}","gists_url":"https://api.github.com/users/jamesdoran/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesdoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesdoran/subscriptions","organizations_url":"https://api.github.com/users/jamesdoran/orgs","repos_url":"https://api.github.com/users/jamesdoran/repos","events_url":"https://api.github.com/users/jamesdoran/events{/privacy}","received_events_url":"https://api.github.com/users/jamesdoran/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T04:44:35Z","updated_at":"2018-07-13T04:44:35Z","author_association":"NONE","body":"Hi @JoshClose,\r\n\r\nThanks for all your hard work on this library, it's made my life a lot easier. \r\n\r\nI just ran into this same issue when doing some testing for using our tool in Sweden. When saving a spreadsheet from Excel running in Sweden region, a semi-colon is used instead of a comma for separation:\r\n\r\nx;y;z\r\n-31,92224;138,587384;10\r\n-32,93503;137,587384;10\r\n-33,92224;136,5936658;10\r\n\r\nWhen I then try and read this in to the tool, the commas used for decimal places deserialise just fine, but it's not happy with the semi-colon. I was able to fix with the following line (thanks to your suggestion):\r\n\r\n`reader.Configuration.Delimiter = CultureInfo.CurrentCulture.TextInfo.ListSeparator;`\r\n\r\nJames"}}
{"actor":{"display_login":"jamesdoran"}}