{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4198","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4198/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4198/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4198/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4198","id":335082501,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODkwNzA4","number":4198,"title":"Reprioritize icons and images for GTLs, prefer images first","user":{"login":"skateman","id":649130,"node_id":"MDQ6VXNlcjY0OTEzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"labels":[{"id":736077188,"node_id":"MDU6TGFiZWw3MzYwNzcxODg=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false},{"id":525833075,"node_id":"MDU6TGFiZWw1MjU4MzMwNzU=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/graphics","name":"graphics","color":"d4c5f9","default":false},{"id":535030860,"node_id":"MDU6TGFiZWw1MzUwMzA4NjA=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gtls","name":"gtls","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-23T08:49:47Z","updated_at":"2018-06-24T21:44:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4198","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4198","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4198.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4198.patch"},"body":"When both a `fonticon` and a `fileicon` is defined for an item, the preferred one was the `fonticon`, except of some special cases when there's a `picture` attribute available. This was unnecessarily complicated and as all the unnecessary PNG files and their references [have been removed](https://github.com/ManageIQ/manageiq-ui-classic/issues/4051), we can simplify this a little.\r\n\r\nSo I'm proposing the same preference as we have for treeviews: `fileicon` over `fonticon` and also dropping the `picture` attribute. \r\n\r\nUI components PR: https://github.com/ManageIQ/ui-components/pull/308\r\n\r\n@miq-bot add_reviewer @epwinchell \r\n@miq-bot add_reviewer @karelhala \r\n@miq-bot add_reviewer @martinpovolny \r\n@miq-bot add_labels gaprindashvili/no, GTLs, graphics"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/399789899","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4198#issuecomment-399789899","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4198","id":399789899,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTc4OTg5OQ==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-24T21:44:44Z","updated_at":"2018-06-24T21:44:44Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/skateman/manageiq-ui-classic/compare/a380d666c1ce1c1533a2d2ca5a080792559fb19f~...499692b085e476b9d445920795be54652c74e734 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n3 files checked, 0 offenses detected\nEverything looks fine. :star:\n"}}
{"actor":{"display_login":"miq-bot"}}