{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/218346619","pull_request_review_id":156261700,"id":218346619,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM0NjYxOQ==","diff_hunk":"@@ -0,0 +1,74 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\Validator\\Tests\\Constraints;\n+\n+use Symfony\\Component\\Validator\\Constraints\\Json;\n+use Symfony\\Component\\Validator\\Constraints\\JsonValidator;\n+use Symfony\\Component\\Validator\\Test\\ConstraintValidatorTestCase;\n+\n+class JsonValidatorTest extends ConstraintValidatorTestCase\n+{\n+    protected function createValidator()\n+    {\n+        return new JsonValidator();\n+    }\n+\n+    public function testJsonIsValid()\n+    {\n+        $this->validator->validate(","path":"src/Symfony/Component/Validator/Tests/Constraints/JsonValidatorTest.php","position":27,"original_position":27,"commit_id":"b061fcfea6dbe35306e1c8977b614a5bef178428","original_commit_id":"b061fcfea6dbe35306e1c8977b614a5bef178428","user":{"login":"zairigimad","id":9056839,"node_id":"MDQ6VXNlcjkwNTY4Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/9056839?v=4","gravatar_id":"","url":"https://api.github.com/users/zairigimad","html_url":"https://github.com/zairigimad","followers_url":"https://api.github.com/users/zairigimad/followers","following_url":"https://api.github.com/users/zairigimad/following{/other_user}","gists_url":"https://api.github.com/users/zairigimad/gists{/gist_id}","starred_url":"https://api.github.com/users/zairigimad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zairigimad/subscriptions","organizations_url":"https://api.github.com/users/zairigimad/orgs","repos_url":"https://api.github.com/users/zairigimad/repos","events_url":"https://api.github.com/users/zairigimad/events{/privacy}","received_events_url":"https://api.github.com/users/zairigimad/received_events","type":"User","site_admin":false},"body":"yes, there are two other assertions with, `testNullIsValid()` and `testEmptyStringIsValid` , i'm going to add the other cases in  `getInvalidValues`.","created_at":"2018-09-18T08:47:27Z","updated_at":"2018-09-18T08:47:28Z","html_url":"https://github.com/symfony/symfony/pull/28477#discussion_r218346619","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28477","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/218346619"},"html":{"href":"https://github.com/symfony/symfony/pull/28477#discussion_r218346619"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28477"}},"in_reply_to_id":218342444},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28477","id":215794178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzk0MTc4","html_url":"https://github.com/symfony/symfony/pull/28477","diff_url":"https://github.com/symfony/symfony/pull/28477.diff","patch_url":"https://github.com/symfony/symfony/pull/28477.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28477","number":28477,"state":"open","locked":false,"title":"Add new json Validator","user":{"login":"zairigimad","id":9056839,"node_id":"MDQ6VXNlcjkwNTY4Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/9056839?v=4","gravatar_id":"","url":"https://api.github.com/users/zairigimad","html_url":"https://github.com/zairigimad","followers_url":"https://api.github.com/users/zairigimad/followers","following_url":"https://api.github.com/users/zairigimad/following{/other_user}","gists_url":"https://api.github.com/users/zairigimad/gists{/gist_id}","starred_url":"https://api.github.com/users/zairigimad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zairigimad/subscriptions","organizations_url":"https://api.github.com/users/zairigimad/orgs","repos_url":"https://api.github.com/users/zairigimad/repos","events_url":"https://api.github.com/users/zairigimad/events{/privacy}","received_events_url":"https://api.github.com/users/zairigimad/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no  \r\n| Deprecations? | no\r\n| Tests pass?   | yes \r\n| License       | MIT\r\n| Doc PR        | https://github.com/symfony/symfony-docs/pull/10351\r\n\r\nHi,\r\n\r\nin so many cases we want to test if a value is a valid json or not, so I propose this new NotJson constraint for this need.\r\n\r\ncordially,","created_at":"2018-09-15T23:21:39Z","updated_at":"2018-09-18T08:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b655c07ce15768d9344721e98638a2d060d9a1c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":238909857,"node_id":"MDU6TGFiZWwyMzg5MDk4NTc=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Work","name":"Status: Needs Work","color":"fad8c7","default":false},{"id":99599,"node_id":"MDU6TGFiZWw5OTU5OQ==","url":"https://api.github.com/repos/symfony/symfony/labels/Validator","name":"Validator","color":"DDDDDD","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":151,"closed_issues":226,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-09-17T19:37:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28477/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28477/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28477/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/b061fcfea6dbe35306e1c8977b614a5bef178428","head":{"label":"zairigimad:is-json-validator","ref":"is-json-validator","sha":"b061fcfea6dbe35306e1c8977b614a5bef178428","user":{"login":"zairigimad","id":9056839,"node_id":"MDQ6VXNlcjkwNTY4Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/9056839?v=4","gravatar_id":"","url":"https://api.github.com/users/zairigimad","html_url":"https://github.com/zairigimad","followers_url":"https://api.github.com/users/zairigimad/followers","following_url":"https://api.github.com/users/zairigimad/following{/other_user}","gists_url":"https://api.github.com/users/zairigimad/gists{/gist_id}","starred_url":"https://api.github.com/users/zairigimad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zairigimad/subscriptions","organizations_url":"https://api.github.com/users/zairigimad/orgs","repos_url":"https://api.github.com/users/zairigimad/repos","events_url":"https://api.github.com/users/zairigimad/events{/privacy}","received_events_url":"https://api.github.com/users/zairigimad/received_events","type":"User","site_admin":false},"repo":{"id":148946507,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5NDY1MDc=","name":"symfony","full_name":"zairigimad/symfony","private":false,"owner":{"login":"zairigimad","id":9056839,"node_id":"MDQ6VXNlcjkwNTY4Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/9056839?v=4","gravatar_id":"","url":"https://api.github.com/users/zairigimad","html_url":"https://github.com/zairigimad","followers_url":"https://api.github.com/users/zairigimad/followers","following_url":"https://api.github.com/users/zairigimad/following{/other_user}","gists_url":"https://api.github.com/users/zairigimad/gists{/gist_id}","starred_url":"https://api.github.com/users/zairigimad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zairigimad/subscriptions","organizations_url":"https://api.github.com/users/zairigimad/orgs","repos_url":"https://api.github.com/users/zairigimad/repos","events_url":"https://api.github.com/users/zairigimad/events{/privacy}","received_events_url":"https://api.github.com/users/zairigimad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zairigimad/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/zairigimad/symfony","forks_url":"https://api.github.com/repos/zairigimad/symfony/forks","keys_url":"https://api.github.com/repos/zairigimad/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zairigimad/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zairigimad/symfony/teams","hooks_url":"https://api.github.com/repos/zairigimad/symfony/hooks","issue_events_url":"https://api.github.com/repos/zairigimad/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/zairigimad/symfony/events","assignees_url":"https://api.github.com/repos/zairigimad/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/zairigimad/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/zairigimad/symfony/tags","blobs_url":"https://api.github.com/repos/zairigimad/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zairigimad/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zairigimad/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/zairigimad/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zairigimad/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/zairigimad/symfony/languages","stargazers_url":"https://api.github.com/repos/zairigimad/symfony/stargazers","contributors_url":"https://api.github.com/repos/zairigimad/symfony/contributors","subscribers_url":"https://api.github.com/repos/zairigimad/symfony/subscribers","subscription_url":"https://api.github.com/repos/zairigimad/symfony/subscription","commits_url":"https://api.github.com/repos/zairigimad/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/zairigimad/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/zairigimad/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/zairigimad/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/zairigimad/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/zairigimad/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zairigimad/symfony/merges","archive_url":"https://api.github.com/repos/zairigimad/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zairigimad/symfony/downloads","issues_url":"https://api.github.com/repos/zairigimad/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/zairigimad/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/zairigimad/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/zairigimad/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zairigimad/symfony/labels{/name}","releases_url":"https://api.github.com/repos/zairigimad/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/zairigimad/symfony/deployments","created_at":"2018-09-15T23:03:06Z","updated_at":"2018-09-15T23:03:25Z","pushed_at":"2018-09-17T18:18:10Z","git_url":"git://github.com/zairigimad/symfony.git","ssh_url":"git@github.com:zairigimad/symfony.git","clone_url":"https://github.com/zairigimad/symfony.git","svn_url":"https://github.com/zairigimad/symfony","homepage":"https://symfony.com","size":119635,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"440944f3c22ed69277a69d8b48722098413717c2","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-09-18T08:14:32Z","pushed_at":"2018-09-18T08:06:48Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":124628,"stargazers_count":18576,"watchers_count":18576,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6396,"mirror_url":null,"archived":false,"open_issues_count":920,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6396,"open_issues":920,"watchers":18576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28477"},"html":{"href":"https://github.com/symfony/symfony/pull/28477"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28477"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28477/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28477/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28477/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/b061fcfea6dbe35306e1c8977b614a5bef178428"}},"author_association":"NONE"}}
{"actor":{"display_login":"zairigimad"}}