{"action":"opened","number":376,"pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376","id":234436877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDM2ODc3","html_url":"https://github.com/reactioncommerce/reaction-component-library/pull/376","diff_url":"https://github.com/reactioncommerce/reaction-component-library/pull/376.diff","patch_url":"https://github.com/reactioncommerce/reaction-component-library/pull/376.patch","issue_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/376","number":376,"state":"open","locked":false,"title":"Test-related updates and fixes","user":{"login":"aldeed","id":3012067,"node_id":"MDQ6VXNlcjMwMTIwNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3012067?v=4","gravatar_id":"","url":"https://api.github.com/users/aldeed","html_url":"https://github.com/aldeed","followers_url":"https://api.github.com/users/aldeed/followers","following_url":"https://api.github.com/users/aldeed/following{/other_user}","gists_url":"https://api.github.com/users/aldeed/gists{/gist_id}","starred_url":"https://api.github.com/users/aldeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldeed/subscriptions","organizations_url":"https://api.github.com/users/aldeed/orgs","repos_url":"https://api.github.com/users/aldeed/repos","events_url":"https://api.github.com/users/aldeed/events{/privacy}","received_events_url":"https://api.github.com/users/aldeed/received_events","type":"User","site_admin":false},"body":"Resolves #172 \r\nResolves #211 \r\nImpact: **minor**  \r\nType: **test**\r\n\r\nVarious changes that affect only Jest tests:\r\n- We had been using forks of `react-test-renderer` and `enzyme-adapter-react-16` due to needing support for newer React APIs. The official packages now have that support, so this PR switches back to the latest official package of each.\r\n- Update to latest `composable-form-tests`. This is needed to support the above change.\r\n- Because of the above two changes, I was also able to uncomment some tests that were previously failing.\r\n- Add additional tests for `RegionInput` to prove that it properly implements the composable forms specification for input-type components.\r\n- There was a bug in `mockComponents` that caused the props in all snapshots to be `undefined`. This is fixed, which necessitated updating most snapshot files.\r\n\r\n## Testing\r\nReview code and snapshot changes. There shouldn't be much else testing needed other than ensuring that all Jest tests pass.","created_at":"2018-11-28T21:54:09Z","updated_at":"2018-11-28T21:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376/commits","review_comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376/comments","review_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/376/comments","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/936d92f58c708873a77deb36f1de536850c6c689","head":{"label":"reactioncommerce:test-aldeed-add-tests-and-fix-snaps","ref":"test-aldeed-add-tests-and-fix-snaps","sha":"936d92f58c708873a77deb36f1de536850c6c689","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":114694142,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQxNDI=","name":"reaction-component-library","full_name":"reactioncommerce/reaction-component-library","private":false,"owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactioncommerce/reaction-component-library","description":"An ecommerce-focused set of React components","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library","forks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/deployments","created_at":"2017-12-18T22:31:00Z","updated_at":"2018-11-28T18:48:42Z","pushed_at":"2018-11-28T21:49:14Z","git_url":"git://github.com/reactioncommerce/reaction-component-library.git","ssh_url":"git@github.com:reactioncommerce/reaction-component-library.git","clone_url":"https://github.com/reactioncommerce/reaction-component-library.git","svn_url":"https://github.com/reactioncommerce/reaction-component-library","homepage":"https://designsystem.reactioncommerce.com/","size":6470,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":31,"watchers":23,"default_branch":"master"}},"base":{"label":"reactioncommerce:master","ref":"master","sha":"2ab26f51536c1f32d44f18e74717975d0553b522","user":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":114694142,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQxNDI=","name":"reaction-component-library","full_name":"reactioncommerce/reaction-component-library","private":false,"owner":{"login":"reactioncommerce","id":5605462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDU0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5605462?v=4","gravatar_id":"","url":"https://api.github.com/users/reactioncommerce","html_url":"https://github.com/reactioncommerce","followers_url":"https://api.github.com/users/reactioncommerce/followers","following_url":"https://api.github.com/users/reactioncommerce/following{/other_user}","gists_url":"https://api.github.com/users/reactioncommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/reactioncommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactioncommerce/subscriptions","organizations_url":"https://api.github.com/users/reactioncommerce/orgs","repos_url":"https://api.github.com/users/reactioncommerce/repos","events_url":"https://api.github.com/users/reactioncommerce/events{/privacy}","received_events_url":"https://api.github.com/users/reactioncommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactioncommerce/reaction-component-library","description":"An ecommerce-focused set of React components","fork":false,"url":"https://api.github.com/repos/reactioncommerce/reaction-component-library","forks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/forks","keys_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/teams","hooks_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/hooks","issue_events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/events","assignees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/tags","blobs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/languages","stargazers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/stargazers","contributors_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contributors","subscribers_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscribers","subscription_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/subscription","commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/merges","archive_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/downloads","issues_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/labels{/name}","releases_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/reactioncommerce/reaction-component-library/deployments","created_at":"2017-12-18T22:31:00Z","updated_at":"2018-11-28T18:48:42Z","pushed_at":"2018-11-28T21:49:14Z","git_url":"git://github.com/reactioncommerce/reaction-component-library.git","ssh_url":"git@github.com:reactioncommerce/reaction-component-library.git","clone_url":"https://github.com/reactioncommerce/reaction-component-library.git","svn_url":"https://github.com/reactioncommerce/reaction-component-library","homepage":"https://designsystem.reactioncommerce.com/","size":6470,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":31,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376"},"html":{"href":"https://github.com/reactioncommerce/reaction-component-library/pull/376"},"issue":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/376"},"comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/reactioncommerce/reaction-component-library/statuses/936d92f58c708873a77deb36f1de536850c6c689"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":463,"deletions":2904,"changed_files":32}}
{"actor":{"display_login":"aldeed"}}