{"action":"created","issue":{"url":"https://api.github.com/repos/sigp/lighthouse/issues/111","repository_url":"https://api.github.com/repos/sigp/lighthouse","labels_url":"https://api.github.com/repos/sigp/lighthouse/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/sigp/lighthouse/issues/111/comments","events_url":"https://api.github.com/repos/sigp/lighthouse/issues/111/events","html_url":"https://github.com/sigp/lighthouse/issues/111","id":390029275,"node_id":"MDU6SXNzdWUzOTAwMjkyNzU=","number":111,"title":"Update hash function","user":{"login":"ralexstokes","id":3113781,"node_id":"MDQ6VXNlcjMxMTM3ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3113781?v=4","gravatar_id":"","url":"https://api.github.com/users/ralexstokes","html_url":"https://github.com/ralexstokes","followers_url":"https://api.github.com/users/ralexstokes/followers","following_url":"https://api.github.com/users/ralexstokes/following{/other_user}","gists_url":"https://api.github.com/users/ralexstokes/gists{/gist_id}","starred_url":"https://api.github.com/users/ralexstokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralexstokes/subscriptions","organizations_url":"https://api.github.com/users/ralexstokes/orgs","repos_url":"https://api.github.com/users/ralexstokes/repos","events_url":"https://api.github.com/users/ralexstokes/events{/privacy}","received_events_url":"https://api.github.com/users/ralexstokes/received_events","type":"User","site_admin":false},"labels":[{"id":1141293876,"node_id":"MDU6TGFiZWwxMTQxMjkzODc2","url":"https://api.github.com/repos/sigp/lighthouse/labels/work-started","name":"work-started","color":"e072ab","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-12T01:42:46Z","updated_at":"2018-12-12T06:32:01Z","closed_at":null,"author_association":"COLLABORATOR","body":"## Description\r\n\r\nThe older spec used `blake2` as the hash function. The latest spec uses `keccak256`.\r\n\r\n## Present Behaviour\r\n\r\nUses the old hash.\r\n\r\n## Expected Behaviour\r\n\r\nShould use the new hash.\r\n\r\n## Steps to resolve\r\n\r\nUse the correct hash function.\r\n\r\nI started this work on a branch and seem to be triggering a panic due to this line:\r\n\r\nhttps://github.com/sigp/signature-schemes/blob/master/src/amcl_utils.rs#L36\r\n\r\nAnd think we should just update that crate to use keccak256 as well.\r\n\r\nFigured I would open this up for discussion before making more changes.\r\n"},"comment":{"url":"https://api.github.com/repos/sigp/lighthouse/issues/comments/446478195","html_url":"https://github.com/sigp/lighthouse/issues/111#issuecomment-446478195","issue_url":"https://api.github.com/repos/sigp/lighthouse/issues/111","id":446478195,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ3ODE5NQ==","user":{"login":"ralexstokes","id":3113781,"node_id":"MDQ6VXNlcjMxMTM3ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3113781?v=4","gravatar_id":"","url":"https://api.github.com/users/ralexstokes","html_url":"https://github.com/ralexstokes","followers_url":"https://api.github.com/users/ralexstokes/followers","following_url":"https://api.github.com/users/ralexstokes/following{/other_user}","gists_url":"https://api.github.com/users/ralexstokes/gists{/gist_id}","starred_url":"https://api.github.com/users/ralexstokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralexstokes/subscriptions","organizations_url":"https://api.github.com/users/ralexstokes/orgs","repos_url":"https://api.github.com/users/ralexstokes/repos","events_url":"https://api.github.com/users/ralexstokes/events{/privacy}","received_events_url":"https://api.github.com/users/ralexstokes/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T06:32:01Z","updated_at":"2018-12-12T06:32:01Z","author_association":"COLLABORATOR","body":"I believe it has to do w/ this:\r\n\r\nhttps://github.com/sigp/lighthouse/blob/master/beacon_chain/utils/hashing/src/lib.rs#L13\r\n\r\nand pretty sure it traces to this:\r\n\r\nhttps://github.com/sigp/signature-schemes/blob/master/src/amcl_utils.rs#L36\r\n\r\nSeems like `GroupG1::map_it` expects a buffer of a certain size (which is the panic I'm seeing)...\r\n\r\nIs there a reason the buffer is this size? "}}
{"actor":{"display_login":"ralexstokes"}}