{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/176570165","pull_request_review_id":106299242,"id":176570165,"diff_hunk":"@@ -0,0 +1,80 @@\n+/*\n+ Copyright 2018-present the Material Components for iOS authors. All Rights Reserved.\n+\n+ Licensed under the Apache License, Version 2.0 (the \"License\");\n+ you may not use this file except in compliance with the License.\n+ You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+ Unless required by applicable law or agreed to in writing, software\n+ distributed under the License is distributed on an \"AS IS\" BASIS,\n+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ See the License for the specific language governing permissions and\n+ limitations under the License.\n+ */\n+\n+#import <Foundation/Foundation.h>\n+#import \"MDCColorScheme.h\"\n+\n+/**\n+ A simple color scheme that provides more semantic context for the colors it uses. Unlike\n+ @c MDCColorScheme, there are no optional properties, so more consistent theming can be applied.\n+ */\n+@protocol MDCSemanticColorScheming <MDCColorScheme>\n+\n+/**\n+ Displayed most frequently across your app.\n+ */\n+@property(nonnull, readonly, nonatomic) UIColor *primaryColor;\n+\n+/**\n+ A tonal variation of primary color.\n+ */\n+@property(nonnull, readonly, nonatomic) UIColor *primaryColorLightVariant;","path":"components/Themes/src/MDCSemanticColorScheme.h","position":34,"original_position":34,"commit_id":"f3eac5142081c41c7a5ec46552534084e39ac00c","original_commit_id":"f3eac5142081c41c7a5ec46552534084e39ac00c","user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"My understanding presently is that these properties are semantically safe as light/dark variants regardless of the theme being light or dark, but I also have not seen any literal mappings be well defined in any componentry, so the jury's out on whether that's actually the case...","created_at":"2018-03-22T20:57:55Z","updated_at":"2018-03-22T20:57:55Z","html_url":"https://github.com/material-components/material-components-ios/pull/3134#discussion_r176570165","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/176570165"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/3134#discussion_r176570165"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134"}},"in_reply_to_id":176562006},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134","id":176884735,"html_url":"https://github.com/material-components/material-components-ios/pull/3134","diff_url":"https://github.com/material-components/material-components-ios/pull/3134.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/3134.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3134","number":3134,"state":"open","locked":false,"title":"[Themes] Add new semantic color scheme","user":{"login":"romoore","id":1753199,"avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"body":"The new color scheme includes error color and drops the lighter/darker\r\nvariants of secondary color.  This implementation should be drop-in compatible\r\nfor themers and other clients currently using MDCColorScheme, except for any\r\nthird-party code that might be using secondaryLightColor or\r\nsecondaryDarkColor.\r\n","created_at":"2018-03-22T19:24:47Z","updated_at":"2018-03-22T20:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f450bd6c019a5d12bb2092435e0101007bbd1d96","assignee":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"assignees":[{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":273191333,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"1e8e3e","default":false},{"id":473892729,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/pr:Author%20will%20merge","name":"pr:Author will merge","color":"F44336","default":false},{"id":634544326,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/where:Themer","name":"where:Themer","color":"2196F3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3134/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/f3eac5142081c41c7a5ec46552534084e39ac00c","head":{"label":"romoore:new-colorscheme","ref":"new-colorscheme","sha":"f3eac5142081c41c7a5ec46552534084e39ac00c","user":{"login":"romoore","id":1753199,"avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"repo":{"id":94778276,"name":"material-components-ios","full_name":"romoore/material-components-ios","owner":{"login":"romoore","id":1753199,"avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romoore/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/romoore/material-components-ios","forks_url":"https://api.github.com/repos/romoore/material-components-ios/forks","keys_url":"https://api.github.com/repos/romoore/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romoore/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romoore/material-components-ios/teams","hooks_url":"https://api.github.com/repos/romoore/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/romoore/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/romoore/material-components-ios/events","assignees_url":"https://api.github.com/repos/romoore/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/romoore/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/romoore/material-components-ios/tags","blobs_url":"https://api.github.com/repos/romoore/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romoore/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romoore/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/romoore/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romoore/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/romoore/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/romoore/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/romoore/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/romoore/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/romoore/material-components-ios/subscription","commits_url":"https://api.github.com/repos/romoore/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/romoore/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/romoore/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/romoore/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/romoore/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/romoore/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romoore/material-components-ios/merges","archive_url":"https://api.github.com/repos/romoore/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romoore/material-components-ios/downloads","issues_url":"https://api.github.com/repos/romoore/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/romoore/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/romoore/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/romoore/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romoore/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/romoore/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/romoore/material-components-ios/deployments","created_at":"2017-06-19T13:13:50Z","updated_at":"2018-03-20T14:42:16Z","pushed_at":"2018-03-22T19:48:13Z","git_url":"git://github.com/romoore/material-components-ios.git","ssh_url":"git@github.com:romoore/material-components-ios.git","clone_url":"https://github.com/romoore/material-components-ios.git","svn_url":"https://github.com/romoore/material-components-ios","homepage":"","size":449884,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"8882cc904623b9af5d2d15f84d229b6bdb60fd97","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-03-22T20:55:25Z","pushed_at":"2018-03-22T20:55:22Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":96012,"stargazers_count":2068,"watchers_count":2068,"language":"Objective-C","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":535,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":291,"open_issues":535,"watchers":2068,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/3134"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/3134"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/3134/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/3134/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/f3eac5142081c41c7a5ec46552534084e39ac00c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jverkoey"}}