{"action":"closed","number":224,"pull_request":{"url":"https://api.github.com/repos/astralapp/astral/pulls/224","id":224557703,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTU3NzAz","html_url":"https://github.com/astralapp/astral/pull/224","diff_url":"https://github.com/astralapp/astral/pull/224.diff","patch_url":"https://github.com/astralapp/astral/pull/224.patch","issue_url":"https://api.github.com/repos/astralapp/astral/issues/224","number":224,"state":"closed","locked":false,"title":"Display total counts","user":{"login":"Williams94","id":5942117,"node_id":"MDQ6VXNlcjU5NDIxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5942117?v=4","gravatar_id":"","url":"https://api.github.com/users/Williams94","html_url":"https://github.com/Williams94","followers_url":"https://api.github.com/users/Williams94/followers","following_url":"https://api.github.com/users/Williams94/following{/other_user}","gists_url":"https://api.github.com/users/Williams94/gists{/gist_id}","starred_url":"https://api.github.com/users/Williams94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Williams94/subscriptions","organizations_url":"https://api.github.com/users/Williams94/orgs","repos_url":"https://api.github.com/users/Williams94/repos","events_url":"https://api.github.com/users/Williams94/events{/privacy}","received_events_url":"https://api.github.com/users/Williams94/received_events","type":"User","site_admin":false},"body":"Enhancement to display totals of all-stars and untagged stars.\r\n\r\nI'm not sure about passing the values `'totalCount` `totalUntagged` through with the endpoints in `GitHubStarsController.php`. Since to make the unit test pass, I had to modify `stars.json` blob which doesn't make sense to me as that blob should represent what is sent back from Github, which `totalUntagged` isn't. So maybe it would be better to make a separate API request for the numbers, which would be done in the `StarsController.php`, let me know what you think.\r\n\r\nAlso, let me know what you think of the style, I've just used the default badge styles. As well as if you think this type of enhancement adds value.\r\n\r\nIn ref to #189 ","created_at":"2018-10-21T17:53:47Z","updated_at":"2018-10-23T19:47:15Z","closed_at":"2018-10-23T19:47:15Z","merged_at":null,"merge_commit_sha":"8bd2f6640dfdc7b85ac04370ca801f7e084134f8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"syropian","id":749061,"node_id":"MDQ6VXNlcjc0OTA2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/749061?v=4","gravatar_id":"","url":"https://api.github.com/users/syropian","html_url":"https://github.com/syropian","followers_url":"https://api.github.com/users/syropian/followers","following_url":"https://api.github.com/users/syropian/following{/other_user}","gists_url":"https://api.github.com/users/syropian/gists{/gist_id}","starred_url":"https://api.github.com/users/syropian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syropian/subscriptions","organizations_url":"https://api.github.com/users/syropian/orgs","repos_url":"https://api.github.com/users/syropian/repos","events_url":"https://api.github.com/users/syropian/events{/privacy}","received_events_url":"https://api.github.com/users/syropian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astralapp/astral/pulls/224/commits","review_comments_url":"https://api.github.com/repos/astralapp/astral/pulls/224/comments","review_comment_url":"https://api.github.com/repos/astralapp/astral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astralapp/astral/issues/224/comments","statuses_url":"https://api.github.com/repos/astralapp/astral/statuses/f8752f9720bd4d5a5c725aeaf5187c13dbe011c3","head":{"label":"astralapp:display-total-counts","ref":"display-total-counts","sha":"f8752f9720bd4d5a5c725aeaf5187c13dbe011c3","user":{"login":"astralapp","id":11477125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc3MTI1","avatar_url":"https://avatars2.githubusercontent.com/u/11477125?v=4","gravatar_id":"","url":"https://api.github.com/users/astralapp","html_url":"https://github.com/astralapp","followers_url":"https://api.github.com/users/astralapp/followers","following_url":"https://api.github.com/users/astralapp/following{/other_user}","gists_url":"https://api.github.com/users/astralapp/gists{/gist_id}","starred_url":"https://api.github.com/users/astralapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralapp/subscriptions","organizations_url":"https://api.github.com/users/astralapp/orgs","repos_url":"https://api.github.com/users/astralapp/repos","events_url":"https://api.github.com/users/astralapp/events{/privacy}","received_events_url":"https://api.github.com/users/astralapp/received_events","type":"Organization","site_admin":false},"repo":{"id":32222363,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIyMjM2Mw==","name":"astral","full_name":"astralapp/astral","private":false,"owner":{"login":"astralapp","id":11477125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc3MTI1","avatar_url":"https://avatars2.githubusercontent.com/u/11477125?v=4","gravatar_id":"","url":"https://api.github.com/users/astralapp","html_url":"https://github.com/astralapp","followers_url":"https://api.github.com/users/astralapp/followers","following_url":"https://api.github.com/users/astralapp/following{/other_user}","gists_url":"https://api.github.com/users/astralapp/gists{/gist_id}","starred_url":"https://api.github.com/users/astralapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralapp/subscriptions","organizations_url":"https://api.github.com/users/astralapp/orgs","repos_url":"https://api.github.com/users/astralapp/repos","events_url":"https://api.github.com/users/astralapp/events{/privacy}","received_events_url":"https://api.github.com/users/astralapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astralapp/astral","description":"Organize Your GitHub Stars With Ease","fork":false,"url":"https://api.github.com/repos/astralapp/astral","forks_url":"https://api.github.com/repos/astralapp/astral/forks","keys_url":"https://api.github.com/repos/astralapp/astral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astralapp/astral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astralapp/astral/teams","hooks_url":"https://api.github.com/repos/astralapp/astral/hooks","issue_events_url":"https://api.github.com/repos/astralapp/astral/issues/events{/number}","events_url":"https://api.github.com/repos/astralapp/astral/events","assignees_url":"https://api.github.com/repos/astralapp/astral/assignees{/user}","branches_url":"https://api.github.com/repos/astralapp/astral/branches{/branch}","tags_url":"https://api.github.com/repos/astralapp/astral/tags","blobs_url":"https://api.github.com/repos/astralapp/astral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astralapp/astral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astralapp/astral/git/refs{/sha}","trees_url":"https://api.github.com/repos/astralapp/astral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astralapp/astral/statuses/{sha}","languages_url":"https://api.github.com/repos/astralapp/astral/languages","stargazers_url":"https://api.github.com/repos/astralapp/astral/stargazers","contributors_url":"https://api.github.com/repos/astralapp/astral/contributors","subscribers_url":"https://api.github.com/repos/astralapp/astral/subscribers","subscription_url":"https://api.github.com/repos/astralapp/astral/subscription","commits_url":"https://api.github.com/repos/astralapp/astral/commits{/sha}","git_commits_url":"https://api.github.com/repos/astralapp/astral/git/commits{/sha}","comments_url":"https://api.github.com/repos/astralapp/astral/comments{/number}","issue_comment_url":"https://api.github.com/repos/astralapp/astral/issues/comments{/number}","contents_url":"https://api.github.com/repos/astralapp/astral/contents/{+path}","compare_url":"https://api.github.com/repos/astralapp/astral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astralapp/astral/merges","archive_url":"https://api.github.com/repos/astralapp/astral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astralapp/astral/downloads","issues_url":"https://api.github.com/repos/astralapp/astral/issues{/number}","pulls_url":"https://api.github.com/repos/astralapp/astral/pulls{/number}","milestones_url":"https://api.github.com/repos/astralapp/astral/milestones{/number}","notifications_url":"https://api.github.com/repos/astralapp/astral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astralapp/astral/labels{/name}","releases_url":"https://api.github.com/repos/astralapp/astral/releases{/id}","deployments_url":"https://api.github.com/repos/astralapp/astral/deployments","created_at":"2015-03-14T16:59:41Z","updated_at":"2018-10-23T15:15:11Z","pushed_at":"2018-10-21T17:55:49Z","git_url":"git://github.com/astralapp/astral.git","ssh_url":"git@github.com:astralapp/astral.git","clone_url":"https://github.com/astralapp/astral.git","svn_url":"https://github.com/astralapp/astral","homepage":"https://astralapp.com","size":26601,"stargazers_count":1182,"watchers_count":1182,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":67,"open_issues":23,"watchers":1182,"default_branch":"master"}},"base":{"label":"astralapp:master","ref":"master","sha":"e29ebdc005357e66ebf2c013a57801da617a7015","user":{"login":"astralapp","id":11477125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc3MTI1","avatar_url":"https://avatars2.githubusercontent.com/u/11477125?v=4","gravatar_id":"","url":"https://api.github.com/users/astralapp","html_url":"https://github.com/astralapp","followers_url":"https://api.github.com/users/astralapp/followers","following_url":"https://api.github.com/users/astralapp/following{/other_user}","gists_url":"https://api.github.com/users/astralapp/gists{/gist_id}","starred_url":"https://api.github.com/users/astralapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralapp/subscriptions","organizations_url":"https://api.github.com/users/astralapp/orgs","repos_url":"https://api.github.com/users/astralapp/repos","events_url":"https://api.github.com/users/astralapp/events{/privacy}","received_events_url":"https://api.github.com/users/astralapp/received_events","type":"Organization","site_admin":false},"repo":{"id":32222363,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIyMjM2Mw==","name":"astral","full_name":"astralapp/astral","private":false,"owner":{"login":"astralapp","id":11477125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc3MTI1","avatar_url":"https://avatars2.githubusercontent.com/u/11477125?v=4","gravatar_id":"","url":"https://api.github.com/users/astralapp","html_url":"https://github.com/astralapp","followers_url":"https://api.github.com/users/astralapp/followers","following_url":"https://api.github.com/users/astralapp/following{/other_user}","gists_url":"https://api.github.com/users/astralapp/gists{/gist_id}","starred_url":"https://api.github.com/users/astralapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralapp/subscriptions","organizations_url":"https://api.github.com/users/astralapp/orgs","repos_url":"https://api.github.com/users/astralapp/repos","events_url":"https://api.github.com/users/astralapp/events{/privacy}","received_events_url":"https://api.github.com/users/astralapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astralapp/astral","description":"Organize Your GitHub Stars With Ease","fork":false,"url":"https://api.github.com/repos/astralapp/astral","forks_url":"https://api.github.com/repos/astralapp/astral/forks","keys_url":"https://api.github.com/repos/astralapp/astral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astralapp/astral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astralapp/astral/teams","hooks_url":"https://api.github.com/repos/astralapp/astral/hooks","issue_events_url":"https://api.github.com/repos/astralapp/astral/issues/events{/number}","events_url":"https://api.github.com/repos/astralapp/astral/events","assignees_url":"https://api.github.com/repos/astralapp/astral/assignees{/user}","branches_url":"https://api.github.com/repos/astralapp/astral/branches{/branch}","tags_url":"https://api.github.com/repos/astralapp/astral/tags","blobs_url":"https://api.github.com/repos/astralapp/astral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astralapp/astral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astralapp/astral/git/refs{/sha}","trees_url":"https://api.github.com/repos/astralapp/astral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astralapp/astral/statuses/{sha}","languages_url":"https://api.github.com/repos/astralapp/astral/languages","stargazers_url":"https://api.github.com/repos/astralapp/astral/stargazers","contributors_url":"https://api.github.com/repos/astralapp/astral/contributors","subscribers_url":"https://api.github.com/repos/astralapp/astral/subscribers","subscription_url":"https://api.github.com/repos/astralapp/astral/subscription","commits_url":"https://api.github.com/repos/astralapp/astral/commits{/sha}","git_commits_url":"https://api.github.com/repos/astralapp/astral/git/commits{/sha}","comments_url":"https://api.github.com/repos/astralapp/astral/comments{/number}","issue_comment_url":"https://api.github.com/repos/astralapp/astral/issues/comments{/number}","contents_url":"https://api.github.com/repos/astralapp/astral/contents/{+path}","compare_url":"https://api.github.com/repos/astralapp/astral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astralapp/astral/merges","archive_url":"https://api.github.com/repos/astralapp/astral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astralapp/astral/downloads","issues_url":"https://api.github.com/repos/astralapp/astral/issues{/number}","pulls_url":"https://api.github.com/repos/astralapp/astral/pulls{/number}","milestones_url":"https://api.github.com/repos/astralapp/astral/milestones{/number}","notifications_url":"https://api.github.com/repos/astralapp/astral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astralapp/astral/labels{/name}","releases_url":"https://api.github.com/repos/astralapp/astral/releases{/id}","deployments_url":"https://api.github.com/repos/astralapp/astral/deployments","created_at":"2015-03-14T16:59:41Z","updated_at":"2018-10-23T15:15:11Z","pushed_at":"2018-10-21T17:55:49Z","git_url":"git://github.com/astralapp/astral.git","ssh_url":"git@github.com:astralapp/astral.git","clone_url":"https://github.com/astralapp/astral.git","svn_url":"https://github.com/astralapp/astral","homepage":"https://astralapp.com","size":26601,"stargazers_count":1182,"watchers_count":1182,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":67,"open_issues":23,"watchers":1182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astralapp/astral/pulls/224"},"html":{"href":"https://github.com/astralapp/astral/pull/224"},"issue":{"href":"https://api.github.com/repos/astralapp/astral/issues/224"},"comments":{"href":"https://api.github.com/repos/astralapp/astral/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/astralapp/astral/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/astralapp/astral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astralapp/astral/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/astralapp/astral/statuses/f8752f9720bd4d5a5c725aeaf5187c13dbe011c3"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":23,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"Williams94"}}