{"action":"closed","number":397,"pull_request":{"url":"https://api.github.com/repos/neo-project/neo/pulls/397","id":218086367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDg2MzY3","html_url":"https://github.com/neo-project/neo/pull/397","diff_url":"https://github.com/neo-project/neo/pull/397.diff","patch_url":"https://github.com/neo-project/neo/pull/397.patch","issue_url":"https://api.github.com/repos/neo-project/neo/issues/397","number":397,"state":"closed","locked":false,"title":"Allow setting Additional GAS to be used in RpcInvoke for RpcServer. Expose overloaded ApplicationEngine.Run allowing a passed Snapshot.","user":{"login":"jsolman","id":4105414,"node_id":"MDQ6VXNlcjQxMDU0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4105414?v=4","gravatar_id":"","url":"https://api.github.com/users/jsolman","html_url":"https://github.com/jsolman","followers_url":"https://api.github.com/users/jsolman/followers","following_url":"https://api.github.com/users/jsolman/following{/other_user}","gists_url":"https://api.github.com/users/jsolman/gists{/gist_id}","starred_url":"https://api.github.com/users/jsolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsolman/subscriptions","organizations_url":"https://api.github.com/users/jsolman/orgs","repos_url":"https://api.github.com/users/jsolman/repos","events_url":"https://api.github.com/users/jsolman/events{/privacy}","received_events_url":"https://api.github.com/users/jsolman/received_events","type":"User","site_admin":false},"body":"It was reported (https://github.com/neo-project/neo/issues/396) that invoke calls prior to 2.9.0 supported more than 10 GAS limit. There should be some limit, but not 10 since it helps batch results coming back to clients. This raises the limit to 300 GAS. \r\n\r\nNote: It was reported Neon wallet currently makes invokes that use between 40 and 50 GAS.\r\n\r\nAlso, some users of neo core want to run against a snapshot that may not be the current block. I'm exposing a mechanism to do this with the overloaded ApplicationEngine.Run method.\r\n\r\nClose #396 ","created_at":"2018-09-25T19:04:26Z","updated_at":"2018-10-17T08:53:51Z","closed_at":"2018-10-17T08:53:51Z","merged_at":"2018-10-17T08:53:51Z","merge_commit_sha":"fbb273ee199c644bb668b52c562ff99776f83447","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo-project/neo/pulls/397/commits","review_comments_url":"https://api.github.com/repos/neo-project/neo/pulls/397/comments","review_comment_url":"https://api.github.com/repos/neo-project/neo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo-project/neo/issues/397/comments","statuses_url":"https://api.github.com/repos/neo-project/neo/statuses/4af92d9cbf321b163de4fc6af4cad929c779ccc4","head":{"label":"neo-project:MoreGasForRpcInvoke","ref":"MoreGasForRpcInvoke","sha":"4af92d9cbf321b163de4fc6af4cad929c779ccc4","user":{"login":"neo-project","id":12685221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36613036,"node_id":"MDEwOlJlcG9zaXRvcnkzNjYxMzAzNg==","name":"neo","full_name":"neo-project/neo","private":false,"owner":{"login":"neo-project","id":12685221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neo-project/neo","description":"NEO Smart Economy","fork":false,"url":"https://api.github.com/repos/neo-project/neo","forks_url":"https://api.github.com/repos/neo-project/neo/forks","keys_url":"https://api.github.com/repos/neo-project/neo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo-project/neo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo-project/neo/teams","hooks_url":"https://api.github.com/repos/neo-project/neo/hooks","issue_events_url":"https://api.github.com/repos/neo-project/neo/issues/events{/number}","events_url":"https://api.github.com/repos/neo-project/neo/events","assignees_url":"https://api.github.com/repos/neo-project/neo/assignees{/user}","branches_url":"https://api.github.com/repos/neo-project/neo/branches{/branch}","tags_url":"https://api.github.com/repos/neo-project/neo/tags","blobs_url":"https://api.github.com/repos/neo-project/neo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo-project/neo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo-project/neo/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo-project/neo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo-project/neo/statuses/{sha}","languages_url":"https://api.github.com/repos/neo-project/neo/languages","stargazers_url":"https://api.github.com/repos/neo-project/neo/stargazers","contributors_url":"https://api.github.com/repos/neo-project/neo/contributors","subscribers_url":"https://api.github.com/repos/neo-project/neo/subscribers","subscription_url":"https://api.github.com/repos/neo-project/neo/subscription","commits_url":"https://api.github.com/repos/neo-project/neo/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo-project/neo/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo-project/neo/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo-project/neo/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo-project/neo/contents/{+path}","compare_url":"https://api.github.com/repos/neo-project/neo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo-project/neo/merges","archive_url":"https://api.github.com/repos/neo-project/neo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo-project/neo/downloads","issues_url":"https://api.github.com/repos/neo-project/neo/issues{/number}","pulls_url":"https://api.github.com/repos/neo-project/neo/pulls{/number}","milestones_url":"https://api.github.com/repos/neo-project/neo/milestones{/number}","notifications_url":"https://api.github.com/repos/neo-project/neo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo-project/neo/labels{/name}","releases_url":"https://api.github.com/repos/neo-project/neo/releases{/id}","deployments_url":"https://api.github.com/repos/neo-project/neo/deployments","created_at":"2015-05-31T17:02:33Z","updated_at":"2018-10-17T07:24:32Z","pushed_at":"2018-10-17T08:53:51Z","git_url":"git://github.com/neo-project/neo.git","ssh_url":"git@github.com:neo-project/neo.git","clone_url":"https://github.com/neo-project/neo.git","svn_url":"https://github.com/neo-project/neo","homepage":"","size":3230,"stargazers_count":2649,"watchers_count":2649,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":834,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":834,"open_issues":73,"watchers":2649,"default_branch":"master"}},"base":{"label":"neo-project:master","ref":"master","sha":"1037c5419648e0e49257df7fafb49f79b2ac6c6f","user":{"login":"neo-project","id":12685221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36613036,"node_id":"MDEwOlJlcG9zaXRvcnkzNjYxMzAzNg==","name":"neo","full_name":"neo-project/neo","private":false,"owner":{"login":"neo-project","id":12685221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1MjIx","avatar_url":"https://avatars3.githubusercontent.com/u/12685221?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-project","html_url":"https://github.com/neo-project","followers_url":"https://api.github.com/users/neo-project/followers","following_url":"https://api.github.com/users/neo-project/following{/other_user}","gists_url":"https://api.github.com/users/neo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-project/subscriptions","organizations_url":"https://api.github.com/users/neo-project/orgs","repos_url":"https://api.github.com/users/neo-project/repos","events_url":"https://api.github.com/users/neo-project/events{/privacy}","received_events_url":"https://api.github.com/users/neo-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neo-project/neo","description":"NEO Smart Economy","fork":false,"url":"https://api.github.com/repos/neo-project/neo","forks_url":"https://api.github.com/repos/neo-project/neo/forks","keys_url":"https://api.github.com/repos/neo-project/neo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo-project/neo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo-project/neo/teams","hooks_url":"https://api.github.com/repos/neo-project/neo/hooks","issue_events_url":"https://api.github.com/repos/neo-project/neo/issues/events{/number}","events_url":"https://api.github.com/repos/neo-project/neo/events","assignees_url":"https://api.github.com/repos/neo-project/neo/assignees{/user}","branches_url":"https://api.github.com/repos/neo-project/neo/branches{/branch}","tags_url":"https://api.github.com/repos/neo-project/neo/tags","blobs_url":"https://api.github.com/repos/neo-project/neo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo-project/neo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo-project/neo/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo-project/neo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo-project/neo/statuses/{sha}","languages_url":"https://api.github.com/repos/neo-project/neo/languages","stargazers_url":"https://api.github.com/repos/neo-project/neo/stargazers","contributors_url":"https://api.github.com/repos/neo-project/neo/contributors","subscribers_url":"https://api.github.com/repos/neo-project/neo/subscribers","subscription_url":"https://api.github.com/repos/neo-project/neo/subscription","commits_url":"https://api.github.com/repos/neo-project/neo/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo-project/neo/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo-project/neo/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo-project/neo/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo-project/neo/contents/{+path}","compare_url":"https://api.github.com/repos/neo-project/neo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo-project/neo/merges","archive_url":"https://api.github.com/repos/neo-project/neo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo-project/neo/downloads","issues_url":"https://api.github.com/repos/neo-project/neo/issues{/number}","pulls_url":"https://api.github.com/repos/neo-project/neo/pulls{/number}","milestones_url":"https://api.github.com/repos/neo-project/neo/milestones{/number}","notifications_url":"https://api.github.com/repos/neo-project/neo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo-project/neo/labels{/name}","releases_url":"https://api.github.com/repos/neo-project/neo/releases{/id}","deployments_url":"https://api.github.com/repos/neo-project/neo/deployments","created_at":"2015-05-31T17:02:33Z","updated_at":"2018-10-17T07:24:32Z","pushed_at":"2018-10-17T08:53:51Z","git_url":"git://github.com/neo-project/neo.git","ssh_url":"git@github.com:neo-project/neo.git","clone_url":"https://github.com/neo-project/neo.git","svn_url":"https://github.com/neo-project/neo","homepage":"","size":3230,"stargazers_count":2649,"watchers_count":2649,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":834,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":834,"open_issues":73,"watchers":2649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo-project/neo/pulls/397"},"html":{"href":"https://github.com/neo-project/neo/pull/397"},"issue":{"href":"https://api.github.com/repos/neo-project/neo/issues/397"},"comments":{"href":"https://api.github.com/repos/neo-project/neo/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/neo-project/neo/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/neo-project/neo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo-project/neo/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/neo-project/neo/statuses/4af92d9cbf321b163de4fc6af4cad929c779ccc4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"erikzhang","id":10204923,"node_id":"MDQ6VXNlcjEwMjA0OTIz","avatar_url":"https://avatars0.githubusercontent.com/u/10204923?v=4","gravatar_id":"","url":"https://api.github.com/users/erikzhang","html_url":"https://github.com/erikzhang","followers_url":"https://api.github.com/users/erikzhang/followers","following_url":"https://api.github.com/users/erikzhang/following{/other_user}","gists_url":"https://api.github.com/users/erikzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/erikzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikzhang/subscriptions","organizations_url":"https://api.github.com/users/erikzhang/orgs","repos_url":"https://api.github.com/users/erikzhang/repos","events_url":"https://api.github.com/users/erikzhang/events{/privacy}","received_events_url":"https://api.github.com/users/erikzhang/received_events","type":"User","site_admin":false},"comments":15,"review_comments":27,"maintainer_can_modify":false,"commits":11,"additions":35,"deletions":26,"changed_files":3}}
{"actor":{"display_login":"erikzhang"}}