{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/165791922","pull_request_review_id":93791875,"id":165791922,"diff_hunk":"@@ -629,23 +633,38 @@ function performBuild(watch) {\n     if (argv.extensions) {\n       if (typeof(argv.extensions) !== 'string') {\n         log(red('ERROR:'), 'Missing list of extensions. Expected format:',\n-        cyan('--extensions=amp-foo,amp-bar'));\n+            cyan('--extensions=amp-foo,amp-bar'),\n+            green('to choose which ones to build, or'),\n+            cyan('--extensions=minimal_set'),\n+            green('to build ones needed to load article.amp.html.'));\n         process.exit(1);\n       }\n-      log(green('Building extension(s):'),\n-          cyan(argv.extensions.split(',').join(', ')));\n+      if (argv.extensions == 'minimal_set') {\n+        argv.extensions =\n+            'amp-ad,amp-ad-network-adsense-impl,amp-audio,amp-video,' +\n+            'amp-image-lightbox,amp-lightbox,amp-sidebar,' +\n+            'amp-analytics,amp-app-banner';\n+        log(green('Building extensions to load article.amp.html.'));\n+      } else {\n+        log(green('Building extension(s):'),\n+            cyan(argv.extensions.split(',').join(', ')));\n+      }\n       log(green('⤷ Use'), cyan('--noextensions'),\n           green('to skip building extensions.'));\n     } else if (argv.noextensions) {\n       log(green('Not building any AMP extensions.'));\n       log(green('⤷ Use'), cyan('--extensions=amp-foo,amp-bar'),\n-          green('to choose which ones to build.'));\n+          green('to choose which ones to build, or'),\n+          cyan('--extensions=minimal_set'),\n+          green('to build ones needed to load article.amp.html.'));\n     } else {\n       log(green('Building all AMP extensions.'));\n       log(green('⤷ Use'), cyan('--noextensions'),\n           green('to skip building extensions, or'),\n           cyan('--extensions=amp-foo,amp-bar'),\n-          green('to choose which ones to build.'));\n+          green('to choose which ones to build, or'),\n+          cyan('--extensions=minimal_set'),\n+          green('to build ones needed to load article.amp.html.'));","path":"gulpfile.js","position":69,"original_position":69,"commit_id":"ef562455466c5ac4ff2d0060c1dc9f837f57ba8e","original_commit_id":"ef562455466c5ac4ff2d0060c1dc9f837f57ba8e","user":{"login":"rsimha-amp","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha-amp","html_url":"https://github.com/rsimha-amp","followers_url":"https://api.github.com/users/rsimha-amp/followers","following_url":"https://api.github.com/users/rsimha-amp/following{/other_user}","gists_url":"https://api.github.com/users/rsimha-amp/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha-amp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha-amp/subscriptions","organizations_url":"https://api.github.com/users/rsimha-amp/orgs","repos_url":"https://api.github.com/users/rsimha-amp/repos","events_url":"https://api.github.com/users/rsimha-amp/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha-amp/received_events","type":"User","site_admin":false},"body":"```\r\ngreen('to build the ones needed to load'), cyan('article.amp.html') + green('.'));\r\n``` \r\n(added `the` and color formatting)","created_at":"2018-02-03T00:11:35Z","updated_at":"2018-02-03T00:16:17Z","html_url":"https://github.com/ampproject/amphtml/pull/13249#discussion_r165791922","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13249","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/165791922"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13249#discussion_r165791922"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13249"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/13249","id":166930123,"html_url":"https://github.com/ampproject/amphtml/pull/13249","diff_url":"https://github.com/ampproject/amphtml/pull/13249.diff","patch_url":"https://github.com/ampproject/amphtml/pull/13249.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/13249","number":13249,"state":"open","locked":false,"title":"Support `--extensions=minimal_set` & bug fix","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"Follow up to #13203 \r\n@rsimha-amp I didn't update `--extensions=minimal_set` to `DEVELOPING.md` because it was not there before. Also I don't know if we want to document a single special value to the `--extensions` flag. Let me know. Thanks!","created_at":"2018-02-02T23:57:21Z","updated_at":"2018-02-03T00:16:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b671a055c7bcd6690d0df983f1a2706eafbaa32e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13249/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13249/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/13249/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/ef562455466c5ac4ff2d0060c1dc9f837f57ba8e","head":{"label":"zhouyx:fix-dist-noextensions","ref":"fix-dist-noextensions","sha":"ef562455466c5ac4ff2d0060c1dc9f837f57ba8e","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"repo":{"id":55454453,"name":"amphtml","full_name":"zhouyx/amphtml","owner":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhouyx/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/zhouyx/amphtml","forks_url":"https://api.github.com/repos/zhouyx/amphtml/forks","keys_url":"https://api.github.com/repos/zhouyx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhouyx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhouyx/amphtml/teams","hooks_url":"https://api.github.com/repos/zhouyx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/zhouyx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/zhouyx/amphtml/events","assignees_url":"https://api.github.com/repos/zhouyx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/zhouyx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/zhouyx/amphtml/tags","blobs_url":"https://api.github.com/repos/zhouyx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhouyx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhouyx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhouyx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhouyx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/zhouyx/amphtml/languages","stargazers_url":"https://api.github.com/repos/zhouyx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/zhouyx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/zhouyx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/zhouyx/amphtml/subscription","commits_url":"https://api.github.com/repos/zhouyx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhouyx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhouyx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhouyx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhouyx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/zhouyx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhouyx/amphtml/merges","archive_url":"https://api.github.com/repos/zhouyx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhouyx/amphtml/downloads","issues_url":"https://api.github.com/repos/zhouyx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/zhouyx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/zhouyx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/zhouyx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhouyx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/zhouyx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/zhouyx/amphtml/deployments","created_at":"2016-04-05T00:10:42Z","updated_at":"2017-12-05T03:37:35Z","pushed_at":"2018-02-02T23:53:47Z","git_url":"git://github.com/zhouyx/amphtml.git","ssh_url":"git@github.com:zhouyx/amphtml.git","clone_url":"https://github.com/zhouyx/amphtml.git","svn_url":"https://github.com/zhouyx/amphtml","homepage":"https://ampproject.org","size":296889,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"7321e01d5ccf032bce9564c2b3d7ecb48c3bd2b6","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-02-02T20:02:24Z","pushed_at":"2018-02-03T00:03:26Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":297252,"stargazers_count":10917,"watchers_count":10917,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2188,"mirror_url":null,"archived":false,"open_issues_count":1105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2188,"open_issues":1105,"watchers":10917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13249"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13249"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13249"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13249/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13249/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13249/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/ef562455466c5ac4ff2d0060c1dc9f837f57ba8e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rsimha-amp"}}