{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/437","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/437/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/437/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/437/events","html_url":"https://github.com/StrikeNP/trac_test/issues/437","id":332176651,"node_id":"MDU6SXNzdWUzMzIxNzY2NTE=","number":437,"title":"Simplify timestepping in CLUBB (Trac #437)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":963997231,"node_id":"MDU6TGFiZWw5NjM5OTcyMzE=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":963997516,"node_id":"MDU6TGFiZWw5NjM5OTc1MTY=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":964011129,"node_id":"MDU6TGFiZWw5NjQwMTExMjk=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/connork@uwm.edu","name":"connork@uwm.edu","color":"FFFFFF","default":false},{"id":963997043,"node_id":"MDU6TGFiZWw5NjM5OTcwNDM=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4","html_url":"https://github.com/StrikeNP/trac_test/milestone/4","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4/labels","id":3423155,"node_id":"MDk6TWlsZXN0b25lMzQyMzE1NQ==","number":4,"title":"3. Refactor CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":63,"state":"open","created_at":"2018-06-13T20:01:14Z","updated_at":"2018-06-15T01:57:15Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-06-13T21:47:41Z","updated_at":"2018-06-15T03:14:05Z","closed_at":null,"author_association":"OWNER","body":"Currently our timestep loop in clubb_driver is very complicated and difficult to follow.  We should consider a clean up that uses a simpler logic that's easier to follow for new users.  \n\nOptionally, it would also be nice to be able to run the microphysics at a shorter timestep or the radiation at a longer timestep if desired.\n\nSome complications:\n\nWe have two timesteps: dtmain, dtclosure.  Do we need both of these?  Right now we always set these equal to each other.  Can we use both of these to advantage?  \n\nMany of the time variables are in double precision.  This avoids round-off errors for long simulations but also is messy.  Can we avoid this by, e.g., using iteration number (integer)?\n\nEven better naming of the time variables, e.g. iteration number, would help.\n\nLet's review the code and see if there are any easy ways to refactor it in order to make it simpler.\n\nAttachments:\n\n[clubb-437.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/clubb/clubb-437.maff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/437\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2011-08-15T18:45:56\", \n    \"description\": \"Currently our timestep loop in clubb_driver is very complicated and difficult to follow.  We should consider a clean up that uses a simpler logic that's easier to follow for new users.  \\n\\nOptionally, it would also be nice to be able to run the microphysics at a shorter timestep or the radiation at a longer timestep if desired.\\n\\nSome complications:\\n\\nWe have two timesteps: dtmain, dtclosure.  Do we need both of these?  Right now we always set these equal to each other.  Can we use both of these to advantage?  \\n\\nMany of the time variables are in double precision.  This avoids round-off errors for long simulations but also is messy.  Can we avoid this by, e.g., using iteration number (integer)?\\n\\nEven better naming of the time variables, e.g. iteration number, would help.\\n\\nLet's review the code and see if there are any easy ways to refactor it in order to make it simpler.\", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1313433956000000\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Simplify timestepping in CLUBB\", \n    \"priority\": \"major\", \n    \"keywords\": \"\", \n    \"time\": \"2011-07-14T19:48:02\", \n    \"milestone\": \"3. Refactor CLUBB\", \n    \"owner\": \"connork@uwm.edu\", \n    \"type\": \"enhancement\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/397501034","html_url":"https://github.com/StrikeNP/trac_test/issues/437#issuecomment-397501034","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/437","id":397501034,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzUwMTAzNA==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T03:14:05Z","updated_at":"2018-06-15T03:14:05Z","author_association":"OWNER","body":"**Trac update on 2011/08/12 at 16:31**\n**connork@uwm.edu commented:**\n\nReplying to [comment:14 vlarson@…]:\n> Replying to [comment:13 connork@…]:\n> > I set dt_rad to 900 for all cloud_feedback cases, but left dt_rad at 1800 for arm_97 and twp_ice. The plots for that are here: http://www.larson-group.com/connork/protected/clubb-437-900.maff. \n>\n> Interestingly, the formation of an anvil cloud in cloud_feedback_s6 is highly sensitive to the radiative timestep.  We should keep this in mind if in the future we ever have trouble with a spurious anvil or a patchy stratocumulus cloud.\n> \n> > cloud_feedback_s6 still looked pretty bad with this timestep, so I lowered dt_rad to 600 for cloud_feedback_s6 and left everything else the same. The plots for that are here: http://www.larson-group.com/connork/protected/clubb-437-600.maff.\n>\n> These results look similar to the results with dt_rad = 60 s.  An anvil forms above the cloud_feedback_s6 cloud, which is undesirable, but we don't want to obscure errors with compensating errors.  Please commit the new settings.\n\nJust to clarify, you want me to commit with dt_rad of 1800 for arm_97 and twp_ice, 900 for cloud_feedback_s11 and cloud_feedback_s12, and 600 for cloud_feedback_s6?\n\n"}}
{"actor":{"display_login":"StrikeNP"}}