{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/components/pulls/comments/171872422","pull_request_review_id":100805305,"id":171872422,"diff_hunk":"@@ -46,11 +46,8 @@\n     public ProcessingFamilyDefinition() {\n         super(NAME,\n                 // Components\n-                new FilterRowDefinition(), new PythonRowDefinition(), new ReplicateDefinition(),\n-                new TypeConverterDefinition(), new FieldSelectorDefinition(),\n-                new WindowDefinition(), new NormalizeDefinition(), new AggregateDefinition()\n-        // Component wizards\n-        );\n+                new AggregateDefinition(), new FieldSelectorDefinition(), new FilterRowDefinition(), new NormalizeDefinition(),\n+                new PythonRowDefinition(), new ReplicateDefinition(), new TypeConverterDefinition(), new WindowDefinition());","path":"components/components-processing/processing-definition/src/main/java/org/talend/components/processing/definition/ProcessingFamilyDefinition.java","position":10,"original_position":10,"commit_id":"9f9b9729f4a761a99e44549d520006fd031f1443","original_commit_id":"9f9b9729f4a761a99e44549d520006fd031f1443","user":{"login":"pbailly","id":7931696,"avatar_url":"https://avatars3.githubusercontent.com/u/7931696?v=4","gravatar_id":"","url":"https://api.github.com/users/pbailly","html_url":"https://github.com/pbailly","followers_url":"https://api.github.com/users/pbailly/followers","following_url":"https://api.github.com/users/pbailly/following{/other_user}","gists_url":"https://api.github.com/users/pbailly/gists{/gist_id}","starred_url":"https://api.github.com/users/pbailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbailly/subscriptions","organizations_url":"https://api.github.com/users/pbailly/orgs","repos_url":"https://api.github.com/users/pbailly/repos","events_url":"https://api.github.com/users/pbailly/events{/privacy}","received_events_url":"https://api.github.com/users/pbailly/received_events","type":"User","site_admin":false},"body":"Please, be careful, you may have conflict with https://github.com/Talend/components/pull/1174 .","created_at":"2018-03-02T15:13:00Z","updated_at":"2018-03-02T15:14:29Z","html_url":"https://github.com/Talend/components/pull/1158#discussion_r171872422","pull_request_url":"https://api.github.com/repos/Talend/components/pulls/1158","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/comments/171872422"},"html":{"href":"https://github.com/Talend/components/pull/1158#discussion_r171872422"},"pull_request":{"href":"https://api.github.com/repos/Talend/components/pulls/1158"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/components/pulls/1158","id":169617535,"html_url":"https://github.com/Talend/components/pull/1158","diff_url":"https://github.com/Talend/components/pull/1158.diff","patch_url":"https://github.com/Talend/components/pull/1158.patch","issue_url":"https://api.github.com/repos/Talend/components/issues/1158","number":1158,"state":"open","locked":false,"title":"fix(TFD-2647): Add type converter.","user":{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars0.githubusercontent.com/u/7744819?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false},"body":"**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nThe type converter is deactivated.\r\n\r\n**What is the new behavior?**\r\n\r\nThe type converter is activated.\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n- [X] The commit message follows Talend standard\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [ ] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**Other information**:\r\n\r\nThe two PR are related:\r\nhttps://github.com/Talend/daikon/pull/342\r\nhttps://github.com/Talend/components/pull/1158","created_at":"2018-02-16T12:55:17Z","updated_at":"2018-03-02T15:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"278c103bc9e2e0086f9162329c03d07a89101672","assignee":{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars0.githubusercontent.com/u/7744819?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false},"assignees":[{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars0.githubusercontent.com/u/7744819?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lbourgeois","id":25078271,"avatar_url":"https://avatars0.githubusercontent.com/u/25078271?v=4","gravatar_id":"","url":"https://api.github.com/users/lbourgeois","html_url":"https://github.com/lbourgeois","followers_url":"https://api.github.com/users/lbourgeois/followers","following_url":"https://api.github.com/users/lbourgeois/following{/other_user}","gists_url":"https://api.github.com/users/lbourgeois/gists{/gist_id}","starred_url":"https://api.github.com/users/lbourgeois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbourgeois/subscriptions","organizations_url":"https://api.github.com/users/lbourgeois/orgs","repos_url":"https://api.github.com/users/lbourgeois/repos","events_url":"https://api.github.com/users/lbourgeois/events{/privacy}","received_events_url":"https://api.github.com/users/lbourgeois/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":399178691,"url":"https://api.github.com/repos/Talend/components/labels/Merged%20build%20passed","name":"Merged build passed","color":"006b75","default":false},{"id":451390171,"url":"https://api.github.com/repos/Talend/components/labels/Work%20in%20progress(do%20not%20merge)","name":"Work in progress(do not merge)","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/components/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/Talend/components/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/Talend/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/components/issues/1158/comments","statuses_url":"https://api.github.com/repos/Talend/components/statuses/9f9b9729f4a761a99e44549d520006fd031f1443","head":{"label":"Talend:rskraba/fix/TFD-2647-typeconverter","ref":"rskraba/fix/TFD-2647-typeconverter","sha":"9f9b9729f4a761a99e44549d520006fd031f1443","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2018-02-12T16:09:04Z","pushed_at":"2018-03-02T15:13:39Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":16613,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":44,"open_issues":21,"watchers":20,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"7120ad8d63f8032016e5d10ead2dfbbb248d285a","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2018-02-12T16:09:04Z","pushed_at":"2018-03-02T15:13:39Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":16613,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":44,"open_issues":21,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/1158"},"html":{"href":"https://github.com/Talend/components/pull/1158"},"issue":{"href":"https://api.github.com/repos/Talend/components/issues/1158"},"comments":{"href":"https://api.github.com/repos/Talend/components/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/components/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/components/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/components/statuses/9f9b9729f4a761a99e44549d520006fd031f1443"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pbailly"}}