{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/214997268","pull_request_review_id":152167481,"id":214997268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDk5NzI2OA==","diff_hunk":"@@ -108,7 +108,7 @@ func installJoinMastersStep(m *metadata) error {\n }\n \n func installJoinWorkersStep(m *metadata) error {\n-\treturn runInstallStep(m, joinWorkersStep)\n+\treturn nil","path":"installer/pkg/workflow/install.go","position":25,"original_position":25,"commit_id":"42ce981b8080d5946c5abdf30ecdb32e495a726c","original_commit_id":"645ddb353038eba0d67656160f866f53f4a8f089","user":{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"Just throw all of that into this PR - that's why there are separate commits. It is logically related.","created_at":"2018-09-04T17:16:09Z","updated_at":"2018-09-04T17:16:09Z","html_url":"https://github.com/openshift/installer/pull/119#discussion_r214997268","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/119","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/214997268"},"html":{"href":"https://github.com/openshift/installer/pull/119#discussion_r214997268"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/119"}},"in_reply_to_id":214117964},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/119","id":207660291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjYwMjkx","html_url":"https://github.com/openshift/installer/pull/119","diff_url":"https://github.com/openshift/installer/pull/119.diff","patch_url":"https://github.com/openshift/installer/pull/119.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/119","number":119,"state":"open","locked":false,"title":"Machine api mvp","user":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"body":"This PR provides a minimum functional integration for the installer with the machine API and machineSets.\r\n\r\nIt removes the terraform step for creating workers machines on AWS so after bootstrapping a cluster with `openshift install` the worker machines are managed by a machineSet object  so we can have an early e2e test driven workflow\r\n\r\nFollow ups:\r\n- Loads of fixes for the underlying tooling(machine-api-actuator, aws actuator)\r\n- Discuss/Consolidate operator config with machineConfig\r\n- Discuss how we deal with the machineSet object (is it owned by machineConfig operator? is it owned by machine-api-operator along with machine-api components? is it owned by its custom operator?)\r\n","created_at":"2018-08-10T16:19:05Z","updated_at":"2018-09-04T17:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa411049248aabfe3c30e33118da1a188f4df02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959730450,"node_id":"MDU6TGFiZWw5NTk3MzA0NTA=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":981486838,"node_id":"MDU6TGFiZWw5ODE0ODY4Mzg=","url":"https://api.github.com/repos/openshift/installer/labels/run-smoke-tests","name":"run-smoke-tests","color":"0e8a16","default":false},{"id":959730581,"node_id":"MDU6TGFiZWw5NTk3MzA1ODE=","url":"https://api.github.com/repos/openshift/installer/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/119/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/119/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/119/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/42ce981b8080d5946c5abdf30ecdb32e495a726c","head":{"label":"enxebre:machine-api-mvp","ref":"machine-api-mvp","sha":"42ce981b8080d5946c5abdf30ecdb32e495a726c","user":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"repo":{"id":139686917,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2ODY5MTc=","name":"installer","full_name":"enxebre/installer","owner":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enxebre/installer","description":"THIS REPO IS FOR PR JOB TESTING ONLY","fork":true,"url":"https://api.github.com/repos/enxebre/installer","forks_url":"https://api.github.com/repos/enxebre/installer/forks","keys_url":"https://api.github.com/repos/enxebre/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enxebre/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enxebre/installer/teams","hooks_url":"https://api.github.com/repos/enxebre/installer/hooks","issue_events_url":"https://api.github.com/repos/enxebre/installer/issues/events{/number}","events_url":"https://api.github.com/repos/enxebre/installer/events","assignees_url":"https://api.github.com/repos/enxebre/installer/assignees{/user}","branches_url":"https://api.github.com/repos/enxebre/installer/branches{/branch}","tags_url":"https://api.github.com/repos/enxebre/installer/tags","blobs_url":"https://api.github.com/repos/enxebre/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enxebre/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enxebre/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/enxebre/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enxebre/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/enxebre/installer/languages","stargazers_url":"https://api.github.com/repos/enxebre/installer/stargazers","contributors_url":"https://api.github.com/repos/enxebre/installer/contributors","subscribers_url":"https://api.github.com/repos/enxebre/installer/subscribers","subscription_url":"https://api.github.com/repos/enxebre/installer/subscription","commits_url":"https://api.github.com/repos/enxebre/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/enxebre/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/enxebre/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/enxebre/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/enxebre/installer/contents/{+path}","compare_url":"https://api.github.com/repos/enxebre/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enxebre/installer/merges","archive_url":"https://api.github.com/repos/enxebre/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enxebre/installer/downloads","issues_url":"https://api.github.com/repos/enxebre/installer/issues{/number}","pulls_url":"https://api.github.com/repos/enxebre/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/enxebre/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/enxebre/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enxebre/installer/labels{/name}","releases_url":"https://api.github.com/repos/enxebre/installer/releases{/id}","deployments_url":"https://api.github.com/repos/enxebre/installer/deployments","created_at":"2018-07-04T07:44:18Z","updated_at":"2018-07-04T07:44:21Z","pushed_at":"2018-09-04T13:10:28Z","git_url":"git://github.com/enxebre/installer.git","ssh_url":"git@github.com:enxebre/installer.git","clone_url":"https://github.com/enxebre/installer.git","svn_url":"https://github.com/enxebre/installer","homepage":"","size":38679,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a47aeb1fcf7ffef94202501fcba30bf46aa02532","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-09-03T09:56:37Z","pushed_at":"2018-09-04T15:49:11Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":36371,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":23,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/119"},"html":{"href":"https://github.com/openshift/installer/pull/119"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/119"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/42ce981b8080d5946c5abdf30ecdb32e495a726c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"crawford"}}