{"action":"created","comment":{"url":"https://api.github.com/repos/webmixedreality/exokit/pulls/comments/211061215","pull_request_review_id":147415665,"id":211061215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA2MTIxNQ==","diff_hunk":"@@ -1609,28 +1609,31 @@ exokit.load = (src, options = {}) => {\n   if (!url.parse(src).protocol) {\n     src = 'http://' + src;\n   }\n-  return fetch(src)\n-    .then(res => {\n-      if (res.status >= 200 && res.status < 300) {\n-        return res.text();\n-      } else {\n-        return Promise.reject(new Error('fetch got invalid status code: ' + res.status + ' : ' + src));\n-      }\n-    })\n-    .then(htmlString => {\n-      let baseUrl;\n-      if (options.baseUrl) {\n-        baseUrl = options.baseUrl;\n-      } else {\n-        baseUrl = utils._getBaseUrl(src);\n-      }\n+  return new Promise(resolve => {","path":"core.js","position":19,"original_position":19,"commit_id":"b98b64bcd965f33c1361d3a22cefe356a69e27d6","original_commit_id":"b98b64bcd965f33c1361d3a22cefe356a69e27d6","user":{"login":"modulesio","id":6926057,"node_id":"MDQ6VXNlcjY5MjYwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6926057?v=4","gravatar_id":"","url":"https://api.github.com/users/modulesio","html_url":"https://github.com/modulesio","followers_url":"https://api.github.com/users/modulesio/followers","following_url":"https://api.github.com/users/modulesio/following{/other_user}","gists_url":"https://api.github.com/users/modulesio/gists{/gist_id}","starred_url":"https://api.github.com/users/modulesio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modulesio/subscriptions","organizations_url":"https://api.github.com/users/modulesio/orgs","repos_url":"https://api.github.com/users/modulesio/repos","events_url":"https://api.github.com/users/modulesio/events{/privacy}","received_events_url":"https://api.github.com/users/modulesio/received_events","type":"User","site_admin":false},"body":"Hm, wasn't `return fetch(src)` already doing that? This is existing code:\r\n\r\n![capture 4](https://user-images.githubusercontent.com/6926057/44294510-2ec7a580-a266-11e8-82be-3a87faa7b922.PNG)\r\n\r\n```\r\n(async () => { let p = require('./index').load('https://aframe.io/a-painter'); let o = await p; console.log(p.constructor.name, Object.keys(o)); })(); 1;\r\n```\r\n","created_at":"2018-08-18T01:41:42Z","updated_at":"2018-08-18T01:41:42Z","html_url":"https://github.com/webmixedreality/exokit/pull/355#discussion_r211061215","pull_request_url":"https://api.github.com/repos/webmixedreality/exokit/pulls/355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/comments/211061215"},"html":{"href":"https://github.com/webmixedreality/exokit/pull/355#discussion_r211061215"},"pull_request":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/355"}},"in_reply_to_id":210862725},"pull_request":{"url":"https://api.github.com/repos/webmixedreality/exokit/pulls/355","id":209085158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDg1MTU4","html_url":"https://github.com/webmixedreality/exokit/pull/355","diff_url":"https://github.com/webmixedreality/exokit/pull/355.diff","patch_url":"https://github.com/webmixedreality/exokit/pull/355.patch","issue_url":"https://api.github.com/repos/webmixedreality/exokit/issues/355","number":355,"state":"open","locked":false,"title":"ndb for debugging with a note in the README on how to use (fixes #246)","user":{"login":"ngokevin","id":674727,"node_id":"MDQ6VXNlcjY3NDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/674727?v=4","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"Worked for me!\r\n\r\nOpen up ndb (not attached to a process).\r\n\r\nThen `var window = await require('./index').load(URL)`.\r\n\r\nAnd get a handle on the window to debug, or use the debugger.","created_at":"2018-08-17T08:56:03Z","updated_at":"2018-08-18T01:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d57d7cc06f8109eb47d4542eb0afc829b172b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webmixedreality/exokit/pulls/355/commits","review_comments_url":"https://api.github.com/repos/webmixedreality/exokit/pulls/355/comments","review_comment_url":"https://api.github.com/repos/webmixedreality/exokit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webmixedreality/exokit/issues/355/comments","statuses_url":"https://api.github.com/repos/webmixedreality/exokit/statuses/b98b64bcd965f33c1361d3a22cefe356a69e27d6","head":{"label":"ngokevin:debugger","ref":"debugger","sha":"b98b64bcd965f33c1361d3a22cefe356a69e27d6","user":{"login":"ngokevin","id":674727,"node_id":"MDQ6VXNlcjY3NDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/674727?v=4","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"repo":{"id":139505735,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1MDU3MzU=","name":"exokit","full_name":"ngokevin/exokit","owner":{"login":"ngokevin","id":674727,"node_id":"MDQ6VXNlcjY3NDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/674727?v=4","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngokevin/exokit","description":"Javascript AR/VR web browser 🦖","fork":true,"url":"https://api.github.com/repos/ngokevin/exokit","forks_url":"https://api.github.com/repos/ngokevin/exokit/forks","keys_url":"https://api.github.com/repos/ngokevin/exokit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngokevin/exokit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngokevin/exokit/teams","hooks_url":"https://api.github.com/repos/ngokevin/exokit/hooks","issue_events_url":"https://api.github.com/repos/ngokevin/exokit/issues/events{/number}","events_url":"https://api.github.com/repos/ngokevin/exokit/events","assignees_url":"https://api.github.com/repos/ngokevin/exokit/assignees{/user}","branches_url":"https://api.github.com/repos/ngokevin/exokit/branches{/branch}","tags_url":"https://api.github.com/repos/ngokevin/exokit/tags","blobs_url":"https://api.github.com/repos/ngokevin/exokit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngokevin/exokit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngokevin/exokit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngokevin/exokit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngokevin/exokit/statuses/{sha}","languages_url":"https://api.github.com/repos/ngokevin/exokit/languages","stargazers_url":"https://api.github.com/repos/ngokevin/exokit/stargazers","contributors_url":"https://api.github.com/repos/ngokevin/exokit/contributors","subscribers_url":"https://api.github.com/repos/ngokevin/exokit/subscribers","subscription_url":"https://api.github.com/repos/ngokevin/exokit/subscription","commits_url":"https://api.github.com/repos/ngokevin/exokit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngokevin/exokit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngokevin/exokit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngokevin/exokit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngokevin/exokit/contents/{+path}","compare_url":"https://api.github.com/repos/ngokevin/exokit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngokevin/exokit/merges","archive_url":"https://api.github.com/repos/ngokevin/exokit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngokevin/exokit/downloads","issues_url":"https://api.github.com/repos/ngokevin/exokit/issues{/number}","pulls_url":"https://api.github.com/repos/ngokevin/exokit/pulls{/number}","milestones_url":"https://api.github.com/repos/ngokevin/exokit/milestones{/number}","notifications_url":"https://api.github.com/repos/ngokevin/exokit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngokevin/exokit/labels{/name}","releases_url":"https://api.github.com/repos/ngokevin/exokit/releases{/id}","deployments_url":"https://api.github.com/repos/ngokevin/exokit/deployments","created_at":"2018-07-02T23:43:34Z","updated_at":"2018-07-02T23:43:37Z","pushed_at":"2018-08-18T01:35:07Z","git_url":"git://github.com/ngokevin/exokit.git","ssh_url":"git@github.com:ngokevin/exokit.git","clone_url":"https://github.com/ngokevin/exokit.git","svn_url":"https://github.com/ngokevin/exokit","homepage":"https://exokit.webmr.io","size":13683,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"webmixedreality:master","ref":"master","sha":"9e20e1cb0d078aeba53a0e4fa5e0c99bfd688a72","user":{"login":"webmixedreality","id":37630640,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjMwNjQw","avatar_url":"https://avatars1.githubusercontent.com/u/37630640?v=4","gravatar_id":"","url":"https://api.github.com/users/webmixedreality","html_url":"https://github.com/webmixedreality","followers_url":"https://api.github.com/users/webmixedreality/followers","following_url":"https://api.github.com/users/webmixedreality/following{/other_user}","gists_url":"https://api.github.com/users/webmixedreality/gists{/gist_id}","starred_url":"https://api.github.com/users/webmixedreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmixedreality/subscriptions","organizations_url":"https://api.github.com/users/webmixedreality/orgs","repos_url":"https://api.github.com/users/webmixedreality/repos","events_url":"https://api.github.com/users/webmixedreality/events{/privacy}","received_events_url":"https://api.github.com/users/webmixedreality/received_events","type":"Organization","site_admin":false},"repo":{"id":118219951,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyMTk5NTE=","name":"exokit","full_name":"webmixedreality/exokit","owner":{"login":"webmixedreality","id":37630640,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjMwNjQw","avatar_url":"https://avatars1.githubusercontent.com/u/37630640?v=4","gravatar_id":"","url":"https://api.github.com/users/webmixedreality","html_url":"https://github.com/webmixedreality","followers_url":"https://api.github.com/users/webmixedreality/followers","following_url":"https://api.github.com/users/webmixedreality/following{/other_user}","gists_url":"https://api.github.com/users/webmixedreality/gists{/gist_id}","starred_url":"https://api.github.com/users/webmixedreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmixedreality/subscriptions","organizations_url":"https://api.github.com/users/webmixedreality/orgs","repos_url":"https://api.github.com/users/webmixedreality/repos","events_url":"https://api.github.com/users/webmixedreality/events{/privacy}","received_events_url":"https://api.github.com/users/webmixedreality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webmixedreality/exokit","description":"Javascript AR/VR/WebXR engine 🦖","fork":false,"url":"https://api.github.com/repos/webmixedreality/exokit","forks_url":"https://api.github.com/repos/webmixedreality/exokit/forks","keys_url":"https://api.github.com/repos/webmixedreality/exokit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmixedreality/exokit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmixedreality/exokit/teams","hooks_url":"https://api.github.com/repos/webmixedreality/exokit/hooks","issue_events_url":"https://api.github.com/repos/webmixedreality/exokit/issues/events{/number}","events_url":"https://api.github.com/repos/webmixedreality/exokit/events","assignees_url":"https://api.github.com/repos/webmixedreality/exokit/assignees{/user}","branches_url":"https://api.github.com/repos/webmixedreality/exokit/branches{/branch}","tags_url":"https://api.github.com/repos/webmixedreality/exokit/tags","blobs_url":"https://api.github.com/repos/webmixedreality/exokit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmixedreality/exokit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmixedreality/exokit/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmixedreality/exokit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmixedreality/exokit/statuses/{sha}","languages_url":"https://api.github.com/repos/webmixedreality/exokit/languages","stargazers_url":"https://api.github.com/repos/webmixedreality/exokit/stargazers","contributors_url":"https://api.github.com/repos/webmixedreality/exokit/contributors","subscribers_url":"https://api.github.com/repos/webmixedreality/exokit/subscribers","subscription_url":"https://api.github.com/repos/webmixedreality/exokit/subscription","commits_url":"https://api.github.com/repos/webmixedreality/exokit/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmixedreality/exokit/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmixedreality/exokit/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmixedreality/exokit/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmixedreality/exokit/contents/{+path}","compare_url":"https://api.github.com/repos/webmixedreality/exokit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmixedreality/exokit/merges","archive_url":"https://api.github.com/repos/webmixedreality/exokit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmixedreality/exokit/downloads","issues_url":"https://api.github.com/repos/webmixedreality/exokit/issues{/number}","pulls_url":"https://api.github.com/repos/webmixedreality/exokit/pulls{/number}","milestones_url":"https://api.github.com/repos/webmixedreality/exokit/milestones{/number}","notifications_url":"https://api.github.com/repos/webmixedreality/exokit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmixedreality/exokit/labels{/name}","releases_url":"https://api.github.com/repos/webmixedreality/exokit/releases{/id}","deployments_url":"https://api.github.com/repos/webmixedreality/exokit/deployments","created_at":"2018-01-20T07:29:25Z","updated_at":"2018-08-17T21:07:25Z","pushed_at":"2018-08-18T01:35:08Z","git_url":"git://github.com/webmixedreality/exokit.git","ssh_url":"git@github.com:webmixedreality/exokit.git","clone_url":"https://github.com/webmixedreality/exokit.git","svn_url":"https://github.com/webmixedreality/exokit","homepage":"https://exokit.webmr.io","size":14684,"stargazers_count":156,"watchers_count":156,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":104,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/355"},"html":{"href":"https://github.com/webmixedreality/exokit/pull/355"},"issue":{"href":"https://api.github.com/repos/webmixedreality/exokit/issues/355"},"comments":{"href":"https://api.github.com/repos/webmixedreality/exokit/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webmixedreality/exokit/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/webmixedreality/exokit/statuses/b98b64bcd965f33c1361d3a22cefe356a69e27d6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"modulesio"}}