{"action":"opened","number":3273,"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273","id":192397552,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzk3NTUy","html_url":"https://github.com/Cockatrice/Cockatrice/pull/3273","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/3273.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/3273.patch","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3273","number":3273,"state":"open","locked":false,"title":"Fix Debug build on Ubuntu 18.04+ (faulty protobuf 3.0 version)","user":{"login":"berserkingyadis","id":9959527,"node_id":"MDQ6VXNlcjk5NTk1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9959527?v=4","gravatar_id":"","url":"https://api.github.com/users/berserkingyadis","html_url":"https://github.com/berserkingyadis","followers_url":"https://api.github.com/users/berserkingyadis/followers","following_url":"https://api.github.com/users/berserkingyadis/following{/other_user}","gists_url":"https://api.github.com/users/berserkingyadis/gists{/gist_id}","starred_url":"https://api.github.com/users/berserkingyadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berserkingyadis/subscriptions","organizations_url":"https://api.github.com/users/berserkingyadis/orgs","repos_url":"https://api.github.com/users/berserkingyadis/repos","events_url":"https://api.github.com/users/berserkingyadis/events{/privacy}","received_events_url":"https://api.github.com/users/berserkingyadis/received_events","type":"User","site_admin":false},"body":"## Related Ticket(s)\r\n- Fixes #2343\r\n\r\n## Short roundup of the initial problem\r\nDue to the faulty protobuf version which is installed by default on Ubuntu 18.04 and 18.10 (discussed in #2343 ), the current cmake configuration throws warning-errors for `unused-parameter` and `misleading-indentation` in the protobuf generated code in Debug build.\r\n\r\nCompiler log:\r\n```\r\nScanning dependencies of target cockatrice_protocol\r\n[ 31%] Building CXX object common/pb/CMakeFiles/cockatrice_protocol.dir/admin_commands.pb.cc.o\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual google::protobuf::uint8* AdminCommand::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:367:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]\r\n     bool deterministic, ::google::protobuf::uint8* target) const {\r\n          ^~~~~~~~~~~~~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual bool AdminCommand::IsInitialized() const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:443:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]\r\n   if (!_extensions_.IsInitialized()) return false;  return true;\r\n   ^~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:443:53: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'\r\n   if (!_extensions_.IsInitialized()) return false;  return true;\r\n                                                     ^~~~~~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual google::protobuf::uint8* Command_UpdateServerMessage::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:583:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]\r\n     bool deterministic, ::google::protobuf::uint8* target) const {\r\n          ^~~~~~~~~~~~~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual google::protobuf::uint8* Command_ShutdownServer::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:853:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]\r\n     bool deterministic, ::google::protobuf::uint8* target) const {\r\n          ^~~~~~~~~~~~~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual google::protobuf::uint8* Command_ReloadConfig::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:1182:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]\r\n     bool deterministic, ::google::protobuf::uint8* target) const {\r\n          ^~~~~~~~~~~~~\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc: In member function 'virtual google::protobuf::uint8* Command_AdjustMod::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const':\r\n/builds/cockatrice/cockatrice/build/common/pb/admin_commands.pb.cc:1452:10: error: unused parameter 'deterministic' [-Werror=unused-parameter]\r\n     bool deterministic, ::google::protobuf::uint8* target) const {\r\n          ^~~~~~~~~~~~~\r\ncc1plus: all warnings being treated as errors\r\ncommon/pb/CMakeFiles/cockatrice_protocol.dir/build.make:1278: recipe for target 'common/pb/CMakeFiles/cockatrice_protocol.dir/admin_commands.pb.cc.o' failed\r\nmake[2]: *** [common/pb/CMakeFiles/cockatrice_protocol.dir/admin_commands.pb.cc.o] Error 1\r\nCMakeFiles/Makefile2:1073: recipe for target 'common/pb/CMakeFiles/cockatrice_protocol.dir/all' failed\r\nmake[1]: *** [common/pb/CMakeFiles/cockatrice_protocol.dir/all] Error 2\r\n```\r\n\r\n## What will change with this Pull Request?\r\nThe 2 warning-errors mentioned above and in #2343 will not be treated as errors anymore.\r\n\r\n\r\n","created_at":"2018-06-04T12:51:07Z","updated_at":"2018-06-04T12:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273/commits","review_comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273/comments","review_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3273/comments","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/4789ee4b2aed4850447c63b8bf7e247eebbd452f","head":{"label":"berserkingyadis:ubuntu_latest_fix_debug_build","ref":"ubuntu_latest_fix_debug_build","sha":"4789ee4b2aed4850447c63b8bf7e247eebbd452f","user":{"login":"berserkingyadis","id":9959527,"node_id":"MDQ6VXNlcjk5NTk1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9959527?v=4","gravatar_id":"","url":"https://api.github.com/users/berserkingyadis","html_url":"https://github.com/berserkingyadis","followers_url":"https://api.github.com/users/berserkingyadis/followers","following_url":"https://api.github.com/users/berserkingyadis/following{/other_user}","gists_url":"https://api.github.com/users/berserkingyadis/gists{/gist_id}","starred_url":"https://api.github.com/users/berserkingyadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berserkingyadis/subscriptions","organizations_url":"https://api.github.com/users/berserkingyadis/orgs","repos_url":"https://api.github.com/users/berserkingyadis/repos","events_url":"https://api.github.com/users/berserkingyadis/events{/privacy}","received_events_url":"https://api.github.com/users/berserkingyadis/received_events","type":"User","site_admin":false},"repo":{"id":133032832,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMzI4MzI=","name":"Cockatrice","full_name":"berserkingyadis/Cockatrice","owner":{"login":"berserkingyadis","id":9959527,"node_id":"MDQ6VXNlcjk5NTk1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9959527?v=4","gravatar_id":"","url":"https://api.github.com/users/berserkingyadis","html_url":"https://github.com/berserkingyadis","followers_url":"https://api.github.com/users/berserkingyadis/followers","following_url":"https://api.github.com/users/berserkingyadis/following{/other_user}","gists_url":"https://api.github.com/users/berserkingyadis/gists{/gist_id}","starred_url":"https://api.github.com/users/berserkingyadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berserkingyadis/subscriptions","organizations_url":"https://api.github.com/users/berserkingyadis/orgs","repos_url":"https://api.github.com/users/berserkingyadis/repos","events_url":"https://api.github.com/users/berserkingyadis/events{/privacy}","received_events_url":"https://api.github.com/users/berserkingyadis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/berserkingyadis/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":true,"url":"https://api.github.com/repos/berserkingyadis/Cockatrice","forks_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/forks","keys_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/teams","hooks_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/events","assignees_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/tags","blobs_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/subscription","commits_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/merges","archive_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/downloads","issues_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/berserkingyadis/Cockatrice/deployments","created_at":"2018-05-11T11:44:18Z","updated_at":"2018-06-04T12:22:21Z","pushed_at":"2018-06-04T12:34:02Z","git_url":"git://github.com/berserkingyadis/Cockatrice.git","ssh_url":"git@github.com:berserkingyadis/Cockatrice.git","clone_url":"https://github.com/berserkingyadis/Cockatrice.git","svn_url":"https://github.com/berserkingyadis/Cockatrice","homepage":"https://cockatrice.github.io","size":39762,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cockatrice:master","ref":"master","sha":"89ab7f1f67aba119377312cc538d29c01662476c","user":{"login":"Cockatrice","id":9746249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3NDYyNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3MDMx","name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3NDYyNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9746249?v=4","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/deployments","created_at":"2011-12-03T20:58:09Z","updated_at":"2018-06-02T16:33:34Z","pushed_at":"2018-06-02T06:54:20Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"https://cockatrice.github.io","size":39751,"stargazers_count":667,"watchers_count":667,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":296,"mirror_url":null,"archived":false,"open_issues_count":529,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":296,"open_issues":529,"watchers":667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/3273"},"issue":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3273"},"comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3273/comments"},"review_comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273/comments"},"review_comment":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3273/commits"},"statuses":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/4789ee4b2aed4850447c63b8bf7e247eebbd452f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"berserkingyadis"}}