{"action":"created","comment":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/189663601","pull_request_review_id":121887094,"id":189663601,"diff_hunk":"@@ -101,8 +105,8 @@ PARAM_DOUBLE_IN(\"min_residue\", \"Residue required to terminate the factorization\"\n     \" (lower values generally mean better fits).\", \"r\", 1e-5);\n \n // Load/save a model.\n-PARAM_MODEL_IN(CF, \"input_model\", \"Trained CF model to load.\", \"m\");\n-PARAM_MODEL_OUT(CF, \"output_model\", \"Output for trained CF model.\", \"M\");\n+PARAM_MODEL_IN(CF<>, \"input_model\", \"Trained CF model to load.\", \"m\");","path":"src/mlpack/methods/cf/cf_main.cpp","position":25,"original_position":25,"commit_id":"386664f9d53e7866bfdee4a0f012531feb0acd65","original_commit_id":"386664f9d53e7866bfdee4a0f012531feb0acd65","user":{"login":"rcurtin","id":1845039,"avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"body":"In other cases where this has come up (it does in `LogisticRegression` for example) I separate the template parameter used for the training of the model.  So, e.g., maybe `CF` has no template parameters but `CF::Train()` does, since the decomposition is only used at training time.\r\n\r\nIf that doesn't work (and I haven't spent a long time thinking about it, so maybe it doesn't), you might try some wrapper model that can hold all `CF<...>` types that might be used.  See, e.g., `AdaBoostModel` in `src/mlpack/methods/adaboost/adaboost_model.hpp`, then you can just serialize that.","created_at":"2018-05-21T17:50:49Z","updated_at":"2018-05-21T17:50:49Z","html_url":"https://github.com/mlpack/mlpack/pull/1355#discussion_r189663601","pull_request_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/189663601"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1355#discussion_r189663601"},"pull_request":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1355"}},"in_reply_to_id":189452365},"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/1355","id":179654524,"html_url":"https://github.com/mlpack/mlpack/pull/1355","diff_url":"https://github.com/mlpack/mlpack/pull/1355.diff","patch_url":"https://github.com/mlpack/mlpack/pull/1355.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/1355","number":1355,"state":"open","locked":false,"title":"CF decomposition using RandomizedSVD","user":{"login":"haritha1313","id":18036057,"avatar_url":"https://avatars3.githubusercontent.com/u/18036057?v=4","gravatar_id":"","url":"https://api.github.com/users/haritha1313","html_url":"https://github.com/haritha1313","followers_url":"https://api.github.com/users/haritha1313/followers","following_url":"https://api.github.com/users/haritha1313/following{/other_user}","gists_url":"https://api.github.com/users/haritha1313/gists{/gist_id}","starred_url":"https://api.github.com/users/haritha1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haritha1313/subscriptions","organizations_url":"https://api.github.com/users/haritha1313/orgs","repos_url":"https://api.github.com/users/haritha1313/repos","events_url":"https://api.github.com/users/haritha1313/events{/privacy}","received_events_url":"https://api.github.com/users/haritha1313/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-05T12:02:21Z","updated_at":"2018-05-21T17:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"989809939d03e3e0af46ce24cb6179e2bfaaae80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/1355/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/386664f9d53e7866bfdee4a0f012531feb0acd65","head":{"label":"haritha1313:randSVD_cf","ref":"randSVD_cf","sha":"386664f9d53e7866bfdee4a0f012531feb0acd65","user":{"login":"haritha1313","id":18036057,"avatar_url":"https://avatars3.githubusercontent.com/u/18036057?v=4","gravatar_id":"","url":"https://api.github.com/users/haritha1313","html_url":"https://github.com/haritha1313","followers_url":"https://api.github.com/users/haritha1313/followers","following_url":"https://api.github.com/users/haritha1313/following{/other_user}","gists_url":"https://api.github.com/users/haritha1313/gists{/gist_id}","starred_url":"https://api.github.com/users/haritha1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haritha1313/subscriptions","organizations_url":"https://api.github.com/users/haritha1313/orgs","repos_url":"https://api.github.com/users/haritha1313/repos","events_url":"https://api.github.com/users/haritha1313/events{/privacy}","received_events_url":"https://api.github.com/users/haritha1313/received_events","type":"User","site_admin":false},"repo":{"id":113683272,"name":"mlpack","full_name":"haritha1313/mlpack","owner":{"login":"haritha1313","id":18036057,"avatar_url":"https://avatars3.githubusercontent.com/u/18036057?v=4","gravatar_id":"","url":"https://api.github.com/users/haritha1313","html_url":"https://github.com/haritha1313","followers_url":"https://api.github.com/users/haritha1313/followers","following_url":"https://api.github.com/users/haritha1313/following{/other_user}","gists_url":"https://api.github.com/users/haritha1313/gists{/gist_id}","starred_url":"https://api.github.com/users/haritha1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haritha1313/subscriptions","organizations_url":"https://api.github.com/users/haritha1313/orgs","repos_url":"https://api.github.com/users/haritha1313/repos","events_url":"https://api.github.com/users/haritha1313/events{/privacy}","received_events_url":"https://api.github.com/users/haritha1313/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haritha1313/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":true,"url":"https://api.github.com/repos/haritha1313/mlpack","forks_url":"https://api.github.com/repos/haritha1313/mlpack/forks","keys_url":"https://api.github.com/repos/haritha1313/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haritha1313/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haritha1313/mlpack/teams","hooks_url":"https://api.github.com/repos/haritha1313/mlpack/hooks","issue_events_url":"https://api.github.com/repos/haritha1313/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/haritha1313/mlpack/events","assignees_url":"https://api.github.com/repos/haritha1313/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/haritha1313/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/haritha1313/mlpack/tags","blobs_url":"https://api.github.com/repos/haritha1313/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haritha1313/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haritha1313/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/haritha1313/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haritha1313/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/haritha1313/mlpack/languages","stargazers_url":"https://api.github.com/repos/haritha1313/mlpack/stargazers","contributors_url":"https://api.github.com/repos/haritha1313/mlpack/contributors","subscribers_url":"https://api.github.com/repos/haritha1313/mlpack/subscribers","subscription_url":"https://api.github.com/repos/haritha1313/mlpack/subscription","commits_url":"https://api.github.com/repos/haritha1313/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/haritha1313/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/haritha1313/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/haritha1313/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/haritha1313/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/haritha1313/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haritha1313/mlpack/merges","archive_url":"https://api.github.com/repos/haritha1313/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haritha1313/mlpack/downloads","issues_url":"https://api.github.com/repos/haritha1313/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/haritha1313/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/haritha1313/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/haritha1313/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haritha1313/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/haritha1313/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/haritha1313/mlpack/deployments","created_at":"2017-12-09T16:21:16Z","updated_at":"2018-05-20T06:48:20Z","pushed_at":"2018-05-21T17:09:57Z","git_url":"git://github.com/haritha1313/mlpack.git","ssh_url":"git@github.com:haritha1313/mlpack.git","clone_url":"https://github.com/haritha1313/mlpack.git","svn_url":"https://github.com/haritha1313/mlpack","homepage":"http://www.mlpack.org/","size":243552,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"0ba2de6d4893c227b75e7f2cfa88b86729095e4f","user":{"login":"mlpack","id":10216045,"avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"name":"mlpack","full_name":"mlpack/mlpack","owner":{"login":"mlpack","id":10216045,"avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2018-05-21T17:16:09Z","pushed_at":"2018-05-21T17:15:55Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":"http://www.mlpack.org/","size":243524,"stargazers_count":2197,"watchers_count":2197,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":809,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":809,"open_issues":110,"watchers":2197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1355"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1355"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1355"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/386664f9d53e7866bfdee4a0f012531feb0acd65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rcurtin"}}