{"action":"created","issue":{"url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/370","repository_url":"https://api.github.com/repos/rust-analyzer/rust-analyzer","labels_url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/370/labels{/name}","comments_url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/370/comments","events_url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/370/events","html_url":"https://github.com/rust-analyzer/rust-analyzer/pull/370","id":394881192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDk2ODk1","number":370,"title":"Self params & type","user":{"login":"flodiebold","id":906069,"node_id":"MDQ6VXNlcjkwNjA2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/906069?v=4","gravatar_id":"","url":"https://api.github.com/users/flodiebold","html_url":"https://github.com/flodiebold","followers_url":"https://api.github.com/users/flodiebold/followers","following_url":"https://api.github.com/users/flodiebold/following{/other_user}","gists_url":"https://api.github.com/users/flodiebold/gists{/gist_id}","starred_url":"https://api.github.com/users/flodiebold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodiebold/subscriptions","organizations_url":"https://api.github.com/users/flodiebold/orgs","repos_url":"https://api.github.com/users/flodiebold/repos","events_url":"https://api.github.com/users/flodiebold/events{/privacy}","received_events_url":"https://api.github.com/users/flodiebold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-30T15:40:51Z","updated_at":"2019-01-04T18:32:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/pulls/370","html_url":"https://github.com/rust-analyzer/rust-analyzer/pull/370","diff_url":"https://github.com/rust-analyzer/rust-analyzer/pull/370.diff","patch_url":"https://github.com/rust-analyzer/rust-analyzer/pull/370.patch"},"body":"This implements type inference for `self`, so field completion for methods taking `self` works now.\r\n\r\n - rename `IMPL_ITEM` to `IMPL_BLOCK` -- rustc calls the methods etc. inside an impl `ImplItem`s, and the impl itself doesn't define an item, so I thought this name was clearer.\r\n - add HIR for impl blocks -- we collect all impls in a crate at once, so we can go from methods to containing impls, and since we will later also need to find all impls for a certain type (which may be anywhere in the crate, I think?). We could be more lazy here, but I don't know if it's worth the complexity.\r\n - resolve `self` and `Self` during type inference\r\n - refactor a bit in ty.rs as well"},"comment":{"url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/comments/451528475","html_url":"https://github.com/rust-analyzer/rust-analyzer/pull/370#issuecomment-451528475","issue_url":"https://api.github.com/repos/rust-analyzer/rust-analyzer/issues/370","id":451528475,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTUyODQ3NQ==","user":{"login":"flodiebold","id":906069,"node_id":"MDQ6VXNlcjkwNjA2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/906069?v=4","gravatar_id":"","url":"https://api.github.com/users/flodiebold","html_url":"https://github.com/flodiebold","followers_url":"https://api.github.com/users/flodiebold/followers","following_url":"https://api.github.com/users/flodiebold/following{/other_user}","gists_url":"https://api.github.com/users/flodiebold/gists{/gist_id}","starred_url":"https://api.github.com/users/flodiebold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodiebold/subscriptions","organizations_url":"https://api.github.com/users/flodiebold/orgs","repos_url":"https://api.github.com/users/flodiebold/repos","events_url":"https://api.github.com/users/flodiebold/events{/privacy}","received_events_url":"https://api.github.com/users/flodiebold/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T18:32:18Z","updated_at":"2019-01-04T18:32:18Z","author_association":"COLLABORATOR","body":"@matklad impls are now collected per module (so there's one arena per module). I didn't even implement the second step (collecting all the impls in a crate) now, since it wasn't necessary anymore for this."}}
{"actor":{"display_login":"flodiebold"}}