{"action":"created","comment":{"url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/comments/190431911","pull_request_review_id":122806036,"id":190431911,"diff_hunk":"@@ -0,0 +1,44 @@\n+// tslint:disable:no-expression-statement\n+// tslint:disable:no-let\n+\n+import * as models from '../tasks';\n+\n+describe('tasks reducer', () => {\n+    const fakeTask: models.Task = {\n+        'id': 'fake1',\n+        'taskDefinitionId': 'fake1Definition',\n+        'starred': false,\n+        'completed': false,\n+        'suggested': false,\n+    };\n+    const initialStore: models.Store = models.reducer(\n+        {tasks: {}, taskDefinitions: {}},\n+        models.addToTaskList(fakeTask),","path":"src/stores/__tests__/tasks.test.ts","position":null,"original_position":16,"commit_id":"3cbee16a9dfa739c47263be05b6edcf8d2517106","original_commit_id":"4f72bc8eee2bb46ff1ac0f8051d97bd9d6e3f652","user":{"login":"bensinjin","id":3228323,"avatar_url":"https://avatars2.githubusercontent.com/u/3228323?v=4","gravatar_id":"","url":"https://api.github.com/users/bensinjin","html_url":"https://github.com/bensinjin","followers_url":"https://api.github.com/users/bensinjin/followers","following_url":"https://api.github.com/users/bensinjin/following{/other_user}","gists_url":"https://api.github.com/users/bensinjin/gists{/gist_id}","starred_url":"https://api.github.com/users/bensinjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensinjin/subscriptions","organizations_url":"https://api.github.com/users/bensinjin/orgs","repos_url":"https://api.github.com/users/bensinjin/repos","events_url":"https://api.github.com/users/bensinjin/events{/privacy}","received_events_url":"https://api.github.com/users/bensinjin/received_events","type":"User","site_admin":false},"body":"This is now using a builder. It is still, however, passing the store from the builder to the reducer and checking the state after actions are applied ... I'm not sure I follow why that would be a code smell?","created_at":"2018-05-23T23:49:32Z","updated_at":"2018-05-23T23:49:32Z","html_url":"https://github.com/pg-irc/pathways-frontend/pull/65#discussion_r190431911","pull_request_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/comments/190431911"},"html":{"href":"https://github.com/pg-irc/pathways-frontend/pull/65#discussion_r190431911"},"pull_request":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65"}},"in_reply_to_id":190003869},"pull_request":{"url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65","id":188889356,"html_url":"https://github.com/pg-irc/pathways-frontend/pull/65","diff_url":"https://github.com/pg-irc/pathways-frontend/pull/65.diff","patch_url":"https://github.com/pg-irc/pathways-frontend/pull/65.patch","issue_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/65","number":65,"state":"open","locked":false,"title":"Feature/issue #42 & #44 tasks and tasks list","user":{"login":"bensinjin","id":3228323,"avatar_url":"https://avatars2.githubusercontent.com/u/3228323?v=4","gravatar_id":"","url":"https://api.github.com/users/bensinjin","html_url":"https://github.com/bensinjin","followers_url":"https://api.github.com/users/bensinjin/followers","following_url":"https://api.github.com/users/bensinjin/following{/other_user}","gists_url":"https://api.github.com/users/bensinjin/gists{/gist_id}","starred_url":"https://api.github.com/users/bensinjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensinjin/subscriptions","organizations_url":"https://api.github.com/users/bensinjin/orgs","repos_url":"https://api.github.com/users/bensinjin/repos","events_url":"https://api.github.com/users/bensinjin/events{/privacy}","received_events_url":"https://api.github.com/users/bensinjin/received_events","type":"User","site_admin":false},"body":"@tnightingale @trisapeace @rasmus-storjohann-PG  So this is the first crack at tasks and task list(s). I suspect very much this will evolve. Following I've outlined what I've implemented and assumptions I've made:\r\n\r\n- A \"task\" currently represents an actionable item a user can interact with ie. add/remove/star/share\r\n- A task holds a reference to its \"definition\" as defined by pathways.  A task definition includes for example a title, description, tags, category etc... The separation here allows us to update task definition data without touching task data.\r\n- A task list is a container for tasks. I'd intend this to be used for \"saved tasks\", \"suggested tasks\", \"sub tasks\" etc...\r\n- The \"My Plan\" page currently displays tasks taken from what I'd envision to be the user's \"saved tasks\".  I've rendered it twice just to demonstrate what some of the newer designs suggest .. naturally UI state is not wired up (see below).\r\n\r\nAll the necessary functionality for tasks to \"work\" is currently in place (run the tests).  I've not wired up the UI to demonstrate how the actions work as that would fall out of the scope of issues #42 & #44.  I'd like to see the next tasks related issue be around demonstration how to we can add tasks from the suggested list into the saved list or something along those lines. Anyways let me know what you think and cheers for the feedback.\r\n","created_at":"2018-05-17T23:47:42Z","updated_at":"2018-05-23T23:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5fd08740b018d9d7190e974483c242bd1d5f342","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65/commits","review_comments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65/comments","review_comment_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/65/comments","statuses_url":"https://api.github.com/repos/pg-irc/pathways-frontend/statuses/3cbee16a9dfa739c47263be05b6edcf8d2517106","head":{"label":"pg-irc:feature/Issue_44_tasks_and_tasks_list","ref":"feature/Issue_44_tasks_and_tasks_list","sha":"3cbee16a9dfa739c47263be05b6edcf8d2517106","user":{"login":"pg-irc","id":30124065,"avatar_url":"https://avatars3.githubusercontent.com/u/30124065?v=4","gravatar_id":"","url":"https://api.github.com/users/pg-irc","html_url":"https://github.com/pg-irc","followers_url":"https://api.github.com/users/pg-irc/followers","following_url":"https://api.github.com/users/pg-irc/following{/other_user}","gists_url":"https://api.github.com/users/pg-irc/gists{/gist_id}","starred_url":"https://api.github.com/users/pg-irc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pg-irc/subscriptions","organizations_url":"https://api.github.com/users/pg-irc/orgs","repos_url":"https://api.github.com/users/pg-irc/repos","events_url":"https://api.github.com/users/pg-irc/events{/privacy}","received_events_url":"https://api.github.com/users/pg-irc/received_events","type":"Organization","site_admin":false},"repo":{"id":99282566,"name":"pathways-frontend","full_name":"pg-irc/pathways-frontend","owner":{"login":"pg-irc","id":30124065,"avatar_url":"https://avatars3.githubusercontent.com/u/30124065?v=4","gravatar_id":"","url":"https://api.github.com/users/pg-irc","html_url":"https://github.com/pg-irc","followers_url":"https://api.github.com/users/pg-irc/followers","following_url":"https://api.github.com/users/pg-irc/following{/other_user}","gists_url":"https://api.github.com/users/pg-irc/gists{/gist_id}","starred_url":"https://api.github.com/users/pg-irc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pg-irc/subscriptions","organizations_url":"https://api.github.com/users/pg-irc/orgs","repos_url":"https://api.github.com/users/pg-irc/repos","events_url":"https://api.github.com/users/pg-irc/events{/privacy}","received_events_url":"https://api.github.com/users/pg-irc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pg-irc/pathways-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/pg-irc/pathways-frontend","forks_url":"https://api.github.com/repos/pg-irc/pathways-frontend/forks","keys_url":"https://api.github.com/repos/pg-irc/pathways-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pg-irc/pathways-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pg-irc/pathways-frontend/teams","hooks_url":"https://api.github.com/repos/pg-irc/pathways-frontend/hooks","issue_events_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/pg-irc/pathways-frontend/events","assignees_url":"https://api.github.com/repos/pg-irc/pathways-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/pg-irc/pathways-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/pg-irc/pathways-frontend/tags","blobs_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pg-irc/pathways-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/pg-irc/pathways-frontend/languages","stargazers_url":"https://api.github.com/repos/pg-irc/pathways-frontend/stargazers","contributors_url":"https://api.github.com/repos/pg-irc/pathways-frontend/contributors","subscribers_url":"https://api.github.com/repos/pg-irc/pathways-frontend/subscribers","subscription_url":"https://api.github.com/repos/pg-irc/pathways-frontend/subscription","commits_url":"https://api.github.com/repos/pg-irc/pathways-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pg-irc/pathways-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/pg-irc/pathways-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pg-irc/pathways-frontend/merges","archive_url":"https://api.github.com/repos/pg-irc/pathways-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pg-irc/pathways-frontend/downloads","issues_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/pg-irc/pathways-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/pg-irc/pathways-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pg-irc/pathways-frontend/labels{/name}","releases_url":"https://api.github.com/repos/pg-irc/pathways-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/deployments","created_at":"2017-08-03T23:15:59Z","updated_at":"2018-05-14T19:16:03Z","pushed_at":"2018-05-23T23:43:37Z","git_url":"git://github.com/pg-irc/pathways-frontend.git","ssh_url":"git@github.com:pg-irc/pathways-frontend.git","clone_url":"https://github.com/pg-irc/pathways-frontend.git","svn_url":"https://github.com/pg-irc/pathways-frontend","homepage":null,"size":997,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":2,"open_issues":40,"watchers":5,"default_branch":"master"}},"base":{"label":"pg-irc:master","ref":"master","sha":"6e14fcc18e2add18eef20cc82785978d11e39756","user":{"login":"pg-irc","id":30124065,"avatar_url":"https://avatars3.githubusercontent.com/u/30124065?v=4","gravatar_id":"","url":"https://api.github.com/users/pg-irc","html_url":"https://github.com/pg-irc","followers_url":"https://api.github.com/users/pg-irc/followers","following_url":"https://api.github.com/users/pg-irc/following{/other_user}","gists_url":"https://api.github.com/users/pg-irc/gists{/gist_id}","starred_url":"https://api.github.com/users/pg-irc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pg-irc/subscriptions","organizations_url":"https://api.github.com/users/pg-irc/orgs","repos_url":"https://api.github.com/users/pg-irc/repos","events_url":"https://api.github.com/users/pg-irc/events{/privacy}","received_events_url":"https://api.github.com/users/pg-irc/received_events","type":"Organization","site_admin":false},"repo":{"id":99282566,"name":"pathways-frontend","full_name":"pg-irc/pathways-frontend","owner":{"login":"pg-irc","id":30124065,"avatar_url":"https://avatars3.githubusercontent.com/u/30124065?v=4","gravatar_id":"","url":"https://api.github.com/users/pg-irc","html_url":"https://github.com/pg-irc","followers_url":"https://api.github.com/users/pg-irc/followers","following_url":"https://api.github.com/users/pg-irc/following{/other_user}","gists_url":"https://api.github.com/users/pg-irc/gists{/gist_id}","starred_url":"https://api.github.com/users/pg-irc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pg-irc/subscriptions","organizations_url":"https://api.github.com/users/pg-irc/orgs","repos_url":"https://api.github.com/users/pg-irc/repos","events_url":"https://api.github.com/users/pg-irc/events{/privacy}","received_events_url":"https://api.github.com/users/pg-irc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pg-irc/pathways-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/pg-irc/pathways-frontend","forks_url":"https://api.github.com/repos/pg-irc/pathways-frontend/forks","keys_url":"https://api.github.com/repos/pg-irc/pathways-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pg-irc/pathways-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pg-irc/pathways-frontend/teams","hooks_url":"https://api.github.com/repos/pg-irc/pathways-frontend/hooks","issue_events_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/pg-irc/pathways-frontend/events","assignees_url":"https://api.github.com/repos/pg-irc/pathways-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/pg-irc/pathways-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/pg-irc/pathways-frontend/tags","blobs_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pg-irc/pathways-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/pg-irc/pathways-frontend/languages","stargazers_url":"https://api.github.com/repos/pg-irc/pathways-frontend/stargazers","contributors_url":"https://api.github.com/repos/pg-irc/pathways-frontend/contributors","subscribers_url":"https://api.github.com/repos/pg-irc/pathways-frontend/subscribers","subscription_url":"https://api.github.com/repos/pg-irc/pathways-frontend/subscription","commits_url":"https://api.github.com/repos/pg-irc/pathways-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pg-irc/pathways-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pg-irc/pathways-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/pg-irc/pathways-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pg-irc/pathways-frontend/merges","archive_url":"https://api.github.com/repos/pg-irc/pathways-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pg-irc/pathways-frontend/downloads","issues_url":"https://api.github.com/repos/pg-irc/pathways-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/pg-irc/pathways-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/pg-irc/pathways-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pg-irc/pathways-frontend/labels{/name}","releases_url":"https://api.github.com/repos/pg-irc/pathways-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/pg-irc/pathways-frontend/deployments","created_at":"2017-08-03T23:15:59Z","updated_at":"2018-05-14T19:16:03Z","pushed_at":"2018-05-23T23:43:37Z","git_url":"git://github.com/pg-irc/pathways-frontend.git","ssh_url":"git@github.com:pg-irc/pathways-frontend.git","clone_url":"https://github.com/pg-irc/pathways-frontend.git","svn_url":"https://github.com/pg-irc/pathways-frontend","homepage":null,"size":997,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":2,"open_issues":40,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65"},"html":{"href":"https://github.com/pg-irc/pathways-frontend/pull/65"},"issue":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/65"},"comments":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/pg-irc/pathways-frontend/statuses/3cbee16a9dfa739c47263be05b6edcf8d2517106"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bensinjin"}}