{"action":"created","issue":{"url":"https://api.github.com/repos/libretro/RetroArch/issues/7102","repository_url":"https://api.github.com/repos/libretro/RetroArch","labels_url":"https://api.github.com/repos/libretro/RetroArch/issues/7102/labels{/name}","comments_url":"https://api.github.com/repos/libretro/RetroArch/issues/7102/comments","events_url":"https://api.github.com/repos/libretro/RetroArch/issues/7102/events","html_url":"https://github.com/libretro/RetroArch/pull/7102","id":352428192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzM5OTc4","number":7102,"title":"Don't unload content if it was never loaded.","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-21T08:03:31Z","updated_at":"2018-08-21T14:33:03Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/libretro/RetroArch/pulls/7102","html_url":"https://github.com/libretro/RetroArch/pull/7102","diff_url":"https://github.com/libretro/RetroArch/pull/7102.diff","patch_url":"https://github.com/libretro/RetroArch/pull/7102.patch"},"body":"## Description\r\n\r\nFixes crashes for a few more cores when loading the core without content.\r\n\r\nPlease see the nxengine issue report Alcaro closed with:\r\n\r\n> At this point, retro_load_game has not returned true, or been called at all. As such, calling this function is not allowed. Frontend bug.\r\n\r\nThis fixes the crashes for `mame2000`, `nxengine`  and `reicast`.\r\n\r\nUnfortunately `lutro` and `hatari` still crash.\r\n\r\nNote that I tested this with a lot of cores without finding regressions, but there are still untested cores...\r\n\r\n## Related Issues\r\n\r\nhttps://github.com/libretro/RetroArch/issues/4493\r\nhttps://github.com/libretro/RetroArch/issues/7082\r\nhttps://github.com/libretro/nxengine-libretro/issues/29\r\n\r\n## Related Pull Requests\r\n\r\nhttps://github.com/libretro/RetroArch/pull/7090\r\n\r\n## Reviewers\r\n\r\n@twinaphex and @Dwedit Does this look right to you?\r\n"},"comment":{"url":"https://api.github.com/repos/libretro/RetroArch/issues/comments/414695725","html_url":"https://github.com/libretro/RetroArch/pull/7102#issuecomment-414695725","issue_url":"https://api.github.com/repos/libretro/RetroArch/issues/7102","id":414695725,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDY5NTcyNQ==","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T14:33:03Z","updated_at":"2018-08-21T14:33:03Z","author_association":"COLLABORATOR","body":"I can also avoid `current_core.game_loaded = false;` too? I understand it would just be redundant?"}}
{"actor":{"display_login":"orbea"}}