{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/2198","repository_url":"https://api.github.com/repos/wireapp/wire-ios","labels_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2198/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2198/comments","events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2198/events","html_url":"https://github.com/wireapp/wire-ios/pull/2198","id":327251279,"number":2198,"title":"Fix: iPad - photo picker popover size is not consistent","user":{"login":"billypchan","id":11852044,"avatar_url":"https://avatars3.githubusercontent.com/u/11852044?v=4","gravatar_id":"","url":"https://api.github.com/users/billypchan","html_url":"https://github.com/billypchan","followers_url":"https://api.github.com/users/billypchan/followers","following_url":"https://api.github.com/users/billypchan/following{/other_user}","gists_url":"https://api.github.com/users/billypchan/gists{/gist_id}","starred_url":"https://api.github.com/users/billypchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billypchan/subscriptions","organizations_url":"https://api.github.com/users/billypchan/orgs","repos_url":"https://api.github.com/users/billypchan/repos","events_url":"https://api.github.com/users/billypchan/events{/privacy}","received_events_url":"https://api.github.com/users/billypchan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-29T10:01:08Z","updated_at":"2018-05-29T10:21:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/2198","html_url":"https://github.com/wireapp/wire-ios/pull/2198","diff_url":"https://github.com/wireapp/wire-ios/pull/2198.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/2198.patch"},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nPhoto picker's size resize to 320px width after the user had selected the album\r\n\r\n### Solutions\r\n\r\nSet preferredContentSize to standard size (320x568) for photo picker popover on iPad.\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments/392727837","html_url":"https://github.com/wireapp/wire-ios/pull/2198#issuecomment-392727837","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/2198","id":392727837,"user":{"login":"wire-bot","id":20773876,"avatar_url":"https://avatars3.githubusercontent.com/u/20773876?v=4","gravatar_id":"","url":"https://api.github.com/users/wire-bot","html_url":"https://github.com/wire-bot","followers_url":"https://api.github.com/users/wire-bot/followers","following_url":"https://api.github.com/users/wire-bot/following{/other_user}","gists_url":"https://api.github.com/users/wire-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wire-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wire-bot/subscriptions","organizations_url":"https://api.github.com/users/wire-bot/orgs","repos_url":"https://api.github.com/users/wire-bot/repos","events_url":"https://api.github.com/users/wire-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wire-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T10:21:46Z","updated_at":"2018-05-29T10:21:46Z","author_association":"COLLABORATOR","body":"<!--\n  0 Errors\n  9 Warnings: ld: linking against a dylib wh...\n  0 Messages\n  0 Markdowns\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          9 Warnings\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/WireSyncEngine.framework/WireSyncEngine</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/WireRequestStrategy.framework/WireRequestStrategy</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/FormatterKit.framework/FormatterKit</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/PureLayout.framework/PureLayout</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/PINCache.framework/PINCache</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/avs.framework/avs</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">ld: linking against a dylib which is not safe for use in application extensions: /Users/distiller/project/Carthage/Build/iOS/HockeySDK.framework/HockeySDK</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/wireapp/wire-ios/blob/127483ddd6b9a34e5203ac4005e74f977a3b69d7/Carthage/Build/iOS/Classy.framework/Headers/CASUtilities.h#L28\">Carthage/Build/iOS/Classy.framework/Headers/CASUtilities.h#L28</a></strong>: this function declaration is not a prototype [-Wstrict-prototypes]  <br /><code>\nNSUInteger CASKeyDeviceSystemMajorVersion();\n</code></td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><strong><a href=\"https://github.com/wireapp/wire-ios/blob/127483ddd6b9a34e5203ac4005e74f977a3b69d7/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+PinchZoom.m#L80\">Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+PinchZoom.m#L80</a></strong>: assigning to ‘__strong id&lt;MediaAsset&gt;’ from incompatible type ‘UIImage * _Nullable’  <br /><code>\n                image = [UIImage imageWithData:message.imageMessageData.imageData];\n</code></td>\n    </tr>\n  </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"wire-bot"}}