{"comment":{"url":"https://api.github.com/repos/jagotu/Cxbx-Reloaded/comments/29112640","html_url":"https://github.com/jagotu/Cxbx-Reloaded/commit/02289c6c96b7daab939e6e75b7ae4cdf6aec0718#commitcomment-29112640","id":29112640,"user":{"login":"ergo720","id":30000751,"avatar_url":"https://avatars1.githubusercontent.com/u/30000751?v=4","gravatar_id":"","url":"https://api.github.com/users/ergo720","html_url":"https://github.com/ergo720","followers_url":"https://api.github.com/users/ergo720/followers","following_url":"https://api.github.com/users/ergo720/following{/other_user}","gists_url":"https://api.github.com/users/ergo720/gists{/gist_id}","starred_url":"https://api.github.com/users/ergo720/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergo720/subscriptions","organizations_url":"https://api.github.com/users/ergo720/orgs","repos_url":"https://api.github.com/users/ergo720/repos","events_url":"https://api.github.com/users/ergo720/events{/privacy}","received_events_url":"https://api.github.com/users/ergo720/received_events","type":"User","site_admin":false},"position":27,"line":2151,"path":"src/CxbxKrnl/VMManager.cpp","commit_id":"02289c6c96b7daab939e6e75b7ae4cdf6aec0718","created_at":"2018-05-24T11:56:41Z","updated_at":"2018-05-24T11:56:41Z","author_association":"NONE","body":"Yeah, I realized the error in the original code was the missing else in the inner if statement. Without it, the memory will always be marked as XBOX_MEM_RESERVE even when it should have been XBOX_MEM_COMMIT"}}
{"actor":{"display_login":"ergo720"}}