{"action":"opened","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/239","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/239/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/239/events","html_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/issues/239","id":336024752,"node_id":"MDU6SXNzdWUzMzYwMjQ3NTI=","number":239,"title":"Pods with failing health checks cannot be deleted","user":{"login":"sabbyanandan","id":1562654,"node_id":"MDQ6VXNlcjE1NjI2NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1562654?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbyanandan","html_url":"https://github.com/sabbyanandan","followers_url":"https://api.github.com/users/sabbyanandan/followers","following_url":"https://api.github.com/users/sabbyanandan/following{/other_user}","gists_url":"https://api.github.com/users/sabbyanandan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbyanandan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbyanandan/subscriptions","organizations_url":"https://api.github.com/users/sabbyanandan/orgs","repos_url":"https://api.github.com/users/sabbyanandan/repos","events_url":"https://api.github.com/users/sabbyanandan/events{/privacy}","received_events_url":"https://api.github.com/users/sabbyanandan/received_events","type":"User","site_admin":false},"labels":[{"id":357499329,"node_id":"MDU6TGFiZWwzNTc0OTkzMjk=","url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/labels/ready","name":"ready","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-26T23:20:00Z","updated_at":"2018-06-26T23:20:00Z","closed_at":null,"author_association":"MEMBER","body":"As a user, while iterating on Boot 2.0's health/info actuator endpoints, with a wrong endpoint (and, liveness/readiness probes failing to connect to it), I'm unable to cleanly delete the pods through `undeploy()` operation. \r\n\r\nMaybe there's an exception that either we drop or it could SCDF isn't handling the response appropriately. Let's review this scenario in the deployer, to begin with; as needed, we can move it to SCDF.\r\n\r\nTo reproduce,\r\n- deploy a stream with 2.0 Apps (via SCDF) _without_ `livenessProbePath` and `readinessProbePath` configs\r\n- notice the failing health checks (via liveness/readiness probes; do a `kubectl describe <app-pod>` to confirm the failure events)\r\n- destroy the stream\r\n- notice the stubborn pods still hanging out as if nothing has happened"}}
{"actor":{"display_login":"sabbyanandan"}}