{"action":"created","issue":{"url":"https://api.github.com/repos/ccd0/4chan-x/issues/1910","repository_url":"https://api.github.com/repos/ccd0/4chan-x","labels_url":"https://api.github.com/repos/ccd0/4chan-x/issues/1910/labels{/name}","comments_url":"https://api.github.com/repos/ccd0/4chan-x/issues/1910/comments","events_url":"https://api.github.com/repos/ccd0/4chan-x/issues/1910/events","html_url":"https://github.com/ccd0/4chan-x/issues/1910","id":321759072,"node_id":"MDU6SXNzdWUzMjE3NTkwNzI=","number":1910,"title":"Keeps forgetting hidden threads","user":{"login":"alidan","id":2681758,"node_id":"MDQ6VXNlcjI2ODE3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2681758?v=4","gravatar_id":"","url":"https://api.github.com/users/alidan","html_url":"https://github.com/alidan","followers_url":"https://api.github.com/users/alidan/followers","following_url":"https://api.github.com/users/alidan/following{/other_user}","gists_url":"https://api.github.com/users/alidan/gists{/gist_id}","starred_url":"https://api.github.com/users/alidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alidan/subscriptions","organizations_url":"https://api.github.com/users/alidan/orgs","repos_url":"https://api.github.com/users/alidan/repos","events_url":"https://api.github.com/users/alidan/events{/privacy}","received_events_url":"https://api.github.com/users/alidan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":63,"created_at":"2018-05-09T23:25:03Z","updated_at":"2018-06-22T05:45:03Z","closed_at":null,"author_association":"NONE","body":"Long story short, I open and hide threads, I keep the threads saved, and I load them up when they 404 to scrape images. \r\nI have been opening threads with a middle click and shift click macro for each thread I want to keep up with, then closing them out in tab outliner\r\nHowever I just went to most of the boards I do this to, and they move slow enough that there is no way in hell I only have 4 hidden threads (the threads that I hide based on filters) \r\n\r\nim on  1.13.15.11 of the extension version."},"comment":{"url":"https://api.github.com/repos/ccd0/4chan-x/issues/comments/399327112","html_url":"https://github.com/ccd0/4chan-x/issues/1910#issuecomment-399327112","issue_url":"https://api.github.com/repos/ccd0/4chan-x/issues/1910","id":399327112,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTMyNzExMg==","user":{"login":"bakugo","id":6014513,"node_id":"MDQ6VXNlcjYwMTQ1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6014513?v=4","gravatar_id":"","url":"https://api.github.com/users/bakugo","html_url":"https://github.com/bakugo","followers_url":"https://api.github.com/users/bakugo/followers","following_url":"https://api.github.com/users/bakugo/following{/other_user}","gists_url":"https://api.github.com/users/bakugo/gists{/gist_id}","starred_url":"https://api.github.com/users/bakugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakugo/subscriptions","organizations_url":"https://api.github.com/users/bakugo/orgs","repos_url":"https://api.github.com/users/bakugo/repos","events_url":"https://api.github.com/users/bakugo/events{/privacy}","received_events_url":"https://api.github.com/users/bakugo/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T05:45:03Z","updated_at":"2018-06-22T05:45:03Z","author_association":"CONTRIBUTOR","body":"Found the issue (I think)\r\n\r\nIt's actually not related to storage at all, it's caused by [DataBoard's ajaxClean function](https://github.com/ccd0/4chan-x/blob/6e2c93e09e2704d14f96b580909651a881429cae/src/classes/DataBoard.coffee#L124). Occasionally, when the second callback (for archive.json) is executed, the response of the first request (for threads.json) `e1.target.response` is null and this gets passed to ajaxCleanParse which clears every active thread as a result. I have no idea what causes the response to become null over time (this might be worth investigating) but simply storing it in a variable during the first callback should fix it. I'm using Chrome 67, in case this behavior is browser specific.\r\n\r\nThe Hidden button in the settings is also broken due to another problem: it was not updated for multisite support. The hiddenThreads and hiddenPosts storage keys can contain data split by site, but the button doesn't handle that, it just tries to read hiddenThreads.boards directly when it can be at hiddenThreads[\"4chan.org\"].boards instead."}}
{"actor":{"display_login":"bakugo"}}