{"action":"closed","number":3085,"pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085","id":219257368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjU3MzY4","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3085","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/3085.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/3085.patch","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3085","number":3085,"state":"closed","locked":false,"title":"Don't let the same doctype be selectable twice in the Nested Content configuration","user":{"login":"kjac","id":7405322,"node_id":"MDQ6VXNlcjc0MDUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7405322?v=4","gravatar_id":"","url":"https://api.github.com/users/kjac","html_url":"https://github.com/kjac","followers_url":"https://api.github.com/users/kjac/followers","following_url":"https://api.github.com/users/kjac/following{/other_user}","gists_url":"https://api.github.com/users/kjac/gists{/gist_id}","starred_url":"https://api.github.com/users/kjac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjac/subscriptions","organizations_url":"https://api.github.com/users/kjac/orgs","repos_url":"https://api.github.com/users/kjac/repos","events_url":"https://api.github.com/users/kjac/events{/privacy}","received_events_url":"https://api.github.com/users/kjac/received_events","type":"User","site_admin":false},"body":"### Prerequisites\r\n\r\n- [x] I have [created an issue](https://github.com/umbraco/Umbraco-CMS/issues) for the proposed changes in this PR, the link is: https://github.com/umbraco/Umbraco-CMS/issues/3081\r\n- [x] I have added steps to test this contribution in the description below\r\n\r\n### Description\r\nThis PR ensures that the already used doctypes are no longer selectable when configuring a Nested Content property.\r\n\r\n![nc config after 1](https://user-images.githubusercontent.com/7405322/46269812-bf6ef200-c543-11e8-9180-ce262b2389c1.png)\r\n\r\n![nc config after 2](https://user-images.githubusercontent.com/7405322/46269815-c1d14c00-c543-11e8-9604-c99451a3bb18.png)\r\n\r\nTo test it:\r\n\r\n1. Create a Nested Content data type\r\n2. Start adding doctypes to the configuration\r\n3. As you add doctypes, verify that the already added ones can't be added again\r\n4. Verify that the selected doctype can still be selected for an existing item in the configuration\r\n\r\n","created_at":"2018-10-01T04:34:54Z","updated_at":"2018-10-03T14:52:59Z","closed_at":"2018-10-03T14:52:59Z","merged_at":"2018-10-03T14:52:59Z","merge_commit_sha":"e80c450e4241ea71180767f030587b58b8c44f21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085/commits","review_comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085/comments","review_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3085/comments","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/2c9256c6724d2e840b0b267657a3db930f00e225","head":{"label":"kjac:fix-nc-config-duplicate-doctypes","ref":"fix-nc-config-duplicate-doctypes","sha":"2c9256c6724d2e840b0b267657a3db930f00e225","user":{"login":"kjac","id":7405322,"node_id":"MDQ6VXNlcjc0MDUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7405322?v=4","gravatar_id":"","url":"https://api.github.com/users/kjac","html_url":"https://github.com/kjac","followers_url":"https://api.github.com/users/kjac/followers","following_url":"https://api.github.com/users/kjac/following{/other_user}","gists_url":"https://api.github.com/users/kjac/gists{/gist_id}","starred_url":"https://api.github.com/users/kjac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjac/subscriptions","organizations_url":"https://api.github.com/users/kjac/orgs","repos_url":"https://api.github.com/users/kjac/repos","events_url":"https://api.github.com/users/kjac/events{/privacy}","received_events_url":"https://api.github.com/users/kjac/received_events","type":"User","site_admin":false},"repo":{"id":121970810,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5NzA4MTA=","name":"Umbraco-CMS","full_name":"kjac/Umbraco-CMS","private":false,"owner":{"login":"kjac","id":7405322,"node_id":"MDQ6VXNlcjc0MDUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7405322?v=4","gravatar_id":"","url":"https://api.github.com/users/kjac","html_url":"https://github.com/kjac","followers_url":"https://api.github.com/users/kjac/followers","following_url":"https://api.github.com/users/kjac/following{/other_user}","gists_url":"https://api.github.com/users/kjac/gists{/gist_id}","starred_url":"https://api.github.com/users/kjac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjac/subscriptions","organizations_url":"https://api.github.com/users/kjac/orgs","repos_url":"https://api.github.com/users/kjac/repos","events_url":"https://api.github.com/users/kjac/events{/privacy}","received_events_url":"https://api.github.com/users/kjac/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kjac/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 400.000 websites","fork":true,"url":"https://api.github.com/repos/kjac/Umbraco-CMS","forks_url":"https://api.github.com/repos/kjac/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/kjac/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjac/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjac/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/kjac/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/kjac/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/kjac/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/kjac/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/kjac/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/kjac/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/kjac/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjac/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjac/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjac/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjac/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/kjac/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/kjac/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/kjac/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/kjac/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/kjac/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/kjac/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjac/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjac/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjac/Umbraco-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjac/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/kjac/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjac/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/kjac/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjac/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/kjac/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/kjac/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/kjac/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/kjac/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjac/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/kjac/Umbraco-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/kjac/Umbraco-CMS/deployments","created_at":"2018-02-18T16:55:46Z","updated_at":"2018-02-18T16:56:02Z","pushed_at":"2018-10-03T14:44:24Z","git_url":"git://github.com/kjac/Umbraco-CMS.git","ssh_url":"git@github.com:kjac/Umbraco-CMS.git","clone_url":"https://github.com/kjac/Umbraco-CMS.git","svn_url":"https://github.com/kjac/Umbraco-CMS","homepage":"http://umbraco.com","size":155581,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev-v7.8"}},"base":{"label":"umbraco:dev-v7","ref":"dev-v7","sha":"328b4b155663bea7f7354ce50165177e0003fe61","user":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"repo":{"id":10601208,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMTIwOA==","name":"Umbraco-CMS","full_name":"umbraco/Umbraco-CMS","private":false,"owner":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/umbraco/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 400.000 websites","fork":false,"url":"https://api.github.com/repos/umbraco/Umbraco-CMS","forks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/deployments","created_at":"2013-06-10T13:50:46Z","updated_at":"2018-10-03T14:33:47Z","pushed_at":"2018-10-03T14:52:59Z","git_url":"git://github.com/umbraco/Umbraco-CMS.git","ssh_url":"git@github.com:umbraco/Umbraco-CMS.git","clone_url":"https://github.com/umbraco/Umbraco-CMS.git","svn_url":"https://github.com/umbraco/Umbraco-CMS","homepage":"https://umbraco.com","size":164426,"stargazers_count":2141,"watchers_count":2141,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1615,"mirror_url":null,"archived":false,"open_issues_count":198,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1615,"open_issues":198,"watchers":2141,"default_branch":"dev-v7"}},"_links":{"self":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085"},"html":{"href":"https://github.com/umbraco/Umbraco-CMS/pull/3085"},"issue":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3085"},"comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3085/comments"},"review_comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085/comments"},"review_comment":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3085/commits"},"statuses":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/2c9256c6724d2e840b0b267657a3db930f00e225"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nul800sebastiaan","id":304656,"node_id":"MDQ6VXNlcjMwNDY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/304656?v=4","gravatar_id":"","url":"https://api.github.com/users/nul800sebastiaan","html_url":"https://github.com/nul800sebastiaan","followers_url":"https://api.github.com/users/nul800sebastiaan/followers","following_url":"https://api.github.com/users/nul800sebastiaan/following{/other_user}","gists_url":"https://api.github.com/users/nul800sebastiaan/gists{/gist_id}","starred_url":"https://api.github.com/users/nul800sebastiaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nul800sebastiaan/subscriptions","organizations_url":"https://api.github.com/users/nul800sebastiaan/orgs","repos_url":"https://api.github.com/users/nul800sebastiaan/repos","events_url":"https://api.github.com/users/nul800sebastiaan/events{/privacy}","received_events_url":"https://api.github.com/users/nul800sebastiaan/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"nul800sebastiaan"}}