{"action":"created","comment":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/188299492","pull_request_review_id":120248417,"id":188299492,"diff_hunk":"@@ -2518,31 +2513,31 @@ AqlValue Functions::DateFromParameters(\n \n       // All Parameters have to be a number or a string\n       if (!value.isNumber() && !value.isString()) {\n-        RegisterInvalidArgumentWarning(query, funcName.c_str());\n+        RegisterInvalidArgumentWarning(query, AFN);\n         return AqlValue(AqlValueHintNull());\n       }\n     }\n \n     // Parse the Year\n     years y{ExtractFunctionParameterValue(parameters, 0).toInt64(trx)};","path":"arangod/Aql/Functions.cpp","position":76,"original_position":76,"commit_id":"b9094be036fea7bdc8a59f210def75b36d05ecd6","original_commit_id":"774f99e8089dd44714fef4d50f9b59b335850fab","user":{"login":"dothebart","id":5013077,"avatar_url":"https://avatars1.githubusercontent.com/u/5013077?v=4","gravatar_id":"","url":"https://api.github.com/users/dothebart","html_url":"https://github.com/dothebart","followers_url":"https://api.github.com/users/dothebart/followers","following_url":"https://api.github.com/users/dothebart/following{/other_user}","gists_url":"https://api.github.com/users/dothebart/gists{/gist_id}","starred_url":"https://api.github.com/users/dothebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dothebart/subscriptions","organizations_url":"https://api.github.com/users/dothebart/orgs","repos_url":"https://api.github.com/users/dothebart/repos","events_url":"https://api.github.com/users/dothebart/events{/privacy}","received_events_url":"https://api.github.com/users/dothebart/received_events","type":"User","site_admin":false},"body":"I don't get it. its a loop over all params, they have to be string or number. what could be changed here? This part of the patch barely switches the function name from the outside to `const char *`","created_at":"2018-05-15T14:04:16Z","updated_at":"2018-05-15T14:04:16Z","html_url":"https://github.com/arangodb/arangodb/pull/5294#discussion_r188299492","pull_request_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/188299492"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5294#discussion_r188299492"},"pull_request":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5294"}},"in_reply_to_id":187005168},"pull_request":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/5294","id":186604973,"html_url":"https://github.com/arangodb/arangodb/pull/5294","diff_url":"https://github.com/arangodb/arangodb/pull/5294.diff","patch_url":"https://github.com/arangodb/arangodb/pull/5294.patch","issue_url":"https://api.github.com/repos/arangodb/arangodb/issues/5294","number":5294,"state":"open","locked":false,"title":"Feature/aql format date","user":{"login":"dothebart","id":5013077,"avatar_url":"https://avatars1.githubusercontent.com/u/5013077?v=4","gravatar_id":"","url":"https://api.github.com/users/dothebart","html_url":"https://github.com/dothebart","followers_url":"https://api.github.com/users/dothebart/followers","following_url":"https://api.github.com/users/dothebart/following{/other_user}","gists_url":"https://api.github.com/users/dothebart/gists{/gist_id}","starred_url":"https://api.github.com/users/dothebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dothebart/subscriptions","organizations_url":"https://api.github.com/users/dothebart/orgs","repos_url":"https://api.github.com/users/dothebart/repos","events_url":"https://api.github.com/users/dothebart/events{/privacy}","received_events_url":"https://api.github.com/users/dothebart/received_events","type":"User","site_admin":false},"body":"implement DATE_FORMAT in c++\r\n\r\nhttp://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-mac/44\r\nhttp://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/429/ unrelated fails: ` /client/tests/shell/shell-foxx-api-spec.js`\r\n\r\n","created_at":"2018-05-08T11:30:18Z","updated_at":"2018-05-15T14:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff63755fcbe89b462b580b7ef2055a953c710a43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/arangodb/arangodb/milestones/82","html_url":"https://github.com/arangodb/arangodb/milestone/82","labels_url":"https://api.github.com/repos/arangodb/arangodb/milestones/82/labels","id":2963125,"number":82,"title":"devel","description":null,"creator":{"login":"fceller","id":392005,"avatar_url":"https://avatars2.githubusercontent.com/u/392005?v=4","gravatar_id":"","url":"https://api.github.com/users/fceller","html_url":"https://github.com/fceller","followers_url":"https://api.github.com/users/fceller/followers","following_url":"https://api.github.com/users/fceller/following{/other_user}","gists_url":"https://api.github.com/users/fceller/gists{/gist_id}","starred_url":"https://api.github.com/users/fceller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fceller/subscriptions","organizations_url":"https://api.github.com/users/fceller/orgs","repos_url":"https://api.github.com/users/fceller/repos","events_url":"https://api.github.com/users/fceller/events{/privacy}","received_events_url":"https://api.github.com/users/fceller/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":380,"state":"open","created_at":"2017-12-06T23:27:12Z","updated_at":"2018-05-15T13:48:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5294/commits","review_comments_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5294/comments","review_comment_url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arangodb/arangodb/issues/5294/comments","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/b9094be036fea7bdc8a59f210def75b36d05ecd6","head":{"label":"arangodb:feature/aql-format-date","ref":"feature/aql-format-date","sha":"b9094be036fea7bdc8a59f210def75b36d05ecd6","user":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-05-15T12:46:37Z","pushed_at":"2018-05-15T13:57:11Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":822970,"stargazers_count":5651,"watchers_count":5651,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":409,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":421,"open_issues":409,"watchers":5651,"default_branch":"devel"}},"base":{"label":"arangodb:devel","ref":"devel","sha":"1c1d8f25281c2c6d2573c2d5d6963e44e578c6cf","user":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-05-15T12:46:37Z","pushed_at":"2018-05-15T13:57:11Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":822970,"stargazers_count":5651,"watchers_count":5651,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":409,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":421,"open_issues":409,"watchers":5651,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5294"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5294"},"issue":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5294"},"comments":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5294/comments"},"review_comments":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5294/comments"},"review_comment":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5294/commits"},"statuses":{"href":"https://api.github.com/repos/arangodb/arangodb/statuses/b9094be036fea7bdc8a59f210def75b36d05ecd6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dothebart"}}