{"action":"closed","number":6393,"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/6393","id":184864067,"html_url":"https://github.com/dealii/dealii/pull/6393","diff_url":"https://github.com/dealii/dealii/pull/6393.diff","patch_url":"https://github.com/dealii/dealii/pull/6393.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/6393","number":6393,"state":"closed","locked":false,"title":"Make sure not to attach a PropertyPool if not asked for","user":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"body":"Previously, we were always trying to copy properties in the \r\n```\r\nParticle<dim,spacedim>::Particle (const void *&data, \r\n                                  PropertyPool &new_property_pool)\r\n```\r\nconstructor. This access invalid memory in case a default `PropertyPool` was passed.\r\nAlso, the documentation is talking about a pointer to a `PropertPool` object instead of a reference.\r\nUsing a pointer intead, seems to be the most reasonable choice indeed. Hence, I changed the interface (again?) and also allow to pass a `nullptr` by default.\r\n","created_at":"2018-04-30T00:36:06Z","updated_at":"2018-05-07T03:45:44Z","closed_at":"2018-05-07T03:45:43Z","merged_at":"2018-05-07T03:45:43Z","merge_commit_sha":"e0efca27dab20597e466a55f31466f9804032b17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":255865986,"url":"https://api.github.com/repos/dealii/dealii/labels/Discussion","name":"Discussion","color":"800080","default":false},{"id":700806033,"url":"https://api.github.com/repos/dealii/dealii/labels/Particles","name":"Particles","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/dealii/dealii/milestones/5","html_url":"https://github.com/dealii/dealii/milestone/5","labels_url":"https://api.github.com/repos/dealii/dealii/milestones/5/labels","id":2293564,"number":5,"title":"Release 9.0","description":"","creator":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars0.githubusercontent.com/u/8276200?v=4","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":156,"state":"open","created_at":"2017-02-01T21:05:28Z","updated_at":"2018-05-07T03:45:44Z","due_on":"2018-05-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/6393/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/6393/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/6393/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/afcb634abd8af817dd4f717df2f77499b8cd86c6","head":{"label":"masterleinad:new_fixes_10","ref":"new_fixes_10","sha":"afcb634abd8af817dd4f717df2f77499b8cd86c6","user":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"repo":{"id":22077233,"name":"dealii","full_name":"masterleinad/dealii","owner":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masterleinad/dealii","description":null,"fork":true,"url":"https://api.github.com/repos/masterleinad/dealii","forks_url":"https://api.github.com/repos/masterleinad/dealii/forks","keys_url":"https://api.github.com/repos/masterleinad/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masterleinad/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masterleinad/dealii/teams","hooks_url":"https://api.github.com/repos/masterleinad/dealii/hooks","issue_events_url":"https://api.github.com/repos/masterleinad/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/masterleinad/dealii/events","assignees_url":"https://api.github.com/repos/masterleinad/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/masterleinad/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/masterleinad/dealii/tags","blobs_url":"https://api.github.com/repos/masterleinad/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masterleinad/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masterleinad/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/masterleinad/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masterleinad/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/masterleinad/dealii/languages","stargazers_url":"https://api.github.com/repos/masterleinad/dealii/stargazers","contributors_url":"https://api.github.com/repos/masterleinad/dealii/contributors","subscribers_url":"https://api.github.com/repos/masterleinad/dealii/subscribers","subscription_url":"https://api.github.com/repos/masterleinad/dealii/subscription","commits_url":"https://api.github.com/repos/masterleinad/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/masterleinad/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/masterleinad/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/masterleinad/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/masterleinad/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/masterleinad/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masterleinad/dealii/merges","archive_url":"https://api.github.com/repos/masterleinad/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masterleinad/dealii/downloads","issues_url":"https://api.github.com/repos/masterleinad/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/masterleinad/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/masterleinad/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/masterleinad/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masterleinad/dealii/labels{/name}","releases_url":"https://api.github.com/repos/masterleinad/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/masterleinad/dealii/deployments","created_at":"2014-07-21T19:26:56Z","updated_at":"2018-03-20T08:06:38Z","pushed_at":"2018-05-07T00:30:00Z","git_url":"git://github.com/masterleinad/dealii.git","ssh_url":"git@github.com:masterleinad/dealii.git","clone_url":"https://github.com/masterleinad/dealii.git","svn_url":"https://github.com/masterleinad/dealii","homepage":null,"size":188384,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"97cf197ca0479efe306228141590d05a648f6a5e","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2018-05-07T03:01:56Z","pushed_at":"2018-05-07T03:45:43Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":186546,"stargazers_count":327,"watchers_count":327,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":255,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":300,"open_issues":255,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6393"},"html":{"href":"https://github.com/dealii/dealii/pull/6393"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/6393"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/6393/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6393/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6393/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/afcb634abd8af817dd4f717df2f77499b8cd86c6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tamiko","id":3432917,"avatar_url":"https://avatars2.githubusercontent.com/u/3432917?v=4","gravatar_id":"","url":"https://api.github.com/users/tamiko","html_url":"https://github.com/tamiko","followers_url":"https://api.github.com/users/tamiko/followers","following_url":"https://api.github.com/users/tamiko/following{/other_user}","gists_url":"https://api.github.com/users/tamiko/gists{/gist_id}","starred_url":"https://api.github.com/users/tamiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamiko/subscriptions","organizations_url":"https://api.github.com/users/tamiko/orgs","repos_url":"https://api.github.com/users/tamiko/repos","events_url":"https://api.github.com/users/tamiko/events{/privacy}","received_events_url":"https://api.github.com/users/tamiko/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":170,"deletions":14,"changed_files":6}}
{"actor":{"display_login":"tamiko"}}