{"action":"opened","issue":{"url":"https://api.github.com/repos/BlackArbsCEO/Adv_Fin_ML_Exercises/issues/4","repository_url":"https://api.github.com/repos/BlackArbsCEO/Adv_Fin_ML_Exercises","labels_url":"https://api.github.com/repos/BlackArbsCEO/Adv_Fin_ML_Exercises/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/BlackArbsCEO/Adv_Fin_ML_Exercises/issues/4/comments","events_url":"https://api.github.com/repos/BlackArbsCEO/Adv_Fin_ML_Exercises/issues/4/events","html_url":"https://github.com/BlackArbsCEO/Adv_Fin_ML_Exercises/issues/4","id":345424639,"node_id":"MDU6SXNzdWUzNDU0MjQ2Mzk=","number":4,"title":"Question about applyPtSlOnT1","user":{"login":"ivan-vasilev","id":2920675,"node_id":"MDQ6VXNlcjI5MjA2NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2920675?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan-vasilev","html_url":"https://github.com/ivan-vasilev","followers_url":"https://api.github.com/users/ivan-vasilev/followers","following_url":"https://api.github.com/users/ivan-vasilev/following{/other_user}","gists_url":"https://api.github.com/users/ivan-vasilev/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-vasilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-vasilev/subscriptions","organizations_url":"https://api.github.com/users/ivan-vasilev/orgs","repos_url":"https://api.github.com/users/ivan-vasilev/repos","events_url":"https://api.github.com/users/ivan-vasilev/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-vasilev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-28T06:48:57Z","updated_at":"2018-07-28T06:48:57Z","closed_at":null,"author_association":"NONE","body":"In the method [3.2] applyPtSlOnT1, there is:\r\n\r\n`        df0=(df0/close[loc]-1)*events_.at[loc,'side'] # path returns\r\n`\r\n\r\nThis line is the same as in the book, however what is the point of multiplying the returns by the predicted side: `*events_.at[loc,'side']`? Wouldn't this change the sign of the returns and thus create an error when the barriers are computed on the next line? I know this is not a bug, so I'm sorry about asking here."}}
{"actor":{"display_login":"ivan-vasilev"}}