{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/200653651","pull_request_review_id":135014723,"id":200653651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDY1MzY1MQ==","diff_hunk":"@@ -58,14 +58,21 @@ def get_confirmed_planets_table(self, cache=True, show_progress=True,\n         table_path : str (optional)\n             Path to a local table file. Default `None` will trigger a\n             download of the table from the internet.\n+        all_columns : bool (optional)\n+            Return all available columns. The default returns only the\n+            columns in the default category at the link above.\n         Returns","path":"astroquery/nasa_exoplanet_archive/nasa_exoplanet_archive.py","position":16,"original_position":16,"commit_id":"3304696e11baf40a575cd238306e80478917ea7b","original_commit_id":"3304696e11baf40a575cd238306e80478917ea7b","user":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"body":"could you add an extra empty line here, the docstring doesn't render correctly atm.","created_at":"2018-07-06T13:31:10Z","updated_at":"2018-07-06T13:34:47Z","html_url":"https://github.com/astropy/astroquery/pull/1183#discussion_r200653651","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/1183","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/200653651"},"html":{"href":"https://github.com/astropy/astroquery/pull/1183#discussion_r200653651"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1183"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/1183","id":199645476,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjQ1NDc2","html_url":"https://github.com/astropy/astroquery/pull/1183","diff_url":"https://github.com/astropy/astroquery/pull/1183.diff","patch_url":"https://github.com/astropy/astroquery/pull/1183.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/1183","number":1183,"state":"open","locked":false,"title":"Allow downloading of all columns in the NASA Exoplanet Archive","user":{"login":"mwcraig","id":1147167,"node_id":"MDQ6VXNlcjExNDcxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1147167?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"body":"This PR fixes #1027 by adding an option to get all columns (instead of just the default set) from the NASA Exoplanet Archive.\r\n\r\nOne test will fail; if I download with `all_columns=True` first, then `False` fails. I assume there is some cacheing going on that I haven't been able to stop.\r\n\r\nArguably it would make more sense just to make it *always* return all columns (though @bmorris3 may know of a reason not too); then we would only need one test :).\r\n\r\nThis catalog is more complete than than the Exoplanet Orbit Database, so it would be nice to have it return more transit-related parameters.","created_at":"2018-07-06T04:59:38Z","updated_at":"2018-07-06T13:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8177280a054886368fdbd8ff256882b5e8b480e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":985939484,"node_id":"MDU6TGFiZWw5ODU5Mzk0ODQ=","url":"https://api.github.com/repos/astropy/astroquery/labels/nasa_exoplanet_archive","name":"nasa_exoplanet_archive","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astroquery/milestones/18","html_url":"https://github.com/astropy/astroquery/milestone/18","labels_url":"https://api.github.com/repos/astropy/astroquery/milestones/18/labels","id":3284985,"node_id":"MDk6TWlsZXN0b25lMzI4NDk4NQ==","number":18,"title":"v0.3.9","description":"","creator":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":20,"state":"open","created_at":"2018-04-20T17:42:46Z","updated_at":"2018-07-06T13:27:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/1183/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/1183/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/1183/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/3304696e11baf40a575cd238306e80478917ea7b","head":{"label":"mwcraig:add-nasa-exo-columns","ref":"add-nasa-exo-columns","sha":"3304696e11baf40a575cd238306e80478917ea7b","user":{"login":"mwcraig","id":1147167,"node_id":"MDQ6VXNlcjExNDcxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1147167?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"repo":{"id":136088543,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODg1NDM=","name":"astroquery","full_name":"mwcraig/astroquery","owner":{"login":"mwcraig","id":1147167,"node_id":"MDQ6VXNlcjExNDcxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1147167?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwcraig/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":true,"url":"https://api.github.com/repos/mwcraig/astroquery","forks_url":"https://api.github.com/repos/mwcraig/astroquery/forks","keys_url":"https://api.github.com/repos/mwcraig/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwcraig/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwcraig/astroquery/teams","hooks_url":"https://api.github.com/repos/mwcraig/astroquery/hooks","issue_events_url":"https://api.github.com/repos/mwcraig/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/mwcraig/astroquery/events","assignees_url":"https://api.github.com/repos/mwcraig/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/mwcraig/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/mwcraig/astroquery/tags","blobs_url":"https://api.github.com/repos/mwcraig/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwcraig/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwcraig/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwcraig/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwcraig/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/mwcraig/astroquery/languages","stargazers_url":"https://api.github.com/repos/mwcraig/astroquery/stargazers","contributors_url":"https://api.github.com/repos/mwcraig/astroquery/contributors","subscribers_url":"https://api.github.com/repos/mwcraig/astroquery/subscribers","subscription_url":"https://api.github.com/repos/mwcraig/astroquery/subscription","commits_url":"https://api.github.com/repos/mwcraig/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwcraig/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwcraig/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwcraig/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwcraig/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/mwcraig/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwcraig/astroquery/merges","archive_url":"https://api.github.com/repos/mwcraig/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwcraig/astroquery/downloads","issues_url":"https://api.github.com/repos/mwcraig/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/mwcraig/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/mwcraig/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/mwcraig/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwcraig/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/mwcraig/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/mwcraig/astroquery/deployments","created_at":"2018-06-04T22:12:19Z","updated_at":"2018-06-04T22:12:22Z","pushed_at":"2018-07-06T04:53:03Z","git_url":"git://github.com/mwcraig/astroquery.git","ssh_url":"git@github.com:mwcraig/astroquery.git","clone_url":"https://github.com/mwcraig/astroquery.git","svn_url":"https://github.com/mwcraig/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":58482,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"80bc62610f3fcf31609291baf6bb12cdaf33b2d6","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg3MjY5","name":"astroquery","full_name":"astropy/astroquery","owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astroquery/deployments","created_at":"2012-06-25T20:52:07Z","updated_at":"2018-07-05T15:30:46Z","pushed_at":"2018-07-06T13:16:34Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":58407,"stargazers_count":157,"watchers_count":157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":158,"open_issues":210,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1183"},"html":{"href":"https://github.com/astropy/astroquery/pull/1183"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1183"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1183/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1183/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1183/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/3304696e11baf40a575cd238306e80478917ea7b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bsipocz"}}