{"action":"created","comment":{"url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/comments/168261524","pull_request_review_id":96600350,"id":168261524,"diff_hunk":"@@ -45,6 +43,13 @@ export function extendStore(Store) {\n       return this._super(modelName);\n     },\n \n+    createModelDataFor(modelName, id, clientId, storeWrapper) {\n+      if (SchemaManager.includesModel(modelName)) {\n+        return new M3ModelData(modelName, id, clientId, storeWrapper, this);","path":"addon/initializers/m3-store.js","position":22,"original_position":22,"commit_id":"7217b992d7718ef69d7ce7ec8a94b84fbd4766bb","original_commit_id":"7217b992d7718ef69d7ce7ec8a94b84fbd4766bb","user":{"login":"dnachev","id":816847,"avatar_url":"https://avatars2.githubusercontent.com/u/816847?v=4","gravatar_id":"","url":"https://api.github.com/users/dnachev","html_url":"https://github.com/dnachev","followers_url":"https://api.github.com/users/dnachev/followers","following_url":"https://api.github.com/users/dnachev/following{/other_user}","gists_url":"https://api.github.com/users/dnachev/gists{/gist_id}","starred_url":"https://api.github.com/users/dnachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnachev/subscriptions","organizations_url":"https://api.github.com/users/dnachev/orgs","repos_url":"https://api.github.com/users/dnachev/repos","events_url":"https://api.github.com/users/dnachev/events{/privacy}","received_events_url":"https://api.github.com/users/dnachev/received_events","type":"User","site_admin":false},"body":"Not needed. Changed it in the other PRs.","created_at":"2018-02-14T18:07:10Z","updated_at":"2018-02-14T18:07:10Z","html_url":"https://github.com/hjdivad/ember-m3/pull/71#discussion_r168261524","pull_request_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/comments/168261524"},"html":{"href":"https://github.com/hjdivad/ember-m3/pull/71#discussion_r168261524"},"pull_request":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71"}},"in_reply_to_id":166739484},"pull_request":{"url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71","id":166883554,"html_url":"https://github.com/hjdivad/ember-m3/pull/71","diff_url":"https://github.com/hjdivad/ember-m3/pull/71.diff","patch_url":"https://github.com/hjdivad/ember-m3/pull/71.patch","issue_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/71","number":71,"state":"open","locked":false,"title":"M3 on top of Model Data RFC","user":{"login":"dnachev","id":816847,"avatar_url":"https://avatars2.githubusercontent.com/u/816847?v=4","gravatar_id":"","url":"https://api.github.com/users/dnachev","html_url":"https://github.com/dnachev","followers_url":"https://api.github.com/users/dnachev/followers","following_url":"https://api.github.com/users/dnachev/following{/other_user}","gists_url":"https://api.github.com/users/dnachev/gists{/gist_id}","starred_url":"https://api.github.com/users/dnachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnachev/subscriptions","organizations_url":"https://api.github.com/users/dnachev/orgs","repos_url":"https://api.github.com/users/dnachev/repos","events_url":"https://api.github.com/users/dnachev/events{/privacy}","received_events_url":"https://api.github.com/users/dnachev/received_events","type":"User","site_admin":false},"body":"This is still WIP, but looking for early feedback and alignment on the approach.\r\n\r\nBundled together with the migration is also changing how we handle updates - we no longer replace everything, but instead of merge the updates with the existing data. This means any field, which needs to be deleted has to be set to `null` in the payload.\r\n\r\nThe migration also introduces dirty tracking the same way it is implemented in ED, for now.\r\n\r\nThe biggest question right now is the way handle nested model datas. We need them to be tracked in their parent, so that we can properly merge updates and we can do dirty tracking in them as well.","created_at":"2018-02-02T19:25:49Z","updated_at":"2018-02-14T18:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8fbcbf9aaacf962f3d76548270ae57135fb3673","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71/commits","review_comments_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71/comments","review_comment_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/71/comments","statuses_url":"https://api.github.com/repos/hjdivad/ember-m3/statuses/7217b992d7718ef69d7ce7ec8a94b84fbd4766bb","head":{"label":"hjdivad:dnachev/model-data","ref":"dnachev/model-data","sha":"7217b992d7718ef69d7ce7ec8a94b84fbd4766bb","user":{"login":"hjdivad","id":17980,"avatar_url":"https://avatars2.githubusercontent.com/u/17980?v=4","gravatar_id":"","url":"https://api.github.com/users/hjdivad","html_url":"https://github.com/hjdivad","followers_url":"https://api.github.com/users/hjdivad/followers","following_url":"https://api.github.com/users/hjdivad/following{/other_user}","gists_url":"https://api.github.com/users/hjdivad/gists{/gist_id}","starred_url":"https://api.github.com/users/hjdivad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjdivad/subscriptions","organizations_url":"https://api.github.com/users/hjdivad/orgs","repos_url":"https://api.github.com/users/hjdivad/repos","events_url":"https://api.github.com/users/hjdivad/events{/privacy}","received_events_url":"https://api.github.com/users/hjdivad/received_events","type":"User","site_admin":false},"repo":{"id":85887421,"name":"ember-m3","full_name":"hjdivad/ember-m3","owner":{"login":"hjdivad","id":17980,"avatar_url":"https://avatars2.githubusercontent.com/u/17980?v=4","gravatar_id":"","url":"https://api.github.com/users/hjdivad","html_url":"https://github.com/hjdivad","followers_url":"https://api.github.com/users/hjdivad/followers","following_url":"https://api.github.com/users/hjdivad/following{/other_user}","gists_url":"https://api.github.com/users/hjdivad/gists{/gist_id}","starred_url":"https://api.github.com/users/hjdivad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjdivad/subscriptions","organizations_url":"https://api.github.com/users/hjdivad/orgs","repos_url":"https://api.github.com/users/hjdivad/repos","events_url":"https://api.github.com/users/hjdivad/events{/privacy}","received_events_url":"https://api.github.com/users/hjdivad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjdivad/ember-m3","description":null,"fork":false,"url":"https://api.github.com/repos/hjdivad/ember-m3","forks_url":"https://api.github.com/repos/hjdivad/ember-m3/forks","keys_url":"https://api.github.com/repos/hjdivad/ember-m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjdivad/ember-m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjdivad/ember-m3/teams","hooks_url":"https://api.github.com/repos/hjdivad/ember-m3/hooks","issue_events_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/events{/number}","events_url":"https://api.github.com/repos/hjdivad/ember-m3/events","assignees_url":"https://api.github.com/repos/hjdivad/ember-m3/assignees{/user}","branches_url":"https://api.github.com/repos/hjdivad/ember-m3/branches{/branch}","tags_url":"https://api.github.com/repos/hjdivad/ember-m3/tags","blobs_url":"https://api.github.com/repos/hjdivad/ember-m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjdivad/ember-m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjdivad/ember-m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjdivad/ember-m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjdivad/ember-m3/statuses/{sha}","languages_url":"https://api.github.com/repos/hjdivad/ember-m3/languages","stargazers_url":"https://api.github.com/repos/hjdivad/ember-m3/stargazers","contributors_url":"https://api.github.com/repos/hjdivad/ember-m3/contributors","subscribers_url":"https://api.github.com/repos/hjdivad/ember-m3/subscribers","subscription_url":"https://api.github.com/repos/hjdivad/ember-m3/subscription","commits_url":"https://api.github.com/repos/hjdivad/ember-m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjdivad/ember-m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjdivad/ember-m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjdivad/ember-m3/contents/{+path}","compare_url":"https://api.github.com/repos/hjdivad/ember-m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjdivad/ember-m3/merges","archive_url":"https://api.github.com/repos/hjdivad/ember-m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjdivad/ember-m3/downloads","issues_url":"https://api.github.com/repos/hjdivad/ember-m3/issues{/number}","pulls_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls{/number}","milestones_url":"https://api.github.com/repos/hjdivad/ember-m3/milestones{/number}","notifications_url":"https://api.github.com/repos/hjdivad/ember-m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjdivad/ember-m3/labels{/name}","releases_url":"https://api.github.com/repos/hjdivad/ember-m3/releases{/id}","deployments_url":"https://api.github.com/repos/hjdivad/ember-m3/deployments","created_at":"2017-03-22T23:51:12Z","updated_at":"2018-01-25T04:14:00Z","pushed_at":"2018-02-14T05:35:34Z","git_url":"git://github.com/hjdivad/ember-m3.git","ssh_url":"git@github.com:hjdivad/ember-m3.git","clone_url":"https://github.com/hjdivad/ember-m3.git","svn_url":"https://github.com/hjdivad/ember-m3","homepage":null,"size":477,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":20,"watchers":6,"default_branch":"master"}},"base":{"label":"hjdivad:master","ref":"master","sha":"a9a10870d8f9a9ef76a16b8ae9112644334de5c5","user":{"login":"hjdivad","id":17980,"avatar_url":"https://avatars2.githubusercontent.com/u/17980?v=4","gravatar_id":"","url":"https://api.github.com/users/hjdivad","html_url":"https://github.com/hjdivad","followers_url":"https://api.github.com/users/hjdivad/followers","following_url":"https://api.github.com/users/hjdivad/following{/other_user}","gists_url":"https://api.github.com/users/hjdivad/gists{/gist_id}","starred_url":"https://api.github.com/users/hjdivad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjdivad/subscriptions","organizations_url":"https://api.github.com/users/hjdivad/orgs","repos_url":"https://api.github.com/users/hjdivad/repos","events_url":"https://api.github.com/users/hjdivad/events{/privacy}","received_events_url":"https://api.github.com/users/hjdivad/received_events","type":"User","site_admin":false},"repo":{"id":85887421,"name":"ember-m3","full_name":"hjdivad/ember-m3","owner":{"login":"hjdivad","id":17980,"avatar_url":"https://avatars2.githubusercontent.com/u/17980?v=4","gravatar_id":"","url":"https://api.github.com/users/hjdivad","html_url":"https://github.com/hjdivad","followers_url":"https://api.github.com/users/hjdivad/followers","following_url":"https://api.github.com/users/hjdivad/following{/other_user}","gists_url":"https://api.github.com/users/hjdivad/gists{/gist_id}","starred_url":"https://api.github.com/users/hjdivad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjdivad/subscriptions","organizations_url":"https://api.github.com/users/hjdivad/orgs","repos_url":"https://api.github.com/users/hjdivad/repos","events_url":"https://api.github.com/users/hjdivad/events{/privacy}","received_events_url":"https://api.github.com/users/hjdivad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjdivad/ember-m3","description":null,"fork":false,"url":"https://api.github.com/repos/hjdivad/ember-m3","forks_url":"https://api.github.com/repos/hjdivad/ember-m3/forks","keys_url":"https://api.github.com/repos/hjdivad/ember-m3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjdivad/ember-m3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjdivad/ember-m3/teams","hooks_url":"https://api.github.com/repos/hjdivad/ember-m3/hooks","issue_events_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/events{/number}","events_url":"https://api.github.com/repos/hjdivad/ember-m3/events","assignees_url":"https://api.github.com/repos/hjdivad/ember-m3/assignees{/user}","branches_url":"https://api.github.com/repos/hjdivad/ember-m3/branches{/branch}","tags_url":"https://api.github.com/repos/hjdivad/ember-m3/tags","blobs_url":"https://api.github.com/repos/hjdivad/ember-m3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjdivad/ember-m3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjdivad/ember-m3/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjdivad/ember-m3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjdivad/ember-m3/statuses/{sha}","languages_url":"https://api.github.com/repos/hjdivad/ember-m3/languages","stargazers_url":"https://api.github.com/repos/hjdivad/ember-m3/stargazers","contributors_url":"https://api.github.com/repos/hjdivad/ember-m3/contributors","subscribers_url":"https://api.github.com/repos/hjdivad/ember-m3/subscribers","subscription_url":"https://api.github.com/repos/hjdivad/ember-m3/subscription","commits_url":"https://api.github.com/repos/hjdivad/ember-m3/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjdivad/ember-m3/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjdivad/ember-m3/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjdivad/ember-m3/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjdivad/ember-m3/contents/{+path}","compare_url":"https://api.github.com/repos/hjdivad/ember-m3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjdivad/ember-m3/merges","archive_url":"https://api.github.com/repos/hjdivad/ember-m3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjdivad/ember-m3/downloads","issues_url":"https://api.github.com/repos/hjdivad/ember-m3/issues{/number}","pulls_url":"https://api.github.com/repos/hjdivad/ember-m3/pulls{/number}","milestones_url":"https://api.github.com/repos/hjdivad/ember-m3/milestones{/number}","notifications_url":"https://api.github.com/repos/hjdivad/ember-m3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjdivad/ember-m3/labels{/name}","releases_url":"https://api.github.com/repos/hjdivad/ember-m3/releases{/id}","deployments_url":"https://api.github.com/repos/hjdivad/ember-m3/deployments","created_at":"2017-03-22T23:51:12Z","updated_at":"2018-01-25T04:14:00Z","pushed_at":"2018-02-14T05:35:34Z","git_url":"git://github.com/hjdivad/ember-m3.git","ssh_url":"git@github.com:hjdivad/ember-m3.git","clone_url":"https://github.com/hjdivad/ember-m3.git","svn_url":"https://github.com/hjdivad/ember-m3","homepage":null,"size":477,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71"},"html":{"href":"https://github.com/hjdivad/ember-m3/pull/71"},"issue":{"href":"https://api.github.com/repos/hjdivad/ember-m3/issues/71"},"comments":{"href":"https://api.github.com/repos/hjdivad/ember-m3/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hjdivad/ember-m3/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/hjdivad/ember-m3/statuses/7217b992d7718ef69d7ce7ec8a94b84fbd4766bb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dnachev"}}