{"action":"created","issue":{"url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/10","repository_url":"https://api.github.com/repos/libp2p/go-libp2p-daemon","labels_url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/10/comments","events_url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/10/events","html_url":"https://github.com/libp2p/go-libp2p-daemon/pull/10","id":364584893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzM1NjY4","number":10,"title":"Basic golang client for libp2p daemon","user":{"login":"bigs","id":213338,"node_id":"MDQ6VXNlcjIxMzMzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/213338?v=4","gravatar_id":"","url":"https://api.github.com/users/bigs","html_url":"https://github.com/bigs","followers_url":"https://api.github.com/users/bigs/followers","following_url":"https://api.github.com/users/bigs/following{/other_user}","gists_url":"https://api.github.com/users/bigs/gists{/gist_id}","starred_url":"https://api.github.com/users/bigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigs/subscriptions","organizations_url":"https://api.github.com/users/bigs/orgs","repos_url":"https://api.github.com/users/bigs/repos","events_url":"https://api.github.com/users/bigs/events{/privacy}","received_events_url":"https://api.github.com/users/bigs/received_events","type":"User","site_admin":false},"labels":[{"id":1066472916,"node_id":"MDU6TGFiZWwxMDY2NDcyOTE2","url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"bigs","id":213338,"node_id":"MDQ6VXNlcjIxMzMzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/213338?v=4","gravatar_id":"","url":"https://api.github.com/users/bigs","html_url":"https://github.com/bigs","followers_url":"https://api.github.com/users/bigs/followers","following_url":"https://api.github.com/users/bigs/following{/other_user}","gists_url":"https://api.github.com/users/bigs/gists{/gist_id}","starred_url":"https://api.github.com/users/bigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigs/subscriptions","organizations_url":"https://api.github.com/users/bigs/orgs","repos_url":"https://api.github.com/users/bigs/repos","events_url":"https://api.github.com/users/bigs/events{/privacy}","received_events_url":"https://api.github.com/users/bigs/received_events","type":"User","site_admin":false},"assignees":[{"login":"bigs","id":213338,"node_id":"MDQ6VXNlcjIxMzMzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/213338?v=4","gravatar_id":"","url":"https://api.github.com/users/bigs","html_url":"https://github.com/bigs","followers_url":"https://api.github.com/users/bigs/followers","following_url":"https://api.github.com/users/bigs/following{/other_user}","gists_url":"https://api.github.com/users/bigs/gists{/gist_id}","starred_url":"https://api.github.com/users/bigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigs/subscriptions","organizations_url":"https://api.github.com/users/bigs/orgs","repos_url":"https://api.github.com/users/bigs/repos","events_url":"https://api.github.com/users/bigs/events{/privacy}","received_events_url":"https://api.github.com/users/bigs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-27T17:46:21Z","updated_at":"2018-09-27T18:27:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/pulls/10","html_url":"https://github.com/libp2p/go-libp2p-daemon/pull/10","diff_url":"https://github.com/libp2p/go-libp2p-daemon/pull/10.diff","patch_url":"https://github.com/libp2p/go-libp2p-daemon/pull/10.patch"},"body":"Would love an initial review of the API as I write some basic tests. I played around with the API a ton and wound up going with this, because it's so simple. I wanted to make sure there were no dependencies on libp2p other than for the protobufs. The only thing I'm not so sure about API wise is whether or not to introduce contexts for closing all connections/listeners or just keeping as is (or removing the `Client#Close` function)"},"comment":{"url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/comments/425196109","html_url":"https://github.com/libp2p/go-libp2p-daemon/pull/10#issuecomment-425196109","issue_url":"https://api.github.com/repos/libp2p/go-libp2p-daemon/issues/10","id":425196109,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE5NjEwOQ==","user":{"login":"raulk","id":1101242,"node_id":"MDQ6VXNlcjExMDEyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1101242?v=4","gravatar_id":"","url":"https://api.github.com/users/raulk","html_url":"https://github.com/raulk","followers_url":"https://api.github.com/users/raulk/followers","following_url":"https://api.github.com/users/raulk/following{/other_user}","gists_url":"https://api.github.com/users/raulk/gists{/gist_id}","starred_url":"https://api.github.com/users/raulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulk/subscriptions","organizations_url":"https://api.github.com/users/raulk/orgs","repos_url":"https://api.github.com/users/raulk/repos","events_url":"https://api.github.com/users/raulk/events{/privacy}","received_events_url":"https://api.github.com/users/raulk/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T18:27:24Z","updated_at":"2018-09-27T18:27:24Z","author_association":"NONE","body":"Just a meta point. Can we call this construct _binding_? The term _client_ is super overloaded and it’s called _binding_ in the roadmap and everywhere else, I believe. "}}
{"actor":{"display_login":"raulk"}}