{"action":"created","comment":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/comments/188830055","pull_request_review_id":120762489,"id":188830055,"diff_hunk":"@@ -347,10 +382,25 @@ void StFlow::evalResidual(double* x, double* rsd, int* diag,\n             // Continuity. This propagates information right-to-left, since\n             // rho_u at point 0 is dependent on rho_u at point 1, but not on\n             // mdot from the inlet.\n+            if(m_strainRateEq == false)\n             rsd[index(c_offset_U,0)] =\n                 -(rho_u(x,1) - rho_u(x,0))/m_dz[0]\n                 -(density(1)*V(x,1) + density(0)*V(x,0));\n-\n+\t\t\telse\n+\t\t\trsd[index(c_offset_U,0)] = -(rho_u(x,1) - rho_u(x,0))/m_dz[0]\n+\t\t\t\t-0.5*(lambda(x,1)*density(1)*V(x,1) + lambda(x,0)*density(0)*V(x,0));\n+\n+            // Control to switch between regular Cantera, one-point or two-point control methods\n+            if (m_twoPointControl == false && m_onePointControl == false)  \n+                rsd[index(c_offset_L,0)] = -rho_u(x,0);\n+            else if (m_twoPointControl == true || m_onePointControl == true)\n+                rsd[index(c_offset_L,0)] = lambda(x,1) - lambda(x,0);\n+\n+            if (m_twoPointControl == false)\n+                rsd[index(c_offset_uo,0)] = -uo(x,0);\n+            else\n+                rsd[index(c_offset_uo, 0)] = uo(x,1) - uo(x,0); ","path":"src/oneD/StFlow.cpp","position":94,"original_position":94,"commit_id":"ded4bec4902b090b19fe9b4eff048e04f0e2bd76","original_commit_id":"52f3e6c86fecb1d8bf559ca909fd1732035f0015","user":{"login":"speth","id":644977,"avatar_url":"https://avatars1.githubusercontent.com/u/644977?v=4","gravatar_id":"","url":"https://api.github.com/users/speth","html_url":"https://github.com/speth","followers_url":"https://api.github.com/users/speth/followers","following_url":"https://api.github.com/users/speth/following{/other_user}","gists_url":"https://api.github.com/users/speth/gists{/gist_id}","starred_url":"https://api.github.com/users/speth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speth/subscriptions","organizations_url":"https://api.github.com/users/speth/orgs","repos_url":"https://api.github.com/users/speth/repos","events_url":"https://api.github.com/users/speth/events{/privacy}","received_events_url":"https://api.github.com/users/speth/received_events","type":"User","site_admin":false},"body":"Cantera's style for if/else structures is to always use braces, e.g.\r\n```c++\r\nif (!m_twoPointControl) {\r\n    rsd[index(c_offset_uo,0)] = -uo(x,0);\r\n} else {\r\n    rsd[index(c_offset_uo, 0)] = uo(x,1) - uo(x,0); \r\n}\r\n```","created_at":"2018-05-17T03:26:16Z","updated_at":"2018-05-17T03:39:21Z","html_url":"https://github.com/Cantera/cantera/pull/534#discussion_r188830055","pull_request_url":"https://api.github.com/repos/Cantera/cantera/pulls/534","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments/188830055"},"html":{"href":"https://github.com/Cantera/cantera/pull/534#discussion_r188830055"},"pull_request":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/Cantera/cantera/pulls/534","id":186523492,"html_url":"https://github.com/Cantera/cantera/pull/534","diff_url":"https://github.com/Cantera/cantera/pull/534.diff","patch_url":"https://github.com/Cantera/cantera/pull/534.patch","issue_url":"https://api.github.com/repos/Cantera/cantera/issues/534","number":534,"state":"open","locked":false,"title":"Numerical continuation techniques","user":{"login":"axbriones","id":38224138,"avatar_url":"https://avatars3.githubusercontent.com/u/38224138?v=4","gravatar_id":"","url":"https://api.github.com/users/axbriones","html_url":"https://github.com/axbriones","followers_url":"https://api.github.com/users/axbriones/followers","following_url":"https://api.github.com/users/axbriones/following{/other_user}","gists_url":"https://api.github.com/users/axbriones/gists{/gist_id}","starred_url":"https://api.github.com/users/axbriones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axbriones/subscriptions","organizations_url":"https://api.github.com/users/axbriones/orgs","repos_url":"https://api.github.com/users/axbriones/repos","events_url":"https://api.github.com/users/axbriones/events{/privacy}","received_events_url":"https://api.github.com/users/axbriones/received_events","type":"User","site_admin":false},"body":"Please fill in the issue number this pull request is fixing:\r\n\r\nFixes #\r\n\r\nChanges proposed in this pull request:\r\n- Added one-point and two-point continuation techniques for opposed flow flames\r\n- Unity Lewis number\r\n- Alternative pseudo-one dimensional equation (strain rate eigenvalue). \r\n- Enable/Disable switch for species ratio rates\r\n","created_at":"2018-05-08T04:24:36Z","updated_at":"2018-05-17T03:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6a0cab22f381383fe15a79ebb9266ef5a6119f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cantera/cantera/pulls/534/commits","review_comments_url":"https://api.github.com/repos/Cantera/cantera/pulls/534/comments","review_comment_url":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cantera/cantera/issues/534/comments","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/ded4bec4902b090b19fe9b4eff048e04f0e2bd76","head":{"label":"axbriones:master","ref":"master","sha":"ded4bec4902b090b19fe9b4eff048e04f0e2bd76","user":{"login":"axbriones","id":38224138,"avatar_url":"https://avatars3.githubusercontent.com/u/38224138?v=4","gravatar_id":"","url":"https://api.github.com/users/axbriones","html_url":"https://github.com/axbriones","followers_url":"https://api.github.com/users/axbriones/followers","following_url":"https://api.github.com/users/axbriones/following{/other_user}","gists_url":"https://api.github.com/users/axbriones/gists{/gist_id}","starred_url":"https://api.github.com/users/axbriones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axbriones/subscriptions","organizations_url":"https://api.github.com/users/axbriones/orgs","repos_url":"https://api.github.com/users/axbriones/repos","events_url":"https://api.github.com/users/axbriones/events{/privacy}","received_events_url":"https://api.github.com/users/axbriones/received_events","type":"User","site_admin":false},"repo":{"id":129832489,"name":"cantera","full_name":"axbriones/cantera","owner":{"login":"axbriones","id":38224138,"avatar_url":"https://avatars3.githubusercontent.com/u/38224138?v=4","gravatar_id":"","url":"https://api.github.com/users/axbriones","html_url":"https://github.com/axbriones","followers_url":"https://api.github.com/users/axbriones/followers","following_url":"https://api.github.com/users/axbriones/following{/other_user}","gists_url":"https://api.github.com/users/axbriones/gists{/gist_id}","starred_url":"https://api.github.com/users/axbriones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axbriones/subscriptions","organizations_url":"https://api.github.com/users/axbriones/orgs","repos_url":"https://api.github.com/users/axbriones/repos","events_url":"https://api.github.com/users/axbriones/events{/privacy}","received_events_url":"https://api.github.com/users/axbriones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axbriones/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":true,"url":"https://api.github.com/repos/axbriones/cantera","forks_url":"https://api.github.com/repos/axbriones/cantera/forks","keys_url":"https://api.github.com/repos/axbriones/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axbriones/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axbriones/cantera/teams","hooks_url":"https://api.github.com/repos/axbriones/cantera/hooks","issue_events_url":"https://api.github.com/repos/axbriones/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/axbriones/cantera/events","assignees_url":"https://api.github.com/repos/axbriones/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/axbriones/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/axbriones/cantera/tags","blobs_url":"https://api.github.com/repos/axbriones/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axbriones/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axbriones/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/axbriones/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axbriones/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/axbriones/cantera/languages","stargazers_url":"https://api.github.com/repos/axbriones/cantera/stargazers","contributors_url":"https://api.github.com/repos/axbriones/cantera/contributors","subscribers_url":"https://api.github.com/repos/axbriones/cantera/subscribers","subscription_url":"https://api.github.com/repos/axbriones/cantera/subscription","commits_url":"https://api.github.com/repos/axbriones/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/axbriones/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/axbriones/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/axbriones/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/axbriones/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/axbriones/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axbriones/cantera/merges","archive_url":"https://api.github.com/repos/axbriones/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axbriones/cantera/downloads","issues_url":"https://api.github.com/repos/axbriones/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/axbriones/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/axbriones/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/axbriones/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axbriones/cantera/labels{/name}","releases_url":"https://api.github.com/repos/axbriones/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/axbriones/cantera/deployments","created_at":"2018-04-17T02:13:32Z","updated_at":"2018-05-17T02:26:53Z","pushed_at":"2018-05-17T02:26:51Z","git_url":"git://github.com/axbriones/cantera.git","ssh_url":"git@github.com:axbriones/cantera.git","clone_url":"https://github.com/axbriones/cantera.git","svn_url":"https://github.com/axbriones/cantera","homepage":"","size":33550,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cantera:master","ref":"master","sha":"cc93ce62ca23ac9dca8074d10d3c0531387ba864","user":{"login":"Cantera","id":817698,"avatar_url":"https://avatars2.githubusercontent.com/u/817698?v=4","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"repo":{"id":32940327,"name":"cantera","full_name":"Cantera/cantera","owner":{"login":"Cantera","id":817698,"avatar_url":"https://avatars2.githubusercontent.com/u/817698?v=4","gravatar_id":"","url":"https://api.github.com/users/Cantera","html_url":"https://github.com/Cantera","followers_url":"https://api.github.com/users/Cantera/followers","following_url":"https://api.github.com/users/Cantera/following{/other_user}","gists_url":"https://api.github.com/users/Cantera/gists{/gist_id}","starred_url":"https://api.github.com/users/Cantera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cantera/subscriptions","organizations_url":"https://api.github.com/users/Cantera/orgs","repos_url":"https://api.github.com/users/Cantera/repos","events_url":"https://api.github.com/users/Cantera/events{/privacy}","received_events_url":"https://api.github.com/users/Cantera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cantera/cantera","description":"Chemical kinetics, thermodynamics, and transport tool suite","fork":false,"url":"https://api.github.com/repos/Cantera/cantera","forks_url":"https://api.github.com/repos/Cantera/cantera/forks","keys_url":"https://api.github.com/repos/Cantera/cantera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cantera/cantera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cantera/cantera/teams","hooks_url":"https://api.github.com/repos/Cantera/cantera/hooks","issue_events_url":"https://api.github.com/repos/Cantera/cantera/issues/events{/number}","events_url":"https://api.github.com/repos/Cantera/cantera/events","assignees_url":"https://api.github.com/repos/Cantera/cantera/assignees{/user}","branches_url":"https://api.github.com/repos/Cantera/cantera/branches{/branch}","tags_url":"https://api.github.com/repos/Cantera/cantera/tags","blobs_url":"https://api.github.com/repos/Cantera/cantera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cantera/cantera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cantera/cantera/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cantera/cantera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cantera/cantera/statuses/{sha}","languages_url":"https://api.github.com/repos/Cantera/cantera/languages","stargazers_url":"https://api.github.com/repos/Cantera/cantera/stargazers","contributors_url":"https://api.github.com/repos/Cantera/cantera/contributors","subscribers_url":"https://api.github.com/repos/Cantera/cantera/subscribers","subscription_url":"https://api.github.com/repos/Cantera/cantera/subscription","commits_url":"https://api.github.com/repos/Cantera/cantera/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cantera/cantera/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cantera/cantera/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cantera/cantera/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cantera/cantera/contents/{+path}","compare_url":"https://api.github.com/repos/Cantera/cantera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cantera/cantera/merges","archive_url":"https://api.github.com/repos/Cantera/cantera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cantera/cantera/downloads","issues_url":"https://api.github.com/repos/Cantera/cantera/issues{/number}","pulls_url":"https://api.github.com/repos/Cantera/cantera/pulls{/number}","milestones_url":"https://api.github.com/repos/Cantera/cantera/milestones{/number}","notifications_url":"https://api.github.com/repos/Cantera/cantera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cantera/cantera/labels{/name}","releases_url":"https://api.github.com/repos/Cantera/cantera/releases{/id}","deployments_url":"https://api.github.com/repos/Cantera/cantera/deployments","created_at":"2015-03-26T16:54:16Z","updated_at":"2018-05-16T21:30:39Z","pushed_at":"2018-05-17T02:26:52Z","git_url":"git://github.com/Cantera/cantera.git","ssh_url":"git@github.com:Cantera/cantera.git","clone_url":"https://github.com/Cantera/cantera.git","svn_url":"https://github.com/Cantera/cantera","homepage":"","size":40546,"stargazers_count":125,"watchers_count":125,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":99,"open_issues":46,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/534"},"html":{"href":"https://github.com/Cantera/cantera/pull/534"},"issue":{"href":"https://api.github.com/repos/Cantera/cantera/issues/534"},"comments":{"href":"https://api.github.com/repos/Cantera/cantera/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cantera/cantera/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/Cantera/cantera/statuses/ded4bec4902b090b19fe9b4eff048e04f0e2bd76"}},"author_association":"NONE"}}
{"actor":{"display_login":"speth"}}