{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8587","repository_url":"https://api.github.com/repos/mattermost/mattermost-server","labels_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8587/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8587/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8587/events","html_url":"https://github.com/mattermost/mattermost-server/pull/8587","id":312039263,"number":8587,"title":"MM-10020:  avoid duplicating unique indexes","user":{"login":"lieut-data","id":1023171,"avatar_url":"https://avatars2.githubusercontent.com/u/1023171?v=4","gravatar_id":"","url":"https://api.github.com/users/lieut-data","html_url":"https://github.com/lieut-data","followers_url":"https://api.github.com/users/lieut-data/followers","following_url":"https://api.github.com/users/lieut-data/following{/other_user}","gists_url":"https://api.github.com/users/lieut-data/gists{/gist_id}","starred_url":"https://api.github.com/users/lieut-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lieut-data/subscriptions","organizations_url":"https://api.github.com/users/lieut-data/orgs","repos_url":"https://api.github.com/users/lieut-data/repos","events_url":"https://api.github.com/users/lieut-data/events{/privacy}","received_events_url":"https://api.github.com/users/lieut-data/received_events","type":"User","site_admin":false},"labels":[{"id":250214574,"url":"https://api.github.com/repos/mattermost/mattermost-server/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-06T16:29:13Z","updated_at":"2018-04-10T14:49:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/8587","html_url":"https://github.com/mattermost/mattermost-server/pull/8587","diff_url":"https://github.com/mattermost/mattermost-server/pull/8587.diff","patch_url":"https://github.com/mattermost/mattermost-server/pull/8587.patch"},"body":"#### Summary\r\nAs described on the corresponding [gorp PR](https://github.com/mattermost/gorp/pull/1), we've been creating duplicate unique indexes in three tables when calling `SetUniqueTogether`. This PR removes those duplicate indexes, pulls in the gorp changes to make `SetUniqueTogether` idempotent, and for good measure, avoids duplicating the master connection from `GetAllConns` when there are no read replicas.\r\n\r\nThis extends the existing support for SQLite, primarily to enable lighter-weight tests, as well as inlining several i18n-ed log messages to avoid having to setup translations just to run a unit test.\r\n\r\nNote too that I ran `glide update`, then removed all but the requisite gorp changes.\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/MM-10020\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Includes text changes and localization file ([.../i18n/en.json](https://github.com/mattermost/mattermost-server/blob/master/i18n/en.json)) updates\r\n- [x] Touches critical sections of the codebase (auth, upgrade, etc.)\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/comments/380128924","html_url":"https://github.com/mattermost/mattermost-server/pull/8587#issuecomment-380128924","issue_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/8587","id":380128924,"user":{"login":"lieut-data","id":1023171,"avatar_url":"https://avatars2.githubusercontent.com/u/1023171?v=4","gravatar_id":"","url":"https://api.github.com/users/lieut-data","html_url":"https://github.com/lieut-data","followers_url":"https://api.github.com/users/lieut-data/followers","following_url":"https://api.github.com/users/lieut-data/following{/other_user}","gists_url":"https://api.github.com/users/lieut-data/gists{/gist_id}","starred_url":"https://api.github.com/users/lieut-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lieut-data/subscriptions","organizations_url":"https://api.github.com/users/lieut-data/orgs","repos_url":"https://api.github.com/users/lieut-data/repos","events_url":"https://api.github.com/users/lieut-data/events{/privacy}","received_events_url":"https://api.github.com/users/lieut-data/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T14:49:21Z","updated_at":"2018-04-10T14:49:21Z","author_association":"CONTRIBUTOR","body":"This PR is on hold until we update the glide dependencies (and it becomes sane to add a new dependency). There are some breaking changes upstream from what I can see."}}
{"actor":{"display_login":"lieut-data"}}