{"action":"created","comment":{"url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/comments/209302284","pull_request_review_id":145295390,"id":209302284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTMwMjI4NA==","diff_hunk":"@@ -24,6 +24,7 @@ norecursedirs = .* docs requirements\n \n [testenv]\n deps =\n+    django18: Django==1.8.18","path":"tox.ini","position":null,"original_position":11,"commit_id":"68361d8a824cca9683665374648b7c456f2eb3c4","original_commit_id":"090f61d83a9655afba82f599276d6a41e2f0865e","user":{"login":"pomegranited","id":7556571,"node_id":"MDQ6VXNlcjc1NTY1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"Yeah.. I thought I'd pin it to the Ginkgo revision, but I see your point..  Fixed with 68361d8a824cca9683665374648b7c456f2eb3c4","created_at":"2018-08-10T15:41:56Z","updated_at":"2018-08-10T15:41:56Z","html_url":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2#discussion_r209302284","pull_request_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/comments/209302284"},"html":{"href":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2#discussion_r209302284"},"pull_request":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2"}},"in_reply_to_id":209278177},"pull_request":{"url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2","id":206901362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTAxMzYy","html_url":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2","diff_url":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2.diff","patch_url":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2.patch","issue_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/2","number":2,"state":"open","locked":false,"title":"[MCKIN-8112] Fixes error with duplicated url namespace","user":{"login":"pomegranited","id":7556571,"node_id":"MDQ6VXNlcjc1NTY1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"**Description:** \r\n\r\nFixes incompatibilities encountered when running this library with Django 1.8, e.g. https://code.djangoproject.com/ticket/28691\r\n\r\n**JIRA:** MCKIN-8112\r\n\r\n**Dependencies:** None\r\n\r\n**Installation instructions:**\r\n\r\nInstallation instructions for ginkgo edx-platform, which does not support django app plugins:\r\n\r\n1. Install this package in the edxapp virtualenv.\r\n1. Add `user_manager` to the `lms.env.common.INSTALLED_APPS` list.\r\n1. Add the urls to the `lms.urls`:\r\n   ```python\r\n   urlpatterns += (\r\n       url(r'^api/user_manager/', include('user_manager.api.urls', namespace='user-manager-api')),\r\n   )\r\n   ```\r\n1. Run migrations to get the new tables.\r\n\r\n**Testing instructions:**\r\n\r\nManual tests:\r\n1. Open http://localhost:8000/api/user_manager/v1/managers/\r\n1. Expect the page to load without error.\r\n\r\nAutomated tests:\r\n1. See updated [README.rst](https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2/files#diff-88b99bb28683bd5b7e3a204826ead112) for testing instructions.\r\n\r\n**Reviewers:**\r\n- [ ] @jcdyer \r\n\r\n**Merge checklist:**\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Version bumped\r\n- [ ] Changelog record added\r\n- [ ] Documentation updated (not only docstrings)\r\n- [ ] Commits are squashed\r\n- [ ] PR author is listed in AUTHORS\r\n\r\n**Post merge:**\r\n- [ ] Create a tag \r\n- [ ] Check new version is pushed to PyPI after tag-triggered build is finished.\r\n- [ ] Delete working branch (if not needed anymore)\r\n\r\n**Author concerns:**\r\n\r\n1. I encountered this error when backporting this application to Ginkgo (edx-solutions), so am unsure whether it happens in edx-platform `master`.\r\n1. I also tried removing the `namespace` parameter from the url include in `lms.urls`, but it did not resolve the issue.","created_at":"2018-08-08T06:06:19Z","updated_at":"2018-08-10T15:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2b868ac4ff565c422aae2cb8b911fcb65787dc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/2/comments","statuses_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/statuses/68361d8a824cca9683665374648b7c456f2eb3c4","head":{"label":"open-craft:MCKIN-8112-fix-url-namespace","ref":"MCKIN-8112-fix-url-namespace","sha":"68361d8a824cca9683665374648b7c456f2eb3c4","user":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":143657143,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NTcxNDM=","name":"openedx-user-manager-api","full_name":"open-craft/openedx-user-manager-api","owner":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/openedx-user-manager-api","description":"A Django app for providing a user-manager relationship API in Open edX","fork":true,"url":"https://api.github.com/repos/open-craft/openedx-user-manager-api","forks_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/forks","keys_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/teams","hooks_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/hooks","issue_events_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/events","assignees_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/tags","blobs_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/languages","stargazers_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/stargazers","contributors_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/contributors","subscribers_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/subscribers","subscription_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/subscription","commits_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/merges","archive_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/downloads","issues_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/openedx-user-manager-api/deployments","created_at":"2018-08-06T00:15:35Z","updated_at":"2018-08-06T00:15:37Z","pushed_at":"2018-08-10T15:41:09Z","git_url":"git://github.com/open-craft/openedx-user-manager-api.git","ssh_url":"git@github.com:open-craft/openedx-user-manager-api.git","clone_url":"https://github.com/open-craft/openedx-user-manager-api.git","svn_url":"https://github.com/open-craft/openedx-user-manager-api","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mckinseyacademy:master","ref":"master","sha":"8613a445afedd5e54330757342bfb57ed1ddd5e9","user":{"login":"mckinseyacademy","id":6392729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/6392729?v=4","gravatar_id":"","url":"https://api.github.com/users/mckinseyacademy","html_url":"https://github.com/mckinseyacademy","followers_url":"https://api.github.com/users/mckinseyacademy/followers","following_url":"https://api.github.com/users/mckinseyacademy/following{/other_user}","gists_url":"https://api.github.com/users/mckinseyacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/mckinseyacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckinseyacademy/subscriptions","organizations_url":"https://api.github.com/users/mckinseyacademy/orgs","repos_url":"https://api.github.com/users/mckinseyacademy/repos","events_url":"https://api.github.com/users/mckinseyacademy/events{/privacy}","received_events_url":"https://api.github.com/users/mckinseyacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":142927937,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5Mjc5Mzc=","name":"openedx-user-manager-api","full_name":"mckinseyacademy/openedx-user-manager-api","owner":{"login":"mckinseyacademy","id":6392729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/6392729?v=4","gravatar_id":"","url":"https://api.github.com/users/mckinseyacademy","html_url":"https://github.com/mckinseyacademy","followers_url":"https://api.github.com/users/mckinseyacademy/followers","following_url":"https://api.github.com/users/mckinseyacademy/following{/other_user}","gists_url":"https://api.github.com/users/mckinseyacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/mckinseyacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckinseyacademy/subscriptions","organizations_url":"https://api.github.com/users/mckinseyacademy/orgs","repos_url":"https://api.github.com/users/mckinseyacademy/repos","events_url":"https://api.github.com/users/mckinseyacademy/events{/privacy}","received_events_url":"https://api.github.com/users/mckinseyacademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mckinseyacademy/openedx-user-manager-api","description":"A Django app for providing a user-manager relationship API in Open edX","fork":false,"url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api","forks_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/forks","keys_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/teams","hooks_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/hooks","issue_events_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/events{/number}","events_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/events","assignees_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/assignees{/user}","branches_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/branches{/branch}","tags_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/tags","blobs_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/languages","stargazers_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/stargazers","contributors_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/contributors","subscribers_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/subscribers","subscription_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/subscription","commits_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/contents/{+path}","compare_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/merges","archive_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/downloads","issues_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues{/number}","pulls_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/labels{/name}","releases_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/releases{/id}","deployments_url":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/deployments","created_at":"2018-07-30T21:02:53Z","updated_at":"2018-08-01T22:46:29Z","pushed_at":"2018-08-10T15:41:09Z","git_url":"git://github.com/mckinseyacademy/openedx-user-manager-api.git","ssh_url":"git@github.com:mckinseyacademy/openedx-user-manager-api.git","clone_url":"https://github.com/mckinseyacademy/openedx-user-manager-api.git","svn_url":"https://github.com/mckinseyacademy/openedx-user-manager-api","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2"},"html":{"href":"https://github.com/mckinseyacademy/openedx-user-manager-api/pull/2"},"issue":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/2"},"comments":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mckinseyacademy/openedx-user-manager-api/statuses/68361d8a824cca9683665374648b7c456f2eb3c4"}},"author_association":"NONE"}}
{"actor":{"display_login":"pomegranited"}}