{"action":"created","comment":{"url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/comments/245066207","pull_request_review_id":189098017,"id":245066207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA2NjIwNw==","diff_hunk":"@@ -266,6 +266,12 @@ static inline unsigned char *chunk_memcpy(unsigned char *out, unsigned char *fro\n     return out;\n }\n \n+#if defined(__arm__) || defined(__aarch64__) || defined(_M_ARM)","path":"memcopy.h","position":4,"original_position":4,"commit_id":"f14c69335b4da0cf887f3fa16acd5cab875a136c","original_commit_id":"f14c69335b4da0cf887f3fa16acd5cab875a136c","user":{"login":"sebpop","id":568397,"node_id":"MDQ6VXNlcjU2ODM5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/568397?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpop","html_url":"https://github.com/sebpop","followers_url":"https://api.github.com/users/sebpop/followers","following_url":"https://api.github.com/users/sebpop/following{/other_user}","gists_url":"https://api.github.com/users/sebpop/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpop/subscriptions","organizations_url":"https://api.github.com/users/sebpop/orgs","repos_url":"https://api.github.com/users/sebpop/repos","events_url":"https://api.github.com/users/sebpop/events{/privacy}","received_events_url":"https://api.github.com/users/sebpop/received_events","type":"User","site_admin":false},"body":"I know that calling memset is better for x86_64, so it is better to change the ifdef like this:\r\n```\r\n#undef CALL_MEMSET\r\n#if defined(__x86_64) || defined(__i386_)\r\n# define CALL_MEMSET 1\r\n#endif\r\n```","created_at":"2019-01-03T17:02:19Z","updated_at":"2019-01-03T17:02:19Z","html_url":"https://github.com/zlib-ng/zlib-ng/pull/267#discussion_r245066207","pull_request_url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/comments/245066207"},"html":{"href":"https://github.com/zlib-ng/zlib-ng/pull/267#discussion_r245066207"},"pull_request":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267","id":241844813,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODQ0ODEz","html_url":"https://github.com/zlib-ng/zlib-ng/pull/267","diff_url":"https://github.com/zlib-ng/zlib-ng/pull/267.diff","patch_url":"https://github.com/zlib-ng/zlib-ng/pull/267.patch","issue_url":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/267","number":267,"state":"open","locked":false,"title":"on x86_64 call libc's memset","user":{"login":"sebpop","id":568397,"node_id":"MDQ6VXNlcjU2ODM5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/568397?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpop","html_url":"https://github.com/sebpop","followers_url":"https://api.github.com/users/sebpop/followers","following_url":"https://api.github.com/users/sebpop/following{/other_user}","gists_url":"https://api.github.com/users/sebpop/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpop/subscriptions","organizations_url":"https://api.github.com/users/sebpop/orgs","repos_url":"https://api.github.com/users/sebpop/repos","events_url":"https://api.github.com/users/sebpop/events{/privacy}","received_events_url":"https://api.github.com/users/sebpop/received_events","type":"User","site_admin":false},"body":"On x86_64-linux by just calling libc's memset, we get faster inflate over all\r\nthe chromium benchmarks with up to 10% speedup.\r\nhttps://gist.github.com/sebpop/326c5120b6fa6cffc0e5e2017e907383\r\n\r\nOn aarch64-linux calling libc's memset ends up being just regressions:\r\nhttps://gist.github.com/sebpop/0260bf9f76b568f5b4763b5d5562790b","created_at":"2019-01-02T20:52:08Z","updated_at":"2019-01-03T17:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62cfff0d527d8c2c201cc587fb4e9a4a08664c32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267/commits","review_comments_url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267/comments","review_comment_url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/267/comments","statuses_url":"https://api.github.com/repos/zlib-ng/zlib-ng/statuses/f14c69335b4da0cf887f3fa16acd5cab875a136c","head":{"label":"sebpop:call-memset","ref":"call-memset","sha":"f14c69335b4da0cf887f3fa16acd5cab875a136c","user":{"login":"sebpop","id":568397,"node_id":"MDQ6VXNlcjU2ODM5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/568397?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpop","html_url":"https://github.com/sebpop","followers_url":"https://api.github.com/users/sebpop/followers","following_url":"https://api.github.com/users/sebpop/following{/other_user}","gists_url":"https://api.github.com/users/sebpop/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpop/subscriptions","organizations_url":"https://api.github.com/users/sebpop/orgs","repos_url":"https://api.github.com/users/sebpop/repos","events_url":"https://api.github.com/users/sebpop/events{/privacy}","received_events_url":"https://api.github.com/users/sebpop/received_events","type":"User","site_admin":false},"repo":{"id":83336318,"node_id":"MDEwOlJlcG9zaXRvcnk4MzMzNjMxOA==","name":"zlib-ng","full_name":"sebpop/zlib-ng","private":false,"owner":{"login":"sebpop","id":568397,"node_id":"MDQ6VXNlcjU2ODM5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/568397?v=4","gravatar_id":"","url":"https://api.github.com/users/sebpop","html_url":"https://github.com/sebpop","followers_url":"https://api.github.com/users/sebpop/followers","following_url":"https://api.github.com/users/sebpop/following{/other_user}","gists_url":"https://api.github.com/users/sebpop/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpop/subscriptions","organizations_url":"https://api.github.com/users/sebpop/orgs","repos_url":"https://api.github.com/users/sebpop/repos","events_url":"https://api.github.com/users/sebpop/events{/privacy}","received_events_url":"https://api.github.com/users/sebpop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebpop/zlib-ng","description":"zlib for the \"next generation\" systems. Drop-In replacement with some serious optimizations.","fork":true,"url":"https://api.github.com/repos/sebpop/zlib-ng","forks_url":"https://api.github.com/repos/sebpop/zlib-ng/forks","keys_url":"https://api.github.com/repos/sebpop/zlib-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebpop/zlib-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebpop/zlib-ng/teams","hooks_url":"https://api.github.com/repos/sebpop/zlib-ng/hooks","issue_events_url":"https://api.github.com/repos/sebpop/zlib-ng/issues/events{/number}","events_url":"https://api.github.com/repos/sebpop/zlib-ng/events","assignees_url":"https://api.github.com/repos/sebpop/zlib-ng/assignees{/user}","branches_url":"https://api.github.com/repos/sebpop/zlib-ng/branches{/branch}","tags_url":"https://api.github.com/repos/sebpop/zlib-ng/tags","blobs_url":"https://api.github.com/repos/sebpop/zlib-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebpop/zlib-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebpop/zlib-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebpop/zlib-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebpop/zlib-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/sebpop/zlib-ng/languages","stargazers_url":"https://api.github.com/repos/sebpop/zlib-ng/stargazers","contributors_url":"https://api.github.com/repos/sebpop/zlib-ng/contributors","subscribers_url":"https://api.github.com/repos/sebpop/zlib-ng/subscribers","subscription_url":"https://api.github.com/repos/sebpop/zlib-ng/subscription","commits_url":"https://api.github.com/repos/sebpop/zlib-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebpop/zlib-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebpop/zlib-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebpop/zlib-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebpop/zlib-ng/contents/{+path}","compare_url":"https://api.github.com/repos/sebpop/zlib-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebpop/zlib-ng/merges","archive_url":"https://api.github.com/repos/sebpop/zlib-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebpop/zlib-ng/downloads","issues_url":"https://api.github.com/repos/sebpop/zlib-ng/issues{/number}","pulls_url":"https://api.github.com/repos/sebpop/zlib-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/sebpop/zlib-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/sebpop/zlib-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebpop/zlib-ng/labels{/name}","releases_url":"https://api.github.com/repos/sebpop/zlib-ng/releases{/id}","deployments_url":"https://api.github.com/repos/sebpop/zlib-ng/deployments","created_at":"2017-02-27T17:13:24Z","updated_at":"2019-01-02T21:51:27Z","pushed_at":"2019-01-02T21:51:25Z","git_url":"git://github.com/sebpop/zlib-ng.git","ssh_url":"git@github.com:sebpop/zlib-ng.git","clone_url":"https://github.com/sebpop/zlib-ng.git","svn_url":"https://github.com/sebpop/zlib-ng","homepage":"","size":5236,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib","node_id":"MDc6TGljZW5zZTI3"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zlib-ng:develop","ref":"develop","sha":"ec85a0a5568712d2654fabe8dd3432bf8389349a","user":{"login":"zlib-ng","id":45075615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDc1NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/45075615?v=4","gravatar_id":"","url":"https://api.github.com/users/zlib-ng","html_url":"https://github.com/zlib-ng","followers_url":"https://api.github.com/users/zlib-ng/followers","following_url":"https://api.github.com/users/zlib-ng/following{/other_user}","gists_url":"https://api.github.com/users/zlib-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/zlib-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlib-ng/subscriptions","organizations_url":"https://api.github.com/users/zlib-ng/orgs","repos_url":"https://api.github.com/users/zlib-ng/repos","events_url":"https://api.github.com/users/zlib-ng/events{/privacy}","received_events_url":"https://api.github.com/users/zlib-ng/received_events","type":"Organization","site_admin":false},"repo":{"id":25165333,"node_id":"MDEwOlJlcG9zaXRvcnkyNTE2NTMzMw==","name":"zlib-ng","full_name":"zlib-ng/zlib-ng","private":false,"owner":{"login":"zlib-ng","id":45075615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDc1NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/45075615?v=4","gravatar_id":"","url":"https://api.github.com/users/zlib-ng","html_url":"https://github.com/zlib-ng","followers_url":"https://api.github.com/users/zlib-ng/followers","following_url":"https://api.github.com/users/zlib-ng/following{/other_user}","gists_url":"https://api.github.com/users/zlib-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/zlib-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlib-ng/subscriptions","organizations_url":"https://api.github.com/users/zlib-ng/orgs","repos_url":"https://api.github.com/users/zlib-ng/repos","events_url":"https://api.github.com/users/zlib-ng/events{/privacy}","received_events_url":"https://api.github.com/users/zlib-ng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zlib-ng/zlib-ng","description":"zlib replacement with optimizations for \"next generation\" systems.","fork":false,"url":"https://api.github.com/repos/zlib-ng/zlib-ng","forks_url":"https://api.github.com/repos/zlib-ng/zlib-ng/forks","keys_url":"https://api.github.com/repos/zlib-ng/zlib-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zlib-ng/zlib-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zlib-ng/zlib-ng/teams","hooks_url":"https://api.github.com/repos/zlib-ng/zlib-ng/hooks","issue_events_url":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/events{/number}","events_url":"https://api.github.com/repos/zlib-ng/zlib-ng/events","assignees_url":"https://api.github.com/repos/zlib-ng/zlib-ng/assignees{/user}","branches_url":"https://api.github.com/repos/zlib-ng/zlib-ng/branches{/branch}","tags_url":"https://api.github.com/repos/zlib-ng/zlib-ng/tags","blobs_url":"https://api.github.com/repos/zlib-ng/zlib-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zlib-ng/zlib-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zlib-ng/zlib-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/zlib-ng/zlib-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zlib-ng/zlib-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/zlib-ng/zlib-ng/languages","stargazers_url":"https://api.github.com/repos/zlib-ng/zlib-ng/stargazers","contributors_url":"https://api.github.com/repos/zlib-ng/zlib-ng/contributors","subscribers_url":"https://api.github.com/repos/zlib-ng/zlib-ng/subscribers","subscription_url":"https://api.github.com/repos/zlib-ng/zlib-ng/subscription","commits_url":"https://api.github.com/repos/zlib-ng/zlib-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/zlib-ng/zlib-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/zlib-ng/zlib-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/zlib-ng/zlib-ng/contents/{+path}","compare_url":"https://api.github.com/repos/zlib-ng/zlib-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zlib-ng/zlib-ng/merges","archive_url":"https://api.github.com/repos/zlib-ng/zlib-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zlib-ng/zlib-ng/downloads","issues_url":"https://api.github.com/repos/zlib-ng/zlib-ng/issues{/number}","pulls_url":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/zlib-ng/zlib-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/zlib-ng/zlib-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zlib-ng/zlib-ng/labels{/name}","releases_url":"https://api.github.com/repos/zlib-ng/zlib-ng/releases{/id}","deployments_url":"https://api.github.com/repos/zlib-ng/zlib-ng/deployments","created_at":"2014-10-13T15:47:27Z","updated_at":"2019-01-03T11:33:52Z","pushed_at":"2019-01-02T21:16:28Z","git_url":"git://github.com/zlib-ng/zlib-ng.git","ssh_url":"git@github.com:zlib-ng/zlib-ng.git","clone_url":"https://github.com/zlib-ng/zlib-ng.git","svn_url":"https://github.com/zlib-ng/zlib-ng","homepage":"","size":4240,"stargazers_count":463,"watchers_count":463,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib","node_id":"MDc6TGljZW5zZTI3"},"forks":57,"open_issues":40,"watchers":463,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267"},"html":{"href":"https://github.com/zlib-ng/zlib-ng/pull/267"},"issue":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/267"},"comments":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/zlib-ng/zlib-ng/statuses/f14c69335b4da0cf887f3fa16acd5cab875a136c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sebpop"}}