{"action":"created","comment":{"url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/comments/176766308","pull_request_review_id":106528948,"id":176766308,"diff_hunk":"@@ -140,14 +146,19 @@ newPaymentBatch sa passphrase NewBatchPayment {..} = do\n sendSignedTx\n      :: MonadWalletWebMode m\n      => SendActions m\n-     -> TxAux\n+     -> CEncTxWithWit\n      -> m Bool\n-sendSignedTx sa txAux =\n-    -- This is done for two reasons:\n-    -- 1. In order not to overflow relay.\n-    -- 2. To let other things (e. g. block processing) happen if\n-    -- `newPayment`s are done continuously.\n-    notFasterThan (6 :: Second) $ sendTxAux sa txAux\n+sendSignedTx sa (CEncTxWithWit (CEncodedData encodedTx) txWitness) = do\n+    let maybeTx = P.decodeFull $ BSL.toStrict encodedTx\n+        maybeTxAux = flip TxAux txWitness <$> maybeTx\n+    case maybeTxAux of\n+      Right txAux ->\n+        -- This is done for two reasons:\n+        -- 1. In order not to overflow relay.\n+        -- 2. To let other things (e. g. block processing) happen if\n+        -- `newPayment`s are done continuously.\n+        notFasterThan (6 :: Second) $ sendTxAux sa txAux\n+      Left e -> return False","path":"wallet/src/Pos/Wallet/Web/Methods/Payment.hs","position":75,"original_position":75,"commit_id":"798ed8f305feda49322d6e7122f54f3277df01a2","original_commit_id":"798ed8f305feda49322d6e7122f54f3277df01a2","user":{"login":"javierdiaz72","id":32520015,"avatar_url":"https://avatars2.githubusercontent.com/u/32520015?v=4","gravatar_id":"","url":"https://api.github.com/users/javierdiaz72","html_url":"https://github.com/javierdiaz72","followers_url":"https://api.github.com/users/javierdiaz72/followers","following_url":"https://api.github.com/users/javierdiaz72/following{/other_user}","gists_url":"https://api.github.com/users/javierdiaz72/gists{/gist_id}","starred_url":"https://api.github.com/users/javierdiaz72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierdiaz72/subscriptions","organizations_url":"https://api.github.com/users/javierdiaz72/orgs","repos_url":"https://api.github.com/users/javierdiaz72/repos","events_url":"https://api.github.com/users/javierdiaz72/events{/privacy}","received_events_url":"https://api.github.com/users/javierdiaz72/received_events","type":"User","site_admin":false},"body":"Very very minor detail: Change `e` to `_`.","created_at":"2018-03-23T15:11:33Z","updated_at":"2018-03-23T15:12:06Z","html_url":"https://github.com/atixlabs/cardano-sl/pull/6#discussion_r176766308","pull_request_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/comments/176766308"},"html":{"href":"https://github.com/atixlabs/cardano-sl/pull/6#discussion_r176766308"},"pull_request":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6","id":177095785,"html_url":"https://github.com/atixlabs/cardano-sl/pull/6","diff_url":"https://github.com/atixlabs/cardano-sl/pull/6.diff","patch_url":"https://github.com/atixlabs/cardano-sl/pull/6.patch","issue_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/6","number":6,"state":"open","locked":false,"title":"[PI-25] Change input to encoded Tx and TxWitness","user":{"login":"ntallar","id":23455124,"avatar_url":"https://avatars0.githubusercontent.com/u/23455124?v=4","gravatar_id":"","url":"https://api.github.com/users/ntallar","html_url":"https://github.com/ntallar","followers_url":"https://api.github.com/users/ntallar/followers","following_url":"https://api.github.com/users/ntallar/following{/other_user}","gists_url":"https://api.github.com/users/ntallar/gists{/gist_id}","starred_url":"https://api.github.com/users/ntallar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntallar/subscriptions","organizations_url":"https://api.github.com/users/ntallar/orgs","repos_url":"https://api.github.com/users/ntallar/repos","events_url":"https://api.github.com/users/ntallar/events{/privacy}","received_events_url":"https://api.github.com/users/ntallar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-23T15:00:27Z","updated_at":"2018-03-23T15:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52f4ac6f36a1611742338cdea37b5b29829b01a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6/commits","review_comments_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6/comments","review_comment_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/6/comments","statuses_url":"https://api.github.com/repos/atixlabs/cardano-sl/statuses/798ed8f305feda49322d6e7122f54f3277df01a2","head":{"label":"atixlabs:feature/pi25-partial-encode-input","ref":"feature/pi25-partial-encode-input","sha":"798ed8f305feda49322d6e7122f54f3277df01a2","user":{"login":"atixlabs","id":7552221,"avatar_url":"https://avatars0.githubusercontent.com/u/7552221?v=4","gravatar_id":"","url":"https://api.github.com/users/atixlabs","html_url":"https://github.com/atixlabs","followers_url":"https://api.github.com/users/atixlabs/followers","following_url":"https://api.github.com/users/atixlabs/following{/other_user}","gists_url":"https://api.github.com/users/atixlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/atixlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atixlabs/subscriptions","organizations_url":"https://api.github.com/users/atixlabs/orgs","repos_url":"https://api.github.com/users/atixlabs/repos","events_url":"https://api.github.com/users/atixlabs/events{/privacy}","received_events_url":"https://api.github.com/users/atixlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":125417419,"name":"cardano-sl","full_name":"atixlabs/cardano-sl","owner":{"login":"atixlabs","id":7552221,"avatar_url":"https://avatars0.githubusercontent.com/u/7552221?v=4","gravatar_id":"","url":"https://api.github.com/users/atixlabs","html_url":"https://github.com/atixlabs","followers_url":"https://api.github.com/users/atixlabs/followers","following_url":"https://api.github.com/users/atixlabs/following{/other_user}","gists_url":"https://api.github.com/users/atixlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/atixlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atixlabs/subscriptions","organizations_url":"https://api.github.com/users/atixlabs/orgs","repos_url":"https://api.github.com/users/atixlabs/repos","events_url":"https://api.github.com/users/atixlabs/events{/privacy}","received_events_url":"https://api.github.com/users/atixlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atixlabs/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":true,"url":"https://api.github.com/repos/atixlabs/cardano-sl","forks_url":"https://api.github.com/repos/atixlabs/cardano-sl/forks","keys_url":"https://api.github.com/repos/atixlabs/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atixlabs/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atixlabs/cardano-sl/teams","hooks_url":"https://api.github.com/repos/atixlabs/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/atixlabs/cardano-sl/events","assignees_url":"https://api.github.com/repos/atixlabs/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/atixlabs/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/atixlabs/cardano-sl/tags","blobs_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atixlabs/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/atixlabs/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/atixlabs/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/atixlabs/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/atixlabs/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/atixlabs/cardano-sl/subscription","commits_url":"https://api.github.com/repos/atixlabs/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/atixlabs/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/atixlabs/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/atixlabs/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atixlabs/cardano-sl/merges","archive_url":"https://api.github.com/repos/atixlabs/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atixlabs/cardano-sl/downloads","issues_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/atixlabs/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/atixlabs/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atixlabs/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/atixlabs/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/atixlabs/cardano-sl/deployments","created_at":"2018-03-15T19:36:04Z","updated_at":"2018-03-15T19:36:10Z","pushed_at":"2018-03-23T15:00:27Z","git_url":"git://github.com/atixlabs/cardano-sl.git","ssh_url":"git@github.com:atixlabs/cardano-sl.git","clone_url":"https://github.com/atixlabs/cardano-sl.git","svn_url":"https://github.com/atixlabs/cardano-sl","homepage":"","size":86837,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"atixlabs:poc","ref":"poc","sha":"933e669d0ed40faffab3b977e9c259142d8a94de","user":{"login":"atixlabs","id":7552221,"avatar_url":"https://avatars0.githubusercontent.com/u/7552221?v=4","gravatar_id":"","url":"https://api.github.com/users/atixlabs","html_url":"https://github.com/atixlabs","followers_url":"https://api.github.com/users/atixlabs/followers","following_url":"https://api.github.com/users/atixlabs/following{/other_user}","gists_url":"https://api.github.com/users/atixlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/atixlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atixlabs/subscriptions","organizations_url":"https://api.github.com/users/atixlabs/orgs","repos_url":"https://api.github.com/users/atixlabs/repos","events_url":"https://api.github.com/users/atixlabs/events{/privacy}","received_events_url":"https://api.github.com/users/atixlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":125417419,"name":"cardano-sl","full_name":"atixlabs/cardano-sl","owner":{"login":"atixlabs","id":7552221,"avatar_url":"https://avatars0.githubusercontent.com/u/7552221?v=4","gravatar_id":"","url":"https://api.github.com/users/atixlabs","html_url":"https://github.com/atixlabs","followers_url":"https://api.github.com/users/atixlabs/followers","following_url":"https://api.github.com/users/atixlabs/following{/other_user}","gists_url":"https://api.github.com/users/atixlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/atixlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atixlabs/subscriptions","organizations_url":"https://api.github.com/users/atixlabs/orgs","repos_url":"https://api.github.com/users/atixlabs/repos","events_url":"https://api.github.com/users/atixlabs/events{/privacy}","received_events_url":"https://api.github.com/users/atixlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atixlabs/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":true,"url":"https://api.github.com/repos/atixlabs/cardano-sl","forks_url":"https://api.github.com/repos/atixlabs/cardano-sl/forks","keys_url":"https://api.github.com/repos/atixlabs/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atixlabs/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atixlabs/cardano-sl/teams","hooks_url":"https://api.github.com/repos/atixlabs/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/atixlabs/cardano-sl/events","assignees_url":"https://api.github.com/repos/atixlabs/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/atixlabs/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/atixlabs/cardano-sl/tags","blobs_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atixlabs/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/atixlabs/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/atixlabs/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/atixlabs/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/atixlabs/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/atixlabs/cardano-sl/subscription","commits_url":"https://api.github.com/repos/atixlabs/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/atixlabs/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/atixlabs/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/atixlabs/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/atixlabs/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atixlabs/cardano-sl/merges","archive_url":"https://api.github.com/repos/atixlabs/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atixlabs/cardano-sl/downloads","issues_url":"https://api.github.com/repos/atixlabs/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/atixlabs/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/atixlabs/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/atixlabs/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atixlabs/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/atixlabs/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/atixlabs/cardano-sl/deployments","created_at":"2018-03-15T19:36:04Z","updated_at":"2018-03-15T19:36:10Z","pushed_at":"2018-03-23T15:00:27Z","git_url":"git://github.com/atixlabs/cardano-sl.git","ssh_url":"git@github.com:atixlabs/cardano-sl.git","clone_url":"https://github.com/atixlabs/cardano-sl.git","svn_url":"https://github.com/atixlabs/cardano-sl","homepage":"","size":86837,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6"},"html":{"href":"https://github.com/atixlabs/cardano-sl/pull/6"},"issue":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/issues/6"},"comments":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/atixlabs/cardano-sl/statuses/798ed8f305feda49322d6e7122f54f3277df01a2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"javierdiaz72"}}