{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/206713378","pull_request_review_id":142180490,"id":206713378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcxMzM3OA==","diff_hunk":"@@ -58,7 +58,6 @@ type Cluster struct {\n ```go\n // AWS converts AWS related config.\n type AWS struct {\n-    AutoScalingGroupExtraTags []map[string]string `json:\"tectonic_autoscaling_group_extra_tags,omitempty\" yaml:\"autoScalingGroupExtraTags,omitempty\"`","path":"Documentation/design/installconfig.md","position":4,"original_position":4,"commit_id":"c9351ed51c8402797b9598ca9ee675def55069db","original_commit_id":"c9351ed51c8402797b9598ca9ee675def55069db","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"This is previous work of tectonic-installer. No need to edit this.","created_at":"2018-07-31T23:18:45Z","updated_at":"2018-07-31T23:18:46Z","html_url":"https://github.com/openshift/installer/pull/88#discussion_r206713378","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/88","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/206713378"},"html":{"href":"https://github.com/openshift/installer/pull/88#discussion_r206713378"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/88","id":205247324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjQ3MzI0","html_url":"https://github.com/openshift/installer/pull/88","diff_url":"https://github.com/openshift/installer/pull/88.diff","patch_url":"https://github.com/openshift/installer/pull/88.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/88","number":88,"state":"open","locked":false,"title":"modules/aws: Drop auto-scaling groups","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"Currently, the installer creates an ASG for both masters and workers.  While this is okay for workers, this causes quite a few headaches for masters.  For example, etcd will be run on the master nodes, but this will be unstable if Amazon is free to delete nodes and recreate them without etcd knowing about it.  Additionally, this makes bootstrap tricky because every master needs to be identical.  In order to break the dependency loop between the MachineConfigController (TNC) and the master nodes, a CNAME is currently used to temporarily redirect Ignition's requests to an S3 bucket with a pre-computed bootstrap config.\n\nThis commit drops the use of ASG for both masters and workers and instead creates individual machines. Once we adopt the use of MachineSets and MachineControllers, we'll regain the functionality we lost by dropping ASGs.\n\nWhile renaming the previous `*-asg` modules, I've also renamed the main Terraform files to `main.tf` to comply with [the standard module structure][1].\n\nThe new `main.tf` follow the example set by `modules/aws/etcd/nodes.tf`, which is why the instance resource declarations have moved to the end of the file.  I've also adjusted the master policy to more closely match the more-restrictive etcd policy, because I don't think the masters will need to push S3 resources, etc.\n\nI've also dropped some redundant names (e.g. `master_profile` -> `master`), because the profile-ness is already covered in the resource name (e.g. `aws_iam_instance_profile.master`).\n\nThe worker load balancer is a bit more complicated now, since we have to loop over both the provided load balancers and the created worker instances to setup associations.\n\n[1]: https://www.terraform.io/docs/modules/create.html#standard-module-structure","created_at":"2018-07-31T21:26:47Z","updated_at":"2018-07-31T23:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7abe86eb005346b4896057d1363249f98004683b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":981486838,"node_id":"MDU6TGFiZWw5ODE0ODY4Mzg=","url":"https://api.github.com/repos/openshift/installer/labels/run-smoke-tests","name":"run-smoke-tests","color":"0e8a16","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/88/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/88/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/88/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/c9351ed51c8402797b9598ca9ee675def55069db","head":{"label":"wking:drop-auto-scaling-groups","ref":"drop-auto-scaling-groups","sha":"c9351ed51c8402797b9598ca9ee675def55069db","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":140026813,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjY4MTM=","name":"openshift-installer","full_name":"wking/openshift-installer","owner":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wking/openshift-installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/wking/openshift-installer","forks_url":"https://api.github.com/repos/wking/openshift-installer/forks","keys_url":"https://api.github.com/repos/wking/openshift-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/openshift-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/openshift-installer/teams","hooks_url":"https://api.github.com/repos/wking/openshift-installer/hooks","issue_events_url":"https://api.github.com/repos/wking/openshift-installer/issues/events{/number}","events_url":"https://api.github.com/repos/wking/openshift-installer/events","assignees_url":"https://api.github.com/repos/wking/openshift-installer/assignees{/user}","branches_url":"https://api.github.com/repos/wking/openshift-installer/branches{/branch}","tags_url":"https://api.github.com/repos/wking/openshift-installer/tags","blobs_url":"https://api.github.com/repos/wking/openshift-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/openshift-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/openshift-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/openshift-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/openshift-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/openshift-installer/languages","stargazers_url":"https://api.github.com/repos/wking/openshift-installer/stargazers","contributors_url":"https://api.github.com/repos/wking/openshift-installer/contributors","subscribers_url":"https://api.github.com/repos/wking/openshift-installer/subscribers","subscription_url":"https://api.github.com/repos/wking/openshift-installer/subscription","commits_url":"https://api.github.com/repos/wking/openshift-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/openshift-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/openshift-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/openshift-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/openshift-installer/contents/{+path}","compare_url":"https://api.github.com/repos/wking/openshift-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/openshift-installer/merges","archive_url":"https://api.github.com/repos/wking/openshift-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/openshift-installer/downloads","issues_url":"https://api.github.com/repos/wking/openshift-installer/issues{/number}","pulls_url":"https://api.github.com/repos/wking/openshift-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/openshift-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/openshift-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/openshift-installer/labels{/name}","releases_url":"https://api.github.com/repos/wking/openshift-installer/releases{/id}","deployments_url":"https://api.github.com/repos/wking/openshift-installer/deployments","created_at":"2018-07-06T20:26:48Z","updated_at":"2018-07-31T22:17:49Z","pushed_at":"2018-07-31T23:12:47Z","git_url":"git://github.com/wking/openshift-installer.git","ssh_url":"git@github.com:wking/openshift-installer.git","clone_url":"https://github.com/wking/openshift-installer.git","svn_url":"https://github.com/wking/openshift-installer","homepage":"","size":35894,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"44ef4be6eacd93f91084186a78b62822c810e159","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-07-31T21:48:48Z","pushed_at":"2018-07-31T23:13:28Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":35881,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":13,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/88"},"html":{"href":"https://github.com/openshift/installer/pull/88"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/88"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/c9351ed51c8402797b9598ca9ee675def55069db"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abhinavdahiya"}}