{"action":"created","comment":{"url":"https://api.github.com/repos/su2code/SU2/pulls/comments/176641996","pull_request_review_id":106381761,"id":176641996,"diff_hunk":"@@ -4978,6 +4985,243 @@ CPhysicalGeometry::CPhysicalGeometry(CGeometry *geometry, CConfig *config) {\n   \n }\n \n+CPhysicalGeometry::CPhysicalGeometry(CGeometry *geometry,\n+                                     CConfig *config,","path":"Common/src/geometry_structure.cpp","position":78,"original_position":78,"commit_id":"6c2a1765141f59ed9de75fa61801d7683b599e41","original_commit_id":"6c2a1765141f59ed9de75fa61801d7683b599e41","user":{"login":"fpalacios","id":29830726,"avatar_url":"https://avatars2.githubusercontent.com/u/29830726?v=4","gravatar_id":"","url":"https://api.github.com/users/fpalacios","html_url":"https://github.com/fpalacios","followers_url":"https://api.github.com/users/fpalacios/followers","following_url":"https://api.github.com/users/fpalacios/following{/other_user}","gists_url":"https://api.github.com/users/fpalacios/gists{/gist_id}","starred_url":"https://api.github.com/users/fpalacios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpalacios/subscriptions","organizations_url":"https://api.github.com/users/fpalacios/orgs","repos_url":"https://api.github.com/users/fpalacios/repos","events_url":"https://api.github.com/users/fpalacios/events{/privacy}","received_events_url":"https://api.github.com/users/fpalacios/received_events","type":"User","site_admin":false},"body":"Is this the new constructor for CPhysicalGeometry? Is the old one still there?","created_at":"2018-03-23T05:28:53Z","updated_at":"2018-03-23T05:35:39Z","html_url":"https://github.com/su2code/SU2/pull/513#discussion_r176641996","pull_request_url":"https://api.github.com/repos/su2code/SU2/pulls/513","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments/176641996"},"html":{"href":"https://github.com/su2code/SU2/pull/513#discussion_r176641996"},"pull_request":{"href":"https://api.github.com/repos/su2code/SU2/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/su2code/SU2/pulls/513","id":174203973,"html_url":"https://github.com/su2code/SU2/pull/513","diff_url":"https://github.com/su2code/SU2/pull/513.diff","patch_url":"https://github.com/su2code/SU2/pull/513.patch","issue_url":"https://api.github.com/repos/su2code/SU2/issues/513","number":513,"state":"open","locked":false,"title":"Fix partitioning","user":{"login":"economon","id":4896083,"avatar_url":"https://avatars0.githubusercontent.com/u/4896083?v=4","gravatar_id":"","url":"https://api.github.com/users/economon","html_url":"https://github.com/economon","followers_url":"https://api.github.com/users/economon/followers","following_url":"https://api.github.com/users/economon/following{/other_user}","gists_url":"https://api.github.com/users/economon/gists{/gist_id}","starred_url":"https://api.github.com/users/economon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/economon/subscriptions","organizations_url":"https://api.github.com/users/economon/orgs","repos_url":"https://api.github.com/users/economon/repos","events_url":"https://api.github.com/users/economon/events{/privacy}","received_events_url":"https://api.github.com/users/economon/received_events","type":"User","site_admin":false},"body":"This Pull Request is the long-awaited overhaul of the front-end partitioning routines for the finite volume solver. It is both a complete refactoring and a streamlining of the routines to remove several bottlenecks (memory and superfluous MPI calls) that were limiting the performance at high rank counts. The rewrite now makes it possible to fix the root issues for the periodic BCs, down to the mesh input level, which is next on the list. \r\n\r\nFor now, the old geometry routines are used for processing meshes with periodic BCs. Once the periodic BCs are all updated, we will remove the old CPhysicalGeometry constructor and associated routines in order to clean up.\r\n\r\n**Note that this PR affects everyone using the finite volume solver.** The regressions are going to fail :). As there are some changes to the order in which element types are read, stored, and partitioned, some cases can show small changes in the residual output, even in serial (especially with multigrid). I have tested everything successfully up to roughly 4000 cores locally, achieving the same final solutions, but it is important that everyone please check your own cases. If we agree that everything is ok, we will have to modify the stored residual values for many regression cases.","created_at":"2018-03-11T04:35:56Z","updated_at":"2018-03-23T05:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f3a38c9fcc94eceae026deb537eabb83c4d989","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/su2code/SU2/pulls/513/commits","review_comments_url":"https://api.github.com/repos/su2code/SU2/pulls/513/comments","review_comment_url":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/su2code/SU2/issues/513/comments","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/6c2a1765141f59ed9de75fa61801d7683b599e41","head":{"label":"su2code:fix_partitioning","ref":"fix_partitioning","sha":"6c2a1765141f59ed9de75fa61801d7683b599e41","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2: An Open-Source Suite for Multiphysics Simulation and Design","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2018-03-20T12:58:03Z","pushed_at":"2018-03-22T10:44:01Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"https://su2code.github.io","size":378002,"stargazers_count":339,"watchers_count":339,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":336,"open_issues":95,"watchers":339,"default_branch":"master"}},"base":{"label":"su2code:develop","ref":"develop","sha":"446d20f2a8d96144f1497fabd39bab3335ac5317","user":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"repo":{"id":11036316,"name":"SU2","full_name":"su2code/SU2","owner":{"login":"su2code","id":4796189,"avatar_url":"https://avatars0.githubusercontent.com/u/4796189?v=4","gravatar_id":"","url":"https://api.github.com/users/su2code","html_url":"https://github.com/su2code","followers_url":"https://api.github.com/users/su2code/followers","following_url":"https://api.github.com/users/su2code/following{/other_user}","gists_url":"https://api.github.com/users/su2code/gists{/gist_id}","starred_url":"https://api.github.com/users/su2code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/su2code/subscriptions","organizations_url":"https://api.github.com/users/su2code/orgs","repos_url":"https://api.github.com/users/su2code/repos","events_url":"https://api.github.com/users/su2code/events{/privacy}","received_events_url":"https://api.github.com/users/su2code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/su2code/SU2","description":"SU2: An Open-Source Suite for Multiphysics Simulation and Design","fork":false,"url":"https://api.github.com/repos/su2code/SU2","forks_url":"https://api.github.com/repos/su2code/SU2/forks","keys_url":"https://api.github.com/repos/su2code/SU2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/su2code/SU2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/su2code/SU2/teams","hooks_url":"https://api.github.com/repos/su2code/SU2/hooks","issue_events_url":"https://api.github.com/repos/su2code/SU2/issues/events{/number}","events_url":"https://api.github.com/repos/su2code/SU2/events","assignees_url":"https://api.github.com/repos/su2code/SU2/assignees{/user}","branches_url":"https://api.github.com/repos/su2code/SU2/branches{/branch}","tags_url":"https://api.github.com/repos/su2code/SU2/tags","blobs_url":"https://api.github.com/repos/su2code/SU2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/su2code/SU2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/su2code/SU2/git/refs{/sha}","trees_url":"https://api.github.com/repos/su2code/SU2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/su2code/SU2/statuses/{sha}","languages_url":"https://api.github.com/repos/su2code/SU2/languages","stargazers_url":"https://api.github.com/repos/su2code/SU2/stargazers","contributors_url":"https://api.github.com/repos/su2code/SU2/contributors","subscribers_url":"https://api.github.com/repos/su2code/SU2/subscribers","subscription_url":"https://api.github.com/repos/su2code/SU2/subscription","commits_url":"https://api.github.com/repos/su2code/SU2/commits{/sha}","git_commits_url":"https://api.github.com/repos/su2code/SU2/git/commits{/sha}","comments_url":"https://api.github.com/repos/su2code/SU2/comments{/number}","issue_comment_url":"https://api.github.com/repos/su2code/SU2/issues/comments{/number}","contents_url":"https://api.github.com/repos/su2code/SU2/contents/{+path}","compare_url":"https://api.github.com/repos/su2code/SU2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/su2code/SU2/merges","archive_url":"https://api.github.com/repos/su2code/SU2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/su2code/SU2/downloads","issues_url":"https://api.github.com/repos/su2code/SU2/issues{/number}","pulls_url":"https://api.github.com/repos/su2code/SU2/pulls{/number}","milestones_url":"https://api.github.com/repos/su2code/SU2/milestones{/number}","notifications_url":"https://api.github.com/repos/su2code/SU2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/su2code/SU2/labels{/name}","releases_url":"https://api.github.com/repos/su2code/SU2/releases{/id}","deployments_url":"https://api.github.com/repos/su2code/SU2/deployments","created_at":"2013-06-28T19:52:40Z","updated_at":"2018-03-20T12:58:03Z","pushed_at":"2018-03-22T10:44:01Z","git_url":"git://github.com/su2code/SU2.git","ssh_url":"git@github.com:su2code/SU2.git","clone_url":"https://github.com/su2code/SU2.git","svn_url":"https://github.com/su2code/SU2","homepage":"https://su2code.github.io","size":378002,"stargazers_count":339,"watchers_count":339,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":336,"open_issues":95,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/su2code/SU2/pulls/513"},"html":{"href":"https://github.com/su2code/SU2/pull/513"},"issue":{"href":"https://api.github.com/repos/su2code/SU2/issues/513"},"comments":{"href":"https://api.github.com/repos/su2code/SU2/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/su2code/SU2/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/su2code/SU2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/su2code/SU2/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/su2code/SU2/statuses/6c2a1765141f59ed9de75fa61801d7683b599e41"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fpalacios"}}