{"action":"created","issue":{"url":"https://api.github.com/repos/ros/ros_comm/issues/1206","repository_url":"https://api.github.com/repos/ros/ros_comm","labels_url":"https://api.github.com/repos/ros/ros_comm/issues/1206/labels{/name}","comments_url":"https://api.github.com/repos/ros/ros_comm/issues/1206/comments","events_url":"https://api.github.com/repos/ros/ros_comm/issues/1206/events","html_url":"https://github.com/ros/ros_comm/pull/1206","id":269210982,"number":1206,"title":"Implement Bag encryption/decryption.","user":{"login":"jwon02","id":16021973,"avatar_url":"https://avatars3.githubusercontent.com/u/16021973?v=4","gravatar_id":"","url":"https://api.github.com/users/jwon02","html_url":"https://github.com/jwon02","followers_url":"https://api.github.com/users/jwon02/followers","following_url":"https://api.github.com/users/jwon02/following{/other_user}","gists_url":"https://api.github.com/users/jwon02/gists{/gist_id}","starred_url":"https://api.github.com/users/jwon02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwon02/subscriptions","organizations_url":"https://api.github.com/users/jwon02/orgs","repos_url":"https://api.github.com/users/jwon02/repos","events_url":"https://api.github.com/users/jwon02/events{/privacy}","received_events_url":"https://api.github.com/users/jwon02/received_events","type":"User","site_admin":false},"labels":[{"id":526649685,"url":"https://api.github.com/repos/ros/ros_comm/labels/consider-future-release","name":"consider-future-release","color":"5319e7","default":false},{"id":11948477,"url":"https://api.github.com/repos/ros/ros_comm/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":515501728,"url":"https://api.github.com/repos/ros/ros_comm/labels/hitlist","name":"hitlist","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-10-27T19:28:00Z","updated_at":"2018-05-19T17:26:41Z","closed_at":"2018-04-24T18:02:49Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/1206","html_url":"https://github.com/ros/ros_comm/pull/1206","diff_url":"https://github.com/ros/ros_comm/pull/1206.diff","patch_url":"https://github.com/ros/ros_comm/pull/1206.patch"},"body":"This PR adds plugins to the `Bag` class to encrypt/decrypt chunks and connection records in a bag file.  By default, the `NoEncryptor` plugin is loaded to generate backward-compatible unencrypted bag files.  Load `AesCbcEncrytpro` to encrypt the bag contents using a GPG key installed in the system.\r\n\r\nABI compatibility is broken by two new members added to `Bag`."},"comment":{"url":"https://api.github.com/repos/ros/ros_comm/issues/comments/390420071","html_url":"https://github.com/ros/ros_comm/pull/1206#issuecomment-390420071","issue_url":"https://api.github.com/repos/ros/ros_comm/issues/1206","id":390420071,"user":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars0.githubusercontent.com/u/944666?v=4","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"created_at":"2018-05-19T17:26:41Z","updated_at":"2018-05-19T17:26:41Z","author_association":"MEMBER","body":"Oh blah, that is a fail on my part. The three options given in the original discussion were:\r\n\r\n- Split rosconsole out of this repo. This should be relatively clean, as rostime and rosunit are already in non-ros_comm repos.\r\n- Break pluginlib's dep on rosconsole. Proposed and rejected in https://github.com/ros/pluginlib/issues/81.\r\n- Hardcode the list of supported plugins, thus dropping (at least for now) the need to explicitly use pluginlib. The only external work I'm aware of which ties into any of this is the hardware-accelerated encryption work discussed in https://github.com/shield-ai/ros_comm/pull/1, but it's not actually implemented as a separate plugin. So this is doable, but limits future expansion. Plus I have other places in ros_comm where I'd like to be able to introduce plugin hooks...\r\n\r\nSo I don't think I have the necessary permissions to create a new repo for rosconsole, but that would be my preferred resolution to this. If such a repo can be created, I can put up the PRs to drop rosconsole from this repo and add it to the new one."}}
{"actor":{"display_login":"mikepurvis"}}