{"action":"opened","number":256,"pull_request":{"url":"https://api.github.com/repos/tweag/rules_haskell/pulls/256","id":189134457,"html_url":"https://github.com/tweag/rules_haskell/pull/256","diff_url":"https://github.com/tweag/rules_haskell/pull/256.diff","patch_url":"https://github.com/tweag/rules_haskell/pull/256.patch","issue_url":"https://api.github.com/repos/tweag/rules_haskell/issues/256","number":256,"state":"open","locked":false,"title":"Set CURRENT_PACKAGE_KEY for every haskell_library rule.","user":{"login":"judah","id":49143,"avatar_url":"https://avatars3.githubusercontent.com/u/49143?v=4","gravatar_id":"","url":"https://api.github.com/users/judah","html_url":"https://github.com/judah","followers_url":"https://api.github.com/users/judah/followers","following_url":"https://api.github.com/users/judah/following{/other_user}","gists_url":"https://api.github.com/users/judah/gists{/gist_id}","starred_url":"https://api.github.com/users/judah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judah/subscriptions","organizations_url":"https://api.github.com/users/judah/orgs","repos_url":"https://api.github.com/users/judah/repos","events_url":"https://api.github.com/users/judah/events{/privacy}","received_events_url":"https://api.github.com/users/judah/received_events","type":"User","site_admin":false},"body":"It's needed by several Cabal packages; for example `lens`:\r\nhttps://github.com/ekmett/lens/blob/1aa37c4/src/Control/Lens/Internal/TH.hs#L102\r\n\r\nIf you don't set it, `lens` defaults to logic like:\r\n```\r\nlensPackageKey          = \"lens-\" ++ showVersion version\r\n```\r\nBut that doesn't work as of #222 which makes the package key more complicated.\r\n\r\nFor example the `fuzzyset` package breaks with Hazel:\r\n```\r\nbazel-out/k8-fastbuild/bin/external/haskell_fuzzyset/gen-srcs-fuzzyset/Data/FuzzySet/Lens.hs:17:1: error:\r\n    * Failed to load interface for `Control.Lens.Type'\r\n      no unit id matching `lens-4.15.4' was found\r\n      (This unit ID looks like the source package ID;\r\n       the real unit ID is `externalZShaskellZUlensZSlens-4.15.4')\r\n    * In the type signature:\r\n        _useLevenshtein :: lens-4.15.4:Control.Lens.Type.Lens' FuzzySet Bool\r\n   |\r\n17 | makeLensesFor\r\n   | ^^^^^^^^^^^^^...\r\n\r\n```\r\n\r\nGiven that `rules_haskell` has the logic that creates the id string, I think\r\nit makes sense for it to set this parameter itself (rather than manually-written\r\nrules, or macros that use it like Hazel/cabal2bazel).","created_at":"2018-05-18T21:03:11Z","updated_at":"2018-05-18T21:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tweag/rules_haskell/pulls/256/commits","review_comments_url":"https://api.github.com/repos/tweag/rules_haskell/pulls/256/comments","review_comment_url":"https://api.github.com/repos/tweag/rules_haskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tweag/rules_haskell/issues/256/comments","statuses_url":"https://api.github.com/repos/tweag/rules_haskell/statuses/e15f4d2f202b266c2a97cba02d8f2ad4aec34ec3","head":{"label":"tweag:current-package-key","ref":"current-package-key","sha":"e15f4d2f202b266c2a97cba02d8f2ad4aec34ec3","user":{"login":"tweag","id":6057932,"avatar_url":"https://avatars3.githubusercontent.com/u/6057932?v=4","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"repo":{"id":109669839,"name":"rules_haskell","full_name":"tweag/rules_haskell","owner":{"login":"tweag","id":6057932,"avatar_url":"https://avatars3.githubusercontent.com/u/6057932?v=4","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tweag/rules_haskell","description":"Haskell rules for Bazel.","fork":false,"url":"https://api.github.com/repos/tweag/rules_haskell","forks_url":"https://api.github.com/repos/tweag/rules_haskell/forks","keys_url":"https://api.github.com/repos/tweag/rules_haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweag/rules_haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweag/rules_haskell/teams","hooks_url":"https://api.github.com/repos/tweag/rules_haskell/hooks","issue_events_url":"https://api.github.com/repos/tweag/rules_haskell/issues/events{/number}","events_url":"https://api.github.com/repos/tweag/rules_haskell/events","assignees_url":"https://api.github.com/repos/tweag/rules_haskell/assignees{/user}","branches_url":"https://api.github.com/repos/tweag/rules_haskell/branches{/branch}","tags_url":"https://api.github.com/repos/tweag/rules_haskell/tags","blobs_url":"https://api.github.com/repos/tweag/rules_haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweag/rules_haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweag/rules_haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweag/rules_haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweag/rules_haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/tweag/rules_haskell/languages","stargazers_url":"https://api.github.com/repos/tweag/rules_haskell/stargazers","contributors_url":"https://api.github.com/repos/tweag/rules_haskell/contributors","subscribers_url":"https://api.github.com/repos/tweag/rules_haskell/subscribers","subscription_url":"https://api.github.com/repos/tweag/rules_haskell/subscription","commits_url":"https://api.github.com/repos/tweag/rules_haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweag/rules_haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweag/rules_haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweag/rules_haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweag/rules_haskell/contents/{+path}","compare_url":"https://api.github.com/repos/tweag/rules_haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweag/rules_haskell/merges","archive_url":"https://api.github.com/repos/tweag/rules_haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweag/rules_haskell/downloads","issues_url":"https://api.github.com/repos/tweag/rules_haskell/issues{/number}","pulls_url":"https://api.github.com/repos/tweag/rules_haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/tweag/rules_haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/tweag/rules_haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweag/rules_haskell/labels{/name}","releases_url":"https://api.github.com/repos/tweag/rules_haskell/releases{/id}","deployments_url":"https://api.github.com/repos/tweag/rules_haskell/deployments","created_at":"2017-11-06T08:50:01Z","updated_at":"2018-05-18T16:16:43Z","pushed_at":"2018-05-18T21:02:51Z","git_url":"git://github.com/tweag/rules_haskell.git","ssh_url":"git@github.com:tweag/rules_haskell.git","clone_url":"https://github.com/tweag/rules_haskell.git","svn_url":"https://github.com/tweag/rules_haskell","homepage":null,"size":538,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":29,"watchers":59,"default_branch":"master"}},"base":{"label":"tweag:master","ref":"master","sha":"fc0dbb49281a6909c6b333bb6567b8a54a49b94c","user":{"login":"tweag","id":6057932,"avatar_url":"https://avatars3.githubusercontent.com/u/6057932?v=4","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"repo":{"id":109669839,"name":"rules_haskell","full_name":"tweag/rules_haskell","owner":{"login":"tweag","id":6057932,"avatar_url":"https://avatars3.githubusercontent.com/u/6057932?v=4","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tweag/rules_haskell","description":"Haskell rules for Bazel.","fork":false,"url":"https://api.github.com/repos/tweag/rules_haskell","forks_url":"https://api.github.com/repos/tweag/rules_haskell/forks","keys_url":"https://api.github.com/repos/tweag/rules_haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweag/rules_haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweag/rules_haskell/teams","hooks_url":"https://api.github.com/repos/tweag/rules_haskell/hooks","issue_events_url":"https://api.github.com/repos/tweag/rules_haskell/issues/events{/number}","events_url":"https://api.github.com/repos/tweag/rules_haskell/events","assignees_url":"https://api.github.com/repos/tweag/rules_haskell/assignees{/user}","branches_url":"https://api.github.com/repos/tweag/rules_haskell/branches{/branch}","tags_url":"https://api.github.com/repos/tweag/rules_haskell/tags","blobs_url":"https://api.github.com/repos/tweag/rules_haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweag/rules_haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweag/rules_haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweag/rules_haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweag/rules_haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/tweag/rules_haskell/languages","stargazers_url":"https://api.github.com/repos/tweag/rules_haskell/stargazers","contributors_url":"https://api.github.com/repos/tweag/rules_haskell/contributors","subscribers_url":"https://api.github.com/repos/tweag/rules_haskell/subscribers","subscription_url":"https://api.github.com/repos/tweag/rules_haskell/subscription","commits_url":"https://api.github.com/repos/tweag/rules_haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweag/rules_haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweag/rules_haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweag/rules_haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweag/rules_haskell/contents/{+path}","compare_url":"https://api.github.com/repos/tweag/rules_haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweag/rules_haskell/merges","archive_url":"https://api.github.com/repos/tweag/rules_haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweag/rules_haskell/downloads","issues_url":"https://api.github.com/repos/tweag/rules_haskell/issues{/number}","pulls_url":"https://api.github.com/repos/tweag/rules_haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/tweag/rules_haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/tweag/rules_haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweag/rules_haskell/labels{/name}","releases_url":"https://api.github.com/repos/tweag/rules_haskell/releases{/id}","deployments_url":"https://api.github.com/repos/tweag/rules_haskell/deployments","created_at":"2017-11-06T08:50:01Z","updated_at":"2018-05-18T16:16:43Z","pushed_at":"2018-05-18T21:02:51Z","git_url":"git://github.com/tweag/rules_haskell.git","ssh_url":"git@github.com:tweag/rules_haskell.git","clone_url":"https://github.com/tweag/rules_haskell.git","svn_url":"https://github.com/tweag/rules_haskell","homepage":null,"size":538,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":29,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tweag/rules_haskell/pulls/256"},"html":{"href":"https://github.com/tweag/rules_haskell/pull/256"},"issue":{"href":"https://api.github.com/repos/tweag/rules_haskell/issues/256"},"comments":{"href":"https://api.github.com/repos/tweag/rules_haskell/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/tweag/rules_haskell/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/tweag/rules_haskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tweag/rules_haskell/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/tweag/rules_haskell/statuses/e15f4d2f202b266c2a97cba02d8f2ad4aec34ec3"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"judah"}}