{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/pagerinc/minion/pulls/17","id":211238400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjM4NDAw","html_url":"https://github.com/pagerinc/minion/pull/17","diff_url":"https://github.com/pagerinc/minion/pull/17.diff","patch_url":"https://github.com/pagerinc/minion/pull/17.patch","issue_url":"https://api.github.com/repos/pagerinc/minion/issues/17","number":17,"state":"closed","locked":false,"title":"feat: be able to pass rabbit url as an option","user":{"login":"gmauricio","id":1579836,"node_id":"MDQ6VXNlcjE1Nzk4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1579836?v=4","gravatar_id":"","url":"https://api.github.com/users/gmauricio","html_url":"https://github.com/gmauricio","followers_url":"https://api.github.com/users/gmauricio/followers","following_url":"https://api.github.com/users/gmauricio/following{/other_user}","gists_url":"https://api.github.com/users/gmauricio/gists{/gist_id}","starred_url":"https://api.github.com/users/gmauricio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmauricio/subscriptions","organizations_url":"https://api.github.com/users/gmauricio/orgs","repos_url":"https://api.github.com/users/gmauricio/repos","events_url":"https://api.github.com/users/gmauricio/events{/privacy}","received_events_url":"https://api.github.com/users/gmauricio/received_events","type":"User","site_admin":false},"body":"Before this, the rabbitMq connection was created inside of Minion, with no ability to overwrite it, with this changes we enable the ability to pass an exisiting jackrabbit instance in case we want to reuse it with other minions, and the ability if wanted to only provide a rabbit url connection string and let the minion start its own connection.\r\nAn important side effect of this changes is that we start a single connection for every Minion we create if we don't provide the connection. Before, as the jackrabbit instance was created globally, it became shared by default.\r\nIt means that we need to be more careful on how we create Minions.","created_at":"2018-08-27T21:34:53Z","updated_at":"2018-09-12T12:56:23Z","closed_at":"2018-09-12T12:56:22Z","merged_at":"2018-09-12T12:56:22Z","merge_commit_sha":"bf589ae390664cc6c218551c5821d507d73acd39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pagerinc/minion/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pagerinc/minion/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pagerinc/minion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pagerinc/minion/issues/17/comments","statuses_url":"https://api.github.com/repos/pagerinc/minion/statuses/fc9e402c13d30c6c0f8f49ef5d536161e0c89707","head":{"label":"gmauricio:feat-rabbitUrl-option","ref":"feat-rabbitUrl-option","sha":"fc9e402c13d30c6c0f8f49ef5d536161e0c89707","user":{"login":"gmauricio","id":1579836,"node_id":"MDQ6VXNlcjE1Nzk4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1579836?v=4","gravatar_id":"","url":"https://api.github.com/users/gmauricio","html_url":"https://github.com/gmauricio","followers_url":"https://api.github.com/users/gmauricio/followers","following_url":"https://api.github.com/users/gmauricio/following{/other_user}","gists_url":"https://api.github.com/users/gmauricio/gists{/gist_id}","starred_url":"https://api.github.com/users/gmauricio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmauricio/subscriptions","organizations_url":"https://api.github.com/users/gmauricio/orgs","repos_url":"https://api.github.com/users/gmauricio/repos","events_url":"https://api.github.com/users/gmauricio/events{/privacy}","received_events_url":"https://api.github.com/users/gmauricio/received_events","type":"User","site_admin":false},"repo":{"id":100748418,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NDg0MTg=","name":"minion","full_name":"gmauricio/minion","owner":{"login":"gmauricio","id":1579836,"node_id":"MDQ6VXNlcjE1Nzk4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1579836?v=4","gravatar_id":"","url":"https://api.github.com/users/gmauricio","html_url":"https://github.com/gmauricio","followers_url":"https://api.github.com/users/gmauricio/followers","following_url":"https://api.github.com/users/gmauricio/following{/other_user}","gists_url":"https://api.github.com/users/gmauricio/gists{/gist_id}","starred_url":"https://api.github.com/users/gmauricio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmauricio/subscriptions","organizations_url":"https://api.github.com/users/gmauricio/orgs","repos_url":"https://api.github.com/users/gmauricio/repos","events_url":"https://api.github.com/users/gmauricio/events{/privacy}","received_events_url":"https://api.github.com/users/gmauricio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmauricio/minion","description":"Microservice Framework for RabbitMQ Workers","fork":true,"url":"https://api.github.com/repos/gmauricio/minion","forks_url":"https://api.github.com/repos/gmauricio/minion/forks","keys_url":"https://api.github.com/repos/gmauricio/minion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmauricio/minion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmauricio/minion/teams","hooks_url":"https://api.github.com/repos/gmauricio/minion/hooks","issue_events_url":"https://api.github.com/repos/gmauricio/minion/issues/events{/number}","events_url":"https://api.github.com/repos/gmauricio/minion/events","assignees_url":"https://api.github.com/repos/gmauricio/minion/assignees{/user}","branches_url":"https://api.github.com/repos/gmauricio/minion/branches{/branch}","tags_url":"https://api.github.com/repos/gmauricio/minion/tags","blobs_url":"https://api.github.com/repos/gmauricio/minion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmauricio/minion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmauricio/minion/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmauricio/minion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmauricio/minion/statuses/{sha}","languages_url":"https://api.github.com/repos/gmauricio/minion/languages","stargazers_url":"https://api.github.com/repos/gmauricio/minion/stargazers","contributors_url":"https://api.github.com/repos/gmauricio/minion/contributors","subscribers_url":"https://api.github.com/repos/gmauricio/minion/subscribers","subscription_url":"https://api.github.com/repos/gmauricio/minion/subscription","commits_url":"https://api.github.com/repos/gmauricio/minion/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmauricio/minion/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmauricio/minion/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmauricio/minion/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmauricio/minion/contents/{+path}","compare_url":"https://api.github.com/repos/gmauricio/minion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmauricio/minion/merges","archive_url":"https://api.github.com/repos/gmauricio/minion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmauricio/minion/downloads","issues_url":"https://api.github.com/repos/gmauricio/minion/issues{/number}","pulls_url":"https://api.github.com/repos/gmauricio/minion/pulls{/number}","milestones_url":"https://api.github.com/repos/gmauricio/minion/milestones{/number}","notifications_url":"https://api.github.com/repos/gmauricio/minion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmauricio/minion/labels{/name}","releases_url":"https://api.github.com/repos/gmauricio/minion/releases{/id}","deployments_url":"https://api.github.com/repos/gmauricio/minion/deployments","created_at":"2017-08-18T20:37:13Z","updated_at":"2018-09-11T20:10:31Z","pushed_at":"2018-09-11T21:34:39Z","git_url":"git://github.com/gmauricio/minion.git","ssh_url":"git@github.com:gmauricio/minion.git","clone_url":"https://github.com/gmauricio/minion.git","svn_url":"https://github.com/gmauricio/minion","homepage":null,"size":157,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pagerinc:master","ref":"master","sha":"493c712deb124afc95a7c3caeb2d4f4c238a036e","user":{"login":"pagerinc","id":4589140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODkxNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4589140?v=4","gravatar_id":"","url":"https://api.github.com/users/pagerinc","html_url":"https://github.com/pagerinc","followers_url":"https://api.github.com/users/pagerinc/followers","following_url":"https://api.github.com/users/pagerinc/following{/other_user}","gists_url":"https://api.github.com/users/pagerinc/gists{/gist_id}","starred_url":"https://api.github.com/users/pagerinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagerinc/subscriptions","organizations_url":"https://api.github.com/users/pagerinc/orgs","repos_url":"https://api.github.com/users/pagerinc/repos","events_url":"https://api.github.com/users/pagerinc/events{/privacy}","received_events_url":"https://api.github.com/users/pagerinc/received_events","type":"Organization","site_admin":false},"repo":{"id":100746773,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NDY3NzM=","name":"minion","full_name":"pagerinc/minion","owner":{"login":"pagerinc","id":4589140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODkxNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4589140?v=4","gravatar_id":"","url":"https://api.github.com/users/pagerinc","html_url":"https://github.com/pagerinc","followers_url":"https://api.github.com/users/pagerinc/followers","following_url":"https://api.github.com/users/pagerinc/following{/other_user}","gists_url":"https://api.github.com/users/pagerinc/gists{/gist_id}","starred_url":"https://api.github.com/users/pagerinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagerinc/subscriptions","organizations_url":"https://api.github.com/users/pagerinc/orgs","repos_url":"https://api.github.com/users/pagerinc/repos","events_url":"https://api.github.com/users/pagerinc/events{/privacy}","received_events_url":"https://api.github.com/users/pagerinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagerinc/minion","description":"Microservice Framework for RabbitMQ Workers","fork":false,"url":"https://api.github.com/repos/pagerinc/minion","forks_url":"https://api.github.com/repos/pagerinc/minion/forks","keys_url":"https://api.github.com/repos/pagerinc/minion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagerinc/minion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagerinc/minion/teams","hooks_url":"https://api.github.com/repos/pagerinc/minion/hooks","issue_events_url":"https://api.github.com/repos/pagerinc/minion/issues/events{/number}","events_url":"https://api.github.com/repos/pagerinc/minion/events","assignees_url":"https://api.github.com/repos/pagerinc/minion/assignees{/user}","branches_url":"https://api.github.com/repos/pagerinc/minion/branches{/branch}","tags_url":"https://api.github.com/repos/pagerinc/minion/tags","blobs_url":"https://api.github.com/repos/pagerinc/minion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagerinc/minion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagerinc/minion/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagerinc/minion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagerinc/minion/statuses/{sha}","languages_url":"https://api.github.com/repos/pagerinc/minion/languages","stargazers_url":"https://api.github.com/repos/pagerinc/minion/stargazers","contributors_url":"https://api.github.com/repos/pagerinc/minion/contributors","subscribers_url":"https://api.github.com/repos/pagerinc/minion/subscribers","subscription_url":"https://api.github.com/repos/pagerinc/minion/subscription","commits_url":"https://api.github.com/repos/pagerinc/minion/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagerinc/minion/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagerinc/minion/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagerinc/minion/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagerinc/minion/contents/{+path}","compare_url":"https://api.github.com/repos/pagerinc/minion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagerinc/minion/merges","archive_url":"https://api.github.com/repos/pagerinc/minion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagerinc/minion/downloads","issues_url":"https://api.github.com/repos/pagerinc/minion/issues{/number}","pulls_url":"https://api.github.com/repos/pagerinc/minion/pulls{/number}","milestones_url":"https://api.github.com/repos/pagerinc/minion/milestones{/number}","notifications_url":"https://api.github.com/repos/pagerinc/minion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagerinc/minion/labels{/name}","releases_url":"https://api.github.com/repos/pagerinc/minion/releases{/id}","deployments_url":"https://api.github.com/repos/pagerinc/minion/deployments","created_at":"2017-08-18T20:12:22Z","updated_at":"2018-09-10T16:52:51Z","pushed_at":"2018-09-12T12:56:22Z","git_url":"git://github.com/pagerinc/minion.git","ssh_url":"git@github.com:pagerinc/minion.git","clone_url":"https://github.com/pagerinc/minion.git","svn_url":"https://github.com/pagerinc/minion","homepage":null,"size":160,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pagerinc/minion/pulls/17"},"html":{"href":"https://github.com/pagerinc/minion/pull/17"},"issue":{"href":"https://api.github.com/repos/pagerinc/minion/issues/17"},"comments":{"href":"https://api.github.com/repos/pagerinc/minion/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pagerinc/minion/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pagerinc/minion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pagerinc/minion/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pagerinc/minion/statuses/fc9e402c13d30c6c0f8f49ef5d536161e0c89707"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gmauricio","id":1579836,"node_id":"MDQ6VXNlcjE1Nzk4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1579836?v=4","gravatar_id":"","url":"https://api.github.com/users/gmauricio","html_url":"https://github.com/gmauricio","followers_url":"https://api.github.com/users/gmauricio/followers","following_url":"https://api.github.com/users/gmauricio/following{/other_user}","gists_url":"https://api.github.com/users/gmauricio/gists{/gist_id}","starred_url":"https://api.github.com/users/gmauricio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmauricio/subscriptions","organizations_url":"https://api.github.com/users/gmauricio/orgs","repos_url":"https://api.github.com/users/gmauricio/repos","events_url":"https://api.github.com/users/gmauricio/events{/privacy}","received_events_url":"https://api.github.com/users/gmauricio/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"gmauricio"}}