{"action":"created","issue":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/1300","repository_url":"https://api.github.com/repos/apache/bookkeeper","labels_url":"https://api.github.com/repos/apache/bookkeeper/issues/1300/labels{/name}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1300/comments","events_url":"https://api.github.com/repos/apache/bookkeeper/issues/1300/events","html_url":"https://github.com/apache/bookkeeper/pull/1300","id":309235275,"number":1300,"title":"[dlog] Fix TestZKLogStreamMetadataStore","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"labels":[{"id":822862030,"url":"https://api.github.com/repos/apache/bookkeeper/labels/area/dlog","name":"area/dlog","color":"f9d0c4","default":false},{"id":636302110,"url":"https://api.github.com/repos/apache/bookkeeper/labels/area/tests","name":"area/tests","color":"f9d0c4","default":false},{"id":636301000,"url":"https://api.github.com/repos/apache/bookkeeper/labels/type/bug","name":"type/bug","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"assignees":[{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-28T06:21:02Z","updated_at":"2018-03-28T23:17:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1300","html_url":"https://github.com/apache/bookkeeper/pull/1300","diff_url":"https://github.com/apache/bookkeeper/pull/1300.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1300.patch"},"body":"\r\n\r\nDescriptions of the changes in this PR:\r\n\r\n*Problem*\r\n\r\nAll test cases in `TestZKLogStreamMetadataStore` share same zookeeper cluster. so if the tests\r\nrun before `testGetMissingPathsRecursive` runs, they might create the missing path components\r\nfor `testGetMissingPathsRecursive`, which will fail the assertion in `testGetMissingPathsRecursive`\r\n\r\n*Solution*\r\n\r\nAdd unique suffix to \"/path\" for each test case to avoid conflicts\r\n\r\n\r\n> ---\r\n> Be sure to do all of the following to help us incorporate your contribution\r\n> quickly and easily:\r\n>\r\n> If this PR is a BookKeeper Proposal (BP):\r\n>\r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<BP-#>: Description of bookkeeper proposal`\r\n>     `e.g. BP-1: 64 bits ledger is support`\r\n> - [ ] Attach the master issue link in the description of this PR.\r\n> - [ ] Attach the google doc link if the BP is written in Google Doc.\r\n>\r\n> Otherwise:\r\n> \r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<Issue #>: Description of pull request`\r\n>     `e.g. Issue 123: Description ...`\r\n> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.\r\n> - [ ] Replace `<Issue #>` in the title with the actual Issue number.\r\n> \r\n> ---\r\n"},"comment":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/comments/377069168","html_url":"https://github.com/apache/bookkeeper/pull/1300#issuecomment-377069168","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1300","id":377069168,"user":{"login":"philipsu522","id":3821073,"avatar_url":"https://avatars2.githubusercontent.com/u/3821073?v=4","gravatar_id":"","url":"https://api.github.com/users/philipsu522","html_url":"https://github.com/philipsu522","followers_url":"https://api.github.com/users/philipsu522/followers","following_url":"https://api.github.com/users/philipsu522/following{/other_user}","gists_url":"https://api.github.com/users/philipsu522/gists{/gist_id}","starred_url":"https://api.github.com/users/philipsu522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipsu522/subscriptions","organizations_url":"https://api.github.com/users/philipsu522/orgs","repos_url":"https://api.github.com/users/philipsu522/repos","events_url":"https://api.github.com/users/philipsu522/events{/privacy}","received_events_url":"https://api.github.com/users/philipsu522/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T23:17:44Z","updated_at":"2018-03-28T23:17:44Z","author_association":"NONE","body":"LGTM"}}
{"actor":{"display_login":"philipsu522"}}