{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/198465490","pull_request_review_id":132398917,"id":198465490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ2NTQ5MA==","diff_hunk":"@@ -22,15 +22,13 @@\n         \"tcp-echo-prefix\" : {\n             \"help\" : \"Some servers send a prefix before echoed message\",\n             \"value\" : null\n-        },\n-        \"sim-blockdevice\": {\n-            \"help\": \"Simulated block device, requires sufficient heap\",\n-            \"macro_name\": \"MBED_TEST_SIM_BLOCKDEVICE\",\n-            \"value\": \"HeapBlockDevice\"\n         }\n     },\n     \"target_overrides\": {\n         \"*\": {\n+            \"nsapi.default-wifi-ssid\": WIFI_SSID,\n+            \"nsapi.default-wifi-password\": WIFI_PASSWORD,\n+            \"nsapi.default-wifi-security\": WIFI_SECURITY,","path":"tools/test_configs/DefaultInterface.json","position":33,"original_position":33,"commit_id":"cf8ad256af88d5c55118cf55c2931cbe7c12b844","original_commit_id":"cf8ad256af88d5c55118cf55c2931cbe7c12b844","user":{"login":"SeppoTakalo","id":3104794,"node_id":"MDQ6VXNlcjMxMDQ3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3104794?v=4","gravatar_id":"","url":"https://api.github.com/users/SeppoTakalo","html_url":"https://github.com/SeppoTakalo","followers_url":"https://api.github.com/users/SeppoTakalo/followers","following_url":"https://api.github.com/users/SeppoTakalo/following{/other_user}","gists_url":"https://api.github.com/users/SeppoTakalo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeppoTakalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeppoTakalo/subscriptions","organizations_url":"https://api.github.com/users/SeppoTakalo/orgs","repos_url":"https://api.github.com/users/SeppoTakalo/repos","events_url":"https://api.github.com/users/SeppoTakalo/events{/privacy}","received_events_url":"https://api.github.com/users/SeppoTakalo/received_events","type":"User","site_admin":false},"body":"Is this missing \" around the macro names?","created_at":"2018-06-27T11:55:05Z","updated_at":"2018-06-27T11:55:05Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/7332#discussion_r198465490","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/198465490"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/7332#discussion_r198465490"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332","id":197393695,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzkzNjk1","html_url":"https://github.com/ARMmbed/mbed-os/pull/7332","diff_url":"https://github.com/ARMmbed/mbed-os/pull/7332.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/7332.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7332","number":7332,"state":"open","locked":false,"title":"Test configs: start using network factories","user":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nReduce amount of special case code by using network factories for built-in-to-target network interfaces.\r\n\r\n### Pull request type\r\n\r\n    [ ] Fix\r\n    [X] Refactor\r\n    [ ] New target\r\n    [ ] Feature\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-06-26T11:44:18Z","updated_at":"2018-06-27T11:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51da4eb32bd136596b885a534d9259f1ff98e67d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7332/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/cf8ad256af88d5c55118cf55c2931cbe7c12b844","head":{"label":"kjbracey-arm:test-config","ref":"test-config","sha":"cf8ad256af88d5c55118cf55c2931cbe7c12b844","user":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"repo":{"id":60763107,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc2MzEwNw==","name":"mbed-os","full_name":"kjbracey-arm/mbed-os","owner":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjbracey-arm/mbed-os","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/kjbracey-arm/mbed-os","forks_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/forks","keys_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/teams","hooks_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/events","assignees_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/tags","blobs_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/languages","stargazers_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/subscription","commits_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/merges","archive_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/downloads","issues_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/kjbracey-arm/mbed-os/deployments","created_at":"2016-06-09T09:23:49Z","updated_at":"2016-10-31T08:09:29Z","pushed_at":"2018-06-27T08:28:30Z","git_url":"git://github.com/kjbracey-arm/mbed-os.git","ssh_url":"git@github.com:kjbracey-arm/mbed-os.git","clone_url":"https://github.com/kjbracey-arm/mbed-os.git","svn_url":"https://github.com/kjbracey-arm/mbed-os","homepage":"","size":214626,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"65abff9ce874ef4b9530d63fcab45215597617e0","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-06-27T01:45:11Z","pushed_at":"2018-06-27T10:55:58Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":216978,"stargazers_count":1710,"watchers_count":1710,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1492,"mirror_url":null,"archived":false,"open_issues_count":411,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1492,"open_issues":411,"watchers":1710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/7332"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7332"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7332/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7332/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/cf8ad256af88d5c55118cf55c2931cbe7c12b844"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SeppoTakalo"}}