{"action":"created","issue":{"url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/107","repository_url":"https://api.github.com/repos/sclorg/rpm-list-builder","labels_url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/107/comments","events_url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/107/events","html_url":"https://github.com/sclorg/rpm-list-builder/pull/107","id":314409058,"number":107,"title":"Fix style check issue for ShellCheck.","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars2.githubusercontent.com/u/121989?v=4","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-15T11:54:30Z","updated_at":"2018-04-18T08:46:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/sclorg/rpm-list-builder/pulls/107","html_url":"https://github.com/sclorg/rpm-list-builder/pull/107","diff_url":"https://github.com/sclorg/rpm-list-builder/pull/107.diff","patch_url":"https://github.com/sclorg/rpm-list-builder/pull/107.patch"},"body":"This fixes https://github.com/sclorg/rpm-list-builder/issues/106 .\r\n\r\nThe reason is ShellCheck changed the definition of the check?\r\nIn my memory, `disable=SC2039` was to restrict the use of `pushd` and `popd`.\r\nAnyway, I fixed, and tested the outdated `tests/integration/run.sh` script too.\r\n\r\nOne test case was failed because of the error of \"fedpkg srpm\" for rh-ror50.\r\nMaybe this test script does not follow the feature to add `fedpkg`.\r\n\r\n```\r\n$ python3 -m venv ./venv\r\n\r\n$ source venv/bin/activate\r\n\r\n(venv) $ pip install -e .\r\n\r\n(venv) $ which rpmlb\r\n~/git/sclorg/rpm-list-builder/venv/bin/rpmlb\r\n\r\n(venv) $ sh tests/integration/run.sh \r\n== TEST: download_only_test ==\r\n  > [OK]\r\n\r\n== TEST: download_from_local_and_build_with_dummy_test ==\r\n  > [OK]\r\n\r\n== TEST: download_by_rhpkg_and_build_with_dummy_test ==\r\n  > [OK]\r\n\r\n== TEST: download_with_custom_and_build_with_dummy_test ==\r\n  > [OK]\r\n\r\n== TEST: build_only_verbose_test ==\r\n  > [OK]\r\n\r\n== TEST: build_only_with_mock_test ==\r\n  > [FAILURE]\r\n\r\n== TEST: build_only_with_custom_echo_test ==\r\n  > [OK]\r\n\r\n== TEST: build_only_with_custom_mock_test ==\r\n  > [OK]\r\n\r\n== TEST: build_only_resume_test ==\r\n  > [OK]\r\n\r\n== TEST: download_and_build_with_custom_echo_test ==\r\n  > [OK]\r\n\r\n== TEST: download_and_build_with_custom_mock_test ==\r\n  > [OK]\r\n\r\n\r\nreal\t7m29.410s\r\nuser\t2m50.111s\r\nsys\t1m22.038s\r\nexist status: 1\r\n\r\n$ vi integration.log\r\n...\r\n2018-04-15 13:38:10,623 ERROR    rpmlb.utils                CMD: [fedpkg srpm] failed at [/home/jaruga/git/sclorg/rpm-list-builder/tmp/work_directory/1/rh-ror50]\r\n...\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/comments/382312572","html_url":"https://github.com/sclorg/rpm-list-builder/pull/107#issuecomment-382312572","issue_url":"https://api.github.com/repos/sclorg/rpm-list-builder/issues/107","id":382312572,"user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars2.githubusercontent.com/u/121989?v=4","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T08:46:36Z","updated_at":"2018-04-18T08:46:36Z","author_association":"COLLABORATOR","body":"I removed `ShellCheck` and the related code. Could you check and merge?\r\nThanks.\r\n"}}
{"actor":{"display_login":"junaruga"}}