{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/205821508","pull_request_review_id":141172067,"id":205821508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTgyMTUwOA==","diff_hunk":"@@ -95,3 +95,4 @@ l_crio_var_sock: \"/var/run/crio/crio.sock\"\n l_insecure_crio_registries: \"{{ '\\\"{}\\\"'.format('\\\", \\\"'.join(l2_docker_insecure_registries)) }}\"\n l_crio_registries: \"{{ l2_docker_additional_registries + ['docker.io'] }}\"\n l_additional_crio_registries: \"{{ '\\\"{}\\\"'.format('\\\", \\\"'.join(l_crio_registries)) }}\"\n+l_blocked_crio_registries: \"{{ '\\\"{}\\\"'.format('\\\", \\\"'.join(l2_docker_blocked_registries)) }}\"","path":"roles/container_runtime/defaults/main.yml","position":null,"original_position":4,"commit_id":"2c91cf62d2c622da286a861bc954063b46d80ae5","original_commit_id":"2177184ea37aa105410c9fc2b300256affea63cb","user":{"login":"umohnani8","id":29377163,"node_id":"MDQ6VXNlcjI5Mzc3MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-07-27T15:58:39Z","updated_at":"2018-07-27T15:58:39Z","html_url":"https://github.com/openshift/openshift-ansible/pull/9307#discussion_r205821508","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/205821508"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9307#discussion_r205821508"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307"}},"in_reply_to_id":205817311},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307","id":203322981,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzIyOTgx","html_url":"https://github.com/openshift/openshift-ansible/pull/9307","diff_url":"https://github.com/openshift/openshift-ansible/pull/9307.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/9307.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9307","number":9307,"state":"open","locked":false,"title":"Update crio.conf.j2 template for registries","user":{"login":"umohnani8","id":29377163,"node_id":"MDQ6VXNlcjI5Mzc3MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"body":"CRI-O 1.11 and above picks up the default registries from\r\n/etc/containers/registries.conf. Updated the crio.conf.j2\r\ntemplate to reflect that.\r\nA registries.conf already exists in roles/container-runtimes/templates\r\nthat ends up in /etc/containers/registries.conf when the playbook is ran.\r\n\r\nSigned-off-by: umohnani8 <umohnani@redhat.com>","created_at":"2018-07-23T19:43:36Z","updated_at":"2018-07-27T15:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e3851c00d052de3d65301d309ce8d02854a443","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vrutkovs","id":114501,"node_id":"MDQ6VXNlcjExNDUwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/114501?v=4","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":681631798,"node_id":"MDU6TGFiZWw2ODE2MzE3OTg=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/9307/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/2c91cf62d2c622da286a861bc954063b46d80ae5","head":{"label":"umohnani8:registries","ref":"registries","sha":"2c91cf62d2c622da286a861bc954063b46d80ae5","user":{"login":"umohnani8","id":29377163,"node_id":"MDQ6VXNlcjI5Mzc3MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"repo":{"id":132033272,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMzMyNzI=","name":"openshift-ansible","full_name":"umohnani8/openshift-ansible","owner":{"login":"umohnani8","id":29377163,"node_id":"MDQ6VXNlcjI5Mzc3MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umohnani8/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":true,"url":"https://api.github.com/repos/umohnani8/openshift-ansible","forks_url":"https://api.github.com/repos/umohnani8/openshift-ansible/forks","keys_url":"https://api.github.com/repos/umohnani8/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umohnani8/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umohnani8/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/umohnani8/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/umohnani8/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/umohnani8/openshift-ansible/events","assignees_url":"https://api.github.com/repos/umohnani8/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/umohnani8/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/umohnani8/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/umohnani8/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umohnani8/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umohnani8/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/umohnani8/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umohnani8/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/umohnani8/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/umohnani8/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/umohnani8/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/umohnani8/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/umohnani8/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/umohnani8/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/umohnani8/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/umohnani8/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/umohnani8/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/umohnani8/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/umohnani8/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umohnani8/openshift-ansible/merges","archive_url":"https://api.github.com/repos/umohnani8/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umohnani8/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/umohnani8/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/umohnani8/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/umohnani8/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/umohnani8/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umohnani8/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/umohnani8/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/umohnani8/openshift-ansible/deployments","created_at":"2018-05-03T18:14:40Z","updated_at":"2018-05-03T18:14:48Z","pushed_at":"2018-07-27T15:57:21Z","git_url":"git://github.com/umohnani8/openshift-ansible.git","ssh_url":"git@github.com:umohnani8/openshift-ansible.git","clone_url":"https://github.com/umohnani8/openshift-ansible.git","svn_url":"https://github.com/umohnani8/openshift-ansible","homepage":"https://install.openshift.com","size":30263,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"91bb588d03bb8c6ce990a9d1b9779423fad964b8","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwOTE5OQ==","name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2018-07-27T15:46:55Z","pushed_at":"2018-07-27T15:57:23Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":30830,"stargazers_count":1058,"watchers_count":1058,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1504,"mirror_url":null,"archived":false,"open_issues_count":1036,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1504,"open_issues":1036,"watchers":1058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/9307"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9307"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/9307/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/9307/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/2c91cf62d2c622da286a861bc954063b46d80ae5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"umohnani8"}}