{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/234168091","pull_request_review_id":175754139,"id":234168091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE2ODA5MQ==","diff_hunk":"@@ -185,12 +185,12 @@ TEST_F(TestAT_CellularNetwork, test_AT_CellularNetwork_get_registration_params)\n     reg_params._periodic_tau = 3;\n \n     EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == cn.get_registration_params(CellularNetwork::C_EREG, reg_params));\n-    EXPECT_TRUE(reg_params._status == CellularNetwork::StatusNotAvailable);\n+    EXPECT_TRUE(reg_params._status == CellularNetwork::NotRegistered);","path":"UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/at_cellularnetworktest.cpp","position":5,"original_position":5,"commit_id":"edd183f7ca9b54a340105512cd2b9eaf5fc0d663","original_commit_id":"edd183f7ca9b54a340105512cd2b9eaf5fc0d663","user":{"login":"0xc0170","id":2963726,"node_id":"MDQ6VXNlcjI5NjM3MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"is this bugfix ? I dont see this related to the debug prints update","created_at":"2018-11-16T11:05:33Z","updated_at":"2018-11-16T11:06:53Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8767#discussion_r234168091","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/234168091"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8767#discussion_r234168091"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767","id":231439950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDM5OTUw","html_url":"https://github.com/ARMmbed/mbed-os/pull/8767","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8767.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8767.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8767","number":8767,"state":"open","locked":false,"title":"Cellular: Updated cellular debug prints","user":{"login":"AriParkkila","id":26764770,"node_id":"MDQ6VXNlcjI2NzY0Nzcw","avatar_url":"https://avatars3.githubusercontent.com/u/26764770?v=4","gravatar_id":"","url":"https://api.github.com/users/AriParkkila","html_url":"https://github.com/AriParkkila","followers_url":"https://api.github.com/users/AriParkkila/followers","following_url":"https://api.github.com/users/AriParkkila/following{/other_user}","gists_url":"https://api.github.com/users/AriParkkila/gists{/gist_id}","starred_url":"https://api.github.com/users/AriParkkila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriParkkila/subscriptions","organizations_url":"https://api.github.com/users/AriParkkila/orgs","repos_url":"https://api.github.com/users/AriParkkila/repos","events_url":"https://api.github.com/users/AriParkkila/events{/privacy}","received_events_url":"https://api.github.com/users/AriParkkila/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nCellular traces need to be improved:\r\n- Removed unnecessary prints.\r\n- Tracing more in DEBUG level.\r\n- Read/write bytes not printed on big packets.\r\n- Signal quality (RSSI) traced to log network problems.\r\n- Dismissed AT data is traced.\r\n- Modem type and firmware version are traced.\r\n\r\nNo functional changes.\r\n\r\n### Pull request type\r\n\r\n    [ ] Fix\r\n    [x] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-11-16T07:33:41Z","updated_at":"2018-11-16T11:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42753573ed4ff15d737bc91fc0bf1d5dc3cc54ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8767/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/edd183f7ca9b54a340105512cd2b9eaf5fc0d663","head":{"label":"AriParkkila:cell-trace","ref":"cell-trace","sha":"edd183f7ca9b54a340105512cd2b9eaf5fc0d663","user":{"login":"AriParkkila","id":26764770,"node_id":"MDQ6VXNlcjI2NzY0Nzcw","avatar_url":"https://avatars3.githubusercontent.com/u/26764770?v=4","gravatar_id":"","url":"https://api.github.com/users/AriParkkila","html_url":"https://github.com/AriParkkila","followers_url":"https://api.github.com/users/AriParkkila/followers","following_url":"https://api.github.com/users/AriParkkila/following{/other_user}","gists_url":"https://api.github.com/users/AriParkkila/gists{/gist_id}","starred_url":"https://api.github.com/users/AriParkkila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriParkkila/subscriptions","organizations_url":"https://api.github.com/users/AriParkkila/orgs","repos_url":"https://api.github.com/users/AriParkkila/repos","events_url":"https://api.github.com/users/AriParkkila/events{/privacy}","received_events_url":"https://api.github.com/users/AriParkkila/received_events","type":"User","site_admin":false},"repo":{"id":94853202,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg1MzIwMg==","name":"mbed-os","full_name":"AriParkkila/mbed-os","private":false,"owner":{"login":"AriParkkila","id":26764770,"node_id":"MDQ6VXNlcjI2NzY0Nzcw","avatar_url":"https://avatars3.githubusercontent.com/u/26764770?v=4","gravatar_id":"","url":"https://api.github.com/users/AriParkkila","html_url":"https://github.com/AriParkkila","followers_url":"https://api.github.com/users/AriParkkila/followers","following_url":"https://api.github.com/users/AriParkkila/following{/other_user}","gists_url":"https://api.github.com/users/AriParkkila/gists{/gist_id}","starred_url":"https://api.github.com/users/AriParkkila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriParkkila/subscriptions","organizations_url":"https://api.github.com/users/AriParkkila/orgs","repos_url":"https://api.github.com/users/AriParkkila/repos","events_url":"https://api.github.com/users/AriParkkila/events{/privacy}","received_events_url":"https://api.github.com/users/AriParkkila/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AriParkkila/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/AriParkkila/mbed-os","forks_url":"https://api.github.com/repos/AriParkkila/mbed-os/forks","keys_url":"https://api.github.com/repos/AriParkkila/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AriParkkila/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AriParkkila/mbed-os/teams","hooks_url":"https://api.github.com/repos/AriParkkila/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/AriParkkila/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/AriParkkila/mbed-os/events","assignees_url":"https://api.github.com/repos/AriParkkila/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/AriParkkila/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/AriParkkila/mbed-os/tags","blobs_url":"https://api.github.com/repos/AriParkkila/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AriParkkila/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AriParkkila/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/AriParkkila/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AriParkkila/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/AriParkkila/mbed-os/languages","stargazers_url":"https://api.github.com/repos/AriParkkila/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/AriParkkila/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/AriParkkila/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/AriParkkila/mbed-os/subscription","commits_url":"https://api.github.com/repos/AriParkkila/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/AriParkkila/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/AriParkkila/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/AriParkkila/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/AriParkkila/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/AriParkkila/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AriParkkila/mbed-os/merges","archive_url":"https://api.github.com/repos/AriParkkila/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AriParkkila/mbed-os/downloads","issues_url":"https://api.github.com/repos/AriParkkila/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/AriParkkila/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/AriParkkila/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/AriParkkila/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AriParkkila/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/AriParkkila/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/AriParkkila/mbed-os/deployments","created_at":"2017-06-20T05:30:58Z","updated_at":"2018-11-12T07:35:07Z","pushed_at":"2018-11-16T10:08:56Z","git_url":"git://github.com/AriParkkila/mbed-os.git","ssh_url":"git@github.com:AriParkkila/mbed-os.git","clone_url":"https://github.com/AriParkkila/mbed-os.git","svn_url":"https://github.com/AriParkkila/mbed-os","homepage":"https://mbed.com","size":236066,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"8a2044b5fc57028b0a8415a35a94ca35dcb6188f","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-11-16T09:16:22Z","pushed_at":"2018-11-16T10:31:09Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":238823,"stargazers_count":2055,"watchers_count":2055,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1673,"mirror_url":null,"archived":false,"open_issues_count":411,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1673,"open_issues":411,"watchers":2055,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8767"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8767"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8767/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8767/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/edd183f7ca9b54a340105512cd2b9eaf5fc0d663"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"0xc0170"}}