{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/24631","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/24631/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/24631/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/24631/events","html_url":"https://github.com/Automattic/wp-calypso/pull/24631","id":319638665,"number":24631,"title":"State: Use getHttpData() for geolocation data","user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars3.githubusercontent.com/u/5431237?v=4","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"labels":[{"id":285009988,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"c5def5","default":false},{"id":360006704,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/State","name":"State","color":"bfdadc","default":false},{"id":565369826,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Blocked%20/%20Hold","name":"[Status] Blocked / Hold","color":"dedede","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-02T17:12:27Z","updated_at":"2018-05-04T09:31:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/24631","html_url":"https://github.com/Automattic/wp-calypso/pull/24631","diff_url":"https://github.com/Automattic/wp-calypso/pull/24631.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/24631.patch"},"body":"> Depends on #24656 before merging!\r\n\r\nIn #22549 we added the `getHttpData()` abstraction\r\nfor simple network data needs.\r\n\r\nIn this patch we're moving the `geo` state subtree over to this\r\nnew abstraction and removing the old code it previously required.\r\n\r\nThis approach is build on the data-layer ideas and extends it\r\nto store data outside of Redux.\r\n\r\nThis is the first PR to build on `getHttpData()` and is being used\r\nto explore the new API so that we can continue to remove code\r\nfrom Calypso related to simple data needs.\r\n\r\n**Testing**\r\n\r\nThe geolocation code was only being used by the language picker\r\nand the `getCurrentUserPaymentMethods()` selector. I have tested\r\nthe language picker when the `/geo` endpoint returns `GB` and I\r\nwould appreciate it if some others in different regions could test\r\nthat as well. The same goes for the payment methods. We want\r\ngeographically diverse tests to confirm that the currencies we are\r\noffered are ones we want."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/386549805","html_url":"https://github.com/Automattic/wp-calypso/pull/24631#issuecomment-386549805","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/24631","id":386549805,"user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars3.githubusercontent.com/u/5431237?v=4","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T09:31:23Z","updated_at":"2018-05-04T09:31:23Z","author_association":"CONTRIBUTOR","body":"> The e2e tests are failing on this\r\n\r\nThanks @alisterscott! This branch depends on #24656 before it can merge (see the description) and I am pretty sure that error is a result of the required changes not being in **master** yet. I've added the `Blocked/Hold` label to try and make this clearer."}}
{"actor":{"display_login":"dmsnell"}}