{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/201060643","pull_request_review_id":135359214,"id":201060643,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA2MDY0Mw==","diff_hunk":"@@ -54,7 +53,7 @@\n public class MapWithOrdinal<K, V> implements Map<K, V> {\n   private final static Logger logger = LoggerFactory.getLogger(MapWithOrdinal.class);\n \n-  private final Map<K, Entry<Integer, V>> primary = Maps.newLinkedHashMap();\n+  private final Map<K, Entry<Integer, V>> primary = new LinkedHashMap<>();\n   private final IntObjectHashMap<V> secondary = new IntObjectHashMap<>();\n \n   private final Map<K, V> delegate = new Map<K, V>() {","path":"common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java","position":32,"original_position":32,"commit_id":"74794cee67a03b190b538d4032bc90e40e78541f","original_commit_id":"74794cee67a03b190b538d4032bc90e40e78541f","user":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"body":"OK, I have removed all these changes and will open a separate PR with them. So now this PR contains only changes required for compiling the code.","created_at":"2018-07-09T16:11:30Z","updated_at":"2018-07-09T16:15:20Z","html_url":"https://github.com/apache/drill/pull/1264#discussion_r201060643","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/1264","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/201060643"},"html":{"href":"https://github.com/apache/drill/pull/1264#discussion_r201060643"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/1264"}},"in_reply_to_id":200172239},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/1264","id":188458598,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NDU4NTk4","html_url":"https://github.com/apache/drill/pull/1264","diff_url":"https://github.com/apache/drill/pull/1264.diff","patch_url":"https://github.com/apache/drill/pull/1264.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/1264","number":1264,"state":"open","locked":false,"title":" DRILL-6422: Update guava to 23.0 and shade it","user":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"body":"Description of made changes:\r\n- Fixed all compilation errors after updating guava version;\r\n- Removed usage of some deprecated API;\r\n- Shaded guava version and added dependencies to the shaded jar;\r\n- To avoid bug with highlighting in IDE, unpacked shaded guava sources to the target source directory;\r\n- Increased size for JDBC driver to 38000000 and 36000000 since both unshaded and shaded versions of guava should be included\r\n- Replaced all guava imports with shaded ones and banned imports to the unshaded classes\r\n- Replaced some guava methods for collections creating by constructors according to the recommendations in it's javadocs\r\n- Replaced usage of some guava interfaces (Function, Predicate etc.) and methods (Sets.filter(), Iterables.tryFind, transform etc.) by java ones\r\n- Added methods to convert shaded ImmutableList to unshaded one for the cases when another library has in its API ImmutableList.","created_at":"2018-05-16T14:46:59Z","updated_at":"2018-07-09T16:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a06b6da4fe9a4c6b37186cf9610d8b2f1bd09587","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/1264/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/1264/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/1264/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/74794cee67a03b190b538d4032bc90e40e78541f","head":{"label":"vvysotskyi:DRILL-6422","ref":"DRILL-6422","sha":"74794cee67a03b190b538d4032bc90e40e78541f","user":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"repo":{"id":84822230,"node_id":"MDEwOlJlcG9zaXRvcnk4NDgyMjIzMA==","name":"drill","full_name":"vvysotskyi/drill","owner":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvysotskyi/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/vvysotskyi/drill","forks_url":"https://api.github.com/repos/vvysotskyi/drill/forks","keys_url":"https://api.github.com/repos/vvysotskyi/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvysotskyi/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvysotskyi/drill/teams","hooks_url":"https://api.github.com/repos/vvysotskyi/drill/hooks","issue_events_url":"https://api.github.com/repos/vvysotskyi/drill/issues/events{/number}","events_url":"https://api.github.com/repos/vvysotskyi/drill/events","assignees_url":"https://api.github.com/repos/vvysotskyi/drill/assignees{/user}","branches_url":"https://api.github.com/repos/vvysotskyi/drill/branches{/branch}","tags_url":"https://api.github.com/repos/vvysotskyi/drill/tags","blobs_url":"https://api.github.com/repos/vvysotskyi/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvysotskyi/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvysotskyi/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvysotskyi/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvysotskyi/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/vvysotskyi/drill/languages","stargazers_url":"https://api.github.com/repos/vvysotskyi/drill/stargazers","contributors_url":"https://api.github.com/repos/vvysotskyi/drill/contributors","subscribers_url":"https://api.github.com/repos/vvysotskyi/drill/subscribers","subscription_url":"https://api.github.com/repos/vvysotskyi/drill/subscription","commits_url":"https://api.github.com/repos/vvysotskyi/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvysotskyi/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvysotskyi/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvysotskyi/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvysotskyi/drill/contents/{+path}","compare_url":"https://api.github.com/repos/vvysotskyi/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvysotskyi/drill/merges","archive_url":"https://api.github.com/repos/vvysotskyi/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvysotskyi/drill/downloads","issues_url":"https://api.github.com/repos/vvysotskyi/drill/issues{/number}","pulls_url":"https://api.github.com/repos/vvysotskyi/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/vvysotskyi/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/vvysotskyi/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvysotskyi/drill/labels{/name}","releases_url":"https://api.github.com/repos/vvysotskyi/drill/releases{/id}","deployments_url":"https://api.github.com/repos/vvysotskyi/drill/deployments","created_at":"2017-03-13T12:09:17Z","updated_at":"2018-07-02T07:44:34Z","pushed_at":"2018-07-09T14:41:54Z","git_url":"git://github.com/vvysotskyi/drill.git","ssh_url":"git@github.com:vvysotskyi/drill.git","clone_url":"https://github.com/vvysotskyi/drill.git","svn_url":"https://github.com/vvysotskyi/drill","homepage":"","size":59053,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3b34f0dfddade01220cee5cd299a62f012aea70a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgzNjUz","name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2018-07-09T12:17:53Z","pushed_at":"2018-07-09T12:17:30Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":61385,"stargazers_count":1000,"watchers_count":1000,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":674,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":674,"open_issues":100,"watchers":1000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/1264"},"html":{"href":"https://github.com/apache/drill/pull/1264"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/1264"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/1264/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/1264/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/1264/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/74794cee67a03b190b538d4032bc90e40e78541f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vvysotskyi"}}