{"action":"created","issue":{"url":"https://api.github.com/repos/Exiv2/exiv2/issues/462","repository_url":"https://api.github.com/repos/Exiv2/exiv2","labels_url":"https://api.github.com/repos/Exiv2/exiv2/issues/462/labels{/name}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/issues/462/comments","events_url":"https://api.github.com/repos/Exiv2/exiv2/issues/462/events","html_url":"https://github.com/Exiv2/exiv2/pull/462","id":367247643,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzMwMTkx","number":462,"title":"Use PROJECT_SOURCE_DIR","user":{"login":"henryborchers","id":7454877,"node_id":"MDQ6VXNlcjc0NTQ4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/7454877?v=4","gravatar_id":"","url":"https://api.github.com/users/henryborchers","html_url":"https://github.com/henryborchers","followers_url":"https://api.github.com/users/henryborchers/followers","following_url":"https://api.github.com/users/henryborchers/following{/other_user}","gists_url":"https://api.github.com/users/henryborchers/gists{/gist_id}","starred_url":"https://api.github.com/users/henryborchers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryborchers/subscriptions","organizations_url":"https://api.github.com/users/henryborchers/orgs","repos_url":"https://api.github.com/users/henryborchers/repos","events_url":"https://api.github.com/users/henryborchers/events{/privacy}","received_events_url":"https://api.github.com/users/henryborchers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-05T14:56:55Z","updated_at":"2018-10-07T08:03:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/462","html_url":"https://github.com/Exiv2/exiv2/pull/462","diff_url":"https://github.com/Exiv2/exiv2/pull/462.diff","patch_url":"https://github.com/Exiv2/exiv2/pull/462.patch"},"body":"Using PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR is exactly the same for locating include folders during a standard build. However, using PROJECT_SOURCE_DIR instead allows the Exiv2 to be built as a subproject of other projects using CMake's FetchContent and ExternalProject_Add.  "},"comment":{"url":"https://api.github.com/repos/Exiv2/exiv2/issues/comments/427634177","html_url":"https://github.com/Exiv2/exiv2/pull/462#issuecomment-427634177","issue_url":"https://api.github.com/repos/Exiv2/exiv2/issues/462","id":427634177,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzYzNDE3Nw==","user":{"login":"D4N","id":786021,"node_id":"MDQ6VXNlcjc4NjAyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/786021?v=4","gravatar_id":"","url":"https://api.github.com/users/D4N","html_url":"https://github.com/D4N","followers_url":"https://api.github.com/users/D4N/followers","following_url":"https://api.github.com/users/D4N/following{/other_user}","gists_url":"https://api.github.com/users/D4N/gists{/gist_id}","starred_url":"https://api.github.com/users/D4N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D4N/subscriptions","organizations_url":"https://api.github.com/users/D4N/orgs","repos_url":"https://api.github.com/users/D4N/repos","events_url":"https://api.github.com/users/D4N/events{/privacy}","received_events_url":"https://api.github.com/users/D4N/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T08:03:33Z","updated_at":"2018-10-07T08:03:33Z","author_association":"CONTRIBUTOR","body":"@henryborchers Done. It was easier to create a new branch based on master, cherry pick the commit with the change and force push it to your branch.\r\n\r\nSome additional stuff concerning git:\r\n- I have force pushed to UIUCLibrary/master, if you do a git pull next time, you'll get a humongous merge and/or a lot of conflicts. Instead only do a git fetch and reset --hard your local copy.\r\n- You can avoid the merges by always performing a `pull --rebase origin/master`. Thereby your local commits will be rebased on top of master and you'll never have to clean up merges again (but a failed rebase is harder to clean up than a merge)."}}
{"actor":{"display_login":"D4N"}}