{"action":"created","comment":{"url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/comments/238084732","pull_request_review_id":180547374,"id":238084732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA4NDczMg==","diff_hunk":"@@ -0,0 +1,164 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Globalization;\n+using FluentAssertions;\n+using NUnit.Framework;\n+using ObjectPrinting;\n+\n+namespace ObjectPrintingTests\n+{\n+    [TestFixture]\n+    public class PrintingConfigTests\n+    {\n+        [SetUp]\n+        public void SetUp()\n+        {\n+            printer = ObjectPrinter.For<Person>();\n+            person = new Person\n+            {\n+                Id = Guid.NewGuid(),\n+                Name = \"mattgroy\",\n+                Age = 18,\n+                Height = 1.89\n+            };\n+//            const string expected = \"Person\\r\\n\\tId = Guid\\r\\n\\tName = mattgroy\\r\\n\\tHeight = 1,89\\r\\n\\tAge = 18\\r\\n\";\n+        }\n+\n+        private PrintingConfig<Person> printer;\n+        private Person person;\n+\n+        public class MyClass\n+        {\n+            public List<Person> MyList { get; set; }\n+            public Dictionary<int, Person> MyDict { get; set; }\n+        }\n+\n+        [Test]\n+        public void ChangeCultureForNumeric_Double()\n+        {\n+            const string expected = \"Person\\r\\n\\tId = Guid\\r\\n\\tName = mattgroy\\r\\n\\tHeight = 1.89\\r\\n\\tAge = 18\\r\\n\";\n+            printer.Printing<double>().Using(CultureInfo.InvariantCulture);\n+            printer.PrintToString(person).Should().Be(expected);\n+        }\n+\n+        [Test]\n+        public void ChangeSerializationForProperty_Age()\n+        {\n+            const string expected = \"Person\\r\\n\\tId = Guid\\r\\n\\tName = mattgroy\\r\\n\\tHeight = 1,89\\r\\n\\tAge = 21\\r\\n\";","path":"ObjectPrintingTests/PrintingConfigTests.cs","position":47,"original_position":47,"commit_id":"ff4168c690e22e7308d746b8a80622cf8225ff85","original_commit_id":"ff4168c690e22e7308d746b8a80622cf8225ff85","user":{"login":"anaym","id":10662975,"node_id":"MDQ6VXNlcjEwNjYyOTc1","avatar_url":"https://avatars0.githubusercontent.com/u/10662975?v=4","gravatar_id":"","url":"https://api.github.com/users/anaym","html_url":"https://github.com/anaym","followers_url":"https://api.github.com/users/anaym/followers","following_url":"https://api.github.com/users/anaym/following{/other_user}","gists_url":"https://api.github.com/users/anaym/gists{/gist_id}","starred_url":"https://api.github.com/users/anaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anaym/subscriptions","organizations_url":"https://api.github.com/users/anaym/orgs","repos_url":"https://api.github.com/users/anaym/repos","events_url":"https://api.github.com/users/anaym/events{/privacy}","received_events_url":"https://api.github.com/users/anaym/received_events","type":"User","site_admin":false},"body":"У меня не проходит данный тест, так как ты явно захардкотил `1,89` в числе (а у меня на компе другие настройки десятичного разделителя). Подумай, как это исправить","created_at":"2018-12-02T04:39:28Z","updated_at":"2018-12-02T04:45:04Z","html_url":"https://github.com/kontur-courses/fluent-api/pull/43#discussion_r238084732","pull_request_url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/comments/238084732"},"html":{"href":"https://github.com/kontur-courses/fluent-api/pull/43#discussion_r238084732"},"pull_request":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43","id":234756259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzU2MjU5","html_url":"https://github.com/kontur-courses/fluent-api/pull/43","diff_url":"https://github.com/kontur-courses/fluent-api/pull/43.diff","patch_url":"https://github.com/kontur-courses/fluent-api/pull/43.patch","issue_url":"https://api.github.com/repos/kontur-courses/fluent-api/issues/43","number":43,"state":"open","locked":false,"title":"Ратков Максим","user":{"login":"mattgroy","id":32338709,"node_id":"MDQ6VXNlcjMyMzM4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/32338709?v=4","gravatar_id":"","url":"https://api.github.com/users/mattgroy","html_url":"https://github.com/mattgroy","followers_url":"https://api.github.com/users/mattgroy/followers","following_url":"https://api.github.com/users/mattgroy/following{/other_user}","gists_url":"https://api.github.com/users/mattgroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgroy/subscriptions","organizations_url":"https://api.github.com/users/mattgroy/orgs","repos_url":"https://api.github.com/users/mattgroy/repos","events_url":"https://api.github.com/users/mattgroy/events{/privacy}","received_events_url":"https://api.github.com/users/mattgroy/received_events","type":"User","site_admin":false},"body":"@anaym","created_at":"2018-11-29T19:22:03Z","updated_at":"2018-12-02T04:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdc416812c56e68a3cbe5b32e9e03f9f19b70292","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43/commits","review_comments_url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43/comments","review_comment_url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontur-courses/fluent-api/issues/43/comments","statuses_url":"https://api.github.com/repos/kontur-courses/fluent-api/statuses/ff4168c690e22e7308d746b8a80622cf8225ff85","head":{"label":"mattgroy:master","ref":"master","sha":"ff4168c690e22e7308d746b8a80622cf8225ff85","user":{"login":"mattgroy","id":32338709,"node_id":"MDQ6VXNlcjMyMzM4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/32338709?v=4","gravatar_id":"","url":"https://api.github.com/users/mattgroy","html_url":"https://github.com/mattgroy","followers_url":"https://api.github.com/users/mattgroy/followers","following_url":"https://api.github.com/users/mattgroy/following{/other_user}","gists_url":"https://api.github.com/users/mattgroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgroy/subscriptions","organizations_url":"https://api.github.com/users/mattgroy/orgs","repos_url":"https://api.github.com/users/mattgroy/repos","events_url":"https://api.github.com/users/mattgroy/events{/privacy}","received_events_url":"https://api.github.com/users/mattgroy/received_events","type":"User","site_admin":false},"repo":{"id":158835362,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4MzUzNjI=","name":"fluent-api","full_name":"mattgroy/fluent-api","private":false,"owner":{"login":"mattgroy","id":32338709,"node_id":"MDQ6VXNlcjMyMzM4NzA5","avatar_url":"https://avatars1.githubusercontent.com/u/32338709?v=4","gravatar_id":"","url":"https://api.github.com/users/mattgroy","html_url":"https://github.com/mattgroy","followers_url":"https://api.github.com/users/mattgroy/followers","following_url":"https://api.github.com/users/mattgroy/following{/other_user}","gists_url":"https://api.github.com/users/mattgroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgroy/subscriptions","organizations_url":"https://api.github.com/users/mattgroy/orgs","repos_url":"https://api.github.com/users/mattgroy/repos","events_url":"https://api.github.com/users/mattgroy/events{/privacy}","received_events_url":"https://api.github.com/users/mattgroy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattgroy/fluent-api","description":"Разработка Fluent API","fork":true,"url":"https://api.github.com/repos/mattgroy/fluent-api","forks_url":"https://api.github.com/repos/mattgroy/fluent-api/forks","keys_url":"https://api.github.com/repos/mattgroy/fluent-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattgroy/fluent-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattgroy/fluent-api/teams","hooks_url":"https://api.github.com/repos/mattgroy/fluent-api/hooks","issue_events_url":"https://api.github.com/repos/mattgroy/fluent-api/issues/events{/number}","events_url":"https://api.github.com/repos/mattgroy/fluent-api/events","assignees_url":"https://api.github.com/repos/mattgroy/fluent-api/assignees{/user}","branches_url":"https://api.github.com/repos/mattgroy/fluent-api/branches{/branch}","tags_url":"https://api.github.com/repos/mattgroy/fluent-api/tags","blobs_url":"https://api.github.com/repos/mattgroy/fluent-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattgroy/fluent-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattgroy/fluent-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattgroy/fluent-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattgroy/fluent-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mattgroy/fluent-api/languages","stargazers_url":"https://api.github.com/repos/mattgroy/fluent-api/stargazers","contributors_url":"https://api.github.com/repos/mattgroy/fluent-api/contributors","subscribers_url":"https://api.github.com/repos/mattgroy/fluent-api/subscribers","subscription_url":"https://api.github.com/repos/mattgroy/fluent-api/subscription","commits_url":"https://api.github.com/repos/mattgroy/fluent-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattgroy/fluent-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattgroy/fluent-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattgroy/fluent-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattgroy/fluent-api/contents/{+path}","compare_url":"https://api.github.com/repos/mattgroy/fluent-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattgroy/fluent-api/merges","archive_url":"https://api.github.com/repos/mattgroy/fluent-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattgroy/fluent-api/downloads","issues_url":"https://api.github.com/repos/mattgroy/fluent-api/issues{/number}","pulls_url":"https://api.github.com/repos/mattgroy/fluent-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mattgroy/fluent-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mattgroy/fluent-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattgroy/fluent-api/labels{/name}","releases_url":"https://api.github.com/repos/mattgroy/fluent-api/releases{/id}","deployments_url":"https://api.github.com/repos/mattgroy/fluent-api/deployments","created_at":"2018-11-23T13:18:09Z","updated_at":"2018-11-30T10:56:26Z","pushed_at":"2018-11-30T10:56:24Z","git_url":"git://github.com/mattgroy/fluent-api.git","ssh_url":"git@github.com:mattgroy/fluent-api.git","clone_url":"https://github.com/mattgroy/fluent-api.git","svn_url":"https://github.com/mattgroy/fluent-api","homepage":null,"size":1506,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kontur-courses:master","ref":"master","sha":"cbeab99467dff34cd973eb9f44fd4c72dbcf6fe0","user":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"repo":{"id":62727275,"node_id":"MDEwOlJlcG9zaXRvcnk2MjcyNzI3NQ==","name":"fluent-api","full_name":"kontur-courses/fluent-api","private":false,"owner":{"login":"kontur-courses","id":19208073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjA4MDcz","avatar_url":"https://avatars2.githubusercontent.com/u/19208073?v=4","gravatar_id":"","url":"https://api.github.com/users/kontur-courses","html_url":"https://github.com/kontur-courses","followers_url":"https://api.github.com/users/kontur-courses/followers","following_url":"https://api.github.com/users/kontur-courses/following{/other_user}","gists_url":"https://api.github.com/users/kontur-courses/gists{/gist_id}","starred_url":"https://api.github.com/users/kontur-courses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontur-courses/subscriptions","organizations_url":"https://api.github.com/users/kontur-courses/orgs","repos_url":"https://api.github.com/users/kontur-courses/repos","events_url":"https://api.github.com/users/kontur-courses/events{/privacy}","received_events_url":"https://api.github.com/users/kontur-courses/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kontur-courses/fluent-api","description":"Разработка Fluent API","fork":false,"url":"https://api.github.com/repos/kontur-courses/fluent-api","forks_url":"https://api.github.com/repos/kontur-courses/fluent-api/forks","keys_url":"https://api.github.com/repos/kontur-courses/fluent-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontur-courses/fluent-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontur-courses/fluent-api/teams","hooks_url":"https://api.github.com/repos/kontur-courses/fluent-api/hooks","issue_events_url":"https://api.github.com/repos/kontur-courses/fluent-api/issues/events{/number}","events_url":"https://api.github.com/repos/kontur-courses/fluent-api/events","assignees_url":"https://api.github.com/repos/kontur-courses/fluent-api/assignees{/user}","branches_url":"https://api.github.com/repos/kontur-courses/fluent-api/branches{/branch}","tags_url":"https://api.github.com/repos/kontur-courses/fluent-api/tags","blobs_url":"https://api.github.com/repos/kontur-courses/fluent-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontur-courses/fluent-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontur-courses/fluent-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontur-courses/fluent-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontur-courses/fluent-api/statuses/{sha}","languages_url":"https://api.github.com/repos/kontur-courses/fluent-api/languages","stargazers_url":"https://api.github.com/repos/kontur-courses/fluent-api/stargazers","contributors_url":"https://api.github.com/repos/kontur-courses/fluent-api/contributors","subscribers_url":"https://api.github.com/repos/kontur-courses/fluent-api/subscribers","subscription_url":"https://api.github.com/repos/kontur-courses/fluent-api/subscription","commits_url":"https://api.github.com/repos/kontur-courses/fluent-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontur-courses/fluent-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontur-courses/fluent-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontur-courses/fluent-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontur-courses/fluent-api/contents/{+path}","compare_url":"https://api.github.com/repos/kontur-courses/fluent-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontur-courses/fluent-api/merges","archive_url":"https://api.github.com/repos/kontur-courses/fluent-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontur-courses/fluent-api/downloads","issues_url":"https://api.github.com/repos/kontur-courses/fluent-api/issues{/number}","pulls_url":"https://api.github.com/repos/kontur-courses/fluent-api/pulls{/number}","milestones_url":"https://api.github.com/repos/kontur-courses/fluent-api/milestones{/number}","notifications_url":"https://api.github.com/repos/kontur-courses/fluent-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontur-courses/fluent-api/labels{/name}","releases_url":"https://api.github.com/repos/kontur-courses/fluent-api/releases{/id}","deployments_url":"https://api.github.com/repos/kontur-courses/fluent-api/deployments","created_at":"2016-07-06T14:27:15Z","updated_at":"2018-11-20T21:52:15Z","pushed_at":"2018-12-01T23:52:23Z","git_url":"git://github.com/kontur-courses/fluent-api.git","ssh_url":"git@github.com:kontur-courses/fluent-api.git","clone_url":"https://github.com/kontur-courses/fluent-api.git","svn_url":"https://github.com/kontur-courses/fluent-api","homepage":null,"size":1484,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":84,"open_issues":35,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43"},"html":{"href":"https://github.com/kontur-courses/fluent-api/pull/43"},"issue":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/issues/43"},"comments":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/kontur-courses/fluent-api/statuses/ff4168c690e22e7308d746b8a80622cf8225ff85"}},"author_association":"NONE"}}
{"actor":{"display_login":"anaym"}}