{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2714","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2714/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2714/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2714/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2714","id":322817929,"number":2714,"title":"North arrow top offset and flag to geometry api","user":{"login":"Dane-Thomas","id":8885149,"avatar_url":"https://avatars1.githubusercontent.com/u/8885149?v=4","gravatar_id":"","url":"https://api.github.com/users/Dane-Thomas","html_url":"https://github.com/Dane-Thomas","followers_url":"https://api.github.com/users/Dane-Thomas/followers","following_url":"https://api.github.com/users/Dane-Thomas/following{/other_user}","gists_url":"https://api.github.com/users/Dane-Thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/Dane-Thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dane-Thomas/subscriptions","organizations_url":"https://api.github.com/users/Dane-Thomas/orgs","repos_url":"https://api.github.com/users/Dane-Thomas/repos","events_url":"https://api.github.com/users/Dane-Thomas/events{/privacy}","received_events_url":"https://api.github.com/users/Dane-Thomas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars0.githubusercontent.com/u/2285779?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars0.githubusercontent.com/u/2285779?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},{"login":"JahidAhmed","id":9637542,"avatar_url":"https://avatars0.githubusercontent.com/u/9637542?v=4","gravatar_id":"","url":"https://api.github.com/users/JahidAhmed","html_url":"https://github.com/JahidAhmed","followers_url":"https://api.github.com/users/JahidAhmed/followers","following_url":"https://api.github.com/users/JahidAhmed/following{/other_user}","gists_url":"https://api.github.com/users/JahidAhmed/gists{/gist_id}","starred_url":"https://api.github.com/users/JahidAhmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JahidAhmed/subscriptions","organizations_url":"https://api.github.com/users/JahidAhmed/orgs","repos_url":"https://api.github.com/users/JahidAhmed/repos","events_url":"https://api.github.com/users/JahidAhmed/events{/privacy}","received_events_url":"https://api.github.com/users/JahidAhmed/received_events","type":"User","site_admin":false},{"login":"barryytm","id":19259169,"avatar_url":"https://avatars3.githubusercontent.com/u/19259169?v=4","gravatar_id":"","url":"https://api.github.com/users/barryytm","html_url":"https://github.com/barryytm","followers_url":"https://api.github.com/users/barryytm/followers","following_url":"https://api.github.com/users/barryytm/following{/other_user}","gists_url":"https://api.github.com/users/barryytm/gists{/gist_id}","starred_url":"https://api.github.com/users/barryytm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryytm/subscriptions","organizations_url":"https://api.github.com/users/barryytm/orgs","repos_url":"https://api.github.com/users/barryytm/repos","events_url":"https://api.github.com/users/barryytm/events{/privacy}","received_events_url":"https://api.github.com/users/barryytm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2018-05-14T13:31:34Z","updated_at":"2018-05-15T16:50:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/2714","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2714","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2714.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2714.patch"},"body":"## Description\r\n<!-- Link to an issue or include a description -->\r\nCloses #2678 \r\n\r\nChange flag to use geometry api.\r\nAdd ability to specify top offset for the north arrow. \r\n\r\n## Testing\r\n<!-- Have you added unit tests for this code?  If not explain why. -->\r\nTested manually.\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] Commit messages follow [the guidelines](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/master/CONTRIBUTING.md#-git-commit-guidelines)\r\n- [x] Release notes have been updated\r\n- [x] PR targets the correct release version\r\n- [ ] ~~Help files and documentation have been updated~~\r\n\r\nRemember, it is a *muffin offence* to open a PR with any of the above checklist items incomplete.\r\n\r\nPlease keep the original issue up to date with the final solution, expected behaviour, and any additional notes for testers\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/2714)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/389236529","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/2714#issuecomment-389236529","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/2714","id":389236529,"user":{"login":"JahidAhmed","id":9637542,"avatar_url":"https://avatars0.githubusercontent.com/u/9637542?v=4","gravatar_id":"","url":"https://api.github.com/users/JahidAhmed","html_url":"https://github.com/JahidAhmed","followers_url":"https://api.github.com/users/JahidAhmed/followers","following_url":"https://api.github.com/users/JahidAhmed/following{/other_user}","gists_url":"https://api.github.com/users/JahidAhmed/gists{/gist_id}","starred_url":"https://api.github.com/users/JahidAhmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JahidAhmed/subscriptions","organizations_url":"https://api.github.com/users/JahidAhmed/orgs","repos_url":"https://api.github.com/users/JahidAhmed/repos","events_url":"https://api.github.com/users/JahidAhmed/events{/privacy}","received_events_url":"https://api.github.com/users/JahidAhmed/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T16:50:05Z","updated_at":"2018-05-15T16:50:05Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 1 of 3 files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[src/app/ui/common/north-arrow.directive.js, line 35 at r5](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/2714#-LCZIPDL5n7Msrhi3K9j:-LCZgyjv8omCUXr8XeHU:b-wxbqzu) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/380de5d2e2d622d2b7f30c58a7ee3c0517e50dc7/src/app/ui/common/north-arrow.directive.js#L35)):*\n<details><summary><i>Previously, Dane-Thomas (Dane Thomas) wrote…</i></summary><blockquote>\n\nalright done\n</blockquote></details>\n\nAlternatively, we could also create the `SimpleLayer` manually by first creating a `LayerRecord` using the appropriate `geoApi` function manually, similar to how the `SimpleLayer` is done: \nhttps://github.com/fgpv-vpgf/fgpv-vpgf/blob/develop/src/app/geo/layer-registry.service.js#L55\n\nThis would ensure we don't add / remove it from any layers list and it also won't be async.\n\nThis can be done in a future PR though if we want to handle it this way\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/2714)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"JahidAhmed"}}