{"action":"created","comment":{"url":"https://api.github.com/repos/tmobile/t-vault/pulls/comments/217447408","pull_request_review_id":155161550,"id":217447408,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ0NzQwOA==","diff_hunk":"@@ -467,8 +467,8 @@ if [[ -z \"$initstat\" ]]; then\n \n   if [[ \"$ENABLE_AWS\" == \"yes\" ]]; then\n      echo \"Enabling AWS auth...\"\n-     vault auth-enable aws >> $INSTLOG\n-     vault mount-tune -default-lease-ttl=15m /auth/aws >> $INSTLOG\n+     vault auth enable aws >> $INSTLOG\n+     vault secrets tune -default-lease-ttl=15m /auth/aws >> $INSTLOG\n   fi","path":"dist/src/main/docker/vault.sh","position":86,"original_position":86,"commit_id":"6ffc4ec2cce7ba16f749e5830dc75727c535bbea","original_commit_id":"6ffc4ec2cce7ba16f749e5830dc75727c535bbea","user":{"login":"anilcs81","id":9734570,"node_id":"MDQ6VXNlcjk3MzQ1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9734570?v=4","gravatar_id":"","url":"https://api.github.com/users/anilcs81","html_url":"https://github.com/anilcs81","followers_url":"https://api.github.com/users/anilcs81/followers","following_url":"https://api.github.com/users/anilcs81/following{/other_user}","gists_url":"https://api.github.com/users/anilcs81/gists{/gist_id}","starred_url":"https://api.github.com/users/anilcs81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anilcs81/subscriptions","organizations_url":"https://api.github.com/users/anilcs81/orgs","repos_url":"https://api.github.com/users/anilcs81/repos","events_url":"https://api.github.com/users/anilcs81/events{/privacy}","received_events_url":"https://api.github.com/users/anilcs81/received_events","type":"User","site_admin":false},"body":"Can you add the tuning for approle as well. I think we missed it in the initial part","created_at":"2018-09-13T16:17:34Z","updated_at":"2018-09-13T16:27:07Z","html_url":"https://github.com/tmobile/t-vault/pull/54#discussion_r217447408","pull_request_url":"https://api.github.com/repos/tmobile/t-vault/pulls/54","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/comments/217447408"},"html":{"href":"https://github.com/tmobile/t-vault/pull/54#discussion_r217447408"},"pull_request":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/tmobile/t-vault/pulls/54","id":214923033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTIzMDMz","html_url":"https://github.com/tmobile/t-vault/pull/54","diff_url":"https://github.com/tmobile/t-vault/pull/54.diff","patch_url":"https://github.com/tmobile/t-vault/pull/54.patch","issue_url":"https://api.github.com/repos/tmobile/t-vault/issues/54","number":54,"state":"open","locked":false,"title":"IAM Authentication","user":{"login":"sivanag1974","id":33500344,"node_id":"MDQ6VXNlcjMzNTAwMzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/33500344?v=4","gravatar_id":"","url":"https://api.github.com/users/sivanag1974","html_url":"https://github.com/sivanag1974","followers_url":"https://api.github.com/users/sivanag1974/followers","following_url":"https://api.github.com/users/sivanag1974/following{/other_user}","gists_url":"https://api.github.com/users/sivanag1974/gists{/gist_id}","starred_url":"https://api.github.com/users/sivanag1974/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivanag1974/subscriptions","organizations_url":"https://api.github.com/users/sivanag1974/orgs","repos_url":"https://api.github.com/users/sivanag1974/repos","events_url":"https://api.github.com/users/sivanag1974/events{/privacy}","received_events_url":"https://api.github.com/users/sivanag1974/received_events","type":"User","site_admin":false},"body":"Changes:\r\n1. IAM Authentication\r\n2. Upgraded vault\r\n3. Code refactoring","created_at":"2018-09-12T11:12:29Z","updated_at":"2018-09-13T16:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4e6dc0ac3f26fbac1255e8a3e2b43a9930caaa3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kaykumar","id":19676806,"node_id":"MDQ6VXNlcjE5Njc2ODA2","avatar_url":"https://avatars0.githubusercontent.com/u/19676806?v=4","gravatar_id":"","url":"https://api.github.com/users/kaykumar","html_url":"https://github.com/kaykumar","followers_url":"https://api.github.com/users/kaykumar/followers","following_url":"https://api.github.com/users/kaykumar/following{/other_user}","gists_url":"https://api.github.com/users/kaykumar/gists{/gist_id}","starred_url":"https://api.github.com/users/kaykumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaykumar/subscriptions","organizations_url":"https://api.github.com/users/kaykumar/orgs","repos_url":"https://api.github.com/users/kaykumar/repos","events_url":"https://api.github.com/users/kaykumar/events{/privacy}","received_events_url":"https://api.github.com/users/kaykumar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tmobile/t-vault/pulls/54/commits","review_comments_url":"https://api.github.com/repos/tmobile/t-vault/pulls/54/comments","review_comment_url":"https://api.github.com/repos/tmobile/t-vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmobile/t-vault/issues/54/comments","statuses_url":"https://api.github.com/repos/tmobile/t-vault/statuses/6ffc4ec2cce7ba16f749e5830dc75727c535bbea","head":{"label":"sivanag1974:dev","ref":"dev","sha":"6ffc4ec2cce7ba16f749e5830dc75727c535bbea","user":{"login":"sivanag1974","id":33500344,"node_id":"MDQ6VXNlcjMzNTAwMzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/33500344?v=4","gravatar_id":"","url":"https://api.github.com/users/sivanag1974","html_url":"https://github.com/sivanag1974","followers_url":"https://api.github.com/users/sivanag1974/followers","following_url":"https://api.github.com/users/sivanag1974/following{/other_user}","gists_url":"https://api.github.com/users/sivanag1974/gists{/gist_id}","starred_url":"https://api.github.com/users/sivanag1974/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivanag1974/subscriptions","organizations_url":"https://api.github.com/users/sivanag1974/orgs","repos_url":"https://api.github.com/users/sivanag1974/repos","events_url":"https://api.github.com/users/sivanag1974/events{/privacy}","received_events_url":"https://api.github.com/users/sivanag1974/received_events","type":"User","site_admin":false},"repo":{"id":126403516,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY0MDM1MTY=","name":"t-vault","full_name":"sivanag1974/t-vault","owner":{"login":"sivanag1974","id":33500344,"node_id":"MDQ6VXNlcjMzNTAwMzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/33500344?v=4","gravatar_id":"","url":"https://api.github.com/users/sivanag1974","html_url":"https://github.com/sivanag1974","followers_url":"https://api.github.com/users/sivanag1974/followers","following_url":"https://api.github.com/users/sivanag1974/following{/other_user}","gists_url":"https://api.github.com/users/sivanag1974/gists{/gist_id}","starred_url":"https://api.github.com/users/sivanag1974/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivanag1974/subscriptions","organizations_url":"https://api.github.com/users/sivanag1974/orgs","repos_url":"https://api.github.com/users/sivanag1974/repos","events_url":"https://api.github.com/users/sivanag1974/events{/privacy}","received_events_url":"https://api.github.com/users/sivanag1974/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sivanag1974/t-vault","description":"Simplified secrets management solution","fork":true,"url":"https://api.github.com/repos/sivanag1974/t-vault","forks_url":"https://api.github.com/repos/sivanag1974/t-vault/forks","keys_url":"https://api.github.com/repos/sivanag1974/t-vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sivanag1974/t-vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sivanag1974/t-vault/teams","hooks_url":"https://api.github.com/repos/sivanag1974/t-vault/hooks","issue_events_url":"https://api.github.com/repos/sivanag1974/t-vault/issues/events{/number}","events_url":"https://api.github.com/repos/sivanag1974/t-vault/events","assignees_url":"https://api.github.com/repos/sivanag1974/t-vault/assignees{/user}","branches_url":"https://api.github.com/repos/sivanag1974/t-vault/branches{/branch}","tags_url":"https://api.github.com/repos/sivanag1974/t-vault/tags","blobs_url":"https://api.github.com/repos/sivanag1974/t-vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sivanag1974/t-vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sivanag1974/t-vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/sivanag1974/t-vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sivanag1974/t-vault/statuses/{sha}","languages_url":"https://api.github.com/repos/sivanag1974/t-vault/languages","stargazers_url":"https://api.github.com/repos/sivanag1974/t-vault/stargazers","contributors_url":"https://api.github.com/repos/sivanag1974/t-vault/contributors","subscribers_url":"https://api.github.com/repos/sivanag1974/t-vault/subscribers","subscription_url":"https://api.github.com/repos/sivanag1974/t-vault/subscription","commits_url":"https://api.github.com/repos/sivanag1974/t-vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/sivanag1974/t-vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/sivanag1974/t-vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/sivanag1974/t-vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/sivanag1974/t-vault/contents/{+path}","compare_url":"https://api.github.com/repos/sivanag1974/t-vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sivanag1974/t-vault/merges","archive_url":"https://api.github.com/repos/sivanag1974/t-vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sivanag1974/t-vault/downloads","issues_url":"https://api.github.com/repos/sivanag1974/t-vault/issues{/number}","pulls_url":"https://api.github.com/repos/sivanag1974/t-vault/pulls{/number}","milestones_url":"https://api.github.com/repos/sivanag1974/t-vault/milestones{/number}","notifications_url":"https://api.github.com/repos/sivanag1974/t-vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sivanag1974/t-vault/labels{/name}","releases_url":"https://api.github.com/repos/sivanag1974/t-vault/releases{/id}","deployments_url":"https://api.github.com/repos/sivanag1974/t-vault/deployments","created_at":"2018-03-22T22:43:58Z","updated_at":"2018-09-12T10:20:39Z","pushed_at":"2018-09-12T10:20:38Z","git_url":"git://github.com/sivanag1974/t-vault.git","ssh_url":"git@github.com:sivanag1974/t-vault.git","clone_url":"https://github.com/sivanag1974/t-vault.git","svn_url":"https://github.com/sivanag1974/t-vault","homepage":"","size":84757,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"tmobile:dev","ref":"dev","sha":"61d65eea10c94c1ad078680a6296229ef2ff6c2a","user":{"login":"tmobile","id":483040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzA0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":116761172,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3NjExNzI=","name":"t-vault","full_name":"tmobile/t-vault","owner":{"login":"tmobile","id":483040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzA0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tmobile/t-vault","description":"Simplified secrets management solution","fork":false,"url":"https://api.github.com/repos/tmobile/t-vault","forks_url":"https://api.github.com/repos/tmobile/t-vault/forks","keys_url":"https://api.github.com/repos/tmobile/t-vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmobile/t-vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmobile/t-vault/teams","hooks_url":"https://api.github.com/repos/tmobile/t-vault/hooks","issue_events_url":"https://api.github.com/repos/tmobile/t-vault/issues/events{/number}","events_url":"https://api.github.com/repos/tmobile/t-vault/events","assignees_url":"https://api.github.com/repos/tmobile/t-vault/assignees{/user}","branches_url":"https://api.github.com/repos/tmobile/t-vault/branches{/branch}","tags_url":"https://api.github.com/repos/tmobile/t-vault/tags","blobs_url":"https://api.github.com/repos/tmobile/t-vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmobile/t-vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmobile/t-vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmobile/t-vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmobile/t-vault/statuses/{sha}","languages_url":"https://api.github.com/repos/tmobile/t-vault/languages","stargazers_url":"https://api.github.com/repos/tmobile/t-vault/stargazers","contributors_url":"https://api.github.com/repos/tmobile/t-vault/contributors","subscribers_url":"https://api.github.com/repos/tmobile/t-vault/subscribers","subscription_url":"https://api.github.com/repos/tmobile/t-vault/subscription","commits_url":"https://api.github.com/repos/tmobile/t-vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmobile/t-vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmobile/t-vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmobile/t-vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmobile/t-vault/contents/{+path}","compare_url":"https://api.github.com/repos/tmobile/t-vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmobile/t-vault/merges","archive_url":"https://api.github.com/repos/tmobile/t-vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmobile/t-vault/downloads","issues_url":"https://api.github.com/repos/tmobile/t-vault/issues{/number}","pulls_url":"https://api.github.com/repos/tmobile/t-vault/pulls{/number}","milestones_url":"https://api.github.com/repos/tmobile/t-vault/milestones{/number}","notifications_url":"https://api.github.com/repos/tmobile/t-vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmobile/t-vault/labels{/name}","releases_url":"https://api.github.com/repos/tmobile/t-vault/releases{/id}","deployments_url":"https://api.github.com/repos/tmobile/t-vault/deployments","created_at":"2018-01-09T03:29:13Z","updated_at":"2018-09-10T17:41:08Z","pushed_at":"2018-09-12T11:12:29Z","git_url":"git://github.com/tmobile/t-vault.git","ssh_url":"git@github.com:tmobile/t-vault.git","clone_url":"https://github.com/tmobile/t-vault.git","svn_url":"https://github.com/tmobile/t-vault","homepage":"","size":62314,"stargazers_count":181,"watchers_count":181,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":3,"watchers":181,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/54"},"html":{"href":"https://github.com/tmobile/t-vault/pull/54"},"issue":{"href":"https://api.github.com/repos/tmobile/t-vault/issues/54"},"comments":{"href":"https://api.github.com/repos/tmobile/t-vault/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmobile/t-vault/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/tmobile/t-vault/statuses/6ffc4ec2cce7ba16f749e5830dc75727c535bbea"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anilcs81"}}