{"action":"created","comment":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/172855634","pull_request_review_id":101943578,"id":172855634,"diff_hunk":"@@ -24,8 +24,8 @@ def is_user_lib(objfile, libname):\n \n def otool(objfile):\n     command = \"otool -L %s | grep -e '\\t' | awk '{ print $1 }'\" % objfile\n-    output  = subprocess.check_output(command, shell = True)\n-    return filter(partial(is_user_lib, objfile), output.split())\n+    output  = subprocess.check_output(command, shell = True, universal_newlines=True)\n+    return list(filter(partial(is_user_lib, objfile), output.split()))","path":"TOOLS/dylib-unhell.py","position":null,"original_position":7,"commit_id":"b21288101ada1c05a9ef68e4801869f9e288d8b8","original_commit_id":"9e19a5cc5363b3ce591c53e216d58a69a6eaaa77","user":{"login":"Akemi","id":680386,"avatar_url":"https://avatars0.githubusercontent.com/u/680386?v=4","gravatar_id":"","url":"https://api.github.com/users/Akemi","html_url":"https://github.com/Akemi","followers_url":"https://api.github.com/users/Akemi/followers","following_url":"https://api.github.com/users/Akemi/following{/other_user}","gists_url":"https://api.github.com/users/Akemi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akemi/subscriptions","organizations_url":"https://api.github.com/users/Akemi/orgs","repos_url":"https://api.github.com/users/Akemi/repos","events_url":"https://api.github.com/users/Akemi/events{/privacy}","received_events_url":"https://api.github.com/users/Akemi/received_events","type":"User","site_admin":false},"body":"no reason, i just didn't think about optimising this part of the code. i mean that change would even be valid without having a need to fix it. i was just dumbly planning to make the code work consistently between the python versions, eg just return the same type as before/with python2.\r\n\r\ni pushed the changed and hope that is what you had in mind.\r\n","created_at":"2018-03-07T14:20:47Z","updated_at":"2018-03-07T14:20:47Z","html_url":"https://github.com/mpv-player/mpv/pull/5606#discussion_r172855634","pull_request_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5606","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/172855634"},"html":{"href":"https://github.com/mpv-player/mpv/pull/5606#discussion_r172855634"},"pull_request":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5606"}},"in_reply_to_id":172748814},"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/5606","id":173262811,"html_url":"https://github.com/mpv-player/mpv/pull/5606","diff_url":"https://github.com/mpv-player/mpv/pull/5606.diff","patch_url":"https://github.com/mpv-player/mpv/pull/5606.patch","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/5606","number":5606,"state":"open","locked":false,"title":"osxbundle: fix bundle creation with python3","user":{"login":"Akemi","id":680386,"avatar_url":"https://avatars0.githubusercontent.com/u/680386?v=4","gravatar_id":"","url":"https://api.github.com/users/Akemi","html_url":"https://github.com/Akemi","followers_url":"https://api.github.com/users/Akemi/followers","following_url":"https://api.github.com/users/Akemi/following{/other_user}","gists_url":"https://api.github.com/users/Akemi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akemi/subscriptions","organizations_url":"https://api.github.com/users/Akemi/orgs","repos_url":"https://api.github.com/users/Akemi/repos","events_url":"https://api.github.com/users/Akemi/events{/privacy}","received_events_url":"https://api.github.com/users/Akemi/received_events","type":"User","site_admin":false},"body":"it would be appreciated if someone else could test with both python2 and python3. just to make sure i didn't break something else again.\r\n\r\nthis fixes #5600 and #3316.","created_at":"2018-03-06T19:50:02Z","updated_at":"2018-03-07T14:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c70ac25e9b0542d1d249c1eda1975dfed3c1cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5606/commits","review_comments_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5606/comments","review_comment_url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/5606/comments","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/b21288101ada1c05a9ef68e4801869f9e288d8b8","head":{"label":"Akemi:macOS_bundle","ref":"macOS_bundle","sha":"b21288101ada1c05a9ef68e4801869f9e288d8b8","user":{"login":"Akemi","id":680386,"avatar_url":"https://avatars0.githubusercontent.com/u/680386?v=4","gravatar_id":"","url":"https://api.github.com/users/Akemi","html_url":"https://github.com/Akemi","followers_url":"https://api.github.com/users/Akemi/followers","following_url":"https://api.github.com/users/Akemi/following{/other_user}","gists_url":"https://api.github.com/users/Akemi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akemi/subscriptions","organizations_url":"https://api.github.com/users/Akemi/orgs","repos_url":"https://api.github.com/users/Akemi/repos","events_url":"https://api.github.com/users/Akemi/events{/privacy}","received_events_url":"https://api.github.com/users/Akemi/received_events","type":"User","site_admin":false},"repo":{"id":61307210,"name":"mpv","full_name":"Akemi/mpv","owner":{"login":"Akemi","id":680386,"avatar_url":"https://avatars0.githubusercontent.com/u/680386?v=4","gravatar_id":"","url":"https://api.github.com/users/Akemi","html_url":"https://github.com/Akemi","followers_url":"https://api.github.com/users/Akemi/followers","following_url":"https://api.github.com/users/Akemi/following{/other_user}","gists_url":"https://api.github.com/users/Akemi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akemi/subscriptions","organizations_url":"https://api.github.com/users/Akemi/orgs","repos_url":"https://api.github.com/users/Akemi/repos","events_url":"https://api.github.com/users/Akemi/events{/privacy}","received_events_url":"https://api.github.com/users/Akemi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Akemi/mpv","description":"Video player based on MPlayer/mplayer2","fork":true,"url":"https://api.github.com/repos/Akemi/mpv","forks_url":"https://api.github.com/repos/Akemi/mpv/forks","keys_url":"https://api.github.com/repos/Akemi/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akemi/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akemi/mpv/teams","hooks_url":"https://api.github.com/repos/Akemi/mpv/hooks","issue_events_url":"https://api.github.com/repos/Akemi/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/Akemi/mpv/events","assignees_url":"https://api.github.com/repos/Akemi/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/Akemi/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/Akemi/mpv/tags","blobs_url":"https://api.github.com/repos/Akemi/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akemi/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akemi/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akemi/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akemi/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/Akemi/mpv/languages","stargazers_url":"https://api.github.com/repos/Akemi/mpv/stargazers","contributors_url":"https://api.github.com/repos/Akemi/mpv/contributors","subscribers_url":"https://api.github.com/repos/Akemi/mpv/subscribers","subscription_url":"https://api.github.com/repos/Akemi/mpv/subscription","commits_url":"https://api.github.com/repos/Akemi/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akemi/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akemi/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akemi/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akemi/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/Akemi/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akemi/mpv/merges","archive_url":"https://api.github.com/repos/Akemi/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akemi/mpv/downloads","issues_url":"https://api.github.com/repos/Akemi/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/Akemi/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/Akemi/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/Akemi/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akemi/mpv/labels{/name}","releases_url":"https://api.github.com/repos/Akemi/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/Akemi/mpv/deployments","created_at":"2016-06-16T15:59:14Z","updated_at":"2018-03-07T01:16:48Z","pushed_at":"2018-03-07T14:09:59Z","git_url":"git://github.com/Akemi/mpv.git","ssh_url":"git@github.com:Akemi/mpv.git","clone_url":"https://github.com/Akemi/mpv.git","svn_url":"https://github.com/Akemi/mpv","homepage":"https://mpv.io","size":88033,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mpv-player:master","ref":"master","sha":"dae88644e62db3ca8ef96fa204d9a2ad924b5b28","user":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"repo":{"id":6201092,"name":"mpv","full_name":"mpv-player/mpv","owner":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpv-player/mpv","description":"🎥 Video player based on MPlayer/mplayer2","fork":false,"url":"https://api.github.com/repos/mpv-player/mpv","forks_url":"https://api.github.com/repos/mpv-player/mpv/forks","keys_url":"https://api.github.com/repos/mpv-player/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpv-player/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpv-player/mpv/teams","hooks_url":"https://api.github.com/repos/mpv-player/mpv/hooks","issue_events_url":"https://api.github.com/repos/mpv-player/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/mpv-player/mpv/events","assignees_url":"https://api.github.com/repos/mpv-player/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/mpv-player/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/mpv-player/mpv/tags","blobs_url":"https://api.github.com/repos/mpv-player/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpv-player/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpv-player/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpv-player/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/mpv-player/mpv/languages","stargazers_url":"https://api.github.com/repos/mpv-player/mpv/stargazers","contributors_url":"https://api.github.com/repos/mpv-player/mpv/contributors","subscribers_url":"https://api.github.com/repos/mpv-player/mpv/subscribers","subscription_url":"https://api.github.com/repos/mpv-player/mpv/subscription","commits_url":"https://api.github.com/repos/mpv-player/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpv-player/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpv-player/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpv-player/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpv-player/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/mpv-player/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpv-player/mpv/merges","archive_url":"https://api.github.com/repos/mpv-player/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpv-player/mpv/downloads","issues_url":"https://api.github.com/repos/mpv-player/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/mpv-player/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/mpv-player/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/mpv-player/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpv-player/mpv/labels{/name}","releases_url":"https://api.github.com/repos/mpv-player/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/mpv-player/mpv/deployments","created_at":"2012-10-13T08:08:44Z","updated_at":"2018-03-07T12:11:09Z","pushed_at":"2018-03-07T14:10:03Z","git_url":"git://github.com/mpv-player/mpv.git","ssh_url":"git@github.com:mpv-player/mpv.git","clone_url":"https://github.com/mpv-player/mpv.git","svn_url":"https://github.com/mpv-player/mpv","homepage":"https://mpv.io","size":88281,"stargazers_count":7454,"watchers_count":7454,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":995,"mirror_url":null,"archived":false,"open_issues_count":394,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":995,"open_issues":394,"watchers":7454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5606"},"html":{"href":"https://github.com/mpv-player/mpv/pull/5606"},"issue":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/5606"},"comments":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/5606/comments"},"review_comments":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5606/comments"},"review_comment":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5606/commits"},"statuses":{"href":"https://api.github.com/repos/mpv-player/mpv/statuses/b21288101ada1c05a9ef68e4801869f9e288d8b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Akemi"}}