{"action":"opened","number":1846,"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846","id":228833241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODMzMjQx","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1846","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1846.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1846.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1846","number":1846,"state":"open","locked":false,"title":"Dive list: invert sort-direction to reflect core","user":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"body":"Traditionally, the DiveTripModel has its data sorted in opposite\r\ndirection to the core-data (chronologically descending vs. ascending).\r\nThis bring a number of subtle problems. For example, when filling\r\nthe model, trips are filled according to the *last* dive, whereas\r\nlater insertion points are according to the ->when value from the\r\ncore, which depends on the *first* dive.\r\n\r\nAs a start of fixing these subtleties, change the sort direction\r\nto reflect the core-data. Ideally, this should lead to a removal\r\nof the redundant data-representation.\r\n\r\nSince the model is now sorted in ascending order, sorting has to\r\nbe enabled in the DiveListView constructor to reflect the\r\ndefault-descending order.\r\n\r\nSigned-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>\r\n\r\n<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [x] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\nOn closer look, the `DiveTripModel` code has a number of problems concerning overlapping trips and dives that happened during a trip, but are not part of a trip. This PR does not fix all of these problems, but is a first step in making them fixable. It also is a first step in removing the redundant representation of list-mode.\r\n\r\nI have difficulties giving this a risk / gain rating. It certainly needs testing, comparisons are infamously tricky.\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n1) Reverse order in DiveTripModel to reflect core.\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\nNo.\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\nNo.\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n","created_at":"2018-11-06T21:01:38Z","updated_at":"2018-11-06T21:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1846/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/97a6b1b0da4a355ca2f2412118c7d87bf2f83d82","head":{"label":"bstoeger:divelist6","ref":"divelist6","sha":"97a6b1b0da4a355ca2f2412118c7d87bf2f83d82","user":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"repo":{"id":107111280,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTEyODA=","name":"subsurface","full_name":"bstoeger/subsurface","private":false,"owner":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bstoeger/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/bstoeger/subsurface","forks_url":"https://api.github.com/repos/bstoeger/subsurface/forks","keys_url":"https://api.github.com/repos/bstoeger/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstoeger/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstoeger/subsurface/teams","hooks_url":"https://api.github.com/repos/bstoeger/subsurface/hooks","issue_events_url":"https://api.github.com/repos/bstoeger/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/bstoeger/subsurface/events","assignees_url":"https://api.github.com/repos/bstoeger/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/bstoeger/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/bstoeger/subsurface/tags","blobs_url":"https://api.github.com/repos/bstoeger/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstoeger/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstoeger/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstoeger/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstoeger/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/bstoeger/subsurface/languages","stargazers_url":"https://api.github.com/repos/bstoeger/subsurface/stargazers","contributors_url":"https://api.github.com/repos/bstoeger/subsurface/contributors","subscribers_url":"https://api.github.com/repos/bstoeger/subsurface/subscribers","subscription_url":"https://api.github.com/repos/bstoeger/subsurface/subscription","commits_url":"https://api.github.com/repos/bstoeger/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstoeger/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstoeger/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstoeger/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/bstoeger/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/bstoeger/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstoeger/subsurface/merges","archive_url":"https://api.github.com/repos/bstoeger/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstoeger/subsurface/downloads","issues_url":"https://api.github.com/repos/bstoeger/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/bstoeger/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/bstoeger/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/bstoeger/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstoeger/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/bstoeger/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/bstoeger/subsurface/deployments","created_at":"2017-10-16T10:11:10Z","updated_at":"2018-09-23T10:13:43Z","pushed_at":"2018-11-06T21:01:27Z","git_url":"git://github.com/bstoeger/subsurface.git","ssh_url":"git@github.com:bstoeger/subsurface.git","clone_url":"https://github.com/bstoeger/subsurface.git","svn_url":"https://github.com/bstoeger/subsurface","homepage":"https://subsurface-divelog.org","size":100847,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"63b47ff5300c73b0392a4e43e461fb0e709a39be","user":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE5NDk4","name":"subsurface","full_name":"Subsurface-divelog/subsurface","private":false,"owner":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-11-06T15:16:06Z","pushed_at":"2018-11-05T16:37:50Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":100860,"stargazers_count":1458,"watchers_count":1458,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":368,"open_issues":94,"watchers":1458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1846"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1846"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1846/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1846/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/97a6b1b0da4a355ca2f2412118c7d87bf2f83d82"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":41,"changed_files":2}}
{"actor":{"display_login":"bstoeger"}}