{"action":"opened","number":168,"pull_request":{"url":"https://api.github.com/repos/gramps-project/addons-source/pulls/168","id":220949860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTQ5ODYw","html_url":"https://github.com/gramps-project/addons-source/pull/168","diff_url":"https://github.com/gramps-project/addons-source/pull/168.diff","patch_url":"https://github.com/gramps-project/addons-source/pull/168.patch","issue_url":"https://api.github.com/repos/gramps-project/addons-source/issues/168","number":168,"state":"open","locked":false,"title":"Fix reports for shared event attribute and note errors","user":{"login":"prculley","id":18122203,"node_id":"MDQ6VXNlcjE4MTIyMjAz","avatar_url":"https://avatars2.githubusercontent.com/u/18122203?v=4","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"body":"Fixes #10720\r\n\r\nSince we added caching to the reports, we picked up some errors where the report writer was extending attribute and note lists from cached primary objects. This mostly did not matter, but when a primary object was referenced more than once in a report (like shared events), the extended lists would accumulate all the changes.\r\n\r\nI looked in all the reports, searching for \".extend(\" or \"+=\" and inspected to see if it was potentially modifying the cached primary object. If so, I made a copy of the list before using it.","created_at":"2018-10-07T14:01:43Z","updated_at":"2018-10-07T14:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":211603883,"node_id":"MDU6TGFiZWwyMTE2MDM4ODM=","url":"https://api.github.com/repos/gramps-project/addons-source/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/gramps-project/addons-source/pulls/168/commits","review_comments_url":"https://api.github.com/repos/gramps-project/addons-source/pulls/168/comments","review_comment_url":"https://api.github.com/repos/gramps-project/addons-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gramps-project/addons-source/issues/168/comments","statuses_url":"https://api.github.com/repos/gramps-project/addons-source/statuses/9611bb4a981e581dda57bb14d1d30823cd266b2d","head":{"label":"gramps-project:bug10720","ref":"bug10720","sha":"9611bb4a981e581dda57bb14d1d30823cd266b2d","user":{"login":"gramps-project","id":10428818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI4ODE4","avatar_url":"https://avatars1.githubusercontent.com/u/10428818?v=4","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"repo":{"id":35628181,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYyODE4MQ==","name":"addons-source","full_name":"gramps-project/addons-source","private":false,"owner":{"login":"gramps-project","id":10428818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI4ODE4","avatar_url":"https://avatars1.githubusercontent.com/u/10428818?v=4","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gramps-project/addons-source","description":"Contributed 3rd party plugins for Gramps","fork":false,"url":"https://api.github.com/repos/gramps-project/addons-source","forks_url":"https://api.github.com/repos/gramps-project/addons-source/forks","keys_url":"https://api.github.com/repos/gramps-project/addons-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gramps-project/addons-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gramps-project/addons-source/teams","hooks_url":"https://api.github.com/repos/gramps-project/addons-source/hooks","issue_events_url":"https://api.github.com/repos/gramps-project/addons-source/issues/events{/number}","events_url":"https://api.github.com/repos/gramps-project/addons-source/events","assignees_url":"https://api.github.com/repos/gramps-project/addons-source/assignees{/user}","branches_url":"https://api.github.com/repos/gramps-project/addons-source/branches{/branch}","tags_url":"https://api.github.com/repos/gramps-project/addons-source/tags","blobs_url":"https://api.github.com/repos/gramps-project/addons-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gramps-project/addons-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gramps-project/addons-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/gramps-project/addons-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gramps-project/addons-source/statuses/{sha}","languages_url":"https://api.github.com/repos/gramps-project/addons-source/languages","stargazers_url":"https://api.github.com/repos/gramps-project/addons-source/stargazers","contributors_url":"https://api.github.com/repos/gramps-project/addons-source/contributors","subscribers_url":"https://api.github.com/repos/gramps-project/addons-source/subscribers","subscription_url":"https://api.github.com/repos/gramps-project/addons-source/subscription","commits_url":"https://api.github.com/repos/gramps-project/addons-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/gramps-project/addons-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/gramps-project/addons-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/gramps-project/addons-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/gramps-project/addons-source/contents/{+path}","compare_url":"https://api.github.com/repos/gramps-project/addons-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gramps-project/addons-source/merges","archive_url":"https://api.github.com/repos/gramps-project/addons-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gramps-project/addons-source/downloads","issues_url":"https://api.github.com/repos/gramps-project/addons-source/issues{/number}","pulls_url":"https://api.github.com/repos/gramps-project/addons-source/pulls{/number}","milestones_url":"https://api.github.com/repos/gramps-project/addons-source/milestones{/number}","notifications_url":"https://api.github.com/repos/gramps-project/addons-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gramps-project/addons-source/labels{/name}","releases_url":"https://api.github.com/repos/gramps-project/addons-source/releases{/id}","deployments_url":"https://api.github.com/repos/gramps-project/addons-source/deployments","created_at":"2015-05-14T18:17:01Z","updated_at":"2018-09-14T08:47:10Z","pushed_at":"2018-10-07T14:00:24Z","git_url":"git://github.com/gramps-project/addons-source.git","ssh_url":"git@github.com:gramps-project/addons-source.git","clone_url":"https://github.com/gramps-project/addons-source.git","svn_url":"https://github.com/gramps-project/addons-source","homepage":"https://gramps-project.org/wiki/index.php?title=Addons_development","size":61692,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":41,"open_issues":13,"watchers":25,"default_branch":"master"}},"base":{"label":"gramps-project:maintenance/gramps50","ref":"maintenance/gramps50","sha":"c43663d4f95c4132942f6bd42401832a44e1101b","user":{"login":"gramps-project","id":10428818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI4ODE4","avatar_url":"https://avatars1.githubusercontent.com/u/10428818?v=4","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"repo":{"id":35628181,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYyODE4MQ==","name":"addons-source","full_name":"gramps-project/addons-source","private":false,"owner":{"login":"gramps-project","id":10428818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI4ODE4","avatar_url":"https://avatars1.githubusercontent.com/u/10428818?v=4","gravatar_id":"","url":"https://api.github.com/users/gramps-project","html_url":"https://github.com/gramps-project","followers_url":"https://api.github.com/users/gramps-project/followers","following_url":"https://api.github.com/users/gramps-project/following{/other_user}","gists_url":"https://api.github.com/users/gramps-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gramps-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramps-project/subscriptions","organizations_url":"https://api.github.com/users/gramps-project/orgs","repos_url":"https://api.github.com/users/gramps-project/repos","events_url":"https://api.github.com/users/gramps-project/events{/privacy}","received_events_url":"https://api.github.com/users/gramps-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gramps-project/addons-source","description":"Contributed 3rd party plugins for Gramps","fork":false,"url":"https://api.github.com/repos/gramps-project/addons-source","forks_url":"https://api.github.com/repos/gramps-project/addons-source/forks","keys_url":"https://api.github.com/repos/gramps-project/addons-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gramps-project/addons-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gramps-project/addons-source/teams","hooks_url":"https://api.github.com/repos/gramps-project/addons-source/hooks","issue_events_url":"https://api.github.com/repos/gramps-project/addons-source/issues/events{/number}","events_url":"https://api.github.com/repos/gramps-project/addons-source/events","assignees_url":"https://api.github.com/repos/gramps-project/addons-source/assignees{/user}","branches_url":"https://api.github.com/repos/gramps-project/addons-source/branches{/branch}","tags_url":"https://api.github.com/repos/gramps-project/addons-source/tags","blobs_url":"https://api.github.com/repos/gramps-project/addons-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gramps-project/addons-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gramps-project/addons-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/gramps-project/addons-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gramps-project/addons-source/statuses/{sha}","languages_url":"https://api.github.com/repos/gramps-project/addons-source/languages","stargazers_url":"https://api.github.com/repos/gramps-project/addons-source/stargazers","contributors_url":"https://api.github.com/repos/gramps-project/addons-source/contributors","subscribers_url":"https://api.github.com/repos/gramps-project/addons-source/subscribers","subscription_url":"https://api.github.com/repos/gramps-project/addons-source/subscription","commits_url":"https://api.github.com/repos/gramps-project/addons-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/gramps-project/addons-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/gramps-project/addons-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/gramps-project/addons-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/gramps-project/addons-source/contents/{+path}","compare_url":"https://api.github.com/repos/gramps-project/addons-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gramps-project/addons-source/merges","archive_url":"https://api.github.com/repos/gramps-project/addons-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gramps-project/addons-source/downloads","issues_url":"https://api.github.com/repos/gramps-project/addons-source/issues{/number}","pulls_url":"https://api.github.com/repos/gramps-project/addons-source/pulls{/number}","milestones_url":"https://api.github.com/repos/gramps-project/addons-source/milestones{/number}","notifications_url":"https://api.github.com/repos/gramps-project/addons-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gramps-project/addons-source/labels{/name}","releases_url":"https://api.github.com/repos/gramps-project/addons-source/releases{/id}","deployments_url":"https://api.github.com/repos/gramps-project/addons-source/deployments","created_at":"2015-05-14T18:17:01Z","updated_at":"2018-09-14T08:47:10Z","pushed_at":"2018-10-07T14:00:24Z","git_url":"git://github.com/gramps-project/addons-source.git","ssh_url":"git@github.com:gramps-project/addons-source.git","clone_url":"https://github.com/gramps-project/addons-source.git","svn_url":"https://github.com/gramps-project/addons-source","homepage":"https://gramps-project.org/wiki/index.php?title=Addons_development","size":61692,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":41,"open_issues":13,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gramps-project/addons-source/pulls/168"},"html":{"href":"https://github.com/gramps-project/addons-source/pull/168"},"issue":{"href":"https://api.github.com/repos/gramps-project/addons-source/issues/168"},"comments":{"href":"https://api.github.com/repos/gramps-project/addons-source/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/gramps-project/addons-source/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/gramps-project/addons-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gramps-project/addons-source/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/gramps-project/addons-source/statuses/9611bb4a981e581dda57bb14d1d30823cd266b2d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"prculley"}}