{"action":"opened","number":3052,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3052","id":174506998,"html_url":"https://github.com/codice/ddf/pull/3052","diff_url":"https://github.com/codice/ddf/pull/3052.diff","patch_url":"https://github.com/codice/ddf/pull/3052.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3052","number":3052,"state":"open","locked":false,"title":"DDF-3664 Replacing Google Font in bootswatch themes with hosted fonts","user":{"login":"BernardIgiri","id":9195522,"avatar_url":"https://avatars3.githubusercontent.com/u/9195522?v=4","gravatar_id":"","url":"https://api.github.com/users/BernardIgiri","html_url":"https://github.com/BernardIgiri","followers_url":"https://api.github.com/users/BernardIgiri/followers","following_url":"https://api.github.com/users/BernardIgiri/following{/other_user}","gists_url":"https://api.github.com/users/BernardIgiri/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardIgiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardIgiri/subscriptions","organizations_url":"https://api.github.com/users/BernardIgiri/orgs","repos_url":"https://api.github.com/users/BernardIgiri/repos","events_url":"https://api.github.com/users/BernardIgiri/events{/privacy}","received_events_url":"https://api.github.com/users/BernardIgiri/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nCreates a ddf-theme module that overrides the external font url to replace that with hosted font css and font files. The ddf-theme module uses SASS to generate the CSS for the bootswatch themes using the SCSS files from bootswatch and bootstrap-sass, as well as CSS taken from the Google fonts, and the Google font files.\r\n#### Who is reviewing it? \r\n@ahoffer @GabrielFabian \r\n#### Select relevant component teams: \r\n@codice/ui\r\n#### Choose 2 committers to review/merge the PR. \r\n@bdeining\r\n@jlcsmith \r\n#### How should this be tested?\r\n\r\nTo test this you should install DDF in experimental/development mode.\r\n\r\nAll of the following URL's should render correct css:\r\nhttps://localhost:8993/admin/metrics\r\nhttps://localhost:8993/admin/certificate\r\nhttps://localhost:8993/admin\r\nhttps://localhost:8993/admin/sources\r\nhttps://localhost:8993/admin/geowebcache\r\nhttps://localhost:8993/error\r\nhttps://localhost:8993/admin/registry/local\r\nhttps://localhost:8993/admin/registry/remote\r\nhttps://localhost:8993/admin/queries\r\nhttps://localhost:8993/admin/data-usage\r\nhttps://localhost:8993/login\r\nhttps://localhost:8993/idp\r\nhttps://localhost:8993/logout\r\nhttps://localhost:8993/admin/spatial-config\r\nhttps://localhost:8993/search/standard\r\n\r\nAdditionally all of the following css files should be accessible:\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/error/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/error/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/error/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/idp/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/idp/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/idp/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/login/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/login/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/login/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/logout/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/logout/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/logout/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-flatly.css\r\n\r\n#### Any background context you want to provide?\r\n\r\nChanges in the ddf-theme module should affect the CSS for every part of the app that was using bootswatch themes before. This means upgrading the bootswatch theme should also be easier.\r\n\r\n#### What are the relevant tickets?\r\n[](https://codice.atlassian.net/browse/)\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-03-12T22:01:13Z","updated_at":"2018-03-12T22:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3052/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3052/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3052/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/1bc3ec2c748f2723ed2d322b5bd895803b84af8c","head":{"label":"BernardIgiri:master","ref":"master","sha":"1bc3ec2c748f2723ed2d322b5bd895803b84af8c","user":{"login":"BernardIgiri","id":9195522,"avatar_url":"https://avatars3.githubusercontent.com/u/9195522?v=4","gravatar_id":"","url":"https://api.github.com/users/BernardIgiri","html_url":"https://github.com/BernardIgiri","followers_url":"https://api.github.com/users/BernardIgiri/followers","following_url":"https://api.github.com/users/BernardIgiri/following{/other_user}","gists_url":"https://api.github.com/users/BernardIgiri/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardIgiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardIgiri/subscriptions","organizations_url":"https://api.github.com/users/BernardIgiri/orgs","repos_url":"https://api.github.com/users/BernardIgiri/repos","events_url":"https://api.github.com/users/BernardIgiri/events{/privacy}","received_events_url":"https://api.github.com/users/BernardIgiri/received_events","type":"User","site_admin":false},"repo":{"id":123493639,"name":"ddf","full_name":"BernardIgiri/ddf","owner":{"login":"BernardIgiri","id":9195522,"avatar_url":"https://avatars3.githubusercontent.com/u/9195522?v=4","gravatar_id":"","url":"https://api.github.com/users/BernardIgiri","html_url":"https://github.com/BernardIgiri","followers_url":"https://api.github.com/users/BernardIgiri/followers","following_url":"https://api.github.com/users/BernardIgiri/following{/other_user}","gists_url":"https://api.github.com/users/BernardIgiri/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardIgiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardIgiri/subscriptions","organizations_url":"https://api.github.com/users/BernardIgiri/orgs","repos_url":"https://api.github.com/users/BernardIgiri/repos","events_url":"https://api.github.com/users/BernardIgiri/events{/privacy}","received_events_url":"https://api.github.com/users/BernardIgiri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BernardIgiri/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/BernardIgiri/ddf","forks_url":"https://api.github.com/repos/BernardIgiri/ddf/forks","keys_url":"https://api.github.com/repos/BernardIgiri/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BernardIgiri/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BernardIgiri/ddf/teams","hooks_url":"https://api.github.com/repos/BernardIgiri/ddf/hooks","issue_events_url":"https://api.github.com/repos/BernardIgiri/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/BernardIgiri/ddf/events","assignees_url":"https://api.github.com/repos/BernardIgiri/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/BernardIgiri/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/BernardIgiri/ddf/tags","blobs_url":"https://api.github.com/repos/BernardIgiri/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BernardIgiri/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BernardIgiri/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/BernardIgiri/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BernardIgiri/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/BernardIgiri/ddf/languages","stargazers_url":"https://api.github.com/repos/BernardIgiri/ddf/stargazers","contributors_url":"https://api.github.com/repos/BernardIgiri/ddf/contributors","subscribers_url":"https://api.github.com/repos/BernardIgiri/ddf/subscribers","subscription_url":"https://api.github.com/repos/BernardIgiri/ddf/subscription","commits_url":"https://api.github.com/repos/BernardIgiri/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/BernardIgiri/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/BernardIgiri/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/BernardIgiri/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/BernardIgiri/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/BernardIgiri/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BernardIgiri/ddf/merges","archive_url":"https://api.github.com/repos/BernardIgiri/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BernardIgiri/ddf/downloads","issues_url":"https://api.github.com/repos/BernardIgiri/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/BernardIgiri/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/BernardIgiri/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/BernardIgiri/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BernardIgiri/ddf/labels{/name}","releases_url":"https://api.github.com/repos/BernardIgiri/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/BernardIgiri/ddf/deployments","created_at":"2018-03-01T21:19:42Z","updated_at":"2018-03-05T16:09:38Z","pushed_at":"2018-03-12T20:43:56Z","git_url":"git://github.com/BernardIgiri/ddf.git","ssh_url":"git@github.com:BernardIgiri/ddf.git","clone_url":"https://github.com/BernardIgiri/ddf.git","svn_url":"https://github.com/BernardIgiri/ddf","homepage":"http://ddf.codice.org","size":384034,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"93f2d1fc93ca3ef7e712ae3fb273f828f04e320c","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-03-12T14:11:06Z","pushed_at":"2018-03-12T21:51:57Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":386297,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":134,"open_issues":37,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3052"},"html":{"href":"https://github.com/codice/ddf/pull/3052"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3052"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3052/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3052/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3052/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/1bc3ec2c748f2723ed2d322b5bd895803b84af8c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":12,"additions":7594,"deletions":882,"changed_files":136}}
{"actor":{"display_login":"BernardIgiri"}}