{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10","id":193017973,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDE3OTcz","html_url":"https://github.com/starkwang/vue-virtual-collection/pull/10","diff_url":"https://github.com/starkwang/vue-virtual-collection/pull/10.diff","patch_url":"https://github.com/starkwang/vue-virtual-collection/pull/10.patch","issue_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/10","number":10,"state":"closed","locked":false,"title":"Safe destructuring of cell returned by section manager in getComputedStyle","user":{"login":"TAGC","id":1588951,"node_id":"MDQ6VXNlcjE1ODg5NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1588951?v=4","gravatar_id":"","url":"https://api.github.com/users/TAGC","html_url":"https://github.com/TAGC","followers_url":"https://api.github.com/users/TAGC/followers","following_url":"https://api.github.com/users/TAGC/following{/other_user}","gists_url":"https://api.github.com/users/TAGC/gists{/gist_id}","starred_url":"https://api.github.com/users/TAGC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TAGC/subscriptions","organizations_url":"https://api.github.com/users/TAGC/orgs","repos_url":"https://api.github.com/users/TAGC/repos","events_url":"https://api.github.com/users/TAGC/events{/privacy}","received_events_url":"https://api.github.com/users/TAGC/received_events","type":"User","site_admin":false},"body":"Resolves #9.\r\n\r\nChecks that a cell exists in the section manager corresponding to a display item before trying to destructure it. This is necessary because it seems that the `displayItems` collection lags behind the cells registered to the section manager when you remove items from the collection. This causes a stream of errors relating to out-of-bounds array access to appear in the console if you're constantly removing items.\r\n\r\nI wasn't sure if it would be possible to add a unit test for this. However, all existing unit tests continue to pass with these changes, and I've been able to verify that it resolves the issue by sym-linking the version of this library with my changes into the project where I observed it.","created_at":"2018-06-06T13:42:58Z","updated_at":"2018-06-07T13:28:58Z","closed_at":"2018-06-07T13:28:57Z","merged_at":"2018-06-07T13:28:57Z","merge_commit_sha":"0f0dc60f5f7c6656c3832c0e942fb035925bd85a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10/commits","review_comments_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10/comments","review_comment_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/10/comments","statuses_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/statuses/588552577413e4209f2dcfd003228646035180b0","head":{"label":"TAGC:patch/9","ref":"patch/9","sha":"588552577413e4209f2dcfd003228646035180b0","user":{"login":"TAGC","id":1588951,"node_id":"MDQ6VXNlcjE1ODg5NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1588951?v=4","gravatar_id":"","url":"https://api.github.com/users/TAGC","html_url":"https://github.com/TAGC","followers_url":"https://api.github.com/users/TAGC/followers","following_url":"https://api.github.com/users/TAGC/following{/other_user}","gists_url":"https://api.github.com/users/TAGC/gists{/gist_id}","starred_url":"https://api.github.com/users/TAGC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TAGC/subscriptions","organizations_url":"https://api.github.com/users/TAGC/orgs","repos_url":"https://api.github.com/users/TAGC/repos","events_url":"https://api.github.com/users/TAGC/events{/privacy}","received_events_url":"https://api.github.com/users/TAGC/received_events","type":"User","site_admin":false},"repo":{"id":136329685,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMjk2ODU=","name":"vue-virtual-collection","full_name":"TAGC/vue-virtual-collection","owner":{"login":"TAGC","id":1588951,"node_id":"MDQ6VXNlcjE1ODg5NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1588951?v=4","gravatar_id":"","url":"https://api.github.com/users/TAGC","html_url":"https://github.com/TAGC","followers_url":"https://api.github.com/users/TAGC/followers","following_url":"https://api.github.com/users/TAGC/following{/other_user}","gists_url":"https://api.github.com/users/TAGC/gists{/gist_id}","starred_url":"https://api.github.com/users/TAGC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TAGC/subscriptions","organizations_url":"https://api.github.com/users/TAGC/orgs","repos_url":"https://api.github.com/users/TAGC/repos","events_url":"https://api.github.com/users/TAGC/events{/privacy}","received_events_url":"https://api.github.com/users/TAGC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TAGC/vue-virtual-collection","description":"Vue component for efficiently rendering large collection data","fork":true,"url":"https://api.github.com/repos/TAGC/vue-virtual-collection","forks_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/forks","keys_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/teams","hooks_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/hooks","issue_events_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/issues/events{/number}","events_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/events","assignees_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/assignees{/user}","branches_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/branches{/branch}","tags_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/tags","blobs_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/languages","stargazers_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/stargazers","contributors_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/contributors","subscribers_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/subscribers","subscription_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/subscription","commits_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/contents/{+path}","compare_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/merges","archive_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/downloads","issues_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/issues{/number}","pulls_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/labels{/name}","releases_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/releases{/id}","deployments_url":"https://api.github.com/repos/TAGC/vue-virtual-collection/deployments","created_at":"2018-06-06T13:04:15Z","updated_at":"2018-06-06T13:04:17Z","pushed_at":"2018-06-06T13:35:16Z","git_url":"git://github.com/TAGC/vue-virtual-collection.git","ssh_url":"git@github.com:TAGC/vue-virtual-collection.git","clone_url":"https://github.com/TAGC/vue-virtual-collection.git","svn_url":"https://github.com/TAGC/vue-virtual-collection","homepage":"https://starkwang.github.io/vue-virtual-collection/demo/dist/index.html","size":374,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"starkwang:master","ref":"master","sha":"54911c06274f038a9f3594c74ca9a45b20bc9738","user":{"login":"starkwang","id":10933333,"node_id":"MDQ6VXNlcjEwOTMzMzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10933333?v=4","gravatar_id":"","url":"https://api.github.com/users/starkwang","html_url":"https://github.com/starkwang","followers_url":"https://api.github.com/users/starkwang/followers","following_url":"https://api.github.com/users/starkwang/following{/other_user}","gists_url":"https://api.github.com/users/starkwang/gists{/gist_id}","starred_url":"https://api.github.com/users/starkwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkwang/subscriptions","organizations_url":"https://api.github.com/users/starkwang/orgs","repos_url":"https://api.github.com/users/starkwang/repos","events_url":"https://api.github.com/users/starkwang/events{/privacy}","received_events_url":"https://api.github.com/users/starkwang/received_events","type":"User","site_admin":false},"repo":{"id":121747014,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NDcwMTQ=","name":"vue-virtual-collection","full_name":"starkwang/vue-virtual-collection","owner":{"login":"starkwang","id":10933333,"node_id":"MDQ6VXNlcjEwOTMzMzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10933333?v=4","gravatar_id":"","url":"https://api.github.com/users/starkwang","html_url":"https://github.com/starkwang","followers_url":"https://api.github.com/users/starkwang/followers","following_url":"https://api.github.com/users/starkwang/following{/other_user}","gists_url":"https://api.github.com/users/starkwang/gists{/gist_id}","starred_url":"https://api.github.com/users/starkwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkwang/subscriptions","organizations_url":"https://api.github.com/users/starkwang/orgs","repos_url":"https://api.github.com/users/starkwang/repos","events_url":"https://api.github.com/users/starkwang/events{/privacy}","received_events_url":"https://api.github.com/users/starkwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/starkwang/vue-virtual-collection","description":"Vue component for efficiently rendering large collection data","fork":false,"url":"https://api.github.com/repos/starkwang/vue-virtual-collection","forks_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/forks","keys_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/teams","hooks_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/hooks","issue_events_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/events{/number}","events_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/events","assignees_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/assignees{/user}","branches_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/branches{/branch}","tags_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/tags","blobs_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/languages","stargazers_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/stargazers","contributors_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/contributors","subscribers_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/subscribers","subscription_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/subscription","commits_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/contents/{+path}","compare_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/merges","archive_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/downloads","issues_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues{/number}","pulls_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/labels{/name}","releases_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/releases{/id}","deployments_url":"https://api.github.com/repos/starkwang/vue-virtual-collection/deployments","created_at":"2018-02-16T12:12:32Z","updated_at":"2018-06-06T02:11:18Z","pushed_at":"2018-06-07T13:28:57Z","git_url":"git://github.com/starkwang/vue-virtual-collection.git","ssh_url":"git@github.com:starkwang/vue-virtual-collection.git","clone_url":"https://github.com/starkwang/vue-virtual-collection.git","svn_url":"https://github.com/starkwang/vue-virtual-collection","homepage":"https://starkwang.github.io/vue-virtual-collection/demo/dist/index.html","size":374,"stargazers_count":190,"watchers_count":190,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":0,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10"},"html":{"href":"https://github.com/starkwang/vue-virtual-collection/pull/10"},"issue":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/10"},"comments":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/starkwang/vue-virtual-collection/statuses/588552577413e4209f2dcfd003228646035180b0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"starkwang","id":10933333,"node_id":"MDQ6VXNlcjEwOTMzMzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10933333?v=4","gravatar_id":"","url":"https://api.github.com/users/starkwang","html_url":"https://github.com/starkwang","followers_url":"https://api.github.com/users/starkwang/followers","following_url":"https://api.github.com/users/starkwang/following{/other_user}","gists_url":"https://api.github.com/users/starkwang/gists{/gist_id}","starred_url":"https://api.github.com/users/starkwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkwang/subscriptions","organizations_url":"https://api.github.com/users/starkwang/orgs","repos_url":"https://api.github.com/users/starkwang/repos","events_url":"https://api.github.com/users/starkwang/events{/privacy}","received_events_url":"https://api.github.com/users/starkwang/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"starkwang"}}