{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/165403667","pull_request_review_id":93337657,"id":165403667,"diff_hunk":"@@ -47,19 +47,22 @@ export class Form<Model> {\n \n   @ValidateNested()\n   model: Model\n+  rawData: object\n   errors: FormValidationError[]\n \n   /**\n    * @param model - a object used to fill the form\n+   * @param rawData - a raw data used to create model instance\n    * @param errors - an array of error objects\n    */\n-  constructor (model: Model, errors: ValidationError[] = []) {\n+  constructor (model: Model, rawData: object = undefined, errors: ValidationError[] = []) {","path":"src/main/app/forms/form.ts","position":13,"original_position":13,"commit_id":"513caf6819326c81ac255b51abcb97848aa59e3a","original_commit_id":"513caf6819326c81ac255b51abcb97848aa59e3a","user":{"login":"rlewan","id":1095386,"avatar_url":"https://avatars0.githubusercontent.com/u/1095386?v=4","gravatar_id":"","url":"https://api.github.com/users/rlewan","html_url":"https://github.com/rlewan","followers_url":"https://api.github.com/users/rlewan/followers","following_url":"https://api.github.com/users/rlewan/following{/other_user}","gists_url":"https://api.github.com/users/rlewan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlewan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlewan/subscriptions","organizations_url":"https://api.github.com/users/rlewan/orgs","repos_url":"https://api.github.com/users/rlewan/repos","events_url":"https://api.github.com/users/rlewan/events{/privacy}","received_events_url":"https://api.github.com/users/rlewan/received_events","type":"User","site_admin":false},"body":"If you added the new parameter after existing ones then you wouldn't need to assign default value to `rawData`, it would be `undefined` by default if not provided. An additional example of such approach is that you're sure you don't break any existing calls. Please change this.","created_at":"2018-02-01T16:08:38Z","updated_at":"2018-02-01T16:08:38Z","html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/355#discussion_r165403667","pull_request_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/165403667"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/355#discussion_r165403667"},"pull_request":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355","id":166272142,"html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/355","diff_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/355.diff","patch_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/355.patch","issue_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/355","number":355,"state":"open","locked":false,"title":"ROC-2016 Deserialize number having comma","user":{"login":"dharmendrak","id":581234,"avatar_url":"https://avatars2.githubusercontent.com/u/581234?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmendrak","html_url":"https://github.com/dharmendrak","followers_url":"https://api.github.com/users/dharmendrak/followers","following_url":"https://api.github.com/users/dharmendrak/following{/other_user}","gists_url":"https://api.github.com/users/dharmendrak/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmendrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmendrak/subscriptions","organizations_url":"https://api.github.com/users/dharmendrak/orgs","repos_url":"https://api.github.com/users/dharmendrak/repos","events_url":"https://api.github.com/users/dharmendrak/events{/privacy}","received_events_url":"https://api.github.com/users/dharmendrak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-31T14:20:26Z","updated_at":"2018-02-01T16:08:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91f336578840d9de2a286ea628bd1ac56f78c366","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355/commits","review_comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355/comments","review_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/355/comments","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/513caf6819326c81ac255b51abcb97848aa59e3a","head":{"label":"hmcts:feature/ROC-2016-Deserialize-number-having-comma","ref":"feature/ROC-2016-Deserialize-number-having-comma","sha":"513caf6819326c81ac255b51abcb97848aa59e3a","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Citizen frontend application for Civil Money Claims","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-11-05T14:28:24Z","pushed_at":"2018-02-01T16:03:21Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":2083,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"b37356bfa5c3b8d6d76c4cfbe3eb910b041d433c","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Citizen frontend application for Civil Money Claims","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-11-05T14:28:24Z","pushed_at":"2018-02-01T16:03:21Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":2083,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/355"},"issue":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/355"},"comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/513caf6819326c81ac255b51abcb97848aa59e3a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rlewan"}}