{"action":"created","comment":{"url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/comments/207760546","pull_request_review_id":143436254,"id":207760546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzc2MDU0Ng==","diff_hunk":"@@ -36,29 +36,12 @@ namespace enigma\n   void graphicssystem_initialize()\n   {\n     //enigma::pbo_isgo=GL_ARB_pixel_buffer_object;\n-    glMatrixMode(GL_PROJECTION);\n-    glClearColor(0,0,0,0);\n-    glMatrixMode(GL_MODELVIEW);\n-    glLoadIdentity();\n-\n-    using enigma_user::room_width;\n-    using enigma_user::room_height;\n-    glViewport(0,0,(int)room_width,(int)room_height);\n-    glOrtho(-1,(int)room_width,-1,(int)room_height,0,1);\n-    glClear (GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n-\n-    glDisable(GL_DEPTH_TEST);\n-    glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n \n     glEnable(GL_BLEND);\n-    glEnable(GL_ALPHA_TEST);","path":"ENIGMAsystem/SHELL/Graphics_Systems/OpenGL1/OPENGLStd.cpp","position":19,"original_position":19,"commit_id":"30bf4141ec8f648f4710995426b35b2619b881de","original_commit_id":"30bf4141ec8f648f4710995426b35b2619b881de","user":{"login":"JoshDreamland","id":164340,"node_id":"MDQ6VXNlcjE2NDM0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/164340?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshDreamland","html_url":"https://github.com/JoshDreamland","followers_url":"https://api.github.com/users/JoshDreamland/followers","following_url":"https://api.github.com/users/JoshDreamland/following{/other_user}","gists_url":"https://api.github.com/users/JoshDreamland/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshDreamland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshDreamland/subscriptions","organizations_url":"https://api.github.com/users/JoshDreamland/orgs","repos_url":"https://api.github.com/users/JoshDreamland/repos","events_url":"https://api.github.com/users/JoshDreamland/events{/privacy}","received_events_url":"https://api.github.com/users/JoshDreamland/received_events","type":"User","site_admin":false},"body":"I would leave this here until the other routines are also re-homed. I don't mind encapsulating these more granularly, but I think `graphicssystem_initialize()` is a pretty good encapsulation, as-is.","created_at":"2018-08-06T02:08:58Z","updated_at":"2018-08-06T02:12:10Z","html_url":"https://github.com/enigma-dev/enigma-dev/pull/1348#discussion_r207760546","pull_request_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/comments/207760546"},"html":{"href":"https://github.com/enigma-dev/enigma-dev/pull/1348#discussion_r207760546"},"pull_request":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348"}}},"pull_request":{"url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348","id":205421631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDIxNjMx","html_url":"https://github.com/enigma-dev/enigma-dev/pull/1348","diff_url":"https://github.com/enigma-dev/enigma-dev/pull/1348.diff","patch_url":"https://github.com/enigma-dev/enigma-dev/pull/1348.patch","issue_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/1348","number":1348,"state":"open","locked":false,"title":"Screen Initialization Cleanup","user":{"login":"RobertBColton","id":3212801,"node_id":"MDQ6VXNlcjMyMTI4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3212801?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertBColton","html_url":"https://github.com/RobertBColton","followers_url":"https://api.github.com/users/RobertBColton/followers","following_url":"https://api.github.com/users/RobertBColton/following{/other_user}","gists_url":"https://api.github.com/users/RobertBColton/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertBColton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertBColton/subscriptions","organizations_url":"https://api.github.com/users/RobertBColton/orgs","repos_url":"https://api.github.com/users/RobertBColton/repos","events_url":"https://api.github.com/users/RobertBColton/events{/privacy}","received_events_url":"https://api.github.com/users/RobertBColton/received_events","type":"User","site_admin":false},"body":"WIP\r\n\r\nThis pull request addresses issue #1337 and moves `screen_init` as well as `display_set_gui_size` to the general graphics folder.\r\n\r\nOne major issue this pull request addresses is that drawing color and alpha should **NOT** be reset when switching rooms as I tested in both GM8 and GMS.\r\nDownload: [render-state-room-transition-test.zip](https://github.com/enigma-dev/enigma-dev/files/2257383/render-state-room-transition-test.zip)\r\n\r\n* All `screen_init` implementations were deleted and I made a single one in `General/`\r\n* I separated `screen_init_state` out of `screen_init` as a secondary user function.\r\n    * `screen_init_state` initializes all of the default render state (e.g, drawing color/alpha) that applies to all generic graphics during startup just after `graphicssystem_initialize`\r\n    * `screen_init` resets the projections/viewports and clears the room background color for all generic graphics and is intended to be called during room transition\r\n\r\n","created_at":"2018-08-01T13:16:17Z","updated_at":"2018-08-06T02:12:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dcb0e36f61f73dd3ff67f277616989bfbc79c94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":41479976,"node_id":"MDU6TGFiZWw0MTQ3OTk3Ng==","url":"https://api.github.com/repos/enigma-dev/enigma-dev/labels/Graphics","name":"Graphics","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348/commits","review_comments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348/comments","review_comment_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/1348/comments","statuses_url":"https://api.github.com/repos/enigma-dev/enigma-dev/statuses/30bf4141ec8f648f4710995426b35b2619b881de","head":{"label":"enigma-dev:screen_init-deduplicate","ref":"screen_init-deduplicate","sha":"30bf4141ec8f648f4710995426b35b2619b881de","user":{"login":"enigma-dev","id":332607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjYwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/332607?v=4","gravatar_id":"","url":"https://api.github.com/users/enigma-dev","html_url":"https://github.com/enigma-dev","followers_url":"https://api.github.com/users/enigma-dev/followers","following_url":"https://api.github.com/users/enigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/enigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/enigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enigma-dev/subscriptions","organizations_url":"https://api.github.com/users/enigma-dev/orgs","repos_url":"https://api.github.com/users/enigma-dev/repos","events_url":"https://api.github.com/users/enigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/enigma-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":3319723,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE5NzIz","name":"enigma-dev","full_name":"enigma-dev/enigma-dev","owner":{"login":"enigma-dev","id":332607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjYwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/332607?v=4","gravatar_id":"","url":"https://api.github.com/users/enigma-dev","html_url":"https://github.com/enigma-dev","followers_url":"https://api.github.com/users/enigma-dev/followers","following_url":"https://api.github.com/users/enigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/enigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/enigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enigma-dev/subscriptions","organizations_url":"https://api.github.com/users/enigma-dev/orgs","repos_url":"https://api.github.com/users/enigma-dev/repos","events_url":"https://api.github.com/users/enigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/enigma-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enigma-dev/enigma-dev","description":"The Extensible Non-Interpreted Game Maker Augmentation.","fork":false,"url":"https://api.github.com/repos/enigma-dev/enigma-dev","forks_url":"https://api.github.com/repos/enigma-dev/enigma-dev/forks","keys_url":"https://api.github.com/repos/enigma-dev/enigma-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enigma-dev/enigma-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enigma-dev/enigma-dev/teams","hooks_url":"https://api.github.com/repos/enigma-dev/enigma-dev/hooks","issue_events_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/events{/number}","events_url":"https://api.github.com/repos/enigma-dev/enigma-dev/events","assignees_url":"https://api.github.com/repos/enigma-dev/enigma-dev/assignees{/user}","branches_url":"https://api.github.com/repos/enigma-dev/enigma-dev/branches{/branch}","tags_url":"https://api.github.com/repos/enigma-dev/enigma-dev/tags","blobs_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enigma-dev/enigma-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/enigma-dev/enigma-dev/languages","stargazers_url":"https://api.github.com/repos/enigma-dev/enigma-dev/stargazers","contributors_url":"https://api.github.com/repos/enigma-dev/enigma-dev/contributors","subscribers_url":"https://api.github.com/repos/enigma-dev/enigma-dev/subscribers","subscription_url":"https://api.github.com/repos/enigma-dev/enigma-dev/subscription","commits_url":"https://api.github.com/repos/enigma-dev/enigma-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/enigma-dev/enigma-dev/contents/{+path}","compare_url":"https://api.github.com/repos/enigma-dev/enigma-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enigma-dev/enigma-dev/merges","archive_url":"https://api.github.com/repos/enigma-dev/enigma-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enigma-dev/enigma-dev/downloads","issues_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues{/number}","pulls_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/enigma-dev/enigma-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/enigma-dev/enigma-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enigma-dev/enigma-dev/labels{/name}","releases_url":"https://api.github.com/repos/enigma-dev/enigma-dev/releases{/id}","deployments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/deployments","created_at":"2012-01-31T22:51:53Z","updated_at":"2018-08-06T00:17:01Z","pushed_at":"2018-08-06T00:17:04Z","git_url":"git://github.com/enigma-dev/enigma-dev.git","ssh_url":"git@github.com:enigma-dev/enigma-dev.git","clone_url":"https://github.com/enigma-dev/enigma-dev.git","svn_url":"https://github.com/enigma-dev/enigma-dev","homepage":"http://enigma-dev.org","size":57615,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":114,"license":null,"forks":70,"open_issues":114,"watchers":118,"default_branch":"master"}},"base":{"label":"enigma-dev:master","ref":"master","sha":"1317935e5c41efbb656bd2fe0776e6ec836f3199","user":{"login":"enigma-dev","id":332607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjYwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/332607?v=4","gravatar_id":"","url":"https://api.github.com/users/enigma-dev","html_url":"https://github.com/enigma-dev","followers_url":"https://api.github.com/users/enigma-dev/followers","following_url":"https://api.github.com/users/enigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/enigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/enigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enigma-dev/subscriptions","organizations_url":"https://api.github.com/users/enigma-dev/orgs","repos_url":"https://api.github.com/users/enigma-dev/repos","events_url":"https://api.github.com/users/enigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/enigma-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":3319723,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE5NzIz","name":"enigma-dev","full_name":"enigma-dev/enigma-dev","owner":{"login":"enigma-dev","id":332607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjYwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/332607?v=4","gravatar_id":"","url":"https://api.github.com/users/enigma-dev","html_url":"https://github.com/enigma-dev","followers_url":"https://api.github.com/users/enigma-dev/followers","following_url":"https://api.github.com/users/enigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/enigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/enigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enigma-dev/subscriptions","organizations_url":"https://api.github.com/users/enigma-dev/orgs","repos_url":"https://api.github.com/users/enigma-dev/repos","events_url":"https://api.github.com/users/enigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/enigma-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enigma-dev/enigma-dev","description":"The Extensible Non-Interpreted Game Maker Augmentation.","fork":false,"url":"https://api.github.com/repos/enigma-dev/enigma-dev","forks_url":"https://api.github.com/repos/enigma-dev/enigma-dev/forks","keys_url":"https://api.github.com/repos/enigma-dev/enigma-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enigma-dev/enigma-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enigma-dev/enigma-dev/teams","hooks_url":"https://api.github.com/repos/enigma-dev/enigma-dev/hooks","issue_events_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/events{/number}","events_url":"https://api.github.com/repos/enigma-dev/enigma-dev/events","assignees_url":"https://api.github.com/repos/enigma-dev/enigma-dev/assignees{/user}","branches_url":"https://api.github.com/repos/enigma-dev/enigma-dev/branches{/branch}","tags_url":"https://api.github.com/repos/enigma-dev/enigma-dev/tags","blobs_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enigma-dev/enigma-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/enigma-dev/enigma-dev/languages","stargazers_url":"https://api.github.com/repos/enigma-dev/enigma-dev/stargazers","contributors_url":"https://api.github.com/repos/enigma-dev/enigma-dev/contributors","subscribers_url":"https://api.github.com/repos/enigma-dev/enigma-dev/subscribers","subscription_url":"https://api.github.com/repos/enigma-dev/enigma-dev/subscription","commits_url":"https://api.github.com/repos/enigma-dev/enigma-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/enigma-dev/enigma-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/enigma-dev/enigma-dev/contents/{+path}","compare_url":"https://api.github.com/repos/enigma-dev/enigma-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enigma-dev/enigma-dev/merges","archive_url":"https://api.github.com/repos/enigma-dev/enigma-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enigma-dev/enigma-dev/downloads","issues_url":"https://api.github.com/repos/enigma-dev/enigma-dev/issues{/number}","pulls_url":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/enigma-dev/enigma-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/enigma-dev/enigma-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enigma-dev/enigma-dev/labels{/name}","releases_url":"https://api.github.com/repos/enigma-dev/enigma-dev/releases{/id}","deployments_url":"https://api.github.com/repos/enigma-dev/enigma-dev/deployments","created_at":"2012-01-31T22:51:53Z","updated_at":"2018-08-06T00:17:01Z","pushed_at":"2018-08-06T00:17:04Z","git_url":"git://github.com/enigma-dev/enigma-dev.git","ssh_url":"git@github.com:enigma-dev/enigma-dev.git","clone_url":"https://github.com/enigma-dev/enigma-dev.git","svn_url":"https://github.com/enigma-dev/enigma-dev","homepage":"http://enigma-dev.org","size":57615,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":114,"license":null,"forks":70,"open_issues":114,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348"},"html":{"href":"https://github.com/enigma-dev/enigma-dev/pull/1348"},"issue":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/1348"},"comments":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/issues/1348/comments"},"review_comments":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348/comments"},"review_comment":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/pulls/1348/commits"},"statuses":{"href":"https://api.github.com/repos/enigma-dev/enigma-dev/statuses/30bf4141ec8f648f4710995426b35b2619b881de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JoshDreamland"}}