{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/1741","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/1741/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1741/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/1741/events","html_url":"https://github.com/opencontainers/runc/pull/1741","id":300070743,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxMjU3MjEy","number":1741,"title":"libcontainer: Set 'status' in hook stdin","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opencontainers/runc/milestones/4","html_url":"https://github.com/opencontainers/runc/milestone/4","labels_url":"https://api.github.com/repos/opencontainers/runc/milestones/4/labels","id":1756705,"node_id":"MDk6TWlsZXN0b25lMTc1NjcwNQ==","number":4,"title":"1.0.0","description":"Final milestone for the runc 1.0.0 Release","creator":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":43,"state":"open","created_at":"2016-05-09T23:22:52Z","updated_at":"2018-11-14T11:50:47Z","due_on":"2017-08-19T07:00:00Z","closed_at":null},"comments":12,"created_at":"2018-02-25T23:05:03Z","updated_at":"2018-11-14T23:40:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1741","html_url":"https://github.com/opencontainers/runc/pull/1741","diff_url":"https://github.com/opencontainers/runc/pull/1741.diff","patch_url":"https://github.com/opencontainers/runc/pull/1741.patch"},"body":"Finish off the work started in #1201 to bring hook stdin into compliance with runtime-spec.\r\n\r\nAlso:\r\n\r\n* Drop `HookState`, since there's no need for a local alias for `specs.State`.\r\n* ~~Add `len` guards to avoid computing the state when `.Hooks` is non-`nil` but the particular phase we're looking at is empty.~~ I had to drop these to satisfy @cyphar [here][4].\r\n* Also set `c.initProcess` in `newInitProcess` to support `OCIState` calls from within `initProcess.start()`.  I think the cyclic references between `linuxContainer` and `initProcess` are unfortunate, but didn't want to address that here.\r\n* I've also left the timing of the `Prestart` hooks alone, although [the spec calls for them to happen before start][1] (not as part of creation, #1710).  Once the timing gets fixed we can drop the `initProcessStartTime` hacks which `initProcess.start` currently needs.\r\n\r\nI'm not sure why we trigger the prestart hooks in response to both [`procReady`][2] and [`procHooks`][3].  But we've had two prestart rounds in `initProcess.start` since #568.  I've left that alone too.\r\n\r\n[1]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0/config.md#prestart\r\n[2]: https://github.com/opencontainers/runc/blob/b50fa98d9e5ec3ff58028c46767129607067f961/libcontainer/process_linux.go#L343\r\n[3]: https://github.com/opencontainers/runc/blob/b50fa98d9e5ec3ff58028c46767129607067f961/libcontainer/process_linux.go#L374\r\n[4]: https://github.com/opencontainers/runc/pull/1741#discussion_r233331570"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/438860248","html_url":"https://github.com/opencontainers/runc/pull/1741#issuecomment-438860248","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1741","id":438860248,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODg2MDI0OA==","user":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T23:40:35Z","updated_at":"2018-11-14T23:40:35Z","author_association":"MEMBER","body":"I'll wait until @mrunalp checks this before merging."}}
{"actor":{"display_login":"cyphar"}}