{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/kapua/pulls/comments/172800346","pull_request_review_id":101877597,"id":172800346,"diff_hunk":"@@ -161,22 +161,21 @@ public User call() throws Exception {\n             }\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionStatus\", deviceConnection.getStatus().toString()));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionModifiedOn\", deviceConnection.getModifiedOn().toString()));\n-            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionModifiedBy\", modifiledUser.getName()));\n+            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionModifiedBy\", modifiedUser != null ? modifiedUser.getName() : \"N/A\"));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionProtocol\", deviceConnection.getProtocol()));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionClientId\", deviceConnection.getClientId()));\n-            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionUser\", connectionUser.getName()));\n+            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionUser\", connectionUser != null ? connectionUser.getName() : \"N/A\"));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionClientIp\", deviceConnection.getClientIp()));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionServerIp\", deviceConnection.getServerIp()));\n             GwtConnectionUserCouplingMode gwtConnectionUserCouplingMode = null;\n             if (deviceConnection.getUserCouplingMode() != null) {\n                 gwtConnectionUserCouplingMode = GwtConnectionUserCouplingMode.valueOf(deviceConnection.getUserCouplingMode().name());\n             }\n-            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionUserCouplingModeInfo\", \"connectionUserCouplingMode\", gwtConnectionUserCouplingMode.getLabel()));\n-            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionUserCouplingModeInfo\", \"connectionReservedUser\",\n-                    reservedUser != null ? reservedUser.getName() : null));\n+            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionUserCouplingModeInfo\", \"connectionUserCouplingMode\", gwtConnectionUserCouplingMode != null ? gwtConnectionUserCouplingMode.getLabel() : \"N/A\"));\n+            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionUserCouplingModeInfo\", \"connectionReservedUser\", reservedUser != null ? reservedUser.getName() : null));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionUserCouplingModeInfo\", \"allowUserChange\", deviceConnection.getAllowUserChange()));\n             deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionFirstEstablishedOn\", deviceConnection.getCreatedOn()));\n-            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionFirstEstablishedBy\", createdUser.getName()));\n+            deviceConnectionPropertiesPairs.add(new GwtGroupedNVPair(\"connectionInfo\", \"connectionFirstEstablishedBy\", createdUser != null ? createdUser.getName() : \"N/A\"));","path":"console/module/device/src/main/java/org/eclipse/kapua/app/console/module/device/server/GwtDeviceConnectionServiceImpl.java","position":33,"original_position":33,"commit_id":"df78d7380d785de2de3a841a906f703e1ba0404d","original_commit_id":"df78d7380d785de2de3a841a906f703e1ba0404d","user":{"login":"Coduz","id":3942036,"avatar_url":"https://avatars3.githubusercontent.com/u/3942036?v=4","gravatar_id":"","url":"https://api.github.com/users/Coduz","html_url":"https://github.com/Coduz","followers_url":"https://api.github.com/users/Coduz/followers","following_url":"https://api.github.com/users/Coduz/following{/other_user}","gists_url":"https://api.github.com/users/Coduz/gists{/gist_id}","starred_url":"https://api.github.com/users/Coduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coduz/subscriptions","organizations_url":"https://api.github.com/users/Coduz/orgs","repos_url":"https://api.github.com/users/Coduz/repos","events_url":"https://api.github.com/users/Coduz/events{/privacy}","received_events_url":"https://api.github.com/users/Coduz/received_events","type":"User","site_admin":false},"body":"Please use `null`, this is managed by https://github.com/eclipse/kapua/blob/develop/console/module/api/src/main/java/org/eclipse/kapua/app/console/module/api/shared/model/GwtGroupedNVPair.java#L35 automatically","created_at":"2018-03-07T10:35:22Z","updated_at":"2018-03-07T10:36:38Z","html_url":"https://github.com/eclipse/kapua/pull/1486#discussion_r172800346","pull_request_url":"https://api.github.com/repos/eclipse/kapua/pulls/1486","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/comments/172800346"},"html":{"href":"https://github.com/eclipse/kapua/pull/1486#discussion_r172800346"},"pull_request":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/1486"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/kapua/pulls/1486","id":173401268,"html_url":"https://github.com/eclipse/kapua/pull/1486","diff_url":"https://github.com/eclipse/kapua/pull/1486.diff","patch_url":"https://github.com/eclipse/kapua/pull/1486.patch","issue_url":"https://api.github.com/repos/eclipse/kapua/issues/1486","number":1486,"state":"open","locked":false,"title":"Description Tab with null user fix","user":{"login":"lorthirk","id":8140139,"avatar_url":"https://avatars3.githubusercontent.com/u/8140139?v=4","gravatar_id":"","url":"https://api.github.com/users/lorthirk","html_url":"https://github.com/lorthirk","followers_url":"https://api.github.com/users/lorthirk/followers","following_url":"https://api.github.com/users/lorthirk/following{/other_user}","gists_url":"https://api.github.com/users/lorthirk/gists{/gist_id}","starred_url":"https://api.github.com/users/lorthirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorthirk/subscriptions","organizations_url":"https://api.github.com/users/lorthirk/orgs","repos_url":"https://api.github.com/users/lorthirk/repos","events_url":"https://api.github.com/users/lorthirk/events{/privacy}","received_events_url":"https://api.github.com/users/lorthirk/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nThis PR simply guards against NPEs in Description tabs when retrieving and showing Entities that have been created or modified by a User that has been deleted in a later time.\r\n\r\nFixes #1484","created_at":"2018-03-07T09:54:12Z","updated_at":"2018-03-07T10:36:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b2e3be136c36fc1c76f0a401ac6bb22701097fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/kapua/pulls/1486/commits","review_comments_url":"https://api.github.com/repos/eclipse/kapua/pulls/1486/comments","review_comment_url":"https://api.github.com/repos/eclipse/kapua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/kapua/issues/1486/comments","statuses_url":"https://api.github.com/repos/eclipse/kapua/statuses/df78d7380d785de2de3a841a906f703e1ba0404d","head":{"label":"eclipse:fix-unkown_user_description_tab","ref":"fix-unkown_user_description_tab","sha":"df78d7380d785de2de3a841a906f703e1ba0404d","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":70921758,"name":"kapua","full_name":"eclipse/kapua","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/kapua","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/kapua","forks_url":"https://api.github.com/repos/eclipse/kapua/forks","keys_url":"https://api.github.com/repos/eclipse/kapua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/kapua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/kapua/teams","hooks_url":"https://api.github.com/repos/eclipse/kapua/hooks","issue_events_url":"https://api.github.com/repos/eclipse/kapua/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/kapua/events","assignees_url":"https://api.github.com/repos/eclipse/kapua/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/kapua/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/kapua/tags","blobs_url":"https://api.github.com/repos/eclipse/kapua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/kapua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/kapua/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/kapua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/kapua/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/kapua/languages","stargazers_url":"https://api.github.com/repos/eclipse/kapua/stargazers","contributors_url":"https://api.github.com/repos/eclipse/kapua/contributors","subscribers_url":"https://api.github.com/repos/eclipse/kapua/subscribers","subscription_url":"https://api.github.com/repos/eclipse/kapua/subscription","commits_url":"https://api.github.com/repos/eclipse/kapua/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/kapua/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/kapua/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/kapua/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/kapua/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/kapua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/kapua/merges","archive_url":"https://api.github.com/repos/eclipse/kapua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/kapua/downloads","issues_url":"https://api.github.com/repos/eclipse/kapua/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/kapua/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/kapua/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/kapua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/kapua/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/kapua/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/kapua/deployments","created_at":"2016-10-14T15:14:46Z","updated_at":"2018-02-21T20:48:12Z","pushed_at":"2018-03-07T09:54:13Z","git_url":"git://github.com/eclipse/kapua.git","ssh_url":"git@github.com:eclipse/kapua.git","clone_url":"https://github.com/eclipse/kapua.git","svn_url":"https://github.com/eclipse/kapua","homepage":null,"size":18314,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":87,"open_issues":204,"watchers":78,"default_branch":"develop"}},"base":{"label":"eclipse:develop","ref":"develop","sha":"461478189a3ab4486e98cacee8088e5cb0600cf1","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":70921758,"name":"kapua","full_name":"eclipse/kapua","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/kapua","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/kapua","forks_url":"https://api.github.com/repos/eclipse/kapua/forks","keys_url":"https://api.github.com/repos/eclipse/kapua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/kapua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/kapua/teams","hooks_url":"https://api.github.com/repos/eclipse/kapua/hooks","issue_events_url":"https://api.github.com/repos/eclipse/kapua/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/kapua/events","assignees_url":"https://api.github.com/repos/eclipse/kapua/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/kapua/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/kapua/tags","blobs_url":"https://api.github.com/repos/eclipse/kapua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/kapua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/kapua/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/kapua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/kapua/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/kapua/languages","stargazers_url":"https://api.github.com/repos/eclipse/kapua/stargazers","contributors_url":"https://api.github.com/repos/eclipse/kapua/contributors","subscribers_url":"https://api.github.com/repos/eclipse/kapua/subscribers","subscription_url":"https://api.github.com/repos/eclipse/kapua/subscription","commits_url":"https://api.github.com/repos/eclipse/kapua/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/kapua/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/kapua/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/kapua/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/kapua/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/kapua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/kapua/merges","archive_url":"https://api.github.com/repos/eclipse/kapua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/kapua/downloads","issues_url":"https://api.github.com/repos/eclipse/kapua/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/kapua/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/kapua/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/kapua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/kapua/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/kapua/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/kapua/deployments","created_at":"2016-10-14T15:14:46Z","updated_at":"2018-02-21T20:48:12Z","pushed_at":"2018-03-07T09:54:13Z","git_url":"git://github.com/eclipse/kapua.git","ssh_url":"git@github.com:eclipse/kapua.git","clone_url":"https://github.com/eclipse/kapua.git","svn_url":"https://github.com/eclipse/kapua","homepage":null,"size":18314,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":87,"open_issues":204,"watchers":78,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/1486"},"html":{"href":"https://github.com/eclipse/kapua/pull/1486"},"issue":{"href":"https://api.github.com/repos/eclipse/kapua/issues/1486"},"comments":{"href":"https://api.github.com/repos/eclipse/kapua/issues/1486/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/1486/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/kapua/pulls/1486/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/kapua/statuses/df78d7380d785de2de3a841a906f703e1ba0404d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Coduz"}}