{"action":"closed","issue":{"url":"https://api.github.com/repos/ShokoAnime/MyAnime3/issues/67","repository_url":"https://api.github.com/repos/ShokoAnime/MyAnime3","labels_url":"https://api.github.com/repos/ShokoAnime/MyAnime3/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/ShokoAnime/MyAnime3/issues/67/comments","events_url":"https://api.github.com/repos/ShokoAnime/MyAnime3/issues/67/events","html_url":"https://github.com/ShokoAnime/MyAnime3/issues/67","id":308266332,"number":67,"title":"Display problems star ratings","user":{"login":"bertrey","id":37740725,"avatar_url":"https://avatars3.githubusercontent.com/u/37740725?v=4","gravatar_id":"","url":"https://api.github.com/users/bertrey","html_url":"https://github.com/bertrey","followers_url":"https://api.github.com/users/bertrey/followers","following_url":"https://api.github.com/users/bertrey/following{/other_user}","gists_url":"https://api.github.com/users/bertrey/gists{/gist_id}","starred_url":"https://api.github.com/users/bertrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertrey/subscriptions","organizations_url":"https://api.github.com/users/bertrey/orgs","repos_url":"https://api.github.com/users/bertrey/repos","events_url":"https://api.github.com/users/bertrey/events{/privacy}","received_events_url":"https://api.github.com/users/bertrey/received_events","type":"User","site_admin":false},"labels":[{"id":122037803,"url":"https://api.github.com/repos/ShokoAnime/MyAnime3/labels/In%20Progress","name":"In Progress","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-24T14:21:46Z","updated_at":"2018-04-06T14:29:22Z","closed_at":"2018-04-06T14:29:22Z","author_association":"NONE","body":"## Description\r\n\r\nI've noticed several display problems with the star ratings on groups/series.\r\nI'm wasn't sure whether I should create separate issues or just one ... I went with one - I hope that's OK.\r\n\r\nI have also attached patches for all these issues (separately) [HERE](https://github.com/ShokoAnime/MyAnime3/files/1844468/patches.zip).\r\nI developed these using the Branch_v3.7.1.0 branch (not the master branch), because that was the latest release for MyAnime3.\r\n\r\n1.  Missing rating image\r\nMost of the time the star rating image is not displayed.\r\nOnly the rating value and the user vote image is displayed:\r\n![screenshot](https://user-images.githubusercontent.com/37740725/37864581-61873188-2f71-11e8-86bf-8a98496424ac.PNG)\r\nIt looks like the star rating image just wasn't updated.\r\n\r\n2. Incorrect rating image color\r\n(I noticed this after fixing issue 1, but they aren't directly related)\r\nIn some cases the stars have the wrong color:\r\n![screenshot](https://user-images.githubusercontent.com/37740725/37864637-f6a3d500-2f71-11e8-995d-f03f53146ff1.PNG)\r\nThe problem was that these images are generated in code, and then cached per rating value.\r\nThe same cache was used for both rating (blue stars) and vote (white stars).\r\nSo if by coincidence the the same value occurs for a rating an a vote (even on different items), they will both use the same image from the cache (which means one of them will have the wrong color).\r\nThis was fixed by using different image names for rating/vote images.\r\n\r\n3. Scaling issue rating image\r\nOn my media center the star rating isn't scaled correctly:\r\n![screenshot](https://user-images.githubusercontent.com/37740725/37864706-eda6cc4a-2f72-11e8-992d-1b99561c720e.PNG)\r\nChanging the windows 10 display scaling from 150% to 100% fixes the problem:\r\n![screenshot setting](https://user-images.githubusercontent.com/37740725/37864729-35e00c7e-2f73-11e8-8545-684a37973127.png)\r\nStrangely enough I can't reproduce the problem on my laptop by setting the display scaling to 150%.\r\nBut I found a way to fix this anyway (by modifying the way the image is generated) - and it works on both my mediacenter and my laptop.\r\n\r\n4. Wrong case in rating text\r\nThis is a _very_ small issue ... but if I'm busy anyway ...\r\nIn all 3 screenshots above the votes use a wrong case: it should be `123 votes`, not `123 Votes`.\r\n\r\n## Steps to reproduce\r\n\r\n1. Start up MediaPortal\r\n2. Open MyAnime3\r\n3. Look at the star rating\r\n\r\n## Resolution\r\n\r\nAs I said before, a patch for all these issues is attached [HERE](https://github.com/ShokoAnime/MyAnime3/files/1844468/patches.zip).\r\nI should probably have done this using a pull request ... but I wasn't sure how to do that :-)"}}
{"actor":{"display_login":"RickDB"}}