{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/23656","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/23656/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/23656/comments","events_url":"https://api.github.com/repos/golang/go/issues/23656/events","html_url":"https://github.com/golang/go/issues/23656","id":293664987,"number":23656,"title":"x/build/devapp: support R= annotations in commit messages","user":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars1.githubusercontent.com/u/2621?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"labels":[{"id":223401461,"url":"https://api.github.com/repos/golang/go/labels/Builders","name":"Builders","color":"ededed","default":false},{"id":373401956,"url":"https://api.github.com/repos/golang/go/labels/NeedsDecision","name":"NeedsDecision","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"andybons","id":365204,"avatar_url":"https://avatars3.githubusercontent.com/u/365204?v=4","gravatar_id":"","url":"https://api.github.com/users/andybons","html_url":"https://github.com/andybons","followers_url":"https://api.github.com/users/andybons/followers","following_url":"https://api.github.com/users/andybons/following{/other_user}","gists_url":"https://api.github.com/users/andybons/gists{/gist_id}","starred_url":"https://api.github.com/users/andybons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybons/subscriptions","organizations_url":"https://api.github.com/users/andybons/orgs","repos_url":"https://api.github.com/users/andybons/repos","events_url":"https://api.github.com/users/andybons/events{/privacy}","received_events_url":"https://api.github.com/users/andybons/received_events","type":"User","site_admin":false},"assignees":[{"login":"andybons","id":365204,"avatar_url":"https://avatars3.githubusercontent.com/u/365204?v=4","gravatar_id":"","url":"https://api.github.com/users/andybons","html_url":"https://github.com/andybons","followers_url":"https://api.github.com/users/andybons/followers","following_url":"https://api.github.com/users/andybons/following{/other_user}","gists_url":"https://api.github.com/users/andybons/gists{/gist_id}","starred_url":"https://api.github.com/users/andybons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andybons/subscriptions","organizations_url":"https://api.github.com/users/andybons/orgs","repos_url":"https://api.github.com/users/andybons/repos","events_url":"https://api.github.com/users/andybons/events{/privacy}","received_events_url":"https://api.github.com/users/andybons/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/22","html_url":"https://github.com/golang/go/milestone/22","labels_url":"https://api.github.com/repos/golang/go/milestones/22/labels","id":1067491,"number":22,"title":"Unreleased","description":"Issues that do not affect released Go code and binaries.\r\n","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":811,"closed_issues":1178,"state":"open","created_at":"2015-04-14T18:48:22Z","updated_at":"2018-02-01T23:37:20Z","due_on":"2099-12-31T08:00:00Z","closed_at":null},"comments":3,"created_at":"2018-02-01T20:02:58Z","updated_at":"2018-02-01T23:44:38Z","closed_at":null,"author_association":"OWNER","body":"I see people using R= in commit messages, instead of in comments:\r\n\r\nhttps://go-review.googlesource.com/c/go/+/91435\r\nhttps://go-review.googlesource.com/c/go/+/63274\r\n\r\nDo we want to support R= in commit messages too?\r\n\r\nEasy technical change. But do we care about commit message prettiness? One CL was R=go1.11 and we approved it for Go 1.10. Fortunately @tklauser updated the commit message before submitting, but that won't always be the case if we make our tooling support R=go1.N and promote its use.\r\n\r\n/cc @andybons @ianlancetaylor "},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/362439379","html_url":"https://github.com/golang/go/issues/23656#issuecomment-362439379","issue_url":"https://api.github.com/repos/golang/go/issues/23656","id":362439379,"user":{"login":"josharian","id":67496,"avatar_url":"https://avatars2.githubusercontent.com/u/67496?v=4","gravatar_id":"","url":"https://api.github.com/users/josharian","html_url":"https://github.com/josharian","followers_url":"https://api.github.com/users/josharian/followers","following_url":"https://api.github.com/users/josharian/following{/other_user}","gists_url":"https://api.github.com/users/josharian/gists{/gist_id}","starred_url":"https://api.github.com/users/josharian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josharian/subscriptions","organizations_url":"https://api.github.com/users/josharian/orgs","repos_url":"https://api.github.com/users/josharian/repos","events_url":"https://api.github.com/users/josharian/events{/privacy}","received_events_url":"https://api.github.com/users/josharian/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T23:44:37Z","updated_at":"2018-02-01T23:44:37Z","author_association":"CONTRIBUTOR","body":"> But do we care about commit message prettiness?\r\n\r\nI do.\r\n\r\nFor those who are heavy `git mail` users, we could add a secret flag (like `-trybot`) to auto-add an `R=go1.N` comment.\r\n\r\nA similar question exists for RELNOTE=yes. I would prefer to see them in gerrit but not commit messages, personally.\r\n\r\nDoes gerrit suppose pre-submit hooks? We could have gerrit rewrite away such lines in the commit message. Then out bot would just need to replicate the commit message annotations in gerrit comments.\r\n"}}
{"actor":{"display_login":"josharian"}}