{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/49900","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/49900/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/49900/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/49900/events","html_url":"https://github.com/rust-lang/rust/pull/49900","id":313659383,"number":49900,"title":"Add src/test/ui regression testing for NLL","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars0.githubusercontent.com/u/173127?v=4","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"labels":[{"id":583437191,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"state":"closed","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-04-12T10:05:36Z","updated_at":"2018-04-20T14:15:09Z","closed_at":"2018-04-19T13:38:49Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/49900","html_url":"https://github.com/rust-lang/rust/pull/49900","diff_url":"https://github.com/rust-lang/rust/pull/49900.diff","patch_url":"https://github.com/rust-lang/rust/pull/49900.patch"},"body":"This PR changes `x.py test` so that when you are running the `ui` test suite, it will also always run `compiletest` in the new `--compare-mode=nll`, which just double-checks that when running under the experimental NLL mode, the output matches the `<source-name>.nll.stderr` file, if present.\r\n\r\nIn order to reduce the chance of a developer revolt in response to this change, this PR also includes some changes to make the `--compare-mode=nll` more user-friendly:\r\n\r\n 1. It now generates nll-specific .stamp files, and uses them (so that repeated runs can reuse previously cached results).\r\n 2. Each line of terminal output distinguishes whether we are running under `--compare-mode=nll` by printing with the prefix `[ui (nll)]` instead of just the prefix `[ui]`.\r\n\r\nSubtask of rust-lang/rust#48879"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/383109830","html_url":"https://github.com/rust-lang/rust/pull/49900#issuecomment-383109830","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/49900","id":383109830,"user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars0.githubusercontent.com/u/173127?v=4","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T14:15:09Z","updated_at":"2018-04-20T14:15:09Z","author_association":"MEMBER","body":"(also, I recognize that I made matters much worse here because I didn't request a review of the newer changes I had made, which included the bug I injected here. I'm sorry and I will try to do better; regression testing a feature like NLL, while important, was certainly not worth breaking a critical piece of infrastructure.)\r\n\r\nOn the plus side, hopefully the problem injected by my bug won't cause too much trouble in the short term, since people should hopefully notice that their stderrs are getting overwritten. "}}
{"actor":{"display_login":"pnkfelix"}}