{"action":"created","issue":{"url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/38","repository_url":"https://api.github.com/repos/oconnormi/docker-ddf-base","labels_url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/38/comments","events_url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/38/events","html_url":"https://github.com/oconnormi/docker-ddf-base/pull/38","id":294417393,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3MTYyNDUw","number":38,"title":"Start DDF with sudo when the port is below 1024","user":{"login":"dannythk","id":7926259,"node_id":"MDQ6VXNlcjc5MjYyNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7926259?v=4","gravatar_id":"","url":"https://api.github.com/users/dannythk","html_url":"https://github.com/dannythk","followers_url":"https://api.github.com/users/dannythk/followers","following_url":"https://api.github.com/users/dannythk/following{/other_user}","gists_url":"https://api.github.com/users/dannythk/gists{/gist_id}","starred_url":"https://api.github.com/users/dannythk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannythk/subscriptions","organizations_url":"https://api.github.com/users/dannythk/orgs","repos_url":"https://api.github.com/users/dannythk/repos","events_url":"https://api.github.com/users/dannythk/events{/privacy}","received_events_url":"https://api.github.com/users/dannythk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T14:45:33Z","updated_at":"2018-07-22T13:00:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/oconnormi/docker-ddf-base/pulls/38","html_url":"https://github.com/oconnormi/docker-ddf-base/pull/38","diff_url":"https://github.com/oconnormi/docker-ddf-base/pull/38.diff","patch_url":"https://github.com/oconnormi/docker-ddf-base/pull/38.patch"},"body":"Instead of me keep updating the line inside my docker build, this should be useful for others who decide to use port below 1024.  "},"comment":{"url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/comments/406864938","html_url":"https://github.com/oconnormi/docker-ddf-base/pull/38#issuecomment-406864938","issue_url":"https://api.github.com/repos/oconnormi/docker-ddf-base/issues/38","id":406864938,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg2NDkzOA==","user":{"login":"oconnormi","id":3409759,"node_id":"MDQ6VXNlcjM0MDk3NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3409759?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnormi","html_url":"https://github.com/oconnormi","followers_url":"https://api.github.com/users/oconnormi/followers","following_url":"https://api.github.com/users/oconnormi/following{/other_user}","gists_url":"https://api.github.com/users/oconnormi/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnormi/subscriptions","organizations_url":"https://api.github.com/users/oconnormi/orgs","repos_url":"https://api.github.com/users/oconnormi/repos","events_url":"https://api.github.com/users/oconnormi/events{/privacy}","received_events_url":"https://api.github.com/users/oconnormi/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T13:00:57Z","updated_at":"2018-07-22T13:00:57Z","author_association":"OWNER","body":"I think we need some additional checks before calling `sudo` based on the port number. We should also check that sudo is on in the path and that the user is not already root. Otherwise this is not portable to images that do not include sudo.\r\n\r\nAlso once #36 is done it should be unnecessary to change the port that ddf is binding inside the container since forwarded ports will work properly thanks to some recent changes in ddf"}}
{"actor":{"display_login":"oconnormi"}}