{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/25984","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/25984/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/25984/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/25984/events","html_url":"https://github.com/JuliaLang/julia/pull/25984","id":296030051,"number":25984,"title":"codegen restructuring","user":{"login":"vtjnash","id":330950,"avatar_url":"https://avatars1.githubusercontent.com/u/330950?v=4","gravatar_id":"","url":"https://api.github.com/users/vtjnash","html_url":"https://github.com/vtjnash","followers_url":"https://api.github.com/users/vtjnash/followers","following_url":"https://api.github.com/users/vtjnash/following{/other_user}","gists_url":"https://api.github.com/users/vtjnash/gists{/gist_id}","starred_url":"https://api.github.com/users/vtjnash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtjnash/subscriptions","organizations_url":"https://api.github.com/users/vtjnash/orgs","repos_url":"https://api.github.com/users/vtjnash/repos","events_url":"https://api.github.com/users/vtjnash/events{/privacy}","received_events_url":"https://api.github.com/users/vtjnash/received_events","type":"User","site_admin":false},"labels":[{"id":183231688,"url":"https://api.github.com/repos/JuliaLang/julia/labels/codegen","name":"codegen","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-09T22:19:42Z","updated_at":"2018-02-16T08:51:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/25984","html_url":"https://github.com/JuliaLang/julia/pull/25984","diff_url":"https://github.com/JuliaLang/julia/pull/25984.diff","patch_url":"https://github.com/JuliaLang/julia/pull/25984.patch"},"body":"This creates the function `jl_create_native` for outputting a `llvm::Module` from a list (`jl_array_t`) of functions (`jl_method_instance_t`) which is independent from the JIT (as needed by https://github.com/JuliaGPU/CUDAnative.jl/issues/122). It's now used by the build system also, so that it'll be tested too. This (mostly) eliminates the `shadow_module`, and does a slightly more aggressive job at ensuring functions are getting precompiled.\r\n\r\nThere's still some more work to do to make that work even better, but that can be done later. I'm also now printing out errors that happen as a result of codegen bugs, rather than propagating them to the user, which makes a few of the tests (for codegen breakage) are a bit noisier now – those will need to be fixed now."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/366176910","html_url":"https://github.com/JuliaLang/julia/pull/25984#issuecomment-366176910","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/25984","id":366176910,"user":{"login":"maleadt","id":383068,"avatar_url":"https://avatars3.githubusercontent.com/u/383068?v=4","gravatar_id":"","url":"https://api.github.com/users/maleadt","html_url":"https://github.com/maleadt","followers_url":"https://api.github.com/users/maleadt/followers","following_url":"https://api.github.com/users/maleadt/following{/other_user}","gists_url":"https://api.github.com/users/maleadt/gists{/gist_id}","starred_url":"https://api.github.com/users/maleadt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleadt/subscriptions","organizations_url":"https://api.github.com/users/maleadt/orgs","repos_url":"https://api.github.com/users/maleadt/repos","events_url":"https://api.github.com/users/maleadt/events{/privacy}","received_events_url":"https://api.github.com/users/maleadt/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T08:51:56Z","updated_at":"2018-02-16T08:51:56Z","author_association":"MEMBER","body":"> That other method is not exported – I didn't change the signature of julia_type_to_llvm (yet 😛 – it might gain a LLVMContextRef eventually).\r\n\r\nAh OK, I didn't see the second definition. An explicit LLVM context should be fine, assuming we can maintain a global one in CUDAnative."}}
{"actor":{"display_login":"maleadt"}}