{"action":"created","issue":{"url":"https://api.github.com/repos/linde12/kod/issues/34","repository_url":"https://api.github.com/repos/linde12/kod","labels_url":"https://api.github.com/repos/linde12/kod/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/linde12/kod/issues/34/comments","events_url":"https://api.github.com/repos/linde12/kod/issues/34/events","html_url":"https://github.com/linde12/kod/pull/34","id":365756017,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTk2NjEw","number":34,"title":"Fix vertical scroll and update implementation of linecache","user":{"login":"emigr2k1","id":40287406,"node_id":"MDQ6VXNlcjQwMjg3NDA2","avatar_url":"https://avatars0.githubusercontent.com/u/40287406?v=4","gravatar_id":"","url":"https://api.github.com/users/emigr2k1","html_url":"https://github.com/emigr2k1","followers_url":"https://api.github.com/users/emigr2k1/followers","following_url":"https://api.github.com/users/emigr2k1/following{/other_user}","gists_url":"https://api.github.com/users/emigr2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/emigr2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emigr2k1/subscriptions","organizations_url":"https://api.github.com/users/emigr2k1/orgs","repos_url":"https://api.github.com/users/emigr2k1/repos","events_url":"https://api.github.com/users/emigr2k1/events{/privacy}","received_events_url":"https://api.github.com/users/emigr2k1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-02T06:20:13Z","updated_at":"2018-10-07T19:29:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linde12/kod/pulls/34","html_url":"https://github.com/linde12/kod/pull/34","diff_url":"https://github.com/linde12/kod/pull/34.diff","patch_url":"https://github.com/linde12/kod/pull/34.patch"},"body":"I added support for vertical scrolling creating an \"offset\" on viewport to know how many lines should Kod scroll based on number of lines and invalid lines before the document.\r\nI also added some helper methods for viewport that I got from tcell. Those provide an easy way to scroll the viewport and make a part of the viewport visible.\r\nNow Kod is not responsible to move the cursor and Xi core is. Cursor will only move when there's a notification from Xi core.\r\nWhen Kod scrolls, it now sends a notification to Xi core to let it know the new viewport.\r\nFinally, I updated the implementation of linecache because there were some problems when Xi invalidates lines and viewport was scrolled."},"comment":{"url":"https://api.github.com/repos/linde12/kod/issues/comments/427679928","html_url":"https://github.com/linde12/kod/pull/34#issuecomment-427679928","issue_url":"https://api.github.com/repos/linde12/kod/issues/34","id":427679928,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY3OTkyOA==","user":{"login":"jantb","id":625930,"node_id":"MDQ6VXNlcjYyNTkzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/625930?v=4","gravatar_id":"","url":"https://api.github.com/users/jantb","html_url":"https://github.com/jantb","followers_url":"https://api.github.com/users/jantb/followers","following_url":"https://api.github.com/users/jantb/following{/other_user}","gists_url":"https://api.github.com/users/jantb/gists{/gist_id}","starred_url":"https://api.github.com/users/jantb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantb/subscriptions","organizations_url":"https://api.github.com/users/jantb/orgs","repos_url":"https://api.github.com/users/jantb/repos","events_url":"https://api.github.com/users/jantb/events{/privacy}","received_events_url":"https://api.github.com/users/jantb/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T19:29:32Z","updated_at":"2018-10-07T19:29:32Z","author_association":"NONE","body":"There is a problem with the draw method, when srolling down, linecache caches up to 1000 above the view. All these lines are iterated and drawn in the draw method. "}}
{"actor":{"display_login":"jantb"}}