{"action":"closed","issue":{"url":"https://api.github.com/repos/electron-userland/electron-forge/issues/512","repository_url":"https://api.github.com/repos/electron-userland/electron-forge","labels_url":"https://api.github.com/repos/electron-userland/electron-forge/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-forge/issues/512/comments","events_url":"https://api.github.com/repos/electron-userland/electron-forge/issues/512/events","html_url":"https://github.com/electron-userland/electron-forge/issues/512","id":325054275,"number":512,"title":"Unable to set exe icon and shortcut icon","user":{"login":"Elindalyne","id":1426875,"avatar_url":"https://avatars3.githubusercontent.com/u/1426875?v=4","gravatar_id":"","url":"https://api.github.com/users/Elindalyne","html_url":"https://github.com/Elindalyne","followers_url":"https://api.github.com/users/Elindalyne/followers","following_url":"https://api.github.com/users/Elindalyne/following{/other_user}","gists_url":"https://api.github.com/users/Elindalyne/gists{/gist_id}","starred_url":"https://api.github.com/users/Elindalyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elindalyne/subscriptions","organizations_url":"https://api.github.com/users/Elindalyne/orgs","repos_url":"https://api.github.com/users/Elindalyne/repos","events_url":"https://api.github.com/users/Elindalyne/events{/privacy}","received_events_url":"https://api.github.com/users/Elindalyne/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-21T20:48:26Z","updated_at":"2018-05-23T15:29:46Z","closed_at":"2018-05-23T15:29:46Z","author_association":"NONE","body":"<!--\r\nThanks for filing an issue!\r\n\r\nIf you have a question, consider searching and asking in other Electron community sites,\r\nso that more people have a chance to help you: https://github.com/electron/electron#community\r\n\r\nSpecific issues about the templates that are available by default when creating a new\r\nElectron Forge project should be filed in its GitHub repository:\r\nhttps://github.com/electron-userland/electron-forge-templates\r\n\r\nPlease check off all of the steps as they are completed by replacing [ ] with [x].\r\n-->\r\n\r\n* [x ] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project.\r\n* [ x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.\r\n* [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.\r\n\r\n**Please describe your issue:**\r\nI've been going over the issues and documentation and have been unable to get my application to take my custom icon and name. I had thought it was an issue with relative paths and moved my configuration to a forge-config.js but that doesn't seem to be the issue.\r\n\r\n\r\n<!-- For bugs and questions, please answer these questions to the best of your ability. -->\r\n\r\n**Console output when you run `electron-forge` with the environment variable `DEBUG=electron-forge:*`. (Instructions on how to do so [here](https://www.npmjs.com/package/debug#usage)). Please include the stack trace if one exists.**\r\n\r\n```\r\nelectron-forge make --arch=ia32\r\nWARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle\r\n  electron-forge:lifecycle Process Started: Checking your system +0ms\r\n  electron-forge:lifecycle Process Succeeded: Checking your system +760ms\r\n  electron-forge:runtime-config setting key: verbose to value: false +0ms\r\nWARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle\r\n  electron-forge:lifecycle Process Started: Resolving Forge Config +0ms\r\n  electron-forge:project-resolver searching for project in: C:\\Source\\AdvantageSuite\\AdvantageSuite\\LocalService\\PrintService +0ms\r\n  electron-forge:project-resolver electron-forge compatible package.json found in C:\\Source\\AdvantageSuite\\AdvantageSuite\\LocalService\\PrintService\\package.json +20ms\r\n  electron-forge:lifecycle Process Succeeded: Resolving Forge Config +25ms\r\n  electron-forge:require-search searching [ '../makers/win32/squirrel.js',\r\n  '../makers/generic/squirrel.js',\r\n  'electron-forge-maker-squirrel',\r\n  'squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\node_modules\\\\squirrel',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\makers\\\\win32\\\\squirrel.js',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\makers\\\\generic\\\\squirrel.js',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\electron-forge-maker-squirrel',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\node_modules\\\\squirrel',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\makers\\\\win32\\\\squirrel.js',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\makers\\\\generic\\\\squirrel.js',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\node_modules\\\\electron-forge-maker-squirrel',\r\n  'C:\\\\Users\\\\rsilver\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\electron-forge\\\\dist\\\\api\\\\node_modules\\\\squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\squirrel',\r\n  'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\node_modules\\\\squirrel' ] relative to C:\\Users\\rsilver\\AppData\\Roaming\\npm\\node_modules\\electron-forge\\dist\\api +0ms\r\n  electron-forge:require-search testing ../makers/win32/squirrel.js +1ms\r\nWe need to package your application before we can make it\r\n  electron-forge:lifecycle Process Started: Preparing to Package Application for arch: ia32 +95ms\r\n  electron-forge:project-resolver searching for project in: C:\\Source\\AdvantageSuite\\AdvantageSuite\\LocalService\\PrintService +100ms\r\n  electron-forge:project-resolver electron-forge compatible package.json found in C:\\Source\\AdvantageSuite\\AdvantageSuite\\LocalService\\PrintService\\package.json +1ms\r\n  electron-forge:hook could not find hook: generateAssets +0ms\r\n  electron-forge:hook could not find hook: prePackage +1ms\r\n  electron-forge:packager packaging with options { asar: false,\r\n  overwrite: true,\r\n  packageManager: 'npm',\r\n  icon: 'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\src\\\\assets\\\\icons\\\\win\\\\twinoaks.ico',\r\n  afterCopy: [ [Function] ],\r\n  afterExtract: [ [Function] ],\r\n  afterPrune: [ [Function] ],\r\n  dir: 'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService',\r\n  arch: 'ia32',\r\n  platform: 'win32',\r\n  out: 'C:\\\\Source\\\\AdvantageSuite\\\\AdvantageSuite\\\\LocalService\\\\PrintService\\\\out',\r\n  electronVersion: '1.8.4',\r\n  quiet: true } +0ms\r\n  electron-forge:lifecycle Process Succeeded: Preparing to Package Application for arch: ia32 +42s\r\n  electron-forge:lifecycle Process Started: Compiling Application +0ms\r\n  electron-forge:lifecycle Process Succeeded: Compiling Application +1s\r\n  electron-forge:lifecycle Process Started: Preparing native dependencies +11s\r\n  electron-forge:lifecycle Process Succeeded: Preparing native dependencies +103ms\r\n  electron-forge:lifecycle Process Started: Packaging Application +0ms\r\n  electron-forge:hook could not find hook: postPackage +1m\r\n  electron-forge:lifecycle Process Succeeded: Packaging Application +25s\r\nMaking for the following targets:\r\n  electron-forge:hook could not find hook: preMake +1ms\r\n  electron-forge:lifecycle Process Started: Making for target: squirrel - On platform: win32 - For arch: ia32 +2ms\r\n  electron-forge:lifecycle Process Succeeded: Making for target: squirrel - On platform: win32 - For arch: ia32 +2m\r\n  electron-forge:hook could not find hook: postMake +2m\r\n```\r\n\r\n\r\n**What command line arguments are you passing?**\r\n\r\n```\r\nmake --arch=ia32\r\n```\r\n\r\n**What does your `config.forge` data in `package.json` look like?**\r\n\r\n```\r\n{\r\n  make_targets: {\r\n    win32: [\r\n      'squirrel',\r\n    ],\r\n    darwin: [\r\n      'zip',\r\n    ],\r\n    linux: [\r\n      'deb',\r\n      'rpm',\r\n    ],\r\n  },\r\n  electronPackagerConfig: {\r\n    packageManager: 'npm',\r\n    icon: path.resolve(__dirname, 'src/assets/icons/win/twinoaks.ico'),\r\n  },\r\n  electronWinstallerConfig: {\r\n    name: 'TwinOaksPrintService',\r\n    noMsi: false,\r\n    author: 'Twin Oaks Software',\r\n    exe: 'PrintService.exe',\r\n    description: '<my description>',\r\n    iconUrl: '<a url that actually resolves>',\r\n  },\r\n  electronInstallerDebian: {},\r\n  electronInstallerRedhat: {},\r\n  github_repository: {\r\n    owner: '',\r\n    name: '',\r\n  },\r\n  windowsStoreConfig: {\r\n    packageName: '',\r\n    name: 'printservice',\r\n  },\r\n};\r\n```\r\n\r\n**Please provide either a failing minimal testcase (with a link to the code) or detailed steps to\r\nreproduce your problem. Using `electron-forge init` is a good starting point, if that is not the\r\nsource of your problem.**\r\n\r\n\r\n"}}
{"actor":{"display_login":"Elindalyne"}}