{"action":"closed","number":577,"pull_request":{"url":"https://api.github.com/repos/dherges/ng-packagr/pulls/577","id":166349062,"html_url":"https://github.com/dherges/ng-packagr/pull/577","diff_url":"https://github.com/dherges/ng-packagr/pull/577.diff","patch_url":"https://github.com/dherges/ng-packagr/pull/577.patch","issue_url":"https://api.github.com/repos/dherges/ng-packagr/issues/577","number":577,"state":"closed","locked":false,"title":"perf: don't await and return","user":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"body":"\r\n## I'm submitting a...\r\n\r\n```\r\n[ ] Bug Fix\r\n[ ] Feature\r\n[x] Other (Refactoring, Added tests, Documentation, ...)\r\n```\r\n\r\n## Checklist\r\n\r\n- [x] Commit Messages follow the [Conventional Commits](https://conventionalcommits.org/) pattern\r\n  - A feature commit message is prefixed \"feat:\"\r\n  - A bugfix commit message is prefixed \"fix:\"\r\n- [x] Tests for the changes have been added\r\n\r\n\r\n## Description\r\nMinor thing\r\n\r\nAn async function always wraps the return value in a Promise. Using return await just adds extra time before the overreaching promise is resolved without changing the semantics\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2018-01-31T19:07:21Z","updated_at":"2018-02-03T08:27:23Z","closed_at":"2018-02-03T08:27:23Z","merged_at":"2018-02-03T08:27:23Z","merge_commit_sha":"f479e81e8e17e05e6af9f464f9977bc648d2fdc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/577/commits","review_comments_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/577/comments","review_comment_url":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/issues/577/comments","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/058dc3d855f90bfe98e6cd687f3422eb227d1db0","head":{"label":"alan-agius4:feature/perf-await","ref":"feature/perf-await","sha":"058dc3d855f90bfe98e6cd687f3422eb227d1db0","user":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"repo":{"id":112093113,"name":"ng-packagr","full_name":"alan-agius4/ng-packagr","owner":{"login":"alan-agius4","id":17563226,"avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alan-agius4/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":true,"url":"https://api.github.com/repos/alan-agius4/ng-packagr","forks_url":"https://api.github.com/repos/alan-agius4/ng-packagr/forks","keys_url":"https://api.github.com/repos/alan-agius4/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alan-agius4/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alan-agius4/ng-packagr/teams","hooks_url":"https://api.github.com/repos/alan-agius4/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/alan-agius4/ng-packagr/events","assignees_url":"https://api.github.com/repos/alan-agius4/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/alan-agius4/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/alan-agius4/ng-packagr/tags","blobs_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alan-agius4/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/alan-agius4/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/alan-agius4/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/alan-agius4/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/alan-agius4/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/alan-agius4/ng-packagr/subscription","commits_url":"https://api.github.com/repos/alan-agius4/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/alan-agius4/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/alan-agius4/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/alan-agius4/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/alan-agius4/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alan-agius4/ng-packagr/merges","archive_url":"https://api.github.com/repos/alan-agius4/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alan-agius4/ng-packagr/downloads","issues_url":"https://api.github.com/repos/alan-agius4/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/alan-agius4/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/alan-agius4/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/alan-agius4/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alan-agius4/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/alan-agius4/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/alan-agius4/ng-packagr/deployments","created_at":"2017-11-26T15:16:43Z","updated_at":"2017-11-26T15:16:45Z","pushed_at":"2018-02-01T09:56:15Z","git_url":"git://github.com/alan-agius4/ng-packagr.git","ssh_url":"git@github.com:alan-agius4/ng-packagr.git","clone_url":"https://github.com/alan-agius4/ng-packagr.git","svn_url":"https://github.com/alan-agius4/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":9601,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dherges:master","ref":"master","sha":"7a996ef763c252d3ea03f416550e6d9e17c9abdc","user":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"repo":{"id":91553810,"name":"ng-packagr","full_name":"dherges/ng-packagr","owner":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dherges/ng-packagr","description":"Transpile your libraries to Angular Package Format","fork":false,"url":"https://api.github.com/repos/dherges/ng-packagr","forks_url":"https://api.github.com/repos/dherges/ng-packagr/forks","keys_url":"https://api.github.com/repos/dherges/ng-packagr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dherges/ng-packagr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dherges/ng-packagr/teams","hooks_url":"https://api.github.com/repos/dherges/ng-packagr/hooks","issue_events_url":"https://api.github.com/repos/dherges/ng-packagr/issues/events{/number}","events_url":"https://api.github.com/repos/dherges/ng-packagr/events","assignees_url":"https://api.github.com/repos/dherges/ng-packagr/assignees{/user}","branches_url":"https://api.github.com/repos/dherges/ng-packagr/branches{/branch}","tags_url":"https://api.github.com/repos/dherges/ng-packagr/tags","blobs_url":"https://api.github.com/repos/dherges/ng-packagr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dherges/ng-packagr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dherges/ng-packagr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dherges/ng-packagr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dherges/ng-packagr/statuses/{sha}","languages_url":"https://api.github.com/repos/dherges/ng-packagr/languages","stargazers_url":"https://api.github.com/repos/dherges/ng-packagr/stargazers","contributors_url":"https://api.github.com/repos/dherges/ng-packagr/contributors","subscribers_url":"https://api.github.com/repos/dherges/ng-packagr/subscribers","subscription_url":"https://api.github.com/repos/dherges/ng-packagr/subscription","commits_url":"https://api.github.com/repos/dherges/ng-packagr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dherges/ng-packagr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dherges/ng-packagr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dherges/ng-packagr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dherges/ng-packagr/contents/{+path}","compare_url":"https://api.github.com/repos/dherges/ng-packagr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dherges/ng-packagr/merges","archive_url":"https://api.github.com/repos/dherges/ng-packagr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dherges/ng-packagr/downloads","issues_url":"https://api.github.com/repos/dherges/ng-packagr/issues{/number}","pulls_url":"https://api.github.com/repos/dherges/ng-packagr/pulls{/number}","milestones_url":"https://api.github.com/repos/dherges/ng-packagr/milestones{/number}","notifications_url":"https://api.github.com/repos/dherges/ng-packagr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dherges/ng-packagr/labels{/name}","releases_url":"https://api.github.com/repos/dherges/ng-packagr/releases{/id}","deployments_url":"https://api.github.com/repos/dherges/ng-packagr/deployments","created_at":"2017-05-17T08:43:27Z","updated_at":"2018-02-02T22:52:14Z","pushed_at":"2018-02-03T08:27:23Z","git_url":"git://github.com/dherges/ng-packagr.git","ssh_url":"git@github.com:dherges/ng-packagr.git","clone_url":"https://github.com/dherges/ng-packagr.git","svn_url":"https://github.com/dherges/ng-packagr","homepage":"http://spektrakel.de/ng-packagr/","size":9859,"stargazers_count":530,"watchers_count":530,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":74,"open_issues":76,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/577"},"html":{"href":"https://github.com/dherges/ng-packagr/pull/577"},"issue":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/577"},"comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dherges/ng-packagr/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/dherges/ng-packagr/statuses/058dc3d855f90bfe98e6cd687f3422eb227d1db0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dherges","id":901354,"avatar_url":"https://avatars1.githubusercontent.com/u/901354?v=4","gravatar_id":"","url":"https://api.github.com/users/dherges","html_url":"https://github.com/dherges","followers_url":"https://api.github.com/users/dherges/followers","following_url":"https://api.github.com/users/dherges/following{/other_user}","gists_url":"https://api.github.com/users/dherges/gists{/gist_id}","starred_url":"https://api.github.com/users/dherges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dherges/subscriptions","organizations_url":"https://api.github.com/users/dherges/orgs","repos_url":"https://api.github.com/users/dherges/repos","events_url":"https://api.github.com/users/dherges/events{/privacy}","received_events_url":"https://api.github.com/users/dherges/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"dherges"}}