{"action":"created","comment":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments/182986150","pull_request_review_id":113897449,"id":182986150,"diff_hunk":"@@ -562,12 +562,14 @@ protected function getFulltextResultsHTML($data, $highlight)\n         }\n \n         $html = '<div class=\"search_fulltextresult\">';\n-        $html .= '<h3>' . $lang['search_fullresults'] . ':</h3>';\n+        $html .= '<h2>' . $lang['search_fullresults'] . ':</h2>';\n \n         $html .= '<dl class=\"search_results\">';\n         $num = 1;","path":"inc/Ui/Search.php","position":17,"original_position":17,"commit_id":"b12bcb7787ac8838fb69ab637f8324983c84fbee","original_commit_id":"6d55fda7de37f2a4bca72abd080dc59986d75e36","user":{"login":"Rocreex","id":6241985,"avatar_url":"https://avatars1.githubusercontent.com/u/6241985?v=4","gravatar_id":"","url":"https://api.github.com/users/Rocreex","html_url":"https://github.com/Rocreex","followers_url":"https://api.github.com/users/Rocreex/followers","following_url":"https://api.github.com/users/Rocreex/following{/other_user}","gists_url":"https://api.github.com/users/Rocreex/gists{/gist_id}","starred_url":"https://api.github.com/users/Rocreex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rocreex/subscriptions","organizations_url":"https://api.github.com/users/Rocreex/orgs","repos_url":"https://api.github.com/users/Rocreex/repos","events_url":"https://api.github.com/users/Rocreex/events{/privacy}","received_events_url":"https://api.github.com/users/Rocreex/received_events","type":"User","site_admin":false},"body":"For the comparison in line 591, this should probably be initialized as 0.","created_at":"2018-04-20T08:53:00Z","updated_at":"2018-04-20T08:53:00Z","html_url":"https://github.com/splitbrain/dokuwiki/pull/2314#discussion_r182986150","pull_request_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments/182986150"},"html":{"href":"https://github.com/splitbrain/dokuwiki/pull/2314#discussion_r182986150"},"pull_request":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314"}}},"pull_request":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314","id":181701209,"html_url":"https://github.com/splitbrain/dokuwiki/pull/2314","diff_url":"https://github.com/splitbrain/dokuwiki/pull/2314.diff","patch_url":"https://github.com/splitbrain/dokuwiki/pull/2314.patch","issue_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2314","number":2314,"state":"open","locked":false,"title":"Fix invalid HTML","user":{"login":"selfthinker","id":108893,"avatar_url":"https://avatars3.githubusercontent.com/u/108893?v=4","gravatar_id":"","url":"https://api.github.com/users/selfthinker","html_url":"https://github.com/selfthinker","followers_url":"https://api.github.com/users/selfthinker/followers","following_url":"https://api.github.com/users/selfthinker/following{/other_user}","gists_url":"https://api.github.com/users/selfthinker/gists{/gist_id}","starred_url":"https://api.github.com/users/selfthinker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfthinker/subscriptions","organizations_url":"https://api.github.com/users/selfthinker/orgs","repos_url":"https://api.github.com/users/selfthinker/repos","events_url":"https://api.github.com/users/selfthinker/events{/privacy}","received_events_url":"https://api.github.com/users/selfthinker/received_events","type":"User","site_admin":false},"body":"This fixes some invalid HTML which mostly sneaked in with #2286.\r\nThe semantics of the search results page are a bit tricky. I nearly changed the existing description list to a normal unordered list, but I think it still makes sense the way it is now, i.e. a `dl` with 1 `dt` and 2 `dd`. Semantically I think it might make more sense to move the \"[number of] Hits\" also into its own `dd` or add it to the 'last modified' line.\r\n","created_at":"2018-04-15T14:16:18Z","updated_at":"2018-04-20T08:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf97f0a65b9991a87156568d2b3c9b1978f39786","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":82934825,"url":"https://api.github.com/repos/splitbrain/dokuwiki/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":87128369,"url":"https://api.github.com/repos/splitbrain/dokuwiki/labels/ToDo:%20needDocUpdate","name":"ToDo: needDocUpdate","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/milestones/4","html_url":"https://github.com/splitbrain/dokuwiki/milestone/4","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/milestones/4/labels","id":2937324,"number":4,"title":"🐱 Greebo","description":"","creator":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":35,"state":"open","created_at":"2017-11-26T12:11:38Z","updated_at":"2018-04-15T14:24:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314/commits","review_comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314/comments","review_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2314/comments","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/b12bcb7787ac8838fb69ab637f8324983c84fbee","head":{"label":"splitbrain:fix-html","ref":"fix-html","sha":"b12bcb7787ac8838fb69ab637f8324983c84fbee","user":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"repo":{"id":456930,"name":"dokuwiki","full_name":"splitbrain/dokuwiki","owner":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splitbrain/dokuwiki","description":"The DokuWiki Open Source Wiki Engine","fork":false,"url":"https://api.github.com/repos/splitbrain/dokuwiki","forks_url":"https://api.github.com/repos/splitbrain/dokuwiki/forks","keys_url":"https://api.github.com/repos/splitbrain/dokuwiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splitbrain/dokuwiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splitbrain/dokuwiki/teams","hooks_url":"https://api.github.com/repos/splitbrain/dokuwiki/hooks","issue_events_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/events{/number}","events_url":"https://api.github.com/repos/splitbrain/dokuwiki/events","assignees_url":"https://api.github.com/repos/splitbrain/dokuwiki/assignees{/user}","branches_url":"https://api.github.com/repos/splitbrain/dokuwiki/branches{/branch}","tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/tags","blobs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/{sha}","languages_url":"https://api.github.com/repos/splitbrain/dokuwiki/languages","stargazers_url":"https://api.github.com/repos/splitbrain/dokuwiki/stargazers","contributors_url":"https://api.github.com/repos/splitbrain/dokuwiki/contributors","subscribers_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscribers","subscription_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscription","commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/splitbrain/dokuwiki/contents/{+path}","compare_url":"https://api.github.com/repos/splitbrain/dokuwiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splitbrain/dokuwiki/merges","archive_url":"https://api.github.com/repos/splitbrain/dokuwiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splitbrain/dokuwiki/downloads","issues_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues{/number}","pulls_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls{/number}","milestones_url":"https://api.github.com/repos/splitbrain/dokuwiki/milestones{/number}","notifications_url":"https://api.github.com/repos/splitbrain/dokuwiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/labels{/name}","releases_url":"https://api.github.com/repos/splitbrain/dokuwiki/releases{/id}","deployments_url":"https://api.github.com/repos/splitbrain/dokuwiki/deployments","created_at":"2010-01-03T13:47:20Z","updated_at":"2018-04-19T21:42:15Z","pushed_at":"2018-04-19T22:39:43Z","git_url":"git://github.com/splitbrain/dokuwiki.git","ssh_url":"git@github.com:splitbrain/dokuwiki.git","clone_url":"https://github.com/splitbrain/dokuwiki.git","svn_url":"https://github.com/splitbrain/dokuwiki","homepage":"http://www.dokuwiki.org","size":33539,"stargazers_count":2105,"watchers_count":2105,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":574,"open_issues":248,"watchers":2105,"default_branch":"master"}},"base":{"label":"splitbrain:master","ref":"master","sha":"0387686cd6e0429b3eaac543c219087f41bf5a35","user":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"repo":{"id":456930,"name":"dokuwiki","full_name":"splitbrain/dokuwiki","owner":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splitbrain/dokuwiki","description":"The DokuWiki Open Source Wiki Engine","fork":false,"url":"https://api.github.com/repos/splitbrain/dokuwiki","forks_url":"https://api.github.com/repos/splitbrain/dokuwiki/forks","keys_url":"https://api.github.com/repos/splitbrain/dokuwiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splitbrain/dokuwiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splitbrain/dokuwiki/teams","hooks_url":"https://api.github.com/repos/splitbrain/dokuwiki/hooks","issue_events_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/events{/number}","events_url":"https://api.github.com/repos/splitbrain/dokuwiki/events","assignees_url":"https://api.github.com/repos/splitbrain/dokuwiki/assignees{/user}","branches_url":"https://api.github.com/repos/splitbrain/dokuwiki/branches{/branch}","tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/tags","blobs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/{sha}","languages_url":"https://api.github.com/repos/splitbrain/dokuwiki/languages","stargazers_url":"https://api.github.com/repos/splitbrain/dokuwiki/stargazers","contributors_url":"https://api.github.com/repos/splitbrain/dokuwiki/contributors","subscribers_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscribers","subscription_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscription","commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/splitbrain/dokuwiki/contents/{+path}","compare_url":"https://api.github.com/repos/splitbrain/dokuwiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splitbrain/dokuwiki/merges","archive_url":"https://api.github.com/repos/splitbrain/dokuwiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splitbrain/dokuwiki/downloads","issues_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues{/number}","pulls_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls{/number}","milestones_url":"https://api.github.com/repos/splitbrain/dokuwiki/milestones{/number}","notifications_url":"https://api.github.com/repos/splitbrain/dokuwiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/labels{/name}","releases_url":"https://api.github.com/repos/splitbrain/dokuwiki/releases{/id}","deployments_url":"https://api.github.com/repos/splitbrain/dokuwiki/deployments","created_at":"2010-01-03T13:47:20Z","updated_at":"2018-04-19T21:42:15Z","pushed_at":"2018-04-19T22:39:43Z","git_url":"git://github.com/splitbrain/dokuwiki.git","ssh_url":"git@github.com:splitbrain/dokuwiki.git","clone_url":"https://github.com/splitbrain/dokuwiki.git","svn_url":"https://github.com/splitbrain/dokuwiki","homepage":"http://www.dokuwiki.org","size":33539,"stargazers_count":2105,"watchers_count":2105,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":574,"open_issues":248,"watchers":2105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314"},"html":{"href":"https://github.com/splitbrain/dokuwiki/pull/2314"},"issue":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2314"},"comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2314/comments"},"review_comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314/comments"},"review_comment":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2314/commits"},"statuses":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/b12bcb7787ac8838fb69ab637f8324983c84fbee"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Rocreex"}}