{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/209269024","pull_request_review_id":145253472,"id":209269024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI2OTAyNA==","diff_hunk":"@@ -324,3 +324,9 @@ bowling_bash_area: 0\n // punch a hole into SG it will for example create a \"suck in\" effect.\n // If you disable this setting, the knockback direction will be completely random (eAthena style).\n stormgust_knockback: true\n+\n+// In eAthena, Magic Rod's animation would not occur unless a spell was absorbed.\n+// In official, Magic Rod's animation occurs every time it is used.\n+// false: Official behavior\n+// true: Old eAthena behavior\n+eathena_magicrod: false","path":"conf/map/battle/skill.conf","position":9,"original_position":9,"commit_id":"716e50c6b8bea2a1c33e5cc7978a459ca09d33f7","original_commit_id":"716e50c6b8bea2a1c33e5cc7978a459ca09d33f7","user":{"login":"kyeme","id":4656578,"node_id":"MDQ6VXNlcjQ2NTY1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4656578?v=4","gravatar_id":"","url":"https://api.github.com/users/kyeme","html_url":"https://github.com/kyeme","followers_url":"https://api.github.com/users/kyeme/followers","following_url":"https://api.github.com/users/kyeme/following{/other_user}","gists_url":"https://api.github.com/users/kyeme/gists{/gist_id}","starred_url":"https://api.github.com/users/kyeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyeme/subscriptions","organizations_url":"https://api.github.com/users/kyeme/orgs","repos_url":"https://api.github.com/users/kyeme/repos","events_url":"https://api.github.com/users/kyeme/events{/privacy}","received_events_url":"https://api.github.com/users/kyeme/received_events","type":"User","site_admin":false},"body":"I think it's better configuration name is\r\n\r\nmagicrod_type: 0","created_at":"2018-08-10T14:01:26Z","updated_at":"2018-08-10T14:01:26Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2034#discussion_r209269024","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/209269024"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2034#discussion_r209269024"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034"}},"in_reply_to_id":192572004},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034","id":186332807,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MzMyODA3","html_url":"https://github.com/HerculesWS/Hercules/pull/2034","diff_url":"https://github.com/HerculesWS/Hercules/pull/2034.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2034.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2034","number":2034,"state":"open","locked":false,"title":"Adds configuration for Magic Rod behavior (official/eAthena).","user":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\n[//]: # (Describe at length, the changes that this pull request makes.)\r\nAdds a battleconf option for Magic Rod behavior, allowing a choice between official and old eAthena.\r\n- Official: Every time you use the Magic Rod skill, the animation will occur.\r\n- eAthena: The animation for Magic Rod will only occur when you absorb a spell.\r\n\r\n**Affected Branches:** \r\n\r\n[//]: # (Master? Slave?)\r\nMaster.\r\n\r\n**Issues addressed:**\r\n\r\n[//]: # (Issue Tracker Number if any.)\r\nNone.\r\n\r\n[//]: # (Insert checklist here)\r\n[//]: # (Syntax: - [ ] Checkbox)\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n","created_at":"2018-05-07T12:07:52Z","updated_at":"2018-08-10T14:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4aea4179000a2b8e638bbcd8d74e18efe01e711","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2034/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/716e50c6b8bea2a1c33e5cc7978a459ca09d33f7","head":{"label":"EyesOfAHawk:magic_rod","ref":"magic_rod","sha":"716e50c6b8bea2a1c33e5cc7978a459ca09d33f7","user":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"repo":{"id":120781877,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3ODE4Nzc=","name":"Hercules","full_name":"EyesOfAHawk/Hercules","owner":{"login":"EyesOfAHawk","id":19625018,"node_id":"MDQ6VXNlcjE5NjI1MDE4","avatar_url":"https://avatars3.githubusercontent.com/u/19625018?v=4","gravatar_id":"","url":"https://api.github.com/users/EyesOfAHawk","html_url":"https://github.com/EyesOfAHawk","followers_url":"https://api.github.com/users/EyesOfAHawk/followers","following_url":"https://api.github.com/users/EyesOfAHawk/following{/other_user}","gists_url":"https://api.github.com/users/EyesOfAHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/EyesOfAHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EyesOfAHawk/subscriptions","organizations_url":"https://api.github.com/users/EyesOfAHawk/orgs","repos_url":"https://api.github.com/users/EyesOfAHawk/repos","events_url":"https://api.github.com/users/EyesOfAHawk/events{/privacy}","received_events_url":"https://api.github.com/users/EyesOfAHawk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EyesOfAHawk/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/EyesOfAHawk/Hercules","forks_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/forks","keys_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/teams","hooks_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/hooks","issue_events_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/events","assignees_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/tags","blobs_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/languages","stargazers_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/stargazers","contributors_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/contributors","subscribers_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/subscribers","subscription_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/subscription","commits_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/merges","archive_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/downloads","issues_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/EyesOfAHawk/Hercules/deployments","created_at":"2018-02-08T15:48:33Z","updated_at":"2018-08-06T15:19:53Z","pushed_at":"2018-08-10T13:32:54Z","git_url":"git://github.com/EyesOfAHawk/Hercules.git","ssh_url":"git@github.com:EyesOfAHawk/Hercules.git","clone_url":"https://github.com/EyesOfAHawk/Hercules.git","svn_url":"https://github.com/EyesOfAHawk/Hercules","homepage":"http://herc.ws","size":172781,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"5c9056c183421df41b546dc3031d251ee6c963b5","user":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"node_id":"MDEwOlJlcG9zaXRvcnk3NTUxNDI5","name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2018-08-03T19:10:32Z","pushed_at":"2018-08-10T13:34:55Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":188919,"stargazers_count":431,"watchers_count":431,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":538,"open_issues":426,"watchers":431,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2034"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2034"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2034/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2034/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/716e50c6b8bea2a1c33e5cc7978a459ca09d33f7"}},"author_association":"NONE"}}
{"actor":{"display_login":"kyeme"}}