{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/170892467","pull_request_review_id":99647780,"id":170892467,"diff_hunk":"@@ -0,0 +1,23 @@\n+var DropdownAdminView = require('dashboard/components/dropdown/dropdown-admin-view');\n+\n+/**\n+ * The content of the dropdown menu opened by the link at the end of the breadcrumbs menu, e.g.\n+ *   username / Maps v\n+ *            ______/\\____\n+ *           |            |\n+ *           |    this    |\n+ *           |____________|\n+ */\n+module.exports = DropdownAdminView.extend({\n+  className: 'Dropdown',\n+\n+  render: function () {\n+    return this;","path":"lib/assets/javascripts/dashboard/components/user-info/dropdown-view.js","position":15,"original_position":15,"commit_id":"f9bb238ddf1488f3f600308663973f29e4e5aa14","original_commit_id":"f9bb238ddf1488f3f600308663973f29e4e5aa14","user":{"login":"rjimenezda","id":446970,"avatar_url":"https://avatars1.githubusercontent.com/u/446970?v=4","gravatar_id":"","url":"https://api.github.com/users/rjimenezda","html_url":"https://github.com/rjimenezda","followers_url":"https://api.github.com/users/rjimenezda/followers","following_url":"https://api.github.com/users/rjimenezda/following{/other_user}","gists_url":"https://api.github.com/users/rjimenezda/gists{/gist_id}","starred_url":"https://api.github.com/users/rjimenezda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjimenezda/subscriptions","organizations_url":"https://api.github.com/users/rjimenezda/orgs","repos_url":"https://api.github.com/users/rjimenezda/repos","events_url":"https://api.github.com/users/rjimenezda/events{/privacy}","received_events_url":"https://api.github.com/users/rjimenezda/received_events","type":"User","site_admin":false},"body":"This Dropdown does not have any JS template, it's a node module. So if we call the super render it might* mess with the DOM\r\n\r\n*to be honest I did a lot of changes around this. It might not be necessary, I'll check.","created_at":"2018-02-27T11:28:55Z","updated_at":"2018-02-27T11:28:55Z","html_url":"https://github.com/CartoDB/cartodb/pull/13620#discussion_r170892467","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/170892467"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13620#discussion_r170892467"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620"}},"in_reply_to_id":170885430},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620","id":171423756,"html_url":"https://github.com/CartoDB/cartodb/pull/13620","diff_url":"https://github.com/CartoDB/cartodb/pull/13620.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13620.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13620","number":13620,"state":"open","locked":false,"title":"Public dashboard migration","user":{"login":"rjimenezda","id":446970,"avatar_url":"https://avatars1.githubusercontent.com/u/446970?v=4","gravatar_id":"","url":"https://api.github.com/users/rjimenezda","html_url":"https://github.com/rjimenezda","followers_url":"https://api.github.com/users/rjimenezda/followers","following_url":"https://api.github.com/users/rjimenezda/following{/other_user}","gists_url":"https://api.github.com/users/rjimenezda/gists{/gist_id}","starred_url":"https://api.github.com/users/rjimenezda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjimenezda/subscriptions","organizations_url":"https://api.github.com/users/rjimenezda/orgs","repos_url":"https://api.github.com/users/rjimenezda/repos","events_url":"https://api.github.com/users/rjimenezda/events{/privacy}","received_events_url":"https://api.github.com/users/rjimenezda/received_events","type":"User","site_admin":false},"body":"This PR migrates the whole public dashboard part to carto.js 4, backbone 1.2 & so on.\r\n\r\nIt affects views that change for organizations, so in order to decide whether to show the new dashboard, the organization has to have builder_enabled & the organization owner needs to have the appropriate feature flag.\r\n\r\nI've also fixed the like button, which had some issues because of a previous refactor, and the old backbone.core-model \r\n\r\nThis will have the same issues as the user-feed, as mentioned on https://github.com/CartoDB/cartodb/issues/13534","created_at":"2018-02-26T16:26:35Z","updated_at":"2018-02-27T11:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf91f197e23eaa4d2f24e70b94fb69b00ae9bc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13620/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/f9bb238ddf1488f3f600308663973f29e4e5aa14","head":{"label":"CartoDB:public-dashboard-migration","ref":"public-dashboard-migration","sha":"f9bb238ddf1488f3f600308663973f29e4e5aa14","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-02-25T16:41:40Z","pushed_at":"2018-02-27T11:26:51Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":366757,"stargazers_count":1764,"watchers_count":1764,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":488,"mirror_url":null,"archived":false,"open_issues_count":482,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":488,"open_issues":482,"watchers":1764,"default_branch":"master"}},"base":{"label":"CartoDB:api-keys-dashboard","ref":"api-keys-dashboard","sha":"3b91c1a06f66ece4bf3cc0ddc531574d5727c6e3","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-02-25T16:41:40Z","pushed_at":"2018-02-27T11:26:51Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":366757,"stargazers_count":1764,"watchers_count":1764,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":488,"mirror_url":null,"archived":false,"open_issues_count":482,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":488,"open_issues":482,"watchers":1764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13620"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13620"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13620/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13620/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/f9bb238ddf1488f3f600308663973f29e4e5aa14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rjimenezda"}}