{"action":"closed","number":598,"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598","id":194578904,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTc4OTA0","html_url":"https://github.com/theforeman/puppet-puppet/pull/598","diff_url":"https://github.com/theforeman/puppet-puppet/pull/598.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/598.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/598","number":598,"state":"closed","locked":false,"title":"Support ssl-protocols option for puppetserver configuration","user":{"login":"stbenjam","id":429763,"node_id":"MDQ6VXNlcjQyOTc2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/429763?v=4","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"body":"When the initial puppetserver configs were done, I think there was some confusion about the various TLS settings for puppetserver.  Currently server_ssl_protocols and server_cipher_suites limit what puppetserver [will use as a client](https://github.com/theforeman/puppet-puppet/blob/master/templates/server/puppetserver/conf.d/puppetserver.conf.erb#L81-L95).  To also restrict what the server makes available, it needs to be done in webserver.conf, too.\r\n","created_at":"2018-06-13T13:03:09Z","updated_at":"2018-06-13T20:45:01Z","closed_at":"2018-06-13T20:45:01Z","merged_at":"2018-06-13T20:45:00Z","merge_commit_sha":"e0c6e7118387f556bb62f4dec0590e192d82e640","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":794027057,"node_id":"MDU6TGFiZWw3OTQwMjcwNTc=","url":"https://api.github.com/repos/theforeman/puppet-puppet/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/598/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/9c3109d366a8caf5e6136e55453823f24e4071e8","head":{"label":"stbenjam:ssl-proto","ref":"ssl-proto","sha":"9c3109d366a8caf5e6136e55453823f24e4071e8","user":{"login":"stbenjam","id":429763,"node_id":"MDQ6VXNlcjQyOTc2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/429763?v=4","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"repo":{"id":137212910,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMTI5MTA=","name":"puppet-puppet","full_name":"stbenjam/puppet-puppet","owner":{"login":"stbenjam","id":429763,"node_id":"MDQ6VXNlcjQyOTc2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/429763?v=4","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stbenjam/puppet-puppet","description":"Puppet module for Puppet client and server","fork":true,"url":"https://api.github.com/repos/stbenjam/puppet-puppet","forks_url":"https://api.github.com/repos/stbenjam/puppet-puppet/forks","keys_url":"https://api.github.com/repos/stbenjam/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stbenjam/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stbenjam/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/stbenjam/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/stbenjam/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/stbenjam/puppet-puppet/events","assignees_url":"https://api.github.com/repos/stbenjam/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/stbenjam/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/stbenjam/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/stbenjam/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stbenjam/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stbenjam/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/stbenjam/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stbenjam/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/stbenjam/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/stbenjam/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/stbenjam/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/stbenjam/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/stbenjam/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/stbenjam/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/stbenjam/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/stbenjam/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/stbenjam/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/stbenjam/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/stbenjam/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stbenjam/puppet-puppet/merges","archive_url":"https://api.github.com/repos/stbenjam/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stbenjam/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/stbenjam/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/stbenjam/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/stbenjam/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/stbenjam/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stbenjam/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/stbenjam/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/stbenjam/puppet-puppet/deployments","created_at":"2018-06-13T12:32:29Z","updated_at":"2018-06-13T12:32:31Z","pushed_at":"2018-06-13T13:34:07Z","git_url":"git://github.com/stbenjam/puppet-puppet.git","ssh_url":"git@github.com:stbenjam/puppet-puppet.git","clone_url":"https://github.com/stbenjam/puppet-puppet.git","svn_url":"https://github.com/stbenjam/puppet-puppet","homepage":"","size":1286,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"1070b619d98b8f78952879f8af1fcd85e1b71eb4","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449635,"node_id":"MDEwOlJlcG9zaXRvcnkzNDQ5NjM1","name":"puppet-puppet","full_name":"theforeman/puppet-puppet","owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-puppet","description":"Puppet module for Puppet client and server","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-puppet","forks_url":"https://api.github.com/repos/theforeman/puppet-puppet/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-puppet/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-puppet/deployments","created_at":"2012-02-15T13:23:34Z","updated_at":"2018-05-29T09:43:11Z","pushed_at":"2018-06-13T20:45:00Z","git_url":"git://github.com/theforeman/puppet-puppet.git","ssh_url":"git@github.com:theforeman/puppet-puppet.git","clone_url":"https://github.com/theforeman/puppet-puppet.git","svn_url":"https://github.com/theforeman/puppet-puppet","homepage":"","size":1284,"stargazers_count":73,"watchers_count":73,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":183,"open_issues":10,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/598"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/598"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/9c3109d366a8caf5e6136e55453823f24e4071e8"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":43,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"ekohl"}}