{"action":"created","issue":{"url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/267","repository_url":"https://api.github.com/repos/dhlab-basel/Sipi","labels_url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/267/comments","events_url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/267/events","html_url":"https://github.com/dhlab-basel/Sipi/pull/267","id":372092162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzkxNjk0","number":267,"title":"Knora integration","user":{"login":"lrosenth","id":5471692,"node_id":"MDQ6VXNlcjU0NzE2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5471692?v=4","gravatar_id":"","url":"https://api.github.com/users/lrosenth","html_url":"https://github.com/lrosenth","followers_url":"https://api.github.com/users/lrosenth/followers","following_url":"https://api.github.com/users/lrosenth/following{/other_user}","gists_url":"https://api.github.com/users/lrosenth/gists{/gist_id}","starred_url":"https://api.github.com/users/lrosenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrosenth/subscriptions","organizations_url":"https://api.github.com/users/lrosenth/orgs","repos_url":"https://api.github.com/users/lrosenth/repos","events_url":"https://api.github.com/users/lrosenth/events{/privacy}","received_events_url":"https://api.github.com/users/lrosenth/received_events","type":"User","site_admin":false},"labels":[{"id":343710713,"node_id":"MDU6TGFiZWwzNDM3MTA3MTM=","url":"https://api.github.com/repos/dhlab-basel/Sipi/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":623437267,"node_id":"MDU6TGFiZWw2MjM0MzcyNjc=","url":"https://api.github.com/repos/dhlab-basel/Sipi/labels/ready-for-review","name":"ready-for-review","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":{"login":"lrosenth","id":5471692,"node_id":"MDQ6VXNlcjU0NzE2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5471692?v=4","gravatar_id":"","url":"https://api.github.com/users/lrosenth","html_url":"https://github.com/lrosenth","followers_url":"https://api.github.com/users/lrosenth/followers","following_url":"https://api.github.com/users/lrosenth/following{/other_user}","gists_url":"https://api.github.com/users/lrosenth/gists{/gist_id}","starred_url":"https://api.github.com/users/lrosenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrosenth/subscriptions","organizations_url":"https://api.github.com/users/lrosenth/orgs","repos_url":"https://api.github.com/users/lrosenth/repos","events_url":"https://api.github.com/users/lrosenth/events{/privacy}","received_events_url":"https://api.github.com/users/lrosenth/received_events","type":"User","site_admin":false},"assignees":[{"login":"lrosenth","id":5471692,"node_id":"MDQ6VXNlcjU0NzE2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5471692?v=4","gravatar_id":"","url":"https://api.github.com/users/lrosenth","html_url":"https://github.com/lrosenth","followers_url":"https://api.github.com/users/lrosenth/followers","following_url":"https://api.github.com/users/lrosenth/following{/other_user}","gists_url":"https://api.github.com/users/lrosenth/gists{/gist_id}","starred_url":"https://api.github.com/users/lrosenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrosenth/subscriptions","organizations_url":"https://api.github.com/users/lrosenth/orgs","repos_url":"https://api.github.com/users/lrosenth/repos","events_url":"https://api.github.com/users/lrosenth/events{/privacy}","received_events_url":"https://api.github.com/users/lrosenth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-19T19:45:36Z","updated_at":"2018-10-31T11:17:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dhlab-basel/Sipi/pulls/267","html_url":"https://github.com/dhlab-basel/Sipi/pull/267","diff_url":"https://github.com/dhlab-basel/Sipi/pull/267.diff","patch_url":"https://github.com/dhlab-basel/Sipi/pull/267.patch"},"body":"I added the url http://iiiif.server/directory/imgid.jp2/knora.json which returns a json containing\r\nthe required image information:\r\n\r\n```\r\n{\r\n\"width\": 512,\r\n\"height\": 512,\r\n\"mimetype\": \"image/tiff\",\r\n\"origname\": \"lena512.tif\"\r\n}\r\n```\r\nI added unittests for this feature and for getting info.json"},"comment":{"url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/comments/434649499","html_url":"https://github.com/dhlab-basel/Sipi/pull/267#issuecomment-434649499","issue_url":"https://api.github.com/repos/dhlab-basel/Sipi/issues/267","id":434649499,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDY0OTQ5OQ==","user":{"login":"lrosenth","id":5471692,"node_id":"MDQ6VXNlcjU0NzE2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5471692?v=4","gravatar_id":"","url":"https://api.github.com/users/lrosenth","html_url":"https://github.com/lrosenth","followers_url":"https://api.github.com/users/lrosenth/followers","following_url":"https://api.github.com/users/lrosenth/following{/other_user}","gists_url":"https://api.github.com/users/lrosenth/gists{/gist_id}","starred_url":"https://api.github.com/users/lrosenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrosenth/subscriptions","organizations_url":"https://api.github.com/users/lrosenth/orgs","repos_url":"https://api.github.com/users/lrosenth/repos","events_url":"https://api.github.com/users/lrosenth/events{/privacy}","received_events_url":"https://api.github.com/users/lrosenth/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T11:17:11Z","updated_at":"2018-10-31T11:17:11Z","author_association":"CONTRIBUTOR","body":"Yes, that's true. I can add the the mimetype is added automatically in any case – even if the original name is not known. Some Skype??\r\n\r\n\r\nAm 31.10.2018 um 12:15 schrieb Benjamin Geer <notifications@github.com<mailto:notifications@github.com>>:\r\n\r\n\r\nWhen reading (SipiImage.new()) the file, the mimetype is determined (using the magic library) and inserted\r\n\r\nI don't think so. Using the complex form of SipiImage.new, the resulting jp2 file contains SIPI:density.tiff|image/tiff|sha256|6b188905b8def1f1158e8ef0263475c98dea512af4dc14dfca6e8f6cc1e53cb1|IGNORE_ICC|NULL.\r\n\r\nUsing the simple form of SipiImage.new, the resulting jp2 file doesn't contain SIPI: or image/tiff.\r\n\r\n—\r\nYou are receiving this because you were assigned.\r\nReply to this email directly, view it on GitHub<https://github.com/dhlab-basel/Sipi/pull/267#issuecomment-434649087>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFN9zPQJPoBAwbEEHcnd_UxBr9j99ikSks5uqYZVgaJpZM4XxUJR>.\r\n\r\n"}}
{"actor":{"display_login":"lrosenth"}}