{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/244978399","pull_request_review_id":188984085,"id":244978399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk3ODM5OQ==","diff_hunk":"@@ -0,0 +1,34 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.activemq.artemis.core.server.impl;\n+\n+import org.apache.activemq.artemis.core.server.PriorityAware;\n+\n+import java.util.Collection;\n+import java.util.Set;\n+\n+public interface QueueConsumers<T extends PriorityAware> extends Collection<T> {\n+\n+   Set<Integer> getPriorites();","path":"artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java","position":26,"original_position":26,"commit_id":"61a91701f3d424d31a83d9942f7786c90ac81559","original_commit_id":"61a91701f3d424d31a83d9942f7786c90ac81559","user":{"login":"franz1981","id":13125299,"node_id":"MDQ6VXNlcjEzMTI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/13125299?v=4","gravatar_id":"","url":"https://api.github.com/users/franz1981","html_url":"https://github.com/franz1981","followers_url":"https://api.github.com/users/franz1981/followers","following_url":"https://api.github.com/users/franz1981/following{/other_user}","gists_url":"https://api.github.com/users/franz1981/gists{/gist_id}","starred_url":"https://api.github.com/users/franz1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz1981/subscriptions","organizations_url":"https://api.github.com/users/franz1981/orgs","repos_url":"https://api.github.com/users/franz1981/repos","events_url":"https://api.github.com/users/franz1981/events{/privacy}","received_events_url":"https://api.github.com/users/franz1981/received_events","type":"User","site_admin":false},"body":"I know that's just a test method, so feel free to ignore me, but I would just use a byte[] here :P","created_at":"2019-01-03T11:57:12Z","updated_at":"2019-01-03T11:57:13Z","html_url":"https://github.com/apache/activemq-artemis/pull/2488#discussion_r244978399","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/244978399"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2488#discussion_r244978399"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488"}}},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488","id":241960992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTYwOTky","html_url":"https://github.com/apache/activemq-artemis/pull/2488","diff_url":"https://github.com/apache/activemq-artemis/pull/2488.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2488.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2488","number":2488,"state":"open","locked":false,"title":"ARTEMIS-196 Implement Consumer Priority","user":{"login":"michaelandrepearce","id":1387822,"node_id":"MDQ6VXNlcjEzODc4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"body":"Add consumer priority support\r\nIncludes refactor of consumer iterating in QueueImpl to its own logical class, to be able to implement.\r\nAdd OpenWire JMS Test - taken from ActiveMQ5\r\nAdd Core JMS Test\r\nAdd AMQP Test\r\nAdd Docs","created_at":"2019-01-03T10:52:27Z","updated_at":"2019-01-03T11:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0075f8f7a413a6325d5776e6fcfefb568a2c2e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2488/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/61a91701f3d424d31a83d9942f7786c90ac81559","head":{"label":"michaelandrepearce:ARTEMIS-196","ref":"ARTEMIS-196","sha":"61a91701f3d424d31a83d9942f7786c90ac81559","user":{"login":"michaelandrepearce","id":1387822,"node_id":"MDQ6VXNlcjEzODc4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"repo":{"id":90807775,"node_id":"MDEwOlJlcG9zaXRvcnk5MDgwNzc3NQ==","name":"activemq-artemis","full_name":"michaelandrepearce/activemq-artemis","private":false,"owner":{"login":"michaelandrepearce","id":1387822,"node_id":"MDQ6VXNlcjEzODc4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michaelandrepearce/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis","forks_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/forks","keys_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/events","assignees_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/merges","archive_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/michaelandrepearce/activemq-artemis/deployments","created_at":"2017-05-10T01:29:30Z","updated_at":"2017-05-10T01:29:44Z","pushed_at":"2019-01-03T10:51:55Z","git_url":"git://github.com/michaelandrepearce/activemq-artemis.git","ssh_url":"git@github.com:michaelandrepearce/activemq-artemis.git","clone_url":"https://github.com/michaelandrepearce/activemq-artemis.git","svn_url":"https://github.com/michaelandrepearce/activemq-artemis","homepage":"","size":57976,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c7bd5605fe58ce33dd30d57a29ae3ea928a3735","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA1NzI2MA==","name":"activemq-artemis","full_name":"apache/activemq-artemis","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2018-12-28T16:47:09Z","pushed_at":"2019-01-03T11:16:32Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":56547,"stargazers_count":378,"watchers_count":378,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":402,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":402,"open_issues":38,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2488"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2488"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2488/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2488/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/61a91701f3d424d31a83d9942f7786c90ac81559"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"franz1981"}}