{"action":"created","issue":{"url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/299","repository_url":"https://api.github.com/repos/NightscoutFoundation/xDrip","labels_url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/299/comments","events_url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/299/events","html_url":"https://github.com/NightscoutFoundation/xDrip/pull/299","id":296144691,"number":299,"title":"Tzachi trend 2","user":{"login":"tzachi-dar","id":7942372,"avatar_url":"https://avatars2.githubusercontent.com/u/7942372?v=4","gravatar_id":"","url":"https://api.github.com/users/tzachi-dar","html_url":"https://github.com/tzachi-dar","followers_url":"https://api.github.com/users/tzachi-dar/followers","following_url":"https://api.github.com/users/tzachi-dar/following{/other_user}","gists_url":"https://api.github.com/users/tzachi-dar/gists{/gist_id}","starred_url":"https://api.github.com/users/tzachi-dar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzachi-dar/subscriptions","organizations_url":"https://api.github.com/users/tzachi-dar/orgs","repos_url":"https://api.github.com/users/tzachi-dar/repos","events_url":"https://api.github.com/users/tzachi-dar/events{/privacy}","received_events_url":"https://api.github.com/users/tzachi-dar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-10T23:45:16Z","updated_at":"2018-02-13T20:50:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NightscoutFoundation/xDrip/pulls/299","html_url":"https://github.com/NightscoutFoundation/xDrip/pull/299","diff_url":"https://github.com/NightscoutFoundation/xDrip/pull/299.diff","patch_url":"https://github.com/NightscoutFoundation/xDrip/pull/299.patch"},"body":"This pr adds a graph with latest bg data for the latest 15 minutes.\r\n\r\n![screenshot_20180211-014207 1](https://user-images.githubusercontent.com/7942372/36067775-32acfeb6-0ecd-11e8-823c-fef1c56778b0.png)\r\n"},"comment":{"url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/comments/365399690","html_url":"https://github.com/NightscoutFoundation/xDrip/pull/299#issuecomment-365399690","issue_url":"https://api.github.com/repos/NightscoutFoundation/xDrip/issues/299","id":365399690,"user":{"login":"tzachi-dar","id":7942372,"avatar_url":"https://avatars2.githubusercontent.com/u/7942372?v=4","gravatar_id":"","url":"https://api.github.com/users/tzachi-dar","html_url":"https://github.com/tzachi-dar","followers_url":"https://api.github.com/users/tzachi-dar/followers","following_url":"https://api.github.com/users/tzachi-dar/following{/other_user}","gists_url":"https://api.github.com/users/tzachi-dar/gists{/gist_id}","starred_url":"https://api.github.com/users/tzachi-dar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzachi-dar/subscriptions","organizations_url":"https://api.github.com/users/tzachi-dar/orgs","repos_url":"https://api.github.com/users/tzachi-dar/repos","events_url":"https://api.github.com/users/tzachi-dar/events{/privacy}","received_events_url":"https://api.github.com/users/tzachi-dar/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T20:50:32Z","updated_at":"2018-02-13T20:50:32Z","author_association":"CONTRIBUTOR","body":"After playing with this PR for a few days, seems that there is one thing that still needs improvement:\r\n\r\nConsider a scan that was done on time X. And then another scan that was done on time x+3 minutes.\r\nThe scan on x+3 minutes has a libreblock data, but no bg was created for it (xDrip is looking for 4 minutes difference).\r\n\r\nIn order to draw the correct trend, I need to read the BG data that was created on time x+3.\r\n\r\nI can store it in memory, but I think that storing it on the LibreBlock is better.\r\n\r\nShould I extend the libre block for this or do you think that another solution will be better?\r\n\r\n"}}
{"actor":{"display_login":"tzachi-dar"}}