{"action":"created","comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/170063821","pull_request_review_id":98693019,"id":170063821,"diff_hunk":"@@ -0,0 +1,133 @@\n+/*\n+ * This software is distributed under BSD 3-clause license (see LICENSE file).\n+ *\n+ * Authors: Heiko Strathmann, Dhruv Arya\n+ */\n+\n+#ifndef _SIGMOID_CALIBRATION_H__\n+#define _SIGMOID_CALIBRATION_H__\n+\n+#include <shogun/lib/config.h>\n+\n+#include <shogun/evaluation/Calibration.h>\n+#include <shogun/mathematics/Statistics.h>\n+\n+\n+namespace shogun\n+{\n+\t/** @brief Calibrates labels based on Platt Scaling [1]. Note that first calibration parameters need to be fitted by \n+\t* calling fit_binary() or fit_multiclass(). Then call calibrate on calibrate_binary() or calibrate_multiclass() on ","path":"src/shogun/evaluation/SigmoidCalibration.h","position":19,"original_position":19,"commit_id":"64c86ace700136eee400dda5e6215fd77cbb42cc","original_commit_id":"9474e30f873c7a3324e7882f637cc7a39398467c","user":{"login":"durovo","id":13575093,"avatar_url":"https://avatars3.githubusercontent.com/u/13575093?v=4","gravatar_id":"","url":"https://api.github.com/users/durovo","html_url":"https://github.com/durovo","followers_url":"https://api.github.com/users/durovo/followers","following_url":"https://api.github.com/users/durovo/following{/other_user}","gists_url":"https://api.github.com/users/durovo/gists{/gist_id}","starred_url":"https://api.github.com/users/durovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durovo/subscriptions","organizations_url":"https://api.github.com/users/durovo/orgs","repos_url":"https://api.github.com/users/durovo/repos","events_url":"https://api.github.com/users/durovo/events{/privacy}","received_events_url":"https://api.github.com/users/durovo/received_events","type":"User","site_admin":false},"body":"The length of the parameter vector is checked in calibrate now and an appropriate message is displayed.","created_at":"2018-02-22T19:16:18Z","updated_at":"2018-02-22T19:16:19Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/4166#discussion_r170063821","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/170063821"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/4166#discussion_r170063821"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166"}},"in_reply_to_id":170023628},"pull_request":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166","id":168314622,"html_url":"https://github.com/shogun-toolbox/shogun/pull/4166","diff_url":"https://github.com/shogun-toolbox/shogun/pull/4166.diff","patch_url":"https://github.com/shogun-toolbox/shogun/pull/4166.patch","issue_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/4166","number":4166,"state":"open","locked":false,"title":"WIP: Fix platt scaling","user":{"login":"durovo","id":13575093,"avatar_url":"https://avatars3.githubusercontent.com/u/13575093?v=4","gravatar_id":"","url":"https://api.github.com/users/durovo","html_url":"https://github.com/durovo","followers_url":"https://api.github.com/users/durovo/followers","following_url":"https://api.github.com/users/durovo/following{/other_user}","gists_url":"https://api.github.com/users/durovo/gists{/gist_id}","starred_url":"https://api.github.com/users/durovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durovo/subscriptions","organizations_url":"https://api.github.com/users/durovo/orgs","repos_url":"https://api.github.com/users/durovo/repos","events_url":"https://api.github.com/users/durovo/events{/privacy}","received_events_url":"https://api.github.com/users/durovo/received_events","type":"User","site_admin":false},"body":"This PR fixes platt scaling and adds new classes SigmoidCalibration and Calibration. Previously, `fit_sigmoid` was only using the predictions to fit parameters which is incorrect. SigmoidCalibration has been added so that `score_to_probabilites` from `CBinaryLabels` can be removed. This will make the x-validated calibration API cleaner (#4009 ). The old `fit_sigmoid` and `scores_to_probabilities` have still not be removed since they are still needed in multiclass calibration. It would probably be safe to remove them after fixing #4164 ","created_at":"2018-02-09T18:48:15Z","updated_at":"2018-02-22T19:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc380020f6a4eaa91a611788fccd722ef271ce44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166/commits","review_comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166/comments","review_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/4166/comments","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/64c86ace700136eee400dda5e6215fd77cbb42cc","head":{"label":"durovo:feature/platt","ref":"feature/platt","sha":"64c86ace700136eee400dda5e6215fd77cbb42cc","user":{"login":"durovo","id":13575093,"avatar_url":"https://avatars3.githubusercontent.com/u/13575093?v=4","gravatar_id":"","url":"https://api.github.com/users/durovo","html_url":"https://github.com/durovo","followers_url":"https://api.github.com/users/durovo/followers","following_url":"https://api.github.com/users/durovo/following{/other_user}","gists_url":"https://api.github.com/users/durovo/gists{/gist_id}","starred_url":"https://api.github.com/users/durovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durovo/subscriptions","organizations_url":"https://api.github.com/users/durovo/orgs","repos_url":"https://api.github.com/users/durovo/repos","events_url":"https://api.github.com/users/durovo/events{/privacy}","received_events_url":"https://api.github.com/users/durovo/received_events","type":"User","site_admin":false},"repo":{"id":96778116,"name":"shogun","full_name":"durovo/shogun","owner":{"login":"durovo","id":13575093,"avatar_url":"https://avatars3.githubusercontent.com/u/13575093?v=4","gravatar_id":"","url":"https://api.github.com/users/durovo","html_url":"https://github.com/durovo","followers_url":"https://api.github.com/users/durovo/followers","following_url":"https://api.github.com/users/durovo/following{/other_user}","gists_url":"https://api.github.com/users/durovo/gists{/gist_id}","starred_url":"https://api.github.com/users/durovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durovo/subscriptions","organizations_url":"https://api.github.com/users/durovo/orgs","repos_url":"https://api.github.com/users/durovo/repos","events_url":"https://api.github.com/users/durovo/events{/privacy}","received_events_url":"https://api.github.com/users/durovo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/durovo/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":true,"url":"https://api.github.com/repos/durovo/shogun","forks_url":"https://api.github.com/repos/durovo/shogun/forks","keys_url":"https://api.github.com/repos/durovo/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/durovo/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/durovo/shogun/teams","hooks_url":"https://api.github.com/repos/durovo/shogun/hooks","issue_events_url":"https://api.github.com/repos/durovo/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/durovo/shogun/events","assignees_url":"https://api.github.com/repos/durovo/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/durovo/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/durovo/shogun/tags","blobs_url":"https://api.github.com/repos/durovo/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/durovo/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/durovo/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/durovo/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/durovo/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/durovo/shogun/languages","stargazers_url":"https://api.github.com/repos/durovo/shogun/stargazers","contributors_url":"https://api.github.com/repos/durovo/shogun/contributors","subscribers_url":"https://api.github.com/repos/durovo/shogun/subscribers","subscription_url":"https://api.github.com/repos/durovo/shogun/subscription","commits_url":"https://api.github.com/repos/durovo/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/durovo/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/durovo/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/durovo/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/durovo/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/durovo/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/durovo/shogun/merges","archive_url":"https://api.github.com/repos/durovo/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/durovo/shogun/downloads","issues_url":"https://api.github.com/repos/durovo/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/durovo/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/durovo/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/durovo/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/durovo/shogun/labels{/name}","releases_url":"https://api.github.com/repos/durovo/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/durovo/shogun/deployments","created_at":"2017-07-10T13:02:57Z","updated_at":"2017-07-10T13:03:08Z","pushed_at":"2018-02-22T19:11:39Z","git_url":"git://github.com/durovo/shogun.git","ssh_url":"git@github.com:durovo/shogun.git","clone_url":"https://github.com/durovo/shogun.git","svn_url":"https://github.com/durovo/shogun","homepage":"http://shogun.ml","size":63663,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"shogun-toolbox:develop","ref":"develop","sha":"ec4930047c5c84152a2f41ad6da3242ea675c453","user":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars1.githubusercontent.com/u/690673?v=4","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":1555094,"name":"shogun","full_name":"shogun-toolbox/shogun","owner":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars1.githubusercontent.com/u/690673?v=4","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shogun-toolbox/shogun","description":"Shōgun","fork":false,"url":"https://api.github.com/repos/shogun-toolbox/shogun","forks_url":"https://api.github.com/repos/shogun-toolbox/shogun/forks","keys_url":"https://api.github.com/repos/shogun-toolbox/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shogun-toolbox/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shogun-toolbox/shogun/teams","hooks_url":"https://api.github.com/repos/shogun-toolbox/shogun/hooks","issue_events_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/shogun-toolbox/shogun/events","assignees_url":"https://api.github.com/repos/shogun-toolbox/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/shogun-toolbox/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/tags","blobs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/shogun-toolbox/shogun/languages","stargazers_url":"https://api.github.com/repos/shogun-toolbox/shogun/stargazers","contributors_url":"https://api.github.com/repos/shogun-toolbox/shogun/contributors","subscribers_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscribers","subscription_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscription","commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/shogun-toolbox/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/shogun-toolbox/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shogun-toolbox/shogun/merges","archive_url":"https://api.github.com/repos/shogun-toolbox/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shogun-toolbox/shogun/downloads","issues_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/shogun-toolbox/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/labels{/name}","releases_url":"https://api.github.com/repos/shogun-toolbox/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/shogun-toolbox/shogun/deployments","created_at":"2011-04-01T10:44:32Z","updated_at":"2018-02-22T19:13:36Z","pushed_at":"2018-02-22T19:11:42Z","git_url":"git://github.com/shogun-toolbox/shogun.git","ssh_url":"git@github.com:shogun-toolbox/shogun.git","clone_url":"https://github.com/shogun-toolbox/shogun.git","svn_url":"https://github.com/shogun-toolbox/shogun","homepage":"http://shogun.ml","size":64080,"stargazers_count":1954,"watchers_count":1954,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":828,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":828,"open_issues":494,"watchers":1954,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/4166"},"issue":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/4166"},"comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/4166/comments"},"review_comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166/comments"},"review_comment":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/4166/commits"},"statuses":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/64c86ace700136eee400dda5e6215fd77cbb42cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"durovo"}}