{"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/188883154","pull_request_review_id":120948487,"id":188883154,"diff_hunk":"@@ -258,7 +258,7 @@ class ParagraphBlock extends Component {\n \t\t\t\t\t\t\t\tsetAttributes( {\n \t\t\t\t\t\t\t\t\tcontent: before,\n \t\t\t\t\t\t\t\t\tblockFootnotes: parseFootnotesFromContent( before ),\n-\t\t\t\t\t\t\t\t} );\n+\t\t\t\t\t\t\t\t}, false );","path":"core-blocks/paragraph/index.js","position":null,"original_position":5,"commit_id":"9ed68191d03a7b53fd5ff22ae7f11103bcb9c44f","original_commit_id":"9ed68191d03a7b53fd5ff22ae7f11103bcb9c44f","user":{"login":"nb","id":27954,"avatar_url":"https://avatars1.githubusercontent.com/u/27954?v=4","gravatar_id":"","url":"https://api.github.com/users/nb","html_url":"https://github.com/nb","followers_url":"https://api.github.com/users/nb/followers","following_url":"https://api.github.com/users/nb/following{/other_user}","gists_url":"https://api.github.com/users/nb/gists{/gist_id}","starred_url":"https://api.github.com/users/nb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nb/subscriptions","organizations_url":"https://api.github.com/users/nb/orgs","repos_url":"https://api.github.com/users/nb/repos","events_url":"https://api.github.com/users/nb/events{/privacy}","received_events_url":"https://api.github.com/users/nb/received_events","type":"User","site_admin":false},"body":"Reading this code, it's hard for me to understand the purpose of the second argument, it’s just a lonely `false`.","created_at":"2018-05-17T08:53:14Z","updated_at":"2018-05-17T08:53:14Z","html_url":"https://github.com/WordPress/gutenberg/pull/6549#discussion_r188883154","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/188883154"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/6549#discussion_r188883154"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549","id":185590821,"html_url":"https://github.com/WordPress/gutenberg/pull/6549","diff_url":"https://github.com/WordPress/gutenberg/pull/6549.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/6549.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6549","number":6549,"state":"open","locked":false,"title":"[WIP] Add footnotes support to Gutenberg","user":{"login":"Aljullu","id":3616980,"avatar_url":"https://avatars3.githubusercontent.com/u/3616980?v=4","gravatar_id":"","url":"https://api.github.com/users/Aljullu","html_url":"https://github.com/Aljullu","followers_url":"https://api.github.com/users/Aljullu/followers","following_url":"https://api.github.com/users/Aljullu/following{/other_user}","gists_url":"https://api.github.com/users/Aljullu/gists{/gist_id}","starred_url":"https://api.github.com/users/Aljullu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aljullu/subscriptions","organizations_url":"https://api.github.com/users/Aljullu/orgs","repos_url":"https://api.github.com/users/Aljullu/repos","events_url":"https://api.github.com/users/Aljullu/events{/privacy}","received_events_url":"https://api.github.com/users/Aljullu/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is a WIP Pull Request with an implementation of footnotes for Gutenberg. Issue #1890.\r\n\r\n## Screenshots\r\n![Footnotes feature in Gutenber](https://user-images.githubusercontent.com/3616980/39666129-034df328-509f-11e8-854f-5028cb22c401.gif)\r\n\r\n## Types of changes\r\nIt is a new feature which adds footnotes support to the Gutenberg editor.\r\n\r\n### User visible changes\r\nIt adds a button in the toolbar. When clicked, it adds a footnote (a superscript number) in the content and the footnotes block displays a `RichText` input area to enter the text for that footnote.\r\n\r\n<p align=\"center\"><img src=\"https://user-images.githubusercontent.com/3616980/39666335-48cb6f72-50a2-11e8-91b0-22cd90ef88d2.png\" alt=\"Footnotes icon in the toolbar\" /><br>\r\n<i>(the icon is not definitive)</i></p>\r\n\r\n### Internal changes\r\n* Footnotes are stored in a new attribute associated to the block called `blockFootnotes`. For now, only the Paragraph block has footnotes implemented.\r\n* A footnotes block is inserted to the post when the first footnotes is added and removed when the last footnote is removed.\r\n* When blocks are modified, inserted, removed, etc. the footnotes block is updated with the new list of footnotes.\r\n\r\nOpen question: when #5794 lands, might it be a good idea to convert footnotes (the superscript numbers we display in the content) into inline blocks?\r\n\r\n## How has this been tested?\r\nThe relevant parts of the code are covered by tests.\r\n\r\nIn order to test it manually: create or edit a post and focus on a paragraph, a new button should appear in the toolbar allowing you to add footnotes. Once clicked, a footnotes block should appear with a _1._ and an empty space to write the text for the footnote.\r\n\r\n## Checklist:\r\n- [x] Add button to the toolbar that adds a footnote in the code.\r\n- [x] Create footnotes block which allows writing footnotes.\r\n- [x] Use auto-incrementing numbers instead of asterisks for footnotes.\r\n- [x] When published, footnote numbers must link to the associated footnote in the footer.\r\n- [x] Make the footnotes block only exist when there are footnotes in the content.\r\n- [ ] Duplicating blocks with footnotes makes two footnotes to have the same uid _(in progress)_.\r\n- [ ] Improve the delete/copy/paste actions on footnotes in the TinyMCE editor.\r\n- [ ] Options to remove and duplicate the footnotes block should be disabled.\r\n- [ ] Allow adding footnotes in blocks other than paragraphs.\r\n- [ ] Use a specific icon for the footnotes button.\r\n","created_at":"2018-05-03T00:01:35Z","updated_at":"2018-05-17T08:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7adc22212752fc58645fc86506d3f7a69d75cb72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6549/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/9ed68191d03a7b53fd5ff22ae7f11103bcb9c44f","head":{"label":"Aljullu:add/footnotes","ref":"add/footnotes","sha":"9ed68191d03a7b53fd5ff22ae7f11103bcb9c44f","user":{"login":"Aljullu","id":3616980,"avatar_url":"https://avatars3.githubusercontent.com/u/3616980?v=4","gravatar_id":"","url":"https://api.github.com/users/Aljullu","html_url":"https://github.com/Aljullu","followers_url":"https://api.github.com/users/Aljullu/followers","following_url":"https://api.github.com/users/Aljullu/following{/other_user}","gists_url":"https://api.github.com/users/Aljullu/gists{/gist_id}","starred_url":"https://api.github.com/users/Aljullu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aljullu/subscriptions","organizations_url":"https://api.github.com/users/Aljullu/orgs","repos_url":"https://api.github.com/users/Aljullu/repos","events_url":"https://api.github.com/users/Aljullu/events{/privacy}","received_events_url":"https://api.github.com/users/Aljullu/received_events","type":"User","site_admin":false},"repo":{"id":130592356,"name":"gutenberg","full_name":"Aljullu/gutenberg","owner":{"login":"Aljullu","id":3616980,"avatar_url":"https://avatars3.githubusercontent.com/u/3616980?v=4","gravatar_id":"","url":"https://api.github.com/users/Aljullu","html_url":"https://github.com/Aljullu","followers_url":"https://api.github.com/users/Aljullu/followers","following_url":"https://api.github.com/users/Aljullu/following{/other_user}","gists_url":"https://api.github.com/users/Aljullu/gists{/gist_id}","starred_url":"https://api.github.com/users/Aljullu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aljullu/subscriptions","organizations_url":"https://api.github.com/users/Aljullu/orgs","repos_url":"https://api.github.com/users/Aljullu/repos","events_url":"https://api.github.com/users/Aljullu/events{/privacy}","received_events_url":"https://api.github.com/users/Aljullu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aljullu/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":true,"url":"https://api.github.com/repos/Aljullu/gutenberg","forks_url":"https://api.github.com/repos/Aljullu/gutenberg/forks","keys_url":"https://api.github.com/repos/Aljullu/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aljullu/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aljullu/gutenberg/teams","hooks_url":"https://api.github.com/repos/Aljullu/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/Aljullu/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/Aljullu/gutenberg/events","assignees_url":"https://api.github.com/repos/Aljullu/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/Aljullu/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/Aljullu/gutenberg/tags","blobs_url":"https://api.github.com/repos/Aljullu/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aljullu/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aljullu/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aljullu/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aljullu/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/Aljullu/gutenberg/languages","stargazers_url":"https://api.github.com/repos/Aljullu/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/Aljullu/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/Aljullu/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/Aljullu/gutenberg/subscription","commits_url":"https://api.github.com/repos/Aljullu/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aljullu/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aljullu/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aljullu/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aljullu/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/Aljullu/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aljullu/gutenberg/merges","archive_url":"https://api.github.com/repos/Aljullu/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aljullu/gutenberg/downloads","issues_url":"https://api.github.com/repos/Aljullu/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/Aljullu/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/Aljullu/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/Aljullu/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aljullu/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/Aljullu/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/Aljullu/gutenberg/deployments","created_at":"2018-04-22T17:46:34Z","updated_at":"2018-05-02T18:46:59Z","pushed_at":"2018-05-16T22:04:10Z","git_url":"git://github.com/Aljullu/gutenberg.git","ssh_url":"git@github.com:Aljullu/gutenberg.git","clone_url":"https://github.com/Aljullu/gutenberg.git","svn_url":"https://github.com/Aljullu/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":13554,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"62bfd969f28ee1167dc803eda0647f233abc52f0","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-05-17T08:34:16Z","pushed_at":"2018-05-17T08:51:53Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":14087,"stargazers_count":2464,"watchers_count":2464,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":614,"mirror_url":null,"archived":false,"open_issues_count":847,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":614,"open_issues":847,"watchers":2464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/6549"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/6549"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/6549/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6549/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/9ed68191d03a7b53fd5ff22ae7f11103bcb9c44f"}},"author_association":"NONE"}}
{"actor":{"display_login":"nb"}}