{"action":"created","comment":{"url":"https://api.github.com/repos/actix/actix/pulls/comments/207806026","pull_request_review_id":143489939,"id":207806026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgwNjAyNg==","diff_hunk":"@@ -44,7 +44,38 @@ use actor::Actor;\n /// Trait for types which are a placeholder of a value that may become\n /// available at some later point in time.\n ///\n-/// This is similar to `futures::Future` trait, except it works with `Actor`\n+/// `ActorFuture` is very similar to a regular `Future`, only with subsequent combinator closures accepting the relevant actor and its context, in addition to the result.","path":"src/fut/mod.rs","position":5,"original_position":5,"commit_id":"848a549beeec072f153fd90beda93fc368c868c6","original_commit_id":"848a549beeec072f153fd90beda93fc368c868c6","user":{"login":"DoumanAsh","id":5676053,"node_id":"MDQ6VXNlcjU2NzYwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5676053?v=4","gravatar_id":"","url":"https://api.github.com/users/DoumanAsh","html_url":"https://github.com/DoumanAsh","followers_url":"https://api.github.com/users/DoumanAsh/followers","following_url":"https://api.github.com/users/DoumanAsh/following{/other_user}","gists_url":"https://api.github.com/users/DoumanAsh/gists{/gist_id}","starred_url":"https://api.github.com/users/DoumanAsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoumanAsh/subscriptions","organizations_url":"https://api.github.com/users/DoumanAsh/orgs","repos_url":"https://api.github.com/users/DoumanAsh/repos","events_url":"https://api.github.com/users/DoumanAsh/events{/privacy}","received_events_url":"https://api.github.com/users/DoumanAsh/received_events","type":"User","site_admin":false},"body":"Minor thing but I believe `relevant` is not needed here","created_at":"2018-08-06T08:11:48Z","updated_at":"2018-08-06T08:13:51Z","html_url":"https://github.com/actix/actix/pull/127#discussion_r207806026","pull_request_url":"https://api.github.com/repos/actix/actix/pulls/127","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/actix/actix/pulls/comments/207806026"},"html":{"href":"https://github.com/actix/actix/pull/127#discussion_r207806026"},"pull_request":{"href":"https://api.github.com/repos/actix/actix/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/actix/actix/pulls/127","id":206109672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTA5Njcy","html_url":"https://github.com/actix/actix/pull/127","diff_url":"https://github.com/actix/actix/pull/127.diff","patch_url":"https://github.com/actix/actix/pull/127.patch","issue_url":"https://api.github.com/repos/actix/actix/issues/127","number":127,"state":"open","locked":false,"title":"Improve documentation of wra_future and ActorFuture","user":{"login":"vmalloc","id":28710,"node_id":"MDQ6VXNlcjI4NzEw","avatar_url":"https://avatars2.githubusercontent.com/u/28710?v=4","gravatar_id":"","url":"https://api.github.com/users/vmalloc","html_url":"https://github.com/vmalloc","followers_url":"https://api.github.com/users/vmalloc/followers","following_url":"https://api.github.com/users/vmalloc/following{/other_user}","gists_url":"https://api.github.com/users/vmalloc/gists{/gist_id}","starred_url":"https://api.github.com/users/vmalloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmalloc/subscriptions","organizations_url":"https://api.github.com/users/vmalloc/orgs","repos_url":"https://api.github.com/users/vmalloc/repos","events_url":"https://api.github.com/users/vmalloc/events{/privacy}","received_events_url":"https://api.github.com/users/vmalloc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-03T18:45:13Z","updated_at":"2018-08-06T08:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a31eb605196352afe7ffe1fd915d4cdef448c520","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/actix/actix/pulls/127/commits","review_comments_url":"https://api.github.com/repos/actix/actix/pulls/127/comments","review_comment_url":"https://api.github.com/repos/actix/actix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/actix/actix/issues/127/comments","statuses_url":"https://api.github.com/repos/actix/actix/statuses/848a549beeec072f153fd90beda93fc368c868c6","head":{"label":"vmalloc:wrap_future_docs","ref":"wrap_future_docs","sha":"848a549beeec072f153fd90beda93fc368c868c6","user":{"login":"vmalloc","id":28710,"node_id":"MDQ6VXNlcjI4NzEw","avatar_url":"https://avatars2.githubusercontent.com/u/28710?v=4","gravatar_id":"","url":"https://api.github.com/users/vmalloc","html_url":"https://github.com/vmalloc","followers_url":"https://api.github.com/users/vmalloc/followers","following_url":"https://api.github.com/users/vmalloc/following{/other_user}","gists_url":"https://api.github.com/users/vmalloc/gists{/gist_id}","starred_url":"https://api.github.com/users/vmalloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmalloc/subscriptions","organizations_url":"https://api.github.com/users/vmalloc/orgs","repos_url":"https://api.github.com/users/vmalloc/repos","events_url":"https://api.github.com/users/vmalloc/events{/privacy}","received_events_url":"https://api.github.com/users/vmalloc/received_events","type":"User","site_admin":false},"repo":{"id":143458729,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0NTg3Mjk=","name":"actix","full_name":"vmalloc/actix","owner":{"login":"vmalloc","id":28710,"node_id":"MDQ6VXNlcjI4NzEw","avatar_url":"https://avatars2.githubusercontent.com/u/28710?v=4","gravatar_id":"","url":"https://api.github.com/users/vmalloc","html_url":"https://github.com/vmalloc","followers_url":"https://api.github.com/users/vmalloc/followers","following_url":"https://api.github.com/users/vmalloc/following{/other_user}","gists_url":"https://api.github.com/users/vmalloc/gists{/gist_id}","starred_url":"https://api.github.com/users/vmalloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmalloc/subscriptions","organizations_url":"https://api.github.com/users/vmalloc/orgs","repos_url":"https://api.github.com/users/vmalloc/repos","events_url":"https://api.github.com/users/vmalloc/events{/privacy}","received_events_url":"https://api.github.com/users/vmalloc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmalloc/actix","description":"Actor framework for Rust","fork":true,"url":"https://api.github.com/repos/vmalloc/actix","forks_url":"https://api.github.com/repos/vmalloc/actix/forks","keys_url":"https://api.github.com/repos/vmalloc/actix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmalloc/actix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmalloc/actix/teams","hooks_url":"https://api.github.com/repos/vmalloc/actix/hooks","issue_events_url":"https://api.github.com/repos/vmalloc/actix/issues/events{/number}","events_url":"https://api.github.com/repos/vmalloc/actix/events","assignees_url":"https://api.github.com/repos/vmalloc/actix/assignees{/user}","branches_url":"https://api.github.com/repos/vmalloc/actix/branches{/branch}","tags_url":"https://api.github.com/repos/vmalloc/actix/tags","blobs_url":"https://api.github.com/repos/vmalloc/actix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmalloc/actix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmalloc/actix/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmalloc/actix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmalloc/actix/statuses/{sha}","languages_url":"https://api.github.com/repos/vmalloc/actix/languages","stargazers_url":"https://api.github.com/repos/vmalloc/actix/stargazers","contributors_url":"https://api.github.com/repos/vmalloc/actix/contributors","subscribers_url":"https://api.github.com/repos/vmalloc/actix/subscribers","subscription_url":"https://api.github.com/repos/vmalloc/actix/subscription","commits_url":"https://api.github.com/repos/vmalloc/actix/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmalloc/actix/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmalloc/actix/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmalloc/actix/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmalloc/actix/contents/{+path}","compare_url":"https://api.github.com/repos/vmalloc/actix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmalloc/actix/merges","archive_url":"https://api.github.com/repos/vmalloc/actix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmalloc/actix/downloads","issues_url":"https://api.github.com/repos/vmalloc/actix/issues{/number}","pulls_url":"https://api.github.com/repos/vmalloc/actix/pulls{/number}","milestones_url":"https://api.github.com/repos/vmalloc/actix/milestones{/number}","notifications_url":"https://api.github.com/repos/vmalloc/actix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmalloc/actix/labels{/name}","releases_url":"https://api.github.com/repos/vmalloc/actix/releases{/id}","deployments_url":"https://api.github.com/repos/vmalloc/actix/deployments","created_at":"2018-08-03T18:07:12Z","updated_at":"2018-08-03T18:07:14Z","pushed_at":"2018-08-06T08:09:36Z","git_url":"git://github.com/vmalloc/actix.git","ssh_url":"git@github.com:vmalloc/actix.git","clone_url":"https://github.com/vmalloc/actix.git","svn_url":"https://github.com/vmalloc/actix","homepage":"","size":2146,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"actix:master","ref":"master","sha":"8aa6e0ad300bc1987205532628b4ee7bc05e7ee5","user":{"login":"actix","id":32776943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc2OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/32776943?v=4","gravatar_id":"","url":"https://api.github.com/users/actix","html_url":"https://github.com/actix","followers_url":"https://api.github.com/users/actix/followers","following_url":"https://api.github.com/users/actix/following{/other_user}","gists_url":"https://api.github.com/users/actix/gists{/gist_id}","starred_url":"https://api.github.com/users/actix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actix/subscriptions","organizations_url":"https://api.github.com/users/actix/orgs","repos_url":"https://api.github.com/users/actix/repos","events_url":"https://api.github.com/users/actix/events{/privacy}","received_events_url":"https://api.github.com/users/actix/received_events","type":"Organization","site_admin":false},"repo":{"id":103894697,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM4OTQ2OTc=","name":"actix","full_name":"actix/actix","owner":{"login":"actix","id":32776943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc2OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/32776943?v=4","gravatar_id":"","url":"https://api.github.com/users/actix","html_url":"https://github.com/actix","followers_url":"https://api.github.com/users/actix/followers","following_url":"https://api.github.com/users/actix/following{/other_user}","gists_url":"https://api.github.com/users/actix/gists{/gist_id}","starred_url":"https://api.github.com/users/actix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actix/subscriptions","organizations_url":"https://api.github.com/users/actix/orgs","repos_url":"https://api.github.com/users/actix/repos","events_url":"https://api.github.com/users/actix/events{/privacy}","received_events_url":"https://api.github.com/users/actix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/actix/actix","description":"Actor framework for Rust","fork":false,"url":"https://api.github.com/repos/actix/actix","forks_url":"https://api.github.com/repos/actix/actix/forks","keys_url":"https://api.github.com/repos/actix/actix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actix/actix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actix/actix/teams","hooks_url":"https://api.github.com/repos/actix/actix/hooks","issue_events_url":"https://api.github.com/repos/actix/actix/issues/events{/number}","events_url":"https://api.github.com/repos/actix/actix/events","assignees_url":"https://api.github.com/repos/actix/actix/assignees{/user}","branches_url":"https://api.github.com/repos/actix/actix/branches{/branch}","tags_url":"https://api.github.com/repos/actix/actix/tags","blobs_url":"https://api.github.com/repos/actix/actix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actix/actix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actix/actix/git/refs{/sha}","trees_url":"https://api.github.com/repos/actix/actix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actix/actix/statuses/{sha}","languages_url":"https://api.github.com/repos/actix/actix/languages","stargazers_url":"https://api.github.com/repos/actix/actix/stargazers","contributors_url":"https://api.github.com/repos/actix/actix/contributors","subscribers_url":"https://api.github.com/repos/actix/actix/subscribers","subscription_url":"https://api.github.com/repos/actix/actix/subscription","commits_url":"https://api.github.com/repos/actix/actix/commits{/sha}","git_commits_url":"https://api.github.com/repos/actix/actix/git/commits{/sha}","comments_url":"https://api.github.com/repos/actix/actix/comments{/number}","issue_comment_url":"https://api.github.com/repos/actix/actix/issues/comments{/number}","contents_url":"https://api.github.com/repos/actix/actix/contents/{+path}","compare_url":"https://api.github.com/repos/actix/actix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actix/actix/merges","archive_url":"https://api.github.com/repos/actix/actix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actix/actix/downloads","issues_url":"https://api.github.com/repos/actix/actix/issues{/number}","pulls_url":"https://api.github.com/repos/actix/actix/pulls{/number}","milestones_url":"https://api.github.com/repos/actix/actix/milestones{/number}","notifications_url":"https://api.github.com/repos/actix/actix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actix/actix/labels{/name}","releases_url":"https://api.github.com/repos/actix/actix/releases{/id}","deployments_url":"https://api.github.com/repos/actix/actix/deployments","created_at":"2017-09-18T05:13:28Z","updated_at":"2018-08-06T05:33:37Z","pushed_at":"2018-08-06T08:09:38Z","git_url":"git://github.com/actix/actix.git","ssh_url":"git@github.com:actix/actix.git","clone_url":"https://github.com/actix/actix.git","svn_url":"https://github.com/actix/actix","homepage":"","size":2173,"stargazers_count":1510,"watchers_count":1510,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":82,"open_issues":6,"watchers":1510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/actix/actix/pulls/127"},"html":{"href":"https://github.com/actix/actix/pull/127"},"issue":{"href":"https://api.github.com/repos/actix/actix/issues/127"},"comments":{"href":"https://api.github.com/repos/actix/actix/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/actix/actix/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/actix/actix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/actix/actix/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/actix/actix/statuses/848a549beeec072f153fd90beda93fc368c868c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DoumanAsh"}}