{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/rummager/pulls/comments/233089356","pull_request_review_id":174428136,"id":233089356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzA4OTM1Ng==","diff_hunk":"@@ -78,6 +78,7 @@\n   # config.warnings = true\n \n   config.before do\n+    stub_any_world_locations_request","path":"spec/spec_helper.rb","position":21,"original_position":4,"commit_id":"b06f39491905d9419b9f1b6d33b3f863f366fd90","original_commit_id":"d7fc15a02c4cea65c4c8857f78b601ad6b89b4cd","user":{"login":"bilbof","id":8124374,"node_id":"MDQ6VXNlcjgxMjQzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8124374?v=4","gravatar_id":"","url":"https://api.github.com/users/bilbof","html_url":"https://github.com/bilbof","followers_url":"https://api.github.com/users/bilbof/followers","following_url":"https://api.github.com/users/bilbof/following{/other_user}","gists_url":"https://api.github.com/users/bilbof/gists{/gist_id}","starred_url":"https://api.github.com/users/bilbof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilbof/subscriptions","organizations_url":"https://api.github.com/users/bilbof/orgs","repos_url":"https://api.github.com/users/bilbof/repos","events_url":"https://api.github.com/users/bilbof/events{/privacy}","received_events_url":"https://api.github.com/users/bilbof/received_events","type":"User","site_admin":false},"body":"Yeah good idea!","created_at":"2018-11-13T15:36:54Z","updated_at":"2018-11-13T15:36:55Z","html_url":"https://github.com/alphagov/rummager/pull/1318#discussion_r233089356","pull_request_url":"https://api.github.com/repos/alphagov/rummager/pulls/1318","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/comments/233089356"},"html":{"href":"https://github.com/alphagov/rummager/pull/1318#discussion_r233089356"},"pull_request":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/1318"}},"in_reply_to_id":232976507},"pull_request":{"url":"https://api.github.com/repos/alphagov/rummager/pulls/1318","id":230184236,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTg0MjM2","html_url":"https://github.com/alphagov/rummager/pull/1318","diff_url":"https://github.com/alphagov/rummager/pull/1318.diff","patch_url":"https://github.com/alphagov/rummager/pull/1318.patch","issue_url":"https://api.github.com/repos/alphagov/rummager/issues/1318","number":1318,"state":"open","locked":false,"title":"Expand World Locations in Finder responses","user":{"login":"bilbof","id":8124374,"node_id":"MDQ6VXNlcjgxMjQzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8124374?v=4","gravatar_id":"","url":"https://api.github.com/users/bilbof","html_url":"https://github.com/bilbof","followers_url":"https://api.github.com/users/bilbof/followers","following_url":"https://api.github.com/users/bilbof/following{/other_user}","gists_url":"https://api.github.com/users/bilbof/gists{/gist_id}","starred_url":"https://api.github.com/users/bilbof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilbof/subscriptions","organizations_url":"https://api.github.com/users/bilbof/orgs","repos_url":"https://api.github.com/users/bilbof/repos","events_url":"https://api.github.com/users/bilbof/events{/privacy}","received_events_url":"https://api.github.com/users/bilbof/received_events","type":"User","site_admin":false},"body":"This fetches world location data from https://www.gov.uk/api/world-locations\r\nand uses it to provide titles and slugs to Finders for use in faceting with\r\nworld locations.\r\n\r\nWe need to use an external source as most world locations were removed from\r\nrummager (commit: https://github.com/alphagov/whitehall/pull/3966/commits/45ce7295a731991f483f5ba238c3424549213746).\r\n\r\nThis is a short term fix. The longer term solution would be to bring world locations back\r\ninto the content-store and rummager. That may be tricky and is being discussed at the moment.\r\n\r\nOnly the title and slug of a world locations is required for Finder-frontend.\r\n\r\nThis is part of the migration of finders from whitehall to finder-frontend.\r\nAfter this is merged we can add world_locations as an available filter to\r\nfinders in finder-frontend.\r\n\r\n## Screenshots\r\n\r\n![screen shot 2018-11-12 at 14 29 32](https://user-images.githubusercontent.com/8124374/48358981-e157aa80-e693-11e8-9017-9252bbe8cf80.png)\r\n","created_at":"2018-11-12T15:59:42Z","updated_at":"2018-11-13T15:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9bfcc610a3450a176c4960d876018c9de65babe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/rummager/pulls/1318/commits","review_comments_url":"https://api.github.com/repos/alphagov/rummager/pulls/1318/comments","review_comment_url":"https://api.github.com/repos/alphagov/rummager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/rummager/issues/1318/comments","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/b06f39491905d9419b9f1b6d33b3f863f366fd90","head":{"label":"alphagov:world-locations-registry","ref":"world-locations-registry","sha":"b06f39491905d9419b9f1b6d33b3f863f366fd90","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2686767,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg2NzY3","name":"rummager","full_name":"alphagov/rummager","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/rummager","description":"Search API for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/rummager","forks_url":"https://api.github.com/repos/alphagov/rummager/forks","keys_url":"https://api.github.com/repos/alphagov/rummager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/rummager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/rummager/teams","hooks_url":"https://api.github.com/repos/alphagov/rummager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/rummager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/rummager/events","assignees_url":"https://api.github.com/repos/alphagov/rummager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/rummager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/rummager/tags","blobs_url":"https://api.github.com/repos/alphagov/rummager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/rummager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/rummager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/rummager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/rummager/languages","stargazers_url":"https://api.github.com/repos/alphagov/rummager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/rummager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/rummager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/rummager/subscription","commits_url":"https://api.github.com/repos/alphagov/rummager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/rummager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/rummager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/rummager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/rummager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/rummager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/rummager/merges","archive_url":"https://api.github.com/repos/alphagov/rummager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/rummager/downloads","issues_url":"https://api.github.com/repos/alphagov/rummager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/rummager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/rummager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/rummager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/rummager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/rummager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/rummager/deployments","created_at":"2011-11-01T10:12:45Z","updated_at":"2018-11-08T14:52:31Z","pushed_at":"2018-11-13T15:35:40Z","git_url":"git://github.com/alphagov/rummager.git","ssh_url":"git@github.com:alphagov/rummager.git","clone_url":"https://github.com/alphagov/rummager.git","svn_url":"https://github.com/alphagov/rummager","homepage":"https://docs.publishing.service.gov.uk/apps/rummager.html","size":9762,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":13,"watchers":40,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"0962e395ab4a9bc291aff61f637e5a15a2ae7310","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2686767,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg2NzY3","name":"rummager","full_name":"alphagov/rummager","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/rummager","description":"Search API for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/rummager","forks_url":"https://api.github.com/repos/alphagov/rummager/forks","keys_url":"https://api.github.com/repos/alphagov/rummager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/rummager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/rummager/teams","hooks_url":"https://api.github.com/repos/alphagov/rummager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/rummager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/rummager/events","assignees_url":"https://api.github.com/repos/alphagov/rummager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/rummager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/rummager/tags","blobs_url":"https://api.github.com/repos/alphagov/rummager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/rummager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/rummager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/rummager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/rummager/languages","stargazers_url":"https://api.github.com/repos/alphagov/rummager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/rummager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/rummager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/rummager/subscription","commits_url":"https://api.github.com/repos/alphagov/rummager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/rummager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/rummager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/rummager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/rummager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/rummager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/rummager/merges","archive_url":"https://api.github.com/repos/alphagov/rummager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/rummager/downloads","issues_url":"https://api.github.com/repos/alphagov/rummager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/rummager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/rummager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/rummager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/rummager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/rummager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/rummager/deployments","created_at":"2011-11-01T10:12:45Z","updated_at":"2018-11-08T14:52:31Z","pushed_at":"2018-11-13T15:35:40Z","git_url":"git://github.com/alphagov/rummager.git","ssh_url":"git@github.com:alphagov/rummager.git","clone_url":"https://github.com/alphagov/rummager.git","svn_url":"https://github.com/alphagov/rummager","homepage":"https://docs.publishing.service.gov.uk/apps/rummager.html","size":9762,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":13,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/1318"},"html":{"href":"https://github.com/alphagov/rummager/pull/1318"},"issue":{"href":"https://api.github.com/repos/alphagov/rummager/issues/1318"},"comments":{"href":"https://api.github.com/repos/alphagov/rummager/issues/1318/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/1318/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/1318/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/rummager/statuses/b06f39491905d9419b9f1b6d33b3f863f366fd90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bilbof"}}