{"action":"created","issue":{"url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/43","repository_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib","labels_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/43/comments","events_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/43/events","html_url":"https://github.com/threefoldtech/jumpscale_lib/issues/43","id":346232821,"node_id":"MDU6SXNzdWUzNDYyMzI4MjE=","number":43,"title":"ValueError when passing ZT client in gw3.networks.add_zerotier()","user":{"login":"rkhamis","id":8425762,"node_id":"MDQ6VXNlcjg0MjU3NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8425762?v=4","gravatar_id":"","url":"https://api.github.com/users/rkhamis","html_url":"https://github.com/rkhamis","followers_url":"https://api.github.com/users/rkhamis/followers","following_url":"https://api.github.com/users/rkhamis/following{/other_user}","gists_url":"https://api.github.com/users/rkhamis/gists{/gist_id}","starred_url":"https://api.github.com/users/rkhamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkhamis/subscriptions","organizations_url":"https://api.github.com/users/rkhamis/orgs","repos_url":"https://api.github.com/users/rkhamis/repos","events_url":"https://api.github.com/users/rkhamis/events{/privacy}","received_events_url":"https://api.github.com/users/rkhamis/received_events","type":"User","site_admin":false},"labels":[{"id":1010422180,"node_id":"MDU6TGFiZWwxMDEwNDIyMTgw","url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/labels/state_planned","name":"state_planned","color":"c2e0c6","default":false},{"id":1008960345,"node_id":"MDU6TGFiZWwxMDA4OTYwMzQ1","url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/labels/state_verification","name":"state_verification","color":"bfe5bf","default":false},{"id":1008960364,"node_id":"MDU6TGFiZWwxMDA4OTYwMzY0","url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/labels/type_bug","name":"type_bug","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/milestones/6","html_url":"https://github.com/threefoldtech/jumpscale_lib/milestone/6","labels_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/milestones/6/labels","id":3541614,"node_id":"MDk6TWlsZXN0b25lMzU0MTYxNA==","number":6,"title":"9.5.1","description":null,"creator":{"login":"rkhamis","id":8425762,"node_id":"MDQ6VXNlcjg0MjU3NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8425762?v=4","gravatar_id":"","url":"https://api.github.com/users/rkhamis","html_url":"https://github.com/rkhamis","followers_url":"https://api.github.com/users/rkhamis/followers","following_url":"https://api.github.com/users/rkhamis/following{/other_user}","gists_url":"https://api.github.com/users/rkhamis/gists{/gist_id}","starred_url":"https://api.github.com/users/rkhamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkhamis/subscriptions","organizations_url":"https://api.github.com/users/rkhamis/orgs","repos_url":"https://api.github.com/users/rkhamis/repos","events_url":"https://api.github.com/users/rkhamis/events{/privacy}","received_events_url":"https://api.github.com/users/rkhamis/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":12,"state":"open","created_at":"2018-08-02T10:14:18Z","updated_at":"2018-09-11T09:58:43Z","due_on":"2018-08-16T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-31T15:11:59Z","updated_at":"2018-09-11T09:58:43Z","closed_at":"2018-09-11T09:58:43Z","author_association":"NONE","body":"*Issue migrated from [https://api.github.com/repos/Jumpscale/lib9/issues/287](), opened by @yveskerwyn*\n\n#### Installation information\r\n\r\n- jumpscale version: development\r\n- operating system:\r\n\r\n\r\n#### Detailed description\r\n\r\n\r\n#### Steps to reproduce\r\n\r\n```python\r\ngw = zos_node.primitives.create_gateway(name='my_gw')\r\nzt_client = j.clients.zerotier.get()\r\nzt_app_network_name = 'app_network'\r\nzt_private_network = gw.networks.add_zerotier(network=zt_client, name=zt_app_network_name)\r\n```\r\n\r\n#### Relevant stacktraces\r\n\r\n```python\r\n---------------------------------------------------------------------------\r\nValueError                                Traceback (most recent call last)\r\n/usr/local/bin/js9 in <module>()\r\n----> 1 zt_private_network = gw3.networks.add_zerotier(network=zt_client, name=zt_app_network_name)\r\n\r\n/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/gateway/network.py in add_zerotier(self, network, name)\r\n    314             if not name:\r\n    315                 raise ValueError('Need to provide a name for network')\r\n--> 316             net = ZTNetwork(name, None, self._parent)\r\n    317             net.client = network\r\n    318         else:\r\n\r\n/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/gateway/network.py in __init__(self, name, networkid, gateway)\r\n    421     def __init__(self, name, networkid, gateway):\r\n    422         self._networkid = None\r\n--> 423         super().__init__(name, networkid, None, gateway)\r\n    424         self.ip = IP()\r\n    425         self.hosts = Hosts(gateway, self)\r\n\r\n/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/abstracts.py in __init__(self, name, networkid, hwaddr, parent)\r\n    126 class ZTNic(Nic):\r\n    127     def __init__(self, name, networkid, hwaddr, parent):\r\n--> 128         super().__init__(name, 'zerotier', networkid, hwaddr, parent)\r\n    129         self._client = None\r\n    130         self._client_name = None\r\n\r\n/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/abstracts.py in __init__(self, name, type_, networkid, hwaddr, parent)\r\n     91         self._type = None\r\n     92         self.name = name\r\n---> 93         self.networkid = networkid\r\n     94         self.type = type_\r\n     95         self.hwaddr = hwaddr\r\n\r\n/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/gateway/network.py in networkid(self, value)\r\n    433     def networkid(self, value):\r\n    434         if not isinstance(value, str) or len(value) != 16:\r\n--> 435             raise ValueError('Invalid value for zerotierid')\r\n    436         self._networkid = value\r\n    437\r\n\r\nValueError: Invalid value for zerotierid\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/comments/420217636","html_url":"https://github.com/threefoldtech/jumpscale_lib/issues/43#issuecomment-420217636","issue_url":"https://api.github.com/repos/threefoldtech/jumpscale_lib/issues/43","id":420217636,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDIxNzYzNg==","user":{"login":"hossnys","id":26298009,"node_id":"MDQ6VXNlcjI2Mjk4MDA5","avatar_url":"https://avatars2.githubusercontent.com/u/26298009?v=4","gravatar_id":"","url":"https://api.github.com/users/hossnys","html_url":"https://github.com/hossnys","followers_url":"https://api.github.com/users/hossnys/followers","following_url":"https://api.github.com/users/hossnys/following{/other_user}","gists_url":"https://api.github.com/users/hossnys/gists{/gist_id}","starred_url":"https://api.github.com/users/hossnys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hossnys/subscriptions","organizations_url":"https://api.github.com/users/hossnys/orgs","repos_url":"https://api.github.com/users/hossnys/repos","events_url":"https://api.github.com/users/hossnys/events{/privacy}","received_events_url":"https://api.github.com/users/hossnys/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T09:58:43Z","updated_at":"2018-09-11T09:58:43Z","author_association":"NONE","body":"verified \r\nbranch: development "}}
{"actor":{"display_login":"hossnys"}}