{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/168713055","pull_request_review_id":97125864,"id":168713055,"diff_hunk":"@@ -288,6 +290,10 @@ if (sle_version_at_least('15') && !check_var('SCC_REGISTER', 'installation')) {\n                 $prefix .= \"-Staging:\" . get_var(\"STAGING\");\n             }\n             my $module_repo_name = get_var(\"REPO_SLE${version}_MODULE_${repo_name}\", \"$prefix-Module-$full_name-POOL-$arch-Build$build-Media1\");\n+            # REPO_SLE* settings and repo names are different for products and modules\n+            # Assign the proper repo name if current $short_name is not a module.\n+            $module_repo_name = get_var(\"REPO_SLE_${repo_name}${version}_POOL\", \"$prefix-Product-$full_name-POOL-$arch-Build$build-Media1\")","path":"products/sle/main.pm","position":17,"original_position":17,"commit_id":"340dcd414f6c44f2a198c51fec4970a1b49bc948","original_commit_id":"340dcd414f6c44f2a198c51fec4970a1b49bc948","user":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"body":"@asmorodskyi working on suggestion. will push after test runs complete.","created_at":"2018-02-16T09:52:56Z","updated_at":"2018-02-16T09:52:56Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416#discussion_r168713055","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/168713055"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416#discussion_r168713055"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416"}},"in_reply_to_id":168688636},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416","id":169114004,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4416","number":4416,"state":"open","locked":false,"title":"Add support for products/extensions in WORKAROUND_MODULES","user":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"body":"This adds support to `WORKAROUND_MODULES` so it can include products (such as sles, sled, sles_sap) or extensions (such as ha) in the variable with the purpose of using it when skipping SCC\r\nregistration or testing in staging areas.\r\n\r\nAlso included in the PR is the inclusion of `sapapp` in the map of modules' short names to full names defined in lib/registration.pm.\r\n\r\n- Related ticket: N/A\r\n- Needles: N/A\r\n- Verification run: http://mango.suse.de/tests/231 & http://mango.suse.de/tests/232\r\n","created_at":"2018-02-14T13:47:38Z","updated_at":"2018-02-16T09:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca47a38c3ef5eeccdb404bfbaf0c0a759a039ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4416/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/340dcd414f6c44f2a198c51fec4970a1b49bc948","head":{"label":"alvarocarvajald:sles4sap-workaround-modules","ref":"sles4sap-workaround-modules","sha":"340dcd414f6c44f2a198c51fec4970a1b49bc948","user":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"repo":{"id":105257141,"name":"os-autoinst-distri-opensuse","full_name":"alvarocarvajald/os-autoinst-distri-opensuse","owner":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/deployments","created_at":"2017-09-29T09:50:15Z","updated_at":"2017-09-29T09:50:19Z","pushed_at":"2018-02-15T16:56:47Z","git_url":"git://github.com/alvarocarvajald/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:alvarocarvajald/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":88055,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"7e2b09e9d4052915c72ce7beb4262b9ca302ecb1","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-02-08T00:11:31Z","pushed_at":"2018-02-16T09:51:16Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":88102,"stargazers_count":29,"watchers_count":29,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":120,"open_issues":39,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4416"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4416"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4416/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4416/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/340dcd414f6c44f2a198c51fec4970a1b49bc948"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alvarocarvajald"}}