{"action":"created","comment":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/231580293","pull_request_review_id":172582069,"id":231580293,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTU4MDI5Mw==","diff_hunk":"@@ -751,3 +752,68 @@ def test_static_route_path_existence_check() -> None:\n     assert 'application/octet-stream' == resp.headers['Content-Type']\n     assert resp.headers.get('Content-Encoding') == 'deflate'\n     await resp.release()\n+\n+\n+async def test_static_file_huge_cancel(aiohttp_client, tmpdir) -> None:\n+    filename = 'huge_data.unknown_mime_type'\n+\n+    # fill 100MB file","path":"tests/test_web_sendfile_functional.py","position":17,"original_position":17,"commit_id":"602b1d089cf839d93b9215c49c2cbcdd70659fd8","original_commit_id":"602b1d089cf839d93b9215c49c2cbcdd70659fd8","user":{"login":"socketpair","id":1157412,"node_id":"MDQ6VXNlcjExNTc0MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1157412?v=4","gravatar_id":"","url":"https://api.github.com/users/socketpair","html_url":"https://github.com/socketpair","followers_url":"https://api.github.com/users/socketpair/followers","following_url":"https://api.github.com/users/socketpair/following{/other_user}","gists_url":"https://api.github.com/users/socketpair/gists{/gist_id}","starred_url":"https://api.github.com/users/socketpair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketpair/subscriptions","organizations_url":"https://api.github.com/users/socketpair/orgs","repos_url":"https://api.github.com/users/socketpair/repos","events_url":"https://api.github.com/users/socketpair/events{/privacy}","received_events_url":"https://api.github.com/users/socketpair/received_events","type":"User","site_admin":false},"body":"this will efficiently create big (but sparse) file. Since that, You may safely increse size to, say, 1Gb. It will not lead to disk IO in any FS except FAT. But no one will run test on FAT fs.","created_at":"2018-11-07T16:35:32Z","updated_at":"2018-11-07T16:35:32Z","html_url":"https://github.com/aio-libs/aiohttp/pull/3383#discussion_r231580293","pull_request_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/231580293"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3383#discussion_r231580293"},"pull_request":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383"}},"in_reply_to_id":231579484},"pull_request":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383","id":228669477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NjY5NDc3","html_url":"https://github.com/aio-libs/aiohttp/pull/3383","diff_url":"https://github.com/aio-libs/aiohttp/pull/3383.diff","patch_url":"https://github.com/aio-libs/aiohttp/pull/3383.patch","issue_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3383","number":3383,"state":"open","locked":false,"title":"Refactor sendfile","user":{"login":"asvetlov","id":356399,"node_id":"MDQ6VXNlcjM1NjM5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"body":"The main change is using `add_done_callback` to unregister writer early on future cancellation.","created_at":"2018-11-06T12:07:56Z","updated_at":"2018-11-07T16:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b1effb3053789f637f4a85697a88ece542a7490","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383/commits","review_comments_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383/comments","review_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3383/comments","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/602b1d089cf839d93b9215c49c2cbcdd70659fd8","head":{"label":"aio-libs:refactor-sendfile","ref":"refactor-sendfile","sha":"602b1d089cf839d93b9215c49c2cbcdd70659fd8","user":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1ODAzOQ==","name":"aiohttp","full_name":"aio-libs/aiohttp","private":false,"owner":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aio-libs/aiohttp","description":"Asynchronous HTTP client/server framework for asyncio and Python","fork":false,"url":"https://api.github.com/repos/aio-libs/aiohttp","forks_url":"https://api.github.com/repos/aio-libs/aiohttp/forks","keys_url":"https://api.github.com/repos/aio-libs/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aiohttp/teams","hooks_url":"https://api.github.com/repos/aio-libs/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aiohttp/events","assignees_url":"https://api.github.com/repos/aio-libs/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aiohttp/tags","blobs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aiohttp/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aiohttp/subscription","commits_url":"https://api.github.com/repos/aio-libs/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aiohttp/merges","archive_url":"https://api.github.com/repos/aio-libs/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aiohttp/downloads","issues_url":"https://api.github.com/repos/aio-libs/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2018-11-07T14:33:31Z","pushed_at":"2018-11-07T12:38:02Z","git_url":"git://github.com/aio-libs/aiohttp.git","ssh_url":"git@github.com:aio-libs/aiohttp.git","clone_url":"https://github.com/aio-libs/aiohttp.git","svn_url":"https://github.com/aio-libs/aiohttp","homepage":"https://docs.aiohttp.org","size":13561,"stargazers_count":6363,"watchers_count":6363,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":987,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":987,"open_issues":169,"watchers":6363,"default_branch":"master"}},"base":{"label":"aio-libs:master","ref":"master","sha":"c96c9af3c0e3b2c8467bc5393f9460def360a11d","user":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1ODAzOQ==","name":"aiohttp","full_name":"aio-libs/aiohttp","private":false,"owner":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aio-libs/aiohttp","description":"Asynchronous HTTP client/server framework for asyncio and Python","fork":false,"url":"https://api.github.com/repos/aio-libs/aiohttp","forks_url":"https://api.github.com/repos/aio-libs/aiohttp/forks","keys_url":"https://api.github.com/repos/aio-libs/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aiohttp/teams","hooks_url":"https://api.github.com/repos/aio-libs/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aiohttp/events","assignees_url":"https://api.github.com/repos/aio-libs/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aiohttp/tags","blobs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aiohttp/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aiohttp/subscription","commits_url":"https://api.github.com/repos/aio-libs/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aiohttp/merges","archive_url":"https://api.github.com/repos/aio-libs/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aiohttp/downloads","issues_url":"https://api.github.com/repos/aio-libs/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2018-11-07T14:33:31Z","pushed_at":"2018-11-07T12:38:02Z","git_url":"git://github.com/aio-libs/aiohttp.git","ssh_url":"git@github.com:aio-libs/aiohttp.git","clone_url":"https://github.com/aio-libs/aiohttp.git","svn_url":"https://github.com/aio-libs/aiohttp","homepage":"https://docs.aiohttp.org","size":13561,"stargazers_count":6363,"watchers_count":6363,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":987,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":987,"open_issues":169,"watchers":6363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3383"},"issue":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3383"},"comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3383/comments"},"review_comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383/comments"},"review_comment":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3383/commits"},"statuses":{"href":"https://api.github.com/repos/aio-libs/aiohttp/statuses/602b1d089cf839d93b9215c49c2cbcdd70659fd8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"socketpair"}}