{"action":"created","comment":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/comments/194722199","pull_request_review_id":127894396,"id":194722199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDcyMjE5OQ==","diff_hunk":"@@ -0,0 +1,93 @@\n+# Copyright 2014-2017 The ODL contributors\n+#\n+# This file is part of ODL.\n+#\n+# This Source Code Form is subject to the terms of the Mozilla Public License,\n+# v. 2.0. If a copy of the MPL was not distributed with this file, You can\n+# obtain one at https://mozilla.org/MPL/2.0/.\n+\n+\"\"\"Method(s) to find optimal reconstruction/regularization parameters with\n+respect to given figures of merit.\"\"\"\n+\n+import numpy as np\n+import scipy\n+\n+__all__ = ('optimal_parameters', )\n+\n+\n+def optimal_parameters(reconstruction, fom, phantoms, data,\n+                       initial_param=0):\n+    \"\"\"Find the optimal parameters for a reconstruction method.\n+\n+    Notes\n+    -----\n+    For a forward operator :math:`A : X \\\\to Y`, a reconstruction operator","path":"odl/contrib/param_opt/param_opt.py","position":24,"original_position":24,"commit_id":"66227953714ba57add0a9bedb876d337398ed692","original_commit_id":"66227953714ba57add0a9bedb876d337398ed692","user":{"login":"adler-j","id":2202312,"node_id":"MDQ6VXNlcjIyMDIzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2202312?v=4","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"body":"Prefer to change this docstring to use  `r\"\"\"` and then remove the double backslashes","created_at":"2018-06-12T12:43:42Z","updated_at":"2018-06-12T12:54:19Z","html_url":"https://github.com/odlgroup/odl/pull/1280#discussion_r194722199","pull_request_url":"https://api.github.com/repos/odlgroup/odl/pulls/1280","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments/194722199"},"html":{"href":"https://github.com/odlgroup/odl/pull/1280#discussion_r194722199"},"pull_request":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1280"}}},"pull_request":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/1280","id":166568931,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY2NTY4OTMx","html_url":"https://github.com/odlgroup/odl/pull/1280","diff_url":"https://github.com/odlgroup/odl/pull/1280.diff","patch_url":"https://github.com/odlgroup/odl/pull/1280.patch","issue_url":"https://api.github.com/repos/odlgroup/odl/issues/1280","number":1280,"state":"open","locked":false,"title":"Reconstruction pipeline","user":{"login":"adler-j","id":2202312,"node_id":"MDQ6VXNlcjIyMDIzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2202312?v=4","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"body":"TODO:\r\n\r\n- [x] [#1184](https://github.com/odlgroup/odl/pull/1184) \"TST: Add general tests for supervised FOMs\"\r\n- [x] [#1185](https://github.com/odlgroup/odl/pull/1185) \"ENH: Pull request of group 1 (Workshop day, work on FOMs)\"\r\n- [x] [#1187](https://github.com/odlgroup/odl/pull/1187) \"Optimize parameters\"\r\n- [x] <s>[#1188](https://github.com/odlgroup/odl/pull/1188)</s> [#1357](https://github.com/odlgroup/odl/pull/1357) \"Reco pipeline mob\"\r\n\r\nAfter these are in we can review and merge to master.\r\n\r\nEdited by @aringh","created_at":"2018-02-01T15:29:24Z","updated_at":"2018-06-12T12:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9595e00f833c00772960fb1679617ac68a019461","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":285214354,"node_id":"MDU6TGFiZWwyODUyMTQzNTQ=","url":"https://api.github.com/repos/odlgroup/odl/labels/needs%20improvement","name":"needs improvement","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odlgroup/odl/pulls/1280/commits","review_comments_url":"https://api.github.com/repos/odlgroup/odl/pulls/1280/comments","review_comment_url":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odlgroup/odl/issues/1280/comments","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/66227953714ba57add0a9bedb876d337398ed692","head":{"label":"odlgroup:reconstruction_pipeline","ref":"reconstruction_pipeline","sha":"66227953714ba57add0a9bedb876d337398ed692","user":{"login":"odlgroup","id":15667171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjY3MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45596393,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU5NjM5Mw==","name":"odl","full_name":"odlgroup/odl","owner":{"login":"odlgroup","id":15667171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjY3MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odlgroup/odl","description":"Operator Discretization Library  https://odlgroup.github.io/odl/","fork":false,"url":"https://api.github.com/repos/odlgroup/odl","forks_url":"https://api.github.com/repos/odlgroup/odl/forks","keys_url":"https://api.github.com/repos/odlgroup/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odlgroup/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odlgroup/odl/teams","hooks_url":"https://api.github.com/repos/odlgroup/odl/hooks","issue_events_url":"https://api.github.com/repos/odlgroup/odl/issues/events{/number}","events_url":"https://api.github.com/repos/odlgroup/odl/events","assignees_url":"https://api.github.com/repos/odlgroup/odl/assignees{/user}","branches_url":"https://api.github.com/repos/odlgroup/odl/branches{/branch}","tags_url":"https://api.github.com/repos/odlgroup/odl/tags","blobs_url":"https://api.github.com/repos/odlgroup/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odlgroup/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odlgroup/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/odlgroup/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/odlgroup/odl/languages","stargazers_url":"https://api.github.com/repos/odlgroup/odl/stargazers","contributors_url":"https://api.github.com/repos/odlgroup/odl/contributors","subscribers_url":"https://api.github.com/repos/odlgroup/odl/subscribers","subscription_url":"https://api.github.com/repos/odlgroup/odl/subscription","commits_url":"https://api.github.com/repos/odlgroup/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/odlgroup/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/odlgroup/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/odlgroup/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/odlgroup/odl/contents/{+path}","compare_url":"https://api.github.com/repos/odlgroup/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odlgroup/odl/merges","archive_url":"https://api.github.com/repos/odlgroup/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odlgroup/odl/downloads","issues_url":"https://api.github.com/repos/odlgroup/odl/issues{/number}","pulls_url":"https://api.github.com/repos/odlgroup/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/odlgroup/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/odlgroup/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odlgroup/odl/labels{/name}","releases_url":"https://api.github.com/repos/odlgroup/odl/releases{/id}","deployments_url":"https://api.github.com/repos/odlgroup/odl/deployments","created_at":"2015-11-05T07:57:55Z","updated_at":"2018-06-11T14:54:06Z","pushed_at":"2018-06-12T07:27:52Z","git_url":"git://github.com/odlgroup/odl.git","ssh_url":"git@github.com:odlgroup/odl.git","clone_url":"https://github.com/odlgroup/odl.git","svn_url":"https://github.com/odlgroup/odl","homepage":"","size":42145,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":39,"open_issues":186,"watchers":64,"default_branch":"master"}},"base":{"label":"odlgroup:master","ref":"master","sha":"dff29c18f2cd5cd7375d3afb1b6e6a7e7789f03a","user":{"login":"odlgroup","id":15667171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjY3MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45596393,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU5NjM5Mw==","name":"odl","full_name":"odlgroup/odl","owner":{"login":"odlgroup","id":15667171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjY3MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odlgroup/odl","description":"Operator Discretization Library  https://odlgroup.github.io/odl/","fork":false,"url":"https://api.github.com/repos/odlgroup/odl","forks_url":"https://api.github.com/repos/odlgroup/odl/forks","keys_url":"https://api.github.com/repos/odlgroup/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odlgroup/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odlgroup/odl/teams","hooks_url":"https://api.github.com/repos/odlgroup/odl/hooks","issue_events_url":"https://api.github.com/repos/odlgroup/odl/issues/events{/number}","events_url":"https://api.github.com/repos/odlgroup/odl/events","assignees_url":"https://api.github.com/repos/odlgroup/odl/assignees{/user}","branches_url":"https://api.github.com/repos/odlgroup/odl/branches{/branch}","tags_url":"https://api.github.com/repos/odlgroup/odl/tags","blobs_url":"https://api.github.com/repos/odlgroup/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odlgroup/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odlgroup/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/odlgroup/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/odlgroup/odl/languages","stargazers_url":"https://api.github.com/repos/odlgroup/odl/stargazers","contributors_url":"https://api.github.com/repos/odlgroup/odl/contributors","subscribers_url":"https://api.github.com/repos/odlgroup/odl/subscribers","subscription_url":"https://api.github.com/repos/odlgroup/odl/subscription","commits_url":"https://api.github.com/repos/odlgroup/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/odlgroup/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/odlgroup/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/odlgroup/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/odlgroup/odl/contents/{+path}","compare_url":"https://api.github.com/repos/odlgroup/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odlgroup/odl/merges","archive_url":"https://api.github.com/repos/odlgroup/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odlgroup/odl/downloads","issues_url":"https://api.github.com/repos/odlgroup/odl/issues{/number}","pulls_url":"https://api.github.com/repos/odlgroup/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/odlgroup/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/odlgroup/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odlgroup/odl/labels{/name}","releases_url":"https://api.github.com/repos/odlgroup/odl/releases{/id}","deployments_url":"https://api.github.com/repos/odlgroup/odl/deployments","created_at":"2015-11-05T07:57:55Z","updated_at":"2018-06-11T14:54:06Z","pushed_at":"2018-06-12T07:27:52Z","git_url":"git://github.com/odlgroup/odl.git","ssh_url":"git@github.com:odlgroup/odl.git","clone_url":"https://github.com/odlgroup/odl.git","svn_url":"https://github.com/odlgroup/odl","homepage":"","size":42145,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":39,"open_issues":186,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1280"},"html":{"href":"https://github.com/odlgroup/odl/pull/1280"},"issue":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1280"},"comments":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1280/comments"},"review_comments":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1280/comments"},"review_comment":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1280/commits"},"statuses":{"href":"https://api.github.com/repos/odlgroup/odl/statuses/66227953714ba57add0a9bedb876d337398ed692"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adler-j"}}