{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/183225719","pull_request_review_id":114189820,"id":183225719,"diff_hunk":"@@ -14,6 +14,7 @@\n  */\n namespace Cake\\Error;\n \n+use Psr\\Http\\Message\\ServerRequestInterface;","path":"src/Error/ExceptionRenderer.php","position":4,"original_position":4,"commit_id":"f10a9fe17bc71c24747222f7dd887fdd662d480f","original_commit_id":"50fdde588eeb9b315ead5f24c377474c7e4526ba","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars3.githubusercontent.com/u/16011037?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"Use classes must be in alphabetical order. Was expecting Cake\\Controller\\Controller","created_at":"2018-04-22T05:13:54Z","updated_at":"2018-04-22T05:13:55Z","html_url":"https://github.com/cakephp/cakephp/pull/11978#discussion_r183225719","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/11978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/183225719"},"html":{"href":"https://github.com/cakephp/cakephp/pull/11978#discussion_r183225719"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/11978"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/11978","id":183256109,"html_url":"https://github.com/cakephp/cakephp/pull/11978","diff_url":"https://github.com/cakephp/cakephp/pull/11978.diff","patch_url":"https://github.com/cakephp/cakephp/pull/11978.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/11978","number":11978,"state":"open","locked":false,"title":"Fix for Issue 11974","user":{"login":"iliepandia","id":1885906,"avatar_url":"https://avatars0.githubusercontent.com/u/1885906?v=4","gravatar_id":"","url":"https://api.github.com/users/iliepandia","html_url":"https://github.com/iliepandia","followers_url":"https://api.github.com/users/iliepandia/followers","following_url":"https://api.github.com/users/iliepandia/following{/other_user}","gists_url":"https://api.github.com/users/iliepandia/gists{/gist_id}","starred_url":"https://api.github.com/users/iliepandia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iliepandia/subscriptions","organizations_url":"https://api.github.com/users/iliepandia/orgs","repos_url":"https://api.github.com/users/iliepandia/repos","events_url":"https://api.github.com/users/iliepandia/events{/privacy}","received_events_url":"https://api.github.com/users/iliepandia/received_events","type":"User","site_admin":false},"body":"This is a suggested fix for #11974 - passing the original request along to the various handlers that are interested in it.\r\n\r\n### Notable changes\r\n\r\nThe `ExceptionRenderer::__construct()` had to be changed to accept the passed along request. I've put `null` as a default so it would still work if called with the previous signature.\r\n\r\n### Cake\\TestSuite\\LegacyRequestDispatcher vs Cake\\TestSuite\\MiddlewareDispatcher\r\n\r\nThey both implemet `execute()` but one expects to an array and the other one a ServerRequest (at least according to PHPDoc).\r\n\r\nTo fix this is have modified the MiddlewareDispatcher to honor the PHPDoc and changed the `IntegrationTestCase::_sendRequest()` to pass along an array to LegacyRequestDispatcher or a prsRequest to the new MiddlewareDispatcher. \r\n\r\nCake tests are now passing. \r\nMy own application tests are passing too. \r\n\r\nI don't know how to add a test in Cake to test specifically for the problem described at #11974 ","created_at":"2018-04-22T05:13:37Z","updated_at":"2018-04-22T05:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2a0d817105f4d8c01fe338bdccc48f23d59bbc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/11978/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/11978/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/11978/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/f10a9fe17bc71c24747222f7dd887fdd662d480f","head":{"label":"iliepandia:issue-11974","ref":"issue-11974","sha":"f10a9fe17bc71c24747222f7dd887fdd662d480f","user":{"login":"iliepandia","id":1885906,"avatar_url":"https://avatars0.githubusercontent.com/u/1885906?v=4","gravatar_id":"","url":"https://api.github.com/users/iliepandia","html_url":"https://github.com/iliepandia","followers_url":"https://api.github.com/users/iliepandia/followers","following_url":"https://api.github.com/users/iliepandia/following{/other_user}","gists_url":"https://api.github.com/users/iliepandia/gists{/gist_id}","starred_url":"https://api.github.com/users/iliepandia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iliepandia/subscriptions","organizations_url":"https://api.github.com/users/iliepandia/orgs","repos_url":"https://api.github.com/users/iliepandia/repos","events_url":"https://api.github.com/users/iliepandia/events{/privacy}","received_events_url":"https://api.github.com/users/iliepandia/received_events","type":"User","site_admin":false},"repo":{"id":4770076,"name":"cakephp","full_name":"iliepandia/cakephp","owner":{"login":"iliepandia","id":1885906,"avatar_url":"https://avatars0.githubusercontent.com/u/1885906?v=4","gravatar_id":"","url":"https://api.github.com/users/iliepandia","html_url":"https://github.com/iliepandia","followers_url":"https://api.github.com/users/iliepandia/followers","following_url":"https://api.github.com/users/iliepandia/following{/other_user}","gists_url":"https://api.github.com/users/iliepandia/gists{/gist_id}","starred_url":"https://api.github.com/users/iliepandia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iliepandia/subscriptions","organizations_url":"https://api.github.com/users/iliepandia/orgs","repos_url":"https://api.github.com/users/iliepandia/repos","events_url":"https://api.github.com/users/iliepandia/events{/privacy}","received_events_url":"https://api.github.com/users/iliepandia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iliepandia/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/iliepandia/cakephp","forks_url":"https://api.github.com/repos/iliepandia/cakephp/forks","keys_url":"https://api.github.com/repos/iliepandia/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iliepandia/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iliepandia/cakephp/teams","hooks_url":"https://api.github.com/repos/iliepandia/cakephp/hooks","issue_events_url":"https://api.github.com/repos/iliepandia/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/iliepandia/cakephp/events","assignees_url":"https://api.github.com/repos/iliepandia/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/iliepandia/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/iliepandia/cakephp/tags","blobs_url":"https://api.github.com/repos/iliepandia/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iliepandia/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iliepandia/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/iliepandia/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iliepandia/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/iliepandia/cakephp/languages","stargazers_url":"https://api.github.com/repos/iliepandia/cakephp/stargazers","contributors_url":"https://api.github.com/repos/iliepandia/cakephp/contributors","subscribers_url":"https://api.github.com/repos/iliepandia/cakephp/subscribers","subscription_url":"https://api.github.com/repos/iliepandia/cakephp/subscription","commits_url":"https://api.github.com/repos/iliepandia/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/iliepandia/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/iliepandia/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/iliepandia/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/iliepandia/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/iliepandia/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iliepandia/cakephp/merges","archive_url":"https://api.github.com/repos/iliepandia/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iliepandia/cakephp/downloads","issues_url":"https://api.github.com/repos/iliepandia/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/iliepandia/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/iliepandia/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/iliepandia/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iliepandia/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/iliepandia/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/iliepandia/cakephp/deployments","created_at":"2012-06-24T05:08:38Z","updated_at":"2018-04-21T15:44:33Z","pushed_at":"2018-04-22T05:13:52Z","git_url":"git://github.com/iliepandia/cakephp.git","ssh_url":"git@github.com:iliepandia/cakephp.git","clone_url":"https://github.com/iliepandia/cakephp.git","svn_url":"https://github.com/iliepandia/cakephp","homepage":"http://cakephp.org","size":72551,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"d4bcd8b7e76fb3058dcc45f2ddfbe3ca955c69e9","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2018-04-21T21:45:23Z","pushed_at":"2018-04-22T05:13:54Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":76881,"stargazers_count":7513,"watchers_count":7513,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3325,"mirror_url":null,"archived":false,"open_issues_count":224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3325,"open_issues":224,"watchers":7513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/11978"},"html":{"href":"https://github.com/cakephp/cakephp/pull/11978"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/11978"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/11978/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/11978/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/11978/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/f10a9fe17bc71c24747222f7dd887fdd662d480f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stickler-ci"}}