{"action":"opened","number":1056,"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056","id":203949654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTQ5NjU0","html_url":"https://github.com/blockchain/My-Wallet-V3-Android/pull/1056","diff_url":"https://github.com/blockchain/My-Wallet-V3-Android/pull/1056.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-Android/pull/1056.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/1056","number":1056,"state":"open","locked":false,"title":"AND-1241 KYC feature flag","user":{"login":"westonal","id":6041352,"node_id":"MDQ6VXNlcjYwNDEzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6041352?v=4","gravatar_id":"","url":"https://api.github.com/users/westonal","html_url":"https://github.com/westonal","followers_url":"https://api.github.com/users/westonal/followers","following_url":"https://api.github.com/users/westonal/following{/other_user}","gists_url":"https://api.github.com/users/westonal/gists{/gist_id}","starred_url":"https://api.github.com/users/westonal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonal/subscriptions","organizations_url":"https://api.github.com/users/westonal/orgs","repos_url":"https://api.github.com/users/westonal/repos","events_url":"https://api.github.com/users/westonal/events{/privacy}","received_events_url":"https://api.github.com/users/westonal/received_events","type":"User","site_admin":false},"body":"- I've gone for a shared feature flag name with homebrew.\r\n- We can make it country specific easily with a replacement implementation of `kyc.FeatureFlag`.\r\n- Same story if we move from `options.json` at some point, it's no problem to create a replacement implementation of `kyc.FeatureFlag`.\r\n- For new classes in the new module, I've started going for a base package of `com.blockchain.kyc`, so no `\"piuk\"` or `\"android\"` what do you think?\r\n","created_at":"2018-07-25T20:12:23Z","updated_at":"2018-07-25T20:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/1056/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/statuses/8feb023f2a9041a1e34ad89e087d9c80a57b6d09","head":{"label":"blockchain:alan/AND-1241/feature-flag","ref":"alan/AND-1241/feature-flag","sha":"8feb023f2a9041a1e34ad89e087d9c80a57b6d09","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26164928,"node_id":"MDEwOlJlcG9zaXRvcnkyNjE2NDkyOA==","name":"My-Wallet-V3-Android","full_name":"blockchain/My-Wallet-V3-Android","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-Android","description":"Blockchain Android Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/deployments","created_at":"2014-11-04T10:54:57Z","updated_at":"2018-07-24T12:49:06Z","pushed_at":"2018-07-25T20:04:03Z","git_url":"git://github.com/blockchain/My-Wallet-V3-Android.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-Android.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-Android.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-Android","homepage":"https://play.google.com/store/apps/details?id=piuk.blockchain.android","size":56783,"stargazers_count":165,"watchers_count":165,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":133,"open_issues":4,"watchers":165,"default_branch":"master"}},"base":{"label":"blockchain:develop","ref":"develop","sha":"ae9a02f44bfc9ddb4d5ff9a898db5acb2eb8eab4","user":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":26164928,"node_id":"MDEwOlJlcG9zaXRvcnkyNjE2NDkyOA==","name":"My-Wallet-V3-Android","full_name":"blockchain/My-Wallet-V3-Android","owner":{"login":"blockchain","id":1777722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-Android","description":"Blockchain Android Wallet","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/deployments","created_at":"2014-11-04T10:54:57Z","updated_at":"2018-07-24T12:49:06Z","pushed_at":"2018-07-25T20:04:03Z","git_url":"git://github.com/blockchain/My-Wallet-V3-Android.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-Android.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-Android.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-Android","homepage":"https://play.google.com/store/apps/details?id=piuk.blockchain.android","size":56783,"stargazers_count":165,"watchers_count":165,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":133,"open_issues":4,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-Android/pull/1056"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/1056"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/issues/1056/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/pulls/1056/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Android/statuses/8feb023f2a9041a1e34ad89e087d9c80a57b6d09"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":135,"deletions":3,"changed_files":10}}
{"actor":{"display_login":"westonal"}}