{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/environment_tools/pulls/comments/167693781","pull_request_review_id":95949804,"id":167693781,"diff_hunk":"@@ -0,0 +1,79 @@\n+# -*- coding: utf-8 -*-\n+import re\n+\n+from environment_tools import type_utils\n+\n+NODE_NAME_FORMAT = '[A-Za-z0-9]*(-[A-Za-z0-9]*)*-(?P<location>[A-Za-z0-9]*)($|\\..*)'","path":"environment_tools/node_utils.py","position":6,"original_position":6,"commit_id":"c8991867f0c92ebc4029443124cf877b5bf393b6","original_commit_id":"c8991867f0c92ebc4029443124cf877b5bf393b6","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars0.githubusercontent.com/u/370205?v=4","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"body":"Can you change the word \"node\" to just be \"hostname\"? \r\nI think it will be easier to understand when we just say hostname when we mean it and not refer to a \"node's hostname\"","created_at":"2018-02-12T21:35:33Z","updated_at":"2018-02-12T21:35:33Z","html_url":"https://github.com/Yelp/environment_tools/pull/9#discussion_r167693781","pull_request_url":"https://api.github.com/repos/Yelp/environment_tools/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/comments/167693781"},"html":{"href":"https://github.com/Yelp/environment_tools/pull/9#discussion_r167693781"},"pull_request":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/environment_tools/pulls/9","id":168692640,"html_url":"https://github.com/Yelp/environment_tools/pull/9","diff_url":"https://github.com/Yelp/environment_tools/pull/9.diff","patch_url":"https://github.com/Yelp/environment_tools/pull/9.patch","issue_url":"https://api.github.com/repos/Yelp/environment_tools/issues/9","number":9,"state":"open","locked":false,"title":"Support working with locations along with location types","user":{"login":"ClareCat","id":1620093,"avatar_url":"https://avatars2.githubusercontent.com/u/1620093?v=4","gravatar_id":"","url":"https://api.github.com/users/ClareCat","html_url":"https://github.com/ClareCat","followers_url":"https://api.github.com/users/ClareCat/followers","following_url":"https://api.github.com/users/ClareCat/following{/other_user}","gists_url":"https://api.github.com/users/ClareCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ClareCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClareCat/subscriptions","organizations_url":"https://api.github.com/users/ClareCat/orgs","repos_url":"https://api.github.com/users/ClareCat/repos","events_url":"https://api.github.com/users/ClareCat/events{/privacy}","received_events_url":"https://api.github.com/users/ClareCat/received_events","type":"User","site_admin":false},"body":"Most of the environment_tools functionality supports working with location types, but it doesn't provide much of an API for use with locations. This adds the following functionality:\r\n\r\n- Given a hostname + regex string will parse the location.\r\n- Given a location will find the corresponding location type\r\n- Given two locations and a specified location type will determine equality for those locations when converted to that location type.\r\n\r\nSee function docstrings for examples.\r\n\r\nAlso upped flake8 line length to 120.","created_at":"2018-02-12T21:28:17Z","updated_at":"2018-02-12T21:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a6f11f2729b3d404a3a94f9805d4ec11d376bdb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"EvanKrall","id":233961,"avatar_url":"https://avatars2.githubusercontent.com/u/233961?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanKrall","html_url":"https://github.com/EvanKrall","followers_url":"https://api.github.com/users/EvanKrall/followers","following_url":"https://api.github.com/users/EvanKrall/following{/other_user}","gists_url":"https://api.github.com/users/EvanKrall/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanKrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanKrall/subscriptions","organizations_url":"https://api.github.com/users/EvanKrall/orgs","repos_url":"https://api.github.com/users/EvanKrall/repos","events_url":"https://api.github.com/users/EvanKrall/events{/privacy}","received_events_url":"https://api.github.com/users/EvanKrall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/environment_tools/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Yelp/environment_tools/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Yelp/environment_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/environment_tools/issues/9/comments","statuses_url":"https://api.github.com/repos/Yelp/environment_tools/statuses/c8991867f0c92ebc4029443124cf877b5bf393b6","head":{"label":"ClareCat:node_utils","ref":"node_utils","sha":"c8991867f0c92ebc4029443124cf877b5bf393b6","user":{"login":"ClareCat","id":1620093,"avatar_url":"https://avatars2.githubusercontent.com/u/1620093?v=4","gravatar_id":"","url":"https://api.github.com/users/ClareCat","html_url":"https://github.com/ClareCat","followers_url":"https://api.github.com/users/ClareCat/followers","following_url":"https://api.github.com/users/ClareCat/following{/other_user}","gists_url":"https://api.github.com/users/ClareCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ClareCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClareCat/subscriptions","organizations_url":"https://api.github.com/users/ClareCat/orgs","repos_url":"https://api.github.com/users/ClareCat/repos","events_url":"https://api.github.com/users/ClareCat/events{/privacy}","received_events_url":"https://api.github.com/users/ClareCat/received_events","type":"User","site_admin":false},"repo":{"id":121282365,"name":"environment_tools","full_name":"ClareCat/environment_tools","owner":{"login":"ClareCat","id":1620093,"avatar_url":"https://avatars2.githubusercontent.com/u/1620093?v=4","gravatar_id":"","url":"https://api.github.com/users/ClareCat","html_url":"https://github.com/ClareCat","followers_url":"https://api.github.com/users/ClareCat/followers","following_url":"https://api.github.com/users/ClareCat/following{/other_user}","gists_url":"https://api.github.com/users/ClareCat/gists{/gist_id}","starred_url":"https://api.github.com/users/ClareCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClareCat/subscriptions","organizations_url":"https://api.github.com/users/ClareCat/orgs","repos_url":"https://api.github.com/users/ClareCat/repos","events_url":"https://api.github.com/users/ClareCat/events{/privacy}","received_events_url":"https://api.github.com/users/ClareCat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ClareCat/environment_tools","description":"Tools for programmatically describing Yelp's different environments (prod, dev, stage)","fork":true,"url":"https://api.github.com/repos/ClareCat/environment_tools","forks_url":"https://api.github.com/repos/ClareCat/environment_tools/forks","keys_url":"https://api.github.com/repos/ClareCat/environment_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClareCat/environment_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClareCat/environment_tools/teams","hooks_url":"https://api.github.com/repos/ClareCat/environment_tools/hooks","issue_events_url":"https://api.github.com/repos/ClareCat/environment_tools/issues/events{/number}","events_url":"https://api.github.com/repos/ClareCat/environment_tools/events","assignees_url":"https://api.github.com/repos/ClareCat/environment_tools/assignees{/user}","branches_url":"https://api.github.com/repos/ClareCat/environment_tools/branches{/branch}","tags_url":"https://api.github.com/repos/ClareCat/environment_tools/tags","blobs_url":"https://api.github.com/repos/ClareCat/environment_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClareCat/environment_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClareCat/environment_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClareCat/environment_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClareCat/environment_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ClareCat/environment_tools/languages","stargazers_url":"https://api.github.com/repos/ClareCat/environment_tools/stargazers","contributors_url":"https://api.github.com/repos/ClareCat/environment_tools/contributors","subscribers_url":"https://api.github.com/repos/ClareCat/environment_tools/subscribers","subscription_url":"https://api.github.com/repos/ClareCat/environment_tools/subscription","commits_url":"https://api.github.com/repos/ClareCat/environment_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClareCat/environment_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClareCat/environment_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClareCat/environment_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClareCat/environment_tools/contents/{+path}","compare_url":"https://api.github.com/repos/ClareCat/environment_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClareCat/environment_tools/merges","archive_url":"https://api.github.com/repos/ClareCat/environment_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClareCat/environment_tools/downloads","issues_url":"https://api.github.com/repos/ClareCat/environment_tools/issues{/number}","pulls_url":"https://api.github.com/repos/ClareCat/environment_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ClareCat/environment_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ClareCat/environment_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClareCat/environment_tools/labels{/name}","releases_url":"https://api.github.com/repos/ClareCat/environment_tools/releases{/id}","deployments_url":"https://api.github.com/repos/ClareCat/environment_tools/deployments","created_at":"2018-02-12T18:04:07Z","updated_at":"2018-02-12T18:04:08Z","pushed_at":"2018-02-12T21:20:05Z","git_url":"git://github.com/ClareCat/environment_tools.git","ssh_url":"git@github.com:ClareCat/environment_tools.git","clone_url":"https://github.com/ClareCat/environment_tools.git","svn_url":"https://github.com/ClareCat/environment_tools","homepage":"","size":18,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"3a907e6b50c9ec2c82e1ad3c29957ba17aa39ced","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":45880151,"name":"environment_tools","full_name":"Yelp/environment_tools","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/environment_tools","description":"Tools for programmatically describing Yelp's different environments (prod, dev, stage)","fork":false,"url":"https://api.github.com/repos/Yelp/environment_tools","forks_url":"https://api.github.com/repos/Yelp/environment_tools/forks","keys_url":"https://api.github.com/repos/Yelp/environment_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/environment_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/environment_tools/teams","hooks_url":"https://api.github.com/repos/Yelp/environment_tools/hooks","issue_events_url":"https://api.github.com/repos/Yelp/environment_tools/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/environment_tools/events","assignees_url":"https://api.github.com/repos/Yelp/environment_tools/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/environment_tools/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/environment_tools/tags","blobs_url":"https://api.github.com/repos/Yelp/environment_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/environment_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/environment_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/environment_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/environment_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/environment_tools/languages","stargazers_url":"https://api.github.com/repos/Yelp/environment_tools/stargazers","contributors_url":"https://api.github.com/repos/Yelp/environment_tools/contributors","subscribers_url":"https://api.github.com/repos/Yelp/environment_tools/subscribers","subscription_url":"https://api.github.com/repos/Yelp/environment_tools/subscription","commits_url":"https://api.github.com/repos/Yelp/environment_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/environment_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/environment_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/environment_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/environment_tools/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/environment_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/environment_tools/merges","archive_url":"https://api.github.com/repos/Yelp/environment_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/environment_tools/downloads","issues_url":"https://api.github.com/repos/Yelp/environment_tools/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/environment_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/environment_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/environment_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/environment_tools/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/environment_tools/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/environment_tools/deployments","created_at":"2015-11-10T01:51:18Z","updated_at":"2017-07-05T15:42:53Z","pushed_at":"2018-02-12T21:28:18Z","git_url":"git://github.com/Yelp/environment_tools.git","ssh_url":"git@github.com:Yelp/environment_tools.git","clone_url":"https://github.com/Yelp/environment_tools.git","svn_url":"https://github.com/Yelp/environment_tools","homepage":"","size":18,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/9"},"html":{"href":"https://github.com/Yelp/environment_tools/pull/9"},"issue":{"href":"https://api.github.com/repos/Yelp/environment_tools/issues/9"},"comments":{"href":"https://api.github.com/repos/Yelp/environment_tools/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/environment_tools/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/environment_tools/statuses/c8991867f0c92ebc4029443124cf877b5bf393b6"}},"author_association":"NONE"}}
{"actor":{"display_login":"solarkennedy"}}