{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.io/pulls/comments/226520232","pull_request_review_id":166361330,"id":226520232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjUyMDIzMg==","diff_hunk":"@@ -132,7 +136,13 @@ def decode_helm_yaml(s):\n         print d\n         if \"<!-- AUTO-GENERATED-START -->\" in d:\n             break\n+    # if os.path.exists(\"values.yaml\"):\n+    #     os.remove(\"values.yaml\")\n+    # else:\n+    #     print(\"values.yaml doesn't exist\")\n \n+    # values = 'https://raw.githubusercontent.com/istio/istio/master/install/kubernetes/helm/istio/values.yaml'","path":"scripts/tablegen/tablegen.py","position":55,"original_position":55,"commit_id":"ef7bf44935a2b5ae136ffbfda6a535e7ac0bb510","original_commit_id":"ef7bf44935a2b5ae136ffbfda6a535e7ac0bb510","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"body":"this is really cool!  I hadn't really considered this - I was instead thinking we would add a command line argument to pass the values in.  This is better.  We do need to be able to handle specific tags.  For the moment, its ok if this is manual, but perhaps the tag or branch could be passed in via cli?","created_at":"2018-10-19T02:32:53Z","updated_at":"2018-10-19T02:38:34Z","html_url":"https://github.com/istio/istio.io/pull/2784#discussion_r226520232","pull_request_url":"https://api.github.com/repos/istio/istio.io/pulls/2784","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments/226520232"},"html":{"href":"https://github.com/istio/istio.io/pull/2784#discussion_r226520232"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2784"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.io/pulls/2784","id":224108266,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTA4MjY2","html_url":"https://github.com/istio/istio.io/pull/2784","diff_url":"https://github.com/istio/istio.io/pull/2784.diff","patch_url":"https://github.com/istio/istio.io/pull/2784.patch","issue_url":"https://api.github.com/repos/istio/istio.io/issues/2784","number":2784,"state":"open","locked":false,"title":"WIP: Helm docs","user":{"login":"jjasghar","id":810824,"node_id":"MDQ6VXNlcjgxMDgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/810824?v=4","gravatar_id":"","url":"https://api.github.com/users/jjasghar","html_url":"https://github.com/jjasghar","followers_url":"https://api.github.com/users/jjasghar/followers","following_url":"https://api.github.com/users/jjasghar/following{/other_user}","gists_url":"https://api.github.com/users/jjasghar/gists{/gist_id}","starred_url":"https://api.github.com/users/jjasghar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjasghar/subscriptions","organizations_url":"https://api.github.com/users/jjasghar/orgs","repos_url":"https://api.github.com/users/jjasghar/repos","events_url":"https://api.github.com/users/jjasghar/events{/privacy}","received_events_url":"https://api.github.com/users/jjasghar/received_events","type":"User","site_admin":false},"body":"This will fix the script so you can run it and just get the values from the values.yaml.","created_at":"2018-10-18T21:41:40Z","updated_at":"2018-10-19T02:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2e24ec1591e7705094efc7f268e1727d3323b7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"linsun","id":1588319,"node_id":"MDQ6VXNlcjE1ODgzMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1588319?v=4","gravatar_id":"","url":"https://api.github.com/users/linsun","html_url":"https://github.com/linsun","followers_url":"https://api.github.com/users/linsun/followers","following_url":"https://api.github.com/users/linsun/following{/other_user}","gists_url":"https://api.github.com/users/linsun/gists{/gist_id}","starred_url":"https://api.github.com/users/linsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linsun/subscriptions","organizations_url":"https://api.github.com/users/linsun/orgs","repos_url":"https://api.github.com/users/linsun/repos","events_url":"https://api.github.com/users/linsun/events{/privacy}","received_events_url":"https://api.github.com/users/linsun/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"node_id":"MDU6TGFiZWw4ODQyNDc0NzU=","url":"https://api.github.com/repos/istio/istio.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":961350981,"node_id":"MDU6TGFiZWw5NjEzNTA5ODE=","url":"https://api.github.com/repos/istio/istio.io/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"ededed","default":false},{"id":881683131,"node_id":"MDU6TGFiZWw4ODE2ODMxMzE=","url":"https://api.github.com/repos/istio/istio.io/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.io/pulls/2784/commits","review_comments_url":"https://api.github.com/repos/istio/istio.io/pulls/2784/comments","review_comment_url":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.io/issues/2784/comments","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/ef7bf44935a2b5ae136ffbfda6a535e7ac0bb510","head":{"label":"jjasghar:helm_docs","ref":"helm_docs","sha":"ef7bf44935a2b5ae136ffbfda6a535e7ac0bb510","user":{"login":"jjasghar","id":810824,"node_id":"MDQ6VXNlcjgxMDgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/810824?v=4","gravatar_id":"","url":"https://api.github.com/users/jjasghar","html_url":"https://github.com/jjasghar","followers_url":"https://api.github.com/users/jjasghar/followers","following_url":"https://api.github.com/users/jjasghar/following{/other_user}","gists_url":"https://api.github.com/users/jjasghar/gists{/gist_id}","starred_url":"https://api.github.com/users/jjasghar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjasghar/subscriptions","organizations_url":"https://api.github.com/users/jjasghar/orgs","repos_url":"https://api.github.com/users/jjasghar/repos","events_url":"https://api.github.com/users/jjasghar/events{/privacy}","received_events_url":"https://api.github.com/users/jjasghar/received_events","type":"User","site_admin":false},"repo":{"id":152112609,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMTI2MDk=","name":"istio.io","full_name":"jjasghar/istio.io","private":false,"owner":{"login":"jjasghar","id":810824,"node_id":"MDQ6VXNlcjgxMDgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/810824?v=4","gravatar_id":"","url":"https://api.github.com/users/jjasghar","html_url":"https://github.com/jjasghar","followers_url":"https://api.github.com/users/jjasghar/followers","following_url":"https://api.github.com/users/jjasghar/following{/other_user}","gists_url":"https://api.github.com/users/jjasghar/gists{/gist_id}","starred_url":"https://api.github.com/users/jjasghar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjasghar/subscriptions","organizations_url":"https://api.github.com/users/jjasghar/orgs","repos_url":"https://api.github.com/users/jjasghar/repos","events_url":"https://api.github.com/users/jjasghar/events{/privacy}","received_events_url":"https://api.github.com/users/jjasghar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjasghar/istio.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/jjasghar/istio.io","forks_url":"https://api.github.com/repos/jjasghar/istio.io/forks","keys_url":"https://api.github.com/repos/jjasghar/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjasghar/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjasghar/istio.io/teams","hooks_url":"https://api.github.com/repos/jjasghar/istio.io/hooks","issue_events_url":"https://api.github.com/repos/jjasghar/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/jjasghar/istio.io/events","assignees_url":"https://api.github.com/repos/jjasghar/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/jjasghar/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/jjasghar/istio.io/tags","blobs_url":"https://api.github.com/repos/jjasghar/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjasghar/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjasghar/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjasghar/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjasghar/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/jjasghar/istio.io/languages","stargazers_url":"https://api.github.com/repos/jjasghar/istio.io/stargazers","contributors_url":"https://api.github.com/repos/jjasghar/istio.io/contributors","subscribers_url":"https://api.github.com/repos/jjasghar/istio.io/subscribers","subscription_url":"https://api.github.com/repos/jjasghar/istio.io/subscription","commits_url":"https://api.github.com/repos/jjasghar/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjasghar/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjasghar/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjasghar/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjasghar/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/jjasghar/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjasghar/istio.io/merges","archive_url":"https://api.github.com/repos/jjasghar/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjasghar/istio.io/downloads","issues_url":"https://api.github.com/repos/jjasghar/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/jjasghar/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/jjasghar/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/jjasghar/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjasghar/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/jjasghar/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/jjasghar/istio.io/deployments","created_at":"2018-10-08T16:35:20Z","updated_at":"2018-10-08T16:35:25Z","pushed_at":"2018-10-18T21:41:03Z","git_url":"git://github.com/jjasghar/istio.io.git","ssh_url":"git@github.com:jjasghar/istio.io.git","clone_url":"https://github.com/jjasghar/istio.io.git","svn_url":"https://github.com/jjasghar/istio.io","homepage":"https://istio.io/","size":35956,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"158bfa1d0561f02fe3d5002298627273c8daaff8","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.io","full_name":"istio/istio.io","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.io","forks_url":"https://api.github.com/repos/istio/istio.io/forks","keys_url":"https://api.github.com/repos/istio/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.io/events","assignees_url":"https://api.github.com/repos/istio/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.io/merges","archive_url":"https://api.github.com/repos/istio/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-10-17T16:44:11Z","pushed_at":"2018-10-18T21:41:41Z","git_url":"git://github.com/istio/istio.io.git","ssh_url":"git@github.com:istio/istio.io.git","clone_url":"https://github.com/istio/istio.io.git","svn_url":"https://github.com/istio/istio.io","homepage":"https://istio.io/","size":36472,"stargazers_count":130,"watchers_count":130,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":373,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":373,"open_issues":108,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2784"},"html":{"href":"https://github.com/istio/istio.io/pull/2784"},"issue":{"href":"https://api.github.com/repos/istio/istio.io/issues/2784"},"comments":{"href":"https://api.github.com/repos/istio/istio.io/issues/2784/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2784/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2784/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.io/statuses/ef7bf44935a2b5ae136ffbfda6a535e7ac0bb510"}},"author_association":"NONE"}}
{"actor":{"display_login":"sdake"}}