{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4505","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4505/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4505/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4505/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4505","id":352446889,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzU0MjM3","number":4505,"title":"Add restful redirect rule for notifications arriving from V2V","user":{"login":"skateman","id":649130,"node_id":"MDQ6VXNlcjY0OTEzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-21T08:59:22Z","updated_at":"2018-08-21T09:07:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4505","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4505","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4505.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4505.patch"},"body":"This is an addition to a really bad antipattern that allows us to redirect the user to an URL based on a record type and an ID. However, for now there's no other way to do this, but I will actively think on a [better solution](http://media.ifunny.com/results/2018/03/29/482i5kkucz.jpg) in the future.\r\n\r\n@AparnaKarve stated that it's 100% sure that the `ServiceTemplateTransformationPlanRequest` is not used for anything else than V2V and I believed her, so any request coming with this model will be redirected to the `migration` controller defined in V2V. As they're using hash routes, I had to use the `:anchor` parameter of the `redirect_to` method.\r\n\r\nRelated drawer modifications: https://github.com/ManageIQ/manageiq-ui-classic/pull/4492\r\nRelated issue: https://github.com/ManageIQ/manageiq-v2v/issues/578\r\n\r\n@miq-bot add_reviewer @martinpovolny \r\n@miq-bot add_reviewer @AparnaKarve "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/414605667","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4505#issuecomment-414605667","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4505","id":414605667,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDYwNTY2Nw==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T09:07:46Z","updated_at":"2018-08-21T09:07:46Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/skateman/manageiq-ui-classic/compare/49dabf8a9de006aa814f0e9a2af01ccc75356ec4~...b422726539df9cffd89946508f0644fafe0b1dc6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n1 file checked, 1 offense detected\n\n**app/controllers/restful_redirect_controller.rb**\n- [ ] :exclamation: - [Line 8](https://github.com/skateman/manageiq-ui-classic/blob/b422726539df9cffd89946508f0644fafe0b1dc6/app/controllers/restful_redirect_controller.rb#L8), Col 7 - [Style/MethodCallWithArgsParentheses](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/MethodCallWithArgsParentheses) - Use parentheses for method calls with arguments.\n"}}
{"actor":{"display_login":"miq-bot"}}