{"action":"created","comment":{"url":"https://api.github.com/repos/cbeust/testng/pulls/comments/236265954","pull_request_review_id":178302609,"id":236265954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI2NTk1NA==","diff_hunk":"@@ -294,6 +285,7 @@ private static void finishInitialize(\n     return vResult.values().toArray(new ITestNGMethod[0]);\n   }\n \n+  @SuppressWarnings(\"unchecked\")","path":"src/main/java/org/testng/internal/annotations/AnnotationHelper.java","position":36,"original_position":36,"commit_id":"31bfe25e62636b813e5ae328afc86597c00eed82","original_commit_id":"e334125cec8bb3938eb0ddf88becaf9101ba0091","user":{"login":"juherr","id":254697,"node_id":"MDQ6VXNlcjI1NDY5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/254697?v=4","gravatar_id":"","url":"https://api.github.com/users/juherr","html_url":"https://github.com/juherr","followers_url":"https://api.github.com/users/juherr/followers","following_url":"https://api.github.com/users/juherr/following{/other_user}","gists_url":"https://api.github.com/users/juherr/gists{/gist_id}","starred_url":"https://api.github.com/users/juherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juherr/subscriptions","organizations_url":"https://api.github.com/users/juherr/orgs","repos_url":"https://api.github.com/users/juherr/repos","events_url":"https://api.github.com/users/juherr/events{/privacy}","received_events_url":"https://api.github.com/users/juherr/received_events","type":"User","site_admin":false},"body":"I need to try in an IDE. But something like that should work:\r\n\r\n```java\r\npublic static <A extends Annotation> A findAnnotationSuperClasses(\r\n    Class<A> annotationClass, Class<?> parameterClass) {\r\n    Class<?> c = parameterClass;\r\n     while (c != null) {\r\n       A result = c.getAnnotation(annotationClass);\r\n       if (result != null) {\r\n         return result;\r\n       }\r\n       c = c.getSuperclass();\r\n     }\r\n     return null;\r\n   }\r\n```","created_at":"2018-11-26T14:04:16Z","updated_at":"2018-11-26T14:04:16Z","html_url":"https://github.com/cbeust/testng/pull/1963#discussion_r236265954","pull_request_url":"https://api.github.com/repos/cbeust/testng/pulls/1963","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments/236265954"},"html":{"href":"https://github.com/cbeust/testng/pull/1963#discussion_r236265954"},"pull_request":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1963"}},"in_reply_to_id":236243858},"pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/1963","id":233545299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTQ1Mjk5","html_url":"https://github.com/cbeust/testng/pull/1963","diff_url":"https://github.com/cbeust/testng/pull/1963.diff","patch_url":"https://github.com/cbeust/testng/pull/1963.patch","issue_url":"https://api.github.com/repos/cbeust/testng/issues/1963","number":1963,"state":"open","locked":false,"title":"More refactoring changes","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"body":"Following changes were done\r\n\r\n* Removed type references \r\n* Removed referring to deprecated code\r\n* Added “SafeVarargs” wherever applicable\r\n* Removed un-used imports\r\n* Removed SuppressWarnings wherever applicable\r\n* Refactored methods so that its usage is not in an \r\ninverted fashion [ i.e., not like !isValid() type ]\r\n* Removed un-used methods (didn’t deprecate them \r\nsince they are internal package residing methods )\r\n* Use lambdas wherever applicable\r\n* Removed extraneous method arguments wherever \r\napplicable\r\n","created_at":"2018-11-26T12:45:49Z","updated_at":"2018-11-26T14:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc20916c899624285a528e7b540ca5d15d048078","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbeust/testng/pulls/1963/commits","review_comments_url":"https://api.github.com/repos/cbeust/testng/pulls/1963/comments","review_comment_url":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/1963/comments","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/31bfe25e62636b813e5ae328afc86597c00eed82","head":{"label":"krmahadevan:krmahadevan-refactoring-26-11-2018","ref":"krmahadevan-refactoring-26-11-2018","sha":"31bfe25e62636b813e5ae328afc86597c00eed82","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"repo":{"id":35460849,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ2MDg0OQ==","name":"testng","full_name":"krmahadevan/testng","private":false,"owner":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krmahadevan/testng","description":"TestNG testing framework","fork":true,"url":"https://api.github.com/repos/krmahadevan/testng","forks_url":"https://api.github.com/repos/krmahadevan/testng/forks","keys_url":"https://api.github.com/repos/krmahadevan/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krmahadevan/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krmahadevan/testng/teams","hooks_url":"https://api.github.com/repos/krmahadevan/testng/hooks","issue_events_url":"https://api.github.com/repos/krmahadevan/testng/issues/events{/number}","events_url":"https://api.github.com/repos/krmahadevan/testng/events","assignees_url":"https://api.github.com/repos/krmahadevan/testng/assignees{/user}","branches_url":"https://api.github.com/repos/krmahadevan/testng/branches{/branch}","tags_url":"https://api.github.com/repos/krmahadevan/testng/tags","blobs_url":"https://api.github.com/repos/krmahadevan/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krmahadevan/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krmahadevan/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/krmahadevan/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krmahadevan/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/krmahadevan/testng/languages","stargazers_url":"https://api.github.com/repos/krmahadevan/testng/stargazers","contributors_url":"https://api.github.com/repos/krmahadevan/testng/contributors","subscribers_url":"https://api.github.com/repos/krmahadevan/testng/subscribers","subscription_url":"https://api.github.com/repos/krmahadevan/testng/subscription","commits_url":"https://api.github.com/repos/krmahadevan/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/krmahadevan/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/krmahadevan/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/krmahadevan/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/krmahadevan/testng/contents/{+path}","compare_url":"https://api.github.com/repos/krmahadevan/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krmahadevan/testng/merges","archive_url":"https://api.github.com/repos/krmahadevan/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krmahadevan/testng/downloads","issues_url":"https://api.github.com/repos/krmahadevan/testng/issues{/number}","pulls_url":"https://api.github.com/repos/krmahadevan/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/krmahadevan/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/krmahadevan/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krmahadevan/testng/labels{/name}","releases_url":"https://api.github.com/repos/krmahadevan/testng/releases{/id}","deployments_url":"https://api.github.com/repos/krmahadevan/testng/deployments","created_at":"2015-05-12T02:00:29Z","updated_at":"2018-11-26T12:26:01Z","pushed_at":"2018-11-26T13:14:26Z","git_url":"git://github.com/krmahadevan/testng.git","ssh_url":"git@github.com:krmahadevan/testng.git","clone_url":"https://github.com/krmahadevan/testng.git","svn_url":"https://github.com/krmahadevan/testng","homepage":"http://testng.org","size":29080,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeust:master","ref":"master","sha":"637e8ff891c18e85215b804d4f7c94e181593098","user":{"login":"cbeust","id":92322,"node_id":"MDQ6VXNlcjkyMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"repo":{"id":745749,"node_id":"MDEwOlJlcG9zaXRvcnk3NDU3NDk=","name":"testng","full_name":"cbeust/testng","private":false,"owner":{"login":"cbeust","id":92322,"node_id":"MDQ6VXNlcjkyMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbeust/testng","description":"TestNG testing framework","fork":false,"url":"https://api.github.com/repos/cbeust/testng","forks_url":"https://api.github.com/repos/cbeust/testng/forks","keys_url":"https://api.github.com/repos/cbeust/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeust/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeust/testng/teams","hooks_url":"https://api.github.com/repos/cbeust/testng/hooks","issue_events_url":"https://api.github.com/repos/cbeust/testng/issues/events{/number}","events_url":"https://api.github.com/repos/cbeust/testng/events","assignees_url":"https://api.github.com/repos/cbeust/testng/assignees{/user}","branches_url":"https://api.github.com/repos/cbeust/testng/branches{/branch}","tags_url":"https://api.github.com/repos/cbeust/testng/tags","blobs_url":"https://api.github.com/repos/cbeust/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeust/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeust/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeust/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeust/testng/languages","stargazers_url":"https://api.github.com/repos/cbeust/testng/stargazers","contributors_url":"https://api.github.com/repos/cbeust/testng/contributors","subscribers_url":"https://api.github.com/repos/cbeust/testng/subscribers","subscription_url":"https://api.github.com/repos/cbeust/testng/subscription","commits_url":"https://api.github.com/repos/cbeust/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeust/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeust/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeust/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeust/testng/contents/{+path}","compare_url":"https://api.github.com/repos/cbeust/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeust/testng/merges","archive_url":"https://api.github.com/repos/cbeust/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeust/testng/downloads","issues_url":"https://api.github.com/repos/cbeust/testng/issues{/number}","pulls_url":"https://api.github.com/repos/cbeust/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeust/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeust/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeust/testng/labels{/name}","releases_url":"https://api.github.com/repos/cbeust/testng/releases{/id}","deployments_url":"https://api.github.com/repos/cbeust/testng/deployments","created_at":"2010-06-28T23:10:17Z","updated_at":"2018-11-26T12:24:58Z","pushed_at":"2018-11-26T13:14:28Z","git_url":"git://github.com/cbeust/testng.git","ssh_url":"git@github.com:cbeust/testng.git","clone_url":"https://github.com/cbeust/testng.git","svn_url":"https://github.com/cbeust/testng","homepage":"http://testng.org","size":29072,"stargazers_count":1149,"watchers_count":1149,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":710,"mirror_url":null,"archived":false,"open_issues_count":268,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":710,"open_issues":268,"watchers":1149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1963"},"html":{"href":"https://github.com/cbeust/testng/pull/1963"},"issue":{"href":"https://api.github.com/repos/cbeust/testng/issues/1963"},"comments":{"href":"https://api.github.com/repos/cbeust/testng/issues/1963/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1963/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1963/commits"},"statuses":{"href":"https://api.github.com/repos/cbeust/testng/statuses/31bfe25e62636b813e5ae328afc86597c00eed82"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"juherr"}}