{"action":"opened","number":563,"pull_request":{"url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563","id":176661044,"html_url":"https://github.com/CMSgov/bluebutton-web-server/pull/563","diff_url":"https://github.com/CMSgov/bluebutton-web-server/pull/563.diff","patch_url":"https://github.com/CMSgov/bluebutton-web-server/pull/563.patch","issue_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/563","number":563,"state":"open","locked":false,"title":"MyMedicare callback updates","user":{"login":"samgensburg-gov","id":25462603,"avatar_url":"https://avatars2.githubusercontent.com/u/25462603?v=4","gravatar_id":"","url":"https://api.github.com/users/samgensburg-gov","html_url":"https://github.com/samgensburg-gov","followers_url":"https://api.github.com/users/samgensburg-gov/followers","following_url":"https://api.github.com/users/samgensburg-gov/following{/other_user}","gists_url":"https://api.github.com/users/samgensburg-gov/gists{/gist_id}","starred_url":"https://api.github.com/users/samgensburg-gov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samgensburg-gov/subscriptions","organizations_url":"https://api.github.com/users/samgensburg-gov/orgs","repos_url":"https://api.github.com/users/samgensburg-gov/repos","events_url":"https://api.github.com/users/samgensburg-gov/events{/privacy}","received_events_url":"https://api.github.com/users/samgensburg-gov/received_events","type":"User","site_admin":false},"body":"There are a few different things here, so I'm going to go into the code and provide justification individually. There's a bunch of obvious code cleanup, but there's also a few other issues that are a little more complicated. I'll provide specific comments on the code itself","created_at":"2018-03-22T02:42:37Z","updated_at":"2018-03-22T02:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563/commits","review_comments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563/comments","review_comment_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/563/comments","statuses_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/statuses/4c19a9f95a6e52b427b2ae5e167c0f6bf838b5f8","head":{"label":"CMSgov:mymedicare_cb-updates","ref":"mymedicare_cb-updates","sha":"4c19a9f95a6e52b427b2ae5e167c0f6bf838b5f8","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":50062960,"name":"bluebutton-web-server","full_name":"CMSgov/bluebutton-web-server","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/bluebutton-web-server","description":"Blue Button API","fork":false,"url":"https://api.github.com/repos/CMSgov/bluebutton-web-server","forks_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/forks","keys_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/teams","hooks_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/events","assignees_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/tags","blobs_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/languages","stargazers_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/subscription","commits_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/merges","archive_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/downloads","issues_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/deployments","created_at":"2016-01-20T21:52:00Z","updated_at":"2018-03-21T17:47:17Z","pushed_at":"2018-03-22T02:25:13Z","git_url":"git://github.com/CMSgov/bluebutton-web-server.git","ssh_url":"git@github.com:CMSgov/bluebutton-web-server.git","clone_url":"https://github.com/CMSgov/bluebutton-web-server.git","svn_url":"https://github.com/CMSgov/bluebutton-web-server","homepage":"https://sandbox.bluebutton.cms.gov","size":11498,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":6,"watchers":10,"default_branch":"develop"}},"base":{"label":"CMSgov:develop","ref":"develop","sha":"7b6c0eb466472c7adbd993735aa047ccf1a7334e","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":50062960,"name":"bluebutton-web-server","full_name":"CMSgov/bluebutton-web-server","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/bluebutton-web-server","description":"Blue Button API","fork":false,"url":"https://api.github.com/repos/CMSgov/bluebutton-web-server","forks_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/forks","keys_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/teams","hooks_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/events","assignees_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/tags","blobs_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/languages","stargazers_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/subscription","commits_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/merges","archive_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/downloads","issues_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/bluebutton-web-server/deployments","created_at":"2016-01-20T21:52:00Z","updated_at":"2018-03-21T17:47:17Z","pushed_at":"2018-03-22T02:25:13Z","git_url":"git://github.com/CMSgov/bluebutton-web-server.git","ssh_url":"git@github.com:CMSgov/bluebutton-web-server.git","clone_url":"https://github.com/CMSgov/bluebutton-web-server.git","svn_url":"https://github.com/CMSgov/bluebutton-web-server","homepage":"https://sandbox.bluebutton.cms.gov","size":11498,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":6,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563"},"html":{"href":"https://github.com/CMSgov/bluebutton-web-server/pull/563"},"issue":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/563"},"comments":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/CMSgov/bluebutton-web-server/statuses/4c19a9f95a6e52b427b2ae5e167c0f6bf838b5f8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":75,"deletions":60,"changed_files":3}}
{"actor":{"display_login":"samgensburg-gov"}}