{"action":"created","issue":{"url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/5","repository_url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook","labels_url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/5/comments","events_url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/5/events","html_url":"https://github.com/rembik/dehydrated-hetzner-hook/issues/5","id":314075280,"node_id":"MDU6SXNzdWUzMTQwNzUyODA=","number":5,"title":"Possibly get rid of hard-coded DNS in the account file.","user":{"login":"fkroener","id":28690007,"node_id":"MDQ6VXNlcjI4NjkwMDA3","avatar_url":"https://avatars2.githubusercontent.com/u/28690007?v=4","gravatar_id":"","url":"https://api.github.com/users/fkroener","html_url":"https://github.com/fkroener","followers_url":"https://api.github.com/users/fkroener/followers","following_url":"https://api.github.com/users/fkroener/following{/other_user}","gists_url":"https://api.github.com/users/fkroener/gists{/gist_id}","starred_url":"https://api.github.com/users/fkroener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkroener/subscriptions","organizations_url":"https://api.github.com/users/fkroener/orgs","repos_url":"https://api.github.com/users/fkroener/repos","events_url":"https://api.github.com/users/fkroener/events{/privacy}","received_events_url":"https://api.github.com/users/fkroener/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-13T11:44:26Z","updated_at":"2018-09-25T23:41:58Z","closed_at":"2018-09-25T23:41:58Z","author_association":"NONE","body":"Hi,\r\n\r\nsince the recent addition of CNAME support the hard-coded DNS IPs are even more an issue than they were before, since hetzner's DNS servers will refuse to answer for domains they aren't authoritative for, which means CNAME'd domains will mostly fail, unless one was to manually replace the first IP in the account file with a different DNS provider.\r\n\r\nI wonder whether hard-coded DNS is actually necessary or improves anything upon doing the same thing Let's Encrypt does to check for propagation: resolve SOA/NS entries.\r\n\r\nSo, for checking CNAMEs one would best ask the locally configured DNS server and only for propagation checking the hetzner servers need to be queried, figuring out the IPs through DNS appears to be more flexible and future-proof than hard-coding.\r\n\r\nThanks again for your time and efforts."},"comment":{"url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/comments/424537152","html_url":"https://github.com/rembik/dehydrated-hetzner-hook/issues/5#issuecomment-424537152","issue_url":"https://api.github.com/repos/rembik/dehydrated-hetzner-hook/issues/5","id":424537152,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDUzNzE1Mg==","user":{"login":"rembik","id":22748318,"node_id":"MDQ6VXNlcjIyNzQ4MzE4","avatar_url":"https://avatars3.githubusercontent.com/u/22748318?v=4","gravatar_id":"","url":"https://api.github.com/users/rembik","html_url":"https://github.com/rembik","followers_url":"https://api.github.com/users/rembik/followers","following_url":"https://api.github.com/users/rembik/following{/other_user}","gists_url":"https://api.github.com/users/rembik/gists{/gist_id}","starred_url":"https://api.github.com/users/rembik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rembik/subscriptions","organizations_url":"https://api.github.com/users/rembik/orgs","repos_url":"https://api.github.com/users/rembik/repos","events_url":"https://api.github.com/users/rembik/events{/privacy}","received_events_url":"https://api.github.com/users/rembik/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T23:41:58Z","updated_at":"2018-09-25T23:41:58Z","author_association":"OWNER","body":"Would you please test the Pull request 'Dynamic dns with hotfix9' #13?"}}
{"actor":{"display_login":"rembik"}}