{"action":"opened","number":11488,"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488","id":225181589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTgxNTg5","html_url":"https://github.com/hrydgard/ppsspp/pull/11488","diff_url":"https://github.com/hrydgard/ppsspp/pull/11488.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/11488.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/11488","number":11488,"state":"open","locked":false,"title":"Windows: Option to show offset scale in memory view","user":{"login":"dl471","id":32369415,"node_id":"MDQ6VXNlcjMyMzY5NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/32369415?v=4","gravatar_id":"","url":"https://api.github.com/users/dl471","html_url":"https://github.com/dl471","followers_url":"https://api.github.com/users/dl471/followers","following_url":"https://api.github.com/users/dl471/following{/other_user}","gists_url":"https://api.github.com/users/dl471/gists{/gist_id}","starred_url":"https://api.github.com/users/dl471/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dl471/subscriptions","organizations_url":"https://api.github.com/users/dl471/orgs","repos_url":"https://api.github.com/users/dl471/repos","events_url":"https://api.github.com/users/dl471/events{/privacy}","received_events_url":"https://api.github.com/users/dl471/received_events","type":"User","site_admin":false},"body":"I've been messing around in the memory view a lot recently so I ended up trying to make a few things to make things a bit more in line with what I'm personally used to where I couldn't find any equivalents. One of the modifications was adding the option to have offsets be drawn at the top of the hex view. This is what it looks like.\r\n\r\n![withoffsets_cropped](https://user-images.githubusercontent.com/32369415/47387408-2dec3d80-d707-11e8-9d24-ecc7895160f2.jpg)\r\n\r\nI made space for it by changing what lines are drawn on the fly since it seemed the most straightforward compared to messing around with multiple DC/bitmaps. I also added a checkbox to toggle it on and off to the memory view window, though said option does not affect the memory view embedded in the diassembler window. It seemed like it might have been too cramped to have it in the disassembler and having it be controlled by a checkbox in a different window seemed like it would be a bit strange.  (That said, the screenshot provided includes it turned on in both as a reference). I tried following along with the existing code style, though I'm not sure if I got it entirely right.\r\n\r\nFinally, the memory view doesn't seem to have changed in a while. Would there be interest in merging things relating to it at all?","created_at":"2018-10-23T20:47:05Z","updated_at":"2018-10-23T20:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/11488/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/7f3aaaa0f7a41e4bc66f7037a04f58466adf917a","head":{"label":"dl471:memview-show-offsets","ref":"memview-show-offsets","sha":"7f3aaaa0f7a41e4bc66f7037a04f58466adf917a","user":{"login":"dl471","id":32369415,"node_id":"MDQ6VXNlcjMyMzY5NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/32369415?v=4","gravatar_id":"","url":"https://api.github.com/users/dl471","html_url":"https://github.com/dl471","followers_url":"https://api.github.com/users/dl471/followers","following_url":"https://api.github.com/users/dl471/following{/other_user}","gists_url":"https://api.github.com/users/dl471/gists{/gist_id}","starred_url":"https://api.github.com/users/dl471/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dl471/subscriptions","organizations_url":"https://api.github.com/users/dl471/orgs","repos_url":"https://api.github.com/users/dl471/repos","events_url":"https://api.github.com/users/dl471/events{/privacy}","received_events_url":"https://api.github.com/users/dl471/received_events","type":"User","site_admin":false},"repo":{"id":153622432,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MjI0MzI=","name":"ppsspp","full_name":"dl471/ppsspp","private":false,"owner":{"login":"dl471","id":32369415,"node_id":"MDQ6VXNlcjMyMzY5NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/32369415?v=4","gravatar_id":"","url":"https://api.github.com/users/dl471","html_url":"https://github.com/dl471","followers_url":"https://api.github.com/users/dl471/followers","following_url":"https://api.github.com/users/dl471/following{/other_user}","gists_url":"https://api.github.com/users/dl471/gists{/gist_id}","starred_url":"https://api.github.com/users/dl471/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dl471/subscriptions","organizations_url":"https://api.github.com/users/dl471/orgs","repos_url":"https://api.github.com/users/dl471/repos","events_url":"https://api.github.com/users/dl471/events{/privacy}","received_events_url":"https://api.github.com/users/dl471/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dl471/ppsspp","description":"A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or in #ppsspp on freenode (IRC) or just send pull requests / issues. For discussion use the forums on ppsspp.org.","fork":true,"url":"https://api.github.com/repos/dl471/ppsspp","forks_url":"https://api.github.com/repos/dl471/ppsspp/forks","keys_url":"https://api.github.com/repos/dl471/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dl471/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dl471/ppsspp/teams","hooks_url":"https://api.github.com/repos/dl471/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/dl471/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/dl471/ppsspp/events","assignees_url":"https://api.github.com/repos/dl471/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/dl471/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/dl471/ppsspp/tags","blobs_url":"https://api.github.com/repos/dl471/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dl471/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dl471/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dl471/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dl471/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/dl471/ppsspp/languages","stargazers_url":"https://api.github.com/repos/dl471/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/dl471/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/dl471/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/dl471/ppsspp/subscription","commits_url":"https://api.github.com/repos/dl471/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dl471/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dl471/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dl471/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dl471/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/dl471/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dl471/ppsspp/merges","archive_url":"https://api.github.com/repos/dl471/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dl471/ppsspp/downloads","issues_url":"https://api.github.com/repos/dl471/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/dl471/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/dl471/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/dl471/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dl471/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/dl471/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/dl471/ppsspp/deployments","created_at":"2018-10-18T12:45:51Z","updated_at":"2018-10-18T12:45:59Z","pushed_at":"2018-10-22T14:56:51Z","git_url":"git://github.com/dl471/ppsspp.git","ssh_url":"git@github.com:dl471/ppsspp.git","clone_url":"https://github.com/dl471/ppsspp.git","svn_url":"https://github.com/dl471/ppsspp","homepage":"https://www.ppsspp.org","size":105570,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"8883156e457cf072e12814a1403056fdf8ced0bf","user":{"login":"hrydgard","id":130929,"node_id":"MDQ6VXNlcjEzMDkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/130929?v=4","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg2ODI2","name":"ppsspp","full_name":"hrydgard/ppsspp","private":false,"owner":{"login":"hrydgard","id":130929,"node_id":"MDQ6VXNlcjEzMDkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/130929?v=4","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or in #ppsspp on freenode (IRC) or just send pull requests / issues. For discussion use the forums on ppsspp.org.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/hrydgard/ppsspp/deployments","created_at":"2012-11-01T08:41:48Z","updated_at":"2018-10-23T16:19:52Z","pushed_at":"2018-10-23T19:26:53Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"https://www.ppsspp.org","size":105566,"stargazers_count":3922,"watchers_count":3922,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1210,"mirror_url":null,"archived":false,"open_issues_count":900,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1210,"open_issues":900,"watchers":3922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/11488"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/11488"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/11488/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/11488/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/7f3aaaa0f7a41e4bc66f7037a04f58466adf917a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":85,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"dl471"}}